alxarafe / alixar

public/htdocs/ticket/card.php

Spacing +5 added lines, -5 removed lines

@@ -322,7 +322,7 @@ 
 
                 if (!$error) {
                     // File transfer
-                    $object->copyFilesForTicket('');        // trackid is forced to '' because files were uploaded when no id for ticket exists yet and trackid was ''
+                    $object->copyFilesForTicket(''); // trackid is forced to '' because files were uploaded when no id for ticket exists yet and trackid was ''
                 }
             }
             if (!$error) {
@@ -704,7 +704,7 @@ 
 
     print load_fiche_titre($langs->trans('NewTicket'), '', 'ticket');
 
-    $formticket->trackid = '';      // TODO Use a unique key 'tic' to avoid conflict in upload file feature
+    $formticket->trackid = ''; // TODO Use a unique key 'tic' to avoid conflict in upload file feature
     $formticket->withfromsocid = $socid ? $socid : $user->socid;
     $formticket->withfromcontactid = $contactid ? $contactid : '';
     $formticket->withtitletopic = 1;
@@ -732,7 +732,7 @@ 
 
     print dol_get_fiche_head($head, 'tabTicket', $langs->trans('Ticket'), -1, 'ticket');
 
-    $formticket->trackid = $object->track_id;        // TODO Use a unique key 'tic' to avoid conflict in upload file feature
+    $formticket->trackid = $object->track_id; // TODO Use a unique key 'tic' to avoid conflict in upload file feature
     $formticket->withfromsocid = $object->socid;
     $formticket->withtitletopic = 1;
     //  $formticket->withnotifytiersatcreate = ($notifyTiers ? 1 : (getDolGlobalString('TICKET_CHECK_NOTIFY_THIRDPARTY_AT_CREATION') ? 1 : 0));
@@ -971,8 +971,8 @@ 
                         $morehtmlref .= $formcontract->formSelectContract($_SERVER["PHP_SELF"] . '?id=' . $object->id, $object->socid, $object->fk_contract, 'contratid', 0, 1, 1, 1);
                     } else {
                         $morehtmlref .= '<a class="editfielda" href="' . $_SERVER["PHP_SELF"] . '?action=edit_contrat&token=' . newToken() . '&id=' . $object->id . '">';
-                        $morehtmlref .=  img_edit($langs->trans('SetContract'));
-                        $morehtmlref .=  '</a>';
+                        $morehtmlref .= img_edit($langs->trans('SetContract'));
+                        $morehtmlref .= '</a>';
                     }
                 } else {
                     if (!empty($object->fk_contract)) {

Braces +6 added lines, -2 removed lines

@@ -192,7 +192,9 @@ 
 
     if (($action == 'add' || ($action == 'update' && $object->status < Ticket::STATUS_CLOSED)) && $permissiontoadd) {
         $ifErrorAction = $action == 'add' ? 'create' : 'edit';
-        if ($action == 'add') $object->track_id = null;
+        if ($action == 'add') {
+            $object->track_id = null;
+        }
         $error = 0;
 
         $fieldsToCheck = [
@@ -344,7 +346,9 @@ 
                 $db->rollback();
                 setEventMessages($object->error, $object->errors, 'errors');
             }
-        } else $action = $ifErrorAction;
+        } else {
+            $action = $ifErrorAction;
+        }
     }
 
     // Mark as Read

public/htdocs/ticket/list.php

Spacing +5 added lines, -5 removed lines

@@ -987,7 +987,7 @@ 
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
     }
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
     if (!empty($arrayfields['t.' . $key]['checked'])) {
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
         $totalarray['nbfield']++;
@@ -1156,11 +1156,11 @@ 
                     $should_show_warning = (getDolGlobalString('TICKET_DELAY_SINCE_LAST_RESPONSE') || getDolGlobalString('TICKET_DELAY_BEFORE_FIRST_RESPONSE'));
                     if ($is_open && $should_show_warning) {
                         $date_last_msg_sent = (int) $object->date_last_msg_sent;
-                        $hour_diff = ($now - $date_last_msg_sent) / 3600 ;
+                        $hour_diff = ($now - $date_last_msg_sent) / 3600;
 
                         if (getDolGlobalString('TICKET_DELAY_BEFORE_FIRST_RESPONSE') && $date_last_msg_sent == 0) {
-                            $creation_date =  $object->datec;
-                            $hour_diff_creation = ($now - $creation_date) / 3600 ;
+                            $creation_date = $object->datec;
+                            $hour_diff_creation = ($now - $creation_date) / 3600;
                             if ($hour_diff_creation > getDolGlobalInt('TICKET_DELAY_BEFORE_FIRST_RESPONSE')) {
                                 print " " . img_picto($langs->trans('Late') . ' : ' . $langs->trans('TicketsDelayForFirstResponseTooLong', getDolGlobalString('TICKET_DELAY_BEFORE_FIRST_RESPONSE')), 'warning', 'style="color: red;"', false, 0, 0, '', '');
                             }
@@ -1256,7 +1256,7 @@ 
 
 print '</table>' . "\n";
 print '</div>' . "\n";
-print '</div>' . "\n";    // end div-responsive-inside
+print '</div>' . "\n"; // end div-responsive-inside
 
 print '</form>' . "\n";
 

public/htdocs/ticket/document.php

Spacing +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
     accessforbidden();
 }
 
-$permissiontoadd = $user->hasRight('ticket', 'write');  // Used by the include of actions_addupdatedelete.inc.php and actions_linkedfiles
+$permissiontoadd = $user->hasRight('ticket', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_linkedfiles
 
 
 /*

public/htdocs/expensereport/ajax/ajaxik.php

Spacing +4 added lines, -4 removed lines

@@ -69,21 +69,21 @@
 
 
 if (empty($fk_expense) || $fk_expense < 0) {
-    $rep->errorMessage =   $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_expense, 'fk_expense');
+    $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_expense, 'fk_expense');
 } elseif (empty($fk_c_exp_tax_cat) || $fk_c_exp_tax_cat < 0) {
-    $rep->errorMessage =  $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_c_exp_tax_cat, 'fk_c_exp_tax_cat');
+    $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_c_exp_tax_cat, 'fk_c_exp_tax_cat');
 
     $rep->response_status = 'error';
 } else {
     // @see ndfp.class.php:3576 (method: compute_total_km)
     $expense = new ExpenseReport($db);
     if ($expense->fetch($fk_expense) <= 0) {
-        $rep->errorMessage =  $langs->transnoentitiesnoconv('ErrorRecordNotFound');
+        $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorRecordNotFound');
         $rep->response_status = 'error';
     } else {
         $userauthor = new User($db);
         if ($userauthor->fetch($expense->fk_user_author) <= 0) {
-            $rep->errorMessage =  $langs->transnoentitiesnoconv('ErrorRecordNotFound');
+            $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorRecordNotFound');
             $rep->response_status = 'error';
         } else {
             $expense = new ExpenseReport($db);

public/htdocs/expensereport/card.php

Spacing +2 added lines, -2 removed lines

@@ -153,7 +153,7 @@ 
 }
 $result = restrictedArea($user, 'expensereport', $object->id, 'expensereport');
 
-$permissiontoadd = $user->hasRight('expensereport', 'creer');   // Used by the include of actions_dellink.inc.php
+$permissiontoadd = $user->hasRight('expensereport', 'creer'); // Used by the include of actions_dellink.inc.php
 
 
 /*
@@ -2384,7 +2384,7 @@ 
 
                         // Quantity
                         print '<td class="right">';
-                        print '<input type="text" min="0" class="input_qty right maxwidth50"  name="qty" value="' . dol_escape_htmltag($line->qty) . '" />';  // We must be able to enter decimal qty
+                        print '<input type="text" min="0" class="input_qty right maxwidth50"  name="qty" value="' . dol_escape_htmltag($line->qty) . '" />'; // We must be able to enter decimal qty
                         print '</td>';
 
                         //print '<td class="right">'.$langs->trans('AmountHT').'</td>';

public/htdocs/expensereport/payment/list.php

Spacing +3 added lines, -3 removed lines

@@ -67,7 +67,7 @@ 
 $search_date_endday     = GETPOSTINT('search_date_endday');
 $search_date_endmonth   = GETPOSTINT('search_date_endmonth');
 $search_date_endyear    = GETPOSTINT('search_date_endyear');
-$search_date_start      = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);  // Use tzserver
+$search_date_start      = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
 $search_date_end        = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
 $search_user            = GETPOST('search_user', 'alpha');
 $search_payment_type    = GETPOST('search_payment_type');
@@ -114,7 +114,7 @@ 
     'pndf.amount'           => array('label' => "Amount", 'checked' => 1, 'position' => 70),
 );
 $arrayfields = dol_sort_array($arrayfields, 'position');
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
 
 // Initialize technical object to manage hooks of page. Note that conf->hooks_modules contains array of hook context
 $hookmanager->initHooks(array('paymentexpensereportlist'));
@@ -420,7 +420,7 @@ 
 }
 
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
 

public/htdocs/expensereport/list.php

Spacing +4 added lines, -4 removed lines

@@ -117,7 +117,7 @@ 
 $search_date_startendday    = GETPOSTINT('search_date_startendday');
 $search_date_startendmonth  = GETPOSTINT('search_date_startendmonth');
 $search_date_startendyear   = GETPOSTINT('search_date_startendyear');
-$search_date_start          = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);  // Use tzserver
+$search_date_start          = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
 $search_date_startend       = dol_mktime(23, 59, 59, $search_date_startendmonth, $search_date_startendday, $search_date_startendyear);
 
 $search_date_endday         = GETPOSTINT('search_date_endday');
@@ -126,10 +126,10 @@ 
 $search_date_endendday      = GETPOSTINT('search_date_endendday');
 $search_date_endendmonth    = GETPOSTINT('search_date_endendmonth');
 $search_date_endendyear     = GETPOSTINT('search_date_endendyear');
-$search_date_end            = dol_mktime(0, 0, 0, $search_date_endmonth, $search_date_endday, $search_date_endyear);    // Use tzserver
+$search_date_end            = dol_mktime(0, 0, 0, $search_date_endmonth, $search_date_endday, $search_date_endyear); // Use tzserver
 $search_date_endend         = dol_mktime(23, 59, 59, $search_date_endendmonth, $search_date_endendday, $search_date_endendyear);
 
-$optioncss    = GETPOST('optioncss', 'alpha');
+$optioncss = GETPOST('optioncss', 'alpha');
 
 if ($search_status == '') {
     $search_status = -1;
@@ -588,7 +588,7 @@ 
 }
 
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
 

public/htdocs/expensereport/document.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
     }
 }
 
-$permissiontoadd = $user->hasRight('expensereport', 'creer');   // Used by the include of actions_dellink.inc.php
+$permissiontoadd = $user->hasRight('expensereport', 'creer'); // Used by the include of actions_dellink.inc.php
 
 
 /*

public/htdocs/expensereport/index.php

Spacing +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
 $dataseries = dol_sort_array($dataseries, 1, 'desc');
 
 // Merge all entries after the $KEEPNFIRST one into one entry called "Other..." (to avoid to have too much entries in graphic).
-$KEEPNFIRST = 7;    // Keep first $KEEPNFIRST one + 1 with the remain
+$KEEPNFIRST = 7; // Keep first $KEEPNFIRST one + 1 with the remain
 $i = 0;
 if (count($dataseries) > ($KEEPNFIRST + 1)) {
     foreach ($dataseries as $key => $val) {