alxarafe / alixar

public/htdocs/fourn/facture/list-rec.php

Spacing +4 added lines, -4 removed lines

@@ -84,7 +84,7 @@ 
 $search_date_endday = GETPOSTINT('search_date_endday');
 $search_date_endmonth = GETPOSTINT('search_date_endmonth');
 $search_date_endyear = GETPOSTINT('search_date_endyear');
-$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);   // Use tzserver
+$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
 $search_date_end = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
 $search_date_when_startday = GETPOSTINT('search_date_when_startday');
 $search_date_when_startmonth = GETPOSTINT('search_date_when_startmonth');
@@ -92,7 +92,7 @@ 
 $search_date_when_endday = GETPOSTINT('search_date_when_endday');
 $search_date_when_endmonth = GETPOSTINT('search_date_when_endmonth');
 $search_date_when_endyear = GETPOSTINT('search_date_when_endyear');
-$search_date_when_start = dol_mktime(0, 0, 0, $search_date_when_startmonth, $search_date_when_startday, $search_date_when_startyear);   // Use tzserver
+$search_date_when_start = dol_mktime(0, 0, 0, $search_date_when_startmonth, $search_date_when_startday, $search_date_when_startyear); // Use tzserver
 $search_date_when_end = dol_mktime(23, 59, 59, $search_date_when_endmonth, $search_date_when_endday, $search_date_when_endyear);
 $search_recurring = GETPOST('search_recurring', 'intcomma');
 $search_frequency = GETPOST('search_frequency', 'alpha');
@@ -163,7 +163,7 @@ 
 
 $object->fields = dol_sort_array($object->fields, 'position');
 $arrayfields = dol_sort_array($arrayfields, 'position');
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
 
 if ($socid > 0) {
     $tmpthirdparty = new Societe($db);
@@ -538,7 +538,7 @@ 
 $massactionbutton = $form->selectMassAction('', $massaction == 'presend' ? array() : array('presend' => $langs->trans("SendByMail"), 'builddoc' => $langs->trans("PDFMerge")));
 
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
 //$selectedfields.=$form->showCheckAddButtons('checkforselect', 1);
 

public/htdocs/fourn/facture/paiement.php

Spacing +4 added lines, -4 removed lines

@@ -312,14 +312,14 @@ 
 
             // Creation of payment line
             $paiement = new PaiementFourn($db);
-            $paiement->datepaye     = $datepaye;
+            $paiement->datepaye = $datepaye;
 
             $correctedAmounts = [];
             foreach ($amounts as $key => $value) {
                 $correctedAmounts[$key] = (float) $value;
             }
 
-            $paiement->amounts      = $correctedAmounts; // Array of amounts
+            $paiement->amounts = $correctedAmounts; // Array of amounts
             $paiement->multicurrency_amounts = $multicurrency_amounts;
             $paiement->multicurrency_code = $multicurrency_code; // Array with all currency of payments dispatching
             $paiement->multicurrency_tx = $multicurrency_tx; // Array with all currency tx of payments dispatching
@@ -610,8 +610,8 @@ 
                         $total = 0;
                         $total_ttc = 0;
                         $totalrecu = 0;
-                        $totalrecucreditnote = 0;   // PHP Warning:  Undefined variable $totalrecucreditnote
-                        $totalrecudeposits = 0;     // PHP Warning:  Undefined variable $totalrecudeposits
+                        $totalrecucreditnote = 0; // PHP Warning:  Undefined variable $totalrecucreditnote
+                        $totalrecudeposits = 0; // PHP Warning:  Undefined variable $totalrecudeposits
                         while ($i < $num) {
                             $objp = $db->fetch_object($resql);
 

public/htdocs/fourn/facture/list.php

Spacing +4 added lines, -4 removed lines

@@ -86,7 +86,7 @@ 
 $search_multicurrency_montant_ht = GETPOST('search_multicurrency_montant_ht', 'alpha');
 $search_multicurrency_montant_vat = GETPOST('search_multicurrency_montant_vat', 'alpha');
 $search_multicurrency_montant_ttc = GETPOST('search_multicurrency_montant_ttc', 'alpha');
-$search_status = GETPOST('search_status', 'intcomma');  // Can be '' or a numeric
+$search_status = GETPOST('search_status', 'intcomma'); // Can be '' or a numeric
 $search_paymentmode = GETPOST('search_paymentmode', 'intcomma');
 $search_paymentcond = GETPOST('search_paymentcond', 'intcomma');
 $search_town = GETPOST('search_town', 'alpha');
@@ -218,7 +218,7 @@ 
 
 $object->fields = dol_sort_array($object->fields, 'position');
 $arrayfields = dol_sort_array($arrayfields, 'position');
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
 
 if (!isModEnabled('supplier_invoice')) {
     accessforbidden();
@@ -1075,7 +1075,7 @@ 
 }
 
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
 
@@ -1929,7 +1929,7 @@ 
                 $totalarray['pos'][$totalarray['nbfield']] = 'totalam';
             }
             if (empty($totalarray['val']['totalam'])) {
-                $totalarray['val']['totalam'] = 0;      // avoid PHP Warning:  Undefined array key "totalam" on line 1891
+                $totalarray['val']['totalam'] = 0; // avoid PHP Warning:  Undefined array key "totalam" on line 1891
             }
             $totalarray['val']['totalam'] += $totalpay;
         }

public/htdocs/fourn/facture/card-rec.php

Spacing +20 added lines, -20 removed lines

@@ -87,10 +87,10 @@ 
     $page = 0;
 }     // If $page is not defined, or '' or -1
 $offset = $limit * $page;
-if (! $sortorder) {
+if (!$sortorder) {
     $sortorder = 'DESC';
 }
-if (! $sortfield) {
+if (!$sortfield) {
     $sortfield = 'f.titre';
 }
 $pageprev = $page - 1;
@@ -99,7 +99,7 @@ 
 $object = new FactureFournisseurRec($db);
 if (($id > 0 || $title) && $action != 'create' && $action != 'add') {
     $ret = $object->fetch($id, $title);
-    if (! $ret) {
+    if (!$ret) {
         setEventMessages($langs->trans("ErrorRecordNotFound"), null, 'errors');
     }
 }
@@ -143,7 +143,7 @@ 
     $action = 'list';
     $massaction = '';
 }
-if (! GETPOST('confirmmassaction', 'alpha') && $massaction != 'presend' && $massaction != 'confirm_presend') {
+if (!GETPOST('confirmmassaction', 'alpha') && $massaction != 'presend' && $massaction != 'confirm_presend') {
     $massaction = '';
 }
 
@@ -170,7 +170,7 @@ 
 
     // Create predefined invoice
     if ($action == 'add') {
-        if (! GETPOST('title', 'alphanohtml')) {
+        if (!GETPOST('title', 'alphanohtml')) {
             setEventMessages($langs->transnoentities("ErrorFieldRequired", $langs->trans("Title")), null, 'errors');
             $action = "create";
             $error++;
@@ -193,10 +193,10 @@ 
             }
         }
 
-        if (! $error) {
+        if (!$error) {
             $object->subtype               = GETPOSTINT('subtype');
             $object->title                 = GETPOST('title', 'alphanohtml');
-            $object->libelle               = GETPOST('libelle', 'alpha');   // deprecated
+            $object->libelle               = GETPOST('libelle', 'alpha'); // deprecated
             $object->label                 = GETPOST('libelle', 'alpha');
             $object->fk_project            = GETPOSTINT('projectid');
             $object->ref_supplier          = GETPOST('ref_supplier', 'alphanohtml');
@@ -242,7 +242,7 @@ 
                 $action = "create";
             }
 
-            if (! $error) {
+            if (!$error) {
                 $db->commit();
 
                 header("Location: " . $_SERVER['PHP_SELF'] . '?facid=' . $object->id);
@@ -292,7 +292,7 @@ 
         $result = $object->setValueFrom('titre', $title, '', null, 'text', '', $user);
 
         if ($result > 0) {
-            $object->titre = $title;    // deprecated
+            $object->titre = $title; // deprecated
             $object->title = $title;
             $object->ref = $object->title;
         } else {
@@ -339,7 +339,7 @@ 
             $error++;
         }
 
-        if (! $error) {
+        if (!$error) {
             $db->commit();
         } else {
             $db->rollback();
@@ -356,7 +356,7 @@ 
             $error++;
         }
 
-        if (! $error) {
+        if (!$error) {
             $db->commit();
         } else {
             $db->rollback();
@@ -415,7 +415,7 @@ 
             $error++;
         }
 
-        if (! $error) {
+        if (!$error) {
             $result = $object->insertExtraFields('BILLREC_MODIFY');
             if ($result < 0) {
                 setEventMessages($object->error, $object->errors, 'errors');
@@ -466,7 +466,7 @@ 
             setEventMessages($langs->trans('ErrorFieldRequired', $langs->transnoentitiesnoconv('Type')), null, 'errors');
             $error++;
         }
-        if ($prod_entry_mode == 'free' && (empty($idprod) || $idprod < 0) && (! ($price_ht >= 0) || $price_ht == '')) {    // Unit price can be 0 but not ''
+        if ($prod_entry_mode == 'free' && (empty($idprod) || $idprod < 0) && (!($price_ht >= 0) || $price_ht == '')) {    // Unit price can be 0 but not ''
             setEventMessages($langs->trans("ErrorFieldRequired", $langs->transnoentitiesnoconv("UnitPriceHT")), null, 'errors');
             $error++;
         }
@@ -515,7 +515,7 @@ 
             }
         }
 
-        if (! $error && ($qty >= 0) && (!empty($product_desc) || (!empty($idprod) && $idprod > 0))) {
+        if (!$error && ($qty >= 0) && (!empty($product_desc) || (!empty($idprod) && $idprod > 0))) {
             $ret = $object->fetch($id);
             if ($ret < 0) {
                 dol_print_error($db, $object->error);
@@ -731,8 +731,8 @@ 
                 $action = '';
             }
         }
-    } elseif ($action == 'updateline' && $usercancreate && ! GETPOST('cancel', 'alpha')) {
-        if (! $object->fetch($id) > 0) {
+    } elseif ($action == 'updateline' && $usercancreate && !GETPOST('cancel', 'alpha')) {
+        if (!$object->fetch($id) > 0) {
             dol_print_error($db);
         }
         $object->fetch_thirdparty();
@@ -783,7 +783,7 @@ 
 
         // Define special_code for special lines
         $special_code = GETPOSTINT('special_code');
-        if (! GETPOST('qty', 'alpha')) {
+        if (!GETPOST('qty', 'alpha')) {
             $special_code = 3;
         }
 
@@ -829,7 +829,7 @@ 
         $date_end_fill = !empty(GETPOSTINT('date_end_fill')) ? GETPOSTINT('date_end_fill') : 'NULL';
 
         // Update line
-        if (! $error) {
+        if (!$error) {
             $result = $object->updateline(GETPOSTINT('lineid'), GETPOSTINT('productid'), $ref_fourn, $label, $description, $pu_ht, $qty, $remise_percent, $vat_rate, $localtax1_rate, $localtax1_rate, 'HT', $type, $date_start_fill, $date_end_fill, $info_bits, $special_code, -1);
             if ($result >= 0) {
                 $object->fetch($object->id); // Reload lines
@@ -1488,8 +1488,8 @@ 
             print $form->editfieldval($langs->trans("NextDateToExecution"), 'date_when', $object->date_when, $object, $usercancreate, 'day', $object->date_when, null, '', '', 0, 'strikeIfMaxNbGenReached');
         }
         //var_dump(dol_print_date($object->date_when+60, 'dayhour').' - '.dol_print_date($now, 'dayhour'));
-        if (! $object->isMaxNbGenReached()) {
-            if (! $object->suspended && $action != 'editdate_when' && $object->frequency > 0 && $object->date_when && $object->date_when < $now) {
+        if (!$object->isMaxNbGenReached()) {
+            if (!$object->suspended && $action != 'editdate_when' && $object->frequency > 0 && $object->date_when && $object->date_when < $now) {
                 print img_warning($langs->trans("Late"));
             }
         } else {

public/htdocs/fourn/paiement/card.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 // Load object
 include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once.
 
-$result = restrictedArea($user, $object->element, $object->id, 'paiementfourn', '');    // This also test permission on read invoice
+$result = restrictedArea($user, $object->element, $object->id, 'paiementfourn', ''); // This also test permission on read invoice
 
 // Security check
 if ($user->socid) {

public/htdocs/fourn/paiement/list.php

Spacing +3 added lines, -3 removed lines

@@ -62,7 +62,7 @@ 
 $search_date_endday     = GETPOSTINT('search_date_endday');
 $search_date_endmonth   = GETPOSTINT('search_date_endmonth');
 $search_date_endyear    = GETPOSTINT('search_date_endyear');
-$search_date_start      = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);  // Use tzserver
+$search_date_start      = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
 $search_date_end        = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
 $search_company         = GETPOST('search_company', 'alpha');
 $search_payment_type    = GETPOST('search_payment_type', 'alpha');
@@ -110,7 +110,7 @@ 
     'p.amount'          => array('label' => "Amount", 'checked' => 1, 'position' => 70),
 );
 $arrayfields = dol_sort_array($arrayfields, 'position');
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
 
 // Initialize technical object to manage hooks of page. Note that conf->hooks_modules contains array of hook context
 $hookmanager->initHooks(array('paymentsupplierlist'));
@@ -207,7 +207,7 @@ 
 $sql .= ' LEFT JOIN ' . MAIN_DB_PREFIX . 'facture_fourn AS f ON f.rowid = pf.fk_facturefourn';
 $sql .= ' LEFT JOIN ' . MAIN_DB_PREFIX . 'societe AS s ON s.rowid = f.fk_soc';
 
-$sql .= ' WHERE f.entity IN (' . getEntity('supplier_invoice') . ')';       // TODO We should use p.entity that does not exists yet in this table
+$sql .= ' WHERE f.entity IN (' . getEntity('supplier_invoice') . ')'; // TODO We should use p.entity that does not exists yet in this table
 if ($socid > 0) {
     $sql .= " AND EXISTS (SELECT f.fk_soc FROM " . MAIN_DB_PREFIX . "facture_fourn as f, " . MAIN_DB_PREFIX . "paiementfourn_facturefourn as pf";
     $sql .= " WHERE p.rowid = pf.fk_paiementfourn AND pf.fk_facturefourn = f.rowid AND f.fk_soc = " . ((int) $socid) . ")";

public/htdocs/fourn/class/fournisseur.facture-rec.class.php

Indentation +4 added lines, -4 removed lines

@@ -699,7 +699,7 @@ 
         return $this->fetch_lines();
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Get lines of template invoices into this->lines
      *
@@ -707,7 +707,7 @@ 
      */
     public function fetch_lines()
     {
-		// phpcs:enable
+        // phpcs:enable
         $this->lines = array();
 
         // Retrieve all extrafield for line
@@ -1512,7 +1512,7 @@ 
         return $this->LibStatut($this->frequency ? 1 : 0, $this->suspended, $mode, $alreadypaid, empty($this->type) ? 0 : $this->type);
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return label of a status
      *
@@ -1525,7 +1525,7 @@ 
      */
     public function LibStatut($recur, $status, $mode = 0, $alreadypaid = -1, $type = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $langs;
         $langs->load('bills');
 

Spacing +13 added lines, -13 removed lines

@@ -351,13 +351,13 @@ 
             $sql .= ", '" . $this->db->idate($now) . "'";
             $sql .= ", " . ((int) $this->suspended);
             $sql .= ", '" . $this->db->escape($this->libelle) . "'";
-            $sql .= ", " . (!empty($facfourn_src->total_ttc) ? (float) $facfourn_src->total_ttc : '0');                              // amount
+            $sql .= ", " . (!empty($facfourn_src->total_ttc) ? (float) $facfourn_src->total_ttc : '0'); // amount
             $sql .= ", " . ((int) $user->id);
             $sql .= ", " . (!empty($this->fk_project) ? ((int) $this->fk_project) : 'NULL');
             $sql .= ", " . (!empty($facfourn_src->fk_account) ? ((int) $facfourn_src->fk_account) : 'NULL');
             $sql .= ", " . ($this->cond_reglement_id > 0 ? (int) $this->cond_reglement_id : 'NULL');
             $sql .= ", " . ($this->mode_reglement_id > 0 ? (int) $this->mode_reglement_id : 'NULL');
-            $sql .= ", " . ($facfourn_src->date_echeance > 0 ? "'" . $this->db->idate($facfourn_src->date_echeance) . "'" : 'NULL');      // date_lim_reglement
+            $sql .= ", " . ($facfourn_src->date_echeance > 0 ? "'" . $this->db->idate($facfourn_src->date_echeance) . "'" : 'NULL'); // date_lim_reglement
             $sql .= ", " . (!empty($this->note_private) ? "'" . $this->db->escape($this->note_private) . "'" : 'NULL');
             $sql .= ", " . (!empty($this->note_public) ? "'" . $this->db->escape($this->note_public) . "'" : 'NULL');
             $sql .= ", " . (!empty($this->model_pdf) ? "'" . $this->db->escape($this->model_pdf) . "'" : 'NULL');
@@ -512,7 +512,7 @@ 
         $error = 0;
 
         $sql = "UPDATE " . MAIN_DB_PREFIX . "facture_fourn_rec SET";
-        $sql .= " titre = '" . (!empty($this->title) ? $this->db->escape($this->title) : "") . "'," ;
+        $sql .= " titre = '" . (!empty($this->title) ? $this->db->escape($this->title) : "") . "',";
         $sql .= " subtype=" . (isset($this->subtype) ? $this->db->escape($this->subtype) : "null") . ",";
         $sql .= " ref_supplier = '" . (!empty($this->ref_supplier) ? $this->db->escape($this->ref_supplier) : "") . "',";
         $sql .= " entity = " . (!empty($this->entity) ? ((int) $this->entity) : 1) . ',';
@@ -630,7 +630,7 @@ 
                 $this->id                       = $obj->rowid;
                 $this->titre                    = $obj->title;
                 $this->title                    = $obj->title;
-                $this->subtype                        = $obj->subtype;
+                $this->subtype = $obj->subtype;
                 $this->ref                      = $obj->title;
                 $this->ref_supplier             = $obj->ref_supplier;
                 $this->entity                   = $obj->entity;
@@ -788,7 +788,7 @@ 
                 $line->product_type             = $objp->product_type;
                 $line->date_start               = $objp->date_start;
                 $line->date_end                 = $objp->date_end;
-                $line->info_bits                = $objp->info_bits  ;
+                $line->info_bits                = $objp->info_bits;
                 $line->special_code             = $objp->special_code;
                 $line->rang                     = $objp->rang;
                 $line->fk_unit                  = $objp->fk_unit;
@@ -871,7 +871,7 @@ 
             }
             // End call triggers
         }
-        if (! $error) {
+        if (!$error) {
             $this->db->commit();
             return 1;
         } else {
@@ -1015,7 +1015,7 @@ 
             $sql .= ', fk_user_author';
             $sql .= ', fk_multicurrency, multicurrency_code, multicurrency_subprice, multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';
             $sql .= ') VALUES (';
-            $sql .= ' ' . (int) $facid;   // source supplier invoice id
+            $sql .= ' ' . (int) $facid; // source supplier invoice id
             $sql .= ', ' . (!empty($fk_product) ? "'" . $this->db->escape($fk_product) . "'" : 'null');
             $sql .= ', ' . (!empty($ref) ? "'" . $this->db->escape($ref) . "'" : 'null');
             $sql .= ', ' . (!empty($label) ? "'" . $this->db->escape($label) . "'" : 'null');
@@ -1356,7 +1356,7 @@ 
 
                     $new_fac_fourn->type = self::TYPE_STANDARD;
                     $new_fac_fourn->subtype = $facturerec->subtype;
-                    $new_fac_fourn->statut = self::STATUS_DRAFT;    // deprecated
+                    $new_fac_fourn->statut = self::STATUS_DRAFT; // deprecated
                     $new_fac_fourn->status = self::STATUS_DRAFT;
                     $new_fac_fourn->date = empty($facturerec->date_when) ? $now : $facturerec->date_when; // We could also use dol_now here but we prefer date_when so invoice has real date when we would like even if we generate later.
                     $new_fac_fourn->socid = $facturerec->socid;
@@ -1365,7 +1365,7 @@ 
                     $new_fac_fourn->model_pdf = $facturerec->model_pdf;
                     $new_fac_fourn->fk_project = $facturerec->fk_project;
                     $new_fac_fourn->label = $facturerec->label;
-                    $new_fac_fourn->libelle = $facturerec->label;   // deprecated
+                    $new_fac_fourn->libelle = $facturerec->label; // deprecated
 
                     $invoiceidgenerated = $new_fac_fourn->create($user);
                     $laststep = "Create invoiceidgenerated $invoiceidgenerated";
@@ -2072,8 +2072,8 @@ 
         $error = 0;
         $this->db->begin();
 
-        if (! $error) {
-            if (! $notrigger) {
+        if (!$error) {
+            if (!$notrigger) {
                 // Call triggers
                 $result = $this->call_trigger('LINESUPPLIERBILLREC_DELETE', $user);
                 if ($result < 0) {
@@ -2083,14 +2083,14 @@ 
             }
         }
 
-        if (! $error) {
+        if (!$error) {
             $result = $this->deleteExtraFields();
             if ($result < 0) {
                 $error++;
             }
         }
 
-        if (! $error) {
+        if (!$error) {
             $sql = 'DELETE FROM ' . MAIN_DB_PREFIX . $this->table_element . ' WHERE rowid=' . (int) $this->id;
 
             $res = $this->db->query($sql);

public/htdocs/fourn/class/fournisseur.commande.class.php

Indentation +14 added lines, -14 removed lines

@@ -606,7 +606,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      * Load array lines
      *
@@ -615,7 +615,7 @@ 
      */
     public function fetch_lines($only_product = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
 
         $this->lines = array();
 
@@ -880,7 +880,7 @@ 
         return $this->LibStatut($this->statut, $mode, $this->billed);
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return label of a status
      *
@@ -891,7 +891,7 @@ 
      */
     public function LibStatut($status, $mode = 0, $billed = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $langs, $hookmanager;
 
         if (empty($this->labelStatus) || empty($this->labelStatusShort)) {
@@ -1389,7 +1389,7 @@ 
         return $result;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Cancel an approved order.
      *  The cancellation is done after approval
@@ -1400,7 +1400,7 @@ 
      */
     public function Cancel($user, $idwarehouse = -1)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $langs, $conf;
 
         $error = 0;
@@ -2537,7 +2537,7 @@ 
         return $ret;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Set a delivery in database for this supplier order
      *
@@ -2549,7 +2549,7 @@ 
      */
     public function Livraison($user, $date, $type, $comment)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $langs;
 
         $result = 0;
@@ -2651,7 +2651,7 @@ 
         return $result;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Set delivery date
      *
@@ -2663,7 +2663,7 @@ 
      */
     public function set_date_livraison($user, $delivery_date, $notrigger = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         return $this->setDeliveryDate($user, $delivery_date, $notrigger);
     }
 
@@ -2723,7 +2723,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Set the id projet
      *
@@ -2734,7 +2734,7 @@ 
      */
     public function set_id_projet($user, $id_projet, $notrigger = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         if ($user->hasRight("fournisseur", "commande", "creer") || $user->hasRight("supplier_order", "creer")) {
             $error = 0;
 
@@ -3242,7 +3242,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Load indicators for dashboard (this->nbtodo and this->nbtodolate)
      *
@@ -3252,7 +3252,7 @@ 
      */
     public function load_board($user, $mode = 'opened')
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $langs;
 
         $sql = "SELECT c.rowid, c.date_creation as datec, c.date_commande, c.fk_statut, c.date_livraison as delivery_date, c.total_ht";

Spacing +15 added lines, -15 removed lines

@@ -520,7 +520,7 @@ 
             $this->ref_supplier = $obj->ref_supplier;
             $this->socid = $obj->fk_soc;
             $this->fourn_id = $obj->fk_soc;
-            $this->statut = $obj->status;   // deprecated
+            $this->statut = $obj->status; // deprecated
             $this->status = $obj->status;
             $this->billed = $obj->billed;
             $this->user_author_id = $obj->user_author_id;
@@ -551,7 +551,7 @@ 
             $this->fk_project = $obj->fk_project;
             $this->cond_reglement_id = $obj->fk_cond_reglement;
             $this->cond_reglement_code = $obj->cond_reglement_code;
-            $this->cond_reglement = $obj->cond_reglement_label;         // deprecated
+            $this->cond_reglement = $obj->cond_reglement_label; // deprecated
             $this->cond_reglement_label = $obj->cond_reglement_label;
             $this->cond_reglement_doc = $obj->cond_reglement_doc;
             $this->fk_account = $obj->fk_account;
@@ -684,10 +684,10 @@ 
                     $sqlsearchpackage .= ' WHERE entity IN (' . getEntity('product_fournisseur_price') . ")";
                     $sqlsearchpackage .= " AND fk_product = " . ((int) $objp->fk_product);
                     $sqlsearchpackage .= " AND ref_fourn = '" . $this->db->escape($objp->ref_supplier) . "'";
-                    $sqlsearchpackage .= " AND quantity <= " . ((float) $objp->qty);  // required to be qualified
-                    $sqlsearchpackage .= " AND (packaging IS NULL OR packaging = 0 OR packaging <= " . ((float) $objp->qty) . ")";  // required to be qualified
+                    $sqlsearchpackage .= " AND quantity <= " . ((float) $objp->qty); // required to be qualified
+                    $sqlsearchpackage .= " AND (packaging IS NULL OR packaging = 0 OR packaging <= " . ((float) $objp->qty) . ")"; // required to be qualified
                     $sqlsearchpackage .= " AND fk_soc = " . ((int) $this->socid);
-                    $sqlsearchpackage .= " ORDER BY packaging ASC";     // Take the smaller package first
+                    $sqlsearchpackage .= " ORDER BY packaging ASC"; // Take the smaller package first
                     $sqlsearchpackage .= " LIMIT 1";
 
                     $resqlsearchpackage = $this->db->query($sqlsearchpackage);
@@ -1623,10 +1623,10 @@ 
                         $line->date_end,
                         $line->array_options,
                         $line->fk_unit,
-                        $line->multicurrency_subprice,  // pu_ht_devise
-                        $line->origin,     // origin
-                        $line->origin_id,  // origin_id
-                        $line->rang,       // rang
+                        $line->multicurrency_subprice, // pu_ht_devise
+                        $line->origin, // origin
+                        $line->origin_id, // origin_id
+                        $line->rang, // rang
                         $line->special_code
                     );
                     if ($result < 0) {
@@ -2000,7 +2000,7 @@ 
             $this->db->begin();
 
             $product_type = $type;
-            $label = '';    // deprecated
+            $label = ''; // deprecated
 
             if ($fk_product > 0) {
                 if (getDolGlobalString('SUPPLIER_ORDER_WITH_PREDEFINED_PRICES_ONLY')) { // Not the common case
@@ -2143,7 +2143,7 @@ 
             $this->line->total_localtax2 = $total_localtax2;
             $this->line->total_ttc = $total_ttc;
             $this->line->product_type = $type;
-            $this->line->special_code   = (!empty($special_code) ? $special_code : 0);
+            $this->line->special_code = (!empty($special_code) ? $special_code : 0);
             $this->line->origin = $origin;
             $this->line->origin_id = $origin_id;
             $this->line->fk_unit = $fk_unit;
@@ -3350,7 +3350,7 @@ 
         global $conf, $langs;
 
         if (!dol_strlen($modele)) {
-            $modele = '';   // No doc template/generation by default
+            $modele = ''; // No doc template/generation by default
 
             if (!empty($this->model_pdf)) {
                 $modele = $this->model_pdf;
@@ -3892,10 +3892,10 @@ 
                     $sqlsearchpackage .= ' WHERE entity IN (' . getEntity('product_fournisseur_price') . ")";
                     $sqlsearchpackage .= " AND fk_product = " . ((int) $objp->fk_product);
                     $sqlsearchpackage .= " AND ref_fourn = '" . $this->db->escape($objp->ref_supplier) . "'";
-                    $sqlsearchpackage .= " AND quantity <= " . ((float) $objp->qty);  // required to be qualified
-                    $sqlsearchpackage .= " AND (packaging IS NULL OR packaging = 0 OR packaging <= " . ((float) $objp->qty) . ")";  // required to be qualified
+                    $sqlsearchpackage .= " AND quantity <= " . ((float) $objp->qty); // required to be qualified
+                    $sqlsearchpackage .= " AND (packaging IS NULL OR packaging = 0 OR packaging <= " . ((float) $objp->qty) . ")"; // required to be qualified
                     $sqlsearchpackage .= " AND fk_soc = " . ((int) $objp->socid);
-                    $sqlsearchpackage .= " ORDER BY packaging ASC";     // Take the smaller package first
+                    $sqlsearchpackage .= " ORDER BY packaging ASC"; // Take the smaller package first
                     $sqlsearchpackage .= " LIMIT 1";
 
                     $resqlsearchpackage = $this->db->query($sqlsearchpackage);

public/htdocs/fourn/class/fournisseur.facture.class.php

Indentation +16 added lines, -16 removed lines

@@ -1012,7 +1012,7 @@ 
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Load this->lines
      *
@@ -1020,7 +1020,7 @@ 
      */
     public function fetch_lines()
     {
-		// phpcs:enable
+        // phpcs:enable
         $this->lines = array();
 
         $sql = 'SELECT f.rowid, f.ref as ref_supplier, f.description as line_desc, f.date_start, f.date_end, f.pu_ht, f.pu_ttc, f.qty, f.remise_percent, f.vat_src_code, f.tva_tx';
@@ -1307,7 +1307,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *    Add a discount line into an invoice (as an invoice line) using an existing absolute discount (Consume the discount)
      *
@@ -1316,7 +1316,7 @@ 
      */
     public function insert_discount($idremise)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $langs;
 
         include_once DOL_DOCUMENT_ROOT . '/core/lib/price.lib.php';
@@ -1542,7 +1542,7 @@ 
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Tag invoice as a paid invoice
      *
@@ -1555,7 +1555,7 @@ 
      */
     public function set_paid($user, $close_code = '', $close_note = '')
     {
-		// phpcs:enable
+        // phpcs:enable
         dol_syslog(get_class($this) . "::set_paid is deprecated, use setPaid instead", LOG_NOTICE);
         return $this->setPaid($user, $close_code, $close_note);
     }
@@ -1620,7 +1620,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Tag the invoice as not fully paid + trigger call BILL_UNPAYED
      *  Function used when a direct debit payment is refused,
@@ -1633,7 +1633,7 @@ 
      */
     public function set_unpaid($user)
     {
-		// phpcs:enable
+        // phpcs:enable
         dol_syslog(get_class($this) . "::set_unpaid is deprecated, use setUnpaid instead", LOG_NOTICE);
         return $this->setUnpaid($user);
     }
@@ -2568,7 +2568,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return list of replaceable invoices
      *  Status valid or abandoned for other reason + not paid + no payment + not already replaced
@@ -2579,7 +2579,7 @@ 
      */
     public function list_replacable_supplier_invoices($socid = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf;
 
         $return = array();
@@ -2617,7 +2617,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return list of qualifying invoices for correction by credit note
      *  Invoices that respect the following rules are returned:
@@ -2629,7 +2629,7 @@ 
      */
     public function list_qualified_avoir_supplier_invoices($socid = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf;
 
         $return = array();
@@ -2671,7 +2671,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Load indicators for dashboard (this->nbtodo and this->nbtodolate)
      *
@@ -2680,7 +2680,7 @@ 
      */
     public function load_board($user)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $langs;
 
         $sql = 'SELECT ff.rowid, ff.date_lim_reglement as datefin, ff.fk_statut as status, ff.total_ht, ff.total_ttc';
@@ -4431,7 +4431,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Mise a jour de l'objet ligne de commande en base
      *
@@ -4439,7 +4439,7 @@ 
      */
     public function update_total()
     {
-		// phpcs:enable
+        // phpcs:enable
         $this->db->begin();
 
         // Mise a jour ligne en base

Spacing +17 added lines, -18 removed lines

@@ -227,7 +227,7 @@ 
     /**
      * @var int ID
      */
-    public $fk_account;     // default bank account
+    public $fk_account; // default bank account
 
     /**
      * @var int Transport mode id
@@ -463,7 +463,7 @@ 
             $this->location_incoterms = $_facrec->location_incoterms;
 
             // Clean parameters
-            if (! $this->type) {
+            if (!$this->type) {
                 $this->type = self::TYPE_STANDARD;
             }
             if (!empty(GETPOST('ref_supplier'))) {
@@ -477,7 +477,7 @@ 
 
             $this->array_options = $_facrec->array_options;
 
-            if (! $this->mode_reglement_id) {
+            if (!$this->mode_reglement_id) {
                 $this->mode_reglement_id = 0;
             }
             $this->status = self::STATUS_DRAFT;
@@ -726,7 +726,7 @@ 
             /*
              * Insert lines of template invoices
              */
-            if (! $error && $this->fac_rec > 0 && $_facrec instanceof FactureFournisseurRec) {
+            if (!$error && $this->fac_rec > 0 && $_facrec instanceof FactureFournisseurRec) {
                 foreach ($_facrec->lines as $i => $val) {
                     if ($_facrec->lines[$i]->fk_product) {
                         $prod = new Product($this->db);
@@ -753,7 +753,7 @@ 
                     $buyprice = empty($_facrec->lines[$i]->buyprice) ? 0 : $_facrec->lines[$i]->buyprice;
 
                     // If buyprice not defined from template invoice, we try to guess the best value
-                    if (! $buyprice && $_facrec->lines[$i]->fk_product > 0) {
+                    if (!$buyprice && $_facrec->lines[$i]->fk_product > 0) {
                         require_once constant('DOL_DOCUMENT_ROOT') . '/fourn/class/fournisseur.product.class.php';
                         $producttmp = new ProductFournisseur($this->db);
                         $producttmp->fetch($_facrec->lines[$i]->fk_product);
@@ -1004,7 +1004,7 @@ 
 
                 $this->extraparams = isset($obj->extraparams) ? (array) json_decode($obj->extraparams, true) : array();
 
-                $this->socid  = $obj->socid;
+                $this->socid = $obj->socid;
 
                 // Retrieve all extrafield
                 // fetch optionals attributes and labels
@@ -2278,7 +2278,7 @@ 
             // Multicurrency
             $supplierinvoiceline->fk_multicurrency = $this->fk_multicurrency;
             $supplierinvoiceline->multicurrency_code = $this->multicurrency_code;
-            $supplierinvoiceline->multicurrency_subprice    = ($this->type == self::TYPE_CREDIT_NOTE ? -abs($pu_ht_devise) : $pu_ht_devise); // For credit note, unit price always negative, always positive otherwise
+            $supplierinvoiceline->multicurrency_subprice = ($this->type == self::TYPE_CREDIT_NOTE ? -abs($pu_ht_devise) : $pu_ht_devise); // For credit note, unit price always negative, always positive otherwise
 
             $supplierinvoiceline->multicurrency_total_ht = (($this->type == self::TYPE_CREDIT_NOTE || $qty < 0) ? -abs($multicurrency_total_ht) : $multicurrency_total_ht); // For credit note and if qty is negative, total is negative
             $supplierinvoiceline->multicurrency_total_tva = (($this->type == self::TYPE_CREDIT_NOTE || $qty < 0) ? -abs($multicurrency_total_tva) : $multicurrency_total_tva); // For credit note and if qty is negative, total is negative
@@ -2444,7 +2444,7 @@ 
 
         $line->qty = ($this->type == self::TYPE_CREDIT_NOTE ? abs((float) $qty) : $qty); // For credit note, quantity is always positive and unit price negative
         $line->subprice = ($this->type == self::TYPE_CREDIT_NOTE ? -abs($pu_ht) : $pu_ht); // For credit note, unit price always negative, always positive otherwise
-        $line->pu_ht = $line->subprice;  // deprecated
+        $line->pu_ht = $line->subprice; // deprecated
         $line->pu_ttc = ($this->type == self::TYPE_CREDIT_NOTE ? -abs($pu_ttc) : $pu_ttc); // For credit note, unit price always negative, always positive otherwise
 
         $line->remise_percent = $remise_percent;
@@ -2729,7 +2729,7 @@ 
 
             while ($obj = $this->db->fetch_object($resql)) {
                 $facturestatic->date_echeance = $this->db->jdate($obj->datefin);
-                $facturestatic->statut = $obj->status;  // For backward compatibility
+                $facturestatic->statut = $obj->status; // For backward compatibility
                 $facturestatic->status = $obj->status;
 
                 $response->nbtodo++;
@@ -3164,15 +3164,15 @@ 
         // Load source object
         $object->fetch($fromid);
         $object->id = 0;
-        $object->statut = self::STATUS_DRAFT;   // For backward compatibility
+        $object->statut = self::STATUS_DRAFT; // For backward compatibility
         $object->status = self::STATUS_DRAFT;
 
         $object->fetch_thirdparty(); // We need it to recalculate VAT localtaxes according to main sale taxes and vendor
 
         // Clear fields
         $object->ref_supplier       = (empty($this->ref_supplier) ? $langs->trans("CopyOf") . ' ' . $object->ref_supplier : $this->ref_supplier);
-        $object->author             = $user->id;  // FIXME? user_validation_id is replacement for author
-        $object->user_validation_id = 0;  // FIXME?  user_validation_id is replacement for author
+        $object->author             = $user->id; // FIXME? user_validation_id is replacement for author
+        $object->user_validation_id = 0; // FIXME?  user_validation_id is replacement for author
         $object->fk_facture_source  = 0;
         $object->date_creation      = '';
         $object->date_validation    = '';
@@ -3475,14 +3475,14 @@ 
         if (!empty($paymentmode) && $paymentmode != 'all') {
             $sql .= ", " . MAIN_DB_PREFIX . "c_paiement as cp";
         }
-        $sql .= " WHERE f.paye = 0";    // Only unpaid
-        $sql .= " AND f.fk_statut = " . self::STATUS_VALIDATED;   // Only validated status
+        $sql .= " WHERE f.paye = 0"; // Only unpaid
+        $sql .= " AND f.fk_statut = " . self::STATUS_VALIDATED; // Only validated status
         if ($datetouse == 'invoicedate') {
             $sql .= " AND f.datef = '" . $this->db->idate($tmpidate, 'gmt') . "'";
         } else {
             $sql .= " AND f.date_lim_reglement = '" . $this->db->idate($tmpidate, 'gmt') . "'";
         }
-        $sql .= " AND f.entity IN (" . getEntity('supplier_invoice', 0) . ")";  // One batch process only one company (no sharing)
+        $sql .= " AND f.entity IN (" . getEntity('supplier_invoice', 0) . ")"; // One batch process only one company (no sharing)
         if (!empty($paymentmode) && $paymentmode != 'all') {
             $sql .= " AND f.fk_mode_reglement = cp.id AND cp.code = '" . $this->db->escape($paymentmode) . "'";
         }
@@ -3702,7 +3702,7 @@ 
                                 $actioncomm->create($user);
                             }
 
-                            $this->db->commit();    // We always commit
+                            $this->db->commit(); // We always commit
                         }
 
                         if ($errormesg) {
@@ -4377,8 +4377,7 @@ 
         $sql .= " " . ($this->fk_parent_line > 0 ? "'" . $this->db->escape($this->fk_parent_line) . "'" : "null") . ",";
         $product_label
             = !empty($this->product_label)
-              ? $this->product_label :
-                (!empty($this->label) ? $this->label : null);
+              ? $this->product_label : (!empty($this->label) ? $this->label : null);
         $sql .= " " . (!empty($product_label) ? "'" . $this->db->escape($product_label) . "'" : "null") . ",";
         $sql .= " '" . $this->db->escape($this->desc ? $this->desc : $this->description) . "',";
         $sql .= " '" . $this->db->escape($this->ref_supplier) . "',";