alxarafe / alixar

dolibarr/htdocs/main.inc.php

Braces +365 added lines, -240 removed lines

@@ -214,16 +214,18 @@ 
     foreach ($tmplist as $tmpkey) {
         $postkey = $tmpautoset[0] . '_' . $tmpkey;
         //var_dump('tmpkey='.$tmpkey.' postkey='.$postkey.' value='.$_POST[$postkey]);
-        if (!empty($_POST[$postkey]))
-            $cookiearrayvalue[$tmpkey] = $_POST[$postkey];
+        if (!empty($_POST[$postkey])) {
+                    $cookiearrayvalue[$tmpkey] = $_POST[$postkey];
+        }
     }
     $cookiename = $tmpautoset[0];
     $cookievalue = json_encode($cookiearrayvalue);
     //var_dump('setcookie cookiename='.$cookiename.' cookievalue='.$cookievalue);
     setcookie($cookiename, empty($cookievalue) ? '' : $cookievalue, empty($cookievalue) ? 0 : (time() + (86400 * 354)), '/', null, false, true); // keep cookie 1 year and add tag httponly
-    if (empty($cookievalue))
-        unset($_COOKIE[$cookiename]);
-}
+    if (empty($cookievalue)) {
+            unset($_COOKIE[$cookiename]);
+    }
+    }
 
 
 // Init session. Name of session is specific to Dolibarr instance.
@@ -232,8 +234,9 @@ 
 
 $sessionname = 'DOLSESSID_' . $prefix;
 $sessiontimeout = 'DOLSESSTIMEOUT_' . $prefix;
-if (!empty($_COOKIE[$sessiontimeout]))
+if (!empty($_COOKIE[$sessiontimeout])) {
     ini_set('session.gc_maxlifetime', $_COOKIE[$sessiontimeout]);
+}
 session_name($sessionname);
 session_set_cookie_params(0, '/', null, false, true);   // Add tag httponly on session cookie (same as setting session.cookie_httponly into php.ini). Must be called before the session_start.
 // This create lock, released when session_write_close() or end of page.
@@ -264,11 +267,13 @@ 
     $conf->browser->layout = $tmp['layout'];     // 'classic', 'phone', 'tablet'
     //var_dump($conf->browser);
 
-    if ($conf->browser->layout == 'phone')
-        $conf->dol_no_mouse_hover = 1;
-    if ($conf->browser->layout == 'phone')
-        $conf->global->MAIN_TESTMENUHIDER = 1;
-}
+    if ($conf->browser->layout == 'phone') {
+            $conf->dol_no_mouse_hover = 1;
+    }
+    if ($conf->browser->layout == 'phone') {
+            $conf->global->MAIN_TESTMENUHIDER = 1;
+    }
+    }
 
 // Force HTTPS if required ($conf->file->main_force_https is 0/1 or https dolibarr root url)
 // $_SERVER["HTTPS"] is 'on' when link is https, otherwise $_SERVER["HTTPS"] is empty or 'off'
@@ -313,10 +318,14 @@ 
 }
 
 // Loading of additional presentation includes
-if (!defined('NOREQUIREHTML'))
-    require_once DOL_BASE_PATH . '/core/class/html.form.class.php';     // Need 660ko memory (800ko in 2.2)
-if (!defined('NOREQUIREAJAX') && $conf->use_javascript_ajax)
-    require_once DOL_BASE_PATH . '/core/lib/ajax.lib.php'; // Need 22ko memory
+if (!defined('NOREQUIREHTML')) {
+    require_once DOL_BASE_PATH . '/core/class/html.form.class.php';
+}
+// Need 660ko memory (800ko in 2.2)
+if (!defined('NOREQUIREAJAX') && $conf->use_javascript_ajax) {
+    require_once DOL_BASE_PATH . '/core/lib/ajax.lib.php';
+}
+// Need 22ko memory
 
 
 
@@ -353,8 +362,9 @@ 
 // Creation of a token against CSRF vulnerabilities
 if (!defined('NOTOKENRENEWAL')) {
     // roulement des jetons car cree a chaque appel
-    if (isset($_SESSION['newtoken']))
-        $_SESSION['token'] = $_SESSION['newtoken'];
+    if (isset($_SESSION['newtoken'])) {
+            $_SESSION['token'] = $_SESSION['newtoken'];
+    }
 
     // Save in $_SESSION['newtoken'] what will be next token. Into forms, we will add param token = $_SESSION['newtoken']
     $token = dol_hash(uniqid(mt_rand(), true)); // Generates a hash of a random number
@@ -376,14 +386,16 @@ 
 }
 
 // Disable modules (this must be after session_start and after conf has been loaded)
-if (GETPOST('disablemodules', 'alpha'))
+if (GETPOST('disablemodules', 'alpha')) {
     $_SESSION["disablemodules"] = GETPOST('disablemodules', 'alpha');
+}
 if (!empty($_SESSION["disablemodules"])) {
     $disabled_modules = explode(',', $_SESSION["disablemodules"]);
     foreach ($disabled_modules as $module) {
         if ($module) {
-            if (empty($conf->$module))
-                $conf->$module = new stdClass();
+            if (empty($conf->$module)) {
+                            $conf->$module = new stdClass();
+            }
             $conf->$module->enabled = false;
             if ($module == 'fournisseur') {  // Special case
                 $conf->supplier_order->enabled = 0;
@@ -405,11 +417,13 @@ 
         $dolibarr_main_authentication = constant('MAIN_AUTHENTICATION_MODE');
     } else {
         // Authentication mode
-        if (empty($dolibarr_main_authentication))
-            $dolibarr_main_authentication = 'http,dolibarr';
+        if (empty($dolibarr_main_authentication)) {
+                    $dolibarr_main_authentication = 'http,dolibarr';
+        }
         // Authentication mode: forceuser
-        if ($dolibarr_main_authentication == 'forceuser' && empty($dolibarr_auto_user))
-            $dolibarr_auto_user = 'auto';
+        if ($dolibarr_main_authentication == 'forceuser' && empty($dolibarr_auto_user)) {
+                    $dolibarr_auto_user = 'auto';
+        }
     }
     // Set authmode
     $authmode = explode(',', $dolibarr_main_authentication);
@@ -486,35 +500,41 @@ 
                 $hookmanager->initHooks(array('login'));
                 $parameters = array('dol_authmode' => $dol_authmode, 'dol_loginmesg' => $_SESSION["dol_loginmesg"]);
                 $reshook = $hookmanager->executeHooks('afterLoginFailed', $parameters, $user, $action);    // Note that $action and $object may have been modified by some hooks
-                if ($reshook < 0)
-                    $error++;
+                if ($reshook < 0) {
+                                    $error++;
+                }
 
                 // Note: exit is done later
             }
         }
 
         $allowedmethodtopostusername = 2;
-        if (defined('MAIN_AUTHENTICATION_POST_METHOD'))
-            $allowedmethodtopostusername = constant('MAIN_AUTHENTICATION_POST_METHOD');
+        if (defined('MAIN_AUTHENTICATION_POST_METHOD')) {
+                    $allowedmethodtopostusername = constant('MAIN_AUTHENTICATION_POST_METHOD');
+        }
         $usertotest = (!empty($_COOKIE['login_dolibarr']) ? $_COOKIE['login_dolibarr'] : GETPOST("username", "alpha", $allowedmethodtopostusername));
         $passwordtotest = GETPOST('password', 'none', $allowedmethodtopostusername);
         $entitytotest = (GETPOST('entity', 'int') ? GETPOST('entity', 'int') : (!empty($conf->entity) ? $conf->entity : 1));
 
         // Define if we received data to test the login.
         $goontestloop = false;
-        if (isset($_SERVER["REMOTE_USER"]) && in_array('http', $authmode))
-            $goontestloop = true;
-        if ($dolibarr_main_authentication == 'forceuser' && !empty($dolibarr_auto_user))
-            $goontestloop = true;
-        if (GETPOST("username", "alpha", $allowedmethodtopostusername) || !empty($_COOKIE['login_dolibarr']) || GETPOST('openid_mode', 'alpha', 1))
-            $goontestloop = true;
+        if (isset($_SERVER["REMOTE_USER"]) && in_array('http', $authmode)) {
+                    $goontestloop = true;
+        }
+        if ($dolibarr_main_authentication == 'forceuser' && !empty($dolibarr_auto_user)) {
+                    $goontestloop = true;
+        }
+        if (GETPOST("username", "alpha", $allowedmethodtopostusername) || !empty($_COOKIE['login_dolibarr']) || GETPOST('openid_mode', 'alpha', 1)) {
+                    $goontestloop = true;
+        }
 
         if (!is_object($langs)) { // This can occurs when calling page with NOREQUIRETRAN defined, however we need langs for error messages.
             include_once DOL_BASE_PATH . '/core/class/translate.class.php';
             $langs = new Translate("", $conf);
             $langcode = (GETPOST('lang', 'aZ09', 1) ? GETPOST('lang', 'aZ09', 1) : (empty($conf->global->MAIN_LANG_DEFAULT) ? 'auto' : $conf->global->MAIN_LANG_DEFAULT));
-            if (defined('MAIN_LANG_DEFAULT'))
-                $langcode = constant('MAIN_LANG_DEFAULT');
+            if (defined('MAIN_LANG_DEFAULT')) {
+                            $langcode = constant('MAIN_LANG_DEFAULT');
+            }
             $langs->setDefaultLang($langcode);
         }
 
@@ -536,8 +556,9 @@ 
                     $datenow = dol_now();
                     $datefirst = dol_stringtotime($_POST["dst_first"]);
                     $datesecond = dol_stringtotime($_POST["dst_second"]);
-                    if ($datenow >= $datefirst && $datenow < $datesecond)
-                        $dol_dst = 1;
+                    if ($datenow >= $datefirst && $datenow < $datesecond) {
+                                            $dol_dst = 1;
+                    }
                 }
                 //print $datefirst.'-'.$datesecond.'-'.$datenow.'-'.$dol_tz.'-'.$dol_tzstring.'-'.$dol_dst; exit;
             }
@@ -549,8 +570,9 @@ 
 
                 // Bad password. No authmode has found a good password.
                 // We set a generic message if not defined inside function checkLoginPassEntity or subfunctions
-                if (empty($_SESSION["dol_loginmesg"]))
-                    $_SESSION["dol_loginmesg"] = $langs->trans("ErrorBadLoginPassword");
+                if (empty($_SESSION["dol_loginmesg"])) {
+                                    $_SESSION["dol_loginmesg"] = $langs->trans("ErrorBadLoginPassword");
+                }
 
                 // Call trigger for the "security events" log
                 $user->trigger_mesg = $langs->trans("ErrorBadLoginPassword") . ' - login=' . GETPOST("username", "alpha", 2);
@@ -567,8 +589,9 @@ 
                 $hookmanager->initHooks(array('login'));
                 $parameters = array('dol_authmode' => $dol_authmode, 'dol_loginmesg' => $_SESSION["dol_loginmesg"]);
                 $reshook = $hookmanager->executeHooks('afterLoginFailed', $parameters, $user, $action);    // Note that $action and $object may have been modified by some hooks
-                if ($reshook < 0)
-                    $error++;
+                if ($reshook < 0) {
+                                    $error++;
+                }
 
                 // Note: exit is done in next chapter
             }
@@ -578,10 +601,11 @@ 
         if (!$login || (in_array('ldap', $authmode) && empty($passwordtotest))) { // With LDAP we refused empty password because some LDAP are "opened" for anonymous access so connexion is a success.
             // No data to test login, so we show the login page
             dol_syslog("--- Access to " . $_SERVER["PHP_SELF"] . " showing the login form and exit");
-            if (defined('NOREDIRECTBYMAINTOLOGIN'))
-                return 'ERROR_NOT_LOGGED';
-            else
-                dol_loginfunction($langs, $conf, (!empty($mysoc) ? $mysoc : ''));
+            if (defined('NOREDIRECTBYMAINTOLOGIN')) {
+                            return 'ERROR_NOT_LOGGED';
+            } else {
+                            dol_loginfunction($langs, $conf, (!empty($mysoc) ? $mysoc : ''));
+            }
             exit;
         }
 
@@ -620,21 +644,24 @@ 
             $hookmanager->initHooks(array('login'));
             $parameters = array('dol_authmode' => $dol_authmode, 'dol_loginmesg' => $_SESSION["dol_loginmesg"]);
             $reshook = $hookmanager->executeHooks('afterLoginFailed', $parameters, $user, $action);    // Note that $action and $object may have been modified by some hooks
-            if ($reshook < 0)
-                $error++;
+            if ($reshook < 0) {
+                            $error++;
+            }
 
             $paramsurl = array();
-            if (GETPOST('textbrowser', 'int'))
-                $paramsurl[] = 'textbrowser=' . GETPOST('textbrowser', 'int');
-            if (GETPOST('nojs', 'int'))
-                $paramsurl[] = 'nojs=' . GETPOST('nojs', 'int');
-            if (GETPOST('lang', 'aZ09'))
-                $paramsurl[] = 'lang=' . GETPOST('lang', 'aZ09');
+            if (GETPOST('textbrowser', 'int')) {
+                            $paramsurl[] = 'textbrowser=' . GETPOST('textbrowser', 'int');
+            }
+            if (GETPOST('nojs', 'int')) {
+                            $paramsurl[] = 'nojs=' . GETPOST('nojs', 'int');
+            }
+            if (GETPOST('lang', 'aZ09')) {
+                            $paramsurl[] = 'lang=' . GETPOST('lang', 'aZ09');
+            }
             header('Location: ' . DOL_BASE_URI . '/index.php' . (count($paramsurl) ? '?' . implode('&', $paramsurl) : ''));
             exit;
         }
-    }
-    else {
+    } else {
         // We are already into an authenticated session
         $login = $_SESSION["dol_login"];
         $entity = $_SESSION["dol_entity"];
@@ -676,20 +703,23 @@ 
             $hookmanager->initHooks(array('login'));
             $parameters = array('dol_authmode' => $dol_authmode, 'dol_loginmesg' => $_SESSION["dol_loginmesg"]);
             $reshook = $hookmanager->executeHooks('afterLoginFailed', $parameters, $user, $action);    // Note that $action and $object may have been modified by some hooks
-            if ($reshook < 0)
-                $error++;
+            if ($reshook < 0) {
+                            $error++;
+            }
 
             $paramsurl = array();
-            if (GETPOST('textbrowser', 'int'))
-                $paramsurl[] = 'textbrowser=' . GETPOST('textbrowser', 'int');
-            if (GETPOST('nojs', 'int'))
-                $paramsurl[] = 'nojs=' . GETPOST('nojs', 'int');
-            if (GETPOST('lang', 'aZ09'))
-                $paramsurl[] = 'lang=' . GETPOST('lang', 'aZ09');
+            if (GETPOST('textbrowser', 'int')) {
+                            $paramsurl[] = 'textbrowser=' . GETPOST('textbrowser', 'int');
+            }
+            if (GETPOST('nojs', 'int')) {
+                            $paramsurl[] = 'nojs=' . GETPOST('nojs', 'int');
+            }
+            if (GETPOST('lang', 'aZ09')) {
+                            $paramsurl[] = 'lang=' . GETPOST('lang', 'aZ09');
+            }
             header('Location: ' . DOL_BASE_URI . '/index.php' . (count($paramsurl) ? '?' . implode('&', $paramsurl) : ''));
             exit;
-        }
-        else {
+        } else {
             // Initialize technical object to manage hooks of page. Note that conf->hooks_modules contains array of hook context
             $hookmanager->initHooks(array('main'));
 
@@ -698,8 +728,9 @@ 
                 $relativepathstring = preg_replace('/\?.*$/', '', $_SERVER["HTTP_REFERER"]);
                 $relativepathstring = preg_replace('/^https?:\/\/[^\/]*/', '', $relativepathstring);     // Get full path except host server
                 // Clean $relativepathstring
-                if (constant('DOL_BASE_URI'))
-                    $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);
+                if (constant('DOL_BASE_URI')) {
+                                    $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);
+                }
                 $relativepathstring = preg_replace('/^\//', '', $relativepathstring);
                 $relativepathstring = preg_replace('/^custom\//', '', $relativepathstring);
                 //var_dump($relativepathstring);
@@ -750,16 +781,21 @@ 
         $_SESSION["dol_company"] = $conf->global->MAIN_INFO_SOCIETE_NOM;
         $_SESSION["dol_entity"] = $conf->entity;
         // Store value into session (values stored only if defined)
-        if (!empty($dol_hide_topmenu))
-            $_SESSION['dol_hide_topmenu'] = $dol_hide_topmenu;
-        if (!empty($dol_hide_leftmenu))
-            $_SESSION['dol_hide_leftmenu'] = $dol_hide_leftmenu;
-        if (!empty($dol_optimize_smallscreen))
-            $_SESSION['dol_optimize_smallscreen'] = $dol_optimize_smallscreen;
-        if (!empty($dol_no_mouse_hover))
-            $_SESSION['dol_no_mouse_hover'] = $dol_no_mouse_hover;
-        if (!empty($dol_use_jmobile))
-            $_SESSION['dol_use_jmobile'] = $dol_use_jmobile;
+        if (!empty($dol_hide_topmenu)) {
+                    $_SESSION['dol_hide_topmenu'] = $dol_hide_topmenu;
+        }
+        if (!empty($dol_hide_leftmenu)) {
+                    $_SESSION['dol_hide_leftmenu'] = $dol_hide_leftmenu;
+        }
+        if (!empty($dol_optimize_smallscreen)) {
+                    $_SESSION['dol_optimize_smallscreen'] = $dol_optimize_smallscreen;
+        }
+        if (!empty($dol_no_mouse_hover)) {
+                    $_SESSION['dol_no_mouse_hover'] = $dol_no_mouse_hover;
+        }
+        if (!empty($dol_use_jmobile)) {
+                    $_SESSION['dol_use_jmobile'] = $dol_use_jmobile;
+        }
 
         dol_syslog("This is a new started user session. _SESSION['dol_login']=" . $_SESSION["dol_login"] . " Session id=" . session_id());
 
@@ -784,8 +820,9 @@ 
         $hookmanager->initHooks(array('login'));
         $parameters = array('dol_authmode' => $dol_authmode, 'dol_loginfo' => $loginfo);
         $reshook = $hookmanager->executeHooks('afterLogin', $parameters, $user, $action);    // Note that $action and $object may have been modified by some hooks
-        if ($reshook < 0)
-            $error++;
+        if ($reshook < 0) {
+                    $error++;
+        }
 
         if ($error) {
             $db->rollback();
@@ -823,10 +860,14 @@ 
      */
 
     // Set liste_limit
-    if (isset($user->conf->MAIN_SIZE_LISTE_LIMIT))
-        $conf->liste_limit = $user->conf->MAIN_SIZE_LISTE_LIMIT; // Can be 0
-    if (isset($user->conf->PRODUIT_LIMIT_SIZE))
-        $conf->product->limit_size = $user->conf->PRODUIT_LIMIT_SIZE; // Can be 0
+    if (isset($user->conf->MAIN_SIZE_LISTE_LIMIT)) {
+            $conf->liste_limit = $user->conf->MAIN_SIZE_LISTE_LIMIT;
+    }
+    // Can be 0
+    if (isset($user->conf->PRODUIT_LIMIT_SIZE)) {
+            $conf->product->limit_size = $user->conf->PRODUIT_LIMIT_SIZE;
+    }
+    // Can be 0
 
 
 
@@ -861,8 +902,9 @@ 
     if (!empty($user->conf->MAIN_DISABLE_JAVASCRIPT)) {
         $conf->use_javascript_ajax = !$user->conf->MAIN_DISABLE_JAVASCRIPT;
     }
-} else
+} else {
     $conf->use_javascript_ajax = 0;
+}
 // Set MAIN_OPTIMIZEFORTEXTBROWSER
 if (GETPOST('textbrowser', 'int') || (!empty($conf->browser->name) && $conf->browser->name == 'lynxlinks') || !empty($user->conf->MAIN_OPTIMIZEFORTEXTBROWSER)) {   // If we must enable text browser
     $conf->global->MAIN_OPTIMIZEFORTEXTBROWSER = 1;
@@ -871,25 +913,32 @@ 
 }
 
 // Set terminal output option according to conf->browser.
-if (GETPOST('dol_hide_leftmenu', 'int') || !empty($_SESSION['dol_hide_leftmenu']))
+if (GETPOST('dol_hide_leftmenu', 'int') || !empty($_SESSION['dol_hide_leftmenu'])) {
     $conf->dol_hide_leftmenu = 1;
-if (GETPOST('dol_hide_topmenu', 'int') || !empty($_SESSION['dol_hide_topmenu']))
+}
+if (GETPOST('dol_hide_topmenu', 'int') || !empty($_SESSION['dol_hide_topmenu'])) {
     $conf->dol_hide_topmenu = 1;
-if (GETPOST('dol_optimize_smallscreen', 'int') || !empty($_SESSION['dol_optimize_smallscreen']))
+}
+if (GETPOST('dol_optimize_smallscreen', 'int') || !empty($_SESSION['dol_optimize_smallscreen'])) {
     $conf->dol_optimize_smallscreen = 1;
-if (GETPOST('dol_no_mouse_hover', 'int') || !empty($_SESSION['dol_no_mouse_hover']))
+}
+if (GETPOST('dol_no_mouse_hover', 'int') || !empty($_SESSION['dol_no_mouse_hover'])) {
     $conf->dol_no_mouse_hover = 1;
-if (GETPOST('dol_use_jmobile', 'int') || !empty($_SESSION['dol_use_jmobile']))
+}
+if (GETPOST('dol_use_jmobile', 'int') || !empty($_SESSION['dol_use_jmobile'])) {
     $conf->dol_use_jmobile = 1;
-if (!empty($conf->browser->layout) && $conf->browser->layout != 'classic')
+}
+if (!empty($conf->browser->layout) && $conf->browser->layout != 'classic') {
     $conf->dol_no_mouse_hover = 1;
+}
 if ((!empty($conf->browser->layout) && $conf->browser->layout == 'phone') || (!empty($_SESSION['dol_screenwidth']) && $_SESSION['dol_screenwidth'] < 400) || (!empty($_SESSION['dol_screenheight']) && $_SESSION['dol_screenheight'] < 400)
 ) {
     $conf->dol_optimize_smallscreen = 1;
 }
 // If we force to use jmobile, then we reenable javascript
-if (!empty($conf->dol_use_jmobile))
+if (!empty($conf->dol_use_jmobile)) {
     $conf->use_javascript_ajax = 1;
+}
 // Replace themes bugged with jmobile with eldy
 if (!empty($conf->dol_use_jmobile) && in_array($conf->theme, array('bureau2crea', 'cameleo', 'amarok'))) {
     $conf->theme = 'eldy';
@@ -913,8 +962,9 @@ 
 if (!defined('NOLOGIN')) {
     // If the login is not recovered, it is identified with an account that does not exist.
     // Hacking attempt?
-    if (!$user->login)
-        accessforbidden();
+    if (!$user->login) {
+            accessforbidden();
+    }
 
     // Check if user is active
     if ($user->statut < 1) {
@@ -989,15 +1039,18 @@ 
 
     // Load the menu manager (only if not already done)
     $file_menu = $conf->standard_menu;
-    if (GETPOST('menu', 'alpha'))
-        $file_menu = GETPOST('menu', 'alpha');     // example: menu=eldy_menu.php
+    if (GETPOST('menu', 'alpha')) {
+            $file_menu = GETPOST('menu', 'alpha');
+    }
+    // example: menu=eldy_menu.php
     if (!class_exists('MenuManager')) {
         $menufound = 0;
         $dirmenus = array_merge(array("/core/menus/"), (array) $conf->modules_parts['menus']);
         foreach ($dirmenus as $dirmenu) {
             $menufound = dol_include_once($dirmenu . "standard/" . $file_menu);
-            if (class_exists('MenuManager'))
-                break;
+            if (class_exists('MenuManager')) {
+                            break;
+            }
         }
         if (!class_exists('MenuManager')) { // If failed to include, we try with standard eldy_menu.php
             dol_syslog("You define a menu manager '" . $file_menu . "' that can not be loaded.", LOG_WARNING);
@@ -1147,18 +1200,20 @@ 
     }
     print '<!doctype html>' . "\n";
 
-    if (!empty($conf->global->MAIN_USE_CACHE_MANIFEST))
-        print '<html lang="' . substr($langs->defaultlang, 0, 2) . '" manifest="' . DOL_BASE_URI . '/cache.manifest">' . "\n";
-    else
-        print '<html lang="' . substr($langs->defaultlang, 0, 2) . '">' . "\n";
+    if (!empty($conf->global->MAIN_USE_CACHE_MANIFEST)) {
+            print '<html lang="' . substr($langs->defaultlang, 0, 2) . '" manifest="' . DOL_BASE_URI . '/cache.manifest">' . "\n";
+    } else {
+            print '<html lang="' . substr($langs->defaultlang, 0, 2) . '">' . "\n";
+    }
     //print '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="fr">'."\n";
     if (empty($disablehead)) {
         $ext = 'layout=' . $conf->browser->layout . '&version=' . urlencode(DOL_VERSION);
 
         print "<head>\n";
 
-        if (GETPOST('dol_basehref', 'alpha'))
-            print '<base href="' . dol_escape_htmltag(GETPOST('dol_basehref', 'alpha')) . '">' . "\n";
+        if (GETPOST('dol_basehref', 'alpha')) {
+                    print '<base href="' . dol_escape_htmltag(GETPOST('dol_basehref', 'alpha')) . '">' . "\n";
+        }
 
         // Displays meta
         print '<meta charset="UTF-8">' . "\n";
@@ -1168,10 +1223,13 @@ 
 
         // Favicon
         $favicon = dol_buildpath('/theme/' . $conf->theme . '/img/favicon.ico', 1);
-        if (!empty($conf->global->MAIN_FAVICON_URL))
-            $favicon = $conf->global->MAIN_FAVICON_URL;
-        if (empty($conf->dol_use_jmobile))
-            print '<link rel="shortcut icon" type="image/x-icon" href="' . $favicon . '"/>' . "\n"; // Not required into an Android webview
+        if (!empty($conf->global->MAIN_FAVICON_URL)) {
+                    $favicon = $conf->global->MAIN_FAVICON_URL;
+        }
+        if (empty($conf->dol_use_jmobile)) {
+                    print '<link rel="shortcut icon" type="image/x-icon" href="' . $favicon . '"/>' . "\n";
+        }
+        // Not required into an Android webview
 
 
 
@@ -1189,47 +1247,59 @@ 
         //if (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) print '<link rel="copyright" title="GNU General Public License" href="http://www.gnu.org/copyleft/gpl.html#SEC1">'."\n";
         //if (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) print '<link rel="author" title="Dolibarr Development Team" href="https://www.dolibarr.org">'."\n";
         // Auto refresh page
-        if (GETPOST('autorefresh', 'int') > 0)
-            print '<meta http-equiv="refresh" content="' . GETPOST('autorefresh', 'int') . '">';
+        if (GETPOST('autorefresh', 'int') > 0) {
+                    print '<meta http-equiv="refresh" content="' . GETPOST('autorefresh', 'int') . '">';
+        }
 
         // Displays title
         $appli = constant('DOL_APPLICATION_TITLE');
-        if (!empty($conf->global->MAIN_APPLICATION_TITLE))
-            $appli = $conf->global->MAIN_APPLICATION_TITLE;
+        if (!empty($conf->global->MAIN_APPLICATION_TITLE)) {
+                    $appli = $conf->global->MAIN_APPLICATION_TITLE;
+        }
 
         print '<title>';
         $titletoshow = '';
-        if ($title && !empty($conf->global->MAIN_HTML_TITLE) && preg_match('/noapp/', $conf->global->MAIN_HTML_TITLE))
-            $titletoshow = dol_htmlentities($title);
-        else if ($title)
-            $titletoshow = dol_htmlentities($appli . ' - ' . $title);
-        else
-            $titletoshow = dol_htmlentities($appli);
-
-        if (!is_object($hookmanager))
-            $hookmanager = new HookManager($db);
+        if ($title && !empty($conf->global->MAIN_HTML_TITLE) && preg_match('/noapp/', $conf->global->MAIN_HTML_TITLE)) {
+                    $titletoshow = dol_htmlentities($title);
+        } else if ($title) {
+                    $titletoshow = dol_htmlentities($appli . ' - ' . $title);
+        } else {
+                    $titletoshow = dol_htmlentities($appli);
+        }
+
+        if (!is_object($hookmanager)) {
+                    $hookmanager = new HookManager($db);
+        }
         $hookmanager->initHooks("main");
         $parameters = array('title' => $titletoshow);
         $result = $hookmanager->executeHooks('setHtmlTitle', $parameters);  // Note that $action and $object may have been modified by some hooks
-        if ($result > 0)
-            $titletoshow = $hookmanager->resPrint;    // Replace Title to show
-        else
-            $titletoshow .= $hookmanager->resPrint;      // Concat to Title to show
+        if ($result > 0) {
+                    $titletoshow = $hookmanager->resPrint;
+        }
+        // Replace Title to show
+        else {
+                    $titletoshow .= $hookmanager->resPrint;
+        }
+        // Concat to Title to show
 
         print $titletoshow;
         print '</title>';
 
         print "\n";
 
-        if (GETPOST('version', 'int'))
-            $ext = 'version=' . GETPOST('version', 'int'); // usefull to force no cache on css/js
-        if (GETPOST('testmenuhider', 'int') || !empty($conf->global->MAIN_TESTMENUHIDER))
-            $ext .= '&testmenuhider=' . (GETPOST('testmenuhider', 'int') ? GETPOST('testmenuhider', 'int') : $conf->global->MAIN_TESTMENUHIDER);
+        if (GETPOST('version', 'int')) {
+                    $ext = 'version=' . GETPOST('version', 'int');
+        }
+        // usefull to force no cache on css/js
+        if (GETPOST('testmenuhider', 'int') || !empty($conf->global->MAIN_TESTMENUHIDER)) {
+                    $ext .= '&testmenuhider=' . (GETPOST('testmenuhider', 'int') ? GETPOST('testmenuhider', 'int') : $conf->global->MAIN_TESTMENUHIDER);
+        }
 
         $themeparam = '&lang=' . $langs->defaultlang . '&amp;theme=' . $conf->theme . (GETPOST('optioncss', 'aZ09') ? '&amp;optioncss=' . GETPOST('optioncss', 'aZ09', 1) : '') . '&amp;userid=' . $user->id . '&amp;entity=' . $conf->entity;
         $themeparam .= ($ext ? '&amp;' . $ext : '');
-        if (!empty($_SESSION['dol_resetcache']))
-            $themeparam .= '&amp;dol_resetcache=' . $_SESSION['dol_resetcache'];
+        if (!empty($_SESSION['dol_resetcache'])) {
+                    $themeparam .= '&amp;dol_resetcache=' . $_SESSION['dol_resetcache'];
+        }
         if (GETPOST('dol_hide_topmenu', 'int')) {
             $themeparam .= '&amp;dol_hide_topmenu=' . GETPOST('dol_hide_topmenu', 'int');
         }
@@ -1288,8 +1358,9 @@ 
 
         //print 'themepath='.$themepath.' themeparam='.$themeparam;exit;
         print '<link rel="stylesheet" type="text/css" href="' . $themepath . $themeparam . '">' . "\n";
-        if (!empty($conf->global->MAIN_FIX_FLASH_ON_CHROME))
-            print '<!-- Includes CSS that does not exists as a workaround of flash bug of chrome -->' . "\n" . '<link rel="stylesheet" type="text/css" href="filethatdoesnotexiststosolvechromeflashbug">' . "\n";
+        if (!empty($conf->global->MAIN_FIX_FLASH_ON_CHROME)) {
+                    print '<!-- Includes CSS that does not exists as a workaround of flash bug of chrome -->' . "\n" . '<link rel="stylesheet" type="text/css" href="filethatdoesnotexiststosolvechromeflashbug">' . "\n";
+        }
 
         // CSS forced by modules (relative url starting with /)
         if (!empty($conf->modules_parts['css'])) {
@@ -1297,13 +1368,15 @@ 
             foreach ($arraycss as $modcss => $filescss) {
                 $filescss = (array) $filescss; // To be sure filecss is an array
                 foreach ($filescss as $cssfile) {
-                    if (empty($cssfile))
-                        dol_syslog("Warning: module " . $modcss . " declared a css path file into its descriptor that is empty.", LOG_WARNING);
+                    if (empty($cssfile)) {
+                                            dol_syslog("Warning: module " . $modcss . " declared a css path file into its descriptor that is empty.", LOG_WARNING);
+                    }
                     // cssfile is a relative path
                     print '<!-- Includes CSS added by module ' . $modcss . ' -->' . "\n" . '<link rel="stylesheet" type="text/css" href="' . dol_buildpath($cssfile, 1);
                     // We add params only if page is not static, because some web server setup does not return content type text/css if url has parameters, so browser cache is not used.
-                    if (!preg_match('/\.css$/i', $cssfile))
-                        print $themeparam;
+                    if (!preg_match('/\.css$/i', $cssfile)) {
+                                            print $themeparam;
+                    }
                     print '">' . "\n";
                 }
             }
@@ -1313,8 +1386,9 @@ 
             foreach ($arrayofcss as $cssfile) {
                 print '<!-- Includes CSS added by page -->' . "\n" . '<link rel="stylesheet" type="text/css" title="default" href="' . dol_buildpath($cssfile, 1);
                 // We add params only if page is not static, because some web server setup does not return content type text/css if url has parameters and browser cache is not used.
-                if (!preg_match('/\.css$/i', $cssfile))
-                    print $themeparam;
+                if (!preg_match('/\.css$/i', $cssfile)) {
+                                    print $themeparam;
+                }
                 print '">' . "\n";
             }
         }
@@ -1418,10 +1492,12 @@ 
             // Browser notifications
             if (!defined('DISABLE_BROWSER_NOTIF')) {
                 $enablebrowsernotif = false;
-                if (!empty($conf->agenda->enabled) && !empty($conf->global->AGENDA_REMINDER_BROWSER))
-                    $enablebrowsernotif = true;
-                if ($conf->browser->layout == 'phone')
-                    $enablebrowsernotif = false;
+                if (!empty($conf->agenda->enabled) && !empty($conf->global->AGENDA_REMINDER_BROWSER)) {
+                                    $enablebrowsernotif = true;
+                }
+                if ($conf->browser->layout == 'phone') {
+                                    $enablebrowsernotif = false;
+                }
                 if ($enablebrowsernotif) {
                     print '<!-- Includes JS of Dolibarr (brwoser layout = ' . $conf->browser->layout . ')-->' . "\n";
                     //print '<script type="text/javascript" src="' . DOL_BASE_URI . '/core/js/lib_notification.js.php' . ($ext ? '?' . $ext : '') . '"></script>' . "\n";
@@ -1458,10 +1534,12 @@ 
             }
         }
 
-        if (!empty($head))
-            print $head . "\n";
-        if (!empty($conf->global->MAIN_HTML_HEADER))
-            print $conf->global->MAIN_HTML_HEADER . "\n";
+        if (!empty($head)) {
+                    print $head . "\n";
+        }
+        if (!empty($conf->global->MAIN_HTML_HEADER)) {
+                    print $conf->global->MAIN_HTML_HEADER . "\n";
+        }
 
         print "<!-- Alixar debugBar header -->";
         print Debug::getRenderHeader(); // Includes Alixar debugBar header
@@ -1526,15 +1604,20 @@ 
         if (!empty($conf->global->MAIN_APPLICATION_TITLE)) {
             $appli = $conf->global->MAIN_APPLICATION_TITLE;
             if (preg_match('/\d\.\d/', $appli)) {
-                if (!preg_match('/' . preg_quote(DOL_VERSION) . '/', $appli))
-                    $appli .= " (" . DOL_VERSION . ")"; // If new title contains a version that is different than core
-            } else
-                $appli .= " " . DOL_VERSION;
-        } else
-            $appli .= " " . DOL_VERSION;
+                if (!preg_match('/' . preg_quote(DOL_VERSION) . '/', $appli)) {
+                                    $appli .= " (" . DOL_VERSION . ")";
+                }
+                // If new title contains a version that is different than core
+            } else {
+                            $appli .= " " . DOL_VERSION;
+            }
+        } else {
+                    $appli .= " " . DOL_VERSION;
+        }
 
-        if (!empty($conf->global->MAIN_FEATURES_LEVEL))
-            $appli .= "<br>" . $langs->trans("LevelOfFeature") . ': ' . $conf->global->MAIN_FEATURES_LEVEL;
+        if (!empty($conf->global->MAIN_FEATURES_LEVEL)) {
+                    $appli .= "<br>" . $langs->trans("LevelOfFeature") . ': ' . $conf->global->MAIN_FEATURES_LEVEL;
+        }
 
         $logouttext = '';
         if (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) {
@@ -1572,12 +1655,15 @@ 
         $parameters = array();
         $result = $hookmanager->executeHooks('printTopRightMenu', $parameters);    // Note that $action and $object may have been modified by some hooks
         if (is_numeric($result)) {
-            if ($result == 0)
-                $toprightmenu .= $hookmanager->resPrint;  // add
-            else
-                $toprightmenu = $hookmanager->resPrint;      // replace
-        }
-        else {
+            if ($result == 0) {
+                            $toprightmenu .= $hookmanager->resPrint;
+            }
+            // add
+            else {
+                            $toprightmenu = $hookmanager->resPrint;
+            }
+            // replace
+        } else {
             $toprightmenu .= $result; // For backward compatibility
         }
 
@@ -1597,8 +1683,9 @@ 
 
             if (is_array($_POST)) {
                 foreach ($_POST as $key => $value) {
-                    if ($key !== 'action' && $key !== 'password' && !is_array($value))
-                        $qs .= '&' . $key . '=' . urlencode($value);
+                    if ($key !== 'action' && $key !== 'password' && !is_array($value)) {
+                                            $qs .= '&' . $key . '=' . urlencode($value);
+                    }
                 }
             }
             $qs .= (($qs && $morequerystring) ? '&' : '') . $morequerystring;
@@ -1617,8 +1704,9 @@ 
             $helppage = '';
             $mode = '';
 
-            if (empty($helppagename))
-                $helppagename = 'EN:User_documentation|FR:Documentation_utilisateur|ES:Documentación_usuarios';
+            if (empty($helppagename)) {
+                            $helppagename = 'EN:User_documentation|FR:Documentation_utilisateur|ES:Documentación_usuarios';
+            }
 
             // Get helpbaseurl, helppage and mode from helppagename and langs
             $arrayres = getHelpParamFor($helppagename, $langs);
@@ -1635,13 +1723,15 @@ 
                 }
                 $title = $appli . '<br>';
                 $title .= $langs->trans($mode == 'wiki' ? 'GoToWikiHelpPage' : 'GoToHelpPage');
-                if ($mode == 'wiki')
-                    $title .= ' - ' . $langs->trans("PageWiki") . ' &quot;' . dol_escape_htmltag(strtr($helppage, '_', ' ')) . '&quot;';
+                if ($mode == 'wiki') {
+                                    $title .= ' - ' . $langs->trans("PageWiki") . ' &quot;' . dol_escape_htmltag(strtr($helppage, '_', ' ')) . '&quot;';
+                }
                 $text .= '<a class="help" target="_blank" rel="noopener" href="';
-                if ($mode == 'wiki')
-                    $text .= sprintf($helpbaseurl, urlencode(html_entity_decode($helppage)));
-                else
-                    $text .= sprintf($helpbaseurl, $helppage);
+                if ($mode == 'wiki') {
+                                    $text .= sprintf($helpbaseurl, urlencode(html_entity_decode($helppage)));
+                } else {
+                                    $text .= sprintf($helpbaseurl, $helppage);
+                }
                 $text .= '">';
                 //$text.=img_picto('', 'helpdoc_top').' ';
                 $text .= '<span class="fa fa-question-circle atoplogin"></span>';
@@ -1668,9 +1758,10 @@ 
         print "<!-- End top horizontal menu -->\n\n";
     }
 
-    if (empty($conf->dol_hide_leftmenu) && empty($conf->dol_use_jmobile))
-        print '<!-- Begin div id-container --><div id="id-container" class="id-container' . ($morecss ? ' ' . $morecss : '') . '">';
-}
+    if (empty($conf->dol_hide_leftmenu) && empty($conf->dol_use_jmobile)) {
+            print '<!-- Begin div id-container --><div id="id-container" class="id-container' . ($morecss ? ' ' . $morecss : '') . '">';
+    }
+    }
 
 /**
  *  Show left menu bar
@@ -1694,8 +1785,9 @@ 
     $searchform = '';
     $bookmarks = '';
 
-    if (!empty($menu_array_before))
-        dol_syslog("Deprecated parameter menu_array_before was used when calling main::left_menu function. Menu entries of module should now be defined into module descriptor and not provided when calling left_menu.", LOG_WARNING);
+    if (!empty($menu_array_before)) {
+            dol_syslog("Deprecated parameter menu_array_before was used when calling main::left_menu function. Menu entries of module should now be defined into module descriptor and not provided when calling left_menu.", LOG_WARNING);
+    }
 
     if (empty($conf->dol_hide_leftmenu) && (!defined('NOREQUIREMENU') || !constant('NOREQUIREMENU'))) {
         // Instantiate hooks of thirdparty module
@@ -1703,8 +1795,10 @@ 
 
         print "\n" . '<!-- Begin side-nav id-left -->' . "\n" . '<div class="side-nav"><div id="id-left">' . "\n";
 
-        if ($conf->browser->layout == 'phone')
-            $conf->global->MAIN_USE_OLD_SEARCH_FORM = 1; // Select into select2 is awfull on smartphone. TODO Is this still true with select2 v4 ?
+        if ($conf->browser->layout == 'phone') {
+                    $conf->global->MAIN_USE_OLD_SEARCH_FORM = 1;
+        }
+        // Select into select2 is awfull on smartphone. TODO Is this still true with select2 v4 ?
 
         print "\n";
 
@@ -1731,8 +1825,9 @@ 
         $reshook = $hookmanager->executeHooks('printSearchForm', $parameters);    // Note that $action and $object may have been modified by some hooks
         if (empty($reshook)) {
             $searchform .= $hookmanager->resPrint;
-        } else
-            $searchform = $hookmanager->resPrint;
+        } else {
+                    $searchform = $hookmanager->resPrint;
+        }
 
         // Force special value for $searchform
         if (!empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER) || empty($conf->use_javascript_ajax)) {
@@ -1776,38 +1871,49 @@ 
         if (empty($conf->global->MAIN_HIDE_VERSION)) {    // Version is already on help picto and on login page.
             $doliurl = 'https://www.dolibarr.org';
             //local communities
-            if (preg_match('/fr/i', $langs->defaultlang))
-                $doliurl = 'https://www.dolibarr.fr';
-            if (preg_match('/es/i', $langs->defaultlang))
-                $doliurl = 'https://www.dolibarr.es';
-            if (preg_match('/de/i', $langs->defaultlang))
-                $doliurl = 'https://www.dolibarr.de';
-            if (preg_match('/it/i', $langs->defaultlang))
-                $doliurl = 'https://www.dolibarr.it';
-            if (preg_match('/gr/i', $langs->defaultlang))
-                $doliurl = 'https://www.dolibarr.gr';
+            if (preg_match('/fr/i', $langs->defaultlang)) {
+                            $doliurl = 'https://www.dolibarr.fr';
+            }
+            if (preg_match('/es/i', $langs->defaultlang)) {
+                            $doliurl = 'https://www.dolibarr.es';
+            }
+            if (preg_match('/de/i', $langs->defaultlang)) {
+                            $doliurl = 'https://www.dolibarr.de';
+            }
+            if (preg_match('/it/i', $langs->defaultlang)) {
+                            $doliurl = 'https://www.dolibarr.it';
+            }
+            if (preg_match('/gr/i', $langs->defaultlang)) {
+                            $doliurl = 'https://www.dolibarr.gr';
+            }
 
             $appli = constant('DOL_APPLICATION_TITLE');
             if (!empty($conf->global->MAIN_APPLICATION_TITLE)) {
                 $appli = $conf->global->MAIN_APPLICATION_TITLE;
                 $doliurl = '';
                 if (preg_match('/\d\.\d/', $appli)) {
-                    if (!preg_match('/' . preg_quote(DOL_VERSION) . '/', $appli))
-                        $appli .= " (" . DOL_VERSION . ")"; // If new title contains a version that is different than core
-                } else
-                    $appli .= " " . DOL_VERSION;
-            } else
-                $appli .= " " . DOL_VERSION;
+                    if (!preg_match('/' . preg_quote(DOL_VERSION) . '/', $appli)) {
+                                            $appli .= " (" . DOL_VERSION . ")";
+                    }
+                    // If new title contains a version that is different than core
+                } else {
+                                    $appli .= " " . DOL_VERSION;
+                }
+            } else {
+                            $appli .= " " . DOL_VERSION;
+            }
             print '<div id="blockvmenuhelpapp" class="blockvmenuhelp">';
-            if ($doliurl)
-                print '<a class="help" target="_blank" rel="noopener" href="' . $doliurl . '">';
-            else
-                print '<span class="help">';
+            if ($doliurl) {
+                            print '<a class="help" target="_blank" rel="noopener" href="' . $doliurl . '">';
+            } else {
+                            print '<span class="help">';
+            }
             print $appli;
-            if ($doliurl)
-                print '</a>';
-            else
-                print '</span>';
+            if ($doliurl) {
+                            print '</a>';
+            } else {
+                            print '</span>';
+            }
             print '</div>' . "\n";
         }
 
@@ -1854,9 +1960,10 @@ 
     print "\n";
     print '<!-- Begin right area -->' . "\n";
 
-    if (empty($leftmenuwithoutmainarea))
-        main_area($title);
-}
+    if (empty($leftmenuwithoutmainarea)) {
+            main_area($title);
+    }
+    }
 
 /**
  *  Begin main area
@@ -1868,16 +1975,18 @@ 
 {
     global $conf, $langs;
 
-    if (empty($conf->dol_hide_leftmenu))
-        print '<div id="id-right">';
+    if (empty($conf->dol_hide_leftmenu)) {
+            print '<div id="id-right">';
+    }
 
     print "\n";
 
     print '<!-- Begin div class="fiche" -->' . "\n" . '<div class="fiche">' . "\n";
 
-    if (!empty($conf->global->MAIN_ONLY_LOGIN_ALLOWED))
-        print info_admin($langs->trans("WarningYouAreInMaintenanceMode", $conf->global->MAIN_ONLY_LOGIN_ALLOWED));
-}
+    if (!empty($conf->global->MAIN_ONLY_LOGIN_ALLOWED)) {
+            print info_admin($langs->trans("WarningYouAreInMaintenanceMode", $conf->global->MAIN_ONLY_LOGIN_ALLOWED));
+    }
+    }
 
 /**
  *  Return helpbaseurl, helppage and mode
@@ -1901,18 +2010,21 @@ 
         // If WIKI URL
         if (preg_match('/^es/i', $langs->defaultlang)) {
             $helpbaseurl = 'http://wiki.dolibarr.org/index.php/%s';
-            if (preg_match('/ES:([^|]+)/i', $helppagename, $reg))
-                $helppage = $reg[1];
+            if (preg_match('/ES:([^|]+)/i', $helppagename, $reg)) {
+                            $helppage = $reg[1];
+            }
         }
         if (preg_match('/^fr/i', $langs->defaultlang)) {
             $helpbaseurl = 'http://wiki.dolibarr.org/index.php/%s';
-            if (preg_match('/FR:([^|]+)/i', $helppagename, $reg))
-                $helppage = $reg[1];
+            if (preg_match('/FR:([^|]+)/i', $helppagename, $reg)) {
+                            $helppage = $reg[1];
+            }
         }
         if (empty($helppage)) { // If help page not already found
             $helpbaseurl = 'http://wiki.dolibarr.org/index.php/%s';
-            if (preg_match('/EN:([^|]+)/i', $helppagename, $reg))
-                $helppage = $reg[1];
+            if (preg_match('/EN:([^|]+)/i', $helppagename, $reg)) {
+                            $helppage = $reg[1];
+            }
         }
         $mode = 'wiki';
     }
@@ -1943,8 +2055,9 @@ 
     $ret .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';
     $ret .= '<input type="hidden" name="mode" value="search">';
     $ret .= '<input type="hidden" name="savelogin" value="' . dol_escape_htmltag($user->login) . '">';
-    if ($showtitlebefore)
-        $ret .= $title . ' ';
+    if ($showtitlebefore) {
+            $ret .= $title . ' ';
+    }
     $ret .= '<input type="text" class="flat ' . $htmlmorecss . '"';
     $ret .= ' style="text-indent: 22px; background-image: url(\'' . $img . '\'); background-repeat: no-repeat; background-position: 3px;"';
     $ret .= ($accesskey ? ' accesskey="' . $accesskey . '"' : '');
@@ -1987,10 +2100,12 @@ 
             foreach ($user->lastsearch_values_tmp as $key => $val) {
                 unset($_SESSION['lastsearch_values_tmp_' . $key]);   // Clean array to rebuild it just after
                 if (count($val) && empty($_POST['button_removefilter'])) { // If there is search criteria to save and we did not click on 'Clear filter' button
-                    if (empty($val['sortfield']))
-                        unset($val['sortfield']);
-                    if (empty($val['sortorder']))
-                        unset($val['sortorder']);
+                    if (empty($val['sortfield'])) {
+                                            unset($val['sortfield']);
+                    }
+                    if (empty($val['sortorder'])) {
+                                            unset($val['sortorder']);
+                    }
                     dol_syslog('Save lastsearch_values_tmp_' . $key . '=' . json_encode($val, 0) . " (systematic recording of last search criterias)");
                     $_SESSION['lastsearch_values_tmp_' . $key] = json_encode($val);
                     unset($_SESSION['lastsearch_values_' . $key]);
@@ -2001,8 +2116,9 @@ 
 
         $relativepathstring = $_SERVER["PHP_SELF"];
         // Clean $relativepathstring
-        if (constant('DOL_BASE_URI'))
-            $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);
+        if (constant('DOL_BASE_URI')) {
+                    $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);
+        }
         $relativepathstring = preg_replace('/^\//', '', $relativepathstring);
         $relativepathstring = preg_replace('/^custom\//', '', $relativepathstring);
         if (preg_match('/list\.php$/', $relativepathstring)) {
@@ -2010,12 +2126,15 @@ 
             unset($_SESSION['lastsearch_page_tmp_' . $relativepathstring]);
             unset($_SESSION['lastsearch_limit_tmp_' . $relativepathstring]);
 
-            if (!empty($contextpage))
-                $_SESSION['lastsearch_contextpage_tmp_' . $relativepathstring] = $contextpage;
-            if (!empty($page) && $page > 1)
-                $_SESSION['lastsearch_page_tmp_' . $relativepathstring] = $page;
-            if (!empty($limit) && $limit != $conf->limit)
-                $_SESSION['lastsearch_limit_tmp_' . $relativepathstring] = $limit;
+            if (!empty($contextpage)) {
+                            $_SESSION['lastsearch_contextpage_tmp_' . $relativepathstring] = $contextpage;
+            }
+            if (!empty($page) && $page > 1) {
+                            $_SESSION['lastsearch_page_tmp_' . $relativepathstring] = $page;
+            }
+            if (!empty($limit) && $limit != $conf->limit) {
+                            $_SESSION['lastsearch_limit_tmp_' . $relativepathstring] = $limit;
+            }
 
             unset($_SESSION['lastsearch_contextpage_' . $relativepathstring]);
             unset($_SESSION['lastsearch_page_' . $relativepathstring]);
@@ -2042,20 +2161,26 @@ 
 
         print '</div> <!-- End div class="fiche" -->' . "\n"; // End div fiche
 
-        if (empty($conf->dol_hide_leftmenu))
-            print '</div> <!-- End div id-right -->' . "\n"; // End div id-right
+        if (empty($conf->dol_hide_leftmenu)) {
+                    print '</div> <!-- End div id-right -->' . "\n";
+        }
+        // End div id-right
 
-        if (empty($conf->dol_hide_leftmenu) && empty($conf->dol_use_jmobile))
-            print '</div> <!-- End div id-container -->' . "\n"; // End div container
+        if (empty($conf->dol_hide_leftmenu) && empty($conf->dol_use_jmobile)) {
+                    print '</div> <!-- End div id-container -->' . "\n";
+        }
+        // End div container
 
         print "\n";
-        if ($comment)
-            print '<!-- ' . $comment . ' -->' . "\n";
+        if ($comment) {
+                    print '<!-- ' . $comment . ' -->' . "\n";
+        }
 
         printCommonFooter($zone);
 
-        if (!empty($delayedhtmlcontent))
-            print $delayedhtmlcontent;
+        if (!empty($delayedhtmlcontent)) {
+                    print $delayedhtmlcontent;
+        }
 
         if (!empty($conf->use_javascript_ajax)) {
             print "\n" . '<!-- Includes JS Footer of Dolibarr -->' . "\n";

dolibarr/htdocs/install/inc.php

Braces +103 added lines, -66 removed lines

@@ -31,8 +31,9 @@ 
  * 	\brief      File that define environment for support pages
  */
 // Just to define version DOL_VERSION
-if (!defined('DOL_INC_FOR_VERSION_ERROR'))
+if (!defined('DOL_INC_FOR_VERSION_ERROR')) {
     define('DOL_INC_FOR_VERSION_ERROR', '1');
+}
 require_once DOL_BASE_PATH . '/filefunc.inc.php';
 
 require_once DOL_BASE_PATH . '/core/class/translate.class.php';
@@ -141,8 +142,9 @@ 
 $conf->global->MAIN_ENABLE_LOG_TO_HTML = 1;
 
 // Define prefix
-if (!isset($dolibarr_main_db_prefix) || !$dolibarr_main_db_prefix)
+if (!isset($dolibarr_main_db_prefix) || !$dolibarr_main_db_prefix) {
     $dolibarr_main_db_prefix = 'llx_';
+}
 define('MAIN_DB_PREFIX', (isset($dolibarr_main_db_prefix) ? $dolibarr_main_db_prefix : ''));
 
 define('DOL_CLASS_PATH', 'class/');                             // Filsystem path to class dir
@@ -150,23 +152,31 @@ 
 define('DOL_MAIN_URL_ROOT', (isset($dolibarr_main_url_root) ? $dolibarr_main_url_root : ''));           // URL relative root
 $uri = preg_replace('/^http(s?):\/\//i', '', constant('DOL_MAIN_URL_ROOT'));  // $uri contains url without http*
 $suburi = strstr($uri, '/');       // $suburi contains url without domain
-if ($suburi == '/')
-    $suburi = '';   // If $suburi is /, it is now ''
+if ($suburi == '/') {
+    $suburi = '';
+}
+// If $suburi is /, it is now ''
 define('DOL_URL_ROOT', $suburi);    // URL relative root ('', '/dolibarr', ...)
 
 
-if (empty($conf->file->character_set_client))
+if (empty($conf->file->character_set_client)) {
     $conf->file->character_set_client = "utf-8";
-if (empty($conf->db->character_set))
+}
+if (empty($conf->db->character_set)) {
     $conf->db->character_set = 'utf8';
-if (empty($conf->db->dolibarr_main_db_collation))
+}
+if (empty($conf->db->dolibarr_main_db_collation)) {
     $conf->db->dolibarr_main_db_collation = 'utf8_unicode_ci';
-if (empty($conf->db->dolibarr_main_db_encryption))
+}
+if (empty($conf->db->dolibarr_main_db_encryption)) {
     $conf->db->dolibarr_main_db_encryption = 0;
-if (empty($conf->db->dolibarr_main_db_cryptkey))
+}
+if (empty($conf->db->dolibarr_main_db_cryptkey)) {
     $conf->db->dolibarr_main_db_cryptkey = '';
-if (empty($conf->db->user))
+}
+if (empty($conf->db->user)) {
     $conf->db->user = '';
+}
 
 // Define array of document root directories
 $conf->file->dol_document_root = array(DOL_DOCUMENT_ROOT);
@@ -223,19 +233,24 @@ 
 // Force usage of log file for install and upgrades
 $conf->syslog->enabled = 1;
 $conf->global->SYSLOG_LEVEL = constant('LOG_DEBUG');
-if (!defined('SYSLOG_HANDLERS'))
+if (!defined('SYSLOG_HANDLERS')) {
     define('SYSLOG_HANDLERS', '["mod_syslog_file"]');
+}
 if (!defined('SYSLOG_FILE')) { // To avoid warning on systems with constant already defined
-    if (@is_writable('/tmp'))
-        define('SYSLOG_FILE', '/tmp/dolibarr_install.log');
-    else if (!empty($_ENV["TMP"]) && @is_writable($_ENV["TMP"]))
-        define('SYSLOG_FILE', $_ENV["TMP"] . '/dolibarr_install.log');
-    else if (!empty($_ENV["TEMP"]) && @is_writable($_ENV["TEMP"]))
-        define('SYSLOG_FILE', $_ENV["TEMP"] . '/dolibarr_install.log');
-    else if (@is_writable('../../../../') && @file_exists('../../../../startdoliwamp.bat'))
-        define('SYSLOG_FILE', '../../../../dolibarr_install.log'); // For DoliWamp
-    else if (@is_writable('../../'))
-        define('SYSLOG_FILE', '../../dolibarr_install.log');    // For others
+    if (@is_writable('/tmp')) {
+            define('SYSLOG_FILE', '/tmp/dolibarr_install.log');
+    } else if (!empty($_ENV["TMP"]) && @is_writable($_ENV["TMP"])) {
+            define('SYSLOG_FILE', $_ENV["TMP"] . '/dolibarr_install.log');
+    } else if (!empty($_ENV["TEMP"]) && @is_writable($_ENV["TEMP"])) {
+            define('SYSLOG_FILE', $_ENV["TEMP"] . '/dolibarr_install.log');
+    } else if (@is_writable('../../../../') && @file_exists('../../../../startdoliwamp.bat')) {
+            define('SYSLOG_FILE', '../../../../dolibarr_install.log');
+    }
+    // For DoliWamp
+    else if (@is_writable('../../')) {
+            define('SYSLOG_FILE', '../../dolibarr_install.log');
+    }
+    // For others
 
 
 
@@ -248,10 +263,12 @@ 
         
 //print 'SYSLOG_FILE='.SYSLOG_FILE;exit;
 }
-if (defined('SYSLOG_FILE'))
+if (defined('SYSLOG_FILE')) {
     $conf->global->SYSLOG_FILE = constant('SYSLOG_FILE');
-if (!defined('SYSLOG_FILE_NO_ERROR'))
+}
+if (!defined('SYSLOG_FILE_NO_ERROR')) {
     define('SYSLOG_FILE_NO_ERROR', 1);
+}
 // We init log handler for install
 $handlers = array('mod_syslog_file');
 foreach ($handlers as $handler) {
@@ -266,9 +283,10 @@ 
         throw new Exception('Log handler does not extend LogHandlerInterface');
     }
 
-    if (empty($conf->loghandlers[$handler]))
-        $conf->loghandlers[$handler] = $loghandlerinstance;
-}
+    if (empty($conf->loghandlers[$handler])) {
+            $conf->loghandlers[$handler] = $loghandlerinstance;
+    }
+    }
 
 // Removed magic_quotes
 if (function_exists('get_magic_quotes_gpc')) { // magic_quotes_* removed in PHP 5.4
@@ -292,10 +310,11 @@ 
 
 // Defini objet langs
 $langs = new Translate('..', $conf);
-if (GETPOST('lang', 'aZ09'))
+if (GETPOST('lang', 'aZ09')) {
     $langs->setDefaultLang(GETPOST('lang', 'aZ09'));
-else
+} else {
     $langs->setDefaultLang('auto');
+}
 
 $bc[false] = ' class="bg1"';
 $bc[true] = ' class="bg2"';
@@ -318,8 +337,9 @@ 
     global $character_set_client;
 
     $return = include_once $dolibarr_main_document_root . '/core/class/conf.class.php';
-    if (!$return)
-        return -1;
+    if (!$return) {
+            return -1;
+    }
 
     $conf = new Conf();
     $conf->db->type = trim($dolibarr_main_db_type);
@@ -330,40 +350,51 @@ 
     $conf->db->pass = trim($dolibarr_main_db_pass);
 
     // Mysql driver support has been removed in favor of mysqli
-    if ($conf->db->type == 'mysql')
-        $conf->db->type = 'mysqli';
-    if (empty($character_set_client))
-        $character_set_client = "UTF-8";
+    if ($conf->db->type == 'mysql') {
+            $conf->db->type = 'mysqli';
+    }
+    if (empty($character_set_client)) {
+            $character_set_client = "UTF-8";
+    }
     $conf->file->character_set_client = strtoupper($character_set_client);
-    if (empty($dolibarr_main_db_character_set))
-        $dolibarr_main_db_character_set = ($conf->db->type == 'mysqli' ? 'utf8' : '');
+    if (empty($dolibarr_main_db_character_set)) {
+            $dolibarr_main_db_character_set = ($conf->db->type == 'mysqli' ? 'utf8' : '');
+    }
     $conf->db->character_set = $dolibarr_main_db_character_set;
-    if (empty($dolibarr_main_db_collation))
-        $dolibarr_main_db_collation = ($conf->db->type == 'mysqli' ? 'utf8_unicode_ci' : '');
+    if (empty($dolibarr_main_db_collation)) {
+            $dolibarr_main_db_collation = ($conf->db->type == 'mysqli' ? 'utf8_unicode_ci' : '');
+    }
     $conf->db->dolibarr_main_db_collation = $dolibarr_main_db_collation;
-    if (empty($dolibarr_main_db_encryption))
-        $dolibarr_main_db_encryption = 0;
+    if (empty($dolibarr_main_db_encryption)) {
+            $dolibarr_main_db_encryption = 0;
+    }
     $conf->db->dolibarr_main_db_encryption = $dolibarr_main_db_encryption;
-    if (empty($dolibarr_main_db_cryptkey))
-        $dolibarr_main_db_cryptkey = '';
+    if (empty($dolibarr_main_db_cryptkey)) {
+            $dolibarr_main_db_cryptkey = '';
+    }
     $conf->db->dolibarr_main_db_cryptkey = $dolibarr_main_db_cryptkey;
 
     // Force usage of log file for install and upgrades
     $conf->syslog->enabled = 1;
     $conf->global->SYSLOG_LEVEL = constant('LOG_DEBUG');
-    if (!defined('SYSLOG_HANDLERS'))
-        define('SYSLOG_HANDLERS', '["mod_syslog_file"]');
+    if (!defined('SYSLOG_HANDLERS')) {
+            define('SYSLOG_HANDLERS', '["mod_syslog_file"]');
+    }
     if (!defined('SYSLOG_FILE')) { // To avoid warning on systems with constant already defined
-        if (@is_writable('/tmp'))
-            define('SYSLOG_FILE', '/tmp/dolibarr_install.log');
-        else if (!empty($_ENV["TMP"]) && @is_writable($_ENV["TMP"]))
-            define('SYSLOG_FILE', $_ENV["TMP"] . '/dolibarr_install.log');
-        else if (!empty($_ENV["TEMP"]) && @is_writable($_ENV["TEMP"]))
-            define('SYSLOG_FILE', $_ENV["TEMP"] . '/dolibarr_install.log');
-        else if (@is_writable('../../../../') && @file_exists('../../../../startdoliwamp.bat'))
-            define('SYSLOG_FILE', '../../../../dolibarr_install.log'); // For DoliWamp
-        else if (@is_writable('../../'))
-            define('SYSLOG_FILE', '../../dolibarr_install.log');    // For others
+        if (@is_writable('/tmp')) {
+                    define('SYSLOG_FILE', '/tmp/dolibarr_install.log');
+        } else if (!empty($_ENV["TMP"]) && @is_writable($_ENV["TMP"])) {
+                    define('SYSLOG_FILE', $_ENV["TMP"] . '/dolibarr_install.log');
+        } else if (!empty($_ENV["TEMP"]) && @is_writable($_ENV["TEMP"])) {
+                    define('SYSLOG_FILE', $_ENV["TEMP"] . '/dolibarr_install.log');
+        } else if (@is_writable('../../../../') && @file_exists('../../../../startdoliwamp.bat')) {
+                    define('SYSLOG_FILE', '../../../../dolibarr_install.log');
+        }
+        // For DoliWamp
+        else if (@is_writable('../../')) {
+                    define('SYSLOG_FILE', '../../dolibarr_install.log');
+        }
+        // For others
 
 
 
@@ -376,10 +407,12 @@ 
             
 //print 'SYSLOG_FILE='.SYSLOG_FILE;exit;
     }
-    if (defined('SYSLOG_FILE'))
-        $conf->global->SYSLOG_FILE = constant('SYSLOG_FILE');
-    if (!defined('SYSLOG_FILE_NO_ERROR'))
-        define('SYSLOG_FILE_NO_ERROR', 1);
+    if (defined('SYSLOG_FILE')) {
+            $conf->global->SYSLOG_FILE = constant('SYSLOG_FILE');
+    }
+    if (!defined('SYSLOG_FILE_NO_ERROR')) {
+            define('SYSLOG_FILE_NO_ERROR', 1);
+    }
     // We init log handler for install
     $handlers = array('mod_syslog_file');
     foreach ($handlers as $handler) {
@@ -394,8 +427,9 @@ 
             throw new Exception('Log handler does not extend LogHandlerInterface');
         }
 
-        if (empty($conf->loghandlers[$handler]))
-            $conf->loghandlers[$handler] = $loghandlerinstance;
+        if (empty($conf->loghandlers[$handler])) {
+                    $conf->loghandlers[$handler] = $loghandlerinstance;
+        }
     }
 
     return 1;
@@ -517,11 +551,13 @@ 
         }
 
         print '<input type="submit" ' . ($nonext == '2' ? 'disabled="disabled" ' : '') . 'value="' . $langs->trans("NextStep") . ' ->"';
-        if ($jscheckfunction)
-            print ' onClick="return ' . $jscheckfunction . '();"';
+        if ($jscheckfunction) {
+                    print ' onClick="return ' . $jscheckfunction . '();"';
+        }
         print '></div>';
-        if ($withpleasewait)
-            print '<div style="visibility: hidden;" class="pleasewait" id="pleasewait"><br>' . $langs->trans("NextStepMightLastALongTime") . '<br><br><div class="blinkwait">' . $langs->trans("PleaseBePatient") . '</div></div>';
+        if ($withpleasewait) {
+                    print '<div style="visibility: hidden;" class="pleasewait" id="pleasewait"><br>' . $langs->trans("NextStepMightLastALongTime") . '<br><br><div class="blinkwait">' . $langs->trans("PleaseBePatient") . '</div></div>';
+        }
     }
     if ($setuplang) {
         print '<input type="hidden" name="selectlang" value="' . $setuplang . '">';
@@ -557,8 +593,9 @@ 
  */
 function dolibarr_install_syslog($message, $level = LOG_DEBUG)
 {
-    if (!defined('LOG_DEBUG'))
-        define('LOG_DEBUG', 6);
+    if (!defined('LOG_DEBUG')) {
+            define('LOG_DEBUG', 6);
+    }
     dol_syslog($message, $level);
 }