Test Failed
Push — main ( c8394f...8477f1 )
by Rafael
66:21
created
public/htdocs/api/class/api.class.php 2 patches
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         //$this->r->setSupportedFormats('jsonFormat');
73 73
     }
74 74
 
75
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
75
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
76 76
     /**
77 77
      * Check and convert a string depending on its type/name.
78 78
      *
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
      */
84 84
     protected function _checkValForAPI($field, $value, $object)
85 85
     {
86
-		// phpcs:enable
86
+        // phpcs:enable
87 87
         if (!is_array($value)) {
88 88
             // Sanitize the value using its type declared into ->fields of $object
89 89
             if (!empty($object->fields) && !empty($object->fields[$field]) && !empty($object->fields[$field]['type'])) {
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         }
128 128
     }
129 129
 
130
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
130
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
131 131
     /**
132 132
      * Filter properties that will be returned on object
133 133
      *
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     protected function _filterObjectProperties($object, $properties)
139 139
     {
140
-		// phpcs:enable
140
+        // phpcs:enable
141 141
         // If properties is empty, we return all properties
142 142
         if (empty($properties)) {
143 143
             return $object;
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
         return $object;
176 176
     }
177 177
 
178
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
178
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
179 179
     /**
180 180
      * Clean sensible object datas
181 181
      *
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
      */
185 185
     protected function _cleanObjectDatas($object)
186 186
     {
187
-		// phpcs:enable
187
+        // phpcs:enable
188 188
         // Remove $db object property for object
189 189
         unset($object->db);
190 190
         unset($object->isextrafieldmanaged);
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
356 356
         return $object;
357 357
     }
358 358
 
359
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
359
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
360 360
     /**
361 361
      * Check access by user to a given resource
362 362
      *
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
      */
371 371
     protected static function _checkAccessToResource($resource, $resource_id = 0, $dbtablename = '', $feature2 = '', $dbt_keyfield = 'fk_soc', $dbt_select = 'rowid')
372 372
     {
373
-		// phpcs:enable
373
+        // phpcs:enable
374 374
         // Features/modules to check
375 375
         $featuresarray = array($resource);
376 376
         if (preg_match('/&/', $resource)) {
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
         return checkUserAccessToObject(DolibarrApiAccess::$user, $featuresarray, $resource_id, $dbtablename, $feature2, $dbt_keyfield, $dbt_select);
388 388
     }
389 389
 
390
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
390
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
391 391
     /**
392 392
      * Return if a $sqlfilters parameter is valid
393 393
      * Function no more used. Kept for backward compatibility with old APIs of modules
@@ -398,13 +398,13 @@  discard block
 block discarded – undo
398 398
      */
399 399
     protected function _checkFilters($sqlfilters, &$error = '')
400 400
     {
401
-		// phpcs:enable
401
+        // phpcs:enable
402 402
         $firstandlastparenthesis = 0;
403 403
         return dolCheckFilters($sqlfilters, $error, $firstandlastparenthesis);
404 404
     }
405 405
 
406
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
407
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
406
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
407
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
408 408
     /**
409 409
      * Function to forge a SQL criteria from a Generic filter string.
410 410
      * Function no more used. Kept for backward compatibility with old APIs of modules
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -158,11 +158,11 @@
 block discarded – undo
158 158
         unset($object->barcode_type_code);
159 159
         unset($object->barcode_type_label);
160 160
 
161
-        unset($object->mode_reglement);     // We use mode_reglement_id now
162
-        unset($object->cond_reglement);     // We use cond_reglement_id now
163
-        unset($object->note);               // We use note_public or note_private now
164
-        unset($object->contact);            // We use contact_id now
165
-        unset($object->thirdparty);         // We use thirdparty_id or fk_soc or socid now
161
+        unset($object->mode_reglement); // We use mode_reglement_id now
162
+        unset($object->cond_reglement); // We use cond_reglement_id now
163
+        unset($object->note); // We use note_public or note_private now
164
+        unset($object->contact); // We use contact_id now
165
+        unset($object->thirdparty); // We use thirdparty_id or fk_soc or socid now
166 166
 
167 167
         unset($object->projet); // Should be fk_project
168 168
         unset($object->project); // Should be fk_project
Please login to merge, or discard this patch.
public/htdocs/api/class/api_login.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@
 block discarded – undo
126 126
         }
127 127
 
128 128
         include_once DOL_DOCUMENT_ROOT . '/core/lib/security2.lib.php';
129
-        $login = checkLoginPassEntity($login, $password, $entity, $authmode, 'api');        // Check credentials.
129
+        $login = checkLoginPassEntity($login, $password, $entity, $authmode, 'api'); // Check credentials.
130 130
         if ($login === '--bad-login-validity--') {
131 131
             $login = '';
132 132
         }
Please login to merge, or discard this patch.
public/htdocs/api/index.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     /**
98 98
      * @return Luracast\Restler\AutoLoader
99 99
      */
100
-    static function () {
100
+    static function() {
101 101
         $loader = Luracast\Restler\AutoLoader::instance();
102 102
         spl_autoload_register($loader);
103 103
         return $loader;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 // If MAIN_API_DEBUG is set to 1, we save logs into file "dolibarr_api.log"
179 179
 if (getDolGlobalString('MAIN_API_DEBUG')) {
180 180
     $r = $api->r;
181
-    $r->onCall(function () use ($r) {
181
+    $r->onCall(function() use ($r) {
182 182
         // Don't log Luracast Restler Explorer resources calls
183 183
         //if (!preg_match('/^explorer/', $r->url)) {
184 184
         //  'method'  => $api->r->requestMethod,
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
             }
362 362
         }
363 363
 
364
-        if (! $endpointisallowed) {
364
+        if (!$endpointisallowed) {
365 365
             dol_syslog('The API with endpoint /' . $classfile . ' is forbidden by config API_ENDPOINT_RULES', LOG_WARNING);
366 366
             print 'The API with endpoint /' . $classfile . ' is forbidden by config API_ENDPOINT_RULES';
367 367
             header('HTTP/1.1 501 API is forbidden by API_ENDPOINT_RULES');
Please login to merge, or discard this patch.
public/htdocs/variants/card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -286,7 +286,7 @@
 block discarded – undo
286 286
     if ($action != 'editline') {
287 287
         print '<div class="tabsAction">' . "\n";
288 288
         $parameters = array();
289
-        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook
289
+        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
290 290
         if ($reshook < 0) {
291 291
             setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
292 292
         }
Please login to merge, or discard this patch.
public/htdocs/variants/combinations.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -778,7 +778,7 @@
 block discarded – undo
778 778
         <div style="text-align: center">
779 779
         <input type="submit" name="create" <?php if (!is_array($productCombination2ValuePairs1)) {
780 780
             print ' disabled="disabled"';
781
-                                           } ?> value="<?php echo $action == 'add' ? $langs->trans('Create') : $langs->trans("Save") ?>" class="button button-save">
781
+                                            } ?> value="<?php echo $action == 'add' ? $langs->trans('Create') : $langs->trans("Save") ?>" class="button button-save">
782 782
         &nbsp;
783 783
         <input type="submit" name="cancel" value="<?php echo $langs->trans("Cancel"); ?>" class="button button-cancel">
784 784
         </div>
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,12 +30,12 @@
 block discarded – undo
30 30
 
31 31
 $langs->loadLangs(array("products", "other"));
32 32
 
33
-$id = GETPOSTINT('id');                             // ID of the parent Product
33
+$id = GETPOSTINT('id'); // ID of the parent Product
34 34
 $ref = GETPOST('ref', 'alpha');
35 35
 
36
-$combination_id = GETPOSTINT('combination_id');     // ID of the combination
36
+$combination_id = GETPOSTINT('combination_id'); // ID of the combination
37 37
 
38
-$reference = GETPOST('reference', 'alpha');         // Reference of the variant Product
38
+$reference = GETPOST('reference', 'alpha'); // Reference of the variant Product
39 39
 
40 40
 $weight_impact = GETPOSTFLOAT('weight_impact', 2);
41 41
 $price_impact_percent = (bool) GETPOST('price_impact_percent');
Please login to merge, or discard this patch.
public/htdocs/variants/list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
 $object->fields = dol_sort_array($object->fields, 'position');
145 145
 $arrayfields = dol_sort_array($arrayfields, 'position');
146
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
146
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
147 147
 
148 148
 $permissiontoread = $user->hasRight('variants', 'read');
149 149
 $permissiontoadd = $user->hasRight('variants', 'write');
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 //}
325 325
 // Add where from hooks
326 326
 $parameters = array();
327
-$reshook = $hookmanager->executeHooks('printFieldListGroupBy', $parameters, $object);    // Note that $action and $object may have been modified by hook
327
+$reshook = $hookmanager->executeHooks('printFieldListGroupBy', $parameters, $object); // Note that $action and $object may have been modified by hook
328 328
 $sql .= $hookmanager->resPrint;
329 329
 $sql = preg_replace("/,\s*$/", "", $sql);
330 330
 
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 }
514 514
 
515 515
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
516
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
516
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
517 517
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
518 518
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
519 519
 
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
617 617
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
618 618
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
619 619
     }
620
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
620
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
621 621
     if (!empty($arrayfields['t.' . $key]['checked'])) {
622 622
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
623 623
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/variants/class/ProductAttribute.class.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
         }
514 514
     }
515 515
 
516
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
516
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
517 517
     /**
518 518
      * Load array lines
519 519
      *
@@ -522,7 +522,7 @@  discard block
 block discarded – undo
522 522
      */
523 523
     public function fetch_lines($filters = '')
524 524
     {
525
-		// phpcs:enable
525
+        // phpcs:enable
526 526
         global $langs;
527 527
 
528 528
         $this->lines = array();
@@ -1242,7 +1242,7 @@  discard block
 block discarded – undo
1242 1242
         return $this->LibStatut(0, $mode);
1243 1243
     }
1244 1244
 
1245
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
1245
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
1246 1246
     /**
1247 1247
      * Return label of a status
1248 1248
      *
@@ -1252,7 +1252,7 @@  discard block
 block discarded – undo
1252 1252
      */
1253 1253
     public function LibStatut($status, $mode = 1)
1254 1254
     {
1255
-		// phpcs:enable
1255
+        // phpcs:enable
1256 1256
         return '';
1257 1257
     }
1258 1258
 
Please login to merge, or discard this patch.
public/htdocs/variants/class/ProductCombination.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -635,7 +635,7 @@
 block discarded – undo
635 635
              * @param mixed $v Feature information of a product.
636 636
              * @return bool
637 637
              */
638
-            static function ($v) {
638
+            static function($v) {
639 639
                 return !empty($v);
640 640
             }
641 641
         );
Please login to merge, or discard this patch.
public/htdocs/imports/emptyexample.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,8 +101,8 @@
 block discarded – undo
101 101
 
102 102
 
103 103
 // List of targets fields
104
-$headerlinefields = array();    // Array of fields (label to show)
105
-$contentlinevalues = array();   // Array of example values
104
+$headerlinefields = array(); // Array of fields (label to show)
105
+$contentlinevalues = array(); // Array of example values
106 106
 $i = 0;
107 107
 foreach ($fieldstarget as $code => $label) {
108 108
     $withoutstar = preg_replace('/\*/', '', $fieldstarget[$code]);
Please login to merge, or discard this patch.