Passed
Push — master ( 49af33...3cffbe )
by Alxarafe
21:21
created
dolibarr/htdocs/core/class/smtps.class.php 1 patch
Spacing   +218 added lines, -218 removed lines patch added patch discarded remove patch
@@ -117,10 +117,10 @@  discard block
 block discarded – undo
117 117
 	/**
118 118
 	 * Message Sensitivity
119 119
 	 */
120
-	var $_arySensitivity = array ( false,
120
+	var $_arySensitivity = array(false,
121 121
                                   'Personal',
122 122
                                   'Private',
123
-                                  'Company Confidential' );
123
+                                  'Company Confidential');
124 124
 
125 125
 	/**
126 126
 	 * Message Sensitivity
@@ -131,12 +131,12 @@  discard block
 block discarded – undo
131 131
 	/**
132 132
 	 * Message Priority
133 133
 	 */
134
-	var $_aryPriority = array ( 'Bulk',
134
+	var $_aryPriority = array('Bulk',
135 135
                                 'Highest',
136 136
                                 'High',
137 137
                                 'Normal',
138 138
                                 'Low',
139
-                                'Lowest' );
139
+                                'Lowest');
140 140
 
141 141
 	/**
142 142
 	 * Content-Transfer-Encoding
@@ -147,13 +147,13 @@  discard block
 block discarded – undo
147 147
 	/**
148 148
 	 * Content-Transfer-Encoding
149 149
 	 */
150
-	var $_smtpsTransEncodeTypes = array( '7bit',               // Simple 7-bit ASCII
151
-                                         '8bit',               // 8-bit coding with line termination characters
152
-                                         'base64',             // 3 octets encoded into 4 sextets with offset
153
-                                         'binary',             // Arbitrary binary stream
154
-                                         'mac-binhex40',       // Macintosh binary to hex encoding
155
-                                         'quoted-printable',   // Mostly 7-bit, with 8-bit characters encoded as "=HH"
156
-                                         'uuencode' );         // UUENCODE encoding
150
+	var $_smtpsTransEncodeTypes = array('7bit', // Simple 7-bit ASCII
151
+                                         '8bit', // 8-bit coding with line termination characters
152
+                                         'base64', // 3 octets encoded into 4 sextets with offset
153
+                                         'binary', // Arbitrary binary stream
154
+                                         'mac-binhex40', // Macintosh binary to hex encoding
155
+                                         'quoted-printable', // Mostly 7-bit, with 8-bit characters encoded as "=HH"
156
+                                         'uuencode'); // UUENCODE encoding
157 157
 
158 158
 	/**
159 159
 	 * Content-Transfer-Encoding
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
      */
301 301
 	function setErrorsTo($_strErrorsTo)
302 302
 	{
303
-		if ( $_strErrorsTo )
303
+		if ($_strErrorsTo)
304 304
 		$this->_errorsTo = $this->_strip_email($_strErrorsTo);
305 305
 	}
306 306
 
@@ -310,11 +310,11 @@  discard block
 block discarded – undo
310 310
      * @param	boolean		$_part		Variant
311 311
      * @return	string					Errors to
312 312
      */
313
-	function getErrorsTo($_part = true )
313
+	function getErrorsTo($_part = true)
314 314
 	{
315 315
 		$_retValue = '';
316 316
 
317
-		if ( $_part === true )
317
+		if ($_part === true)
318 318
 		$_retValue = $this->_errorsTo;
319 319
 		else
320 320
 		$_retValue = $this->_errorsTo[$_part];
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 	 * @param	boolean		$_vDebug		Value for debug
329 329
 	 * @return 	void
330 330
 	 */
331
-	function setDebug($_vDebug = false )
331
+	function setDebug($_vDebug = false)
332 332
 	{
333 333
 		$this->_debug = $_vDebug;
334 334
 	}
@@ -359,29 +359,29 @@  discard block
 block discarded – undo
359 359
 		// We have to make sure the HOST given is valid
360 360
 		// This is done here because '@fsockopen' will not give me this
361 361
 		// information if it failes to connect because it can't find the HOST
362
-		$host=$this->getHost();
363
-		$usetls = preg_match('@tls://@i',$host);
362
+		$host = $this->getHost();
363
+		$usetls = preg_match('@tls://@i', $host);
364 364
 
365
-		$host=preg_replace('@tcp://@i','',$host);	// Remove prefix
366
-		$host=preg_replace('@ssl://@i','',$host);	// Remove prefix
367
-		$host=preg_replace('@tls://@i','',$host);	// Remove prefix
365
+		$host = preg_replace('@tcp://@i', '', $host); // Remove prefix
366
+		$host = preg_replace('@ssl://@i', '', $host); // Remove prefix
367
+		$host = preg_replace('@tls://@i', '', $host); // Remove prefix
368 368
 
369 369
 		// @CHANGE LDR
370 370
 		include_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
371 371
 
372
-		if ( (! is_ip($host)) && ((gethostbyname($host)) == $host))
372
+		if ((!is_ip($host)) && ((gethostbyname($host)) == $host))
373 373
 		{
374
-			$this->_setErr(99, $host . ' is either offline or is an invalid host name.');
374
+			$this->_setErr(99, $host.' is either offline or is an invalid host name.');
375 375
 			$_retVal = false;
376 376
 		}
377 377
 		else
378 378
 		{
379 379
 			//See if we can connect to the SMTP server
380 380
 			if ($this->socket = @fsockopen(
381
-    			preg_replace('@tls://@i','',$this->getHost()),       // Host to 'hit', IP or domain
382
-    			$this->getPort(),       // which Port number to use
383
-    			$this->errno,           // actual system level error
384
-    			$this->errstr,          // and any text that goes with the error
381
+    			preg_replace('@tls://@i', '', $this->getHost()), // Host to 'hit', IP or domain
382
+    			$this->getPort(), // which Port number to use
383
+    			$this->errno, // actual system level error
384
+    			$this->errstr, // and any text that goes with the error
385 385
     			$this->_smtpTimeout
386 386
 			))  // timeout for reading/writing data over the socket
387 387
 			{
@@ -392,14 +392,14 @@  discard block
 block discarded – undo
392 392
 				if (function_exists('stream_set_timeout')) stream_set_timeout($this->socket, $this->_smtpTimeout, 0);
393 393
 
394 394
 				// Check response from Server
395
-				if ( $_retVal = $this->server_parse($this->socket, "220") )
395
+				if ($_retVal = $this->server_parse($this->socket, "220"))
396 396
 				$_retVal = $this->socket;
397 397
 			}
398 398
 			// This connection attempt failed.
399 399
 			else
400 400
 			{
401 401
 				// @CHANGE LDR
402
-				if (empty($this->errstr)) $this->errstr='Failed to connect with fsockopen host='.$this->getHost().' port='.$this->getPort();
402
+				if (empty($this->errstr)) $this->errstr = 'Failed to connect with fsockopen host='.$this->getHost().' port='.$this->getPort();
403 403
 				$this->_setErr($this->errno, $this->errstr);
404 404
 				$_retVal = false;
405 405
 			}
@@ -422,18 +422,18 @@  discard block
 block discarded – undo
422 422
 		// Send the RFC2554 specified EHLO.
423 423
 		// This improvment as provided by 'SirSir' to
424 424
 		// accomodate both SMTP AND ESMTP capable servers
425
-		$host=$this->getHost();
426
-		$usetls = preg_match('@tls://@i',$host);
425
+		$host = $this->getHost();
426
+		$usetls = preg_match('@tls://@i', $host);
427 427
 
428
-		$host=preg_replace('@tcp://@i','',$host);	// Remove prefix
429
-		$host=preg_replace('@ssl://@i','',$host);	// Remove prefix
430
-		$host=preg_replace('@tls://@i','',$host);	// Remove prefix
428
+		$host = preg_replace('@tcp://@i', '', $host); // Remove prefix
429
+		$host = preg_replace('@ssl://@i', '', $host); // Remove prefix
430
+		$host = preg_replace('@tls://@i', '', $host); // Remove prefix
431 431
 
432
-		if ($usetls) $host='tls://'.$host;
432
+		if ($usetls) $host = 'tls://'.$host;
433 433
 
434 434
 		$hosth = $host;
435 435
 
436
-		if (! empty($conf->global->MAIL_SMTP_USE_FROM_FOR_HELO))
436
+		if (!empty($conf->global->MAIL_SMTP_USE_FROM_FOR_HELO))
437 437
 		{
438 438
 			// If the from to is 'aaa <[email protected]>', we will keep 'ccc.com'
439 439
 			$hosth = $this->getFrom('addr');
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
 			$hosth = preg_replace('/.*@/', '', $hosth);
443 443
 		}
444 444
 
445
-		if ( $_retVal = $this->socket_send_str('EHLO ' . $hosth, '250') )
445
+		if ($_retVal = $this->socket_send_str('EHLO '.$hosth, '250'))
446 446
 		{
447 447
 			if ($usetls)
448 448
 			{
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 				// the answer with list of supported AUTH methods. They may differs between non STARTTLS and with STARTTLS.
494 494
 				if (!$_retVal = $this->socket_send_str('EHLO '.$host, '250'))
495 495
 				{
496
-					$this->_setErr(126, '"' . $host . '" does not support authenticated connections.');
496
+					$this->_setErr(126, '"'.$host.'" does not support authenticated connections.');
497 497
 					return $_retVal;
498 498
 				}
499 499
 			}
@@ -506,12 +506,12 @@  discard block
 block discarded – undo
506 506
 
507 507
 			// The error here just means the ID/password combo doesn't work.
508 508
 			// There is not a method to determine which is the problem, ID or password
509
-			if ( ! $_retVal = $this->socket_send_str(base64_encode($this->_smtpsPW), '235') )
509
+			if (!$_retVal = $this->socket_send_str(base64_encode($this->_smtpsPW), '235'))
510 510
 			$this->_setErr(130, 'Invalid Authentication Credentials.');
511 511
 		}
512 512
 		else
513 513
 		{
514
-			$this->_setErr(126, '"' . $host . '" does not support authenticated connections.');
514
+			$this->_setErr(126, '"'.$host.'" does not support authenticated connections.');
515 515
 		}
516 516
 
517 517
 		return $_retVal;
@@ -535,10 +535,10 @@  discard block
 block discarded – undo
535 535
 		$_retVal = false;
536 536
 
537 537
 		// Connect to Server
538
-		if ( $this->socket = $this->_server_connect() )
538
+		if ($this->socket = $this->_server_connect())
539 539
 		{
540 540
 			// If a User ID *and* a password is given, assume Authentication is desired
541
-			if( !empty($this->_smtpsID) && !empty($this->_smtpsPW) )
541
+			if (!empty($this->_smtpsID) && !empty($this->_smtpsPW))
542 542
 			{
543 543
 				// Send the RFC2554 specified EHLO.
544 544
 				$_retVal = $this->_server_authenticate();
@@ -548,16 +548,16 @@  discard block
 block discarded – undo
548 548
 			else
549 549
 			{
550 550
 				// Send the RFC821 specified HELO.
551
-				$host=$this->getHost();
552
-				$usetls = preg_match('@tls://@i',$host);
551
+				$host = $this->getHost();
552
+				$usetls = preg_match('@tls://@i', $host);
553 553
 
554
-				$host=preg_replace('@tcp://@i','',$host);	// Remove prefix
555
-				$host=preg_replace('@ssl://@i','',$host);	// Remove prefix
556
-				$host=preg_replace('@tls://@i','',$host);	// Remove prefix
554
+				$host = preg_replace('@tcp://@i', '', $host); // Remove prefix
555
+				$host = preg_replace('@ssl://@i', '', $host); // Remove prefix
556
+				$host = preg_replace('@tls://@i', '', $host); // Remove prefix
557 557
 
558 558
 				$hosth = $host;
559 559
 
560
-				if (! empty($conf->global->MAIL_SMTP_USE_FROM_FOR_HELO))
560
+				if (!empty($conf->global->MAIL_SMTP_USE_FROM_FOR_HELO))
561 561
 				{
562 562
 					// If the from to is 'aaa <[email protected]>', we will keep 'ccc.com'
563 563
 					$hosth = $this->getFrom('addr');
@@ -566,21 +566,21 @@  discard block
 block discarded – undo
566 566
 					$hosth = preg_replace('/.*@/', '', $hosth);
567 567
 				}
568 568
 
569
-				$_retVal = $this->socket_send_str('HELO ' . $hosth, '250');
569
+				$_retVal = $this->socket_send_str('HELO '.$hosth, '250');
570 570
 			}
571 571
 
572 572
 			// Well, did we get to the server?
573
-			if ( $_retVal )
573
+			if ($_retVal)
574 574
 			{
575 575
 				// From this point onward most server response codes should be 250
576 576
 				// Specify who the mail is from....
577 577
 				// This has to be the raw email address, strip the "name" off
578
-				$this->socket_send_str('MAIL FROM: ' . $this->getFrom('addr'), '250');
578
+				$this->socket_send_str('MAIL FROM: '.$this->getFrom('addr'), '250');
579 579
 
580 580
 				// 'RCPT TO:' must be given a single address, so this has to loop
581 581
 				// through the list of addresses, regardless of TO, CC or BCC
582 582
 				// and send it out "single file"
583
-				foreach ( $this->get_RCPT_list() as $_address )
583
+				foreach ($this->get_RCPT_list() as $_address)
584 584
 				{
585 585
 				    /* Note:
586 586
 				     * BCC email addresses must be listed in the RCPT TO command list,
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
 					 * mark the last address as "bad" and start the address loop over again.
597 597
 					 * If any address fails, the entire message fails.
598 598
 					 */
599
-					$this->socket_send_str('RCPT TO: <' . $_address . '>', '250');
599
+					$this->socket_send_str('RCPT TO: <'.$_address.'>', '250');
600 600
 				}
601 601
 
602 602
 				// Tell the server we are ready to start sending data
@@ -606,7 +606,7 @@  discard block
 block discarded – undo
606 606
 
607 607
 				// Now we are ready for the message...
608 608
 				// Ok, all the ingredients are mixed in let's cook this puppy...
609
-				$this->socket_send_str($this->getHeader().$this->getBodyContent() . "\r\n" . '.', '250');
609
+				$this->socket_send_str($this->getHeader().$this->getBodyContent()."\r\n".'.', '250');
610 610
 
611 611
 				// Now tell the server we are done and close the socket...
612 612
 				fputs($this->socket, 'QUIT');
@@ -656,13 +656,13 @@  discard block
 block discarded – undo
656 656
 		$_retVal = true;
657 657
 
658 658
 		// if we have a path...
659
-		if ( ! empty ($_strConfigPath) )
659
+		if (!empty ($_strConfigPath))
660 660
 		{
661 661
 			// If the path is not valid, this will NOT generate an error,
662 662
 			// it will simply return false.
663
-			if ( ! @include $_strConfigPath)
663
+			if (!@include $_strConfigPath)
664 664
 			{
665
-				$this->_setErr(110, '"' . $_strConfigPath . '" is not a valid path.');
665
+				$this->_setErr(110, '"'.$_strConfigPath.'" is not a valid path.');
666 666
 				$_retVal = false;
667 667
 			}
668 668
 		}
@@ -672,13 +672,13 @@  discard block
 block discarded – undo
672 672
 		{
673 673
 			// Set these properties ONLY if they are set in the php.ini file.
674 674
 			// Otherwise the default values will be used.
675
-			if ( $_host = ini_get('SMTPs') )
675
+			if ($_host = ini_get('SMTPs'))
676 676
 			$this->setHost($_host);
677 677
 
678
-			if ( $_port = ini_get('smtp_port') )
678
+			if ($_port = ini_get('smtp_port'))
679 679
 			$this->setPort($_port);
680 680
 
681
-			if ( $_from = ini_get('sendmail_from') )
681
+			if ($_from = ini_get('sendmail_from'))
682 682
 			$this->setFrom($_from);
683 683
 		}
684 684
 
@@ -697,8 +697,8 @@  discard block
 block discarded – undo
697 697
 	 */
698 698
 	function setTransportType($_type = 0)
699 699
 	{
700
-		if ( ( is_numeric($_type) ) &&
701
-		( ( $_type >= 0 ) && ( $_type <= 3 ) ) )
700
+		if ((is_numeric($_type)) &&
701
+		(($_type >= 0) && ($_type <= 3)))
702 702
 		$this->_transportType = $_type;
703 703
 	}
704 704
 
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
 	 */
741 741
 	function setHost($_strHost)
742 742
 	{
743
-		if ( $_strHost )
743
+		if ($_strHost)
744 744
 		$this->_smtpsHost = $_strHost;
745 745
 	}
746 746
 
@@ -765,8 +765,8 @@  discard block
 block discarded – undo
765 765
 	 */
766 766
 	function setPort($_intPort)
767 767
 	{
768
-		if ( ( is_numeric($_intPort) ) &&
769
-		( ( $_intPort >= 1 ) && ( $_intPort <= 65536 ) ) )
768
+		if ((is_numeric($_intPort)) &&
769
+		(($_intPort >= 1) && ($_intPort <= 65536)))
770 770
 		$this->_smtpsPort = $_intPort;
771 771
 	}
772 772
 
@@ -832,7 +832,7 @@  discard block
 block discarded – undo
832 832
 	 */
833 833
 	function setCharSet($_strCharSet)
834 834
 	{
835
-		if ( $_strCharSet )
835
+		if ($_strCharSet)
836 836
 		$this->_smtpsCharSet = $_strCharSet;
837 837
 	}
838 838
 
@@ -920,7 +920,7 @@  discard block
 block discarded – undo
920 920
 	 */
921 921
 	function setFrom($_strFrom)
922 922
 	{
923
-		if ( $_strFrom )
923
+		if ($_strFrom)
924 924
 		$this->_msgFrom = $this->_strip_email($_strFrom);
925 925
 	}
926 926
 
@@ -934,7 +934,7 @@  discard block
 block discarded – undo
934 934
 	{
935 935
 		$_retValue = '';
936 936
 
937
-		if ( $_part === true )
937
+		if ($_part === true)
938 938
 		$_retValue = $this->_msgFrom;
939 939
 		else
940 940
 		$_retValue = $this->_msgFrom[$_part];
@@ -950,7 +950,7 @@  discard block
 block discarded – undo
950 950
 	 */
951 951
 	function setReplyTo($_strReplyTo)
952 952
 	{
953
-	    if ( $_strReplyTo )
953
+	    if ($_strReplyTo)
954 954
 	        $this->_msgReplyTo = $this->_strip_email($_strReplyTo);
955 955
 	}
956 956
 
@@ -964,7 +964,7 @@  discard block
 block discarded – undo
964 964
 	{
965 965
 	    $_retValue = '';
966 966
 
967
-	    if ( $_part === true )
967
+	    if ($_part === true)
968 968
 	        $_retValue = $this->_msgReplyTo;
969 969
 	    else
970 970
 	        $_retValue = $this->_msgReplyTo[$_part];
@@ -990,13 +990,13 @@  discard block
 block discarded – undo
990 990
 		$aryHost = $this->_msgRecipients;
991 991
 
992 992
 		// Only run this if we have something
993
-		if ( !empty ($_addrList ))
993
+		if (!empty ($_addrList))
994 994
 		{
995 995
 			// $_addrList can be a STRING or an array
996
-			if ( is_string($_addrList) )
996
+			if (is_string($_addrList))
997 997
 			{
998 998
 				// This could be a COMMA delimited string
999
-				if ( strstr($_addrList, ',') )
999
+				if (strstr($_addrList, ','))
1000 1000
 				// "explode "list" into an array
1001 1001
 				$_addrList = explode(',', $_addrList);
1002 1002
 
@@ -1006,7 +1006,7 @@  discard block
 block discarded – undo
1006 1006
 			}
1007 1007
 
1008 1008
 			// take the array of addresses and split them further
1009
-			foreach ( $_addrList as $_strAddr )
1009
+			foreach ($_addrList as $_strAddr)
1010 1010
 			{
1011 1011
 				// Strip off the end '>'
1012 1012
 				$_strAddr = str_replace('>', '', $_strAddr);
@@ -1016,7 +1016,7 @@  discard block
 block discarded – undo
1016 1016
 				$_tmpaddr = explode('<', $_strAddr);
1017 1017
 
1018 1018
 				// We have a "Real Name" and eMail address
1019
-				if ( count($_tmpaddr) == 2 )
1019
+				if (count($_tmpaddr) == 2)
1020 1020
 				{
1021 1021
 					$_tmpHost = explode('@', $_tmpaddr[1]);
1022 1022
 					$_tmpaddr[0] = trim($_tmpaddr[0], ' ">');
@@ -1073,10 +1073,10 @@  discard block
 block discarded – undo
1073 1073
 		$_tmpAry = explode('<', $_strAddr);
1074 1074
 
1075 1075
 		// Do we have a "Real name"
1076
-		if ( count($_tmpAry) == 2 )
1076
+		if (count($_tmpAry) == 2)
1077 1077
 		{
1078 1078
 			// We may not really have a "Real Name"
1079
-			if ( $_tmpAry[0])
1079
+			if ($_tmpAry[0])
1080 1080
 			$_aryEmail['real'] = trim($_tmpAry[0], ' ">');
1081 1081
 
1082 1082
 			$_aryEmail['addr'] = $_tmpAry[1];
@@ -1085,10 +1085,10 @@  discard block
 block discarded – undo
1085 1085
 		$_aryEmail['addr'] = $_tmpAry[0];
1086 1086
 
1087 1087
 		// Pull User Name and Host.tld apart
1088
-		list($_aryEmail['user'], $_aryEmail['host'] ) = explode('@', $_aryEmail['addr']);
1088
+		list($_aryEmail['user'], $_aryEmail['host']) = explode('@', $_aryEmail['addr']);
1089 1089
 
1090 1090
 		// Put the brackets back around the address
1091
-		$_aryEmail['addr'] = '<' . $_aryEmail['addr'] . '>';
1091
+		$_aryEmail['addr'] = '<'.$_aryEmail['addr'].'>';
1092 1092
 
1093 1093
 		return $_aryEmail;
1094 1094
 	}
@@ -1107,17 +1107,17 @@  discard block
 block discarded – undo
1107 1107
 		/**
1108 1108
 		 * An array of bares addresses for use with 'RCPT TO:'
1109 1109
 		 */
1110
-		$_RCPT_list=array();
1110
+		$_RCPT_list = array();
1111 1111
 
1112 1112
 		// walk down Recipients array and pull just email addresses
1113
-		foreach ( $this->_msgRecipients as $_host => $_list )
1113
+		foreach ($this->_msgRecipients as $_host => $_list)
1114 1114
 		{
1115
-			foreach ( $_list as $_subList )
1115
+			foreach ($_list as $_subList)
1116 1116
 			{
1117
-				foreach ( $_subList as $_name => $_addr )
1117
+				foreach ($_subList as $_name => $_addr)
1118 1118
 				{
1119 1119
 					// build RCPT list
1120
-					$_RCPT_list[] = $_name . '@' . $_host;
1120
+					$_RCPT_list[] = $_name.'@'.$_host;
1121 1121
 				}
1122 1122
 			}
1123 1123
 		}
@@ -1136,27 +1136,27 @@  discard block
 block discarded – undo
1136 1136
 	{
1137 1137
         // phpcs:enable
1138 1138
 		// We need to know which address segment to pull
1139
-		if ( $_which )
1139
+		if ($_which)
1140 1140
 		{
1141 1141
 			// Make sure we have addresses to process
1142
-			if ( $this->_msgRecipients )
1142
+			if ($this->_msgRecipients)
1143 1143
 			{
1144
-				$_RCPT_list=array();
1144
+				$_RCPT_list = array();
1145 1145
 				// walk down Recipients array and pull just email addresses
1146
-				foreach ( $this->_msgRecipients as $_host => $_list )
1146
+				foreach ($this->_msgRecipients as $_host => $_list)
1147 1147
 				{
1148
-					if ( $this->_msgRecipients[$_host][$_which] )
1148
+					if ($this->_msgRecipients[$_host][$_which])
1149 1149
 					{
1150
-						foreach ( $this->_msgRecipients[$_host][$_which] as $_addr => $_realName )
1150
+						foreach ($this->_msgRecipients[$_host][$_which] as $_addr => $_realName)
1151 1151
 						{
1152
-							if ( $_realName )	// @CHANGE LDR
1152
+							if ($_realName)	// @CHANGE LDR
1153 1153
 							{
1154
-								$_realName = '"' . $_realName . '"';
1155
-								$_RCPT_list[] = $_realName . ' <' . $_addr . '@' . $_host . '>';
1154
+								$_realName = '"'.$_realName.'"';
1155
+								$_RCPT_list[] = $_realName.' <'.$_addr.'@'.$_host.'>';
1156 1156
 							}
1157 1157
 							else
1158 1158
 							{
1159
-								$_RCPT_list[] = $_addr . '@' . $_host;
1159
+								$_RCPT_list[] = $_addr.'@'.$_host;
1160 1160
 							}
1161 1161
 						}
1162 1162
 					}
@@ -1185,7 +1185,7 @@  discard block
 block discarded – undo
1185 1185
 	 */
1186 1186
 	function setTO($_addrTo)
1187 1187
 	{
1188
-		if ( $_addrTo )
1188
+		if ($_addrTo)
1189 1189
 		$this->_buildAddrList('to', $_addrTo);
1190 1190
 	}
1191 1191
 
@@ -1207,7 +1207,7 @@  discard block
 block discarded – undo
1207 1207
 	 */
1208 1208
 	function setCC($_strCC)
1209 1209
 	{
1210
-		if ( $_strCC )
1210
+		if ($_strCC)
1211 1211
 		$this->_buildAddrList('cc', $_strCC);
1212 1212
 	}
1213 1213
 
@@ -1229,7 +1229,7 @@  discard block
 block discarded – undo
1229 1229
 	 */
1230 1230
 	function setBCC($_strBCC)
1231 1231
 	{
1232
-		if ( $_strBCC )
1232
+		if ($_strBCC)
1233 1233
 		$this->_buildAddrList('bcc', $_strBCC);
1234 1234
 	}
1235 1235
 
@@ -1251,7 +1251,7 @@  discard block
 block discarded – undo
1251 1251
 	 */
1252 1252
 	function setSubject($_strSubject = '')
1253 1253
 	{
1254
-		if ( $_strSubject )
1254
+		if ($_strSubject)
1255 1255
 		$this->_msgSubject = $_strSubject;
1256 1256
 	}
1257 1257
 
@@ -1274,11 +1274,11 @@  discard block
 block discarded – undo
1274 1274
 	{
1275 1275
 		global $conf;
1276 1276
 
1277
-		$_header = 'From: '       . $this->getFrom('org') . "\r\n"
1278
-		. 'To: '         . $this->getTO()          . "\r\n";
1277
+		$_header = 'From: '.$this->getFrom('org')."\r\n"
1278
+		. 'To: '.$this->getTO()."\r\n";
1279 1279
 
1280
-		if ( $this->getCC() )
1281
-		$_header .= 'Cc: ' . $this->getCC()  . "\r\n";
1280
+		if ($this->getCC())
1281
+		$_header .= 'Cc: '.$this->getCC()."\r\n";
1282 1282
 
1283 1283
 		/* Note:
1284 1284
 		 * BCC email addresses must be listed in the RCPT TO command list,
@@ -1291,57 +1291,57 @@  discard block
 block discarded – undo
1291 1291
 		$_header .= 'Bcc: ' . $this->getBCC()  . "\r\n";
1292 1292
         */
1293 1293
 
1294
-		$host=$this->getHost();
1295
-		$usetls = preg_match('@tls://@i',$host);
1294
+		$host = $this->getHost();
1295
+		$usetls = preg_match('@tls://@i', $host);
1296 1296
 
1297
-		$host=preg_replace('@tcp://@i','',$host);	// Remove prefix
1298
-		$host=preg_replace('@ssl://@i','',$host);	// Remove prefix
1299
-		$host=preg_replace('@tls://@i','',$host);	// Remove prefix
1297
+		$host = preg_replace('@tcp://@i', '', $host); // Remove prefix
1298
+		$host = preg_replace('@ssl://@i', '', $host); // Remove prefix
1299
+		$host = preg_replace('@tls://@i', '', $host); // Remove prefix
1300 1300
 
1301
-		$host=dol_getprefix('email');
1301
+		$host = dol_getprefix('email');
1302 1302
 
1303 1303
 		//NOTE: Message-ID should probably contain the username of the user who sent the msg
1304
-		$_header .= 'Subject: '    . $this->getSubject()     . "\r\n";
1305
-		$_header .= 'Date: '       . date("r")               . "\r\n";
1304
+		$_header .= 'Subject: '.$this->getSubject()."\r\n";
1305
+		$_header .= 'Date: '.date("r")."\r\n";
1306 1306
 
1307 1307
 		$trackid = $this->getTrackId();
1308 1308
 		if ($trackid)
1309 1309
 		{
1310 1310
 			// References is kept in response and Message-ID is returned into In-Reply-To:
1311
-			$_header .= 'Message-ID: <' . time() . '.SMTPs-dolibarr-'.$trackid.'@' . $host . ">\r\n";
1312
-			$_header .= 'References: <' . time() . '.SMTPs-dolibarr-'.$trackid.'@' . $host . ">\r\n";
1313
-			$_header .= 'X-Dolibarr-TRACKID: ' . $trackid . '@' . $host . "\r\n";
1311
+			$_header .= 'Message-ID: <'.time().'.SMTPs-dolibarr-'.$trackid.'@'.$host.">\r\n";
1312
+			$_header .= 'References: <'.time().'.SMTPs-dolibarr-'.$trackid.'@'.$host.">\r\n";
1313
+			$_header .= 'X-Dolibarr-TRACKID: '.$trackid.'@'.$host."\r\n";
1314 1314
 		}
1315 1315
 		else
1316 1316
 		{
1317
-			$_header .= 'Message-ID: <' . time() . '.SMTPs@' . $host . ">\r\n";
1317
+			$_header .= 'Message-ID: <'.time().'.SMTPs@'.$host.">\r\n";
1318 1318
 		}
1319
-		if (! empty($_SERVER['REMOTE_ADDR'])) $_header .= "X-RemoteAddr: " . $_SERVER['REMOTE_ADDR']. "\r\n";
1320
-		if ( $this->getMoreInHeader() )
1321
-		    $_header .= $this->getMoreInHeader();     // Value must include the "\r\n";
1319
+		if (!empty($_SERVER['REMOTE_ADDR'])) $_header .= "X-RemoteAddr: ".$_SERVER['REMOTE_ADDR']."\r\n";
1320
+		if ($this->getMoreInHeader())
1321
+		    $_header .= $this->getMoreInHeader(); // Value must include the "\r\n";
1322 1322
 
1323 1323
 		//$_header .=
1324 1324
 		//                 'Read-Receipt-To: '   . $this->getFrom( 'org' ) . "\r\n"
1325 1325
 		//                 'Return-Receipt-To: ' . $this->getFrom( 'org' ) . "\r\n";
1326 1326
 
1327
-		if ( $this->getSensitivity() )
1328
-		$_header .= 'Sensitivity: ' . $this->getSensitivity()  . "\r\n";
1327
+		if ($this->getSensitivity())
1328
+		$_header .= 'Sensitivity: '.$this->getSensitivity()."\r\n";
1329 1329
 
1330
-		if ( $this->_msgPriority != 3 )
1330
+		if ($this->_msgPriority != 3)
1331 1331
 		$_header .= $this->getPriority();
1332 1332
 
1333 1333
 
1334 1334
 		// @CHANGE LDR
1335
-		if ( $this->getDeliveryReceipt() )
1336
-		    $_header .= 'Disposition-Notification-To: '.$this->getFrom('addr') . "\r\n";
1337
-		if ( $this->getErrorsTo() )
1338
-		    $_header .= 'Errors-To: '.$this->getErrorsTo('addr') . "\r\n";
1339
-		if ( $this->getReplyTo() )
1340
-		    $_header .= "Reply-To: ".$this->getReplyTo('addr') ."\r\n";
1335
+		if ($this->getDeliveryReceipt())
1336
+		    $_header .= 'Disposition-Notification-To: '.$this->getFrom('addr')."\r\n";
1337
+		if ($this->getErrorsTo())
1338
+		    $_header .= 'Errors-To: '.$this->getErrorsTo('addr')."\r\n";
1339
+		if ($this->getReplyTo())
1340
+		    $_header .= "Reply-To: ".$this->getReplyTo('addr')."\r\n";
1341 1341
 
1342
-		$_header .= 'X-Mailer: Dolibarr version ' . DOL_VERSION .' (using SMTPs Mailer)' . "\r\n";
1343
-		$_header .= 'X-Dolibarr-Option: '.($conf->global->MAIN_MAIL_USE_MULTI_PART?'MAIN_MAIL_USE_MULTI_PART':'No MAIN_MAIL_USE_MULTI_PART') . "\r\n";
1344
-		$_header .= 'Mime-Version: 1.0' . "\r\n";
1342
+		$_header .= 'X-Mailer: Dolibarr version '.DOL_VERSION.' (using SMTPs Mailer)'."\r\n";
1343
+		$_header .= 'X-Dolibarr-Option: '.($conf->global->MAIN_MAIL_USE_MULTI_PART ? 'MAIN_MAIL_USE_MULTI_PART' : 'No MAIN_MAIL_USE_MULTI_PART')."\r\n";
1344
+		$_header .= 'Mime-Version: 1.0'."\r\n";
1345 1345
 
1346 1346
 
1347 1347
 		return $_header;
@@ -1358,7 +1358,7 @@  discard block
 block discarded – undo
1358 1358
 	{
1359 1359
 		//if ( $strContent )
1360 1360
 		//{
1361
-		if ( $strType == 'html' )
1361
+		if ($strType == 'html')
1362 1362
 		$strMimeType = 'text/html';
1363 1363
 		else
1364 1364
 		$strMimeType = 'text/plain';
@@ -1370,14 +1370,14 @@  discard block
 block discarded – undo
1370 1370
 		if ($strType == 'html')
1371 1371
 		{
1372 1372
 			// Similar code to forge a text from html is also in CMailFile.class.php
1373
-			$strContentAltText = preg_replace("/<br\s*[^>]*>/"," ", $strContent);
1373
+			$strContentAltText = preg_replace("/<br\s*[^>]*>/", " ", $strContent);
1374 1374
 			$strContentAltText = html_entity_decode(strip_tags($strContentAltText));
1375 1375
 			$strContentAltText = rtrim(wordwrap($strContentAltText, 75, "\r\n"));
1376 1376
 		}
1377 1377
 
1378 1378
 		// Make RFC2045 Compliant
1379 1379
 		//$strContent = rtrim(chunk_split($strContent));    // Function chunck_split seems ko if not used on a base64 content
1380
-		$strContent = rtrim(wordwrap($strContent, 75, "\r\n"));   // TODO Using this method creates unexpected line break on text/plain content.
1380
+		$strContent = rtrim(wordwrap($strContent, 75, "\r\n")); // TODO Using this method creates unexpected line break on text/plain content.
1381 1381
 
1382 1382
 		$this->_msgContent[$strType] = array();
1383 1383
 
@@ -1385,7 +1385,7 @@  discard block
 block discarded – undo
1385 1385
 		$this->_msgContent[$strType]['data']     = $strContent;
1386 1386
 		$this->_msgContent[$strType]['dataText'] = $strContentAltText;
1387 1387
 
1388
-		if ( $this->getMD5flag() )
1388
+		if ($this->getMD5flag())
1389 1389
 		$this->_msgContent[$strType]['md5']      = dol_hash($strContent, 3);
1390 1390
 		//}
1391 1391
 	}
@@ -1409,49 +1409,49 @@  discard block
 block discarded – undo
1409 1409
 		$keyCount = count($_types);
1410 1410
 
1411 1411
 		// If we have ZERO, we have a problem
1412
-		if( $keyCount === 0 )
1412
+		if ($keyCount === 0)
1413 1413
 		die ("Sorry, no content");
1414 1414
 
1415 1415
 		// If we have ONE, we can use the simple format
1416
-		else if( $keyCount === 1 && empty($conf->global->MAIN_MAIL_USE_MULTI_PART))
1416
+		else if ($keyCount === 1 && empty($conf->global->MAIN_MAIL_USE_MULTI_PART))
1417 1417
 		{
1418 1418
 			$_msgData = $this->_msgContent;
1419 1419
 			$_msgData = $_msgData[$_types[0]];
1420 1420
 
1421
-			$content = 'Content-Type: ' . $_msgData['mimeType'] . '; charset="' . $this->getCharSet() . '"' . "\r\n"
1422
-			. 'Content-Transfer-Encoding: ' . $this->getTransEncodeType() . "\r\n"
1423
-			. 'Content-Disposition: inline'  . "\r\n"
1424
-			. 'Content-Description: Message' . "\r\n";
1421
+			$content = 'Content-Type: '.$_msgData['mimeType'].'; charset="'.$this->getCharSet().'"'."\r\n"
1422
+			. 'Content-Transfer-Encoding: '.$this->getTransEncodeType()."\r\n"
1423
+			. 'Content-Disposition: inline'."\r\n"
1424
+			. 'Content-Description: Message'."\r\n";
1425 1425
 
1426
-			if ( $this->getMD5flag() )
1427
-			$content .= 'Content-MD5: ' . $_msgData['md5'] . "\r\n";
1426
+			if ($this->getMD5flag())
1427
+			$content .= 'Content-MD5: '.$_msgData['md5']."\r\n";
1428 1428
 
1429 1429
 			$content .= "\r\n"
1430
-			.  $_msgData['data'] . "\r\n";
1430
+			.  $_msgData['data']."\r\n";
1431 1431
 		}
1432 1432
 
1433 1433
 		// If we have more than ONE, we use the multi-part format
1434
-		else if( $keyCount >= 1 || ! empty($conf->global->MAIN_MAIL_USE_MULTI_PART))
1434
+		else if ($keyCount >= 1 || !empty($conf->global->MAIN_MAIL_USE_MULTI_PART))
1435 1435
 		{
1436 1436
 			// Since this is an actual multi-part message
1437 1437
 			// We need to define a content message Boundary
1438 1438
 			// NOTE: This was 'multipart/alternative', but Windows based mail servers have issues with this.
1439 1439
 
1440 1440
 			//$content = 'Content-Type: multipart/related; boundary="' . $this->_getBoundary() . '"'   . "\r\n";
1441
-			$content = 'Content-Type: multipart/mixed; boundary="' . $this->_getBoundary('mixed') . '"'   . "\r\n";
1441
+			$content = 'Content-Type: multipart/mixed; boundary="'.$this->_getBoundary('mixed').'"'."\r\n";
1442 1442
 
1443 1443
 			//                     . "\r\n"
1444 1444
 			//                     . 'This is a multi-part message in MIME format.' . "\r\n";
1445 1445
 			$content .= "Content-Transfer-Encoding: 8bit\r\n";
1446 1446
 			$content .= "\r\n";
1447 1447
 
1448
-			$content .= "--" . $this->_getBoundary('mixed') . "\r\n";
1448
+			$content .= "--".$this->_getBoundary('mixed')."\r\n";
1449 1449
 
1450 1450
 			if (key_exists('image', $this->_msgContent))     // If inline image found
1451 1451
 			{
1452
-				$content.= 'Content-Type: multipart/alternative; boundary="'.$this->_getBoundary('alternative').'"' . "\r\n";
1452
+				$content .= 'Content-Type: multipart/alternative; boundary="'.$this->_getBoundary('alternative').'"'."\r\n";
1453 1453
 				$content .= "\r\n";
1454
-				$content .= "--" . $this->_getBoundary('alternative') . "\r\n";
1454
+				$content .= "--".$this->_getBoundary('alternative')."\r\n";
1455 1455
 			}
1456 1456
 
1457 1457
 
@@ -1459,93 +1459,93 @@  discard block
 block discarded – undo
1459 1459
 
1460 1460
 
1461 1461
 			// Loop through message content array
1462
-			foreach ($this->_msgContent as $type => $_content )
1462
+			foreach ($this->_msgContent as $type => $_content)
1463 1463
 			{
1464
-				if ( $type == 'attachment' )
1464
+				if ($type == 'attachment')
1465 1465
 				{
1466 1466
 					// loop through all attachments
1467
-					foreach ( $_content as $_file => $_data )
1467
+					foreach ($_content as $_file => $_data)
1468 1468
 					{
1469
-						$content .= "--" . $this->_getBoundary('mixed') . "\r\n"
1470
-						.  'Content-Disposition: attachment; filename="' . $_data['fileName'] . '"' . "\r\n"
1471
-						.  'Content-Type: ' . $_data['mimeType'] . '; name="' . $_data['fileName'] . '"' . "\r\n"
1472
-						.  'Content-Transfer-Encoding: base64' . "\r\n"
1473
-						.  'Content-Description: ' . $_data['fileName'] ."\r\n";
1469
+						$content .= "--".$this->_getBoundary('mixed')."\r\n"
1470
+						.  'Content-Disposition: attachment; filename="'.$_data['fileName'].'"'."\r\n"
1471
+						.  'Content-Type: '.$_data['mimeType'].'; name="'.$_data['fileName'].'"'."\r\n"
1472
+						.  'Content-Transfer-Encoding: base64'."\r\n"
1473
+						.  'Content-Description: '.$_data['fileName']."\r\n";
1474 1474
 
1475
-						if ( $this->getMD5flag() )
1476
-						$content .= 'Content-MD5: ' . $_data['md5'] . "\r\n";
1475
+						if ($this->getMD5flag())
1476
+						$content .= 'Content-MD5: '.$_data['md5']."\r\n";
1477 1477
 
1478
-						$content .= "\r\n" .  $_data['data'] . "\r\n\r\n";
1478
+						$content .= "\r\n".$_data['data']."\r\n\r\n";
1479 1479
 					}
1480 1480
 				}
1481 1481
 				// @CHANGE LDR
1482
-				else if ( $type == 'image' )
1482
+				else if ($type == 'image')
1483 1483
 				{
1484 1484
 					// loop through all images
1485
-					foreach ( $_content as $_image => $_data )
1485
+					foreach ($_content as $_image => $_data)
1486 1486
 					{
1487
-						$content .= "--" . $this->_getBoundary('related') . "\r\n";  // always related for an inline image
1487
+						$content .= "--".$this->_getBoundary('related')."\r\n"; // always related for an inline image
1488 1488
 
1489
-						$content .= 'Content-Type: ' . $_data['mimeType'] . '; name="' . $_data['imageName'] . '"' . "\r\n"
1490
-						.  'Content-Transfer-Encoding: base64' . "\r\n"
1491
-						.  'Content-Disposition: inline; filename="' . $_data['imageName'] . '"' . "\r\n"
1492
-						.  'Content-ID: <' . $_data['cid'] . '> ' . "\r\n";
1489
+						$content .= 'Content-Type: '.$_data['mimeType'].'; name="'.$_data['imageName'].'"'."\r\n"
1490
+						.  'Content-Transfer-Encoding: base64'."\r\n"
1491
+						.  'Content-Disposition: inline; filename="'.$_data['imageName'].'"'."\r\n"
1492
+						.  'Content-ID: <'.$_data['cid'].'> '."\r\n";
1493 1493
 
1494
-						if ( $this->getMD5flag() )
1495
-						$content .= 'Content-MD5: ' . $_data['md5'] . "\r\n";
1494
+						if ($this->getMD5flag())
1495
+						$content .= 'Content-MD5: '.$_data['md5']."\r\n";
1496 1496
 
1497 1497
 						$content .= "\r\n"
1498
-						. $_data['data'] . "\r\n";
1498
+						. $_data['data']."\r\n";
1499 1499
 					}
1500 1500
 
1501 1501
 					// always end related and end alternative after inline images
1502
-					$content.= "--" . $this->_getBoundary('related') . "--" . "\r\n";
1503
-					$content.= "\r\n" . "--" . $this->_getBoundary('alternative') . "--" . "\r\n";
1504
-					$content.= "\r\n";
1502
+					$content .= "--".$this->_getBoundary('related')."--"."\r\n";
1503
+					$content .= "\r\n"."--".$this->_getBoundary('alternative')."--"."\r\n";
1504
+					$content .= "\r\n";
1505 1505
 				}
1506 1506
 				else
1507 1507
 				{
1508 1508
 					if (key_exists('image', $this->_msgContent))
1509 1509
 					{
1510
-						$content.= "Content-Type: text/plain; charset=" . $this->getCharSet() . "\r\n";
1511
-						$content.= "\r\n" . ($_content['dataText']?$_content['dataText']:strip_tags($_content['data'])) . "\r\n"; // Add plain text message
1512
-						$content.= "--" . $this->_getBoundary('alternative') . "\r\n";
1513
-						$content.= 'Content-Type: multipart/related; boundary="' . $this->_getBoundary('related') . '"' . "\r\n";
1514
-						$content.= "\r\n";
1515
-						$content.= "--" . $this->_getBoundary('related') . "\r\n";
1510
+						$content .= "Content-Type: text/plain; charset=".$this->getCharSet()."\r\n";
1511
+						$content .= "\r\n".($_content['dataText'] ? $_content['dataText'] : strip_tags($_content['data']))."\r\n"; // Add plain text message
1512
+						$content .= "--".$this->_getBoundary('alternative')."\r\n";
1513
+						$content .= 'Content-Type: multipart/related; boundary="'.$this->_getBoundary('related').'"'."\r\n";
1514
+						$content .= "\r\n";
1515
+						$content .= "--".$this->_getBoundary('related')."\r\n";
1516 1516
 					}
1517 1517
 
1518
-					if (! key_exists('image', $this->_msgContent) && $_content['dataText'] && ! empty($conf->global->MAIN_MAIL_USE_MULTI_PART))  // Add plain text message part before html part
1518
+					if (!key_exists('image', $this->_msgContent) && $_content['dataText'] && !empty($conf->global->MAIN_MAIL_USE_MULTI_PART))  // Add plain text message part before html part
1519 1519
 					{
1520
-					    $content.= 'Content-Type: multipart/alternative; boundary="'.$this->_getBoundary('alternative').'"' . "\r\n";
1520
+					    $content .= 'Content-Type: multipart/alternative; boundary="'.$this->_getBoundary('alternative').'"'."\r\n";
1521 1521
     					$content .= "\r\n";
1522
-	       				$content .= "--" . $this->_getBoundary('alternative') . "\r\n";
1522
+	       				$content .= "--".$this->_getBoundary('alternative')."\r\n";
1523 1523
 
1524
-	       				$content.= "Content-Type: text/plain; charset=" . $this->getCharSet() . "\r\n";
1525
-	       				$content.= "\r\n". $_content['dataText'] . "\r\n";
1526
-	       				$content.= "--" . $this->_getBoundary('alternative') . "\r\n";
1524
+	       				$content .= "Content-Type: text/plain; charset=".$this->getCharSet()."\r\n";
1525
+	       				$content .= "\r\n".$_content['dataText']."\r\n";
1526
+	       				$content .= "--".$this->_getBoundary('alternative')."\r\n";
1527 1527
 					}
1528 1528
 
1529
-					$content .= 'Content-Type: ' . $_content['mimeType'] . '; '
1529
+					$content .= 'Content-Type: '.$_content['mimeType'].'; '
1530 1530
 					//                             . 'charset="' . $this->getCharSet() . '"';
1531
-					. 'charset=' . $this->getCharSet() . '';
1531
+					. 'charset='.$this->getCharSet().'';
1532 1532
 
1533 1533
 					//                    $content .= ( $type == 'html') ? '; name="HTML Part"' : '';
1534
-					$content .=  "\r\n";
1534
+					$content .= "\r\n";
1535 1535
 					//                    $content .= 'Content-Transfer-Encoding: ';
1536 1536
 					//                    $content .= ($type == 'html') ? 'quoted-printable' : $this->getTransEncodeType();
1537 1537
 					//                    $content .=  "\r\n"
1538 1538
 					//                             . 'Content-Disposition: inline'  . "\r\n"
1539 1539
 					//                             . 'Content-Description: ' . $type . ' message' . "\r\n";
1540 1540
 
1541
-					if ( $this->getMD5flag() )
1542
-					$content .= 'Content-MD5: ' . $_content['md5'] . "\r\n";
1541
+					if ($this->getMD5flag())
1542
+					$content .= 'Content-MD5: '.$_content['md5']."\r\n";
1543 1543
 
1544
-					$content .= "\r\n"	. $_content['data'] . "\r\n";
1544
+					$content .= "\r\n".$_content['data']."\r\n";
1545 1545
 
1546
-					if (! key_exists('image', $this->_msgContent) && $_content['dataText'] && ! empty($conf->global->MAIN_MAIL_USE_MULTI_PART))  // Add plain text message part after html part
1546
+					if (!key_exists('image', $this->_msgContent) && $_content['dataText'] && !empty($conf->global->MAIN_MAIL_USE_MULTI_PART))  // Add plain text message part after html part
1547 1547
 					{
1548
-					    $content.= "--" . $this->_getBoundary('alternative') . "--". "\r\n";
1548
+					    $content .= "--".$this->_getBoundary('alternative')."--"."\r\n";
1549 1549
 					}
1550 1550
 
1551 1551
 					$content .= "\r\n";
@@ -1554,7 +1554,7 @@  discard block
 block discarded – undo
1554 1554
 
1555 1555
 			// Close message boundries
1556 1556
 			//            $content .= "\r\n--" . $this->_getBoundary() . '--' . "\r\n" ;
1557
-			$content .= "--" . $this->_getBoundary('mixed') . '--' . "\r\n" ;
1557
+			$content .= "--".$this->_getBoundary('mixed').'--'."\r\n";
1558 1558
 		}
1559 1559
 
1560 1560
 		return $content;
@@ -1571,15 +1571,15 @@  discard block
 block discarded – undo
1571 1571
 	 */
1572 1572
 	function setAttachment($strContent, $strFileName = 'unknown', $strMimeType = 'unknown')
1573 1573
 	{
1574
-		if ( $strContent )
1574
+		if ($strContent)
1575 1575
 		{
1576
-			$strContent = rtrim(chunk_split(base64_encode($strContent), 76, "\r\n"));    // 76 max is defined into http://tools.ietf.org/html/rfc2047
1576
+			$strContent = rtrim(chunk_split(base64_encode($strContent), 76, "\r\n")); // 76 max is defined into http://tools.ietf.org/html/rfc2047
1577 1577
 
1578 1578
 			$this->_msgContent['attachment'][$strFileName]['mimeType'] = $strMimeType;
1579 1579
 			$this->_msgContent['attachment'][$strFileName]['fileName'] = $strFileName;
1580 1580
 			$this->_msgContent['attachment'][$strFileName]['data']     = $strContent;
1581 1581
 
1582
-			if ( $this->getMD5flag() )
1582
+			if ($this->getMD5flag())
1583 1583
 			$this->_msgContent['attachment'][$strFileName]['md5']      = dol_hash($strContent, 3);
1584 1584
 		}
1585 1585
 	}
@@ -1606,7 +1606,7 @@  discard block
 block discarded – undo
1606 1606
 			$this->_msgContent['image'][$strImageName]['cid']      = $strImageCid;
1607 1607
 			$this->_msgContent['image'][$strImageName]['data']     = $strContent;
1608 1608
 
1609
-			if ( $this->getMD5flag() )
1609
+			if ($this->getMD5flag())
1610 1610
 			$this->_msgContent['image'][$strImageName]['md5']      = dol_hash($strContent, 3);
1611 1611
 		}
1612 1612
 	}
@@ -1626,8 +1626,8 @@  discard block
 block discarded – undo
1626 1626
 	 */
1627 1627
 	function setSensitivity($_value = 0)
1628 1628
 	{
1629
-		if ( ( is_numeric($_value) ) &&
1630
-		( ( $_value >= 0 ) && ( $_value <= 3 ) ) )
1629
+		if ((is_numeric($_value)) &&
1630
+		(($_value >= 0) && ($_value <= 3)))
1631 1631
 		$this->_msgSensitivity = $_value;
1632 1632
 	}
1633 1633
 
@@ -1659,10 +1659,10 @@  discard block
 block discarded – undo
1659 1659
 	 * @param 	integer 	$_value 	Message Priority
1660 1660
 	 * @return 	void
1661 1661
 	 */
1662
-	function setPriority( $_value = 3 )
1662
+	function setPriority($_value = 3)
1663 1663
 	{
1664
-		if ( ( is_numeric($_value) ) &&
1665
-		( ( $_value >= 0 ) && ( $_value <= 5 ) ) )
1664
+		if ((is_numeric($_value)) &&
1665
+		(($_value >= 0) && ($_value <= 5)))
1666 1666
 		$this->_msgPriority = $_value;
1667 1667
 	}
1668 1668
 
@@ -1680,9 +1680,9 @@  discard block
 block discarded – undo
1680 1680
 	 */
1681 1681
 	function getPriority()
1682 1682
 	{
1683
-		return 'Importance: ' . $this->_aryPriority[$this->_msgPriority] . "\r\n"
1684
-		. 'Priority: '   . $this->_aryPriority[$this->_msgPriority] . "\r\n"
1685
-		. 'X-Priority: ' . $this->_msgPriority . ' (' . $this->_aryPriority[$this->_msgPriority] . ')' . "\r\n";
1683
+		return 'Importance: '.$this->_aryPriority[$this->_msgPriority]."\r\n"
1684
+		. 'Priority: '.$this->_aryPriority[$this->_msgPriority]."\r\n"
1685
+		. 'X-Priority: '.$this->_msgPriority.' ('.$this->_aryPriority[$this->_msgPriority].')'."\r\n";
1686 1686
 	}
1687 1687
 
1688 1688
 	/**
@@ -1716,7 +1716,7 @@  discard block
 block discarded – undo
1716 1716
 	 */
1717 1717
 	function setXheader($strXdata)
1718 1718
 	{
1719
-		if ( $strXdata )
1719
+		if ($strXdata)
1720 1720
 		$this->_msgXheader[] = $strXdata;
1721 1721
 	}
1722 1722
 
@@ -1737,7 +1737,7 @@  discard block
 block discarded – undo
1737 1737
 	 */
1738 1738
 	function _setBoundary()
1739 1739
 	{
1740
-		$this->_smtpsBoundary = "multipart_x." . time() . ".x_boundary";
1740
+		$this->_smtpsBoundary = "multipart_x.".time().".x_boundary";
1741 1741
 		$this->_smtpsRelatedBoundary = 'mul_'.dol_hash(uniqid("dolibarr2"), 3);
1742 1742
 		$this->_smtpsAlternativeBoundary = 'mul_'.dol_hash(uniqid("dolibarr3"), 3);
1743 1743
 	}
@@ -1748,7 +1748,7 @@  discard block
 block discarded – undo
1748 1748
 	 * @param  string $type				Type of boundary
1749 1749
 	 * @return string $_smtpsBoundary 	MIME message Boundary
1750 1750
 	 */
1751
-	function _getBoundary($type='mixed')
1751
+	function _getBoundary($type = 'mixed')
1752 1752
 	{
1753 1753
 		if ($type == 'mixed') return $this->_smtpsBoundary;
1754 1754
 		else if ($type == 'related') return $this->_smtpsRelatedBoundary;
@@ -1776,11 +1776,11 @@  discard block
 block discarded – undo
1776 1776
 		$server_response = '';
1777 1777
 
1778 1778
         // avoid infinite loop
1779
-        $limit=0;
1779
+        $limit = 0;
1780 1780
 
1781
-		while (substr($server_response,3,1) != ' ' && $limit<100)
1781
+		while (substr($server_response, 3, 1) != ' ' && $limit < 100)
1782 1782
 		{
1783
-			if (! ($server_response = fgets($socket, 256)))
1783
+			if (!($server_response = fgets($socket, 256)))
1784 1784
 			{
1785 1785
 				$this->_setErr(121, "Couldn't get mail server response codes");
1786 1786
 				$_retVal = false;
@@ -1789,7 +1789,7 @@  discard block
 block discarded – undo
1789 1789
             $limit++;
1790 1790
 		}
1791 1791
 
1792
-		if (! (substr($server_response, 0, 3) == $response))
1792
+		if (!(substr($server_response, 0, 3) == $response))
1793 1793
 		{
1794 1794
 			$this->_setErr(120, "Ran into problems sending Mail.\r\nResponse: $server_response");
1795 1795
 			$_retVal = false;
@@ -1807,14 +1807,14 @@  discard block
 block discarded – undo
1807 1807
 	 * @param 	string		$CRLF			CRLF
1808 1808
 	 * @return 	boolean|null						True or false
1809 1809
 	 */
1810
-	function socket_send_str( $_strSend, $_returnCode = null, $CRLF = "\r\n" )
1810
+	function socket_send_str($_strSend, $_returnCode = null, $CRLF = "\r\n")
1811 1811
 	{
1812 1812
         // phpcs:enable
1813
-		if ($this->_debug) $this->log.=$_strSend;	// @CHANGE LDR for log
1814
-		fputs($this->socket, $_strSend . $CRLF);
1815
-		if ($this->_debug) $this->log.=' ('.$_returnCode.')' . $CRLF;
1813
+		if ($this->_debug) $this->log .= $_strSend; // @CHANGE LDR for log
1814
+		fputs($this->socket, $_strSend.$CRLF);
1815
+		if ($this->_debug) $this->log .= ' ('.$_returnCode.')'.$CRLF;
1816 1816
 
1817
-		if ( $_returnCode )
1817
+		if ($_returnCode)
1818 1818
 		return $this->server_parse($this->socket, $_returnCode);
1819 1819
 	}
1820 1820
 
@@ -1828,7 +1828,7 @@  discard block
 block discarded – undo
1828 1828
 	 * @param  string $_errMsg  Error Message
1829 1829
 	 * @return void
1830 1830
      */
1831
-    function _setErr( $_errNum, $_errMsg )
1831
+    function _setErr($_errNum, $_errMsg)
1832 1832
     {
1833 1833
         $this->_smtpsErrors[] = array(
1834 1834
             'num' => $_errNum,
@@ -1847,9 +1847,9 @@  discard block
 block discarded – undo
1847 1847
 
1848 1848
 		if (is_array($this->_smtpsErrors))
1849 1849
 		{
1850
-			foreach ( $this->_smtpsErrors as $_err => $_info )
1850
+			foreach ($this->_smtpsErrors as $_err => $_info)
1851 1851
 			{
1852
-				$_errMsg[] = 'Error [' . $_info['num'] .']: '. $_info['msg'];
1852
+				$_errMsg[] = 'Error ['.$_info['num'].']: '.$_info['msg'];
1853 1853
 			}
1854 1854
 		}
1855 1855
 
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/commonobjectline.class.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
      * 	@param	string $type Label type (long or short)
58 58
      *	@return	string|int <0 if ko, label if ok
59 59
      */
60
-	public function getLabelOfUnit($type='long')
60
+	public function getLabelOfUnit($type = 'long')
61 61
 	{
62 62
 		global $langs;
63 63
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
 		$sql = 'select '.$label_type.' from '.MAIN_DB_PREFIX.'c_units where rowid='.$this->fk_unit;
78 78
 		$resql = $this->db->query($sql);
79
-		if($resql && $this->db->num_rows($resql) > 0)
79
+		if ($resql && $this->db->num_rows($resql) > 0)
80 80
 		{
81 81
 			$res = $this->db->fetch_array($resql);
82 82
 			$label = $res[$label_type];
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 		}
86 86
 		else
87 87
 		{
88
-			$this->error=$this->db->error().' sql='.$sql;
88
+			$this->error = $this->db->error().' sql='.$sql;
89 89
 			dol_syslog(get_class($this)."::getLabelOfUnit Error ".$this->error, LOG_ERR);
90 90
 			return -1;
91 91
 		}
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/fiscalyear.class.php 1 patch
Spacing   +60 added lines, -60 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
  *		\brief      File of class to manage fiscal years
22 22
  */
23 23
 
24
-require_once DOL_DOCUMENT_ROOT . '/core/class/commonobject.class.php';
24
+require_once DOL_DOCUMENT_ROOT.'/core/class/commonobject.class.php';
25 25
 
26 26
 /**
27 27
  * Class to manage fiscal year
@@ -31,12 +31,12 @@  discard block
 block discarded – undo
31 31
 	/**
32 32
 	 * @var string ID to identify managed object
33 33
 	 */
34
-	public $element='fiscalyear';
34
+	public $element = 'fiscalyear';
35 35
 
36 36
 	/**
37 37
 	 * @var string Name of table without prefix where object is stored
38 38
 	 */
39
-	public $table_element='accounting_fiscalyear';
39
+	public $table_element = 'accounting_fiscalyear';
40 40
 
41 41
 	/**
42 42
 	 * @var int    Name of subtable line
@@ -67,15 +67,15 @@  discard block
 block discarded – undo
67 67
 	public $date_start;
68 68
 	public $date_end;
69 69
 	public $datec;
70
-	public $statut;		// 0=open, 1=closed
70
+	public $statut; // 0=open, 1=closed
71 71
 
72 72
 	/**
73 73
 	 * @var int Entity
74 74
 	 */
75 75
 	public $entity;
76 76
 
77
-	public $statuts=array();
78
-	public $statuts_short=array();
77
+	public $statuts = array();
78
+	public $statuts_short = array();
79 79
 
80 80
 	/**
81 81
 	 * Constructor
@@ -104,27 +104,27 @@  discard block
 block discarded – undo
104 104
 
105 105
 		$error = 0;
106 106
 
107
-		$now=dol_now();
107
+		$now = dol_now();
108 108
 
109 109
 		$this->db->begin();
110 110
 
111 111
 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."accounting_fiscalyear (";
112
-		$sql.= "label";
113
-		$sql.= ", date_start";
114
-		$sql.= ", date_end";
115
-		$sql.= ", statut";
116
-		$sql.= ", entity";
117
-		$sql.= ", datec";
118
-		$sql.= ", fk_user_author";
119
-		$sql.= ") VALUES (";
120
-		$sql.= " '".$this->db->escape($this->label)."'";
121
-		$sql.= ", '".$this->db->idate($this->date_start)."'";
122
-		$sql.= ", ".($this->date_end ? "'".$this->db->idate($this->date_end)."'":"null");
123
-		$sql.= ", 0";
124
-		$sql.= ", ".$conf->entity;
125
-		$sql.= ", '".$this->db->idate($now)."'";
126
-		$sql.= ", ". $user->id;
127
-		$sql.= ")";
112
+		$sql .= "label";
113
+		$sql .= ", date_start";
114
+		$sql .= ", date_end";
115
+		$sql .= ", statut";
116
+		$sql .= ", entity";
117
+		$sql .= ", datec";
118
+		$sql .= ", fk_user_author";
119
+		$sql .= ") VALUES (";
120
+		$sql .= " '".$this->db->escape($this->label)."'";
121
+		$sql .= ", '".$this->db->idate($this->date_start)."'";
122
+		$sql .= ", ".($this->date_end ? "'".$this->db->idate($this->date_end)."'" : "null");
123
+		$sql .= ", 0";
124
+		$sql .= ", ".$conf->entity;
125
+		$sql .= ", '".$this->db->idate($now)."'";
126
+		$sql .= ", ".$user->id;
127
+		$sql .= ")";
128 128
 
129 129
 		dol_syslog(get_class($this)."::create", LOG_DEBUG);
130 130
 		$result = $this->db->query($sql);
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 		{
133 133
 			$this->id = $this->db->last_insert_id(MAIN_DB_PREFIX."accounting_fiscalyear");
134 134
 
135
-			$result=$this->update($user);
135
+			$result = $this->update($user);
136 136
 			if ($result > 0)
137 137
 			{
138 138
 				$this->db->commit();
@@ -140,14 +140,14 @@  discard block
 block discarded – undo
140 140
 			}
141 141
 			else
142 142
 			{
143
-				$this->error=$this->db->lasterror();
143
+				$this->error = $this->db->lasterror();
144 144
 				$this->db->rollback();
145 145
 				return $result;
146 146
 			}
147 147
 		}
148 148
 		else
149 149
 		{
150
-			$this->error=$this->db->lasterror()." sql=".$sql;
150
+			$this->error = $this->db->lasterror()." sql=".$sql;
151 151
 			$this->db->rollback();
152 152
 			return -1;
153 153
 		}
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 		// Check parameters
167 167
 		if (empty($this->date_start) && empty($this->date_end))
168 168
 		{
169
-			$this->error='ErrorBadParameter';
169
+			$this->error = 'ErrorBadParameter';
170 170
 			return -1;
171 171
 		}
172 172
 
@@ -176,9 +176,9 @@  discard block
 block discarded – undo
176 176
 		$sql .= " SET label = '".$this->db->escape($this->label)."'";
177 177
 		$sql .= ", date_start = '".$this->db->idate($this->date_start)."'";
178 178
 		$sql .= ", date_end = ".($this->date_end ? "'".$this->db->idate($this->date_end)."'" : "null");
179
-		$sql .= ", statut = '".$this->db->escape($this->statut?$this->statut:0)."'";
180
-		$sql .= ", datec = " . ($this->datec != '' ? "'".$this->db->idate($this->datec)."'" : 'null');
181
-		$sql .= ", fk_user_modif = " . $user->id;
179
+		$sql .= ", statut = '".$this->db->escape($this->statut ? $this->statut : 0)."'";
180
+		$sql .= ", datec = ".($this->datec != '' ? "'".$this->db->idate($this->datec)."'" : 'null');
181
+		$sql .= ", fk_user_modif = ".$user->id;
182 182
 		$sql .= " WHERE rowid = ".$this->id;
183 183
 
184 184
 		dol_syslog(get_class($this)."::update", LOG_DEBUG);
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 		}
191 191
 		else
192 192
 		{
193
-			$this->error=$this->db->lasterror();
193
+			$this->error = $this->db->lasterror();
194 194
 			dol_syslog($this->error, LOG_ERR);
195 195
 			$this->db->rollback();
196 196
 			return -1;
@@ -206,27 +206,27 @@  discard block
 block discarded – undo
206 206
 	function fetch($id)
207 207
 	{
208 208
 		$sql = "SELECT rowid, label, date_start, date_end, statut";
209
-		$sql.= " FROM ".MAIN_DB_PREFIX."accounting_fiscalyear";
210
-		$sql.= " WHERE rowid = ".$id;
209
+		$sql .= " FROM ".MAIN_DB_PREFIX."accounting_fiscalyear";
210
+		$sql .= " WHERE rowid = ".$id;
211 211
 
212 212
 		dol_syslog(get_class($this)."::fetch", LOG_DEBUG);
213 213
 		$result = $this->db->query($sql);
214
-		if ( $result )
214
+		if ($result)
215 215
 		{
216 216
 			$obj = $this->db->fetch_object($result);
217 217
 
218
-			$this->id			= $obj->rowid;
219
-			$this->ref			= $obj->rowid;
218
+			$this->id = $obj->rowid;
219
+			$this->ref = $obj->rowid;
220 220
 			$this->date_start	= $this->db->jdate($obj->date_start);
221
-			$this->date_end		= $this->db->jdate($obj->date_end);
222
-			$this->label		= $obj->label;
221
+			$this->date_end = $this->db->jdate($obj->date_end);
222
+			$this->label = $obj->label;
223 223
 			$this->statut	    = $obj->statut;
224 224
 
225 225
 			return 1;
226 226
 		}
227 227
 		else
228 228
 		{
229
-			$this->error=$this->db->lasterror();
229
+			$this->error = $this->db->lasterror();
230 230
 			return -1;
231 231
 		}
232 232
 	}
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
 		}
253 253
 		else
254 254
 		{
255
-			$this->error=$this->db->lasterror();
255
+			$this->error = $this->db->lasterror();
256 256
 			$this->db->rollback();
257 257
 			return -1;
258 258
 		}
@@ -264,9 +264,9 @@  discard block
 block discarded – undo
264 264
 	 * @param	int		$mode   	0=long label, 1=short label, 2=Picto + short label, 3=Picto, 4=Picto + long label, 5=Short label + Picto
265 265
 	 * @return  string   		   	Label
266 266
 	 */
267
-	function getLibStatut($mode=0)
267
+	function getLibStatut($mode = 0)
268 268
 	{
269
-		return $this->LibStatut($this->statut,$mode);
269
+		return $this->LibStatut($this->statut, $mode);
270 270
 	}
271 271
 
272 272
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 	 *  @param  int		$mode       0=long label, 1=short label, 2=Picto + short label, 3=Picto, 4=Picto + long label, 5=Short label + Picto
278 278
 	 *  @return string      		Label
279 279
 	 */
280
-	function LibStatut($statut,$mode=0)
280
+	function LibStatut($statut, $mode = 0)
281 281
 	{
282 282
 		// phpcs:enable
283 283
 		global $langs;
@@ -292,23 +292,23 @@  discard block
 block discarded – undo
292 292
 		}
293 293
 		elseif ($mode == 2)
294 294
 		{
295
-			if ($statut==0) return img_picto($langs->trans($this->statuts_short[$statut]),'statut4').' '.$langs->trans($this->statuts_short[$statut]);
296
-			elseif ($statut==1) return img_picto($langs->trans($this->statuts_short[$statut]),'statut8').' '.$langs->trans($this->statuts_short[$statut]);
295
+			if ($statut == 0) return img_picto($langs->trans($this->statuts_short[$statut]), 'statut4').' '.$langs->trans($this->statuts_short[$statut]);
296
+			elseif ($statut == 1) return img_picto($langs->trans($this->statuts_short[$statut]), 'statut8').' '.$langs->trans($this->statuts_short[$statut]);
297 297
 		}
298 298
 		elseif ($mode == 3)
299 299
 		{
300
-			if ($statut==0 && ! empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]),'statut4');
301
-			elseif ($statut==1 && ! empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]),'statut8');
300
+			if ($statut == 0 && !empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]), 'statut4');
301
+			elseif ($statut == 1 && !empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]), 'statut8');
302 302
 		}
303 303
 		elseif ($mode == 4)
304 304
 		{
305
-			if ($statut==0 && ! empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]),'statut4').' '.$langs->trans($this->statuts[$statut]);
306
-			elseif ($statut==1 && ! empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]),'statut8').' '.$langs->trans($this->statuts[$statut]);
305
+			if ($statut == 0 && !empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]), 'statut4').' '.$langs->trans($this->statuts[$statut]);
306
+			elseif ($statut == 1 && !empty($this->statuts_short[$statut])) return img_picto($langs->trans($this->statuts_short[$statut]), 'statut8').' '.$langs->trans($this->statuts[$statut]);
307 307
 		}
308 308
 		elseif ($mode == 5)
309 309
 		{
310
-			if ($statut==0 && ! empty($this->statuts_short[$statut])) return $langs->trans($this->statuts_short[$statut]).' '.img_picto($langs->trans($this->statuts_short[$statut]),'statut4');
311
-			elseif ($statut==1 && ! empty($this->statuts_short[$statut])) return $langs->trans($this->statuts_short[$statut]).' '.img_picto($langs->trans($this->statuts_short[$statut]),'statut6');
310
+			if ($statut == 0 && !empty($this->statuts_short[$statut])) return $langs->trans($this->statuts_short[$statut]).' '.img_picto($langs->trans($this->statuts_short[$statut]), 'statut4');
311
+			elseif ($statut == 1 && !empty($this->statuts_short[$statut])) return $langs->trans($this->statuts_short[$statut]).' '.img_picto($langs->trans($this->statuts_short[$statut]), 'statut6');
312 312
 		}
313 313
 	}
314 314
 
@@ -321,9 +321,9 @@  discard block
 block discarded – undo
321 321
 	function info($id)
322 322
 	{
323 323
 		$sql = 'SELECT fy.rowid, fy.datec, fy.fk_user_author, fy.fk_user_modif,';
324
-		$sql.= ' fy.tms';
325
-		$sql.= ' FROM '.MAIN_DB_PREFIX.'accounting_fiscalyear as fy';
326
-		$sql.= ' WHERE fy.rowid = '.$id;
324
+		$sql .= ' fy.tms';
325
+		$sql .= ' FROM '.MAIN_DB_PREFIX.'accounting_fiscalyear as fy';
326
+		$sql .= ' WHERE fy.rowid = '.$id;
327 327
 
328 328
 		dol_syslog(get_class($this)."::fetch info", LOG_DEBUG);
329 329
 		$result = $this->db->query($sql);
@@ -369,10 +369,10 @@  discard block
 block discarded – undo
369 369
 		global $conf;
370 370
 
371 371
 		$sql = "SELECT count(DISTINCT piece_num) as nb";
372
-		$sql.= " FROM ".MAIN_DB_PREFIX."accounting_bookkeeping ";
373
-		$sql.= " WHERE doc_date >= '".$datestart."' and doc_date <= '".$dateend."'";
372
+		$sql .= " FROM ".MAIN_DB_PREFIX."accounting_bookkeeping ";
373
+		$sql .= " WHERE doc_date >= '".$datestart."' and doc_date <= '".$dateend."'";
374 374
 
375
-		$resql=$this->db->query($sql);
375
+		$resql = $this->db->query($sql);
376 376
 		if ($resql)
377 377
 		{
378 378
 			$obj = $this->db->fetch_object($resql);
@@ -395,10 +395,10 @@  discard block
 block discarded – undo
395 395
 		global $conf;
396 396
 
397 397
 		$sql = "SELECT count(rowid) as nb";
398
-		$sql.= " FROM ".MAIN_DB_PREFIX."accounting_bookkeeping ";
399
-		$sql.= " WHERE doc_date >= '".$datestart."' AND doc_date <= '".$dateend."'";
398
+		$sql .= " FROM ".MAIN_DB_PREFIX."accounting_bookkeeping ";
399
+		$sql .= " WHERE doc_date >= '".$datestart."' AND doc_date <= '".$dateend."'";
400 400
 
401
-		$resql=$this->db->query($sql);
401
+		$resql = $this->db->query($sql);
402 402
 		if ($resql)
403 403
 		{
404 404
 			$obj = $this->db->fetch_object($resql);
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/ctypent.class.php 1 patch
Spacing   +68 added lines, -68 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	/**
36 36
 	 * @var string Error code (or message)
37 37
 	 */
38
-	public $error='';
38
+	public $error = '';
39 39
 
40 40
 	/**
41 41
 	 * @var string[] Error codes (or messages)
@@ -76,18 +76,18 @@  discard block
 block discarded – undo
76 76
      *  @param      int		$notrigger   0=launch triggers after, 1=disable triggers
77 77
      *  @return     int      		   	 <0 if KO, Id of created object if OK
78 78
      */
79
-    function create($user, $notrigger=0)
79
+    function create($user, $notrigger = 0)
80 80
     {
81 81
     	global $conf, $langs;
82
-		$error=0;
82
+		$error = 0;
83 83
 
84 84
 		// Clean parameters
85 85
 
86
-		if (isset($this->id)) $this->id=trim($this->id);
87
-		if (isset($this->code)) $this->code=trim($this->code);
88
-		if (isset($this->libelle)) $this->libelle=trim($this->libelle);
89
-		if (isset($this->active)) $this->active=trim($this->active);
90
-		if (isset($this->module)) $this->module=trim($this->module);
86
+		if (isset($this->id)) $this->id = trim($this->id);
87
+		if (isset($this->code)) $this->code = trim($this->code);
88
+		if (isset($this->libelle)) $this->libelle = trim($this->libelle);
89
+		if (isset($this->active)) $this->active = trim($this->active);
90
+		if (isset($this->module)) $this->module = trim($this->module);
91 91
 
92 92
 
93 93
 
@@ -97,35 +97,35 @@  discard block
 block discarded – undo
97 97
         // Insert request
98 98
 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."c_typent(";
99 99
 
100
-		$sql.= "id,";
101
-		$sql.= "code,";
102
-		$sql.= "libelle,";
103
-		$sql.= "active,";
104
-		$sql.= "module";
100
+		$sql .= "id,";
101
+		$sql .= "code,";
102
+		$sql .= "libelle,";
103
+		$sql .= "active,";
104
+		$sql .= "module";
105 105
 
106 106
 
107
-        $sql.= ") VALUES (";
107
+        $sql .= ") VALUES (";
108 108
 
109
-		$sql.= " ".(! isset($this->id)?'NULL':"'".$this->db->escape($this->id)."'").",";
110
-		$sql.= " ".(! isset($this->code)?'NULL':"'".$this->db->escape($this->code)."'").",";
111
-		$sql.= " ".(! isset($this->libelle)?'NULL':"'".$this->db->escape($this->libelle)."'").",";
112
-		$sql.= " ".(! isset($this->active)?'NULL':"'".$this->db->active($this->active)."'").",";
113
-		$sql.= " ".(! isset($this->module)?'NULL':"'".$this->db->escape($this->module)."'")."";
109
+		$sql .= " ".(!isset($this->id) ? 'NULL' : "'".$this->db->escape($this->id)."'").",";
110
+		$sql .= " ".(!isset($this->code) ? 'NULL' : "'".$this->db->escape($this->code)."'").",";
111
+		$sql .= " ".(!isset($this->libelle) ? 'NULL' : "'".$this->db->escape($this->libelle)."'").",";
112
+		$sql .= " ".(!isset($this->active) ? 'NULL' : "'".$this->db->active($this->active)."'").",";
113
+		$sql .= " ".(!isset($this->module) ? 'NULL' : "'".$this->db->escape($this->module)."'")."";
114 114
 
115 115
 
116
-		$sql.= ")";
116
+		$sql .= ")";
117 117
 
118 118
 		$this->db->begin();
119 119
 
120 120
 	   	dol_syslog(get_class($this)."::create", LOG_DEBUG);
121
-        $resql=$this->db->query($sql);
122
-    	if (! $resql) { $error++; $this->errors[]="Error ".$this->db->lasterror(); }
121
+        $resql = $this->db->query($sql);
122
+    	if (!$resql) { $error++; $this->errors[] = "Error ".$this->db->lasterror(); }
123 123
 
124
-		if (! $error)
124
+		if (!$error)
125 125
         {
126 126
             $this->id = $this->db->last_insert_id(MAIN_DB_PREFIX."c_typent");
127 127
 
128
-			if (! $notrigger)
128
+			if (!$notrigger)
129 129
 			{
130 130
 	            // Uncomment this and change MYOBJECT to your own tag if you
131 131
 	            // want this action call a trigger.
@@ -142,13 +142,13 @@  discard block
 block discarded – undo
142 142
         // Commit or rollback
143 143
         if ($error)
144 144
 		{
145
-			foreach($this->errors as $errmsg)
145
+			foreach ($this->errors as $errmsg)
146 146
 			{
147 147
 	            dol_syslog(get_class($this)."::create ".$errmsg, LOG_ERR);
148
-	            $this->error.=($this->error?', '.$errmsg:$errmsg);
148
+	            $this->error .= ($this->error ? ', '.$errmsg : $errmsg);
149 149
 			}
150 150
 			$this->db->rollback();
151
-			return -1*$error;
151
+			return -1 * $error;
152 152
 		}
153 153
 		else
154 154
 		{
@@ -166,29 +166,29 @@  discard block
 block discarded – undo
166 166
      *  @param		string	$label	Label
167 167
      *  @return     int          	<0 if KO, >0 if OK
168 168
      */
169
-    function fetch($id,$code='',$label='')
169
+    function fetch($id, $code = '', $label = '')
170 170
     {
171 171
     	global $langs;
172 172
         $sql = "SELECT";
173
-		$sql.= " t.id,";
174
-		$sql.= " t.code,";
175
-		$sql.= " t.libelle as label,";
176
-		$sql.= " t.fk_country as country_id,";
177
-		$sql.= " t.active,";
178
-		$sql.= " t.module";
179
-        $sql.= " FROM ".MAIN_DB_PREFIX."c_typent as t";
180
-        if ($id)   $sql.= " WHERE t.id = ".$id;
181
-        elseif ($code) $sql.= " WHERE t.code = '".$this->db->escape($code)."'";
182
-        elseif ($label) $sql.= " WHERE t.libelle = '".$this->db->escape($label)."'";
183
-
184
-        $resql=$this->db->query($sql);
173
+		$sql .= " t.id,";
174
+		$sql .= " t.code,";
175
+		$sql .= " t.libelle as label,";
176
+		$sql .= " t.fk_country as country_id,";
177
+		$sql .= " t.active,";
178
+		$sql .= " t.module";
179
+        $sql .= " FROM ".MAIN_DB_PREFIX."c_typent as t";
180
+        if ($id)   $sql .= " WHERE t.id = ".$id;
181
+        elseif ($code) $sql .= " WHERE t.code = '".$this->db->escape($code)."'";
182
+        elseif ($label) $sql .= " WHERE t.libelle = '".$this->db->escape($label)."'";
183
+
184
+        $resql = $this->db->query($sql);
185 185
         if ($resql)
186 186
         {
187 187
             if ($this->db->num_rows($resql))
188 188
             {
189 189
                 $obj = $this->db->fetch_object($resql);
190 190
 
191
-                $this->id    = $obj->id;
191
+                $this->id = $obj->id;
192 192
 				$this->code = $obj->code;
193 193
 				$this->libelle = $obj->label;
194 194
 				$this->country_id = $obj->country_id;
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         }
202 202
         else
203 203
         {
204
-      	    $this->error="Error ".$this->db->lasterror();
204
+      	    $this->error = "Error ".$this->db->lasterror();
205 205
             return -1;
206 206
         }
207 207
     }
@@ -214,16 +214,16 @@  discard block
 block discarded – undo
214 214
      *  @param      int		$notrigger	 0=launch triggers after, 1=disable triggers
215 215
      *  @return     int     		   	 <0 if KO, >0 if OK
216 216
      */
217
-    function update($user=null, $notrigger=0)
217
+    function update($user = null, $notrigger = 0)
218 218
     {
219 219
     	global $conf, $langs;
220
-		$error=0;
220
+		$error = 0;
221 221
 
222 222
 		// Clean parameters
223
-		if (isset($this->code)) $this->code=trim($this->code);
224
-		if (isset($this->libelle)) $this->libelle=trim($this->libelle);
225
-		if (isset($this->active)) $this->active=trim($this->active);
226
-		if (isset($this->module)) $this->module=trim($this->module);
223
+		if (isset($this->code)) $this->code = trim($this->code);
224
+		if (isset($this->libelle)) $this->libelle = trim($this->libelle);
225
+		if (isset($this->active)) $this->active = trim($this->active);
226
+		if (isset($this->module)) $this->module = trim($this->module);
227 227
 
228 228
 
229 229
 		// Check parameters
@@ -231,21 +231,21 @@  discard block
 block discarded – undo
231 231
 
232 232
         // Update request
233 233
         $sql = "UPDATE ".MAIN_DB_PREFIX."c_typent SET";
234
-		$sql.= " code=".(isset($this->code)?"'".$this->db->escape($this->code)."'":"null").",";
235
-		$sql.= " libelle=".(isset($this->libelle)?"'".$this->db->escape($this->libelle)."'":"null").",";
236
-		$sql.= " active=".(isset($this->active)?$this->active:"null").",";
237
-		$sql.= " module=".(isset($this->module)?"'".$this->db->escape($this->module)."'":"null")."";
238
-        $sql.= " WHERE id=".$this->id;
234
+		$sql .= " code=".(isset($this->code) ? "'".$this->db->escape($this->code)."'" : "null").",";
235
+		$sql .= " libelle=".(isset($this->libelle) ? "'".$this->db->escape($this->libelle)."'" : "null").",";
236
+		$sql .= " active=".(isset($this->active) ? $this->active : "null").",";
237
+		$sql .= " module=".(isset($this->module) ? "'".$this->db->escape($this->module)."'" : "null")."";
238
+        $sql .= " WHERE id=".$this->id;
239 239
 
240 240
 		$this->db->begin();
241 241
 
242 242
 		dol_syslog(get_class($this)."::update", LOG_DEBUG);
243 243
         $resql = $this->db->query($sql);
244
-    	if (! $resql) { $error++; $this->errors[]="Error ".$this->db->lasterror(); }
244
+    	if (!$resql) { $error++; $this->errors[] = "Error ".$this->db->lasterror(); }
245 245
 
246
-		if (! $error)
246
+		if (!$error)
247 247
 		{
248
-			if (! $notrigger)
248
+			if (!$notrigger)
249 249
 			{
250 250
 	            // Uncomment this and change MYOBJECT to your own tag if you
251 251
 	            // want this action call a trigger.
@@ -262,13 +262,13 @@  discard block
 block discarded – undo
262 262
         // Commit or rollback
263 263
 		if ($error)
264 264
 		{
265
-			foreach($this->errors as $errmsg)
265
+			foreach ($this->errors as $errmsg)
266 266
 			{
267 267
 	            dol_syslog(get_class($this)."::update ".$errmsg, LOG_ERR);
268
-	            $this->error.=($this->error?', '.$errmsg:$errmsg);
268
+	            $this->error .= ($this->error ? ', '.$errmsg : $errmsg);
269 269
 			}
270 270
 			$this->db->rollback();
271
-			return -1*$error;
271
+			return -1 * $error;
272 272
 		}
273 273
 		else
274 274
 		{
@@ -285,23 +285,23 @@  discard block
 block discarded – undo
285 285
      *  @param  int		$notrigger	 0=launch triggers after, 1=disable triggers
286 286
 	 *  @return	int					 <0 if KO, >0 if OK
287 287
 	 */
288
-	function delete($user, $notrigger=0)
288
+	function delete($user, $notrigger = 0)
289 289
 	{
290 290
 		global $conf, $langs;
291
-		$error=0;
291
+		$error = 0;
292 292
 
293 293
 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."c_typent";
294
-		$sql.= " WHERE id=".$this->id;
294
+		$sql .= " WHERE id=".$this->id;
295 295
 
296 296
 		$this->db->begin();
297 297
 
298 298
 		dol_syslog(get_class($this)."::delete", LOG_DEBUG);
299 299
 		$resql = $this->db->query($sql);
300
-    	if (! $resql) { $error++; $this->errors[]="Error ".$this->db->lasterror(); }
300
+    	if (!$resql) { $error++; $this->errors[] = "Error ".$this->db->lasterror(); }
301 301
 
302
-		if (! $error)
302
+		if (!$error)
303 303
 		{
304
-			if (! $notrigger)
304
+			if (!$notrigger)
305 305
 			{
306 306
 				// Uncomment this and change MYOBJECT to your own tag if you
307 307
 		        // want this action call a trigger.
@@ -318,13 +318,13 @@  discard block
 block discarded – undo
318 318
         // Commit or rollback
319 319
 		if ($error)
320 320
 		{
321
-			foreach($this->errors as $errmsg)
321
+			foreach ($this->errors as $errmsg)
322 322
 			{
323 323
 	            dol_syslog(get_class($this)."::delete ".$errmsg, LOG_ERR);
324
-	            $this->error.=($this->error?', '.$errmsg:$errmsg);
324
+	            $this->error .= ($this->error ? ', '.$errmsg : $errmsg);
325 325
 			}
326 326
 			$this->db->rollback();
327
-			return -1*$error;
327
+			return -1 * $error;
328 328
 		}
329 329
 		else
330 330
 		{
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/html.formbank.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
 	 * @var string Error code (or message)
39 39
 	 */
40
-	public $error='';
40
+	public $error = '';
41 41
 
42 42
 
43 43
     /**
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/ldap.class.php 1 patch
Spacing   +221 added lines, -221 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @var string Error code (or message)
34 34
 	 */
35
-	public $error='';
35
+	public $error = '';
36 36
 
37 37
 	/**
38 38
 	 * @var string[]	Array of error strings
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 	/**
43 43
 	 * Tableau des serveurs (IP addresses ou nom d'hotes)
44 44
 	 */
45
-	var $server=array();
45
+	var $server = array();
46 46
 
47 47
 	/**
48 48
 	 * Base DN (e.g. "dc=foo,dc=com")
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	var $uacf;
98 98
 	var $pwdlastset;
99 99
 
100
-	var $ldapcharset='UTF-8';	// LDAP should be UTF-8 encoded
100
+	var $ldapcharset = 'UTF-8'; // LDAP should be UTF-8 encoded
101 101
 
102 102
 
103 103
 	/**
@@ -118,8 +118,8 @@  discard block
 block discarded – undo
118 118
 		global $conf;
119 119
 
120 120
 		// Server
121
-		if (! empty($conf->global->LDAP_SERVER_HOST))       $this->server[] = $conf->global->LDAP_SERVER_HOST;
122
-		if (! empty($conf->global->LDAP_SERVER_HOST_SLAVE)) $this->server[] = $conf->global->LDAP_SERVER_HOST_SLAVE;
121
+		if (!empty($conf->global->LDAP_SERVER_HOST))       $this->server[] = $conf->global->LDAP_SERVER_HOST;
122
+		if (!empty($conf->global->LDAP_SERVER_HOST_SLAVE)) $this->server[] = $conf->global->LDAP_SERVER_HOST_SLAVE;
123 123
 		$this->serverPort          = $conf->global->LDAP_SERVER_PORT;
124 124
 		$this->ldapProtocolVersion = $conf->global->LDAP_SERVER_PROTOCOLVERSION;
125 125
 		$this->dn                  = $conf->global->LDAP_SERVER_DN;
@@ -130,8 +130,8 @@  discard block
 block discarded – undo
130 130
 		$this->people              = $conf->global->LDAP_USER_DN;
131 131
 		$this->groups              = $conf->global->LDAP_GROUP_DN;
132 132
 
133
-		$this->filter              = $conf->global->LDAP_FILTER_CONNECTION;	// Filter on user
134
-		$this->filtermember        = $conf->global->LDAP_MEMBER_FILTER;		// Filter on member
133
+		$this->filter              = $conf->global->LDAP_FILTER_CONNECTION; // Filter on user
134
+		$this->filtermember        = $conf->global->LDAP_MEMBER_FILTER; // Filter on member
135 135
 
136 136
 		// Users
137 137
 		$this->attr_login      = $conf->global->LDAP_FIELD_LOGIN; //unix
@@ -162,22 +162,22 @@  discard block
 block discarded – undo
162 162
         // phpcs:enable
163 163
 		global $langs, $conf;
164 164
 
165
-		$connected=0;
166
-		$this->bind=0;
165
+		$connected = 0;
166
+		$this->bind = 0;
167 167
 
168 168
 		// Check parameters
169 169
 		if (count($this->server) == 0 || empty($this->server[0]))
170 170
 		{
171
-			$this->error='LDAP setup (file conf.php) is not complete';
171
+			$this->error = 'LDAP setup (file conf.php) is not complete';
172 172
 			dol_syslog(get_class($this)."::connect_bind ".$this->error, LOG_WARNING);
173 173
 			return -1;
174 174
 		}
175 175
 
176
-		if (! function_exists("ldap_connect"))
176
+		if (!function_exists("ldap_connect"))
177 177
 		{
178
-			$this->error='LDAPFunctionsNotAvailableOnPHP';
178
+			$this->error = 'LDAPFunctionsNotAvailableOnPHP';
179 179
 			dol_syslog(get_class($this)."::connect_bind ".$this->error, LOG_WARNING);
180
-			$return=-1;
180
+			$return = -1;
181 181
 		}
182 182
 
183 183
 		if (empty($this->error))
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
196 196
 				if (is_resource($this->connection))
197 197
 				{
198 198
 					// Begin TLS if requested by the configuration
199
-					if (! empty($conf->global->LDAP_SERVER_USE_TLS))
199
+					if (!empty($conf->global->LDAP_SERVER_USE_TLS))
200 200
 					{
201
-						if (! ldap_start_tls($this->connection))
201
+						if (!ldap_start_tls($this->connection))
202 202
 						{
203 203
 							dol_syslog(get_class($this)."::connect_bind failed to start tls", LOG_WARNING);
204 204
 							$connected = 0;
@@ -213,18 +213,18 @@  discard block
 block discarded – undo
213 213
 
214 214
 					if ($this->serverType == "activedirectory")
215 215
 					{
216
-						$result=$this->setReferrals();
217
-						dol_syslog(get_class($this)."::connect_bind try bindauth for activedirectory on ".$host." user=".$this->searchUser." password=".preg_replace('/./','*',$this->searchPassword),LOG_DEBUG);
218
-						$this->result=$this->bindauth($this->searchUser,$this->searchPassword);
216
+						$result = $this->setReferrals();
217
+						dol_syslog(get_class($this)."::connect_bind try bindauth for activedirectory on ".$host." user=".$this->searchUser." password=".preg_replace('/./', '*', $this->searchPassword), LOG_DEBUG);
218
+						$this->result = $this->bindauth($this->searchUser, $this->searchPassword);
219 219
 						if ($this->result)
220 220
 						{
221
-							$this->bind=$this->result;
222
-							$connected=2;
221
+							$this->bind = $this->result;
222
+							$connected = 2;
223 223
 							break;
224 224
 						}
225 225
 						else
226 226
 						{
227
-							$this->error=ldap_errno($this->connection).' '.ldap_error($this->connection);
227
+							$this->error = ldap_errno($this->connection).' '.ldap_error($this->connection);
228 228
 						}
229 229
 					}
230 230
 					else
@@ -232,51 +232,51 @@  discard block
 block discarded – undo
232 232
 						// Try in auth mode
233 233
 						if ($this->searchUser && $this->searchPassword)
234 234
 						{
235
-							dol_syslog(get_class($this)."::connect_bind try bindauth on ".$host." user=".$this->searchUser." password=".preg_replace('/./','*',$this->searchPassword),LOG_DEBUG);
236
-							$this->result=$this->bindauth($this->searchUser,$this->searchPassword);
235
+							dol_syslog(get_class($this)."::connect_bind try bindauth on ".$host." user=".$this->searchUser." password=".preg_replace('/./', '*', $this->searchPassword), LOG_DEBUG);
236
+							$this->result = $this->bindauth($this->searchUser, $this->searchPassword);
237 237
 							if ($this->result)
238 238
 							{
239
-								$this->bind=$this->result;
240
-								$connected=2;
239
+								$this->bind = $this->result;
240
+								$connected = 2;
241 241
 								break;
242 242
 							}
243 243
 							else
244 244
 							{
245
-								$this->error=ldap_errno($this->connection).' '.ldap_error($this->connection);
245
+								$this->error = ldap_errno($this->connection).' '.ldap_error($this->connection);
246 246
 							}
247 247
 						}
248 248
 						// Try in anonymous
249
-						if (! $this->bind)
249
+						if (!$this->bind)
250 250
 						{
251
-							dol_syslog(get_class($this)."::connect_bind try bind on ".$host,LOG_DEBUG);
252
-							$result=$this->bind();
251
+							dol_syslog(get_class($this)."::connect_bind try bind on ".$host, LOG_DEBUG);
252
+							$result = $this->bind();
253 253
 							if ($result)
254 254
 							{
255
-								$this->bind=$this->result;
256
-								$connected=1;
255
+								$this->bind = $this->result;
256
+								$connected = 1;
257 257
 								break;
258 258
 							}
259 259
 							else
260 260
 							{
261
-								$this->error=ldap_errno($this->connection).' '.ldap_error($this->connection);
261
+								$this->error = ldap_errno($this->connection).' '.ldap_error($this->connection);
262 262
 							}
263 263
 						}
264 264
 					}
265 265
 				}
266 266
 
267
-				if (! $connected) $this->close();
267
+				if (!$connected) $this->close();
268 268
 			}
269 269
 		}
270 270
 
271 271
 		if ($connected)
272 272
 		{
273
-			$return=$connected;
273
+			$return = $connected;
274 274
 			dol_syslog(get_class($this)."::connect_bind return=".$return, LOG_DEBUG);
275 275
 		}
276 276
 		else
277 277
 		{
278
-			$this->error='Failed to connect to LDAP'.($this->error?': '.$this->error:'');
279
-			$return=-1;
278
+			$this->error = 'Failed to connect to LDAP'.($this->error ? ': '.$this->error : '');
279
+			$return = -1;
280 280
 			dol_syslog(get_class($this)."::connect_bind return=".$return.' - '.$this->error, LOG_WARNING);
281 281
 		}
282 282
 		return $return;
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
 	 */
293 293
 	function close()
294 294
 	{
295
-		if ($this->connection && ! @ldap_close($this->connection))
295
+		if ($this->connection && !@ldap_close($this->connection))
296 296
 		{
297 297
 			return false;
298 298
 		}
@@ -310,11 +310,11 @@  discard block
 block discarded – undo
310 310
 	 */
311 311
 	function bind()
312 312
 	{
313
-		if (! $this->result=@ldap_bind($this->connection))
313
+		if (!$this->result = @ldap_bind($this->connection))
314 314
 		{
315 315
 			$this->ldapErrorCode = ldap_errno($this->connection);
316 316
 			$this->ldapErrorText = ldap_error($this->connection);
317
-			$this->error=$this->ldapErrorCode." ".$this->ldapErrorText;
317
+			$this->error = $this->ldapErrorCode." ".$this->ldapErrorText;
318 318
 			return false;
319 319
 		}
320 320
 		else
@@ -333,13 +333,13 @@  discard block
 block discarded – undo
333 333
 	 * @param	string	$pass			Password
334 334
 	 * @return	boolean					true or false
335 335
 	 */
336
-	function bindauth($bindDn,$pass)
336
+	function bindauth($bindDn, $pass)
337 337
 	{
338
-		if (! $this->result = @ldap_bind($this->connection, $bindDn, $pass))
338
+		if (!$this->result = @ldap_bind($this->connection, $bindDn, $pass))
339 339
 		{
340 340
 			$this->ldapErrorCode = ldap_errno($this->connection);
341 341
 			$this->ldapErrorText = ldap_error($this->connection);
342
-			$this->error=$this->ldapErrorCode." ".$this->ldapErrorText;
342
+			$this->error = $this->ldapErrorCode." ".$this->ldapErrorText;
343 343
 			return false;
344 344
 		}
345 345
 		else
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 	 */
356 356
 	function unbind()
357 357
 	{
358
-		if (!$this->result=@ldap_unbind($this->connection))
358
+		if (!$this->result = @ldap_unbind($this->connection))
359 359
 		{
360 360
 			return false;
361 361
 		} else {
@@ -414,31 +414,31 @@  discard block
 block discarded – undo
414 414
 	{
415 415
 		global $conf;
416 416
 
417
-		dol_syslog(get_class($this)."::add dn=".$dn." info=".join(',',$info));
417
+		dol_syslog(get_class($this)."::add dn=".$dn." info=".join(',', $info));
418 418
 
419 419
 		// Check parameters
420
-		if (! $this->connection)
420
+		if (!$this->connection)
421 421
 		{
422
-			$this->error="NotConnected";
422
+			$this->error = "NotConnected";
423 423
 			return -2;
424 424
 		}
425
-		if (! $this->bind)
425
+		if (!$this->bind)
426 426
 		{
427
-			$this->error="NotConnected";
427
+			$this->error = "NotConnected";
428 428
 			return -3;
429 429
 		}
430 430
 
431 431
 		// Encode to LDAP page code
432
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
433
-		foreach($info as $key => $val)
432
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
433
+		foreach ($info as $key => $val)
434 434
 		{
435
-			if (! is_array($val)) $info[$key]=$this->convFromOutputCharset($val,$this->ldapcharset);
435
+			if (!is_array($val)) $info[$key] = $this->convFromOutputCharset($val, $this->ldapcharset);
436 436
 		}
437 437
 
438
-		$this->dump($dn,$info);
438
+		$this->dump($dn, $info);
439 439
 
440 440
 		//print_r($info);
441
-		$result=@ldap_add($this->connection, $dn, $info);
441
+		$result = @ldap_add($this->connection, $dn, $info);
442 442
 
443 443
 		if ($result)
444 444
 		{
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
 		{
450 450
 			$this->ldapErrorCode = @ldap_errno($this->connection);
451 451
 			$this->ldapErrorText = @ldap_error($this->connection);
452
-			$this->error=$this->ldapErrorCode." ".$this->ldapErrorText;
452
+			$this->error = $this->ldapErrorCode." ".$this->ldapErrorText;
453 453
 			dol_syslog(get_class($this)."::add failed: ".$this->error, LOG_ERR);
454 454
 			return -1;
455 455
 		}
@@ -468,31 +468,31 @@  discard block
 block discarded – undo
468 468
 	{
469 469
 		global $conf;
470 470
 
471
-		dol_syslog(get_class($this)."::modify dn=".$dn." info=".join(',',$info));
471
+		dol_syslog(get_class($this)."::modify dn=".$dn." info=".join(',', $info));
472 472
 
473 473
 		// Check parameters
474
-		if (! $this->connection)
474
+		if (!$this->connection)
475 475
 		{
476
-			$this->error="NotConnected";
476
+			$this->error = "NotConnected";
477 477
 			return -2;
478 478
 		}
479
-		if (! $this->bind)
479
+		if (!$this->bind)
480 480
 		{
481
-			$this->error="NotConnected";
481
+			$this->error = "NotConnected";
482 482
 			return -3;
483 483
 		}
484 484
 
485 485
 		// Encode to LDAP page code
486
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
487
-		foreach($info as $key => $val)
486
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
487
+		foreach ($info as $key => $val)
488 488
 		{
489
-			if (! is_array($val)) $info[$key]=$this->convFromOutputCharset($val,$this->ldapcharset);
489
+			if (!is_array($val)) $info[$key] = $this->convFromOutputCharset($val, $this->ldapcharset);
490 490
 		}
491 491
 
492
-		$this->dump($dn,$info);
492
+		$this->dump($dn, $info);
493 493
 
494 494
 		//print_r($info);
495
-		$result=@ldap_modify($this->connection, $dn, $info);
495
+		$result = @ldap_modify($this->connection, $dn, $info);
496 496
 
497 497
 		if ($result)
498 498
 		{
@@ -501,7 +501,7 @@  discard block
 block discarded – undo
501 501
 		}
502 502
 		else
503 503
 		{
504
-			$this->error=@ldap_error($this->connection);
504
+			$this->error = @ldap_error($this->connection);
505 505
 			dol_syslog(get_class($this)."::modify failed: ".$this->error, LOG_ERR);
506 506
 			return -1;
507 507
 		}
@@ -522,27 +522,27 @@  discard block
 block discarded – undo
522 522
 	{
523 523
 		global $conf;
524 524
 
525
-		dol_syslog(get_class($this)."::modify dn=".$dn." newrdn=".$newrdn." newparent=".$newparent." deleteoldrdn=".($deleteoldrdn?1:0));
525
+		dol_syslog(get_class($this)."::modify dn=".$dn." newrdn=".$newrdn." newparent=".$newparent." deleteoldrdn=".($deleteoldrdn ? 1 : 0));
526 526
 
527 527
 		// Check parameters
528
-		if (! $this->connection)
528
+		if (!$this->connection)
529 529
 		{
530
-			$this->error="NotConnected";
530
+			$this->error = "NotConnected";
531 531
 			return -2;
532 532
 		}
533
-		if (! $this->bind)
533
+		if (!$this->bind)
534 534
 		{
535
-			$this->error="NotConnected";
535
+			$this->error = "NotConnected";
536 536
 			return -3;
537 537
 		}
538 538
 
539 539
 		// Encode to LDAP page code
540
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
541
-		$newrdn=$this->convFromOutputCharset($newrdn,$this->ldapcharset);
542
-		$newparent=$this->convFromOutputCharset($newparent,$this->ldapcharset);
540
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
541
+		$newrdn = $this->convFromOutputCharset($newrdn, $this->ldapcharset);
542
+		$newparent = $this->convFromOutputCharset($newparent, $this->ldapcharset);
543 543
 
544 544
 		//print_r($info);
545
-		$result=@ldap_rename($this->connection, $dn, $newrdn, $newparent, $deleteoldrdn);
545
+		$result = @ldap_rename($this->connection, $dn, $newrdn, $newparent, $deleteoldrdn);
546 546
 
547 547
 		if ($result)
548 548
 		{
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
 		}
552 552
 		else
553 553
 		{
554
-			$this->error=@ldap_error($this->connection);
554
+			$this->error = @ldap_error($this->connection);
555 555
 			dol_syslog(get_class($this)."::rename failed: ".$this->error, LOG_ERR);
556 556
 			return -1;
557 557
 		}
@@ -569,27 +569,27 @@  discard block
 block discarded – undo
569 569
 	 *	@param	string	$newparent	New parent (ou=xxx,dc=aaa,dc=bbb) (for ldap_rename)
570 570
 	 *	@return	int					<0 if KO, >0 if OK
571 571
 	 */
572
-	function update($dn, $info, $user, $olddn, $newrdn=false, $newparent=false)
572
+	function update($dn, $info, $user, $olddn, $newrdn = false, $newparent = false)
573 573
 	{
574 574
 		global $conf;
575 575
 
576 576
 		dol_syslog(get_class($this)."::update dn=".$dn." olddn=".$olddn);
577 577
 
578 578
 		// Check parameters
579
-		if (! $this->connection)
579
+		if (!$this->connection)
580 580
 		{
581
-			$this->error="NotConnected";
581
+			$this->error = "NotConnected";
582 582
 			return -2;
583 583
 		}
584
-		if (! $this->bind)
584
+		if (!$this->bind)
585 585
 		{
586
-			$this->error="NotConnected";
586
+			$this->error = "NotConnected";
587 587
 			return -3;
588 588
 		}
589 589
 
590
-		if (! $olddn || $olddn != $dn)
590
+		if (!$olddn || $olddn != $dn)
591 591
 		{
592
-			if (! empty($olddn) && ! empty($newrdn) && ! empty($newparent) && $conf->global->LDAP_SERVER_PROTOCOLVERSION === '3')
592
+			if (!empty($olddn) && !empty($newrdn) && !empty($newparent) && $conf->global->LDAP_SERVER_PROTOCOLVERSION === '3')
593 593
 			{
594 594
 				// This function currently only works with LDAPv3
595 595
 				$result = $this->rename($olddn, $newrdn, $newparent, $user, true);
@@ -598,19 +598,19 @@  discard block
 block discarded – undo
598 598
 			{
599 599
 				// If change we make is rename the key of LDAP record, we create new one and if ok, we delete old one.
600 600
 				$result = $this->add($dn, $info, $user);
601
-				if ($result > 0 && $olddn && $olddn != $dn) $result = $this->delete($olddn);	// If add fails, we do not try to delete old one
601
+				if ($result > 0 && $olddn && $olddn != $dn) $result = $this->delete($olddn); // If add fails, we do not try to delete old one
602 602
 			}
603 603
 		}
604 604
 		else
605 605
 		{
606 606
 			//$result = $this->delete($olddn);
607
-			$result = $this->add($dn, $info, $user);	// If record has been deleted from LDAP, we recreate it. We ignore error if it already exists.
608
-			$result = $this->modify($dn, $info, $user);	// We use add/modify instead of delete/add when olddn is received
607
+			$result = $this->add($dn, $info, $user); // If record has been deleted from LDAP, we recreate it. We ignore error if it already exists.
608
+			$result = $this->modify($dn, $info, $user); // We use add/modify instead of delete/add when olddn is received
609 609
 		}
610 610
 		if ($result <= 0)
611 611
 		{
612 612
 			$this->error = ldap_errno($this->connection)." ".ldap_error($this->connection)." ".$this->error;
613
-			dol_syslog(get_class($this)."::update ".$this->error,LOG_ERR);
613
+			dol_syslog(get_class($this)."::update ".$this->error, LOG_ERR);
614 614
 			//print_r($info);
615 615
 			return -1;
616 616
 		}
@@ -636,21 +636,21 @@  discard block
 block discarded – undo
636 636
 		dol_syslog(get_class($this)."::delete Delete LDAP entry dn=".$dn);
637 637
 
638 638
 		// Check parameters
639
-		if (! $this->connection)
639
+		if (!$this->connection)
640 640
 		{
641
-			$this->error="NotConnected";
641
+			$this->error = "NotConnected";
642 642
 			return -2;
643 643
 		}
644
-		if (! $this->bind)
644
+		if (!$this->bind)
645 645
 		{
646
-			$this->error="NotConnected";
646
+			$this->error = "NotConnected";
647 647
 			return -3;
648 648
 		}
649 649
 
650 650
 		// Encode to LDAP page code
651
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
651
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
652 652
 
653
-		$result=@ldap_delete($this->connection, $dn);
653
+		$result = @ldap_delete($this->connection, $dn);
654 654
 
655 655
 		if ($result) return 1;
656 656
 		return -1;
@@ -667,33 +667,33 @@  discard block
 block discarded – undo
667 667
 	function dump_content($dn, $info)
668 668
 	{
669 669
         // phpcs:enable
670
-		$content='';
670
+		$content = '';
671 671
 
672 672
 		// Create file content
673
-		if (preg_match('/^ldap/',$this->server[0]))
673
+		if (preg_match('/^ldap/', $this->server[0]))
674 674
 		{
675
-			$target="-H ".join(',',$this->server);
675
+			$target = "-H ".join(',', $this->server);
676 676
 		}
677 677
 		else
678 678
 		{
679
-			$target="-h ".join(',',$this->server)." -p ".$this->serverPort;
679
+			$target = "-h ".join(',', $this->server)." -p ".$this->serverPort;
680 680
 		}
681
-		$content.="# ldapadd $target -c -v -D ".$this->searchUser." -W -f ldapinput.in\n";
682
-		$content.="# ldapmodify $target -c -v -D ".$this->searchUser." -W -f ldapinput.in\n";
683
-		$content.="# ldapdelete $target -c -v -D ".$this->searchUser." -W -f ldapinput.in\n";
684
-		if (in_array('localhost',$this->server)) $content.="# If commands fails to connect, try without -h and -p\n";
685
-		$content.="dn: ".$dn."\n";
686
-		foreach($info as $key => $value)
681
+		$content .= "# ldapadd $target -c -v -D ".$this->searchUser." -W -f ldapinput.in\n";
682
+		$content .= "# ldapmodify $target -c -v -D ".$this->searchUser." -W -f ldapinput.in\n";
683
+		$content .= "# ldapdelete $target -c -v -D ".$this->searchUser." -W -f ldapinput.in\n";
684
+		if (in_array('localhost', $this->server)) $content .= "# If commands fails to connect, try without -h and -p\n";
685
+		$content .= "dn: ".$dn."\n";
686
+		foreach ($info as $key => $value)
687 687
 		{
688
-			if (! is_array($value))
688
+			if (!is_array($value))
689 689
 			{
690
-				$content.="$key: $value\n";
690
+				$content .= "$key: $value\n";
691 691
 			}
692 692
 			else
693 693
 			{
694
-				foreach($value as $valuekey => $valuevalue)
694
+				foreach ($value as $valuekey => $valuevalue)
695 695
 				{
696
-					$content.="$key: $valuevalue\n";
696
+					$content .= "$key: $valuevalue\n";
697 697
 				}
698 698
 			}
699 699
 		}
@@ -712,18 +712,18 @@  discard block
 block discarded – undo
712 712
 		global $conf;
713 713
 
714 714
 		// Create content
715
-		$content=$this->dump_content($dn, $info);
715
+		$content = $this->dump_content($dn, $info);
716 716
 
717 717
 		//Create file
718
-		$result=dol_mkdir($conf->ldap->dir_temp);
718
+		$result = dol_mkdir($conf->ldap->dir_temp);
719 719
 
720
-		$outputfile=$conf->ldap->dir_temp.'/ldapinput.in';
721
-		$fp=fopen($outputfile,"w");
720
+		$outputfile = $conf->ldap->dir_temp.'/ldapinput.in';
721
+		$fp = fopen($outputfile, "w");
722 722
 		if ($fp)
723 723
 		{
724 724
 			fputs($fp, $content);
725 725
 			fclose($fp);
726
-			if (! empty($conf->global->MAIN_UMASK))
726
+			if (!empty($conf->global->MAIN_UMASK))
727 727
 			@chmod($outputfile, octdec($conf->global->MAIN_UMASK));
728 728
 			return 1;
729 729
 		}
@@ -741,14 +741,14 @@  discard block
 block discarded – undo
741 741
 	 * @param int		$timeout		Timeout in second (default 1s)
742 742
 	 * @return boolean				true or false
743 743
 	 */
744
-	function serverPing($host, $port=389, $timeout=1)
744
+	function serverPing($host, $port = 389, $timeout = 1)
745 745
 	{
746 746
 		// Replace ldaps:// by ssl://
747
-		if (preg_match('/^ldaps:\/\/([^\/]+)\/?$/',$host, $regs)) {
747
+		if (preg_match('/^ldaps:\/\/([^\/]+)\/?$/', $host, $regs)) {
748 748
 			$host = 'ssl://'.$regs[1];
749 749
 		}
750 750
 		// Remove ldap://
751
-		if (preg_match('/^ldap:\/\/([^\/]+)\/?$/',$host, $regs)) {
751
+		if (preg_match('/^ldap:\/\/([^\/]+)\/?$/', $host, $regs)) {
752 752
 			$host = $regs[1];
753 753
 		}
754 754
 		$op = @fsockopen($host, $port, $errno, $errstr, $timeout);
@@ -775,31 +775,31 @@  discard block
 block discarded – undo
775 775
 	{
776 776
 		global $conf;
777 777
 
778
-		dol_syslog(get_class($this)."::addAttribute dn=".$dn." info=".join(',',$info));
778
+		dol_syslog(get_class($this)."::addAttribute dn=".$dn." info=".join(',', $info));
779 779
 
780 780
 		// Check parameters
781
-		if (! $this->connection)
781
+		if (!$this->connection)
782 782
 		{
783
-			$this->error="NotConnected";
783
+			$this->error = "NotConnected";
784 784
 			return -2;
785 785
 		}
786
-		if (! $this->bind)
786
+		if (!$this->bind)
787 787
 		{
788
-			$this->error="NotConnected";
788
+			$this->error = "NotConnected";
789 789
 			return -3;
790 790
 		}
791 791
 
792 792
 		// Encode to LDAP page code
793
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
794
-		foreach($info as $key => $val)
793
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
794
+		foreach ($info as $key => $val)
795 795
 		{
796
-			if (! is_array($val)) $info[$key]=$this->convFromOutputCharset($val,$this->ldapcharset);
796
+			if (!is_array($val)) $info[$key] = $this->convFromOutputCharset($val, $this->ldapcharset);
797 797
 		}
798 798
 
799
-		$this->dump($dn,$info);
799
+		$this->dump($dn, $info);
800 800
 
801 801
 		//print_r($info);
802
-		$result=@ldap_mod_add($this->connection, $dn, $info);
802
+		$result = @ldap_mod_add($this->connection, $dn, $info);
803 803
 
804 804
 		if ($result)
805 805
 		{
@@ -808,7 +808,7 @@  discard block
 block discarded – undo
808 808
 		}
809 809
 		else
810 810
 		{
811
-			$this->error=@ldap_error($this->connection);
811
+			$this->error = @ldap_error($this->connection);
812 812
 			dol_syslog(get_class($this)."::add_attribute failed: ".$this->error, LOG_ERR);
813 813
 			return -1;
814 814
 		}
@@ -827,31 +827,31 @@  discard block
 block discarded – undo
827 827
 	{
828 828
 		global $conf;
829 829
 
830
-		dol_syslog(get_class($this)."::updateAttribute dn=".$dn." info=".join(',',$info));
830
+		dol_syslog(get_class($this)."::updateAttribute dn=".$dn." info=".join(',', $info));
831 831
 
832 832
 		// Check parameters
833
-		if (! $this->connection)
833
+		if (!$this->connection)
834 834
 		{
835
-			$this->error="NotConnected";
835
+			$this->error = "NotConnected";
836 836
 			return -2;
837 837
 		}
838
-		if (! $this->bind)
838
+		if (!$this->bind)
839 839
 		{
840
-			$this->error="NotConnected";
840
+			$this->error = "NotConnected";
841 841
 			return -3;
842 842
 		}
843 843
 
844 844
 		// Encode to LDAP page code
845
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
846
-		foreach($info as $key => $val)
845
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
846
+		foreach ($info as $key => $val)
847 847
 		{
848
-			if (! is_array($val)) $info[$key]=$this->convFromOutputCharset($val,$this->ldapcharset);
848
+			if (!is_array($val)) $info[$key] = $this->convFromOutputCharset($val, $this->ldapcharset);
849 849
 		}
850 850
 
851
-		$this->dump($dn,$info);
851
+		$this->dump($dn, $info);
852 852
 
853 853
 		//print_r($info);
854
-		$result=@ldap_mod_replace($this->connection, $dn, $info);
854
+		$result = @ldap_mod_replace($this->connection, $dn, $info);
855 855
 
856 856
 		if ($result)
857 857
 		{
@@ -860,7 +860,7 @@  discard block
 block discarded – undo
860 860
 		}
861 861
 		else
862 862
 		{
863
-			$this->error=@ldap_error($this->connection);
863
+			$this->error = @ldap_error($this->connection);
864 864
 			dol_syslog(get_class($this)."::updateAttribute failed: ".$this->error, LOG_ERR);
865 865
 			return -1;
866 866
 		}
@@ -879,31 +879,31 @@  discard block
 block discarded – undo
879 879
 	{
880 880
 		global $conf;
881 881
 
882
-		dol_syslog(get_class($this)."::deleteAttribute dn=".$dn." info=".join(',',$info));
882
+		dol_syslog(get_class($this)."::deleteAttribute dn=".$dn." info=".join(',', $info));
883 883
 
884 884
 		// Check parameters
885
-		if (! $this->connection)
885
+		if (!$this->connection)
886 886
 		{
887
-			$this->error="NotConnected";
887
+			$this->error = "NotConnected";
888 888
 			return -2;
889 889
 		}
890
-		if (! $this->bind)
890
+		if (!$this->bind)
891 891
 		{
892
-			$this->error="NotConnected";
892
+			$this->error = "NotConnected";
893 893
 			return -3;
894 894
 		}
895 895
 
896 896
 		// Encode to LDAP page code
897
-		$dn=$this->convFromOutputCharset($dn,$this->ldapcharset);
898
-		foreach($info as $key => $val)
897
+		$dn = $this->convFromOutputCharset($dn, $this->ldapcharset);
898
+		foreach ($info as $key => $val)
899 899
 		{
900
-			if (! is_array($val)) $info[$key]=$this->convFromOutputCharset($val,$this->ldapcharset);
900
+			if (!is_array($val)) $info[$key] = $this->convFromOutputCharset($val, $this->ldapcharset);
901 901
 		}
902 902
 
903
-		$this->dump($dn,$info);
903
+		$this->dump($dn, $info);
904 904
 
905 905
 		//print_r($info);
906
-		$result=@ldap_mod_del($this->connection, $dn, $info);
906
+		$result = @ldap_mod_del($this->connection, $dn, $info);
907 907
 
908 908
 		if ($result)
909 909
 		{
@@ -912,7 +912,7 @@  discard block
 block discarded – undo
912 912
 		}
913 913
 		else
914 914
 		{
915
-			$this->error=@ldap_error($this->connection);
915
+			$this->error = @ldap_error($this->connection);
916 916
 			dol_syslog(get_class($this)."::deleteAttribute failed: ".$this->error, LOG_ERR);
917 917
 			return -1;
918 918
 		}
@@ -925,21 +925,21 @@  discard block
 block discarded – undo
925 925
 	 *	@param	string	$filter		Filter
926 926
 	 *	@return	int|array			<0 or false if KO, array if OK
927 927
 	 */
928
-	function getAttribute($dn,$filter)
928
+	function getAttribute($dn, $filter)
929 929
 	{
930 930
 		// Check parameters
931
-		if (! $this->connection)
931
+		if (!$this->connection)
932 932
 		{
933
-			$this->error="NotConnected";
933
+			$this->error = "NotConnected";
934 934
 			return -2;
935 935
 		}
936
-		if (! $this->bind)
936
+		if (!$this->bind)
937 937
 		{
938
-			$this->error="NotConnected";
938
+			$this->error = "NotConnected";
939 939
 			return -3;
940 940
 		}
941 941
 
942
-		$search = ldap_search($this->connection,$dn,$filter);
942
+		$search = ldap_search($this->connection, $dn, $filter);
943 943
 
944 944
 		// Only one entry should ever be returned
945 945
 		$entry = ldap_first_entry($this->connection, $search);
@@ -948,11 +948,11 @@  discard block
 block discarded – undo
948 948
 		{
949 949
 			$this->ldapErrorCode = -1;
950 950
 			$this->ldapErrorText = "Couldn't find entry";
951
-			return 0;  // Couldn't find entry...
951
+			return 0; // Couldn't find entry...
952 952
 		}
953 953
 
954 954
 		// Get values
955
-		if (! $values = ldap_get_attributes($this->connection, $entry))
955
+		if (!$values = ldap_get_attributes($this->connection, $entry))
956 956
 		{
957 957
 			$this->ldapErrorCode = ldap_errno($this->connection);
958 958
 			$this->ldapErrorText = ldap_error($this->connection);
@@ -970,13 +970,13 @@  discard block
 block discarded – undo
970 970
 	 * 	@param	string	$attribute			Attributes
971 971
 	 * 	@return void
972 972
 	 */
973
-	function getAttributeValues($filterrecord,$attribute)
973
+	function getAttributeValues($filterrecord, $attribute)
974 974
 	{
975
-		$attributes=array();
975
+		$attributes = array();
976 976
 		$attributes[0] = $attribute;
977 977
 
978 978
 		// We need to search for this user in order to get their entry.
979
-		$this->result = @ldap_search($this->connection,$this->people,$filterrecord,$attributes);
979
+		$this->result = @ldap_search($this->connection, $this->people, $filterrecord, $attributes);
980 980
 
981 981
 		// Pourquoi cette ligne ?
982 982
 		//$info = ldap_get_entries($this->connection, $this->result);
@@ -988,11 +988,11 @@  discard block
 block discarded – undo
988 988
 		{
989 989
 			$this->ldapErrorCode = -1;
990 990
 			$this->ldapErrorText = "Couldn't find user";
991
-			return false;  // Couldn't find the user...
991
+			return false; // Couldn't find the user...
992 992
 		}
993 993
 
994 994
 		// Get values
995
-		if (! $values = @ldap_get_values($this->connection, $entry, $attribute))
995
+		if (!$values = @ldap_get_values($this->connection, $entry, $attribute))
996 996
 		{
997 997
 			$this->ldapErrorCode = ldap_errno($this->connection);
998 998
 			$this->ldapErrorText = ldap_error($this->connection);
@@ -1015,11 +1015,11 @@  discard block
 block discarded – undo
1015 1015
 	 *	@param	array	$attributeAsArray 	Array of fields wanted as an array not a string
1016 1016
 	 *	@return	array						Array of [id_record][ldap_field]=value
1017 1017
 	 */
1018
-	function getRecords($search, $userDn, $useridentifier, $attributeArray, $activefilter=0, $attributeAsArray=array())
1018
+	function getRecords($search, $userDn, $useridentifier, $attributeArray, $activefilter = 0, $attributeAsArray = array())
1019 1019
 	{
1020
-		$fulllist=array();
1020
+		$fulllist = array();
1021 1021
 
1022
-		dol_syslog(get_class($this)."::getRecords search=".$search." userDn=".$userDn." useridentifier=".$useridentifier." attributeArray=array(".join(',',$attributeArray).") activefilter=".$activefilter);
1022
+		dol_syslog(get_class($this)."::getRecords search=".$search." userDn=".$userDn." useridentifier=".$useridentifier." attributeArray=array(".join(',', $attributeArray).") activefilter=".$activefilter);
1023 1023
 
1024 1024
 		// if the directory is AD, then bind first with the search user first
1025 1025
 		if ($this->serverType == "activedirectory")
@@ -1029,7 +1029,7 @@  discard block
 block discarded – undo
1029 1029
 		}
1030 1030
 
1031 1031
 		// Define filter
1032
-		if (! empty($activefilter))
1032
+		if (!empty($activefilter))
1033 1033
 		{
1034 1034
 			if (((string) $activefilter == '1' || (string) $activefilter == 'user') && $this->filter)
1035 1035
 			{
@@ -1052,8 +1052,8 @@  discard block
 block discarded – undo
1052 1052
 		if (is_array($attributeArray))
1053 1053
 		{
1054 1054
 			// Return list with required fields
1055
-			$attributeArray=array_values($attributeArray);	// This is to force to have index reordered from 0 (not make ldap_search fails)
1056
-			dol_syslog(get_class($this)."::getRecords connection=".$this->connection." userDn=".$userDn." filter=".$filter. " attributeArray=(".join(',',$attributeArray).")");
1055
+			$attributeArray = array_values($attributeArray); // This is to force to have index reordered from 0 (not make ldap_search fails)
1056
+			dol_syslog(get_class($this)."::getRecords connection=".$this->connection." userDn=".$userDn." filter=".$filter." attributeArray=(".join(',', $attributeArray).")");
1057 1057
 			//var_dump($attributeArray);
1058 1058
 			$this->result = @ldap_search($this->connection, $userDn, $filter, $attributeArray);
1059 1059
 		}
@@ -1077,35 +1077,35 @@  discard block
 block discarded – undo
1077 1077
 
1078 1078
 		for ($i = 0; $i < $info["count"]; $i++)
1079 1079
 		{
1080
-			$recordid=$this->convToOutputCharset($info[$i][$useridentifier][0],$this->ldapcharset);
1080
+			$recordid = $this->convToOutputCharset($info[$i][$useridentifier][0], $this->ldapcharset);
1081 1081
 			if ($recordid)
1082 1082
 			{
1083 1083
 				//print "Found record with key $useridentifier=".$recordid."<br>\n";
1084
-				$fulllist[$recordid][$useridentifier]=$recordid;
1084
+				$fulllist[$recordid][$useridentifier] = $recordid;
1085 1085
 
1086 1086
 				// Add to the array for each attribute in my list
1087 1087
 				$num = count($attributeArray);
1088 1088
 				for ($j = 0; $j < $num; $j++)
1089 1089
 				{
1090
-					$keyattributelower=strtolower($attributeArray[$j]);
1090
+					$keyattributelower = strtolower($attributeArray[$j]);
1091 1091
 					//print " Param ".$attributeArray[$j]."=".$info[$i][$keyattributelower][0]."<br>\n";
1092 1092
 
1093 1093
 					//permet de recuperer le SID avec Active Directory
1094 1094
 					if ($this->serverType == "activedirectory" && $keyattributelower == "objectsid")
1095 1095
 					{
1096 1096
 						$objectsid = $this->getObjectSid($recordid);
1097
-						$fulllist[$recordid][$attributeArray[$j]]    = $objectsid;
1097
+						$fulllist[$recordid][$attributeArray[$j]] = $objectsid;
1098 1098
 					}
1099 1099
 					else
1100 1100
 					{
1101
-						if(in_array($attributeArray[$j], $attributeAsArray) && is_array($info[$i][$keyattributelower])) {
1101
+						if (in_array($attributeArray[$j], $attributeAsArray) && is_array($info[$i][$keyattributelower])) {
1102 1102
 							$valueTab = array();
1103
-							foreach($info[$i][$keyattributelower] as $key => $value) {
1104
-								$valueTab[$key] = $this->convToOutputCharset($value,$this->ldapcharset);
1103
+							foreach ($info[$i][$keyattributelower] as $key => $value) {
1104
+								$valueTab[$key] = $this->convToOutputCharset($value, $this->ldapcharset);
1105 1105
 							}
1106 1106
 							$fulllist[$recordid][$attributeArray[$j]] = $valueTab;
1107 1107
 						} else {
1108
-							$fulllist[$recordid][$attributeArray[$j]] = $this->convToOutputCharset($info[$i][$keyattributelower][0],$this->ldapcharset);
1108
+							$fulllist[$recordid][$attributeArray[$j]] = $this->convToOutputCharset($info[$i][$keyattributelower][0], $this->ldapcharset);
1109 1109
 						}
1110 1110
 					}
1111 1111
 				}
@@ -1125,8 +1125,8 @@  discard block
 block discarded – undo
1125 1125
 	 */
1126 1126
 	function littleEndian($hex)
1127 1127
 	{
1128
-		for ($x=dol_strlen($hex)-2; $x >= 0; $x=$x-2) {
1129
-			$result .= substr($hex,$x,2);
1128
+		for ($x = dol_strlen($hex) - 2; $x >= 0; $x = $x - 2) {
1129
+			$result .= substr($hex, $x, 2);
1130 1130
 		}
1131 1131
 		return $result;
1132 1132
 	}
@@ -1141,7 +1141,7 @@  discard block
 block discarded – undo
1141 1141
 	 */
1142 1142
 	function getObjectSid($ldapUser)
1143 1143
 	{
1144
-		$criteria =  '('.$this->getUserIdentifier().'='.$ldapUser.')';
1144
+		$criteria = '('.$this->getUserIdentifier().'='.$ldapUser.')';
1145 1145
 		$justthese = array("objectsid");
1146 1146
 
1147 1147
 		// if the directory is AD, then bind first with the search user first
@@ -1200,14 +1200,14 @@  discard block
 block discarded – undo
1200 1200
 	 */
1201 1201
 	function binSIDtoText($binsid)
1202 1202
 	{
1203
-		$hex_sid=bin2hex($binsid);
1204
-		$rev = hexdec(substr($hex_sid,0,2));          // Get revision-part of SID
1205
-		$subcount = hexdec(substr($hex_sid,2,2));    // Get count of sub-auth entries
1206
-		$auth = hexdec(substr($hex_sid,4,12));      // SECURITY_NT_AUTHORITY
1203
+		$hex_sid = bin2hex($binsid);
1204
+		$rev = hexdec(substr($hex_sid, 0, 2)); // Get revision-part of SID
1205
+		$subcount = hexdec(substr($hex_sid, 2, 2)); // Get count of sub-auth entries
1206
+		$auth = hexdec(substr($hex_sid, 4, 12)); // SECURITY_NT_AUTHORITY
1207 1207
 		$result = "$rev-$auth";
1208
-		for ($x=0;$x < $subcount; $x++)
1208
+		for ($x = 0; $x < $subcount; $x++)
1209 1209
 		{
1210
-			$result .= "-".hexdec($this->littleEndian(substr($hex_sid,16+($x*8),8)));  // get all SECURITY_NT_AUTHORITY
1210
+			$result .= "-".hexdec($this->littleEndian(substr($hex_sid, 16 + ($x * 8), 8))); // get all SECURITY_NT_AUTHORITY
1211 1211
 		}
1212 1212
 		return $result;
1213 1213
 	}
@@ -1228,8 +1228,8 @@  discard block
 block discarded – undo
1228 1228
 	{
1229 1229
 		dol_syslog(get_class($this)."::search checkDn=".$checkDn." filter=".$filter);
1230 1230
 
1231
-		$checkDn=$this->convFromOutputCharset($checkDn,$this->ldapcharset);
1232
-		$filter=$this->convFromOutputCharset($filter,$this->ldapcharset);
1231
+		$checkDn = $this->convFromOutputCharset($checkDn, $this->ldapcharset);
1232
+		$filter = $this->convFromOutputCharset($filter, $this->ldapcharset);
1233 1233
 
1234 1234
 		// if the directory is AD, then bind first with the search user first
1235 1235
 		if ($this->serverType == "activedirectory") {
@@ -1239,7 +1239,7 @@  discard block
 block discarded – undo
1239 1239
 		$this->result = @ldap_search($this->connection, $checkDn, $filter);
1240 1240
 
1241 1241
 		$result = @ldap_get_entries($this->connection, $this->result);
1242
-		if (! $result)
1242
+		if (!$result)
1243 1243
 		{
1244 1244
 			$this->error = ldap_errno($this->connection)." ".ldap_error($this->connection);
1245 1245
 			return -1;
@@ -1260,7 +1260,7 @@  discard block
 block discarded – undo
1260 1260
 	 *                       	       	Examples: &(objectClass=inetOrgPerson) &(objectClass=user)(objectCategory=person) &(isMemberOf=cn=Sales,ou=Groups,dc=opencsi,dc=com)
1261 1261
 	 *		@return	int					>0 if OK, <0 if KO
1262 1262
 	 */
1263
-	function fetch($user,$filter)
1263
+	function fetch($user, $filter)
1264 1264
 	{
1265 1265
 		// Perform the search and get the entry handles
1266 1266
 
@@ -1269,10 +1269,10 @@  discard block
 block discarded – undo
1269 1269
 			$this->bindauth($this->searchUser, $this->searchPassword);
1270 1270
 		}
1271 1271
 
1272
-		$searchDN = $this->people;    // TODO Why searching in people then domain ?
1272
+		$searchDN = $this->people; // TODO Why searching in people then domain ?
1273 1273
 
1274 1274
 		$result = '';
1275
-		$i=0;
1275
+		$i = 0;
1276 1276
 		while ($i <= 2)
1277 1277
 		{
1278 1278
 			dol_syslog(get_class($this)."::fetch search with searchDN=".$searchDN." filter=".$filter);
@@ -1291,7 +1291,7 @@  discard block
 block discarded – undo
1291 1291
 				return -1;
1292 1292
 			}
1293 1293
 
1294
-			if (! $result)
1294
+			if (!$result)
1295 1295
 			{
1296 1296
 				// Si pas de resultat on cherche dans le domaine
1297 1297
 				$searchDN = $this->domain;
@@ -1303,42 +1303,42 @@  discard block
 block discarded – undo
1303 1303
 			}
1304 1304
 		}
1305 1305
 
1306
-		if (! $result)
1306
+		if (!$result)
1307 1307
 		{
1308 1308
 			$this->error = ldap_errno($this->connection)." ".ldap_error($this->connection);
1309 1309
 			return -1;
1310 1310
 		}
1311 1311
 		else
1312 1312
 		{
1313
-			$this->name       = $this->convToOutputCharset($result[0][$this->attr_name][0],$this->ldapcharset);
1314
-			$this->firstname  = $this->convToOutputCharset($result[0][$this->attr_firstname][0],$this->ldapcharset);
1315
-			$this->login      = $this->convToOutputCharset($result[0][$this->attr_login][0],$this->ldapcharset);
1316
-			$this->phone      = $this->convToOutputCharset($result[0][$this->attr_phone][0],$this->ldapcharset);
1317
-			$this->skype      = $this->convToOutputCharset($result[0][$this->attr_skype][0],$this->ldapcharset);
1318
-			$this->fax        = $this->convToOutputCharset($result[0][$this->attr_fax][0],$this->ldapcharset);
1319
-			$this->mail       = $this->convToOutputCharset($result[0][$this->attr_mail][0],$this->ldapcharset);
1320
-			$this->mobile     = $this->convToOutputCharset($result[0][$this->attr_mobile][0],$this->ldapcharset);
1313
+			$this->name       = $this->convToOutputCharset($result[0][$this->attr_name][0], $this->ldapcharset);
1314
+			$this->firstname  = $this->convToOutputCharset($result[0][$this->attr_firstname][0], $this->ldapcharset);
1315
+			$this->login      = $this->convToOutputCharset($result[0][$this->attr_login][0], $this->ldapcharset);
1316
+			$this->phone      = $this->convToOutputCharset($result[0][$this->attr_phone][0], $this->ldapcharset);
1317
+			$this->skype      = $this->convToOutputCharset($result[0][$this->attr_skype][0], $this->ldapcharset);
1318
+			$this->fax        = $this->convToOutputCharset($result[0][$this->attr_fax][0], $this->ldapcharset);
1319
+			$this->mail       = $this->convToOutputCharset($result[0][$this->attr_mail][0], $this->ldapcharset);
1320
+			$this->mobile     = $this->convToOutputCharset($result[0][$this->attr_mobile][0], $this->ldapcharset);
1321 1321
 
1322
-			$this->uacf       = $this->parseUACF($this->convToOutputCharset($result[0]["useraccountcontrol"][0],$this->ldapcharset));
1322
+			$this->uacf       = $this->parseUACF($this->convToOutputCharset($result[0]["useraccountcontrol"][0], $this->ldapcharset));
1323 1323
 			if (isset($result[0]["pwdlastset"][0]))	// If expiration on password exists
1324 1324
 			{
1325
-				$this->pwdlastset = ($result[0]["pwdlastset"][0] != 0)?$this->convert_time($this->convToOutputCharset($result[0]["pwdlastset"][0],$this->ldapcharset)):0;
1325
+				$this->pwdlastset = ($result[0]["pwdlastset"][0] != 0) ? $this->convert_time($this->convToOutputCharset($result[0]["pwdlastset"][0], $this->ldapcharset)) : 0;
1326 1326
 			}
1327 1327
 			else
1328 1328
 			{
1329 1329
 				$this->pwdlastset = -1;
1330 1330
 			}
1331 1331
 			if (!$this->name && !$this->login) $this->pwdlastset = -1;
1332
-			$this->badpwdtime = $this->convert_time($this->convToOutputCharset($result[0]["badpasswordtime"][0],$this->ldapcharset));
1332
+			$this->badpwdtime = $this->convert_time($this->convToOutputCharset($result[0]["badpasswordtime"][0], $this->ldapcharset));
1333 1333
 
1334 1334
 			// FQDN domain
1335
-			$domain = str_replace('dc=','',$this->domain);
1336
-			$domain = str_replace(',','.',$domain);
1335
+			$domain = str_replace('dc=', '', $this->domain);
1336
+			$domain = str_replace(',', '.', $domain);
1337 1337
 			$this->domainFQDN = $domain;
1338 1338
 
1339 1339
 			// Set ldapUserDn (each user can have a different dn)
1340 1340
 			//var_dump($result[0]);exit;
1341
-			$this->ldapUserDN=$result[0]['dn'];
1341
+			$this->ldapUserDN = $result[0]['dn'];
1342 1342
 
1343 1343
 			ldap_free_result($this->result);
1344 1344
 			return 1;
@@ -1433,7 +1433,7 @@  discard block
 block discarded – undo
1433 1433
 				break;
1434 1434
 			}
1435 1435
 		}
1436
-		if (empty($retval)) $retval = "UNKNOWN_TYPE_" . $samtype;
1436
+		if (empty($retval)) $retval = "UNKNOWN_TYPE_".$samtype;
1437 1437
 
1438 1438
 		return($retval);
1439 1439
 	}
@@ -1448,10 +1448,10 @@  discard block
 block discarded – undo
1448 1448
 	function convert_time($value)
1449 1449
 	{
1450 1450
         // phpcs:enable
1451
-		$dateLargeInt=$value; // nano secondes depuis 1601 !!!!
1451
+		$dateLargeInt = $value; // nano secondes depuis 1601 !!!!
1452 1452
 		$secsAfterADEpoch = $dateLargeInt / (10000000); // secondes depuis le 1 jan 1601
1453
-		$ADToUnixConvertor=((1970-1601) * 365.242190) * 86400; // UNIX start date - AD start date * jours * secondes
1454
-		$unixTimeStamp=intval($secsAfterADEpoch-$ADToUnixConvertor); // Unix time stamp
1453
+		$ADToUnixConvertor = ((1970 - 1601) * 365.242190) * 86400; // UNIX start date - AD start date * jours * secondes
1454
+		$unixTimeStamp = intval($secsAfterADEpoch - $ADToUnixConvertor); // Unix time stamp
1455 1455
 		return $unixTimeStamp;
1456 1456
 	}
1457 1457
 
@@ -1463,11 +1463,11 @@  discard block
 block discarded – undo
1463 1463
 	 *  @param	string	$pagecodefrom	Page code of src string
1464 1464
 	 *  @return string         			Converted string
1465 1465
 	 */
1466
-	private function convToOutputCharset($str,$pagecodefrom='UTF-8')
1466
+	private function convToOutputCharset($str, $pagecodefrom = 'UTF-8')
1467 1467
 	{
1468 1468
 		global $conf;
1469
-		if ($pagecodefrom == 'ISO-8859-1' && $conf->file->character_set_client == 'UTF-8')  $str=utf8_encode($str);
1470
-		if ($pagecodefrom == 'UTF-8' && $conf->file->character_set_client == 'ISO-8859-1')  $str=utf8_decode($str);
1469
+		if ($pagecodefrom == 'ISO-8859-1' && $conf->file->character_set_client == 'UTF-8')  $str = utf8_encode($str);
1470
+		if ($pagecodefrom == 'UTF-8' && $conf->file->character_set_client == 'ISO-8859-1')  $str = utf8_decode($str);
1471 1471
 		return $str;
1472 1472
 	}
1473 1473
 
@@ -1478,11 +1478,11 @@  discard block
 block discarded – undo
1478 1478
 	 *  @param	string	$pagecodeto		Page code for result string
1479 1479
 	 *  @return string         			Converted string
1480 1480
 	 */
1481
-	function convFromOutputCharset($str,$pagecodeto='UTF-8')
1481
+	function convFromOutputCharset($str, $pagecodeto = 'UTF-8')
1482 1482
 	{
1483 1483
 		global $conf;
1484
-		if ($pagecodeto == 'ISO-8859-1' && $conf->file->character_set_client == 'UTF-8') $str=utf8_decode($str);
1485
-		if ($pagecodeto == 'UTF-8' && $conf->file->character_set_client == 'ISO-8859-1') $str=utf8_encode($str);
1484
+		if ($pagecodeto == 'ISO-8859-1' && $conf->file->character_set_client == 'UTF-8') $str = utf8_decode($str);
1485
+		if ($pagecodeto == 'UTF-8' && $conf->file->character_set_client == 'ISO-8859-1') $str = utf8_encode($str);
1486 1486
 		return $str;
1487 1487
 	}
1488 1488
 
@@ -1493,25 +1493,25 @@  discard block
 block discarded – undo
1493 1493
 	 *	@param	string	$keygroup	Key of group
1494 1494
 	 *	@return	int					gid number
1495 1495
 	 */
1496
-	function getNextGroupGid($keygroup='LDAP_KEY_GROUPS')
1496
+	function getNextGroupGid($keygroup = 'LDAP_KEY_GROUPS')
1497 1497
 	{
1498 1498
 		global $conf;
1499 1499
 
1500
-		if (empty($keygroup)) $keygroup='LDAP_KEY_GROUPS';
1500
+		if (empty($keygroup)) $keygroup = 'LDAP_KEY_GROUPS';
1501 1501
 
1502
-		$search='('.$conf->global->$keygroup.'=*)';
1503
-		$result = $this->search($this->groups,$search);
1502
+		$search = '('.$conf->global->$keygroup.'=*)';
1503
+		$result = $this->search($this->groups, $search);
1504 1504
 		if ($result)
1505 1505
 		{
1506 1506
 			$c = $result['count'];
1507 1507
 			$gids = array();
1508
-			for($i=0;$i<$c;$i++)
1508
+			for ($i = 0; $i < $c; $i++)
1509 1509
 			{
1510 1510
 				$gids[] = $result[$i]['gidnumber'][0];
1511 1511
 			}
1512 1512
 			rsort($gids);
1513 1513
 
1514
-			return $gids[0]+1;
1514
+			return $gids[0] + 1;
1515 1515
 		}
1516 1516
 
1517 1517
 		return 0;
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/antivir.class.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	/**
34 34
 	 * @var string Error code (or message)
35 35
 	 */
36
-	public $error='';
36
+	public $error = '';
37 37
 
38 38
 	/**
39 39
 	 * @var string[] Error codes (or messages)
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	 */
58 58
 	function __construct($db)
59 59
 	{
60
-		$this->db=$db;
60
+		$this->db = $db;
61 61
 	}
62 62
 
63 63
     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps
@@ -82,17 +82,17 @@  discard block
 block discarded – undo
82 82
 		    return -97;
83 83
 		}
84 84
 
85
-		$fullcommand=$this->getCliCommand($file);
85
+		$fullcommand = $this->getCliCommand($file);
86 86
 		//$fullcommand='"c:\Program Files (x86)\ClamWin\bin\clamscan.exe" --database="C:\Program Files (x86)\ClamWin\lib" "c:\temp\aaa.txt"';
87
-        $fullcommand.=' 2>&1';      // This is to get error output
87
+        $fullcommand .= ' 2>&1'; // This is to get error output
88 88
 
89
-		$output=array();
90
-		$return_var=0;
91
-        $safemode=ini_get("safe_mode");
89
+		$output = array();
90
+		$return_var = 0;
91
+        $safemode = ini_get("safe_mode");
92 92
 		// Create a clean fullcommand
93
-		dol_syslog("AntiVir::dol_avscan_file Run command=".$fullcommand." with safe_mode ".($safemode?"on":"off"));
93
+		dol_syslog("AntiVir::dol_avscan_file Run command=".$fullcommand." with safe_mode ".($safemode ? "on" : "off"));
94 94
 		// Run CLI command. If run of Windows, you can get return with echo %ERRORLEVEL%
95
-		$lastline=exec($fullcommand, $output, $return_var);
95
+		$lastline = exec($fullcommand, $output, $return_var);
96 96
 
97 97
         //print "x".$lastline." - ".join(',',$output)." - ".$return_var."y";exit;
98 98
 
@@ -126,18 +126,18 @@  discard block
 block discarded – undo
126 126
 		}
127 127
 		*/
128 128
 
129
-		dol_syslog("AntiVir::dol_avscan_file Result return_var=".$return_var." output=".join(',',$output));
129
+		dol_syslog("AntiVir::dol_avscan_file Result return_var=".$return_var." output=".join(',', $output));
130 130
 
131
-		$returncodevirus=1;
131
+		$returncodevirus = 1;
132 132
 		if ($return_var == $returncodevirus)	// Virus found
133 133
 		{
134
-			$this->errors=$output;
134
+			$this->errors = $output;
135 135
 			return -99;
136 136
 		}
137 137
 
138 138
 		if ($return_var > 0)					// If other error
139 139
 		{
140
-			$this->errors=$output;
140
+			$this->errors = $output;
141 141
 			return -98;
142 142
 		}
143 143
 
@@ -157,28 +157,28 @@  discard block
 block discarded – undo
157 157
 	{
158 158
 		global $conf;
159 159
 
160
-		$maxreclevel = 5 ; 			// maximal recursion level
161
-		$maxfiles = 1000; 			// maximal number of files to be scanned within archive
162
-		$maxratio = 200; 			// maximal compression ratio
163
-		$bz2archivememlim = 0; 		// limit memory usage for bzip2 (0/1)
164
-		$maxfilesize = 10485760; 	// archived files larger than this value (in bytes) will not be scanned
160
+		$maxreclevel = 5; // maximal recursion level
161
+		$maxfiles = 1000; // maximal number of files to be scanned within archive
162
+		$maxratio = 200; // maximal compression ratio
163
+		$bz2archivememlim = 0; // limit memory usage for bzip2 (0/1)
164
+		$maxfilesize = 10485760; // archived files larger than this value (in bytes) will not be scanned
165 165
 
166
-		$command=$conf->global->MAIN_ANTIVIRUS_COMMAND;
167
-		$param=$conf->global->MAIN_ANTIVIRUS_PARAM;
166
+		$command = $conf->global->MAIN_ANTIVIRUS_COMMAND;
167
+		$param = $conf->global->MAIN_ANTIVIRUS_PARAM;
168 168
 
169
-		$param=preg_replace('/%maxreclevel/',$maxreclevel,$param);
170
-		$param=preg_replace('/%maxfiles/',$maxfiles,$param);
171
-		$param=preg_replace('/%maxratio/',$maxratio,$param);
172
-		$param=preg_replace('/%bz2archivememlim/',$bz2archivememlim,$param);
173
-		$param=preg_replace('/%maxfilesize/',$maxfilesize,$param);
174
-		$param=preg_replace('/%file/',trim($file),$param);
169
+		$param = preg_replace('/%maxreclevel/', $maxreclevel, $param);
170
+		$param = preg_replace('/%maxfiles/', $maxfiles, $param);
171
+		$param = preg_replace('/%maxratio/', $maxratio, $param);
172
+		$param = preg_replace('/%bz2archivememlim/', $bz2archivememlim, $param);
173
+		$param = preg_replace('/%maxfilesize/', $maxfilesize, $param);
174
+		$param = preg_replace('/%file/', trim($file), $param);
175 175
 
176
-		if (! preg_match('/%file/',$conf->global->MAIN_ANTIVIRUS_PARAM))
177
-			$param=$param." ".escapeshellarg(trim($file));
176
+		if (!preg_match('/%file/', $conf->global->MAIN_ANTIVIRUS_PARAM))
177
+			$param = $param." ".escapeshellarg(trim($file));
178 178
 
179
-		if (preg_match("/\s/",$command)) $command=escapeshellarg($command);	// Use quotes on command. Using escapeshellcmd fails.
179
+		if (preg_match("/\s/", $command)) $command = escapeshellarg($command); // Use quotes on command. Using escapeshellcmd fails.
180 180
 
181
-		$ret=$command.' '.$param;
181
+		$ret = $command.' '.$param;
182 182
 		//$ret=$command.' '.$param.' 2>&1';
183 183
         //print "xx".$ret."xx";exit;
184 184
 
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/commonobject.class.php 1 patch
Spacing   +1526 added lines, -1526 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	/**
61 61
 	 * @var string[]	Array of error strings
62 62
 	 */
63
-	public $errors=array();
63
+	public $errors = array();
64 64
 
65 65
 	/**
66 66
 	 * @var string ID to identify managed object
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	/**
76 76
 	 * @var int    Name of subtable line
77 77
 	 */
78
-	public $table_element_line='';
78
+	public $table_element_line = '';
79 79
 
80 80
 	/**
81 81
 	 * @var string		Key value used to track if data is coming from import wizard
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	/**
86 86
 	 * @var mixed		Contains data to manage extrafields
87 87
 	 */
88
-	public $array_options=array();
88
+	public $array_options = array();
89 89
 
90 90
 	/**
91 91
 	 * @var int[][]		Array of linked objects ids. Loaded by ->fetchObjectLinked
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 	/**
115 115
 	 * @var array<string,mixed>		Can be used to pass information when only object is provided to method
116 116
 	 */
117
-	public $context=array();
117
+	public $context = array();
118 118
 
119 119
 	/**
120 120
 	 * @var string		Contains canvas name if record is an alternative canvas record
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
 	 * @var mixed		Contains comments
375 375
 	 * @see fetchComments()
376 376
 	 */
377
-	public $comments=array();
377
+	public $comments = array();
378 378
 
379 379
 	/**
380 380
 	 * @var int
@@ -400,9 +400,9 @@  discard block
 block discarded – undo
400 400
 	public $civility_id;
401 401
 
402 402
 	// Dates
403
-	public $date_creation;			// Date creation
404
-	public $date_validation;		// Date validation
405
-	public $date_modification;		// Date last change (tms field)
403
+	public $date_creation; // Date creation
404
+	public $date_validation; // Date validation
405
+	public $date_modification; // Date last change (tms field)
406 406
 
407 407
 
408 408
 
@@ -418,29 +418,29 @@  discard block
 block discarded – undo
418 418
 	 *  @param	string	$ref_ext	Ref ext of object to check
419 419
 	 *  @return int     			<0 if KO, 0 if OK but not found, >0 if OK and exists
420 420
 	 */
421
-	static function isExistingObject($element, $id, $ref='', $ref_ext='')
421
+	static function isExistingObject($element, $id, $ref = '', $ref_ext = '')
422 422
 	{
423
-		global $db,$conf;
423
+		global $db, $conf;
424 424
 
425 425
 		$sql = "SELECT rowid, ref, ref_ext";
426
-		$sql.= " FROM ".MAIN_DB_PREFIX.$element;
427
-		$sql.= " WHERE entity IN (".getEntity($element).")" ;
426
+		$sql .= " FROM ".MAIN_DB_PREFIX.$element;
427
+		$sql .= " WHERE entity IN (".getEntity($element).")";
428 428
 
429
-		if ($id > 0) $sql.= " AND rowid = ".$db->escape($id);
430
-		else if ($ref) $sql.= " AND ref = '".$db->escape($ref)."'";
431
-		else if ($ref_ext) $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";
429
+		if ($id > 0) $sql .= " AND rowid = ".$db->escape($id);
430
+		else if ($ref) $sql .= " AND ref = '".$db->escape($ref)."'";
431
+		else if ($ref_ext) $sql .= " AND ref_ext = '".$db->escape($ref_ext)."'";
432 432
 		else {
433
-			$error='ErrorWrongParameters';
433
+			$error = 'ErrorWrongParameters';
434 434
 			dol_print_error(get_class()."::isExistingObject ".$error, LOG_ERR);
435 435
 			return -1;
436 436
 		}
437
-		if ($ref || $ref_ext) $sql.= " AND entity = ".$conf->entity;
437
+		if ($ref || $ref_ext) $sql .= " AND entity = ".$conf->entity;
438 438
 
439 439
 		dol_syslog(get_class()."::isExistingObject", LOG_DEBUG);
440 440
 		$resql = $db->query($sql);
441 441
 		if ($resql)
442 442
 		{
443
-			$num=$db->num_rows($resql);
443
+			$num = $db->num_rows($resql);
444 444
 			if ($num > 0) return 1;
445 445
 			else return 0;
446 446
 		}
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
 	 */
455 455
 	function errorsToString()
456 456
 	{
457
-		return $this->error.(is_array($this->errors)?(($this->error!=''?', ':'').join(', ',$this->errors)):'');
457
+		return $this->error.(is_array($this->errors) ? (($this->error != '' ? ', ' : '').join(', ', $this->errors)) : '');
458 458
 	}
459 459
 
460 460
 	/**
@@ -466,23 +466,23 @@  discard block
 block discarded – undo
466 466
 	 * 	@param	int			$maxlen			Maximum length
467 467
 	 * 	@return	string						String with full name
468 468
 	 */
469
-	function getFullName($langs,$option=0,$nameorder=-1,$maxlen=0)
469
+	function getFullName($langs, $option = 0, $nameorder = -1, $maxlen = 0)
470 470
 	{
471 471
 		//print "lastname=".$this->lastname." name=".$this->name." nom=".$this->nom."<br>\n";
472
-		$lastname=$this->lastname;
473
-		$firstname=$this->firstname;
474
-		if (empty($lastname))  $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));
472
+		$lastname = $this->lastname;
473
+		$firstname = $this->firstname;
474
+		if (empty($lastname))  $lastname = (isset($this->lastname) ? $this->lastname : (isset($this->name) ? $this->name : (isset($this->nom) ? $this->nom : (isset($this->societe) ? $this->societe : (isset($this->company) ? $this->company : '')))));
475 475
 
476
-		$ret='';
476
+		$ret = '';
477 477
 		if ($option && $this->civility_id)
478 478
 		{
479
-			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';
480
-			else $ret.=$this->civility_id.' ';
479
+			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id) != "Civility".$this->civility_id) $ret .= $langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';
480
+			else $ret .= $this->civility_id.' ';
481 481
 		}
482 482
 
483
-		$ret.=dolGetFirstLastname($firstname, $lastname, $nameorder);
483
+		$ret .= dolGetFirstLastname($firstname, $lastname, $nameorder);
484 484
 
485
-		return dol_trunc($ret,$maxlen);
485
+		return dol_trunc($ret, $maxlen);
486 486
 	}
487 487
 
488 488
 	/**
@@ -493,24 +493,24 @@  discard block
 block discarded – undo
493 493
 	 *  @param		int		    $withregion			1=Add region into address string
494 494
 	 *	@return		string							Full address string
495 495
 	 */
496
-	function getFullAddress($withcountry=0, $sep="\n", $withregion=0)
496
+	function getFullAddress($withcountry = 0, $sep = "\n", $withregion = 0)
497 497
 	{
498 498
 		if ($withcountry && $this->country_id && (empty($this->country_code) || empty($this->country)))
499 499
 		{
500
-			require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';
501
-			$tmparray=getCountry($this->country_id,'all');
502
-			$this->country_code=$tmparray['code'];
503
-			$this->country     =$tmparray['label'];
500
+			require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';
501
+			$tmparray = getCountry($this->country_id, 'all');
502
+			$this->country_code = $tmparray['code'];
503
+			$this->country     = $tmparray['label'];
504 504
 		}
505 505
 
506 506
         if ($withregion && $this->state_id && (empty($this->state_code) || empty($this->state) || empty($this->region) || empty($this->region_cpde)))
507 507
     	{
508
-    		require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';
509
-    		$tmparray=getState($this->state_id,'all',0,1);
510
-			$this->state_code   =$tmparray['code'];
511
-			$this->state        =$tmparray['label'];
512
-			$this->region_code  =$tmparray['region_code'];
513
-			$this->region       =$tmparray['region'];
508
+    		require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';
509
+    		$tmparray = getState($this->state_id, 'all', 0, 1);
510
+			$this->state_code   = $tmparray['code'];
511
+			$this->state        = $tmparray['label'];
512
+			$this->region_code  = $tmparray['region_code'];
513
+			$this->region       = $tmparray['region'];
514 514
         }
515 515
 
516 516
 		return dol_format_address($this, $withcountry, $sep);
@@ -528,108 +528,108 @@  discard block
 block discarded – undo
528 528
 	{
529 529
 		global $conf, $langs;
530 530
 
531
-		$countriesusingstate=array('AU','US','IN','GB','ES','UK','TR');    // See also option MAIN_FORCE_STATE_INTO_ADDRESS
531
+		$countriesusingstate = array('AU', 'US', 'IN', 'GB', 'ES', 'UK', 'TR'); // See also option MAIN_FORCE_STATE_INTO_ADDRESS
532 532
 
533
-		$contactid=0;
534
-		$thirdpartyid=0;
533
+		$contactid = 0;
534
+		$thirdpartyid = 0;
535 535
 		if ($this->element == 'societe')
536 536
 		{
537
-			$thirdpartyid=$this->id;
537
+			$thirdpartyid = $this->id;
538 538
 		}
539 539
 		if ($this->element == 'contact')
540 540
 		{
541
-			$contactid=$this->id;
542
-			$thirdpartyid=$object->fk_soc;
541
+			$contactid = $this->id;
542
+			$thirdpartyid = $object->fk_soc;
543 543
 		}
544 544
 		if ($this->element == 'user')
545 545
 		{
546
-			$contactid=$this->contact_id;
547
-			$thirdpartyid=$object->fk_soc;
546
+			$contactid = $this->contact_id;
547
+			$thirdpartyid = $object->fk_soc;
548 548
 		}
549 549
 
550
-		$out='<!-- BEGIN part to show address block -->';
550
+		$out = '<!-- BEGIN part to show address block -->';
551 551
 
552
-		$outdone=0;
553
-		$coords = $this->getFullAddress(1,', ',$conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT);
552
+		$outdone = 0;
553
+		$coords = $this->getFullAddress(1, ', ', $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT);
554 554
 		if ($coords)
555 555
 		{
556
-			if (! empty($conf->use_javascript_ajax))
556
+			if (!empty($conf->use_javascript_ajax))
557 557
 			{
558
-				$namecoords = $this->getFullName($langs,1).'<br>'.$coords;
558
+				$namecoords = $this->getFullName($langs, 1).'<br>'.$coords;
559 559
 				// hideonsmatphone because copyToClipboard call jquery dialog that does not work with jmobile
560
-				$out.='<a href="#" class="hideonsmartphone" onclick="return copyToClipboard(\''.dol_escape_js($namecoords).'\',\''.dol_escape_js($langs->trans("HelpCopyToClipboard")).'\');">';
561
-				$out.=img_picto($langs->trans("Address"), 'object_address.png');
562
-				$out.='</a> ';
560
+				$out .= '<a href="#" class="hideonsmartphone" onclick="return copyToClipboard(\''.dol_escape_js($namecoords).'\',\''.dol_escape_js($langs->trans("HelpCopyToClipboard")).'\');">';
561
+				$out .= img_picto($langs->trans("Address"), 'object_address.png');
562
+				$out .= '</a> ';
563 563
 			}
564
-			$out.=dol_print_address($coords, 'address_'.$htmlkey.'_'.$this->id, $this->element, $this->id, 1, ', '); $outdone++;
564
+			$out .= dol_print_address($coords, 'address_'.$htmlkey.'_'.$this->id, $this->element, $this->id, 1, ', '); $outdone++;
565 565
 			$outdone++;
566 566
 		}
567 567
 
568
-		if (! in_array($this->country_code,$countriesusingstate) && empty($conf->global->MAIN_FORCE_STATE_INTO_ADDRESS)   // If MAIN_FORCE_STATE_INTO_ADDRESS is on, state is already returned previously with getFullAddress
568
+		if (!in_array($this->country_code, $countriesusingstate) && empty($conf->global->MAIN_FORCE_STATE_INTO_ADDRESS)   // If MAIN_FORCE_STATE_INTO_ADDRESS is on, state is already returned previously with getFullAddress
569 569
 				&& empty($conf->global->SOCIETE_DISABLE_STATE) && $this->state)
570 570
 		{
571 571
             if (!empty($conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT) && $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT == 1 && $this->region) {
572
-                $out.=($outdone?' - ':'').$this->region.' - '.$this->state;
572
+                $out .= ($outdone ? ' - ' : '').$this->region.' - '.$this->state;
573 573
             }
574 574
             else {
575
-                $out.=($outdone?' - ':'').$this->state;
575
+                $out .= ($outdone ? ' - ' : '').$this->state;
576 576
             }
577 577
 			$outdone++;
578 578
 		}
579 579
 
580
-		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) $out.=($outdone?'<br>':'');
581
-		if (! empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone
582
-			$out.=dol_print_phone($this->phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;
580
+		if (!empty($this->phone) || !empty($this->phone_pro) || !empty($this->phone_mobile) || !empty($this->phone_perso) || !empty($this->fax) || !empty($this->office_phone) || !empty($this->user_mobile) || !empty($this->office_fax)) $out .= ($outdone ? '<br>' : '');
581
+		if (!empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone
582
+			$out .= dol_print_phone($this->phone, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePro")); $outdone++;
583 583
 		}
584
-		if (! empty($this->phone_pro)) {
585
-			$out.=dol_print_phone($this->phone_pro,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;
584
+		if (!empty($this->phone_pro)) {
585
+			$out .= dol_print_phone($this->phone_pro, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePro")); $outdone++;
586 586
 		}
587
-		if (! empty($this->phone_mobile)) {
588
-			$out.=dol_print_phone($this->phone_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;
587
+		if (!empty($this->phone_mobile)) {
588
+			$out .= dol_print_phone($this->phone_mobile, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'mobile', $langs->trans("PhoneMobile")); $outdone++;
589 589
 		}
590
-		if (! empty($this->phone_perso)) {
591
-			$out.=dol_print_phone($this->phone_perso,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePerso")); $outdone++;
590
+		if (!empty($this->phone_perso)) {
591
+			$out .= dol_print_phone($this->phone_perso, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePerso")); $outdone++;
592 592
 		}
593
-		if (! empty($this->office_phone)) {
594
-			$out.=dol_print_phone($this->office_phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;
593
+		if (!empty($this->office_phone)) {
594
+			$out .= dol_print_phone($this->office_phone, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePro")); $outdone++;
595 595
 		}
596
-		if (! empty($this->user_mobile)) {
597
-			$out.=dol_print_phone($this->user_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;
596
+		if (!empty($this->user_mobile)) {
597
+			$out .= dol_print_phone($this->user_mobile, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'mobile', $langs->trans("PhoneMobile")); $outdone++;
598 598
 		}
599
-		if (! empty($this->fax)) {
600
-			$out.=dol_print_phone($this->fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;
599
+		if (!empty($this->fax)) {
600
+			$out .= dol_print_phone($this->fax, $this->country_code, $contactid, $thirdpartyid, 'AC_FAX', '&nbsp;', 'fax', $langs->trans("Fax")); $outdone++;
601 601
 		}
602
-		if (! empty($this->office_fax)) {
603
-			$out.=dol_print_phone($this->office_fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;
602
+		if (!empty($this->office_fax)) {
603
+			$out .= dol_print_phone($this->office_fax, $this->country_code, $contactid, $thirdpartyid, 'AC_FAX', '&nbsp;', 'fax', $langs->trans("Fax")); $outdone++;
604 604
 		}
605 605
 
606
-		$out.='<div style="clear: both;"></div>';
607
-		$outdone=0;
608
-		if (! empty($this->email))
606
+		$out .= '<div style="clear: both;"></div>';
607
+		$outdone = 0;
608
+		if (!empty($this->email))
609 609
 		{
610
-			$out.=dol_print_email($this->email,$this->id,$object->id,'AC_EMAIL',0,0,1);
610
+			$out .= dol_print_email($this->email, $this->id, $object->id, 'AC_EMAIL', 0, 0, 1);
611 611
 			$outdone++;
612 612
 		}
613
-		if (! empty($this->url))
613
+		if (!empty($this->url))
614 614
 		{
615
-			$out.=dol_print_url($this->url,'_goout',0,1);
615
+			$out .= dol_print_url($this->url, '_goout', 0, 1);
616 616
 			$outdone++;
617 617
 		}
618
-		$out.='<div style="clear: both;">';
619
-		if (! empty($conf->socialnetworks->enabled))
618
+		$out .= '<div style="clear: both;">';
619
+		if (!empty($conf->socialnetworks->enabled))
620 620
 		{
621
-			if ($this->skype) $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');
621
+			if ($this->skype) $out .= dol_print_socialnetworks($this->skype, $this->id, $object->id, 'skype');
622 622
 			$outdone++;
623
-			if ($this->jabberid) $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');
623
+			if ($this->jabberid) $out .= dol_print_socialnetworks($this->jabberid, $this->id, $object->id, 'jabber');
624 624
 			$outdone++;
625
-			if ($this->twitter) $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');
625
+			if ($this->twitter) $out .= dol_print_socialnetworks($this->twitter, $this->id, $object->id, 'twitter');
626 626
 			$outdone++;
627
-			if ($this->facebook) $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');
627
+			if ($this->facebook) $out .= dol_print_socialnetworks($this->facebook, $this->id, $object->id, 'facebook');
628 628
 			$outdone++;
629 629
 		}
630
-		$out.='</div>';
630
+		$out .= '</div>';
631 631
 
632
-		$out.='<!-- END Part to show address block -->';
632
+		$out .= '<!-- END Part to show address block -->';
633 633
 
634 634
 		return $out;
635 635
 	}
@@ -642,17 +642,17 @@  discard block
 block discarded – undo
642 642
 	 * @param	int		$relativelink		0=Return full external link, 1=Return link relative to root of file
643 643
 	 * @return	string						Link or empty string if there is no download link
644 644
 	 */
645
-	function getLastMainDocLink($modulepart, $initsharekey=0, $relativelink=0)
645
+	function getLastMainDocLink($modulepart, $initsharekey = 0, $relativelink = 0)
646 646
 	{
647 647
 		global $user, $dolibarr_main_url_root;
648 648
 
649 649
 		if (empty($this->last_main_doc))
650 650
 		{
651
-			return '';		// No way to known which document name to use
651
+			return ''; // No way to known which document name to use
652 652
 		}
653 653
 
654 654
 		include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';
655
-		$ecmfile=new EcmFiles($this->db);
655
+		$ecmfile = new EcmFiles($this->db);
656 656
 		$result = $ecmfile->fetch(0, '', $this->last_main_doc);
657 657
 		if ($result < 0)
658 658
 		{
@@ -700,26 +700,26 @@  discard block
 block discarded – undo
700 700
 		}
701 701
 
702 702
 		// Define $urlwithroot
703
-		$urlwithouturlroot=preg_replace('/'.preg_quote(DOL_URL_ROOT,'/').'$/i','',trim($dolibarr_main_url_root));
704
-		$urlwithroot=$urlwithouturlroot.DOL_URL_ROOT;		// This is to use external domain name found into config file
703
+		$urlwithouturlroot = preg_replace('/'.preg_quote(DOL_URL_ROOT, '/').'$/i', '', trim($dolibarr_main_url_root));
704
+		$urlwithroot = $urlwithouturlroot.DOL_URL_ROOT; // This is to use external domain name found into config file
705 705
 		//$urlwithroot=DOL_MAIN_URL_ROOT;					// This is to use same domain name than current
706 706
 
707
-		$forcedownload=0;
707
+		$forcedownload = 0;
708 708
 
709
-		$paramlink='';
709
+		$paramlink = '';
710 710
 		//if (! empty($modulepart)) $paramlink.=($paramlink?'&':'').'modulepart='.$modulepart;		// For sharing with hash (so public files), modulepart is not required.
711 711
 		//if (! empty($ecmfile->entity)) $paramlink.='&entity='.$ecmfile->entity; 					// For sharing with hash (so public files), entity is not required.
712 712
 		//$paramlink.=($paramlink?'&':'').'file='.urlencode($filepath);								// No need of name of file for public link, we will use the hash
713
-		if (! empty($ecmfile->share)) $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;			// Hash for public share
714
-		if ($forcedownload) $paramlink.=($paramlink?'&':'').'attachment=1';
713
+		if (!empty($ecmfile->share)) $paramlink .= ($paramlink ? '&' : '').'hashp='.$ecmfile->share; // Hash for public share
714
+		if ($forcedownload) $paramlink .= ($paramlink ? '&' : '').'attachment=1';
715 715
 
716 716
 		if ($relativelink)
717 717
 		{
718
-			$linktoreturn='document.php'.($paramlink?'?'.$paramlink:'');
718
+			$linktoreturn = 'document.php'.($paramlink ? '?'.$paramlink : '');
719 719
 		}
720 720
 		else
721 721
 		{
722
-			$linktoreturn=$urlwithroot.'/document.php'.($paramlink?'?'.$paramlink:'');
722
+			$linktoreturn = $urlwithroot.'/document.php'.($paramlink ? '?'.$paramlink : '');
723 723
 		}
724 724
 
725 725
 		// Here $ecmfile->share is defined
@@ -737,10 +737,10 @@  discard block
 block discarded – undo
737 737
 	 *  @param  int		$notrigger			Disable all triggers
738 738
 	 *  @return int                 		<0 if KO, >0 if OK
739 739
 	 */
740
-	function add_contact($fk_socpeople, $type_contact, $source='external',$notrigger=0)
740
+	function add_contact($fk_socpeople, $type_contact, $source = 'external', $notrigger = 0)
741 741
 	{
742 742
         // phpcs:enable
743
-		global $user,$langs;
743
+		global $user, $langs;
744 744
 
745 745
 
746 746
 		dol_syslog(get_class($this)."::add_contact $fk_socpeople, $type_contact, $source, $notrigger");
@@ -749,43 +749,43 @@  discard block
 block discarded – undo
749 749
 		if ($fk_socpeople <= 0)
750 750
 		{
751 751
 			$langs->load("errors");
752
-			$this->error=$langs->trans("ErrorWrongValueForParameterX","1");
753
-			dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);
752
+			$this->error = $langs->trans("ErrorWrongValueForParameterX", "1");
753
+			dol_syslog(get_class($this)."::add_contact ".$this->error, LOG_ERR);
754 754
 			return -1;
755 755
 		}
756
-		if (! $type_contact)
756
+		if (!$type_contact)
757 757
 		{
758 758
 			$langs->load("errors");
759
-			$this->error=$langs->trans("ErrorWrongValueForParameterX","2");
760
-			dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);
759
+			$this->error = $langs->trans("ErrorWrongValueForParameterX", "2");
760
+			dol_syslog(get_class($this)."::add_contact ".$this->error, LOG_ERR);
761 761
 			return -2;
762 762
 		}
763 763
 
764
-		$id_type_contact=0;
764
+		$id_type_contact = 0;
765 765
 		if (is_numeric($type_contact))
766 766
 		{
767
-			$id_type_contact=$type_contact;
767
+			$id_type_contact = $type_contact;
768 768
 		}
769 769
 		else
770 770
 		{
771 771
 			// We look for id type_contact
772 772
 			$sql = "SELECT tc.rowid";
773
-			$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";
774
-			$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";
775
-			$sql.= " AND tc.source='".$this->db->escape($source)."'";
776
-			$sql.= " AND tc.code='".$this->db->escape($type_contact)."' AND tc.active=1";
773
+			$sql .= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";
774
+			$sql .= " WHERE tc.element='".$this->db->escape($this->element)."'";
775
+			$sql .= " AND tc.source='".$this->db->escape($source)."'";
776
+			$sql .= " AND tc.code='".$this->db->escape($type_contact)."' AND tc.active=1";
777 777
 			//print $sql;
778
-			$resql=$this->db->query($sql);
778
+			$resql = $this->db->query($sql);
779 779
 			if ($resql)
780 780
 			{
781 781
 				$obj = $this->db->fetch_object($resql);
782
-				if ($obj) $id_type_contact=$obj->rowid;
782
+				if ($obj) $id_type_contact = $obj->rowid;
783 783
 			}
784 784
 		}
785 785
 
786 786
 		if ($id_type_contact == 0)
787 787
 		{
788
-			$this->error='CODE_NOT_VALID_FOR_THIS_ELEMENT';
788
+			$this->error = 'CODE_NOT_VALID_FOR_THIS_ELEMENT';
789 789
 			dol_syslog("CODE_NOT_VALID_FOR_THIS_ELEMENT: Code type of contact '".$type_contact."' does not exists or is not active for element ".$this->element.", we can ignore it");
790 790
 			return -3;
791 791
 		}
@@ -793,35 +793,35 @@  discard block
 block discarded – undo
793 793
 		$datecreate = dol_now();
794 794
 
795 795
 		// Socpeople must have already been added by some trigger, then we have to check it to avoid DB_ERROR_RECORD_ALREADY_EXISTS error
796
-		$TListeContacts=$this->liste_contact(-1, $source);
797
-		$already_added=false;
798
-		if(!empty($TListeContacts)) {
799
-			foreach($TListeContacts as $array_contact) {
800
-				if($array_contact['status'] == 4 && $array_contact['id'] == $fk_socpeople && $array_contact['fk_c_type_contact'] == $id_type_contact) {
801
-					$already_added=true;
796
+		$TListeContacts = $this->liste_contact(-1, $source);
797
+		$already_added = false;
798
+		if (!empty($TListeContacts)) {
799
+			foreach ($TListeContacts as $array_contact) {
800
+				if ($array_contact['status'] == 4 && $array_contact['id'] == $fk_socpeople && $array_contact['fk_c_type_contact'] == $id_type_contact) {
801
+					$already_added = true;
802 802
 					break;
803 803
 				}
804 804
 			}
805 805
 		}
806 806
 
807
-		if(!$already_added) {
807
+		if (!$already_added) {
808 808
 
809 809
 			$this->db->begin();
810 810
 
811 811
 			// Insert into database
812 812
 			$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_contact";
813
-			$sql.= " (element_id, fk_socpeople, datecreate, statut, fk_c_type_contact) ";
814
-			$sql.= " VALUES (".$this->id.", ".$fk_socpeople." , " ;
815
-			$sql.= "'".$this->db->idate($datecreate)."'";
816
-			$sql.= ", 4, ". $id_type_contact;
817
-			$sql.= ")";
813
+			$sql .= " (element_id, fk_socpeople, datecreate, statut, fk_c_type_contact) ";
814
+			$sql .= " VALUES (".$this->id.", ".$fk_socpeople." , ";
815
+			$sql .= "'".$this->db->idate($datecreate)."'";
816
+			$sql .= ", 4, ".$id_type_contact;
817
+			$sql .= ")";
818 818
 
819
-			$resql=$this->db->query($sql);
819
+			$resql = $this->db->query($sql);
820 820
 			if ($resql)
821 821
 			{
822
-				if (! $notrigger)
822
+				if (!$notrigger)
823 823
 				{
824
-					$result=$this->call_trigger(strtoupper($this->element).'_ADD_CONTACT', $user);
824
+					$result = $this->call_trigger(strtoupper($this->element).'_ADD_CONTACT', $user);
825 825
 					if ($result < 0)
826 826
 					{
827 827
 						$this->db->rollback();
@@ -836,14 +836,14 @@  discard block
 block discarded – undo
836 836
 			{
837 837
 				if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')
838 838
 				{
839
-					$this->error=$this->db->errno();
839
+					$this->error = $this->db->errno();
840 840
 					$this->db->rollback();
841 841
 					echo 'err rollback';
842 842
 					return -2;
843 843
 				}
844 844
 				else
845 845
 				{
846
-					$this->error=$this->db->error();
846
+					$this->error = $this->db->error();
847 847
 					$this->db->rollback();
848 848
 					return -1;
849 849
 				}
@@ -859,15 +859,15 @@  discard block
 block discarded – undo
859 859
 	 *    @param    string          $source     Nature of contact ('internal' or 'external')
860 860
 	 *    @return   int                         >0 if OK, <0 if KO
861 861
 	 */
862
-	function copy_linked_contact($objFrom, $source='internal')
862
+	function copy_linked_contact($objFrom, $source = 'internal')
863 863
 	{
864 864
         // phpcs:enable
865 865
 		$contacts = $objFrom->liste_contact(-1, $source);
866
-		foreach($contacts as $contact)
866
+		foreach ($contacts as $contact)
867 867
 		{
868 868
 			if ($this->add_contact($contact['id'], $contact['fk_c_type_contact'], $contact['source']) < 0)
869 869
 			{
870
-				$this->error=$this->db->lasterror();
870
+				$this->error = $this->db->lasterror();
871 871
 				return -1;
872 872
 			}
873 873
 		}
@@ -884,23 +884,23 @@  discard block
 block discarded – undo
884 884
 	 *      @param  int		$fk_socpeople	    Id of soc_people to update (not modified if 0)
885 885
 	 *      @return int                 		<0 if KO, >= 0 if OK
886 886
 	 */
887
-	function update_contact($rowid, $statut, $type_contact_id=0, $fk_socpeople=0)
887
+	function update_contact($rowid, $statut, $type_contact_id = 0, $fk_socpeople = 0)
888 888
 	{
889 889
         // phpcs:enable
890 890
 		// Insert into database
891 891
 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_contact set";
892
-		$sql.= " statut = ".$statut;
893
-		if ($type_contact_id) $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";
894
-		if ($fk_socpeople) $sql.= ", fk_socpeople = '".$fk_socpeople ."'";
895
-		$sql.= " where rowid = ".$rowid;
896
-		$resql=$this->db->query($sql);
892
+		$sql .= " statut = ".$statut;
893
+		if ($type_contact_id) $sql .= ", fk_c_type_contact = '".$type_contact_id."'";
894
+		if ($fk_socpeople) $sql .= ", fk_socpeople = '".$fk_socpeople."'";
895
+		$sql .= " where rowid = ".$rowid;
896
+		$resql = $this->db->query($sql);
897 897
 		if ($resql)
898 898
 		{
899 899
 			return 0;
900 900
 		}
901 901
 		else
902 902
 		{
903
-			$this->error=$this->db->lasterror();
903
+			$this->error = $this->db->lasterror();
904 904
 			return -1;
905 905
 		}
906 906
 	}
@@ -913,7 +913,7 @@  discard block
 block discarded – undo
913 913
 	 *    @param	int		$notrigger		Disable all triggers
914 914
 	 *    @return   int						>0 if OK, <0 if KO
915 915
 	 */
916
-	function delete_contact($rowid, $notrigger=0)
916
+	function delete_contact($rowid, $notrigger = 0)
917 917
 	{
918 918
         // phpcs:enable
919 919
 		global $user;
@@ -922,14 +922,14 @@  discard block
 block discarded – undo
922 922
 		$this->db->begin();
923 923
 
924 924
 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";
925
-		$sql.= " WHERE rowid =".$rowid;
925
+		$sql .= " WHERE rowid =".$rowid;
926 926
 
927 927
 		dol_syslog(get_class($this)."::delete_contact", LOG_DEBUG);
928 928
 		if ($this->db->query($sql))
929 929
 		{
930
-			if (! $notrigger)
930
+			if (!$notrigger)
931 931
 			{
932
-				$result=$this->call_trigger(strtoupper($this->element).'_DELETE_CONTACT', $user);
932
+				$result = $this->call_trigger(strtoupper($this->element).'_DELETE_CONTACT', $user);
933 933
 				if ($result < 0) { $this->db->rollback(); return -1; }
934 934
 			}
935 935
 
@@ -938,7 +938,7 @@  discard block
 block discarded – undo
938 938
 		}
939 939
 		else
940 940
 		{
941
-			$this->error=$this->db->lasterror();
941
+			$this->error = $this->db->lasterror();
942 942
 			$this->db->rollback();
943 943
 			return -1;
944 944
 		}
@@ -952,22 +952,22 @@  discard block
 block discarded – undo
952 952
 	 *	  @param	string	$code		Type of contact (code or id)
953 953
 	 *    @return   int					>0 if OK, <0 if KO
954 954
 	 */
955
-	function delete_linked_contact($source='',$code='')
955
+	function delete_linked_contact($source = '', $code = '')
956 956
 	{
957 957
         // phpcs:enable
958 958
 		$temp = array();
959
-		$typeContact = $this->liste_type_contact($source,'',0,0,$code);
959
+		$typeContact = $this->liste_type_contact($source, '', 0, 0, $code);
960 960
 
961
-		foreach($typeContact as $key => $value)
961
+		foreach ($typeContact as $key => $value)
962 962
 		{
963
-			array_push($temp,$key);
963
+			array_push($temp, $key);
964 964
 		}
965 965
 		$listId = implode(",", $temp);
966 966
 
967 967
 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";
968
-		$sql.= " WHERE element_id = ".$this->id;
968
+		$sql .= " WHERE element_id = ".$this->id;
969 969
 		if ($listId)
970
-			$sql.= " AND fk_c_type_contact IN (".$listId.")";
970
+			$sql .= " AND fk_c_type_contact IN (".$listId.")";
971 971
 
972 972
 		dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);
973 973
 		if ($this->db->query($sql))
@@ -976,7 +976,7 @@  discard block
 block discarded – undo
976 976
 		}
977 977
 		else
978 978
 		{
979
-			$this->error=$this->db->lasterror();
979
+			$this->error = $this->db->lasterror();
980 980
 			return -1;
981 981
 		}
982 982
 	}
@@ -991,54 +991,54 @@  discard block
 block discarded – undo
991 991
 	 *    @param    string      $code       Filter on this code of contact type ('SHIPPING', 'BILLING', ...)
992 992
 	 *    @return	array|int		        Array of contacts, -1 if error
993 993
 	 */
994
-	function liste_contact($statut=-1,$source='external',$list=0,$code='')
994
+	function liste_contact($statut = -1, $source = 'external', $list = 0, $code = '')
995 995
 	{
996 996
         // phpcs:enable
997 997
 		global $langs;
998 998
 
999
-		$tab=array();
1000
-
1001
-		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact";    // This field contains id of llx_socpeople or id of llx_user
1002
-		if ($source == 'internal') $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";
1003
-		if ($source == 'external' || $source == 'thirdparty') $sql.=", t.fk_soc as socid, t.statut as statuscontact";
1004
-		$sql.= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";
1005
-		$sql.= ", tc.source, tc.element, tc.code, tc.libelle";
1006
-		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";
1007
-		$sql.= ", ".MAIN_DB_PREFIX."element_contact ec";
1008
-		if ($source == 'internal') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";
1009
-		if ($source == 'external'|| $source == 'thirdparty') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";
1010
-		$sql.= " WHERE ec.element_id =".$this->id;
1011
-		$sql.= " AND ec.fk_c_type_contact=tc.rowid";
1012
-		$sql.= " AND tc.element='".$this->db->escape($this->element)."'";
1013
-		if ($code) $sql.= " AND tc.code = '".$this->db->escape($code)."'";
1014
-		if ($source == 'internal') $sql.= " AND tc.source = 'internal'";
1015
-		if ($source == 'external' || $source == 'thirdparty') $sql.= " AND tc.source = 'external'";
1016
-		$sql.= " AND tc.active=1";
1017
-		if ($statut >= 0) $sql.= " AND ec.statut = '".$statut."'";
1018
-		$sql.=" ORDER BY t.lastname ASC";
999
+		$tab = array();
1000
+
1001
+		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact"; // This field contains id of llx_socpeople or id of llx_user
1002
+		if ($source == 'internal') $sql .= ", '-1' as socid, t.statut as statuscontact, t.login, t.photo";
1003
+		if ($source == 'external' || $source == 'thirdparty') $sql .= ", t.fk_soc as socid, t.statut as statuscontact";
1004
+		$sql .= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";
1005
+		$sql .= ", tc.source, tc.element, tc.code, tc.libelle";
1006
+		$sql .= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";
1007
+		$sql .= ", ".MAIN_DB_PREFIX."element_contact ec";
1008
+		if ($source == 'internal') $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";
1009
+		if ($source == 'external' || $source == 'thirdparty') $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";
1010
+		$sql .= " WHERE ec.element_id =".$this->id;
1011
+		$sql .= " AND ec.fk_c_type_contact=tc.rowid";
1012
+		$sql .= " AND tc.element='".$this->db->escape($this->element)."'";
1013
+		if ($code) $sql .= " AND tc.code = '".$this->db->escape($code)."'";
1014
+		if ($source == 'internal') $sql .= " AND tc.source = 'internal'";
1015
+		if ($source == 'external' || $source == 'thirdparty') $sql .= " AND tc.source = 'external'";
1016
+		$sql .= " AND tc.active=1";
1017
+		if ($statut >= 0) $sql .= " AND ec.statut = '".$statut."'";
1018
+		$sql .= " ORDER BY t.lastname ASC";
1019 1019
 
1020 1020
 		dol_syslog(get_class($this)."::liste_contact", LOG_DEBUG);
1021
-		$resql=$this->db->query($sql);
1021
+		$resql = $this->db->query($sql);
1022 1022
 		if ($resql)
1023 1023
 		{
1024
-			$num=$this->db->num_rows($resql);
1025
-			$i=0;
1024
+			$num = $this->db->num_rows($resql);
1025
+			$i = 0;
1026 1026
 			while ($i < $num)
1027 1027
 			{
1028 1028
 				$obj = $this->db->fetch_object($resql);
1029 1029
 
1030
-				if (! $list)
1030
+				if (!$list)
1031 1031
 				{
1032
-					$transkey="TypeContact_".$obj->element."_".$obj->source."_".$obj->code;
1033
-					$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);
1034
-					$tab[$i]=array('source'=>$obj->source,'socid'=>$obj->socid,'id'=>$obj->id,
1035
-								   'nom'=>$obj->lastname,      // For backward compatibility
1032
+					$transkey = "TypeContact_".$obj->element."_".$obj->source."_".$obj->code;
1033
+					$libelle_type = ($langs->trans($transkey) != $transkey ? $langs->trans($transkey) : $obj->libelle);
1034
+					$tab[$i] = array('source'=>$obj->source, 'socid'=>$obj->socid, 'id'=>$obj->id,
1035
+								   'nom'=>$obj->lastname, // For backward compatibility
1036 1036
 								   'civility'=>$obj->civility, 'lastname'=>$obj->lastname, 'firstname'=>$obj->firstname, 'email'=>$obj->email, 'login'=>$obj->login, 'photo'=>$obj->photo, 'statuscontact'=>$obj->statuscontact,
1037 1037
 								   'rowid'=>$obj->rowid, 'code'=>$obj->code, 'libelle'=>$libelle_type, 'status'=>$obj->statuslink, 'fk_c_type_contact'=>$obj->fk_c_type_contact);
1038 1038
 				}
1039 1039
 				else
1040 1040
 				{
1041
-					$tab[$i]=$obj->id;
1041
+					$tab[$i] = $obj->id;
1042 1042
 				}
1043 1043
 
1044 1044
 				$i++;
@@ -1048,7 +1048,7 @@  discard block
 block discarded – undo
1048 1048
 		}
1049 1049
 		else
1050 1050
 		{
1051
-			$this->error=$this->db->lasterror();
1051
+			$this->error = $this->db->lasterror();
1052 1052
 			dol_print_error($this->db);
1053 1053
 			return -1;
1054 1054
 		}
@@ -1064,16 +1064,16 @@  discard block
 block discarded – undo
1064 1064
 	function swapContactStatus($rowid)
1065 1065
 	{
1066 1066
 		$sql = "SELECT ec.datecreate, ec.statut, ec.fk_socpeople, ec.fk_c_type_contact,";
1067
-		$sql.= " tc.code, tc.libelle";
1067
+		$sql .= " tc.code, tc.libelle";
1068 1068
 		//$sql.= ", s.fk_soc";
1069
-		$sql.= " FROM (".MAIN_DB_PREFIX."element_contact as ec, ".MAIN_DB_PREFIX."c_type_contact as tc)";
1069
+		$sql .= " FROM (".MAIN_DB_PREFIX."element_contact as ec, ".MAIN_DB_PREFIX."c_type_contact as tc)";
1070 1070
 		//$sql.= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople as s ON ec.fk_socpeople=s.rowid";	// Si contact de type external, alors il est lie a une societe
1071
-		$sql.= " WHERE ec.rowid =".$rowid;
1072
-		$sql.= " AND ec.fk_c_type_contact=tc.rowid";
1073
-		$sql.= " AND tc.element = '".$this->db->escape($this->element)."'";
1071
+		$sql .= " WHERE ec.rowid =".$rowid;
1072
+		$sql .= " AND ec.fk_c_type_contact=tc.rowid";
1073
+		$sql .= " AND tc.element = '".$this->db->escape($this->element)."'";
1074 1074
 
1075 1075
 		dol_syslog(get_class($this)."::swapContactStatus", LOG_DEBUG);
1076
-		$resql=$this->db->query($sql);
1076
+		$resql = $this->db->query($sql);
1077 1077
 		if ($resql)
1078 1078
 		{
1079 1079
 			$obj = $this->db->fetch_object($resql);
@@ -1084,7 +1084,7 @@  discard block
 block discarded – undo
1084 1084
 		}
1085 1085
 		else
1086 1086
 		{
1087
-			$this->error=$this->db->error();
1087
+			$this->error = $this->db->error();
1088 1088
 			dol_print_error($this->db);
1089 1089
 			return -1;
1090 1090
 		}
@@ -1101,44 +1101,44 @@  discard block
 block discarded – undo
1101 1101
 	 *		@param	string	$code		Type of contact (Example: 'CUSTOMER', 'SERVICE')
1102 1102
 	 *      @return array       		Array list of type of contacts (id->label if option=0, code->label if option=1)
1103 1103
 	 */
1104
-	function liste_type_contact($source='internal', $order='position', $option=0, $activeonly=0, $code='')
1104
+	function liste_type_contact($source = 'internal', $order = 'position', $option = 0, $activeonly = 0, $code = '')
1105 1105
 	{
1106 1106
         // phpcs:enable
1107 1107
 		global $langs;
1108 1108
 
1109
-		if (empty($order)) $order='position';
1110
-		if ($order == 'position') $order.=',code';
1109
+		if (empty($order)) $order = 'position';
1110
+		if ($order == 'position') $order .= ',code';
1111 1111
 
1112 1112
 		$tab = array();
1113 1113
 		$sql = "SELECT DISTINCT tc.rowid, tc.code, tc.libelle, tc.position";
1114
-		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";
1115
-		$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";
1116
-		if ($activeonly == 1) $sql.= " AND tc.active=1"; // only the active types
1117
-		if (! empty($source) && $source != 'all') $sql.= " AND tc.source='".$this->db->escape($source)."'";
1118
-		if (! empty($code)) $sql.= " AND tc.code='".$this->db->escape($code)."'";
1119
-		$sql.= $this->db->order($order,'ASC');
1114
+		$sql .= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";
1115
+		$sql .= " WHERE tc.element='".$this->db->escape($this->element)."'";
1116
+		if ($activeonly == 1) $sql .= " AND tc.active=1"; // only the active types
1117
+		if (!empty($source) && $source != 'all') $sql .= " AND tc.source='".$this->db->escape($source)."'";
1118
+		if (!empty($code)) $sql .= " AND tc.code='".$this->db->escape($code)."'";
1119
+		$sql .= $this->db->order($order, 'ASC');
1120 1120
 
1121 1121
 		//print "sql=".$sql;
1122
-		$resql=$this->db->query($sql);
1122
+		$resql = $this->db->query($sql);
1123 1123
 		if ($resql)
1124 1124
 		{
1125
-			$num=$this->db->num_rows($resql);
1126
-			$i=0;
1125
+			$num = $this->db->num_rows($resql);
1126
+			$i = 0;
1127 1127
 			while ($i < $num)
1128 1128
 			{
1129 1129
 				$obj = $this->db->fetch_object($resql);
1130 1130
 
1131
-				$transkey="TypeContact_".$this->element."_".$source."_".$obj->code;
1132
-				$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);
1133
-				if (empty($option)) $tab[$obj->rowid]=$libelle_type;
1134
-				else $tab[$obj->code]=$libelle_type;
1131
+				$transkey = "TypeContact_".$this->element."_".$source."_".$obj->code;
1132
+				$libelle_type = ($langs->trans($transkey) != $transkey ? $langs->trans($transkey) : $obj->libelle);
1133
+				if (empty($option)) $tab[$obj->rowid] = $libelle_type;
1134
+				else $tab[$obj->code] = $libelle_type;
1135 1135
 				$i++;
1136 1136
 			}
1137 1137
 			return $tab;
1138 1138
 		}
1139 1139
 		else
1140 1140
 		{
1141
-			$this->error=$this->db->lasterror();
1141
+			$this->error = $this->db->lasterror();
1142 1142
 			//dol_print_error($this->db);
1143 1143
 			return null;
1144 1144
 		}
@@ -1155,53 +1155,53 @@  discard block
 block discarded – undo
1155 1155
 	 *		@param	int		$status		limited to a certain status
1156 1156
 	 *      @return array       		List of id for such contacts
1157 1157
 	 */
1158
-	function getIdContact($source,$code,$status=0)
1158
+	function getIdContact($source, $code, $status = 0)
1159 1159
 	{
1160 1160
 		global $conf;
1161 1161
 
1162
-		$result=array();
1163
-		$i=0;
1162
+		$result = array();
1163
+		$i = 0;
1164 1164
 		//cas particulier pour les expeditions
1165
-		if($this->element=='shipping' && $this->origin_id != 0) {
1166
-			$id=$this->origin_id;
1167
-			$element='commande';
1168
-        } else if($this->element=='reception' && $this->origin_id != 0) {
1169
-            $id=$this->origin_id;
1170
-            $element='order_supplier';
1165
+		if ($this->element == 'shipping' && $this->origin_id != 0) {
1166
+			$id = $this->origin_id;
1167
+			$element = 'commande';
1168
+        } else if ($this->element == 'reception' && $this->origin_id != 0) {
1169
+            $id = $this->origin_id;
1170
+            $element = 'order_supplier';
1171 1171
 		} else {
1172
-			$id=$this->id;
1173
-			$element=$this->element;
1172
+			$id = $this->id;
1173
+			$element = $this->element;
1174 1174
 		}
1175 1175
 
1176 1176
 		$sql = "SELECT ec.fk_socpeople";
1177
-		$sql.= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";
1178
-		if ($source == 'internal') $sql.= " ".MAIN_DB_PREFIX."user as c,";
1179
-		if ($source == 'external') $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";
1180
-		$sql.= " ".MAIN_DB_PREFIX."c_type_contact as tc";
1181
-		$sql.= " WHERE ec.element_id = ".$id;
1182
-		$sql.= " AND ec.fk_socpeople = c.rowid";
1183
-		if ($source == 'internal') $sql.= " AND c.entity IN (".getEntity('user').")";
1184
-		if ($source == 'external') $sql.= " AND c.entity IN (".getEntity('societe').")";
1185
-		$sql.= " AND ec.fk_c_type_contact = tc.rowid";
1186
-		$sql.= " AND tc.element = '".$element."'";
1187
-		$sql.= " AND tc.source = '".$source."'";
1188
-		$sql.= " AND tc.code = '".$code."'";
1189
-		$sql.= " AND tc.active = 1";
1190
-		if ($status) $sql.= " AND ec.statut = ".$status;
1177
+		$sql .= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";
1178
+		if ($source == 'internal') $sql .= " ".MAIN_DB_PREFIX."user as c,";
1179
+		if ($source == 'external') $sql .= " ".MAIN_DB_PREFIX."socpeople as c,";
1180
+		$sql .= " ".MAIN_DB_PREFIX."c_type_contact as tc";
1181
+		$sql .= " WHERE ec.element_id = ".$id;
1182
+		$sql .= " AND ec.fk_socpeople = c.rowid";
1183
+		if ($source == 'internal') $sql .= " AND c.entity IN (".getEntity('user').")";
1184
+		if ($source == 'external') $sql .= " AND c.entity IN (".getEntity('societe').")";
1185
+		$sql .= " AND ec.fk_c_type_contact = tc.rowid";
1186
+		$sql .= " AND tc.element = '".$element."'";
1187
+		$sql .= " AND tc.source = '".$source."'";
1188
+		$sql .= " AND tc.code = '".$code."'";
1189
+		$sql .= " AND tc.active = 1";
1190
+		if ($status) $sql .= " AND ec.statut = ".$status;
1191 1191
 
1192 1192
 		dol_syslog(get_class($this)."::getIdContact", LOG_DEBUG);
1193
-		$resql=$this->db->query($sql);
1193
+		$resql = $this->db->query($sql);
1194 1194
 		if ($resql)
1195 1195
 		{
1196 1196
 			while ($obj = $this->db->fetch_object($resql))
1197 1197
 			{
1198
-				$result[$i]=$obj->fk_socpeople;
1198
+				$result[$i] = $obj->fk_socpeople;
1199 1199
 				$i++;
1200 1200
 			}
1201 1201
 		}
1202 1202
 		else
1203 1203
 		{
1204
-			$this->error=$this->db->error();
1204
+			$this->error = $this->db->error();
1205 1205
 			return null;
1206 1206
 		}
1207 1207
 
@@ -1215,16 +1215,16 @@  discard block
 block discarded – undo
1215 1215
 	 *		@param	int		$contactid      Id du contact. Use this->contactid if empty.
1216 1216
 	 *		@return	int						<0 if KO, >0 if OK
1217 1217
 	 */
1218
-	function fetch_contact($contactid=null)
1218
+	function fetch_contact($contactid = null)
1219 1219
 	{
1220 1220
         // phpcs:enable
1221
-		if (empty($contactid)) $contactid=$this->contactid;
1221
+		if (empty($contactid)) $contactid = $this->contactid;
1222 1222
 
1223 1223
 		if (empty($contactid)) return 0;
1224 1224
 
1225 1225
 		require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';
1226 1226
 		$contact = new Contact($this->db);
1227
-		$result=$contact->fetch($contactid);
1227
+		$result = $contact->fetch($contactid);
1228 1228
 		$this->contact = $contact;
1229 1229
 		return $result;
1230 1230
 	}
@@ -1236,7 +1236,7 @@  discard block
 block discarded – undo
1236 1236
 	 *		@param		int		$force_thirdparty_id	Force thirdparty id
1237 1237
 	 *		@return		int								<0 if KO, >0 if OK
1238 1238
 	 */
1239
-	function fetch_thirdparty($force_thirdparty_id=0)
1239
+	function fetch_thirdparty($force_thirdparty_id = 0)
1240 1240
 	{
1241 1241
         // phpcs:enable
1242 1242
 		global $conf;
@@ -1244,7 +1244,7 @@  discard block
 block discarded – undo
1244 1244
 		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id))
1245 1245
 			return 0;
1246 1246
 
1247
-		require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';
1247
+		require_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';
1248 1248
 
1249 1249
 		$idtofetch = isset($this->socid) ? $this->socid : (isset($this->fk_soc) ? $this->fk_soc : $this->fk_thirdparty);
1250 1250
 		if ($force_thirdparty_id)
@@ -1307,7 +1307,7 @@  discard block
 block discarded – undo
1307 1307
 
1308 1308
 		dol_syslog(get_class($this).'::fetch_barcode this->element='.$this->element.' this->barcode_type='.$this->barcode_type);
1309 1309
 
1310
-		$idtype=$this->barcode_type;
1310
+		$idtype = $this->barcode_type;
1311 1311
 		if (empty($idtype) && $idtype != '0')	// If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined
1312 1312
 		{
1313 1313
 			if ($this->element == 'product')      $idtype = $conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;
@@ -1320,8 +1320,8 @@  discard block
 block discarded – undo
1320 1320
 			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder))    // If data not already loaded
1321 1321
 			{
1322 1322
 				$sql = "SELECT rowid, code, libelle as label, coder";
1323
-				$sql.= " FROM ".MAIN_DB_PREFIX."c_barcode_type";
1324
-				$sql.= " WHERE rowid = ".$idtype;
1323
+				$sql .= " FROM ".MAIN_DB_PREFIX."c_barcode_type";
1324
+				$sql .= " WHERE rowid = ".$idtype;
1325 1325
 				dol_syslog(get_class($this).'::fetch_barcode', LOG_DEBUG);
1326 1326
 				$resql = $this->db->query($sql);
1327 1327
 				if ($resql)
@@ -1354,13 +1354,13 @@  discard block
 block discarded – undo
1354 1354
         // phpcs:enable
1355 1355
 		include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';
1356 1356
 
1357
-		if (empty($this->fk_project) && ! empty($this->fk_projet)) $this->fk_project = $this->fk_projet;	// For backward compatibility
1357
+		if (empty($this->fk_project) && !empty($this->fk_projet)) $this->fk_project = $this->fk_projet; // For backward compatibility
1358 1358
 		if (empty($this->fk_project)) return 0;
1359 1359
 
1360 1360
 		$project = new Project($this->db);
1361 1361
 		$result = $project->fetch($this->fk_project);
1362 1362
 
1363
-		$this->projet = $project;	// deprecated
1363
+		$this->projet = $project; // deprecated
1364 1364
 		$this->project = $project;
1365 1365
 		return $result;
1366 1366
 	}
@@ -1396,7 +1396,7 @@  discard block
 block discarded – undo
1396 1396
 	{
1397 1397
         // phpcs:enable
1398 1398
 		$user = new User($this->db);
1399
-		$result=$user->fetch($userid);
1399
+		$result = $user->fetch($userid);
1400 1400
 		$this->user = $user;
1401 1401
 		return $result;
1402 1402
 	}
@@ -1434,14 +1434,14 @@  discard block
 block discarded – undo
1434 1434
 	{
1435 1435
 		global $conf;
1436 1436
 
1437
-		$result=false;
1437
+		$result = false;
1438 1438
 
1439 1439
 		$sql = "SELECT rowid FROM ".MAIN_DB_PREFIX.$table;
1440
-		$sql.= " WHERE ".$field." = '".$key."'";
1441
-		if (! empty($element)) {
1442
-			$sql.= " AND entity IN (".getEntity($element).")";
1440
+		$sql .= " WHERE ".$field." = '".$key."'";
1441
+		if (!empty($element)) {
1442
+			$sql .= " AND entity IN (".getEntity($element).")";
1443 1443
 		} else {
1444
-			$sql.= " AND entity = ".$conf->entity;
1444
+			$sql .= " AND entity = ".$conf->entity;
1445 1445
 		}
1446 1446
 
1447 1447
 		dol_syslog(get_class($this).'::fetchObjectFrom', LOG_DEBUG);
@@ -1468,10 +1468,10 @@  discard block
 block discarded – undo
1468 1468
 	 */
1469 1469
 	function getValueFrom($table, $id, $field)
1470 1470
 	{
1471
-		$result=false;
1471
+		$result = false;
1472 1472
 		if (!empty($id) && !empty($field) && !empty($table)) {
1473 1473
 			$sql = "SELECT ".$field." FROM ".MAIN_DB_PREFIX.$table;
1474
-			$sql.= " WHERE rowid = ".$id;
1474
+			$sql .= " WHERE rowid = ".$id;
1475 1475
 
1476 1476
 			dol_syslog(get_class($this).'::getValueFrom', LOG_DEBUG);
1477 1477
 			$resql = $this->db->query($sql);
@@ -1500,36 +1500,36 @@  discard block
 block discarded – undo
1500 1500
 	 *	@return	int							<0 if KO, >0 if OK
1501 1501
 	 *  @see updateExtraField
1502 1502
 	 */
1503
-	function setValueFrom($field, $value, $table='', $id=null, $format='', $id_field='', $fuser=null, $trigkey='', $fk_user_field='fk_user_modif')
1503
+	function setValueFrom($field, $value, $table = '', $id = null, $format = '', $id_field = '', $fuser = null, $trigkey = '', $fk_user_field = 'fk_user_modif')
1504 1504
 	{
1505
-		global $user,$langs,$conf;
1505
+		global $user, $langs, $conf;
1506 1506
 
1507
-		if (empty($table)) 	  $table=$this->table_element;
1508
-		if (empty($id))    	  $id=$this->id;
1509
-		if (empty($format))   $format='text';
1510
-		if (empty($id_field)) $id_field='rowid';
1507
+		if (empty($table)) 	  $table = $this->table_element;
1508
+		if (empty($id))    	  $id = $this->id;
1509
+		if (empty($format))   $format = 'text';
1510
+		if (empty($id_field)) $id_field = 'rowid';
1511 1511
 
1512
-		$error=0;
1512
+		$error = 0;
1513 1513
 
1514 1514
 		$this->db->begin();
1515 1515
 
1516 1516
 		// Special case
1517
-		if ($table == 'product' && $field == 'note_private') $field='note';
1517
+		if ($table == 'product' && $field == 'note_private') $field = 'note';
1518 1518
 		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) $fk_user_field = 'fk_user_mod';
1519 1519
 
1520 1520
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$table." SET ";
1521 1521
 
1522
-		if ($format == 'text') $sql.= $field." = '".$this->db->escape($value)."'";
1523
-		else if ($format == 'int') $sql.= $field." = ".$this->db->escape($value);
1524
-		else if ($format == 'date') $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");
1522
+		if ($format == 'text') $sql .= $field." = '".$this->db->escape($value)."'";
1523
+		else if ($format == 'int') $sql .= $field." = ".$this->db->escape($value);
1524
+		else if ($format == 'date') $sql .= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");
1525 1525
 
1526 1526
 		if ($fk_user_field)
1527 1527
 		{
1528
-			if (! empty($fuser) && is_object($fuser)) $sql.=", ".$fk_user_field." = ".$fuser->id;
1529
-			elseif (empty($fuser) || $fuser != 'none') $sql.=", ".$fk_user_field." = ".$user->id;
1528
+			if (!empty($fuser) && is_object($fuser)) $sql .= ", ".$fk_user_field." = ".$fuser->id;
1529
+			elseif (empty($fuser) || $fuser != 'none') $sql .= ", ".$fk_user_field." = ".$user->id;
1530 1530
 		}
1531 1531
 
1532
-		$sql.= " WHERE ".$id_field." = ".$id;
1532
+		$sql .= " WHERE ".$id_field." = ".$id;
1533 1533
 
1534 1534
 		dol_syslog(get_class($this)."::".__FUNCTION__."", LOG_DEBUG);
1535 1535
 		$resql = $this->db->query($sql);
@@ -1546,11 +1546,11 @@  discard block
 block discarded – undo
1546 1546
 				{
1547 1547
 					$result = $this->fetchCommon($id);
1548 1548
 				}
1549
-				if ($result >= 0) $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);   // This may set this->errors
1549
+				if ($result >= 0) $result = $this->call_trigger($trigkey, (!empty($fuser) && is_object($fuser)) ? $fuser : $user); // This may set this->errors
1550 1550
 				if ($result < 0) $error++;
1551 1551
 			}
1552 1552
 
1553
-			if (! $error)
1553
+			if (!$error)
1554 1554
 			{
1555 1555
 				if (property_exists($this, $field)) $this->$field = $value;
1556 1556
 				$this->db->commit();
@@ -1564,7 +1564,7 @@  discard block
 block discarded – undo
1564 1564
 		}
1565 1565
 		else
1566 1566
 		{
1567
-			$this->error=$this->db->lasterror();
1567
+			$this->error = $this->db->lasterror();
1568 1568
 			$this->db->rollback();
1569 1569
 			return -1;
1570 1570
 		}
@@ -1579,14 +1579,14 @@  discard block
 block discarded – undo
1579 1579
 	 *		@param	int		$nodbprefix	Do not include DB prefix to forge table name
1580 1580
 	 *      @return int         		<0 if KO, >0 if OK
1581 1581
 	 */
1582
-	function load_previous_next_ref($filter, $fieldid, $nodbprefix=0)
1582
+	function load_previous_next_ref($filter, $fieldid, $nodbprefix = 0)
1583 1583
 	{
1584 1584
         // phpcs:enable
1585 1585
 		global $conf, $user;
1586 1586
 
1587
-		if (! $this->table_element)
1587
+		if (!$this->table_element)
1588 1588
 		{
1589
-			dol_print_error('',get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");
1589
+			dol_print_error('', get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");
1590 1590
 			return -1;
1591 1591
 		}
1592 1592
 		if ($fieldid == 'none') return 1;
@@ -1601,45 +1601,45 @@  discard block
 block discarded – undo
1601 1601
 		if ($this->element == 'societe') $alias = 'te';
1602 1602
 
1603 1603
 		$sql = "SELECT MAX(te.".$fieldid.")";
1604
-		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";
1605
-		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1606
-			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";
1607
-		}
1608
-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity
1609
-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid
1610
-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid
1611
-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
1612
-		$sql.= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)
1613
-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;
1614
-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';
1615
-		if (! empty($filter))
1616
-		{
1617
-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility
1618
-			$sql.=$filter;
1619
-		}
1620
-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity
1621
-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid
1604
+		$sql .= " FROM ".(empty($nodbprefix) ?MAIN_DB_PREFIX:'').$this->table_element." as te";
1605
+		if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1606
+			$sql .= ",".MAIN_DB_PREFIX."usergroup_user as ug";
1607
+		}
1608
+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to entity
1609
+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to socid
1610
+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid"; // If we need to link to societe to limit select to socid
1611
+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
1612
+		$sql .= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'"; // ->ref must always be defined (set to id if field does not exists)
1613
+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND sc.fk_user = ".$user->id;
1614
+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND (sc.fk_user = ".$user->id.' OR te.fk_soc IS NULL)';
1615
+		if (!empty($filter))
1616
+		{
1617
+			if (!preg_match('/^\s*AND/i', $filter)) $sql .= " AND "; // For backward compatibility
1618
+			$sql .= $filter;
1619
+		}
1620
+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to entity
1621
+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to socid
1622 1622
 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {
1623
-			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1624
-				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {
1625
-					$sql.= " AND te.entity IS NOT NULL"; // Show all users
1623
+			if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1624
+				if (!empty($user->admin) && empty($user->entity) && $conf->entity == 1) {
1625
+					$sql .= " AND te.entity IS NOT NULL"; // Show all users
1626 1626
 				} else {
1627
-					$sql.= " AND ug.fk_user = te.rowid";
1628
-					$sql.= " AND ug.entity IN (".getEntity($this->element).")";
1627
+					$sql .= " AND ug.fk_user = te.rowid";
1628
+					$sql .= " AND ug.entity IN (".getEntity($this->element).")";
1629 1629
 				}
1630 1630
 			} else {
1631
-				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';
1631
+				$sql .= ' AND te.entity IN ('.getEntity($this->element).')';
1632 1632
 			}
1633 1633
 		}
1634
-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;
1635
-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';
1636
-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;
1634
+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql .= ' AND te.fk_soc = '.$socid;
1635
+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql .= ' AND (te.fk_soc = '.$socid.' OR te.fk_soc IS NULL)';
1636
+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql .= ' AND te.rowid = '.$socid;
1637 1637
 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";
1638 1638
 
1639 1639
 		$result = $this->db->query($sql);
1640
-		if (! $result)
1640
+		if (!$result)
1641 1641
 		{
1642
-			$this->error=$this->db->lasterror();
1642
+			$this->error = $this->db->lasterror();
1643 1643
 			return -1;
1644 1644
 		}
1645 1645
 		$row = $this->db->fetch_row($result);
@@ -1647,46 +1647,46 @@  discard block
 block discarded – undo
1647 1647
 
1648 1648
 
1649 1649
 		$sql = "SELECT MIN(te.".$fieldid.")";
1650
-		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";
1651
-		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1652
-			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";
1653
-		}
1654
-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity
1655
-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid
1656
-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid
1657
-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
1658
-		$sql.= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)
1659
-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;
1660
-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';
1661
-		if (! empty($filter))
1662
-		{
1663
-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility
1664
-			$sql.=$filter;
1665
-		}
1666
-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity
1667
-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid
1650
+		$sql .= " FROM ".(empty($nodbprefix) ?MAIN_DB_PREFIX:'').$this->table_element." as te";
1651
+		if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1652
+			$sql .= ",".MAIN_DB_PREFIX."usergroup_user as ug";
1653
+		}
1654
+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to entity
1655
+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to socid
1656
+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid"; // If we need to link to societe to limit select to socid
1657
+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
1658
+		$sql .= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'"; // ->ref must always be defined (set to id if field does not exists)
1659
+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND sc.fk_user = ".$user->id;
1660
+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND (sc.fk_user = ".$user->id.' OR te.fk_soc IS NULL)';
1661
+		if (!empty($filter))
1662
+		{
1663
+			if (!preg_match('/^\s*AND/i', $filter)) $sql .= " AND "; // For backward compatibility
1664
+			$sql .= $filter;
1665
+		}
1666
+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to entity
1667
+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to socid
1668 1668
 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {
1669
-			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1670
-				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {
1671
-					$sql.= " AND te.entity IS NOT NULL"; // Show all users
1669
+			if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {
1670
+				if (!empty($user->admin) && empty($user->entity) && $conf->entity == 1) {
1671
+					$sql .= " AND te.entity IS NOT NULL"; // Show all users
1672 1672
 				} else {
1673
-					$sql.= " AND ug.fk_user = te.rowid";
1674
-					$sql.= " AND ug.entity IN (".getEntity($this->element).")";
1673
+					$sql .= " AND ug.fk_user = te.rowid";
1674
+					$sql .= " AND ug.entity IN (".getEntity($this->element).")";
1675 1675
 				}
1676 1676
 			} else {
1677
-				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';
1677
+				$sql .= ' AND te.entity IN ('.getEntity($this->element).')';
1678 1678
 			}
1679 1679
 		}
1680
-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;
1681
-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';
1682
-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;
1680
+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql .= ' AND te.fk_soc = '.$socid;
1681
+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql .= ' AND (te.fk_soc = '.$socid.' OR te.fk_soc IS NULL)';
1682
+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql .= ' AND te.rowid = '.$socid;
1683 1683
 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";
1684 1684
 		// Rem: Bug in some mysql version: SELECT MIN(rowid) FROM llx_socpeople WHERE rowid > 1 when one row in database with rowid=1, returns 1 instead of null
1685 1685
 
1686 1686
 		$result = $this->db->query($sql);
1687
-		if (! $result)
1687
+		if (!$result)
1688 1688
 		{
1689
-			$this->error=$this->db->lasterror();
1689
+			$this->error = $this->db->lasterror();
1690 1690
 			return -2;
1691 1691
 		}
1692 1692
 		$row = $this->db->fetch_row($result);
@@ -1703,11 +1703,11 @@  discard block
 block discarded – undo
1703 1703
 	 *      @return array				Array of id of contacts (if source=external or internal)
1704 1704
 	 * 									Array of id of third parties with at least one contact on object (if source=thirdparty)
1705 1705
 	 */
1706
-	function getListContactId($source='external')
1706
+	function getListContactId($source = 'external')
1707 1707
 	{
1708 1708
 		$contactAlreadySelected = array();
1709
-		$tab = $this->liste_contact(-1,$source);
1710
-		$num=count($tab);
1709
+		$tab = $this->liste_contact(-1, $source);
1710
+		$num = count($tab);
1711 1711
 		$i = 0;
1712 1712
 		while ($i < $num)
1713 1713
 		{
@@ -1727,24 +1727,24 @@  discard block
 block discarded – undo
1727 1727
 	 */
1728 1728
 	function setProject($projectid)
1729 1729
 	{
1730
-		if (! $this->table_element)
1730
+		if (!$this->table_element)
1731 1731
 		{
1732
-			dol_syslog(get_class($this)."::setProject was called on objet with property table_element not defined",LOG_ERR);
1732
+			dol_syslog(get_class($this)."::setProject was called on objet with property table_element not defined", LOG_ERR);
1733 1733
 			return -1;
1734 1734
 		}
1735 1735
 
1736 1736
 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;
1737 1737
 		if ($this->table_element == 'actioncomm')
1738 1738
 		{
1739
-			if ($projectid) $sql.= ' SET fk_project = '.$projectid;
1740
-			else $sql.= ' SET fk_project = NULL';
1741
-			$sql.= ' WHERE id = '.$this->id;
1739
+			if ($projectid) $sql .= ' SET fk_project = '.$projectid;
1740
+			else $sql .= ' SET fk_project = NULL';
1741
+			$sql .= ' WHERE id = '.$this->id;
1742 1742
 		}
1743 1743
 		else
1744 1744
 		{
1745
-			if ($projectid) $sql.= ' SET fk_projet = '.$projectid;
1746
-			else $sql.= ' SET fk_projet = NULL';
1747
-			$sql.= ' WHERE rowid = '.$this->id;
1745
+			if ($projectid) $sql .= ' SET fk_projet = '.$projectid;
1746
+			else $sql .= ' SET fk_projet = NULL';
1747
+			$sql .= ' WHERE rowid = '.$this->id;
1748 1748
 		}
1749 1749
 
1750 1750
 		dol_syslog(get_class($this)."::setProject", LOG_DEBUG);
@@ -1790,14 +1790,14 @@  discard block
 block discarded – undo
1790 1790
 			else
1791 1791
 			{
1792 1792
 				dol_syslog(get_class($this).'::setPaymentMethods Erreur '.$sql.' - '.$this->db->error());
1793
-				$this->error=$this->db->error();
1793
+				$this->error = $this->db->error();
1794 1794
 				return -1;
1795 1795
 			}
1796 1796
 		}
1797 1797
 		else
1798 1798
 		{
1799 1799
 			dol_syslog(get_class($this).'::setPaymentMethods, status of the object is incompatible');
1800
-			$this->error='Status of the object is incompatible '.$this->statut;
1800
+			$this->error = 'Status of the object is incompatible '.$this->statut;
1801 1801
 			return -2;
1802 1802
 		}
1803 1803
 	}
@@ -1824,21 +1824,21 @@  discard block
 block discarded – undo
1824 1824
 				$this->multicurrency_code = $code;
1825 1825
 
1826 1826
 				list($fk_multicurrency, $rate) = MultiCurrency::getIdAndTxFromCode($this->db, $code);
1827
-				if ($rate) $this->setMulticurrencyRate($rate,2);
1827
+				if ($rate) $this->setMulticurrencyRate($rate, 2);
1828 1828
 
1829 1829
 				return 1;
1830 1830
 			}
1831 1831
 			else
1832 1832
 			{
1833 1833
 				dol_syslog(get_class($this).'::setMulticurrencyCode Erreur '.$sql.' - '.$this->db->error());
1834
-				$this->error=$this->db->error();
1834
+				$this->error = $this->db->error();
1835 1835
 				return -1;
1836 1836
 			}
1837 1837
 		}
1838 1838
 		else
1839 1839
 		{
1840 1840
 			dol_syslog(get_class($this).'::setMulticurrencyCode, status of the object is incompatible');
1841
-			$this->error='Status of the object is incompatible '.$this->statut;
1841
+			$this->error = 'Status of the object is incompatible '.$this->statut;
1842 1842
 			return -2;
1843 1843
 		}
1844 1844
 	}
@@ -1850,7 +1850,7 @@  discard block
 block discarded – undo
1850 1850
 	 *  @param		int		$mode	mode 1 : amounts in company currency will be recalculated, mode 2 : amounts in foreign currency
1851 1851
 	 *  @return		int				>0 if OK, <0 if KO
1852 1852
 	 */
1853
-	function setMulticurrencyRate($rate, $mode=1)
1853
+	function setMulticurrencyRate($rate, $mode = 1)
1854 1854
 	{
1855 1855
 		dol_syslog(get_class($this).'::setMulticurrencyRate('.$id.')');
1856 1856
 		if ($this->statut >= 0 || $this->element == 'societe')
@@ -1870,7 +1870,7 @@  discard block
 block discarded – undo
1870 1870
 				{
1871 1871
 					foreach ($this->lines as &$line)
1872 1872
 					{
1873
-						if($mode == 1) {
1873
+						if ($mode == 1) {
1874 1874
 							$line->subprice = 0;
1875 1875
 						}
1876 1876
 
@@ -1878,14 +1878,14 @@  discard block
 block discarded – undo
1878 1878
 							case 'propal':
1879 1879
 								$this->updateline(
1880 1880
 									$line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,
1881
-									($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,
1881
+									($line->description ? $line->description : $line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,
1882 1882
 									$line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->date_start,
1883 1883
 									$line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice
1884 1884
 								);
1885 1885
 								break;
1886 1886
 							case 'commande':
1887 1887
 								$this->updateline(
1888
-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,
1888
+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->qty, $line->remise_percent,
1889 1889
 									$line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->date_start, $line->date_end,
1890 1890
 									$line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,
1891 1891
 									$line->special_code, $line->array_options, $line->fk_unit, $line->multicurrency_subprice
@@ -1893,7 +1893,7 @@  discard block
 block discarded – undo
1893 1893
 								break;
1894 1894
 							case 'facture':
1895 1895
 								$this->updateline(
1896
-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,
1896
+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->qty, $line->remise_percent,
1897 1897
 									$line->date_start, $line->date_end, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits,
1898 1898
 									$line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,
1899 1899
 									$line->special_code, $line->array_options, $line->situation_percent, $line->fk_unit, $line->multicurrency_subprice
@@ -1902,21 +1902,21 @@  discard block
 block discarded – undo
1902 1902
 							case 'supplier_proposal':
1903 1903
 								$this->updateline(
1904 1904
 									$line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,
1905
-									($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,
1905
+									($line->description ? $line->description : $line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,
1906 1906
 									$line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->array_options,
1907 1907
 									$line->ref_fourn, $line->multicurrency_subprice
1908 1908
 								);
1909 1909
 								break;
1910 1910
 							case 'order_supplier':
1911 1911
 								$this->updateline(
1912
-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,
1912
+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->qty, $line->remise_percent,
1913 1913
 									$line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->product_type, false,
1914 1914
 									$line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice
1915 1915
 								);
1916 1916
 								break;
1917 1917
 							case 'invoice_supplier':
1918 1918
 								$this->updateline(
1919
-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->tva_tx, $line->localtax1_tx,
1919
+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->tva_tx, $line->localtax1_tx,
1920 1920
 									$line->localtax2_tx, $line->qty, 0, 'HT', $line->info_bits, $line->product_type, $line->remise_percent, false,
1921 1921
 									$line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice
1922 1922
 								);
@@ -1933,14 +1933,14 @@  discard block
 block discarded – undo
1933 1933
 			else
1934 1934
 			{
1935 1935
 				dol_syslog(get_class($this).'::setMulticurrencyRate Erreur '.$sql.' - '.$this->db->error());
1936
-				$this->error=$this->db->error();
1936
+				$this->error = $this->db->error();
1937 1937
 				return -1;
1938 1938
 			}
1939 1939
 		}
1940 1940
 		else
1941 1941
 		{
1942 1942
 			dol_syslog(get_class($this).'::setMulticurrencyRate, status of the object is incompatible');
1943
-			$this->error='Status of the object is incompatible '.$this->statut;
1943
+			$this->error = 'Status of the object is incompatible '.$this->statut;
1944 1944
 			return -2;
1945 1945
 		}
1946 1946
 	}
@@ -1970,20 +1970,20 @@  discard block
 block discarded – undo
1970 1970
 				$this->cond_reglement_id = $id;
1971 1971
 				// for supplier
1972 1972
 				if (get_class($this) == 'Fournisseur') $this->cond_reglement_supplier_id = $id;
1973
-				$this->cond_reglement = $id;	// for compatibility
1973
+				$this->cond_reglement = $id; // for compatibility
1974 1974
 				return 1;
1975 1975
 			}
1976 1976
 			else
1977 1977
 			{
1978 1978
 				dol_syslog(get_class($this).'::setPaymentTerms Erreur '.$sql.' - '.$this->db->error());
1979
-				$this->error=$this->db->error();
1979
+				$this->error = $this->db->error();
1980 1980
 				return -1;
1981 1981
 			}
1982 1982
 		}
1983 1983
 		else
1984 1984
 		{
1985 1985
 			dol_syslog(get_class($this).'::setPaymentTerms, status of the object is incompatible');
1986
-			$this->error='Status of the object is incompatible '.$this->statut;
1986
+			$this->error = 'Status of the object is incompatible '.$this->statut;
1987 1987
 			return -2;
1988 1988
 		}
1989 1989
 	}
@@ -2001,7 +2001,7 @@  discard block
 block discarded – undo
2001 2001
 		if ($this->element == 'delivery' || $this->element == 'shipping') $fieldname = 'fk_address';
2002 2002
 
2003 2003
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element." SET ".$fieldname." = ".$id;
2004
-		$sql.= " WHERE rowid = ".$this->id." AND fk_statut = 0";
2004
+		$sql .= " WHERE rowid = ".$this->id." AND fk_statut = 0";
2005 2005
 
2006 2006
 		if ($this->db->query($sql))
2007 2007
 		{
@@ -2010,7 +2010,7 @@  discard block
 block discarded – undo
2010 2010
 		}
2011 2011
 		else
2012 2012
 		{
2013
-			$this->error=$this->db->error();
2013
+			$this->error = $this->db->error();
2014 2014
 			dol_syslog(get_class($this).'::setDeliveryAddress Erreur '.$sql.' - '.$this->error);
2015 2015
 			return -1;
2016 2016
 		}
@@ -2026,29 +2026,29 @@  discard block
 block discarded – undo
2026 2026
 	 *
2027 2027
 	 *  @return     int              1 if OK, 0 if KO
2028 2028
 	 */
2029
-	function setShippingMethod($shipping_method_id, $notrigger=false, $userused=null)
2029
+	function setShippingMethod($shipping_method_id, $notrigger = false, $userused = null)
2030 2030
 	{
2031 2031
         global $user;
2032 2032
 
2033
-        if (empty($userused)) $userused=$user;
2033
+        if (empty($userused)) $userused = $user;
2034 2034
 
2035 2035
         $error = 0;
2036 2036
 
2037
-		if (! $this->table_element) {
2038
-			dol_syslog(get_class($this)."::setShippingMethod was called on objet with property table_element not defined",LOG_ERR);
2037
+		if (!$this->table_element) {
2038
+			dol_syslog(get_class($this)."::setShippingMethod was called on objet with property table_element not defined", LOG_ERR);
2039 2039
 			return -1;
2040 2040
 		}
2041 2041
 
2042 2042
         $this->db->begin();
2043 2043
 
2044
-		if ($shipping_method_id<0) $shipping_method_id='NULL';
2044
+		if ($shipping_method_id < 0) $shipping_method_id = 'NULL';
2045 2045
 		dol_syslog(get_class($this).'::setShippingMethod('.$shipping_method_id.')');
2046 2046
 
2047 2047
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;
2048
-		$sql.= " SET fk_shipping_method = ".$shipping_method_id;
2049
-		$sql.= " WHERE rowid=".$this->id;
2048
+		$sql .= " SET fk_shipping_method = ".$shipping_method_id;
2049
+		$sql .= " WHERE rowid=".$this->id;
2050 2050
         $resql = $this->db->query($sql);
2051
-		if (! $resql) {
2051
+		if (!$resql) {
2052 2052
 			dol_syslog(get_class($this).'::setShippingMethod Error ', LOG_DEBUG);
2053 2053
 			$this->error = $this->db->lasterror();
2054 2054
 			$error++;
@@ -2056,8 +2056,8 @@  discard block
 block discarded – undo
2056 2056
             if (!$notrigger)
2057 2057
             {
2058 2058
                 // Call trigger
2059
-                $this->context=array('shippingmethodupdate'=>1);
2060
-                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);
2059
+                $this->context = array('shippingmethodupdate'=>1);
2060
+                $result = $this->call_trigger(strtoupper(get_class($this)).'_MODIFY', $userused);
2061 2061
                 if ($result < 0) $error++;
2062 2062
                 // End call trigger
2063 2063
             }
@@ -2067,7 +2067,7 @@  discard block
 block discarded – undo
2067 2067
             $this->db->rollback();
2068 2068
             return -1;
2069 2069
         } else {
2070
-            $this->shipping_method_id = ($shipping_method_id=='NULL')?null:$shipping_method_id;
2070
+            $this->shipping_method_id = ($shipping_method_id == 'NULL') ?null:$shipping_method_id;
2071 2071
             $this->db->commit();
2072 2072
             return 1;
2073 2073
         }
@@ -2082,23 +2082,23 @@  discard block
 block discarded – undo
2082 2082
 	 */
2083 2083
 	function setWarehouse($warehouse_id)
2084 2084
 	{
2085
-		if (! $this->table_element) {
2086
-			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined",LOG_ERR);
2085
+		if (!$this->table_element) {
2086
+			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined", LOG_ERR);
2087 2087
 			return -1;
2088 2088
 		}
2089
-		if ($warehouse_id<0) $warehouse_id='NULL';
2089
+		if ($warehouse_id < 0) $warehouse_id = 'NULL';
2090 2090
 		dol_syslog(get_class($this).'::setWarehouse('.$warehouse_id.')');
2091 2091
 
2092 2092
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;
2093
-		$sql.= " SET fk_warehouse = ".$warehouse_id;
2094
-		$sql.= " WHERE rowid=".$this->id;
2093
+		$sql .= " SET fk_warehouse = ".$warehouse_id;
2094
+		$sql .= " WHERE rowid=".$this->id;
2095 2095
 
2096 2096
 		if ($this->db->query($sql)) {
2097
-			$this->warehouse_id = ($warehouse_id=='NULL')?null:$warehouse_id;
2097
+			$this->warehouse_id = ($warehouse_id == 'NULL') ?null:$warehouse_id;
2098 2098
 			return 1;
2099 2099
 		} else {
2100 2100
 			dol_syslog(get_class($this).'::setWarehouse Error ', LOG_DEBUG);
2101
-			$this->error=$this->db->error();
2101
+			$this->error = $this->db->error();
2102 2102
 			return 0;
2103 2103
 		}
2104 2104
 	}
@@ -2113,25 +2113,25 @@  discard block
 block discarded – undo
2113 2113
 	 */
2114 2114
 	function setDocModel($user, $modelpdf)
2115 2115
 	{
2116
-		if (! $this->table_element)
2116
+		if (!$this->table_element)
2117 2117
 		{
2118
-			dol_syslog(get_class($this)."::setDocModel was called on objet with property table_element not defined",LOG_ERR);
2118
+			dol_syslog(get_class($this)."::setDocModel was called on objet with property table_element not defined", LOG_ERR);
2119 2119
 			return -1;
2120 2120
 		}
2121 2121
 
2122
-		$newmodelpdf=dol_trunc($modelpdf,255);
2122
+		$newmodelpdf = dol_trunc($modelpdf, 255);
2123 2123
 
2124 2124
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;
2125
-		$sql.= " SET model_pdf = '".$this->db->escape($newmodelpdf)."'";
2126
-		$sql.= " WHERE rowid = ".$this->id;
2125
+		$sql .= " SET model_pdf = '".$this->db->escape($newmodelpdf)."'";
2126
+		$sql .= " WHERE rowid = ".$this->id;
2127 2127
 		// if ($this->element == 'facture') $sql.= " AND fk_statut < 2";
2128 2128
 		// if ($this->element == 'propal')  $sql.= " AND fk_statut = 0";
2129 2129
 
2130 2130
 		dol_syslog(get_class($this)."::setDocModel", LOG_DEBUG);
2131
-		$resql=$this->db->query($sql);
2131
+		$resql = $this->db->query($sql);
2132 2132
 		if ($resql)
2133 2133
 		{
2134
-			$this->modelpdf=$modelpdf;
2134
+			$this->modelpdf = $modelpdf;
2135 2135
 			return 1;
2136 2136
 		}
2137 2137
 		else
@@ -2150,29 +2150,29 @@  discard block
 block discarded – undo
2150 2150
 	 *  @param      User	$userused		Object user
2151 2151
 	 *  @return		int				1 if OK, 0 if KO
2152 2152
 	 */
2153
-	function setBankAccount($fk_account, $notrigger=false, $userused=null)
2153
+	function setBankAccount($fk_account, $notrigger = false, $userused = null)
2154 2154
 	{
2155 2155
         global $user;
2156 2156
 
2157
-        if (empty($userused)) $userused=$user;
2157
+        if (empty($userused)) $userused = $user;
2158 2158
 
2159 2159
         $error = 0;
2160 2160
 
2161
-		if (! $this->table_element) {
2162
-			dol_syslog(get_class($this)."::setBankAccount was called on objet with property table_element not defined",LOG_ERR);
2161
+		if (!$this->table_element) {
2162
+			dol_syslog(get_class($this)."::setBankAccount was called on objet with property table_element not defined", LOG_ERR);
2163 2163
 			return -1;
2164 2164
 		}
2165 2165
         $this->db->begin();
2166 2166
 
2167
-		if ($fk_account<0) $fk_account='NULL';
2167
+		if ($fk_account < 0) $fk_account = 'NULL';
2168 2168
 		dol_syslog(get_class($this).'::setBankAccount('.$fk_account.')');
2169 2169
 
2170 2170
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;
2171
-		$sql.= " SET fk_account = ".$fk_account;
2172
-		$sql.= " WHERE rowid=".$this->id;
2171
+		$sql .= " SET fk_account = ".$fk_account;
2172
+		$sql .= " WHERE rowid=".$this->id;
2173 2173
 
2174 2174
         $resql = $this->db->query($sql);
2175
-        if (! $resql)
2175
+        if (!$resql)
2176 2176
         {
2177 2177
             dol_syslog(get_class($this).'::setBankAccount Error '.$sql.' - '.$this->db->error());
2178 2178
             $this->error = $this->db->lasterror();
@@ -2183,8 +2183,8 @@  discard block
 block discarded – undo
2183 2183
             if (!$notrigger)
2184 2184
             {
2185 2185
                 // Call trigger
2186
-                $this->context=array('bankaccountupdate'=>1);
2187
-                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);
2186
+                $this->context = array('bankaccountupdate'=>1);
2187
+                $result = $this->call_trigger(strtoupper(get_class($this)).'_MODIFY', $userused);
2188 2188
                 if ($result < 0) $error++;
2189 2189
                 // End call trigger
2190 2190
             }
@@ -2196,7 +2196,7 @@  discard block
 block discarded – undo
2196 2196
         }
2197 2197
         else
2198 2198
         {
2199
-            $this->fk_account = ($fk_account=='NULL')?null:$fk_account;
2199
+            $this->fk_account = ($fk_account == 'NULL') ?null:$fk_account;
2200 2200
             $this->db->commit();
2201 2201
             return 1;
2202 2202
         }
@@ -2215,26 +2215,26 @@  discard block
 block discarded – undo
2215 2215
 	 * 	@param		boolean		$fk_parent_line    Table with fk_parent_line field or not
2216 2216
 	 * 	@return		int                            <0 if KO, >0 if OK
2217 2217
 	 */
2218
-	function line_order($renum=false, $rowidorder='ASC', $fk_parent_line=true)
2218
+	function line_order($renum = false, $rowidorder = 'ASC', $fk_parent_line = true)
2219 2219
 	{
2220 2220
         // phpcs:enable
2221
-		if (! $this->table_element_line)
2221
+		if (!$this->table_element_line)
2222 2222
 		{
2223
-			dol_syslog(get_class($this)."::line_order was called on objet with property table_element_line not defined",LOG_ERR);
2223
+			dol_syslog(get_class($this)."::line_order was called on objet with property table_element_line not defined", LOG_ERR);
2224 2224
 			return -1;
2225 2225
 		}
2226
-		if (! $this->fk_element)
2226
+		if (!$this->fk_element)
2227 2227
 		{
2228
-			dol_syslog(get_class($this)."::line_order was called on objet with property fk_element not defined",LOG_ERR);
2228
+			dol_syslog(get_class($this)."::line_order was called on objet with property fk_element not defined", LOG_ERR);
2229 2229
 			return -1;
2230 2230
 		}
2231 2231
 
2232 2232
 		// Count number of lines to reorder (according to choice $renum)
2233
-		$nl=0;
2233
+		$nl = 0;
2234 2234
 		$sql = 'SELECT count(rowid) FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2235
-		$sql.= ' WHERE '.$this->fk_element.'='.$this->id;
2236
-		if (! $renum) $sql.= ' AND rang = 0';
2237
-		if ($renum) $sql.= ' AND rang <> 0';
2235
+		$sql .= ' WHERE '.$this->fk_element.'='.$this->id;
2236
+		if (!$renum) $sql .= ' AND rang = 0';
2237
+		if ($renum) $sql .= ' AND rang <> 0';
2238 2238
 
2239 2239
 		dol_syslog(get_class($this)."::line_order", LOG_DEBUG);
2240 2240
 		$resql = $this->db->query($sql);
@@ -2248,28 +2248,28 @@  discard block
 block discarded – undo
2248 2248
 		{
2249 2249
 			// The goal of this part is to reorder all lines, with all children lines sharing the same
2250 2250
 			// counter that parents.
2251
-			$rows=array();
2251
+			$rows = array();
2252 2252
 
2253 2253
 			// We first search all lines that are parent lines (for multilevel details lines)
2254 2254
 			$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2255
-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2256
-			if ($fk_parent_line) $sql.= ' AND fk_parent_line IS NULL';
2257
-			$sql.= ' ORDER BY rang ASC, rowid '.$rowidorder;
2255
+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2256
+			if ($fk_parent_line) $sql .= ' AND fk_parent_line IS NULL';
2257
+			$sql .= ' ORDER BY rang ASC, rowid '.$rowidorder;
2258 2258
 
2259 2259
 			dol_syslog(get_class($this)."::line_order search all parent lines", LOG_DEBUG);
2260 2260
 			$resql = $this->db->query($sql);
2261 2261
 			if ($resql)
2262 2262
 			{
2263
-				$i=0;
2263
+				$i = 0;
2264 2264
 				$num = $this->db->num_rows($resql);
2265 2265
 				while ($i < $num)
2266 2266
 				{
2267 2267
 					$row = $this->db->fetch_row($resql);
2268
-					$rows[] = $row[0];	// Add parent line into array rows
2268
+					$rows[] = $row[0]; // Add parent line into array rows
2269 2269
 					$childrens = $this->getChildrenOfLine($row[0]);
2270
-					if (! empty($childrens))
2270
+					if (!empty($childrens))
2271 2271
 					{
2272
-						foreach($childrens as $child)
2272
+						foreach ($childrens as $child)
2273 2273
 						{
2274 2274
 							array_push($rows, $child);
2275 2275
 						}
@@ -2278,11 +2278,11 @@  discard block
 block discarded – undo
2278 2278
 				}
2279 2279
 
2280 2280
 				// Now we set a new number for each lines (parent and children with children included into parent tree)
2281
-				if (! empty($rows))
2281
+				if (!empty($rows))
2282 2282
 				{
2283
-					foreach($rows as $key => $row)
2283
+					foreach ($rows as $key => $row)
2284 2284
 					{
2285
-						$this->updateRangOfLine($row, ($key+1));
2285
+						$this->updateRangOfLine($row, ($key + 1));
2286 2286
 					}
2287 2287
 				}
2288 2288
 			}
@@ -2302,18 +2302,18 @@  discard block
 block discarded – undo
2302 2302
 	 */
2303 2303
 	function getChildrenOfLine($id)
2304 2304
 	{
2305
-		$rows=array();
2305
+		$rows = array();
2306 2306
 
2307 2307
 		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2308
-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2309
-		$sql.= ' AND fk_parent_line = '.$id;
2310
-		$sql.= ' ORDER BY rang ASC';
2308
+		$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2309
+		$sql .= ' AND fk_parent_line = '.$id;
2310
+		$sql .= ' ORDER BY rang ASC';
2311 2311
 
2312 2312
 		dol_syslog(get_class($this)."::getChildrenOfLine search children lines for line ".$id."", LOG_DEBUG);
2313 2313
 		$resql = $this->db->query($sql);
2314 2314
 		if ($resql)
2315 2315
 		{
2316
-			$i=0;
2316
+			$i = 0;
2317 2317
 			$num = $this->db->num_rows($resql);
2318 2318
 			while ($i < $num)
2319 2319
 			{
@@ -2334,7 +2334,7 @@  discard block
 block discarded – undo
2334 2334
 	 * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not
2335 2335
 	 * 	@return	void
2336 2336
 	 */
2337
-	function line_up($rowid, $fk_parent_line=true)
2337
+	function line_up($rowid, $fk_parent_line = true)
2338 2338
 	{
2339 2339
         // phpcs:enable
2340 2340
 		$this->line_order(false, 'ASC', $fk_parent_line);
@@ -2354,7 +2354,7 @@  discard block
 block discarded – undo
2354 2354
 	 * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not
2355 2355
 	 * 	@return	void
2356 2356
 	 */
2357
-	function line_down($rowid, $fk_parent_line=true)
2357
+	function line_down($rowid, $fk_parent_line = true)
2358 2358
 	{
2359 2359
         // phpcs:enable
2360 2360
 		$this->line_order(false, 'ASC', $fk_parent_line);
@@ -2376,16 +2376,16 @@  discard block
 block discarded – undo
2376 2376
 	 * 	@param	int		$rang		Position
2377 2377
 	 * 	@return	void
2378 2378
 	 */
2379
-	function updateRangOfLine($rowid,$rang)
2379
+	function updateRangOfLine($rowid, $rang)
2380 2380
 	{
2381 2381
 		$fieldposition = 'rang';
2382 2382
 		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';
2383 2383
 
2384 2384
 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;
2385
-		$sql.= ' WHERE rowid = '.$rowid;
2385
+		$sql .= ' WHERE rowid = '.$rowid;
2386 2386
 
2387 2387
 		dol_syslog(get_class($this)."::updateRangOfLine", LOG_DEBUG);
2388
-		if (! $this->db->query($sql))
2388
+		if (!$this->db->query($sql))
2389 2389
 		{
2390 2390
 			dol_print_error($this->db);
2391 2391
 		}
@@ -2402,9 +2402,9 @@  discard block
 block discarded – undo
2402 2402
 	{
2403 2403
         // phpcs:enable
2404 2404
 		$num = count($rows);
2405
-		for ($i = 0 ; $i < $num ; $i++)
2405
+		for ($i = 0; $i < $num; $i++)
2406 2406
 		{
2407
-			$this->updateRangOfLine($rows[$i], ($i+1));
2407
+			$this->updateRangOfLine($rows[$i], ($i + 1));
2408 2408
 		}
2409 2409
 	}
2410 2410
 
@@ -2415,21 +2415,21 @@  discard block
 block discarded – undo
2415 2415
 	 * 	@param	int		$rang		Position
2416 2416
 	 * 	@return	void
2417 2417
 	 */
2418
-	function updateLineUp($rowid,$rang)
2418
+	function updateLineUp($rowid, $rang)
2419 2419
 	{
2420 2420
 		if ($rang > 1)
2421 2421
 		{
2422 2422
 			$fieldposition = 'rang';
2423 2423
 			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';
2424 2424
 
2425
-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang ;
2426
-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2427
-			$sql.= ' AND rang = '.($rang - 1);
2428
-			if ($this->db->query($sql) )
2425
+			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;
2426
+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2427
+			$sql .= ' AND rang = '.($rang - 1);
2428
+			if ($this->db->query($sql))
2429 2429
 			{
2430 2430
 				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang - 1);
2431
-				$sql.= ' WHERE rowid = '.$rowid;
2432
-				if (! $this->db->query($sql) )
2431
+				$sql .= ' WHERE rowid = '.$rowid;
2432
+				if (!$this->db->query($sql))
2433 2433
 				{
2434 2434
 					dol_print_error($this->db);
2435 2435
 				}
@@ -2449,7 +2449,7 @@  discard block
 block discarded – undo
2449 2449
 	 * 	@param	int		$max		Max
2450 2450
 	 * 	@return	void
2451 2451
 	 */
2452
-	function updateLineDown($rowid,$rang,$max)
2452
+	function updateLineDown($rowid, $rang, $max)
2453 2453
 	{
2454 2454
 		if ($rang < $max)
2455 2455
 		{
@@ -2457,13 +2457,13 @@  discard block
 block discarded – undo
2457 2457
 			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';
2458 2458
 
2459 2459
 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;
2460
-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2461
-			$sql.= ' AND rang = '.($rang+1);
2462
-			if ($this->db->query($sql) )
2460
+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2461
+			$sql .= ' AND rang = '.($rang + 1);
2462
+			if ($this->db->query($sql))
2463 2463
 			{
2464
-				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang+1);
2465
-				$sql.= ' WHERE rowid = '.$rowid;
2466
-				if (! $this->db->query($sql) )
2464
+				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang + 1);
2465
+				$sql .= ' WHERE rowid = '.$rowid;
2466
+				if (!$this->db->query($sql))
2467 2467
 				{
2468 2468
 					dol_print_error($this->db);
2469 2469
 				}
@@ -2484,7 +2484,7 @@  discard block
 block discarded – undo
2484 2484
 	function getRangOfLine($rowid)
2485 2485
 	{
2486 2486
 		$sql = 'SELECT rang FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2487
-		$sql.= ' WHERE rowid ='.$rowid;
2487
+		$sql .= ' WHERE rowid ='.$rowid;
2488 2488
 
2489 2489
 		dol_syslog(get_class($this)."::getRangOfLine", LOG_DEBUG);
2490 2490
 		$resql = $this->db->query($sql);
@@ -2504,8 +2504,8 @@  discard block
 block discarded – undo
2504 2504
 	function getIdOfLine($rang)
2505 2505
 	{
2506 2506
 		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2507
-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2508
-		$sql.= ' AND rang = '.$rang;
2507
+		$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2508
+		$sql .= ' AND rang = '.$rang;
2509 2509
 		$resql = $this->db->query($sql);
2510 2510
 		if ($resql)
2511 2511
 		{
@@ -2521,22 +2521,22 @@  discard block
 block discarded – undo
2521 2521
 	 * 	@param		int		$fk_parent_line		Parent line id
2522 2522
 	 *  @return     int  			   			Max value of rang in table of lines
2523 2523
 	 */
2524
-	function line_max($fk_parent_line=0)
2524
+	function line_max($fk_parent_line = 0)
2525 2525
 	{
2526 2526
         // phpcs:enable
2527 2527
 		// Search the last rang with fk_parent_line
2528 2528
 		if ($fk_parent_line)
2529 2529
 		{
2530 2530
 			$sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2531
-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2532
-			$sql.= ' AND fk_parent_line = '.$fk_parent_line;
2531
+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2532
+			$sql .= ' AND fk_parent_line = '.$fk_parent_line;
2533 2533
 
2534 2534
 			dol_syslog(get_class($this)."::line_max", LOG_DEBUG);
2535 2535
 			$resql = $this->db->query($sql);
2536 2536
 			if ($resql)
2537 2537
 			{
2538 2538
 				$row = $this->db->fetch_row($resql);
2539
-				if (! empty($row[0]))
2539
+				if (!empty($row[0]))
2540 2540
 				{
2541 2541
 					return $row[0];
2542 2542
 				}
@@ -2550,7 +2550,7 @@  discard block
 block discarded – undo
2550 2550
 		else
2551 2551
 		{
2552 2552
 			$sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2553
-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2553
+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2554 2554
 
2555 2555
 			dol_syslog(get_class($this)."::line_max", LOG_DEBUG);
2556 2556
 			$resql = $this->db->query($sql);
@@ -2572,15 +2572,15 @@  discard block
 block discarded – undo
2572 2572
 	function update_ref_ext($ref_ext)
2573 2573
 	{
2574 2574
         // phpcs:enable
2575
-		if (! $this->table_element)
2575
+		if (!$this->table_element)
2576 2576
 		{
2577 2577
 			dol_syslog(get_class($this)."::update_ref_ext was called on objet with property table_element not defined", LOG_ERR);
2578 2578
 			return -1;
2579 2579
 		}
2580 2580
 
2581 2581
 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;
2582
-		$sql.= " SET ref_ext = '".$this->db->escape($ref_ext)."'";
2583
-		$sql.= " WHERE ".(isset($this->table_rowid)?$this->table_rowid:'rowid')." = ". $this->id;
2582
+		$sql .= " SET ref_ext = '".$this->db->escape($ref_ext)."'";
2583
+		$sql .= " WHERE ".(isset($this->table_rowid) ? $this->table_rowid : 'rowid')." = ".$this->id;
2584 2584
 
2585 2585
 		dol_syslog(get_class($this)."::update_ref_ext", LOG_DEBUG);
2586 2586
 		if ($this->db->query($sql))
@@ -2590,7 +2590,7 @@  discard block
 block discarded – undo
2590 2590
 		}
2591 2591
 		else
2592 2592
 		{
2593
-			$this->error=$this->db->error();
2593
+			$this->error = $this->db->error();
2594 2594
 			return -1;
2595 2595
 		}
2596 2596
 	}
@@ -2603,31 +2603,31 @@  discard block
 block discarded – undo
2603 2603
 	 *  @param		string		$suffix		'', '_public' or '_private'
2604 2604
 	 *  @return     int      		   		<0 if KO, >0 if OK
2605 2605
 	 */
2606
-	function update_note($note, $suffix='')
2606
+	function update_note($note, $suffix = '')
2607 2607
 	{
2608 2608
         // phpcs:enable
2609 2609
 		global $user;
2610 2610
 
2611
-		if (! $this->table_element)
2611
+		if (!$this->table_element)
2612 2612
 		{
2613
-			$this->error='update_note was called on objet with property table_element not defined';
2613
+			$this->error = 'update_note was called on objet with property table_element not defined';
2614 2614
 			dol_syslog(get_class($this)."::update_note was called on objet with property table_element not defined", LOG_ERR);
2615 2615
 			return -1;
2616 2616
 		}
2617
-		if (! in_array($suffix,array('','_public','_private')))
2617
+		if (!in_array($suffix, array('', '_public', '_private')))
2618 2618
 		{
2619
-			$this->error='update_note Parameter suffix must be empty, \'_private\' or \'_public\'';
2619
+			$this->error = 'update_note Parameter suffix must be empty, \'_private\' or \'_public\'';
2620 2620
 			dol_syslog(get_class($this)."::update_note Parameter suffix must be empty, '_private' or '_public'", LOG_ERR);
2621 2621
 			return -2;
2622 2622
 		}
2623 2623
 		// Special cas
2624 2624
 		//var_dump($this->table_element);exit;
2625
-		if ($this->table_element == 'product') $suffix='';
2625
+		if ($this->table_element == 'product') $suffix = '';
2626 2626
 
2627 2627
 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;
2628
-		$sql.= " SET note".$suffix." = ".(!empty($note)?("'".$this->db->escape($note)."'"):"NULL");
2629
-		$sql.= " ,".(in_array($this->table_element, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))?"fk_user_mod":"fk_user_modif")." = ".$user->id;
2630
-		$sql.= " WHERE rowid =". $this->id;
2628
+		$sql .= " SET note".$suffix." = ".(!empty($note) ? ("'".$this->db->escape($note)."'") : "NULL");
2629
+		$sql .= " ,".(in_array($this->table_element, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment')) ? "fk_user_mod" : "fk_user_modif")." = ".$user->id;
2630
+		$sql .= " WHERE rowid =".$this->id;
2631 2631
 
2632 2632
 		dol_syslog(get_class($this)."::update_note", LOG_DEBUG);
2633 2633
 		if ($this->db->query($sql))
@@ -2636,14 +2636,14 @@  discard block
 block discarded – undo
2636 2636
 			else if ($suffix == '_private') $this->note_private = $note;
2637 2637
 			else
2638 2638
 			{
2639
-				$this->note = $note;      // deprecated
2639
+				$this->note = $note; // deprecated
2640 2640
 				$this->note_private = $note;
2641 2641
 			}
2642 2642
 			return 1;
2643 2643
 		}
2644 2644
 		else
2645 2645
 		{
2646
-			$this->error=$this->db->lasterror();
2646
+			$this->error = $this->db->lasterror();
2647 2647
 			return -1;
2648 2648
 		}
2649 2649
 	}
@@ -2660,7 +2660,7 @@  discard block
 block discarded – undo
2660 2660
 	function update_note_public($note)
2661 2661
 	{
2662 2662
         // phpcs:enable
2663
-		return $this->update_note($note,'_public');
2663
+		return $this->update_note($note, '_public');
2664 2664
 	}
2665 2665
 
2666 2666
     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps
@@ -2674,7 +2674,7 @@  discard block
 block discarded – undo
2674 2674
 	 *  @param	Societe	$seller				If roundingadjust is '0' or '1' or maybe 'auto', it means we recalculate total for lines before calculating total for object and for this, we need seller object.
2675 2675
 	 *	@return	int    			           	<0 if KO, >0 if OK
2676 2676
 	 */
2677
-	function update_price($exclspec=0,$roundingadjust='none',$nodatabaseupdate=0,$seller=null)
2677
+	function update_price($exclspec = 0, $roundingadjust = 'none', $nodatabaseupdate = 0, $seller = null)
2678 2678
 	{
2679 2679
         // phpcs:enable
2680 2680
 		global $conf, $hookmanager, $action;
@@ -2694,8 +2694,8 @@  discard block
 block discarded – undo
2694 2694
 		elseif ($this->element == 'supplier_proposal')
2695 2695
 			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";
2696 2696
 
2697
-		if (! empty($MODULE)) {
2698
-			if (! empty($conf->global->$MODULE)) {
2697
+		if (!empty($MODULE)) {
2698
+			if (!empty($conf->global->$MODULE)) {
2699 2699
 				$modsactivated = explode(',', $conf->global->$MODULE);
2700 2700
 				foreach ($modsactivated as $mod) {
2701 2701
 					if ($conf->$mod->enabled)
@@ -2706,44 +2706,44 @@  discard block
 block discarded – undo
2706 2706
 
2707 2707
 		include_once DOL_DOCUMENT_ROOT.'/core/lib/price.lib.php';
2708 2708
 
2709
-		if ($roundingadjust == '-1') $roundingadjust='auto';	// For backward compatibility
2709
+		if ($roundingadjust == '-1') $roundingadjust = 'auto'; // For backward compatibility
2710 2710
 
2711
-		$forcedroundingmode=$roundingadjust;
2712
-		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode=$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;
2713
-		elseif ($forcedroundingmode == 'auto') $forcedroundingmode='0';
2711
+		$forcedroundingmode = $roundingadjust;
2712
+		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode = $conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;
2713
+		elseif ($forcedroundingmode == 'auto') $forcedroundingmode = '0';
2714 2714
 
2715
-		$error=0;
2715
+		$error = 0;
2716 2716
 
2717 2717
 		$multicurrency_tx = !empty($this->multicurrency_tx) ? $this->multicurrency_tx : 1;
2718 2718
 
2719 2719
 		// Define constants to find lines to sum
2720
-		$fieldtva='total_tva';
2721
-		$fieldlocaltax1='total_localtax1';
2722
-		$fieldlocaltax2='total_localtax2';
2723
-		$fieldup='subprice';
2720
+		$fieldtva = 'total_tva';
2721
+		$fieldlocaltax1 = 'total_localtax1';
2722
+		$fieldlocaltax2 = 'total_localtax2';
2723
+		$fieldup = 'subprice';
2724 2724
 		if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier')
2725 2725
 		{
2726
-			$fieldtva='tva';
2727
-			$fieldup='pu_ht';
2726
+			$fieldtva = 'tva';
2727
+			$fieldup = 'pu_ht';
2728 2728
 		}
2729 2729
 		if ($this->element == 'expensereport')
2730 2730
 		{
2731
-			$fieldup='value_unit';
2731
+			$fieldup = 'value_unit';
2732 2732
 		}
2733 2733
 
2734 2734
 		$sql = 'SELECT rowid, qty, '.$fieldup.' as up, remise_percent, total_ht, '.$fieldtva.' as total_tva, total_ttc, '.$fieldlocaltax1.' as total_localtax1, '.$fieldlocaltax2.' as total_localtax2,';
2735
-		$sql.= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';
2736
-			if ($this->table_element_line == 'facturedet') $sql.= ', situation_percent';
2737
-			$sql.= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';
2738
-		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2739
-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;
2735
+		$sql .= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';
2736
+			if ($this->table_element_line == 'facturedet') $sql .= ', situation_percent';
2737
+			$sql .= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';
2738
+		$sql .= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;
2739
+		$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;
2740 2740
 		if ($exclspec)
2741 2741
 		{
2742
-			$product_field='product_type';
2743
-			if ($this->table_element_line == 'contratdet') $product_field='';    // contratdet table has no product_type field
2744
-			if ($product_field) $sql.= ' AND '.$product_field.' <> 9';
2742
+			$product_field = 'product_type';
2743
+			if ($this->table_element_line == 'contratdet') $product_field = ''; // contratdet table has no product_type field
2744
+			if ($product_field) $sql .= ' AND '.$product_field.' <> 9';
2745 2745
 		}
2746
-		$sql.= ' ORDER by rowid';	// We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used
2746
+		$sql .= ' ORDER by rowid'; // We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used
2747 2747
 
2748 2748
 		dol_syslog(get_class($this)."::update_price", LOG_DEBUG);
2749 2749
 		$resql = $this->db->query($sql);
@@ -2757,7 +2757,7 @@  discard block
 block discarded – undo
2757 2757
 			$total_ht_by_vats  = array();
2758 2758
 			$total_tva_by_vats = array();
2759 2759
 			$total_ttc_by_vats = array();
2760
-			$this->multicurrency_total_ht	= 0;
2760
+			$this->multicurrency_total_ht = 0;
2761 2761
 			$this->multicurrency_total_tva	= 0;
2762 2762
 			$this->multicurrency_total_ttc	= 0;
2763 2763
 
@@ -2768,54 +2768,54 @@  discard block
 block discarded – undo
2768 2768
 				$obj = $this->db->fetch_object($resql);
2769 2769
 
2770 2770
 				// Note: There is no check on detail line and no check on total, if $forcedroundingmode = 'none'
2771
-				$parameters=array('fk_element' => $obj->rowid);
2771
+				$parameters = array('fk_element' => $obj->rowid);
2772 2772
 				$reshook = $hookmanager->executeHooks('changeRoundingMode', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks
2773 2773
 
2774 2774
 				if (empty($reshook) && $forcedroundingmode == '0')	// Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'
2775 2775
 				{
2776
-					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);
2777
-					$tmpcal=calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);
2778
-					$diff=price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);
2776
+					$localtax_array = array($obj->localtax1_type, $obj->localtax1_tx, $obj->localtax2_type, $obj->localtax2_tx);
2777
+					$tmpcal = calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);
2778
+					$diff = price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);
2779 2779
 					if ($diff)
2780 2780
 					{
2781
-						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;
2781
+						$sqlfix = "UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;
2782 2782
 						dol_syslog('We found unconsistent data into detailed line (difference of '.$diff.') for line rowid = '.$obj->rowid." (total vat of line calculated=".$tmpcal[1].", database=".$obj->total_tva."). We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);
2783
-								$resqlfix=$this->db->query($sqlfix);
2784
-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');
2783
+								$resqlfix = $this->db->query($sqlfix);
2784
+								if (!$resqlfix) dol_print_error($this->db, 'Failed to update line');
2785 2785
 								$obj->total_tva = $tmpcal[1];
2786 2786
 								$obj->total_ttc = $tmpcal[2];
2787 2787
 						//
2788 2788
 					}
2789 2789
 				}
2790 2790
 
2791
-				$this->total_ht        += $obj->total_ht;		// The field visible at end of line detail
2791
+				$this->total_ht        += $obj->total_ht; // The field visible at end of line detail
2792 2792
 				$this->total_tva       += $obj->total_tva;
2793 2793
 				$this->total_localtax1 += $obj->total_localtax1;
2794 2794
 				$this->total_localtax2 += $obj->total_localtax2;
2795 2795
 				$this->total_ttc       += $obj->total_ttc;
2796
-				$this->multicurrency_total_ht        += $obj->multicurrency_total_ht;		// The field visible at end of line detail
2796
+				$this->multicurrency_total_ht        += $obj->multicurrency_total_ht; // The field visible at end of line detail
2797 2797
 				$this->multicurrency_total_tva       += $obj->multicurrency_total_tva;
2798 2798
 				$this->multicurrency_total_ttc       += $obj->multicurrency_total_ttc;
2799 2799
 
2800
-				if (! isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate]=0;
2801
-				if (! isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate]=0;
2802
-				if (! isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate]=0;
2800
+				if (!isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate] = 0;
2801
+				if (!isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate] = 0;
2802
+				if (!isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate] = 0;
2803 2803
 				$total_ht_by_vats[$obj->vatrate]  += $obj->total_ht;
2804 2804
 				$total_tva_by_vats[$obj->vatrate] += $obj->total_tva;
2805 2805
 				$total_ttc_by_vats[$obj->vatrate] += $obj->total_ttc;
2806 2806
 
2807 2807
 				if ($forcedroundingmode == '1')	// Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency
2808 2808
 				{
2809
-					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);
2810
-					$diff=price2num($total_tva_by_vats[$obj->vatrate]-$tmpvat, 'MT', 1);
2809
+					$tmpvat = price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);
2810
+					$diff = price2num($total_tva_by_vats[$obj->vatrate] - $tmpvat, 'MT', 1);
2811 2811
 					//print 'Line '.$i.' rowid='.$obj->rowid.' vat_rate='.$obj->vatrate.' total_ht='.$obj->total_ht.' total_tva='.$obj->total_tva.' total_ttc='.$obj->total_ttc.' total_ht_by_vats='.$total_ht_by_vats[$obj->vatrate].' total_tva_by_vats='.$total_tva_by_vats[$obj->vatrate].' (new calculation = '.$tmpvat.') total_ttc_by_vats='.$total_ttc_by_vats[$obj->vatrate].($diff?" => DIFF":"")."<br>\n";
2812 2812
 					if ($diff)
2813 2813
 					{
2814 2814
 						if (abs($diff) > 0.1) { dol_syslog('A rounding difference was detected into TOTAL but is too high to be corrected', LOG_WARNING); exit; }
2815
-						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;
2815
+						$sqlfix = "UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;
2816 2816
 						dol_syslog('We found a difference of '.$diff.' for line rowid = '.$obj->rowid.". We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);
2817
-								$resqlfix=$this->db->query($sqlfix);
2818
-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');
2817
+								$resqlfix = $this->db->query($sqlfix);
2818
+								if (!$resqlfix) dol_print_error($this->db, 'Failed to update line');
2819 2819
 								$this->total_tva -= $diff;
2820 2820
 								$this->total_ttc -= $diff;
2821 2821
 								$total_tva_by_vats[$obj->vatrate] -= $diff;
@@ -2827,11 +2827,11 @@  discard block
 block discarded – undo
2827 2827
 			}
2828 2828
 
2829 2829
 			// Add revenue stamp to total
2830
-			$this->total_ttc       			+= isset($this->revenuestamp)?$this->revenuestamp:0;
2831
-			$this->multicurrency_total_ttc  += isset($this->revenuestamp)?($this->revenuestamp * $multicurrency_tx):0;
2830
+			$this->total_ttc += isset($this->revenuestamp) ? $this->revenuestamp : 0;
2831
+			$this->multicurrency_total_ttc += isset($this->revenuestamp) ? ($this->revenuestamp * $multicurrency_tx) : 0;
2832 2832
 
2833 2833
 			// Situations totals
2834
-			if ($this->situation_cycle_ref && $this->situation_counter > 1 && method_exists($this, 'get_prev_sits') && $this->type != $this::TYPE_CREDIT_NOTE )
2834
+			if ($this->situation_cycle_ref && $this->situation_counter > 1 && method_exists($this, 'get_prev_sits') && $this->type != $this::TYPE_CREDIT_NOTE)
2835 2835
 			{
2836 2836
 				$prev_sits = $this->get_prev_sits();
2837 2837
 
@@ -2850,17 +2850,17 @@  discard block
 block discarded – undo
2850 2850
 			$this->db->free($resql);
2851 2851
 
2852 2852
 			// Now update global field total_ht, total_ttc and tva
2853
-			$fieldht='total_ht';
2854
-			$fieldtva='tva';
2855
-			$fieldlocaltax1='localtax1';
2856
-			$fieldlocaltax2='localtax2';
2857
-			$fieldttc='total_ttc';
2853
+			$fieldht = 'total_ht';
2854
+			$fieldtva = 'tva';
2855
+			$fieldlocaltax1 = 'localtax1';
2856
+			$fieldlocaltax2 = 'localtax2';
2857
+			$fieldttc = 'total_ttc';
2858 2858
 			// Specific code for backward compatibility with old field names
2859
-			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht='total';
2860
-			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva='total_tva';
2861
-			if ($this->element == 'propal')                                                $fieldttc='total';
2862
-			if ($this->element == 'expensereport')                                         $fieldtva='total_tva';
2863
-			if ($this->element == 'supplier_proposal')                                     $fieldttc='total';
2859
+			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht = 'total';
2860
+			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva = 'total_tva';
2861
+			if ($this->element == 'propal')                                                $fieldttc = 'total';
2862
+			if ($this->element == 'expensereport')                                         $fieldtva = 'total_tva';
2863
+			if ($this->element == 'supplier_proposal')                                     $fieldttc = 'total';
2864 2864
 
2865 2865
 			if (empty($nodatabaseupdate))
2866 2866
 			{
@@ -2877,16 +2877,16 @@  discard block
 block discarded – undo
2877 2877
 
2878 2878
 
2879 2879
 				dol_syslog(get_class($this)."::update_price", LOG_DEBUG);
2880
-				$resql=$this->db->query($sql);
2881
-				if (! $resql)
2880
+				$resql = $this->db->query($sql);
2881
+				if (!$resql)
2882 2882
 				{
2883 2883
 					$error++;
2884
-					$this->error=$this->db->lasterror();
2885
-					$this->errors[]=$this->db->lasterror();
2884
+					$this->error = $this->db->lasterror();
2885
+					$this->errors[] = $this->db->lasterror();
2886 2886
 				}
2887 2887
 			}
2888 2888
 
2889
-			if (! $error)
2889
+			if (!$error)
2890 2890
 			{
2891 2891
 				return 1;
2892 2892
 			}
@@ -2897,7 +2897,7 @@  discard block
 block discarded – undo
2897 2897
 		}
2898 2898
 		else
2899 2899
 		{
2900
-			dol_print_error($this->db,'Bad request in update_price');
2900
+			dol_print_error($this->db, 'Bad request in update_price');
2901 2901
 			return -1;
2902 2902
 		}
2903 2903
 	}
@@ -2911,30 +2911,30 @@  discard block
 block discarded – undo
2911 2911
 	 *	@return		int					<=0 if KO, >0 if OK
2912 2912
 	 *	@see		fetchObjectLinked, updateObjectLinked, deleteObjectLinked
2913 2913
 	 */
2914
-	function add_object_linked($origin=null, $origin_id=null)
2914
+	function add_object_linked($origin = null, $origin_id = null)
2915 2915
 	{
2916 2916
         // phpcs:enable
2917
-		$origin = (! empty($origin) ? $origin : $this->origin);
2918
-		$origin_id = (! empty($origin_id) ? $origin_id : $this->origin_id);
2917
+		$origin = (!empty($origin) ? $origin : $this->origin);
2918
+		$origin_id = (!empty($origin_id) ? $origin_id : $this->origin_id);
2919 2919
 
2920 2920
 		// Special case
2921
-		if ($origin == 'order') $origin='commande';
2922
-		if ($origin == 'invoice') $origin='facture';
2923
-		if ($origin == 'invoice_template') $origin='facturerec';
2924
-    	if ($origin == 'supplierorder') $origin='order_supplier';
2921
+		if ($origin == 'order') $origin = 'commande';
2922
+		if ($origin == 'invoice') $origin = 'facture';
2923
+		if ($origin == 'invoice_template') $origin = 'facturerec';
2924
+    	if ($origin == 'supplierorder') $origin = 'order_supplier';
2925 2925
 		$this->db->begin();
2926 2926
 
2927 2927
 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";
2928
-		$sql.= "fk_source";
2929
-		$sql.= ", sourcetype";
2930
-		$sql.= ", fk_target";
2931
-		$sql.= ", targettype";
2932
-		$sql.= ") VALUES (";
2933
-		$sql.= $origin_id;
2934
-		$sql.= ", '".$this->db->escape($origin)."'";
2935
-		$sql.= ", ".$this->id;
2936
-		$sql.= ", '".$this->db->escape($this->element)."'";
2937
-		$sql.= ")";
2928
+		$sql .= "fk_source";
2929
+		$sql .= ", sourcetype";
2930
+		$sql .= ", fk_target";
2931
+		$sql .= ", targettype";
2932
+		$sql .= ") VALUES (";
2933
+		$sql .= $origin_id;
2934
+		$sql .= ", '".$this->db->escape($origin)."'";
2935
+		$sql .= ", ".$this->id;
2936
+		$sql .= ", '".$this->db->escape($this->element)."'";
2937
+		$sql .= ")";
2938 2938
 
2939 2939
 		dol_syslog(get_class($this)."::add_object_linked", LOG_DEBUG);
2940 2940
 		if ($this->db->query($sql))
@@ -2944,7 +2944,7 @@  discard block
 block discarded – undo
2944 2944
 	  	}
2945 2945
 	  	else
2946 2946
 	  	{
2947
-	  		$this->error=$this->db->lasterror();
2947
+	  		$this->error = $this->db->lasterror();
2948 2948
 	  		$this->db->rollback();
2949 2949
 	  		return 0;
2950 2950
 	  	}
@@ -2972,33 +2972,33 @@  discard block
 block discarded – undo
2972 2972
 	 *	@return int							<0 if KO, >0 if OK
2973 2973
 	 *  @see	add_object_linked, updateObjectLinked, deleteObjectLinked
2974 2974
 	 */
2975
-	function fetchObjectLinked($sourceid=null,$sourcetype='',$targetid=null,$targettype='',$clause='OR',$alsosametype=1,$orderby='sourcetype',$loadalsoobjects=1)
2975
+	function fetchObjectLinked($sourceid = null, $sourcetype = '', $targetid = null, $targettype = '', $clause = 'OR', $alsosametype = 1, $orderby = 'sourcetype', $loadalsoobjects = 1)
2976 2976
 	{
2977 2977
 		global $conf;
2978 2978
 
2979
-		$this->linkedObjectsIds=array();
2980
-		$this->linkedObjects=array();
2979
+		$this->linkedObjectsIds = array();
2980
+		$this->linkedObjects = array();
2981 2981
 
2982
-		$justsource=false;
2983
-		$justtarget=false;
2984
-		$withtargettype=false;
2985
-		$withsourcetype=false;
2982
+		$justsource = false;
2983
+		$justtarget = false;
2984
+		$withtargettype = false;
2985
+		$withsourcetype = false;
2986 2986
 
2987
-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid))
2987
+		if (!empty($sourceid) && !empty($sourcetype) && empty($targetid))
2988 2988
 		{
2989
-			$justsource=true;  // the source (id and type) is a search criteria
2990
-			if (! empty($targettype)) $withtargettype=true;
2989
+			$justsource = true; // the source (id and type) is a search criteria
2990
+			if (!empty($targettype)) $withtargettype = true;
2991 2991
 		}
2992
-		if (! empty($targetid) && ! empty($targettype) && empty($sourceid))
2992
+		if (!empty($targetid) && !empty($targettype) && empty($sourceid))
2993 2993
 		{
2994
-			$justtarget=true;  // the target (id and type) is a search criteria
2995
-			if (! empty($sourcetype)) $withsourcetype=true;
2994
+			$justtarget = true; // the target (id and type) is a search criteria
2995
+			if (!empty($sourcetype)) $withsourcetype = true;
2996 2996
 		}
2997 2997
 
2998
-		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);
2999
-		$targetid = (! empty($targetid) ? $targetid : $this->id);
3000
-		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);
3001
-		$targettype = (! empty($targettype) ? $targettype : $this->element);
2998
+		$sourceid = (!empty($sourceid) ? $sourceid : $this->id);
2999
+		$targetid = (!empty($targetid) ? $targetid : $this->id);
3000
+		$sourcetype = (!empty($sourcetype) ? $sourcetype : $this->element);
3001
+		$targettype = (!empty($targettype) ? $targettype : $this->element);
3002 3002
 
3003 3003
 		/*if (empty($sourceid) && empty($targetid))
3004 3004
 		 {
@@ -3008,25 +3008,25 @@  discard block
 block discarded – undo
3008 3008
 
3009 3009
 		// Links between objects are stored in table element_element
3010 3010
 		$sql = 'SELECT rowid, fk_source, sourcetype, fk_target, targettype';
3011
-		$sql.= ' FROM '.MAIN_DB_PREFIX.'element_element';
3012
-		$sql.= " WHERE ";
3011
+		$sql .= ' FROM '.MAIN_DB_PREFIX.'element_element';
3012
+		$sql .= " WHERE ";
3013 3013
 		if ($justsource || $justtarget)
3014 3014
 		{
3015 3015
 			if ($justsource)
3016 3016
 			{
3017
-				$sql.= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";
3018
-				if ($withtargettype) $sql.= " AND targettype = '".$targettype."'";
3017
+				$sql .= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";
3018
+				if ($withtargettype) $sql .= " AND targettype = '".$targettype."'";
3019 3019
 			}
3020 3020
 			else if ($justtarget)
3021 3021
 			{
3022
-				$sql.= "fk_target = ".$targetid." AND targettype = '".$targettype."'";
3023
-				if ($withsourcetype) $sql.= " AND sourcetype = '".$sourcetype."'";
3022
+				$sql .= "fk_target = ".$targetid." AND targettype = '".$targettype."'";
3023
+				if ($withsourcetype) $sql .= " AND sourcetype = '".$sourcetype."'";
3024 3024
 			}
3025 3025
 		}
3026 3026
 		else
3027 3027
 		{
3028
-			$sql.= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";
3029
-			$sql.= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";
3028
+			$sql .= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";
3029
+			$sql .= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";
3030 3030
 		}
3031 3031
 		$sql .= ' ORDER BY '.$orderby;
3032 3032
 
@@ -3043,36 +3043,36 @@  discard block
 block discarded – undo
3043 3043
 				{
3044 3044
 					if ($justsource)
3045 3045
 					{
3046
-						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;
3046
+						$this->linkedObjectsIds[$obj->targettype][$obj->rowid] = $obj->fk_target;
3047 3047
 					}
3048 3048
 					else if ($justtarget)
3049 3049
 					{
3050
-						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;
3050
+						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid] = $obj->fk_source;
3051 3051
 					}
3052 3052
 				}
3053 3053
 				else
3054 3054
 				{
3055 3055
 					if ($obj->fk_source == $sourceid && $obj->sourcetype == $sourcetype)
3056 3056
 					{
3057
-						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;
3057
+						$this->linkedObjectsIds[$obj->targettype][$obj->rowid] = $obj->fk_target;
3058 3058
 					}
3059 3059
 					if ($obj->fk_target == $targetid && $obj->targettype == $targettype)
3060 3060
 					{
3061
-						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;
3061
+						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid] = $obj->fk_source;
3062 3062
 					}
3063 3063
 				}
3064 3064
 				$i++;
3065 3065
 			}
3066 3066
 
3067
-			if (! empty($this->linkedObjectsIds))
3067
+			if (!empty($this->linkedObjectsIds))
3068 3068
 			{
3069 3069
 				$tmparray = $this->linkedObjectsIds;
3070
-				foreach($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)
3070
+				foreach ($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)
3071 3071
 				{
3072 3072
 					// Parse element/subelement (ex: project_task, cabinetmed_consultation, ...)
3073 3073
 					$module = $element = $subelement = $objecttype;
3074 3074
 					if ($objecttype != 'supplier_proposal' && $objecttype != 'order_supplier' && $objecttype != 'invoice_supplier'
3075
-						&& preg_match('/^([^_]+)_([^_]+)/i',$objecttype,$regs))
3075
+						&& preg_match('/^([^_]+)_([^_]+)/i', $objecttype, $regs))
3076 3076
 					{
3077 3077
 						$module = $element = $regs[1];
3078 3078
 						$subelement = $regs[2];
@@ -3080,31 +3080,31 @@  discard block
 block discarded – undo
3080 3080
 
3081 3081
 					$classpath = $element.'/class';
3082 3082
 					// To work with non standard classpath or module name
3083
-					if ($objecttype == 'facture')			{
3083
+					if ($objecttype == 'facture') {
3084 3084
 						$classpath = 'compta/facture/class';
3085 3085
 					}
3086
-					else if ($objecttype == 'facturerec')			{
3086
+					else if ($objecttype == 'facturerec') {
3087 3087
 						$classpath = 'compta/facture/class'; $module = 'facture';
3088 3088
 					}
3089
-					else if ($objecttype == 'propal')			{
3089
+					else if ($objecttype == 'propal') {
3090 3090
 						$classpath = 'comm/propal/class';
3091 3091
 					}
3092
-					else if ($objecttype == 'supplier_proposal')			{
3092
+					else if ($objecttype == 'supplier_proposal') {
3093 3093
 						$classpath = 'supplier_proposal/class';
3094 3094
 					}
3095
-					else if ($objecttype == 'shipping')			{
3095
+					else if ($objecttype == 'shipping') {
3096 3096
 						$classpath = 'expedition/class'; $subelement = 'expedition'; $module = 'expedition_bon';
3097 3097
 					}
3098
-					else if ($objecttype == 'delivery')			{
3098
+					else if ($objecttype == 'delivery') {
3099 3099
 						$classpath = 'livraison/class'; $subelement = 'livraison'; $module = 'livraison_bon';
3100 3100
 					}
3101
-					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{
3101
+					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier') {
3102 3102
 						$classpath = 'fourn/class'; $module = 'fournisseur';
3103 3103
 					}
3104
-					else if ($objecttype == 'fichinter')			{
3104
+					else if ($objecttype == 'fichinter') {
3105 3105
 						$classpath = 'fichinter/class'; $subelement = 'fichinter'; $module = 'ficheinter';
3106 3106
 					}
3107
-					else if ($objecttype == 'subscription')			{
3107
+					else if ($objecttype == 'subscription') {
3108 3108
 						$classpath = 'adherents/class'; $module = 'adherent';
3109 3109
 					}
3110 3110
 
@@ -3117,16 +3117,16 @@  discard block
 block discarded – undo
3117 3117
 					else if ($objecttype == 'invoice_supplier') {
3118 3118
 						$classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';
3119 3119
 					}
3120
-					else if ($objecttype == 'order_supplier')   {
3120
+					else if ($objecttype == 'order_supplier') {
3121 3121
 						$classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';
3122 3122
 					}
3123
-					else if ($objecttype == 'supplier_proposal')   {
3123
+					else if ($objecttype == 'supplier_proposal') {
3124 3124
 						$classfile = 'supplier_proposal'; $classname = 'SupplierProposal';
3125 3125
 					}
3126
-					else if ($objecttype == 'facturerec')   {
3126
+					else if ($objecttype == 'facturerec') {
3127 3127
 						$classfile = 'facture-rec'; $classname = 'FactureRec';
3128 3128
 					}
3129
-					else if ($objecttype == 'subscription')   {
3129
+					else if ($objecttype == 'subscription') {
3130 3130
 						$classfile = 'subscription'; $classname = 'Subscription';
3131 3131
 					}
3132 3132
 
@@ -3139,7 +3139,7 @@  discard block
 block discarded – undo
3139 3139
 							//print '/'.$classpath.'/'.$classfile.'.class.php '.class_exists($classname);
3140 3140
 							if (class_exists($classname))
3141 3141
 							{
3142
-								foreach($objectids as $i => $objectid)	// $i is rowid into llx_element_element
3142
+								foreach ($objectids as $i => $objectid)	// $i is rowid into llx_element_element
3143 3143
 								{
3144 3144
 									$object = new $classname($this->db);
3145 3145
 									$ret = $object->fetch($objectid);
@@ -3176,28 +3176,28 @@  discard block
 block discarded – undo
3176 3176
 	 *	@return							int	>0 if OK, <0 if KO
3177 3177
 	 *	@see	add_object_linked, fetObjectLinked, deleteObjectLinked
3178 3178
 	 */
3179
-	function updateObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='')
3179
+	function updateObjectLinked($sourceid = null, $sourcetype = '', $targetid = null, $targettype = '')
3180 3180
 	{
3181
-		$updatesource=false;
3182
-		$updatetarget=false;
3181
+		$updatesource = false;
3182
+		$updatetarget = false;
3183 3183
 
3184
-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource=true;
3185
-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $updatetarget=true;
3184
+		if (!empty($sourceid) && !empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource = true;
3185
+		else if (empty($sourceid) && empty($sourcetype) && !empty($targetid) && !empty($targettype)) $updatetarget = true;
3186 3186
 
3187 3187
 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_element SET ";
3188 3188
 		if ($updatesource)
3189 3189
 		{
3190
-			$sql.= "fk_source = ".$sourceid;
3191
-			$sql.= ", sourcetype = '".$this->db->escape($sourcetype)."'";
3192
-			$sql.= " WHERE fk_target = ".$this->id;
3193
-			$sql.= " AND targettype = '".$this->db->escape($this->element)."'";
3190
+			$sql .= "fk_source = ".$sourceid;
3191
+			$sql .= ", sourcetype = '".$this->db->escape($sourcetype)."'";
3192
+			$sql .= " WHERE fk_target = ".$this->id;
3193
+			$sql .= " AND targettype = '".$this->db->escape($this->element)."'";
3194 3194
 		}
3195 3195
 		else if ($updatetarget)
3196 3196
 		{
3197
-			$sql.= "fk_target = ".$targetid;
3198
-			$sql.= ", targettype = '".$this->db->escape($targettype)."'";
3199
-			$sql.= " WHERE fk_source = ".$this->id;
3200
-			$sql.= " AND sourcetype = '".$this->db->escape($this->element)."'";
3197
+			$sql .= "fk_target = ".$targetid;
3198
+			$sql .= ", targettype = '".$this->db->escape($targettype)."'";
3199
+			$sql .= " WHERE fk_source = ".$this->id;
3200
+			$sql .= " AND sourcetype = '".$this->db->escape($this->element)."'";
3201 3201
 		}
3202 3202
 
3203 3203
 		dol_syslog(get_class($this)."::updateObjectLinked", LOG_DEBUG);
@@ -3207,7 +3207,7 @@  discard block
 block discarded – undo
3207 3207
 		}
3208 3208
 		else
3209 3209
 		{
3210
-			$this->error=$this->db->lasterror();
3210
+			$this->error = $this->db->lasterror();
3211 3211
 			return -1;
3212 3212
 		}
3213 3213
 	}
@@ -3223,42 +3223,42 @@  discard block
 block discarded – undo
3223 3223
 	 *	@return     					int	>0 if OK, <0 if KO
3224 3224
 	 *	@see	add_object_linked, updateObjectLinked, fetchObjectLinked
3225 3225
 	 */
3226
-	function deleteObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='', $rowid='')
3226
+	function deleteObjectLinked($sourceid = null, $sourcetype = '', $targetid = null, $targettype = '', $rowid = '')
3227 3227
 	{
3228
-		$deletesource=false;
3229
-		$deletetarget=false;
3228
+		$deletesource = false;
3229
+		$deletetarget = false;
3230 3230
 
3231
-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource=true;
3232
-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $deletetarget=true;
3231
+		if (!empty($sourceid) && !empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource = true;
3232
+		else if (empty($sourceid) && empty($sourcetype) && !empty($targetid) && !empty($targettype)) $deletetarget = true;
3233 3233
 
3234
-		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);
3235
-		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);
3236
-		$targetid = (! empty($targetid) ? $targetid : $this->id);
3237
-		$targettype = (! empty($targettype) ? $targettype : $this->element);
3234
+		$sourceid = (!empty($sourceid) ? $sourceid : $this->id);
3235
+		$sourcetype = (!empty($sourcetype) ? $sourcetype : $this->element);
3236
+		$targetid = (!empty($targetid) ? $targetid : $this->id);
3237
+		$targettype = (!empty($targettype) ? $targettype : $this->element);
3238 3238
 
3239 3239
 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_element";
3240
-		$sql.= " WHERE";
3240
+		$sql .= " WHERE";
3241 3241
 		if ($rowid > 0)
3242 3242
 		{
3243
-			$sql.=" rowid = ".$rowid;
3243
+			$sql .= " rowid = ".$rowid;
3244 3244
 		}
3245 3245
 		else
3246 3246
 		{
3247 3247
 			if ($deletesource)
3248 3248
 			{
3249
-				$sql.= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";
3250
-				$sql.= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";
3249
+				$sql .= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";
3250
+				$sql .= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";
3251 3251
 			}
3252 3252
 			else if ($deletetarget)
3253 3253
 			{
3254
-				$sql.= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";
3255
-				$sql.= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";
3254
+				$sql .= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";
3255
+				$sql .= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";
3256 3256
 			}
3257 3257
 			else
3258 3258
 			{
3259
-				$sql.= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";
3260
-				$sql.= " OR";
3261
-				$sql.= " (fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."')";
3259
+				$sql .= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";
3260
+				$sql .= " OR";
3261
+				$sql .= " (fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."')";
3262 3262
 			}
3263 3263
 		}
3264 3264
 
@@ -3269,8 +3269,8 @@  discard block
 block discarded – undo
3269 3269
 		}
3270 3270
 		else
3271 3271
 		{
3272
-			$this->error=$this->db->lasterror();
3273
-			$this->errors[]=$this->error;
3272
+			$this->error = $this->db->lasterror();
3273
+			$this->errors[] = $this->error;
3274 3274
 			return -1;
3275 3275
 		}
3276 3276
 	}
@@ -3284,30 +3284,30 @@  discard block
 block discarded – undo
3284 3284
 	 *      @param	string	$trigkey		Trigger key to use for trigger
3285 3285
 	 *      @return int						<0 if KO, >0 if OK
3286 3286
 	 */
3287
-	function setStatut($status, $elementId=null, $elementType='', $trigkey='')
3287
+	function setStatut($status, $elementId = null, $elementType = '', $trigkey = '')
3288 3288
 	{
3289
-		global $user,$langs,$conf;
3289
+		global $user, $langs, $conf;
3290 3290
 
3291
-		$savElementId=$elementId;  // To be used later to know if we were using the method using the id of this or not.
3291
+		$savElementId = $elementId; // To be used later to know if we were using the method using the id of this or not.
3292 3292
 
3293
-		$elementId = (!empty($elementId)?$elementId:$this->id);
3294
-		$elementTable = (!empty($elementType)?$elementType:$this->table_element);
3293
+		$elementId = (!empty($elementId) ? $elementId : $this->id);
3294
+		$elementTable = (!empty($elementType) ? $elementType : $this->table_element);
3295 3295
 
3296 3296
 		$this->db->begin();
3297 3297
 
3298
-		$fieldstatus="fk_statut";
3299
-		if ($elementTable == 'facture_rec') $fieldstatus="suspended";
3300
-		if ($elementTable == 'mailing') $fieldstatus="statut";
3301
-		if ($elementTable == 'cronjob') $fieldstatus="status";
3302
-		if ($elementTable == 'user') $fieldstatus="statut";
3303
-		if ($elementTable == 'expensereport') $fieldstatus="fk_statut";
3304
-		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus="status";
3298
+		$fieldstatus = "fk_statut";
3299
+		if ($elementTable == 'facture_rec') $fieldstatus = "suspended";
3300
+		if ($elementTable == 'mailing') $fieldstatus = "statut";
3301
+		if ($elementTable == 'cronjob') $fieldstatus = "status";
3302
+		if ($elementTable == 'user') $fieldstatus = "statut";
3303
+		if ($elementTable == 'expensereport') $fieldstatus = "fk_statut";
3304
+		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus = "status";
3305 3305
 
3306 3306
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$elementTable;
3307
-		$sql.= " SET ".$fieldstatus." = ".$status;
3307
+		$sql .= " SET ".$fieldstatus." = ".$status;
3308 3308
 		// If status = 1 = validated, update also fk_user_valid
3309
-		if ($status == 1 && $elementTable == 'expensereport') $sql.=", fk_user_valid = ".$user->id;
3310
-		$sql.= " WHERE rowid=".$elementId;
3309
+		if ($status == 1 && $elementTable == 'expensereport') $sql .= ", fk_user_valid = ".$user->id;
3310
+		$sql .= " WHERE rowid=".$elementId;
3311 3311
 
3312 3312
 		dol_syslog(get_class($this)."::setStatut", LOG_DEBUG);
3313 3313
 		if ($this->db->query($sql))
@@ -3317,27 +3317,27 @@  discard block
 block discarded – undo
3317 3317
 			// Try autoset of trigkey
3318 3318
 			if (empty($trigkey))
3319 3319
 			{
3320
-				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey='SUPPLIER_PROPOSAL_SIGN';   // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class
3321
-				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey='SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class
3322
-				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey='SUPPLIER_PROPOSAL_CLOSE';  // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class
3323
-				if ($this->element == 'fichinter' && $status == 3) $trigkey='FICHINTER_CLASSIFY_DONE';
3324
-				if ($this->element == 'fichinter' && $status == 2) $trigkey='FICHINTER_CLASSIFY_BILLED';
3325
-				if ($this->element == 'fichinter' && $status == 1) $trigkey='FICHINTER_CLASSIFY_UNBILLED';
3320
+				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey = 'SUPPLIER_PROPOSAL_SIGN'; // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class
3321
+				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey = 'SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class
3322
+				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey = 'SUPPLIER_PROPOSAL_CLOSE'; // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class
3323
+				if ($this->element == 'fichinter' && $status == 3) $trigkey = 'FICHINTER_CLASSIFY_DONE';
3324
+				if ($this->element == 'fichinter' && $status == 2) $trigkey = 'FICHINTER_CLASSIFY_BILLED';
3325
+				if ($this->element == 'fichinter' && $status == 1) $trigkey = 'FICHINTER_CLASSIFY_UNBILLED';
3326 3326
 			}
3327 3327
 
3328 3328
 			if ($trigkey)
3329 3329
 			{
3330 3330
 				// Appel des triggers
3331
-				include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
3332
-				$interface=new Interfaces($this->db);
3333
-				$result=$interface->run_triggers($trigkey,$this,$user,$langs,$conf);
3331
+				include_once DOL_DOCUMENT_ROOT.'/core/class/interfaces.class.php';
3332
+				$interface = new Interfaces($this->db);
3333
+				$result = $interface->run_triggers($trigkey, $this, $user, $langs, $conf);
3334 3334
 				if ($result < 0) {
3335
-					$error++; $this->errors=$interface->errors;
3335
+					$error++; $this->errors = $interface->errors;
3336 3336
 				}
3337 3337
 				// Fin appel triggers
3338 3338
 			}
3339 3339
 
3340
-			if (! $error)
3340
+			if (!$error)
3341 3341
 			{
3342 3342
 				$this->db->commit();
3343 3343
 
@@ -3352,13 +3352,13 @@  discard block
 block discarded – undo
3352 3352
 			else
3353 3353
 			{
3354 3354
 				$this->db->rollback();
3355
-				dol_syslog(get_class($this)."::setStatus ".$this->error,LOG_ERR);
3355
+				dol_syslog(get_class($this)."::setStatus ".$this->error, LOG_ERR);
3356 3356
 				return -1;
3357 3357
 			}
3358 3358
 		}
3359 3359
 		else
3360 3360
 		{
3361
-			$this->error=$this->db->lasterror();
3361
+			$this->error = $this->db->lasterror();
3362 3362
 			$this->db->rollback();
3363 3363
 			return -1;
3364 3364
 		}
@@ -3372,21 +3372,21 @@  discard block
 block discarded – undo
3372 3372
 	 *  @param      string	$ref    Record ref
3373 3373
 	 *  @return		int				<0 if KO, 0 if nothing done, >0 if OK
3374 3374
 	 */
3375
-	function getCanvas($id=0,$ref='')
3375
+	function getCanvas($id = 0, $ref = '')
3376 3376
 	{
3377 3377
 		global $conf;
3378 3378
 
3379 3379
 		if (empty($id) && empty($ref)) return 0;
3380
-		if (! empty($conf->global->MAIN_DISABLE_CANVAS)) return 0;    // To increase speed. Not enabled by default.
3380
+		if (!empty($conf->global->MAIN_DISABLE_CANVAS)) return 0; // To increase speed. Not enabled by default.
3381 3381
 
3382 3382
 		// Clean parameters
3383 3383
 		$ref = trim($ref);
3384 3384
 
3385 3385
 		$sql = "SELECT rowid, canvas";
3386
-		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element;
3387
-		$sql.= " WHERE entity IN (".getEntity($this->element).")";
3388
-		if (! empty($id))  $sql.= " AND rowid = ".$id;
3389
-		if (! empty($ref)) $sql.= " AND ref = '".$this->db->escape($ref)."'";
3386
+		$sql .= " FROM ".MAIN_DB_PREFIX.$this->table_element;
3387
+		$sql .= " WHERE entity IN (".getEntity($this->element).")";
3388
+		if (!empty($id))  $sql .= " AND rowid = ".$id;
3389
+		if (!empty($ref)) $sql .= " AND ref = '".$this->db->escape($ref)."'";
3390 3390
 
3391 3391
 		$resql = $this->db->query($sql);
3392 3392
 		if ($resql)
@@ -3394,7 +3394,7 @@  discard block
 block discarded – undo
3394 3394
 			$obj = $this->db->fetch_object($resql);
3395 3395
 			if ($obj)
3396 3396
 			{
3397
-				$this->canvas   = $obj->canvas;
3397
+				$this->canvas = $obj->canvas;
3398 3398
 				return 1;
3399 3399
 			}
3400 3400
 			else return 0;
@@ -3416,7 +3416,7 @@  discard block
 block discarded – undo
3416 3416
 	function getSpecialCode($lineid)
3417 3417
 	{
3418 3418
 		$sql = 'SELECT special_code FROM '.MAIN_DB_PREFIX.$this->table_element_line;
3419
-		$sql.= ' WHERE rowid = '.$lineid;
3419
+		$sql .= ' WHERE rowid = '.$lineid;
3420 3420
 		$resql = $this->db->query($sql);
3421 3421
 		if ($resql)
3422 3422
 		{
@@ -3432,14 +3432,14 @@  discard block
 block discarded – undo
3432 3432
 	 *  @param	int		$id			Force id of object
3433 3433
 	 *  @return	int					<0 if KO, 0 if not used, >0 if already used
3434 3434
 	 */
3435
-	function isObjectUsed($id=0)
3435
+	function isObjectUsed($id = 0)
3436 3436
 	{
3437 3437
 		global $langs;
3438 3438
 
3439
-		if (empty($id)) $id=$this->id;
3439
+		if (empty($id)) $id = $this->id;
3440 3440
 
3441 3441
 		// Check parameters
3442
-		if (! isset($this->childtables) || ! is_array($this->childtables) || count($this->childtables) == 0)
3442
+		if (!isset($this->childtables) || !is_array($this->childtables) || count($this->childtables) == 0)
3443 3443
 		{
3444 3444
 			dol_print_error('Called isObjectUsed on a class with property this->childtables not defined');
3445 3445
 			return -1;
@@ -3447,24 +3447,24 @@  discard block
 block discarded – undo
3447 3447
 
3448 3448
 		$arraytoscan = $this->childtables;
3449 3449
 		// For backward compatibility, we check if array is old format array('table1', 'table2', ...)
3450
-		$tmparray=array_keys($this->childtables);
3450
+		$tmparray = array_keys($this->childtables);
3451 3451
 		if (is_numeric($tmparray[0]))
3452 3452
 		{
3453 3453
 			$arraytoscan = array_flip($this->childtables);
3454 3454
 		}
3455 3455
 
3456 3456
 		// Test if child exists
3457
-		$haschild=0;
3458
-		foreach($arraytoscan as $table => $elementname)
3457
+		$haschild = 0;
3458
+		foreach ($arraytoscan as $table => $elementname)
3459 3459
 		{
3460 3460
 			//print $id.'-'.$table.'-'.$elementname.'<br>';
3461 3461
 			// Check if third party can be deleted
3462 3462
 			$sql = "SELECT COUNT(*) as nb from ".MAIN_DB_PREFIX.$table;
3463
-			$sql.= " WHERE ".$this->fk_element." = ".$id;
3464
-			$resql=$this->db->query($sql);
3463
+			$sql .= " WHERE ".$this->fk_element." = ".$id;
3464
+			$resql = $this->db->query($sql);
3465 3465
 			if ($resql)
3466 3466
 			{
3467
-				$obj=$this->db->fetch_object($resql);
3467
+				$obj = $this->db->fetch_object($resql);
3468 3468
 				if ($obj->nb > 0)
3469 3469
 				{
3470 3470
 					$langs->load("errors");
@@ -3472,24 +3472,24 @@  discard block
 block discarded – undo
3472 3472
 					$haschild += $obj->nb;
3473 3473
 					if (is_numeric($elementname))	// old usage
3474 3474
 					{
3475
-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);
3475
+						$this->errors[] = $langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);
3476 3476
 					}
3477 3477
 					else	// new usage: $elementname=Translation key
3478 3478
 					{
3479
-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));
3479
+						$this->errors[] = $langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));
3480 3480
 					}
3481
-					break;    // We found at least one, we stop here
3481
+					break; // We found at least one, we stop here
3482 3482
 				}
3483 3483
 			}
3484 3484
 			else
3485 3485
 			{
3486
-				$this->errors[]=$this->db->lasterror();
3486
+				$this->errors[] = $this->db->lasterror();
3487 3487
 				return -1;
3488 3488
 			}
3489 3489
 		}
3490 3490
 		if ($haschild > 0)
3491 3491
 		{
3492
-			$this->errors[]="ErrorRecordHasChildren";
3492
+			$this->errors[] = "ErrorRecordHasChildren";
3493 3493
 			return $haschild;
3494 3494
 		}
3495 3495
 		else return 0;
@@ -3501,18 +3501,18 @@  discard block
 block discarded – undo
3501 3501
 	 *	@param	int		$predefined		-1=All, 0=Count free product/service only, 1=Count predefined product/service only, 2=Count predefined product, 3=Count predefined service
3502 3502
 	 *  @return	int						<0 if KO, 0 if no predefined products, nb of lines with predefined products if found
3503 3503
 	 */
3504
-	function hasProductsOrServices($predefined=-1)
3504
+	function hasProductsOrServices($predefined = -1)
3505 3505
 	{
3506
-		$nb=0;
3506
+		$nb = 0;
3507 3507
 
3508
-		foreach($this->lines as $key => $val)
3508
+		foreach ($this->lines as $key => $val)
3509 3509
 		{
3510
-			$qualified=0;
3511
-			if ($predefined == -1) $qualified=1;
3512
-			if ($predefined == 1 && $val->fk_product > 0) $qualified=1;
3513
-			if ($predefined == 0 && $val->fk_product <= 0) $qualified=1;
3514
-			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) $qualified=1;
3515
-			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) $qualified=1;
3510
+			$qualified = 0;
3511
+			if ($predefined == -1) $qualified = 1;
3512
+			if ($predefined == 1 && $val->fk_product > 0) $qualified = 1;
3513
+			if ($predefined == 0 && $val->fk_product <= 0) $qualified = 1;
3514
+			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type == 0) $qualified = 1;
3515
+			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type == 1) $qualified = 1;
3516 3516
 			if ($qualified) $nb++;
3517 3517
 		}
3518 3518
 		dol_syslog(get_class($this).'::hasProductsOrServices we found '.$nb.' qualified lines of products/servcies');
@@ -3526,24 +3526,24 @@  discard block
 block discarded – undo
3526 3526
 	 */
3527 3527
 	function getTotalDiscount()
3528 3528
 	{
3529
-		$total_discount=0.00;
3529
+		$total_discount = 0.00;
3530 3530
 
3531 3531
 		$sql = "SELECT subprice as pu_ht, qty, remise_percent, total_ht";
3532
-		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element."det";
3533
-		$sql.= " WHERE ".$this->fk_element." = ".$this->id;
3532
+		$sql .= " FROM ".MAIN_DB_PREFIX.$this->table_element."det";
3533
+		$sql .= " WHERE ".$this->fk_element." = ".$this->id;
3534 3534
 
3535 3535
 		dol_syslog(get_class($this).'::getTotalDiscount', LOG_DEBUG);
3536 3536
 		$resql = $this->db->query($sql);
3537 3537
 		if ($resql)
3538 3538
 		{
3539
-			$num=$this->db->num_rows($resql);
3540
-			$i=0;
3539
+			$num = $this->db->num_rows($resql);
3540
+			$i = 0;
3541 3541
 			while ($i < $num)
3542 3542
 			{
3543 3543
 				$obj = $this->db->fetch_object($resql);
3544 3544
 
3545 3545
 				$pu_ht = $obj->pu_ht;
3546
-				$qty= $obj->qty;
3546
+				$qty = $obj->qty;
3547 3547
 				$total_ht = $obj->total_ht;
3548 3548
 
3549 3549
 				$total_discount_line = floatval(price2num(($pu_ht * $qty) - $total_ht, 'MT'));
@@ -3577,17 +3577,17 @@  discard block
 block discarded – undo
3577 3577
 		{
3578 3578
 			if (isset($line->qty_asked))
3579 3579
 			{
3580
-				if (empty($totalOrdered)) $totalOrdered=0;  // Avoid warning because $totalOrdered is ''
3581
-				$totalOrdered+=$line->qty_asked;    // defined for shipment only
3580
+				if (empty($totalOrdered)) $totalOrdered = 0; // Avoid warning because $totalOrdered is ''
3581
+				$totalOrdered += $line->qty_asked; // defined for shipment only
3582 3582
 			}
3583 3583
 			if (isset($line->qty_shipped))
3584 3584
 			{
3585
-				if (empty($totalToShip)) $totalToShip=0;    // Avoid warning because $totalToShip is ''
3586
-				$totalToShip+=$line->qty_shipped;   // defined for shipment only
3587
-            }else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))
3585
+				if (empty($totalToShip)) $totalToShip = 0; // Avoid warning because $totalToShip is ''
3586
+				$totalToShip += $line->qty_shipped; // defined for shipment only
3587
+            } else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))
3588 3588
             {
3589
-                if (empty($totalToShip)) $totalToShip=0;
3590
-                $totalToShip+=$line->qty;   // defined for reception only
3589
+                if (empty($totalToShip)) $totalToShip = 0;
3590
+                $totalToShip += $line->qty; // defined for reception only
3591 3591
 			}
3592 3592
 
3593 3593
 			// Define qty, weight, volume, weight_units, volume_units
@@ -3600,27 +3600,27 @@  discard block
 block discarded – undo
3600 3600
 			}
3601 3601
 
3602 3602
 			$weight = $line->weight ? $line->weight : 0;
3603
-            ($weight==0 && !empty($line->product->weight))? $weight=$line->product->weight: 0;
3603
+            ($weight == 0 && !empty($line->product->weight)) ? $weight = $line->product->weight : 0;
3604 3604
 			$volume = $line->volume ? $line->volume : 0;
3605
-			($volume==0 && !empty($line->product->volume))? $volume=$line->product->volume: 0;
3605
+			($volume == 0 && !empty($line->product->volume)) ? $volume = $line->product->volume : 0;
3606 3606
 
3607
-			$weight_units=$line->weight_units;
3608
-			($weight_units==0 && !empty($line->product->weight_units))? $weight_units=$line->product->weight_units: 0;
3609
-			$volume_units=$line->volume_units;
3610
-			($volume_units==0 && !empty($line->product->volume_units))? $volume_units=$line->product->volume_units: 0;
3607
+			$weight_units = $line->weight_units;
3608
+			($weight_units == 0 && !empty($line->product->weight_units)) ? $weight_units = $line->product->weight_units : 0;
3609
+			$volume_units = $line->volume_units;
3610
+			($volume_units == 0 && !empty($line->product->volume_units)) ? $volume_units = $line->product->volume_units : 0;
3611 3611
 
3612
-			$weightUnit=0;
3613
-			$volumeUnit=0;
3614
-			if (! empty($weight_units)) $weightUnit = $weight_units;
3615
-			if (! empty($volume_units)) $volumeUnit = $volume_units;
3612
+			$weightUnit = 0;
3613
+			$volumeUnit = 0;
3614
+			if (!empty($weight_units)) $weightUnit = $weight_units;
3615
+			if (!empty($volume_units)) $volumeUnit = $volume_units;
3616 3616
 
3617
-			if (empty($totalWeight)) $totalWeight=0;  // Avoid warning because $totalWeight is ''
3618
-			if (empty($totalVolume)) $totalVolume=0;  // Avoid warning because $totalVolume is ''
3617
+			if (empty($totalWeight)) $totalWeight = 0; // Avoid warning because $totalWeight is ''
3618
+			if (empty($totalVolume)) $totalVolume = 0; // Avoid warning because $totalVolume is ''
3619 3619
 
3620 3620
 			//var_dump($line->volume_units);
3621 3621
 			if ($weight_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)
3622 3622
 			{
3623
-				$trueWeightUnit=pow(10, $weightUnit);
3623
+				$trueWeightUnit = pow(10, $weightUnit);
3624 3624
 				$totalWeight += $weight * $qty * $trueWeightUnit;
3625 3625
 			}
3626 3626
 			else {
@@ -3634,18 +3634,18 @@  discard block
 block discarded – undo
3634 3634
 			$totalWeight += $weight * $qty * $trueWeightUnit;
3635 3635
 		}
3636 3636
 		else
3637
-					$totalWeight += $weight * $qty;   // This may be wrong if we mix different units
3637
+					$totalWeight += $weight * $qty; // This may be wrong if we mix different units
3638 3638
 			}
3639 3639
 			if ($volume_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)
3640 3640
 			{
3641 3641
 				//print $line->volume."x".$line->volume_units."x".($line->volume_units < 50)."x".$volumeUnit;
3642
-				$trueVolumeUnit=pow(10, $volumeUnit);
3642
+				$trueVolumeUnit = pow(10, $volumeUnit);
3643 3643
 				//print $line->volume;
3644 3644
 				$totalVolume += $volume * $qty * $trueVolumeUnit;
3645 3645
 			}
3646 3646
 			else
3647 3647
 			{
3648
-				$totalVolume += $volume * $qty;   // This may be wrong if we mix different units
3648
+				$totalVolume += $volume * $qty; // This may be wrong if we mix different units
3649 3649
 			}
3650 3650
 		}
3651 3651
 
@@ -3662,17 +3662,17 @@  discard block
 block discarded – undo
3662 3662
 	{
3663 3663
 		$this->db->begin();
3664 3664
 
3665
-		$extraparams = (! empty($this->extraparams) ? json_encode($this->extraparams) : null);
3665
+		$extraparams = (!empty($this->extraparams) ? json_encode($this->extraparams) : null);
3666 3666
 
3667 3667
 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;
3668
-		$sql.= " SET extraparams = ".(! empty($extraparams) ? "'".$this->db->escape($extraparams)."'" : "null");
3669
-		$sql.= " WHERE rowid = ".$this->id;
3668
+		$sql .= " SET extraparams = ".(!empty($extraparams) ? "'".$this->db->escape($extraparams)."'" : "null");
3669
+		$sql .= " WHERE rowid = ".$this->id;
3670 3670
 
3671 3671
 		dol_syslog(get_class($this)."::setExtraParameters", LOG_DEBUG);
3672 3672
 		$resql = $this->db->query($sql);
3673
-		if (! $resql)
3673
+		if (!$resql)
3674 3674
 		{
3675
-			$this->error=$this->db->lasterror();
3675
+			$this->error = $this->db->lasterror();
3676 3676
 			$this->db->rollback();
3677 3677
 			return -1;
3678 3678
 		}
@@ -3707,7 +3707,7 @@  discard block
 block discarded – undo
3707 3707
 			}
3708 3708
 		}
3709 3709
 
3710
-		$out .= (($res->code && $this->location_incoterms)?' - ':'').$this->location_incoterms;
3710
+		$out .= (($res->code && $this->location_incoterms) ? ' - ' : '').$this->location_incoterms;
3711 3711
 
3712 3712
 		return $out;
3713 3713
 	}
@@ -3753,11 +3753,11 @@  discard block
 block discarded – undo
3753 3753
 		if ($this->id && $this->table_element)
3754 3754
 		{
3755 3755
 			$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;
3756
-			$sql.= " SET fk_incoterms = ".($id_incoterm > 0 ? $id_incoterm : "null");
3757
-			$sql.= ", location_incoterms = ".($id_incoterm > 0 ? "'".$this->db->escape($location)."'" : "null");
3758
-			$sql.= " WHERE rowid = " . $this->id;
3756
+			$sql .= " SET fk_incoterms = ".($id_incoterm > 0 ? $id_incoterm : "null");
3757
+			$sql .= ", location_incoterms = ".($id_incoterm > 0 ? "'".$this->db->escape($location)."'" : "null");
3758
+			$sql .= " WHERE rowid = ".$this->id;
3759 3759
 			dol_syslog(get_class($this).'::setIncoterms', LOG_DEBUG);
3760
-			$resql=$this->db->query($sql);
3760
+			$resql = $this->db->query($sql);
3761 3761
 			if ($resql)
3762 3762
 			{
3763 3763
 				$this->fk_incoterms = $id_incoterm;
@@ -3798,24 +3798,24 @@  discard block
 block discarded – undo
3798 3798
 	 */
3799 3799
 	function formAddObjectLine($dateSelector, $seller, $buyer)
3800 3800
 	{
3801
-		global $conf,$user,$langs,$object,$hookmanager;
3802
-		global $form,$bcnd,$var;
3801
+		global $conf, $user, $langs, $object, $hookmanager;
3802
+		global $form, $bcnd, $var;
3803 3803
 
3804 3804
 		// Line extrafield
3805 3805
 		require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';
3806 3806
 		$extrafieldsline = new ExtraFields($this->db);
3807
-		$extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);
3807
+		$extralabelslines = $extrafieldsline->fetch_name_optionals_label($this->table_element_line);
3808 3808
 
3809 3809
 		// Output template part (modules that overwrite templates must declare this into descriptor)
3810 3810
 		// Use global variables + $dateSelector + $seller and $buyer
3811
-		$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));
3812
-		foreach($dirtpls as $reldir)
3811
+		$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));
3812
+		foreach ($dirtpls as $reldir)
3813 3813
 		{
3814 3814
 			$tpl = dol_buildpath($reldir.'/objectline_create.tpl.php');
3815 3815
 			if (empty($conf->file->strict_mode)) {
3816
-				$res=@include $tpl;
3816
+				$res = @include $tpl;
3817 3817
 			} else {
3818
-				$res=include $tpl; // for debug
3818
+				$res = include $tpl; // for debug
3819 3819
 			}
3820 3820
 			if ($res) break;
3821 3821
 		}
@@ -3839,24 +3839,24 @@  discard block
 block discarded – undo
3839 3839
 	 *	@param  int	    	$dateSelector      	1=Show also date range input fields
3840 3840
 	 *	@return	void
3841 3841
 	 */
3842
-	function printObjectLines($action, $seller, $buyer, $selected=0, $dateSelector=0)
3842
+	function printObjectLines($action, $seller, $buyer, $selected = 0, $dateSelector = 0)
3843 3843
 	{
3844 3844
 		global $conf, $hookmanager, $langs, $user;
3845 3845
 		// TODO We should not use global var for this !
3846 3846
 		global $inputalsopricewithtax, $usemargins, $disableedit, $disablemove, $disableremove, $outputalsopricetotalwithtax;
3847 3847
 
3848 3848
 		// Define usemargins
3849
-		$usemargins=0;
3850
-		if (! empty($conf->margin->enabled) && ! empty($this->element) && in_array($this->element,array('facture','propal','commande'))) $usemargins=1;
3849
+		$usemargins = 0;
3850
+		if (!empty($conf->margin->enabled) && !empty($this->element) && in_array($this->element, array('facture', 'propal', 'commande'))) $usemargins = 1;
3851 3851
 
3852 3852
 		$num = count($this->lines);
3853 3853
 
3854 3854
 		// Line extrafield
3855 3855
 		require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';
3856 3856
 		$extrafieldsline = new ExtraFields($this->db);
3857
-		$extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);
3857
+		$extralabelslines = $extrafieldsline->fetch_name_optionals_label($this->table_element_line);
3858 3858
 
3859
-		$parameters = array('num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);
3859
+		$parameters = array('num'=>$num, 'i'=>$i, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);
3860 3860
 		$reshook = $hookmanager->executeHooks('printObjectLineTitle', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks
3861 3861
 		if (empty($reshook))
3862 3862
 		{
@@ -3866,7 +3866,7 @@  discard block
 block discarded – undo
3866 3866
 			print '<tr class="liste_titre nodrag nodrop">';
3867 3867
 
3868 3868
 			// Adds a line numbering column
3869
-			if (! empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';
3869
+			if (!empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';
3870 3870
 
3871 3871
 			// Description
3872 3872
 			print '<td class="linecoldescription">'.$langs->trans('Description').'</td>';
@@ -3890,7 +3890,7 @@  discard block
 block discarded – undo
3890 3890
 			// Qty
3891 3891
 			print '<td class="linecolqty" align="right">'.$langs->trans('Qty').'</td>';
3892 3892
 
3893
-			if($conf->global->PRODUCT_USE_UNITS)
3893
+			if ($conf->global->PRODUCT_USE_UNITS)
3894 3894
 			{
3895 3895
 				print '<td class="linecoluseunit" align="left">'.$langs->trans('Unit').'</td>';
3896 3896
 			}
@@ -3899,10 +3899,10 @@  discard block
 block discarded – undo
3899 3899
 			print '<td class="linecoldiscount" align="right">'.$langs->trans('ReductionShort').'</td>';
3900 3900
 
3901 3901
 			if ($this->situation_cycle_ref) {
3902
-				print '<td class="linecolcycleref" align="right">' . $langs->trans('Progress') . '</td>';
3902
+				print '<td class="linecolcycleref" align="right">'.$langs->trans('Progress').'</td>';
3903 3903
 			}
3904 3904
 
3905
-			if ($usemargins && ! empty($conf->margin->enabled) && empty($user->societe_id))
3905
+			if ($usemargins && !empty($conf->margin->enabled) && empty($user->societe_id))
3906 3906
 			{
3907 3907
 				if (!empty($user->rights->margins->creer))
3908 3908
 				{
@@ -3912,9 +3912,9 @@  discard block
 block discarded – undo
3912 3912
 						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';
3913 3913
 				}
3914 3914
 
3915
-				if (! empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)
3915
+				if (!empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)
3916 3916
 					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';
3917
-				if (! empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)
3917
+				if (!empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)
3918 3918
 					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';
3919 3919
 			}
3920 3920
 
@@ -3926,13 +3926,13 @@  discard block
 block discarded – undo
3926 3926
 
3927 3927
 			if ($outputalsopricetotalwithtax) print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';
3928 3928
 
3929
-			print '<td class="linecoledit"></td>';  // No width to allow autodim
3929
+			print '<td class="linecoledit"></td>'; // No width to allow autodim
3930 3930
 
3931 3931
 			print '<td class="linecoldelete" width="10"></td>';
3932 3932
 
3933 3933
 			print '<td class="linecolmove" width="10"></td>';
3934 3934
 
3935
-			if($action == 'selectlines')
3935
+			if ($action == 'selectlines')
3936 3936
 			{
3937 3937
 			    print '<td class="linecolcheckall" align="center">';
3938 3938
 			    print '<input type="checkbox" class="linecheckboxtoggle" />';
@@ -3945,7 +3945,7 @@  discard block
 block discarded – undo
3945 3945
 		}
3946 3946
 
3947 3947
 		$var = true;
3948
-		$i	 = 0;
3948
+		$i = 0;
3949 3949
 
3950 3950
 		print "<tbody>\n";
3951 3951
 		foreach ($this->lines as $line)
@@ -3958,18 +3958,18 @@  discard block
 block discarded – undo
3958 3958
 			{
3959 3959
 				if (empty($line->fk_parent_line))
3960 3960
 				{
3961
-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);
3962
-					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks
3961
+					$parameters = array('line'=>$line, 'var'=>$var, 'num'=>$num, 'i'=>$i, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);
3962
+					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks
3963 3963
 				}
3964 3964
 				else
3965 3965
 				{
3966
-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);
3967
-					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks
3966
+					$parameters = array('line'=>$line, 'var'=>$var, 'num'=>$num, 'i'=>$i, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);
3967
+					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks
3968 3968
 				}
3969 3969
 			}
3970 3970
 			if (empty($reshook))
3971 3971
 			{
3972
-				$this->printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected,$extrafieldsline);
3972
+				$this->printObjectLine($action, $line, $var, $num, $i, $dateSelector, $seller, $buyer, $selected, $extrafieldsline);
3973 3973
 			}
3974 3974
 
3975 3975
 			$i++;
@@ -3993,23 +3993,23 @@  discard block
 block discarded – undo
3993 3993
 	 *  @param  int			$extrafieldsline	Object of extrafield line attribute
3994 3994
 	 *	@return	void
3995 3995
 	 */
3996
-	function printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected=0,$extrafieldsline=0)
3996
+	function printObjectLine($action, $line, $var, $num, $i, $dateSelector, $seller, $buyer, $selected = 0, $extrafieldsline = 0)
3997 3997
 	{
3998
-		global $conf,$langs,$user,$object,$hookmanager;
3999
-		global $form,$bc,$bcdd;
4000
-		global $object_rights, $disableedit, $disablemove, $disableremove;   // TODO We should not use global var for this !
3998
+		global $conf, $langs, $user, $object, $hookmanager;
3999
+		global $form, $bc, $bcdd;
4000
+		global $object_rights, $disableedit, $disablemove, $disableremove; // TODO We should not use global var for this !
4001 4001
 
4002 4002
 		$object_rights = $this->getRights();
4003 4003
 
4004
-		$element=$this->element;
4004
+		$element = $this->element;
4005 4005
 
4006
-		$text=''; $description=''; $type=0;
4006
+		$text = ''; $description = ''; $type = 0;
4007 4007
 
4008 4008
 		// Show product and description
4009
-		$type=(! empty($line->product_type)?$line->product_type:$line->fk_product_type);
4009
+		$type = (!empty($line->product_type) ? $line->product_type : $line->fk_product_type);
4010 4010
 		// Try to enhance type detection using date_start and date_end for free lines where type was not saved.
4011
-		if (! empty($line->date_start)) $type=1; // deprecated
4012
-		if (! empty($line->date_end)) $type=1; // deprecated
4011
+		if (!empty($line->date_start)) $type = 1; // deprecated
4012
+		if (!empty($line->date_end)) $type = 1; // deprecated
4013 4013
 
4014 4014
 		// Ligne en mode visu
4015 4015
 		if ($action != 'editline' || $selected != $line->id)
@@ -4022,14 +4022,14 @@  discard block
 block discarded – undo
4022 4022
 
4023 4023
 				$product_static->ref = $line->ref; //can change ref in hook
4024 4024
 				$product_static->label = $line->label; //can change label in hook
4025
-				$text=$product_static->getNomUrl(1);
4025
+				$text = $product_static->getNomUrl(1);
4026 4026
 
4027 4027
 				// Define output language and label
4028
-				if (! empty($conf->global->MAIN_MULTILANGS))
4028
+				if (!empty($conf->global->MAIN_MULTILANGS))
4029 4029
 				{
4030
-					if (! is_object($this->thirdparty))
4030
+					if (!is_object($this->thirdparty))
4031 4031
 					{
4032
-						dol_print_error('','Error: Method printObjectLine was called on an object and object->fetch_thirdparty was not done before');
4032
+						dol_print_error('', 'Error: Method printObjectLine was called on an object and object->fetch_thirdparty was not done before');
4033 4033
 						return;
4034 4034
 					}
4035 4035
 
@@ -4037,38 +4037,38 @@  discard block
 block discarded – undo
4037 4037
 					$prod->fetch($line->fk_product);
4038 4038
 
4039 4039
 					$outputlangs = $langs;
4040
-					$newlang='';
4041
-					if (empty($newlang) && GETPOST('lang_id','aZ09')) $newlang=GETPOST('lang_id','aZ09');
4042
-					if (! empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang=$this->thirdparty->default_lang;		// For language to language of customer
4043
-					if (! empty($newlang))
4040
+					$newlang = '';
4041
+					if (empty($newlang) && GETPOST('lang_id', 'aZ09')) $newlang = GETPOST('lang_id', 'aZ09');
4042
+					if (!empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang = $this->thirdparty->default_lang; // For language to language of customer
4043
+					if (!empty($newlang))
4044 4044
 					{
4045
-						$outputlangs = new Translate("",$conf);
4045
+						$outputlangs = new Translate("", $conf);
4046 4046
 						$outputlangs->setDefaultLang($newlang);
4047 4047
 					}
4048 4048
 
4049
-					$label = (! empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;
4049
+					$label = (!empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;
4050 4050
 				}
4051 4051
 				else
4052 4052
 				{
4053 4053
 					$label = $line->product_label;
4054 4054
 				}
4055 4055
 
4056
-				$text.= ' - '.(! empty($line->label)?$line->label:$label);
4057
-				$description.=(! empty($conf->global->PRODUIT_DESC_IN_FORM)?'':dol_htmlentitiesbr($line->description));	// Description is what to show on popup. We shown nothing if already into desc.
4056
+				$text .= ' - '.(!empty($line->label) ? $line->label : $label);
4057
+				$description .= (!empty($conf->global->PRODUIT_DESC_IN_FORM) ? '' : dol_htmlentitiesbr($line->description)); // Description is what to show on popup. We shown nothing if already into desc.
4058 4058
 			}
4059 4059
 
4060
-			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');
4060
+			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx / 100)), 'MU');
4061 4061
 
4062 4062
 			// Output template part (modules that overwrite templates must declare this into descriptor)
4063 4063
 			// Use global variables + $dateSelector + $seller and $buyer
4064
-			$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));
4065
-			foreach($dirtpls as $reldir)
4064
+			$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));
4065
+			foreach ($dirtpls as $reldir)
4066 4066
 			{
4067 4067
 				$tpl = dol_buildpath($reldir.'/objectline_view.tpl.php');
4068 4068
 				if (empty($conf->file->strict_mode)) {
4069
-					$res=@include $tpl;
4069
+					$res = @include $tpl;
4070 4070
 				} else {
4071
-					$res=include $tpl; // for debug
4071
+					$res = include $tpl; // for debug
4072 4072
 				}
4073 4073
 				if ($res) break;
4074 4074
 			}
@@ -4077,21 +4077,21 @@  discard block
 block discarded – undo
4077 4077
 		// Ligne en mode update
4078 4078
 		if ($this->statut == 0 && $action == 'editline' && $selected == $line->id)
4079 4079
 		{
4080
-			$label = (! empty($line->label) ? $line->label : (($line->fk_product > 0) ? $line->product_label : ''));
4081
-			$placeholder=' placeholder="'.$langs->trans("Label").'"';
4080
+			$label = (!empty($line->label) ? $line->label : (($line->fk_product > 0) ? $line->product_label : ''));
4081
+			$placeholder = ' placeholder="'.$langs->trans("Label").'"';
4082 4082
 
4083
-			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');
4083
+			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx / 100)), 'MU');
4084 4084
 
4085 4085
 			// Output template part (modules that overwrite templates must declare this into descriptor)
4086 4086
 			// Use global variables + $dateSelector + $seller and $buyer
4087
-			$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));
4088
-			foreach($dirtpls as $reldir)
4087
+			$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));
4088
+			foreach ($dirtpls as $reldir)
4089 4089
 			{
4090 4090
 				$tpl = dol_buildpath($reldir.'/objectline_edit.tpl.php');
4091 4091
 				if (empty($conf->file->strict_mode)) {
4092
-					$res=@include $tpl;
4092
+					$res = @include $tpl;
4093 4093
 				} else {
4094
-					$res=include $tpl; // for debug
4094
+					$res = include $tpl; // for debug
4095 4095
 				}
4096 4096
 				if ($res) break;
4097 4097
 			}
@@ -4111,7 +4111,7 @@  discard block
 block discarded – undo
4111 4111
 	 *	@param	string		$restrictlist		''=All lines, 'services'=Restrict to services only
4112 4112
 	 *  @return	void
4113 4113
 	 */
4114
-	function printOriginLinesList($restrictlist='')
4114
+	function printOriginLinesList($restrictlist = '')
4115 4115
 	{
4116 4116
 		global $langs, $hookmanager, $conf;
4117 4117
 
@@ -4122,26 +4122,26 @@  discard block
 block discarded – undo
4122 4122
 		print '<td align="right">'.$langs->trans('PriceUHT').'</td>';
4123 4123
 		if (!empty($conf->multicurrency->enabled)) print '<td align="right">'.$langs->trans('PriceUHTCurrency').'</td>';
4124 4124
 		print '<td align="right">'.$langs->trans('Qty').'</td>';
4125
-		if($conf->global->PRODUCT_USE_UNITS)
4125
+		if ($conf->global->PRODUCT_USE_UNITS)
4126 4126
 		{
4127 4127
 			print '<td align="left">'.$langs->trans('Unit').'</td>';
4128 4128
 		}
4129 4129
 		print '<td align="right">'.$langs->trans('ReductionShort').'</td></tr>';
4130 4130
 
4131 4131
 		$var = true;
4132
-		$i	 = 0;
4132
+		$i = 0;
4133 4133
 
4134
-		if (! empty($this->lines))
4134
+		if (!empty($this->lines))
4135 4135
 		{
4136 4136
 			foreach ($this->lines as $line)
4137 4137
 			{
4138
-				if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))
4138
+				if (is_object($hookmanager) && (($line->product_type == 9 && !empty($line->special_code)) || !empty($line->fk_parent_line)))
4139 4139
 				{
4140 4140
 					if (empty($line->fk_parent_line))
4141 4141
 					{
4142
-						$parameters=array('line'=>$line,'var'=>$var,'i'=>$i);
4143
-						$action='';
4144
-						$hookmanager->executeHooks('printOriginObjectLine',$parameters,$this,$action);    // Note that $action and $object may have been modified by some hooks
4142
+						$parameters = array('line'=>$line, 'var'=>$var, 'i'=>$i);
4143
+						$action = '';
4144
+						$hookmanager->executeHooks('printOriginObjectLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks
4145 4145
 					}
4146 4146
 				}
4147 4147
 				else
@@ -4165,103 +4165,103 @@  discard block
 block discarded – undo
4165 4165
 	 *	@param	string				$restrictlist		''=All lines, 'services'=Restrict to services only (strike line if not)
4166 4166
 	 * 	@return	void
4167 4167
 	 */
4168
-	function printOriginLine($line, $var, $restrictlist='')
4168
+	function printOriginLine($line, $var, $restrictlist = '')
4169 4169
 	{
4170 4170
 		global $langs, $conf;
4171 4171
 
4172 4172
 		//var_dump($line);
4173 4173
 		if (!empty($line->date_start))
4174 4174
 		{
4175
-			$date_start=$line->date_start;
4175
+			$date_start = $line->date_start;
4176 4176
 		}
4177 4177
 		else
4178 4178
 		{
4179
-			$date_start=$line->date_debut_prevue;
4180
-			if ($line->date_debut_reel) $date_start=$line->date_debut_reel;
4179
+			$date_start = $line->date_debut_prevue;
4180
+			if ($line->date_debut_reel) $date_start = $line->date_debut_reel;
4181 4181
 		}
4182 4182
 		if (!empty($line->date_end))
4183 4183
 		{
4184
-			$date_end=$line->date_end;
4184
+			$date_end = $line->date_end;
4185 4185
 		}
4186 4186
 		else
4187 4187
 		{
4188
-			$date_end=$line->date_fin_prevue;
4189
-			if ($line->date_fin_reel) $date_end=$line->date_fin_reel;
4188
+			$date_end = $line->date_fin_prevue;
4189
+			if ($line->date_fin_reel) $date_end = $line->date_fin_reel;
4190 4190
 		}
4191 4191
 
4192 4192
 		$this->tpl['label'] = '';
4193
-		if (! empty($line->fk_parent_line)) $this->tpl['label'].= img_picto('', 'rightarrow');
4193
+		if (!empty($line->fk_parent_line)) $this->tpl['label'] .= img_picto('', 'rightarrow');
4194 4194
 
4195 4195
 		if (($line->info_bits & 2) == 2)  // TODO Not sure this is used for source object
4196 4196
 		{
4197
-			$discount=new DiscountAbsolute($this->db);
4197
+			$discount = new DiscountAbsolute($this->db);
4198 4198
 			$discount->fk_soc = $this->socid;
4199
-			$this->tpl['label'].= $discount->getNomUrl(0,'discount');
4199
+			$this->tpl['label'] .= $discount->getNomUrl(0, 'discount');
4200 4200
 		}
4201
-		else if (! empty($line->fk_product))
4201
+		else if (!empty($line->fk_product))
4202 4202
 		{
4203 4203
 			$productstatic = new Product($this->db);
4204 4204
 			$productstatic->id = $line->fk_product;
4205 4205
 			$productstatic->ref = $line->ref;
4206 4206
 			$productstatic->type = $line->fk_product_type;
4207
-            if(empty($productstatic->ref)){
4207
+            if (empty($productstatic->ref)) {
4208 4208
 				$line->fetch_product();
4209 4209
 				$productstatic = $line->product;
4210 4210
 			}
4211 4211
 			
4212
-			$this->tpl['label'].= $productstatic->getNomUrl(1);
4213
-			$this->tpl['label'].= ' - '.(! empty($line->label)?$line->label:$line->product_label);
4212
+			$this->tpl['label'] .= $productstatic->getNomUrl(1);
4213
+			$this->tpl['label'] .= ' - '.(!empty($line->label) ? $line->label : $line->product_label);
4214 4214
 			// Dates
4215 4215
 			if ($line->product_type == 1 && ($date_start || $date_end))
4216 4216
 			{
4217
-				$this->tpl['label'].= get_date_range($date_start,$date_end);
4217
+				$this->tpl['label'] .= get_date_range($date_start, $date_end);
4218 4218
 			}
4219 4219
 		}
4220 4220
 		else
4221 4221
 		{
4222
-			$this->tpl['label'].= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''),'service') : img_object($langs->trans(''),'product')));
4222
+			$this->tpl['label'] .= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''), 'service') : img_object($langs->trans(''), 'product')));
4223 4223
 			if (!empty($line->desc)) {
4224
-				$this->tpl['label'].=$line->desc;
4225
-			}else {
4226
-				$this->tpl['label'].= ($line->label ? '&nbsp;'.$line->label : '');
4224
+				$this->tpl['label'] .= $line->desc;
4225
+			} else {
4226
+				$this->tpl['label'] .= ($line->label ? '&nbsp;'.$line->label : '');
4227 4227
 			}
4228 4228
 			
4229 4229
 			// Dates
4230 4230
 			if ($line->product_type == 1 && ($date_start || $date_end))
4231 4231
 			{
4232
-				$this->tpl['label'].= get_date_range($date_start,$date_end);
4232
+				$this->tpl['label'] .= get_date_range($date_start, $date_end);
4233 4233
 			}
4234 4234
 		}
4235 4235
 
4236
-		if (! empty($line->desc))
4236
+		if (!empty($line->desc))
4237 4237
 		{
4238 4238
 			if ($line->desc == '(CREDIT_NOTE)')  // TODO Not sure this is used for source object
4239 4239
 			{
4240
-				$discount=new DiscountAbsolute($this->db);
4240
+				$discount = new DiscountAbsolute($this->db);
4241 4241
 				$discount->fetch($line->fk_remise_except);
4242
-				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote",$discount->getNomUrl(0));
4242
+				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote", $discount->getNomUrl(0));
4243 4243
 			}
4244 4244
 			elseif ($line->desc == '(DEPOSIT)')  // TODO Not sure this is used for source object
4245 4245
 			{
4246
-				$discount=new DiscountAbsolute($this->db);
4246
+				$discount = new DiscountAbsolute($this->db);
4247 4247
 				$discount->fetch($line->fk_remise_except);
4248
-				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit",$discount->getNomUrl(0));
4248
+				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit", $discount->getNomUrl(0));
4249 4249
 			}
4250 4250
 			elseif ($line->desc == '(EXCESS RECEIVED)')
4251 4251
 			{
4252
-				$discount=new DiscountAbsolute($this->db);
4252
+				$discount = new DiscountAbsolute($this->db);
4253 4253
 				$discount->fetch($line->fk_remise_except);
4254
-				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived",$discount->getNomUrl(0));
4254
+				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived", $discount->getNomUrl(0));
4255 4255
 			}
4256 4256
 			elseif ($line->desc == '(EXCESS PAID)')
4257 4257
 			{
4258
-				$discount=new DiscountAbsolute($this->db);
4258
+				$discount = new DiscountAbsolute($this->db);
4259 4259
 				$discount->fetch($line->fk_remise_except);
4260
-				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid",$discount->getNomUrl(0));
4260
+				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid", $discount->getNomUrl(0));
4261 4261
 			}
4262 4262
 			else
4263 4263
 			{
4264
-				$this->tpl['description'] = dol_trunc($line->desc,60);
4264
+				$this->tpl['description'] = dol_trunc($line->desc, 60);
4265 4265
 			}
4266 4266
 		}
4267 4267
 		else
@@ -4272,7 +4272,7 @@  discard block
 block discarded – undo
4272 4272
         // VAT Rate
4273 4273
         $this->tpl['vat_rate'] = vatrate($line->tva_tx, true);
4274 4274
         $this->tpl['vat_rate'] .= (($line->info_bits & 1) == 1) ? '*' : '';
4275
-        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';
4275
+        if (!empty($line->vat_src_code) && !preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'] .= ' ('.$line->vat_src_code.')';
4276 4276
 
4277 4277
 		$this->tpl['price'] = price($line->subprice);
4278 4278
 		$this->tpl['multicurrency_price'] = price($line->multicurrency_subprice);
@@ -4281,19 +4281,19 @@  discard block
 block discarded – undo
4281 4281
 		$this->tpl['remise_percent'] = (($line->info_bits & 2) != 2) ? vatrate($line->remise_percent, true) : '&nbsp;';
4282 4282
 
4283 4283
 		// Is the line strike or not
4284
-		$this->tpl['strike']=0;
4285
-		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike']=1;
4284
+		$this->tpl['strike'] = 0;
4285
+		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike'] = 1;
4286 4286
 
4287 4287
 		// Output template part (modules that overwrite templates must declare this into descriptor)
4288 4288
 		// Use global variables + $dateSelector + $seller and $buyer
4289
-		$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));
4290
-		foreach($dirtpls as $reldir)
4289
+		$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));
4290
+		foreach ($dirtpls as $reldir)
4291 4291
 		{
4292 4292
 			$tpl = dol_buildpath($reldir.'/originproductline.tpl.php');
4293 4293
 			if (empty($conf->file->strict_mode)) {
4294
-				$res=@include $tpl;
4294
+				$res = @include $tpl;
4295 4295
 			} else {
4296
-				$res=include $tpl; // for debug
4296
+				$res = include $tpl; // for debug
4297 4297
 			}
4298 4298
 			if ($res) break;
4299 4299
 		}
@@ -4311,26 +4311,26 @@  discard block
 block discarded – undo
4311 4311
 	 *	@param		int		$mandatory			Mandatory or not
4312 4312
 	 *	@return		int							<=0 if KO, >0 if OK
4313 4313
 	 */
4314
-	function add_element_resource($resource_id, $resource_type, $busy=0, $mandatory=0)
4314
+	function add_element_resource($resource_id, $resource_type, $busy = 0, $mandatory = 0)
4315 4315
 	{
4316 4316
         // phpcs:enable
4317 4317
 		$this->db->begin();
4318 4318
 
4319 4319
 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_resources (";
4320
-		$sql.= "resource_id";
4321
-		$sql.= ", resource_type";
4322
-		$sql.= ", element_id";
4323
-		$sql.= ", element_type";
4324
-		$sql.= ", busy";
4325
-		$sql.= ", mandatory";
4326
-		$sql.= ") VALUES (";
4327
-		$sql.= $resource_id;
4328
-		$sql.= ", '".$this->db->escape($resource_type)."'";
4329
-		$sql.= ", '".$this->db->escape($this->id)."'";
4330
-		$sql.= ", '".$this->db->escape($this->element)."'";
4331
-		$sql.= ", '".$this->db->escape($busy)."'";
4332
-		$sql.= ", '".$this->db->escape($mandatory)."'";
4333
-		$sql.= ")";
4320
+		$sql .= "resource_id";
4321
+		$sql .= ", resource_type";
4322
+		$sql .= ", element_id";
4323
+		$sql .= ", element_type";
4324
+		$sql .= ", busy";
4325
+		$sql .= ", mandatory";
4326
+		$sql .= ") VALUES (";
4327
+		$sql .= $resource_id;
4328
+		$sql .= ", '".$this->db->escape($resource_type)."'";
4329
+		$sql .= ", '".$this->db->escape($this->id)."'";
4330
+		$sql .= ", '".$this->db->escape($this->element)."'";
4331
+		$sql .= ", '".$this->db->escape($busy)."'";
4332
+		$sql .= ", '".$this->db->escape($mandatory)."'";
4333
+		$sql .= ")";
4334 4334
 
4335 4335
 		dol_syslog(get_class($this)."::add_element_resource", LOG_DEBUG);
4336 4336
 		if ($this->db->query($sql))
@@ -4340,7 +4340,7 @@  discard block
 block discarded – undo
4340 4340
 		}
4341 4341
 		else
4342 4342
 		{
4343
-			$this->error=$this->db->lasterror();
4343
+			$this->error = $this->db->lasterror();
4344 4344
 			$this->db->rollback();
4345 4345
 			return  0;
4346 4346
 		}
@@ -4355,7 +4355,7 @@  discard block
 block discarded – undo
4355 4355
 	 *    @param	int		$notrigger		Disable all triggers
4356 4356
 	 *    @return   int						>0 if OK, <0 if KO
4357 4357
 	 */
4358
-	function delete_resource($rowid, $element, $notrigger=0)
4358
+	function delete_resource($rowid, $element, $notrigger = 0)
4359 4359
 	{
4360 4360
         // phpcs:enable
4361 4361
 		global $user;
@@ -4363,22 +4363,22 @@  discard block
 block discarded – undo
4363 4363
 		$this->db->begin();
4364 4364
 
4365 4365
 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_resources";
4366
-		$sql.= " WHERE rowid=".$rowid;
4366
+		$sql .= " WHERE rowid=".$rowid;
4367 4367
 
4368 4368
 		dol_syslog(get_class($this)."::delete_resource", LOG_DEBUG);
4369 4369
 
4370
-		$resql=$this->db->query($sql);
4371
-		if (! $resql)
4370
+		$resql = $this->db->query($sql);
4371
+		if (!$resql)
4372 4372
 		{
4373
-			$this->error=$this->db->lasterror();
4373
+			$this->error = $this->db->lasterror();
4374 4374
 			$this->db->rollback();
4375 4375
 			return -1;
4376 4376
 		}
4377 4377
 		else
4378 4378
 		{
4379
-			if (! $notrigger)
4379
+			if (!$notrigger)
4380 4380
 			{
4381
-				$result=$this->call_trigger(strtoupper($element).'_DELETE_RESOURCE', $user);
4381
+				$result = $this->call_trigger(strtoupper($element).'_DELETE_RESOURCE', $user);
4382 4382
 				if ($result < 0) { $this->db->rollback(); return -1; }
4383 4383
 			}
4384 4384
 			$this->db->commit();
@@ -4397,8 +4397,8 @@  discard block
 block discarded – undo
4397 4397
 		// Force a copy of this->lines, otherwise it will point to same object.
4398 4398
 		if (isset($this->lines) && is_array($this->lines))
4399 4399
 		{
4400
-			$nboflines=count($this->lines);
4401
-			for($i=0; $i < $nboflines; $i++)
4400
+			$nboflines = count($this->lines);
4401
+			for ($i = 0; $i < $nboflines; $i++)
4402 4402
 			{
4403 4403
 				$this->lines[$i] = clone $this->lines[$i];
4404 4404
 			}
@@ -4418,43 +4418,43 @@  discard block
 block discarded – undo
4418 4418
 	 * @return 	int 						>0 if OK, <0 if KO
4419 4419
 	 * @see	addFileIntoDatabaseIndex
4420 4420
 	 */
4421
-	protected function commonGenerateDocument($modelspath, $modele, $outputlangs, $hidedetails, $hidedesc, $hideref, $moreparams=null)
4421
+	protected function commonGenerateDocument($modelspath, $modele, $outputlangs, $hidedetails, $hidedesc, $hideref, $moreparams = null)
4422 4422
 	{
4423 4423
 		global $conf, $langs, $user;
4424 4424
 
4425
-		$srctemplatepath='';
4425
+		$srctemplatepath = '';
4426 4426
 
4427 4427
 		// Increase limit for PDF build
4428
-		$err=error_reporting();
4428
+		$err = error_reporting();
4429 4429
 		error_reporting(0);
4430 4430
 		@set_time_limit(120);
4431 4431
 		error_reporting($err);
4432 4432
 
4433 4433
 		// If selected model is a filename template (then $modele="modelname" or "modelname:filename")
4434
-		$tmp=explode(':',$modele,2);
4435
-		if (! empty($tmp[1]))
4434
+		$tmp = explode(':', $modele, 2);
4435
+		if (!empty($tmp[1]))
4436 4436
 		{
4437
-			$modele=$tmp[0];
4438
-			$srctemplatepath=$tmp[1];
4437
+			$modele = $tmp[0];
4438
+			$srctemplatepath = $tmp[1];
4439 4439
 		}
4440 4440
 
4441 4441
 		// Search template files
4442
-		$file=''; $classname=''; $filefound=0;
4443
-		$dirmodels=array('/');
4444
-		if (is_array($conf->modules_parts['models'])) $dirmodels=array_merge($dirmodels,$conf->modules_parts['models']);
4445
-		foreach($dirmodels as $reldir)
4442
+		$file = ''; $classname = ''; $filefound = 0;
4443
+		$dirmodels = array('/');
4444
+		if (is_array($conf->modules_parts['models'])) $dirmodels = array_merge($dirmodels, $conf->modules_parts['models']);
4445
+		foreach ($dirmodels as $reldir)
4446 4446
 		{
4447
-			foreach(array('doc','pdf') as $prefix)
4447
+			foreach (array('doc', 'pdf') as $prefix)
4448 4448
 			{
4449
-				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php";     // Member module use prefix_module.class.php
4449
+				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php"; // Member module use prefix_module.class.php
4450 4450
 				else $file = $prefix."_".$modele.".modules.php";
4451 4451
 
4452 4452
 				// On verifie l'emplacement du modele
4453
-				$file=dol_buildpath($reldir.$modelspath.$file,0);
4453
+				$file = dol_buildpath($reldir.$modelspath.$file, 0);
4454 4454
 				if (file_exists($file))
4455 4455
 				{
4456
-					$filefound=1;
4457
-					$classname=$prefix.'_'.$modele;
4456
+					$filefound = 1;
4457
+					$classname = $prefix.'_'.$modele;
4458 4458
 					break;
4459 4459
 				}
4460 4460
 			}
@@ -4464,7 +4464,7 @@  discard block
 block discarded – undo
4464 4464
 		// If generator was found
4465 4465
 		if ($filefound)
4466 4466
 		{
4467
-			global $db;  // Required to solve a conception default in commonstickergenerator.class.php making an include of code using $db
4467
+			global $db; // Required to solve a conception default in commonstickergenerator.class.php making an include of code using $db
4468 4468
 
4469 4469
 			require_once $file;
4470 4470
 
@@ -4473,32 +4473,32 @@  discard block
 block discarded – undo
4473 4473
 			// If generator is ODT, we must have srctemplatepath defined, if not we set it.
4474 4474
 			if ($obj->type == 'odt' && empty($srctemplatepath))
4475 4475
 			{
4476
-				$varfortemplatedir=$obj->scandir;
4477
-				if ($varfortemplatedir && ! empty($conf->global->$varfortemplatedir))
4476
+				$varfortemplatedir = $obj->scandir;
4477
+				if ($varfortemplatedir && !empty($conf->global->$varfortemplatedir))
4478 4478
 				{
4479
-					$dirtoscan=$conf->global->$varfortemplatedir;
4479
+					$dirtoscan = $conf->global->$varfortemplatedir;
4480 4480
 
4481
-					$listoffiles=array();
4481
+					$listoffiles = array();
4482 4482
 
4483 4483
 					// Now we add first model found in directories scanned
4484
-					$listofdir=explode(',',$dirtoscan);
4485
-					foreach($listofdir as $key => $tmpdir)
4484
+					$listofdir = explode(',', $dirtoscan);
4485
+					foreach ($listofdir as $key => $tmpdir)
4486 4486
 					{
4487
-						$tmpdir=trim($tmpdir);
4488
-						$tmpdir=preg_replace('/DOL_DATA_ROOT/',DOL_DATA_ROOT,$tmpdir);
4489
-						if (! $tmpdir) { unset($listofdir[$key]); continue; }
4487
+						$tmpdir = trim($tmpdir);
4488
+						$tmpdir = preg_replace('/DOL_DATA_ROOT/', DOL_DATA_ROOT, $tmpdir);
4489
+						if (!$tmpdir) { unset($listofdir[$key]); continue; }
4490 4490
 						if (is_dir($tmpdir))
4491 4491
 						{
4492
-							$tmpfiles=dol_dir_list($tmpdir,'files',0,'\.od(s|t)$','','name',SORT_ASC,0);
4493
-							if (count($tmpfiles)) $listoffiles=array_merge($listoffiles,$tmpfiles);
4492
+							$tmpfiles = dol_dir_list($tmpdir, 'files', 0, '\.od(s|t)$', '', 'name', SORT_ASC, 0);
4493
+							if (count($tmpfiles)) $listoffiles = array_merge($listoffiles, $tmpfiles);
4494 4494
 						}
4495 4495
 					}
4496 4496
 
4497 4497
 					if (count($listoffiles))
4498 4498
 					{
4499
-						foreach($listoffiles as $record)
4499
+						foreach ($listoffiles as $record)
4500 4500
 						{
4501
-							$srctemplatepath=$record['fullname'];
4501
+							$srctemplatepath = $record['fullname'];
4502 4502
 							break;
4503 4503
 						}
4504 4504
 					}
@@ -4506,27 +4506,27 @@  discard block
 block discarded – undo
4506 4506
 
4507 4507
 				if (empty($srctemplatepath))
4508 4508
 				{
4509
-					$this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotDefined';
4509
+					$this->error = 'ErrorGenerationAskedForOdtTemplateWithSrcFileNotDefined';
4510 4510
 					return -1;
4511 4511
 				}
4512 4512
 			}
4513 4513
 
4514
-			if ($obj->type == 'odt' && ! empty($srctemplatepath))
4514
+			if ($obj->type == 'odt' && !empty($srctemplatepath))
4515 4515
 			{
4516
-				if (! dol_is_file($srctemplatepath))
4516
+				if (!dol_is_file($srctemplatepath))
4517 4517
 				{
4518
-					$this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotFound';
4518
+					$this->error = 'ErrorGenerationAskedForOdtTemplateWithSrcFileNotFound';
4519 4519
 					return -1;
4520 4520
 				}
4521 4521
 			}
4522 4522
 
4523 4523
 			// We save charset_output to restore it because write_file can change it if needed for
4524 4524
 			// output format that does not support UTF8.
4525
-			$sav_charset_output=$outputlangs->charset_output;
4525
+			$sav_charset_output = $outputlangs->charset_output;
4526 4526
 
4527 4527
 			if (in_array(get_class($this), array('Adherent')))
4528 4528
 			{
4529
-				$arrayofrecords = array();   // The write_file of templates of adherent class need this var
4529
+				$arrayofrecords = array(); // The write_file of templates of adherent class need this var
4530 4530
 				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, 'member', 1, $moreparams);
4531 4531
 			}
4532 4532
 			else
@@ -4537,41 +4537,41 @@  discard block
 block discarded – undo
4537 4537
 
4538 4538
 			if ($resultwritefile > 0)
4539 4539
 			{
4540
-				$outputlangs->charset_output=$sav_charset_output;
4540
+				$outputlangs->charset_output = $sav_charset_output;
4541 4541
 
4542 4542
 				// We delete old preview
4543 4543
 				require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
4544 4544
 				dol_delete_preview($this);
4545 4545
 
4546 4546
 				// Index file in database
4547
-				if (! empty($obj->result['fullpath']))
4547
+				if (!empty($obj->result['fullpath']))
4548 4548
 				{
4549 4549
 					$destfull = $obj->result['fullpath'];
4550 4550
 					$upload_dir = dirname($destfull);
4551 4551
 					$destfile = basename($destfull);
4552
-					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $upload_dir);
4552
+					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT, '/').'/', '', $upload_dir);
4553 4553
 
4554
-					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir
4554
+					if (!preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir
4555 4555
 					{
4556 4556
 						$filename = basename($destfile);
4557 4557
 						$rel_dir = preg_replace('/[\\/]$/', '', $rel_dir);
4558 4558
 						$rel_dir = preg_replace('/^[\\/]/', '', $rel_dir);
4559 4559
 
4560 4560
 						include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';
4561
-						$ecmfile=new EcmFiles($this->db);
4562
-						$result = $ecmfile->fetch(0, '', ($rel_dir?$rel_dir.'/':'').$filename);
4561
+						$ecmfile = new EcmFiles($this->db);
4562
+						$result = $ecmfile->fetch(0, '', ($rel_dir ? $rel_dir.'/' : '').$filename);
4563 4563
 
4564 4564
 						// Set the public "share" key
4565 4565
 						$setsharekey = false;
4566 4566
 						if ($this->element == 'propal')
4567 4567
 						{
4568
-							$useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL;	// Replace this with 1 when feature to make online signature is ok
4569
-							if ($useonlinesignature) $setsharekey=true;
4570
-							if (! empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;
4568
+							$useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL; // Replace this with 1 when feature to make online signature is ok
4569
+							if ($useonlinesignature) $setsharekey = true;
4570
+							if (!empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey = true;
4571 4571
 						}
4572
-						if ($this->element == 'commande'     && ! empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey=true;
4573
-						if ($this->element == 'facture'      && ! empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey=true;
4574
-						if ($this->element == 'bank_account' && ! empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;
4572
+						if ($this->element == 'commande' && !empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey = true;
4573
+						if ($this->element == 'facture' && !empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey = true;
4574
+						if ($this->element == 'bank_account' && !empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey = true;
4575 4575
 
4576 4576
 						if ($setsharekey)
4577 4577
 						{
@@ -4584,11 +4584,11 @@  discard block
 block discarded – undo
4584 4584
 
4585 4585
 						if ($result > 0)
4586 4586
 						{
4587
-							$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content
4587
+							$ecmfile->label = md5_file(dol_osencode($destfull)); // hash of file content
4588 4588
 							$ecmfile->fullpath_orig = '';
4589 4589
 							$ecmfile->gen_or_uploaded = 'generated';
4590
-							$ecmfile->description = '';    // indexed content
4591
-							$ecmfile->keyword = '';        // keyword content
4590
+							$ecmfile->description = ''; // indexed content
4591
+							$ecmfile->keyword = ''; // keyword content
4592 4592
 							$result = $ecmfile->update($user);
4593 4593
 							if ($result < 0)
4594 4594
 							{
@@ -4600,11 +4600,11 @@  discard block
 block discarded – undo
4600 4600
 							$ecmfile->entity = $conf->entity;
4601 4601
 							$ecmfile->filepath = $rel_dir;
4602 4602
 							$ecmfile->filename = $filename;
4603
-							$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content
4603
+							$ecmfile->label = md5_file(dol_osencode($destfull)); // hash of file content
4604 4604
 							$ecmfile->fullpath_orig = '';
4605 4605
 							$ecmfile->gen_or_uploaded = 'generated';
4606
-							$ecmfile->description = '';    // indexed content
4607
-							$ecmfile->keyword = '';        // keyword content
4606
+							$ecmfile->description = ''; // indexed content
4607
+							$ecmfile->keyword = ''; // keyword content
4608 4608
 							$ecmfile->src_object_type = $this->table_element;
4609 4609
 							$ecmfile->src_object_id   = $this->id;
4610 4610
 
@@ -4621,14 +4621,14 @@  discard block
 block discarded – undo
4621 4621
 						//var_dump($obj->update_main_doc_field);exit;
4622 4622
 
4623 4623
 						// Update the last_main_doc field into main object (if documenent generator has property ->update_main_doc_field set)
4624
-						$update_main_doc_field=0;
4625
-						if (! empty($obj->update_main_doc_field)) $update_main_doc_field=1;
4626
-						if ($update_main_doc_field && ! empty($this->table_element))
4624
+						$update_main_doc_field = 0;
4625
+						if (!empty($obj->update_main_doc_field)) $update_main_doc_field = 1;
4626
+						if ($update_main_doc_field && !empty($this->table_element))
4627 4627
 						{
4628 4628
 							$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element." SET last_main_doc = '".($ecmfile->filepath.'/'.$ecmfile->filename)."'";
4629
-							$sql.= ' WHERE rowid = '.$this->id;
4629
+							$sql .= ' WHERE rowid = '.$this->id;
4630 4630
 							$resql = $this->db->query($sql);
4631
-							if (! $resql) dol_print_error($this->db);
4631
+							if (!$resql) dol_print_error($this->db);
4632 4632
 						}
4633 4633
 					}
4634 4634
 				}
@@ -4644,15 +4644,15 @@  discard block
 block discarded – undo
4644 4644
 			}
4645 4645
 			else
4646 4646
 			{
4647
-				$outputlangs->charset_output=$sav_charset_output;
4647
+				$outputlangs->charset_output = $sav_charset_output;
4648 4648
 				dol_print_error($this->db, "Error generating document for ".__CLASS__.". Error: ".$obj->error, $obj->errors);
4649 4649
 				return -1;
4650 4650
 			}
4651 4651
 		}
4652 4652
 		else
4653 4653
 		{
4654
-			$this->error=$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);
4655
-			dol_print_error('',$this->error);
4654
+			$this->error = $langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists", $file);
4655
+			dol_print_error('', $this->error);
4656 4656
 			return -1;
4657 4657
 		}
4658 4658
 	}
@@ -4668,9 +4668,9 @@  discard block
 block discarded – undo
4668 4668
 	{
4669 4669
 		global $maxwidthsmall, $maxheightsmall, $maxwidthmini, $maxheightmini, $quality;
4670 4670
 
4671
-		require_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';		// This define also $maxwidthsmall, $quality, ...
4671
+		require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php'; // This define also $maxwidthsmall, $quality, ...
4672 4672
 
4673
-		$file_osencoded=dol_osencode($file);
4673
+		$file_osencoded = dol_osencode($file);
4674 4674
 		if (file_exists($file_osencoded))
4675 4675
 		{
4676 4676
 			// Create small thumbs for company (Ratio is near 16/9)
@@ -4700,7 +4700,7 @@  discard block
 block discarded – undo
4700 4700
 	 * @param   string              $alternatevalue     Alternate value to use
4701 4701
 	 * @return  string|string[]                         Default value (can be an array if the GETPOST return an array)
4702 4702
 	 **/
4703
-	function getDefaultCreateValueFor($fieldname, $alternatevalue=null)
4703
+	function getDefaultCreateValueFor($fieldname, $alternatevalue = null)
4704 4704
 	{
4705 4705
 		global $conf, $_POST;
4706 4706
 
@@ -4709,16 +4709,16 @@  discard block
 block discarded – undo
4709 4709
 
4710 4710
 		if (isset($alternatevalue)) return $alternatevalue;
4711 4711
 
4712
-		$newelement=$this->element;
4713
-		if ($newelement == 'facture') $newelement='invoice';
4714
-		if ($newelement == 'commande') $newelement='order';
4712
+		$newelement = $this->element;
4713
+		if ($newelement == 'facture') $newelement = 'invoice';
4714
+		if ($newelement == 'commande') $newelement = 'order';
4715 4715
 		if (empty($newelement))
4716 4716
 		{
4717 4717
 			dol_syslog("Ask a default value using common method getDefaultCreateValueForField on an object with no property ->element defined. Return empty string.", LOG_WARNING);
4718 4718
 			return '';
4719 4719
 		}
4720 4720
 
4721
-		$keyforfieldname=strtoupper($newelement.'_DEFAULT_'.$fieldname);
4721
+		$keyforfieldname = strtoupper($newelement.'_DEFAULT_'.$fieldname);
4722 4722
 		//var_dump($keyforfieldname);
4723 4723
 		if (isset($conf->global->$keyforfieldname)) return $conf->global->$keyforfieldname;
4724 4724
 
@@ -4743,21 +4743,21 @@  discard block
 block discarded – undo
4743 4743
 	function call_trigger($trigger_name, $user)
4744 4744
 	{
4745 4745
         // phpcs:enable
4746
-		global $langs,$conf;
4746
+		global $langs, $conf;
4747 4747
 
4748
-		include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';
4749
-		$interface=new Interfaces($this->db);
4750
-		$result=$interface->run_triggers($trigger_name,$this,$user,$langs,$conf);
4748
+		include_once DOL_DOCUMENT_ROOT.'/core/class/interfaces.class.php';
4749
+		$interface = new Interfaces($this->db);
4750
+		$result = $interface->run_triggers($trigger_name, $this, $user, $langs, $conf);
4751 4751
 
4752 4752
 		if ($result < 0)
4753 4753
 		{
4754 4754
 			if (!empty($this->errors))
4755 4755
 			{
4756
-				$this->errors=array_unique(array_merge($this->errors,$interface->errors));   // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.
4756
+				$this->errors = array_unique(array_merge($this->errors, $interface->errors)); // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.
4757 4757
 			}
4758 4758
 			else
4759 4759
 			{
4760
-				$this->errors=$interface->errors;
4760
+				$this->errors = $interface->errors;
4761 4761
 			}
4762 4762
 		}
4763 4763
 		return $result;
@@ -4776,19 +4776,19 @@  discard block
 block discarded – undo
4776 4776
 	 *  @param  array	$optionsArray   Array resulting of call of extrafields->fetch_name_optionals_label(). Deprecated. Function must be called without parameters.
4777 4777
 	 *  @return	int						<0 if error, 0 if no values of extrafield to find nor found, 1 if an attribute is found and value loaded
4778 4778
 	 */
4779
-	function fetch_optionals($rowid=null, $optionsArray=null)
4779
+	function fetch_optionals($rowid = null, $optionsArray = null)
4780 4780
 	{
4781 4781
         // phpcs:enable
4782
-		if (empty($rowid)) $rowid=$this->id;
4782
+		if (empty($rowid)) $rowid = $this->id;
4783 4783
 
4784 4784
 		// To avoid SQL errors. Probably not the better solution though
4785 4785
 		if (!$this->table_element) {
4786 4786
 			return 0;
4787 4787
 		}
4788 4788
 
4789
-		$this->array_options=array();
4789
+		$this->array_options = array();
4790 4790
 
4791
-		if (! is_array($optionsArray))
4791
+		if (!is_array($optionsArray))
4792 4792
 		{
4793 4793
 			// If $extrafields is not a known object, we initialize it. Best practice is to have $extrafields defined into card.php or list.php page.
4794 4794
 			// TODO Use of existing $extrafield is not yet ready (must mutualize code that use extrafields in form first)
@@ -4804,7 +4804,7 @@  discard block
 block discarded – undo
4804 4804
 			{
4805 4805
 				$extrafields->fetch_name_optionals_label($this->table_element);
4806 4806
 			}
4807
-			$optionsArray = (! empty($extrafields->attributes[$this->table_element]['label'])?$extrafields->attributes[$this->table_element]['label']:null);
4807
+			$optionsArray = (!empty($extrafields->attributes[$this->table_element]['label']) ? $extrafields->attributes[$this->table_element]['label'] : null);
4808 4808
 		}
4809 4809
 		else
4810 4810
 		{
@@ -4823,18 +4823,18 @@  discard block
 block discarded – undo
4823 4823
 			{
4824 4824
 				if (empty($extrafields->attributes[$this->table_element]['type'][$name]) || $extrafields->attributes[$this->table_element]['type'][$name] != 'separate')
4825 4825
 				{
4826
-					$sql.= ", ".$name;
4826
+					$sql .= ", ".$name;
4827 4827
 				}
4828 4828
 			}
4829
-			$sql.= " FROM ".MAIN_DB_PREFIX.$table_element."_extrafields";
4830
-			$sql.= " WHERE fk_object = ".$rowid;
4829
+			$sql .= " FROM ".MAIN_DB_PREFIX.$table_element."_extrafields";
4830
+			$sql .= " WHERE fk_object = ".$rowid;
4831 4831
 
4832 4832
 			//dol_syslog(get_class($this)."::fetch_optionals get extrafields data for ".$this->table_element, LOG_DEBUG);		// Too verbose
4833
-			$resql=$this->db->query($sql);
4833
+			$resql = $this->db->query($sql);
4834 4834
 			if ($resql)
4835 4835
 			{
4836 4836
 				$this->array_options = array();
4837
-				$numrows=$this->db->num_rows($resql);
4837
+				$numrows = $this->db->num_rows($resql);
4838 4838
 				if ($numrows)
4839 4839
 				{
4840 4840
 					$tab = $this->db->fetch_array($resql);
@@ -4842,17 +4842,17 @@  discard block
 block discarded – undo
4842 4842
 					foreach ($tab as $key => $value)
4843 4843
 					{
4844 4844
 						// Test fetch_array ! is_int($key) because fetch_array result is a mix table with Key as alpha and Key as int (depend db engine)
4845
-						if ($key != 'rowid' && $key != 'tms' && $key != 'fk_member' && ! is_int($key))
4845
+						if ($key != 'rowid' && $key != 'tms' && $key != 'fk_member' && !is_int($key))
4846 4846
 						{
4847 4847
 							// we can add this attribute to object
4848
-							if (! empty($extrafields) && in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date','datetime')))
4848
+							if (!empty($extrafields) && in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date', 'datetime')))
4849 4849
 							{
4850 4850
 								//var_dump($extrafields->attributes[$this->table_element]['type'][$key]);
4851
-								$this->array_options["options_".$key]=$this->db->jdate($value);
4851
+								$this->array_options["options_".$key] = $this->db->jdate($value);
4852 4852
 							}
4853 4853
 							else
4854 4854
 							{
4855
-								$this->array_options["options_".$key]=$value;
4855
+								$this->array_options["options_".$key] = $value;
4856 4856
 							}
4857 4857
 
4858 4858
 							//var_dump('key '.$key.' '.$value.' type='.$extrafields->attributes[$this->table_element]['type'][$key].' '.$this->array_options["options_".$key]);
@@ -4888,10 +4888,10 @@  discard block
 block discarded – undo
4888 4888
 
4889 4889
 		$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;
4890 4890
 		dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);
4891
-		$resql=$this->db->query($sql_del);
4892
-		if (! $resql)
4891
+		$resql = $this->db->query($sql_del);
4892
+		if (!$resql)
4893 4893
 		{
4894
-			$this->error=$this->db->lasterror();
4894
+			$this->error = $this->db->lasterror();
4895 4895
 			$this->db->rollback();
4896 4896
 			return -1;
4897 4897
 		}
@@ -4912,36 +4912,36 @@  discard block
 block discarded – undo
4912 4912
 	 *  @return int 						-1=error, O=did nothing, 1=OK
4913 4913
 	 *  @see updateExtraField, setValueFrom
4914 4914
 	 */
4915
-	function insertExtraFields($trigger='', $userused=null)
4915
+	function insertExtraFields($trigger = '', $userused = null)
4916 4916
 	{
4917
-		global $conf,$langs,$user;
4917
+		global $conf, $langs, $user;
4918 4918
 
4919
-		if (empty($userused)) $userused=$user;
4919
+		if (empty($userused)) $userused = $user;
4920 4920
 
4921
-		$error=0;
4921
+		$error = 0;
4922 4922
 
4923
-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used
4923
+		if (!empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0; // For avoid conflicts if trigger used
4924 4924
 
4925
-		if (! empty($this->array_options))
4925
+		if (!empty($this->array_options))
4926 4926
 		{
4927 4927
 			// Check parameters
4928 4928
 			$langs->load('admin');
4929 4929
 			require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';
4930 4930
 			$extrafields = new ExtraFields($this->db);
4931
-			$target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);
4931
+			$target_extrafields = $extrafields->fetch_name_optionals_label($this->table_element);
4932 4932
 
4933 4933
 			//Eliminate copied source object extra_fields that do not exist in target object
4934
-			$new_array_options=array();
4934
+			$new_array_options = array();
4935 4935
 			foreach ($this->array_options as $key => $value) {
4936
-				if (in_array(substr($key,8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test
4936
+				if (in_array(substr($key, 8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test
4937 4937
 					$new_array_options[$key] = $value;
4938 4938
 				elseif (in_array($key, array_keys($target_extrafields)))		// We test on $key that does not contains the 'options_' prefix
4939 4939
 					$new_array_options['options_'.$key] = $value;
4940 4940
 			}
4941 4941
 
4942
-			foreach($new_array_options as $key => $value)
4942
+			foreach ($new_array_options as $key => $value)
4943 4943
 			{
4944
-			   	$attributeKey      = substr($key,8);   // Remove 'options_' prefix
4944
+			   	$attributeKey      = substr($key, 8); // Remove 'options_' prefix
4945 4945
 			   	$attributeType     = $extrafields->attributes[$this->table_element]['type'][$attributeKey];
4946 4946
 			   	$attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$attributeKey];
4947 4947
 			   	$attributeParam    = $extrafields->attributes[$this->table_element]['param'][$attributeKey];
@@ -4949,13 +4949,13 @@  discard block
 block discarded – undo
4949 4949
 
4950 4950
 			   	if ($attributeRequired)
4951 4951
 			   	{
4952
-			   		$mandatorypb=false;
4953
-			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb=true;
4954
-			   		if ($this->array_options[$key] === '') $mandatorypb=true;
4952
+			   		$mandatorypb = false;
4953
+			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb = true;
4954
+			   		if ($this->array_options[$key] === '') $mandatorypb = true;
4955 4955
 			   		if ($mandatorypb)
4956 4956
 			   		{
4957 4957
 			   			dol_syslog($this->error);
4958
-			   			$this->errors[]=$langs->trans('ErrorFieldRequired', $attributeLabel);
4958
+			   			$this->errors[] = $langs->trans('ErrorFieldRequired', $attributeLabel);
4959 4959
 			   			return -1;
4960 4960
 			   		}
4961 4961
 			   	}
@@ -4966,25 +4966,25 @@  discard block
 block discarded – undo
4966 4966
 			   	switch ($attributeType)
4967 4967
 			   	{
4968 4968
 			   		case 'int':
4969
-			  			if (!is_numeric($value) && $value!='')
4969
+			  			if (!is_numeric($value) && $value != '')
4970 4970
 			   			{
4971
-			   				$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
4971
+			   				$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
4972 4972
 			   				return -1;
4973 4973
 			  			}
4974
-			   			elseif ($value=='')
4974
+			   			elseif ($value == '')
4975 4975
 			   			{
4976 4976
 			   				$new_array_options[$key] = null;
4977 4977
 			   			}
4978 4978
 			 			break;
4979 4979
 					case 'double':
4980 4980
 						$value = price2num($value);
4981
-						if (!is_numeric($value) && $value!='')
4981
+						if (!is_numeric($value) && $value != '')
4982 4982
 						{
4983 4983
 							dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);
4984
-							$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
4984
+							$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
4985 4985
 							return -1;
4986 4986
 						}
4987
-						elseif ($value=='')
4987
+						elseif ($value == '')
4988 4988
 						{
4989 4989
 							$new_array_options[$key] = null;
4990 4990
 						}
@@ -4998,12 +4998,12 @@  discard block
 block discarded – undo
4998 4998
              			}
4999 4999
              			break;*/
5000 5000
 			   		case 'password':
5001
-			   			$algo='';
5001
+			   			$algo = '';
5002 5002
 			   			if ($this->array_options[$key] != '' && is_array($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']))
5003 5003
 			   			{
5004 5004
 			   				// If there is an encryption choice, we use it to crypt data before insert
5005 5005
 			   				$tmparrays = array_keys($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']);
5006
-			   				$algo=reset($tmparrays);
5006
+			   				$algo = reset($tmparrays);
5007 5007
 			   				if ($algo != '')
5008 5008
 			   				{
5009 5009
 			   					//global $action;		// $action may be 'create', 'update', 'update_extras'...
@@ -5014,7 +5014,7 @@  discard block
 block discarded – undo
5014 5014
 			   						//var_dump($this->oldcopy->array_options[$key]); var_dump($this->array_options[$key]);
5015 5015
 				   					if ($this->array_options[$key] == $this->oldcopy->array_options[$key])	// If old value crypted in database is same than submited new value, it means we don't change it, so we don't update.
5016 5016
 				   					{
5017
-				   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept
5017
+				   						$new_array_options[$key] = $this->array_options[$key]; // Value is kept
5018 5018
 				   					}
5019 5019
 									else
5020 5020
 									{
@@ -5025,7 +5025,7 @@  discard block
 block discarded – undo
5025 5025
 			   					}
5026 5026
 			   					else
5027 5027
 			   					{
5028
-			   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept
5028
+			   						$new_array_options[$key] = $this->array_options[$key]; // Value is kept
5029 5029
 			   					}
5030 5030
 			   				}
5031 5031
 			   			}
@@ -5042,13 +5042,13 @@  discard block
 block discarded – undo
5042 5042
 						break;
5043 5043
 					case 'datetime':
5044 5044
 						// If data is a string instead of a timestamp, we convert it
5045
-						if (! is_int($this->array_options[$key])) {
5045
+						if (!is_int($this->array_options[$key])) {
5046 5046
 							$this->array_options[$key] = strtotime($this->array_options[$key]);
5047 5047
 						}
5048 5048
 						$new_array_options[$key] = $this->db->idate($this->array_options[$key]);
5049 5049
 						break;
5050 5050
 		   			case 'link':
5051
-						$param_list=array_keys($attributeParam['options']);
5051
+						$param_list = array_keys($attributeParam['options']);
5052 5052
 						// 0 : ObjectName
5053 5053
 						// 1 : classPath
5054 5054
 						$InfoFieldList = explode(":", $param_list[0]);
@@ -5057,18 +5057,18 @@  discard block
 block discarded – undo
5057 5057
 						{
5058 5058
 							if ($value == '-1')	// -1 is key for no defined in combo list of objects
5059 5059
 							{
5060
-								$new_array_options[$key]='';
5060
+								$new_array_options[$key] = '';
5061 5061
 							}
5062 5062
 							elseif ($value)
5063 5063
 							{
5064 5064
 								$object = new $InfoFieldList[0]($this->db);
5065
-								if (is_numeric($value)) $res=$object->fetch($value);
5066
-								else $res=$object->fetch('',$value);
5065
+								if (is_numeric($value)) $res = $object->fetch($value);
5066
+								else $res = $object->fetch('', $value);
5067 5067
 
5068
-								if ($res > 0) $new_array_options[$key]=$object->id;
5068
+								if ($res > 0) $new_array_options[$key] = $object->id;
5069 5069
 								else
5070 5070
 								{
5071
-									$this->error="Id/Ref '".$value."' for object '".$object->element."' not found";
5071
+									$this->error = "Id/Ref '".$value."' for object '".$object->element."' not found";
5072 5072
 									$this->db->rollback();
5073 5073
 									return -1;
5074 5074
 								}
@@ -5092,46 +5092,46 @@  discard block
 block discarded – undo
5092 5092
 			$this->db->query($sql_del);
5093 5093
 
5094 5094
 			$sql = "INSERT INTO ".MAIN_DB_PREFIX.$table_element."_extrafields (fk_object";
5095
-			foreach($new_array_options as $key => $value)
5095
+			foreach ($new_array_options as $key => $value)
5096 5096
 			{
5097
-				$attributeKey = substr($key,8);   // Remove 'options_' prefix
5097
+				$attributeKey = substr($key, 8); // Remove 'options_' prefix
5098 5098
 				// Add field of attribut
5099 5099
 				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator
5100
-					$sql.=",".$attributeKey;
5100
+					$sql .= ",".$attributeKey;
5101 5101
 			}
5102 5102
 			$sql .= ") VALUES (".$this->id;
5103 5103
 
5104
-			foreach($new_array_options as $key => $value)
5104
+			foreach ($new_array_options as $key => $value)
5105 5105
 			{
5106
-				$attributeKey = substr($key,8);   // Remove 'options_' prefix
5106
+				$attributeKey = substr($key, 8); // Remove 'options_' prefix
5107 5107
 				// Add field of attribute
5108 5108
 				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator)
5109 5109
 				{
5110 5110
 					if ($new_array_options[$key] != '')
5111 5111
 					{
5112
-						$sql.=",'".$this->db->escape($new_array_options[$key])."'";
5112
+						$sql .= ",'".$this->db->escape($new_array_options[$key])."'";
5113 5113
 					}
5114 5114
 					else
5115 5115
 					{
5116
-						$sql.=",null";
5116
+						$sql .= ",null";
5117 5117
 					}
5118 5118
 				}
5119 5119
 			}
5120
-			$sql.=")";
5120
+			$sql .= ")";
5121 5121
 
5122 5122
 			dol_syslog(get_class($this)."::insertExtraFields insert", LOG_DEBUG);
5123 5123
 			$resql = $this->db->query($sql);
5124
-			if (! $resql)
5124
+			if (!$resql)
5125 5125
 			{
5126
-				$this->error=$this->db->lasterror();
5126
+				$this->error = $this->db->lasterror();
5127 5127
 				$error++;
5128 5128
 			}
5129 5129
 
5130
-			if (! $error && $trigger)
5130
+			if (!$error && $trigger)
5131 5131
 			{
5132 5132
 				// Call trigger
5133
-				$this->context=array('extrafieldaddupdate'=>1);
5134
-				$result=$this->call_trigger($trigger, $userused);
5133
+				$this->context = array('extrafieldaddupdate'=>1);
5134
+				$result = $this->call_trigger($trigger, $userused);
5135 5135
 				if ($result < 0) $error++;
5136 5136
 				// End call trigger
5137 5137
 			}
@@ -5160,25 +5160,25 @@  discard block
 block discarded – undo
5160 5160
 	 *  @return int                 		-1=error, O=did nothing, 1=OK
5161 5161
 	 *  @see setValueFrom, insertExtraFields
5162 5162
 	 */
5163
-	function updateExtraField($key, $trigger=null, $userused=null)
5163
+	function updateExtraField($key, $trigger = null, $userused = null)
5164 5164
 	{
5165
-		global $conf,$langs,$user;
5165
+		global $conf, $langs, $user;
5166 5166
 
5167
-		if (empty($userused)) $userused=$user;
5167
+		if (empty($userused)) $userused = $user;
5168 5168
 
5169
-		$error=0;
5169
+		$error = 0;
5170 5170
 
5171
-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used
5171
+		if (!empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0; // For avoid conflicts if trigger used
5172 5172
 
5173
-		if (! empty($this->array_options) && isset($this->array_options["options_".$key]))
5173
+		if (!empty($this->array_options) && isset($this->array_options["options_".$key]))
5174 5174
 		{
5175 5175
 			// Check parameters
5176 5176
 			$langs->load('admin');
5177 5177
 			require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';
5178 5178
 			$extrafields = new ExtraFields($this->db);
5179
-			$target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);
5179
+			$target_extrafields = $extrafields->fetch_name_optionals_label($this->table_element);
5180 5180
 
5181
-			$value=$this->array_options["options_".$key];
5181
+			$value = $this->array_options["options_".$key];
5182 5182
 
5183 5183
 			$attributeType     = $extrafields->attributes[$this->table_element]['type'][$key];
5184 5184
 			$attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$key];
@@ -5191,25 +5191,25 @@  discard block
 block discarded – undo
5191 5191
 			switch ($attributeType)
5192 5192
 			{
5193 5193
 				case 'int':
5194
-					if (!is_numeric($value) && $value!='')
5194
+					if (!is_numeric($value) && $value != '')
5195 5195
 					{
5196
-						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue",$attributeLabel);
5196
+						$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
5197 5197
 						return -1;
5198 5198
 					}
5199
-					elseif ($value=='')
5199
+					elseif ($value == '')
5200 5200
 					{
5201 5201
 						$this->array_options["options_".$key] = null;
5202 5202
 					}
5203 5203
 					break;
5204 5204
 				case 'double':
5205 5205
 					$value = price2num($value);
5206
-					if (!is_numeric($value) && $value!='')
5206
+					if (!is_numeric($value) && $value != '')
5207 5207
 					{
5208 5208
 						dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);
5209
-						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
5209
+						$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);
5210 5210
 						return -1;
5211 5211
 					}
5212
-					elseif ($value=='')
5212
+					elseif ($value == '')
5213 5213
 					{
5214 5214
 						$this->array_options["options_".$key] = null;
5215 5215
 					}
@@ -5226,13 +5226,13 @@  discard block
 block discarded – undo
5226 5226
 					$this->array_options["options_".$key] = price2num($this->array_options["options_".$key]);
5227 5227
 					break;
5228 5228
 				case 'date':
5229
-					$this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);
5229
+					$this->array_options["options_".$key] = $this->db->idate($this->array_options["options_".$key]);
5230 5230
 					break;
5231 5231
 				case 'datetime':
5232
-					$this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);
5232
+					$this->array_options["options_".$key] = $this->db->idate($this->array_options["options_".$key]);
5233 5233
 					break;
5234 5234
 				case 'link':
5235
-					$param_list=array_keys($attributeParam['options']);
5235
+					$param_list = array_keys($attributeParam['options']);
5236 5236
 					// 0 : ObjectName
5237 5237
 					// 1 : classPath
5238 5238
 					$InfoFieldList = explode(":", $param_list[0]);
@@ -5240,8 +5240,8 @@  discard block
 block discarded – undo
5240 5240
 					if ($value)
5241 5241
 					{
5242 5242
 						$object = new $InfoFieldList[0]($this->db);
5243
-						$object->fetch(0,$value);
5244
-						$this->array_options["options_".$key]=$object->id;
5243
+						$object->fetch(0, $value);
5244
+						$this->array_options["options_".$key] = $object->id;
5245 5245
 					}
5246 5246
 					break;
5247 5247
 			}
@@ -5250,24 +5250,24 @@  discard block
 block discarded – undo
5250 5250
 			$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element."_extrafields SET ".$key."='".$this->db->escape($this->array_options["options_".$key])."'";
5251 5251
 			$sql .= " WHERE fk_object = ".$this->id;
5252 5252
 			$resql = $this->db->query($sql);
5253
-			if (! $resql)
5253
+			if (!$resql)
5254 5254
 			{
5255 5255
 				$error++;
5256
-				$this->error=$this->db->lasterror();
5256
+				$this->error = $this->db->lasterror();
5257 5257
 			}
5258 5258
 
5259
-			if (! $error && $trigger)
5259
+			if (!$error && $trigger)
5260 5260
 			{
5261 5261
 				// Call trigger
5262
-				$this->context=array('extrafieldupdate'=>1);
5263
-				$result=$this->call_trigger($trigger, $userused);
5262
+				$this->context = array('extrafieldupdate'=>1);
5263
+				$result = $this->call_trigger($trigger, $userused);
5264 5264
 				if ($result < 0) $error++;
5265 5265
 				// End call trigger
5266 5266
 			}
5267 5267
 
5268 5268
 			if ($error)
5269 5269
 			{
5270
-				dol_syslog(get_class($this) . "::".__METHOD__ . $this->error, LOG_ERR);
5270
+				dol_syslog(get_class($this)."::".__METHOD__.$this->error, LOG_ERR);
5271 5271
 				$this->db->rollback();
5272 5272
 				return -1;
5273 5273
 			}
@@ -5294,71 +5294,71 @@  discard block
 block discarded – undo
5294 5294
 	 * @param  string|int		$morecss       Value for css to define style/length of field. May also be a numeric.
5295 5295
 	 * @return string
5296 5296
 	 */
5297
-	function showInputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $morecss=0)
5297
+	function showInputField($val, $key, $value, $moreparam = '', $keysuffix = '', $keyprefix = '', $morecss = 0)
5298 5298
 	{
5299
-		global $conf,$langs,$form;
5299
+		global $conf, $langs, $form;
5300 5300
 
5301
-		if (! is_object($form))
5301
+		if (!is_object($form))
5302 5302
 		{
5303 5303
 			require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';
5304
-			$form=new Form($this->db);
5304
+			$form = new Form($this->db);
5305 5305
 		}
5306 5306
 
5307
-		$val=$this->fields[$key];
5307
+		$val = $this->fields[$key];
5308 5308
 
5309
-		$out='';
5310
-        $type='';
5309
+		$out = '';
5310
+        $type = '';
5311 5311
         $param = array();
5312
-        $param['options']=array();
5313
-        $size =$this->fields[$key]['size'];
5312
+        $param['options'] = array();
5313
+        $size = $this->fields[$key]['size'];
5314 5314
         // Because we work on extrafields
5315
-        if(preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)){
5316
-            $param['options']=array($reg[1].':'.$reg[2]=>'N');
5317
-            $type ='link';
5318
-        } elseif(preg_match('/^link:(.*):(.*)/i', $val['type'], $reg)) {
5319
-            $param['options']=array($reg[1].':'.$reg[2]=>'N');
5320
-            $type ='link';
5321
-        } elseif(preg_match('/^sellist:(.*):(.*):(.*):(.*)/i', $val['type'], $reg)) {
5322
-            $param['options']=array($reg[1].':'.$reg[2].':'.$reg[3].':'.$reg[4]=>'N');
5323
-            $type ='sellist';
5324
-        } elseif(preg_match('/varchar\((\d+)\)/', $val['type'],$reg)) {
5325
-            $param['options']=array();
5326
-            $type ='varchar';
5327
-            $size=$reg[1];
5328
-        } elseif(preg_match('/varchar/', $val['type'])) {
5329
-            $param['options']=array();
5330
-            $type ='varchar';
5331
-        } elseif(is_array($this->fields[$key]['arrayofkeyval'])) {
5332
-            $param['options']=$this->fields[$key]['arrayofkeyval'];
5333
-            $type ='select';
5315
+        if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) {
5316
+            $param['options'] = array($reg[1].':'.$reg[2]=>'N');
5317
+            $type = 'link';
5318
+        } elseif (preg_match('/^link:(.*):(.*)/i', $val['type'], $reg)) {
5319
+            $param['options'] = array($reg[1].':'.$reg[2]=>'N');
5320
+            $type = 'link';
5321
+        } elseif (preg_match('/^sellist:(.*):(.*):(.*):(.*)/i', $val['type'], $reg)) {
5322
+            $param['options'] = array($reg[1].':'.$reg[2].':'.$reg[3].':'.$reg[4]=>'N');
5323
+            $type = 'sellist';
5324
+        } elseif (preg_match('/varchar\((\d+)\)/', $val['type'], $reg)) {
5325
+            $param['options'] = array();
5326
+            $type = 'varchar';
5327
+            $size = $reg[1];
5328
+        } elseif (preg_match('/varchar/', $val['type'])) {
5329
+            $param['options'] = array();
5330
+            $type = 'varchar';
5331
+        } elseif (is_array($this->fields[$key]['arrayofkeyval'])) {
5332
+            $param['options'] = $this->fields[$key]['arrayofkeyval'];
5333
+            $type = 'select';
5334 5334
         } else {
5335
-            $param['options']=array();
5336
-            $type =$this->fields[$key]['type'];
5335
+            $param['options'] = array();
5336
+            $type = $this->fields[$key]['type'];
5337 5337
         }
5338 5338
 
5339
-		$label=$this->fields[$key]['label'];
5339
+		$label = $this->fields[$key]['label'];
5340 5340
 		//$elementtype=$this->fields[$key]['elementtype'];	// Seems not used
5341
-		$default=$this->fields[$key]['default'];
5342
-		$computed=$this->fields[$key]['computed'];
5343
-		$unique=$this->fields[$key]['unique'];
5344
-		$required=$this->fields[$key]['required'];
5341
+		$default = $this->fields[$key]['default'];
5342
+		$computed = $this->fields[$key]['computed'];
5343
+		$unique = $this->fields[$key]['unique'];
5344
+		$required = $this->fields[$key]['required'];
5345 5345
 
5346
-		$langfile=$this->fields[$key]['langfile'];
5347
-		$list=$this->fields[$key]['list'];
5348
-		$hidden=abs($this->fields[$key]['visible'])!=1?1:0;
5346
+		$langfile = $this->fields[$key]['langfile'];
5347
+		$list = $this->fields[$key]['list'];
5348
+		$hidden = abs($this->fields[$key]['visible']) != 1 ? 1 : 0;
5349 5349
 
5350 5350
 		$objectid = $this->id;
5351 5351
 
5352 5352
 
5353 5353
 		if ($computed)
5354 5354
 		{
5355
-			if (! preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';
5355
+			if (!preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';
5356 5356
 			else return '';
5357 5357
 		}
5358 5358
 
5359 5359
 
5360 5360
 		// Use in priority showsize from parameters, then $val['css'] then autodefine
5361
-		if (empty($morecss) && ! empty($val['css']))
5361
+		if (empty($morecss) && !empty($val['css']))
5362 5362
 		{
5363 5363
 			$showsize = $val['css'];
5364 5364
 		}
@@ -5372,16 +5372,16 @@  discard block
 block discarded – undo
5372 5372
 			{
5373 5373
 				$morecss = 'minwidth200imp';
5374 5374
 			}
5375
-			elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))
5375
+			elseif (in_array($type, array('int', 'integer', 'price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/', $type))
5376 5376
 			{
5377 5377
 				$morecss = 'maxwidth75';
5378 5378
                         }elseif ($type == 'url')
5379 5379
 			{
5380
-				$morecss='minwidth400';
5380
+				$morecss = 'minwidth400';
5381 5381
 			}
5382 5382
 			elseif ($type == 'boolean')
5383 5383
 			{
5384
-				$morecss='';
5384
+				$morecss = '';
5385 5385
 			}
5386 5386
 			else
5387 5387
 			{
@@ -5400,12 +5400,12 @@  discard block
 block discarded – undo
5400 5400
 			}
5401 5401
 		}
5402 5402
 
5403
-		if (in_array($type,array('date','datetime')))
5403
+		if (in_array($type, array('date', 'datetime')))
5404 5404
 		{
5405
-			$tmp=explode(',',$size);
5406
-			$newsize=$tmp[0];
5405
+			$tmp = explode(',', $size);
5406
+			$newsize = $tmp[0];
5407 5407
 
5408
-			$showtime = in_array($type,array('datetime')) ? 1 : 0;
5408
+			$showtime = in_array($type, array('datetime')) ? 1 : 0;
5409 5409
 
5410 5410
 			// Do not show current date when field not required (see selectDate() method)
5411 5411
 			if (!$required && $value == '') $value = '-1';
@@ -5413,237 +5413,237 @@  discard block
 block discarded – undo
5413 5413
 			// TODO Must also support $moreparam
5414 5414
 			$out = $form->selectDate($value, $keyprefix.$key.$keysuffix, $showtime, $showtime, $required, '', 1, (($keyprefix != 'search_' && $keyprefix != 'search_options_') ? 1 : 0), 0, 1);
5415 5415
 		}
5416
-		elseif (in_array($type,array('int','integer')))
5416
+		elseif (in_array($type, array('int', 'integer')))
5417 5417
 		{
5418
-			$tmp=explode(',',$size);
5419
-			$newsize=$tmp[0];
5420
-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';
5418
+			$tmp = explode(',', $size);
5419
+			$newsize = $tmp[0];
5420
+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam ? $moreparam : '').'>';
5421 5421
 		}
5422 5422
 		elseif (preg_match('/varchar/', $type))
5423 5423
 		{
5424
-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';
5424
+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam ? $moreparam : '').'>';
5425 5425
 		}
5426 5426
 		elseif (in_array($type, array('mail', 'phone', 'url')))
5427 5427
 		{
5428
-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';
5428
+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam ? $moreparam : '').'>';
5429 5429
 		}
5430 5430
 		elseif ($type == 'text')
5431 5431
 		{
5432
-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field
5432
+			if (!preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field
5433 5433
 			{
5434 5434
 				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
5435
-				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,false,ROWS_5,'90%');
5436
-				$out=$doleditor->Create(1);
5435
+				$doleditor = new DolEditor($keyprefix.$key.$keysuffix, $value, '', 200, 'dolibarr_notes', 'In', false, false, false, ROWS_5, '90%');
5436
+				$out = $doleditor->Create(1);
5437 5437
 			}
5438 5438
 			else
5439 5439
 			{
5440
-				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';
5440
+				$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam ? $moreparam : '').'>';
5441 5441
 			}
5442 5442
 		}
5443 5443
 		elseif ($type == 'html')
5444 5444
 		{
5445
-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field
5445
+			if (!preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field
5446 5446
 			{
5447 5447
 				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
5448
-				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,! empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE,ROWS_5,'90%');
5449
-				$out=$doleditor->Create(1);
5448
+				$doleditor = new DolEditor($keyprefix.$key.$keysuffix, $value, '', 200, 'dolibarr_notes', 'In', false, false, !empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE, ROWS_5, '90%');
5449
+				$out = $doleditor->Create(1);
5450 5450
 			}
5451 5451
 			else
5452 5452
 			{
5453
-				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';
5453
+				$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam ? $moreparam : '').'>';
5454 5454
 			}
5455 5455
 		}
5456 5456
 		elseif ($type == 'boolean')
5457 5457
 		{
5458
-			$checked='';
5458
+			$checked = '';
5459 5459
 			if (!empty($value)) {
5460
-				$checked=' checked value="1" ';
5460
+				$checked = ' checked value="1" ';
5461 5461
 			} else {
5462
-				$checked=' value="1" ';
5462
+				$checked = ' value="1" ';
5463 5463
 			}
5464
-			$out='<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam?$moreparam:'').'>';
5464
+			$out = '<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam ? $moreparam : '').'>';
5465 5465
 		}
5466 5466
 		elseif ($type == 'price')
5467 5467
 		{
5468 5468
 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.
5469
-				$value=price($value);
5469
+				$value = price($value);
5470 5470
 			}
5471
-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> '.$langs->getCurrencySymbol($conf->currency);
5471
+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam ? $moreparam : '').'> '.$langs->getCurrencySymbol($conf->currency);
5472 5472
 		}
5473
-		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))
5473
+		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/', $type))
5474 5474
 		{
5475 5475
 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.
5476
-				$value=price($value);
5476
+				$value = price($value);
5477 5477
 			}
5478
-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> ';
5478
+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam ? $moreparam : '').'> ';
5479 5479
 		}
5480 5480
 		elseif ($type == 'select')
5481 5481
 		{
5482 5482
 			$out = '';
5483
-			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))
5483
+			if (!empty($conf->use_javascript_ajax) && !empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))
5484 5484
 			{
5485
-				include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';
5486
-				$out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);
5485
+				include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';
5486
+				$out .= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);
5487 5487
 			}
5488 5488
 
5489
-			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';
5490
-                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1))$out.='<option value="0">&nbsp;</option>';
5489
+			$out .= '<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam ? $moreparam : '').'>';
5490
+                if ((!isset($this->fields[$key]['default'])) || ($this->fields[$key]['notnull'] != 1))$out .= '<option value="0">&nbsp;</option>';
5491 5491
 			foreach ($param['options'] as $key => $val)
5492 5492
 			{
5493 5493
 				if ((string) $key == '') continue;
5494 5494
 				list($val, $parent) = explode('|', $val);
5495
-				$out.='<option value="'.$key.'"';
5496
-				$out.= (((string) $value == (string) $key)?' selected':'');
5497
-				$out.= (!empty($parent)?' parent="'.$parent.'"':'');
5498
-				$out.='>'.$val.'</option>';
5495
+				$out .= '<option value="'.$key.'"';
5496
+				$out .= (((string) $value == (string) $key) ? ' selected' : '');
5497
+				$out .= (!empty($parent) ? ' parent="'.$parent.'"' : '');
5498
+				$out .= '>'.$val.'</option>';
5499 5499
 			}
5500
-			$out.='</select>';
5500
+			$out .= '</select>';
5501 5501
 		}
5502 5502
 		elseif ($type == 'sellist')
5503 5503
 		{
5504 5504
 			$out = '';
5505
-			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))
5505
+			if (!empty($conf->use_javascript_ajax) && !empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))
5506 5506
 			{
5507
-				include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';
5508
-				$out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);
5507
+				include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';
5508
+				$out .= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);
5509 5509
 			}
5510 5510
 
5511
-			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';
5511
+			$out .= '<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam ? $moreparam : '').'>';
5512 5512
 			if (is_array($param['options']))
5513 5513
 			{
5514
-				$param_list=array_keys($param['options']);
5514
+				$param_list = array_keys($param['options']);
5515 5515
 				$InfoFieldList = explode(":", $param_list[0]);
5516
-				$parentName='';
5517
-				$parentField='';
5516
+				$parentName = '';
5517
+				$parentField = '';
5518 5518
 				// 0 : tableName
5519 5519
 				// 1 : label field name
5520 5520
 				// 2 : key fields name (if differ of rowid)
5521 5521
 				// 3 : key field parent (for dependent lists)
5522 5522
 				// 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value
5523
-				$keyList=(empty($InfoFieldList[2])?'rowid':$InfoFieldList[2].' as rowid');
5523
+				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2].' as rowid');
5524 5524
 
5525 5525
 
5526
-				if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4]))
5526
+				if (count($InfoFieldList) > 4 && !empty($InfoFieldList[4]))
5527 5527
 				{
5528 5528
 					if (strpos($InfoFieldList[4], 'extra.') !== false)
5529 5529
 					{
5530
-						$keyList='main.'.$InfoFieldList[2].' as rowid';
5530
+						$keyList = 'main.'.$InfoFieldList[2].' as rowid';
5531 5531
 					} else {
5532
-						$keyList=$InfoFieldList[2].' as rowid';
5532
+						$keyList = $InfoFieldList[2].' as rowid';
5533 5533
 					}
5534 5534
 				}
5535
-				if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3]))
5535
+				if (count($InfoFieldList) > 3 && !empty($InfoFieldList[3]))
5536 5536
 				{
5537 5537
 					list($parentName, $parentField) = explode('|', $InfoFieldList[3]);
5538
-					$keyList.= ', '.$parentField;
5538
+					$keyList .= ', '.$parentField;
5539 5539
 				}
5540 5540
 
5541
-				$fields_label = explode('|',$InfoFieldList[1]);
5541
+				$fields_label = explode('|', $InfoFieldList[1]);
5542 5542
 				if (is_array($fields_label))
5543 5543
 				{
5544
-					$keyList .=', ';
5544
+					$keyList .= ', ';
5545 5545
 					$keyList .= implode(', ', $fields_label);
5546 5546
 				}
5547 5547
 
5548
-				$sqlwhere='';
5548
+				$sqlwhere = '';
5549 5549
 				$sql = 'SELECT '.$keyList;
5550
-				$sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];
5550
+				$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];
5551 5551
 				if (!empty($InfoFieldList[4]))
5552 5552
 				{
5553 5553
 					// can use SELECT request
5554
-					if (strpos($InfoFieldList[4], '$SEL$')!==false) {
5555
-						$InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);
5554
+					if (strpos($InfoFieldList[4], '$SEL$') !== false) {
5555
+						$InfoFieldList[4] = str_replace('$SEL$', 'SELECT', $InfoFieldList[4]);
5556 5556
 					}
5557 5557
 
5558 5558
 					// current object id can be use into filter
5559
-					if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {
5560
-						$InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);
5559
+					if (strpos($InfoFieldList[4], '$ID$') !== false && !empty($objectid)) {
5560
+						$InfoFieldList[4] = str_replace('$ID$', $objectid, $InfoFieldList[4]);
5561 5561
 					} else {
5562
-						$InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);
5562
+						$InfoFieldList[4] = str_replace('$ID$', '0', $InfoFieldList[4]);
5563 5563
 					}
5564 5564
 					//We have to join on extrafield table
5565
-					if (strpos($InfoFieldList[4], 'extra')!==false)
5565
+					if (strpos($InfoFieldList[4], 'extra') !== false)
5566 5566
 					{
5567
-						$sql.= ' as main, '.MAIN_DB_PREFIX .$InfoFieldList[0].'_extrafields as extra';
5568
-						$sqlwhere.= ' WHERE extra.fk_object=main.'.$InfoFieldList[2]. ' AND '.$InfoFieldList[4];
5567
+						$sql .= ' as main, '.MAIN_DB_PREFIX.$InfoFieldList[0].'_extrafields as extra';
5568
+						$sqlwhere .= ' WHERE extra.fk_object=main.'.$InfoFieldList[2].' AND '.$InfoFieldList[4];
5569 5569
 					}
5570 5570
 					else
5571 5571
 					{
5572
-						$sqlwhere.= ' WHERE '.$InfoFieldList[4];
5572
+						$sqlwhere .= ' WHERE '.$InfoFieldList[4];
5573 5573
 					}
5574 5574
 				}
5575 5575
 				else
5576 5576
 				{
5577
-					$sqlwhere.= ' WHERE 1=1';
5577
+					$sqlwhere .= ' WHERE 1=1';
5578 5578
 				}
5579 5579
 				// Some tables may have field, some other not. For the moment we disable it.
5580
-				if (in_array($InfoFieldList[0],array('tablewithentity')))
5580
+				if (in_array($InfoFieldList[0], array('tablewithentity')))
5581 5581
 				{
5582
-					$sqlwhere.= ' AND entity = '.$conf->entity;
5582
+					$sqlwhere .= ' AND entity = '.$conf->entity;
5583 5583
 				}
5584
-				$sql.=$sqlwhere;
5584
+				$sql .= $sqlwhere;
5585 5585
 				//print $sql;
5586 5586
 
5587
-				$sql .= ' ORDER BY ' . implode(', ', $fields_label);
5587
+				$sql .= ' ORDER BY '.implode(', ', $fields_label);
5588 5588
 
5589 5589
 				dol_syslog(get_class($this).'::showInputField type=sellist', LOG_DEBUG);
5590 5590
 				$resql = $this->db->query($sql);
5591 5591
 				if ($resql)
5592 5592
 				{
5593
-					$out.='<option value="0">&nbsp;</option>';
5593
+					$out .= '<option value="0">&nbsp;</option>';
5594 5594
 					$num = $this->db->num_rows($resql);
5595 5595
 					$i = 0;
5596 5596
 					while ($i < $num)
5597 5597
 					{
5598
-						$labeltoshow='';
5598
+						$labeltoshow = '';
5599 5599
 						$obj = $this->db->fetch_object($resql);
5600 5600
 
5601 5601
 						// Several field into label (eq table:code|libelle:rowid)
5602 5602
 						$notrans = false;
5603
-						$fields_label = explode('|',$InfoFieldList[1]);
5603
+						$fields_label = explode('|', $InfoFieldList[1]);
5604 5604
 						if (is_array($fields_label))
5605 5605
 						{
5606 5606
 							$notrans = true;
5607 5607
 							foreach ($fields_label as $field_toshow)
5608 5608
 							{
5609
-								$labeltoshow.= $obj->$field_toshow.' ';
5609
+								$labeltoshow .= $obj->$field_toshow.' ';
5610 5610
 							}
5611 5611
 						}
5612 5612
 						else
5613 5613
 						{
5614
-							$labeltoshow=$obj->{$InfoFieldList[1]};
5614
+							$labeltoshow = $obj->{$InfoFieldList[1]};
5615 5615
 						}
5616
-						$labeltoshow=dol_trunc($labeltoshow,45);
5616
+						$labeltoshow = dol_trunc($labeltoshow, 45);
5617 5617
 
5618 5618
 						if ($value == $obj->rowid)
5619 5619
 						{
5620 5620
 							foreach ($fields_label as $field_toshow)
5621 5621
 							{
5622
-								$translabel=$langs->trans($obj->$field_toshow);
5623
-								if ($translabel!=$obj->$field_toshow) {
5624
-									$labeltoshow=dol_trunc($translabel,18).' ';
5625
-								}else {
5626
-									$labeltoshow=dol_trunc($obj->$field_toshow,18).' ';
5622
+								$translabel = $langs->trans($obj->$field_toshow);
5623
+								if ($translabel != $obj->$field_toshow) {
5624
+									$labeltoshow = dol_trunc($translabel, 18).' ';
5625
+								} else {
5626
+									$labeltoshow = dol_trunc($obj->$field_toshow, 18).' ';
5627 5627
 								}
5628 5628
 							}
5629
-							$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';
5629
+							$out .= '<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';
5630 5630
 						}
5631 5631
 						else
5632 5632
 						{
5633
-							if (! $notrans)
5633
+							if (!$notrans)
5634 5634
 							{
5635
-								$translabel=$langs->trans($obj->{$InfoFieldList[1]});
5636
-								if ($translabel!=$obj->{$InfoFieldList[1]}) {
5637
-									$labeltoshow=dol_trunc($translabel,18);
5635
+								$translabel = $langs->trans($obj->{$InfoFieldList[1]});
5636
+								if ($translabel != $obj->{$InfoFieldList[1]}) {
5637
+									$labeltoshow = dol_trunc($translabel, 18);
5638 5638
 								}
5639 5639
 								else {
5640
-									$labeltoshow=dol_trunc($obj->{$InfoFieldList[1]},18);
5640
+									$labeltoshow = dol_trunc($obj->{$InfoFieldList[1]},18);
5641 5641
 								}
5642 5642
 							}
5643
-							if (empty($labeltoshow)) $labeltoshow='(not defined)';
5644
-							if ($value==$obj->rowid)
5643
+							if (empty($labeltoshow)) $labeltoshow = '(not defined)';
5644
+							if ($value == $obj->rowid)
5645 5645
 							{
5646
-								$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';
5646
+								$out .= '<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';
5647 5647
 							}
5648 5648
 
5649 5649
 							if (!empty($InfoFieldList[3]) && $parentField)
@@ -5651,10 +5651,10 @@  discard block
 block discarded – undo
5651 5651
 								$parent = $parentName.':'.$obj->{$parentField};
5652 5652
 							}
5653 5653
 
5654
-							$out.='<option value="'.$obj->rowid.'"';
5655
-							$out.= ($value==$obj->rowid?' selected':'');
5656
-							$out.= (!empty($parent)?' parent="'.$parent.'"':'');
5657
-							$out.='>'.$labeltoshow.'</option>';
5654
+							$out .= '<option value="'.$obj->rowid.'"';
5655
+							$out .= ($value == $obj->rowid ? ' selected' : '');
5656
+							$out .= (!empty($parent) ? ' parent="'.$parent.'"' : '');
5657
+							$out .= '>'.$labeltoshow.'</option>';
5658 5658
 						}
5659 5659
 
5660 5660
 						$i++;
@@ -5665,23 +5665,23 @@  discard block
 block discarded – undo
5665 5665
 					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';
5666 5666
 				}
5667 5667
 			}
5668
-			$out.='</select>';
5668
+			$out .= '</select>';
5669 5669
 		}
5670 5670
 		elseif ($type == 'checkbox')
5671 5671
 		{
5672
-			$value_arr=explode(',',$value);
5673
-			$out=$form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options'])?null:$param['options']), $value_arr, '', 0, '', 0, '100%');
5672
+			$value_arr = explode(',', $value);
5673
+			$out = $form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options']) ?null:$param['options']), $value_arr, '', 0, '', 0, '100%');
5674 5674
 		}
5675 5675
 		elseif ($type == 'radio')
5676 5676
 		{
5677
-			$out='';
5677
+			$out = '';
5678 5678
 			foreach ($param['options'] as $keyopt => $val)
5679 5679
 			{
5680
-				$out.='<input class="flat '.$morecss.'" type="radio" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'');
5681
-				$out.=' value="'.$keyopt.'"';
5682
-				$out.=' id="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'"';
5683
-				$out.= ($value==$keyopt?'checked':'');
5684
-				$out.='/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';
5680
+				$out .= '<input class="flat '.$morecss.'" type="radio" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam ? $moreparam : '');
5681
+				$out .= ' value="'.$keyopt.'"';
5682
+				$out .= ' id="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'"';
5683
+				$out .= ($value == $keyopt ? 'checked' : '');
5684
+				$out .= '/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';
5685 5685
 			}
5686 5686
 		}
5687 5687
 		elseif ($type == 'chkbxlst')
@@ -5696,24 +5696,24 @@  discard block
 block discarded – undo
5696 5696
 			if (is_array($param['options'])) {
5697 5697
 				$param_list = array_keys($param['options']);
5698 5698
 				$InfoFieldList = explode(":", $param_list[0]);
5699
-				$parentName='';
5700
-				$parentField='';
5699
+				$parentName = '';
5700
+				$parentField = '';
5701 5701
 				// 0 : tableName
5702 5702
 				// 1 : label field name
5703 5703
 				// 2 : key fields name (if differ of rowid)
5704 5704
 				// 3 : key field parent (for dependent lists)
5705 5705
 				// 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value
5706
-				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2] . ' as rowid');
5706
+				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2].' as rowid');
5707 5707
 
5708
-				if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3])) {
5709
-					list ( $parentName, $parentField ) = explode('|', $InfoFieldList[3]);
5710
-					$keyList .= ', ' . $parentField;
5708
+				if (count($InfoFieldList) > 3 && !empty($InfoFieldList[3])) {
5709
+					list ($parentName, $parentField) = explode('|', $InfoFieldList[3]);
5710
+					$keyList .= ', '.$parentField;
5711 5711
 				}
5712
-				if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4])) {
5712
+				if (count($InfoFieldList) > 4 && !empty($InfoFieldList[4])) {
5713 5713
 					if (strpos($InfoFieldList[4], 'extra.') !== false) {
5714
-						$keyList = 'main.' . $InfoFieldList[2] . ' as rowid';
5714
+						$keyList = 'main.'.$InfoFieldList[2].' as rowid';
5715 5715
 					} else {
5716
-						$keyList = $InfoFieldList[2] . ' as rowid';
5716
+						$keyList = $InfoFieldList[2].' as rowid';
5717 5717
 					}
5718 5718
 				}
5719 5719
 
@@ -5724,50 +5724,50 @@  discard block
 block discarded – undo
5724 5724
 				}
5725 5725
 
5726 5726
 				$sqlwhere = '';
5727
-				$sql = 'SELECT ' . $keyList;
5728
-				$sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];
5729
-				if (! empty($InfoFieldList[4])) {
5727
+				$sql = 'SELECT '.$keyList;
5728
+				$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];
5729
+				if (!empty($InfoFieldList[4])) {
5730 5730
 
5731 5731
 					// can use SELECT request
5732
-					if (strpos($InfoFieldList[4], '$SEL$')!==false) {
5733
-						$InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);
5732
+					if (strpos($InfoFieldList[4], '$SEL$') !== false) {
5733
+						$InfoFieldList[4] = str_replace('$SEL$', 'SELECT', $InfoFieldList[4]);
5734 5734
 					}
5735 5735
 
5736 5736
 					// current object id can be use into filter
5737
-					if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {
5738
-						$InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);
5737
+					if (strpos($InfoFieldList[4], '$ID$') !== false && !empty($objectid)) {
5738
+						$InfoFieldList[4] = str_replace('$ID$', $objectid, $InfoFieldList[4]);
5739 5739
 					} else {
5740
-						$InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);
5740
+						$InfoFieldList[4] = str_replace('$ID$', '0', $InfoFieldList[4]);
5741 5741
 					}
5742 5742
 
5743 5743
 					// We have to join on extrafield table
5744 5744
 					if (strpos($InfoFieldList[4], 'extra') !== false) {
5745
-						$sql .= ' as main, ' . MAIN_DB_PREFIX . $InfoFieldList[0] . '_extrafields as extra';
5746
-						$sqlwhere .= ' WHERE extra.fk_object=main.' . $InfoFieldList[2] . ' AND ' . $InfoFieldList[4];
5745
+						$sql .= ' as main, '.MAIN_DB_PREFIX.$InfoFieldList[0].'_extrafields as extra';
5746
+						$sqlwhere .= ' WHERE extra.fk_object=main.'.$InfoFieldList[2].' AND '.$InfoFieldList[4];
5747 5747
 					} else {
5748
-						$sqlwhere .= ' WHERE ' . $InfoFieldList[4];
5748
+						$sqlwhere .= ' WHERE '.$InfoFieldList[4];
5749 5749
 					}
5750 5750
 				} else {
5751 5751
 					$sqlwhere .= ' WHERE 1=1';
5752 5752
 				}
5753 5753
 				// Some tables may have field, some other not. For the moment we disable it.
5754
-				if (in_array($InfoFieldList[0], array ('tablewithentity')))
5754
+				if (in_array($InfoFieldList[0], array('tablewithentity')))
5755 5755
 				{
5756
-					$sqlwhere .= ' AND entity = ' . $conf->entity;
5756
+					$sqlwhere .= ' AND entity = '.$conf->entity;
5757 5757
 				}
5758 5758
 				// $sql.=preg_replace('/^ AND /','',$sqlwhere);
5759 5759
 				// print $sql;
5760 5760
 
5761 5761
 				$sql .= $sqlwhere;
5762
-				dol_syslog(get_class($this) . '::showInputField type=chkbxlst',LOG_DEBUG);
5762
+				dol_syslog(get_class($this).'::showInputField type=chkbxlst', LOG_DEBUG);
5763 5763
 				$resql = $this->db->query($sql);
5764 5764
 				if ($resql) {
5765 5765
 					$num = $this->db->num_rows($resql);
5766 5766
 					$i = 0;
5767 5767
 
5768
-					$data=array();
5768
+					$data = array();
5769 5769
 
5770
-					while ( $i < $num ) {
5770
+					while ($i < $num) {
5771 5771
 						$labeltoshow = '';
5772 5772
 						$obj = $this->db->fetch_object($resql);
5773 5773
 
@@ -5776,8 +5776,8 @@  discard block
 block discarded – undo
5776 5776
 						$fields_label = explode('|', $InfoFieldList[1]);
5777 5777
 						if (is_array($fields_label)) {
5778 5778
 							$notrans = true;
5779
-							foreach ( $fields_label as $field_toshow ) {
5780
-								$labeltoshow .= $obj->$field_toshow . ' ';
5779
+							foreach ($fields_label as $field_toshow) {
5780
+								$labeltoshow .= $obj->$field_toshow.' ';
5781 5781
 							}
5782 5782
 						} else {
5783 5783
 							$labeltoshow = $obj->{$InfoFieldList[1]};
@@ -5785,18 +5785,18 @@  discard block
 block discarded – undo
5785 5785
 						$labeltoshow = dol_trunc($labeltoshow, 45);
5786 5786
 
5787 5787
 						if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {
5788
-							foreach ( $fields_label as $field_toshow ) {
5788
+							foreach ($fields_label as $field_toshow) {
5789 5789
 								$translabel = $langs->trans($obj->$field_toshow);
5790 5790
 								if ($translabel != $obj->$field_toshow) {
5791
-									$labeltoshow = dol_trunc($translabel, 18) . ' ';
5791
+									$labeltoshow = dol_trunc($translabel, 18).' ';
5792 5792
 								} else {
5793
-									$labeltoshow = dol_trunc($obj->$field_toshow, 18) . ' ';
5793
+									$labeltoshow = dol_trunc($obj->$field_toshow, 18).' ';
5794 5794
 								}
5795 5795
 							}
5796 5796
 
5797
-							$data[$obj->rowid]=$labeltoshow;
5797
+							$data[$obj->rowid] = $labeltoshow;
5798 5798
 						} else {
5799
-							if (! $notrans) {
5799
+							if (!$notrans) {
5800 5800
 								$translabel = $langs->trans($obj->{$InfoFieldList[1]});
5801 5801
 								if ($translabel != $obj->{$InfoFieldList[1]}) {
5802 5802
 									$labeltoshow = dol_trunc($translabel, 18);
@@ -5808,67 +5808,67 @@  discard block
 block discarded – undo
5808 5808
 								$labeltoshow = '(not defined)';
5809 5809
 
5810 5810
 								if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {
5811
-									$data[$obj->rowid]=$labeltoshow;
5811
+									$data[$obj->rowid] = $labeltoshow;
5812 5812
 								}
5813 5813
 
5814
-								if (! empty($InfoFieldList[3]) && $parentField) {
5815
-									$parent = $parentName . ':' . $obj->{$parentField};
5814
+								if (!empty($InfoFieldList[3]) && $parentField) {
5815
+									$parent = $parentName.':'.$obj->{$parentField};
5816 5816
 								}
5817 5817
 
5818
-								$data[$obj->rowid]=$labeltoshow;
5818
+								$data[$obj->rowid] = $labeltoshow;
5819 5819
 						}
5820 5820
 
5821
-						$i ++;
5821
+						$i++;
5822 5822
 					}
5823 5823
 					$this->db->free($resql);
5824 5824
 
5825
-					$out=$form->multiselectarray($keyprefix.$key.$keysuffix, $data, $value_arr, '', 0, '', 0, '100%');
5825
+					$out = $form->multiselectarray($keyprefix.$key.$keysuffix, $data, $value_arr, '', 0, '', 0, '100%');
5826 5826
 				} else {
5827
-					print 'Error in request ' . $sql . ' ' . $this->db->lasterror() . '. Check setup of extra parameters.<br>';
5827
+					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';
5828 5828
 				}
5829 5829
 			}
5830 5830
 		}
5831 5831
 		elseif ($type == 'link')
5832 5832
 		{
5833
-			$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'
5834
-			$showempty=(($required && $default != '')?0:1);
5835
-			$out=$form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);
5833
+			$param_list = array_keys($param['options']); // $param_list='ObjectName:classPath'
5834
+			$showempty = (($required && $default != '') ? 0 : 1);
5835
+			$out = $form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);
5836 5836
 			if ($conf->global->MAIN_FEATURES_LEVEL >= 2)
5837 5837
 			{
5838
-            			list($class,$classfile)=explode(':',$param_list[0]);
5839
-            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);
5840
-            			else $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);
5841
-            			$out.='<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';
5838
+            			list($class, $classfile) = explode(':', $param_list[0]);
5839
+            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path = dol_buildpath(dirname(dirname($classfile)).'/card.php', 1);
5840
+            			else $url_path = dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php', 1);
5841
+            			$out .= '<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';
5842 5842
             			// TODO Add Javascript code to add input fields contents to new elements urls
5843 5843
 			}
5844 5844
 		}
5845 5845
 		elseif ($type == 'password')
5846 5846
 		{
5847 5847
 			// If prefix is 'search_', field is used as a filter, we use a common text field.
5848
-			$out='<input type="'.($keyprefix=='search_'?'text':'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'>';
5848
+			$out = '<input type="'.($keyprefix == 'search_' ? 'text' : 'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam ? $moreparam : '').'>';
5849 5849
 		}
5850 5850
 		elseif ($type == 'array')
5851 5851
 		{
5852 5852
 			$newval = $val;
5853 5853
 			$newval['type'] = 'varchar(256)';
5854 5854
 
5855
-			$out='';
5855
+			$out = '';
5856 5856
 
5857 5857
 			$inputs = array();
5858
-			if(! empty($value)) {
5859
-				foreach($value as $option) {
5860
-					$out.= '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';
5861
-					$out.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', $option, $moreparam, '', '', $showsize).'<br></span>';
5858
+			if (!empty($value)) {
5859
+				foreach ($value as $option) {
5860
+					$out .= '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';
5861
+					$out .= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', $option, $moreparam, '', '', $showsize).'<br></span>';
5862 5862
 				}
5863 5863
 			}
5864 5864
 
5865
-			$out.= '<a id="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_add" href="javascript:;"><span class="fa fa-plus-circle valignmiddle"></span></a>';
5865
+			$out .= '<a id="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_add" href="javascript:;"><span class="fa fa-plus-circle valignmiddle"></span></a>';
5866 5866
 
5867 5867
 			$newInput = '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';
5868
-			$newInput.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', '', $moreparam, '', '', $showsize).'<br></span>';
5868
+			$newInput .= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', '', $moreparam, '', '', $showsize).'<br></span>';
5869 5869
 
5870
-			if(! empty($conf->use_javascript_ajax)) {
5871
-				$out.= '
5870
+			if (!empty($conf->use_javascript_ajax)) {
5871
+				$out .= '
5872 5872
 					<script type="text/javascript">
5873 5873
 					$(document).ready(function() {
5874 5874
 						$("a#'.dol_escape_js($keyprefix.$key.$keysuffix).'_add").click(function() {
@@ -5883,7 +5883,7 @@  discard block
 block discarded – undo
5883 5883
 			}
5884 5884
 		}
5885 5885
 		if (!empty($hidden)) {
5886
-			$out='<input type="hidden" value="'.$value.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'"/>';
5886
+			$out = '<input type="hidden" value="'.$value.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'"/>';
5887 5887
 		}
5888 5888
 		/* Add comments
5889 5889
 		 if ($type == 'date') $out.=' (YYYY-MM-DD)';
@@ -5905,14 +5905,14 @@  discard block
 block discarded – undo
5905 5905
 	 * @param  mixed   $showsize       Value for css to define size. May also be a numeric.
5906 5906
 	 * @return string
5907 5907
 	 */
5908
-	function showOutputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $showsize=0)
5908
+	function showOutputField($val, $key, $value, $moreparam = '', $keysuffix = '', $keyprefix = '', $showsize = 0)
5909 5909
 	{
5910
-		global $conf,$langs,$form;
5910
+		global $conf, $langs, $form;
5911 5911
 
5912
-		if (! is_object($form))
5912
+		if (!is_object($form))
5913 5913
 		{
5914 5914
 			require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';
5915
-			$form=new Form($this->db);
5915
+			$form = new Form($this->db);
5916 5916
 		}
5917 5917
 
5918 5918
 		$objectid = $this->id;
@@ -5923,28 +5923,28 @@  discard block
 block discarded – undo
5923 5923
 		// Convert var to be able to share same code than showOutputField of extrafields
5924 5924
 		if (preg_match('/varchar\((\d+)\)/', $type, $reg))
5925 5925
 		{
5926
-			$type = 'varchar';		// convert varchar(xx) int varchar
5926
+			$type = 'varchar'; // convert varchar(xx) int varchar
5927 5927
 			$size = $reg[1];
5928 5928
 		}
5929
-		elseif (preg_match('/varchar/', $type)) $type = 'varchar';		// convert varchar(xx) int varchar
5930
-		if (is_array($val['arrayofkeyval'])) $type='select';
5931
-		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type='link';
5929
+		elseif (preg_match('/varchar/', $type)) $type = 'varchar'; // convert varchar(xx) int varchar
5930
+		if (is_array($val['arrayofkeyval'])) $type = 'select';
5931
+		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type = 'link';
5932 5932
 
5933
-		$default=$val['default'];
5934
-		$computed=$val['computed'];
5935
-		$unique=$val['unique'];
5936
-		$required=$val['required'];
5937
-		$param=$val['param'];
5933
+		$default = $val['default'];
5934
+		$computed = $val['computed'];
5935
+		$unique = $val['unique'];
5936
+		$required = $val['required'];
5937
+		$param = $val['param'];
5938 5938
 		if (is_array($val['arrayofkeyval'])) $param['options'] = $val['arrayofkeyval'];
5939 5939
 		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg))
5940 5940
 		{
5941
-			$type='link';
5942
-			$param['options']=array($reg[1].':'.$reg[2]=>$reg[1].':'.$reg[2]);
5941
+			$type = 'link';
5942
+			$param['options'] = array($reg[1].':'.$reg[2]=>$reg[1].':'.$reg[2]);
5943 5943
 		}
5944
-		$langfile=$val['langfile'];
5945
-		$list=$val['list'];
5946
-		$help=$val['help'];
5947
-		$hidden=(($val['visible'] == 0) ? 1 : 0);			// If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)
5944
+		$langfile = $val['langfile'];
5945
+		$list = $val['list'];
5946
+		$help = $val['help'];
5947
+		$hidden = (($val['visible'] == 0) ? 1 : 0); // If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)
5948 5948
 
5949 5949
 		if ($hidden) return '';
5950 5950
 
@@ -5968,18 +5968,18 @@  discard block
 block discarded – undo
5968 5968
 				//$showsize=19;
5969 5969
 				$showsize = 'minwidth200imp';
5970 5970
 			}
5971
-			elseif (in_array($type,array('int','double','price')))
5971
+			elseif (in_array($type, array('int', 'double', 'price')))
5972 5972
 			{
5973 5973
 				//$showsize=10;
5974 5974
 				$showsize = 'maxwidth75';
5975 5975
 			}
5976 5976
 			elseif ($type == 'url')
5977 5977
 			{
5978
-				$showsize='minwidth400';
5978
+				$showsize = 'minwidth400';
5979 5979
 			}
5980 5980
 			elseif ($type == 'boolean')
5981 5981
 			{
5982
-				$showsize='';
5982
+				$showsize = '';
5983 5983
 			}
5984 5984
 			else
5985 5985
 			{
@@ -6000,90 +6000,90 @@  discard block
 block discarded – undo
6000 6000
 		}
6001 6001
 
6002 6002
 		// Format output value differently according to properties of field
6003
-		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value=$this->getNomUrl(1, '', 0, '', 1);
6004
-		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value=$this->getLibStatut(3);
6003
+		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value = $this->getNomUrl(1, '', 0, '', 1);
6004
+		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value = $this->getLibStatut(3);
6005 6005
 		elseif ($type == 'date')
6006 6006
 		{
6007
-			if(! empty($value)) {
6008
-				$value=dol_print_date($value,'day');
6007
+			if (!empty($value)) {
6008
+				$value = dol_print_date($value, 'day');
6009 6009
 			} else {
6010
-				$value='';
6010
+				$value = '';
6011 6011
 			}
6012 6012
 		}
6013 6013
 		elseif ($type == 'datetime')
6014 6014
 		{
6015
-			if(! empty($value)) {
6016
-				$value=dol_print_date($value,'dayhour');
6015
+			if (!empty($value)) {
6016
+				$value = dol_print_date($value, 'dayhour');
6017 6017
 			} else {
6018
-				$value='';
6018
+				$value = '';
6019 6019
 			}
6020 6020
 		}
6021 6021
 		elseif ($type == 'double')
6022 6022
 		{
6023 6023
 			if (!empty($value)) {
6024
-				$value=price($value);
6024
+				$value = price($value);
6025 6025
 			}
6026 6026
 		}
6027 6027
 		elseif ($type == 'boolean')
6028 6028
 		{
6029
-			$checked='';
6029
+			$checked = '';
6030 6030
 			if (!empty($value)) {
6031
-				$checked=' checked ';
6031
+				$checked = ' checked ';
6032 6032
 			}
6033
-			$value='<input type="checkbox" '.$checked.' '.($moreparam?$moreparam:'').' readonly disabled>';
6033
+			$value = '<input type="checkbox" '.$checked.' '.($moreparam ? $moreparam : '').' readonly disabled>';
6034 6034
 		}
6035 6035
 		elseif ($type == 'mail')
6036 6036
 		{
6037
-			$value=dol_print_email($value,0,0,0,64,1,1);
6037
+			$value = dol_print_email($value, 0, 0, 0, 64, 1, 1);
6038 6038
 		}
6039 6039
 		elseif ($type == 'url')
6040 6040
 		{
6041
-			$value=dol_print_url($value,'_blank',32,1);
6041
+			$value = dol_print_url($value, '_blank', 32, 1);
6042 6042
 		}
6043 6043
 		elseif ($type == 'phone')
6044 6044
 		{
6045
-			$value=dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);
6045
+			$value = dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);
6046 6046
 		}
6047 6047
 		elseif ($type == 'price')
6048 6048
 		{
6049
-			$value=price($value,0,$langs,0,0,-1,$conf->currency);
6049
+			$value = price($value, 0, $langs, 0, 0, -1, $conf->currency);
6050 6050
 		}
6051 6051
 		elseif ($type == 'select')
6052 6052
 		{
6053
-			$value=$param['options'][$value];
6053
+			$value = $param['options'][$value];
6054 6054
 		}
6055 6055
 		elseif ($type == 'sellist')
6056 6056
 		{
6057
-			$param_list=array_keys($param['options']);
6057
+			$param_list = array_keys($param['options']);
6058 6058
 			$InfoFieldList = explode(":", $param_list[0]);
6059 6059
 
6060
-			$selectkey="rowid";
6061
-			$keyList='rowid';
6060
+			$selectkey = "rowid";
6061
+			$keyList = 'rowid';
6062 6062
 
6063
-			if (count($InfoFieldList)>=3)
6063
+			if (count($InfoFieldList) >= 3)
6064 6064
 			{
6065 6065
 				$selectkey = $InfoFieldList[2];
6066
-				$keyList=$InfoFieldList[2].' as rowid';
6066
+				$keyList = $InfoFieldList[2].' as rowid';
6067 6067
 			}
6068 6068
 
6069
-			$fields_label = explode('|',$InfoFieldList[1]);
6070
-			if(is_array($fields_label)) {
6071
-				$keyList .=', ';
6069
+			$fields_label = explode('|', $InfoFieldList[1]);
6070
+			if (is_array($fields_label)) {
6071
+				$keyList .= ', ';
6072 6072
 				$keyList .= implode(', ', $fields_label);
6073 6073
 			}
6074 6074
 
6075 6075
 			$sql = 'SELECT '.$keyList;
6076
-			$sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];
6077
-			if (strpos($InfoFieldList[4], 'extra')!==false)
6076
+			$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];
6077
+			if (strpos($InfoFieldList[4], 'extra') !== false)
6078 6078
 			{
6079
-				$sql.= ' as main';
6079
+				$sql .= ' as main';
6080 6080
 			}
6081
-			if ($selectkey=='rowid' && empty($value)) {
6082
-				$sql.= " WHERE ".$selectkey."=0";
6083
-			} elseif ($selectkey=='rowid') {
6084
-				$sql.= " WHERE ".$selectkey."=".$this->db->escape($value);
6085
-			}else {
6086
-				$sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";
6081
+			if ($selectkey == 'rowid' && empty($value)) {
6082
+				$sql .= " WHERE ".$selectkey."=0";
6083
+			} elseif ($selectkey == 'rowid') {
6084
+				$sql .= " WHERE ".$selectkey."=".$this->db->escape($value);
6085
+			} else {
6086
+				$sql .= " WHERE ".$selectkey."='".$this->db->escape($value)."'";
6087 6087
 			}
6088 6088
 
6089 6089
 			//$sql.= ' AND entity = '.$conf->entity;
@@ -6092,38 +6092,38 @@  discard block
 block discarded – undo
6092 6092
 			$resql = $this->db->query($sql);
6093 6093
 			if ($resql)
6094 6094
 			{
6095
-				$value='';	// value was used, so now we reste it to use it to build final output
6095
+				$value = ''; // value was used, so now we reste it to use it to build final output
6096 6096
 
6097 6097
 				$obj = $this->db->fetch_object($resql);
6098 6098
 
6099 6099
 				// Several field into label (eq table:code|libelle:rowid)
6100
-				$fields_label = explode('|',$InfoFieldList[1]);
6100
+				$fields_label = explode('|', $InfoFieldList[1]);
6101 6101
 
6102
-				if(is_array($fields_label) && count($fields_label)>1)
6102
+				if (is_array($fields_label) && count($fields_label) > 1)
6103 6103
 				{
6104 6104
 					foreach ($fields_label as $field_toshow)
6105 6105
 					{
6106
-						$translabel='';
6106
+						$translabel = '';
6107 6107
 						if (!empty($obj->$field_toshow)) {
6108
-							$translabel=$langs->trans($obj->$field_toshow);
6108
+							$translabel = $langs->trans($obj->$field_toshow);
6109 6109
 						}
6110
-						if ($translabel!=$field_toshow) {
6111
-							$value.=dol_trunc($translabel,18).' ';
6112
-						}else {
6113
-							$value.=$obj->$field_toshow.' ';
6110
+						if ($translabel != $field_toshow) {
6111
+							$value .= dol_trunc($translabel, 18).' ';
6112
+						} else {
6113
+							$value .= $obj->$field_toshow.' ';
6114 6114
 						}
6115 6115
 					}
6116 6116
 				}
6117 6117
 				else
6118 6118
 				{
6119
-					$translabel='';
6119
+					$translabel = '';
6120 6120
 					if (!empty($obj->{$InfoFieldList[1]})) {
6121
-						$translabel=$langs->trans($obj->{$InfoFieldList[1]});
6121
+						$translabel = $langs->trans($obj->{$InfoFieldList[1]});
6122 6122
 					}
6123
-					if ($translabel!=$obj->{$InfoFieldList[1]}) {
6124
-						$value=dol_trunc($translabel,18);
6125
-					}else {
6126
-						$value=$obj->{$InfoFieldList[1]};
6123
+					if ($translabel != $obj->{$InfoFieldList[1]}) {
6124
+						$value = dol_trunc($translabel, 18);
6125
+					} else {
6126
+						$value = $obj->{$InfoFieldList[1]};
6127 6127
 					}
6128 6128
 				}
6129 6129
 			}
@@ -6131,18 +6131,18 @@  discard block
 block discarded – undo
6131 6131
 		}
6132 6132
 		elseif ($type == 'radio')
6133 6133
 		{
6134
-			$value=$param['options'][$value];
6134
+			$value = $param['options'][$value];
6135 6135
 		}
6136 6136
 		elseif ($type == 'checkbox')
6137 6137
 		{
6138
-			$value_arr=explode(',',$value);
6139
-			$value='';
6140
-			if (is_array($value_arr) && count($value_arr)>0)
6138
+			$value_arr = explode(',', $value);
6139
+			$value = '';
6140
+			if (is_array($value_arr) && count($value_arr) > 0)
6141 6141
 			{
6142 6142
 				foreach ($value_arr as $keyval=>$valueval) {
6143
-					$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$param['options'][$valueval].'</li>';
6143
+					$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$param['options'][$valueval].'</li>';
6144 6144
 				}
6145
-				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';
6145
+				$value = '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';
6146 6146
 			}
6147 6147
 		}
6148 6148
 		elseif ($type == 'chkbxlst')
@@ -6157,7 +6157,7 @@  discard block
 block discarded – undo
6157 6157
 
6158 6158
 			if (count($InfoFieldList) >= 3) {
6159 6159
 				$selectkey = $InfoFieldList[2];
6160
-				$keyList = $InfoFieldList[2] . ' as rowid';
6160
+				$keyList = $InfoFieldList[2].' as rowid';
6161 6161
 			}
6162 6162
 
6163 6163
 			$fields_label = explode('|', $InfoFieldList[1]);
@@ -6166,75 +6166,75 @@  discard block
 block discarded – undo
6166 6166
 				$keyList .= implode(', ', $fields_label);
6167 6167
 			}
6168 6168
 
6169
-			$sql = 'SELECT ' . $keyList;
6170
-			$sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];
6169
+			$sql = 'SELECT '.$keyList;
6170
+			$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];
6171 6171
 			if (strpos($InfoFieldList[4], 'extra') !== false) {
6172 6172
 				$sql .= ' as main';
6173 6173
 			}
6174 6174
 			// $sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";
6175 6175
 			// $sql.= ' AND entity = '.$conf->entity;
6176 6176
 
6177
-			dol_syslog(get_class($this) . ':showOutputField:$type=chkbxlst',LOG_DEBUG);
6177
+			dol_syslog(get_class($this).':showOutputField:$type=chkbxlst', LOG_DEBUG);
6178 6178
 			$resql = $this->db->query($sql);
6179 6179
 			if ($resql) {
6180 6180
 				$value = ''; // value was used, so now we reste it to use it to build final output
6181
-				$toprint=array();
6182
-				while ( $obj = $this->db->fetch_object($resql) ) {
6181
+				$toprint = array();
6182
+				while ($obj = $this->db->fetch_object($resql)) {
6183 6183
 
6184 6184
 					// Several field into label (eq table:code|libelle:rowid)
6185 6185
 					$fields_label = explode('|', $InfoFieldList[1]);
6186 6186
 					if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {
6187 6187
 						if (is_array($fields_label) && count($fields_label) > 1) {
6188
-							foreach ( $fields_label as $field_toshow ) {
6188
+							foreach ($fields_label as $field_toshow) {
6189 6189
 								$translabel = '';
6190
-								if (! empty($obj->$field_toshow)) {
6190
+								if (!empty($obj->$field_toshow)) {
6191 6191
 									$translabel = $langs->trans($obj->$field_toshow);
6192 6192
 								}
6193 6193
 								if ($translabel != $field_toshow) {
6194
-									$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';
6194
+									$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';
6195 6195
 								} else {
6196
-									$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->$field_toshow.'</li>';
6196
+									$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->$field_toshow.'</li>';
6197 6197
 								}
6198 6198
 							}
6199 6199
 						} else {
6200 6200
 							$translabel = '';
6201
-							if (! empty($obj->{$InfoFieldList[1]})) {
6201
+							if (!empty($obj->{$InfoFieldList[1]})) {
6202 6202
 								$translabel = $langs->trans($obj->{$InfoFieldList[1]});
6203 6203
 							}
6204 6204
 							if ($translabel != $obj->{$InfoFieldList[1]}) {
6205
-								$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';
6205
+								$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';
6206 6206
 							} else {
6207
-								$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->{$InfoFieldList[1]}.'</li>';
6207
+								$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->{$InfoFieldList[1]}.'</li>';
6208 6208
 							}
6209 6209
 						}
6210 6210
 					}
6211 6211
 				}
6212
-				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';
6212
+				$value = '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';
6213 6213
 			} else {
6214
-				dol_syslog(get_class($this) . '::showOutputField error ' . $this->db->lasterror(), LOG_WARNING);
6214
+				dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);
6215 6215
 			}
6216 6216
 		}
6217 6217
 		elseif ($type == 'link')
6218 6218
 		{
6219
-			$out='';
6219
+			$out = '';
6220 6220
 
6221 6221
 			// only if something to display (perf)
6222 6222
 			if ($value)
6223 6223
 			{
6224
-				$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'
6224
+				$param_list = array_keys($param['options']); // $param_list='ObjectName:classPath'
6225 6225
 
6226 6226
 				$InfoFieldList = explode(":", $param_list[0]);
6227
-				$classname=$InfoFieldList[0];
6228
-				$classpath=$InfoFieldList[1];
6229
-				$getnomurlparam=(empty($InfoFieldList[2]) ? 3 : $InfoFieldList[2]);
6230
-				if (! empty($classpath))
6227
+				$classname = $InfoFieldList[0];
6228
+				$classpath = $InfoFieldList[1];
6229
+				$getnomurlparam = (empty($InfoFieldList[2]) ? 3 : $InfoFieldList[2]);
6230
+				if (!empty($classpath))
6231 6231
 				{
6232 6232
 					dol_include_once($InfoFieldList[1]);
6233 6233
 					if ($classname && class_exists($classname))
6234 6234
 					{
6235 6235
 						$object = new $classname($this->db);
6236 6236
 						$object->fetch($value);
6237
-						$value=$object->getNomUrl($getnomurlparam);
6237
+						$value = $object->getNomUrl($getnomurlparam);
6238 6238
 					}
6239 6239
 				}
6240 6240
 				else
@@ -6243,15 +6243,15 @@  discard block
 block discarded – undo
6243 6243
 					return 'Error bad setup of extrafield';
6244 6244
 				}
6245 6245
 			}
6246
-			else $value='';
6246
+			else $value = '';
6247 6247
 		}
6248 6248
 		elseif ($type == 'text' || $type == 'html')
6249 6249
 		{
6250
-			$value=dol_htmlentitiesbr($value);
6250
+			$value = dol_htmlentitiesbr($value);
6251 6251
 		}
6252 6252
 		elseif ($type == 'password')
6253 6253
 		{
6254
-			$value=preg_replace('/./i','*',$value);
6254
+			$value = preg_replace('/./i', '*', $value);
6255 6255
 		}
6256 6256
 		elseif ($type == 'array')
6257 6257
 		{
@@ -6259,7 +6259,7 @@  discard block
 block discarded – undo
6259 6259
 		}
6260 6260
 
6261 6261
 		//print $type.'-'.$size;
6262
-		$out=$value;
6262
+		$out = $value;
6263 6263
 
6264 6264
 		return $out;
6265 6265
 	}
@@ -6276,11 +6276,11 @@  discard block
 block discarded – undo
6276 6276
 	 * @param	string		$onetrtd		All fields in same tr td
6277 6277
 	 * @return 	string
6278 6278
 	 */
6279
-	function showOptionals($extrafields, $mode='view', $params=null, $keysuffix='', $keyprefix='', $onetrtd=0)
6279
+	function showOptionals($extrafields, $mode = 'view', $params = null, $keysuffix = '', $keyprefix = '', $onetrtd = 0)
6280 6280
 	{
6281 6281
 		global $db, $conf, $langs, $action, $form;
6282 6282
 
6283
-		if (! is_object($form)) $form=new Form($db);
6283
+		if (!is_object($form)) $form = new Form($db);
6284 6284
 
6285 6285
 		$out = '';
6286 6286
 
@@ -6291,10 +6291,10 @@  discard block
 block discarded – undo
6291 6291
 			$out .= "\n";
6292 6292
 
6293 6293
 			$e = 0;
6294
-			foreach($extrafields->attributes[$this->table_element]['label'] as $key=>$label)
6294
+			foreach ($extrafields->attributes[$this->table_element]['label'] as $key=>$label)
6295 6295
 			{
6296 6296
 				// Show only the key field in params
6297
-				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) continue;
6297
+				if (is_array($params) && array_key_exists('onlykey', $params) && $key != $params['onlykey']) continue;
6298 6298
 
6299 6299
 				$enabled = 1;
6300 6300
 				if ($enabled && isset($extrafields->attributes[$this->table_element]['list'][$key]))
@@ -6308,25 +6308,25 @@  discard block
 block discarded – undo
6308 6308
 					$perms = dol_eval($extrafields->attributes[$this->table_element]['perms'][$key], 1);
6309 6309
 				}
6310 6310
 
6311
-				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue;	// <> -1 and <> 1 and <> 3 = not visible on forms, only on list
6311
+				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue; // <> -1 and <> 1 and <> 3 = not visible on forms, only on list
6312 6312
 				if (empty($perms)) continue;
6313 6313
 
6314 6314
 				// Load language if required
6315
-				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);
6315
+				if (!empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);
6316 6316
 
6317
-				$colspan='3';
6318
-				if (is_array($params) && count($params)>0) {
6319
-					if (array_key_exists('colspan',$params)) {
6320
-						$colspan=$params['colspan'];
6317
+				$colspan = '3';
6318
+				if (is_array($params) && count($params) > 0) {
6319
+					if (array_key_exists('colspan', $params)) {
6320
+						$colspan = $params['colspan'];
6321 6321
 					}
6322 6322
 				}
6323 6323
 
6324
-				switch($mode) {
6324
+				switch ($mode) {
6325 6325
 					case "view":
6326
-						$value=$this->array_options["options_".$key.$keysuffix];
6326
+						$value = $this->array_options["options_".$key.$keysuffix];
6327 6327
 						break;
6328 6328
 					case "edit":
6329
-						$getposttemp = GETPOST($keyprefix.'options_'.$key.$keysuffix, 'none');				// GETPOST can get value from GET, POST or setup of default values.
6329
+						$getposttemp = GETPOST($keyprefix.'options_'.$key.$keysuffix, 'none'); // GETPOST can get value from GET, POST or setup of default values.
6330 6330
 						// GETPOST("options_" . $key) can be 'abc' or array(0=>'abc')
6331 6331
 						if (is_array($getposttemp) || $getposttemp != '' || GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix))
6332 6332
 						{
@@ -6337,7 +6337,7 @@  discard block
 block discarded – undo
6337 6337
 								$value = $getposttemp;
6338 6338
 							}
6339 6339
 						} else {
6340
-							$value = $this->array_options["options_" . $key];			// No GET, no POST, no default value, so we take value of object.
6340
+							$value = $this->array_options["options_".$key]; // No GET, no POST, no default value, so we take value of object.
6341 6341
 						}
6342 6342
 						//var_dump($keyprefix.' - '.$key.' - '.$keysuffix.' - '.$keyprefix.'options_'.$key.$keysuffix.' - '.$this->array_options["options_".$key.$keysuffix].' - '.$getposttemp.' - '.$value);
6343 6343
 						break;
@@ -6349,11 +6349,11 @@  discard block
 block discarded – undo
6349 6349
 				}
6350 6350
 				else
6351 6351
 				{
6352
-					$csstyle='';
6353
-					$class=(!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');
6354
-					if (is_array($params) && count($params)>0) {
6355
-						if (array_key_exists('style',$params)) {
6356
-							$csstyle=$params['style'];
6352
+					$csstyle = '';
6353
+					$class = (!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');
6354
+					if (is_array($params) && count($params) > 0) {
6355
+						if (array_key_exists('style', $params)) {
6356
+							$csstyle = $params['style'];
6357 6357
 						}
6358 6358
 					}
6359 6359
 
@@ -6366,43 +6366,43 @@  discard block
 block discarded – undo
6366 6366
 
6367 6367
 					$out .= '<tr id="'.$html_id.'" '.$csstyle.' class="'.$class.$this->element.'_extras_'.$key.'" '.$domData.' >';
6368 6368
 
6369
-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0)
6369
+					if (!empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0)
6370 6370
 					{
6371
-						if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0) { $colspan='0'; }
6371
+						if (!empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0) { $colspan = '0'; }
6372 6372
 					}
6373 6373
 
6374 6374
 					if ($action == 'selectlines') { $colspan++; }
6375 6375
 
6376 6376
 					// Convert date into timestamp format (value in memory must be a timestamp)
6377
-					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('date','datetime')))
6377
+					if (in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date', 'datetime')))
6378 6378
 					{
6379
-						$datenotinstring = $this->array_options['options_' . $key];
6380
-						if (! is_numeric($this->array_options['options_' . $key]))	// For backward compatibility
6379
+						$datenotinstring = $this->array_options['options_'.$key];
6380
+						if (!is_numeric($this->array_options['options_'.$key]))	// For backward compatibility
6381 6381
 						{
6382 6382
 							$datenotinstring = $this->db->jdate($datenotinstring);
6383 6383
 						}
6384
-						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min",'int',3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year",'int',3)):$datenotinstring;
6384
+						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix) ?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min", 'int', 3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year", 'int', 3)) : $datenotinstring;
6385 6385
 					}
6386 6386
 					// Convert float submited string into real php numeric (value in memory must be a php numeric)
6387
-					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('price','double')))
6387
+					if (in_array($extrafields->attributes[$this->table_element]['type'][$key], array('price', 'double')))
6388 6388
 					{
6389
-						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?price2num(GETPOST($keyprefix.'options_'.$key.$keysuffix, 'alpha', 3)):$this->array_options['options_'.$key];
6389
+						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix) ?price2num(GETPOST($keyprefix.'options_'.$key.$keysuffix, 'alpha', 3)) : $this->array_options['options_'.$key];
6390 6390
 					}
6391 6391
 
6392 6392
 					$labeltoshow = $langs->trans($label);
6393 6393
 
6394 6394
 					$out .= '<td class="titlefield';
6395
-					if (GETPOST('action','none') == 'create') $out.='create';
6396
-					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';
6395
+					if (GETPOST('action', 'none') == 'create') $out .= 'create';
6396
+					if ($mode != 'view' && !empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';
6397 6397
 					$out .= '">';
6398
-					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);
6398
+					if (!empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);
6399 6399
 					else $out .= $labeltoshow;
6400 6400
 					$out .= '</td>';
6401 6401
 
6402 6402
 					$html_id = !empty($this->id) ? $this->element.'_extras_'.$key.'_'.$this->id : '';
6403
-					$out .='<td id="'.$html_id.'" class="'.$this->element.'_extras_'.$key.'" '.($colspan?' colspan="'.$colspan.'"':'').'>';
6403
+					$out .= '<td id="'.$html_id.'" class="'.$this->element.'_extras_'.$key.'" '.($colspan ? ' colspan="'.$colspan.'"' : '').'>';
6404 6404
 
6405
-					switch($mode) {
6405
+					switch ($mode) {
6406 6406
 						case "view":
6407 6407
 							$out .= $extrafields->showOutputField($key, $value);
6408 6408
 							break;
@@ -6413,14 +6413,14 @@  discard block
 block discarded – undo
6413 6413
 
6414 6414
 					$out .= '</td>';
6415 6415
 
6416
-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';
6416
+					if (!empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';
6417 6417
 					else $out .= '</tr>';
6418 6418
 					$e++;
6419 6419
 				}
6420 6420
 			}
6421 6421
 			$out .= "\n";
6422 6422
 			// Add code to manage list depending on others
6423
-			if (! empty($conf->use_javascript_ajax)) {
6423
+			if (!empty($conf->use_javascript_ajax)) {
6424 6424
 				$out .= '
6425 6425
 				<script type="text/javascript">
6426 6426
 				    jQuery(document).ready(function() {
@@ -6466,7 +6466,7 @@  discard block
 block discarded – undo
6466 6466
 		global $user;
6467 6467
 
6468 6468
 		$element = $this->element;
6469
-		if ($element == 'facturerec') $element='facture';
6469
+		if ($element == 'facturerec') $element = 'facture';
6470 6470
 
6471 6471
 		return $user->rights->{$element};
6472 6472
 	}
@@ -6483,15 +6483,15 @@  discard block
 block discarded – undo
6483 6483
 	 * @param  int         $ignoreerrors  Ignore errors. Return true even if errors. We need this when replacement can fails like for categories (categorie of old thirdparty may already exists on new one)
6484 6484
 	 * @return bool						  True if success, False if error
6485 6485
 	 */
6486
-	public static function commonReplaceThirdparty(DoliDB $db, $origin_id, $dest_id, array $tables, $ignoreerrors=0)
6486
+	public static function commonReplaceThirdparty(DoliDB $db, $origin_id, $dest_id, array $tables, $ignoreerrors = 0)
6487 6487
 	{
6488 6488
 		foreach ($tables as $table)
6489 6489
 		{
6490 6490
 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$table.' SET fk_soc = '.$dest_id.' WHERE fk_soc = '.$origin_id;
6491 6491
 
6492
-			if (! $db->query($sql))
6492
+			if (!$db->query($sql))
6493 6493
 			{
6494
-				if ($ignoreerrors) return true;		// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.
6494
+				if ($ignoreerrors) return true; // TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.
6495 6495
 				//$this->errors = $db->lasterror();
6496 6496
 				return false;
6497 6497
 			}
@@ -6525,7 +6525,7 @@  discard block
 block discarded – undo
6525 6525
 		else
6526 6526
 		{
6527 6527
 			// Get cost price for margin calculation
6528
-			if (! empty($fk_product))
6528
+			if (!empty($fk_product))
6529 6529
 			{
6530 6530
 				if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'costprice')
6531 6531
 				{
@@ -6562,7 +6562,7 @@  discard block
 block discarded – undo
6562 6562
 					}
6563 6563
 				}
6564 6564
 
6565
-				if (empty($buyPrice) && isset($conf->global->MARGIN_TYPE) && in_array($conf->global->MARGIN_TYPE, array('1','pmp','costprice')))
6565
+				if (empty($buyPrice) && isset($conf->global->MARGIN_TYPE) && in_array($conf->global->MARGIN_TYPE, array('1', 'pmp', 'costprice')))
6566 6566
 				{
6567 6567
 					require_once DOL_DOCUMENT_ROOT.'/fourn/class/fournisseur.product.class.php';
6568 6568
 					$productFournisseur = new ProductFournisseur($this->db);
@@ -6599,18 +6599,18 @@  discard block
 block discarded – undo
6599 6599
 	 *  @param		int		$usesharelink	Use the public shared link of image (if not available, the 'nophoto' image will be shown instead)
6600 6600
 	 *  @return     string					Html code to show photo. Number of photos shown is saved in this->nbphoto
6601 6601
 	 */
6602
-	function show_photos($modulepart, $sdir, $size=0, $nbmax=0, $nbbyrow=5, $showfilename=0, $showaction=0, $maxHeight=120, $maxWidth=160, $nolink=0, $notitle=0, $usesharelink=0)
6602
+	function show_photos($modulepart, $sdir, $size = 0, $nbmax = 0, $nbbyrow = 5, $showfilename = 0, $showaction = 0, $maxHeight = 120, $maxWidth = 160, $nolink = 0, $notitle = 0, $usesharelink = 0)
6603 6603
 	{
6604 6604
         // phpcs:enable
6605
-		global $conf,$user,$langs;
6605
+		global $conf, $user, $langs;
6606 6606
 
6607
-		include_once DOL_DOCUMENT_ROOT .'/core/lib/files.lib.php';
6608
-		include_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';
6607
+		include_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';
6608
+		include_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';
6609 6609
 
6610
-		$sortfield='position_name';
6611
-		$sortorder='asc';
6610
+		$sortfield = 'position_name';
6611
+		$sortorder = 'asc';
6612 6612
 
6613
-		$dir = $sdir . '/';
6613
+		$dir = $sdir.'/';
6614 6614
 		$pdir = '/';
6615 6615
 		if ($modulepart == 'ticket')
6616 6616
 		{
@@ -6624,28 +6624,28 @@  discard block
 block discarded – undo
6624 6624
 		}
6625 6625
 
6626 6626
 		// For backward compatibility
6627
-		if ($modulepart == 'product' && ! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))
6627
+		if ($modulepart == 'product' && !empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))
6628 6628
 		{
6629
-			$dir = $sdir . '/'. get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";
6630
-			$pdir = '/' . get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";
6629
+			$dir = $sdir.'/'.get_exdir($this->id, 2, 0, 0, $this, $modulepart).$this->id."/photos/";
6630
+			$pdir = '/'.get_exdir($this->id, 2, 0, 0, $this, $modulepart).$this->id."/photos/";
6631 6631
 		}
6632 6632
 
6633 6633
 		// Defined relative dir to DOL_DATA_ROOT
6634 6634
 		$relativedir = '';
6635 6635
 		if ($dir)
6636 6636
 		{
6637
-			$relativedir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $dir);
6638
-			$relativedir = preg_replace('/^[\\/]/','',$relativedir);
6639
-			$relativedir = preg_replace('/[\\/]$/','',$relativedir);
6637
+			$relativedir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT, '/').'/', '', $dir);
6638
+			$relativedir = preg_replace('/^[\\/]/', '', $relativedir);
6639
+			$relativedir = preg_replace('/[\\/]$/', '', $relativedir);
6640 6640
 		}
6641 6641
 
6642 6642
 		$dirthumb = $dir.'thumbs/';
6643 6643
 		$pdirthumb = $pdir.'thumbs/';
6644 6644
 
6645
-		$return ='<!-- Photo -->'."\n";
6646
-		$nbphoto=0;
6645
+		$return = '<!-- Photo -->'."\n";
6646
+		$nbphoto = 0;
6647 6647
 
6648
-		$filearray=dol_dir_list($dir,"files",0,'','(\.meta|_preview.*\.png)$',$sortfield,(strtolower($sortorder)=='desc'?SORT_DESC:SORT_ASC),1);
6648
+		$filearray = dol_dir_list($dir, "files", 0, '', '(\.meta|_preview.*\.png)$', $sortfield, (strtolower($sortorder) == 'desc' ?SORT_DESC:SORT_ASC), 1);
6649 6649
 
6650 6650
 		/*if (! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))    // For backward compatiblity, we scan also old dirs
6651 6651
 		 {
@@ -6659,12 +6659,12 @@  discard block
 block discarded – undo
6659 6659
 		{
6660 6660
 			if ($sortfield && $sortorder)
6661 6661
 			{
6662
-				$filearray=dol_sort_array($filearray, $sortfield, $sortorder);
6662
+				$filearray = dol_sort_array($filearray, $sortfield, $sortorder);
6663 6663
 			}
6664 6664
 
6665
-			foreach($filearray as $key => $val)
6665
+			foreach ($filearray as $key => $val)
6666 6666
 			{
6667
-				$photo='';
6667
+				$photo = '';
6668 6668
 				$file = $val['name'];
6669 6669
 
6670 6670
 				//if (! utf8_check($file)) $file=utf8_encode($file);	// To be sure file is stored in UTF8 in memory
@@ -6679,36 +6679,36 @@  discard block
 block discarded – undo
6679 6679
 					if ($size == 1 || $size == 'small') {   // Format vignette
6680 6680
 
6681 6681
 						// Find name of thumb file
6682
-						$photo_vignette=basename(getImageFileNameForSize($dir.$file, '_small'));
6683
-						if (! dol_is_file($dirthumb.$photo_vignette)) $photo_vignette='';
6682
+						$photo_vignette = basename(getImageFileNameForSize($dir.$file, '_small'));
6683
+						if (!dol_is_file($dirthumb.$photo_vignette)) $photo_vignette = '';
6684 6684
 
6685 6685
 						// Get filesize of original file
6686
-						$imgarray=dol_getImageSize($dir.$photo);
6686
+						$imgarray = dol_getImageSize($dir.$photo);
6687 6687
 
6688 6688
 						if ($nbbyrow > 0)
6689 6689
 						{
6690
-							if ($nbphoto == 1) $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';
6690
+							if ($nbphoto == 1) $return .= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';
6691 6691
 
6692
-							if ($nbphoto % $nbbyrow == 1) $return.= '<tr align=center valign=middle border=1>';
6693
-							$return.= '<td width="'.ceil(100/$nbbyrow).'%" class="photo">';
6692
+							if ($nbphoto % $nbbyrow == 1) $return .= '<tr align=center valign=middle border=1>';
6693
+							$return .= '<td width="'.ceil(100 / $nbbyrow).'%" class="photo">';
6694 6694
 						}
6695 6695
 						else if ($nbbyrow < 0) $return .= '<div class="inline-block">';
6696 6696
 
6697
-						$return.= "\n";
6697
+						$return .= "\n";
6698 6698
 
6699
-						$relativefile=preg_replace('/^\//', '', $pdir.$photo);
6699
+						$relativefile = preg_replace('/^\//', '', $pdir.$photo);
6700 6700
 						if (empty($nolink))
6701 6701
 						{
6702
-							$urladvanced=getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);
6703
-							if ($urladvanced) $return.='<a href="'.$urladvanced.'">';
6704
-							else $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';
6702
+							$urladvanced = getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);
6703
+							if ($urladvanced) $return .= '<a href="'.$urladvanced.'">';
6704
+							else $return .= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';
6705 6705
 						}
6706 6706
 
6707 6707
 						// Show image (width height=$maxHeight)
6708 6708
 						// Si fichier vignette disponible et image source trop grande, on utilise la vignette, sinon on utilise photo origine
6709
-						$alt=$langs->transnoentitiesnoconv('File').': '.$relativefile;
6710
-						$alt.=' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];
6711
-						if ($notitle) $alt='';
6709
+						$alt = $langs->transnoentitiesnoconv('File').': '.$relativefile;
6710
+						$alt .= ' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];
6711
+						if ($notitle) $alt = '';
6712 6712
 
6713 6713
 						if ($usesharelink)
6714 6714
 						{
@@ -6716,81 +6716,81 @@  discard block
 block discarded – undo
6716 6716
 							{
6717 6717
 								if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)
6718 6718
 								{
6719
-									$return.= '<!-- Show original file (thumb not yet available with shared links) -->';
6720
-									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';
6719
+									$return .= '<!-- Show original file (thumb not yet available with shared links) -->';
6720
+									$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';
6721 6721
 								}
6722 6722
 								else {
6723
-									$return.= '<!-- Show original file -->';
6724
-									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';
6723
+									$return .= '<!-- Show original file -->';
6724
+									$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';
6725 6725
 								}
6726 6726
 							}
6727 6727
 							else
6728 6728
 							{
6729
-								$return.= '<!-- Show nophoto file (because file is not shared) -->';
6730
-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';
6729
+								$return .= '<!-- Show nophoto file (because file is not shared) -->';
6730
+								$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';
6731 6731
 							}
6732 6732
 						}
6733 6733
 						else
6734 6734
 						{
6735 6735
 							if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)
6736 6736
 							{
6737
-								$return.= '<!-- Show thumb -->';
6738
-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';
6737
+								$return .= '<!-- Show thumb -->';
6738
+								$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';
6739 6739
 							}
6740 6740
 							else {
6741
-								$return.= '<!-- Show original file -->';
6742
-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';
6741
+								$return .= '<!-- Show original file -->';
6742
+								$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';
6743 6743
 							}
6744 6744
 						}
6745 6745
 
6746
-						if (empty($nolink)) $return.= '</a>';
6747
-						$return.="\n";
6746
+						if (empty($nolink)) $return .= '</a>';
6747
+						$return .= "\n";
6748 6748
 
6749
-						if ($showfilename) $return.= '<br>'.$viewfilename;
6749
+						if ($showfilename) $return .= '<br>'.$viewfilename;
6750 6750
 						if ($showaction)
6751 6751
 						{
6752
-							$return.= '<br>';
6752
+							$return .= '<br>';
6753 6753
 							// On propose la generation de la vignette si elle n'existe pas et si la taille est superieure aux limites
6754 6754
 							if ($photo_vignette && (image_format_supported($photo) > 0) && ($this->imgWidth > $maxWidth || $this->imgHeight > $maxHeight))
6755 6755
 							{
6756
-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=addthumb&amp;file='.urlencode($pdir.$viewfilename).'">'.img_picto($langs->trans('GenerateThumb'),'refresh').'&nbsp;&nbsp;</a>';
6756
+								$return .= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=addthumb&amp;file='.urlencode($pdir.$viewfilename).'">'.img_picto($langs->trans('GenerateThumb'), 'refresh').'&nbsp;&nbsp;</a>';
6757 6757
 							}
6758 6758
 							// Special cas for product
6759 6759
 							if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))
6760 6760
 							{
6761 6761
 								// Link to resize
6762
-								$return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';
6762
+								$return .= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';
6763 6763
 
6764 6764
 								// Link to delete
6765
-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';
6766
-								$return.= img_delete().'</a>';
6765
+								$return .= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';
6766
+								$return .= img_delete().'</a>';
6767 6767
 							}
6768 6768
 						}
6769
-						$return.= "\n";
6769
+						$return .= "\n";
6770 6770
 
6771 6771
 						if ($nbbyrow > 0)
6772 6772
 						{
6773
-							$return.= '</td>';
6774
-							if (($nbphoto % $nbbyrow) == 0) $return.= '</tr>';
6773
+							$return .= '</td>';
6774
+							if (($nbphoto % $nbbyrow) == 0) $return .= '</tr>';
6775 6775
 						}
6776
-						else if ($nbbyrow < 0) $return.='</div>';
6776
+						else if ($nbbyrow < 0) $return .= '</div>';
6777 6777
 					}
6778 6778
 
6779 6779
 					if (empty($size)) {     // Format origine
6780
-						$return.= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';
6780
+						$return .= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';
6781 6781
 
6782
-						if ($showfilename) $return.= '<br>'.$viewfilename;
6782
+						if ($showfilename) $return .= '<br>'.$viewfilename;
6783 6783
 						if ($showaction)
6784 6784
 						{
6785 6785
 							// Special case for product
6786 6786
 							if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))
6787 6787
 							{
6788 6788
 								// Link to resize
6789
-								$return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';
6789
+								$return .= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';
6790 6790
 
6791 6791
 								// Link to delete
6792
-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';
6793
-								$return.= img_delete().'</a>';
6792
+								$return .= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';
6793
+								$return .= img_delete().'</a>';
6794 6794
 							}
6795 6795
 						}
6796 6796
 					}
@@ -6800,18 +6800,18 @@  discard block
 block discarded – undo
6800 6800
 				}
6801 6801
 			}
6802 6802
 
6803
-			if ($size==1 || $size=='small')
6803
+			if ($size == 1 || $size == 'small')
6804 6804
 			{
6805 6805
 				if ($nbbyrow > 0)
6806 6806
 				{
6807 6807
 					// Ferme tableau
6808 6808
 					while ($nbphoto % $nbbyrow)
6809 6809
 					{
6810
-						$return.= '<td width="'.ceil(100/$nbbyrow).'%">&nbsp;</td>';
6810
+						$return .= '<td width="'.ceil(100 / $nbbyrow).'%">&nbsp;</td>';
6811 6811
 						$nbphoto++;
6812 6812
 					}
6813 6813
 
6814
-					if ($nbphoto) $return.= '</table>';
6814
+					if ($nbphoto) $return .= '</table>';
6815 6815
 				}
6816 6816
 			}
6817 6817
 		}
@@ -6830,9 +6830,9 @@  discard block
 block discarded – undo
6830 6830
 	 */
6831 6831
 	protected function isArray($info)
6832 6832
 	{
6833
-		if(is_array($info))
6833
+		if (is_array($info))
6834 6834
 		{
6835
-			if(isset($info['type']) && $info['type']=='array') return true;
6835
+			if (isset($info['type']) && $info['type'] == 'array') return true;
6836 6836
 			else return false;
6837 6837
 		}
6838 6838
 		else return false;
@@ -6846,9 +6846,9 @@  discard block
 block discarded – undo
6846 6846
 	 */
6847 6847
 	protected function isNull($info)
6848 6848
 	{
6849
-		if(is_array($info))
6849
+		if (is_array($info))
6850 6850
 		{
6851
-			if(isset($info['type']) && $info['type']=='null') return true;
6851
+			if (isset($info['type']) && $info['type'] == 'null') return true;
6852 6852
 			else return false;
6853 6853
 		}
6854 6854
 		else return false;
@@ -6862,7 +6862,7 @@  discard block
 block discarded – undo
6862 6862
 	 */
6863 6863
 	public function isDate($info)
6864 6864
 	{
6865
-		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) return true;
6865
+		if (isset($info['type']) && ($info['type'] == 'date' || $info['type'] == 'datetime' || $info['type'] == 'timestamp')) return true;
6866 6866
 		else return false;
6867 6867
 	}
6868 6868
 
@@ -6874,9 +6874,9 @@  discard block
 block discarded – undo
6874 6874
 	 */
6875 6875
 	public function isInt($info)
6876 6876
 	{
6877
-		if(is_array($info))
6877
+		if (is_array($info))
6878 6878
 		{
6879
-			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) return true;
6879
+			if (isset($info['type']) && ($info['type'] == 'int' || preg_match('/^integer/i', $info['type']))) return true;
6880 6880
 			else return false;
6881 6881
 		}
6882 6882
 		else return false;
@@ -6890,7 +6890,7 @@  discard block
 block discarded – undo
6890 6890
 	 */
6891 6891
 	public function isFloat($info)
6892 6892
 	{
6893
-		if(is_array($info))
6893
+		if (is_array($info))
6894 6894
 		{
6895 6895
 			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) return true;
6896 6896
 			else return false;
@@ -6906,9 +6906,9 @@  discard block
 block discarded – undo
6906 6906
 	 */
6907 6907
 	public function isText($info)
6908 6908
 	{
6909
-		if(is_array($info))
6909
+		if (is_array($info))
6910 6910
 		{
6911
-			if(isset($info['type']) && $info['type']=='text') return true;
6911
+			if (isset($info['type']) && $info['type'] == 'text') return true;
6912 6912
 			else return false;
6913 6913
 		}
6914 6914
 		else return false;
@@ -6922,9 +6922,9 @@  discard block
 block discarded – undo
6922 6922
 	 */
6923 6923
 	protected function isIndex($info)
6924 6924
 	{
6925
-		if(is_array($info))
6925
+		if (is_array($info))
6926 6926
 		{
6927
-			if(isset($info['index']) && $info['index']==true) return true;
6927
+			if (isset($info['index']) && $info['index'] == true) return true;
6928 6928
 			else return false;
6929 6929
 		}
6930 6930
 		else return false;
@@ -6940,13 +6940,13 @@  discard block
 block discarded – undo
6940 6940
 	{
6941 6941
 		global $conf;
6942 6942
 
6943
-		$queryarray=array();
6943
+		$queryarray = array();
6944 6944
 		foreach ($this->fields as $field=>$info)	// Loop on definition of fields
6945 6945
 		{
6946 6946
 			// Depending on field type ('datetime', ...)
6947
-			if($this->isDate($info))
6947
+			if ($this->isDate($info))
6948 6948
 			{
6949
-				if(empty($this->{$field}))
6949
+				if (empty($this->{$field}))
6950 6950
 				{
6951 6951
 					$queryarray[$field] = null;
6952 6952
 				}
@@ -6955,10 +6955,10 @@  discard block
 block discarded – undo
6955 6955
 					$queryarray[$field] = $this->db->idate($this->{$field});
6956 6956
 				}
6957 6957
 			}
6958
-			else if($this->isArray($info))
6958
+			else if ($this->isArray($info))
6959 6959
 			{
6960
-				if(! empty($this->{$field})) {
6961
-					if(! is_array($this->{$field})) {
6960
+				if (!empty($this->{$field})) {
6961
+					if (!is_array($this->{$field})) {
6962 6962
 						$this->{$field} = array($this->{$field});
6963 6963
 					}
6964 6964
 					$queryarray[$field] = serialize($this->{$field});
@@ -6966,19 +6966,19 @@  discard block
 block discarded – undo
6966 6966
 					$queryarray[$field] = null;
6967 6967
 				}
6968 6968
 			}
6969
-			else if($this->isInt($info))
6969
+			else if ($this->isInt($info))
6970 6970
 			{
6971
-				if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field]=$conf->entity;
6971
+				if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field] = $conf->entity;
6972 6972
 				else
6973 6973
 				{
6974 6974
 					$queryarray[$field] = (int) price2num($this->{$field});
6975
-					if (empty($queryarray[$field])) $queryarray[$field]=0;		// May be reset to null later if property 'notnull' is -1 for this field.
6975
+					if (empty($queryarray[$field])) $queryarray[$field] = 0; // May be reset to null later if property 'notnull' is -1 for this field.
6976 6976
 				}
6977 6977
 			}
6978
-			else if($this->isFloat($info))
6978
+			else if ($this->isFloat($info))
6979 6979
 			{
6980 6980
 				$queryarray[$field] = (double) price2num($this->{$field});
6981
-				if (empty($queryarray[$field])) $queryarray[$field]=0;
6981
+				if (empty($queryarray[$field])) $queryarray[$field] = 0;
6982 6982
 			}
6983 6983
 			else
6984 6984
 			{
@@ -6986,7 +6986,7 @@  discard block
 block discarded – undo
6986 6986
 			}
6987 6987
 
6988 6988
 			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) unset($queryarray[$field]);
6989
-			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;
6989
+			if (!empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;
6990 6990
 		}
6991 6991
 
6992 6992
 		return $queryarray;
@@ -7002,35 +7002,35 @@  discard block
 block discarded – undo
7002 7002
 	{
7003 7003
 		foreach ($this->fields as $field => $info)
7004 7004
 		{
7005
-			if($this->isDate($info))
7005
+			if ($this->isDate($info))
7006 7006
 			{
7007
-				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;
7007
+				if (empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;
7008 7008
 				else $this->{$field} = strtotime($obj->{$field});
7009 7009
 			}
7010
-			elseif($this->isArray($info))
7010
+			elseif ($this->isArray($info))
7011 7011
 			{
7012
-				if(! empty($obj->{$field})) {
7012
+				if (!empty($obj->{$field})) {
7013 7013
 					$this->{$field} = @unserialize($obj->{$field});
7014 7014
 					// Hack for data not in UTF8
7015
-					if($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));
7015
+					if ($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));
7016 7016
 				} else {
7017 7017
 					$this->{$field} = array();
7018 7018
 				}
7019 7019
 			}
7020
-			elseif($this->isInt($info))
7020
+			elseif ($this->isInt($info))
7021 7021
 			{
7022 7022
 				if ($field == 'rowid') $this->id = (int) $obj->{$field};
7023 7023
 				else $this->{$field} = (int) $obj->{$field};
7024 7024
 			}
7025
-			elseif($this->isFloat($info))
7025
+			elseif ($this->isFloat($info))
7026 7026
 			{
7027 7027
 				$this->{$field} = (double) $obj->{$field};
7028 7028
 			}
7029
-			elseif($this->isNull($info))
7029
+			elseif ($this->isNull($info))
7030 7030
 			{
7031 7031
 				$val = $obj->{$field};
7032 7032
 				// zero is not null
7033
-				$this->{$field} = (is_null($val) || (empty($val) && $val!==0 && $val!=='0') ? null : $val);
7033
+				$this->{$field} = (is_null($val) || (empty($val) && $val !== 0 && $val !== '0') ? null : $val);
7034 7034
 			}
7035 7035
 			else
7036 7036
 			{
@@ -7039,7 +7039,7 @@  discard block
 block discarded – undo
7039 7039
 		}
7040 7040
 
7041 7041
 		// If there is no 'ref' field, we force property ->ref to ->id for a better compatibility with common functions.
7042
-		if (! isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;
7042
+		if (!isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;
7043 7043
 	}
7044 7044
 
7045 7045
 	/**
@@ -7081,14 +7081,14 @@  discard block
 block discarded – undo
7081 7081
 
7082 7082
 		$error = 0;
7083 7083
 
7084
-		$now=dol_now();
7084
+		$now = dol_now();
7085 7085
 
7086 7086
 		$fieldvalues = $this->setSaveQuery();
7087
-		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation']=$this->db->idate($now);
7088
-		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat']=$user->id;
7089
-		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.
7087
+		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation'] = $this->db->idate($now);
7088
+		if (array_key_exists('fk_user_creat', $fieldvalues) && !($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat'] = $user->id;
7089
+		unset($fieldvalues['rowid']); // The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.
7090 7090
 
7091
-		$keys=array();
7091
+		$keys = array();
7092 7092
 		$values = array();
7093 7093
 		foreach ($fieldvalues as $k => $v) {
7094 7094
 			$keys[$k] = $k;
@@ -7097,58 +7097,58 @@  discard block
 block discarded – undo
7097 7097
 		}
7098 7098
 
7099 7099
 		// Clean and check mandatory
7100
-		foreach($keys as $key)
7100
+		foreach ($keys as $key)
7101 7101
 		{
7102 7102
 			// If field is an implicit foreign key field
7103
-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';
7104
-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';
7103
+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key] = '';
7104
+			if (!empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key] = '';
7105 7105
 
7106 7106
 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));
7107
-			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && ! isset($values[$key]) && is_null($val['default']))
7107
+			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && !isset($values[$key]) && is_null($val['default']))
7108 7108
 			{
7109 7109
 				$error++;
7110
-				$this->errors[]=$langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);
7110
+				$this->errors[] = $langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);
7111 7111
 			}
7112 7112
 
7113 7113
 			// If field is an implicit foreign key field
7114
-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key]='null';
7115
-			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key]='null';
7114
+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key] = 'null';
7115
+			if (!empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key] = 'null';
7116 7116
 		}
7117 7117
 
7118 7118
 		if ($error) return -1;
7119 7119
 
7120 7120
 		$this->db->begin();
7121 7121
 
7122
-		if (! $error)
7122
+		if (!$error)
7123 7123
 		{
7124 7124
 			$sql = 'INSERT INTO '.MAIN_DB_PREFIX.$this->table_element;
7125
-			$sql.= ' ('.implode( ", ", $keys ).')';
7126
-			$sql.= ' VALUES ('.implode( ", ", $values ).')';
7125
+			$sql .= ' ('.implode(", ", $keys).')';
7126
+			$sql .= ' VALUES ('.implode(", ", $values).')';
7127 7127
 
7128 7128
 			$res = $this->db->query($sql);
7129
-			if ($res===false) {
7129
+			if ($res === false) {
7130 7130
 				$error++;
7131 7131
 				$this->errors[] = $this->db->lasterror();
7132 7132
 			}
7133 7133
 		}
7134 7134
 
7135
-		if (! $error)
7135
+		if (!$error)
7136 7136
 		{
7137
-			$this->id = $this->db->last_insert_id(MAIN_DB_PREFIX . $this->table_element);
7137
+			$this->id = $this->db->last_insert_id(MAIN_DB_PREFIX.$this->table_element);
7138 7138
 		}
7139 7139
 
7140 7140
 		// Create extrafields
7141
-		if (! $error)
7141
+		if (!$error)
7142 7142
 		{
7143
-			$result=$this->insertExtraFields();
7143
+			$result = $this->insertExtraFields();
7144 7144
 			if ($result < 0) $error++;
7145 7145
 		}
7146 7146
 
7147 7147
 		// Triggers
7148
-		if (! $error && ! $notrigger)
7148
+		if (!$error && !$notrigger)
7149 7149
 		{
7150 7150
 			// Call triggers
7151
-			$result=$this->call_trigger(strtoupper(get_class($this)).'_CREATE',$user);
7151
+			$result = $this->call_trigger(strtoupper(get_class($this)).'_CREATE', $user);
7152 7152
 			if ($result < 0) { $error++; }
7153 7153
 			// End call triggers
7154 7154
 		}
@@ -7177,13 +7177,13 @@  discard block
 block discarded – undo
7177 7177
 		if (empty($id) && empty($ref) && empty($morewhere)) return -1;
7178 7178
 
7179 7179
 		$sql = 'SELECT '.$this->getFieldList();
7180
-		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element;
7180
+		$sql .= ' FROM '.MAIN_DB_PREFIX.$this->table_element;
7181 7181
 
7182
-		if (!empty($id))  $sql.= ' WHERE rowid = '.$id;
7183
-		elseif (!empty($ref)) $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);
7184
-		else $sql.=' WHERE 1 = 1';	// usage with empty id and empty ref is very rare
7185
-		if ($morewhere)   $sql.= $morewhere;
7186
-		$sql.=' LIMIT 1';	// This is a fetch, to be sure to get only one record
7182
+		if (!empty($id))  $sql .= ' WHERE rowid = '.$id;
7183
+		elseif (!empty($ref)) $sql .= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);
7184
+		else $sql .= ' WHERE 1 = 1'; // usage with empty id and empty ref is very rare
7185
+		if ($morewhere)   $sql .= $morewhere;
7186
+		$sql .= ' LIMIT 1'; // This is a fetch, to be sure to get only one record
7187 7187
 
7188 7188
 		$res = $this->db->query($sql);
7189 7189
 		if ($res)
@@ -7220,14 +7220,14 @@  discard block
 block discarded – undo
7220 7220
 
7221 7221
 		$error = 0;
7222 7222
 
7223
-		$now=dol_now();
7223
+		$now = dol_now();
7224 7224
 
7225 7225
 		$fieldvalues = $this->setSaveQuery();
7226
-		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification']=$this->db->idate($now);
7227
-		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif']=$user->id;
7228
-		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.
7226
+		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification'] = $this->db->idate($now);
7227
+		if (array_key_exists('fk_user_modif', $fieldvalues) && !($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif'] = $user->id;
7228
+		unset($fieldvalues['rowid']); // The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.
7229 7229
 
7230
-		$keys=array();
7230
+		$keys = array();
7231 7231
 		$values = array();
7232 7232
 		foreach ($fieldvalues as $k => $v) {
7233 7233
 			$keys[$k] = $k;
@@ -7237,10 +7237,10 @@  discard block
 block discarded – undo
7237 7237
 		}
7238 7238
 
7239 7239
 		// Clean and check mandatory
7240
-		foreach($keys as $key)
7240
+		foreach ($keys as $key)
7241 7241
 		{
7242
-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';		// This is an implicit foreign key field
7243
-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';					// This is an explicit foreign key field
7242
+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key] = ''; // This is an implicit foreign key field
7243
+			if (!empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key] = ''; // This is an explicit foreign key field
7244 7244
 
7245 7245
 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));
7246 7246
 			/*
@@ -7251,13 +7251,13 @@  discard block
 block discarded – undo
7251 7251
 			}*/
7252 7252
 		}
7253 7253
 
7254
-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode( ',', $tmp ).' WHERE rowid='.$this->id ;
7254
+		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode(',', $tmp).' WHERE rowid='.$this->id;
7255 7255
 
7256 7256
 		$this->db->begin();
7257
-		if (! $error)
7257
+		if (!$error)
7258 7258
 		{
7259 7259
 			$res = $this->db->query($sql);
7260
-			if ($res===false)
7260
+			if ($res === false)
7261 7261
 			{
7262 7262
 				$error++;
7263 7263
 				$this->errors[] = $this->db->lasterror();
@@ -7265,9 +7265,9 @@  discard block
 block discarded – undo
7265 7265
 		}
7266 7266
 
7267 7267
 		// Update extrafield
7268
-		if (! $error && empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && is_array($this->array_options) && count($this->array_options)>0)
7268
+		if (!$error && empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && is_array($this->array_options) && count($this->array_options) > 0)
7269 7269
 		{
7270
-			$result=$this->insertExtraFields();
7270
+			$result = $this->insertExtraFields();
7271 7271
 			if ($result < 0)
7272 7272
 			{
7273 7273
 				$error++;
@@ -7275,10 +7275,10 @@  discard block
 block discarded – undo
7275 7275
 		}
7276 7276
 
7277 7277
 		// Triggers
7278
-		if (! $error && ! $notrigger)
7278
+		if (!$error && !$notrigger)
7279 7279
 		{
7280 7280
 			// Call triggers
7281
-			$result=$this->call_trigger(strtoupper(get_class($this)).'_MODIFY',$user);
7281
+			$result = $this->call_trigger(strtoupper(get_class($this)).'_MODIFY', $user);
7282 7282
 			if ($result < 0) { $error++; } //Do also here what you must do to rollback action if trigger fail
7283 7283
 			// End call triggers
7284 7284
 		}
@@ -7301,68 +7301,68 @@  discard block
 block discarded – undo
7301 7301
 	 * @param	int		$forcechilddeletion		0=no, 1=Force deletion of children
7302 7302
 	 * @return 	int             				<=0 if KO, >0 if OK
7303 7303
 	 */
7304
-	public function deleteCommon(User $user, $notrigger=false, $forcechilddeletion=0)
7304
+	public function deleteCommon(User $user, $notrigger = false, $forcechilddeletion = 0)
7305 7305
 	{
7306
-		$error=0;
7306
+		$error = 0;
7307 7307
 
7308 7308
 		$this->db->begin();
7309 7309
 
7310 7310
 		if ($forcechilddeletion)
7311 7311
 		{
7312
-			foreach($this->childtables as $table)
7312
+			foreach ($this->childtables as $table)
7313 7313
 			{
7314 7314
 				$sql = 'DELETE FROM '.MAIN_DB_PREFIX.$table.' WHERE '.$this->fk_element.' = '.$this->id;
7315 7315
 				$resql = $this->db->query($sql);
7316
-				if (! $resql)
7316
+				if (!$resql)
7317 7317
 				{
7318
-					$this->error=$this->db->lasterror();
7319
-					$this->errors[]=$this->error;
7318
+					$this->error = $this->db->lasterror();
7319
+					$this->errors[] = $this->error;
7320 7320
 					$this->db->rollback();
7321 7321
 					return -1;
7322 7322
 				}
7323 7323
 			}
7324 7324
 		}
7325
-		elseif (! empty($this->fk_element) && ! empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.
7325
+		elseif (!empty($this->fk_element) && !empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.
7326 7326
 		{
7327 7327
 			$objectisused = $this->isObjectUsed($this->id);
7328
-			if (! empty($objectisused))
7328
+			if (!empty($objectisused))
7329 7329
 			{
7330 7330
 				dol_syslog(get_class($this)."::deleteCommon Can't delete record as it has some child", LOG_WARNING);
7331
-				$this->error='ErrorRecordHasChildren';
7332
-				$this->errors[]=$this->error;
7331
+				$this->error = 'ErrorRecordHasChildren';
7332
+				$this->errors[] = $this->error;
7333 7333
 				$this->db->rollback();
7334 7334
 				return 0;
7335 7335
 			}
7336 7336
 		}
7337 7337
 
7338
-		if (! $error) {
7339
-			if (! $notrigger) {
7338
+		if (!$error) {
7339
+			if (!$notrigger) {
7340 7340
 				// Call triggers
7341
-				$result=$this->call_trigger(strtoupper(get_class($this)).'_DELETE', $user);
7341
+				$result = $this->call_trigger(strtoupper(get_class($this)).'_DELETE', $user);
7342 7342
 				if ($result < 0) { $error++; } // Do also here what you must do to rollback action if trigger fail
7343 7343
 				// End call triggers
7344 7344
 			}
7345 7345
 		}
7346 7346
 
7347
-		if (! $error && ! empty($this->isextrafieldmanaged))
7347
+		if (!$error && !empty($this->isextrafieldmanaged))
7348 7348
 		{
7349
-			$sql = "DELETE FROM " . MAIN_DB_PREFIX . $this->table_element."_extrafields";
7350
-			$sql.= " WHERE fk_object=" . $this->id;
7349
+			$sql = "DELETE FROM ".MAIN_DB_PREFIX.$this->table_element."_extrafields";
7350
+			$sql .= " WHERE fk_object=".$this->id;
7351 7351
 
7352 7352
 			$resql = $this->db->query($sql);
7353
-			if (! $resql)
7353
+			if (!$resql)
7354 7354
 			{
7355 7355
 				$this->errors[] = $this->db->lasterror();
7356 7356
 				$error++;
7357 7357
 			}
7358 7358
 		}
7359 7359
 
7360
-		if (! $error)
7360
+		if (!$error)
7361 7361
 		{
7362 7362
 			$sql = 'DELETE FROM '.MAIN_DB_PREFIX.$this->table_element.' WHERE rowid='.$this->id;
7363 7363
 
7364 7364
 			$res = $this->db->query($sql);
7365
-			if($res===false) {
7365
+			if ($res === false) {
7366 7366
 				$error++;
7367 7367
 				$this->errors[] = $this->db->lasterror();
7368 7368
 			}
@@ -7403,9 +7403,9 @@  discard block
 block discarded – undo
7403 7403
 		require_once DOL_DOCUMENT_ROOT.'/core/class/comment.class.php';
7404 7404
 
7405 7405
 		$comment = new Comment($this->db);
7406
-		$result=$comment->fetchAllFor($this->element, $this->id);
7407
-		if ($result<0) {
7408
-			$this->errors=array_merge($this->errors, $comment->errors);
7406
+		$result = $comment->fetchAllFor($this->element, $this->id);
7407
+		if ($result < 0) {
7408
+			$this->errors = array_merge($this->errors, $comment->errors);
7409 7409
 			return -1;
7410 7410
 		} else {
7411 7411
 			$this->comments = $comment->comments;
Please login to merge, or discard this patch.
dolibarr/htdocs/core/class/dolgraph.class.php 1 patch
Spacing   +198 added lines, -198 removed lines patch added patch discarded remove patch
@@ -39,48 +39,48 @@  discard block
 block discarded – undo
39 39
  */
40 40
 class DolGraph
41 41
 {
42
-	public $type=array();			// Array with type of each series. Example: array('bars', 'lines', ...)
43
-	public $mode='side';		    // Mode bars graph: side, depth
44
-	private $_library='jflot';	// Graphic library to use (jflot, artichow)
42
+	public $type = array(); // Array with type of each series. Example: array('bars', 'lines', ...)
43
+	public $mode = 'side'; // Mode bars graph: side, depth
44
+	private $_library = 'jflot'; // Graphic library to use (jflot, artichow)
45 45
 
46 46
 	//! Array of data
47
-	public $data;				// Data of graph: array(array('abs1',valA1,valB1), array('abs2',valA2,valB2), ...)
48
-	public $title;				// Title of graph
49
-	public $cssprefix='';		// To add into css styles
50
-	public $width=380;
51
-	public $height=200;
52
-	public $MaxValue=0;
53
-	public $MinValue=0;
54
-	public $SetShading=0;
55
-
56
-	public $PrecisionY=-1;
57
-
58
-	public $horizTickIncrement=-1;
59
-	public $SetNumXTicks=-1;
60
-	public $labelInterval=-1;
61
-
62
-	public $hideXGrid=false;
63
-	public $hideYGrid=false;
64
-
65
-	public $Legend=array();
66
-	public $LegendWidthMin=0;
67
-	public $showlegend=1;
68
-	public $showpointvalue=1;
69
-	public $showpercent=0;
70
-	public $combine=0;				// 0.05 if you want to combine records < 5% into "other"
71
-	public $graph;     			// Objet Graph (Artichow, Phplot...)
47
+	public $data; // Data of graph: array(array('abs1',valA1,valB1), array('abs2',valA2,valB2), ...)
48
+	public $title; // Title of graph
49
+	public $cssprefix = ''; // To add into css styles
50
+	public $width = 380;
51
+	public $height = 200;
52
+	public $MaxValue = 0;
53
+	public $MinValue = 0;
54
+	public $SetShading = 0;
55
+
56
+	public $PrecisionY = -1;
57
+
58
+	public $horizTickIncrement = -1;
59
+	public $SetNumXTicks = -1;
60
+	public $labelInterval = -1;
61
+
62
+	public $hideXGrid = false;
63
+	public $hideYGrid = false;
64
+
65
+	public $Legend = array();
66
+	public $LegendWidthMin = 0;
67
+	public $showlegend = 1;
68
+	public $showpointvalue = 1;
69
+	public $showpercent = 0;
70
+	public $combine = 0; // 0.05 if you want to combine records < 5% into "other"
71
+	public $graph; // Objet Graph (Artichow, Phplot...)
72 72
 
73 73
 	/**
74 74
 	 * @var string Error code (or message)
75 75
 	 */
76
-	public $error='';
76
+	public $error = '';
77 77
 
78
-	public $bordercolor;			// array(R,G,B)
79
-	public $bgcolor;				// array(R,G,B)
80
-	public $bgcolorgrid=array(255,255,255);			// array(R,G,B)
81
-	public $datacolor;				// array(array(R,G,B),...)
78
+	public $bordercolor; // array(R,G,B)
79
+	public $bgcolor; // array(R,G,B)
80
+	public $bgcolorgrid = array(255, 255, 255); // array(R,G,B)
81
+	public $datacolor; // array(array(R,G,B),...)
82 82
 
83
-	private $stringtoshow;      // To store string to output graph into HTML page
83
+	private $stringtoshow; // To store string to output graph into HTML page
84 84
 
85 85
 
86 86
 	/**
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	 *
89 89
 	 * @param	string	$library		'jflot' (default) or 'artichow' (no more supported)
90 90
 	 */
91
-	function __construct($library='jflot')
91
+	function __construct($library = 'jflot')
92 92
 	{
93 93
 		global $conf;
94 94
 		global $theme_bordercolor, $theme_datacolor, $theme_bgcolor, $theme_bgcoloronglet;
@@ -96,25 +96,25 @@  discard block
 block discarded – undo
96 96
 		// To use old feature
97 97
 		if ($library == 'artichow')
98 98
 		{
99
-			$this->_library='artichow';
99
+			$this->_library = 'artichow';
100 100
 
101 101
 			// Test if module GD present
102 102
 			$modules_list = get_loaded_extensions();
103
-			$isgdinstalled=0;
103
+			$isgdinstalled = 0;
104 104
 			foreach ($modules_list as $module)
105 105
 			{
106
-				if ($module == 'gd') $isgdinstalled=1;
106
+				if ($module == 'gd') $isgdinstalled = 1;
107 107
 			}
108
-			if (! $isgdinstalled)
108
+			if (!$isgdinstalled)
109 109
 			{
110
-				$this->error="Error: PHP GD module is not available. It is required to build graphics.";
110
+				$this->error = "Error: PHP GD module is not available. It is required to build graphics.";
111 111
 				return -1;
112 112
 			}
113 113
 		}
114 114
 
115
-		$this->bordercolor = array(235,235,224);
116
-		$this->datacolor = array(array(120,130,150), array(160,160,180), array(190,190,220));
117
-		$this->bgcolor = array(235,235,224);
115
+		$this->bordercolor = array(235, 235, 224);
116
+		$this->datacolor = array(array(120, 130, 150), array(160, 160, 180), array(190, 190, 220));
117
+		$this->bgcolor = array(235, 235, 224);
118 118
 
119 119
 		$color_file = DOL_DOCUMENT_ROOT.'/theme/'.$conf->theme.'/graph-color.php';
120 120
 		if (is_readable($color_file))
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
 	 */
449 449
 	function setShowLegend($showlegend)
450 450
 	{
451
-		$this->showlegend=$showlegend;
451
+		$this->showlegend = $showlegend;
452 452
 	}
453 453
 
454 454
 	/**
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
 	 */
460 460
 	function setShowPointValue($showpointvalue)
461 461
 	{
462
-		$this->showpointvalue=$showpointvalue;
462
+		$this->showpointvalue = $showpointvalue;
463 463
 	}
464 464
 
465 465
 	/**
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
 	 */
471 471
 	function setShowPercent($showpercent)
472 472
 	{
473
-		$this->showpercent=$showpercent;
473
+		$this->showpercent = $showpercent;
474 474
 	}
475 475
 
476 476
 
@@ -482,12 +482,12 @@  discard block
 block discarded – undo
482 482
 	 * @param	array	$bg_color		array(R,G,B) ou 'onglet' ou 'default'
483 483
 	 * @return	void
484 484
 	 */
485
-	function SetBgColor($bg_color = array(255,255,255))
485
+	function SetBgColor($bg_color = array(255, 255, 255))
486 486
 	{
487 487
         // phpcs:enable
488
-		global $theme_bgcolor,$theme_bgcoloronglet;
488
+		global $theme_bgcolor, $theme_bgcoloronglet;
489 489
 
490
-		if (! is_array($bg_color))
490
+		if (!is_array($bg_color))
491 491
 		{
492 492
 			if ($bg_color == 'onglet')
493 493
 			{
@@ -512,12 +512,12 @@  discard block
 block discarded – undo
512 512
 	 * @param	array	$bg_colorgrid		array(R,G,B) ou 'onglet' ou 'default'
513 513
 	 * @return	void
514 514
 	 */
515
-	function SetBgColorGrid($bg_colorgrid = array(255,255,255))
515
+	function SetBgColorGrid($bg_colorgrid = array(255, 255, 255))
516 516
 	{
517 517
         // phpcs:enable
518
-		global $theme_bgcolor,$theme_bgcoloronglet;
518
+		global $theme_bgcolor, $theme_bgcoloronglet;
519 519
 
520
-		if (! is_array($bg_colorgrid))
520
+		if (!is_array($bg_colorgrid))
521 521
 		{
522 522
 			if ($bg_colorgrid == 'onglet')
523 523
 			{
@@ -562,11 +562,11 @@  discard block
 block discarded – undo
562 562
 		$nblines = count($this->data);
563 563
 		$nbvalues = count($this->data[0]) - 1;
564 564
 
565
-		for ($j = 0 ; $j < $nblines ; $j++)
565
+		for ($j = 0; $j < $nblines; $j++)
566 566
 		{
567
-			for ($i = 0 ; $i < $nbvalues ; $i++)
567
+			for ($i = 0; $i < $nbvalues; $i++)
568 568
 			{
569
-				$vals[$k] = $this->data[$j][$i+1];
569
+				$vals[$k] = $this->data[$j][$i + 1];
570 570
 				$k++;
571 571
 			}
572 572
 		}
@@ -589,11 +589,11 @@  discard block
 block discarded – undo
589 589
 		$nblines = count($this->data);
590 590
 		$nbvalues = count($this->data[0]) - 1;
591 591
 
592
-		for ($j = 0 ; $j < $nblines ; $j++)
592
+		for ($j = 0; $j < $nblines; $j++)
593 593
 		{
594
-			for ($i = 0 ; $i < $nbvalues ; $i++)
594
+			for ($i = 0; $i < $nbvalues; $i++)
595 595
 			{
596
-				$vals[$k] = $this->data[$j][$i+1];
596
+				$vals[$k] = $this->data[$j][$i + 1];
597 597
 				$k++;
598 598
 			}
599 599
 		}
@@ -612,15 +612,15 @@  discard block
 block discarded – undo
612 612
         // phpcs:enable
613 613
 		$max = $this->GetMaxValueInData();
614 614
 		if ($max != 0) $max++;
615
-		$size=dol_strlen(abs(ceil($max)));
616
-		$factor=1;
617
-		for ($i=0; $i < ($size-1); $i++)
615
+		$size = dol_strlen(abs(ceil($max)));
616
+		$factor = 1;
617
+		for ($i = 0; $i < ($size - 1); $i++)
618 618
 		{
619
-			$factor*=10;
619
+			$factor *= 10;
620 620
 		}
621 621
 
622
-		$res=0;
623
-		if (is_numeric($max)) $res=ceil($max/$factor)*$factor;
622
+		$res = 0;
623
+		if (is_numeric($max)) $res = ceil($max / $factor) * $factor;
624 624
 
625 625
 		//print "max=".$max." res=".$res;
626 626
 		return $res;
@@ -636,16 +636,16 @@  discard block
 block discarded – undo
636 636
 	{
637 637
         // phpcs:enable
638 638
 		$min = $this->GetMinValueInData();
639
-		if ($min == '') $min=0;
639
+		if ($min == '') $min = 0;
640 640
 		if ($min != 0) $min--;
641
-		$size=dol_strlen(abs(floor($min)));
642
-		$factor=1;
643
-		for ($i=0; $i < ($size-1); $i++)
641
+		$size = dol_strlen(abs(floor($min)));
642
+		$factor = 1;
643
+		for ($i = 0; $i < ($size - 1); $i++)
644 644
 		{
645
-			$factor*=10;
645
+			$factor *= 10;
646 646
 		}
647 647
 
648
-		$res=floor($min/$factor)*$factor;
648
+		$res = floor($min / $factor) * $factor;
649 649
 
650 650
 		//print "min=".$min." res=".$res;
651 651
 		return $res;
@@ -658,27 +658,27 @@  discard block
 block discarded – undo
658 658
 	 * @param	string	$fileurl	Url path to show image if saved onto disk
659 659
 	 * @return	integer|null
660 660
 	 */
661
-	function draw($file, $fileurl='')
661
+	function draw($file, $fileurl = '')
662 662
 	{
663 663
 		if (empty($file))
664 664
 		{
665
-			$this->error="Call to draw method was made with empty value for parameter file.";
665
+			$this->error = "Call to draw method was made with empty value for parameter file.";
666 666
 			dol_syslog(get_class($this)."::draw ".$this->error, LOG_ERR);
667 667
 			return -2;
668 668
 		}
669
-		if (! is_array($this->data))
669
+		if (!is_array($this->data))
670 670
 		{
671
-			$this->error="Call to draw method was made but SetData was not called or called with an empty dataset for parameters";
671
+			$this->error = "Call to draw method was made but SetData was not called or called with an empty dataset for parameters";
672 672
 			dol_syslog(get_class($this)."::draw ".$this->error, LOG_ERR);
673 673
 			return -1;
674 674
 		}
675 675
 		if (count($this->data) < 1)
676 676
 		{
677
-			$this->error="Call to draw method was made but SetData was is an empty dataset";
677
+			$this->error = "Call to draw method was made but SetData was is an empty dataset";
678 678
 			dol_syslog(get_class($this)."::draw ".$this->error, LOG_WARNING);
679 679
 		}
680 680
 		$call = "draw_".$this->_library;
681
-		call_user_func_array(array($this,$call), array($file,$fileurl));
681
+		call_user_func_array(array($this, $call), array($file, $fileurl));
682 682
 	}
683 683
 
684 684
 
@@ -690,31 +690,31 @@  discard block
 block discarded – undo
690 690
 	 * @param	string	$fileurl	Url path to show image if saved onto disk
691 691
 	 * @return	void
692 692
 	 */
693
-	private function draw_artichow($file,$fileurl)
693
+	private function draw_artichow($file, $fileurl)
694 694
 	{
695 695
         // phpcs:enable
696 696
 		global $artichow_defaultfont;
697 697
 
698
-		dol_syslog(get_class($this)."::draw_artichow this->type=".join(',',$this->type));
698
+		dol_syslog(get_class($this)."::draw_artichow this->type=".join(',', $this->type));
699 699
 
700
-		if (! defined('SHADOW_RIGHT_TOP'))  define('SHADOW_RIGHT_TOP',3);
701
-		if (! defined('LEGEND_BACKGROUND')) define('LEGEND_BACKGROUND',2);
702
-		if (! defined('LEGEND_LINE'))       define('LEGEND_LINE',1);
700
+		if (!defined('SHADOW_RIGHT_TOP'))  define('SHADOW_RIGHT_TOP', 3);
701
+		if (!defined('LEGEND_BACKGROUND')) define('LEGEND_BACKGROUND', 2);
702
+		if (!defined('LEGEND_LINE'))       define('LEGEND_LINE', 1);
703 703
 
704 704
 		// Create graph
705
-		$classname='';
706
-		if (! isset($this->type[0]) || $this->type[0] == 'bars')  $classname='BarPlot';    // Only one type (first one) is supported by artichow
707
-		else if ($this->type[0] == 'lines' || $this->type[0] == 'linesnopoint') $classname='LinePlot';
708
-		else $classname='TypeUnknown';
705
+		$classname = '';
706
+		if (!isset($this->type[0]) || $this->type[0] == 'bars')  $classname = 'BarPlot'; // Only one type (first one) is supported by artichow
707
+		else if ($this->type[0] == 'lines' || $this->type[0] == 'linesnopoint') $classname = 'LinePlot';
708
+		else $classname = 'TypeUnknown';
709 709
 		include_once ARTICHOW_PATH.$classname.'.class.php';
710 710
 
711 711
 		// Definition de couleurs
712
-		$bgcolor=new Color($this->bgcolor[0],$this->bgcolor[1],$this->bgcolor[2]);
713
-		$bgcolorgrid=new Color($this->bgcolorgrid[0],$this->bgcolorgrid[1],$this->bgcolorgrid[2]);
714
-		$colortrans=new Color(0,0,0,100);
715
-		$colorsemitrans=new Color(255,255,255,60);
716
-		$colorgradient= new LinearGradient(new Color(235, 235, 235),new Color(255, 255, 255),0);
717
-		$colorwhite=new Color(255,255,255);
712
+		$bgcolor = new Color($this->bgcolor[0], $this->bgcolor[1], $this->bgcolor[2]);
713
+		$bgcolorgrid = new Color($this->bgcolorgrid[0], $this->bgcolorgrid[1], $this->bgcolorgrid[2]);
714
+		$colortrans = new Color(0, 0, 0, 100);
715
+		$colorsemitrans = new Color(255, 255, 255, 60);
716
+		$colorgradient = new LinearGradient(new Color(235, 235, 235), new Color(255, 255, 255), 0);
717
+		$colorwhite = new Color(255, 255, 255);
718 718
 
719 719
 		// Graph
720 720
 		$graph = new Graph($this->width, $this->height);
@@ -733,13 +733,13 @@  discard block
 block discarded – undo
733 733
 		$group = new PlotGroup;
734 734
 		//$group->setSpace(5, 5, 0, 0);
735 735
 
736
-		$paddleft=50;
737
-		$paddright=10;
738
-		$strl=dol_strlen(max(abs($this->MaxValue),abs($this->MinValue)));
736
+		$paddleft = 50;
737
+		$paddright = 10;
738
+		$strl = dol_strlen(max(abs($this->MaxValue), abs($this->MinValue)));
739 739
 		if ($strl > 6) $paddleft += ($strl * 4);
740
-		$group->setPadding($paddleft, $paddright);		// Width on left and right for Y axis values
740
+		$group->setPadding($paddleft, $paddright); // Width on left and right for Y axis values
741 741
 		$group->legend->setSpace(0);
742
-		$group->legend->setPadding(2,2,2,2);
742
+		$group->legend->setPadding(2, 2, 2, 2);
743 743
 		$group->legend->setPosition(null, 0.1);
744 744
 		$group->legend->setBackgroundColor($colorsemitrans);
745 745
 
@@ -750,26 +750,26 @@  discard block
 block discarded – undo
750 750
 		if ($this->hideYGrid)	$group->grid->hideHorizontal(true);
751 751
 
752 752
 		// On boucle sur chaque lot de donnees
753
-		$legends=array();
754
-		$i=0;
755
-		$nblot=count($this->data[0])-1;
753
+		$legends = array();
754
+		$i = 0;
755
+		$nblot = count($this->data[0]) - 1;
756 756
 
757 757
 		while ($i < $nblot)
758 758
 		{
759
-			$x=0;
760
-			$values=array();
761
-			foreach($this->data as $key => $valarray)
759
+			$x = 0;
760
+			$values = array();
761
+			foreach ($this->data as $key => $valarray)
762 762
 			{
763 763
 				$legends[$x] = $valarray[0];
764
-				$values[$x]  = $valarray[$i+1];
764
+				$values[$x]  = $valarray[$i + 1];
765 765
 				$x++;
766 766
 			}
767 767
 
768 768
 			// We fix unknown values to null
769
-			$newvalues=array();
770
-			foreach($values as $val)
769
+			$newvalues = array();
770
+			foreach ($values as $val)
771 771
 			{
772
-				$newvalues[]=(is_numeric($val) ? $val : null);
772
+				$newvalues[] = (is_numeric($val) ? $val : null);
773 773
 			}
774 774
 
775 775
 
@@ -779,14 +779,14 @@  discard block
 block discarded – undo
779 779
 				//print_r($values);
780 780
 				//print '<br>';
781 781
 
782
-				$color=new Color($this->datacolor[$i][0],$this->datacolor[$i][1],$this->datacolor[$i][2],20);
783
-				$colorbis=new Color(min($this->datacolor[$i][0]+50,255),min($this->datacolor[$i][1]+50,255),min($this->datacolor[$i][2]+50,255),50);
782
+				$color = new Color($this->datacolor[$i][0], $this->datacolor[$i][1], $this->datacolor[$i][2], 20);
783
+				$colorbis = new Color(min($this->datacolor[$i][0] + 50, 255), min($this->datacolor[$i][1] + 50, 255), min($this->datacolor[$i][2] + 50, 255), 50);
784 784
 
785
-				$colorgrey=new Color(100,100,100);
786
-				$colorborder=new Color($this->datacolor[$i][0],$this->datacolor[$i][1],$this->datacolor[$i][2]);
785
+				$colorgrey = new Color(100, 100, 100);
786
+				$colorborder = new Color($this->datacolor[$i][0], $this->datacolor[$i][1], $this->datacolor[$i][2]);
787 787
 
788
-				if ($this->mode == 'side')  $plot = new BarPlot($newvalues, $i+1, $nblot);
789
-				if ($this->mode == 'depth') $plot = new BarPlot($newvalues, 1, 1, ($nblot-$i-1)*5);
788
+				if ($this->mode == 'side')  $plot = new BarPlot($newvalues, $i + 1, $nblot);
789
+				if ($this->mode == 'depth') $plot = new BarPlot($newvalues, 1, 1, ($nblot - $i - 1) * 5);
790 790
 
791 791
 				$plot->barBorder->setColor($colorgrey);
792 792
 				//$plot->setBarColor($color);
@@ -811,9 +811,9 @@  discard block
 block discarded – undo
811 811
 
812 812
 			if ($this->type[0] == 'lines' || $this->type[0] == 'linesnopoint')
813 813
 			{
814
-				$color=new Color($this->datacolor[$i][0],$this->datacolor[$i][1],$this->datacolor[$i][2],20);
815
-				$colorbis=new Color(min($this->datacolor[$i][0]+20,255),min($this->datacolor[$i][1]+20,255),min($this->datacolor[$i][2]+20,255),60);
816
-				$colorter=new Color(min($this->datacolor[$i][0]+50,255),min($this->datacolor[$i][1]+50,255),min($this->datacolor[$i][2]+50,255),90);
814
+				$color = new Color($this->datacolor[$i][0], $this->datacolor[$i][1], $this->datacolor[$i][2], 20);
815
+				$colorbis = new Color(min($this->datacolor[$i][0] + 20, 255), min($this->datacolor[$i][1] + 20, 255), min($this->datacolor[$i][2] + 20, 255), 60);
816
+				$colorter = new Color(min($this->datacolor[$i][0] + 50, 255), min($this->datacolor[$i][1] + 50, 255), min($this->datacolor[$i][2] + 50, 255), 90);
817 817
 
818 818
 				$plot = new LinePlot($newvalues);
819 819
 				//$plot->setSize(1, 0.96);
@@ -859,7 +859,7 @@  discard block
 block discarded – undo
859 859
 		// Generate file
860 860
 		$graph->draw($file);
861 861
 
862
-		$this->stringtoshow='<!-- Build using '.$this->_library.' --><img src="'.$fileurl.'" title="'.dol_escape_htmltag($this->title?$this->title:$this->YLabel).'" alt="'.dol_escape_htmltag($this->title?$this->title:$this->YLabel).'">';
862
+		$this->stringtoshow = '<!-- Build using '.$this->_library.' --><img src="'.$fileurl.'" title="'.dol_escape_htmltag($this->title ? $this->title : $this->YLabel).'" alt="'.dol_escape_htmltag($this->title ? $this->title : $this->YLabel).'">';
863 863
 	}
864 864
 
865 865
 
@@ -885,7 +885,7 @@  discard block
 block discarded – undo
885 885
         // phpcs:enable
886 886
 		global $artichow_defaultfont;
887 887
 
888
-		dol_syslog(get_class($this)."::draw_jflot this->type=".join(',',$this->type)." this->MaxValue=".$this->MaxValue);
888
+		dol_syslog(get_class($this)."::draw_jflot this->type=".join(',', $this->type)." this->MaxValue=".$this->MaxValue);
889 889
 
890 890
 		if (empty($this->width) && empty($this->height))
891 891
 		{
@@ -893,87 +893,87 @@  discard block
 block discarded – undo
893 893
 			return;
894 894
 		}
895 895
 
896
-		$legends=array();
897
-		$nblot=count($this->data[0])-1;    // -1 to remove legend
896
+		$legends = array();
897
+		$nblot = count($this->data[0]) - 1; // -1 to remove legend
898 898
 		if ($nblot < 0) dol_syslog('Bad value for property ->data. Must be set by mydolgraph->SetData before calling mydolgrapgh->draw', LOG_WARNING);
899
-		$firstlot=0;
899
+		$firstlot = 0;
900 900
 		// Works with line but not with bars
901 901
 		//if ($nblot > 2) $firstlot = ($nblot - 2);        // We limit nblot to 2 because jflot can't manage more than 2 bars on same x
902 902
 
903
-		$i=$firstlot;
904
-		$serie=array();
903
+		$i = $firstlot;
904
+		$serie = array();
905 905
 		while ($i < $nblot)	// Loop on each serie
906 906
 		{
907
-			$values=array();	// Array with horizontal y values (specific values of a serie) for each abscisse x
908
-			$serie[$i]="var d".$i." = [];\n";
907
+			$values = array(); // Array with horizontal y values (specific values of a serie) for each abscisse x
908
+			$serie[$i] = "var d".$i." = [];\n";
909 909
 
910 910
 			// Fill array $values
911
-			$x=0;
912
-			foreach($this->data as $valarray)	// Loop on each x
911
+			$x = 0;
912
+			foreach ($this->data as $valarray)	// Loop on each x
913 913
 			{
914 914
 				$legends[$x] = $valarray[0];
915
-				$values[$x]  = (is_numeric($valarray[$i+1]) ? $valarray[$i+1] : null);
915
+				$values[$x]  = (is_numeric($valarray[$i + 1]) ? $valarray[$i + 1] : null);
916 916
 				$x++;
917 917
 			}
918 918
 
919 919
 			// TODO Avoid push by adding generated long array...
920 920
 			if (isset($this->type[$firstlot]) && $this->type[$firstlot] == 'pie')
921 921
 			{
922
-				foreach($values as $x => $y) {
923
-					if (isset($y)) $serie[$i].='d'.$i.'.push({"label":"'.dol_escape_js($legends[$x]).'", "data":'.$y.'});'."\n";
922
+				foreach ($values as $x => $y) {
923
+					if (isset($y)) $serie[$i] .= 'd'.$i.'.push({"label":"'.dol_escape_js($legends[$x]).'", "data":'.$y.'});'."\n";
924 924
 				}
925 925
 			}
926 926
 			else
927 927
 			{
928
-				foreach($values as $x => $y) {
929
-					if (isset($y)) $serie[$i].='d'.$i.'.push(['.$x.', '.$y.']);'."\n";
928
+				foreach ($values as $x => $y) {
929
+					if (isset($y)) $serie[$i] .= 'd'.$i.'.push(['.$x.', '.$y.']);'."\n";
930 930
 				}
931 931
 			}
932 932
 
933 933
 			unset($values);
934 934
 			$i++;
935 935
 		}
936
-		$tag=dol_escape_htmltag(dol_string_unaccent(dol_string_nospecial(basename($file),'_',array('-','.'))));
936
+		$tag = dol_escape_htmltag(dol_string_unaccent(dol_string_nospecial(basename($file), '_', array('-', '.'))));
937 937
 
938
-		$this->stringtoshow ='<!-- Build using '.$this->_library.' -->'."\n";
939
-		if (! empty($this->title)) $this->stringtoshow.='<div align="center" class="dolgraphtitle'.(empty($this->cssprefix)?'':' dolgraphtitle'.$this->cssprefix).'">'.$this->title.'</div>';
940
-		if (! empty($this->shownographyet))
938
+		$this->stringtoshow = '<!-- Build using '.$this->_library.' -->'."\n";
939
+		if (!empty($this->title)) $this->stringtoshow .= '<div align="center" class="dolgraphtitle'.(empty($this->cssprefix) ? '' : ' dolgraphtitle'.$this->cssprefix).'">'.$this->title.'</div>';
940
+		if (!empty($this->shownographyet))
941 941
 		{
942
-		  $this->stringtoshow.='<div style="width:'.$this->width.'px;height:'.$this->height.'px;" class="nographyet"></div>';
943
-		  $this->stringtoshow.='<div class="nographyettext">'.$langs->trans("NotEnoughDataYet").'</div>';
942
+		  $this->stringtoshow .= '<div style="width:'.$this->width.'px;height:'.$this->height.'px;" class="nographyet"></div>';
943
+		  $this->stringtoshow .= '<div class="nographyettext">'.$langs->trans("NotEnoughDataYet").'</div>';
944 944
 		  return;
945 945
 		}
946
-		$this->stringtoshow.='<div id="placeholder_'.$tag.'" style="width:'.$this->width.'px;height:'.$this->height.'px;" class="dolgraph'.(empty($this->cssprefix)?'':' dolgraph'.$this->cssprefix).'"></div>'."\n";
946
+		$this->stringtoshow .= '<div id="placeholder_'.$tag.'" style="width:'.$this->width.'px;height:'.$this->height.'px;" class="dolgraph'.(empty($this->cssprefix) ? '' : ' dolgraph'.$this->cssprefix).'"></div>'."\n";
947 947
 
948
-		$this->stringtoshow.='<script id="'.$tag.'">'."\n";
949
-		$this->stringtoshow.='$(function () {'."\n";
950
-		$i=$firstlot;
948
+		$this->stringtoshow .= '<script id="'.$tag.'">'."\n";
949
+		$this->stringtoshow .= '$(function () {'."\n";
950
+		$i = $firstlot;
951 951
 		if ($nblot < 0)
952 952
 		{
953
-			$this->stringtoshow.='<!-- No series of data -->';
953
+			$this->stringtoshow .= '<!-- No series of data -->';
954 954
 		}
955 955
 		else
956 956
 		{
957 957
 			while ($i < $nblot)
958 958
 			{
959
-				$this->stringtoshow.=$serie[$i];
959
+				$this->stringtoshow .= $serie[$i];
960 960
 				$i++;
961 961
 			}
962 962
 		}
963
-		$this->stringtoshow.="\n";
963
+		$this->stringtoshow .= "\n";
964 964
 
965 965
 		// Special case for Graph of type 'pie'
966 966
 		if (isset($this->type[$firstlot]) && $this->type[$firstlot] == 'pie')
967 967
 		{
968
-			$datacolor=array();
969
-			foreach($this->datacolor as $val) $datacolor[]="#".sprintf("%02x%02x%02x",$val[0],$val[1],$val[2]);
968
+			$datacolor = array();
969
+			foreach ($this->datacolor as $val) $datacolor[] = "#".sprintf("%02x%02x%02x", $val[0], $val[1], $val[2]);
970 970
 
971
-			$urltemp='';	// TODO Add support for url link into labels
972
-			$showlegend=$this->showlegend;
973
-			$showpointvalue=$this->showpointvalue;
974
-			$showpercent=$this->showpercent;
971
+			$urltemp = ''; // TODO Add support for url link into labels
972
+			$showlegend = $this->showlegend;
973
+			$showpointvalue = $this->showpointvalue;
974
+			$showpercent = $this->showpercent;
975 975
 
976
-			$this->stringtoshow.= '
976
+			$this->stringtoshow .= '
977 977
 			function plotWithOptions_'.$tag.'() {
978 978
 			$.plot($("#placeholder_'.$tag.'"), d0,
979 979
 			{
@@ -984,7 +984,7 @@  discard block
 block discarded – undo
984 984
 						'.($this->combine ? '
985 985
 						combine: {
986 986
 						 	threshold: '.$this->combine.'
987
-						},' : '') . '
987
+						},' : '').'
988 988
 						label: {
989 989
 							show: true,
990 990
 							radius: 0.9,
@@ -992,15 +992,15 @@  discard block
 block discarded – undo
992 992
 								var percent=Math.round(series.percent);
993 993
 								var number=series.data[0][1];
994 994
 								return \'';
995
-								$this->stringtoshow.='<span style="font-size:8pt;text-align:center;padding:2px;color:black;">';
996
-								if ($urltemp) $this->stringtoshow.='<a style="color: #FFFFFF;" border="0" href="'.$urltemp.'">';
997
-								$this->stringtoshow.='\'+';
998
-								$this->stringtoshow.=($showlegend?'':'label+\' \'+');	// Hide label if already shown in legend
999
-								$this->stringtoshow.=($showpointvalue?'number+':'');
1000
-								$this->stringtoshow.=($showpercent?'\'<br/>\'+percent+\'%\'+':'');
1001
-								$this->stringtoshow.='\'';
1002
-								if ($urltemp) $this->stringtoshow.='</a>';
1003
-								$this->stringtoshow.='</span>\';
995
+								$this->stringtoshow .= '<span style="font-size:8pt;text-align:center;padding:2px;color:black;">';
996
+								if ($urltemp) $this->stringtoshow .= '<a style="color: #FFFFFF;" border="0" href="'.$urltemp.'">';
997
+								$this->stringtoshow .= '\'+';
998
+								$this->stringtoshow .= ($showlegend ? '' : 'label+\' \'+'); // Hide label if already shown in legend
999
+								$this->stringtoshow .= ($showpointvalue ? 'number+' : '');
1000
+								$this->stringtoshow .= ($showpercent ? '\'<br/>\'+percent+\'%\'+' : '');
1001
+								$this->stringtoshow .= '\'';
1002
+								if ($urltemp) $this->stringtoshow .= '</a>';
1003
+								$this->stringtoshow .= '</span>\';
1004 1004
 							},
1005 1005
 							background: {
1006 1006
 							opacity: 0.0,
@@ -1017,9 +1017,9 @@  discard block
 block discarded – undo
1017 1017
 			},';
1018 1018
 			if (count($datacolor))
1019 1019
 			{
1020
-				$this->stringtoshow.='colors: '.(! empty($data['seriescolor']) ? json_encode($data['seriescolor']) : json_encode($datacolor)).',';
1020
+				$this->stringtoshow .= 'colors: '.(!empty($data['seriescolor']) ? json_encode($data['seriescolor']) : json_encode($datacolor)).',';
1021 1021
 			}
1022
-			$this->stringtoshow.='legend: {show: '.($showlegend?'true':'false').', position: \'ne\' }
1022
+			$this->stringtoshow .= 'legend: {show: '.($showlegend ? 'true' : 'false').', position: \'ne\' }
1023 1023
 		});
1024 1024
 		}'."\n";
1025 1025
 		}
@@ -1028,7 +1028,7 @@  discard block
 block discarded – undo
1028 1028
 		{
1029 1029
 			// Add code to support tooltips
1030 1030
 		    // TODO: remove js css and use graph-tooltip-inner class instead by adding css in each themes
1031
-			$this->stringtoshow.='
1031
+			$this->stringtoshow .= '
1032 1032
 			function showTooltip_'.$tag.'(x, y, contents) {
1033 1033
 				$(\'<div class="graph-tooltip-inner" id="tooltip_'.$tag.'">\' + contents + \'</div>\').css({
1034 1034
 					position: \'absolute\',
@@ -1060,10 +1060,10 @@  discard block
 block discarded – undo
1060 1060
 						var y = item.datapoint[1].toFixed(2);
1061 1061
 						var z = item.series.xaxis.ticks[item.dataIndex].label;
1062 1062
 						';
1063
-						if ($this->showpointvalue > 0) $this->stringtoshow.='
1063
+						if ($this->showpointvalue > 0) $this->stringtoshow .= '
1064 1064
 							showTooltip_'.$tag.'(item.pageX, item.pageY, item.series.label + "<br>" + z + " => " + y);
1065 1065
 						';
1066
-						$this->stringtoshow.='
1066
+						$this->stringtoshow .= '
1067 1067
 					}
1068 1068
 				}
1069 1069
 				else {
@@ -1073,50 +1073,50 @@  discard block
 block discarded – undo
1073 1073
 			});
1074 1074
 			';
1075 1075
 
1076
-			$this->stringtoshow.='var stack = null, steps = false;'."\n";
1076
+			$this->stringtoshow .= 'var stack = null, steps = false;'."\n";
1077 1077
 
1078
-			$this->stringtoshow.='function plotWithOptions_'.$tag.'() {'."\n";
1079
-			$this->stringtoshow.='$.plot($("#placeholder_'.$tag.'"), [ '."\n";
1080
-			$i=$firstlot;
1078
+			$this->stringtoshow .= 'function plotWithOptions_'.$tag.'() {'."\n";
1079
+			$this->stringtoshow .= '$.plot($("#placeholder_'.$tag.'"), [ '."\n";
1080
+			$i = $firstlot;
1081 1081
 			while ($i < $nblot)
1082 1082
 			{
1083
-				if ($i > $firstlot) $this->stringtoshow.=', '."\n";
1084
-				$color=sprintf("%02x%02x%02x",$this->datacolor[$i][0],$this->datacolor[$i][1],$this->datacolor[$i][2]);
1085
-				$this->stringtoshow.='{ ';
1086
-				if (! isset($this->type[$i]) || $this->type[$i] == 'bars') $this->stringtoshow.='bars: { lineWidth: 1, show: true, align: "'.($i==$firstlot?'center':'left').'", barWidth: 0.5 }, ';
1087
-				if (isset($this->type[$i]) && ($this->type[$i] == 'lines' || $this->type[$i] == 'linesnopoint')) $this->stringtoshow.='lines: { show: true, fill: false }, points: { show: '.($this->type[$i] == 'linesnopoint' ? 'false' : 'true').' }, ';
1088
-				$this->stringtoshow.='color: "#'.$color.'", label: "'.(isset($this->Legend[$i]) ? dol_escape_js($this->Legend[$i]) : '').'", data: d'.$i.' }';
1083
+				if ($i > $firstlot) $this->stringtoshow .= ', '."\n";
1084
+				$color = sprintf("%02x%02x%02x", $this->datacolor[$i][0], $this->datacolor[$i][1], $this->datacolor[$i][2]);
1085
+				$this->stringtoshow .= '{ ';
1086
+				if (!isset($this->type[$i]) || $this->type[$i] == 'bars') $this->stringtoshow .= 'bars: { lineWidth: 1, show: true, align: "'.($i == $firstlot ? 'center' : 'left').'", barWidth: 0.5 }, ';
1087
+				if (isset($this->type[$i]) && ($this->type[$i] == 'lines' || $this->type[$i] == 'linesnopoint')) $this->stringtoshow .= 'lines: { show: true, fill: false }, points: { show: '.($this->type[$i] == 'linesnopoint' ? 'false' : 'true').' }, ';
1088
+				$this->stringtoshow .= 'color: "#'.$color.'", label: "'.(isset($this->Legend[$i]) ? dol_escape_js($this->Legend[$i]) : '').'", data: d'.$i.' }';
1089 1089
 				$i++;
1090 1090
 			}
1091 1091
 			// shadowSize: 0 -> Drawing is faster without shadows
1092
-			$this->stringtoshow.="\n".' ], { series: { shadowSize: 0, stack: stack, lines: { fill: false, steps: steps }, bars: { barWidth: 0.6 } }'."\n";
1092
+			$this->stringtoshow .= "\n".' ], { series: { shadowSize: 0, stack: stack, lines: { fill: false, steps: steps }, bars: { barWidth: 0.6 } }'."\n";
1093 1093
 
1094 1094
 			// Xaxis
1095
-			$this->stringtoshow.=', xaxis: { ticks: ['."\n";
1096
-			$x=0;
1097
-			foreach($this->data as $key => $valarray)
1095
+			$this->stringtoshow .= ', xaxis: { ticks: ['."\n";
1096
+			$x = 0;
1097
+			foreach ($this->data as $key => $valarray)
1098 1098
 			{
1099
-				if ($x > 0) $this->stringtoshow.=', '."\n";
1100
-				$this->stringtoshow.= ' ['.$x.', "'.$valarray[0].'"]';
1099
+				if ($x > 0) $this->stringtoshow .= ', '."\n";
1100
+				$this->stringtoshow .= ' ['.$x.', "'.$valarray[0].'"]';
1101 1101
 				$x++;
1102 1102
 			}
1103
-			$this->stringtoshow.='] }'."\n";
1103
+			$this->stringtoshow .= '] }'."\n";
1104 1104
 
1105 1105
 			// Yaxis
1106
-			$this->stringtoshow.=', yaxis: { min: '.$this->MinValue.', max: '.($this->MaxValue).' }'."\n";
1106
+			$this->stringtoshow .= ', yaxis: { min: '.$this->MinValue.', max: '.($this->MaxValue).' }'."\n";
1107 1107
 
1108 1108
 			// Background color
1109
-			$color1=sprintf("%02x%02x%02x",$this->bgcolorgrid[0],$this->bgcolorgrid[0],$this->bgcolorgrid[2]);
1110
-			$color2=sprintf("%02x%02x%02x",$this->bgcolorgrid[0],$this->bgcolorgrid[1],$this->bgcolorgrid[2]);
1111
-			$this->stringtoshow.=', grid: { hoverable: true, backgroundColor: { colors: ["#'.$color1.'", "#'.$color2.'"] }, borderWidth: 1, borderColor: \'#e6e6e6\', tickColor  : \'#e6e6e6\' }'."\n";
1109
+			$color1 = sprintf("%02x%02x%02x", $this->bgcolorgrid[0], $this->bgcolorgrid[0], $this->bgcolorgrid[2]);
1110
+			$color2 = sprintf("%02x%02x%02x", $this->bgcolorgrid[0], $this->bgcolorgrid[1], $this->bgcolorgrid[2]);
1111
+			$this->stringtoshow .= ', grid: { hoverable: true, backgroundColor: { colors: ["#'.$color1.'", "#'.$color2.'"] }, borderWidth: 1, borderColor: \'#e6e6e6\', tickColor  : \'#e6e6e6\' }'."\n";
1112 1112
 			//$this->stringtoshow.=', shadowSize: 20'."\n";    TODO Uncommet this
1113
-			$this->stringtoshow.='});'."\n";
1114
-			$this->stringtoshow.='}'."\n";
1113
+			$this->stringtoshow .= '});'."\n";
1114
+			$this->stringtoshow .= '}'."\n";
1115 1115
 		}
1116 1116
 
1117
-		$this->stringtoshow.='plotWithOptions_'.$tag.'();'."\n";
1118
-		$this->stringtoshow.='});'."\n";
1119
-		$this->stringtoshow.='</script>'."\n";
1117
+		$this->stringtoshow .= 'plotWithOptions_'.$tag.'();'."\n";
1118
+		$this->stringtoshow .= '});'."\n";
1119
+		$this->stringtoshow .= '</script>'."\n";
1120 1120
 	}
1121 1121
 
1122 1122
 
@@ -1127,14 +1127,14 @@  discard block
 block discarded – undo
1127 1127
 	 * @param	int			$shownographyet 	Show graph to say there is not enough data
1128 1128
 	 * @return	string							HTML string to show graph
1129 1129
 	 */
1130
-	function show($shownographyet=0)
1130
+	function show($shownographyet = 0)
1131 1131
 	{
1132 1132
 		global $langs;
1133 1133
 
1134 1134
 		if ($shownographyet)
1135 1135
 		{
1136
-			$s= '<div class="nographyet" style="width:'.(preg_match('/%/',$this->width)?$this->width:$this->width.'px').'; height:'.(preg_match('/%/',$this->height)?$this->height:$this->height.'px').';"></div>';
1137
-			$s.='<div class="nographyettext">'.$langs->trans("NotEnoughDataYet").'</div>';
1136
+			$s = '<div class="nographyet" style="width:'.(preg_match('/%/', $this->width) ? $this->width : $this->width.'px').'; height:'.(preg_match('/%/', $this->height) ? $this->height : $this->height.'px').';"></div>';
1137
+			$s .= '<div class="nographyettext">'.$langs->trans("NotEnoughDataYet").'</div>';
1138 1138
 			return $s;
1139 1139
 		}
1140 1140
 
@@ -1149,18 +1149,18 @@  discard block
 block discarded – undo
1149 1149
 	 * @param	string	$defaultsize	Value we want as default size
1150 1150
 	 * @return	int						Value of width or height to use by default
1151 1151
 	 */
1152
-	static function getDefaultGraphSizeForStats($direction,$defaultsize='')
1152
+	static function getDefaultGraphSizeForStats($direction, $defaultsize = '')
1153 1153
 	{
1154 1154
 		global $conf;
1155 1155
 
1156 1156
 		if ($direction == 'width')
1157 1157
 		{
1158 1158
 			if (empty($conf->dol_optimize_smallscreen)) return ($defaultsize ? $defaultsize : '500');
1159
-			else return (empty($_SESSION['dol_screen_width']) ? '280' : ($_SESSION['dol_screen_width']-40));
1159
+			else return (empty($_SESSION['dol_screen_width']) ? '280' : ($_SESSION['dol_screen_width'] - 40));
1160 1160
 		}
1161 1161
 		if ($direction == 'height')
1162 1162
 		{
1163
-			return (empty($conf->dol_optimize_smallscreen)?($defaultsize?$defaultsize:'200'):'160');
1163
+			return (empty($conf->dol_optimize_smallscreen) ? ($defaultsize ? $defaultsize : '200') : '160');
1164 1164
 		}
1165 1165
 		return 0;
1166 1166
 	}
Please login to merge, or discard this patch.