alxarafe / alixar

dolibarr/htdocs/core/actions_addupdatedelete.inc.php

Indentation +158 added lines, -158 removed lines

@@ -32,187 +32,187 @@
 
 if ($cancel)
 {
-	if (! empty($backtopage))
-	{
-		header("Location: ".$backtopage);
-		exit;
-	}
-	$action='';
+    if (! empty($backtopage))
+    {
+        header("Location: ".$backtopage);
+        exit;
+    }
+    $action='';
 }
 
 // Action to add record
 if ($action == 'add' && ! empty($permissiontoadd))
 {
-	foreach ($object->fields as $key => $val)
-	{
-		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
-
-		// Set value to insert
-		if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
-			$value = GETPOST($key,'none');
-		} elseif ($object->fields[$key]['type']=='date') {
-			$value = dol_mktime(12, 0, 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='datetime') {
-			$value = dol_mktime(GETPOST($key.'hour'), GETPOST($key.'min'), 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='price') {
-			$value = price2num(GETPOST($key));
-		} else {
-			$value = GETPOST($key,'alpha');
-		}
-		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
-		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
-
-		$object->$key=$value;
-		if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
-		{
-			$error++;
-			setEventMessages($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv($val['label'])), null, 'errors');
-		}
-	}
-
-	if (! $error)
-	{
-		$result=$object->create($user);
-		if ($result > 0)
-		{
-			// Creation OK
-			$urltogo=$backtopage?str_replace('__ID__', $result, $backtopage):$backurlforlist;
-			header("Location: ".$urltogo);
-			exit;
-		}
-		else
-		{
-			// Creation KO
-			if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
-			else  setEventMessages($object->error, null, 'errors');
-			$action='create';
-		}
-	}
-	else
-	{
-		$action='create';
-	}
+    foreach ($object->fields as $key => $val)
+    {
+        if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
+
+        // Set value to insert
+        if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
+            $value = GETPOST($key,'none');
+        } elseif ($object->fields[$key]['type']=='date') {
+            $value = dol_mktime(12, 0, 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
+        } elseif ($object->fields[$key]['type']=='datetime') {
+            $value = dol_mktime(GETPOST($key.'hour'), GETPOST($key.'min'), 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
+        } elseif ($object->fields[$key]['type']=='price') {
+            $value = price2num(GETPOST($key));
+        } else {
+            $value = GETPOST($key,'alpha');
+        }
+        if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
+        if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
+
+        $object->$key=$value;
+        if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
+        {
+            $error++;
+            setEventMessages($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv($val['label'])), null, 'errors');
+        }
+    }
+
+    if (! $error)
+    {
+        $result=$object->create($user);
+        if ($result > 0)
+        {
+            // Creation OK
+            $urltogo=$backtopage?str_replace('__ID__', $result, $backtopage):$backurlforlist;
+            header("Location: ".$urltogo);
+            exit;
+        }
+        else
+        {
+            // Creation KO
+            if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
+            else  setEventMessages($object->error, null, 'errors');
+            $action='create';
+        }
+    }
+    else
+    {
+        $action='create';
+    }
 }
 
 // Action to update record
 if ($action == 'update' && ! empty($permissiontoadd))
 {
-	foreach ($object->fields as $key => $val)
-	{
-		if (! GETPOSTISSET($key)) continue;		// The field was not submited to be edited
-		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
-
-		// Set value to update
-		if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
-			$value = GETPOST($key,'none');
-		} elseif ($object->fields[$key]['type']=='date') {
-			$value = dol_mktime(12, 0, 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='datetime') {
-			$value = dol_mktime(GETPOST($key.'hour'), GETPOST($key.'min'), 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='price') {
-			$value = price2num(GETPOST($key));
-		} else {
-			$value = GETPOST($key,'alpha');
-		}
-		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
-		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
-
-		$object->$key=$value;
-		if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
-		{
-			$error++;
-			setEventMessages($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv($val['label'])), null, 'errors');
-		}
-	}
-
-	if (! $error)
-	{
-		$result=$object->update($user);
-		if ($result > 0)
-		{
-			$action='view';
-		}
-		else
-		{
-			// Creation KO
-			setEventMessages($object->error, $object->errors, 'errors');
-			$action='edit';
-		}
-	}
-	else
-	{
-		$action='edit';
-	}
+    foreach ($object->fields as $key => $val)
+    {
+        if (! GETPOSTISSET($key)) continue;		// The field was not submited to be edited
+        if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
+
+        // Set value to update
+        if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
+            $value = GETPOST($key,'none');
+        } elseif ($object->fields[$key]['type']=='date') {
+            $value = dol_mktime(12, 0, 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
+        } elseif ($object->fields[$key]['type']=='datetime') {
+            $value = dol_mktime(GETPOST($key.'hour'), GETPOST($key.'min'), 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
+        } elseif ($object->fields[$key]['type']=='price') {
+            $value = price2num(GETPOST($key));
+        } else {
+            $value = GETPOST($key,'alpha');
+        }
+        if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
+        if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
+
+        $object->$key=$value;
+        if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
+        {
+            $error++;
+            setEventMessages($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv($val['label'])), null, 'errors');
+        }
+    }
+
+    if (! $error)
+    {
+        $result=$object->update($user);
+        if ($result > 0)
+        {
+            $action='view';
+        }
+        else
+        {
+            // Creation KO
+            setEventMessages($object->error, $object->errors, 'errors');
+            $action='edit';
+        }
+    }
+    else
+    {
+        $action='edit';
+    }
 }
 
 // Action to update one extrafield
 if ($action == "update_extras" && ! empty($permissiontoadd))
 {
-	$object->fetch(GETPOST('id','int'));
-	$attributekey = GETPOST('attribute','alpha');
-	$attributekeylong = 'options_'.$attributekey;
-	$object->array_options['options_'.$attributekey] = GETPOST($attributekeylong,' alpha');
-
-	$result = $object->insertExtraFields(empty($triggermodname)?'':$triggermodname, $user);
-	if ($result > 0)
-	{
-		setEventMessages($langs->trans('RecordSaved'), null, 'mesgs');
-		$action = 'view';
-	}
-	else
-	{
-		setEventMessages($object->error, $object->errors, 'errors');
-		$action = 'edit_extras';
-	}
+    $object->fetch(GETPOST('id','int'));
+    $attributekey = GETPOST('attribute','alpha');
+    $attributekeylong = 'options_'.$attributekey;
+    $object->array_options['options_'.$attributekey] = GETPOST($attributekeylong,' alpha');
+
+    $result = $object->insertExtraFields(empty($triggermodname)?'':$triggermodname, $user);
+    if ($result > 0)
+    {
+        setEventMessages($langs->trans('RecordSaved'), null, 'mesgs');
+        $action = 'view';
+    }
+    else
+    {
+        setEventMessages($object->error, $object->errors, 'errors');
+        $action = 'edit_extras';
+    }
 }
 
 // Action to delete
 if ($action == 'confirm_delete' && ! empty($permissiontodelete))
 {
-	$result=$object->delete($user);
-	if ($result > 0)
-	{
-		// Delete OK
-		setEventMessages("RecordDeleted", null, 'mesgs');
-		header("Location: ".$backurlforlist);
-		exit;
-	}
-	else
-	{
-		if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
-		else setEventMessages($object->error, null, 'errors');
-	}
+    $result=$object->delete($user);
+    if ($result > 0)
+    {
+        // Delete OK
+        setEventMessages("RecordDeleted", null, 'mesgs');
+        header("Location: ".$backurlforlist);
+        exit;
+    }
+    else
+    {
+        if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
+        else setEventMessages($object->error, null, 'errors');
+    }
 }
 
 // Action clone object
 if ($action == 'confirm_clone' && $confirm == 'yes' && ! empty($permissiontoadd))
 {
-	if (1==0 && ! GETPOST('clone_content') && ! GETPOST('clone_receivers'))
-	{
-		setEventMessages($langs->trans("NoCloneOptionsSpecified"), null, 'errors');
-	}
-	else
-	{
-		if ($object->id > 0)
-		{
-			// Because createFromClone modifies the object, we must clone it so that we can restore it later
-			$orig = clone $object;
-
-			$result=$object->createFromClone($user, $object->id);
-			if ($result > 0)
-			{
-				$newid = 0;
-				if (is_object($result)) $newid = $result->id;
-				else $newid = $result;
-				header("Location: ".$_SERVER['PHP_SELF'].'?id='.$newid);	// Open record of new object
-				exit;
-			}
-			else
-			{
-				setEventMessages($object->error, $object->errors, 'errors');
-				$object = $orig;
-				$action='';
-			}
-		}
-	}
+    if (1==0 && ! GETPOST('clone_content') && ! GETPOST('clone_receivers'))
+    {
+        setEventMessages($langs->trans("NoCloneOptionsSpecified"), null, 'errors');
+    }
+    else
+    {
+        if ($object->id > 0)
+        {
+            // Because createFromClone modifies the object, we must clone it so that we can restore it later
+            $orig = clone $object;
+
+            $result=$object->createFromClone($user, $object->id);
+            if ($result > 0)
+            {
+                $newid = 0;
+                if (is_object($result)) $newid = $result->id;
+                else $newid = $result;
+                header("Location: ".$_SERVER['PHP_SELF'].'?id='.$newid);	// Open record of new object
+                exit;
+            }
+            else
+            {
+                setEventMessages($object->error, $object->errors, 'errors');
+                $object = $orig;
+                $action='';
+            }
+        }
+    }
 }

Spacing +49 added lines, -49 removed lines

@@ -32,128 +32,128 @@ 
 
 if ($cancel)
 {
-	if (! empty($backtopage))
+	if (!empty($backtopage))
 	{
 		header("Location: ".$backtopage);
 		exit;
 	}
-	$action='';
+	$action = '';
 }
 
 // Action to add record
-if ($action == 'add' && ! empty($permissiontoadd))
+if ($action == 'add' && !empty($permissiontoadd))
 {
 	foreach ($object->fields as $key => $val)
 	{
-		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
+		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue; // Ignore special fields
 
 		// Set value to insert
 		if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
-			$value = GETPOST($key,'none');
-		} elseif ($object->fields[$key]['type']=='date') {
+			$value = GETPOST($key, 'none');
+		} elseif ($object->fields[$key]['type'] == 'date') {
 			$value = dol_mktime(12, 0, 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='datetime') {
+		} elseif ($object->fields[$key]['type'] == 'datetime') {
 			$value = dol_mktime(GETPOST($key.'hour'), GETPOST($key.'min'), 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='price') {
+		} elseif ($object->fields[$key]['type'] == 'price') {
 			$value = price2num(GETPOST($key));
 		} else {
-			$value = GETPOST($key,'alpha');
+			$value = GETPOST($key, 'alpha');
 		}
-		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
-		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
+		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value = ''; // This is an implicit foreign key field
+		if (!empty($object->fields[$key]['foreignkey']) && $value == '-1') $value = ''; // This is an explicit foreign key field
 
-		$object->$key=$value;
+		$object->$key = $value;
 		if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
 		{
 			$error++;
-			setEventMessages($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv($val['label'])), null, 'errors');
+			setEventMessages($langs->trans("ErrorFieldRequired", $langs->transnoentitiesnoconv($val['label'])), null, 'errors');
 		}
 	}
 
-	if (! $error)
+	if (!$error)
 	{
-		$result=$object->create($user);
+		$result = $object->create($user);
 		if ($result > 0)
 		{
 			// Creation OK
-			$urltogo=$backtopage?str_replace('__ID__', $result, $backtopage):$backurlforlist;
+			$urltogo = $backtopage ?str_replace('__ID__', $result, $backtopage) : $backurlforlist;
 			header("Location: ".$urltogo);
 			exit;
 		}
 		else
 		{
 			// Creation KO
-			if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
+			if (!empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
 			else  setEventMessages($object->error, null, 'errors');
-			$action='create';
+			$action = 'create';
 		}
 	}
 	else
 	{
-		$action='create';
+		$action = 'create';
 	}
 }
 
 // Action to update record
-if ($action == 'update' && ! empty($permissiontoadd))
+if ($action == 'update' && !empty($permissiontoadd))
 {
 	foreach ($object->fields as $key => $val)
 	{
-		if (! GETPOSTISSET($key)) continue;		// The field was not submited to be edited
-		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
+		if (!GETPOSTISSET($key)) continue; // The field was not submited to be edited
+		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue; // Ignore special fields
 
 		// Set value to update
 		if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
-			$value = GETPOST($key,'none');
-		} elseif ($object->fields[$key]['type']=='date') {
+			$value = GETPOST($key, 'none');
+		} elseif ($object->fields[$key]['type'] == 'date') {
 			$value = dol_mktime(12, 0, 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='datetime') {
+		} elseif ($object->fields[$key]['type'] == 'datetime') {
 			$value = dol_mktime(GETPOST($key.'hour'), GETPOST($key.'min'), 0, GETPOST($key.'month'), GETPOST($key.'day'), GETPOST($key.'year'));
-		} elseif ($object->fields[$key]['type']=='price') {
+		} elseif ($object->fields[$key]['type'] == 'price') {
 			$value = price2num(GETPOST($key));
 		} else {
-			$value = GETPOST($key,'alpha');
+			$value = GETPOST($key, 'alpha');
 		}
-		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
-		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
+		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value = ''; // This is an implicit foreign key field
+		if (!empty($object->fields[$key]['foreignkey']) && $value == '-1') $value = ''; // This is an explicit foreign key field
 
-		$object->$key=$value;
+		$object->$key = $value;
 		if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
 		{
 			$error++;
-			setEventMessages($langs->trans("ErrorFieldRequired",$langs->transnoentitiesnoconv($val['label'])), null, 'errors');
+			setEventMessages($langs->trans("ErrorFieldRequired", $langs->transnoentitiesnoconv($val['label'])), null, 'errors');
 		}
 	}
 
-	if (! $error)
+	if (!$error)
 	{
-		$result=$object->update($user);
+		$result = $object->update($user);
 		if ($result > 0)
 		{
-			$action='view';
+			$action = 'view';
 		}
 		else
 		{
 			// Creation KO
 			setEventMessages($object->error, $object->errors, 'errors');
-			$action='edit';
+			$action = 'edit';
 		}
 	}
 	else
 	{
-		$action='edit';
+		$action = 'edit';
 	}
 }
 
 // Action to update one extrafield
-if ($action == "update_extras" && ! empty($permissiontoadd))
+if ($action == "update_extras" && !empty($permissiontoadd))
 {
-	$object->fetch(GETPOST('id','int'));
-	$attributekey = GETPOST('attribute','alpha');
+	$object->fetch(GETPOST('id', 'int'));
+	$attributekey = GETPOST('attribute', 'alpha');
 	$attributekeylong = 'options_'.$attributekey;
-	$object->array_options['options_'.$attributekey] = GETPOST($attributekeylong,' alpha');
+	$object->array_options['options_'.$attributekey] = GETPOST($attributekeylong, ' alpha');
 
-	$result = $object->insertExtraFields(empty($triggermodname)?'':$triggermodname, $user);
+	$result = $object->insertExtraFields(empty($triggermodname) ? '' : $triggermodname, $user);
 	if ($result > 0)
 	{
 		setEventMessages($langs->trans('RecordSaved'), null, 'mesgs');
@@ -167,9 +167,9 @@ 
 }
 
 // Action to delete
-if ($action == 'confirm_delete' && ! empty($permissiontodelete))
+if ($action == 'confirm_delete' && !empty($permissiontodelete))
 {
-	$result=$object->delete($user);
+	$result = $object->delete($user);
 	if ($result > 0)
 	{
 		// Delete OK
@@ -179,15 +179,15 @@ 
 	}
 	else
 	{
-		if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
+		if (!empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
 		else setEventMessages($object->error, null, 'errors');
 	}
 }
 
 // Action clone object
-if ($action == 'confirm_clone' && $confirm == 'yes' && ! empty($permissiontoadd))
+if ($action == 'confirm_clone' && $confirm == 'yes' && !empty($permissiontoadd))
 {
-	if (1==0 && ! GETPOST('clone_content') && ! GETPOST('clone_receivers'))
+	if (1 == 0 && !GETPOST('clone_content') && !GETPOST('clone_receivers'))
 	{
 		setEventMessages($langs->trans("NoCloneOptionsSpecified"), null, 'errors');
 	}
@@ -198,20 +198,20 @@ 
 			// Because createFromClone modifies the object, we must clone it so that we can restore it later
 			$orig = clone $object;
 
-			$result=$object->createFromClone($user, $object->id);
+			$result = $object->createFromClone($user, $object->id);
 			if ($result > 0)
 			{
 				$newid = 0;
 				if (is_object($result)) $newid = $result->id;
 				else $newid = $result;
-				header("Location: ".$_SERVER['PHP_SELF'].'?id='.$newid);	// Open record of new object
+				header("Location: ".$_SERVER['PHP_SELF'].'?id='.$newid); // Open record of new object
 				exit;
 			}
 			else
 			{
 				setEventMessages($object->error, $object->errors, 'errors');
 				$object = $orig;
-				$action='';
+				$action = '';
 			}
 		}
 	}

Braces +51 added lines, -29 removed lines

@@ -45,7 +45,10 @@ 
 {
 	foreach ($object->fields as $key => $val)
 	{
-		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
+		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) {
+		    continue;
+		}
+		// Ignore special fields
 
 		// Set value to insert
 		if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
@@ -59,8 +62,14 @@ 
 		} else {
 			$value = GETPOST($key,'alpha');
 		}
-		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
-		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
+		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') {
+		    $value='';
+		}
+		// This is an implicit foreign key field
+		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') {
+		    $value='';
+		}
+		// This is an explicit foreign key field
 
 		$object->$key=$value;
 		if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
@@ -79,16 +88,17 @@ 
 			$urltogo=$backtopage?str_replace('__ID__', $result, $backtopage):$backurlforlist;
 			header("Location: ".$urltogo);
 			exit;
-		}
-		else
+		} else
 		{
 			// Creation KO
-			if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
-			else  setEventMessages($object->error, null, 'errors');
+			if (! empty($object->errors)) {
+			    setEventMessages(null, $object->errors, 'errors');
+			} else {
+			    setEventMessages($object->error, null, 'errors');
+			}
 			$action='create';
 		}
-	}
-	else
+	} else
 	{
 		$action='create';
 	}
@@ -99,8 +109,14 @@ 
 {
 	foreach ($object->fields as $key => $val)
 	{
-		if (! GETPOSTISSET($key)) continue;		// The field was not submited to be edited
-		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) continue;	// Ignore special fields
+		if (! GETPOSTISSET($key)) {
+		    continue;
+		}
+		// The field was not submited to be edited
+		if (in_array($key, array('rowid', 'entity', 'date_creation', 'tms', 'fk_user_creat', 'fk_user_modif', 'import_key'))) {
+		    continue;
+		}
+		// Ignore special fields
 
 		// Set value to update
 		if (in_array($object->fields[$key]['type'], array('text', 'html'))) {
@@ -114,8 +130,14 @@ 
 		} else {
 			$value = GETPOST($key,'alpha');
 		}
-		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') $value='';		// This is an implicit foreign key field
-		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') $value='';					// This is an explicit foreign key field
+		if (preg_match('/^integer:/i', $object->fields[$key]['type']) && $value == '-1') {
+		    $value='';
+		}
+		// This is an implicit foreign key field
+		if (! empty($object->fields[$key]['foreignkey']) && $value == '-1') {
+		    $value='';
+		}
+		// This is an explicit foreign key field
 
 		$object->$key=$value;
 		if ($val['notnull'] > 0 && $object->$key == '' && is_null($val['default']))
@@ -131,15 +153,13 @@ 
 		if ($result > 0)
 		{
 			$action='view';
-		}
-		else
+		} else
 		{
 			// Creation KO
 			setEventMessages($object->error, $object->errors, 'errors');
 			$action='edit';
 		}
-	}
-	else
+	} else
 	{
 		$action='edit';
 	}
@@ -158,8 +178,7 @@ 
 	{
 		setEventMessages($langs->trans('RecordSaved'), null, 'mesgs');
 		$action = 'view';
-	}
-	else
+	} else
 	{
 		setEventMessages($object->error, $object->errors, 'errors');
 		$action = 'edit_extras';
@@ -176,11 +195,13 @@ 
 		setEventMessages("RecordDeleted", null, 'mesgs');
 		header("Location: ".$backurlforlist);
 		exit;
-	}
-	else
+	} else
 	{
-		if (! empty($object->errors)) setEventMessages(null, $object->errors, 'errors');
-		else setEventMessages($object->error, null, 'errors');
+		if (! empty($object->errors)) {
+		    setEventMessages(null, $object->errors, 'errors');
+		} else {
+		    setEventMessages($object->error, null, 'errors');
+		}
 	}
 }
 
@@ -190,8 +211,7 @@ 
 	if (1==0 && ! GETPOST('clone_content') && ! GETPOST('clone_receivers'))
 	{
 		setEventMessages($langs->trans("NoCloneOptionsSpecified"), null, 'errors');
-	}
-	else
+	} else
 	{
 		if ($object->id > 0)
 		{
@@ -202,12 +222,14 @@ 
 			if ($result > 0)
 			{
 				$newid = 0;
-				if (is_object($result)) $newid = $result->id;
-				else $newid = $result;
+				if (is_object($result)) {
+				    $newid = $result->id;
+				} else {
+				    $newid = $result;
+				}
 				header("Location: ".$_SERVER['PHP_SELF'].'?id='.$newid);	// Open record of new object
 				exit;
-			}
-			else
+			} else
 			{
 				setEventMessages($object->error, $object->errors, 'errors');
 				$object = $orig;

dolibarr/htdocs/core/actions_comments.inc.php

Indentation +35 added lines, -35 removed lines

@@ -35,42 +35,42 @@
 
 if ($action == 'addcomment')
 {
-	$description = GETPOST('comment_description', 'none');
-	if (!empty($description))
-	{
-		$comment->description = $description;
-		$comment->datec = time();
-		$comment->fk_element = GETPOST('id','int');
-		$comment->element_type = GETPOST('comment_element_type','alpha');
-		$comment->fk_user_author = $user->id;
-		$comment->entity = $conf->entity;
-		if ($comment->create($user) > 0)
-		{
-			setEventMessages($langs->trans("CommentAdded"), null, 'mesgs');
-			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
-			exit;
-		}
-		else
-		{
-			setEventMessages($comment->error, $comment->errors,'errors');
-			$action='';
-		}
-	}
+    $description = GETPOST('comment_description', 'none');
+    if (!empty($description))
+    {
+        $comment->description = $description;
+        $comment->datec = time();
+        $comment->fk_element = GETPOST('id','int');
+        $comment->element_type = GETPOST('comment_element_type','alpha');
+        $comment->fk_user_author = $user->id;
+        $comment->entity = $conf->entity;
+        if ($comment->create($user) > 0)
+        {
+            setEventMessages($langs->trans("CommentAdded"), null, 'mesgs');
+            header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
+            exit;
+        }
+        else
+        {
+            setEventMessages($comment->error, $comment->errors,'errors');
+            $action='';
+        }
+    }
 }
 if ($action == 'deletecomment')
 {
-	if ($comment->fetch($idcomment) >= 0)
-	{
-		if ($comment->delete($user) > 0)
-		{
-			setEventMessages($langs->trans("CommentDeleted"), null, 'mesgs');
-			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
-			exit;
-		}
-		else
-		{
-			setEventMessages($comment->error, $comment->errors,'errors');
-			$action='';
-		}
-	}
+    if ($comment->fetch($idcomment) >= 0)
+    {
+        if ($comment->delete($user) > 0)
+        {
+            setEventMessages($langs->trans("CommentDeleted"), null, 'mesgs');
+            header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
+            exit;
+        }
+        else
+        {
+            setEventMessages($comment->error, $comment->errors,'errors');
+            $action='';
+        }
+    }
 }
\ No newline at end of file

Spacing +9 added lines, -9 removed lines

@@ -26,7 +26,7 @@ 
 
 require_once DOL_DOCUMENT_ROOT.'/core/class/comment.class.php';
 
-$varpage=empty($contextpage)?$_SERVER["PHP_SELF"]:$contextpage;
+$varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
 $comment = new Comment($db);
 
 /*
@@ -40,20 +40,20 @@ 
 	{
 		$comment->description = $description;
 		$comment->datec = time();
-		$comment->fk_element = GETPOST('id','int');
-		$comment->element_type = GETPOST('comment_element_type','alpha');
+		$comment->fk_element = GETPOST('id', 'int');
+		$comment->element_type = GETPOST('comment_element_type', 'alpha');
 		$comment->fk_user_author = $user->id;
 		$comment->entity = $conf->entity;
 		if ($comment->create($user) > 0)
 		{
 			setEventMessages($langs->trans("CommentAdded"), null, 'mesgs');
-			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
+			header('Location: '.$varpage.'?id='.$id.($withproject ? '&withproject=1' : ''));
 			exit;
 		}
 		else
 		{
-			setEventMessages($comment->error, $comment->errors,'errors');
-			$action='';
+			setEventMessages($comment->error, $comment->errors, 'errors');
+			$action = '';
 		}
 	}
 }
@@ -64,13 +64,13 @@ 
 		if ($comment->delete($user) > 0)
 		{
 			setEventMessages($langs->trans("CommentDeleted"), null, 'mesgs');
-			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
+			header('Location: '.$varpage.'?id='.$id.($withproject ? '&withproject=1' : ''));
 			exit;
 		}
 		else
 		{
-			setEventMessages($comment->error, $comment->errors,'errors');
-			$action='';
+			setEventMessages($comment->error, $comment->errors, 'errors');
+			$action = '';
 		}
 	}
 }
\ No newline at end of file

Braces +2 added lines, -4 removed lines

@@ -49,8 +49,7 @@ 
 			setEventMessages($langs->trans("CommentAdded"), null, 'mesgs');
 			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
 			exit;
-		}
-		else
+		} else
 		{
 			setEventMessages($comment->error, $comment->errors,'errors');
 			$action='';
@@ -66,8 +65,7 @@ 
 			setEventMessages($langs->trans("CommentDeleted"), null, 'mesgs');
 			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
 			exit;
-		}
-		else
+		} else
 		{
 			setEventMessages($comment->error, $comment->errors,'errors');
 			$action='';

dolibarr/htdocs/core/filemanagerdol/browser/default/browser.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
 //define('NOTOKENRENEWAL',1); // Disables token renewal
 //require '../../../../main.inc.php';
-require '../../connectors/php/config.php';      // This include the define('NOTOKENRENEWAL',1) and the require main.in.php
+require '../../connectors/php/config.php'; // This include the define('NOTOKENRENEWAL',1) and the require main.in.php
 
 global $Config;
 

dolibarr/htdocs/core/filemanagerdol/connectors/php/basexml.php

Indentation +48 added lines, -48 removed lines

@@ -30,21 +30,21 @@ 
  */
 function SetXmlHeaders()
 {
-	ob_end_clean();
-
-	// Prevent the browser from caching the result.
-	// Date in the past
-	header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
-	// always modified
-	header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
-	// HTTP/1.1
-	header('Cache-Control: no-store, no-cache, must-revalidate');
-	header('Cache-Control: post-check=0, pre-check=0', false);
-	// HTTP/1.0
-	header('Pragma: no-cache');
-
-	// Set the response format.
-	header('Content-Type: text/xml; charset=utf-8');
+    ob_end_clean();
+
+    // Prevent the browser from caching the result.
+    // Date in the past
+    header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
+    // always modified
+    header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
+    // HTTP/1.1
+    header('Cache-Control: no-store, no-cache, must-revalidate');
+    header('Cache-Control: post-check=0, pre-check=0', false);
+    // HTTP/1.0
+    header('Pragma: no-cache');
+
+    // Set the response format.
+    header('Content-Type: text/xml; charset=utf-8');
 }
 
 /**
@@ -57,18 +57,18 @@ 
  */
 function CreateXmlHeader( $command, $resourceType, $currentFolder )
 {
-	SetXmlHeaders();
+    SetXmlHeaders();
 
-	// Create the XML document header.
-	echo '<?xml version="1.0" encoding="utf-8" ?>' ;
+    // Create the XML document header.
+    echo '<?xml version="1.0" encoding="utf-8" ?>' ;
 
-	// Create the main "Connector" node.
-	echo '<Connector command="' . $command . '" resourceType="' . $resourceType . '">' ;
+    // Create the main "Connector" node.
+    echo '<Connector command="' . $command . '" resourceType="' . $resourceType . '">' ;
 
-	// Add the current folder node.
-	echo '<CurrentFolder path="' . ConvertToXmlAttribute($currentFolder) . '" url="' . ConvertToXmlAttribute(GetUrlFromPath($resourceType, $currentFolder, $command)) . '" />' ;
+    // Add the current folder node.
+    echo '<CurrentFolder path="' . ConvertToXmlAttribute($currentFolder) . '" url="' . ConvertToXmlAttribute(GetUrlFromPath($resourceType, $currentFolder, $command)) . '" />' ;
 
-	$GLOBALS['HeaderSent'] = true ;
+    $GLOBALS['HeaderSent'] = true ;
 }
 
 /**
@@ -78,7 +78,7 @@ 
  */
 function CreateXmlFooter()
 {
-	echo '</Connector>' ;
+    echo '</Connector>' ;
 }
 
 /**
@@ -90,30 +90,30 @@ 
  */
 function SendError($number, $text)
 {
-	if ( $_GET['Command'] == 'FileUpload' )
-		SendUploadResults($number, "", "", $text);
-
-	if ( isset( $GLOBALS['HeaderSent'] ) && $GLOBALS['HeaderSent'] )
-	{
-		SendErrorNode($number, $text);
-		CreateXmlFooter();
-	}
-	else
-	{
-		SetXmlHeaders();
-
-		dol_syslog('Error: '.$number.' '.$text, LOG_ERR);
+    if ( $_GET['Command'] == 'FileUpload' )
+        SendUploadResults($number, "", "", $text);
+
+    if ( isset( $GLOBALS['HeaderSent'] ) && $GLOBALS['HeaderSent'] )
+    {
+        SendErrorNode($number, $text);
+        CreateXmlFooter();
+    }
+    else
+    {
+        SetXmlHeaders();
+
+        dol_syslog('Error: '.$number.' '.$text, LOG_ERR);
 		
-		// Create the XML document header
-		echo '<?xml version="1.0" encoding="utf-8" ?>' ;
+        // Create the XML document header
+        echo '<?xml version="1.0" encoding="utf-8" ?>' ;
 
-		echo '<Connector>' ;
+        echo '<Connector>' ;
 
-		SendErrorNode($number, $text);
+        SendErrorNode($number, $text);
 
-		echo '</Connector>' ;
-	}
-	exit ;
+        echo '</Connector>' ;
+    }
+    exit ;
 }
 
 /**
@@ -125,8 +125,8 @@ 
  */
 function SendErrorNode($number, $text)
 {
-	if ($text)
-		echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
-	else
-		echo '<Error number="' . $number . '" />' ;
+    if ($text)
+        echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
+    else
+        echo '<Error number="' . $number . '" />' ;
 }

Spacing +15 added lines, -15 removed lines

@@ -36,7 +36,7 @@ 
 	// Date in the past
 	header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
 	// always modified
-	header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
+	header('Last-Modified: '.gmdate('D, d M Y H:i:s').' GMT');
 	// HTTP/1.1
 	header('Cache-Control: no-store, no-cache, must-revalidate');
 	header('Cache-Control: post-check=0, pre-check=0', false);
@@ -55,20 +55,20 @@ 
  * @param string	$currentFolder	Current folder
  * @return void
  */
-function CreateXmlHeader( $command, $resourceType, $currentFolder )
+function CreateXmlHeader($command, $resourceType, $currentFolder)
 {
 	SetXmlHeaders();
 
 	// Create the XML document header.
-	echo '<?xml version="1.0" encoding="utf-8" ?>' ;
+	echo '<?xml version="1.0" encoding="utf-8" ?>';
 
 	// Create the main "Connector" node.
-	echo '<Connector command="' . $command . '" resourceType="' . $resourceType . '">' ;
+	echo '<Connector command="'.$command.'" resourceType="'.$resourceType.'">';
 
 	// Add the current folder node.
-	echo '<CurrentFolder path="' . ConvertToXmlAttribute($currentFolder) . '" url="' . ConvertToXmlAttribute(GetUrlFromPath($resourceType, $currentFolder, $command)) . '" />' ;
+	echo '<CurrentFolder path="'.ConvertToXmlAttribute($currentFolder).'" url="'.ConvertToXmlAttribute(GetUrlFromPath($resourceType, $currentFolder, $command)).'" />';
 
-	$GLOBALS['HeaderSent'] = true ;
+	$GLOBALS['HeaderSent'] = true;
 }
 
 /**
@@ -78,7 +78,7 @@ 
  */
 function CreateXmlFooter()
 {
-	echo '</Connector>' ;
+	echo '</Connector>';
 }
 
 /**
@@ -90,10 +90,10 @@ 
  */
 function SendError($number, $text)
 {
-	if ( $_GET['Command'] == 'FileUpload' )
+	if ($_GET['Command'] == 'FileUpload')
 		SendUploadResults($number, "", "", $text);
 
-	if ( isset( $GLOBALS['HeaderSent'] ) && $GLOBALS['HeaderSent'] )
+	if (isset($GLOBALS['HeaderSent']) && $GLOBALS['HeaderSent'])
 	{
 		SendErrorNode($number, $text);
 		CreateXmlFooter();
@@ -105,15 +105,15 @@ 
 		dol_syslog('Error: '.$number.' '.$text, LOG_ERR);
 		
 		// Create the XML document header
-		echo '<?xml version="1.0" encoding="utf-8" ?>' ;
+		echo '<?xml version="1.0" encoding="utf-8" ?>';
 
-		echo '<Connector>' ;
+		echo '<Connector>';
 
 		SendErrorNode($number, $text);
 
-		echo '</Connector>' ;
+		echo '</Connector>';
 	}
-	exit ;
+	exit;
 }
 
 /**
@@ -126,7 +126,7 @@ 
 function SendErrorNode($number, $text)
 {
 	if ($text)
-		echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
+		echo '<Error number="'.$number.'" text="'.htmlspecialchars($text).'" />';
 	else
-		echo '<Error number="' . $number . '" />' ;
+		echo '<Error number="'.$number.'" />';
 }

Braces +10 added lines, -9 removed lines

@@ -90,15 +90,15 @@ 
  */
 function SendError($number, $text)
 {
-	if ( $_GET['Command'] == 'FileUpload' )
-		SendUploadResults($number, "", "", $text);
+	if ( $_GET['Command'] == 'FileUpload' ) {
+			SendUploadResults($number, "", "", $text);
+	}
 
 	if ( isset( $GLOBALS['HeaderSent'] ) && $GLOBALS['HeaderSent'] )
 	{
 		SendErrorNode($number, $text);
 		CreateXmlFooter();
-	}
-	else
+	} else
 	{
 		SetXmlHeaders();
 
@@ -125,8 +125,9 @@ 
  */
 function SendErrorNode($number, $text)
 {
-	if ($text)
-		echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
-	else
-		echo '<Error number="' . $number . '" />' ;
-}
+	if ($text) {
+			echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
+	} else {
+			echo '<Error number="' . $number . '" />' ;
+	}
+	}

dolibarr/htdocs/core/filemanagerdol/connectors/php/connector.php

Indentation +37 added lines, -37 removed lines

@@ -31,7 +31,7 @@ 
 require 'commands.php';
 
 if ( !$Config['Enabled'] )
-	SendError(1, 'This connector is disabled. Please check the "editor/filemanager/connectors/php/config.php" file');
+    SendError(1, 'This connector is disabled. Please check the "editor/filemanager/connectors/php/config.php" file');
 
 DoResponse();
 
@@ -45,47 +45,47 @@ 
     if (!isset($_GET)) {
         global $_GET;
     }
-	if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) )
-		return;
+    if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) )
+        return;
 
-	// Get the main request informaiton.
-	$sCommand		= $_GET['Command'] ;
-	$sResourceType	= $_GET['Type'] ;
-	$sCurrentFolder	= GetCurrentFolder();
+    // Get the main request informaiton.
+    $sCommand		= $_GET['Command'] ;
+    $sResourceType	= $_GET['Type'] ;
+    $sCurrentFolder	= GetCurrentFolder();
 
-	// Check if it is an allowed command
-	if (! IsAllowedCommand($sCommand))
-	{
-		SendError(1, 'The "' . $sCommand . '" command isn\'t allowed');
-	}
-	// Check if it is an allowed type.
-	if (! IsAllowedType($sResourceType))
-		SendError(1, 'Invalid type specified');
+    // Check if it is an allowed command
+    if (! IsAllowedCommand($sCommand))
+    {
+        SendError(1, 'The "' . $sCommand . '" command isn\'t allowed');
+    }
+    // Check if it is an allowed type.
+    if (! IsAllowedType($sResourceType))
+        SendError(1, 'Invalid type specified');
 
-	// File Upload doesn't have to Return XML, so it must be intercepted before anything.
-	if ( $sCommand == 'FileUpload' )
-	{
-		FileUpload($sResourceType, $sCurrentFolder, $sCommand);
-		return;
-	}
+    // File Upload doesn't have to Return XML, so it must be intercepted before anything.
+    if ( $sCommand == 'FileUpload' )
+    {
+        FileUpload($sResourceType, $sCurrentFolder, $sCommand);
+        return;
+    }
 
-	CreateXmlHeader($sCommand, $sResourceType, $sCurrentFolder);
+    CreateXmlHeader($sCommand, $sResourceType, $sCurrentFolder);
 
-	// Execute the required command.
-	switch ( $sCommand )
-	{
-		case 'GetFolders' :
-			GetFolders($sResourceType, $sCurrentFolder);
-			break;
-		case 'GetFoldersAndFiles' :
-			GetFoldersAndFiles($sResourceType, $sCurrentFolder);
-			break;
-		case 'CreateFolder' :
-			CreateFolder($sResourceType, $sCurrentFolder);
-			break;
-	}
+    // Execute the required command.
+    switch ( $sCommand )
+    {
+        case 'GetFolders' :
+            GetFolders($sResourceType, $sCurrentFolder);
+            break;
+        case 'GetFoldersAndFiles' :
+            GetFoldersAndFiles($sResourceType, $sCurrentFolder);
+            break;
+        case 'CreateFolder' :
+            CreateFolder($sResourceType, $sCurrentFolder);
+            break;
+    }
 
-	CreateXmlFooter();
+    CreateXmlFooter();
 
-	exit;
+    exit;
 }

Spacing +10 added lines, -10 removed lines

@@ -30,7 +30,7 @@ 
 require 'basexml.php';
 require 'commands.php';
 
-if ( !$Config['Enabled'] )
+if (!$Config['Enabled'])
 	SendError(1, 'This connector is disabled. Please check the "editor/filemanager/connectors/php/config.php" file');
 
 DoResponse();
@@ -45,25 +45,25 @@ 
     if (!isset($_GET)) {
         global $_GET;
     }
-	if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) )
+	if (!isset($_GET['Command']) || !isset($_GET['Type']) || !isset($_GET['CurrentFolder']))
 		return;
 
 	// Get the main request informaiton.
-	$sCommand		= $_GET['Command'] ;
-	$sResourceType	= $_GET['Type'] ;
-	$sCurrentFolder	= GetCurrentFolder();
+	$sCommand = $_GET['Command'];
+	$sResourceType = $_GET['Type'];
+	$sCurrentFolder = GetCurrentFolder();
 
 	// Check if it is an allowed command
-	if (! IsAllowedCommand($sCommand))
+	if (!IsAllowedCommand($sCommand))
 	{
-		SendError(1, 'The "' . $sCommand . '" command isn\'t allowed');
+		SendError(1, 'The "'.$sCommand.'" command isn\'t allowed');
 	}
 	// Check if it is an allowed type.
-	if (! IsAllowedType($sResourceType))
+	if (!IsAllowedType($sResourceType))
 		SendError(1, 'Invalid type specified');
 
 	// File Upload doesn't have to Return XML, so it must be intercepted before anything.
-	if ( $sCommand == 'FileUpload' )
+	if ($sCommand == 'FileUpload')
 	{
 		FileUpload($sResourceType, $sCurrentFolder, $sCommand);
 		return;
@@ -72,7 +72,7 @@ 
 	CreateXmlHeader($sCommand, $sResourceType, $sCurrentFolder);
 
 	// Execute the required command.
-	switch ( $sCommand )
+	switch ($sCommand)
 	{
 		case 'GetFolders' :
 			GetFolders($sResourceType, $sCurrentFolder);

Braces +8 added lines, -5 removed lines

@@ -30,8 +30,9 @@ 
 require 'basexml.php';
 require 'commands.php';
 
-if ( !$Config['Enabled'] )
+if ( !$Config['Enabled'] ) {
 	SendError(1, 'This connector is disabled. Please check the "editor/filemanager/connectors/php/config.php" file');
+}
 
 DoResponse();
 
@@ -45,8 +46,9 @@ 
     if (!isset($_GET)) {
         global $_GET;
     }
-	if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) )
-		return;
+	if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) ) {
+			return;
+	}
 
 	// Get the main request informaiton.
 	$sCommand		= $_GET['Command'] ;
@@ -59,8 +61,9 @@ 
 		SendError(1, 'The "' . $sCommand . '" command isn\'t allowed');
 	}
 	// Check if it is an allowed type.
-	if (! IsAllowedType($sResourceType))
-		SendError(1, 'Invalid type specified');
+	if (! IsAllowedType($sResourceType)) {
+			SendError(1, 'Invalid type specified');
+	}
 
 	// File Upload doesn't have to Return XML, so it must be intercepted before anything.
 	if ( $sCommand == 'FileUpload' )

dolibarr/htdocs/core/filemanagerdol/connectors/php/upload.php

Indentation +3 added lines, -3 removed lines

@@ -36,13 +36,13 @@ 
  */
 function SendError($number, $text)
 {
-	SendUploadResults($number, '', '', $text);
+    SendUploadResults($number, '', '', $text);
 }
 
 
 // Check if this uploader has been enabled.
 if ( !$Config['Enabled'] )
-	SendUploadResults('1', '', '', 'This file uploader is disabled. Please check the "filemanagerdol/connectors/php/config.php" file');
+    SendUploadResults('1', '', '', 'This file uploader is disabled. Please check the "filemanagerdol/connectors/php/config.php" file');
 
 $sCommand = 'QuickUpload' ;
 
@@ -53,7 +53,7 @@ 
 
 // Is enabled the upload?
 if (! IsAllowedCommand($sCommand))
-	SendUploadResults('1', '', '', 'The ""' . $sCommand . '"" command isn\'t allowed');
+    SendUploadResults('1', '', '', 'The ""' . $sCommand . '"" command isn\'t allowed');
 
 // Check if it is an allowed type.
 if (! IsAllowedType($sType))

Spacing +7 added lines, -7 removed lines

@@ -41,22 +41,22 @@
 
 
 // Check if this uploader has been enabled.
-if ( !$Config['Enabled'] )
+if (!$Config['Enabled'])
 	SendUploadResults('1', '', '', 'This file uploader is disabled. Please check the "filemanagerdol/connectors/php/config.php" file');
 
-$sCommand = 'QuickUpload' ;
+$sCommand = 'QuickUpload';
 
 // The file type (from the QueryString, by default 'File').
-$sType = isset( $_GET['Type'] ) ? $_GET['Type'] : 'File' ;
+$sType = isset($_GET['Type']) ? $_GET['Type'] : 'File';
 
-$sCurrentFolder	= "/" ;
+$sCurrentFolder = "/";
 
 // Is enabled the upload?
-if (! IsAllowedCommand($sCommand))
-	SendUploadResults('1', '', '', 'The ""' . $sCommand . '"" command isn\'t allowed');
+if (!IsAllowedCommand($sCommand))
+	SendUploadResults('1', '', '', 'The ""'.$sCommand.'"" command isn\'t allowed');
 
 // Check if it is an allowed type.
-if (! IsAllowedType($sType))
+if (!IsAllowedType($sType))
     SendUploadResults(1, '', '', 'Invalid type specified');
 
 

Braces +6 added lines, -3 removed lines

@@ -41,8 +41,9 @@ 
 
 
 // Check if this uploader has been enabled.
-if ( !$Config['Enabled'] )
+if ( !$Config['Enabled'] ) {
 	SendUploadResults('1', '', '', 'This file uploader is disabled. Please check the "filemanagerdol/connectors/php/config.php" file');
+}
 
 $sCommand = 'QuickUpload' ;
 
@@ -52,12 +53,14 @@ 
 $sCurrentFolder	= "/" ;
 
 // Is enabled the upload?
-if (! IsAllowedCommand($sCommand))
+if (! IsAllowedCommand($sCommand)) {
 	SendUploadResults('1', '', '', 'The ""' . $sCommand . '"" command isn\'t allowed');
+}
 
 // Check if it is an allowed type.
-if (! IsAllowedType($sType))
+if (! IsAllowedType($sType)) {
     SendUploadResults(1, '', '', 'Invalid type specified');
+}
 
 
 // @CHANGE

dolibarr/htdocs/core/filemanagerdol/connectors/php/io.php

Indentation +162 added lines, -162 removed lines

@@ -31,7 +31,7 @@ 
  */
 function CombinePaths( $sBasePath, $sFolder )
 {
-	return RemoveFromEnd($sBasePath, '/') . '/' . RemoveFromStart($sFolder, '/');
+    return RemoveFromEnd($sBasePath, '/') . '/' . RemoveFromStart($sFolder, '/');
 }
 /**
  * GetResourceTypePath
@@ -42,12 +42,12 @@ 
  */
 function GetResourceTypePath($resourceType, $sCommand)
 {
-	global $Config ;
+    global $Config ;
 
-	if ($sCommand == "QuickUpload")
-		return $Config['QuickUploadPath'][$resourceType] ;
-	else
-		return $Config['FileTypesPath'][$resourceType] ;
+    if ($sCommand == "QuickUpload")
+        return $Config['QuickUploadPath'][$resourceType] ;
+    else
+        return $Config['FileTypesPath'][$resourceType] ;
 }
 
 /**
@@ -59,23 +59,23 @@ 
  */
 function GetResourceTypeDirectory($resourceType, $sCommand)
 {
-	global $Config ;
-	if ($sCommand == "QuickUpload")
-	{
-		if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0)
-			return $Config['QuickUploadAbsolutePath'][$resourceType] ;
-
-		// Map the "UserFiles" path to a local directory.
-		return Server_MapPath($Config['QuickUploadPath'][$resourceType]);
-	}
-	else
-	{
-		if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0)
-			return $Config['FileTypesAbsolutePath'][$resourceType] ;
-
-		// Map the "UserFiles" path to a local directory.
-		return Server_MapPath($Config['FileTypesPath'][$resourceType]);
-	}
+    global $Config ;
+    if ($sCommand == "QuickUpload")
+    {
+        if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0)
+            return $Config['QuickUploadAbsolutePath'][$resourceType] ;
+
+        // Map the "UserFiles" path to a local directory.
+        return Server_MapPath($Config['QuickUploadPath'][$resourceType]);
+    }
+    else
+    {
+        if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0)
+            return $Config['FileTypesAbsolutePath'][$resourceType] ;
+
+        // Map the "UserFiles" path to a local directory.
+        return Server_MapPath($Config['FileTypesPath'][$resourceType]);
+    }
 }
 
 /**
@@ -88,7 +88,7 @@ 
  */
 function GetUrlFromPath($resourceType, $folderPath, $sCommand)
 {
-	return CombinePaths(GetResourceTypePath($resourceType, $sCommand), $folderPath);
+    return CombinePaths(GetResourceTypePath($resourceType, $sCommand), $folderPath);
 }
 
 /**
@@ -99,7 +99,7 @@ 
  */
 function RemoveExtension($fileName)
 {
-	return substr($fileName, 0, strrpos($fileName, '.'));
+    return substr($fileName, 0, strrpos($fileName, '.'));
 }
 /**
  * ServerMapFolder
@@ -111,16 +111,16 @@ 
  */
 function ServerMapFolder($resourceType, $folderPath, $sCommand)
 {
-	// Get the resource type directory.
-	$sResourceTypePath = GetResourceTypeDirectory($resourceType, $sCommand);
+    // Get the resource type directory.
+    $sResourceTypePath = GetResourceTypeDirectory($resourceType, $sCommand);
 
-	// Ensure that the directory exists.
-	$sErrorMsg = CreateServerFolder($sResourceTypePath);
-	if ( $sErrorMsg != '' )
-		SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
+    // Ensure that the directory exists.
+    $sErrorMsg = CreateServerFolder($sResourceTypePath);
+    if ( $sErrorMsg != '' )
+        SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
 
-	// Return the resource type directory combined with the required path.
-	return CombinePaths($sResourceTypePath, $folderPath);
+    // Return the resource type directory combined with the required path.
+    return CombinePaths($sResourceTypePath, $folderPath);
 }
 
 /**
@@ -144,67 +144,67 @@ 
  */
 function CreateServerFolder($folderPath, $lastFolder = null)
 {
-	global $Config ;
-	$sParent = GetParentFolder($folderPath);
-
-	// Ensure the folder path has no double-slashes, or mkdir may fail on certain platforms
-	while ( strpos($folderPath, '//') !== false )
-	{
-		$folderPath = str_replace('//', '/', $folderPath);
-	}
-
-	// Check if the parent exists, or create it.
-	if ( !empty($sParent) && !file_exists($sParent))
-	{
-		//prevents agains infinite loop when we can't create root folder
-		if ( !is_null($lastFolder) && $lastFolder === $sParent) {
-			return "Can't create $folderPath directory" ;
-		}
-
-		$sErrorMsg = CreateServerFolder($sParent, $folderPath);
-		if ( $sErrorMsg != '' )
-			return $sErrorMsg ;
-	}
-
-	if ( !file_exists($folderPath))
-	{
-		// Turn off all error reporting.
-		error_reporting(0);
-
-		$php_errormsg = '' ;
-		// Enable error tracking to catch the error.
-		ini_set('track_errors', '1');
-
-		if ( isset( $Config['ChmodOnFolderCreate'] ) && !$Config['ChmodOnFolderCreate'] )
-		{
-			mkdir($folderPath);
-		}
-		else
-		{
-			$permissions = '0777';
-			if ( isset( $Config['ChmodOnFolderCreate'] ) && $Config['ChmodOnFolderCreate'])
-			{
-				$permissions = (string) $Config['ChmodOnFolderCreate'];
-			}
-			$permissionsdec = octdec($permissions);
-			$permissionsdec |= octdec('0111');  // Set x bit required for directories
-			dol_syslog("io.php permission = ".$permissions." ".$permissionsdec." ".decoct($permissionsdec));
-			// To create the folder with 0777 permissions, we need to set umask to zero.
-			$oldumask = umask(0);
-			mkdir($folderPath, $permissionsdec);
-			umask($oldumask);
-		}
-
-		$sErrorMsg = $php_errormsg ;
-
-		// Restore the configurations.
-		ini_restore('track_errors');
-		ini_restore('error_reporting');
-
-		return $sErrorMsg ;
-	}
-	else
-		return '' ;
+    global $Config ;
+    $sParent = GetParentFolder($folderPath);
+
+    // Ensure the folder path has no double-slashes, or mkdir may fail on certain platforms
+    while ( strpos($folderPath, '//') !== false )
+    {
+        $folderPath = str_replace('//', '/', $folderPath);
+    }
+
+    // Check if the parent exists, or create it.
+    if ( !empty($sParent) && !file_exists($sParent))
+    {
+        //prevents agains infinite loop when we can't create root folder
+        if ( !is_null($lastFolder) && $lastFolder === $sParent) {
+            return "Can't create $folderPath directory" ;
+        }
+
+        $sErrorMsg = CreateServerFolder($sParent, $folderPath);
+        if ( $sErrorMsg != '' )
+            return $sErrorMsg ;
+    }
+
+    if ( !file_exists($folderPath))
+    {
+        // Turn off all error reporting.
+        error_reporting(0);
+
+        $php_errormsg = '' ;
+        // Enable error tracking to catch the error.
+        ini_set('track_errors', '1');
+
+        if ( isset( $Config['ChmodOnFolderCreate'] ) && !$Config['ChmodOnFolderCreate'] )
+        {
+            mkdir($folderPath);
+        }
+        else
+        {
+            $permissions = '0777';
+            if ( isset( $Config['ChmodOnFolderCreate'] ) && $Config['ChmodOnFolderCreate'])
+            {
+                $permissions = (string) $Config['ChmodOnFolderCreate'];
+            }
+            $permissionsdec = octdec($permissions);
+            $permissionsdec |= octdec('0111');  // Set x bit required for directories
+            dol_syslog("io.php permission = ".$permissions." ".$permissionsdec." ".decoct($permissionsdec));
+            // To create the folder with 0777 permissions, we need to set umask to zero.
+            $oldumask = umask(0);
+            mkdir($folderPath, $permissionsdec);
+            umask($oldumask);
+        }
+
+        $sErrorMsg = $php_errormsg ;
+
+        // Restore the configurations.
+        ini_restore('track_errors');
+        ini_restore('error_reporting');
+
+        return $sErrorMsg ;
+    }
+    else
+        return '' ;
 }
 
 /**
@@ -260,18 +260,18 @@ 
  */
 function IsAllowedExt($sExtension, $resourceType)
 {
-	global $Config ;
-	// Get the allowed and denied extensions arrays.
-	$arAllowed	= $Config['AllowedExtensions'][$resourceType] ;
-	$arDenied	= $Config['DeniedExtensions'][$resourceType] ;
+    global $Config ;
+    // Get the allowed and denied extensions arrays.
+    $arAllowed	= $Config['AllowedExtensions'][$resourceType] ;
+    $arDenied	= $Config['DeniedExtensions'][$resourceType] ;
 
-	if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed))
-		return false ;
+    if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed))
+        return false ;
 
-	if ( count($arDenied) > 0 && in_array($sExtension, $arDenied))
-		return false ;
+    if ( count($arDenied) > 0 && in_array($sExtension, $arDenied))
+        return false ;
 
-	return true ;
+    return true ;
 }
 
 /**
@@ -282,11 +282,11 @@ 
  */
 function IsAllowedType($resourceType)
 {
-	global $Config ;
-	if ( !in_array($resourceType, $Config['ConfigAllowedTypes']))
-		return false ;
+    global $Config ;
+    if ( !in_array($resourceType, $Config['ConfigAllowedTypes']))
+        return false ;
 
-	return true ;
+    return true ;
 }
 
 /**
@@ -297,12 +297,12 @@ 
  */
 function IsAllowedCommand($sCommand)
 {
-	global $Config ;
+    global $Config ;
 
-	if (! in_array($sCommand, $Config['ConfigAllowedCommands']))
-		return false ;
+    if (! in_array($sCommand, $Config['ConfigAllowedCommands']))
+        return false ;
 
-	return true ;
+    return true ;
 }
 
 /**
@@ -312,79 +312,79 @@ 
  */
 function GetCurrentFolder()
 {
-	if (!isset($_GET)) {
-		global $_GET;
-	}
-	$sCurrentFolder	= isset( $_GET['CurrentFolder'] ) ? GETPOST('CurrentFolder', '', 1) : '/' ;
-
-	// Check the current folder syntax (must begin and start with a slash).
-	if (!preg_match('|/$|', $sCurrentFolder))
-		$sCurrentFolder .= '/' ;
-	if (strpos($sCurrentFolder, '/') !== 0)
-		$sCurrentFolder = '/' . $sCurrentFolder ;
-
-	// Ensure the folder path has no double-slashes
-	while ( strpos($sCurrentFolder, '//') !== false ) {
-		$sCurrentFolder = str_replace('//', '/', $sCurrentFolder);
-	}
-
-	// Check for invalid folder paths (..)
-	if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\"))
-		SendError(102, '');
-
-	if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder))
-		SendError(102, '');
-
-	return $sCurrentFolder ;
+    if (!isset($_GET)) {
+        global $_GET;
+    }
+    $sCurrentFolder	= isset( $_GET['CurrentFolder'] ) ? GETPOST('CurrentFolder', '', 1) : '/' ;
+
+    // Check the current folder syntax (must begin and start with a slash).
+    if (!preg_match('|/$|', $sCurrentFolder))
+        $sCurrentFolder .= '/' ;
+    if (strpos($sCurrentFolder, '/') !== 0)
+        $sCurrentFolder = '/' . $sCurrentFolder ;
+
+    // Ensure the folder path has no double-slashes
+    while ( strpos($sCurrentFolder, '//') !== false ) {
+        $sCurrentFolder = str_replace('//', '/', $sCurrentFolder);
+    }
+
+    // Check for invalid folder paths (..)
+    if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\"))
+        SendError(102, '');
+
+    if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder))
+        SendError(102, '');
+
+    return $sCurrentFolder ;
 }
 
 // Do a cleanup of the folder name to avoid possible problems
 function SanitizeFolderName( $sNewFolderName )
 {
-	$sNewFolderName = stripslashes($sNewFolderName);
+    $sNewFolderName = stripslashes($sNewFolderName);
 
-	// Remove . \ / | : ? * " < >
-	$sNewFolderName = preg_replace('/\\.|\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFolderName);
+    // Remove . \ / | : ? * " < >
+    $sNewFolderName = preg_replace('/\\.|\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFolderName);
 
-	return $sNewFolderName ;
+    return $sNewFolderName ;
 }
 
 // Do a cleanup of the file name to avoid possible problems
 function SanitizeFileName( $sNewFileName )
 {
-	global $Config ;
+    global $Config ;
 
-	$sNewFileName = stripslashes($sNewFileName);
+    $sNewFileName = stripslashes($sNewFileName);
 
-	// Replace dots in the name with underscores (only one dot can be there... security issue).
-	if ( $Config['ForceSingleExtension'] )
-		$sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
+    // Replace dots in the name with underscores (only one dot can be there... security issue).
+    if ( $Config['ForceSingleExtension'] )
+        $sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
 
-	// Remove \ / | : ? * " < >
-	$sNewFileName = preg_replace('/\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFileName);
+    // Remove \ / | : ? * " < >
+    $sNewFileName = preg_replace('/\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFileName);
 
-	return $sNewFileName ;
+    return $sNewFileName ;
 }
 
 // This is the function that sends the results of the uploading process.
 function SendUploadResults( $errorNumber, $fileUrl = '', $fileName = '', $customMsg = '' )
 {
-	// Minified version of the document.domain automatic fix script (#1919).
-	// The original script can be found at _dev/domain_fix_template.js
-	echo <<<EOF
+    // Minified version of the document.domain automatic fix script (#1919).
+    // The original script can be found at _dev/domain_fix_template.js
+    echo <<<EOF
 <script type="text/javascript">
 (function(){var d=document.domain;while (true){try{var A=window.parent.document.domain;break;}catch(e) {};d=d.replace(/.*?(?:\.|$)/,'');if (d.length==0) break;try{document.domain=d;}catch (e){break;}}})();
 EOF;
 
-	if ($errorNumber && $errorNumber != 201) {
-		$fileUrl = "";
-		$fileName = "";
-	}
+    if ($errorNumber && $errorNumber != 201) {
+        $fileUrl = "";
+        $fileName = "";
+    }
 
-	$rpl = array( '\\' => '\\\\', '"' => '\\"' );
-	echo 'window.parent.OnUploadCompleted(' . $errorNumber . ',"' . strtr($fileUrl, $rpl) . '","' . strtr($fileName, $rpl) . '", "' . strtr($customMsg, $rpl) . '");' ;
-	echo '</script>' ;
-	exit ;
+    $rpl = array( '\\' => '\\\\', '"' => '\\"' );
+    echo 'window.parent.OnUploadCompleted(' . $errorNumber . ',"' . strtr($fileUrl, $rpl) . '","' . strtr($fileName, $rpl) . '", "' . strtr($customMsg, $rpl) . '");' ;
+    echo '</script>' ;
+    exit ;
 }
 
 
@@ -401,11 +401,11 @@ 
  */
 function SendCKEditorResults($callback, $sFileUrl, $customMsg = '')
 {
-  echo '<script type="text/javascript">';
+    echo '<script type="text/javascript">';
 
-  $rpl = array( '\\' => '\\\\', '"' => '\\"' );
+    $rpl = array( '\\' => '\\\\', '"' => '\\"' );
 
-  echo 'window.parent.CKEDITOR.tools.callFunction("'. $callback. '","'. strtr($sFileUrl, $rpl). '", "'. strtr($customMsg, $rpl). '");' ;
+    echo 'window.parent.CKEDITOR.tools.callFunction("'. $callback. '","'. strtr($sFileUrl, $rpl). '", "'. strtr($customMsg, $rpl). '");' ;
 
-  echo '</script>';
+    echo '</script>';
 }

Spacing +69 added lines, -69 removed lines

@@ -29,9 +29,9 @@ 
  * @param   string $sFolder       sFolder
  * @return  string                Combined path
  */
-function CombinePaths( $sBasePath, $sFolder )
+function CombinePaths($sBasePath, $sFolder)
 {
-	return RemoveFromEnd($sBasePath, '/') . '/' . RemoveFromStart($sFolder, '/');
+	return RemoveFromEnd($sBasePath, '/').'/'.RemoveFromStart($sFolder, '/');
 }
 /**
  * GetResourceTypePath
@@ -42,12 +42,12 @@ 
  */
 function GetResourceTypePath($resourceType, $sCommand)
 {
-	global $Config ;
+	global $Config;
 
 	if ($sCommand == "QuickUpload")
-		return $Config['QuickUploadPath'][$resourceType] ;
+		return $Config['QuickUploadPath'][$resourceType];
 	else
-		return $Config['FileTypesPath'][$resourceType] ;
+		return $Config['FileTypesPath'][$resourceType];
 }
 
 /**
@@ -59,19 +59,19 @@ 
  */
 function GetResourceTypeDirectory($resourceType, $sCommand)
 {
-	global $Config ;
+	global $Config;
 	if ($sCommand == "QuickUpload")
 	{
-		if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0)
-			return $Config['QuickUploadAbsolutePath'][$resourceType] ;
+		if (strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0)
+			return $Config['QuickUploadAbsolutePath'][$resourceType];
 
 		// Map the "UserFiles" path to a local directory.
 		return Server_MapPath($Config['QuickUploadPath'][$resourceType]);
 	}
 	else
 	{
-		if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0)
-			return $Config['FileTypesAbsolutePath'][$resourceType] ;
+		if (strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0)
+			return $Config['FileTypesAbsolutePath'][$resourceType];
 
 		// Map the "UserFiles" path to a local directory.
 		return Server_MapPath($Config['FileTypesPath'][$resourceType]);
@@ -116,7 +116,7 @@ 
 
 	// Ensure that the directory exists.
 	$sErrorMsg = CreateServerFolder($sResourceTypePath);
-	if ( $sErrorMsg != '' )
+	if ($sErrorMsg != '')
 		SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
 
 	// Return the resource type directory combined with the required path.
@@ -131,7 +131,7 @@ 
  */
 function GetParentFolder($folderPath)
 {
-    $sPattern = "-[/\\\\][^/\\\\]+[/\\\\]?$-" ;
+    $sPattern = "-[/\\\\][^/\\\\]+[/\\\\]?$-";
     return preg_replace($sPattern, '', $folderPath);
 }
 
@@ -144,50 +144,50 @@ 
  */
 function CreateServerFolder($folderPath, $lastFolder = null)
 {
-	global $Config ;
+	global $Config;
 	$sParent = GetParentFolder($folderPath);
 
 	// Ensure the folder path has no double-slashes, or mkdir may fail on certain platforms
-	while ( strpos($folderPath, '//') !== false )
+	while (strpos($folderPath, '//') !== false)
 	{
 		$folderPath = str_replace('//', '/', $folderPath);
 	}
 
 	// Check if the parent exists, or create it.
-	if ( !empty($sParent) && !file_exists($sParent))
+	if (!empty($sParent) && !file_exists($sParent))
 	{
 		//prevents agains infinite loop when we can't create root folder
-		if ( !is_null($lastFolder) && $lastFolder === $sParent) {
-			return "Can't create $folderPath directory" ;
+		if (!is_null($lastFolder) && $lastFolder === $sParent) {
+			return "Can't create $folderPath directory";
 		}
 
 		$sErrorMsg = CreateServerFolder($sParent, $folderPath);
-		if ( $sErrorMsg != '' )
-			return $sErrorMsg ;
+		if ($sErrorMsg != '')
+			return $sErrorMsg;
 	}
 
-	if ( !file_exists($folderPath))
+	if (!file_exists($folderPath))
 	{
 		// Turn off all error reporting.
 		error_reporting(0);
 
-		$php_errormsg = '' ;
+		$php_errormsg = '';
 		// Enable error tracking to catch the error.
 		ini_set('track_errors', '1');
 
-		if ( isset( $Config['ChmodOnFolderCreate'] ) && !$Config['ChmodOnFolderCreate'] )
+		if (isset($Config['ChmodOnFolderCreate']) && !$Config['ChmodOnFolderCreate'])
 		{
 			mkdir($folderPath);
 		}
 		else
 		{
 			$permissions = '0777';
-			if ( isset( $Config['ChmodOnFolderCreate'] ) && $Config['ChmodOnFolderCreate'])
+			if (isset($Config['ChmodOnFolderCreate']) && $Config['ChmodOnFolderCreate'])
 			{
 				$permissions = (string) $Config['ChmodOnFolderCreate'];
 			}
 			$permissionsdec = octdec($permissions);
-			$permissionsdec |= octdec('0111');  // Set x bit required for directories
+			$permissionsdec |= octdec('0111'); // Set x bit required for directories
 			dol_syslog("io.php permission = ".$permissions." ".$permissionsdec." ".decoct($permissionsdec));
 			// To create the folder with 0777 permissions, we need to set umask to zero.
 			$oldumask = umask(0);
@@ -195,16 +195,16 @@ 
 			umask($oldumask);
 		}
 
-		$sErrorMsg = $php_errormsg ;
+		$sErrorMsg = $php_errormsg;
 
 		// Restore the configurations.
 		ini_restore('track_errors');
 		ini_restore('error_reporting');
 
-		return $sErrorMsg ;
+		return $sErrorMsg;
 	}
 	else
-		return '' ;
+		return '';
 }
 
 /**
@@ -219,9 +219,9 @@ 
     }
     $sRealPath = realpath('./');
     // #2124 ensure that no slash is at the end
-    $sRealPath = rtrim($sRealPath,"\\/");
+    $sRealPath = rtrim($sRealPath, "\\/");
 
-    $sSelfPath = $_SERVER['PHP_SELF'] ;
+    $sSelfPath = $_SERVER['PHP_SELF'];
     $sSelfPath = substr($sSelfPath, 0, strrpos($sSelfPath, '/'));
 
     $sSelfPath = str_replace('/', DIRECTORY_SEPARATOR, $sSelfPath);
@@ -230,7 +230,7 @@ 
 
     // This can check only that this script isn't run from a virtual dir
     // But it avoids the problems that arise if it isn't checked
-    if ( $position === false || $position <> strlen($sRealPath) - strlen($sSelfPath) )
+    if ($position === false || $position <> strlen($sRealPath) - strlen($sSelfPath))
         SendError(1, 'Sorry, can\'t map "UserFilesPath" to a physical path. You must set the "UserFilesAbsolutePath" value in "editor/filemanager/connectors/php/config.php".');
 
     return substr($sRealPath, 0, $position);
@@ -238,17 +238,17 @@ 
 
 // Emulate the asp Server.mapPath function.
 // given an url path return the physical directory that it corresponds to
-function Server_MapPath( $path )
+function Server_MapPath($path)
 {
     // This function is available only for Apache
     if (function_exists('apache_lookup_uri')) {
         $info = apache_lookup_uri($path);
-        return $info->filename . $info->path_info ;
+        return $info->filename.$info->path_info;
     }
 
     // This isn't correct but for the moment there's no other solution
     // If this script is under a virtual directory or symlink it will detect the problem and stop
-    return GetRootPath() . $path ;
+    return GetRootPath().$path;
 }
 
 /**
@@ -260,18 +260,18 @@ 
  */
 function IsAllowedExt($sExtension, $resourceType)
 {
-	global $Config ;
+	global $Config;
 	// Get the allowed and denied extensions arrays.
-	$arAllowed	= $Config['AllowedExtensions'][$resourceType] ;
-	$arDenied	= $Config['DeniedExtensions'][$resourceType] ;
+	$arAllowed = $Config['AllowedExtensions'][$resourceType];
+	$arDenied = $Config['DeniedExtensions'][$resourceType];
 
-	if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed))
-		return false ;
+	if (count($arAllowed) > 0 && !in_array($sExtension, $arAllowed))
+		return false;
 
-	if ( count($arDenied) > 0 && in_array($sExtension, $arDenied))
-		return false ;
+	if (count($arDenied) > 0 && in_array($sExtension, $arDenied))
+		return false;
 
-	return true ;
+	return true;
 }
 
 /**
@@ -282,11 +282,11 @@ 
  */
 function IsAllowedType($resourceType)
 {
-	global $Config ;
-	if ( !in_array($resourceType, $Config['ConfigAllowedTypes']))
-		return false ;
+	global $Config;
+	if (!in_array($resourceType, $Config['ConfigAllowedTypes']))
+		return false;
 
-	return true ;
+	return true;
 }
 
 /**
@@ -297,12 +297,12 @@ 
  */
 function IsAllowedCommand($sCommand)
 {
-	global $Config ;
+	global $Config;
 
-	if (! in_array($sCommand, $Config['ConfigAllowedCommands']))
-		return false ;
+	if (!in_array($sCommand, $Config['ConfigAllowedCommands']))
+		return false;
 
-	return true ;
+	return true;
 }
 
 /**
@@ -315,59 +315,59 @@ 
 	if (!isset($_GET)) {
 		global $_GET;
 	}
-	$sCurrentFolder	= isset( $_GET['CurrentFolder'] ) ? GETPOST('CurrentFolder', '', 1) : '/' ;
+	$sCurrentFolder = isset($_GET['CurrentFolder']) ? GETPOST('CurrentFolder', '', 1) : '/';
 
 	// Check the current folder syntax (must begin and start with a slash).
 	if (!preg_match('|/$|', $sCurrentFolder))
-		$sCurrentFolder .= '/' ;
+		$sCurrentFolder .= '/';
 	if (strpos($sCurrentFolder, '/') !== 0)
-		$sCurrentFolder = '/' . $sCurrentFolder ;
+		$sCurrentFolder = '/'.$sCurrentFolder;
 
 	// Ensure the folder path has no double-slashes
-	while ( strpos($sCurrentFolder, '//') !== false ) {
+	while (strpos($sCurrentFolder, '//') !== false) {
 		$sCurrentFolder = str_replace('//', '/', $sCurrentFolder);
 	}
 
 	// Check for invalid folder paths (..)
-	if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\"))
+	if (strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\"))
 		SendError(102, '');
 
-	if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder))
+	if (preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder))
 		SendError(102, '');
 
-	return $sCurrentFolder ;
+	return $sCurrentFolder;
 }
 
 // Do a cleanup of the folder name to avoid possible problems
-function SanitizeFolderName( $sNewFolderName )
+function SanitizeFolderName($sNewFolderName)
 {
 	$sNewFolderName = stripslashes($sNewFolderName);
 
 	// Remove . \ / | : ? * " < >
 	$sNewFolderName = preg_replace('/\\.|\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFolderName);
 
-	return $sNewFolderName ;
+	return $sNewFolderName;
 }
 
 // Do a cleanup of the file name to avoid possible problems
-function SanitizeFileName( $sNewFileName )
+function SanitizeFileName($sNewFileName)
 {
-	global $Config ;
+	global $Config;
 
 	$sNewFileName = stripslashes($sNewFileName);
 
 	// Replace dots in the name with underscores (only one dot can be there... security issue).
-	if ( $Config['ForceSingleExtension'] )
+	if ($Config['ForceSingleExtension'])
 		$sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
 
 	// Remove \ / | : ? * " < >
 	$sNewFileName = preg_replace('/\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFileName);
 
-	return $sNewFileName ;
+	return $sNewFileName;
 }
 
 // This is the function that sends the results of the uploading process.
-function SendUploadResults( $errorNumber, $fileUrl = '', $fileName = '', $customMsg = '' )
+function SendUploadResults($errorNumber, $fileUrl = '', $fileName = '', $customMsg = '')
 {
 	// Minified version of the document.domain automatic fix script (#1919).
 	// The original script can be found at _dev/domain_fix_template.js
@@ -381,10 +381,10 @@ 
 		$fileName = "";
 	}
 
-	$rpl = array( '\\' => '\\\\', '"' => '\\"' );
-	echo 'window.parent.OnUploadCompleted(' . $errorNumber . ',"' . strtr($fileUrl, $rpl) . '","' . strtr($fileName, $rpl) . '", "' . strtr($customMsg, $rpl) . '");' ;
-	echo '</script>' ;
-	exit ;
+	$rpl = array('\\' => '\\\\', '"' => '\\"');
+	echo 'window.parent.OnUploadCompleted('.$errorNumber.',"'.strtr($fileUrl, $rpl).'","'.strtr($fileName, $rpl).'", "'.strtr($customMsg, $rpl).'");';
+	echo '</script>';
+	exit;
 }
 
 
@@ -403,9 +403,9 @@ 
 {
   echo '<script type="text/javascript">';
 
-  $rpl = array( '\\' => '\\\\', '"' => '\\"' );
+  $rpl = array('\\' => '\\\\', '"' => '\\"');
 
-  echo 'window.parent.CKEDITOR.tools.callFunction("'. $callback. '","'. strtr($sFileUrl, $rpl). '", "'. strtr($customMsg, $rpl). '");' ;
+  echo 'window.parent.CKEDITOR.tools.callFunction("'.$callback.'","'.strtr($sFileUrl, $rpl).'", "'.strtr($customMsg, $rpl).'");';
 
   echo '</script>';
 }

Braces +53 added lines, -40 removed lines

@@ -44,11 +44,12 @@ 
 {
 	global $Config ;
 
-	if ($sCommand == "QuickUpload")
-		return $Config['QuickUploadPath'][$resourceType] ;
-	else
-		return $Config['FileTypesPath'][$resourceType] ;
-}
+	if ($sCommand == "QuickUpload") {
+			return $Config['QuickUploadPath'][$resourceType] ;
+	} else {
+			return $Config['FileTypesPath'][$resourceType] ;
+	}
+	}
 
 /**
  * GetResourceTypeDirectory
@@ -62,16 +63,17 @@ 
 	global $Config ;
 	if ($sCommand == "QuickUpload")
 	{
-		if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0)
-			return $Config['QuickUploadAbsolutePath'][$resourceType] ;
+		if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0) {
+					return $Config['QuickUploadAbsolutePath'][$resourceType] ;
+		}
 
 		// Map the "UserFiles" path to a local directory.
 		return Server_MapPath($Config['QuickUploadPath'][$resourceType]);
-	}
-	else
+	} else
 	{
-		if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0)
-			return $Config['FileTypesAbsolutePath'][$resourceType] ;
+		if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0) {
+					return $Config['FileTypesAbsolutePath'][$resourceType] ;
+		}
 
 		// Map the "UserFiles" path to a local directory.
 		return Server_MapPath($Config['FileTypesPath'][$resourceType]);
@@ -116,8 +118,9 @@ 
 
 	// Ensure that the directory exists.
 	$sErrorMsg = CreateServerFolder($sResourceTypePath);
-	if ( $sErrorMsg != '' )
-		SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
+	if ( $sErrorMsg != '' ) {
+			SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
+	}
 
 	// Return the resource type directory combined with the required path.
 	return CombinePaths($sResourceTypePath, $folderPath);
@@ -162,8 +165,9 @@ 
 		}
 
 		$sErrorMsg = CreateServerFolder($sParent, $folderPath);
-		if ( $sErrorMsg != '' )
-			return $sErrorMsg ;
+		if ( $sErrorMsg != '' ) {
+					return $sErrorMsg ;
+		}
 	}
 
 	if ( !file_exists($folderPath))
@@ -178,8 +182,7 @@ 
 		if ( isset( $Config['ChmodOnFolderCreate'] ) && !$Config['ChmodOnFolderCreate'] )
 		{
 			mkdir($folderPath);
-		}
-		else
+		} else
 		{
 			$permissions = '0777';
 			if ( isset( $Config['ChmodOnFolderCreate'] ) && $Config['ChmodOnFolderCreate'])
@@ -202,10 +205,10 @@ 
 		ini_restore('error_reporting');
 
 		return $sErrorMsg ;
+	} else {
+			return '' ;
+	}
 	}
-	else
-		return '' ;
-}
 
 /**
  * Get Root Path
@@ -230,8 +233,9 @@ 
 
     // This can check only that this script isn't run from a virtual dir
     // But it avoids the problems that arise if it isn't checked
-    if ( $position === false || $position <> strlen($sRealPath) - strlen($sSelfPath) )
-        SendError(1, 'Sorry, can\'t map "UserFilesPath" to a physical path. You must set the "UserFilesAbsolutePath" value in "editor/filemanager/connectors/php/config.php".');
+    if ( $position === false || $position <> strlen($sRealPath) - strlen($sSelfPath) ) {
+            SendError(1, 'Sorry, can\'t map "UserFilesPath" to a physical path. You must set the "UserFilesAbsolutePath" value in "editor/filemanager/connectors/php/config.php".');
+    }
 
     return substr($sRealPath, 0, $position);
 }
@@ -265,11 +269,13 @@ 
 	$arAllowed	= $Config['AllowedExtensions'][$resourceType] ;
 	$arDenied	= $Config['DeniedExtensions'][$resourceType] ;
 
-	if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed))
-		return false ;
+	if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed)) {
+			return false ;
+	}
 
-	if ( count($arDenied) > 0 && in_array($sExtension, $arDenied))
-		return false ;
+	if ( count($arDenied) > 0 && in_array($sExtension, $arDenied)) {
+			return false ;
+	}
 
 	return true ;
 }
@@ -283,8 +289,9 @@ 
 function IsAllowedType($resourceType)
 {
 	global $Config ;
-	if ( !in_array($resourceType, $Config['ConfigAllowedTypes']))
-		return false ;
+	if ( !in_array($resourceType, $Config['ConfigAllowedTypes'])) {
+			return false ;
+	}
 
 	return true ;
 }
@@ -299,8 +306,9 @@ 
 {
 	global $Config ;
 
-	if (! in_array($sCommand, $Config['ConfigAllowedCommands']))
-		return false ;
+	if (! in_array($sCommand, $Config['ConfigAllowedCommands'])) {
+			return false ;
+	}
 
 	return true ;
 }
@@ -318,10 +326,12 @@ 
 	$sCurrentFolder	= isset( $_GET['CurrentFolder'] ) ? GETPOST('CurrentFolder', '', 1) : '/' ;
 
 	// Check the current folder syntax (must begin and start with a slash).
-	if (!preg_match('|/$|', $sCurrentFolder))
-		$sCurrentFolder .= '/' ;
-	if (strpos($sCurrentFolder, '/') !== 0)
-		$sCurrentFolder = '/' . $sCurrentFolder ;
+	if (!preg_match('|/$|', $sCurrentFolder)) {
+			$sCurrentFolder .= '/' ;
+	}
+	if (strpos($sCurrentFolder, '/') !== 0) {
+			$sCurrentFolder = '/' . $sCurrentFolder ;
+	}
 
 	// Ensure the folder path has no double-slashes
 	while ( strpos($sCurrentFolder, '//') !== false ) {
@@ -329,11 +339,13 @@ 
 	}
 
 	// Check for invalid folder paths (..)
-	if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\"))
-		SendError(102, '');
+	if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\")) {
+			SendError(102, '');
+	}
 
-	if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder))
-		SendError(102, '');
+	if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder)) {
+			SendError(102, '');
+	}
 
 	return $sCurrentFolder ;
 }
@@ -357,8 +369,9 @@ 
 	$sNewFileName = stripslashes($sNewFileName);
 
 	// Replace dots in the name with underscores (only one dot can be there... security issue).
-	if ( $Config['ForceSingleExtension'] )
-		$sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
+	if ( $Config['ForceSingleExtension'] ) {
+			$sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
+	}
 
 	// Remove \ / | : ? * " < >
 	$sNewFileName = preg_replace('/\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFileName);

dolibarr/htdocs/core/filemanagerdol/connectors/php/commands.php

Indentation +246 added lines, -246 removed lines

@@ -31,33 +31,33 @@ 
  */
 function GetFolders($resourceType, $currentFolder)
 {
-	// Map the virtual path to the local server path.
-	$sServerDir = ServerMapFolder($resourceType, $currentFolder, 'GetFolders');
+    // Map the virtual path to the local server path.
+    $sServerDir = ServerMapFolder($resourceType, $currentFolder, 'GetFolders');
 
-	// Array that will hold the folders names.
-	$aFolders	= array();
+    // Array that will hold the folders names.
+    $aFolders	= array();
 
-	$oCurrentFolder = @opendir($sServerDir);
+    $oCurrentFolder = @opendir($sServerDir);
 
-	if ($oCurrentFolder !== false)
-	{
-		while ( $sFile = readdir($oCurrentFolder) )
-		{
-			if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) )
-				$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
-		}
-		closedir($oCurrentFolder);
-	}
+    if ($oCurrentFolder !== false)
+    {
+        while ( $sFile = readdir($oCurrentFolder) )
+        {
+            if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) )
+                $aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+        }
+        closedir($oCurrentFolder);
+    }
 
-	// Open the "Folders" node.
-	echo "<Folders>" ;
+    // Open the "Folders" node.
+    echo "<Folders>" ;
 
-	natcasesort($aFolders);
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+    natcasesort($aFolders);
+    foreach ( $aFolders as $sFolder )
+        echo $sFolder ;
 
-	// Close the "Folders" node.
-	echo "</Folders>" ;
+    // Close the "Folders" node.
+    echo "</Folders>" ;
 }
 
 /**
@@ -69,60 +69,60 @@ 
  */
 function GetFoldersAndFiles( $resourceType, $currentFolder )
 {
-	// Map the virtual path to the local server path.
-	$sServerDir = ServerMapFolder($resourceType, $currentFolder, 'GetFoldersAndFiles');
-
-	// Arrays that will hold the folders and files names.
-	$aFolders	= array();
-	$aFiles		= array();
-
-	$oCurrentFolder = @opendir($sServerDir);
-
-	if ($oCurrentFolder !== false)
-	{
-		while ( $sFile = readdir($oCurrentFolder) )
-		{
-			if ( $sFile != '.' && $sFile != '..' )
-			{
-				if ( is_dir($sServerDir . $sFile) )
-					$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
-				else
-				{
-					$iFileSize = @filesize($sServerDir . $sFile);
-					if ( !$iFileSize ) {
-						$iFileSize = 0 ;
-					}
-					if ( $iFileSize > 0 )
-					{
-						$iFileSize = round($iFileSize / 1024);
-						if ( $iFileSize < 1 )
-							$iFileSize = 1 ;
-					}
-
-					$aFiles[] = '<File name="' . ConvertToXmlAttribute($sFile) . '" size="' . $iFileSize . '" />' ;
-				}
-			}
-		}
-		closedir($oCurrentFolder);
-	}
-
-	// Send the folders
-	natcasesort($aFolders);
-	echo '<Folders>' ;
-
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
-
-	echo '</Folders>' ;
-
-	// Send the files
-	natcasesort($aFiles);
-	echo '<Files>' ;
-
-	foreach ( $aFiles as $sFiles )
-		echo $sFiles ;
-
-	echo '</Files>' ;
+    // Map the virtual path to the local server path.
+    $sServerDir = ServerMapFolder($resourceType, $currentFolder, 'GetFoldersAndFiles');
+
+    // Arrays that will hold the folders and files names.
+    $aFolders	= array();
+    $aFiles		= array();
+
+    $oCurrentFolder = @opendir($sServerDir);
+
+    if ($oCurrentFolder !== false)
+    {
+        while ( $sFile = readdir($oCurrentFolder) )
+        {
+            if ( $sFile != '.' && $sFile != '..' )
+            {
+                if ( is_dir($sServerDir . $sFile) )
+                    $aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+                else
+                {
+                    $iFileSize = @filesize($sServerDir . $sFile);
+                    if ( !$iFileSize ) {
+                        $iFileSize = 0 ;
+                    }
+                    if ( $iFileSize > 0 )
+                    {
+                        $iFileSize = round($iFileSize / 1024);
+                        if ( $iFileSize < 1 )
+                            $iFileSize = 1 ;
+                    }
+
+                    $aFiles[] = '<File name="' . ConvertToXmlAttribute($sFile) . '" size="' . $iFileSize . '" />' ;
+                }
+            }
+        }
+        closedir($oCurrentFolder);
+    }
+
+    // Send the folders
+    natcasesort($aFolders);
+    echo '<Folders>' ;
+
+    foreach ( $aFolders as $sFolder )
+        echo $sFolder ;
+
+    echo '</Folders>' ;
+
+    // Send the files
+    natcasesort($aFiles);
+    echo '<Files>' ;
+
+    foreach ( $aFiles as $sFiles )
+        echo $sFiles ;
+
+    echo '</Files>' ;
 }
 
 /**
@@ -134,53 +134,53 @@ 
  */
 function CreateFolder( $resourceType, $currentFolder )
 {
-	if (!isset($_GET)) {
-		global $_GET;
-	}
-	$sErrorNumber	= '0' ;
-	$sErrorMsg		= '' ;
-
-	if ( isset( $_GET['NewFolderName'] ) )
-	{
-		$sNewFolderName = $_GET['NewFolderName'] ;
-		$sNewFolderName = SanitizeFolderName($sNewFolderName);
-
-		if (strpos($sNewFolderName, '..') !== false)
-			$sErrorNumber = '102' ;		// Invalid folder name.
-		else
-		{
-			// Map the virtual path to the local server path of the current folder.
-			$sServerDir = ServerMapFolder($resourceType, $currentFolder, 'CreateFolder');
-
-			if ( is_writable($sServerDir) )
-			{
-				$sServerDir .= $sNewFolderName ;
-
-				$sErrorMsg = CreateServerFolder($sServerDir);
-
-				switch ( $sErrorMsg )
-				{
-					case '':
-						$sErrorNumber = '0' ;
-						break;
-					case 'Invalid argument' :
-					case 'No such file or directory' :
-						$sErrorNumber = '102' ;		// Path too long.
-						break ;
-					default:
-						$sErrorNumber = '110' ;
-						break ;
-				}
-			}
-			else
-				$sErrorNumber = '103' ;
-		}
-	}
-	else
-		$sErrorNumber = '102' ;
-
-	// Create the "Error" node.
-	echo '<Error number="' . $sErrorNumber . '" />' ;
+    if (!isset($_GET)) {
+        global $_GET;
+    }
+    $sErrorNumber	= '0' ;
+    $sErrorMsg		= '' ;
+
+    if ( isset( $_GET['NewFolderName'] ) )
+    {
+        $sNewFolderName = $_GET['NewFolderName'] ;
+        $sNewFolderName = SanitizeFolderName($sNewFolderName);
+
+        if (strpos($sNewFolderName, '..') !== false)
+            $sErrorNumber = '102' ;		// Invalid folder name.
+        else
+        {
+            // Map the virtual path to the local server path of the current folder.
+            $sServerDir = ServerMapFolder($resourceType, $currentFolder, 'CreateFolder');
+
+            if ( is_writable($sServerDir) )
+            {
+                $sServerDir .= $sNewFolderName ;
+
+                $sErrorMsg = CreateServerFolder($sServerDir);
+
+                switch ( $sErrorMsg )
+                {
+                    case '':
+                        $sErrorNumber = '0' ;
+                        break;
+                    case 'Invalid argument' :
+                    case 'No such file or directory' :
+                        $sErrorNumber = '102' ;		// Path too long.
+                        break ;
+                    default:
+                        $sErrorNumber = '110' ;
+                        break ;
+                }
+            }
+            else
+                $sErrorNumber = '103' ;
+        }
+    }
+    else
+        $sErrorNumber = '102' ;
+
+    // Create the "Error" node.
+    echo '<Error number="' . $sErrorNumber . '" />' ;
 }
 
 // @CHANGE
@@ -196,134 +196,134 @@ 
  */
 function FileUpload($resourceType, $currentFolder, $sCommand, $CKEcallback = '')
 {
-	if (!isset($_FILES)) {
-		global $_FILES;
-	}
-	$sErrorNumber = '0' ;
-	$sFileName = '' ;
-
-	if ( isset( $_FILES['NewFile'] ) && !is_null($_FILES['NewFile']['tmp_name'])
-       // This is for the QuickUpload tab box
+    if (!isset($_FILES)) {
+        global $_FILES;
+    }
+    $sErrorNumber = '0' ;
+    $sFileName = '' ;
+
+    if ( isset( $_FILES['NewFile'] ) && !is_null($_FILES['NewFile']['tmp_name'])
+        // This is for the QuickUpload tab box
         or (isset($_FILES['upload']) && !is_null($_FILES['upload']['tmp_name'])))
-	{
-		global $Config ;
-
-		$oFile = isset($_FILES['NewFile']) ? $_FILES['NewFile'] : $_FILES['upload'];
-
-		// Map the virtual path to the local server path.
-		$sServerDir = ServerMapFolder($resourceType, $currentFolder, $sCommand);
-
-		// Get the uploaded file name.
-		$sFileName = $oFile['name'] ;
-		$sFileName = SanitizeFileName($sFileName);
-
-		$sOriginalFileName = $sFileName ;
-
-		// Get the extension.
-		$sExtension = substr($sFileName, (strrpos($sFileName, '.') + 1));
-		$sExtension = strtolower($sExtension);
-
-		if ( isset( $Config['SecureImageUploads'] ) )
-		{
-			if ( ( $isImageValid = IsImageValid($oFile['tmp_name'], $sExtension) ) === false )
-			{
-				$sErrorNumber = '202' ;
-			}
-		}
-
-		if ( isset( $Config['HtmlExtensions'] ) )
-		{
-			if (!IsHtmlExtension($sExtension, $Config['HtmlExtensions']) &&
-				($detectHtml = DetectHtml($oFile['tmp_name'])) === true)
-			{
-				$sErrorNumber = '202' ;
-			}
-		}
-
-		// Check if it is an allowed extension.
-		if ( !$sErrorNumber && IsAllowedExt($sExtension, $resourceType) )
-		{
-			$iCounter = 0 ;
-
-			while ( true )
-			{
-				$sFilePath = $sServerDir . $sFileName ;
-
-				if ( is_file($sFilePath) )
-				{
-					$iCounter++ ;
-					$sFileName = RemoveExtension($sOriginalFileName) . '(' . $iCounter . ').' . $sExtension ;
-					$sErrorNumber = '201' ;
-				}
-				else
-				{
-					move_uploaded_file($oFile['tmp_name'], $sFilePath);
-
-					if ( is_file($sFilePath) )
-					{
-						if ( isset( $Config['ChmodOnUpload'] ) && !$Config['ChmodOnUpload'] )
-						{
-							break ;
-						}
-
-						$permissions = '0777';
-						if ( isset( $Config['ChmodOnUpload'] ) && $Config['ChmodOnUpload'] )
-						{
-							$permissions = (string) $Config['ChmodOnUpload'] ;
-						}
-						$permissionsdec = octdec($permissions);
-						dol_syslog("commands.php permission = ".$permissions." ".$permissionsdec." ".decoct($permissionsdec));
-						$oldumask = umask(0);
-						chmod($sFilePath, $permissionsdec);
-						umask($oldumask);
-					}
-
-					break ;
-				}
-			}
-
-			if ( file_exists($sFilePath) )
-			{
-				//previous checks failed, try once again
-				if ( isset( $isImageValid ) && $isImageValid === -1 && IsImageValid($sFilePath, $sExtension) === false )
-				{
-					@unlink($sFilePath);
-					$sErrorNumber = '202' ;
-				}
-				else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
-				{
-					@unlink($sFilePath);
-					$sErrorNumber = '202' ;
-				}
-			}
-		}
-		else
-			$sErrorNumber = '202' ;
-	}
-	else
-		$sErrorNumber = '202' ;
-
-
-	$sFileUrl = CombinePaths(GetResourceTypePath($resourceType, $sCommand), $currentFolder);
-	$sFileUrl = CombinePaths($sFileUrl, $sFileName);
-
-
-	// @CHANGE
-	//SendUploadResults( $sErrorNumber, $sFileUrl, $sFileName );
-	if($CKEcallback == '')
+    {
+        global $Config ;
+
+        $oFile = isset($_FILES['NewFile']) ? $_FILES['NewFile'] : $_FILES['upload'];
+
+        // Map the virtual path to the local server path.
+        $sServerDir = ServerMapFolder($resourceType, $currentFolder, $sCommand);
+
+        // Get the uploaded file name.
+        $sFileName = $oFile['name'] ;
+        $sFileName = SanitizeFileName($sFileName);
+
+        $sOriginalFileName = $sFileName ;
+
+        // Get the extension.
+        $sExtension = substr($sFileName, (strrpos($sFileName, '.') + 1));
+        $sExtension = strtolower($sExtension);
+
+        if ( isset( $Config['SecureImageUploads'] ) )
+        {
+            if ( ( $isImageValid = IsImageValid($oFile['tmp_name'], $sExtension) ) === false )
+            {
+                $sErrorNumber = '202' ;
+            }
+        }
+
+        if ( isset( $Config['HtmlExtensions'] ) )
+        {
+            if (!IsHtmlExtension($sExtension, $Config['HtmlExtensions']) &&
+                ($detectHtml = DetectHtml($oFile['tmp_name'])) === true)
+            {
+                $sErrorNumber = '202' ;
+            }
+        }
+
+        // Check if it is an allowed extension.
+        if ( !$sErrorNumber && IsAllowedExt($sExtension, $resourceType) )
+        {
+            $iCounter = 0 ;
+
+            while ( true )
+            {
+                $sFilePath = $sServerDir . $sFileName ;
+
+                if ( is_file($sFilePath) )
+                {
+                    $iCounter++ ;
+                    $sFileName = RemoveExtension($sOriginalFileName) . '(' . $iCounter . ').' . $sExtension ;
+                    $sErrorNumber = '201' ;
+                }
+                else
+                {
+                    move_uploaded_file($oFile['tmp_name'], $sFilePath);
+
+                    if ( is_file($sFilePath) )
+                    {
+                        if ( isset( $Config['ChmodOnUpload'] ) && !$Config['ChmodOnUpload'] )
+                        {
+                            break ;
+                        }
+
+                        $permissions = '0777';
+                        if ( isset( $Config['ChmodOnUpload'] ) && $Config['ChmodOnUpload'] )
+                        {
+                            $permissions = (string) $Config['ChmodOnUpload'] ;
+                        }
+                        $permissionsdec = octdec($permissions);
+                        dol_syslog("commands.php permission = ".$permissions." ".$permissionsdec." ".decoct($permissionsdec));
+                        $oldumask = umask(0);
+                        chmod($sFilePath, $permissionsdec);
+                        umask($oldumask);
+                    }
+
+                    break ;
+                }
+            }
+
+            if ( file_exists($sFilePath) )
+            {
+                //previous checks failed, try once again
+                if ( isset( $isImageValid ) && $isImageValid === -1 && IsImageValid($sFilePath, $sExtension) === false )
+                {
+                    @unlink($sFilePath);
+                    $sErrorNumber = '202' ;
+                }
+                else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
+                {
+                    @unlink($sFilePath);
+                    $sErrorNumber = '202' ;
+                }
+            }
+        }
+        else
+            $sErrorNumber = '202' ;
+    }
+    else
+        $sErrorNumber = '202' ;
+
+
+    $sFileUrl = CombinePaths(GetResourceTypePath($resourceType, $sCommand), $currentFolder);
+    $sFileUrl = CombinePaths($sFileUrl, $sFileName);
+
+
+    // @CHANGE
+    //SendUploadResults( $sErrorNumber, $sFileUrl, $sFileName );
+    if($CKEcallback == '')
     {
         // this line already exists so wrap the if block around it
         SendUploadResults($sErrorNumber, $sFileUrl, $sFileName);
     }
     else
-	{
-	    //issue the CKEditor Callback
-		SendCKEditorResults(
-			$CKEcallback,
-			$sFileUrl,
-			($sErrorNumber != 0 ? 'Error '. $sErrorNumber. ' upload failed.' : 'Upload Successful')
-    	);
-	}
-
-	exit;
+    {
+        //issue the CKEditor Callback
+        SendCKEditorResults(
+            $CKEcallback,
+            $sFileUrl,
+            ($sErrorNumber != 0 ? 'Error '. $sErrorNumber. ' upload failed.' : 'Upload Successful')
+        );
+    }
+
+    exit;
 }

Spacing +81 added lines, -81 removed lines

@@ -35,29 +35,29 @@ 
 	$sServerDir = ServerMapFolder($resourceType, $currentFolder, 'GetFolders');
 
 	// Array that will hold the folders names.
-	$aFolders	= array();
+	$aFolders = array();
 
 	$oCurrentFolder = @opendir($sServerDir);
 
 	if ($oCurrentFolder !== false)
 	{
-		while ( $sFile = readdir($oCurrentFolder) )
+		while ($sFile = readdir($oCurrentFolder))
 		{
-			if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) )
-				$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+			if ($sFile != '.' && $sFile != '..' && is_dir($sServerDir.$sFile))
+				$aFolders[] = '<Folder name="'.ConvertToXmlAttribute($sFile).'" />';
 		}
 		closedir($oCurrentFolder);
 	}
 
 	// Open the "Folders" node.
-	echo "<Folders>" ;
+	echo "<Folders>";
 
 	natcasesort($aFolders);
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+	foreach ($aFolders as $sFolder)
+		echo $sFolder;
 
 	// Close the "Folders" node.
-	echo "</Folders>" ;
+	echo "</Folders>";
 }
 
 /**
@@ -67,39 +67,39 @@ 
  * @param	string	$currentFolder	Current folder
  * @return void
  */
-function GetFoldersAndFiles( $resourceType, $currentFolder )
+function GetFoldersAndFiles($resourceType, $currentFolder)
 {
 	// Map the virtual path to the local server path.
 	$sServerDir = ServerMapFolder($resourceType, $currentFolder, 'GetFoldersAndFiles');
 
 	// Arrays that will hold the folders and files names.
-	$aFolders	= array();
-	$aFiles		= array();
+	$aFolders = array();
+	$aFiles = array();
 
 	$oCurrentFolder = @opendir($sServerDir);
 
 	if ($oCurrentFolder !== false)
 	{
-		while ( $sFile = readdir($oCurrentFolder) )
+		while ($sFile = readdir($oCurrentFolder))
 		{
-			if ( $sFile != '.' && $sFile != '..' )
+			if ($sFile != '.' && $sFile != '..')
 			{
-				if ( is_dir($sServerDir . $sFile) )
-					$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+				if (is_dir($sServerDir.$sFile))
+					$aFolders[] = '<Folder name="'.ConvertToXmlAttribute($sFile).'" />';
 				else
 				{
-					$iFileSize = @filesize($sServerDir . $sFile);
-					if ( !$iFileSize ) {
-						$iFileSize = 0 ;
+					$iFileSize = @filesize($sServerDir.$sFile);
+					if (!$iFileSize) {
+						$iFileSize = 0;
 					}
-					if ( $iFileSize > 0 )
+					if ($iFileSize > 0)
 					{
 						$iFileSize = round($iFileSize / 1024);
-						if ( $iFileSize < 1 )
-							$iFileSize = 1 ;
+						if ($iFileSize < 1)
+							$iFileSize = 1;
 					}
 
-					$aFiles[] = '<File name="' . ConvertToXmlAttribute($sFile) . '" size="' . $iFileSize . '" />' ;
+					$aFiles[] = '<File name="'.ConvertToXmlAttribute($sFile).'" size="'.$iFileSize.'" />';
 				}
 			}
 		}
@@ -108,21 +108,21 @@ 
 
 	// Send the folders
 	natcasesort($aFolders);
-	echo '<Folders>' ;
+	echo '<Folders>';
 
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+	foreach ($aFolders as $sFolder)
+		echo $sFolder;
 
-	echo '</Folders>' ;
+	echo '</Folders>';
 
 	// Send the files
 	natcasesort($aFiles);
-	echo '<Files>' ;
+	echo '<Files>';
 
-	foreach ( $aFiles as $sFiles )
-		echo $sFiles ;
+	foreach ($aFiles as $sFiles)
+		echo $sFiles;
 
-	echo '</Files>' ;
+	echo '</Files>';
 }
 
 /**
@@ -132,55 +132,55 @@ 
  * @param   string $currentFolder   Current folder
  * @return void
  */
-function CreateFolder( $resourceType, $currentFolder )
+function CreateFolder($resourceType, $currentFolder)
 {
 	if (!isset($_GET)) {
 		global $_GET;
 	}
-	$sErrorNumber	= '0' ;
-	$sErrorMsg		= '' ;
+	$sErrorNumber = '0';
+	$sErrorMsg = '';
 
-	if ( isset( $_GET['NewFolderName'] ) )
+	if (isset($_GET['NewFolderName']))
 	{
-		$sNewFolderName = $_GET['NewFolderName'] ;
+		$sNewFolderName = $_GET['NewFolderName'];
 		$sNewFolderName = SanitizeFolderName($sNewFolderName);
 
 		if (strpos($sNewFolderName, '..') !== false)
-			$sErrorNumber = '102' ;		// Invalid folder name.
+			$sErrorNumber = '102'; // Invalid folder name.
 		else
 		{
 			// Map the virtual path to the local server path of the current folder.
 			$sServerDir = ServerMapFolder($resourceType, $currentFolder, 'CreateFolder');
 
-			if ( is_writable($sServerDir) )
+			if (is_writable($sServerDir))
 			{
-				$sServerDir .= $sNewFolderName ;
+				$sServerDir .= $sNewFolderName;
 
 				$sErrorMsg = CreateServerFolder($sServerDir);
 
-				switch ( $sErrorMsg )
+				switch ($sErrorMsg)
 				{
 					case '':
-						$sErrorNumber = '0' ;
+						$sErrorNumber = '0';
 						break;
 					case 'Invalid argument' :
 					case 'No such file or directory' :
-						$sErrorNumber = '102' ;		// Path too long.
-						break ;
+						$sErrorNumber = '102'; // Path too long.
+						break;
 					default:
-						$sErrorNumber = '110' ;
-						break ;
+						$sErrorNumber = '110';
+						break;
 				}
 			}
 			else
-				$sErrorNumber = '103' ;
+				$sErrorNumber = '103';
 		}
 	}
 	else
-		$sErrorNumber = '102' ;
+		$sErrorNumber = '102';
 
 	// Create the "Error" node.
-	echo '<Error number="' . $sErrorNumber . '" />' ;
+	echo '<Error number="'.$sErrorNumber.'" />';
 }
 
 // @CHANGE
@@ -199,14 +199,14 @@ 
 	if (!isset($_FILES)) {
 		global $_FILES;
 	}
-	$sErrorNumber = '0' ;
-	$sFileName = '' ;
+	$sErrorNumber = '0';
+	$sFileName = '';
 
-	if ( isset( $_FILES['NewFile'] ) && !is_null($_FILES['NewFile']['tmp_name'])
+	if (isset($_FILES['NewFile']) && !is_null($_FILES['NewFile']['tmp_name'])
        // This is for the QuickUpload tab box
         or (isset($_FILES['upload']) && !is_null($_FILES['upload']['tmp_name'])))
 	{
-		global $Config ;
+		global $Config;
 
 		$oFile = isset($_FILES['NewFile']) ? $_FILES['NewFile'] : $_FILES['upload'];
 
@@ -214,62 +214,62 @@ 
 		$sServerDir = ServerMapFolder($resourceType, $currentFolder, $sCommand);
 
 		// Get the uploaded file name.
-		$sFileName = $oFile['name'] ;
+		$sFileName = $oFile['name'];
 		$sFileName = SanitizeFileName($sFileName);
 
-		$sOriginalFileName = $sFileName ;
+		$sOriginalFileName = $sFileName;
 
 		// Get the extension.
 		$sExtension = substr($sFileName, (strrpos($sFileName, '.') + 1));
 		$sExtension = strtolower($sExtension);
 
-		if ( isset( $Config['SecureImageUploads'] ) )
+		if (isset($Config['SecureImageUploads']))
 		{
-			if ( ( $isImageValid = IsImageValid($oFile['tmp_name'], $sExtension) ) === false )
+			if (($isImageValid = IsImageValid($oFile['tmp_name'], $sExtension)) === false)
 			{
-				$sErrorNumber = '202' ;
+				$sErrorNumber = '202';
 			}
 		}
 
-		if ( isset( $Config['HtmlExtensions'] ) )
+		if (isset($Config['HtmlExtensions']))
 		{
 			if (!IsHtmlExtension($sExtension, $Config['HtmlExtensions']) &&
 				($detectHtml = DetectHtml($oFile['tmp_name'])) === true)
 			{
-				$sErrorNumber = '202' ;
+				$sErrorNumber = '202';
 			}
 		}
 
 		// Check if it is an allowed extension.
-		if ( !$sErrorNumber && IsAllowedExt($sExtension, $resourceType) )
+		if (!$sErrorNumber && IsAllowedExt($sExtension, $resourceType))
 		{
-			$iCounter = 0 ;
+			$iCounter = 0;
 
-			while ( true )
+			while (true)
 			{
-				$sFilePath = $sServerDir . $sFileName ;
+				$sFilePath = $sServerDir.$sFileName;
 
-				if ( is_file($sFilePath) )
+				if (is_file($sFilePath))
 				{
-					$iCounter++ ;
-					$sFileName = RemoveExtension($sOriginalFileName) . '(' . $iCounter . ').' . $sExtension ;
-					$sErrorNumber = '201' ;
+					$iCounter++;
+					$sFileName = RemoveExtension($sOriginalFileName).'('.$iCounter.').'.$sExtension;
+					$sErrorNumber = '201';
 				}
 				else
 				{
 					move_uploaded_file($oFile['tmp_name'], $sFilePath);
 
-					if ( is_file($sFilePath) )
+					if (is_file($sFilePath))
 					{
-						if ( isset( $Config['ChmodOnUpload'] ) && !$Config['ChmodOnUpload'] )
+						if (isset($Config['ChmodOnUpload']) && !$Config['ChmodOnUpload'])
 						{
-							break ;
+							break;
 						}
 
 						$permissions = '0777';
-						if ( isset( $Config['ChmodOnUpload'] ) && $Config['ChmodOnUpload'] )
+						if (isset($Config['ChmodOnUpload']) && $Config['ChmodOnUpload'])
 						{
-							$permissions = (string) $Config['ChmodOnUpload'] ;
+							$permissions = (string) $Config['ChmodOnUpload'];
 						}
 						$permissionsdec = octdec($permissions);
 						dol_syslog("commands.php permission = ".$permissions." ".$permissionsdec." ".decoct($permissionsdec));
@@ -278,30 +278,30 @@ 
 						umask($oldumask);
 					}
 
-					break ;
+					break;
 				}
 			}
 
-			if ( file_exists($sFilePath) )
+			if (file_exists($sFilePath))
 			{
 				//previous checks failed, try once again
-				if ( isset( $isImageValid ) && $isImageValid === -1 && IsImageValid($sFilePath, $sExtension) === false )
+				if (isset($isImageValid) && $isImageValid === -1 && IsImageValid($sFilePath, $sExtension) === false)
 				{
 					@unlink($sFilePath);
-					$sErrorNumber = '202' ;
+					$sErrorNumber = '202';
 				}
-				else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
+				else if (isset($detectHtml) && $detectHtml === -1 && DetectHtml($sFilePath) === true)
 				{
 					@unlink($sFilePath);
-					$sErrorNumber = '202' ;
+					$sErrorNumber = '202';
 				}
 			}
 		}
 		else
-			$sErrorNumber = '202' ;
+			$sErrorNumber = '202';
 	}
 	else
-		$sErrorNumber = '202' ;
+		$sErrorNumber = '202';
 
 
 	$sFileUrl = CombinePaths(GetResourceTypePath($resourceType, $sCommand), $currentFolder);
@@ -310,7 +310,7 @@ 
 
 	// @CHANGE
 	//SendUploadResults( $sErrorNumber, $sFileUrl, $sFileName );
-	if($CKEcallback == '')
+	if ($CKEcallback == '')
     {
         // this line already exists so wrap the if block around it
         SendUploadResults($sErrorNumber, $sFileUrl, $sFileName);
@@ -321,7 +321,7 @@ 
 		SendCKEditorResults(
 			$CKEcallback,
 			$sFileUrl,
-			($sErrorNumber != 0 ? 'Error '. $sErrorNumber. ' upload failed.' : 'Upload Successful')
+			($sErrorNumber != 0 ? 'Error '.$sErrorNumber.' upload failed.' : 'Upload Successful')
     	);
 	}
 

Braces +32 added lines, -28 removed lines

@@ -43,8 +43,9 @@ 
 	{
 		while ( $sFile = readdir($oCurrentFolder) )
 		{
-			if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) )
-				$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+			if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) ) {
+							$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+			}
 		}
 		closedir($oCurrentFolder);
 	}
@@ -53,8 +54,9 @@ 
 	echo "<Folders>" ;
 
 	natcasesort($aFolders);
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+	foreach ( $aFolders as $sFolder ) {
+			echo $sFolder ;
+	}
 
 	// Close the "Folders" node.
 	echo "</Folders>" ;
@@ -84,9 +86,9 @@ 
 		{
 			if ( $sFile != '.' && $sFile != '..' )
 			{
-				if ( is_dir($sServerDir . $sFile) )
-					$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
-				else
+				if ( is_dir($sServerDir . $sFile) ) {
+									$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+				} else
 				{
 					$iFileSize = @filesize($sServerDir . $sFile);
 					if ( !$iFileSize ) {
@@ -95,8 +97,9 @@ 
 					if ( $iFileSize > 0 )
 					{
 						$iFileSize = round($iFileSize / 1024);
-						if ( $iFileSize < 1 )
-							$iFileSize = 1 ;
+						if ( $iFileSize < 1 ) {
+													$iFileSize = 1 ;
+						}
 					}
 
 					$aFiles[] = '<File name="' . ConvertToXmlAttribute($sFile) . '" size="' . $iFileSize . '" />' ;
@@ -110,8 +113,9 @@ 
 	natcasesort($aFolders);
 	echo '<Folders>' ;
 
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+	foreach ( $aFolders as $sFolder ) {
+			echo $sFolder ;
+	}
 
 	echo '</Folders>' ;
 
@@ -119,8 +123,9 @@ 
 	natcasesort($aFiles);
 	echo '<Files>' ;
 
-	foreach ( $aFiles as $sFiles )
-		echo $sFiles ;
+	foreach ( $aFiles as $sFiles ) {
+			echo $sFiles ;
+	}
 
 	echo '</Files>' ;
 }
@@ -145,8 +150,10 @@ 
 		$sNewFolderName = $_GET['NewFolderName'] ;
 		$sNewFolderName = SanitizeFolderName($sNewFolderName);
 
-		if (strpos($sNewFolderName, '..') !== false)
-			$sErrorNumber = '102' ;		// Invalid folder name.
+		if (strpos($sNewFolderName, '..') !== false) {
+					$sErrorNumber = '102' ;
+		}
+		// Invalid folder name.
 		else
 		{
 			// Map the virtual path to the local server path of the current folder.
@@ -171,13 +178,13 @@ 
 						$sErrorNumber = '110' ;
 						break ;
 				}
+			} else {
+							$sErrorNumber = '103' ;
 			}
-			else
-				$sErrorNumber = '103' ;
 		}
+	} else {
+			$sErrorNumber = '102' ;
 	}
-	else
-		$sErrorNumber = '102' ;
 
 	// Create the "Error" node.
 	echo '<Error number="' . $sErrorNumber . '" />' ;
@@ -254,8 +261,7 @@ 
 					$iCounter++ ;
 					$sFileName = RemoveExtension($sOriginalFileName) . '(' . $iCounter . ').' . $sExtension ;
 					$sErrorNumber = '201' ;
-				}
-				else
+				} else
 				{
 					move_uploaded_file($oFile['tmp_name'], $sFilePath);
 
@@ -289,19 +295,18 @@ 
 				{
 					@unlink($sFilePath);
 					$sErrorNumber = '202' ;
-				}
-				else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
+				} else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
 				{
 					@unlink($sFilePath);
 					$sErrorNumber = '202' ;
 				}
 			}
+		} else {
+					$sErrorNumber = '202' ;
 		}
-		else
+	} else {
 			$sErrorNumber = '202' ;
 	}
-	else
-		$sErrorNumber = '202' ;
 
 
 	$sFileUrl = CombinePaths(GetResourceTypePath($resourceType, $sCommand), $currentFolder);
@@ -314,8 +319,7 @@ 
     {
         // this line already exists so wrap the if block around it
         SendUploadResults($sErrorNumber, $sFileUrl, $sFileName);
-    }
-    else
+    } else
 	{
 	    //issue the CKEditor Callback
 		SendCKEditorResults(

dolibarr/htdocs/core/filemanagerdol/connectors/php/config.php

Spacing +34 added lines, -34 removed lines

@@ -22,44 +22,44 @@ 
  * Configuration file for the File Manager Connector for PHP.
  */
 
-global $Config ;
+global $Config;
 global $website;
 
-define('NOTOKENRENEWAL',1); // Disables token renewal
+define('NOTOKENRENEWAL', 1); // Disables token renewal
 
 // We must include the main because this page is
 // a web page that require security controls and
 // is a security hole if anybody can access without
 // being an authenticated user.
 require_once '../../../../main.inc.php';
-$uri=preg_replace('/^http(s?):\/\//i','',$dolibarr_main_url_root);
-$pos = strstr($uri, '/');       // $pos contient alors url sans nom domaine
-if ($pos == '/') $pos = '';     // si $pos vaut /, on le met a ''
+$uri = preg_replace('/^http(s?):\/\//i', '', $dolibarr_main_url_root);
+$pos = strstr($uri, '/'); // $pos contient alors url sans nom domaine
+if ($pos == '/') $pos = ''; // si $pos vaut /, on le met a ''
 define('DOL_URL_ROOT', $pos);
 $entity = ((!empty($_SESSION['dol_entity']) && $_SESSION['dol_entity'] > 1) ? $_SESSION['dol_entity'] : null);
 
 // SECURITY: You must explicitly enable this "connector". (Set it to "true").
 // WARNING: don't just set "$Config['Enabled'] = true ;", you must be sure that only
 //		authenticated users can access this file or use some kind of session checking.
-$Config['Enabled'] = true ;
+$Config['Enabled'] = true;
 
 
 // Path to user files relative to the document root.
-$extEntity=(empty($entity) ? 1 : $entity); // For multicompany with external access
+$extEntity = (empty($entity) ? 1 : $entity); // For multicompany with external access
 
-$Config['UserFilesPath'] = DOL_URL_ROOT.'/viewimage.php?modulepart=medias'.(empty($website)?'':'_'.$website).'&entity='.$extEntity.'&file=' ;
-$Config['UserFilesAbsolutePathRelative'] = (empty($website) ? ((!empty($entity) ? '/' . $entity : '') . '/medias/') : ('/website/'.$website));
+$Config['UserFilesPath'] = DOL_URL_ROOT.'/viewimage.php?modulepart=medias'.(empty($website) ? '' : '_'.$website).'&entity='.$extEntity.'&file=';
+$Config['UserFilesAbsolutePathRelative'] = (empty($website) ? ((!empty($entity) ? '/'.$entity : '').'/medias/') : ('/website/'.$website));
 
 
 // Fill the following value it you prefer to specify the absolute path for the
 // user files directory. Useful if you are using a virtual directory, symbolic
 // link or alias. Examples: 'C:\\MySite\\userfiles\\' or '/root/mysite/userfiles/'.
 // Attention: The above 'UserFilesPath' must point to the same directory.
-$Config['UserFilesAbsolutePath'] = $dolibarr_main_data_root . $Config['UserFilesAbsolutePathRelative'];
+$Config['UserFilesAbsolutePath'] = $dolibarr_main_data_root.$Config['UserFilesAbsolutePathRelative'];
 
 // Due to security issues with Apache modules, it is recommended to leave the
 // following setting enabled.
-$Config['ForceSingleExtension'] = true ;
+$Config['ForceSingleExtension'] = true;
 
 // Perform additional checks for image files.
 // If set to true, validate image size (using getimagesize).
@@ -81,15 +81,15 @@ 
 // Set to 0 to disable this feature.
 // Note: not needed on Windows-based servers.
 $newmask = '0644';
-if (! empty($conf->global->MAIN_UMASK)) $newmask=$conf->global->MAIN_UMASK;
+if (!empty($conf->global->MAIN_UMASK)) $newmask = $conf->global->MAIN_UMASK;
 $Config['ChmodOnUpload'] = $newmask;
 
 // See comments above.
 // Used when creating folders that does not exist.
 $newmask = '0755';
-$dirmaskdec=octdec($newmask);
-if (! empty($conf->global->MAIN_UMASK)) $dirmaskdec=octdec($conf->global->MAIN_UMASK);
-$dirmaskdec |= octdec('0200');  // Set w bit required to be able to create content for recursive subdirs files
+$dirmaskdec = octdec($newmask);
+if (!empty($conf->global->MAIN_UMASK)) $dirmaskdec = octdec($conf->global->MAIN_UMASK);
+$dirmaskdec |= octdec('0200'); // Set w bit required to be able to create content for recursive subdirs files
 $newmask = decoct($dirmaskdec);
 
 $Config['ChmodOnFolderCreate'] = $newmask;
@@ -148,29 +148,29 @@ 
 
 $Config['AllowedExtensions']['File']	= array('7z', 'aiff', 'asf', 'avi', 'bmp', 'csv', 'doc', 'fla', 'flv', 'gif', 'gz', 'gzip', 'jpeg', 'jpg', 'mid', 'mov', 'mp3', 'mp4', 'mpc', 'mpeg', 'mpg', 'ods', 'odt', 'pdf', 'png', 'ppt', 'pxd', 'qt', 'ram', 'rar', 'rm', 'rmi', 'rmvb', 'rtf', 'sdc', 'sitd', 'swf', 'sxc', 'sxw', 'tar', 'tgz', 'tif', 'tiff', 'txt', 'vsd', 'wav', 'wma', 'wmv', 'xls', 'xml', 'zip');
 $Config['DeniedExtensions']['File']		= array();
-$Config['FileTypesPath']['File']		= $Config['UserFilesPath'] . 'file/' ;
-$Config['FileTypesAbsolutePath']['File']= ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'file/' ;
-$Config['QuickUploadPath']['File']		= $Config['UserFilesPath'] ;
-$Config['QuickUploadAbsolutePath']['File']= $Config['UserFilesAbsolutePath'] ;
+$Config['FileTypesPath']['File'] = $Config['UserFilesPath'].'file/';
+$Config['FileTypesAbsolutePath']['File'] = ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'file/';
+$Config['QuickUploadPath']['File'] = $Config['UserFilesPath'];
+$Config['QuickUploadAbsolutePath']['File'] = $Config['UserFilesAbsolutePath'];
 
-$Config['AllowedExtensions']['Image']	= array('bmp','gif','jpeg','jpg','png');
+$Config['AllowedExtensions']['Image'] = array('bmp', 'gif', 'jpeg', 'jpg', 'png');
 $Config['DeniedExtensions']['Image']	= array();
-$Config['FileTypesPath']['Image']		= $Config['UserFilesPath'] . 'image/' ;
-$Config['FileTypesAbsolutePath']['Image']= ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'image/' ;
-$Config['QuickUploadPath']['Image']		= $Config['UserFilesPath'] ;
-$Config['QuickUploadAbsolutePath']['Image']= $Config['UserFilesAbsolutePath'] ;
+$Config['FileTypesPath']['Image'] = $Config['UserFilesPath'].'image/';
+$Config['FileTypesAbsolutePath']['Image'] = ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'image/';
+$Config['QuickUploadPath']['Image']		= $Config['UserFilesPath'];
+$Config['QuickUploadAbsolutePath']['Image'] = $Config['UserFilesAbsolutePath'];
 
-$Config['AllowedExtensions']['Flash']	= array('swf','flv');
+$Config['AllowedExtensions']['Flash'] = array('swf', 'flv');
 $Config['DeniedExtensions']['Flash']	= array();
-$Config['FileTypesPath']['Flash']		= $Config['UserFilesPath'] . 'flash/' ;
-$Config['FileTypesAbsolutePath']['Flash']= ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'flash/' ;
-$Config['QuickUploadPath']['Flash']		= $Config['UserFilesPath'] ;
-$Config['QuickUploadAbsolutePath']['Flash']= $Config['UserFilesAbsolutePath'] ;
+$Config['FileTypesPath']['Flash'] = $Config['UserFilesPath'].'flash/';
+$Config['FileTypesAbsolutePath']['Flash'] = ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'flash/';
+$Config['QuickUploadPath']['Flash']		= $Config['UserFilesPath'];
+$Config['QuickUploadAbsolutePath']['Flash'] = $Config['UserFilesAbsolutePath'];
 
-$Config['AllowedExtensions']['Media']	= array('aiff', 'asf', 'avi', 'bmp', 'fla', 'flv', 'gif', 'jpeg', 'jpg', 'mid', 'mov', 'mp3', 'mp4', 'mpc', 'mpeg', 'mpg', 'png', 'qt', 'ram', 'rm', 'rmi', 'rmvb', 'swf', 'tif', 'tiff', 'wav', 'wma', 'wmv');
+$Config['AllowedExtensions']['Media'] = array('aiff', 'asf', 'avi', 'bmp', 'fla', 'flv', 'gif', 'jpeg', 'jpg', 'mid', 'mov', 'mp3', 'mp4', 'mpc', 'mpeg', 'mpg', 'png', 'qt', 'ram', 'rm', 'rmi', 'rmvb', 'swf', 'tif', 'tiff', 'wav', 'wma', 'wmv');
 $Config['DeniedExtensions']['Media']	= array();
-$Config['FileTypesPath']['Media']		= $Config['UserFilesPath'] . 'media/' ;
-$Config['FileTypesAbsolutePath']['Media']= ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'media/' ;
-$Config['QuickUploadPath']['Media']		= $Config['UserFilesPath'] ;
-$Config['QuickUploadAbsolutePath']['Media']= $Config['UserFilesAbsolutePath'] ;
+$Config['FileTypesPath']['Media'] = $Config['UserFilesPath'].'media/';
+$Config['FileTypesAbsolutePath']['Media'] = ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'media/';
+$Config['QuickUploadPath']['Media']		= $Config['UserFilesPath'];
+$Config['QuickUploadAbsolutePath']['Media'] = $Config['UserFilesAbsolutePath'];
 

Braces +10 added lines, -3 removed lines

@@ -34,7 +34,10 @@ 
 require_once '../../../../main.inc.php';
 $uri=preg_replace('/^http(s?):\/\//i','',$dolibarr_main_url_root);
 $pos = strstr($uri, '/');       // $pos contient alors url sans nom domaine
-if ($pos == '/') $pos = '';     // si $pos vaut /, on le met a ''
+if ($pos == '/') {
+    $pos = '';
+}
+// si $pos vaut /, on le met a ''
 define('DOL_URL_ROOT', $pos);
 $entity = ((!empty($_SESSION['dol_entity']) && $_SESSION['dol_entity'] > 1) ? $_SESSION['dol_entity'] : null);
 
@@ -81,14 +84,18 @@ 
 // Set to 0 to disable this feature.
 // Note: not needed on Windows-based servers.
 $newmask = '0644';
-if (! empty($conf->global->MAIN_UMASK)) $newmask=$conf->global->MAIN_UMASK;
+if (! empty($conf->global->MAIN_UMASK)) {
+    $newmask=$conf->global->MAIN_UMASK;
+}
 $Config['ChmodOnUpload'] = $newmask;
 
 // See comments above.
 // Used when creating folders that does not exist.
 $newmask = '0755';
 $dirmaskdec=octdec($newmask);
-if (! empty($conf->global->MAIN_UMASK)) $dirmaskdec=octdec($conf->global->MAIN_UMASK);
+if (! empty($conf->global->MAIN_UMASK)) {
+    $dirmaskdec=octdec($conf->global->MAIN_UMASK);
+}
 $dirmaskdec |= octdec('0200');  // Set w bit required to be able to create content for recursive subdirs files
 $newmask = decoct($dirmaskdec);