alxarafe / alixar

dolibarr/htdocs/core/actions_comments.inc.php

Braces +2 added lines, -4 removed lines

@@ -49,8 +49,7 @@ 
 			setEventMessages($langs->trans("CommentAdded"), null, 'mesgs');
 			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
 			exit;
-		}
-		else
+		} else
 		{
 			setEventMessages($comment->error, $comment->errors,'errors');
 			$action='';
@@ -66,8 +65,7 @@ 
 			setEventMessages($langs->trans("CommentDeleted"), null, 'mesgs');
 			header('Location: '.$varpage.'?id='.$id.($withproject?'&withproject=1':''));
 			exit;
-		}
-		else
+		} else
 		{
 			setEventMessages($comment->error, $comment->errors,'errors');
 			$action='';

dolibarr/htdocs/core/filemanagerdol/connectors/php/basexml.php

Braces +10 added lines, -9 removed lines

@@ -90,15 +90,15 @@ 
  */
 function SendError($number, $text)
 {
-	if ( $_GET['Command'] == 'FileUpload' )
-		SendUploadResults($number, "", "", $text);
+	if ( $_GET['Command'] == 'FileUpload' ) {
+			SendUploadResults($number, "", "", $text);
+	}
 
 	if ( isset( $GLOBALS['HeaderSent'] ) && $GLOBALS['HeaderSent'] )
 	{
 		SendErrorNode($number, $text);
 		CreateXmlFooter();
-	}
-	else
+	} else
 	{
 		SetXmlHeaders();
 
@@ -125,8 +125,9 @@ 
  */
 function SendErrorNode($number, $text)
 {
-	if ($text)
-		echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
-	else
-		echo '<Error number="' . $number . '" />' ;
-}
+	if ($text) {
+			echo '<Error number="' . $number . '" text="' . htmlspecialchars($text) . '" />' ;
+	} else {
+			echo '<Error number="' . $number . '" />' ;
+	}
+	}

dolibarr/htdocs/core/filemanagerdol/connectors/php/connector.php

Braces +8 added lines, -5 removed lines

@@ -30,8 +30,9 @@ 
 require 'basexml.php';
 require 'commands.php';
 
-if ( !$Config['Enabled'] )
+if ( !$Config['Enabled'] ) {
 	SendError(1, 'This connector is disabled. Please check the "editor/filemanager/connectors/php/config.php" file');
+}
 
 DoResponse();
 
@@ -45,8 +46,9 @@ 
     if (!isset($_GET)) {
         global $_GET;
     }
-	if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) )
-		return;
+	if ( !isset( $_GET['Command'] ) || !isset( $_GET['Type'] ) || !isset( $_GET['CurrentFolder'] ) ) {
+			return;
+	}
 
 	// Get the main request informaiton.
 	$sCommand		= $_GET['Command'] ;
@@ -59,8 +61,9 @@ 
 		SendError(1, 'The "' . $sCommand . '" command isn\'t allowed');
 	}
 	// Check if it is an allowed type.
-	if (! IsAllowedType($sResourceType))
-		SendError(1, 'Invalid type specified');
+	if (! IsAllowedType($sResourceType)) {
+			SendError(1, 'Invalid type specified');
+	}
 
 	// File Upload doesn't have to Return XML, so it must be intercepted before anything.
 	if ( $sCommand == 'FileUpload' )

dolibarr/htdocs/core/filemanagerdol/connectors/php/upload.php

Braces +6 added lines, -3 removed lines

@@ -41,8 +41,9 @@ 
 
 
 // Check if this uploader has been enabled.
-if ( !$Config['Enabled'] )
+if ( !$Config['Enabled'] ) {
 	SendUploadResults('1', '', '', 'This file uploader is disabled. Please check the "filemanagerdol/connectors/php/config.php" file');
+}
 
 $sCommand = 'QuickUpload' ;
 
@@ -52,12 +53,14 @@ 
 $sCurrentFolder	= "/" ;
 
 // Is enabled the upload?
-if (! IsAllowedCommand($sCommand))
+if (! IsAllowedCommand($sCommand)) {
 	SendUploadResults('1', '', '', 'The ""' . $sCommand . '"" command isn\'t allowed');
+}
 
 // Check if it is an allowed type.
-if (! IsAllowedType($sType))
+if (! IsAllowedType($sType)) {
     SendUploadResults(1, '', '', 'Invalid type specified');
+}
 
 
 // @CHANGE

dolibarr/htdocs/core/filemanagerdol/connectors/php/io.php

Braces +53 added lines, -40 removed lines

@@ -44,11 +44,12 @@ 
 {
 	global $Config ;
 
-	if ($sCommand == "QuickUpload")
-		return $Config['QuickUploadPath'][$resourceType] ;
-	else
-		return $Config['FileTypesPath'][$resourceType] ;
-}
+	if ($sCommand == "QuickUpload") {
+			return $Config['QuickUploadPath'][$resourceType] ;
+	} else {
+			return $Config['FileTypesPath'][$resourceType] ;
+	}
+	}
 
 /**
  * GetResourceTypeDirectory
@@ -62,16 +63,17 @@ 
 	global $Config ;
 	if ($sCommand == "QuickUpload")
 	{
-		if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0)
-			return $Config['QuickUploadAbsolutePath'][$resourceType] ;
+		if ( strlen($Config['QuickUploadAbsolutePath'][$resourceType]) > 0) {
+					return $Config['QuickUploadAbsolutePath'][$resourceType] ;
+		}
 
 		// Map the "UserFiles" path to a local directory.
 		return Server_MapPath($Config['QuickUploadPath'][$resourceType]);
-	}
-	else
+	} else
 	{
-		if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0)
-			return $Config['FileTypesAbsolutePath'][$resourceType] ;
+		if ( strlen($Config['FileTypesAbsolutePath'][$resourceType]) > 0) {
+					return $Config['FileTypesAbsolutePath'][$resourceType] ;
+		}
 
 		// Map the "UserFiles" path to a local directory.
 		return Server_MapPath($Config['FileTypesPath'][$resourceType]);
@@ -116,8 +118,9 @@ 
 
 	// Ensure that the directory exists.
 	$sErrorMsg = CreateServerFolder($sResourceTypePath);
-	if ( $sErrorMsg != '' )
-		SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
+	if ( $sErrorMsg != '' ) {
+			SendError(1, "Error creating folder \"{$sResourceTypePath}\" ({$sErrorMsg})");
+	}
 
 	// Return the resource type directory combined with the required path.
 	return CombinePaths($sResourceTypePath, $folderPath);
@@ -162,8 +165,9 @@ 
 		}
 
 		$sErrorMsg = CreateServerFolder($sParent, $folderPath);
-		if ( $sErrorMsg != '' )
-			return $sErrorMsg ;
+		if ( $sErrorMsg != '' ) {
+					return $sErrorMsg ;
+		}
 	}
 
 	if ( !file_exists($folderPath))
@@ -178,8 +182,7 @@ 
 		if ( isset( $Config['ChmodOnFolderCreate'] ) && !$Config['ChmodOnFolderCreate'] )
 		{
 			mkdir($folderPath);
-		}
-		else
+		} else
 		{
 			$permissions = '0777';
 			if ( isset( $Config['ChmodOnFolderCreate'] ) && $Config['ChmodOnFolderCreate'])
@@ -202,10 +205,10 @@ 
 		ini_restore('error_reporting');
 
 		return $sErrorMsg ;
+	} else {
+			return '' ;
+	}
 	}
-	else
-		return '' ;
-}
 
 /**
  * Get Root Path
@@ -230,8 +233,9 @@ 
 
     // This can check only that this script isn't run from a virtual dir
     // But it avoids the problems that arise if it isn't checked
-    if ( $position === false || $position <> strlen($sRealPath) - strlen($sSelfPath) )
-        SendError(1, 'Sorry, can\'t map "UserFilesPath" to a physical path. You must set the "UserFilesAbsolutePath" value in "editor/filemanager/connectors/php/config.php".');
+    if ( $position === false || $position <> strlen($sRealPath) - strlen($sSelfPath) ) {
+            SendError(1, 'Sorry, can\'t map "UserFilesPath" to a physical path. You must set the "UserFilesAbsolutePath" value in "editor/filemanager/connectors/php/config.php".');
+    }
 
     return substr($sRealPath, 0, $position);
 }
@@ -265,11 +269,13 @@ 
 	$arAllowed	= $Config['AllowedExtensions'][$resourceType] ;
 	$arDenied	= $Config['DeniedExtensions'][$resourceType] ;
 
-	if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed))
-		return false ;
+	if ( count($arAllowed) > 0 && !in_array($sExtension, $arAllowed)) {
+			return false ;
+	}
 
-	if ( count($arDenied) > 0 && in_array($sExtension, $arDenied))
-		return false ;
+	if ( count($arDenied) > 0 && in_array($sExtension, $arDenied)) {
+			return false ;
+	}
 
 	return true ;
 }
@@ -283,8 +289,9 @@ 
 function IsAllowedType($resourceType)
 {
 	global $Config ;
-	if ( !in_array($resourceType, $Config['ConfigAllowedTypes']))
-		return false ;
+	if ( !in_array($resourceType, $Config['ConfigAllowedTypes'])) {
+			return false ;
+	}
 
 	return true ;
 }
@@ -299,8 +306,9 @@ 
 {
 	global $Config ;
 
-	if (! in_array($sCommand, $Config['ConfigAllowedCommands']))
-		return false ;
+	if (! in_array($sCommand, $Config['ConfigAllowedCommands'])) {
+			return false ;
+	}
 
 	return true ;
 }
@@ -318,10 +326,12 @@ 
 	$sCurrentFolder	= isset( $_GET['CurrentFolder'] ) ? GETPOST('CurrentFolder', '', 1) : '/' ;
 
 	// Check the current folder syntax (must begin and start with a slash).
-	if (!preg_match('|/$|', $sCurrentFolder))
-		$sCurrentFolder .= '/' ;
-	if (strpos($sCurrentFolder, '/') !== 0)
-		$sCurrentFolder = '/' . $sCurrentFolder ;
+	if (!preg_match('|/$|', $sCurrentFolder)) {
+			$sCurrentFolder .= '/' ;
+	}
+	if (strpos($sCurrentFolder, '/') !== 0) {
+			$sCurrentFolder = '/' . $sCurrentFolder ;
+	}
 
 	// Ensure the folder path has no double-slashes
 	while ( strpos($sCurrentFolder, '//') !== false ) {
@@ -329,11 +339,13 @@ 
 	}
 
 	// Check for invalid folder paths (..)
-	if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\"))
-		SendError(102, '');
+	if ( strpos($sCurrentFolder, '..') || strpos($sCurrentFolder, "\\")) {
+			SendError(102, '');
+	}
 
-	if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder))
-		SendError(102, '');
+	if ( preg_match(",(/\.)|[[:cntrl:]]|(//)|(\\\\)|([\:\*\?\"\<\>\|]),", $sCurrentFolder)) {
+			SendError(102, '');
+	}
 
 	return $sCurrentFolder ;
 }
@@ -357,8 +369,9 @@ 
 	$sNewFileName = stripslashes($sNewFileName);
 
 	// Replace dots in the name with underscores (only one dot can be there... security issue).
-	if ( $Config['ForceSingleExtension'] )
-		$sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
+	if ( $Config['ForceSingleExtension'] ) {
+			$sNewFileName = preg_replace('/\\.(?![^.]*$)/', '_', $sNewFileName);
+	}
 
 	// Remove \ / | : ? * " < >
 	$sNewFileName = preg_replace('/\\\\|\\/|\\||\\:|\\?|\\*|"|<|>|[[:cntrl:]]/', '_', $sNewFileName);

dolibarr/htdocs/core/filemanagerdol/connectors/php/commands.php

Braces +32 added lines, -28 removed lines

@@ -43,8 +43,9 @@ 
 	{
 		while ( $sFile = readdir($oCurrentFolder) )
 		{
-			if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) )
-				$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+			if ( $sFile != '.' && $sFile != '..' && is_dir($sServerDir . $sFile) ) {
+							$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+			}
 		}
 		closedir($oCurrentFolder);
 	}
@@ -53,8 +54,9 @@ 
 	echo "<Folders>" ;
 
 	natcasesort($aFolders);
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+	foreach ( $aFolders as $sFolder ) {
+			echo $sFolder ;
+	}
 
 	// Close the "Folders" node.
 	echo "</Folders>" ;
@@ -84,9 +86,9 @@ 
 		{
 			if ( $sFile != '.' && $sFile != '..' )
 			{
-				if ( is_dir($sServerDir . $sFile) )
-					$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
-				else
+				if ( is_dir($sServerDir . $sFile) ) {
+									$aFolders[] = '<Folder name="' . ConvertToXmlAttribute($sFile) . '" />' ;
+				} else
 				{
 					$iFileSize = @filesize($sServerDir . $sFile);
 					if ( !$iFileSize ) {
@@ -95,8 +97,9 @@ 
 					if ( $iFileSize > 0 )
 					{
 						$iFileSize = round($iFileSize / 1024);
-						if ( $iFileSize < 1 )
-							$iFileSize = 1 ;
+						if ( $iFileSize < 1 ) {
+													$iFileSize = 1 ;
+						}
 					}
 
 					$aFiles[] = '<File name="' . ConvertToXmlAttribute($sFile) . '" size="' . $iFileSize . '" />' ;
@@ -110,8 +113,9 @@ 
 	natcasesort($aFolders);
 	echo '<Folders>' ;
 
-	foreach ( $aFolders as $sFolder )
-		echo $sFolder ;
+	foreach ( $aFolders as $sFolder ) {
+			echo $sFolder ;
+	}
 
 	echo '</Folders>' ;
 
@@ -119,8 +123,9 @@ 
 	natcasesort($aFiles);
 	echo '<Files>' ;
 
-	foreach ( $aFiles as $sFiles )
-		echo $sFiles ;
+	foreach ( $aFiles as $sFiles ) {
+			echo $sFiles ;
+	}
 
 	echo '</Files>' ;
 }
@@ -145,8 +150,10 @@ 
 		$sNewFolderName = $_GET['NewFolderName'] ;
 		$sNewFolderName = SanitizeFolderName($sNewFolderName);
 
-		if (strpos($sNewFolderName, '..') !== false)
-			$sErrorNumber = '102' ;		// Invalid folder name.
+		if (strpos($sNewFolderName, '..') !== false) {
+					$sErrorNumber = '102' ;
+		}
+		// Invalid folder name.
 		else
 		{
 			// Map the virtual path to the local server path of the current folder.
@@ -171,13 +178,13 @@ 
 						$sErrorNumber = '110' ;
 						break ;
 				}
+			} else {
+							$sErrorNumber = '103' ;
 			}
-			else
-				$sErrorNumber = '103' ;
 		}
+	} else {
+			$sErrorNumber = '102' ;
 	}
-	else
-		$sErrorNumber = '102' ;
 
 	// Create the "Error" node.
 	echo '<Error number="' . $sErrorNumber . '" />' ;
@@ -254,8 +261,7 @@ 
 					$iCounter++ ;
 					$sFileName = RemoveExtension($sOriginalFileName) . '(' . $iCounter . ').' . $sExtension ;
 					$sErrorNumber = '201' ;
-				}
-				else
+				} else
 				{
 					move_uploaded_file($oFile['tmp_name'], $sFilePath);
 
@@ -289,19 +295,18 @@ 
 				{
 					@unlink($sFilePath);
 					$sErrorNumber = '202' ;
-				}
-				else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
+				} else if ( isset( $detectHtml ) && $detectHtml === -1 && DetectHtml($sFilePath) === true )
 				{
 					@unlink($sFilePath);
 					$sErrorNumber = '202' ;
 				}
 			}
+		} else {
+					$sErrorNumber = '202' ;
 		}
-		else
+	} else {
 			$sErrorNumber = '202' ;
 	}
-	else
-		$sErrorNumber = '202' ;
 
 
 	$sFileUrl = CombinePaths(GetResourceTypePath($resourceType, $sCommand), $currentFolder);
@@ -314,8 +319,7 @@ 
     {
         // this line already exists so wrap the if block around it
         SendUploadResults($sErrorNumber, $sFileUrl, $sFileName);
-    }
-    else
+    } else
 	{
 	    //issue the CKEditor Callback
 		SendCKEditorResults(

dolibarr/htdocs/core/filemanagerdol/connectors/php/config.php

Braces +10 added lines, -3 removed lines

@@ -34,7 +34,10 @@ 
 require_once '../../../../main.inc.php';
 $uri=preg_replace('/^http(s?):\/\//i','',$dolibarr_main_url_root);
 $pos = strstr($uri, '/');       // $pos contient alors url sans nom domaine
-if ($pos == '/') $pos = '';     // si $pos vaut /, on le met a ''
+if ($pos == '/') {
+    $pos = '';
+}
+// si $pos vaut /, on le met a ''
 define('DOL_URL_ROOT', $pos);
 $entity = ((!empty($_SESSION['dol_entity']) && $_SESSION['dol_entity'] > 1) ? $_SESSION['dol_entity'] : null);
 
@@ -81,14 +84,18 @@ 
 // Set to 0 to disable this feature.
 // Note: not needed on Windows-based servers.
 $newmask = '0644';
-if (! empty($conf->global->MAIN_UMASK)) $newmask=$conf->global->MAIN_UMASK;
+if (! empty($conf->global->MAIN_UMASK)) {
+    $newmask=$conf->global->MAIN_UMASK;
+}
 $Config['ChmodOnUpload'] = $newmask;
 
 // See comments above.
 // Used when creating folders that does not exist.
 $newmask = '0755';
 $dirmaskdec=octdec($newmask);
-if (! empty($conf->global->MAIN_UMASK)) $dirmaskdec=octdec($conf->global->MAIN_UMASK);
+if (! empty($conf->global->MAIN_UMASK)) {
+    $dirmaskdec=octdec($conf->global->MAIN_UMASK);
+}
 $dirmaskdec |= octdec('0200');  // Set w bit required to be able to create content for recursive subdirs files
 $newmask = decoct($dirmaskdec);
 

dolibarr/htdocs/core/filemanagerdol/connectors/php/util.php

Braces +2 added lines, -4 removed lines

@@ -87,8 +87,7 @@ 
 	if ( defined('PHP_OS') )
 	{
 		$os = PHP_OS ;
-	}
-	else
+	} else
 	{
 		$os = php_uname();
 	}
@@ -96,8 +95,7 @@ 
 	if (strtoupper(substr($os, 0, 3)) === 'WIN' || FindBadUtf8($value))
 	{
 		return (utf8_encode(htmlspecialchars($value)));
-	}
-	else
+	} else
 	{
 		return (htmlspecialchars($value));
 	}

dolibarr/htdocs/core/lib/import.lib.php

Braces +3 added lines, -1 removed lines

@@ -36,7 +36,9 @@
 {
 	global $langs;
 
-	if (empty($maxstep)) $maxstep=6;
+	if (empty($maxstep)) {
+	    $maxstep=6;
+	}
 
 	$h=0;
 	$head = array();