alxarafe / alixar

dolibarr/htdocs/core/tpl/notes.tpl.php

Indentation +33 added lines, -33 removed lines

@@ -19,8 +19,8 @@ 
 
 // Protection to avoid direct call of template
 if (empty($object) || ! is_object($object)) {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 // $permissionnote 	must be defined by caller. For example $permissionnote=$user->rights->module->create
@@ -37,23 +37,23 @@ 
 $value_private=$object->note_private;
 if (! empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PUBLIC_NOTES))
 {
-	$stringtoadd=dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
-	if (GETPOST('action','aZ09') == 'edit'.$note_public)
-	{
-		$value_public=dol_concatdesc($value_public, ($value_public?"\n":"")."-- ".$stringtoadd);
-		if (dol_textishtml($value_public)) $value_public.="<br>\n";
-		else $value_public.="\n";
-	}
+    $stringtoadd=dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
+    if (GETPOST('action','aZ09') == 'edit'.$note_public)
+    {
+        $value_public=dol_concatdesc($value_public, ($value_public?"\n":"")."-- ".$stringtoadd);
+        if (dol_textishtml($value_public)) $value_public.="<br>\n";
+        else $value_public.="\n";
+    }
 }
 if (! empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PRIVATE_NOTES))
 {
-	$stringtoadd=dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
-	if (GETPOST('action','aZ09') == 'edit'.$note_private)
-	{
-		$value_private=dol_concatdesc($value_private, ($value_private?"\n":"")."-- ".$stringtoadd);
-		if (dol_textishtml($value_private)) $value_private.="<br>\n";
-		else $value_private.="\n";
-	}
+    $stringtoadd=dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
+    if (GETPOST('action','aZ09') == 'edit'.$note_private)
+    {
+        $value_private=dol_concatdesc($value_private, ($value_private?"\n":"")."-- ".$stringtoadd);
+        if (dol_textishtml($value_private)) $value_private.="<br>\n";
+        else $value_private.="\n";
+    }
 }
 
 // Special cases
@@ -76,25 +76,25 @@ 
 print '<!-- BEGIN PHP TEMPLATE NOTES -->'."\n";
 print '<div class="tagtable border table-border centpercent">'."\n";
 if ($module != 'product') {
-	// No public note yet on products
-	print '<div class="tagtr pair table-border-row">'."\n";
-	print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass)?'':' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
-	print $form->editfieldkey("NotePublic", $note_public, $value_public, $object, $permission, $typeofdata, $moreparam, '', 0);
-	print '</div>'."\n";
-	print '<div class="tagtd table-val-border-col">'."\n";
-	print $form->editfieldval("NotePublic", $note_public, $value_public, $object, $permission, $typeofdata, '', null, null, $moreparam, 1)."\n";
-	print '</div>'."\n";
-	print '</div>'."\n";
+    // No public note yet on products
+    print '<div class="tagtr pair table-border-row">'."\n";
+    print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass)?'':' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
+    print $form->editfieldkey("NotePublic", $note_public, $value_public, $object, $permission, $typeofdata, $moreparam, '', 0);
+    print '</div>'."\n";
+    print '<div class="tagtd table-val-border-col">'."\n";
+    print $form->editfieldval("NotePublic", $note_public, $value_public, $object, $permission, $typeofdata, '', null, null, $moreparam, 1)."\n";
+    print '</div>'."\n";
+    print '</div>'."\n";
 }
 if (empty($user->societe_id)) {
-	print '<div class="tagtr '.($module != 'product'?'impair':'pair').' table-border-row">'."\n";
-	print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass)?'':' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
-	print $form->editfieldkey("NotePrivate", $note_private, $value_private, $object, $permission, $typeofdata, $moreparam, '', 0);
-	print '</div>'."\n";
-	print '<div class="tagtd table-val-border-col">'."\n";
-	print $form->editfieldval("NotePrivate", $note_private, $value_private, $object, $permission, $typeofdata, '', null, null, $moreparam, 1);
-	print '</div>'."\n";
-	print '</div>'."\n";
+    print '<div class="tagtr '.($module != 'product'?'impair':'pair').' table-border-row">'."\n";
+    print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass)?'':' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
+    print $form->editfieldkey("NotePrivate", $note_private, $value_private, $object, $permission, $typeofdata, $moreparam, '', 0);
+    print '</div>'."\n";
+    print '<div class="tagtd table-val-border-col">'."\n";
+    print $form->editfieldval("NotePrivate", $note_private, $value_private, $object, $permission, $typeofdata, '', null, null, $moreparam, 1);
+    print '</div>'."\n";
+    print '</div>'."\n";
 }
 print '</div>'."\n";
 ?>

Spacing +34 added lines, -34 removed lines

@@ -18,7 +18,7 @@ 
  */
 
 // Protection to avoid direct call of template
-if (empty($object) || ! is_object($object)) {
+if (empty($object) || !is_object($object)) {
 	print "Error, template page can't be called as URL";
 	exit;
 }
@@ -29,56 +29,56 @@ 
 $note_public  = 'note_public';
 $note_private = 'note_private';
 
-$colwidth=(isset($colwidth)?$colwidth:(empty($cssclass)?'25':''));
+$colwidth = (isset($colwidth) ? $colwidth : (empty($cssclass) ? '25' : ''));
 // Set $permission from the $permissionnote var defined on calling page
-$permission=(isset($permissionnote)?$permissionnote:(isset($permission)?$permission:(isset($user->rights->$module->create)?$user->rights->$module->create:(isset($user->rights->$module->creer)?$user->rights->$module->creer:0))));
-$moreparam=(isset($moreparam)?$moreparam:'');
-$value_public=$object->note_public;
-$value_private=$object->note_private;
-if (! empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PUBLIC_NOTES))
+$permission = (isset($permissionnote) ? $permissionnote : (isset($permission) ? $permission : (isset($user->rights->$module->create) ? $user->rights->$module->create : (isset($user->rights->$module->creer) ? $user->rights->$module->creer : 0))));
+$moreparam = (isset($moreparam) ? $moreparam : '');
+$value_public = $object->note_public;
+$value_private = $object->note_private;
+if (!empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PUBLIC_NOTES))
 {
-	$stringtoadd=dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
-	if (GETPOST('action','aZ09') == 'edit'.$note_public)
+	$stringtoadd = dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
+	if (GETPOST('action', 'aZ09') == 'edit'.$note_public)
 	{
-		$value_public=dol_concatdesc($value_public, ($value_public?"\n":"")."-- ".$stringtoadd);
-		if (dol_textishtml($value_public)) $value_public.="<br>\n";
-		else $value_public.="\n";
+		$value_public = dol_concatdesc($value_public, ($value_public ? "\n" : "")."-- ".$stringtoadd);
+		if (dol_textishtml($value_public)) $value_public .= "<br>\n";
+		else $value_public .= "\n";
 	}
 }
-if (! empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PRIVATE_NOTES))
+if (!empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PRIVATE_NOTES))
 {
-	$stringtoadd=dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
-	if (GETPOST('action','aZ09') == 'edit'.$note_private)
+	$stringtoadd = dol_print_date(dol_now(), 'dayhour').' '.$user->getFullName($langs).' --';
+	if (GETPOST('action', 'aZ09') == 'edit'.$note_private)
 	{
-		$value_private=dol_concatdesc($value_private, ($value_private?"\n":"")."-- ".$stringtoadd);
-		if (dol_textishtml($value_private)) $value_private.="<br>\n";
-		else $value_private.="\n";
+		$value_private = dol_concatdesc($value_private, ($value_private ? "\n" : "")."-- ".$stringtoadd);
+		if (dol_textishtml($value_private)) $value_private .= "<br>\n";
+		else $value_private .= "\n";
 	}
 }
 
 // Special cases
-if ($module == 'propal')                 { $permission=$user->rights->propale->creer;}
-elseif ($module == 'supplier_proposal')  { $permission=$user->rights->supplier_proposal->creer;}
-elseif ($module == 'fichinter')          { $permission=$user->rights->ficheinter->creer;}
-elseif ($module == 'project')            { $permission=$user->rights->projet->creer;}
-elseif ($module == 'project_task')       { $permission=$user->rights->projet->creer;}
-elseif ($module == 'invoice_supplier')   { $permission=$user->rights->fournisseur->facture->creer;}
-elseif ($module == 'order_supplier')     { $permission=$user->rights->fournisseur->commande->creer;}
-elseif ($module == 'societe')     	 	 { $permission=$user->rights->societe->creer;}
-elseif ($module == 'contact')     		 { $permission=$user->rights->societe->creer;}
-elseif ($module == 'shipping')    		 { $permission=$user->rights->expedition->creer;}
-elseif ($module == 'product')    		 { $permission=$user->rights->produit->creer;}
+if ($module == 'propal') { $permission = $user->rights->propale->creer; }
+elseif ($module == 'supplier_proposal') { $permission = $user->rights->supplier_proposal->creer; }
+elseif ($module == 'fichinter') { $permission = $user->rights->ficheinter->creer; }
+elseif ($module == 'project') { $permission = $user->rights->projet->creer; }
+elseif ($module == 'project_task') { $permission = $user->rights->projet->creer; }
+elseif ($module == 'invoice_supplier') { $permission = $user->rights->fournisseur->facture->creer; }
+elseif ($module == 'order_supplier') { $permission = $user->rights->fournisseur->commande->creer; }
+elseif ($module == 'societe') { $permission = $user->rights->societe->creer; }
+elseif ($module == 'contact') { $permission = $user->rights->societe->creer; }
+elseif ($module == 'shipping') { $permission = $user->rights->expedition->creer; }
+elseif ($module == 'product') { $permission = $user->rights->produit->creer; }
 //else dol_print_error('','Bad value '.$module.' for param module');
 
-if (! empty($conf->fckeditor->enabled) && ! empty($conf->global->FCKEDITOR_ENABLE_SOCIETE)) $typeofdata='ckeditor:dolibarr_notes:100%:200::1:12:95%';	// Rem: This var is for all notes, not only thirdparties note.
-else $typeofdata='textarea:12:95%';
+if (!empty($conf->fckeditor->enabled) && !empty($conf->global->FCKEDITOR_ENABLE_SOCIETE)) $typeofdata = 'ckeditor:dolibarr_notes:100%:200::1:12:95%'; // Rem: This var is for all notes, not only thirdparties note.
+else $typeofdata = 'textarea:12:95%';
 
 print '<!-- BEGIN PHP TEMPLATE NOTES -->'."\n";
 print '<div class="tagtable border table-border centpercent">'."\n";
 if ($module != 'product') {
 	// No public note yet on products
 	print '<div class="tagtr pair table-border-row">'."\n";
-	print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass)?'':' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
+	print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass) ? '' : ' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
 	print $form->editfieldkey("NotePublic", $note_public, $value_public, $object, $permission, $typeofdata, $moreparam, '', 0);
 	print '</div>'."\n";
 	print '<div class="tagtd table-val-border-col">'."\n";
@@ -87,8 +87,8 @@ 
 	print '</div>'."\n";
 }
 if (empty($user->societe_id)) {
-	print '<div class="tagtr '.($module != 'product'?'impair':'pair').' table-border-row">'."\n";
-	print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass)?'':' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
+	print '<div class="tagtr '.($module != 'product' ? 'impair' : 'pair').' table-border-row">'."\n";
+	print '<div class="tagtd tagtdnote tdtop table-key-border-col'.(empty($cssclass) ? '' : ' '.$cssclass).'"'.($colwidth ? ' style="width: '.$colwidth.'%"' : '').'>'."\n";
 	print $form->editfieldkey("NotePrivate", $note_private, $value_private, $object, $permission, $typeofdata, $moreparam, '', 0);
 	print '</div>'."\n";
 	print '<div class="tagtd table-val-border-col">'."\n";

Braces +18 added lines, -17 removed lines

@@ -41,8 +41,11 @@ 
 	if (GETPOST('action','aZ09') == 'edit'.$note_public)
 	{
 		$value_public=dol_concatdesc($value_public, ($value_public?"\n":"")."-- ".$stringtoadd);
-		if (dol_textishtml($value_public)) $value_public.="<br>\n";
-		else $value_public.="\n";
+		if (dol_textishtml($value_public)) {
+		    $value_public.="<br>\n";
+		} else {
+		    $value_public.="\n";
+		}
 	}
 }
 if (! empty($conf->global->MAIN_AUTO_TIMESTAMP_IN_PRIVATE_NOTES))
@@ -51,27 +54,25 @@ 
 	if (GETPOST('action','aZ09') == 'edit'.$note_private)
 	{
 		$value_private=dol_concatdesc($value_private, ($value_private?"\n":"")."-- ".$stringtoadd);
-		if (dol_textishtml($value_private)) $value_private.="<br>\n";
-		else $value_private.="\n";
+		if (dol_textishtml($value_private)) {
+		    $value_private.="<br>\n";
+		} else {
+		    $value_private.="\n";
+		}
 	}
 }
 
 // Special cases
-if ($module == 'propal')                 { $permission=$user->rights->propale->creer;}
-elseif ($module == 'supplier_proposal')  { $permission=$user->rights->supplier_proposal->creer;}
-elseif ($module == 'fichinter')          { $permission=$user->rights->ficheinter->creer;}
-elseif ($module == 'project')            { $permission=$user->rights->projet->creer;}
-elseif ($module == 'project_task')       { $permission=$user->rights->projet->creer;}
-elseif ($module == 'invoice_supplier')   { $permission=$user->rights->fournisseur->facture->creer;}
-elseif ($module == 'order_supplier')     { $permission=$user->rights->fournisseur->commande->creer;}
-elseif ($module == 'societe')     	 	 { $permission=$user->rights->societe->creer;}
-elseif ($module == 'contact')     		 { $permission=$user->rights->societe->creer;}
-elseif ($module == 'shipping')    		 { $permission=$user->rights->expedition->creer;}
-elseif ($module == 'product')    		 { $permission=$user->rights->produit->creer;}
+if ($module == 'propal')                 { $permission=$user->rights->propale->creer;} elseif ($module == 'supplier_proposal')  { $permission=$user->rights->supplier_proposal->creer;} elseif ($module == 'fichinter')          { $permission=$user->rights->ficheinter->creer;} elseif ($module == 'project')            { $permission=$user->rights->projet->creer;} elseif ($module == 'project_task')       { $permission=$user->rights->projet->creer;} elseif ($module == 'invoice_supplier')   { $permission=$user->rights->fournisseur->facture->creer;} elseif ($module == 'order_supplier')     { $permission=$user->rights->fournisseur->commande->creer;} elseif ($module == 'societe')     	 	 { $permission=$user->rights->societe->creer;} elseif ($module == 'contact')     		 { $permission=$user->rights->societe->creer;} elseif ($module == 'shipping')    		 { $permission=$user->rights->expedition->creer;} elseif ($module == 'product')    		 { $permission=$user->rights->produit->creer;}
 //else dol_print_error('','Bad value '.$module.' for param module');
 
-if (! empty($conf->fckeditor->enabled) && ! empty($conf->global->FCKEDITOR_ENABLE_SOCIETE)) $typeofdata='ckeditor:dolibarr_notes:100%:200::1:12:95%';	// Rem: This var is for all notes, not only thirdparties note.
-else $typeofdata='textarea:12:95%';
+if (! empty($conf->fckeditor->enabled) && ! empty($conf->global->FCKEDITOR_ENABLE_SOCIETE)) {
+    $typeofdata='ckeditor:dolibarr_notes:100%:200::1:12:95%';
+}
+// Rem: This var is for all notes, not only thirdparties note.
+else {
+    $typeofdata='textarea:12:95%';
+}
 
 print '<!-- BEGIN PHP TEMPLATE NOTES -->'."\n";
 print '<div class="tagtable border table-border centpercent">'."\n";

dolibarr/htdocs/core/tpl/extrafields_list_search_param.tpl.php

Indentation +5 added lines, -5 removed lines

@@ -3,8 +3,8 @@ 
 // Protection to avoid direct call of template
 if (empty($conf) || ! is_object($conf))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 // Loop to complete $param for extrafields
@@ -12,8 +12,8 @@ 
 {
 foreach ($search_array_options as $key => $val)
 {
-	$crit=$val;
-	$tmpkey=preg_replace('/search_options_/','',$key);
-	if ($val != '') $param.='&search_options_'.$tmpkey.'='.urlencode($val);
+    $crit=$val;
+    $tmpkey=preg_replace('/search_options_/','',$key);
+    if ($val != '') $param.='&search_options_'.$tmpkey.'='.urlencode($val);
 }
 }

Spacing +5 added lines, -5 removed lines

@@ -1,19 +1,19 @@
 <?php
 
 // Protection to avoid direct call of template
-if (empty($conf) || ! is_object($conf))
+if (empty($conf) || !is_object($conf))
 {
 	print "Error, template page can't be called as URL";
 	exit;
 }
 
 // Loop to complete $param for extrafields
-if (! empty($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
+if (!empty($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
 foreach ($search_array_options as $key => $val)
 {
-	$crit=$val;
-	$tmpkey=preg_replace('/search_options_/','',$key);
-	if ($val != '') $param.='&search_options_'.$tmpkey.'='.urlencode($val);
+	$crit = $val;
+	$tmpkey = preg_replace('/search_options_/', '', $key);
+	if ($val != '') $param .= '&search_options_'.$tmpkey.'='.urlencode($val);
 }
 }

Braces +7 added lines, -3 removed lines

@@ -8,12 +8,16 @@
 }
 
 // Loop to complete $param for extrafields
-if (! empty($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
+if (! empty($search_array_options)) {
+    // $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
 foreach ($search_array_options as $key => $val)
 {
 	$crit=$val;
-	$tmpkey=preg_replace('/search_options_/','',$key);
-	if ($val != '') $param.='&search_options_'.$tmpkey.'='.urlencode($val);
 }
+	$tmpkey=preg_replace('/search_options_/','',$key);
+	if ($val != '') {
+	    $param.='&search_options_'.$tmpkey.'='.urlencode($val);
+	}
+	}
 }

dolibarr/htdocs/core/tpl/extrafields_edit.tpl.php

Indentation +3 added lines, -3 removed lines

@@ -28,8 +28,8 @@ 
 // Protection to avoid direct call of template
 if (empty($conf) || ! is_object($conf))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 ?>
@@ -41,7 +41,7 @@ 
 $reshook = $hookmanager->executeHooks('formObjectOptions', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
 print $hookmanager->resPrint;
 if (empty($reshook)) {
-	print $object->showOptionals($extrafields, 'edit');
+    print $object->showOptionals($extrafields, 'edit');
 }
 
 ?>

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
  */
 
 // Protection to avoid direct call of template
-if (empty($conf) || ! is_object($conf))
+if (empty($conf) || !is_object($conf))
 {
 	print "Error, template page can't be called as URL";
 	exit;

dolibarr/htdocs/core/tpl/extrafields_list_search_title.tpl.php

Indentation +16 added lines, -16 removed lines

@@ -3,8 +3,8 @@ 
 // Protection to avoid direct call of template
 if (empty($conf) || ! is_object($conf))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey=$object->table_element;
@@ -12,18 +12,18 @@ 
 // Loop to show all columns of extrafields for the title line
 if (! empty($extrafieldsobjectkey))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
-	if (is_array($extrafields->attributes[$extrafieldsobjectkey]['label']) && count($extrafields->attributes[$extrafieldsobjectkey]['label']))
-	{
-		foreach($extrafields->attributes[$extrafieldsobjectkey]['label'] as $key => $val)
-		{
-			if (! empty($arrayfields["ef.".$key]['checked']))
-			{
-				$align=$extrafields->getAlignFlag($key);
-				$sortonfield = "ef.".$key;
-				if (! empty($extrafields->attributes[$extrafieldsobjectkey]['computed'][$key])) $sortonfield='';
-				if ($extrafields->attributes[$extrafieldsobjectkey]['type'][$key] == 'separate') print '<th class="liste_titre thseparator"></th>';
-				else print getTitleFieldOfList($langs->trans($extralabels[$key]), 0, $_SERVER["PHP_SELF"], $sortonfield, "", $param, ($align?'align="'.$align.'"':''), $sortfield, $sortorder)."\n";
-			}
-		}
-	}
+    if (is_array($extrafields->attributes[$extrafieldsobjectkey]['label']) && count($extrafields->attributes[$extrafieldsobjectkey]['label']))
+    {
+        foreach($extrafields->attributes[$extrafieldsobjectkey]['label'] as $key => $val)
+        {
+            if (! empty($arrayfields["ef.".$key]['checked']))
+            {
+                $align=$extrafields->getAlignFlag($key);
+                $sortonfield = "ef.".$key;
+                if (! empty($extrafields->attributes[$extrafieldsobjectkey]['computed'][$key])) $sortonfield='';
+                if ($extrafields->attributes[$extrafieldsobjectkey]['type'][$key] == 'separate') print '<th class="liste_titre thseparator"></th>';
+                else print getTitleFieldOfList($langs->trans($extralabels[$key]), 0, $_SERVER["PHP_SELF"], $sortonfield, "", $param, ($align?'align="'.$align.'"':''), $sortfield, $sortorder)."\n";
+            }
+        }
+    }
 }
\ No newline at end of file

Spacing +8 added lines, -8 removed lines

@@ -1,28 +1,28 @@
 <?php
 
 // Protection to avoid direct call of template
-if (empty($conf) || ! is_object($conf))
+if (empty($conf) || !is_object($conf))
 {
 	print "Error, template page can't be called as URL";
 	exit;
 }
 
-if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey=$object->table_element;
+if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey = $object->table_element;
 
 // Loop to show all columns of extrafields for the title line
-if (! empty($extrafieldsobjectkey))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
+if (!empty($extrafieldsobjectkey))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
 	if (is_array($extrafields->attributes[$extrafieldsobjectkey]['label']) && count($extrafields->attributes[$extrafieldsobjectkey]['label']))
 	{
-		foreach($extrafields->attributes[$extrafieldsobjectkey]['label'] as $key => $val)
+		foreach ($extrafields->attributes[$extrafieldsobjectkey]['label'] as $key => $val)
 		{
-			if (! empty($arrayfields["ef.".$key]['checked']))
+			if (!empty($arrayfields["ef.".$key]['checked']))
 			{
-				$align=$extrafields->getAlignFlag($key);
+				$align = $extrafields->getAlignFlag($key);
 				$sortonfield = "ef.".$key;
-				if (! empty($extrafields->attributes[$extrafieldsobjectkey]['computed'][$key])) $sortonfield='';
+				if (!empty($extrafields->attributes[$extrafieldsobjectkey]['computed'][$key])) $sortonfield = '';
 				if ($extrafields->attributes[$extrafieldsobjectkey]['type'][$key] == 'separate') print '<th class="liste_titre thseparator"></th>';
-				else print getTitleFieldOfList($langs->trans($extralabels[$key]), 0, $_SERVER["PHP_SELF"], $sortonfield, "", $param, ($align?'align="'.$align.'"':''), $sortfield, $sortorder)."\n";
+				else print getTitleFieldOfList($langs->trans($extralabels[$key]), 0, $_SERVER["PHP_SELF"], $sortonfield, "", $param, ($align ? 'align="'.$align.'"' : ''), $sortfield, $sortorder)."\n";
 			}
 		}
 	}

Braces +14 added lines, -5 removed lines

@@ -7,10 +7,13 @@ 
 	exit;
 }
 
-if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey=$object->table_element;
+if (empty($extrafieldsobjectkey) && is_object($object)) {
+    $extrafieldsobjectkey=$object->table_element;
+}
 
 // Loop to show all columns of extrafields for the title line
-if (! empty($extrafieldsobjectkey))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
+if (! empty($extrafieldsobjectkey)) {
+    // $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
 	if (is_array($extrafields->attributes[$extrafieldsobjectkey]['label']) && count($extrafields->attributes[$extrafieldsobjectkey]['label']))
 	{
@@ -19,10 +22,16 @@ 
 			if (! empty($arrayfields["ef.".$key]['checked']))
 			{
 				$align=$extrafields->getAlignFlag($key);
+}
 				$sortonfield = "ef.".$key;
-				if (! empty($extrafields->attributes[$extrafieldsobjectkey]['computed'][$key])) $sortonfield='';
-				if ($extrafields->attributes[$extrafieldsobjectkey]['type'][$key] == 'separate') print '<th class="liste_titre thseparator"></th>';
-				else print getTitleFieldOfList($langs->trans($extralabels[$key]), 0, $_SERVER["PHP_SELF"], $sortonfield, "", $param, ($align?'align="'.$align.'"':''), $sortfield, $sortorder)."\n";
+				if (! empty($extrafields->attributes[$extrafieldsobjectkey]['computed'][$key])) {
+				    $sortonfield='';
+				}
+				if ($extrafields->attributes[$extrafieldsobjectkey]['type'][$key] == 'separate') {
+				    print '<th class="liste_titre thseparator"></th>';
+				} else {
+				    print getTitleFieldOfList($langs->trans($extralabels[$key]), 0, $_SERVER["PHP_SELF"], $sortonfield, "", $param, ($align?'align="'.$align.'"':''), $sortfield, $sortorder)."\n";
+				}
 			}
 		}
 	}

dolibarr/htdocs/core/tpl/commonfields_add.tpl.php

Indentation +21 added lines, -21 removed lines

@@ -25,8 +25,8 @@ 
 // Protection to avoid direct call of template
 if (empty($conf) || ! is_object($conf))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 ?>
@@ -37,30 +37,30 @@ 
 
 foreach($object->fields as $key => $val)
 {
-	// Discard if extrafield is a hidden field on form
-	if (abs($val['visible']) != 1) continue;
+    // Discard if extrafield is a hidden field on form
+    if (abs($val['visible']) != 1) continue;
 
-	if (array_key_exists('enabled', $val) && isset($val['enabled']) && ! verifCond($val['enabled'])) continue;	// We don't want this field
+    if (array_key_exists('enabled', $val) && isset($val['enabled']) && ! verifCond($val['enabled'])) continue;	// We don't want this field
 
-	print '<tr id="field_'.$key.'">';
-	print '<td';
-	print ' class="titlefieldcreate';
-	if ($val['notnull'] > 0) print ' fieldrequired';
-	if ($val['type'] == 'text' || $val['type'] == 'html') print ' tdtop';
-	print '"';
-	print '>';
-	print $langs->trans($val['label']);
+    print '<tr id="field_'.$key.'">';
+    print '<td';
+    print ' class="titlefieldcreate';
+    if ($val['notnull'] > 0) print ' fieldrequired';
+    if ($val['type'] == 'text' || $val['type'] == 'html') print ' tdtop';
+    print '"';
+    print '>';
+    print $langs->trans($val['label']);
     if(!empty($val['help'])){
         print $form->textwithpicto('',$langs->trans($val['help']));
     }
-	print '</td>';
-	print '<td>';
-	if (in_array($val['type'], array('int', 'integer'))) $value = GETPOST($key, 'int');
-	elseif ($val['type'] == 'text' || $val['type'] == 'html') $value = GETPOST($key, 'none');
-	else $value = GETPOST($key, 'alpha');
-	print $object->showInputField($val, $key, $value, '', '', '', 0);
-	print '</td>';
-	print '</tr>';
+    print '</td>';
+    print '<td>';
+    if (in_array($val['type'], array('int', 'integer'))) $value = GETPOST($key, 'int');
+    elseif ($val['type'] == 'text' || $val['type'] == 'html') $value = GETPOST($key, 'none');
+    else $value = GETPOST($key, 'alpha');
+    print $object->showInputField($val, $key, $value, '', '', '', 0);
+    print '</td>';
+    print '</tr>';
 }
 
 ?>

Spacing +5 added lines, -5 removed lines

@@ -23,7 +23,7 @@ 
  */
 
 // Protection to avoid direct call of template
-if (empty($conf) || ! is_object($conf))
+if (empty($conf) || !is_object($conf))
 {
 	print "Error, template page can't be called as URL";
 	exit;
@@ -35,12 +35,12 @@ 
 
 $object->fields = dol_sort_array($object->fields, 'position');
 
-foreach($object->fields as $key => $val)
+foreach ($object->fields as $key => $val)
 {
 	// Discard if extrafield is a hidden field on form
 	if (abs($val['visible']) != 1) continue;
 
-	if (array_key_exists('enabled', $val) && isset($val['enabled']) && ! verifCond($val['enabled'])) continue;	// We don't want this field
+	if (array_key_exists('enabled', $val) && isset($val['enabled']) && !verifCond($val['enabled'])) continue; // We don't want this field
 
 	print '<tr id="field_'.$key.'">';
 	print '<td';
@@ -50,8 +50,8 @@ 
 	print '"';
 	print '>';
 	print $langs->trans($val['label']);
-    if(!empty($val['help'])){
-        print $form->textwithpicto('',$langs->trans($val['help']));
+    if (!empty($val['help'])) {
+        print $form->textwithpicto('', $langs->trans($val['help']));
     }
 	print '</td>';
 	print '<td>';

Braces +20 added lines, -7 removed lines

@@ -38,15 +38,24 @@ 
 foreach($object->fields as $key => $val)
 {
 	// Discard if extrafield is a hidden field on form
-	if (abs($val['visible']) != 1) continue;
+	if (abs($val['visible']) != 1) {
+	    continue;
+	}
 
-	if (array_key_exists('enabled', $val) && isset($val['enabled']) && ! verifCond($val['enabled'])) continue;	// We don't want this field
+	if (array_key_exists('enabled', $val) && isset($val['enabled']) && ! verifCond($val['enabled'])) {
+	    continue;
+	}
+	// We don't want this field
 
 	print '<tr id="field_'.$key.'">';
 	print '<td';
 	print ' class="titlefieldcreate';
-	if ($val['notnull'] > 0) print ' fieldrequired';
-	if ($val['type'] == 'text' || $val['type'] == 'html') print ' tdtop';
+	if ($val['notnull'] > 0) {
+	    print ' fieldrequired';
+	}
+	if ($val['type'] == 'text' || $val['type'] == 'html') {
+	    print ' tdtop';
+	}
 	print '"';
 	print '>';
 	print $langs->trans($val['label']);
@@ -55,9 +64,13 @@ 
     }
 	print '</td>';
 	print '<td>';
-	if (in_array($val['type'], array('int', 'integer'))) $value = GETPOST($key, 'int');
-	elseif ($val['type'] == 'text' || $val['type'] == 'html') $value = GETPOST($key, 'none');
-	else $value = GETPOST($key, 'alpha');
+	if (in_array($val['type'], array('int', 'integer'))) {
+	    $value = GETPOST($key, 'int');
+	} elseif ($val['type'] == 'text' || $val['type'] == 'html') {
+	    $value = GETPOST($key, 'none');
+	} else {
+	    $value = GETPOST($key, 'alpha');
+	}
 	print $object->showInputField($val, $key, $value, '', '', '', 0);
 	print '</td>';
 	print '</tr>';

dolibarr/htdocs/core/tpl/onlinepaymentlinks.tpl.php

Indentation +50 added lines, -50 removed lines

@@ -18,8 +18,8 @@ 
 // Protection to avoid direct call of template
 if (empty($conf) || ! is_object($conf))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 require_once DOL_DOCUMENT_ROOT.'/core/lib/payments.lib.php';
@@ -32,13 +32,13 @@ 
 print '<strong>'.getOnlinePaymentUrl(1,'free')."</strong><br><br>\n";
 if (! empty($conf->commande->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnOrder",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'order')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
-	{
-	    $langs->load("orders");
-	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Order")).': ';
+    print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnOrder",$servicename).':<br>';
+    print '<strong>'.getOnlinePaymentUrl(1,'order')."</strong><br>\n";
+    if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+    {
+        $langs->load("orders");
+        print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
+        print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Order")).': ';
         print '<input type="text class="flat" id="generate_order_ref" name="generate_order_ref" value="'.GETPOST('generate_order_ref','alpha').'" size="10">';
         print '<input type="submit" class="none button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_order_ref','alpha'))
@@ -49,18 +49,18 @@ 
             print "</strong><br>\n";
         }
         print '</form>';
-	}
-	print '<br>';
+    }
+    print '<br>';
 }
 if (! empty($conf->facture->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnInvoice",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'invoice')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
-	{
-	    $langs->load("bills");
-	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Invoice")).': ';
+    print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnInvoice",$servicename).':<br>';
+    print '<strong>'.getOnlinePaymentUrl(1,'invoice')."</strong><br>\n";
+    if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+    {
+        $langs->load("bills");
+        print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
+        print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Invoice")).': ';
         print '<input type="text class="flat" id="generate_invoice_ref" name="generate_invoice_ref" value="'.GETPOST('generate_invoice_ref','alpha').'" size="10">';
         print '<input type="submit" class="none button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_invoice_ref','alpha'))
@@ -71,18 +71,18 @@ 
             print "</strong><br>\n";
         }
         print '</form>';
-	}
-	print '<br>';
+    }
+    print '<br>';
 }
 if (! empty($conf->contrat->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnContractLine",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'contractline')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
-	{
-	    $langs->load("contracts");
-	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("ContractLine")).': ';
+    print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnContractLine",$servicename).':<br>';
+    print '<strong>'.getOnlinePaymentUrl(1,'contractline')."</strong><br>\n";
+    if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+    {
+        $langs->load("contracts");
+        print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
+        print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("ContractLine")).': ';
         print '<input type="text class="flat" id="generate_contract_ref" name="generate_contract_ref" value="'.GETPOST('generate_contract_ref','alpha').'" size="10">';
         print '<input type="submit" class="none button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_contract_ref'))
@@ -93,18 +93,18 @@ 
             print "</strong><br>\n";
         }
         print '</form>';
-	}
-	print '<br>';
+    }
+    print '<br>';
 }
 if (! empty($conf->adherent->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnMemberSubscription",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'membersubscription')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
-	{
-	    $langs->load("members");
-	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Member")).': ';
+    print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnMemberSubscription",$servicename).':<br>';
+    print '<strong>'.getOnlinePaymentUrl(1,'membersubscription')."</strong><br>\n";
+    if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+    {
+        $langs->load("members");
+        print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
+        print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Member")).': ';
         print '<input type="text class="flat" id="generate_member_ref" name="generate_member_ref" value="'.GETPOST('generate_member_ref','alpha').'" size="10">';
         print '<input type="submit" class="none reposition button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_member_ref'))
@@ -115,18 +115,18 @@ 
             print "</strong><br>\n";
         }
         print '</form>';
-	}
-	print '<br>';
+    }
+    print '<br>';
 }
 if (! empty($conf->don->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnDonation",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'donation')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
-	{
-	    $langs->load("members");
-	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Don")).': ';
+    print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnDonation",$servicename).':<br>';
+    print '<strong>'.getOnlinePaymentUrl(1,'donation')."</strong><br>\n";
+    if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+    {
+        $langs->load("members");
+        print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
+        print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Don")).': ';
         print '<input type="text class="flat" id="generate_donation_ref" name="generate_donation_ref" value="'.GETPOST('generate_donation_ref','alpha').'" size="10">';
         print '<input type="submit" class="none reposition button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_donation_ref'))
@@ -137,14 +137,14 @@ 
             print "</strong><br>\n";
         }
         print '</form>';
-	}
-	print '<br>';
+    }
+    print '<br>';
 }
 
 if (! empty($conf->use_javascript_ajax))
 {
-	print "\n".'<script type="text/javascript">';
-	print '$(document).ready(function () {
+    print "\n".'<script type="text/javascript">';
+    print '$(document).ready(function () {
 		$("#generate_token").click(function() {
             	$.get( "'.DOL_URL_ROOT.'/core/ajax/security.php", {
             		action: \'getrandompassword\',
@@ -155,7 +155,7 @@ 
 				});
             });
     	});';
-	print '</script>';
+    print '</script>';
 }
 
 print info_admin($langs->trans("YouCanAddTagOnUrl"));

Spacing +41 added lines, -41 removed lines

@@ -16,7 +16,7 @@ 
  */
 
 // Protection to avoid direct call of template
-if (empty($conf) || ! is_object($conf))
+if (empty($conf) || !is_object($conf))
 {
 	print "Error, template page can't be called as URL";
 	exit;
@@ -28,23 +28,23 @@ 
 
 // Url list
 print '<u>'.$langs->trans("FollowingUrlAreAvailableToMakePayments").':</u><br><br>';
-print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnFreeAmount",$servicename).':<br>';
-print '<strong>'.getOnlinePaymentUrl(1,'free')."</strong><br><br>\n";
-if (! empty($conf->commande->enabled))
+print img_picto('', 'object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnFreeAmount", $servicename).':<br>';
+print '<strong>'.getOnlinePaymentUrl(1, 'free')."</strong><br><br>\n";
+if (!empty($conf->commande->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnOrder",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'order')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+	print img_picto('', 'object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnOrder", $servicename).':<br>';
+	print '<strong>'.getOnlinePaymentUrl(1, 'order')."</strong><br>\n";
+	if (!empty($conf->global->PAYMENT_SECURITY_TOKEN) && !empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
 	{
 	    $langs->load("orders");
 	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Order")).': ';
-        print '<input type="text class="flat" id="generate_order_ref" name="generate_order_ref" value="'.GETPOST('generate_order_ref','alpha').'" size="10">';
+	    print $langs->trans("EnterRefToBuildUrl", $langs->transnoentitiesnoconv("Order")).': ';
+        print '<input type="text class="flat" id="generate_order_ref" name="generate_order_ref" value="'.GETPOST('generate_order_ref', 'alpha').'" size="10">';
         print '<input type="submit" class="none button" value="'.$langs->trans("GetSecuredUrl").'">';
-        if (GETPOST('generate_order_ref','alpha'))
+        if (GETPOST('generate_order_ref', 'alpha'))
         {
             print '<br> -> <strong>';
-            $url=getOnlinePaymentUrl(0,'order',GETPOST('generate_order_ref','alpha'));
+            $url = getOnlinePaymentUrl(0, 'order', GETPOST('generate_order_ref', 'alpha'));
             print $url;
             print "</strong><br>\n";
         }
@@ -52,21 +52,21 @@ 
 	}
 	print '<br>';
 }
-if (! empty($conf->facture->enabled))
+if (!empty($conf->facture->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnInvoice",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'invoice')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+	print img_picto('', 'object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnInvoice", $servicename).':<br>';
+	print '<strong>'.getOnlinePaymentUrl(1, 'invoice')."</strong><br>\n";
+	if (!empty($conf->global->PAYMENT_SECURITY_TOKEN) && !empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
 	{
 	    $langs->load("bills");
 	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Invoice")).': ';
-        print '<input type="text class="flat" id="generate_invoice_ref" name="generate_invoice_ref" value="'.GETPOST('generate_invoice_ref','alpha').'" size="10">';
+	    print $langs->trans("EnterRefToBuildUrl", $langs->transnoentitiesnoconv("Invoice")).': ';
+        print '<input type="text class="flat" id="generate_invoice_ref" name="generate_invoice_ref" value="'.GETPOST('generate_invoice_ref', 'alpha').'" size="10">';
         print '<input type="submit" class="none button" value="'.$langs->trans("GetSecuredUrl").'">';
-        if (GETPOST('generate_invoice_ref','alpha'))
+        if (GETPOST('generate_invoice_ref', 'alpha'))
         {
             print '<br> -> <strong>';
-            $url=getOnlinePaymentUrl(0,'invoice',GETPOST('generate_invoice_ref','alpha'));
+            $url = getOnlinePaymentUrl(0, 'invoice', GETPOST('generate_invoice_ref', 'alpha'));
             print $url;
             print "</strong><br>\n";
         }
@@ -74,21 +74,21 @@ 
 	}
 	print '<br>';
 }
-if (! empty($conf->contrat->enabled))
+if (!empty($conf->contrat->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnContractLine",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'contractline')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+	print img_picto('', 'object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnContractLine", $servicename).':<br>';
+	print '<strong>'.getOnlinePaymentUrl(1, 'contractline')."</strong><br>\n";
+	if (!empty($conf->global->PAYMENT_SECURITY_TOKEN) && !empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
 	{
 	    $langs->load("contracts");
 	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("ContractLine")).': ';
-        print '<input type="text class="flat" id="generate_contract_ref" name="generate_contract_ref" value="'.GETPOST('generate_contract_ref','alpha').'" size="10">';
+	    print $langs->trans("EnterRefToBuildUrl", $langs->transnoentitiesnoconv("ContractLine")).': ';
+        print '<input type="text class="flat" id="generate_contract_ref" name="generate_contract_ref" value="'.GETPOST('generate_contract_ref', 'alpha').'" size="10">';
         print '<input type="submit" class="none button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_contract_ref'))
         {
             print '<br> -> <strong>';
-            $url=getOnlinePaymentUrl(0,'contractline',GETPOST('generate_contract_ref','alpha'));
+            $url = getOnlinePaymentUrl(0, 'contractline', GETPOST('generate_contract_ref', 'alpha'));
             print $url;
             print "</strong><br>\n";
         }
@@ -96,21 +96,21 @@ 
 	}
 	print '<br>';
 }
-if (! empty($conf->adherent->enabled))
+if (!empty($conf->adherent->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnMemberSubscription",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'membersubscription')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+	print img_picto('', 'object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnMemberSubscription", $servicename).':<br>';
+	print '<strong>'.getOnlinePaymentUrl(1, 'membersubscription')."</strong><br>\n";
+	if (!empty($conf->global->PAYMENT_SECURITY_TOKEN) && !empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
 	{
 	    $langs->load("members");
 	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Member")).': ';
-        print '<input type="text class="flat" id="generate_member_ref" name="generate_member_ref" value="'.GETPOST('generate_member_ref','alpha').'" size="10">';
+	    print $langs->trans("EnterRefToBuildUrl", $langs->transnoentitiesnoconv("Member")).': ';
+        print '<input type="text class="flat" id="generate_member_ref" name="generate_member_ref" value="'.GETPOST('generate_member_ref', 'alpha').'" size="10">';
         print '<input type="submit" class="none reposition button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_member_ref'))
         {
             print '<br> -> <strong>';
-            $url=getOnlinePaymentUrl(0,'membersubscription',GETPOST('generate_member_ref','alpha'));
+            $url = getOnlinePaymentUrl(0, 'membersubscription', GETPOST('generate_member_ref', 'alpha'));
             print $url;
             print "</strong><br>\n";
         }
@@ -118,21 +118,21 @@ 
 	}
 	print '<br>';
 }
-if (! empty($conf->don->enabled))
+if (!empty($conf->don->enabled))
 {
-	print img_picto('','object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnDonation",$servicename).':<br>';
-	print '<strong>'.getOnlinePaymentUrl(1,'donation')."</strong><br>\n";
-	if (! empty($conf->global->PAYMENT_SECURITY_TOKEN) && ! empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
+	print img_picto('', 'object_globe.png').' '.$langs->trans("ToOfferALinkForOnlinePaymentOnDonation", $servicename).':<br>';
+	print '<strong>'.getOnlinePaymentUrl(1, 'donation')."</strong><br>\n";
+	if (!empty($conf->global->PAYMENT_SECURITY_TOKEN) && !empty($conf->global->PAYMENT_SECURITY_TOKEN_UNIQUE))
 	{
 	    $langs->load("members");
 	    print '<form action="'.$_SERVER["PHP_SELF"].'" method="POST">';
-	    print $langs->trans("EnterRefToBuildUrl",$langs->transnoentitiesnoconv("Don")).': ';
-        print '<input type="text class="flat" id="generate_donation_ref" name="generate_donation_ref" value="'.GETPOST('generate_donation_ref','alpha').'" size="10">';
+	    print $langs->trans("EnterRefToBuildUrl", $langs->transnoentitiesnoconv("Don")).': ';
+        print '<input type="text class="flat" id="generate_donation_ref" name="generate_donation_ref" value="'.GETPOST('generate_donation_ref', 'alpha').'" size="10">';
         print '<input type="submit" class="none reposition button" value="'.$langs->trans("GetSecuredUrl").'">';
         if (GETPOST('generate_donation_ref'))
         {
             print '<br> -> <strong>';
-            $url=getOnlinePaymentUrl(0,'donation',GETPOST('generate_donation_ref','alpha'));
+            $url = getOnlinePaymentUrl(0, 'donation', GETPOST('generate_donation_ref', 'alpha'));
             print $url;
             print "</strong><br>\n";
         }
@@ -141,7 +141,7 @@ 
 	print '<br>';
 }
 
-if (! empty($conf->use_javascript_ajax))
+if (!empty($conf->use_javascript_ajax))
 {
 	print "\n".'<script type="text/javascript">';
 	print '$(document).ready(function () {

dolibarr/htdocs/core/tpl/extrafields_view.tpl.php

Indentation +131 added lines, -131 removed lines

@@ -27,8 +27,8 @@ 
 // Protection to avoid direct call of template
 if (empty($object) || ! is_object($object))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 if (! is_object($form)) $form=new Form($db);
@@ -50,134 +50,134 @@ 
 if (empty($reshook) && is_array($extrafields->attributes[$object->table_element]['label']))
 
 {
-	foreach ($extrafields->attributes[$object->table_element]['label'] as $key => $label)
-	{
-		// Discard if extrafield is a hidden field on form
-
-		$enabled = 1;
-		if ($enabled && isset($extrafields->attributes[$object->table_element]['enabled'][$key]))
-		{
-			$enabled = dol_eval($extrafields->attributes[$object->table_element]['enabled'][$key], 1);
-		}
-		if ($enabled && isset($extrafields->attributes[$object->table_element]['list'][$key]))
-		{
-			$enabled = dol_eval($extrafields->attributes[$object->table_element]['list'][$key], 1);
-		}
-		$perms = 1;
-		if ($perms && isset($extrafields->attributes[$object->table_element]['perms'][$key]))
-		{
-			$perms = dol_eval($extrafields->attributes[$object->table_element]['perms'][$key], 1);
-		}
-		//print $key.'-'.$enabled.'-'.$perms.'-'.$label.$_POST["options_" . $key].'<br>'."\n";
-
-		if (empty($enabled)) continue;	// 0 = Never visible field
-		if (abs($enabled) != 1 && abs($enabled) != 3) continue;  // <> -1 and <> 1 and <> 3 = not visible on forms, only on list
-		if (empty($perms)) continue;    // 0 = Not visible
-
-		// Load language if required
-		if (! empty($extrafields->attributes[$object->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$object->table_element]['langfile'][$key]);
-		if ($action == 'edit_extras')
-		{
-			$value = (isset($_POST["options_" . $key]) ? $_POST["options_" . $key] : $object->array_options["options_" . $key]);
-		}
-		else
-		{
-			$value = $object->array_options["options_" . $key];
-		}
-		if ($extrafields->attributes[$object->table_element]['type'][$key] == 'separate')
-		{
-			print $extrafields->showSeparator($key, $object);
-		}
-		else
-		{
-			print '<tr>';
-			print '<td class="titlefield">';
-			print '<table width="100%" class="nobordernopadding">';
-			print '<tr>';
-			print '<td';
-			print ' class="';
-			//var_dump($action);exit;
-
-			if ((! empty($action) && ($action == 'create' || $action == 'edit')) && ! empty($extrafields->attributes[$object->table_element]['required'][$key])) print ' fieldrequired';
-			print '">';
-			if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) print $form->textwithpicto($langs->trans($label), $langs->trans($extrafields->attributes[$object->table_element]['help'][$key]));
-			else print $langs->trans($label);
-			print '</td>';
-
-			//TODO Improve element and rights detection
-			//var_dump($user->rights);
-			$permok=false;
-			$keyforperm=$object->element;
-			if ($object->element == 'fichinter') $keyforperm='ficheinter';
-			if (isset($user->rights->$keyforperm)) $permok=$user->rights->$keyforperm->creer||$user->rights->$keyforperm->create||$user->rights->$keyforperm->write;
-			if ($object->element=='order_supplier')   $permok=$user->rights->fournisseur->commande->creer;
-			if ($object->element=='invoice_supplier') $permok=$user->rights->fournisseur->facture->creer;
-			if ($object->element=='shipping')         $permok=$user->rights->expedition->creer;
-			if ($object->element=='delivery')         $permok=$user->rights->expedition->livraison->creer;
-			if ($object->element=='productlot')       $permok=$user->rights->stock->creer;
-			if ($object->element=='facturerec') 	  $permok=$user->rights->facture->creer;
-			if (($object->statut == 0 || ! empty($extrafields->attributes[$object->table_element]['alwayseditable'][$key]))
-				&& $permok && ($action != 'edit_extras' || GETPOST('attribute') != $key)
-			    && empty($extrafields->attributes[$object->table_element]['computed'][$key]))
-			{
-			    $fieldid='id';
-			    if ($object->table_element == 'societe') $fieldid='socid';
-				print '<td align="right"><a class="reposition" href="' . $_SERVER['PHP_SELF'] . '?'.$fieldid.'=' . $object->id . '&action=edit_extras&attribute=' . $key . '">' . img_edit().'</a></td>';
-			}
-			print '</tr></table>';
-			print '</td>';
-
-			$html_id = !empty($object->id) ? $object->element.'_extras_'.$key.'_'.$object->id : '';
-
-			print '<td id="'.$html_id.'" class="'.$object->element.'_extras_'.$key.' wordbreak"'.($cols?' colspan="'.$cols.'"':'').'>';
-
-			// Convert date into timestamp format
-			if (in_array($extrafields->attributes[$object->table_element]['type'][$key], array('date','datetime')))
-			{
-				$datenotinstring = $object->array_options['options_' . $key];
-				// print 'X'.$object->array_options['options_' . $key].'-'.$datenotinstring.'x';
-				if (! is_numeric($object->array_options['options_' . $key]))	// For backward compatibility
-				{
-					$datenotinstring = $db->jdate($datenotinstring);
-				}
-				//print 'x'.$object->array_options['options_' . $key].'-'.$datenotinstring.' - '.dol_print_date($datenotinstring, 'dayhour');
-				$value = isset($_POST["options_" . $key]) ? dol_mktime($_POST["options_" . $key . "hour"], $_POST["options_" . $key . "min"], 0, $_POST["options_" . $key . "month"], $_POST["options_" . $key . "day"], $_POST["options_" . $key . "year"]) : $datenotinstring;
-			}
-			//TODO Improve element and rights detection
-			if ($action == 'edit_extras' && $permok && GETPOST('attribute','none') == $key)
-			{
-			    $fieldid='id';
-			    if ($object->table_element == 'societe') $fieldid='socid';
-			    print '<form enctype="multipart/form-data" action="' . $_SERVER["PHP_SELF"] . '" method="post" name="formextra">';
-				print '<input type="hidden" name="action" value="update_extras">';
-				print '<input type="hidden" name="attribute" value="' . $key . '">';
-				print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';
-				print '<input type="hidden" name="'.$fieldid.'" value="' . $object->id . '">';
-				print $extrafields->showInputField($key, $value, '', '', '', 0, $object->id);
-
-
-				print '<input type="submit" class="button" value="' . dol_escape_htmltag($langs->trans('Modify')) . '">';
-
-				print '</form>';
-			}
-			else
-			{
-				//print $key.'-'.$value.'-'.$object->table_element;
-				print $extrafields->showOutputField($key, $value, '', $object->table_element);
-			}
-
-			print '</td>';
-			print '</tr>' . "\n";
-		}
-	}
-
-
-	// Add code to manage list depending on others
-	// TODO Test/enhance this with a more generic solution
-	if (! empty($conf->use_javascript_ajax))
-	{
-		print "\n";
-		print '
+    foreach ($extrafields->attributes[$object->table_element]['label'] as $key => $label)
+    {
+        // Discard if extrafield is a hidden field on form
+
+        $enabled = 1;
+        if ($enabled && isset($extrafields->attributes[$object->table_element]['enabled'][$key]))
+        {
+            $enabled = dol_eval($extrafields->attributes[$object->table_element]['enabled'][$key], 1);
+        }
+        if ($enabled && isset($extrafields->attributes[$object->table_element]['list'][$key]))
+        {
+            $enabled = dol_eval($extrafields->attributes[$object->table_element]['list'][$key], 1);
+        }
+        $perms = 1;
+        if ($perms && isset($extrafields->attributes[$object->table_element]['perms'][$key]))
+        {
+            $perms = dol_eval($extrafields->attributes[$object->table_element]['perms'][$key], 1);
+        }
+        //print $key.'-'.$enabled.'-'.$perms.'-'.$label.$_POST["options_" . $key].'<br>'."\n";
+
+        if (empty($enabled)) continue;	// 0 = Never visible field
+        if (abs($enabled) != 1 && abs($enabled) != 3) continue;  // <> -1 and <> 1 and <> 3 = not visible on forms, only on list
+        if (empty($perms)) continue;    // 0 = Not visible
+
+        // Load language if required
+        if (! empty($extrafields->attributes[$object->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$object->table_element]['langfile'][$key]);
+        if ($action == 'edit_extras')
+        {
+            $value = (isset($_POST["options_" . $key]) ? $_POST["options_" . $key] : $object->array_options["options_" . $key]);
+        }
+        else
+        {
+            $value = $object->array_options["options_" . $key];
+        }
+        if ($extrafields->attributes[$object->table_element]['type'][$key] == 'separate')
+        {
+            print $extrafields->showSeparator($key, $object);
+        }
+        else
+        {
+            print '<tr>';
+            print '<td class="titlefield">';
+            print '<table width="100%" class="nobordernopadding">';
+            print '<tr>';
+            print '<td';
+            print ' class="';
+            //var_dump($action);exit;
+
+            if ((! empty($action) && ($action == 'create' || $action == 'edit')) && ! empty($extrafields->attributes[$object->table_element]['required'][$key])) print ' fieldrequired';
+            print '">';
+            if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) print $form->textwithpicto($langs->trans($label), $langs->trans($extrafields->attributes[$object->table_element]['help'][$key]));
+            else print $langs->trans($label);
+            print '</td>';
+
+            //TODO Improve element and rights detection
+            //var_dump($user->rights);
+            $permok=false;
+            $keyforperm=$object->element;
+            if ($object->element == 'fichinter') $keyforperm='ficheinter';
+            if (isset($user->rights->$keyforperm)) $permok=$user->rights->$keyforperm->creer||$user->rights->$keyforperm->create||$user->rights->$keyforperm->write;
+            if ($object->element=='order_supplier')   $permok=$user->rights->fournisseur->commande->creer;
+            if ($object->element=='invoice_supplier') $permok=$user->rights->fournisseur->facture->creer;
+            if ($object->element=='shipping')         $permok=$user->rights->expedition->creer;
+            if ($object->element=='delivery')         $permok=$user->rights->expedition->livraison->creer;
+            if ($object->element=='productlot')       $permok=$user->rights->stock->creer;
+            if ($object->element=='facturerec') 	  $permok=$user->rights->facture->creer;
+            if (($object->statut == 0 || ! empty($extrafields->attributes[$object->table_element]['alwayseditable'][$key]))
+                && $permok && ($action != 'edit_extras' || GETPOST('attribute') != $key)
+                && empty($extrafields->attributes[$object->table_element]['computed'][$key]))
+            {
+                $fieldid='id';
+                if ($object->table_element == 'societe') $fieldid='socid';
+                print '<td align="right"><a class="reposition" href="' . $_SERVER['PHP_SELF'] . '?'.$fieldid.'=' . $object->id . '&action=edit_extras&attribute=' . $key . '">' . img_edit().'</a></td>';
+            }
+            print '</tr></table>';
+            print '</td>';
+
+            $html_id = !empty($object->id) ? $object->element.'_extras_'.$key.'_'.$object->id : '';
+
+            print '<td id="'.$html_id.'" class="'.$object->element.'_extras_'.$key.' wordbreak"'.($cols?' colspan="'.$cols.'"':'').'>';
+
+            // Convert date into timestamp format
+            if (in_array($extrafields->attributes[$object->table_element]['type'][$key], array('date','datetime')))
+            {
+                $datenotinstring = $object->array_options['options_' . $key];
+                // print 'X'.$object->array_options['options_' . $key].'-'.$datenotinstring.'x';
+                if (! is_numeric($object->array_options['options_' . $key]))	// For backward compatibility
+                {
+                    $datenotinstring = $db->jdate($datenotinstring);
+                }
+                //print 'x'.$object->array_options['options_' . $key].'-'.$datenotinstring.' - '.dol_print_date($datenotinstring, 'dayhour');
+                $value = isset($_POST["options_" . $key]) ? dol_mktime($_POST["options_" . $key . "hour"], $_POST["options_" . $key . "min"], 0, $_POST["options_" . $key . "month"], $_POST["options_" . $key . "day"], $_POST["options_" . $key . "year"]) : $datenotinstring;
+            }
+            //TODO Improve element and rights detection
+            if ($action == 'edit_extras' && $permok && GETPOST('attribute','none') == $key)
+            {
+                $fieldid='id';
+                if ($object->table_element == 'societe') $fieldid='socid';
+                print '<form enctype="multipart/form-data" action="' . $_SERVER["PHP_SELF"] . '" method="post" name="formextra">';
+                print '<input type="hidden" name="action" value="update_extras">';
+                print '<input type="hidden" name="attribute" value="' . $key . '">';
+                print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';
+                print '<input type="hidden" name="'.$fieldid.'" value="' . $object->id . '">';
+                print $extrafields->showInputField($key, $value, '', '', '', 0, $object->id);
+
+
+                print '<input type="submit" class="button" value="' . dol_escape_htmltag($langs->trans('Modify')) . '">';
+
+                print '</form>';
+            }
+            else
+            {
+                //print $key.'-'.$value.'-'.$object->table_element;
+                print $extrafields->showOutputField($key, $value, '', $object->table_element);
+            }
+
+            print '</td>';
+            print '</tr>' . "\n";
+        }
+    }
+
+
+    // Add code to manage list depending on others
+    // TODO Test/enhance this with a more generic solution
+    if (! empty($conf->use_javascript_ajax))
+    {
+        print "\n";
+        print '
 				<script type="text/javascript">
 				    jQuery(document).ready(function() {
 				    	function showOptions(child_list, parent_list)
@@ -205,7 +205,7 @@ 
 						setListDependencies();
 				    });
 				</script>'."\n";
-	}
+    }
 }
 ?>
 <!-- END PHP TEMPLATE extrafields_view.tpl.php -->

Spacing +43 added lines, -43 removed lines

@@ -25,22 +25,22 @@ 
  * $cols
  */
 // Protection to avoid direct call of template
-if (empty($object) || ! is_object($object))
+if (empty($object) || !is_object($object))
 {
 	print "Error, template page can't be called as URL";
 	exit;
 }
 
-if (! is_object($form)) $form=new Form($db);
+if (!is_object($form)) $form = new Form($db);
 
 
 ?>
 <!-- BEGIN PHP TEMPLATE extrafields_view.tpl.php -->
 <?php
-if (! is_array($parameters)) $parameters = array();
-if (! empty($cols)) $parameters['colspan'] = ' colspan="'.$cols.'"';
-if (! empty($cols)) $parameters['cols'] = $cols;
-if (! empty($object->fk_soc)) $parameters['socid'] = $object->fk_soc;
+if (!is_array($parameters)) $parameters = array();
+if (!empty($cols)) $parameters['colspan'] = ' colspan="'.$cols.'"';
+if (!empty($cols)) $parameters['cols'] = $cols;
+if (!empty($object->fk_soc)) $parameters['socid'] = $object->fk_soc;
 $reshook = $hookmanager->executeHooks('formObjectOptions', $parameters, $object, $action);
 print $hookmanager->resPrint;
 if ($reshook < 0) setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
@@ -70,19 +70,19 @@ 
 		}
 		//print $key.'-'.$enabled.'-'.$perms.'-'.$label.$_POST["options_" . $key].'<br>'."\n";
 
-		if (empty($enabled)) continue;	// 0 = Never visible field
-		if (abs($enabled) != 1 && abs($enabled) != 3) continue;  // <> -1 and <> 1 and <> 3 = not visible on forms, only on list
-		if (empty($perms)) continue;    // 0 = Not visible
+		if (empty($enabled)) continue; // 0 = Never visible field
+		if (abs($enabled) != 1 && abs($enabled) != 3) continue; // <> -1 and <> 1 and <> 3 = not visible on forms, only on list
+		if (empty($perms)) continue; // 0 = Not visible
 
 		// Load language if required
-		if (! empty($extrafields->attributes[$object->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$object->table_element]['langfile'][$key]);
+		if (!empty($extrafields->attributes[$object->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$object->table_element]['langfile'][$key]);
 		if ($action == 'edit_extras')
 		{
-			$value = (isset($_POST["options_" . $key]) ? $_POST["options_" . $key] : $object->array_options["options_" . $key]);
+			$value = (isset($_POST["options_".$key]) ? $_POST["options_".$key] : $object->array_options["options_".$key]);
 		}
 		else
 		{
-			$value = $object->array_options["options_" . $key];
+			$value = $object->array_options["options_".$key];
 		}
 		if ($extrafields->attributes[$object->table_element]['type'][$key] == 'separate')
 		{
@@ -98,65 +98,65 @@ 
 			print ' class="';
 			//var_dump($action);exit;
 
-			if ((! empty($action) && ($action == 'create' || $action == 'edit')) && ! empty($extrafields->attributes[$object->table_element]['required'][$key])) print ' fieldrequired';
+			if ((!empty($action) && ($action == 'create' || $action == 'edit')) && !empty($extrafields->attributes[$object->table_element]['required'][$key])) print ' fieldrequired';
 			print '">';
-			if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) print $form->textwithpicto($langs->trans($label), $langs->trans($extrafields->attributes[$object->table_element]['help'][$key]));
+			if (!empty($extrafields->attributes[$object->table_element]['help'][$key])) print $form->textwithpicto($langs->trans($label), $langs->trans($extrafields->attributes[$object->table_element]['help'][$key]));
 			else print $langs->trans($label);
 			print '</td>';
 
 			//TODO Improve element and rights detection
 			//var_dump($user->rights);
-			$permok=false;
-			$keyforperm=$object->element;
-			if ($object->element == 'fichinter') $keyforperm='ficheinter';
-			if (isset($user->rights->$keyforperm)) $permok=$user->rights->$keyforperm->creer||$user->rights->$keyforperm->create||$user->rights->$keyforperm->write;
-			if ($object->element=='order_supplier')   $permok=$user->rights->fournisseur->commande->creer;
-			if ($object->element=='invoice_supplier') $permok=$user->rights->fournisseur->facture->creer;
-			if ($object->element=='shipping')         $permok=$user->rights->expedition->creer;
-			if ($object->element=='delivery')         $permok=$user->rights->expedition->livraison->creer;
-			if ($object->element=='productlot')       $permok=$user->rights->stock->creer;
-			if ($object->element=='facturerec') 	  $permok=$user->rights->facture->creer;
-			if (($object->statut == 0 || ! empty($extrafields->attributes[$object->table_element]['alwayseditable'][$key]))
+			$permok = false;
+			$keyforperm = $object->element;
+			if ($object->element == 'fichinter') $keyforperm = 'ficheinter';
+			if (isset($user->rights->$keyforperm)) $permok = $user->rights->$keyforperm->creer || $user->rights->$keyforperm->create || $user->rights->$keyforperm->write;
+			if ($object->element == 'order_supplier')   $permok = $user->rights->fournisseur->commande->creer;
+			if ($object->element == 'invoice_supplier') $permok = $user->rights->fournisseur->facture->creer;
+			if ($object->element == 'shipping')         $permok = $user->rights->expedition->creer;
+			if ($object->element == 'delivery')         $permok = $user->rights->expedition->livraison->creer;
+			if ($object->element == 'productlot')       $permok = $user->rights->stock->creer;
+			if ($object->element == 'facturerec') 	  $permok = $user->rights->facture->creer;
+			if (($object->statut == 0 || !empty($extrafields->attributes[$object->table_element]['alwayseditable'][$key]))
 				&& $permok && ($action != 'edit_extras' || GETPOST('attribute') != $key)
 			    && empty($extrafields->attributes[$object->table_element]['computed'][$key]))
 			{
-			    $fieldid='id';
-			    if ($object->table_element == 'societe') $fieldid='socid';
-				print '<td align="right"><a class="reposition" href="' . $_SERVER['PHP_SELF'] . '?'.$fieldid.'=' . $object->id . '&action=edit_extras&attribute=' . $key . '">' . img_edit().'</a></td>';
+			    $fieldid = 'id';
+			    if ($object->table_element == 'societe') $fieldid = 'socid';
+				print '<td align="right"><a class="reposition" href="'.$_SERVER['PHP_SELF'].'?'.$fieldid.'='.$object->id.'&action=edit_extras&attribute='.$key.'">'.img_edit().'</a></td>';
 			}
 			print '</tr></table>';
 			print '</td>';
 
 			$html_id = !empty($object->id) ? $object->element.'_extras_'.$key.'_'.$object->id : '';
 
-			print '<td id="'.$html_id.'" class="'.$object->element.'_extras_'.$key.' wordbreak"'.($cols?' colspan="'.$cols.'"':'').'>';
+			print '<td id="'.$html_id.'" class="'.$object->element.'_extras_'.$key.' wordbreak"'.($cols ? ' colspan="'.$cols.'"' : '').'>';
 
 			// Convert date into timestamp format
-			if (in_array($extrafields->attributes[$object->table_element]['type'][$key], array('date','datetime')))
+			if (in_array($extrafields->attributes[$object->table_element]['type'][$key], array('date', 'datetime')))
 			{
-				$datenotinstring = $object->array_options['options_' . $key];
+				$datenotinstring = $object->array_options['options_'.$key];
 				// print 'X'.$object->array_options['options_' . $key].'-'.$datenotinstring.'x';
-				if (! is_numeric($object->array_options['options_' . $key]))	// For backward compatibility
+				if (!is_numeric($object->array_options['options_'.$key]))	// For backward compatibility
 				{
 					$datenotinstring = $db->jdate($datenotinstring);
 				}
 				//print 'x'.$object->array_options['options_' . $key].'-'.$datenotinstring.' - '.dol_print_date($datenotinstring, 'dayhour');
-				$value = isset($_POST["options_" . $key]) ? dol_mktime($_POST["options_" . $key . "hour"], $_POST["options_" . $key . "min"], 0, $_POST["options_" . $key . "month"], $_POST["options_" . $key . "day"], $_POST["options_" . $key . "year"]) : $datenotinstring;
+				$value = isset($_POST["options_".$key]) ? dol_mktime($_POST["options_".$key."hour"], $_POST["options_".$key."min"], 0, $_POST["options_".$key."month"], $_POST["options_".$key."day"], $_POST["options_".$key."year"]) : $datenotinstring;
 			}
 			//TODO Improve element and rights detection
-			if ($action == 'edit_extras' && $permok && GETPOST('attribute','none') == $key)
+			if ($action == 'edit_extras' && $permok && GETPOST('attribute', 'none') == $key)
 			{
-			    $fieldid='id';
-			    if ($object->table_element == 'societe') $fieldid='socid';
-			    print '<form enctype="multipart/form-data" action="' . $_SERVER["PHP_SELF"] . '" method="post" name="formextra">';
+			    $fieldid = 'id';
+			    if ($object->table_element == 'societe') $fieldid = 'socid';
+			    print '<form enctype="multipart/form-data" action="'.$_SERVER["PHP_SELF"].'" method="post" name="formextra">';
 				print '<input type="hidden" name="action" value="update_extras">';
-				print '<input type="hidden" name="attribute" value="' . $key . '">';
-				print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';
-				print '<input type="hidden" name="'.$fieldid.'" value="' . $object->id . '">';
+				print '<input type="hidden" name="attribute" value="'.$key.'">';
+				print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';
+				print '<input type="hidden" name="'.$fieldid.'" value="'.$object->id.'">';
 				print $extrafields->showInputField($key, $value, '', '', '', 0, $object->id);
 
 
-				print '<input type="submit" class="button" value="' . dol_escape_htmltag($langs->trans('Modify')) . '">';
+				print '<input type="submit" class="button" value="'.dol_escape_htmltag($langs->trans('Modify')).'">';
 
 				print '</form>';
 			}
@@ -167,14 +167,14 @@ 
 			}
 
 			print '</td>';
-			print '</tr>' . "\n";
+			print '</tr>'."\n";
 		}
 	}
 
 
 	// Add code to manage list depending on others
 	// TODO Test/enhance this with a more generic solution
-	if (! empty($conf->use_javascript_ajax))
+	if (!empty($conf->use_javascript_ajax))
 	{
 		print "\n";
 		print '

Braces +77 added lines, -30 removed lines

@@ -31,19 +31,31 @@ 
 	exit;
 }
 
-if (! is_object($form)) $form=new Form($db);
+if (! is_object($form)) {
+    $form=new Form($db);
+}
 
 
 ?>
 <!-- BEGIN PHP TEMPLATE extrafields_view.tpl.php -->
 <?php
-if (! is_array($parameters)) $parameters = array();
-if (! empty($cols)) $parameters['colspan'] = ' colspan="'.$cols.'"';
-if (! empty($cols)) $parameters['cols'] = $cols;
-if (! empty($object->fk_soc)) $parameters['socid'] = $object->fk_soc;
+if (! is_array($parameters)) {
+    $parameters = array();
+}
+if (! empty($cols)) {
+    $parameters['colspan'] = ' colspan="'.$cols.'"';
+}
+if (! empty($cols)) {
+    $parameters['cols'] = $cols;
+}
+if (! empty($object->fk_soc)) {
+    $parameters['socid'] = $object->fk_soc;
+}
 $reshook = $hookmanager->executeHooks('formObjectOptions', $parameters, $object, $action);
 print $hookmanager->resPrint;
-if ($reshook < 0) setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
+if ($reshook < 0) {
+    setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
+}
 
 
 //var_dump($extrafields->attributes[$object->table_element]);
@@ -70,25 +82,34 @@ 
 		}
 		//print $key.'-'.$enabled.'-'.$perms.'-'.$label.$_POST["options_" . $key].'<br>'."\n";
 
-		if (empty($enabled)) continue;	// 0 = Never visible field
-		if (abs($enabled) != 1 && abs($enabled) != 3) continue;  // <> -1 and <> 1 and <> 3 = not visible on forms, only on list
-		if (empty($perms)) continue;    // 0 = Not visible
+		if (empty($enabled)) {
+		    continue;
+		}
+		// 0 = Never visible field
+		if (abs($enabled) != 1 && abs($enabled) != 3) {
+		    continue;
+		}
+		// <> -1 and <> 1 and <> 3 = not visible on forms, only on list
+		if (empty($perms)) {
+		    continue;
+		}
+		// 0 = Not visible
 
 		// Load language if required
-		if (! empty($extrafields->attributes[$object->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$object->table_element]['langfile'][$key]);
+		if (! empty($extrafields->attributes[$object->table_element]['langfile'][$key])) {
+		    $langs->load($extrafields->attributes[$object->table_element]['langfile'][$key]);
+		}
 		if ($action == 'edit_extras')
 		{
 			$value = (isset($_POST["options_" . $key]) ? $_POST["options_" . $key] : $object->array_options["options_" . $key]);
-		}
-		else
+		} else
 		{
 			$value = $object->array_options["options_" . $key];
 		}
 		if ($extrafields->attributes[$object->table_element]['type'][$key] == 'separate')
 		{
 			print $extrafields->showSeparator($key, $object);
-		}
-		else
+		} else
 		{
 			print '<tr>';
 			print '<td class="titlefield">';
@@ -98,30 +119,53 @@ 
 			print ' class="';
 			//var_dump($action);exit;
 
-			if ((! empty($action) && ($action == 'create' || $action == 'edit')) && ! empty($extrafields->attributes[$object->table_element]['required'][$key])) print ' fieldrequired';
+			if ((! empty($action) && ($action == 'create' || $action == 'edit')) && ! empty($extrafields->attributes[$object->table_element]['required'][$key])) {
+			    print ' fieldrequired';
+			}
 			print '">';
-			if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) print $form->textwithpicto($langs->trans($label), $langs->trans($extrafields->attributes[$object->table_element]['help'][$key]));
-			else print $langs->trans($label);
+			if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) {
+			    print $form->textwithpicto($langs->trans($label), $langs->trans($extrafields->attributes[$object->table_element]['help'][$key]));
+			} else {
+			    print $langs->trans($label);
+			}
 			print '</td>';
 
 			//TODO Improve element and rights detection
 			//var_dump($user->rights);
 			$permok=false;
 			$keyforperm=$object->element;
-			if ($object->element == 'fichinter') $keyforperm='ficheinter';
-			if (isset($user->rights->$keyforperm)) $permok=$user->rights->$keyforperm->creer||$user->rights->$keyforperm->create||$user->rights->$keyforperm->write;
-			if ($object->element=='order_supplier')   $permok=$user->rights->fournisseur->commande->creer;
-			if ($object->element=='invoice_supplier') $permok=$user->rights->fournisseur->facture->creer;
-			if ($object->element=='shipping')         $permok=$user->rights->expedition->creer;
-			if ($object->element=='delivery')         $permok=$user->rights->expedition->livraison->creer;
-			if ($object->element=='productlot')       $permok=$user->rights->stock->creer;
-			if ($object->element=='facturerec') 	  $permok=$user->rights->facture->creer;
+			if ($object->element == 'fichinter') {
+			    $keyforperm='ficheinter';
+			}
+			if (isset($user->rights->$keyforperm)) {
+			    $permok=$user->rights->$keyforperm->creer||$user->rights->$keyforperm->create||$user->rights->$keyforperm->write;
+			}
+			if ($object->element=='order_supplier') {
+			    $permok=$user->rights->fournisseur->commande->creer;
+			}
+			if ($object->element=='invoice_supplier') {
+			    $permok=$user->rights->fournisseur->facture->creer;
+			}
+			if ($object->element=='shipping') {
+			    $permok=$user->rights->expedition->creer;
+			}
+			if ($object->element=='delivery') {
+			    $permok=$user->rights->expedition->livraison->creer;
+			}
+			if ($object->element=='productlot') {
+			    $permok=$user->rights->stock->creer;
+			}
+			if ($object->element=='facturerec') {
+			    $permok=$user->rights->facture->creer;
+			}
 			if (($object->statut == 0 || ! empty($extrafields->attributes[$object->table_element]['alwayseditable'][$key]))
 				&& $permok && ($action != 'edit_extras' || GETPOST('attribute') != $key)
 			    && empty($extrafields->attributes[$object->table_element]['computed'][$key]))
 			{
 			    $fieldid='id';
-			    if ($object->table_element == 'societe') $fieldid='socid';
+			    if ($object->table_element == 'societe') {
+			        $fieldid='socid';
+			    }
 				print '<td align="right"><a class="reposition" href="' . $_SERVER['PHP_SELF'] . '?'.$fieldid.'=' . $object->id . '&action=edit_extras&attribute=' . $key . '">' . img_edit().'</a></td>';
 			}
 			print '</tr></table>';
@@ -136,10 +180,12 @@ 
 			{
 				$datenotinstring = $object->array_options['options_' . $key];
 				// print 'X'.$object->array_options['options_' . $key].'-'.$datenotinstring.'x';
-				if (! is_numeric($object->array_options['options_' . $key]))	// For backward compatibility
+				if (! is_numeric($object->array_options['options_' . $key])) {
+				    // For backward compatibility
 				{
 					$datenotinstring = $db->jdate($datenotinstring);
 				}
+				}
 				//print 'x'.$object->array_options['options_' . $key].'-'.$datenotinstring.' - '.dol_print_date($datenotinstring, 'dayhour');
 				$value = isset($_POST["options_" . $key]) ? dol_mktime($_POST["options_" . $key . "hour"], $_POST["options_" . $key . "min"], 0, $_POST["options_" . $key . "month"], $_POST["options_" . $key . "day"], $_POST["options_" . $key . "year"]) : $datenotinstring;
 			}
@@ -147,7 +193,9 @@ 
 			if ($action == 'edit_extras' && $permok && GETPOST('attribute','none') == $key)
 			{
 			    $fieldid='id';
-			    if ($object->table_element == 'societe') $fieldid='socid';
+			    if ($object->table_element == 'societe') {
+			        $fieldid='socid';
+			    }
 			    print '<form enctype="multipart/form-data" action="' . $_SERVER["PHP_SELF"] . '" method="post" name="formextra">';
 				print '<input type="hidden" name="action" value="update_extras">';
 				print '<input type="hidden" name="attribute" value="' . $key . '">';
@@ -159,8 +207,7 @@ 
 				print '<input type="submit" class="button" value="' . dol_escape_htmltag($langs->trans('Modify')) . '">';
 
 				print '</form>';
-			}
-			else
+			} else
 			{
 				//print $key.'-'.$value.'-'.$object->table_element;
 				print $extrafields->showOutputField($key, $value, '', $object->table_element);

dolibarr/htdocs/core/tpl/extrafields_list_search_sql.tpl.php

Indentation +20 added lines, -20 removed lines

@@ -3,8 +3,8 @@ 
 // Protection to avoid direct call of template
 if (empty($conf) || ! is_object($conf))
 {
-	print "Error, template page can't be called as URL";
-	exit;
+    print "Error, template page can't be called as URL";
+    exit;
 }
 
 if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey=$object->table_element;
@@ -12,24 +12,24 @@ 
 // Loop to complete the sql search criterias from extrafields
 if (! empty($extrafieldsobjectkey) && ! empty($search_array_options) && is_array($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
-	foreach ($search_array_options as $key => $val)
-	{
-		$crit=$val;
-		$tmpkey=preg_replace('/search_options_/','',$key);
-		$typ=$extrafields->attributes[$extrafieldsobjectkey]['type'][$tmpkey];
+    foreach ($search_array_options as $key => $val)
+    {
+        $crit=$val;
+        $tmpkey=preg_replace('/search_options_/','',$key);
+        $typ=$extrafields->attributes[$extrafieldsobjectkey]['type'][$tmpkey];
 
-		if ($crit != '' && in_array($typ, array('date', 'datetime', 'timestamp')))
-		{
-			$sql .= " AND ef.".$tmpkey." = '".$db->idate($crit)."'";
-		}
-		elseif ($crit != '' && (! in_array($typ, array('select','sellist')) || $crit != '0') && (! in_array($typ, array('link')) || $crit != '-1'))
-		{
-			$mode_search=0;
-			if (in_array($typ, array('int','double','real'))) $mode_search=1;								// Search on a numeric
-			if (in_array($typ, array('sellist','link')) && $crit != '0' && $crit != '-1') $mode_search=2;	// Search on a foreign key int
-			if (in_array($typ, array('chkbxlst','checkbox'))) $mode_search=4;	                            // Search on a multiselect field with sql type = text
+        if ($crit != '' && in_array($typ, array('date', 'datetime', 'timestamp')))
+        {
+            $sql .= " AND ef.".$tmpkey." = '".$db->idate($crit)."'";
+        }
+        elseif ($crit != '' && (! in_array($typ, array('select','sellist')) || $crit != '0') && (! in_array($typ, array('link')) || $crit != '-1'))
+        {
+            $mode_search=0;
+            if (in_array($typ, array('int','double','real'))) $mode_search=1;								// Search on a numeric
+            if (in_array($typ, array('sellist','link')) && $crit != '0' && $crit != '-1') $mode_search=2;	// Search on a foreign key int
+            if (in_array($typ, array('chkbxlst','checkbox'))) $mode_search=4;	                            // Search on a multiselect field with sql type = text
 
-			$sql .= natural_search('ef.'.$tmpkey, $crit, $mode_search);
-		}
-	}
+            $sql .= natural_search('ef.'.$tmpkey, $crit, $mode_search);
+        }
+    }
 }

Spacing +11 added lines, -11 removed lines

@@ -1,33 +1,33 @@
 <?php
 
 // Protection to avoid direct call of template
-if (empty($conf) || ! is_object($conf))
+if (empty($conf) || !is_object($conf))
 {
 	print "Error, template page can't be called as URL";
 	exit;
 }
 
-if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey=$object->table_element;
+if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey = $object->table_element;
 
 // Loop to complete the sql search criterias from extrafields
-if (! empty($extrafieldsobjectkey) && ! empty($search_array_options) && is_array($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
+if (!empty($extrafieldsobjectkey) && !empty($search_array_options) && is_array($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
 	foreach ($search_array_options as $key => $val)
 	{
-		$crit=$val;
-		$tmpkey=preg_replace('/search_options_/','',$key);
-		$typ=$extrafields->attributes[$extrafieldsobjectkey]['type'][$tmpkey];
+		$crit = $val;
+		$tmpkey = preg_replace('/search_options_/', '', $key);
+		$typ = $extrafields->attributes[$extrafieldsobjectkey]['type'][$tmpkey];
 
 		if ($crit != '' && in_array($typ, array('date', 'datetime', 'timestamp')))
 		{
 			$sql .= " AND ef.".$tmpkey." = '".$db->idate($crit)."'";
 		}
-		elseif ($crit != '' && (! in_array($typ, array('select','sellist')) || $crit != '0') && (! in_array($typ, array('link')) || $crit != '-1'))
+		elseif ($crit != '' && (!in_array($typ, array('select', 'sellist')) || $crit != '0') && (!in_array($typ, array('link')) || $crit != '-1'))
 		{
-			$mode_search=0;
-			if (in_array($typ, array('int','double','real'))) $mode_search=1;								// Search on a numeric
-			if (in_array($typ, array('sellist','link')) && $crit != '0' && $crit != '-1') $mode_search=2;	// Search on a foreign key int
-			if (in_array($typ, array('chkbxlst','checkbox'))) $mode_search=4;	                            // Search on a multiselect field with sql type = text
+			$mode_search = 0;
+			if (in_array($typ, array('int', 'double', 'real'))) $mode_search = 1; // Search on a numeric
+			if (in_array($typ, array('sellist', 'link')) && $crit != '0' && $crit != '-1') $mode_search = 2; // Search on a foreign key int
+			if (in_array($typ, array('chkbxlst', 'checkbox'))) $mode_search = 4; // Search on a multiselect field with sql type = text
 
 			$sql .= natural_search('ef.'.$tmpkey, $crit, $mode_search);
 		}

Braces +19 added lines, -7 removed lines

@@ -7,27 +7,39 @@
 	exit;
 }
 
-if (empty($extrafieldsobjectkey) && is_object($object)) $extrafieldsobjectkey=$object->table_element;
+if (empty($extrafieldsobjectkey) && is_object($object)) {
+    $extrafieldsobjectkey=$object->table_element;
+}
 
 // Loop to complete the sql search criterias from extrafields
-if (! empty($extrafieldsobjectkey) && ! empty($search_array_options) && is_array($search_array_options))	// $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
+if (! empty($extrafieldsobjectkey) && ! empty($search_array_options) && is_array($search_array_options)) {
+    // $extrafieldsobject is the $object->table_element like 'societe', 'socpeople', ...
 {
 	foreach ($search_array_options as $key => $val)
 	{
 		$crit=$val;
+}
 		$tmpkey=preg_replace('/search_options_/','',$key);
 		$typ=$extrafields->attributes[$extrafieldsobjectkey]['type'][$tmpkey];
 
 		if ($crit != '' && in_array($typ, array('date', 'datetime', 'timestamp')))
 		{
 			$sql .= " AND ef.".$tmpkey." = '".$db->idate($crit)."'";
-		}
-		elseif ($crit != '' && (! in_array($typ, array('select','sellist')) || $crit != '0') && (! in_array($typ, array('link')) || $crit != '-1'))
+		} elseif ($crit != '' && (! in_array($typ, array('select','sellist')) || $crit != '0') && (! in_array($typ, array('link')) || $crit != '-1'))
 		{
 			$mode_search=0;
-			if (in_array($typ, array('int','double','real'))) $mode_search=1;								// Search on a numeric
-			if (in_array($typ, array('sellist','link')) && $crit != '0' && $crit != '-1') $mode_search=2;	// Search on a foreign key int
-			if (in_array($typ, array('chkbxlst','checkbox'))) $mode_search=4;	                            // Search on a multiselect field with sql type = text
+			if (in_array($typ, array('int','double','real'))) {
+			    $mode_search=1;
+			}
+			// Search on a numeric
+			if (in_array($typ, array('sellist','link')) && $crit != '0' && $crit != '-1') {
+			    $mode_search=2;
+			}
+			// Search on a foreign key int
+			if (in_array($typ, array('chkbxlst','checkbox'))) {
+			    $mode_search=4;
+			}
+			// Search on a multiselect field with sql type = text
 
 			$sql .= natural_search('ef.'.$tmpkey, $crit, $mode_search);
 		}

dolibarr/htdocs/core/tpl/massactions_pre.tpl.php

Indentation +123 added lines, -123 removed lines

@@ -29,138 +29,138 @@
 
 if ($massaction == 'predeletedraft')
 {
-	print $form->formconfirm($_SERVER["PHP_SELF"], $langs->trans("ConfirmMassDraftDeletion"), $langs->trans("ConfirmMassDeletionQuestion", count($toselect)), "delete", null, '', 0, 200, 500, 1);
+    print $form->formconfirm($_SERVER["PHP_SELF"], $langs->trans("ConfirmMassDraftDeletion"), $langs->trans("ConfirmMassDeletionQuestion", count($toselect)), "delete", null, '', 0, 200, 500, 1);
 }
 
 if ($massaction == 'predelete')
 {
-	print $form->formconfirm($_SERVER["PHP_SELF"], $langs->trans("ConfirmMassDeletion"), $langs->trans("ConfirmMassDeletionQuestion", count($toselect)), "delete", null, '', 0, 200, 500, 1);
+    print $form->formconfirm($_SERVER["PHP_SELF"], $langs->trans("ConfirmMassDeletion"), $langs->trans("ConfirmMassDeletionQuestion", count($toselect)), "delete", null, '', 0, 200, 500, 1);
 }
 
 if ($massaction == 'presend')
 {
-	$langs->load("mails");
+    $langs->load("mails");
 
-	$listofselectedid = array();
-	$listofselectedthirdparties = array();
-	$listofselectedref = array();
+    $listofselectedid = array();
+    $listofselectedthirdparties = array();
+    $listofselectedref = array();
 	
-	if (! GETPOST('cancel', 'alpha'))
-	{
-		foreach ($arrayofselected as $toselectid)
-		{
-			$result = $objecttmp->fetch($toselectid);
-			if ($result > 0)
-			{
-				$listofselectedid[$toselectid] = $toselectid;
-				$thirdpartyid = ($objecttmp->fk_soc ? $objecttmp->fk_soc : $objecttmp->socid);
-				if ($objecttmp->element == 'societe')
-					$thirdpartyid = $objecttmp->id;
-				if ($objecttmp->element == 'expensereport')
-					$thirdpartyid = $objecttmp->fk_user_author;
-				$listofselectedthirdparties[$thirdpartyid] = $thirdpartyid;
-				$listofselectedref[$thirdpartyid][$toselectid] = $objecttmp->ref;
-			}
-		}
-	}
-
-	print '<input type="hidden" name="massaction" value="confirm_presend">';
-
-	include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
-	$formmail = new FormMail($db);
-
-	dol_fiche_head(null, '', '');
-
-	// Cree l'objet formulaire mail
-	include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
-	$formmail = new FormMail($db);
-	$formmail->withform = -1;
-	$formmail->fromtype = (GETPOST('fromtype') ? GETPOST('fromtype') : (! empty($conf->global->MAIN_MAIL_DEFAULT_FROMTYPE) ? $conf->global->MAIN_MAIL_DEFAULT_FROMTYPE : 'user'));
-
-	if ($formmail->fromtype === 'user')
-	{
-		$formmail->fromid = $user->id;
-	}
-	$formmail->trackid = $trackid;
-	if (! empty($conf->global->MAIN_EMAIL_ADD_TRACK_ID) && ($conf->global->MAIN_EMAIL_ADD_TRACK_ID & 2)) // If bit 2 is set
-	{
-		include DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
-		$formmail->frommail = dolAddEmailTrackId($formmail->frommail, $trackid);
-	}
-	$formmail->withfrom = 1;
-	$liste = $langs->trans("AllRecipientSelected", count($arrayofselected));
-	if (count($listofselectedthirdparties) == 1) // Only 1 different recipient selected, we can suggest contacts
-	{
-		$liste = array();
-		$thirdpartyid = array_shift($listofselectedthirdparties);
-		if ($objecttmp->element == 'expensereport')
-		{
-			$fuser = new User($db);
-			$fuser->fetch($thirdpartyid);
-			$liste['thirdparty'] = $fuser->getFullName($langs)." &lt;".$fuser->email."&gt;";
-		}
-		else
-		{
-			$soc = new Societe($db);
-			$soc->fetch($thirdpartyid);
-			foreach ($soc->thirdparty_and_contact_email_array(1) as $key => $value) {
-				$liste[$key] = $value;
-			}
-		}
-		$formmail->withtoreadonly = 0;
-	} else {
-		$formmail->withtoreadonly = 1;
-	}
+    if (! GETPOST('cancel', 'alpha'))
+    {
+        foreach ($arrayofselected as $toselectid)
+        {
+            $result = $objecttmp->fetch($toselectid);
+            if ($result > 0)
+            {
+                $listofselectedid[$toselectid] = $toselectid;
+                $thirdpartyid = ($objecttmp->fk_soc ? $objecttmp->fk_soc : $objecttmp->socid);
+                if ($objecttmp->element == 'societe')
+                    $thirdpartyid = $objecttmp->id;
+                if ($objecttmp->element == 'expensereport')
+                    $thirdpartyid = $objecttmp->fk_user_author;
+                $listofselectedthirdparties[$thirdpartyid] = $thirdpartyid;
+                $listofselectedref[$thirdpartyid][$toselectid] = $objecttmp->ref;
+            }
+        }
+    }
+
+    print '<input type="hidden" name="massaction" value="confirm_presend">';
+
+    include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
+    $formmail = new FormMail($db);
+
+    dol_fiche_head(null, '', '');
+
+    // Cree l'objet formulaire mail
+    include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
+    $formmail = new FormMail($db);
+    $formmail->withform = -1;
+    $formmail->fromtype = (GETPOST('fromtype') ? GETPOST('fromtype') : (! empty($conf->global->MAIN_MAIL_DEFAULT_FROMTYPE) ? $conf->global->MAIN_MAIL_DEFAULT_FROMTYPE : 'user'));
+
+    if ($formmail->fromtype === 'user')
+    {
+        $formmail->fromid = $user->id;
+    }
+    $formmail->trackid = $trackid;
+    if (! empty($conf->global->MAIN_EMAIL_ADD_TRACK_ID) && ($conf->global->MAIN_EMAIL_ADD_TRACK_ID & 2)) // If bit 2 is set
+    {
+        include DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
+        $formmail->frommail = dolAddEmailTrackId($formmail->frommail, $trackid);
+    }
+    $formmail->withfrom = 1;
+    $liste = $langs->trans("AllRecipientSelected", count($arrayofselected));
+    if (count($listofselectedthirdparties) == 1) // Only 1 different recipient selected, we can suggest contacts
+    {
+        $liste = array();
+        $thirdpartyid = array_shift($listofselectedthirdparties);
+        if ($objecttmp->element == 'expensereport')
+        {
+            $fuser = new User($db);
+            $fuser->fetch($thirdpartyid);
+            $liste['thirdparty'] = $fuser->getFullName($langs)." &lt;".$fuser->email."&gt;";
+        }
+        else
+        {
+            $soc = new Societe($db);
+            $soc->fetch($thirdpartyid);
+            foreach ($soc->thirdparty_and_contact_email_array(1) as $key => $value) {
+                $liste[$key] = $value;
+            }
+        }
+        $formmail->withtoreadonly = 0;
+    } else {
+        $formmail->withtoreadonly = 1;
+    }
 	
-	$formmail->withoptiononeemailperrecipient = (count($listofselectedref) == 1 || empty($liste))? 0 : ((GETPOST('oneemailperrecipient')=='on')?1:-1);
-	$formmail->withto = empty($liste)?(GETPOST('sendto','alpha')?GETPOST('sendto','alpha'):array()):$liste;
-	$formmail->withtofree = empty($liste)?1:0;
-	$formmail->withtocc = 1;
-	$formmail->withtoccc = $conf->global->MAIN_EMAIL_USECCC;
-	$formmail->withtopic = $langs->transnoentities($topicmail, '__REF__', '__REFCLIENT__');
-	$formmail->withfile = 1;
-	// $formmail->withfile = 2; Not yet supported in mass action
-	$formmail->withmaindocfile = 1; // Add a checkbox "Attach also main document"
-	if ($objecttmp->element != 'societe') {
-		$formmail->withfile = '<span class="hideonsmartphone">'.$langs->trans("OnlyPDFattachmentSupported").'</span>';
-		$formmail->withmaindocfile = - 1; // Add a checkbox "Attach also main document" but not checked by default
-	}
-	$formmail->withbody = 1;
-	$formmail->withdeliveryreceipt = 1;
-	$formmail->withcancel = 1;
-
-	// Make substitution in email content
-	$substitutionarray = getCommonSubstitutionArray($langs, 0, null, $object);
-	$substitutionarray['__EMAIL__'] = $sendto;
-	$substitutionarray['__CHECK_READ__'] = (is_object($object) && is_object($object->thirdparty)) ? '<img src="' . DOL_MAIN_URL_ROOT . '/public/emailing/mailing-read.php?tag=' . $object->thirdparty->tag . '&securitykey=' . urlencode($conf->global->MAILING_EMAIL_UNSUBSCRIBE_KEY) . '" width="1" height="1" style="width:1px;height:1px" border="0"/>' : '';
-	$substitutionarray['__PERSONALIZED__'] = '';	// deprecated
-	$substitutionarray['__CONTACTCIVNAME__'] = '';
-
-	$parameters = array(
-		'mode' => 'formemail'
-	);
-	complete_substitutions_array($substitutionarray, $langs, $object, $parameters);
-
-	// Tableau des substitutions
-	$formmail->substit = $substitutionarray;
-
-	// Tableau des parametres complementaires du post
-	$formmail->param['action'] = $action;
-	$formmail->param['models'] = $modelmail;
-	$formmail->param['models_id'] = GETPOST('modelmailselected', 'int');
-	$formmail->param['id'] = join(',', $arrayofselected);
-	// $formmail->param['returnurl']=$_SERVER["PHP_SELF"].'?id='.$object->id;
-	if (! empty($conf->global->MAILING_LIMIT_SENDBYWEB) && count($listofselectedthirdparties) > $conf->global->MAILING_LIMIT_SENDBYWEB)
-	{
-		$langs->load("errors");
-		print img_warning() . ' ' . $langs->trans('WarningNumberOfRecipientIsRestrictedInMassAction', $conf->global->MAILING_LIMIT_SENDBYWEB);
-		print ' - <a href="javascript: window.history.go(-1)">' . $langs->trans("GoBack") . '</a>';
-		$arrayofmassactions = array();
-	}
-	else
-	{
-		print $formmail->get_form();
-	}
-
-	dol_fiche_end();
+    $formmail->withoptiononeemailperrecipient = (count($listofselectedref) == 1 || empty($liste))? 0 : ((GETPOST('oneemailperrecipient')=='on')?1:-1);
+    $formmail->withto = empty($liste)?(GETPOST('sendto','alpha')?GETPOST('sendto','alpha'):array()):$liste;
+    $formmail->withtofree = empty($liste)?1:0;
+    $formmail->withtocc = 1;
+    $formmail->withtoccc = $conf->global->MAIN_EMAIL_USECCC;
+    $formmail->withtopic = $langs->transnoentities($topicmail, '__REF__', '__REFCLIENT__');
+    $formmail->withfile = 1;
+    // $formmail->withfile = 2; Not yet supported in mass action
+    $formmail->withmaindocfile = 1; // Add a checkbox "Attach also main document"
+    if ($objecttmp->element != 'societe') {
+        $formmail->withfile = '<span class="hideonsmartphone">'.$langs->trans("OnlyPDFattachmentSupported").'</span>';
+        $formmail->withmaindocfile = - 1; // Add a checkbox "Attach also main document" but not checked by default
+    }
+    $formmail->withbody = 1;
+    $formmail->withdeliveryreceipt = 1;
+    $formmail->withcancel = 1;
+
+    // Make substitution in email content
+    $substitutionarray = getCommonSubstitutionArray($langs, 0, null, $object);
+    $substitutionarray['__EMAIL__'] = $sendto;
+    $substitutionarray['__CHECK_READ__'] = (is_object($object) && is_object($object->thirdparty)) ? '<img src="' . DOL_MAIN_URL_ROOT . '/public/emailing/mailing-read.php?tag=' . $object->thirdparty->tag . '&securitykey=' . urlencode($conf->global->MAILING_EMAIL_UNSUBSCRIBE_KEY) . '" width="1" height="1" style="width:1px;height:1px" border="0"/>' : '';
+    $substitutionarray['__PERSONALIZED__'] = '';	// deprecated
+    $substitutionarray['__CONTACTCIVNAME__'] = '';
+
+    $parameters = array(
+        'mode' => 'formemail'
+    );
+    complete_substitutions_array($substitutionarray, $langs, $object, $parameters);
+
+    // Tableau des substitutions
+    $formmail->substit = $substitutionarray;
+
+    // Tableau des parametres complementaires du post
+    $formmail->param['action'] = $action;
+    $formmail->param['models'] = $modelmail;
+    $formmail->param['models_id'] = GETPOST('modelmailselected', 'int');
+    $formmail->param['id'] = join(',', $arrayofselected);
+    // $formmail->param['returnurl']=$_SERVER["PHP_SELF"].'?id='.$object->id;
+    if (! empty($conf->global->MAILING_LIMIT_SENDBYWEB) && count($listofselectedthirdparties) > $conf->global->MAILING_LIMIT_SENDBYWEB)
+    {
+        $langs->load("errors");
+        print img_warning() . ' ' . $langs->trans('WarningNumberOfRecipientIsRestrictedInMassAction', $conf->global->MAILING_LIMIT_SENDBYWEB);
+        print ' - <a href="javascript: window.history.go(-1)">' . $langs->trans("GoBack") . '</a>';
+        $arrayofmassactions = array();
+    }
+    else
+    {
+        print $formmail->get_form();
+    }
+
+    dol_fiche_end();
 }

Spacing +14 added lines, -14 removed lines

@@ -45,7 +45,7 @@ 
 	$listofselectedthirdparties = array();
 	$listofselectedref = array();
 	
-	if (! GETPOST('cancel', 'alpha'))
+	if (!GETPOST('cancel', 'alpha'))
 	{
 		foreach ($arrayofselected as $toselectid)
 		{
@@ -66,25 +66,25 @@ 
 
 	print '<input type="hidden" name="massaction" value="confirm_presend">';
 
-	include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
+	include_once DOL_DOCUMENT_ROOT.'/core/class/html.formmail.class.php';
 	$formmail = new FormMail($db);
 
 	dol_fiche_head(null, '', '');
 
 	// Cree l'objet formulaire mail
-	include_once DOL_DOCUMENT_ROOT . '/core/class/html.formmail.class.php';
+	include_once DOL_DOCUMENT_ROOT.'/core/class/html.formmail.class.php';
 	$formmail = new FormMail($db);
 	$formmail->withform = -1;
-	$formmail->fromtype = (GETPOST('fromtype') ? GETPOST('fromtype') : (! empty($conf->global->MAIN_MAIL_DEFAULT_FROMTYPE) ? $conf->global->MAIN_MAIL_DEFAULT_FROMTYPE : 'user'));
+	$formmail->fromtype = (GETPOST('fromtype') ? GETPOST('fromtype') : (!empty($conf->global->MAIN_MAIL_DEFAULT_FROMTYPE) ? $conf->global->MAIN_MAIL_DEFAULT_FROMTYPE : 'user'));
 
 	if ($formmail->fromtype === 'user')
 	{
 		$formmail->fromid = $user->id;
 	}
 	$formmail->trackid = $trackid;
-	if (! empty($conf->global->MAIN_EMAIL_ADD_TRACK_ID) && ($conf->global->MAIN_EMAIL_ADD_TRACK_ID & 2)) // If bit 2 is set
+	if (!empty($conf->global->MAIN_EMAIL_ADD_TRACK_ID) && ($conf->global->MAIN_EMAIL_ADD_TRACK_ID & 2)) // If bit 2 is set
 	{
-		include DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
+		include DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
 		$formmail->frommail = dolAddEmailTrackId($formmail->frommail, $trackid);
 	}
 	$formmail->withfrom = 1;
@@ -112,9 +112,9 @@ 
 		$formmail->withtoreadonly = 1;
 	}
 	
-	$formmail->withoptiononeemailperrecipient = (count($listofselectedref) == 1 || empty($liste))? 0 : ((GETPOST('oneemailperrecipient')=='on')?1:-1);
-	$formmail->withto = empty($liste)?(GETPOST('sendto','alpha')?GETPOST('sendto','alpha'):array()):$liste;
-	$formmail->withtofree = empty($liste)?1:0;
+	$formmail->withoptiononeemailperrecipient = (count($listofselectedref) == 1 || empty($liste)) ? 0 : ((GETPOST('oneemailperrecipient') == 'on') ? 1 : -1);
+	$formmail->withto = empty($liste) ? (GETPOST('sendto', 'alpha') ?GETPOST('sendto', 'alpha') : array()) : $liste;
+	$formmail->withtofree = empty($liste) ? 1 : 0;
 	$formmail->withtocc = 1;
 	$formmail->withtoccc = $conf->global->MAIN_EMAIL_USECCC;
 	$formmail->withtopic = $langs->transnoentities($topicmail, '__REF__', '__REFCLIENT__');
@@ -132,8 +132,8 @@ 
 	// Make substitution in email content
 	$substitutionarray = getCommonSubstitutionArray($langs, 0, null, $object);
 	$substitutionarray['__EMAIL__'] = $sendto;
-	$substitutionarray['__CHECK_READ__'] = (is_object($object) && is_object($object->thirdparty)) ? '<img src="' . DOL_MAIN_URL_ROOT . '/public/emailing/mailing-read.php?tag=' . $object->thirdparty->tag . '&securitykey=' . urlencode($conf->global->MAILING_EMAIL_UNSUBSCRIBE_KEY) . '" width="1" height="1" style="width:1px;height:1px" border="0"/>' : '';
-	$substitutionarray['__PERSONALIZED__'] = '';	// deprecated
+	$substitutionarray['__CHECK_READ__'] = (is_object($object) && is_object($object->thirdparty)) ? '<img src="'.DOL_MAIN_URL_ROOT.'/public/emailing/mailing-read.php?tag='.$object->thirdparty->tag.'&securitykey='.urlencode($conf->global->MAILING_EMAIL_UNSUBSCRIBE_KEY).'" width="1" height="1" style="width:1px;height:1px" border="0"/>' : '';
+	$substitutionarray['__PERSONALIZED__'] = ''; // deprecated
 	$substitutionarray['__CONTACTCIVNAME__'] = '';
 
 	$parameters = array(
@@ -150,11 +150,11 @@ 
 	$formmail->param['models_id'] = GETPOST('modelmailselected', 'int');
 	$formmail->param['id'] = join(',', $arrayofselected);
 	// $formmail->param['returnurl']=$_SERVER["PHP_SELF"].'?id='.$object->id;
-	if (! empty($conf->global->MAILING_LIMIT_SENDBYWEB) && count($listofselectedthirdparties) > $conf->global->MAILING_LIMIT_SENDBYWEB)
+	if (!empty($conf->global->MAILING_LIMIT_SENDBYWEB) && count($listofselectedthirdparties) > $conf->global->MAILING_LIMIT_SENDBYWEB)
 	{
 		$langs->load("errors");
-		print img_warning() . ' ' . $langs->trans('WarningNumberOfRecipientIsRestrictedInMassAction', $conf->global->MAILING_LIMIT_SENDBYWEB);
-		print ' - <a href="javascript: window.history.go(-1)">' . $langs->trans("GoBack") . '</a>';
+		print img_warning().' '.$langs->trans('WarningNumberOfRecipientIsRestrictedInMassAction', $conf->global->MAILING_LIMIT_SENDBYWEB);
+		print ' - <a href="javascript: window.history.go(-1)">'.$langs->trans("GoBack").'</a>';
 		$arrayofmassactions = array();
 	}
 	else

Braces +14 added lines, -10 removed lines

@@ -54,10 +54,12 @@ 
 			{
 				$listofselectedid[$toselectid] = $toselectid;
 				$thirdpartyid = ($objecttmp->fk_soc ? $objecttmp->fk_soc : $objecttmp->socid);
-				if ($objecttmp->element == 'societe')
-					$thirdpartyid = $objecttmp->id;
-				if ($objecttmp->element == 'expensereport')
-					$thirdpartyid = $objecttmp->fk_user_author;
+				if ($objecttmp->element == 'societe') {
+									$thirdpartyid = $objecttmp->id;
+				}
+				if ($objecttmp->element == 'expensereport') {
+									$thirdpartyid = $objecttmp->fk_user_author;
+				}
 				$listofselectedthirdparties[$thirdpartyid] = $thirdpartyid;
 				$listofselectedref[$thirdpartyid][$toselectid] = $objecttmp->ref;
 			}
@@ -82,24 +84,27 @@ 
 		$formmail->fromid = $user->id;
 	}
 	$formmail->trackid = $trackid;
-	if (! empty($conf->global->MAIN_EMAIL_ADD_TRACK_ID) && ($conf->global->MAIN_EMAIL_ADD_TRACK_ID & 2)) // If bit 2 is set
+	if (! empty($conf->global->MAIN_EMAIL_ADD_TRACK_ID) && ($conf->global->MAIN_EMAIL_ADD_TRACK_ID & 2)) {
+	    // If bit 2 is set
 	{
 		include DOL_DOCUMENT_ROOT . '/core/lib/functions2.lib.php';
+	}
 		$formmail->frommail = dolAddEmailTrackId($formmail->frommail, $trackid);
 	}
 	$formmail->withfrom = 1;
 	$liste = $langs->trans("AllRecipientSelected", count($arrayofselected));
-	if (count($listofselectedthirdparties) == 1) // Only 1 different recipient selected, we can suggest contacts
+	if (count($listofselectedthirdparties) == 1) {
+	    // Only 1 different recipient selected, we can suggest contacts
 	{
 		$liste = array();
+	}
 		$thirdpartyid = array_shift($listofselectedthirdparties);
 		if ($objecttmp->element == 'expensereport')
 		{
 			$fuser = new User($db);
 			$fuser->fetch($thirdpartyid);
 			$liste['thirdparty'] = $fuser->getFullName($langs)." <".$fuser->email.">";
-		}
-		else
+		} else
 		{
 			$soc = new Societe($db);
 			$soc->fetch($thirdpartyid);
@@ -156,8 +161,7 @@ 
 		print img_warning() . ' ' . $langs->trans('WarningNumberOfRecipientIsRestrictedInMassAction', $conf->global->MAILING_LIMIT_SENDBYWEB);
 		print ' - <a href="javascript: window.history.go(-1)">' . $langs->trans("GoBack") . '</a>';
 		$arrayofmassactions = array();
-	}
-	else
+	} else
 	{
 		print $formmail->get_form();
 	}