alxarafe / alixar

Dolibarr/Code/Accountancy/Classes/AccountancyExport.php

Indentation +5 added lines, -5 removed lines

@@ -2545,14 +2545,14 @@
     }
 
     /**
-    * Export format : iSuite Expert
-    *
-    * by OpenSolus [https://opensolus.fr]
-    *
+     * Export format : iSuite Expert
+     *
+     * by OpenSolus [https://opensolus.fr]
+     *
      * @param   array       $objectLines            data
      * @param   resource    $exportFile             [=null] File resource to export or print if null
      * @return  void
-    */
+     */
     public function exportiSuiteExpert($objectLines, $exportFile = null)
     {
         $separator = ';';

Spacing +4 added lines, -4 removed lines

@@ -335,8 +335,8 @@ 
      */
     public function export(&$TData, $formatexportset, $withAttachment = 0, $downloadMode = 0, $outputMode = 0, $noouput = 0)
     {
-        global $db, $conf, $langs;  // The tpl file use $db
-        global $search_date_end;    // Used into /accountancy/tpl/export_journal.tpl.php
+        global $db, $conf, $langs; // The tpl file use $db
+        global $search_date_end; // Used into /accountancy/tpl/export_journal.tpl.php
 
         // Define name of file to save
         $filename = 'general_ledger-' . $this->getFormatCode($formatexportset);
@@ -2001,7 +2001,7 @@ 
             // MOPM
             $tab[] = "";
             // BONP
-            $tab[] =  "";
+            $tab[] = "";
             // BQAF
             $tab[] = "";
             // ECES
@@ -2207,7 +2207,7 @@ 
                 }
             } elseif ($line->doc_type == 'customer_invoice') {
                 if (($line->amount) < 0) {
-                    $nature_piece = 'AC';       // Currently, only the sign of amount allows to know the type of invoice (standard or credit note). Other solution is to analyse debit/credit/role of account. TODO Add column doc_type_long or make amount mandatory with rule on sign.
+                    $nature_piece = 'AC'; // Currently, only the sign of amount allows to know the type of invoice (standard or credit note). Other solution is to analyse debit/credit/role of account. TODO Add column doc_type_long or make amount mandatory with rule on sign.
                 } else {
                     $nature_piece = 'FC';
                 }

Dolibarr/Code/Accountancy/Classes/BookKeeping.php

Indentation +6 added lines, -6 removed lines

@@ -1987,7 +1987,7 @@ 
         return 1;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      * Export bookkeeping
      *
@@ -1996,7 +1996,7 @@ 
      */
     public function export_bookkeeping($model = 'ebp')
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf;
 
         $sql = "SELECT rowid, doc_date, doc_type,";
@@ -2180,7 +2180,7 @@ 
         */
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      * Return list of accounts with label by chart of accounts
      *
@@ -2195,7 +2195,7 @@ 
      */
     public function select_account($selectid, $htmlname = 'account', $showempty = 0, $event = array(), $select_in = 0, $select_out = 0, $aabase = '')
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf;
 
         require_once constant('DOL_DOCUMENT_ROOT') . '/core/lib/accounting.lib.php';
@@ -2292,7 +2292,7 @@ 
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      * Description of accounting account
      *
@@ -2301,7 +2301,7 @@ 
      */
     public function get_compte_desc($account = null)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf;
 
         $pcgver = getDolGlobalInt('CHARTOFACCOUNTS');

Spacing +1 added lines, -1 removed lines

@@ -1731,7 +1731,7 @@
         $sql = "DELETE";
         $sql .= " FROM " . MAIN_DB_PREFIX . $this->table_element . $mode;
         $sql .= " WHERE piece_num = " . (int) $piecenum;
-        $sql .= " AND date_validated IS NULL";      // For security, exclusion of validated entries at the time of deletion
+        $sql .= " AND date_validated IS NULL"; // For security, exclusion of validated entries at the time of deletion
         $sql .= " AND entity = " . ((int) $conf->entity); // Do not use getEntity for accounting features
         $sql .= $sql_filter;
 

Dolibarr/Code/Accountancy/Classes/AccountingAccount.php

Indentation +2 added lines, -2 removed lines

@@ -698,7 +698,7 @@ 
         return $this->LibStatut($this->status, $mode);
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return the label of a given status
      *
@@ -708,7 +708,7 @@ 
      */
     public function LibStatut($status, $mode = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         if (empty($this->labelStatus) || empty($this->labelStatusShort)) {
             global $langs;
             $langs->load("users");

Spacing +4 added lines, -4 removed lines

@@ -744,7 +744,7 @@ 
         $hookmanager->initHooks(array('accountancyBindingCalculation'));
 
         // Execute hook accountancyBindingCalculation
-        $parameters = array('buyer' => $buyer, 'seller' => $seller, 'product' => $product, 'facture' => $facture, 'factureDet' => $factureDet ,'accountingAccount' => $accountingAccount, 0 => $type);
+        $parameters = array('buyer' => $buyer, 'seller' => $seller, 'product' => $product, 'facture' => $facture, 'factureDet' => $factureDet, 'accountingAccount' => $accountingAccount, 0 => $type);
         $reshook = $hookmanager->executeHooks('accountancyBindingCalculation', $parameters); // Note that $action and $object may have been modified by some hooks
 
         if (empty($reshook)) {
@@ -758,9 +758,9 @@ 
             require_once constant('DOL_DOCUMENT_ROOT') . '/core/lib/company.lib.php';
             $isBuyerInEEC = isInEEC($buyer);
             $isSellerInEEC = isInEEC($seller);
-            $code_l = '';   // Default value for generic product/service
-            $code_p = '';   // Value for the product/service in parameter ($product)
-            $code_t = '';   // Default value of product account for the thirdparty
+            $code_l = ''; // Default value for generic product/service
+            $code_p = ''; // Value for the product/service in parameter ($product)
+            $code_t = ''; // Default value of product account for the thirdparty
             $suggestedid = '';
 
             // Level 1 (define $code_l): Search suggested default account for product/service

Dolibarr/Code/Accountancy/Classes/AccountancyCategory.php

Spacing +1 added lines, -1 removed lines

@@ -639,7 +639,7 @@
         if (is_array($cpt)) {
             $listofaccount = '';
             foreach ($cpt as $cptcursor) {
-                if (! is_null($cptcursor)) {
+                if (!is_null($cptcursor)) {
                     if ($listofaccount) {
                         $listofaccount .= ",";
                     }

Dolibarr/Code/Accountancy/Classes/Lettering.php

Braces +6 added lines, -2 removed lines

@@ -318,11 +318,15 @@
         $resql = $this->db->query($sql);
         if ($resql) {
             while ($obj = $this->db->fetch_object($resql)) {
-                if (empty($obj->lettering_code)) continue;
+                if (empty($obj->lettering_code)) {
+                    continue;
+                }
 
                 // Remove normal lettering code if set partial lettering
                 if ($partial && preg_match('/^[A-Z]+$/', $obj->lettering_code)) {
-                    if (!empty($obj->bookkeeping_ids)) $ids = array_diff($ids, explode(',', $obj->bookkeeping_ids));
+                    if (!empty($obj->bookkeeping_ids)) {
+                        $ids = array_diff($ids, explode(',', $obj->bookkeeping_ids));
+                    }
                 } elseif (!$partial && preg_match('/^[a-z]+$/', $obj->lettering_code)) {
                     // Delete partial lettering code if set normal lettering
                     $sql2 = "UPDATE " . MAIN_DB_PREFIX . "accounting_bookkeeping SET";

Dolibarr/Code/Api/Classes/DolibarrApiAccess.php

Indentation +4 added lines, -4 removed lines

@@ -81,7 +81,7 @@ 
         $this->db = $db;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName
     /**
      * Check access
      *
@@ -92,7 +92,7 @@ 
      */
     public function __isAllowed()
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $db, $user;
 
         $login = '';
@@ -229,13 +229,13 @@ 
         return in_array(static::$role, (array) $requirefortest) || static::$role == 'admin';
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName
     /**
      * @return string string to be used with WWW-Authenticate header
      */
     public function __getWWWAuthenticateString()
     {
-		// phpcs:enable
+        // phpcs:enable
         return '';
     }
 

Dolibarr/Code/Api/Api/Setup.php

Indentation +2 added lines, -3 removed lines

@@ -724,7 +724,7 @@ 
         return $list;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      * Clean sensible object datas
      *
@@ -733,7 +733,7 @@ 
      */
     protected function _cleanObjectDatas($object)
     {
-		// phpcs:enable
+        // phpcs:enable
         $object = parent::_cleanObjectDatas($object);
 
         unset($object->error);
@@ -1401,7 +1401,6 @@ 
     }
 
     /**
-
      * Update Extrafield object
      *
      * @param   string  $attrname       extrafield attrname

Spacing +3 added lines, -3 removed lines

@@ -1175,7 +1175,7 @@ 
                     $list[$tab->elementtype][$tab->name]['computed'] = $tab->fieldcomputed;
                     $list[$tab->elementtype][$tab->name]['unique'] = $tab->fieldunique;
                     $list[$tab->elementtype][$tab->name]['required'] = $tab->fieldrequired;
-                    $list[$tab->elementtype][$tab->name]['param'] = ($tab->param ? jsonOrUnserialize($tab->param) : '');    // This may be a string encoded with serialise() or json_encode()
+                    $list[$tab->elementtype][$tab->name]['param'] = ($tab->param ? jsonOrUnserialize($tab->param) : ''); // This may be a string encoded with serialise() or json_encode()
                     $list[$tab->elementtype][$tab->name]['pos'] = $tab->pos;
                     $list[$tab->elementtype][$tab->name]['alwayseditable'] = $tab->alwayseditable;
                     $list[$tab->elementtype][$tab->name]['perms'] = $tab->perms;
@@ -1285,7 +1285,7 @@ 
                     $answer[$tab->elementtype][$tab->name]['computed'] = $tab->fieldcomputed;
                     $answer[$tab->elementtype][$tab->name]['unique'] = $tab->fieldunique;
                     $answer[$tab->elementtype][$tab->name]['required'] = $tab->fieldrequired;
-                    $answer[$tab->elementtype][$tab->name]['param'] = ($tab->param ? jsonOrUnserialize($tab->param) : '');  // This may be a string encoded with serialise() or json_encode()
+                    $answer[$tab->elementtype][$tab->name]['param'] = ($tab->param ? jsonOrUnserialize($tab->param) : ''); // This may be a string encoded with serialise() or json_encode()
                     $answer[$tab->elementtype][$tab->name]['pos'] = $tab->pos;
                     $answer[$tab->elementtype][$tab->name]['alwayseditable'] = $tab->alwayseditable;
                     $answer[$tab->elementtype][$tab->name]['perms'] = $tab->perms;
@@ -2410,7 +2410,7 @@ 
                 throw new RestException(500, $langs->trans('XmlNotFound') . ': /install/' . $xmlshortfile);
             }
         } else {
-            $xmlarray = getURLContent($xmlremote, 'GET', '', 1, array(), array('http', 'https'), 0);    // Accept http or https links on external remote server only. Same is used into filecheck.php.
+            $xmlarray = getURLContent($xmlremote, 'GET', '', 1, array(), array('http', 'https'), 0); // Accept http or https links on external remote server only. Same is used into filecheck.php.
 
             // Return array('content'=>response,'curl_error_no'=>errno,'curl_error_msg'=>errmsg...)
             if (!$xmlarray['curl_error_no'] && $xmlarray['http_code'] != '400' && $xmlarray['http_code'] != '404') {

Dolibarr/Core/Base/DolibarrApi.php

Spacing +5 added lines, -5 removed lines

@@ -158,11 +158,11 @@
         unset($object->barcode_type_code);
         unset($object->barcode_type_label);
 
-        unset($object->mode_reglement);     // We use mode_reglement_id now
-        unset($object->cond_reglement);     // We use cond_reglement_id now
-        unset($object->note);               // We use note_public or note_private now
-        unset($object->contact);            // We use contact_id now
-        unset($object->thirdparty);         // We use thirdparty_id or fk_soc or socid now
+        unset($object->mode_reglement); // We use mode_reglement_id now
+        unset($object->cond_reglement); // We use cond_reglement_id now
+        unset($object->note); // We use note_public or note_private now
+        unset($object->contact); // We use contact_id now
+        unset($object->thirdparty); // We use thirdparty_id or fk_soc or socid now
 
         unset($object->projet); // Should be fk_project
         unset($object->project); // Should be fk_project

Dolibarr/Core/Trait/DolDeprecationHandler.php

Spacing +5 added lines, -5 removed lines

@@ -60,12 +60,12 @@ 
             return $this->$newProperty;
         }
         if ($this->isDynamicPropertiesEnabled()) {
-            return null;  // If the property is set, then __get is not called.
+            return null; // If the property is set, then __get is not called.
         }
         $msg = "DolDeprecationHandler: Undefined property '" . $name . "'" . self::getCallerInfoString();
         dol_syslog($msg);
         trigger_error($msg, E_USER_NOTICE);
-        return $this->$name;  // Returning value anyway (graceful degradation)
+        return $this->$name; // Returning value anyway (graceful degradation)
     }
 
     /**
@@ -95,7 +95,7 @@ 
         if (!$this->isDynamicPropertiesEnabled()) {
             $msg = "DolDeprecationHandler: Undefined property '" . $name . "'" . self::getCallerInfoString();
             trigger_error($msg, E_USER_NOTICE);
-            $this->$name = $value;  // Setting anyway for graceful degradation
+            $this->$name = $value; // Setting anyway for graceful degradation
         } else {
             $this->$name = $value;
         }
@@ -192,7 +192,7 @@ 
 
         if (property_exists($this, 'enableDeprecatedReporting')) {
             // If the property exists, then we use it.
-            return (bool)$this->enableDeprecatedReporting;
+            return (bool) $this->enableDeprecatedReporting;
         }
 
         return (error_reporting() & E_DEPRECATED) === E_DEPRECATED;
@@ -209,7 +209,7 @@ 
 
         if (property_exists($this, 'enableDynamicProperties')) {
             // If the property exists, then we use it.
-            return (bool)$this->enableDynamicProperties;
+            return (bool) $this->enableDynamicProperties;
         }
 
         // Otherwise it depends on a choice