Passed
Push — GENERAL_BUG_REVIEW_240911 ( 3c7aa9...2db864 )
by Rafael
45:58
created
public/htdocs/comm/action/index.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     $conf->global->AGENDA_EXT_NB = 5;
53 53
 }
54 54
 $MAXAGENDA = getDolGlobalString('AGENDA_EXT_NB');
55
-$DELAYFORCACHE = 300;   // 300 seconds
55
+$DELAYFORCACHE = 300; // 300 seconds
56 56
 
57 57
 $disabledefaultvalues = GETPOSTINT('disabledefaultvalues');
58 58
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
 $mode = GETPOST('mode', 'aZ09');
111 111
 if (empty($mode) && preg_match('/show_/', $action)) {
112
-    $mode = $action;    // For backward compatibility
112
+    $mode = $action; // For backward compatibility
113 113
 }
114 114
 $resourceid = GETPOST("search_resourceid", 'int');
115 115
 $year = GETPOSTINT("year") ? GETPOSTINT("year") : date("Y");
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 }
145 145
 
146 146
 $defaultview = getDolGlobalString('AGENDA_DEFAULT_VIEW', 'show_month'); // default for app
147
-$defaultview = getDolUserString('AGENDA_DEFAULT_VIEW', $defaultview);   // default for user
147
+$defaultview = getDolUserString('AGENDA_DEFAULT_VIEW', $defaultview); // default for user
148 148
 if (empty($mode) && !GETPOSTISSET('mode')) {
149 149
     $mode = $defaultview;
150 150
 }
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 
540 540
 $viewmode .= '</div>';
541 541
 
542
-$viewmode .= '<span class="marginrightonly"></span>';   // To add a space before the navigation tools
542
+$viewmode .= '<span class="marginrightonly"></span>'; // To add a space before the navigation tools
543 543
 
544 544
 
545 545
 $newparam = '';
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
     $newparam .= '&month=' . ((int) $month) . '&year=' . ((int) $tmpforcreatebutton['year']) . '&mode=' . urlencode($mode);
551 551
 
552 552
     //$param='month='.$monthshown.'&year='.$year;
553
-    $hourminsec = dol_print_date(dol_mktime(10, 0, 0, 1, 1, 1970, 'gmt'), '%H', 'gmt') . '0000';  // Set $hourminsec to '100000' to auto set hour to 10:00 at creation
553
+    $hourminsec = dol_print_date(dol_mktime(10, 0, 0, 1, 1, 1970, 'gmt'), '%H', 'gmt') . '0000'; // Set $hourminsec to '100000' to auto set hour to 10:00 at creation
554 554
 
555 555
     $urltocreateaction = constant('BASE_URL') . '/comm/action/card.php?action=create';
556 556
     $urltocreateaction .= '&apyear=' . $tmpforcreatebutton['year'] . '&apmonth=' . $tmpforcreatebutton['mon'] . '&apday=' . $tmpforcreatebutton['mday'] . '&aphour=' . $tmpforcreatebutton['hours'] . '&apmin=' . $tmpforcreatebutton['minutes'];
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
     $sql .= " WHERE bc.status = 1";
577 577
     $sql .= " AND ba.status = 1";
578 578
     if (!empty($filtert) && $filtert != -1) {
579
-        $sql .= " AND bc.visibility = " . (int) $filtert ;
579
+        $sql .= " AND bc.visibility = " . (int) $filtert;
580 580
     }
581 581
     $resql = $db->query($sql);
582 582
     if ($resql) {
@@ -658,7 +658,7 @@  discard block
 block discarded – undo
658 658
         $s .= '</script>' . "\n";
659 659
 
660 660
         foreach ($showextcals as $val) {
661
-            $htmlname = md5($val['name']);  // not used for security purpose, only to get a string with no special char
661
+            $htmlname = md5($val['name']); // not used for security purpose, only to get a string with no special char
662 662
 
663 663
             if (!empty($val['default']) || GETPOSTINT('check_ext' . $htmlname)) {
664 664
                 $default = "checked";
@@ -1109,7 +1109,7 @@  discard block
 block discarded – undo
1109 1109
 
1110 1110
     if ($mode == 'show_day') {
1111 1111
         // Request only leaves for the current selected day
1112
-        $sql .= " AND '" . $db->escape($year) . "-" . $db->escape($month) . "-" . $db->escape($day) . "' BETWEEN x.date_debut AND x.date_fin";  // date_debut and date_fin are date without time
1112
+        $sql .= " AND '" . $db->escape($year) . "-" . $db->escape($month) . "-" . $db->escape($day) . "' BETWEEN x.date_debut AND x.date_fin"; // date_debut and date_fin are date without time
1113 1113
     } elseif ($mode == 'show_week') {
1114 1114
         // Restrict on current month (we get more, but we will filter later)
1115 1115
         $sql .= " AND date_debut < '" . $db->idate(dol_get_last_day($year, $month)) . "'";
@@ -1655,7 +1655,7 @@  discard block
 block discarded – undo
1655 1655
 
1656 1656
     for ($iter_day = 0; $iter_day < 7; $iter_day++) {
1657 1657
         // Show days of the current week
1658
-        $curtime = dol_time_plus_duree($firstdaytoshow, $iter_day, 'd');        // $firstdaytoshow is in timezone of server
1658
+        $curtime = dol_time_plus_duree($firstdaytoshow, $iter_day, 'd'); // $firstdaytoshow is in timezone of server
1659 1659
         $tmpday = dol_print_date($curtime, '%d', 'tzuserrel');
1660 1660
         $tmpmonth = dol_print_date($curtime, '%m', 'tzuserrel');
1661 1661
         $tmpyear = dol_print_date($curtime, '%Y', 'tzuserrel');
@@ -1885,9 +1885,9 @@  discard block
 block discarded – undo
1885 1885
     $tmpholiday = new Holiday($db);
1886 1886
 
1887 1887
     foreach ($eventarray as $daykey => $notused) {      // daykey is the 'YYYYMMDD' to show according to user
1888
-        $annee = dol_print_date($daykey, '%Y', 'gmt');  // We use gmt because we want the value represented by string 'YYYYMMDD'
1889
-        $mois =  dol_print_date($daykey, '%m', 'gmt');  // We use gmt because we want the value represented by string 'YYYYMMDD'
1890
-        $jour =  dol_print_date($daykey, '%d', 'gmt');  // We use gmt because we want the value represented by string 'YYYYMMDD'
1888
+        $annee = dol_print_date($daykey, '%Y', 'gmt'); // We use gmt because we want the value represented by string 'YYYYMMDD'
1889
+        $mois = dol_print_date($daykey, '%m', 'gmt'); // We use gmt because we want the value represented by string 'YYYYMMDD'
1890
+        $jour = dol_print_date($daykey, '%d', 'gmt'); // We use gmt because we want the value represented by string 'YYYYMMDD'
1891 1891
 
1892 1892
         //print 'event daykey='.$daykey.' dol_print_date(daykey)='.dol_print_date($daykey, 'dayhour', 'gmt').' jour='.$jour.' mois='.$mois.' annee='.$annee."<br>\n";
1893 1893
         //print 'event daykey='.$daykey.' dol_print_date(daykey)='.dol_print_date($daykey, 'dayhour', 'gmt').' day='.$day.' month='.$month.' year='.$year."<br>\n";
Please login to merge, or discard this patch.
public/htdocs/comm/remx.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
  *      \brief      Page to edit absolute discounts for a customer
27 27
  */
28 28
 
29
-if (! defined('CSRFCHECK_WITH_TOKEN')) {
29
+if (!defined('CSRFCHECK_WITH_TOKEN')) {
30 30
     define('CSRFCHECK_WITH_TOKEN', '1');
31 31
 }       // Force use of CSRF protection with tokens even for GET
32 32
 
Please login to merge, or discard this patch.
public/htdocs/modulebuilder/template/admin/setup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 // Parameters
69 69
 $action = GETPOST('action', 'aZ09');
70 70
 $backtopage = GETPOST('backtopage', 'alpha');
71
-$modulepart = GETPOST('modulepart', 'aZ09');    // Used by actions_setmoduleoptions.inc.php
71
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
72 72
 
73 73
 $value = GETPOST('value', 'alpha');
74 74
 $label = GETPOST('label', 'alpha');
Please login to merge, or discard this patch.
public/htdocs/modulebuilder/template/myobject_card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,13 +39,13 @@
 block discarded – undo
39 39
 // Get parameters
40 40
 $id = GETPOSTINT('id');
41 41
 $ref = GETPOST('ref', 'alpha');
42
-$lineid   = GETPOSTINT('lineid');
42
+$lineid = GETPOSTINT('lineid');
43 43
 
44 44
 $action = GETPOST('action', 'aZ09');
45 45
 $confirm = GETPOST('confirm', 'alpha');
46 46
 $cancel = GETPOST('cancel', 'aZ09');
47 47
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : str_replace('_', '', basename(dirname(__FILE__)) . basename(__FILE__, '.php')); // To manage different context of search
48
-$backtopage = GETPOST('backtopage', 'alpha');                   // if not set, a default page will be used
48
+$backtopage = GETPOST('backtopage', 'alpha'); // if not set, a default page will be used
49 49
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha'); // if not set, $backtopage will be used
50 50
 $backtopagejsfields = GETPOST('backtopagejsfields', 'alpha');
51 51
 $dol_openinpopup = GETPOST('dol_openinpopup', 'aZ09');
Please login to merge, or discard this patch.
template/core/modules/mymodule/doc/doc_generic_myobject_odt.modules.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
         return $texte;
207 207
     }
208 208
 
209
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
209
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
210 210
     /**
211 211
      *  Function to build a document on disk using the generic odt module.
212 212
      *
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
      */
221 221
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
222 222
     {
223
-		// phpcs:enable
223
+        // phpcs:enable
224 224
         global $user, $langs, $conf, $mysoc, $hookmanager;
225 225
         global $action;
226 226
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@
 block discarded – undo
189 189
         $maxfilesizearray = getMaxFileSizeArray();
190 190
         $maxmin = $maxfilesizearray['maxmin'];
191 191
         if ($maxmin > 0) {
192
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
192
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
193 193
         }
194 194
         $texte .= ' <input type="file" name="uploadfile">';
195 195
         $texte .= '<input type="hidden" value="MYMODULE_MYOBJECT_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';
Please login to merge, or discard this patch.
public/htdocs/modulebuilder/template/core/modules/modMyModule.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,8 +75,8 @@
 block discarded – undo
75 75
 
76 76
         // Author
77 77
         $this->editor_name = 'Editor name';
78
-        $this->editor_url = 'https://www.example.com';      // Must be an external online web site
79
-        $this->editor_squarred_logo = '';                   // Must be image filename into the module/img directory followed with @modulename. Example: 'myimage.png@mymodule'
78
+        $this->editor_url = 'https://www.example.com'; // Must be an external online web site
79
+        $this->editor_squarred_logo = ''; // Must be image filename into the module/img directory followed with @modulename. Example: 'myimage.png@mymodule'
80 80
 
81 81
         // Possible values for version are: 'development', 'experimental', 'dolibarr', 'dolibarr_deprecated', 'experimental_deprecated' or a version string like 'x.y.z'
82 82
         $this->version = '1.0';
Please login to merge, or discard this patch.
template/core/modules/mailings/mailing_mymodule_selector1.modules.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     }
91 91
 
92 92
 
93
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
93
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
94 94
     /**
95 95
      *  This is the main function that returns the array of emails
96 96
      *
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     public function add_to_target($mailing_id)
101 101
     {
102
-		// phpcs:enable
102
+        // phpcs:enable
103 103
         $target = array();
104 104
         $j = 0;
105 105
 
Please login to merge, or discard this patch.
public/htdocs/modulebuilder/template/class/api_mymodule.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 
343 343
 
344 344
 
345
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
345
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
346 346
     /**
347 347
      * Clean sensible object datas
348 348
      *
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
      */
352 352
     protected function _cleanObjectDatas($object)
353 353
     {
354
-		// phpcs:enable
354
+        // phpcs:enable
355 355
         $object = parent::_cleanObjectDatas($object);
356 356
 
357 357
         unset($object->rowid);
Please login to merge, or discard this patch.
public/htdocs/modulebuilder/template/class/myobject.class.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -979,7 +979,7 @@  discard block
 block discarded – undo
979 979
         return $this->LibStatut($this->status, $mode);
980 980
     }
981 981
 
982
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
982
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
983 983
     /**
984 984
      *  Return the label of a given status
985 985
      *
@@ -989,7 +989,7 @@  discard block
 block discarded – undo
989 989
      */
990 990
     public function LibStatut($status, $mode = 0)
991 991
     {
992
-		// phpcs:enable
992
+        // phpcs:enable
993 993
         if (is_null($status)) {
994 994
             return '';
995 995
         }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -163,8 +163,8 @@  discard block
 block discarded – undo
163 163
     /**
164 164
      * @var int Thirdparty ID
165 165
      */
166
-    public $socid;      // both socid and fk_soc are used
167
-    public $fk_soc;     // both socid and fk_soc are used
166
+    public $socid; // both socid and fk_soc are used
167
+    public $fk_soc; // both socid and fk_soc are used
168 168
 
169 169
     /**
170 170
      * @var int Status
@@ -1052,7 +1052,7 @@  discard block
 block discarded – undo
1052 1052
                 $this->date_creation     = $this->db->jdate($obj->datec);
1053 1053
                 $this->date_modification = empty($obj->datem) ? '' : $this->db->jdate($obj->datem);
1054 1054
                 if (!empty($obj->datev)) {
1055
-                    $this->date_validation   = empty($obj->datev) ? '' : $this->db->jdate($obj->datev);
1055
+                    $this->date_validation = empty($obj->datev) ? '' : $this->db->jdate($obj->datev);
1056 1056
                 }
1057 1057
             }
1058 1058
 
@@ -1257,13 +1257,13 @@  discard block
 block discarded – undo
1257 1257
      * To overload
1258 1258
      * @see CommonObjectLine
1259 1259
      */
1260
-    public $parent_element = '';        // Example: '' or 'myobject'
1260
+    public $parent_element = ''; // Example: '' or 'myobject'
1261 1261
 
1262 1262
     /**
1263 1263
      * To overload
1264 1264
      * @see CommonObjectLine
1265 1265
      */
1266
-    public $fk_parent_attribute = '';   // Example: '' or 'fk_myobject'
1266
+    public $fk_parent_attribute = ''; // Example: '' or 'fk_myobject'
1267 1267
 
1268 1268
     /**
1269 1269
      * Constructor
Please login to merge, or discard this patch.