DbTrait::connectDb() - Code Metrics - Inspection of "The changes made during the last few days are uplo..." - alxarafe/alixar - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 7af4bb...131f20 )

by Rafael

created 2024-06-21 20:22 UTC

DbTrait::connectDb() A

↳ Parent: DbTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	9
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	13
rs	9.9666

<?php

/* Copyright (C) 2024      Rafael San José      <[email protected]>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <https://www.gnu.org/licenses/>.
 */

namespace Alxarafe\Base\Controller\Trait;

use Alxarafe\Base\Config;
use DoliModules\Install\Controller\InstallController;

trait DbTrait
{
    public static function connectDb(?stdClass $db=null): bool

    {
        if ($db === null) {
            return false;
        }
        $checkDatabase = Config::checkDatabaseConnection($db);
        if (!$checkDatabase) {
            dump([
                'db' => $db,
                'check' => $checkDatabase,
            ]);
            (new InstallController())->doIndex();
            die();
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

}


1			<?php
2
3			/* Copyright (C) 2024 Rafael San José <[email protected]>
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 3 of the License, or
8			* any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License
16			* along with this program. If not, see <https://www.gnu.org/licenses/>.
17			*/
18
19			namespace Alxarafe\Base\Controller\Trait;
20
21			use Alxarafe\Base\Config;
22			use DoliModules\Install\Controller\InstallController;
23
24			trait DbTrait
25			{
26			public static function connectDb(?stdClass $db=null): bool
			0 ignored issues – show Bug introduced 2024-06-21 21:20 UTC by Report Bug Copy Issue Report The type `Alxarafe\Base\Controller\Trait\stdClass` was not found. Did you mean `stdClass`? If so, make sure to prefix the type with `\`. Loading history...
27			{
28			if ($db === null) {
29			return false;
30			}
31			$checkDatabase = Config::checkDatabaseConnection($db);
32			if (!$checkDatabase) {
33			dump([
34			'db' => $db,
35			'check' => $checkDatabase,
36			]);
37			(new InstallController())->doIndex();
38			die();
			0 ignored issues – show Best Practice introduced 2024-06-21 21:20 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history... Bug Best Practice introduced 2024-06-21 21:20 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
39			}
			0 ignored issues – show Bug Best Practice introduced 2024-06-21 21:20 UTC by Report Bug Copy Issue Report The function implicitly returns `null` when the `if` condition on line 32 is `false`. This is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
40			}
41
42			}
43

alxarafe / alixar

Push — main ( 7af4bb...131f20 )

DbTrait::connectDb() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like