Passed
Push — GENERAL_BUG_REVIEW_240911 ( 8cbbee...d4fdcf )
by Rafael
64:20
created
public/htdocs/theme/eldy/btn.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
19 19
     print "/* For dark mode */\n";
20 20
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
21
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
21
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
22 22
     } else {
23 23
         print "@media not print {";
24 24
     }
Please login to merge, or discard this patch.
public/htdocs/theme/md/style.css.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 $colortext           = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXT') ? $colortext : $conf->global->THEME_ELDY_TEXT) : (empty($user->conf->THEME_ELDY_TEXT) ? $colortext : $user->conf->THEME_ELDY_TEXT);
194 194
 $colortextlink       = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTLINK') ? $colortext : $conf->global->THEME_ELDY_TEXTLINK) : (empty($user->conf->THEME_ELDY_TEXTLINK) ? $colortextlink : $user->conf->THEME_ELDY_TEXTLINK);
195 195
 $butactionbg         = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_BTNACTION') ? $butactionbg : $conf->global->THEME_ELDY_BTNACTION) : (empty($user->conf->THEME_ELDY_BTNACTION) ? $butactionbg : $user->conf->THEME_ELDY_BTNACTION);
196
-$textbutaction     = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTBTNACTION') ? $textbutaction : $conf->global->THEME_ELDY_TEXTBTNACTION) : (empty($user->conf->THEME_ELDY_TEXTBTNACTION) ? $textbutaction : $user->conf->THEME_ELDY_TEXTBTNACTION);
196
+$textbutaction = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTBTNACTION') ? $textbutaction : $conf->global->THEME_ELDY_TEXTBTNACTION) : (empty($user->conf->THEME_ELDY_TEXTBTNACTION) ? $textbutaction : $user->conf->THEME_ELDY_TEXTBTNACTION);
197 197
 $fontsize            = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_FONT_SIZE1') ? $fontsize : $conf->global->THEME_ELDY_FONT_SIZE1) : (empty($user->conf->THEME_ELDY_FONT_SIZE1) ? $fontsize : $user->conf->THEME_ELDY_FONT_SIZE1);
198 198
 $fontsizesmaller     = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_FONT_SIZE2') ? $fontsize : $conf->global->THEME_ELDY_FONT_SIZE2) : (empty($user->conf->THEME_ELDY_FONT_SIZE2) ? $fontsize : $user->conf->THEME_ELDY_FONT_SIZE2);
199 199
 $heightrow           = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_USECOMOACTROW') ? '155%' : '300%') : (empty($user->conf->THEME_ELDY_USECOMOACTROW) ? '155%' : '300%');
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
378 378
     print "/* For dark mode */\n";
379 379
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
380
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
380
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
381 381
     } else {
382 382
         print "@media not print {";
383 383
     }
@@ -3034,7 +3034,7 @@  discard block
 block discarded – undo
3034 3034
                     if (preg_match('/^fa\-/', $iconformodule)) {
3035 3035
                         // This is a fa icon
3036 3036
                     } else {
3037
-                        $url =  dol_buildpath('/' . $val . '/img/' . $iconformodule . '.png', 1);
3037
+                        $url = dol_buildpath('/' . $val . '/img/' . $iconformodule . '.png', 1);
3038 3038
                     }
3039 3039
                     $found = 1;
3040 3040
                 } else {
Please login to merge, or discard this patch.
public/htdocs/theme/md/btn.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
19 19
     print "/* For dark mode */\n";
20 20
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
21
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
21
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
22 22
     } else {
23 23
         print "@media not print {";
24 24
     }
Please login to merge, or discard this patch.
public/htdocs/variants/card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -286,7 +286,7 @@
 block discarded – undo
286 286
     if ($action != 'editline') {
287 287
         print '<div class="tabsAction">' . "\n";
288 288
         $parameters = array();
289
-        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook
289
+        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
290 290
         if ($reshook < 0) {
291 291
             setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
292 292
         }
Please login to merge, or discard this patch.
public/htdocs/variants/combinations.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -778,7 +778,7 @@
 block discarded – undo
778 778
         <div style="text-align: center">
779 779
         <input type="submit" name="create" <?php if (!is_array($productCombination2ValuePairs1)) {
780 780
             print ' disabled="disabled"';
781
-                                           } ?> value="<?php echo $action == 'add' ? $langs->trans('Create') : $langs->trans("Save") ?>" class="button button-save">
781
+                                            } ?> value="<?php echo $action == 'add' ? $langs->trans('Create') : $langs->trans("Save") ?>" class="button button-save">
782 782
         &nbsp;
783 783
         <input type="submit" name="cancel" value="<?php echo $langs->trans("Cancel"); ?>" class="button button-cancel">
784 784
         </div>
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,12 +30,12 @@
 block discarded – undo
30 30
 
31 31
 $langs->loadLangs(array("products", "other"));
32 32
 
33
-$id = GETPOSTINT('id');                             // ID of the parent Product
33
+$id = GETPOSTINT('id'); // ID of the parent Product
34 34
 $ref = GETPOST('ref', 'alpha');
35 35
 
36
-$combination_id = GETPOSTINT('combination_id');     // ID of the combination
36
+$combination_id = GETPOSTINT('combination_id'); // ID of the combination
37 37
 
38
-$reference = GETPOST('reference', 'alpha');         // Reference of the variant Product
38
+$reference = GETPOST('reference', 'alpha'); // Reference of the variant Product
39 39
 
40 40
 $weight_impact = GETPOSTFLOAT('weight_impact', 2);
41 41
 $price_impact_percent = (bool) GETPOST('price_impact_percent');
Please login to merge, or discard this patch.
public/htdocs/variants/list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
 $object->fields = dol_sort_array($object->fields, 'position');
145 145
 $arrayfields = dol_sort_array($arrayfields, 'position');
146
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
146
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
147 147
 
148 148
 $permissiontoread = $user->hasRight('variants', 'read');
149 149
 $permissiontoadd = $user->hasRight('variants', 'write');
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 //}
325 325
 // Add where from hooks
326 326
 $parameters = array();
327
-$reshook = $hookmanager->executeHooks('printFieldListGroupBy', $parameters, $object);    // Note that $action and $object may have been modified by hook
327
+$reshook = $hookmanager->executeHooks('printFieldListGroupBy', $parameters, $object); // Note that $action and $object may have been modified by hook
328 328
 $sql .= $hookmanager->resPrint;
329 329
 $sql = preg_replace("/,\s*$/", "", $sql);
330 330
 
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 }
514 514
 
515 515
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
516
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
516
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
517 517
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
518 518
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
519 519
 
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
617 617
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
618 618
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
619 619
     }
620
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
620
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
621 621
     if (!empty($arrayfields['t.' . $key]['checked'])) {
622 622
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
623 623
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/webhook/target_list.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -39,15 +39,15 @@  discard block
 block discarded – undo
39 39
 $langs->loadLangs(array('other'));
40 40
 
41 41
 // Get Parameters
42
-$action      = GETPOST('action', 'aZ09') ? GETPOST('action', 'aZ09') : 'view';    // The action 'add', 'create', 'edit', 'update', 'view', ...
43
-$massaction  = GETPOST('massaction', 'alpha');    // The bulk action (combo box choice into lists)
44
-$show_files  = GETPOSTINT('show_files');    // Show files area generated by bulk actions ?
45
-$confirm     = GETPOST('confirm', 'alpha');    // Result of a confirmation
46
-$cancel      = GETPOST('cancel', 'alpha');    // We click on a Cancel button
47
-$toselect    = GETPOST('toselect', 'array');    // Array of ids of elements selected into a list
48
-$contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'targetlist';    // To manage different context of search
49
-$backtopage  = GETPOST('backtopage', 'alpha');    // Go back to a dedicated page
50
-$optioncss   = GETPOST('optioncss', 'aZ');    // Option for the css output (always '' except when 'print')
42
+$action      = GETPOST('action', 'aZ09') ? GETPOST('action', 'aZ09') : 'view'; // The action 'add', 'create', 'edit', 'update', 'view', ...
43
+$massaction  = GETPOST('massaction', 'alpha'); // The bulk action (combo box choice into lists)
44
+$show_files  = GETPOSTINT('show_files'); // Show files area generated by bulk actions ?
45
+$confirm     = GETPOST('confirm', 'alpha'); // Result of a confirmation
46
+$cancel      = GETPOST('cancel', 'alpha'); // We click on a Cancel button
47
+$toselect    = GETPOST('toselect', 'array'); // Array of ids of elements selected into a list
48
+$contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'targetlist'; // To manage different context of search
49
+$backtopage  = GETPOST('backtopage', 'alpha'); // Go back to a dedicated page
50
+$optioncss   = GETPOST('optioncss', 'aZ'); // Option for the css output (always '' except when 'print')
51 51
 $mode        = GETPOST('mode', 'aZ');
52 52
 if (empty($mode)) {
53 53
     $mode = 'modulesetup';
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 
83 83
 // Default sort order (if not yet defined by previous GETPOST)
84 84
 if (!$sortfield) {
85
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
85
+    reset($object->fields); // Reset is required to avoid key() to return null.
86 86
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
87 87
 }
88 88
 if (!$sortorder) {
@@ -518,7 +518,7 @@  discard block
 block discarded – undo
518 518
 }
519 519
 
520 520
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
521
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
521
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
522 522
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
523 523
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
524 524
 
@@ -612,7 +612,7 @@  discard block
 block discarded – undo
612 612
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
613 613
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
614 614
     }
615
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
615
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
616 616
     if (!empty($arrayfields['t.' . $key]['checked'])) {
617 617
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
618 618
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/webhook/target_card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 global $conf, $db, $hookmanager, $langs, $user;
37 37
 
38 38
 // Load translation files required by the page
39
-$langs->loadLangs(array('other','admin'));
39
+$langs->loadLangs(array('other', 'admin'));
40 40
 
41 41
 // Get parameters
42 42
 $id = GETPOSTINT('id');
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'targetcard'; // To manage different context of search
48 48
 $backtopage = GETPOST('backtopage', 'alpha');
49 49
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
50
-$lineid   = GETPOSTINT('lineid');
50
+$lineid = GETPOSTINT('lineid');
51 51
 
52 52
 // Initialize technical objects
53 53
 $object = new Target($db);
Please login to merge, or discard this patch.
public/htdocs/reception/card.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -966,7 +966,7 @@
 block discarded – undo
966 966
             /**
967 967
              * @var array $suffix2numAsked map HTTP query parameter suffixes (like '1_0') to line indices so that
968 968
              *                             extrafields from HTTP query can be assigned to the correct dispatch line
969
-            */
969
+             */
970 970
             $suffix2numAsked = array();
971 971
             $dispatchLines = array();
972 972
 
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 
344 344
         // Loop lines to calculate $totalqty
345 345
         for ($i = 1; $i <= $num; $i++) {
346
-            $idl = "idl" . $i;    // id line source
346
+            $idl = "idl" . $i; // id line source
347 347
 
348 348
             //$sub_qty = array();
349 349
             //$subtotalqty = 0;
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
             //$j = 0;
352 352
             //$batch = "batchl".$i."_0";
353 353
             //$stockLocation = "ent1".$i."_0";
354
-            $qty = "qtyl" . $i;   // qty
354
+            $qty = "qtyl" . $i; // qty
355 355
 
356 356
             //reception line for product with no batch management and no multiple stock location
357 357
             if (GETPOST($qty, 'alpha') > 0) {
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
 
366 366
         if ($totalqty > 0) {  // There is at least one thing to ship
367 367
             for ($i = 1; $i <= $num; $i++) {
368
-                $idl = "idl" . $i;    // id line source
368
+                $idl = "idl" . $i; // id line source
369 369
                 $lineToTest = '';
370 370
                 $lineId = GETPOSTINT($idl);
371 371
                 foreach ($objectsrc->lines as $linesrc) {
@@ -1144,7 +1144,7 @@  discard block
 block discarded – undo
1144 1144
 
1145 1145
                     print '<input type="hidden" name="productl' . $indiceAsked . '" value="' . $line->fk_product . '">';
1146 1146
 
1147
-                    if (! array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1147
+                    if (!array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1148 1148
                         print '<input type="hidden" name="productid' . $indiceAsked . '" value="' . $line->fk_product . '">';
1149 1149
 
1150 1150
                         // Show product and description
@@ -1166,7 +1166,7 @@  discard block
 block discarded – undo
1166 1166
                     print '</td>';
1167 1167
                 } else {
1168 1168
                     print "<td>";
1169
-                    if (! array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1169
+                    if (!array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1170 1170
                         if ($type == 1) {
1171 1171
                             $text = img_object($langs->trans('Service'), 'service');
1172 1172
                         } else {
@@ -1195,7 +1195,7 @@  discard block
 block discarded – undo
1195 1195
 
1196 1196
                 // Qty in source purchase order line
1197 1197
                 print '<td class="center">';
1198
-                if (! array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1198
+                if (!array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1199 1199
                     print $line->qty;
1200 1200
                 }
1201 1201
                 print '<input type="hidden" name="fk_commandefournisseurdet' . $indiceAsked . '" value="' . $line->id . '">';
@@ -1207,7 +1207,7 @@  discard block
 block discarded – undo
1207 1207
                 // Qty already received
1208 1208
                 print '<td class="center">';
1209 1209
                 $quantityDelivered = $objectsrc->receptions[$line->id];
1210
-                if (! array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1210
+                if (!array_key_exists($line->id, $arrayofpurchaselinealreadyoutput)) { // Add test to avoid to show qty twice
1211 1211
                     print $quantityDelivered;
1212 1212
                 }
1213 1213
                 print '<input name="qtydelivered' . $indiceAsked . '" id="qtydelivered' . $indiceAsked . '" type="hidden" value="' . $quantityDelivered . '">';
Please login to merge, or discard this patch.