DoliModules\Admin\Controller\AdminMenuController::index()

Complexity

Conditions	12
Paths	36

Size

Total Lines	107
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function index($executeActions = true): bool
    {
        global $conf;
        global $db;
        global $user;
        global $hookmanager;
        global $user;
        global $menumanager;
        global $langs;
        global $mysoc;

        $action = GETPOST('action', 'aZ09');
        $cancel = GETPOST('cancel', 'alpha');

// Load translation files required by the page
        $langs->loadLangs(["companies", "products", "admin", "users", "other"]);

// Security check
        if (!$user->admin) {
            accessforbidden();
        }

        $dirstandard = [];
        $dirsmartphone = [];
        $dirmenus = array_merge(["/core/menus/"], (array) $conf->modules_parts['menus']);
        foreach ($dirmenus as $dirmenu) {
            $dirstandard[] = $dirmenu . 'standard';
            $dirsmartphone[] = $dirmenu . 'smartphone';
        }

        $error = 0;

// This can be a big page.  The execution time limit is increased.
// This setting can only be changed when the 'safe_mode' is inactive.
        $err = error_reporting();
        error_reporting(0); // Disable all errors
//error_reporting(E_ALL);
        @set_time_limit(300); // Need more than 240 on Windows 7/64

It seems like you do not handle an error condition for set_time_limit(). This can introduce security issues, and is generally not recommended.

        error_reporting($err);


        /*
         * Actions
         */

        if ($action == 'update' && !$cancel) {
            $_SESSION["mainmenu"] = "home"; // The menu manager may have changed

            dolibarr_set_const($db, "MAIN_MENU_STANDARD", GETPOST('MAIN_MENU_STANDARD', 'alpha'), 'chaine', 0, '', $conf->entity);
            dolibarr_set_const($db, "MAIN_MENU_SMARTPHONE", GETPOST('MAIN_MENU_SMARTPHONE', 'alpha'), 'chaine', 0, '', $conf->entity);

            dolibarr_set_const($db, "MAIN_MENUFRONT_STANDARD", GETPOST('MAIN_MENUFRONT_STANDARD', 'alpha'), 'chaine', 0, '', $conf->entity);
            dolibarr_set_const($db, "MAIN_MENUFRONT_SMARTPHONE", GETPOST('MAIN_MENUFRONT_SMARTPHONE', 'alpha'), 'chaine', 0, '', $conf->entity);

            // Define list of menu handlers to initialize
            $listofmenuhandler = [];
            $listofmenuhandler[preg_replace('/(_backoffice|_frontoffice|_menu)?\.php/i', '', GETPOST('MAIN_MENU_STANDARD', 'alpha'))] = 1;
            $listofmenuhandler[preg_replace('/(_backoffice|_frontoffice|_menu)?\.php/i', '', GETPOST('MAIN_MENUFRONT_STANDARD', 'alpha'))] = 1;
            if (GETPOST('MAIN_MENU_SMARTPHONE', 'alpha')) {
                $listofmenuhandler[preg_replace('/(_backoffice|_frontoffice|_menu)?\.php/i', '', GETPOST('MAIN_MENU_SMARTPHONE', 'alpha'))] = 1;
            }
            if (GETPOST('MAIN_MENUFRONT_SMARTPHONE', 'alpha')) {
                $listofmenuhandler[preg_replace('/(_backoffice|_frontoffice|_menu)?\.php/i', '', GETPOST('MAIN_MENUFRONT_SMARTPHONE', 'alpha'))] = 1;
            }

            // Initialize menu handlers
            foreach ($listofmenuhandler as $key => $val) {
                // Load sql init_menu_handler.sql file
                $dirmenus = array_merge(["/core/menus/"], (array) $conf->modules_parts['menus']);
                foreach ($dirmenus as $dirmenu) {
                    $file = 'init_menu_' . $key . '.sql';
                    $fullpath = dol_buildpath($dirmenu . $file);
                    //print 'action='.$action.' Search menu into fullpath='.$fullpath.'<br>';exit;

                    if (file_exists($fullpath)) {
                        $db->begin();

                        $result = run_sql($fullpath, 1, '', 1, $key, 'none');
                        if ($result > 0) {
                            $db->commit();
                        } else {
                            $error++;
                            setEventMessages($langs->trans("FailedToInitializeMenu") . ' ' . $key, null, 'errors');
                            $db->rollback();
                        }
                    }
                }
            }

            if (!$error) {
                $db->close();

                // We make a header redirect because we need to change menu NOW.
                header("Location: " . $_SERVER['PHP_SELF']);
                exit;

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

            }
        }


        /*
         * View
         */
        require_once realpath(BASE_PATH . '/../Dolibarr/Modules/Admin/Views/admin_menu.php');

        $db->close();

        return true;
    }