Passed
Push — GENERAL_BUG_REVIEW_240911 ( 3362b2...8cbbee )
by Rafael
49:13
created
public/htdocs/expedition/card.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1449,7 +1449,7 @@  discard block
 block discarded – undo
1449 1449
                                         $tooltipClass = ' classfortooltip';
1450 1450
                                         $tooltipTitle = $langs->trans('StockQuantitiesAlreadyAllocatedOnPreviousLines') . ' : ' . $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1451 1451
                                     } else {
1452
-                                        $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0 ;
1452
+                                        $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0;
1453 1453
                                     }
1454 1454
                                     $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = $deliverableQty + $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1455 1455
 
@@ -1688,7 +1688,7 @@  discard block
 block discarded – undo
1688 1688
                                             $tooltipClass = ' classfortooltip';
1689 1689
                                             $tooltipTitle = $langs->trans('StockQuantitiesAlreadyAllocatedOnPreviousLines') . ' : ' . $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1690 1690
                                         } else {
1691
-                                            $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0 ;
1691
+                                            $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0;
1692 1692
                                         }
1693 1693
                                         $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = $deliverableQty + $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1694 1694
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1437,7 +1437,9 @@
 block discarded – undo
1437 1437
                                         $deliverableQty = min($quantityToBeDelivered, $batchStock);
1438 1438
                                     }
1439 1439
 
1440
-                                    if ($deliverableQty < 0) $deliverableQty = 0;
1440
+                                    if ($deliverableQty < 0) {
1441
+                                        $deliverableQty = 0;
1442
+                                    }
1441 1443
 
1442 1444
                                     $inputName = 'qtyl' . $indiceAsked . '_' . $subj;
1443 1445
                                     if (GETPOSTISSET($inputName)) {
Please login to merge, or discard this patch.
public/htdocs/expedition/list.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@
 block discarded – undo
153 153
 
154 154
 $object->fields = dol_sort_array($object->fields, 'position');
155 155
 $arrayfields = dol_sort_array($arrayfields, 'position');
156
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
156
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
157 157
 
158 158
 // Security check
159 159
 $expeditionid = GETPOSTINT('id');
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -444,8 +444,10 @@
 block discarded – undo
444 444
                             );
445 445
                             if ($result > 0) {
446 446
                                 $lineid = $result;
447
-                                if (!empty($createbills_onebythird)) //increment rang to keep sending
447
+                                if (!empty($createbills_onebythird)) {
448
+                                    //increment rang to keep sending
448 449
                                     $TFactThirdNbLines[$expd->socid]++;
450
+                                }
449 451
                             } else {
450 452
                                 $lineid = 0;
451 453
                                 $error++;
Please login to merge, or discard this patch.
public/htdocs/expedition/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
 }
97 97
 $result = restrictedArea($user, 'expedition', $object->id, '');
98 98
 
99
-$permissiontoadd = $user->hasRight('expedition', 'creer');  // Used by the include of actions_dellink.inc.php
99
+$permissiontoadd = $user->hasRight('expedition', 'creer'); // Used by the include of actions_dellink.inc.php
100 100
 
101 101
 
102 102
 /*
Please login to merge, or discard this patch.
public/htdocs/expedition/shipment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     $socid = $user->socid;
82 82
 }
83 83
 
84
-$result = restrictedArea($user, 'expedition', 0, '');   // We use 0 for id, because there is no particular shipment on this tab, only id of order is known
84
+$result = restrictedArea($user, 'expedition', 0, ''); // We use 0 for id, because there is no particular shipment on this tab, only id of order is known
85 85
 
86 86
 
87 87
 
Please login to merge, or discard this patch.
public/htdocs/hrm/position.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 
92 92
 // Default sort order (if not yet defined by previous GETPOST)
93 93
 if (!$sortfield) {
94
-    reset($objectposition->fields);                    // Reset is required to avoid key() to return null.
94
+    reset($objectposition->fields); // Reset is required to avoid key() to return null.
95 95
     $sortfield = "t." . key($objectposition->fields); // Set here default search field. By default 1st field in definition.
96 96
 }
97 97
 if (!$sortorder) {
Please login to merge, or discard this patch.
public/htdocs/hrm/evaluation_note.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
 // Permissions
64 64
 $permissionnote   = $user->hasRight('hrm', 'evaluation', 'write'); // Used by the include of actions_setnotes.inc.php
65
-$permissiontoread = $user->hasRight('hrm', 'evaluation', 'read');  // Used by the include of actions_addupdatedelete.inc.php
65
+$permissiontoread = $user->hasRight('hrm', 'evaluation', 'read'); // Used by the include of actions_addupdatedelete.inc.php
66 66
 
67 67
 // Security check (enable the most restrictive one)
68 68
 //if ($user->socid > 0) accessforbidden();
Please login to merge, or discard this patch.
public/htdocs/hrm/skill_list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 $optioncss   = GETPOST('optioncss', 'aZ'); // Option for the css output (always '' except when 'print')
57 57
 $mode        = GETPOST('mode', 'alpha'); // for mode view result
58 58
 
59
-$id         = GETPOSTINT('id');
59
+$id = GETPOSTINT('id');
60 60
 
61 61
 // Load variable for pagination
62 62
 $limit = GETPOSTINT('limit') ? GETPOSTINT('limit') : $conf->liste_limit;
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
 // Default sort order (if not yet defined by previous GETPOST)
87 87
 if (!$sortfield) {
88
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
88
+    reset($object->fields); // Reset is required to avoid key() to return null.
89 89
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
90 90
 }
91 91
 if (!$sortorder) {
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
 }
487 487
 
488 488
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
489
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
489
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
490 490
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
491 491
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
492 492
 
@@ -577,7 +577,7 @@  discard block
 block discarded – undo
577 577
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
578 578
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
579 579
     }
580
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
580
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
581 581
     if (!empty($arrayfields['t.' . $key]['checked'])) {
582 582
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
583 583
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/hrm/position_card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 $action     = GETPOST('action', 'aZ09') ? GETPOST('action', 'aZ09') : 'view'; // The action 'add', 'create', 'edit', 'update', 'view', ...
42 42
 $backtopage = GETPOST('backtopage', 'alpha');
43 43
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
44
-$id     = GETPOSTINT('id');
44
+$id = GETPOSTINT('id');
45 45
 
46 46
 // Initialize technical objects
47 47
 $form = new Form($db);
Please login to merge, or discard this patch.
public/htdocs/hrm/job_card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 require_once constant('DOL_DOCUMENT_ROOT') . '/hrm/class/skillrank.class.php';
39 39
 
40 40
 // Load translation files required by the page
41
-$langs->loadLangs(array('hrm', 'other', 'products'));   // why products?
41
+$langs->loadLangs(array('hrm', 'other', 'products')); // why products?
42 42
 
43 43
 // Get parameters
44 44
 $id = GETPOSTINT('id');
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'jobcard'; // To manage different context of search
50 50
 $backtopage = GETPOST('backtopage', 'alpha');
51 51
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
52
-$lineid   = GETPOSTINT('lineid');
52
+$lineid = GETPOSTINT('lineid');
53 53
 
54 54
 // Initialize technical objects
55 55
 $object = new Job($db);
Please login to merge, or discard this patch.