Passed
Push — GENERAL_BUG_REVIEW_240911 ( 3362b2...8cbbee )
by Rafael
49:13
created
public/htdocs/mrp/mo_card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 $backtopage = GETPOST('backtopage', 'alpha');
54 54
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
55 55
 $TBomLineId = GETPOST('bomlineid', 'array');
56
-$lineid   = GETPOSTINT('lineid');
56
+$lineid = GETPOSTINT('lineid');
57 57
 $socid = GETPOSTINT("socid");
58 58
 
59 59
 // Initialize technical objects
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         $objectbomchildline = new BOMLine($db);
155 155
 
156 156
         foreach ($TBomLineId as $id_bom_line) {
157
-            $object = new Mo($db);  // modified by the actions_addupdatedelete.inc.php
157
+            $object = new Mo($db); // modified by the actions_addupdatedelete.inc.php
158 158
 
159 159
             $objectbomchildline->fetch($id_bom_line);
160 160
 
Please login to merge, or discard this patch.
public/htdocs/recruitment/admin/setup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 // Parameters
69 69
 $action = GETPOST('action', 'aZ09');
70 70
 $backtopage = GETPOST('backtopage', 'alpha');
71
-$modulepart = GETPOST('modulepart', 'aZ09');    // Used by actions_setmoduleoptions.inc.php
71
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
72 72
 
73 73
 $value = GETPOST('value', 'alpha');
74 74
 $label = GETPOST('label', 'alpha');
Please login to merge, or discard this patch.
public/htdocs/recruitment/admin/setup_candidatures.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 // Parameters
69 69
 $action = GETPOST('action', 'aZ09');
70 70
 $backtopage = GETPOST('backtopage', 'alpha');
71
-$modulepart = GETPOST('modulepart', 'aZ09');    // Used by actions_setmoduleoptions.inc.php
71
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
72 72
 
73 73
 $value = GETPOST('value', 'alpha');
74 74
 $label = GETPOST('label', 'alpha');
Please login to merge, or discard this patch.
modules/recruitment/doc/pdf_standard_recruitmentjobposition.modules.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
     }
177 177
 
178 178
 
179
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
179
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
180 180
     /**
181 181
      *  Function to build pdf onto disk
182 182
      *
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
      */
191 191
     public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
192 192
     {
193
-		// phpcs:enable
193
+        // phpcs:enable
194 194
         global $user, $langs, $conf, $mysoc, $db, $hookmanager, $nblines;
195 195
         global $action;
196 196
 
@@ -643,7 +643,7 @@  discard block
 block discarded – undo
643 643
         }
644 644
     }
645 645
 
646
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
646
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
647 647
     /**
648 648
      *  Return list of active generation modules
649 649
      *
@@ -653,11 +653,11 @@  discard block
 block discarded – undo
653 653
      */
654 654
     public static function liste_modeles($db, $maxfilenamelength = 0)
655 655
     {
656
-		// phpcs:enable
656
+        // phpcs:enable
657 657
         return parent::liste_modeles($db, $maxfilenamelength); // TODO: Change the autogenerated stub
658 658
     }
659 659
 
660
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
660
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
661 661
     /**
662 662
      *   Show table for lines
663 663
      *
@@ -709,7 +709,7 @@  discard block
 block discarded – undo
709 709
         }
710 710
     }
711 711
 
712
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
712
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
713 713
     /**
714 714
      *  Show top header of page.
715 715
      *
@@ -951,7 +951,7 @@  discard block
 block discarded – undo
951 951
         return $top_shift;
952 952
     }
953 953
 
954
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
954
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
955 955
     /**
956 956
      * Show footer of page. Need this->emetteur object
957 957
      *
Please login to merge, or discard this patch.
modules/recruitment/doc/doc_generic_recruitmentjobposition_odt.modules.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
         return $texte;
207 207
     }
208 208
 
209
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
209
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
210 210
     /**
211 211
      *  Function to build a document on disk using the generic odt module.
212 212
      *
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
      */
221 221
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
222 222
     {
223
-		// phpcs:enable
223
+        // phpcs:enable
224 224
         global $user, $langs, $conf, $mysoc, $hookmanager;
225 225
         global $action;
226 226
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@
 block discarded – undo
188 188
         $maxfilesizearray = getMaxFileSizeArray();
189 189
         $maxmin = $maxfilesizearray['maxmin'];
190 190
         if ($maxmin > 0) {
191
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
191
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
192 192
         }
193 193
         $texte .= ' <input type="file" name="uploadfile">';
194 194
         $texte .= '<input type="hidden" value="RECRUITMENT_RECRUITMENTJOBPOSITION_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';
Please login to merge, or discard this patch.
public/htdocs/recruitment/recruitmentcandidature_list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 $object = new RecruitmentCandidature($db);
68 68
 $extrafields = new ExtraFields($db);
69 69
 $diroutputmassaction = $conf->recruitment->dir_output . '/temp/massgeneration/' . $user->id;
70
-$hookmanager->initHooks(array($contextpage));   // Note that conf->hooks_modules contains array of activated contexes
70
+$hookmanager->initHooks(array($contextpage)); // Note that conf->hooks_modules contains array of activated contexes
71 71
 
72 72
 // Fetch optionals attributes and labels
73 73
 $extrafields->fetch_name_optionals_label($object->table_element);
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
699 699
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
700 700
     }
701
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
701
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
702 702
     if (!empty($arrayfields['t.' . $key]['checked'])) {
703 703
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
704 704
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/holiday/define_holiday.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 $limit = GETPOSTINT('limit') ? GETPOSTINT('limit') : $conf->liste_limit;
50 50
 $sortfield = GETPOST('sortfield', 'aZ09comma');
51 51
 $sortorder = GETPOST('sortorder', 'aZ09comma');
52
-$toselect   = GETPOST('toselect', 'array'); // Array of ids of elements selected into a list
52
+$toselect = GETPOST('toselect', 'array'); // Array of ids of elements selected into a list
53 53
 $confirm = GETPOST('confirm', 'alpha');
54 54
 
55 55
 $page = GETPOSTISSET('pageplusone') ? (GETPOSTINT('pageplusone') - 1) : GETPOSTINT("page");
@@ -267,12 +267,12 @@  discard block
 block discarded – undo
267 267
     foreach ($typeleaves as $key => $val) {
268 268
         $labeltypes[$val['id']] = ($langs->trans($val['code']) != $val['code']) ? $langs->trans($val['code']) : $langs->trans($val['label']);
269 269
     }
270
-    $formquestion [] = array( 'type' => 'other',
270
+    $formquestion [] = array('type' => 'other',
271 271
         'name' => 'typeofholiday',
272 272
         'label' => $langs->trans("Type"),
273 273
         'value' => $form->selectarray('typeholiday', $labeltypes, GETPOST('typeholiday', 'alpha'), 1)
274 274
     );
275
-    $formquestion [] = array( 'type' => 'other',
275
+    $formquestion [] = array('type' => 'other',
276 276
         'name' => 'nbdaysholydays',
277 277
         'label' => $langs->trans("NumberDayAddMass"),
278 278
         'value' => '<input name="nbdaysholidays" class="maxwidth75" id="nbdaysholidays" value="' . GETPOSTINT('nbdaysholidays') . '">'
Please login to merge, or discard this patch.
public/htdocs/holiday/card.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
 
506 506
                 // option to warn the validator in case of too short delay
507 507
                 if (!getDolGlobalString('HOLIDAY_HIDE_APPROVER_ABOUT_TOO_LOW_DELAY')) {
508
-                    $delayForRequest = 0;       // TODO Set delay depending of holiday leave type
508
+                    $delayForRequest = 0; // TODO Set delay depending of holiday leave type
509 509
                     if ($delayForRequest) {
510 510
                         $nowplusdelay = dol_time_plus_duree($now, $delayForRequest, 'd');
511 511
 
@@ -1213,7 +1213,7 @@  discard block
 block discarded – undo
1213 1213
             $result = $object->fetch($id, $ref);
1214 1214
 
1215 1215
             $approverexpected = new User($db);
1216
-            $approverexpected->fetch($object->fk_validator);    // Use that should be the approver
1216
+            $approverexpected->fetch($object->fk_validator); // Use that should be the approver
1217 1217
 
1218 1218
             $userRequest = new User($db);
1219 1219
             $userRequest->fetch($object->fk_user);
@@ -1448,7 +1448,7 @@  discard block
 block discarded – undo
1448 1448
                     print '</tr>';
1449 1449
                 } else {
1450 1450
                     print '<tr>';
1451
-                    print '<td class="titlefield">' . $langs->trans('ReviewedByCP') . '</td>';  // Will be approved by
1451
+                    print '<td class="titlefield">' . $langs->trans('ReviewedByCP') . '</td>'; // Will be approved by
1452 1452
                     print '<td>';
1453 1453
                     $include_users = $object->fetch_users_approver_holiday();
1454 1454
                     if (!in_array($object->fk_validator, $include_users)) {  // Add the current validator to the list to not lose it when editing.
Please login to merge, or discard this patch.
public/htdocs/holiday/card_group.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
165 165
         }
166 166
 
167 167
         if (!$error) {
168
-            $users      =  GETPOST('users', 'array');
169
-            $groups     =  GETPOST('groups', 'array');
168
+            $users      = GETPOST('users', 'array');
169
+            $groups     = GETPOST('groups', 'array');
170 170
 
171 171
             $date_debut = dol_mktime(0, 0, 0, GETPOST('date_debut_month'), GETPOST('date_debut_day'), GETPOST('date_debut_year'));
172 172
             $date_fin = dol_mktime(0, 0, 0, GETPOST('date_fin_month'), GETPOST('date_fin_day'), GETPOST('date_fin_year'));
@@ -732,7 +732,7 @@  discard block
 block discarded – undo
732 732
 
733 733
                 // option to warn the validator in case of too short delay
734 734
                 if (!getDolGlobalString('HOLIDAY_HIDE_APPROVER_ABOUT_TOO_LOW_DELAY')) {
735
-                    $delayForRequest = 0;       // TODO Set delay depending of holiday leave type
735
+                    $delayForRequest = 0; // TODO Set delay depending of holiday leave type
736 736
                     if ($delayForRequest) {
737 737
                         $nowplusdelay = dol_time_plus_duree($now, $delayForRequest, 'd');
738 738
 
Please login to merge, or discard this patch.