Passed
Push — GENERAL_BUG_REVIEW_240911 ( 3362b2...8cbbee )
by Rafael
49:13
created
public/htdocs/blockedlog/admin/blockedlog_list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
     $previoushash = '';
158 158
     $firstid = '';
159 159
 
160
-    if (! (GETPOSTINT('yeartoexport') > 0)) {
160
+    if (!(GETPOSTINT('yeartoexport') > 0)) {
161 161
         setEventMessages($langs->trans("ErrorFieldRequired", $langs->transnoentitiesnoconv("Year")), null, "errors");
162 162
         $error++;
163 163
     } else {
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
 
582 582
             // Link to source object
583 583
             print '<td class="tdoverflowmax150"' . (preg_match('/<a/', $object_link) ? '' : 'title="' . dol_escape_htmltag(dol_string_nohtmltag($object_link . ' - ' . $object_link_title)) . '"') . '>';
584
-            print '<!-- object_link -->';   // $object_link can be a '<a href' link or a text
584
+            print '<!-- object_link -->'; // $object_link can be a '<a href' link or a text
585 585
             print $object_link;
586 586
             print '</td>';
587 587
 
Please login to merge, or discard this patch.
public/htdocs/theme/eldy/global.inc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
147 147
     print "/* For dark mode */\n";
148 148
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
149
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
149
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
150 150
     } else {
151 151
         print "@media not print {";
152 152
     }
@@ -5402,7 +5402,7 @@  discard block
 block discarded – undo
5402 5402
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
5403 5403
     print "/* For dark mode */\n";
5404 5404
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
5405
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
5405
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
5406 5406
     } else {
5407 5407
         print "@media not print {";
5408 5408
     } ?>
Please login to merge, or discard this patch.
public/htdocs/theme/eldy/btn.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
19 19
     print "/* For dark mode */\n";
20 20
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
21
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
21
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
22 22
     } else {
23 23
         print "@media not print {";
24 24
     }
Please login to merge, or discard this patch.
public/htdocs/theme/md/style.css.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 $colortext           = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXT') ? $colortext : $conf->global->THEME_ELDY_TEXT) : (empty($user->conf->THEME_ELDY_TEXT) ? $colortext : $user->conf->THEME_ELDY_TEXT);
194 194
 $colortextlink       = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTLINK') ? $colortext : $conf->global->THEME_ELDY_TEXTLINK) : (empty($user->conf->THEME_ELDY_TEXTLINK) ? $colortextlink : $user->conf->THEME_ELDY_TEXTLINK);
195 195
 $butactionbg         = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_BTNACTION') ? $butactionbg : $conf->global->THEME_ELDY_BTNACTION) : (empty($user->conf->THEME_ELDY_BTNACTION) ? $butactionbg : $user->conf->THEME_ELDY_BTNACTION);
196
-$textbutaction     = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTBTNACTION') ? $textbutaction : $conf->global->THEME_ELDY_TEXTBTNACTION) : (empty($user->conf->THEME_ELDY_TEXTBTNACTION) ? $textbutaction : $user->conf->THEME_ELDY_TEXTBTNACTION);
196
+$textbutaction = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTBTNACTION') ? $textbutaction : $conf->global->THEME_ELDY_TEXTBTNACTION) : (empty($user->conf->THEME_ELDY_TEXTBTNACTION) ? $textbutaction : $user->conf->THEME_ELDY_TEXTBTNACTION);
197 197
 $fontsize            = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_FONT_SIZE1') ? $fontsize : $conf->global->THEME_ELDY_FONT_SIZE1) : (empty($user->conf->THEME_ELDY_FONT_SIZE1) ? $fontsize : $user->conf->THEME_ELDY_FONT_SIZE1);
198 198
 $fontsizesmaller     = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_FONT_SIZE2') ? $fontsize : $conf->global->THEME_ELDY_FONT_SIZE2) : (empty($user->conf->THEME_ELDY_FONT_SIZE2) ? $fontsize : $user->conf->THEME_ELDY_FONT_SIZE2);
199 199
 $heightrow           = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_USECOMOACTROW') ? '155%' : '300%') : (empty($user->conf->THEME_ELDY_USECOMOACTROW) ? '155%' : '300%');
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
378 378
     print "/* For dark mode */\n";
379 379
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
380
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
380
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
381 381
     } else {
382 382
         print "@media not print {";
383 383
     }
@@ -3034,7 +3034,7 @@  discard block
 block discarded – undo
3034 3034
                     if (preg_match('/^fa\-/', $iconformodule)) {
3035 3035
                         // This is a fa icon
3036 3036
                     } else {
3037
-                        $url =  dol_buildpath('/' . $val . '/img/' . $iconformodule . '.png', 1);
3037
+                        $url = dol_buildpath('/' . $val . '/img/' . $iconformodule . '.png', 1);
3038 3038
                     }
3039 3039
                     $found = 1;
3040 3040
                 } else {
Please login to merge, or discard this patch.
public/htdocs/theme/md/btn.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
19 19
     print "/* For dark mode */\n";
20 20
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
21
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
21
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
22 22
     } else {
23 23
         print "@media not print {";
24 24
     }
Please login to merge, or discard this patch.
public/htdocs/variants/card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -286,7 +286,7 @@
 block discarded – undo
286 286
     if ($action != 'editline') {
287 287
         print '<div class="tabsAction">' . "\n";
288 288
         $parameters = array();
289
-        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook
289
+        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
290 290
         if ($reshook < 0) {
291 291
             setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
292 292
         }
Please login to merge, or discard this patch.
public/htdocs/variants/combinations.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -778,7 +778,7 @@
 block discarded – undo
778 778
         <div style="text-align: center">
779 779
         <input type="submit" name="create" <?php if (!is_array($productCombination2ValuePairs1)) {
780 780
             print ' disabled="disabled"';
781
-                                           } ?> value="<?php echo $action == 'add' ? $langs->trans('Create') : $langs->trans("Save") ?>" class="button button-save">
781
+                                            } ?> value="<?php echo $action == 'add' ? $langs->trans('Create') : $langs->trans("Save") ?>" class="button button-save">
782 782
         &nbsp;
783 783
         <input type="submit" name="cancel" value="<?php echo $langs->trans("Cancel"); ?>" class="button button-cancel">
784 784
         </div>
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,12 +30,12 @@
 block discarded – undo
30 30
 
31 31
 $langs->loadLangs(array("products", "other"));
32 32
 
33
-$id = GETPOSTINT('id');                             // ID of the parent Product
33
+$id = GETPOSTINT('id'); // ID of the parent Product
34 34
 $ref = GETPOST('ref', 'alpha');
35 35
 
36
-$combination_id = GETPOSTINT('combination_id');     // ID of the combination
36
+$combination_id = GETPOSTINT('combination_id'); // ID of the combination
37 37
 
38
-$reference = GETPOST('reference', 'alpha');         // Reference of the variant Product
38
+$reference = GETPOST('reference', 'alpha'); // Reference of the variant Product
39 39
 
40 40
 $weight_impact = GETPOSTFLOAT('weight_impact', 2);
41 41
 $price_impact_percent = (bool) GETPOST('price_impact_percent');
Please login to merge, or discard this patch.
public/htdocs/variants/list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
 $object->fields = dol_sort_array($object->fields, 'position');
145 145
 $arrayfields = dol_sort_array($arrayfields, 'position');
146
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
146
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
147 147
 
148 148
 $permissiontoread = $user->hasRight('variants', 'read');
149 149
 $permissiontoadd = $user->hasRight('variants', 'write');
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 //}
325 325
 // Add where from hooks
326 326
 $parameters = array();
327
-$reshook = $hookmanager->executeHooks('printFieldListGroupBy', $parameters, $object);    // Note that $action and $object may have been modified by hook
327
+$reshook = $hookmanager->executeHooks('printFieldListGroupBy', $parameters, $object); // Note that $action and $object may have been modified by hook
328 328
 $sql .= $hookmanager->resPrint;
329 329
 $sql = preg_replace("/,\s*$/", "", $sql);
330 330
 
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 }
514 514
 
515 515
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
516
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
516
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
517 517
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
518 518
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
519 519
 
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
617 617
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
618 618
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
619 619
     }
620
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
620
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
621 621
     if (!empty($arrayfields['t.' . $key]['checked'])) {
622 622
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
623 623
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/imports/emptyexample.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,8 +101,8 @@
 block discarded – undo
101 101
 
102 102
 
103 103
 // List of targets fields
104
-$headerlinefields = array();    // Array of fields (label to show)
105
-$contentlinevalues = array();   // Array of example values
104
+$headerlinefields = array(); // Array of fields (label to show)
105
+$contentlinevalues = array(); // Array of example values
106 106
 $i = 0;
107 107
 foreach ($fieldstarget as $code => $label) {
108 108
     $withoutstar = preg_replace('/\*/', '', $fieldstarget[$code]);
Please login to merge, or discard this patch.