DoliModules\Install\Controller\InstallController::createUser()

Complexity

Conditions	34
Paths	> 20000

Size

Total Lines	209
Code Lines	123

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    private function createUser(string $username, string $password): bool
    {
        $db = Config::getDb();
        $conf = Config::getConf();

        // Active module user
        include_once BASE_PATH . '/core/modules/modUser.class.php';
        $objMod = new modUser($db);

        dolibarr_install_syslog('step5: load module user ' . DOL_DOCUMENT_ROOT . "/core/modules/" . $file, LOG_INFO);

The variable $file seems to be never defined.

        $result = $objMod->init();
        if (!$result) {
            print "ERROR: failed to init module file = " . $file;
        }

        if ($db->connected) {
            $conf->setValues($db);
            // Reset forced setup after the setValues
            if (defined('SYSLOG_FILE')) {
                $conf->global->SYSLOG_FILE = constant('SYSLOG_FILE');
            }
            $conf->global->MAIN_ENABLE_LOG_TO_HTML = 1;

            // Create admin user
            include_once DOL_DOCUMENT_ROOT . '/user/class/user.class.php';

            // Set default encryption to yes, generate a salt and set default encryption algorithm (but only if there is no user yet into database)
            $sql = "SELECT u.rowid, u.pass, u.pass_crypted";
            $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";
            $resql = $db->query($sql);
            if ($resql) {
                $numrows = $db->num_rows($resql);
                if ($numrows == 0) {
                    // Define default setup for password encryption
                    dolibarr_set_const($db, "DATABASE_PWD_ENCRYPTED", "1", 'chaine', 0, '', $conf->entity);
                    dolibarr_set_const($db, "MAIN_SECURITY_SALT", dol_print_date(dol_now(), 'dayhourlog'), 'chaine', 0, '', 0); // All entities
                    if (function_exists('password_hash')) {
                        dolibarr_set_const($db, "MAIN_SECURITY_HASH_ALGO", 'password_hash', 'chaine', 0, '', 0); // All entities
                    } else {
                        dolibarr_set_const($db, "MAIN_SECURITY_HASH_ALGO", 'sha1md5', 'chaine', 0, '', 0); // All entities
                    }
                }

                dolibarr_install_syslog('step5: DATABASE_PWD_ENCRYPTED = ' . getDolGlobalString('DATABASE_PWD_ENCRYPTED') . ' MAIN_SECURITY_HASH_ALGO = ' . getDolGlobalString('MAIN_SECURITY_HASH_ALGO'), LOG_INFO);
            }

            // Create user used to create the admin user
            $createuser = new User($db);
            $createuser->id = 0;
            $createuser->admin = 1;

            // Set admin user
            $newuser = new User($db);
            $newuser->lastname = 'SuperAdmin';
            $newuser->firstname = '';
            $newuser->login = $username;
            $newuser->pass = $password;
            $newuser->admin = 1;
            $newuser->entity = 0;

            $conf->global->USER_MAIL_REQUIRED = 0;            // Force global option to be sure to create a new user with no email
            $conf->global->USER_PASSWORD_GENERATED = '';    // To not use any rule for password validation

            $result = $newuser->create($createuser, 1);
            if ($result > 0) {
                print $this->langs->trans("AdminLoginCreatedSuccessfuly", $login) . "<br>";

The variable $login seems to be never defined.

                $success = 1;
            } else {
                if ($result == -6) {    //login or email already exists
                    dolibarr_install_syslog('step5: AdminLoginAlreadyExists', LOG_WARNING);
                    print '<br><div class="warning">' . $newuser->error . "</div><br>";
                    $success = 1;
                } else {
                    dolibarr_install_syslog('step5: FailedToCreateAdminLogin ' . $newuser->error, LOG_ERR);
                    setEventMessages($this->langs->trans("FailedToCreateAdminLogin") . ' ' . $newuser->error, null, 'errors');
                    //header("Location: step4.php?error=3&selectlang=$setuplang".(isset($login) ? '&login='.$login : ''));
                    print '<br><div class="error">' . $this->langs->trans("FailedToCreateAdminLogin") . ': ' . $newuser->error . '</div><br><br>';
                    print $this->langs->trans("ErrorGoBackAndCorrectParameters") . '<br><br>';
                }
            }

            if ($success) {
                // Insert MAIN_VERSION_FIRST_INSTALL in a dedicated transaction. So if it fails (when first install was already done), we can do other following requests.
                $db->begin();
                dolibarr_install_syslog('step5: set MAIN_VERSION_FIRST_INSTALL const to ' . $targetversion, LOG_DEBUG);

The variable $targetversion seems to be never defined.

                $resql = $db->query("INSERT INTO " . MAIN_DB_PREFIX . "const(name, value, type, visible, note, entity) values(" . $db->encrypt('MAIN_VERSION_FIRST_INSTALL') . ", " . $db->encrypt($targetversion) . ", 'chaine', 0, 'Dolibarr version when first install', 0)");
                if ($resql) {
                    $conf->global->MAIN_VERSION_FIRST_INSTALL = $targetversion;
                    $db->commit();
                } else {
                    //if (! $resql) dol_print_error($db,'Error in setup program');      // We ignore errors. Key may already exists
                    $db->commit();
                }

                $db->begin();

                dolibarr_install_syslog('step5: set MAIN_VERSION_LAST_INSTALL const to ' . $targetversion, LOG_DEBUG);
                $resql = $db->query("DELETE FROM " . MAIN_DB_PREFIX . "const WHERE " . $db->decrypt('name') . " = 'MAIN_VERSION_LAST_INSTALL'");
                if (!$resql) {
                    dol_print_error($db, 'Error in setup program');
                }
                $resql = $db->query("INSERT INTO " . MAIN_DB_PREFIX . "const(name,value,type,visible,note,entity) values(" . $db->encrypt('MAIN_VERSION_LAST_INSTALL') . ", " . $db->encrypt($targetversion) . ", 'chaine', 0, 'Dolibarr version when last install', 0)");
                if (!$resql) {
                    dol_print_error($db, 'Error in setup program');
                }
                $conf->global->MAIN_VERSION_LAST_INSTALL = $targetversion;

                if ($useforcedwizard) {

The variable $useforcedwizard seems to be never defined.

                    dolibarr_install_syslog('step5: set MAIN_REMOVE_INSTALL_WARNING const to 1', LOG_DEBUG);
                    $resql = $db->query("DELETE FROM " . MAIN_DB_PREFIX . "const WHERE " . $db->decrypt('name') . " = 'MAIN_REMOVE_INSTALL_WARNING'");
                    if (!$resql) {
                        dol_print_error($db, 'Error in setup program');
                    }
                    // The install.lock file is created few lines later if version is last one or if option MAIN_ALWAYS_CREATE_LOCK_AFTER_LAST_UPGRADE is on
                    /* No need to enable this
                    $resql = $db->query("INSERT INTO ".MAIN_DB_PREFIX."const(name,value,type,visible,note,entity) values(".$db->encrypt('MAIN_REMOVE_INSTALL_WARNING').", ".$db->encrypt(1).", 'chaine', 1, 'Disable install warnings', 0)");
                    if (!$resql) {
                        dol_print_error($db, 'Error in setup program');
                    }
                    $conf->global->MAIN_REMOVE_INSTALL_WARNING = 1;
                    */
                }

                // List of modules to enable
                $tmparray = array();

                // If we ask to force some modules to be enabled
                if (!empty($force_install_module)) {

The variable $force_install_module seems to never exist and therefore empty should always be true.

                    if (!defined('DOL_DOCUMENT_ROOT') && !empty($dolibarr_main_document_root)) {

The variable $dolibarr_main_document_root seems to never exist and therefore empty should always be true.

                        define('DOL_DOCUMENT_ROOT', $dolibarr_main_document_root);
                    }

                    $tmparray = explode(',', $force_install_module);
                }

                $modNameLoaded = array();

                // Search modules dirs
                $modulesdir[] = $dolibarr_main_document_root . '/core/modules/';

The variable $dolibarr_main_document_root seems to be never defined.

$modulesdir was never initialized. Although not strictly required by PHP, it is generally a good practice to add $modulesdir = array(); before regardless.

                foreach ($modulesdir as $dir) {
                    // Load modules attributes in arrays (name, numero, orders) from dir directory
                    //print $dir."\n<br>";
                    dol_syslog("Scan directory " . $dir . " for module descriptor files (modXXX.class.php)");
                    $handle = @opendir($dir);
                    if (is_resource($handle)) {
                        while (($file = readdir($handle)) !== false) {
                            if (is_readable($dir . $file) && substr($file, 0, 3) == 'mod' && substr($file, dol_strlen($file) - 10) == '.class.php') {
                                $modName = substr($file, 0, dol_strlen($file) - 10);
                                if ($modName) {
                                    if (!empty($modNameLoaded[$modName])) {   // In cache of already loaded modules ?
                                        $mesg = "Error: Module " . $modName . " was found twice: Into " . $modNameLoaded[$modName] . " and " . $dir . ". You probably have an old file on your disk.<br>";
                                        setEventMessages($mesg, null, 'warnings');
                                        dol_syslog($mesg, LOG_ERR);
                                        continue;
                                    }

                                    try {
                                        $res = include_once $dir . $file; // A class already exists in a different file will send a non catchable fatal error.
                                        if (class_exists($modName)) {
                                            $objMod = new $modName($db);
                                            $modNameLoaded[$modName] = $dir;
                                            if (!empty($objMod->enabled_bydefault) && !in_array($file, $tmparray)) {
                                                $tmparray[] = $file;
                                            }
                                        }
                                    } catch (Exception $e) {

The type DoliModules\Install\Controller\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

                                        dol_syslog("Failed to load " . $dir . $file . " " . $e->getMessage(), LOG_ERR);
                                    }
                                }
                            }
                        }
                    }
                }

                // Loop on each modules to activate it
                if (!empty($tmparray)) {
                    foreach ($tmparray as $modtoactivate) {
                        $modtoactivatenew = preg_replace('/\.class\.php$/i', '', $modtoactivate);
                        //print $this->langs->trans("ActivateModule", $modtoactivatenew).'<br>';

                        $file = $modtoactivatenew . '.class.php';
                        dolibarr_install_syslog('step5: activate module file=' . $file);
                        $res = dol_include_once("/core/modules/" . $file);

                        $res = activateModule($modtoactivatenew, 1);
                        if (!empty($res['errors'])) {
                            print 'ERROR: failed to activateModule() file=' . $file;
                        }
                    }
                    //print '<br>';
                }

                // Now delete the flag that say installation is not complete
                dolibarr_install_syslog('step5: remove MAIN_NOT_INSTALLED const');
                $resql = $db->query("DELETE FROM " . MAIN_DB_PREFIX . "const WHERE " . $db->decrypt('name') . " = 'MAIN_NOT_INSTALLED'");
                if (!$resql) {
                    dol_print_error($db, 'Error in setup program');
                }

                // May fail if parameter already defined
                dolibarr_install_syslog('step5: set the default language');
                $resql = $db->query("INSERT INTO " . MAIN_DB_PREFIX . "const(name,value,type,visible,note,entity) VALUES (" . $db->encrypt('MAIN_LANG_DEFAULT') . ", " . $db->encrypt($setuplang) . ", 'chaine', 0, 'Default language', 1)");

The variable $setuplang seems to be never defined.

                //if (! $resql) dol_print_error($db,'Error in setup program');

                $db->commit();

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

            }

The function implicitly returns null when the if condition on line 746 is false. This is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

        } else {
            print $this->langs->trans("ErrorFailedToConnect") . "<br>";

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

        }