Passed
Push — GENERAL_BUG_REVIEW_241017 ( bdd305...ea216b )
by Rafael
47:51
created
public/htdocs/accountancy/supplier/lines.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 $changeaccount = GETPOST('changeaccount');
50 50
 // Search Getpost
51 51
 $search_societe = GETPOST('search_societe', 'alpha');
52
-$search_lineid = GETPOST('search_lineid', 'alpha');     // Can be '> 100'
52
+$search_lineid = GETPOST('search_lineid', 'alpha'); // Can be '> 100'
53 53
 $search_ref = GETPOST('search_ref', 'alpha');
54 54
 $search_invoice = GETPOST('search_invoice', 'alpha');
55 55
 //$search_ref_supplier = GETPOST('search_ref_supplier', 'alpha');
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 $search_date_endday = GETPOSTINT('search_date_endday');
65 65
 $search_date_endmonth = GETPOSTINT('search_date_endmonth');
66 66
 $search_date_endyear = GETPOSTINT('search_date_endyear');
67
-$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);   // Use tzserver
67
+$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
68 68
 $search_date_end = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
69 69
 $search_country = GETPOST('search_country', 'aZ09');
70 70
 $search_tvaintra = GETPOST('search_tvaintra', 'alpha');
Please login to merge, or discard this patch.
public/htdocs/accountancy/supplier/list.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 $mesCasesCochees = GETPOST('toselect', 'array');
59 59
 
60 60
 // Search Getpost
61
-$search_lineid = GETPOST('search_lineid', 'alpha');     // Can be '> 100'
61
+$search_lineid = GETPOST('search_lineid', 'alpha'); // Can be '> 100'
62 62
 $search_societe = GETPOST('search_societe', 'alpha');
63 63
 $search_ref = GETPOST('search_ref', 'alpha');
64 64
 $search_ref_supplier = GETPOST('search_ref_supplier', 'alpha');
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 $search_date_endday = GETPOSTINT('search_date_endday');
75 75
 $search_date_endmonth = GETPOSTINT('search_date_endmonth');
76 76
 $search_date_endyear = GETPOSTINT('search_date_endyear');
77
-$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);   // Use tzserver
77
+$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
78 78
 $search_date_end = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
79 79
 $search_country = GETPOST('search_country', 'aZ09');
80 80
 $search_tvaintra = GETPOST('search_tvaintra', 'alpha');
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
585 585
         $thirdpartystatic->email = $objp->email;
586 586
         $thirdpartystatic->country_code = $objp->country_code;
587 587
         $thirdpartystatic->tva_intra = $objp->tva_intra;
588
-        $thirdpartystatic->code_compta_product = $objp->company_code_buy;       // The accounting account for product stored on thirdparty object (for level3 suggestion)
588
+        $thirdpartystatic->code_compta_product = $objp->company_code_buy; // The accounting account for product stored on thirdparty object (for level3 suggestion)
589 589
 
590 590
         $product_static->ref = $objp->product_ref;
591 591
         $product_static->id = $objp->product_id;
Please login to merge, or discard this patch.
public/htdocs/accountancy/supplier/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -201,7 +201,7 @@
 block discarded – undo
201 201
             $thirdpartystatic->email = $objp->email;
202 202
             $thirdpartystatic->country_code = $objp->country_code;
203 203
             $thirdpartystatic->tva_intra = $objp->tva_intra;
204
-            $thirdpartystatic->code_compta_product = $objp->company_code_buy;       // The accounting account for product stored on thirdparty object (for level3 suggestion)
204
+            $thirdpartystatic->code_compta_product = $objp->company_code_buy; // The accounting account for product stored on thirdparty object (for level3 suggestion)
205 205
 
206 206
             $product_static->ref = $objp->product_ref;
207 207
             $product_static->id = $objp->product_id;
Please login to merge, or discard this patch.
public/htdocs/categories/viewcat.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1140,7 +1140,7 @@
 block discarded – undo
1140 1140
                 print '<input type="hidden" name="action" value="addintocategory">';
1141 1141
                 print '<table class="noborder centpercent">';
1142 1142
                 print '<tr class="liste_titre"><td>';
1143
-                $force_entity = getEntity($object->element);    // So we will get same filter than the getObjectsInCateg()
1143
+                $force_entity = getEntity($object->element); // So we will get same filter than the getObjectsInCateg()
1144 1144
                 print img_picto('', $type, 'class="pictofixedwidth"');
1145 1145
                 print $form->select_dolusers('', 'elemid', 1, null, 0, '', '', $force_entity);
1146 1146
                 print '<input type="submit" class="button buttongen" value="' . $langs->trans("ClassifyInCategory") . '"></td>';
Please login to merge, or discard this patch.
public/htdocs/categories/photos.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 /*
70 70
  * Actions
71 71
  */
72
-$parameters = array('id' => $id,  'label' => $label, 'confirm' => $confirm, 'type' => $type, 'uploaddir' => $upload_dir, 'sendfile' => (GETPOST("sendit") ? true : false));
72
+$parameters = array('id' => $id, 'label' => $label, 'confirm' => $confirm, 'type' => $type, 'uploaddir' => $upload_dir, 'sendfile' => (GETPOST("sendit") ? true : false));
73 73
 // Note that $action and $object may be modified by some hooks
74 74
 $reshook = $hookmanager->executeHooks('doActions', $parameters, $object, $action);
75 75
 if ($reshook < 0) {
Please login to merge, or discard this patch.
public/htdocs/categories/traduction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
 $type = $object->type;
61 61
 if (is_numeric($type)) {
62
-    $type = Categorie::$MAP_ID_TO_CODE[$type];   // For backward compatibility
62
+    $type = Categorie::$MAP_ID_TO_CODE[$type]; // For backward compatibility
63 63
 }
64 64
 
65 65
 
Please login to merge, or discard this patch.
public/htdocs/emailcollector/lib/emailcollector.lib.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
  */
119 119
 function getAttachments($jk, $mbox)
120 120
 {
121
-    $structure = imap_fetchstructure($mbox, $jk, FT_UID);  // @phan-suppress-current-line PhanTypeMismatchArgumentInternal
121
+    $structure = imap_fetchstructure($mbox, $jk, FT_UID); // @phan-suppress-current-line PhanTypeMismatchArgumentInternal
122 122
     $parts = getParts($structure);
123 123
 
124 124
     $fpos = 2;
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
  */
156 156
 function getFileData($jk, $fpos, $type, $mbox)
157 157
 {
158
-    $merge = imap_fetchbody($mbox, $jk, $fpos, FT_UID);  // @phan-suppress-current-line PhanTypeMismatchArgumentInternal
158
+    $merge = imap_fetchbody($mbox, $jk, $fpos, FT_UID); // @phan-suppress-current-line PhanTypeMismatchArgumentInternal
159 159
     $data = getDecodeValue($merge, $type);
160 160
 
161 161
     return $data;
Please login to merge, or discard this patch.
public/htdocs/expedition/ajax/searchfrombarcode.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -98,22 +98,22 @@
 block discarded – undo
98 98
                     $fk_product = $obj->fk_product;
99 99
                     $reelqty = $obj->reel;
100 100
 
101
-                    $objectreturn = array('fk_warehouse' => $warehouseid,'fk_product' => $fk_product,'reelqty' => $reelqty);
101
+                    $objectreturn = array('fk_warehouse' => $warehouseid, 'fk_product' => $fk_product, 'reelqty' => $reelqty);
102 102
                 }
103 103
             }
104 104
         }
105 105
         if ($warehousefound < 1) {
106
-            $response = array('status' => 'error','errorcode' => 'NotFound','message' => 'No warehouse found for barcode' . $barcode);
106
+            $response = array('status' => 'error', 'errorcode' => 'NotFound', 'message' => 'No warehouse found for barcode' . $barcode);
107 107
         } elseif ($warehousefound > 1) {
108
-            $response = array('status' => 'error','errorcode' => 'TooManyWarehouse','message' => 'Too many warehouse found');
108
+            $response = array('status' => 'error', 'errorcode' => 'TooManyWarehouse', 'message' => 'Too many warehouse found');
109 109
         } else {
110
-            $response = array('status' => 'success','message' => 'Warehouse found','object' => $objectreturn);
110
+            $response = array('status' => 'success', 'message' => 'Warehouse found', 'object' => $objectreturn);
111 111
         }
112 112
     } else {
113
-        $response = array('status' => 'error','errorcode' => 'NotFound','message' => "No results found for barcode");
113
+        $response = array('status' => 'error', 'errorcode' => 'NotFound', 'message' => "No results found for barcode");
114 114
     }
115 115
 } else {
116
-    $response = array('status' => 'error','errorcode' => 'ActionError','message' => "Error on action");
116
+    $response = array('status' => 'error', 'errorcode' => 'ActionError', 'message' => "Error on action");
117 117
 }
118 118
 
119 119
 $response = json_encode($response);
Please login to merge, or discard this patch.
public/htdocs/expedition/card.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1449,7 +1449,7 @@  discard block
 block discarded – undo
1449 1449
                                         $tooltipClass = ' classfortooltip';
1450 1450
                                         $tooltipTitle = $langs->trans('StockQuantitiesAlreadyAllocatedOnPreviousLines') . ' : ' . $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1451 1451
                                     } else {
1452
-                                        $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0 ;
1452
+                                        $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0;
1453 1453
                                     }
1454 1454
                                     $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = $deliverableQty + $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1455 1455
 
@@ -1688,7 +1688,7 @@  discard block
 block discarded – undo
1688 1688
                                             $tooltipClass = ' classfortooltip';
1689 1689
                                             $tooltipTitle = $langs->trans('StockQuantitiesAlreadyAllocatedOnPreviousLines') . ' : ' . $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1690 1690
                                         } else {
1691
-                                            $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0 ;
1691
+                                            $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = 0;
1692 1692
                                         }
1693 1693
                                         $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)] = $deliverableQty + $alreadyQtyBatchSetted[$line->fk_product][$dbatch->batch][intval($warehouse_id)];
1694 1694
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1437,7 +1437,9 @@
 block discarded – undo
1437 1437
                                         $deliverableQty = min($quantityToBeDelivered, $batchStock);
1438 1438
                                     }
1439 1439
 
1440
-                                    if ($deliverableQty < 0) $deliverableQty = 0;
1440
+                                    if ($deliverableQty < 0) {
1441
+                                        $deliverableQty = 0;
1442
+                                    }
1441 1443
 
1442 1444
                                     $inputName = 'qtyl' . $indiceAsked . '_' . $subj;
1443 1445
                                     if (GETPOSTISSET($inputName)) {
Please login to merge, or discard this patch.