alxarafe / alixar

Base/Conf.php

Spacing +101 added lines, -101 removed lines

@@ -36,8 +36,8 @@ 
     //! Used to store current currency (ISO code like 'USD', 'EUR', ...)

     public $currency;

     //! Used to store current css (from theme)

-    public $theme;        // Contains current theme ("eldy", "auguria", ...)

-    public $css;          // Contains full path of css page ("/theme/eldy/style.css.php", ...)

+    public $theme; // Contains current theme ("eldy", "auguria", ...)

+    public $css; // Contains full path of css page ("/theme/eldy/style.css.php", ...)

     //! Used to store current menu handler

     public $standard_menu;

     public $modules = array(); // List of activated modules

@@ -54,11 +54,11 @@ 
     public $entity = 1;

     //! Used to store list of entities to use for each element

     public $entities = array();

-    public $dol_hide_topmenu;   // Set if we force param dol_hide_topmenu into login url

-    public $dol_hide_leftmenu;   // Set if we force param dol_hide_leftmenu into login url

+    public $dol_hide_topmenu; // Set if we force param dol_hide_topmenu into login url

+    public $dol_hide_leftmenu; // Set if we force param dol_hide_leftmenu into login url

     public $dol_optimize_smallscreen; // Set if we force param dol_optimize_smallscreen into login url or if browser is smartphone

-    public $dol_no_mouse_hover;   // Set if we force param dol_no_mouse_hover into login url or if browser is smartphone

-    public $dol_use_jmobile;   // Set if we force param dol_use_jmobile into login url

+    public $dol_no_mouse_hover; // Set if we force param dol_no_mouse_hover into login url or if browser is smartphone

+    public $dol_use_jmobile; // Set if we force param dol_use_jmobile into login url

 

     /**

      * Constructor

@@ -79,7 +79,7 @@ 
         $this->multicompany = new \stdClass();

 

         //! Charset for HTML output and for storing data in memory

-        $this->file->character_set_client = 'UTF-8';   // UTF-8, ISO-8859-1

+        $this->file->character_set_client = 'UTF-8'; // UTF-8, ISO-8859-1

         // First level object

         // TODO Remove this part.

         $this->expedition_bon = new \stdClass();

@@ -113,13 +113,13 @@ 
     {

         global $conf;

 

-        dol_syslog(get_class($this) . "::setValues");

+        dol_syslog(get_class($this)."::setValues");

 

         //Define all global constants into $this->global->key=value

-        $sql = "SELECT " . $db->decrypt('name') . " as name,";

-        $sql .= " " . $db->decrypt('value') . " as value, entity";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "const";

-        $sql .= " WHERE entity IN (0," . $this->entity . ")";

+        $sql = "SELECT ".$db->decrypt('name')." as name,";

+        $sql .= " ".$db->decrypt('value')." as value, entity";

+        $sql .= " FROM ".MAIN_DB_PREFIX."const";

+        $sql .= " WHERE entity IN (0,".$this->entity.")";

         $sql .= " ORDER BY entity"; // This is to have entity 0 first, then entity 1 that overwrite.

 

         $resql = $db->query($sql);

@@ -159,13 +159,13 @@ 
                             if (is_array($arrValue) && !empty($arrValue))

                                 $value = $arrValue;

                             else if (in_array($partname, array('login', 'menus', 'substitutions', 'triggers', 'tpl')))

-                                $value = '/' . $modulename . '/core/' . $partname . '/';

+                                $value = '/'.$modulename.'/core/'.$partname.'/';

                             else if (in_array($partname, array('models', 'theme')))

-                                $value = '/' . $modulename . '/';

+                                $value = '/'.$modulename.'/';

                             else if (in_array($partname, array('sms')))

-                                $value = '/' . $modulename . '/';

+                                $value = '/'.$modulename.'/';

                             else if ($value == 1)

-                                $value = '/' . $modulename . '/core/modules/' . $partname . '/'; // ex: partname = societe

+                                $value = '/'.$modulename.'/core/modules/'.$partname.'/'; // ex: partname = societe

                             $this->modules_parts[$partname] = array_merge($this->modules_parts[$partname], array($modulename => $value)); // $value may be a string or an array

                         }

                         // If this is a module constant (must be at end)

@@ -178,7 +178,7 @@ 
                             if (!isset($this->$modulename) || !is_object($this->$modulename))

                                 $this->$modulename = new \stdClass();

                             $this->$modulename->enabled = true;

-                            $this->modules[] = $modulename;              // Add this module in list of enabled modules

+                            $this->modules[] = $modulename; // Add this module in list of enabled modules

                         }

                     }

                 }

@@ -193,7 +193,7 @@ 
             $filesList = explode(":", $this->global->LOCAL_CONSTS_FILES);

             foreach ($filesList as $file) {

                 $file = dol_sanitizeFileName($file);

-                include_once DOL_DOCUMENT_ROOT . "/" . $file . "/" . $file . "_consts.php";

+                include_once DOL_DOCUMENT_ROOT."/".$file."/".$file."_consts.php";

                 foreach ($file2bddconsts as $key => $value) {

                     $this->global->$key = $value;

                 }

@@ -209,7 +209,7 @@ 
             try {

                 date_default_timezone_set($this->global->MAIN_SERVER_TZ);

             } catch (Exception $e) {

-                dol_syslog("Error: Bad value for parameter MAIN_SERVER_TZ=" . $this->global->MAIN_SERVER_TZ, LOG_ERR);

+                dol_syslog("Error: Bad value for parameter MAIN_SERVER_TZ=".$this->global->MAIN_SERVER_TZ, LOG_ERR);

             }

         }

 

@@ -269,18 +269,18 @@ 
         $rootforuser = DOL_DATA_ROOT;

         // If multicompany module is enabled, we redefine the root of data

         if (!empty($this->multicompany->enabled) && !empty($this->entity) && $this->entity > 1) {

-            $rootfordata .= '/' . $this->entity;

+            $rootfordata .= '/'.$this->entity;

         }

 

         // Define default dir_output and dir_temp for directories of modules

         foreach ($this->modules as $module) {

             //var_dump($module);

             // For multicompany sharings

-            $this->$module->multidir_output = array($this->entity => $rootfordata . "/" . $module);

-            $this->$module->multidir_temp = array($this->entity => $rootfordata . "/" . $module . "/temp");

+            $this->$module->multidir_output = array($this->entity => $rootfordata."/".$module);

+            $this->$module->multidir_temp = array($this->entity => $rootfordata."/".$module."/temp");

             // For backward compatibility

-            $this->$module->dir_output = $rootfordata . "/" . $module;

-            $this->$module->dir_temp = $rootfordata . "/" . $module . "/temp";

+            $this->$module->dir_output = $rootfordata."/".$module;

+            $this->$module->dir_temp = $rootfordata."/".$module."/temp";

         }

 

         // External modules storage

@@ -290,45 +290,45 @@ 
                     foreach ($dirs as $type => $name) {

                         $subdir = ($type == 'temp' ? '/temp' : '');

                         // For multicompany sharings

-                        $varname = 'multidir_' . $type;

-                        $this->$module->$varname = array($this->entity => $rootfordata . "/" . $name . $subdir);

+                        $varname = 'multidir_'.$type;

+                        $this->$module->$varname = array($this->entity => $rootfordata."/".$name.$subdir);

                         // For backward compatibility

-                        $varname = 'dir_' . $type;

-                        $this->$module->$varname = $rootfordata . "/" . $name . $subdir;

+                        $varname = 'dir_'.$type;

+                        $this->$module->$varname = $rootfordata."/".$name.$subdir;

                     }

                 }

             }

         }

 

         // For mycompany storage

-        $this->mycompany->dir_output = $rootfordata . "/mycompany";

-        $this->mycompany->dir_temp = $rootfordata . "/mycompany/temp";

+        $this->mycompany->dir_output = $rootfordata."/mycompany";

+        $this->mycompany->dir_temp = $rootfordata."/mycompany/temp";

 

         // For admin storage

-        $this->admin->dir_output = $rootfordata . '/admin';

-        $this->admin->dir_temp = $rootfordata . '/admin/temp';

+        $this->admin->dir_output = $rootfordata.'/admin';

+        $this->admin->dir_temp = $rootfordata.'/admin/temp';

 

         // For user storage

-        $this->user->multidir_output = array($this->entity => $rootfordata . "/users");

-        $this->user->multidir_temp = array($this->entity => $rootfordata . "/users/temp");

+        $this->user->multidir_output = array($this->entity => $rootfordata."/users");

+        $this->user->multidir_temp = array($this->entity => $rootfordata."/users/temp");

         // For backward compatibility

-        $this->user->dir_output = $rootforuser . "/users";

-        $this->user->dir_temp = $rootforuser . "/users/temp";

+        $this->user->dir_output = $rootforuser."/users";

+        $this->user->dir_temp = $rootforuser."/users/temp";

 

         // For usergroup storage

-        $this->usergroup->dir_output = $rootforuser . "/usergroups";

-        $this->usergroup->dir_temp = $rootforuser . "/usergroups/temp";

+        $this->usergroup->dir_output = $rootforuser."/usergroups";

+        $this->usergroup->dir_temp = $rootforuser."/usergroups/temp";

 

         // For proposal storage

-        $this->propal->multidir_output = array($this->entity => $rootfordata . "/propale");

-        $this->propal->multidir_temp = array($this->entity => $rootfordata . "/propale/temp");

+        $this->propal->multidir_output = array($this->entity => $rootfordata."/propale");

+        $this->propal->multidir_temp = array($this->entity => $rootfordata."/propale/temp");

         // For backward compatibility

-        $this->propal->dir_output = $rootfordata . "/propale";

-        $this->propal->dir_temp = $rootfordata . "/propale/temp";

+        $this->propal->dir_output = $rootfordata."/propale";

+        $this->propal->dir_temp = $rootfordata."/propale/temp";

 

         // For medias storage

-        $this->medias->multidir_output = array($this->entity => $rootfordata . "/medias");

-        $this->medias->multidir_temp = array($this->entity => $rootfordata . "/medias/temp");

+        $this->medias->multidir_output = array($this->entity => $rootfordata."/medias");

+        $this->medias->multidir_temp = array($this->entity => $rootfordata."/medias/temp");

 

         // Exception: Some dir are not the name of module. So we keep exception here for backward compatibility.

         // Sous module bons d'expedition

@@ -339,72 +339,72 @@ 
         // Module fournisseur

         if (!empty($this->fournisseur)) {

             $this->fournisseur->commande = new \stdClass();

-            $this->fournisseur->commande->multidir_output = array($this->entity => $rootfordata . "/fournisseur/commande");

-            $this->fournisseur->commande->multidir_temp = array($this->entity => $rootfordata . "/fournisseur/commande/temp");

-            $this->fournisseur->commande->dir_output = $rootfordata . "/fournisseur/commande";  // For backward compatibility

-            $this->fournisseur->commande->dir_temp = $rootfordata . "/fournisseur/commande/temp"; // For backward compatibility

+            $this->fournisseur->commande->multidir_output = array($this->entity => $rootfordata."/fournisseur/commande");

+            $this->fournisseur->commande->multidir_temp = array($this->entity => $rootfordata."/fournisseur/commande/temp");

+            $this->fournisseur->commande->dir_output = $rootfordata."/fournisseur/commande"; // For backward compatibility

+            $this->fournisseur->commande->dir_temp = $rootfordata."/fournisseur/commande/temp"; // For backward compatibility

             $this->fournisseur->facture = new \stdClass();

-            $this->fournisseur->facture->multidir_output = array($this->entity => $rootfordata . "/fournisseur/facture");

-            $this->fournisseur->facture->multidir_temp = array($this->entity => $rootfordata . "/fournisseur/facture/temp");

-            $this->fournisseur->facture->dir_output = $rootfordata . "/fournisseur/facture";  // For backward compatibility

-            $this->fournisseur->facture->dir_temp = $rootfordata . "/fournisseur/facture/temp"; // For backward compatibility

+            $this->fournisseur->facture->multidir_output = array($this->entity => $rootfordata."/fournisseur/facture");

+            $this->fournisseur->facture->multidir_temp = array($this->entity => $rootfordata."/fournisseur/facture/temp");

+            $this->fournisseur->facture->dir_output = $rootfordata."/fournisseur/facture"; // For backward compatibility

+            $this->fournisseur->facture->dir_temp = $rootfordata."/fournisseur/facture/temp"; // For backward compatibility

             $this->supplierproposal = new \stdClass();

-            $this->supplierproposal->multidir_output = array($this->entity => $rootfordata . "/supplier_proposal");

-            $this->supplierproposal->multidir_temp = array($this->entity => $rootfordata . "/supplier_proposal/temp");

-            $this->supplierproposal->dir_output = $rootfordata . "/supplier_proposal";    // For backward compatibility

-            $this->supplierproposal->dir_temp = $rootfordata . "/supplier_proposal/temp";   // For backward compatibility

+            $this->supplierproposal->multidir_output = array($this->entity => $rootfordata."/supplier_proposal");

+            $this->supplierproposal->multidir_temp = array($this->entity => $rootfordata."/supplier_proposal/temp");

+            $this->supplierproposal->dir_output = $rootfordata."/supplier_proposal"; // For backward compatibility

+            $this->supplierproposal->dir_temp = $rootfordata."/supplier_proposal/temp"; // For backward compatibility

             $this->fournisseur->payment = new \stdClass();

-            $this->fournisseur->payment->multidir_output = array($this->entity => $rootfordata . "/fournisseur/payment");

-            $this->fournisseur->payment->multidir_temp = array($this->entity => $rootfordata . "/fournisseur/payment/temp");

-            $this->fournisseur->payment->dir_output = $rootfordata . "/fournisseur/payment";  // For backward compatibility

-            $this->fournisseur->payment->dir_temp = $rootfordata . "/fournisseur/payment/temp"; // For backward compatibility

+            $this->fournisseur->payment->multidir_output = array($this->entity => $rootfordata."/fournisseur/payment");

+            $this->fournisseur->payment->multidir_temp = array($this->entity => $rootfordata."/fournisseur/payment/temp");

+            $this->fournisseur->payment->dir_output = $rootfordata."/fournisseur/payment"; // For backward compatibility

+            $this->fournisseur->payment->dir_temp = $rootfordata."/fournisseur/payment/temp"; // For backward compatibility

             // To prepare split of module fournisseur into fournisseur + supplier_order + supplier_invoice

             if (!empty($this->fournisseur->enabled) && empty($this->global->MAIN_USE_NEW_SUPPLIERMOD)) {  // By default, if module supplier is on, we set new properties

                 $this->supplier_order = new \stdClass();

                 $this->supplier_order->enabled = 1;

-                $this->supplier_order->multidir_output = array($this->entity => $rootfordata . "/fournisseur/commande");

-                $this->supplier_order->multidir_temp = array($this->entity => $rootfordata . "/fournisseur/commande/temp");

-                $this->supplier_order->dir_output = $rootfordata . "/fournisseur/commande";   // For backward compatibility

-                $this->supplier_order->dir_temp = $rootfordata . "/fournisseur/commande/temp";  // For backward compatibility

+                $this->supplier_order->multidir_output = array($this->entity => $rootfordata."/fournisseur/commande");

+                $this->supplier_order->multidir_temp = array($this->entity => $rootfordata."/fournisseur/commande/temp");

+                $this->supplier_order->dir_output = $rootfordata."/fournisseur/commande"; // For backward compatibility

+                $this->supplier_order->dir_temp = $rootfordata."/fournisseur/commande/temp"; // For backward compatibility

                 $this->supplier_invoice = new \stdClass();

                 $this->supplier_invoice->enabled = 1;

-                $this->supplier_invoice->multidir_output = array($this->entity => $rootfordata . "/fournisseur/facture");

-                $this->supplier_invoice->multidir_temp = array($this->entity => $rootfordata . "/fournisseur/facture/temp");

-                $this->supplier_invoice->dir_output = $rootfordata . "/fournisseur/facture";  // For backward compatibility

-                $this->supplier_invoice->dir_temp = $rootfordata . "/fournisseur/facture/temp";  // For backward compatibility

+                $this->supplier_invoice->multidir_output = array($this->entity => $rootfordata."/fournisseur/facture");

+                $this->supplier_invoice->multidir_temp = array($this->entity => $rootfordata."/fournisseur/facture/temp");

+                $this->supplier_invoice->dir_output = $rootfordata."/fournisseur/facture"; // For backward compatibility

+                $this->supplier_invoice->dir_temp = $rootfordata."/fournisseur/facture/temp"; // For backward compatibility

                 $this->supplierproposal = new \stdClass();

-                $this->supplierproposal->multidir_output = array($this->entity => $rootfordata . "/supplier_proposal");

-                $this->supplierproposal->multidir_temp = array($this->entity => $rootfordata . "/supplier_proposal/temp");

-                $this->supplierproposal->dir_output = $rootfordata . "/supplier_proposal";   // For backward compatibility

-                $this->supplierproposal->dir_temp = $rootfordata . "/supplier_proposal/temp";  // For backward compatibility

+                $this->supplierproposal->multidir_output = array($this->entity => $rootfordata."/supplier_proposal");

+                $this->supplierproposal->multidir_temp = array($this->entity => $rootfordata."/supplier_proposal/temp");

+                $this->supplierproposal->dir_output = $rootfordata."/supplier_proposal"; // For backward compatibility

+                $this->supplierproposal->dir_temp = $rootfordata."/supplier_proposal/temp"; // For backward compatibility

             }

         }

 

         // Module product/service

-        $this->product->multidir_output = array($this->entity => $rootfordata . "/produit");

-        $this->product->multidir_temp = array($this->entity => $rootfordata . "/produit/temp");

-        $this->service->multidir_output = array($this->entity => $rootfordata . "/produit");

-        $this->service->multidir_temp = array($this->entity => $rootfordata . "/produit/temp");

+        $this->product->multidir_output = array($this->entity => $rootfordata."/produit");

+        $this->product->multidir_temp = array($this->entity => $rootfordata."/produit/temp");

+        $this->service->multidir_output = array($this->entity => $rootfordata."/produit");

+        $this->service->multidir_temp = array($this->entity => $rootfordata."/produit/temp");

         // For backward compatibility

-        $this->product->dir_output = $rootfordata . "/produit";

-        $this->product->dir_temp = $rootfordata . "/produit/temp";

-        $this->service->dir_output = $rootfordata . "/produit";

-        $this->service->dir_temp = $rootfordata . "/produit/temp";

+        $this->product->dir_output = $rootfordata."/produit";

+        $this->product->dir_temp = $rootfordata."/produit/temp";

+        $this->service->dir_output = $rootfordata."/produit";

+        $this->service->dir_temp = $rootfordata."/produit/temp";

 

         // Module productbatch

-        $this->productbatch->multidir_output = array($this->entity => $rootfordata . "/produitlot");

-        $this->productbatch->multidir_temp = array($this->entity => $rootfordata . "/produitlot/temp");

+        $this->productbatch->multidir_output = array($this->entity => $rootfordata."/produitlot");

+        $this->productbatch->multidir_temp = array($this->entity => $rootfordata."/produitlot/temp");

 

         // Module contrat

-        $this->contrat->multidir_output = array($this->entity => $rootfordata . "/contract");

-        $this->contrat->multidir_temp = array($this->entity => $rootfordata . "/contract/temp");

+        $this->contrat->multidir_output = array($this->entity => $rootfordata."/contract");

+        $this->contrat->multidir_temp = array($this->entity => $rootfordata."/contract/temp");

         // For backward compatibility

-        $this->contrat->dir_output = $rootfordata . "/contract";

-        $this->contrat->dir_temp = $rootfordata . "/contract/temp";

+        $this->contrat->dir_output = $rootfordata."/contract";

+        $this->contrat->dir_temp = $rootfordata."/contract/temp";

 

         // Module bank

-        $this->bank->dir_output = $rootfordata . "/bank";

-        $this->bank->dir_temp = $rootfordata . "/bank/temp";

+        $this->bank->dir_output = $rootfordata."/bank";

+        $this->bank->dir_temp = $rootfordata."/bank/temp";

 

 

         // Set some default values

@@ -427,7 +427,7 @@ 
         if (empty($this->global->USER_PASSWORD_GENERATED))

             $this->global->USER_PASSWORD_GENERATED = 'standard'; // Default password generator

         if (empty($this->global->MAIN_UMASK))

-            $this->global->MAIN_UMASK = '0664';         // Default mask

+            $this->global->MAIN_UMASK = '0664'; // Default mask

 

 

 

@@ -466,7 +466,7 @@ 
         $this->currency = $this->global->MAIN_MONNAIE;

 

         if (empty($this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY))

-            $this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY = 30;   // Less than 1 minutes to be sure

+            $this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY = 30; // Less than 1 minutes to be sure

 

 

 

@@ -474,7 +474,7 @@ 
             

 // conf->global->ACCOUNTING_MODE = Option des modules Comptabilites (simple ou expert). Defini le mode de calcul des etats comptables (CA,...)

         if (empty($this->global->ACCOUNTING_MODE))

-            $this->global->ACCOUNTING_MODE = 'RECETTES-DEPENSES';  // By default. Can be 'RECETTES-DEPENSES' ou 'CREANCES-DETTES'

+            $this->global->ACCOUNTING_MODE = 'RECETTES-DEPENSES'; // By default. Can be 'RECETTES-DEPENSES' ou 'CREANCES-DETTES'

 

 

 

@@ -504,7 +504,7 @@ 
             $this->global->MAIN_THEME = $this->global->MAIN_FORCETHEME;

         $this->theme = $this->global->MAIN_THEME;

         //$this->css  = "/theme/".$this->theme."/style.css.php";

-        $this->css = '?controller=theme/' . $this->theme . '&method=style.css';

+        $this->css = '?controller=theme/'.$this->theme.'&method=style.css';

 

         // conf->email_from = email pour envoi par dolibarr des mails automatiques

         $this->email_from = "robot@example.com";

@@ -524,8 +524,8 @@ 
             $this->global->MAIN_EMAIL_ADD_TRACK_ID = 1;

 

         // Format for date (used by default when not found or not searched in lang)

-        $this->format_date_short = "%d/%m/%Y";            // Format of day with PHP/C tags (strftime functions)

-        $this->format_date_short_java = "dd/MM/yyyy";     // Format of day with Java tags

+        $this->format_date_short = "%d/%m/%Y"; // Format of day with PHP/C tags (strftime functions)

+        $this->format_date_short_java = "dd/MM/yyyy"; // Format of day with Java tags

         $this->format_hour_short = "%H:%M";

         $this->format_hour_short_duration = "%H:%M";

         $this->format_date_text_short = "%d %b %Y";

@@ -549,9 +549,9 @@ 
 

         // Default pdf option

         if (!isset($this->global->MAIN_PDF_DASH_BETWEEN_LINES))

-            $this->global->MAIN_PDF_DASH_BETWEEN_LINES = 1;    // use dash between lines

+            $this->global->MAIN_PDF_DASH_BETWEEN_LINES = 1; // use dash between lines

         if (!isset($this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT))

-            $this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT = 1;  // allow html content into free footer text

+            $this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT = 1; // allow html content into free footer text

 

 

 

@@ -566,7 +566,7 @@ 
 

         // By default, we propagate contacts

         if (!isset($this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN))

-            $this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN = '*';  // Can be also '*' or '^(BILLING|SHIPPING|CUSTOMER|.*)$' (regex not yet implemented)

+            $this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN = '*'; // Can be also '*' or '^(BILLING|SHIPPING|CUSTOMER|.*)$' (regex not yet implemented)

 

 

 

@@ -589,7 +589,7 @@ 
             $this->global->MAIN_MODULES_FOR_EXTERNAL = 'user,societe,propal,commande,facture,categorie,supplierproposal,fournisseur,contact,projet,contrat,ficheinter,expedition,agenda,resource,adherent,blockedlog'; // '' means 'all'. Note that contact is added here as it should be a module later.

         if (!empty($this->modules_parts['moduleforexternal'])) {  // Module part to include an external module into the MAIN_MODULES_FOR_EXTERNAL list

             foreach ($this->modules_parts['moduleforexternal'] as $key => $value)

-                $this->global->MAIN_MODULES_FOR_EXTERNAL .= "," . $key;

+                $this->global->MAIN_MODULES_FOR_EXTERNAL .= ",".$key;

         }

 

         // Enable select2

@@ -682,7 +682,7 @@ 
 

         // Save inconsistent option

         if (empty($this->global->AGENDA_USE_EVENT_TYPE) && (!isset($this->global->AGENDA_DEFAULT_FILTER_TYPE) || $this->global->AGENDA_DEFAULT_FILTER_TYPE == 'AC_NON_AUTO')) {

-            $this->global->AGENDA_DEFAULT_FILTER_TYPE = '0';    // 'AC_NON_AUTO' does not exists when AGENDA_DEFAULT_FILTER_TYPE is not on.

+            $this->global->AGENDA_DEFAULT_FILTER_TYPE = '0'; // 'AC_NON_AUTO' does not exists when AGENDA_DEFAULT_FILTER_TYPE is not on.

         }

 

         if (!isset($this->global->MAIN_EXTRAFIELDS_IN_ONE_TD))

@@ -723,7 +723,7 @@ 
                 $dir = dol_buildpath($reldir, 0);

                 $newdir = dol_osencode($dir);

                 if (is_dir($newdir)) {

-                    $file = $newdir . $handler . '.php';

+                    $file = $newdir.$handler.'.php';

                     if (file_exists($file)) {

                         $handler_files[] = $file;

                     }

@@ -731,7 +731,7 @@ 
             }

 

             if (empty($handler_files)) {

-                throw new Exception('Missing log handler file ' . $handler . '.php');

+                throw new Exception('Missing log handler file '.$handler.'.php');

             }

 

             require_once $handler_files[0];

Braces +229 added lines, -151 removed lines

@@ -156,27 +156,32 @@ 
                                 $this->modules_parts[$partname] = array();

                             }

                             $arrValue = json_decode($value, true);

-                            if (is_array($arrValue) && !empty($arrValue))

-                                $value = $arrValue;

-                            else if (in_array($partname, array('login', 'menus', 'substitutions', 'triggers', 'tpl')))

-                                $value = '/' . $modulename . '/core/' . $partname . '/';

-                            else if (in_array($partname, array('models', 'theme')))

-                                $value = '/' . $modulename . '/';

-                            else if (in_array($partname, array('sms')))

-                                $value = '/' . $modulename . '/';

-                            else if ($value == 1)

-                                $value = '/' . $modulename . '/core/modules/' . $partname . '/'; // ex: partname = societe

+                            if (is_array($arrValue) && !empty($arrValue)) {
+                                                            $value = $arrValue;
+                            } else if (in_array($partname, array('login', 'menus', 'substitutions', 'triggers', 'tpl'))) {
+                                                            $value = '/' . $modulename . '/core/' . $partname . '/';
+                            } else if (in_array($partname, array('models', 'theme'))) {
+                                                            $value = '/' . $modulename . '/';
+                            } else if (in_array($partname, array('sms'))) {
+                                                            $value = '/' . $modulename . '/';
+                            } else if ($value == 1) {
+                                                            $value = '/' . $modulename . '/core/modules/' . $partname . '/';
+                            }
+                            // ex: partname = societe

                             $this->modules_parts[$partname] = array_merge($this->modules_parts[$partname], array($modulename => $value)); // $value may be a string or an array

                         }

                         // If this is a module constant (must be at end)

                         elseif (preg_match('/^MAIN_MODULE_([0-9A-Z_]+)$/i', $key, $reg)) {

                             $modulename = strtolower($reg[1]);

-                            if ($modulename == 'propale')

-                                $modulename = 'propal';

-                            if ($modulename == 'supplierproposal')

-                                $modulename = 'supplier_proposal';

-                            if (!isset($this->$modulename) || !is_object($this->$modulename))

-                                $this->$modulename = new \stdClass();

+                            if ($modulename == 'propale') {
+                                                            $modulename = 'propal';
+                            }
+                            if ($modulename == 'supplierproposal') {
+                                                            $modulename = 'supplier_proposal';
+                            }
+                            if (!isset($this->$modulename) || !is_object($this->$modulename)) {
+                                                            $this->$modulename = new \stdClass();
+                            }
                             $this->$modulename->enabled = true;

                             $this->modules[] = $modulename;              // Add this module in list of enabled modules

                         }

@@ -224,46 +229,60 @@ 
         }

 

         // Clean some variables

-        if (empty($this->global->MAIN_MENU_STANDARD))

-            $this->global->MAIN_MENU_STANDARD = "eldy_menu.php";

-        if (empty($this->global->MAIN_MENUFRONT_STANDARD))

-            $this->global->MAIN_MENUFRONT_STANDARD = "eldy_menu.php";

-        if (empty($this->global->MAIN_MENU_SMARTPHONE))

-            $this->global->MAIN_MENU_SMARTPHONE = "eldy_menu.php"; // Use eldy by default because smartphone does not work on all phones

-        if (empty($this->global->MAIN_MENUFRONT_SMARTPHONE))

-            $this->global->MAIN_MENUFRONT_SMARTPHONE = "eldy_menu.php"; // Use eldy by default because smartphone does not work on all phones

+        if (empty($this->global->MAIN_MENU_STANDARD)) {
+                    $this->global->MAIN_MENU_STANDARD = "eldy_menu.php";
+        }
+        if (empty($this->global->MAIN_MENUFRONT_STANDARD)) {
+                    $this->global->MAIN_MENUFRONT_STANDARD = "eldy_menu.php";
+        }
+        if (empty($this->global->MAIN_MENU_SMARTPHONE)) {
+                    $this->global->MAIN_MENU_SMARTPHONE = "eldy_menu.php";
+        }
+        // Use eldy by default because smartphone does not work on all phones

+        if (empty($this->global->MAIN_MENUFRONT_SMARTPHONE)) {
+                    $this->global->MAIN_MENUFRONT_SMARTPHONE = "eldy_menu.php";
+        }
+        // Use eldy by default because smartphone does not work on all phones

 

 

 

             

 // Clean var use vat for company

-        if (!isset($this->global->FACTURE_TVAOPTION))

-            $this->global->FACTURE_TVAOPTION = 1;

-        else if (!empty($this->global->FACTURE_TVAOPTION) && !is_numeric($this->global->FACTURE_TVAOPTION)) {

+        if (!isset($this->global->FACTURE_TVAOPTION)) {
+                    $this->global->FACTURE_TVAOPTION = 1;
+        } else if (!empty($this->global->FACTURE_TVAOPTION) && !is_numeric($this->global->FACTURE_TVAOPTION)) {

             // Old value of option, we clean to use new value (0 or 1)

-            if ($this->global->FACTURE_TVAOPTION != "franchise")

-                $this->global->FACTURE_TVAOPTION = 1;

-            else

-                $this->global->FACTURE_TVAOPTION = 0;

+            if ($this->global->FACTURE_TVAOPTION != "franchise") {
+                            $this->global->FACTURE_TVAOPTION = 1;
+            } else {
+                            $this->global->FACTURE_TVAOPTION = 0;
+            }
         }

 

         // Variable globales LDAP

-        if (empty($this->global->LDAP_FIELD_FULLNAME))

-            $this->global->LDAP_FIELD_FULLNAME = '';

-        if (!isset($this->global->LDAP_KEY_USERS))

-            $this->global->LDAP_KEY_USERS = $this->global->LDAP_FIELD_FULLNAME;

-        if (!isset($this->global->LDAP_KEY_GROUPS))

-            $this->global->LDAP_KEY_GROUPS = $this->global->LDAP_FIELD_FULLNAME;

-        if (!isset($this->global->LDAP_KEY_CONTACTS))

-            $this->global->LDAP_KEY_CONTACTS = $this->global->LDAP_FIELD_FULLNAME;

-        if (!isset($this->global->LDAP_KEY_MEMBERS))

-            $this->global->LDAP_KEY_MEMBERS = $this->global->LDAP_FIELD_FULLNAME;

-        if (!isset($this->global->LDAP_KEY_MEMBERS_TYPES))

-            $this->global->LDAP_KEY_MEMBERS_TYPES = $this->global->LDAP_FIELD_FULLNAME;

+        if (empty($this->global->LDAP_FIELD_FULLNAME)) {
+                    $this->global->LDAP_FIELD_FULLNAME = '';
+        }
+        if (!isset($this->global->LDAP_KEY_USERS)) {
+                    $this->global->LDAP_KEY_USERS = $this->global->LDAP_FIELD_FULLNAME;
+        }
+        if (!isset($this->global->LDAP_KEY_GROUPS)) {
+                    $this->global->LDAP_KEY_GROUPS = $this->global->LDAP_FIELD_FULLNAME;
+        }
+        if (!isset($this->global->LDAP_KEY_CONTACTS)) {
+                    $this->global->LDAP_KEY_CONTACTS = $this->global->LDAP_FIELD_FULLNAME;
+        }
+        if (!isset($this->global->LDAP_KEY_MEMBERS)) {
+                    $this->global->LDAP_KEY_MEMBERS = $this->global->LDAP_FIELD_FULLNAME;
+        }
+        if (!isset($this->global->LDAP_KEY_MEMBERS_TYPES)) {
+                    $this->global->LDAP_KEY_MEMBERS_TYPES = $this->global->LDAP_FIELD_FULLNAME;
+        }
 

         // Load translation object with current language

-        if (empty($this->global->MAIN_LANG_DEFAULT))

-            $this->global->MAIN_LANG_DEFAULT = "en_US";

+        if (empty($this->global->MAIN_LANG_DEFAULT)) {
+                    $this->global->MAIN_LANG_DEFAULT = "en_US";
+        }
 

         $rootfordata = DOL_DATA_ROOT;

         $rootforuser = DOL_DATA_ROOT;

@@ -413,21 +432,29 @@ 
         $this->global->MAIN_MAIL_USE_MULTI_PART = 1;

 

         // societe

-        if (empty($this->global->SOCIETE_CODECLIENT_ADDON))

-            $this->global->SOCIETE_CODECLIENT_ADDON = "mod_codeclient_leopard";

-        if (empty($this->global->SOCIETE_CODECOMPTA_ADDON))

-            $this->global->SOCIETE_CODECOMPTA_ADDON = "mod_codecompta_panicum";

-

-        if (empty($this->global->CHEQUERECEIPTS_ADDON))

-            $this->global->CHEQUERECEIPTS_ADDON = 'mod_chequereceipt_mint';

-        if (empty($conf->global->TICKETSUP_ADDON))

-            $this->global->TICKETSUP_ADDON = 'mod_ticket_simple';

+        if (empty($this->global->SOCIETE_CODECLIENT_ADDON)) {
+                    $this->global->SOCIETE_CODECLIENT_ADDON = "mod_codeclient_leopard";
+        }
+        if (empty($this->global->SOCIETE_CODECOMPTA_ADDON)) {
+                    $this->global->SOCIETE_CODECOMPTA_ADDON = "mod_codecompta_panicum";
+        }
+

+        if (empty($this->global->CHEQUERECEIPTS_ADDON)) {
+                    $this->global->CHEQUERECEIPTS_ADDON = 'mod_chequereceipt_mint';
+        }
+        if (empty($conf->global->TICKETSUP_ADDON)) {
+                    $this->global->TICKETSUP_ADDON = 'mod_ticket_simple';
+        }
 

         // Security

-        if (empty($this->global->USER_PASSWORD_GENERATED))

-            $this->global->USER_PASSWORD_GENERATED = 'standard'; // Default password generator

-        if (empty($this->global->MAIN_UMASK))

-            $this->global->MAIN_UMASK = '0664';         // Default mask

+        if (empty($this->global->USER_PASSWORD_GENERATED)) {
+                    $this->global->USER_PASSWORD_GENERATED = 'standard';
+        }
+        // Default password generator

+        if (empty($this->global->MAIN_UMASK)) {
+                    $this->global->MAIN_UMASK = '0664';
+        }
+        // Default mask

 

 

 

@@ -435,8 +462,9 @@ 
             

 // conf->use_javascript_ajax

         $this->use_javascript_ajax = 1;

-        if (isset($this->global->MAIN_DISABLE_JAVASCRIPT))

-            $this->use_javascript_ajax = !$this->global->MAIN_DISABLE_JAVASCRIPT;

+        if (isset($this->global->MAIN_DISABLE_JAVASCRIPT)) {
+                    $this->use_javascript_ajax = !$this->global->MAIN_DISABLE_JAVASCRIPT;
+        }
         // If no javascript_ajax, Ajax features are disabled.

         if (empty($this->use_javascript_ajax)) {

             unset($this->global->PRODUIT_USE_SEARCH_TO_SELECT);

@@ -452,29 +480,34 @@ 
             $this->global->STOCK_CALCULATE_ON_SHIPMENT_CLOSE = 0;

             $this->global->STOCK_CALCULATE_ON_SUPPLIER_BILL = 0;

             $this->global->STOCK_CALCULATE_ON_SUPPLIER_VALIDATE_ORDER = 0;

-            if (empty($this->reception->enabled))

-                $this->global->STOCK_CALCULATE_ON_SUPPLIER_DISPATCH_ORDER = 1;

-            else {

+            if (empty($this->reception->enabled)) {
+                            $this->global->STOCK_CALCULATE_ON_SUPPLIER_DISPATCH_ORDER = 1;
+            } else {

                 $this->global->STOCK_CALCULATE_ON_RECEPTION = 1;

                 $this->global->STOCK_CALCULATE_ON_RECEPTION_CLOSE = 0;

             }

         }

 

         // conf->currency

-        if (empty($this->global->MAIN_MONNAIE))

-            $this->global->MAIN_MONNAIE = 'EUR';

+        if (empty($this->global->MAIN_MONNAIE)) {
+                    $this->global->MAIN_MONNAIE = 'EUR';
+        }
         $this->currency = $this->global->MAIN_MONNAIE;

 

-        if (empty($this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY))

-            $this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY = 30;   // Less than 1 minutes to be sure

+        if (empty($this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY)) {
+                    $this->global->MAIN_BROWSER_NOTIFICATION_FREQUENCY = 30;
+        }
+        // Less than 1 minutes to be sure

 

 

 

 

             

 // conf->global->ACCOUNTING_MODE = Option des modules Comptabilites (simple ou expert). Defini le mode de calcul des etats comptables (CA,...)

-        if (empty($this->global->ACCOUNTING_MODE))

-            $this->global->ACCOUNTING_MODE = 'RECETTES-DEPENSES';  // By default. Can be 'RECETTES-DEPENSES' ou 'CREANCES-DETTES'

+        if (empty($this->global->ACCOUNTING_MODE)) {
+                    $this->global->ACCOUNTING_MODE = 'RECETTES-DEPENSES';
+        }
+        // By default. Can be 'RECETTES-DEPENSES' ou 'CREANCES-DETTES'

 

 

 

@@ -484,44 +517,53 @@ 
         $this->global->PROJECT_CAN_ALWAYS_LINK_TO_ALL_SUPPLIERS = 1;

 

         // MAIN_HTML_TITLE

-        if (!isset($this->global->MAIN_HTML_TITLE))

-            $this->global->MAIN_HTML_TITLE = 'noapp,thirdpartynameonly,contactnameonly,projectnameonly';

+        if (!isset($this->global->MAIN_HTML_TITLE)) {
+                    $this->global->MAIN_HTML_TITLE = 'noapp,thirdpartynameonly,contactnameonly,projectnameonly';
+        }
 

         // conf->liste_limit = constante de taille maximale des listes

-        if (empty($this->global->MAIN_SIZE_LISTE_LIMIT))

-            $this->global->MAIN_SIZE_LISTE_LIMIT = 25;

+        if (empty($this->global->MAIN_SIZE_LISTE_LIMIT)) {
+                    $this->global->MAIN_SIZE_LISTE_LIMIT = 25;
+        }
         $this->liste_limit = $this->global->MAIN_SIZE_LISTE_LIMIT;

 

         // conf->product->limit_size = constante de taille maximale des select de produit

-        if (!isset($this->global->PRODUIT_LIMIT_SIZE))

-            $this->global->PRODUIT_LIMIT_SIZE = 1000;

+        if (!isset($this->global->PRODUIT_LIMIT_SIZE)) {
+                    $this->global->PRODUIT_LIMIT_SIZE = 1000;
+        }
         $this->product->limit_size = $this->global->PRODUIT_LIMIT_SIZE;

 

         // conf->theme et $this->css

-        if (empty($this->global->MAIN_THEME))

-            $this->global->MAIN_THEME = "eldy";

-        if (!empty($this->global->MAIN_FORCETHEME))

-            $this->global->MAIN_THEME = $this->global->MAIN_FORCETHEME;

+        if (empty($this->global->MAIN_THEME)) {
+                    $this->global->MAIN_THEME = "eldy";
+        }
+        if (!empty($this->global->MAIN_FORCETHEME)) {
+                    $this->global->MAIN_THEME = $this->global->MAIN_FORCETHEME;
+        }
         $this->theme = $this->global->MAIN_THEME;

         //$this->css  = "/theme/".$this->theme."/style.css.php";

         $this->css = '?controller=theme/' . $this->theme . '&method=style.css';

 

         // conf->email_from = email pour envoi par dolibarr des mails automatiques

         $this->email_from = "robot@example.com";

-        if (!empty($this->global->MAIN_MAIL_EMAIL_FROM))

-            $this->email_from = $this->global->MAIN_MAIL_EMAIL_FROM;

+        if (!empty($this->global->MAIN_MAIL_EMAIL_FROM)) {
+                    $this->email_from = $this->global->MAIN_MAIL_EMAIL_FROM;
+        }
 

         // conf->notification->email_from = email pour envoi par Dolibarr des notifications

         $this->notification->email_from = $this->email_from;

-        if (!empty($this->global->NOTIFICATION_EMAIL_FROM))

-            $this->notification->email_from = $this->global->NOTIFICATION_EMAIL_FROM;

+        if (!empty($this->global->NOTIFICATION_EMAIL_FROM)) {
+                    $this->notification->email_from = $this->global->NOTIFICATION_EMAIL_FROM;
+        }
 

         // conf->mailing->email_from = email pour envoi par Dolibarr des mailings

         $this->mailing->email_from = $this->email_from;

-        if (!empty($this->global->MAILING_EMAIL_FROM))

-            $this->mailing->email_from = $this->global->MAILING_EMAIL_FROM;

-        if (!isset($this->global->MAIN_EMAIL_ADD_TRACK_ID))

-            $this->global->MAIN_EMAIL_ADD_TRACK_ID = 1;

+        if (!empty($this->global->MAILING_EMAIL_FROM)) {
+                    $this->mailing->email_from = $this->global->MAILING_EMAIL_FROM;
+        }
+        if (!isset($this->global->MAIN_EMAIL_ADD_TRACK_ID)) {
+                    $this->global->MAIN_EMAIL_ADD_TRACK_ID = 1;
+        }
 

         // Format for date (used by default when not found or not searched in lang)

         $this->format_date_short = "%d/%m/%Y";            // Format of day with PHP/C tags (strftime functions)

@@ -536,81 +578,105 @@ 
         $this->format_date_hour_text = "%d %B %Y %H:%M";

 

         // Duration of workday

-        if (!isset($this->global->MAIN_DURATION_OF_WORKDAY))

-            $this->global->MAIN_DURATION_OF_WORKDAY = 86400;

+        if (!isset($this->global->MAIN_DURATION_OF_WORKDAY)) {
+                    $this->global->MAIN_DURATION_OF_WORKDAY = 86400;
+        }
 

         // Limites decimales si non definie (peuvent etre egale a 0)

-        if (!isset($this->global->MAIN_MAX_DECIMALS_UNIT))

-            $this->global->MAIN_MAX_DECIMALS_UNIT = 5;

-        if (!isset($this->global->MAIN_MAX_DECIMALS_TOT))

-            $this->global->MAIN_MAX_DECIMALS_TOT = 2;

-        if (!isset($this->global->MAIN_MAX_DECIMALS_SHOWN))

-            $this->global->MAIN_MAX_DECIMALS_SHOWN = 8;

+        if (!isset($this->global->MAIN_MAX_DECIMALS_UNIT)) {
+                    $this->global->MAIN_MAX_DECIMALS_UNIT = 5;
+        }
+        if (!isset($this->global->MAIN_MAX_DECIMALS_TOT)) {
+                    $this->global->MAIN_MAX_DECIMALS_TOT = 2;
+        }
+        if (!isset($this->global->MAIN_MAX_DECIMALS_SHOWN)) {
+                    $this->global->MAIN_MAX_DECIMALS_SHOWN = 8;
+        }
 

         // Default pdf option

-        if (!isset($this->global->MAIN_PDF_DASH_BETWEEN_LINES))

-            $this->global->MAIN_PDF_DASH_BETWEEN_LINES = 1;    // use dash between lines

-        if (!isset($this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT))

-            $this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT = 1;  // allow html content into free footer text

+        if (!isset($this->global->MAIN_PDF_DASH_BETWEEN_LINES)) {
+                    $this->global->MAIN_PDF_DASH_BETWEEN_LINES = 1;
+        }
+        // use dash between lines

+        if (!isset($this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT)) {
+                    $this->global->PDF_ALLOW_HTML_FOR_FREE_TEXT = 1;
+        }
+        // allow html content into free footer text

 

 

 

 

             

 // Set default value to MAIN_SHOW_LOGO

-        if (!isset($this->global->MAIN_SHOW_LOGO))

-            $this->global->MAIN_SHOW_LOGO = 1;

+        if (!isset($this->global->MAIN_SHOW_LOGO)) {
+                    $this->global->MAIN_SHOW_LOGO = 1;
+        }
 

         // Default max file size for upload

         $this->maxfilesize = (empty($this->global->MAIN_UPLOAD_DOC) ? 0 : (int) $this->global->MAIN_UPLOAD_DOC * 1024);

 

         // By default, we propagate contacts

-        if (!isset($this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN))

-            $this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN = '*';  // Can be also '*' or '^(BILLING|SHIPPING|CUSTOMER|.*)$' (regex not yet implemented)

+        if (!isset($this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN)) {
+                    $this->global->MAIN_PROPAGATE_CONTACTS_FROM_ORIGIN = '*';
+        }
+        // Can be also '*' or '^(BILLING|SHIPPING|CUSTOMER|.*)$' (regex not yet implemented)

 

 

 

 

             

 // By default, we do not use the zip town table but the table of third parties

-        if (!isset($this->global->MAIN_USE_ZIPTOWN_DICTIONNARY))

-            $this->global->MAIN_USE_ZIPTOWN_DICTIONNARY = 0;

+        if (!isset($this->global->MAIN_USE_ZIPTOWN_DICTIONNARY)) {
+                    $this->global->MAIN_USE_ZIPTOWN_DICTIONNARY = 0;
+        }
 

         // By default, we open card if one found

-        if (!isset($this->global->MAIN_SEARCH_DIRECT_OPEN_IF_ONLY_ONE))

-            $this->global->MAIN_SEARCH_DIRECT_OPEN_IF_ONLY_ONE = 1;

+        if (!isset($this->global->MAIN_SEARCH_DIRECT_OPEN_IF_ONLY_ONE)) {
+                    $this->global->MAIN_SEARCH_DIRECT_OPEN_IF_ONLY_ONE = 1;
+        }
 

         // By default, we show state code in combo list

-        if (!isset($this->global->MAIN_SHOW_STATE_CODE))

-            $this->global->MAIN_SHOW_STATE_CODE = 1;

+        if (!isset($this->global->MAIN_SHOW_STATE_CODE)) {
+                    $this->global->MAIN_SHOW_STATE_CODE = 1;
+        }
 

         // Define list of limited modules (value must be key found for "name" property of module, so for example 'supplierproposal' for Module "Supplier Proposal"

-        if (!isset($this->global->MAIN_MODULES_FOR_EXTERNAL))

-            $this->global->MAIN_MODULES_FOR_EXTERNAL = 'user,societe,propal,commande,facture,categorie,supplierproposal,fournisseur,contact,projet,contrat,ficheinter,expedition,agenda,resource,adherent,blockedlog'; // '' means 'all'. Note that contact is added here as it should be a module later.

+        if (!isset($this->global->MAIN_MODULES_FOR_EXTERNAL)) {
+                    $this->global->MAIN_MODULES_FOR_EXTERNAL = 'user,societe,propal,commande,facture,categorie,supplierproposal,fournisseur,contact,projet,contrat,ficheinter,expedition,agenda,resource,adherent,blockedlog';
+        }
+        // '' means 'all'. Note that contact is added here as it should be a module later.

         if (!empty($this->modules_parts['moduleforexternal'])) {  // Module part to include an external module into the MAIN_MODULES_FOR_EXTERNAL list

-            foreach ($this->modules_parts['moduleforexternal'] as $key => $value)

-                $this->global->MAIN_MODULES_FOR_EXTERNAL .= "," . $key;

+            foreach ($this->modules_parts['moduleforexternal'] as $key => $value) {
+                            $this->global->MAIN_MODULES_FOR_EXTERNAL .= "," . $key;
+            }
         }

 

         // Enable select2

-        if (empty($this->global->MAIN_USE_JQUERY_MULTISELECT) || $this->global->MAIN_USE_JQUERY_MULTISELECT == '1')

-            $this->global->MAIN_USE_JQUERY_MULTISELECT = 'select2';

+        if (empty($this->global->MAIN_USE_JQUERY_MULTISELECT) || $this->global->MAIN_USE_JQUERY_MULTISELECT == '1') {
+                    $this->global->MAIN_USE_JQUERY_MULTISELECT = 'select2';
+        }
 

         // Timeouts

-        if (empty($this->global->MAIN_USE_CONNECT_TIMEOUT))

-            $this->global->MAIN_USE_CONNECT_TIMEOUT = 10;

-        if (empty($this->global->MAIN_USE_RESPONSE_TIMEOUT))

-            $this->global->MAIN_USE_RESPONSE_TIMEOUT = 30;

+        if (empty($this->global->MAIN_USE_CONNECT_TIMEOUT)) {
+                    $this->global->MAIN_USE_CONNECT_TIMEOUT = 10;
+        }
+        if (empty($this->global->MAIN_USE_RESPONSE_TIMEOUT)) {
+                    $this->global->MAIN_USE_RESPONSE_TIMEOUT = 30;
+        }
 

         // Set default variable to calculate VAT as if option tax_mode was 0 (standard)

-        if (empty($this->global->TAX_MODE_SELL_PRODUCT))

-            $this->global->TAX_MODE_SELL_PRODUCT = 'invoice';

-        if (empty($this->global->TAX_MODE_BUY_PRODUCT))

-            $this->global->TAX_MODE_BUY_PRODUCT = 'invoice';

-        if (empty($this->global->TAX_MODE_SELL_SERVICE))

-            $this->global->TAX_MODE_SELL_SERVICE = 'payment';

-        if (empty($this->global->TAX_MODE_BUY_SERVICE))

-            $this->global->TAX_MODE_BUY_SERVICE = 'payment';

+        if (empty($this->global->TAX_MODE_SELL_PRODUCT)) {
+                    $this->global->TAX_MODE_SELL_PRODUCT = 'invoice';
+        }
+        if (empty($this->global->TAX_MODE_BUY_PRODUCT)) {
+                    $this->global->TAX_MODE_BUY_PRODUCT = 'invoice';
+        }
+        if (empty($this->global->TAX_MODE_SELL_SERVICE)) {
+                    $this->global->TAX_MODE_SELL_SERVICE = 'payment';
+        }
+        if (empty($this->global->TAX_MODE_BUY_SERVICE)) {
+                    $this->global->TAX_MODE_BUY_SERVICE = 'payment';
+        }
 

         // Delay before warnings

         // Avoid strict errors. TODO: Replace xxx->warning_delay with a property ->warning_delay_xxx

@@ -618,8 +684,9 @@ 
             $this->adherent->subscription = new \stdClass();

             $this->adherent->subscription->warning_delay = (isset($this->global->MAIN_DELAY_MEMBERS) ? $this->global->MAIN_DELAY_MEMBERS : 0) * 24 * 60 * 60;

         }

-        if (isset($this->agenda))

-            $this->agenda->warning_delay = (isset($this->global->MAIN_DELAY_ACTIONS_TODO) ? $this->global->MAIN_DELAY_ACTIONS_TODO : 7) * 24 * 60 * 60;

+        if (isset($this->agenda)) {
+                    $this->agenda->warning_delay = (isset($this->global->MAIN_DELAY_ACTIONS_TODO) ? $this->global->MAIN_DELAY_ACTIONS_TODO : 7) * 24 * 60 * 60;
+        }
         if (isset($this->projet)) {

             $this->projet->warning_delay = (isset($this->global->MAIN_DELAY_PROJECT_TO_CLOSE) ? $this->global->MAIN_DELAY_PROJECT_TO_CLOSE : 7) * 24 * 60 * 60;

             $this->projet->task = new StdClass();

@@ -669,44 +736,55 @@ 
         }

 

         // For modules that want to disable top or left menu

-        if (!empty($this->global->MAIN_HIDE_TOP_MENU))

-            $this->dol_hide_topmenu = $this->global->MAIN_HIDE_TOP_MENU;

-        if (!empty($this->global->MAIN_HIDE_LEFT_MENU))

-            $this->dol_hide_leftmenu = $this->global->MAIN_HIDE_LEFT_MENU;

+        if (!empty($this->global->MAIN_HIDE_TOP_MENU)) {
+                    $this->dol_hide_topmenu = $this->global->MAIN_HIDE_TOP_MENU;
+        }
+        if (!empty($this->global->MAIN_HIDE_LEFT_MENU)) {
+                    $this->dol_hide_leftmenu = $this->global->MAIN_HIDE_LEFT_MENU;
+        }
 

-        if (empty($this->global->MAIN_SIZE_SHORTLIST_LIMIT))

-            $this->global->MAIN_SIZE_SHORTLIST_LIMIT = 3;

+        if (empty($this->global->MAIN_SIZE_SHORTLIST_LIMIT)) {
+                    $this->global->MAIN_SIZE_SHORTLIST_LIMIT = 3;
+        }
 

-        if (!isset($this->global->THEME_HIDE_BORDER_ON_INPUT))

-            $this->global->THEME_HIDE_BORDER_ON_INPUT = 0;

+        if (!isset($this->global->THEME_HIDE_BORDER_ON_INPUT)) {
+                    $this->global->THEME_HIDE_BORDER_ON_INPUT = 0;
+        }
 

         // Save inconsistent option

         if (empty($this->global->AGENDA_USE_EVENT_TYPE) && (!isset($this->global->AGENDA_DEFAULT_FILTER_TYPE) || $this->global->AGENDA_DEFAULT_FILTER_TYPE == 'AC_NON_AUTO')) {

             $this->global->AGENDA_DEFAULT_FILTER_TYPE = '0';    // 'AC_NON_AUTO' does not exists when AGENDA_DEFAULT_FILTER_TYPE is not on.

         }

 

-        if (!isset($this->global->MAIN_EXTRAFIELDS_IN_ONE_TD))

-            $this->global->MAIN_EXTRAFIELDS_IN_ONE_TD = 1;

+        if (!isset($this->global->MAIN_EXTRAFIELDS_IN_ONE_TD)) {
+                    $this->global->MAIN_EXTRAFIELDS_IN_ONE_TD = 1;
+        }
 

         $this->global->MAIN_MODULE_DOLISTORE_API_SRV = 'https://www.dolistore.com';

         $this->global->MAIN_MODULE_DOLISTORE_API_KEY = 'dolistorecatalogpublickey1234567';

 

         // For backward compatibility

-        if (isset($this->product))

-            $this->produit = $this->product;

-        if (isset($this->facture))

-            $this->invoice = $this->facture;

-        if (isset($this->commande))

-            $this->order = $this->commande;

-        if (isset($this->contrat))

-            $this->contract = $this->contrat;

-        if (isset($this->categorie))

-            $this->category = $this->categorie;

+        if (isset($this->product)) {
+                    $this->produit = $this->product;
+        }
+        if (isset($this->facture)) {
+                    $this->invoice = $this->facture;
+        }
+        if (isset($this->commande)) {
+                    $this->order = $this->commande;
+        }
+        if (isset($this->contrat)) {
+                    $this->contract = $this->contrat;
+        }
+        if (isset($this->categorie)) {
+                    $this->category = $this->categorie;
+        }
 

         // Object $mc

         if (!defined('NOREQUIREMC') && !empty($this->multicompany->enabled)) {

-            if (is_object($mc))

-                $mc->setValues($this);

+            if (is_object($mc)) {
+                            $mc->setValues($this);
+            }
         }

 

         // We init log handlers

Base/MenuManager.php

Spacing +24 added lines, -24 removed lines

@@ -35,8 +35,8 @@ 
      * @var DoliDB Database handler.

      */

     // public $db;

-    var $type_user;         // Put 0 for internal users, 1 for external users

-    var $atarget = "";                                // To store default target to use onto links

+    var $type_user; // Put 0 for internal users, 1 for external users

+    var $atarget = ""; // To store default target to use onto links

     var $name = "eldy";

     var $menu_array;

     var $menu_array_after;

@@ -104,7 +104,7 @@ 
             $leftmenu = $forceleftmenu;

         }

 

-        require_once DOL_DOCUMENT_ROOT . '/core/class/menubase.class.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/class/menubase.class.php';

         $tabMenu = array();

         $menuArbo = new Menubase('eldy');

         $menuArbo->menuLoad($mainmenu, $leftmenu, $this->type_user, 'eldy', $tabMenu);

@@ -127,14 +127,14 @@ 
 

         //var_dump($this->tabMenu);

 

-        require_once DOL_DOCUMENT_ROOT . '/core/menus/standard/eldy.lib.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/menus/standard/eldy.lib.php';

 

         if ($this->type_user == 1) {

             $conf->global->MAIN_SEARCHFORM_SOCIETE_DISABLED = 1;

             $conf->global->MAIN_SEARCHFORM_CONTACT_DISABLED = 1;

         }

 

-        require_once DOL_DOCUMENT_ROOT . '/core/class/menu.class.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/class/menu.class.php';

         $this->menu = new Menu();

 

         if (empty($conf->global->MAIN_MENU_INVERT)) {

@@ -155,16 +155,16 @@ 
         }

 

         if ($mode == 'topnb') {

-            print_eldy_menu($this->db, $this->atarget, $this->type_user, $this->tabMenu, $this->menu, 1, $mode);  // no output

+            print_eldy_menu($this->db, $this->atarget, $this->type_user, $this->tabMenu, $this->menu, 1, $mode); // no output

             return $this->menu->getNbOfVisibleMenuEntries();

         }

 

         if ($mode == 'jmobile') {     // Used to get menu in xml ul/li

-            print_eldy_menu($this->db, $this->atarget, $this->type_user, $this->tabMenu, $this->menu, 1, $mode);      // Fill this->menu that is empty with top menu

+            print_eldy_menu($this->db, $this->atarget, $this->type_user, $this->tabMenu, $this->menu, 1, $mode); // Fill this->menu that is empty with top menu

             // $this->menu->liste is top menu

             //var_dump($this->menu->liste);exit;

             $lastlevel = array();

-            print '<!-- Generate menu list from menu handler ' . $this->name . ' -->' . "\n";

+            print '<!-- Generate menu list from menu handler '.$this->name.' -->'."\n";

             foreach ($this->menu->liste as $key => $val) {  // $val['url','titre','level','enabled'=0|1|2,'target','mainmenu','leftmenu'

                 print '<ul class="ulmenu" data-inset="true">';

                 print '<li class="lilevel0">';

@@ -185,13 +185,13 @@ 
                     }

 

                     print $val['titre'];

-                    print '</a>' . "\n";

+                    print '</a>'."\n";

 

                     // Search submenu fot this mainmenu entry

                     $tmpmainmenu = $val['mainmenu'];

                     $tmpleftmenu = 'all';

                     $submenu = new Menu();

-                    print_left_eldy_menu($this->db, $this->menu_array, $this->menu_array_after, $this->tabMenu, $submenu, 1, $tmpmainmenu, $tmpleftmenu);       // Fill $submenu (example with tmpmainmenu='home' tmpleftmenu='all', return left menu tree of Home)

+                    print_left_eldy_menu($this->db, $this->menu_array, $this->menu_array_after, $this->tabMenu, $submenu, 1, $tmpmainmenu, $tmpleftmenu); // Fill $submenu (example with tmpmainmenu='home' tmpleftmenu='all', return left menu tree of Home)

                     // Note: $submenu contains menu entry with substitution not yet done

                     //if ($tmpmainmenu.'-'.$tmpleftmenu == 'home-all') { var_dump($submenu); exit; }

                     //if ($tmpmainmenu=='accountancy') { var_dump($submenu->liste); exit; }

@@ -201,21 +201,21 @@ 
                     $canonnexturl = preg_replace('/\?.*$/', '', $nexturl);

                     //var_dump($canonrelurl);

                     //var_dump($canonnexturl);

-                    print '<ul>' . "\n";

+                    print '<ul>'."\n";

                     if (($canonrelurl != $canonnexturl && !in_array($val['mainmenu'], array('tools'))) || (strpos($canonrelurl, '/product/index.php') !== false || strpos($canonrelurl, '/compta/bank/list.php') !== false)) {

                         // We add sub entry

-                        print str_pad('', 1) . '<li class="lilevel1 ui-btn-icon-right ui-btn">';  // ui-btn to highlight on clic

-                        print '<a href="' . $relurl . '">';

-                        if ($langs->trans(ucfirst($val['mainmenu']) . "Dashboard") == ucfirst($val['mainmenu']) . "Dashboard") {  // No translation

+                        print str_pad('', 1).'<li class="lilevel1 ui-btn-icon-right ui-btn">'; // ui-btn to highlight on clic

+                        print '<a href="'.$relurl.'">';

+                        if ($langs->trans(ucfirst($val['mainmenu'])."Dashboard") == ucfirst($val['mainmenu'])."Dashboard") {  // No translation

                             if (in_array($val['mainmenu'], array('cashdesk', 'externalsite', 'website', 'collab'))) {

                                 print $langs->trans("Access");

                             } else {

                                 print $langs->trans("Dashboard");

                             }

                         } else

-                            print $langs->trans(ucfirst($val['mainmenu']) . "Dashboard");

+                            print $langs->trans(ucfirst($val['mainmenu'])."Dashboard");

                         print '</a>';

-                        print '</li>' . "\n";

+                        print '</li>'."\n";

                     }

 

                     if ($val['level'] == 0) {

@@ -249,7 +249,7 @@ 
                         if ($showmenu) {  // Visible (option to hide when not allowed is off or allowed)

                             $substitarray = array('__LOGIN__' => $user->login, '__USER_ID__' => $user->id, '__USER_SUPERVISOR_ID__' => $user->fk_user);

                             $substitarray['__USERID__'] = $user->id; // For backward compatibility

-                            $val2['url'] = make_substitutions($val2['url'], $substitarray);  // Make also substitution of __(XXX)__ and __[XXX]__

+                            $val2['url'] = make_substitutions($val2['url'], $substitarray); // Make also substitution of __(XXX)__ and __[XXX]__

 

                             if (!preg_match("/^(http:\/\/|https:\/\/)/i", $val2['url'])) {

                                 $relurl2 = dol_buildpath($val2['url'], 1);

@@ -268,14 +268,14 @@ 
                             }

 

                             print str_pad('', $val2['level'] + 1);

-                            print '<li class="lilevel' . ($val2['level'] + 1);

+                            print '<li class="lilevel'.($val2['level'] + 1);

                             if ($val2['level'] == 0) {

-                                print ' ui-btn-icon-right ui-btn';  // ui-btn to highlight on clic

+                                print ' ui-btn-icon-right ui-btn'; // ui-btn to highlight on clic

                             }

-                            print $disabled . '">';  // ui-btn to highlight on clic

+                            print $disabled.'">'; // ui-btn to highlight on clic

                             if ($relurl2) {

                                 if ($val2['enabled']) { // Allowed

-                                    print '<a href="' . $relurl2 . '"';

+                                    print '<a href="'.$relurl2.'"';

                                     //print ' data-ajax="false"';

                                     print '>';

                                     $lastlevel2[$val2['level']] = 'enabled';

@@ -299,17 +299,17 @@ 
                                 else

                                     print '</a>';

                             }

-                            print '</li>' . "\n";

+                            print '</li>'."\n";

                         }

                     }

                     //var_dump($submenu);

                     print '</ul>';

                 }

                 if ($val['enabled'] == 2) {

-                    print '<font class="vsmenudisabled">' . $val['titre'] . '</font>';

+                    print '<font class="vsmenudisabled">'.$val['titre'].'</font>';

                 }

                 print '</li>';

-                print '</ul>' . "\n";

+                print '</ul>'."\n";

             }

         }

 

Braces +9 added lines, -6 removed lines

@@ -210,8 +210,9 @@ 
                             } else {

                                 print $langs->trans("Dashboard");

                             }

-                        } else

-                            print $langs->trans(ucfirst($val['mainmenu']) . "Dashboard");

+                        } else {
+                                                    print $langs->trans(ucfirst($val['mainmenu']) . "Dashboard");
+                        }
                         print '</a>';

                         print '</li>' . "\n";

                     }

@@ -292,10 +293,12 @@ 
                             //var_dump($lastlevel2);

                             print $val2['titre'];

                             if ($relurl2) {

-                                if ($val2['enabled']) // Allowed

-                                    print '</a>';

-                                else

-                                    print '</a>';

+                                if ($val2['enabled']) {
+                                    // Allowed

+                                    print '</a>';
+                                } else {
+                                                                    print '</a>';
+                                }
                             }

                             print '</li>' . "\n";

                         }

Base/User.php

Spacing +337 added lines, -337 removed lines

@@ -54,7 +54,7 @@ 
     public $skype;

     public $twitter;

     public $facebook;

-    public $job;   // job position

+    public $job; // job position

     public $signature;

 

     /**

@@ -63,7 +63,7 @@ 
     public $address;

     public $zip;

     public $town;

-    public $state_id;  // The state/department

+    public $state_id; // The state/department

     public $state_code;

     public $state;

     public $office_phone;

@@ -117,26 +117,26 @@ 
     public $datepreviouslogin;

     public $photo;

     public $lang;

-    public $rights;                        // Array of permissions user->rights->permx

-    public $all_permissions_are_loaded;    // All permission are loaded

-    public $nb_rights;              // Number of rights granted to the user

-    private $_tab_loaded = array();     // Cache array of already loaded permissions

-    public $conf;             // To store personal config

-    public $default_values;         // To store default values for user

-    public $lastsearch_values_tmp;  // To store current search criterias for user

-    public $lastsearch_values;      // To store last saved search criterias for user

-    public $users = array();  // To store all tree of users hierarchy

-    public $parentof;    // To store an array of all parents for all ids.

+    public $rights; // Array of permissions user->rights->permx

+    public $all_permissions_are_loaded; // All permission are loaded

+    public $nb_rights; // Number of rights granted to the user

+    private $_tab_loaded = array(); // Cache array of already loaded permissions

+    public $conf; // To store personal config

+    public $default_values; // To store default values for user

+    public $lastsearch_values_tmp; // To store current search criterias for user

+    public $lastsearch_values; // To store last saved search criterias for user

+    public $users = array(); // To store all tree of users hierarchy

+    public $parentof; // To store an array of all parents for all ids.

     private $cache_childids;

-    public $accountancy_code;   // Accountancy code in prevision of the complete accountancy module

-    public $thm;     // Average cost of employee - Used for valuation of time spent

-    public $tjm;     // Average cost of employee

-    public $salary;     // Monthly salary       - Denormalized value from llx_user_employment

-    public $salaryextra;    // Monthly salary extra - Denormalized value from llx_user_employment

-    public $weeklyhours;    // Weekly hours         - Denormalized value from llx_user_employment

-    public $color;      // Define background color for user in agenda

-    public $dateemployment;   // Define date of employment by company

-    public $dateemploymentend;  // Define date of employment end by company

+    public $accountancy_code; // Accountancy code in prevision of the complete accountancy module

+    public $thm; // Average cost of employee - Used for valuation of time spent

+    public $tjm; // Average cost of employee

+    public $salary; // Monthly salary       - Denormalized value from llx_user_employment

+    public $salaryextra; // Monthly salary extra - Denormalized value from llx_user_employment

+    public $weeklyhours; // Weekly hours         - Denormalized value from llx_user_employment

+    public $color; // Define background color for user in agenda

+    public $dateemployment; // Define date of employment by company

+    public $dateemploymentend; // Define date of employment end by company

     public $default_c_exp_tax_cat;

     public $default_range;

     public $fields = array(

@@ -211,37 +211,37 @@ 
         $sql .= " u.color,";

         $sql .= " u.dateemployment, u.dateemploymentend,";

         $sql .= " u.ref_int, u.ref_ext,";

-        $sql .= " u.default_range, u.default_c_exp_tax_cat,";   // Expense report default mode

+        $sql .= " u.default_range, u.default_c_exp_tax_cat,"; // Expense report default mode

         $sql .= " c.code as country_code, c.label as country,";

         $sql .= " d.code_departement as state_code, d.nom as state";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";

-        $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "c_country as c ON u.fk_country = c.rowid";

-        $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "c_departements as d ON u.fk_state = d.rowid";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user as u";

+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."c_country as c ON u.fk_country = c.rowid";

+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."c_departements as d ON u.fk_state = d.rowid";

 

         if ($entity < 0) {

             if ((empty($conf->multicompany->enabled) || empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) && (!empty($user->entity))) {

-                $sql .= " WHERE u.entity IN (0," . Globals::$conf->entity . ")";

+                $sql .= " WHERE u.entity IN (0,".Globals::$conf->entity.")";

             } else {

-                $sql .= " WHERE u.entity IS NOT NULL";    // multicompany is on in transverse mode or user making fetch is on entity 0, so user is allowed to fetch anywhere into database

+                $sql .= " WHERE u.entity IS NOT NULL"; // multicompany is on in transverse mode or user making fetch is on entity 0, so user is allowed to fetch anywhere into database

             }

         } else {  // The fetch was forced on an entity

             if (!empty($conf->multicompany->enabled) && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-                $sql .= " WHERE u.entity IS NOT NULL";    // multicompany is on in transverse mode or user making fetch is on entity 0, so user is allowed to fetch anywhere into database

+                $sql .= " WHERE u.entity IS NOT NULL"; // multicompany is on in transverse mode or user making fetch is on entity 0, so user is allowed to fetch anywhere into database

             } else {

-                $sql .= " WHERE u.entity IN (0, " . (($entity != '' && $entity >= 0) ? $entity : Globals::$conf->entity) . ")";   // search in entity provided in parameter

+                $sql .= " WHERE u.entity IN (0, ".(($entity != '' && $entity >= 0) ? $entity : Globals::$conf->entity).")"; // search in entity provided in parameter

             }

         }

 

         if ($sid) {    // permet une recherche du user par son SID ActiveDirectory ou Samba

             //$sql .= " AND (u.ldap_sid = '" . Config::$dbEngine->escape($sid) . "' OR u.login = '" . Config::$dbEngine->escape($login) . "') LIMIT 1";

-            $sql .= " AND (u.ldap_sid = '" . $sid . "' OR u.login = '" . Config::$dbEngine->escape($login) . "') LIMIT 1";

+            $sql .= " AND (u.ldap_sid = '".$sid."' OR u.login = '".Config::$dbEngine->escape($login)."') LIMIT 1";

         } else if ($login) {

             // $sql .= " AND u.login = '" . Config::$dbEngine->escape($login) . "'";

-            $sql .= " AND u.login = '" . $login . "'";

+            $sql .= " AND u.login = '".$login."'";

         } else {

-            $sql .= " AND u.rowid = " . $id;

+            $sql .= " AND u.rowid = ".$id;

         }

-        $sql .= " ORDER BY u.entity ASC";    // Avoid random result when there is 2 login in 2 different entities

+        $sql .= " ORDER BY u.entity ASC"; // Avoid random result when there is 2 login in 2 different entities

 

         $result = Config::$dbEngine->select($sql);

         // echo "<p>SQL in 2477 of User: '$sql'</p>";

@@ -327,7 +327,7 @@ 
                 $this->datelastlogin = $obj->datel;

                 $this->datepreviouslogin = $obj->datep;

 

-                $this->societe_id = $obj->fk_soc;  // deprecated

+                $this->societe_id = $obj->fk_soc; // deprecated

                 $this->contact_id = $obj->fk_socpeople; // deprecated

                 $this->socid = $obj->fk_soc;

                 $this->contactid = $obj->fk_socpeople;

@@ -348,7 +348,7 @@ 
                 $this->fetch_optionals();

             } else {

                 $this->error = "USERNOTFOUND";

-                DolUtils::dol_syslog(get_class($this) . "::fetch user not found", LOG_DEBUG);

+                DolUtils::dol_syslog(get_class($this)."::fetch user not found", LOG_DEBUG);

                 return 0;

             }

         } else {

@@ -359,9 +359,9 @@ 
         // To get back the global configuration unique to the user

         if ($loadpersonalconf) {

             // Load user->conf for user

-            $sql = "SELECT param, value FROM " . MAIN_DB_PREFIX . "user_param";

-            $sql .= " WHERE fk_user = " . $this->id;

-            $sql .= " AND entity = " . Globals::$conf->entity;

+            $sql = "SELECT param, value FROM ".MAIN_DB_PREFIX."user_param";

+            $sql .= " WHERE fk_user = ".$this->id;

+            $sql .= " AND entity = ".Globals::$conf->entity;

             //DolUtils::dol_syslog(get_class($this).'::fetch load personalized conf', LOG_DEBUG);

             $resql = Config::$dbEngine->select($sql);

             if (is_array($resql)) {

@@ -399,9 +399,9 @@ 
         // global $conf;

         // Load user->default_values for user. TODO Save this in memcached ?

         $sql = "SELECT rowid, entity, type, page, param, value";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "default_values";

-        $sql .= " WHERE entity IN (" . ($this->entity > 0 ? $this->entity . ", " : "") . Globals::$conf->entity . ")"; // Entity of user (if defined) + current entity

-        $sql .= " AND user_id IN (0" . ($this->id > 0 ? ", " . $this->id : "") . ")";       // User 0 (all) + me (if defined)

+        $sql .= " FROM ".MAIN_DB_PREFIX."default_values";

+        $sql .= " WHERE entity IN (".($this->entity > 0 ? $this->entity.", " : "").Globals::$conf->entity.")"; // Entity of user (if defined) + current entity

+        $sql .= " AND user_id IN (0".($this->id > 0 ? ", ".$this->id : "").")"; // User 0 (all) + me (if defined)

         $resql = Config::$dbEngine->select($sql);

         if (is_array($resql)) {

             foreach ($resql as $array) {

@@ -450,7 +450,7 @@ 
 

         $entity = (!empty($entity) ? $entity : Globals::$conf->entity);

 

-        DolUtils::dol_syslog(get_class($this) . "::addrights $rid, $allmodule, $allperms, $entity");

+        DolUtils::dol_syslog(get_class($this)."::addrights $rid, $allmodule, $allperms, $entity");

         $error = 0;

         $whereforadd = '';

 

@@ -460,9 +460,9 @@ 
             // Si on a demande ajout d'un droit en particulier, on recupere

             // les caracteristiques (module, perms et subperms) de ce droit.

             $sql = "SELECT module, perms, subperms";

-            $sql .= " FROM " . MAIN_DB_PREFIX . "rights_def";

-            $sql .= " WHERE id = '" . Config::$dbEngine->escape($rid) . "'";

-            $sql .= " AND entity = " . $entity;

+            $sql .= " FROM ".MAIN_DB_PREFIX."rights_def";

+            $sql .= " WHERE id = '".Config::$dbEngine->escape($rid)."'";

+            $sql .= " AND entity = ".$entity;

 

             $result = Config::$dbEngine->query($sql);

             if ($result) {

@@ -476,7 +476,7 @@ 
             }

 

             // Where pour la liste des droits a ajouter

-            $whereforadd = "id=" . Config::$dbEngine->escape($rid);

+            $whereforadd = "id=".Config::$dbEngine->escape($rid);

             // Ajout des droits induits

             if (!empty($subperms)) {

                 $whereforadd .= " OR (module='$module' AND perms='$perms' AND (subperms='lire' OR subperms='read'))";

@@ -493,9 +493,9 @@ 
                 if ($allmodule == 'allmodules') {

                     $whereforadd = 'allmodules';

                 } else {

-                    $whereforadd = "module='" . Config::$dbEngine->escape($allmodule) . "'";

+                    $whereforadd = "module='".Config::$dbEngine->escape($allmodule)."'";

                     if (!empty($allperms)) {

-                        $whereforadd .= " AND perms='" . Config::$dbEngine->escape($allperms) . "'";

+                        $whereforadd .= " AND perms='".Config::$dbEngine->escape($allperms)."'";

                     }

                 }

             }

@@ -505,10 +505,10 @@ 
         if (!empty($whereforadd)) {

             //print "$module-$perms-$subperms";

             $sql = "SELECT id";

-            $sql .= " FROM " . MAIN_DB_PREFIX . "rights_def";

-            $sql .= " WHERE entity = " . $entity;

+            $sql .= " FROM ".MAIN_DB_PREFIX."rights_def";

+            $sql .= " WHERE entity = ".$entity;

             if (!empty($whereforadd) && $whereforadd != 'allmodules') {

-                $sql .= " AND " . $whereforadd;

+                $sql .= " AND ".$whereforadd;

             }

 

             $result = Config::$dbEngine->query($sql);

@@ -519,10 +519,10 @@ 
                     $obj = Config::$dbEngine->fetch_object($result);

                     $nid = $obj->id;

 

-                    $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user_rights WHERE fk_user = " . $this->id . " AND fk_id=" . $nid . " AND entity = " . $entity;

+                    $sql = "DELETE FROM ".MAIN_DB_PREFIX."user_rights WHERE fk_user = ".$this->id." AND fk_id=".$nid." AND entity = ".$entity;

                     if (!Config::$dbEngine->query($sql))

                         $error++;

-                    $sql = "INSERT INTO " . MAIN_DB_PREFIX . "user_rights (entity, fk_user, fk_id) VALUES (" . $entity . ", " . $this->id . ", " . $nid . ")";

+                    $sql = "INSERT INTO ".MAIN_DB_PREFIX."user_rights (entity, fk_user, fk_id) VALUES (".$entity.", ".$this->id.", ".$nid.")";

                     if (!Config::$dbEngine->query($sql))

                         $error++;

 

@@ -537,7 +537,7 @@ 
 

         if (!$error && !$notrigger) {

             $langs->load("other");

-            $this->context = array('audit' => $langs->trans("PermissionsAdd") . ($rid ? ' (id=' . $rid . ')' : ''));

+            $this->context = array('audit' => $langs->trans("PermissionsAdd").($rid ? ' (id='.$rid.')' : ''));

 

             // Call trigger

             $result = $this->call_trigger('USER_MODIFY', $user);

@@ -581,9 +581,9 @@ 
             // Si on a demande supression d'un droit en particulier, on recupere

             // les caracteristiques module, perms et subperms de ce droit.

             $sql = "SELECT module, perms, subperms";

-            $sql .= " FROM " . MAIN_DB_PREFIX . "rights_def";

-            $sql .= " WHERE id = '" . Config::$dbEngine->escape($rid) . "'";

-            $sql .= " AND entity = " . $entity;

+            $sql .= " FROM ".MAIN_DB_PREFIX."rights_def";

+            $sql .= " WHERE id = '".Config::$dbEngine->escape($rid)."'";

+            $sql .= " AND entity = ".$entity;

 

             $result = Config::$dbEngine->query($sql);

             if ($result) {

@@ -597,7 +597,7 @@ 
             }

 

             // Where pour la liste des droits a supprimer

-            $wherefordel = "id=" . Config::$dbEngine->escape($rid);

+            $wherefordel = "id=".Config::$dbEngine->escape($rid);

             // Suppression des droits induits

             if ($subperms == 'lire' || $subperms == 'read') {

                 $wherefordel .= " OR (module='$module' AND perms='$perms' AND subperms IS NOT NULL)";

@@ -612,9 +612,9 @@ 
                 if ($allmodule == 'allmodules') {

                     $wherefordel = 'allmodules';

                 } else {

-                    $wherefordel = "module='" . Config::$dbEngine->escape($allmodule) . "'";

+                    $wherefordel = "module='".Config::$dbEngine->escape($allmodule)."'";

                     if (!empty($allperms)) {

-                        $whereforadd .= " AND perms='" . Config::$dbEngine->escape($allperms) . "'";

+                        $whereforadd .= " AND perms='".Config::$dbEngine->escape($allperms)."'";

                     }

                 }

             }

@@ -624,10 +624,10 @@ 
         if (!empty($wherefordel)) {

             //print "$module-$perms-$subperms";

             $sql = "SELECT id";

-            $sql .= " FROM " . MAIN_DB_PREFIX . "rights_def";

-            $sql .= " WHERE entity = " . $entity;

+            $sql .= " FROM ".MAIN_DB_PREFIX."rights_def";

+            $sql .= " WHERE entity = ".$entity;

             if (!empty($wherefordel) && $wherefordel != 'allmodules') {

-                $sql .= " AND " . $wherefordel;

+                $sql .= " AND ".$wherefordel;

             }

 

             $result = Config::$dbEngine->query($sql);

@@ -638,9 +638,9 @@ 
                     $obj = Config::$dbEngine->fetch_object($result);

                     $nid = $obj->id;

 

-                    $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user_rights";

-                    $sql .= " WHERE fk_user = " . $this->id . " AND fk_id=" . $nid;

-                    $sql .= " AND entity = " . $entity;

+                    $sql = "DELETE FROM ".MAIN_DB_PREFIX."user_rights";

+                    $sql .= " WHERE fk_user = ".$this->id." AND fk_id=".$nid;

+                    $sql .= " AND entity = ".$entity;

                     if (!Config::$dbEngine->query($sql)) {

                         $error++;

                     }

@@ -655,7 +655,7 @@ 
 

         if (!$error && !$notrigger) {

             $langs->load("other");

-            $this->context = array('audit' => $langs->trans("PermissionsDelete") . ($rid ? ' (id=' . $rid . ')' : ''));

+            $this->context = array('audit' => $langs->trans("PermissionsDelete").($rid ? ' (id='.$rid.')' : ''));

 

             // Call trigger

             $result = $this->call_trigger('USER_MODIFY', $user);

@@ -682,7 +682,7 @@ 
      */

     function clearrights()

     {

-        DolUtils::dol_syslog(get_class($this) . "::clearrights reset user->rights");

+        DolUtils::dol_syslog(get_class($this)."::clearrights reset user->rights");

         $this->rights = '';

         $this->all_permissions_are_loaded = false;

         $this->_tab_loaded = array();

@@ -715,19 +715,19 @@ 
         // Recuperation des droits utilisateurs + recuperation des droits groupes

         // D'abord les droits utilisateurs

         $sql = "SELECT DISTINCT r.module, r.perms, r.subperms";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user_rights as ur";

-        $sql .= ", " . MAIN_DB_PREFIX . "rights_def as r";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user_rights as ur";

+        $sql .= ", ".MAIN_DB_PREFIX."rights_def as r";

         $sql .= " WHERE r.id = ur.fk_id";

         if (!empty($conf->global->MULTICOMPANY_BACKWARD_COMPATIBILITY)) {

-            $sql .= " AND r.entity IN (0," . (!empty($conf->multicompany->enabled) && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE) ? "1," : "") . Globals::$conf->entity . ")";

+            $sql .= " AND r.entity IN (0,".(!empty($conf->multicompany->enabled) && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE) ? "1," : "").Globals::$conf->entity.")";

         } else {

-            $sql .= " AND ur.entity = " . Globals::$conf->entity;

+            $sql .= " AND ur.entity = ".Globals::$conf->entity;

         }

-        $sql .= " AND ur.fk_user= " . $this->id;

+        $sql .= " AND ur.fk_user= ".$this->id;

         $sql .= " AND r.perms IS NOT NULL";

         if ($moduletag) {

             // $sql .= " AND r.module = '" . Config::$dbEngine->escape($moduletag) . "'";

-            $sql .= " AND r.module = '" . $moduletag . "'";

+            $sql .= " AND r.module = '".$moduletag."'";

         }

 

         $resql = Config::$dbEngine->select($sql);

@@ -768,25 +768,25 @@ 
 

         // Maintenant les droits groupes

         $sql = "SELECT DISTINCT r.module, r.perms, r.subperms";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "usergroup_rights as gr,";

-        $sql .= " " . MAIN_DB_PREFIX . "usergroup_user as gu,";

-        $sql .= " " . MAIN_DB_PREFIX . "rights_def as r";

+        $sql .= " FROM ".MAIN_DB_PREFIX."usergroup_rights as gr,";

+        $sql .= " ".MAIN_DB_PREFIX."usergroup_user as gu,";

+        $sql .= " ".MAIN_DB_PREFIX."rights_def as r";

         $sql .= " WHERE r.id = gr.fk_id";

         if (!empty($conf->global->MULTICOMPANY_BACKWARD_COMPATIBILITY)) {

             if (!empty($conf->multicompany->enabled) && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-                $sql .= " AND gu.entity IN (0," . Globals::$conf->entity . ")";

+                $sql .= " AND gu.entity IN (0,".Globals::$conf->entity.")";

             } else {

-                $sql .= " AND r.entity = " . Globals::$conf->entity;

+                $sql .= " AND r.entity = ".Globals::$conf->entity;

             }

         } else {

-            $sql .= " AND gr.entity = " . Globals::$conf->entity;

-            $sql .= " AND r.entity = " . Globals::$conf->entity;

+            $sql .= " AND gr.entity = ".Globals::$conf->entity;

+            $sql .= " AND r.entity = ".Globals::$conf->entity;

         }

         $sql .= " AND gr.fk_usergroup = gu.fk_usergroup";

-        $sql .= " AND gu.fk_user = " . $this->id;

+        $sql .= " AND gu.fk_user = ".$this->id;

         $sql .= " AND r.perms IS NOT NULL";

         if ($moduletag) {

-            $sql .= " AND r.module = '" . $moduletag . "'";

+            $sql .= " AND r.module = '".$moduletag."'";

         }

 

         $resql = Config::$dbEngine->select($sql);

@@ -866,12 +866,12 @@ 
         Config::$dbEngine->begin();

 

         // Deactivate user

-        $sql = "UPDATE " . MAIN_DB_PREFIX . "user";

-        $sql .= " SET statut = " . $this->statut;

-        $sql .= " WHERE rowid = " . $this->id;

+        $sql = "UPDATE ".MAIN_DB_PREFIX."user";

+        $sql .= " SET statut = ".$this->statut;

+        $sql .= " WHERE rowid = ".$this->id;

         $result = Config::$dbEngine->query($sql);

 

-        DolUtils::dol_syslog(get_class($this) . "::setstatus", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::setstatus", LOG_DEBUG);

         if ($result) {

             // Call trigger

             $result = $this->call_trigger('USER_ENABLEDISABLE', $user);

@@ -908,7 +908,7 @@ 
         }

 

         // Get current categories

-        require_once DOL_DOCUMENT_ROOT . '/categories/class/categorie.class.php';

+        require_once DOL_DOCUMENT_ROOT.'/categories/class/categorie.class.php';

         $c = new Categorie(Config::$dbEngine);

         $existing = $c->containing($this->id, Categorie::TYPE_USER, 'id');

 

@@ -951,10 +951,10 @@ 
 

         $this->fetch($this->id);

 

-        DolUtils::dol_syslog(get_class($this) . "::delete", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::delete", LOG_DEBUG);

 

         // Remove rights

-        $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user_rights WHERE fk_user = " . $this->id;

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."user_rights WHERE fk_user = ".$this->id;

 

         if (!$error && !Config::$dbEngine->query($sql)) {

             $error++;

@@ -962,7 +962,7 @@ 
         }

 

         // Remove group

-        $sql = "DELETE FROM " . MAIN_DB_PREFIX . "usergroup_user WHERE fk_user  = " . $this->id;

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."usergroup_user WHERE fk_user  = ".$this->id;

         if (!$error && !Config::$dbEngine->query($sql)) {

             $error++;

             $this->error = Config::$dbEngine->lasterror();

@@ -970,7 +970,7 @@ 
 

         // If contact, remove link

         if ($this->contact_id) {

-            $sql = "UPDATE " . MAIN_DB_PREFIX . "socpeople SET fk_user_creat = null WHERE rowid = " . $this->contact_id;

+            $sql = "UPDATE ".MAIN_DB_PREFIX."socpeople SET fk_user_creat = null WHERE rowid = ".$this->contact_id;

             if (!$error && !Config::$dbEngine->query($sql)) {

                 $error++;

                 $this->error = Config::$dbEngine->lasterror();

@@ -982,14 +982,14 @@ 
             $result = $this->deleteExtraFields();

             if ($result < 0) {

                 $error++;

-                DolUtils::dol_syslog(get_class($this) . "::delete error -4 " . $this->error, LOG_ERR);

+                DolUtils::dol_syslog(get_class($this)."::delete error -4 ".$this->error, LOG_ERR);

             }

         }

 

         // Remove user

         if (!$error) {

-            $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user WHERE rowid = " . $this->id;

-            DolUtils::dol_syslog(get_class($this) . "::delete", LOG_DEBUG);

+            $sql = "DELETE FROM ".MAIN_DB_PREFIX."user WHERE rowid = ".$this->id;

+            DolUtils::dol_syslog(get_class($this)."::delete", LOG_DEBUG);

             if (!Config::$dbEngine->query($sql)) {

                 $error++;

                 $this->error = Config::$dbEngine->lasterror();

@@ -1031,7 +1031,7 @@ 
         if (!isset($this->entity)) {

             $this->entity = Globals::$conf->entity; // If not defined, we use default value

         }

-        DolUtils::dol_syslog(get_class($this) . "::create login=" . $this->login . ", user=" . (is_object($user) ? $user->id : ''), LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::create login=".$this->login.", user=".(is_object($user) ? $user->id : ''), LOG_DEBUG);

 

         // Check parameters

         if (!empty($conf->global->USER_MAIL_REQUIRED) && !isValidEMail($this->email)) {

@@ -1050,11 +1050,11 @@ 
         $error = 0;

         Config::$dbEngine->begin();

 

-        $sql = "SELECT login FROM " . MAIN_DB_PREFIX . "user";

-        $sql .= " WHERE login ='" . Config::$dbEngine->escape($this->login) . "'";

-        $sql .= " AND entity IN (0," . Config::$dbEngine->escape($conf->entity) . ")";

+        $sql = "SELECT login FROM ".MAIN_DB_PREFIX."user";

+        $sql .= " WHERE login ='".Config::$dbEngine->escape($this->login)."'";

+        $sql .= " AND entity IN (0,".Config::$dbEngine->escape($conf->entity).")";

 

-        DolUtils::dol_syslog(get_class($this) . "::create", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::create", LOG_DEBUG);

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

             $num = Config::$dbEngine->num_rows($resql);

@@ -1062,17 +1062,17 @@ 
 

             if ($num) {

                 $this->error = 'ErrorLoginAlreadyExists';

-                DolUtils::dol_syslog(get_class($this) . "::create " . $this->error, LOG_WARNING);

+                DolUtils::dol_syslog(get_class($this)."::create ".$this->error, LOG_WARNING);

                 Config::$dbEngine->rollback();

                 return -6;

             } else {

-                $sql = "INSERT INTO " . MAIN_DB_PREFIX . "user (datec,login,ldap_sid,entity)";

-                $sql .= " VALUES('" . Config::$dbEngine->idate($this->datec) . "','" . Config::$dbEngine->escape($this->login) . "','" . Config::$dbEngine->escape($this->ldap_sid) . "'," . Config::$dbEngine->escape($this->entity) . ")";

+                $sql = "INSERT INTO ".MAIN_DB_PREFIX."user (datec,login,ldap_sid,entity)";

+                $sql .= " VALUES('".Config::$dbEngine->idate($this->datec)."','".Config::$dbEngine->escape($this->login)."','".Config::$dbEngine->escape($this->ldap_sid)."',".Config::$dbEngine->escape($this->entity).")";

                 $result = Config::$dbEngine->query($sql);

 

-                DolUtils::dol_syslog(get_class($this) . "::create", LOG_DEBUG);

+                DolUtils::dol_syslog(get_class($this)."::create", LOG_DEBUG);

                 if ($result) {

-                    $this->id = Config::$dbEngine->last_insert_id(MAIN_DB_PREFIX . "user");

+                    $this->id = Config::$dbEngine->last_insert_id(MAIN_DB_PREFIX."user");

 

                     // Set default rights

                     if ($this->set_default_rights() < 0) {

@@ -1089,7 +1089,7 @@ 
                     }

 

                     if (!empty($conf->global->STOCK_USERSTOCK_AUTOCREATE)) {

-                        require_once DOL_DOCUMENT_ROOT . '/product/stock/class/entrepot.class.php';

+                        require_once DOL_DOCUMENT_ROOT.'/product/stock/class/entrepot.class.php';

                         $langs->load("stocks");

                         $entrepot = new Entrepot(Config::$dbEngine);

                         $entrepot->libelle = $langs->trans("PersonalStock", $this->getFullName($langs));

@@ -1113,7 +1113,7 @@ 
                         return $this->id;

                     } else {

                         //$this->error=$interface->error;

-                        DolUtils::dol_syslog(get_class($this) . "::create " . $this->error, LOG_ERR);

+                        DolUtils::dol_syslog(get_class($this)."::create ".$this->error, LOG_ERR);

                         Config::$dbEngine->rollback();

                         return -3;

                     }

@@ -1166,7 +1166,7 @@ 
         $this->employee = 0;

 

         if (empty($login)) {

-            $login = strtolower(substr($contact->firstname, 0, 4)) . strtolower(substr($contact->lastname, 0, 4));

+            $login = strtolower(substr($contact->firstname, 0, 4)).strtolower(substr($contact->lastname, 0, 4));

         }

         $this->login = $login;

 

@@ -1175,15 +1175,15 @@ 
         // Cree et positionne $this->id

         $result = $this->create($user);

         if ($result > 0) {

-            $sql = "UPDATE " . MAIN_DB_PREFIX . "user";

-            $sql .= " SET fk_socpeople=" . $contact->id;

+            $sql = "UPDATE ".MAIN_DB_PREFIX."user";

+            $sql .= " SET fk_socpeople=".$contact->id;

             if ($contact->socid) {

-                $sql .= ", fk_soc=" . $contact->socid;

+                $sql .= ", fk_soc=".$contact->socid;

             }

-            $sql .= " WHERE rowid=" . $this->id;

+            $sql .= " WHERE rowid=".$this->id;

             $resql = Config::$dbEngine->query($sql);

 

-            DolUtils::dol_syslog(get_class($this) . "::create_from_contact", LOG_DEBUG);

+            DolUtils::dol_syslog(get_class($this)."::create_from_contact", LOG_DEBUG);

             if ($resql) {

                 $this->context['createfromcontact'] = 'createfromcontact';

 

@@ -1206,7 +1206,7 @@ 
             }

         } else {

             // $this->error deja positionne

-            DolUtils::dol_syslog(get_class($this) . "::create_from_contact - 0");

+            DolUtils::dol_syslog(get_class($this)."::create_from_contact - 0");

 

             Config::$dbEngine->rollback();

             return $result;

@@ -1241,7 +1241,7 @@ 
         $this->country_id = $member->country_id;

 

         if (empty($login)) {

-            $login = strtolower(substr($member->firstname, 0, 4)) . strtolower(substr($member->lastname, 0, 4));

+            $login = strtolower(substr($member->firstname, 0, 4)).strtolower(substr($member->lastname, 0, 4));

         }

         $this->login = $login;

 

@@ -1256,11 +1256,11 @@ 
             }

 

             if ($result > 0 && $member->fk_soc) { // If member is linked to a thirdparty

-                $sql = "UPDATE " . MAIN_DB_PREFIX . "user";

-                $sql .= " SET fk_soc=" . $member->fk_soc;

-                $sql .= " WHERE rowid=" . $this->id;

+                $sql = "UPDATE ".MAIN_DB_PREFIX."user";

+                $sql .= " SET fk_soc=".$member->fk_soc;

+                $sql .= " WHERE rowid=".$this->id;

 

-                DolUtils::dol_syslog(get_class($this) . "::create_from_member", LOG_DEBUG);

+                DolUtils::dol_syslog(get_class($this)."::create_from_member", LOG_DEBUG);

                 $resql = Config::$dbEngine->query($sql);

                 if ($resql) {

                     Config::$dbEngine->commit();

@@ -1295,9 +1295,9 @@ 
         // phpcs:enable

         global $conf;

 

-        $sql = "SELECT id FROM " . MAIN_DB_PREFIX . "rights_def";

+        $sql = "SELECT id FROM ".MAIN_DB_PREFIX."rights_def";

         $sql .= " WHERE bydefault = 1";

-        $sql .= " AND entity = " . Globals::$conf->entity;

+        $sql .= " AND entity = ".Globals::$conf->entity;

 

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

@@ -1314,10 +1314,10 @@ 
         $i = 0;

         while ($i < $num) {

 

-            $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user_rights WHERE fk_user = $this->id AND fk_id=$rd[$i]";

+            $sql = "DELETE FROM ".MAIN_DB_PREFIX."user_rights WHERE fk_user = $this->id AND fk_id=$rd[$i]";

             $result = Config::$dbEngine->query($sql);

 

-            $sql = "INSERT INTO " . MAIN_DB_PREFIX . "user_rights (fk_user, fk_id) VALUES ($this->id, $rd[$i])";

+            $sql = "INSERT INTO ".MAIN_DB_PREFIX."user_rights (fk_user, fk_id) VALUES ($this->id, $rd[$i])";

             $result = Config::$dbEngine->query($sql);

             if (!$result) {

                 return -1;

@@ -1345,7 +1345,7 @@ 
         $nbrowsaffected = 0;

         $error = 0;

 

-        DolUtils::dol_syslog(get_class($this) . "::update notrigger=" . $notrigger . ", nosyncmember=" . $nosyncmember . ", nosyncmemberpass=" . $nosyncmemberpass);

+        DolUtils::dol_syslog(get_class($this)."::update notrigger=".$notrigger.", nosyncmember=".$nosyncmember.", nosyncmemberpass=".$nosyncmemberpass);

 

         // Clean parameters

         $this->lastname = trim($this->lastname);

@@ -1373,7 +1373,7 @@ 
         $this->job = trim($this->job);

         $this->signature = trim($this->signature);

         $this->note = trim($this->note);

-        $this->openid = trim(empty($this->openid) ? '' : $this->openid);    // Avoid warning

+        $this->openid = trim(empty($this->openid) ? '' : $this->openid); // Avoid warning

         $this->admin = $this->admin ? $this->admin : 0;

         $this->address = empty($this->address) ? '' : $this->address;

         $this->zip = empty($this->zip) ? '' : $this->zip;

@@ -1398,59 +1398,59 @@ 
         Config::$dbEngine->begin();

 

         // Update datas

-        $sql = "UPDATE " . MAIN_DB_PREFIX . "user SET";

-        $sql .= " lastname = '" . Config::$dbEngine->escape($this->lastname) . "'";

-        $sql .= ", firstname = '" . Config::$dbEngine->escape($this->firstname) . "'";

-        $sql .= ", employee = " . $this->employee;

-        $sql .= ", login = '" . Config::$dbEngine->escape($this->login) . "'";

-        $sql .= ", api_key = " . ($this->api_key ? "'" . Config::$dbEngine->escape($this->api_key) . "'" : "null");

-        $sql .= ", gender = " . ($this->gender != -1 ? "'" . Config::$dbEngine->escape($this->gender) . "'" : "null"); // 'man' or 'woman'

-        $sql .= ", birth=" . (strval($this->birth) != '' ? "'" . Config::$dbEngine->idate($this->birth) . "'" : 'null');

+        $sql = "UPDATE ".MAIN_DB_PREFIX."user SET";

+        $sql .= " lastname = '".Config::$dbEngine->escape($this->lastname)."'";

+        $sql .= ", firstname = '".Config::$dbEngine->escape($this->firstname)."'";

+        $sql .= ", employee = ".$this->employee;

+        $sql .= ", login = '".Config::$dbEngine->escape($this->login)."'";

+        $sql .= ", api_key = ".($this->api_key ? "'".Config::$dbEngine->escape($this->api_key)."'" : "null");

+        $sql .= ", gender = ".($this->gender != -1 ? "'".Config::$dbEngine->escape($this->gender)."'" : "null"); // 'man' or 'woman'

+        $sql .= ", birth=".(strval($this->birth) != '' ? "'".Config::$dbEngine->idate($this->birth)."'" : 'null');

         if (!empty($user->admin)) {

-            $sql .= ", admin = " . $this->admin; // admin flag can be set/unset only by an admin user

-        }

-        $sql .= ", address = '" . Config::$dbEngine->escape($this->address) . "'";

-        $sql .= ", zip = '" . Config::$dbEngine->escape($this->zip) . "'";

-        $sql .= ", town = '" . Config::$dbEngine->escape($this->town) . "'";

-        $sql .= ", fk_state = " . ((!empty($this->state_id) && $this->state_id > 0) ? "'" . Config::$dbEngine->escape($this->state_id) . "'" : "null");

-        $sql .= ", fk_country = " . ((!empty($this->country_id) && $this->country_id > 0) ? "'" . Config::$dbEngine->escape($this->country_id) . "'" : "null");

-        $sql .= ", office_phone = '" . Config::$dbEngine->escape($this->office_phone) . "'";

-        $sql .= ", office_fax = '" . Config::$dbEngine->escape($this->office_fax) . "'";

-        $sql .= ", user_mobile = '" . Config::$dbEngine->escape($this->user_mobile) . "'";

-        $sql .= ", email = '" . Config::$dbEngine->escape($this->email) . "'";

-        $sql .= ", skype = '" . Config::$dbEngine->escape($this->skype) . "'";

-        $sql .= ", twitter = '" . Config::$dbEngine->escape($this->twitter) . "'";

-        $sql .= ", facebook = '" . Config::$dbEngine->escape($this->facebook) . "'";

-        $sql .= ", job = '" . Config::$dbEngine->escape($this->job) . "'";

-        $sql .= ", signature = '" . Config::$dbEngine->escape($this->signature) . "'";

-        $sql .= ", accountancy_code = '" . Config::$dbEngine->escape($this->accountancy_code) . "'";

-        $sql .= ", color = '" . Config::$dbEngine->escape($this->color) . "'";

-        $sql .= ", dateemployment=" . (strval($this->dateemployment) != '' ? "'" . Config::$dbEngine->idate($this->dateemployment) . "'" : 'null');

-        $sql .= ", dateemploymentend=" . (strval($this->dateemploymentend) != '' ? "'" . Config::$dbEngine->idate($this->dateemploymentend) . "'" : 'null');

-        $sql .= ", note = '" . Config::$dbEngine->escape($this->note) . "'";

-        $sql .= ", photo = " . ($this->photo ? "'" . Config::$dbEngine->escape($this->photo) . "'" : "null");

-        $sql .= ", openid = " . ($this->openid ? "'" . Config::$dbEngine->escape($this->openid) . "'" : "null");

-        $sql .= ", fk_user = " . ($this->fk_user > 0 ? "'" . Config::$dbEngine->escape($this->fk_user) . "'" : "null");

+            $sql .= ", admin = ".$this->admin; // admin flag can be set/unset only by an admin user

+        }

+        $sql .= ", address = '".Config::$dbEngine->escape($this->address)."'";

+        $sql .= ", zip = '".Config::$dbEngine->escape($this->zip)."'";

+        $sql .= ", town = '".Config::$dbEngine->escape($this->town)."'";

+        $sql .= ", fk_state = ".((!empty($this->state_id) && $this->state_id > 0) ? "'".Config::$dbEngine->escape($this->state_id)."'" : "null");

+        $sql .= ", fk_country = ".((!empty($this->country_id) && $this->country_id > 0) ? "'".Config::$dbEngine->escape($this->country_id)."'" : "null");

+        $sql .= ", office_phone = '".Config::$dbEngine->escape($this->office_phone)."'";

+        $sql .= ", office_fax = '".Config::$dbEngine->escape($this->office_fax)."'";

+        $sql .= ", user_mobile = '".Config::$dbEngine->escape($this->user_mobile)."'";

+        $sql .= ", email = '".Config::$dbEngine->escape($this->email)."'";

+        $sql .= ", skype = '".Config::$dbEngine->escape($this->skype)."'";

+        $sql .= ", twitter = '".Config::$dbEngine->escape($this->twitter)."'";

+        $sql .= ", facebook = '".Config::$dbEngine->escape($this->facebook)."'";

+        $sql .= ", job = '".Config::$dbEngine->escape($this->job)."'";

+        $sql .= ", signature = '".Config::$dbEngine->escape($this->signature)."'";

+        $sql .= ", accountancy_code = '".Config::$dbEngine->escape($this->accountancy_code)."'";

+        $sql .= ", color = '".Config::$dbEngine->escape($this->color)."'";

+        $sql .= ", dateemployment=".(strval($this->dateemployment) != '' ? "'".Config::$dbEngine->idate($this->dateemployment)."'" : 'null');

+        $sql .= ", dateemploymentend=".(strval($this->dateemploymentend) != '' ? "'".Config::$dbEngine->idate($this->dateemploymentend)."'" : 'null');

+        $sql .= ", note = '".Config::$dbEngine->escape($this->note)."'";

+        $sql .= ", photo = ".($this->photo ? "'".Config::$dbEngine->escape($this->photo)."'" : "null");

+        $sql .= ", openid = ".($this->openid ? "'".Config::$dbEngine->escape($this->openid)."'" : "null");

+        $sql .= ", fk_user = ".($this->fk_user > 0 ? "'".Config::$dbEngine->escape($this->fk_user)."'" : "null");

         if (isset($this->thm) || $this->thm != '') {

-            $sql .= ", thm= " . ($this->thm != '' ? "'" . Config::$dbEngine->escape($this->thm) . "'" : "null");

+            $sql .= ", thm= ".($this->thm != '' ? "'".Config::$dbEngine->escape($this->thm)."'" : "null");

         }

         if (isset($this->tjm) || $this->tjm != '') {

-            $sql .= ", tjm= " . ($this->tjm != '' ? "'" . Config::$dbEngine->escape($this->tjm) . "'" : "null");

+            $sql .= ", tjm= ".($this->tjm != '' ? "'".Config::$dbEngine->escape($this->tjm)."'" : "null");

         }

         if (isset($this->salary) || $this->salary != '') {

-            $sql .= ", salary= " . ($this->salary != '' ? "'" . Config::$dbEngine->escape($this->salary) . "'" : "null");

+            $sql .= ", salary= ".($this->salary != '' ? "'".Config::$dbEngine->escape($this->salary)."'" : "null");

         }

         if (isset($this->salaryextra) || $this->salaryextra != '') {

-            $sql .= ", salaryextra= " . ($this->salaryextra != '' ? "'" . Config::$dbEngine->escape($this->salaryextra) . "'" : "null");

+            $sql .= ", salaryextra= ".($this->salaryextra != '' ? "'".Config::$dbEngine->escape($this->salaryextra)."'" : "null");

         }

-        $sql .= ", weeklyhours= " . ($this->weeklyhours != '' ? "'" . Config::$dbEngine->escape($this->weeklyhours) . "'" : "null");

-        $sql .= ", entity = '" . Config::$dbEngine->escape($this->entity) . "'";

-        $sql .= ", default_range = " . ($this->default_range > 0 ? $this->default_range : 'null');

-        $sql .= ", default_c_exp_tax_cat = " . ($this->default_c_exp_tax_cat > 0 ? $this->default_c_exp_tax_cat : 'null');

+        $sql .= ", weeklyhours= ".($this->weeklyhours != '' ? "'".Config::$dbEngine->escape($this->weeklyhours)."'" : "null");

+        $sql .= ", entity = '".Config::$dbEngine->escape($this->entity)."'";

+        $sql .= ", default_range = ".($this->default_range > 0 ? $this->default_range : 'null');

+        $sql .= ", default_c_exp_tax_cat = ".($this->default_c_exp_tax_cat > 0 ? $this->default_c_exp_tax_cat : 'null');

 

-        $sql .= " WHERE rowid = " . $this->id;

+        $sql .= " WHERE rowid = ".$this->id;

 

-        DolUtils::dol_syslog(get_class($this) . "::update", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::update", LOG_DEBUG);

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

             $nbrowsaffected += Config::$dbEngine->affected_rows($resql);

@@ -1468,8 +1468,8 @@ 
 

             // If user is linked to a member, remove old link to this member

             if ($this->fk_member > 0) {

-                DolUtils::dol_syslog(get_class($this) . "::update remove link with member. We will recreate it later", LOG_DEBUG);

-                $sql = "UPDATE " . MAIN_DB_PREFIX . "user SET fk_member = NULL where fk_member = " . $this->fk_member;

+                DolUtils::dol_syslog(get_class($this)."::update remove link with member. We will recreate it later", LOG_DEBUG);

+                $sql = "UPDATE ".MAIN_DB_PREFIX."user SET fk_member = NULL where fk_member = ".$this->fk_member;

                 $resql = Config::$dbEngine->query($sql);

                 if (!$resql) {

                     $this->error = Config::$dbEngine->error();

@@ -1478,8 +1478,8 @@ 
                 }

             }

             // Set link to user

-            DolUtils::dol_syslog(get_class($this) . "::update set link with member", LOG_DEBUG);

-            $sql = "UPDATE " . MAIN_DB_PREFIX . "user SET fk_member =" . ($this->fk_member > 0 ? $this->fk_member : 'null') . " where rowid = " . $this->id;

+            DolUtils::dol_syslog(get_class($this)."::update set link with member", LOG_DEBUG);

+            $sql = "UPDATE ".MAIN_DB_PREFIX."user SET fk_member =".($this->fk_member > 0 ? $this->fk_member : 'null')." where rowid = ".$this->id;

             $resql = Config::$dbEngine->query($sql);

             if (!$resql) {

                 $this->error = Config::$dbEngine->error();

@@ -1489,9 +1489,9 @@ 
 

             if ($nbrowsaffected) { // If something has changed in data

                 if ($this->fk_member > 0 && !$nosyncmember) {

-                    DolUtils::dol_syslog(get_class($this) . "::update user is linked with a member. We try to update member too.", LOG_DEBUG);

+                    DolUtils::dol_syslog(get_class($this)."::update user is linked with a member. We try to update member too.", LOG_DEBUG);

 

-                    require_once DOL_DOCUMENT_ROOT . '/adherents/class/adherent.class.php';

+                    require_once DOL_DOCUMENT_ROOT.'/adherents/class/adherent.class.php';

 

                     // This user is linked with a member, so we also update member information

                     // if this is an update.

@@ -1531,7 +1531,7 @@ 
                         if ($result < 0) {

                             $this->error = $adh->error;

                             $this->errors = $adh->errors;

-                            DolUtils::dol_syslog(get_class($this) . "::update error after calling adh->update to sync it with user: " . $this->error, LOG_ERR);

+                            DolUtils::dol_syslog(get_class($this)."::update error after calling adh->update to sync it with user: ".$this->error, LOG_ERR);

                             $error++;

                         }

                     } else {

@@ -1542,9 +1542,9 @@ 
                 }

 

                 if ($this->contact_id > 0 && !$nosynccontact) {

-                    DolUtils::dol_syslog(get_class($this) . "::update user is linked with a contact. We try to update contact too.", LOG_DEBUG);

+                    DolUtils::dol_syslog(get_class($this)."::update user is linked with a contact. We try to update contact too.", LOG_DEBUG);

 

-                    require_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';

+                    require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

 

                     // This user is linked with a contact, so we also update contact information

                     // if this is an update.

@@ -1584,7 +1584,7 @@ 
                         if ($result < 0) {

                             $this->error = $tmpobj->error;

                             $this->errors = $tmpobj->errors;

-                            DolUtils::dol_syslog(get_class($this) . "::update error after calling adh->update to sync it with user: " . $this->error, LOG_ERR);

+                            DolUtils::dol_syslog(get_class($this)."::update error after calling adh->update to sync it with user: ".$this->error, LOG_ERR);

                             $error++;

                         }

                     } else {

@@ -1618,7 +1618,7 @@ 
                 Config::$dbEngine->commit();

                 return $nbrowsaffected;

             } else {

-                DolUtils::dol_syslog(get_class($this) . "::update error=" . $this->error, LOG_ERR);

+                DolUtils::dol_syslog(get_class($this)."::update error=".$this->error, LOG_ERR);

                 Config::$dbEngine->rollback();

                 return -1;

             }

@@ -1641,20 +1641,20 @@ 
         // phpcs:enable

         $now = dol_now();

 

-        $sql = "UPDATE " . MAIN_DB_PREFIX . "user SET";

+        $sql = "UPDATE ".MAIN_DB_PREFIX."user SET";

         $sql .= " datepreviouslogin = datelastlogin,";

-        $sql .= " datelastlogin = '" . Config::$dbEngine->idate($now) . "',";

-        $sql .= " tms = tms";    // La date de derniere modif doit changer sauf pour la mise a jour de date de derniere connexion

-        $sql .= " WHERE rowid = " . $this->id;

+        $sql .= " datelastlogin = '".Config::$dbEngine->idate($now)."',";

+        $sql .= " tms = tms"; // La date de derniere modif doit changer sauf pour la mise a jour de date de derniere connexion

+        $sql .= " WHERE rowid = ".$this->id;

 

-        DolUtils::dol_syslog(get_class($this) . "::update_last_login_date user->id=" . $this->id . " " . $sql, LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::update_last_login_date user->id=".$this->id." ".$sql, LOG_DEBUG);

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

             $this->datepreviouslogin = $this->datelastlogin;

             $this->datelastlogin = $now;

             return 1;

         } else {

-            $this->error = Config::$dbEngine->lasterror() . ' sql=' . $sql;

+            $this->error = Config::$dbEngine->lasterror().' sql='.$sql;

             return -1;

         }

     }

@@ -1672,11 +1672,11 @@ 
     function setPassword($user, $password = '', $changelater = 0, $notrigger = 0, $nosyncmember = 0)

     {

         global $conf, $langs;

-        require_once DOL_DOCUMENT_ROOT . '/core/lib/security2.lib.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

 

         $error = 0;

 

-        DolUtils::dol_syslog(get_class($this) . "::setPassword user=" . $user->id . " password=" . preg_replace('/./i', '*', $password) . " changelater=" . $changelater . " notrigger=" . $notrigger . " nosyncmember=" . $nosyncmember, LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::setPassword user=".$user->id." password=".preg_replace('/./i', '*', $password)." changelater=".$changelater." notrigger=".$notrigger." nosyncmember=".$nosyncmember, LOG_DEBUG);

 

         // If new password not provided, we generate one

         if (!$password) {

@@ -1694,17 +1694,17 @@ 
 

             Config::$dbEngine->begin();

 

-            $sql = "UPDATE " . MAIN_DB_PREFIX . "user";

-            $sql .= " SET pass_crypted = '" . Config::$dbEngine->escape($password_crypted) . "',";

+            $sql = "UPDATE ".MAIN_DB_PREFIX."user";

+            $sql .= " SET pass_crypted = '".Config::$dbEngine->escape($password_crypted)."',";

             $sql .= " pass_temp = null";

             if (!empty($conf->global->DATABASE_PWD_ENCRYPTED)) {

                 $sql .= ", pass = null";

             } else {

-                $sql .= ", pass = '" . Config::$dbEngine->escape($password) . "'";

+                $sql .= ", pass = '".Config::$dbEngine->escape($password)."'";

             }

-            $sql .= " WHERE rowid = " . $this->id;

+            $sql .= " WHERE rowid = ".$this->id;

 

-            DolUtils::dol_syslog(get_class($this) . "::setPassword", LOG_DEBUG);

+            DolUtils::dol_syslog(get_class($this)."::setPassword", LOG_DEBUG);

             $result = Config::$dbEngine->query($sql);

             if ($result) {

                 if (Config::$dbEngine->affected_rows($result)) {

@@ -1713,7 +1713,7 @@ 
                     $this->pass_indatabase_crypted = $password_crypted;

 

                     if ($this->fk_member && !$nosyncmember) {

-                        require_once DOL_DOCUMENT_ROOT . '/adherents/class/adherent.class.php';

+                        require_once DOL_DOCUMENT_ROOT.'/adherents/class/adherent.class.php';

 

                         // This user is linked with a member, so we also update members informations

                         // if this is an update.

@@ -1724,7 +1724,7 @@ 
                             $result = $adh->setPassword($user, $this->pass, (empty($conf->global->DATABASE_PWD_ENCRYPTED) ? 0 : 1), 1); // Cryptage non gere dans module adherent

                             if ($result < 0) {

                                 $this->error = $adh->error;

-                                DolUtils::dol_syslog(get_class($this) . "::setPassword " . $this->error, LOG_ERR);

+                                DolUtils::dol_syslog(get_class($this)."::setPassword ".$this->error, LOG_ERR);

                                 $error++;

                             }

                         } else {

@@ -1733,7 +1733,7 @@ 
                         }

                     }

 

-                    DolUtils::dol_syslog(get_class($this) . "::setPassword notrigger=" . $notrigger . " error=" . $error, LOG_DEBUG);

+                    DolUtils::dol_syslog(get_class($this)."::setPassword notrigger=".$notrigger." error=".$error, LOG_DEBUG);

 

                     if (!$error && !$notrigger) {

                         // Call trigger

@@ -1760,11 +1760,11 @@ 
         } else {

             // We store clear password in password temporary field.

             // After receiving confirmation link, we will crypt it and store it in pass_crypted

-            $sql = "UPDATE " . MAIN_DB_PREFIX . "user";

-            $sql .= " SET pass_temp = '" . Config::$dbEngine->escape($password) . "'";

-            $sql .= " WHERE rowid = " . $this->id;

+            $sql = "UPDATE ".MAIN_DB_PREFIX."user";

+            $sql .= " SET pass_temp = '".Config::$dbEngine->escape($password)."'";

+            $sql .= " WHERE rowid = ".$this->id;

 

-            DolUtils::dol_syslog(get_class($this) . "::setPassword", LOG_DEBUG); // No log

+            DolUtils::dol_syslog(get_class($this)."::setPassword", LOG_DEBUG); // No log

             $result = Config::$dbEngine->query($sql);

             if ($result) {

                 return $password;

@@ -1790,7 +1790,7 @@ 
         global $conf, $langs;

         global $dolibarr_main_url_root;

 

-        require_once DOL_DOCUMENT_ROOT . '/core/class/CMailFile.class.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/class/CMailFile.class.php';

 

         $msgishtml = 0;

 

@@ -1815,36 +1815,36 @@ 
         $subject = $outputlangs->transnoentitiesnoconv("SubjectNewPassword", $appli);

 

         // Define $urlwithroot

-        $urlwithouturlroot = preg_replace('/' . preg_quote(DOL_URL_ROOT, '/') . '$/i', '', trim($dolibarr_main_url_root));

-        $urlwithroot = $urlwithouturlroot . DOL_URL_ROOT;  // This is to use external domain name found into config file

+        $urlwithouturlroot = preg_replace('/'.preg_quote(DOL_URL_ROOT, '/').'$/i', '', trim($dolibarr_main_url_root));

+        $urlwithroot = $urlwithouturlroot.DOL_URL_ROOT; // This is to use external domain name found into config file

 

         if (!$changelater) {

-            $url = $urlwithroot . '/';

+            $url = $urlwithroot.'/';

 

-            $mesg .= $outputlangs->transnoentitiesnoconv("RequestToResetPasswordReceived") . ".\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("NewKeyIs") . " :\n\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("Login") . " = " . $this->login . "\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("Password") . " = " . $password . "\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("RequestToResetPasswordReceived").".\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("NewKeyIs")." :\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("Login")." = ".$this->login."\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("Password")." = ".$password."\n\n";

             $mesg .= "\n";

 

-            $mesg .= $outputlangs->transnoentitiesnoconv("ClickHereToGoTo", $appli) . ': ' . $url . "\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("ClickHereToGoTo", $appli).': '.$url."\n\n";

             $mesg .= "--\n";

             $mesg .= $user->getFullName($outputlangs); // Username that make then sending

 

-            DolUtils::dol_syslog(get_class($this) . "::send_password changelater is off, url=" . $url);

+            DolUtils::dol_syslog(get_class($this)."::send_password changelater is off, url=".$url);

         } else {

-            $url = $urlwithroot . '/user/passwordforgotten.php?action=validatenewpassword&username=' . $this->login . "&passwordhash=" . dol_hash($password);

+            $url = $urlwithroot.'/user/passwordforgotten.php?action=validatenewpassword&username='.$this->login."&passwordhash=".dol_hash($password);

 

-            $mesg .= $outputlangs->transnoentitiesnoconv("RequestToResetPasswordReceived") . "\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("NewKeyWillBe") . " :\n\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("Login") . " = " . $this->login . "\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("Password") . " = " . $password . "\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("RequestToResetPasswordReceived")."\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("NewKeyWillBe")." :\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("Login")." = ".$this->login."\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("Password")." = ".$password."\n\n";

             $mesg .= "\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("YouMustClickToChange") . " :\n";

-            $mesg .= $url . "\n\n";

-            $mesg .= $outputlangs->transnoentitiesnoconv("ForgetIfNothing") . "\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("YouMustClickToChange")." :\n";

+            $mesg .= $url."\n\n";

+            $mesg .= $outputlangs->transnoentitiesnoconv("ForgetIfNothing")."\n\n";

 

-            DolUtils::dol_syslog(get_class($this) . "::send_password changelater is on, url=" . $url);

+            DolUtils::dol_syslog(get_class($this)."::send_password changelater is on, url=".$url);

         }

 

         $mailfile = new CMailFile(

@@ -1855,7 +1855,7 @@ 
             return 1;

         } else {

             $langs->trans("errors");

-            $this->error = $langs->trans("ErrorFailedToSendPassword") . ' ' . $mailfile->error;

+            $this->error = $langs->trans("ErrorFailedToSendPassword").' '.$mailfile->error;

             return -1;

         }

     }

@@ -1880,8 +1880,8 @@ 
     {

         // phpcs:enable

         $sql = "SELECT url, login, pass, poste ";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user_clicktodial as u";

-        $sql .= " WHERE u.fk_user = " . $this->id;

+        $sql .= " FROM ".MAIN_DB_PREFIX."user_clicktodial as u";

+        $sql .= " WHERE u.fk_user = ".$this->id;

 

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

@@ -1915,21 +1915,21 @@ 
         // phpcs:enable

         Config::$dbEngine->begin();

 

-        $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user_clicktodial";

-        $sql .= " WHERE fk_user = " . $this->id;

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."user_clicktodial";

+        $sql .= " WHERE fk_user = ".$this->id;

 

-        DolUtils::dol_syslog(get_class($this) . '::update_clicktodial', LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this).'::update_clicktodial', LOG_DEBUG);

         $result = Config::$dbEngine->query($sql);

 

-        $sql = "INSERT INTO " . MAIN_DB_PREFIX . "user_clicktodial";

+        $sql = "INSERT INTO ".MAIN_DB_PREFIX."user_clicktodial";

         $sql .= " (fk_user,url,login,pass,poste)";

-        $sql .= " VALUES (" . $this->id;

-        $sql .= ", '" . Config::$dbEngine->escape($this->clicktodial_url) . "'";

-        $sql .= ", '" . Config::$dbEngine->escape($this->clicktodial_login) . "'";

-        $sql .= ", '" . Config::$dbEngine->escape($this->clicktodial_password) . "'";

-        $sql .= ", '" . Config::$dbEngine->escape($this->clicktodial_poste) . "')";

+        $sql .= " VALUES (".$this->id;

+        $sql .= ", '".Config::$dbEngine->escape($this->clicktodial_url)."'";

+        $sql .= ", '".Config::$dbEngine->escape($this->clicktodial_login)."'";

+        $sql .= ", '".Config::$dbEngine->escape($this->clicktodial_password)."'";

+        $sql .= ", '".Config::$dbEngine->escape($this->clicktodial_poste)."')";

 

-        DolUtils::dol_syslog(get_class($this) . '::update_clicktodial', LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this).'::update_clicktodial', LOG_DEBUG);

         $result = Config::$dbEngine->query($sql);

         if ($result) {

             Config::$dbEngine->commit();

@@ -1959,20 +1959,20 @@ 
 

         Config::$dbEngine->begin();

 

-        $sql = "DELETE FROM " . MAIN_DB_PREFIX . "usergroup_user";

-        $sql .= " WHERE fk_user  = " . $this->id;

-        $sql .= " AND fk_usergroup = " . $group;

-        $sql .= " AND entity = " . $entity;

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."usergroup_user";

+        $sql .= " WHERE fk_user  = ".$this->id;

+        $sql .= " AND fk_usergroup = ".$group;

+        $sql .= " AND entity = ".$entity;

 

         $result = Config::$dbEngine->query($sql);

 

-        $sql = "INSERT INTO " . MAIN_DB_PREFIX . "usergroup_user (entity, fk_user, fk_usergroup)";

-        $sql .= " VALUES (" . $entity . "," . $this->id . "," . $group . ")";

+        $sql = "INSERT INTO ".MAIN_DB_PREFIX."usergroup_user (entity, fk_user, fk_usergroup)";

+        $sql .= " VALUES (".$entity.",".$this->id.",".$group.")";

 

         $result = Config::$dbEngine->query($sql);

         if ($result) {

             if (!$error && !$notrigger) {

-                $this->newgroupid = $group;    // deprecated. Remove this.

+                $this->newgroupid = $group; // deprecated. Remove this.

                 $this->context = array('audit' => $langs->trans("UserSetInGroup"), 'newgroupid' => $group);

 

                 // Call trigger

@@ -1987,7 +1987,7 @@ 
                 Config::$dbEngine->commit();

                 return 1;

             } else {

-                DolUtils::dol_syslog(get_class($this) . "::SetInGroup " . $this->error, LOG_ERR);

+                DolUtils::dol_syslog(get_class($this)."::SetInGroup ".$this->error, LOG_ERR);

                 Config::$dbEngine->rollback();

                 return -2;

             }

@@ -2016,15 +2016,15 @@ 
 

         Config::$dbEngine->begin();

 

-        $sql = "DELETE FROM " . MAIN_DB_PREFIX . "usergroup_user";

-        $sql .= " WHERE fk_user  = " . $this->id;

-        $sql .= " AND fk_usergroup = " . $group;

-        $sql .= " AND entity = " . $entity;

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."usergroup_user";

+        $sql .= " WHERE fk_user  = ".$this->id;

+        $sql .= " AND fk_usergroup = ".$group;

+        $sql .= " AND entity = ".$entity;

 

         $result = Config::$dbEngine->query($sql);

         if ($result) {

             if (!$error && !$notrigger) {

-                $this->oldgroupid = $group;    // deprecated. Remove this.

+                $this->oldgroupid = $group; // deprecated. Remove this.

                 $this->context = array('audit' => $langs->trans("UserRemovedFromGroup"), 'oldgroupid' => $group);

 

                 // Call trigger

@@ -2040,7 +2040,7 @@ 
                 return 1;

             } else {

                 $this->error = $interface->error;

-                DolUtils::dol_syslog(get_class($this) . "::RemoveFromGroup " . $this->error, LOG_ERR);

+                DolUtils::dol_syslog(get_class($this)."::RemoveFromGroup ".$this->error, LOG_ERR);

                 Config::$dbEngine->rollback();

                 return -2;

             }

@@ -2064,7 +2064,7 @@ 
     function getPhotoUrl($width, $height, $cssclass = '', $imagesize = '')

     {

         // $result = '<a href="' . DOL_URL_ROOT . '/user/card.php?id=' . $this->id . '">';

-        $result = '<a href="' . BASE_URI . '?controller=user&method=card&id=' . $this->id . '">';

+        $result = '<a href="'.BASE_URI.'?controller=user&method=card&id='.$this->id.'">';

         $result .= Form::showphoto('userphoto', $this, $width, $height, 0, $cssclass, $imagesize);

         $result .= '</a>';

 

@@ -2114,49 +2114,49 @@ 
 

         // Info Login

         $label .= '<div class="centpercent">';

-        $label .= '<u>' . $langs->trans("User") . '</u><br>';

-        $label .= '<b>' . $langs->trans('Name') . ':</b> ' . $this->getFullName($langs, '');

+        $label .= '<u>'.$langs->trans("User").'</u><br>';

+        $label .= '<b>'.$langs->trans('Name').':</b> '.$this->getFullName($langs, '');

         if (!empty($this->login)) {

-            $label .= '<br><b>' . $langs->trans('Login') . ':</b> ' . $this->login;

+            $label .= '<br><b>'.$langs->trans('Login').':</b> '.$this->login;

         }

-        $label .= '<br><b>' . $langs->trans("EMail") . ':</b> ' . $this->email;

+        $label .= '<br><b>'.$langs->trans("EMail").':</b> '.$this->email;

         if (!empty($this->admin)) {

-            $label .= '<br><b>' . $langs->trans("Administrator") . '</b>: ' . yn($this->admin);

+            $label .= '<br><b>'.$langs->trans("Administrator").'</b>: '.yn($this->admin);

         }

         if (!empty($this->socid)) { // Add thirdparty for external users

             $thirdpartystatic = new Societe($db);

             $thirdpartystatic->fetch($this->socid);

             if (empty($hidethirdpartylogo)) {

-                $companylink = ' ' . $thirdpartystatic->getNomUrl(2, (($option == 'nolink') ? 'nolink' : '')); // picto only of company

+                $companylink = ' '.$thirdpartystatic->getNomUrl(2, (($option == 'nolink') ? 'nolink' : '')); // picto only of company

             }

-            $company = ' (' . $langs->trans("Company") . ': ' . $thirdpartystatic->name . ')';

+            $company = ' ('.$langs->trans("Company").': '.$thirdpartystatic->name.')';

         }

-        $type = ($this->socid ? $langs->trans("External") . $company : $langs->trans("Internal"));

-        $label .= '<br><b>' . $langs->trans("Type") . ':</b> ' . $type;

-        $label .= '<br><b>' . $langs->trans("Status") . '</b>: ' . $this->getLibStatut(0);

+        $type = ($this->socid ? $langs->trans("External").$company : $langs->trans("Internal"));

+        $label .= '<br><b>'.$langs->trans("Type").':</b> '.$type;

+        $label .= '<br><b>'.$langs->trans("Status").'</b>: '.$this->getLibStatut(0);

         $label .= '</div>';

         if ($infologin > 0) {

             $label .= '<br>';

-            $label .= '<br><u>' . $langs->trans("Connection") . '</u>';

-            $label .= '<br><b>' . $langs->trans("IPAddress") . '</b>: ' . $_SERVER["REMOTE_ADDR"];

+            $label .= '<br><u>'.$langs->trans("Connection").'</u>';

+            $label .= '<br><b>'.$langs->trans("IPAddress").'</b>: '.$_SERVER["REMOTE_ADDR"];

             if (!empty($conf->global->MAIN_MODULE_MULTICOMPANY)) {

-                $label .= '<br><b>' . $langs->trans("ConnectedOnMultiCompany") . ':</b> ' . Globals::$conf->entity . ' (user entity ' . $this->entity . ')';

+                $label .= '<br><b>'.$langs->trans("ConnectedOnMultiCompany").':</b> '.Globals::$conf->entity.' (user entity '.$this->entity.')';

             }

-            $label .= '<br><b>' . $langs->trans("AuthenticationMode") . ':</b> ' . $_SESSION["dol_authmode"] . (empty($dolibarr_main_demo) ? '' : ' (demo)');

-            $label .= '<br><b>' . $langs->trans("ConnectedSince") . ':</b> ' . dol_print_date($this->datelastlogin, "dayhour", 'tzuser');

-            $label .= '<br><b>' . $langs->trans("PreviousConnexion") . ':</b> ' . dol_print_date($this->datepreviouslogin, "dayhour", 'tzuser');

-            $label .= '<br><b>' . $langs->trans("CurrentTheme") . ':</b> ' . Globals::$conf->theme;

-            $label .= '<br><b>' . $langs->trans("CurrentMenuManager") . ':</b> ' . $menumanager->name;

+            $label .= '<br><b>'.$langs->trans("AuthenticationMode").':</b> '.$_SESSION["dol_authmode"].(empty($dolibarr_main_demo) ? '' : ' (demo)');

+            $label .= '<br><b>'.$langs->trans("ConnectedSince").':</b> '.dol_print_date($this->datelastlogin, "dayhour", 'tzuser');

+            $label .= '<br><b>'.$langs->trans("PreviousConnexion").':</b> '.dol_print_date($this->datepreviouslogin, "dayhour", 'tzuser');

+            $label .= '<br><b>'.$langs->trans("CurrentTheme").':</b> '.Globals::$conf->theme;

+            $label .= '<br><b>'.$langs->trans("CurrentMenuManager").':</b> '.$menumanager->name;

             $s = picto_from_langcode($langs->getDefaultLang());

-            $label .= '<br><b>' . $langs->trans("CurrentUserLanguage") . ':</b> ' . ($s ? $s . ' ' : '') . $langs->getDefaultLang();

-            $label .= '<br><b>' . $langs->trans("Browser") . ':</b> ' . Globals::$conf->browser->name . ($conf->browser->version ? ' ' . Globals::$conf->browser->version : '') . ' (' . $_SERVER['HTTP_USER_AGENT'] . ')';

-            $label .= '<br><b>' . $langs->trans("Layout") . ':</b> ' . Globals::$conf->browser->layout;

-            $label .= '<br><b>' . $langs->trans("Screen") . ':</b> ' . $_SESSION['dol_screenwidth'] . ' x ' . $_SESSION['dol_screenheight'];

+            $label .= '<br><b>'.$langs->trans("CurrentUserLanguage").':</b> '.($s ? $s.' ' : '').$langs->getDefaultLang();

+            $label .= '<br><b>'.$langs->trans("Browser").':</b> '.Globals::$conf->browser->name.($conf->browser->version ? ' '.Globals::$conf->browser->version : '').' ('.$_SERVER['HTTP_USER_AGENT'].')';

+            $label .= '<br><b>'.$langs->trans("Layout").':</b> '.Globals::$conf->browser->layout;

+            $label .= '<br><b>'.$langs->trans("Screen").':</b> '.$_SESSION['dol_screenwidth'].' x '.$_SESSION['dol_screenheight'];

             if ($conf->browser->layout == 'phone') {

-                $label .= '<br><b>' . $langs->trans("Phone") . ':</b> ' . $langs->trans("Yes");

+                $label .= '<br><b>'.$langs->trans("Phone").':</b> '.$langs->trans("Yes");

             }

             if (!empty($_SESSION["disablemodules"])) {

-                $label .= '<br><b>' . $langs->trans("DisabledModules") . ':</b> <br>' . join(', ', explode(',', $_SESSION["disablemodules"]));

+                $label .= '<br><b>'.$langs->trans("DisabledModules").':</b> <br>'.join(', ', explode(',', $_SESSION["disablemodules"]));

             }

         }

         if ($infologin < 0) {

@@ -2164,10 +2164,10 @@ 
         }

 

         // $url = DOL_URL_ROOT . '/user/card.php?id=' . $this->id;

-        $url = BASE_URI . '?controller=user&method=card&id=' . $this->id;

+        $url = BASE_URI.'?controller=user&method=card&id='.$this->id;

         if ($option == 'leave') {

             //$url = DOL_URL_ROOT . '/holiday/list.php?id=' . $this->id;

-            $url = BASE_URI . '?controller=holiday&method=list&id=' . $this->id;

+            $url = BASE_URI.'?controller=holiday&method=list&id='.$this->id;

         }

         if ($option != 'nolink') {

             // Add param to save lastsearch_values or not

@@ -2180,16 +2180,16 @@ 
             }

         }

 

-        $linkstart = '<a href="' . $url . '"';

+        $linkstart = '<a href="'.$url.'"';

         $linkclose = "";

         if (empty($notooltip)) {

             if (!empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) {

                 $langs->load("users");

                 $label = $langs->trans("ShowUser");

-                $linkclose .= ' alt="' . dol_escape_htmltag($label, 1) . '"';

+                $linkclose .= ' alt="'.dol_escape_htmltag($label, 1).'"';

             }

-            $linkclose .= ' title="' . dol_escape_htmltag($label, 1) . '"';

-            $linkclose .= ' class="classfortooltip' . ($morecss ? ' ' . $morecss : '') . '"';

+            $linkclose .= ' title="'.dol_escape_htmltag($label, 1).'"';

+            $linkclose .= ' class="classfortooltip'.($morecss ? ' '.$morecss : '').'"';

 

             /*

               $hookmanager->initHooks(array('userdao'));

@@ -2199,7 +2199,7 @@ 
              */

         }

 

-        $linkstart .= $linkclose . '>';

+        $linkstart .= $linkclose.'>';

         $linkend = '</a>';

 

         //if ($withpictoimg == -1) $result.='<div class="nowrap">';

@@ -2211,15 +2211,15 @@ 
             }

             // Only picto

             if ($withpictoimg > 0) {

-                $picto = '<!-- picto user --><div class="inline-block nopadding userimg' . ($morecss ? ' ' . $morecss : '') . '">' . img_object('', 'user', $paddafterimage . ' ' . ($notooltip ? '' : 'class="classfortooltip"'), 0, 0, $notooltip ? 0 : 1) . '</div>';

+                $picto = '<!-- picto user --><div class="inline-block nopadding userimg'.($morecss ? ' '.$morecss : '').'">'.img_object('', 'user', $paddafterimage.' '.($notooltip ? '' : 'class="classfortooltip"'), 0, 0, $notooltip ? 0 : 1).'</div>';

             } else { // Picto must be a photo

-                $picto = '<!-- picto photo user --><div class="inline-block nopadding userimg' . ($morecss ? ' ' . $morecss : '') . '"' . ($paddafterimage ? ' ' . $paddafterimage : '') . '>' . Form::showphoto('userphoto', $this, 0, 0, 0, 'userphoto' . ($withpictoimg == -3 ? 'small' : ''), 'mini', 0, 1) . '</div>';

+                $picto = '<!-- picto photo user --><div class="inline-block nopadding userimg'.($morecss ? ' '.$morecss : '').'"'.($paddafterimage ? ' '.$paddafterimage : '').'>'.Form::showphoto('userphoto', $this, 0, 0, 0, 'userphoto'.($withpictoimg == -3 ? 'small' : ''), 'mini', 0, 1).'</div>';

             }

             $result .= $picto;

         }

         if ($withpictoimg > -2 && $withpictoimg != 2) {

             if (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) {

-                $result .= '<div class="inline-block nopadding valignmiddle usertext' . ((!isset($this->statut) || $this->statut) ? '' : ' strikefordisabled') . ($morecss ? ' ' . $morecss : '') . '">';

+                $result .= '<div class="inline-block nopadding valignmiddle usertext'.((!isset($this->statut) || $this->statut) ? '' : ' strikefordisabled').($morecss ? ' '.$morecss : '').'">';

             }

             if ($mode == 'login') {

                 $result .= dol_trunc($this->login, $maxlen);

@@ -2237,7 +2237,7 @@ 
         global $action;

         $hookmanager->initHooks(array('userdao'));

         $parameters = array('id' => $this->id, 'getnomurl' => $result);

-        $reshook = $hookmanager->executeHooks('getNomUrl', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

+        $reshook = $hookmanager->executeHooks('getNomUrl', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

         if ($reshook > 0) {

             $result = $hookmanager->resPrint;

         } else {

@@ -2261,7 +2261,7 @@ 
         $result = '';

 

         // $linkstart = '<a href="'.DOL_URL_ROOT.'/user/card.php?id='.$this->id.'">';

-        $linkstart = '<a href="' . BASE_URI . '?controller=user&method=card&id=' . $this->id . '">';

+        $linkstart = '<a href="'.BASE_URI.'?controller=user&method=card&id='.$this->id.'">';

         $linkend = '</a>';

 

         //Check user's rights to see an other user

@@ -2271,7 +2271,7 @@ 
 

         if ($option == 'xxx') {

             //$linkstart = '<a href="'.DOL_URL_ROOT.'/user/card.php?id='.$this->id.'">';

-            $linkstart = '<a href="' . BASE_URI . '?controller=user&method=card.php&id=' . $this->id . '">';

+            $linkstart = '<a href="'.BASE_URI.'?controller=user&method=card.php&id='.$this->id.'">';

             $linkend = '</a>';

         }

 

@@ -2328,9 +2328,9 @@ 
             }

         } elseif ($mode == 2) {

             if ($statut == 1) {

-                return img_picto($langs->trans('Enabled'), 'statut4', 'class="pictostatus"') . ' ' . $langs->trans('Enabled');

+                return img_picto($langs->trans('Enabled'), 'statut4', 'class="pictostatus"').' '.$langs->trans('Enabled');

             } elseif ($statut == 0) {

-                return img_picto($langs->trans('Disabled'), 'statut5', 'class="pictostatus"') . ' ' . $langs->trans('Disabled');

+                return img_picto($langs->trans('Disabled'), 'statut5', 'class="pictostatus"').' '.$langs->trans('Disabled');

             }

         } elseif ($mode == 3) {

             if ($statut == 1) {

@@ -2340,15 +2340,15 @@ 
             }

         } elseif ($mode == 4) {

             if ($statut == 1) {

-                return img_picto($langs->trans('Enabled'), 'statut4', 'class="pictostatus"') . ' ' . $langs->trans('Enabled');

+                return img_picto($langs->trans('Enabled'), 'statut4', 'class="pictostatus"').' '.$langs->trans('Enabled');

             } elseif ($statut == 0) {

-                return img_picto($langs->trans('Disabled'), 'statut5', 'class="pictostatus"') . ' ' . $langs->trans('Disabled');

+                return img_picto($langs->trans('Disabled'), 'statut5', 'class="pictostatus"').' '.$langs->trans('Disabled');

             }

         } elseif ($mode == 5) {

             if ($statut == 1) {

-                return $langs->trans('Enabled') . ' ' . img_picto($langs->trans('Enabled'), 'statut4', 'class="pictostatus"');

+                return $langs->trans('Enabled').' '.img_picto($langs->trans('Enabled'), 'statut4', 'class="pictostatus"');

             } elseif ($statut == 0) {

-                return $langs->trans('Disabled') . ' ' . img_picto($langs->trans('Disabled'), 'statut5', 'class="pictostatus"');

+                return $langs->trans('Disabled').' '.img_picto($langs->trans('Disabled'), 'statut5', 'class="pictostatus"');

             }

         }

     }

@@ -2369,11 +2369,11 @@ 
         global $conf;

         $dn = '';

         if ($mode == 0) {

-            $dn = Globals::$conf->global->LDAP_KEY_USERS . "=" . $info[$conf->global->LDAP_KEY_USERS] . "," . Globals::$conf->global->LDAP_USER_DN;

+            $dn = Globals::$conf->global->LDAP_KEY_USERS."=".$info[$conf->global->LDAP_KEY_USERS].",".Globals::$conf->global->LDAP_USER_DN;

         } elseif ($mode == 1) {

             $dn = Globals::$conf->global->LDAP_USER_DN;

         } elseif ($mode == 2) {

-            $dn = Globals::$conf->global->LDAP_KEY_USERS . "=" . $info[$conf->global->LDAP_KEY_USERS];

+            $dn = Globals::$conf->global->LDAP_KEY_USERS."=".$info[$conf->global->LDAP_KEY_USERS];

         }

         return $dn;

     }

@@ -2571,8 +2571,8 @@ 
     {

         $sql = "SELECT u.rowid, u.login as ref, u.datec,";

         $sql .= " u.tms as date_modification, u.entity";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";

-        $sql .= " WHERE u.rowid = " . $id;

+        $sql .= " FROM ".MAIN_DB_PREFIX."user as u";

+        $sql .= " WHERE u.rowid = ".$id;

 

         $result = Config::$dbEngine->query($sql);

         if ($result) {

@@ -2601,9 +2601,9 @@ 
     function getNbOfEMailings()

     {

         $sql = "SELECT count(mc.email) as nb";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "mailing_cibles as mc";

-        $sql .= " WHERE mc.email = '" . Config::$dbEngine->escape($this->email) . "'";

-        $sql .= " AND mc.statut NOT IN (-1,0)";      // -1 erreur, 0 non envoye, 1 envoye avec succes

+        $sql .= " FROM ".MAIN_DB_PREFIX."mailing_cibles as mc";

+        $sql .= " WHERE mc.email = '".Config::$dbEngine->escape($this->email)."'";

+        $sql .= " AND mc.statut NOT IN (-1,0)"; // -1 erreur, 0 non envoye, 1 envoye avec succes

 

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

@@ -2631,19 +2631,19 @@ 
         global $conf;

 

         $sql = "SELECT count(rowid) as nb";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user";

         if ($option == 'superadmin') {

             $sql .= " WHERE entity = 0";

             if ($admin >= 0) {

-                $sql .= " AND admin = " . $admin;

+                $sql .= " AND admin = ".$admin;

             }

         } else {

-            $sql .= " WHERE entity IN (" . getEntity('user', 0) . ")";

+            $sql .= " WHERE entity IN (".getEntity('user', 0).")";

             if ($limitTo == 'active') {

                 $sql .= " AND statut = 1";

             }

             if ($admin >= 0) {

-                $sql .= " AND admin = " . $admin;

+                $sql .= " AND admin = ".$admin;

             }

         }

 

@@ -2694,7 +2694,7 @@ 
 

         $result = $this->update($user);

 

-        DolUtils::dol_syslog(get_class($this) . "::update_ldap2dolibarr result=" . $result, LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::update_ldap2dolibarr result=".$result, LOG_DEBUG);

 

         return $result;

     }

@@ -2709,10 +2709,10 @@ 
     function get_children()

     {

         // phpcs:enable

-        $sql = "SELECT rowid FROM " . MAIN_DB_PREFIX . "user";

-        $sql .= " WHERE fk_user = " . $this->id;

+        $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."user";

+        $sql .= " WHERE fk_user = ".$this->id;

 

-        DolUtils::dol_syslog(get_class($this) . "::get_children result=" . $result, LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::get_children result=".$result, LOG_DEBUG);

         $res = Config::$dbEngine->query($sql);

         if ($res) {

             $users = array();

@@ -2741,11 +2741,11 @@ 
 

         // Load array[child]=parent

         $sql = "SELECT fk_user as id_parent, rowid as id_son";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user";

         $sql .= " WHERE fk_user <> 0";

-        $sql .= " AND entity IN (" . getEntity('user') . ")";

+        $sql .= " AND entity IN (".getEntity('user').")";

 

-        DolUtils::dol_syslog(get_class($this) . "::loadParentOf", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::loadParentOf", LOG_DEBUG);

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

             while ($obj = Config::$dbEngine->fetch_object($resql)) {

@@ -2788,20 +2788,20 @@ 
 

         // Init $this->users array

         $sql = "SELECT DISTINCT u.rowid, u.firstname, u.lastname, u.fk_user, u.fk_soc, u.login, u.email, u.gender, u.admin, u.statut, u.photo, u.entity"; // Distinct reduce pb with old tables with duplicates

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user as u";

         // Add fields from hooks

         $parameters = array();

-        $reshook = $hookmanager->executeHooks('printUserListWhere', $parameters);    // Note that $action and $object may have been modified by hook

+        $reshook = $hookmanager->executeHooks('printUserListWhere', $parameters); // Note that $action and $object may have been modified by hook

         if ($reshook > 0) {

             $sql .= $hookmanager->resPrint;

         } else {

-            $sql .= " WHERE u.entity IN (" . getEntity('user') . ")";

+            $sql .= " WHERE u.entity IN (".getEntity('user').")";

         }

         if ($filter) {

-            $sql .= " AND " . $filter;

+            $sql .= " AND ".$filter;

         }

 

-        DolUtils::dol_syslog(get_class($this) . "::get_full_tree get user list", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::get_full_tree get user list", LOG_DEBUG);

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

             $i = 0;

@@ -2827,7 +2827,7 @@ 
         }

 

         // We add the fullpath property to each elements of first level (no parent exists)

-        DolUtils::dol_syslog(get_class($this) . "::get_full_tree call to build_path_from_id_user", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::get_full_tree call to build_path_from_id_user", LOG_DEBUG);

         foreach ($this->users as $key => $val) {

             $result = $this->build_path_from_id_user($key, 0); // Process a branch from the root user key (this user has no parent)

             if ($result < 0) {

@@ -2839,18 +2839,18 @@ 
         // Exclude leaf including $deleteafterid from tree

         if ($deleteafterid) {

             //print "Look to discard user ".$deleteafterid."\n";

-            $keyfilter1 = '^' . $deleteafterid . '$';

-            $keyfilter2 = '_' . $deleteafterid . '$';

-            $keyfilter3 = '^' . $deleteafterid . '_';

-            $keyfilter4 = '_' . $deleteafterid . '_';

+            $keyfilter1 = '^'.$deleteafterid.'$';

+            $keyfilter2 = '_'.$deleteafterid.'$';

+            $keyfilter3 = '^'.$deleteafterid.'_';

+            $keyfilter4 = '_'.$deleteafterid.'_';

             foreach ($this->users as $key => $val) {

-                if (preg_match('/' . $keyfilter1 . '/', $val['fullpath']) || preg_match('/' . $keyfilter2 . '/', $val['fullpath']) || preg_match('/' . $keyfilter3 . '/', $val['fullpath']) || preg_match('/' . $keyfilter4 . '/', $val['fullpath'])) {

+                if (preg_match('/'.$keyfilter1.'/', $val['fullpath']) || preg_match('/'.$keyfilter2.'/', $val['fullpath']) || preg_match('/'.$keyfilter3.'/', $val['fullpath']) || preg_match('/'.$keyfilter4.'/', $val['fullpath'])) {

                     unset($this->users[$key]);

                 }

             }

         }

 

-        DolUtils::dol_syslog(get_class($this) . "::get_full_tree dol_sort_array", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::get_full_tree dol_sort_array", LOG_DEBUG);

         $this->users = dol_sort_array($this->users, 'fullname', 'asc', true, false);

 

         //var_dump($this->users);

@@ -2878,10 +2878,10 @@ 
 

             $idtoscan = $this->id;

 

-            DolUtils::dol_syslog("Build childid for id = " . $idtoscan);

+            DolUtils::dol_syslog("Build childid for id = ".$idtoscan);

             foreach ($this->users as $id => $val) {

                 //var_dump($val['fullpath']);

-                if (preg_match('/_' . $idtoscan . '_/', $val['fullpath'])) {

+                if (preg_match('/_'.$idtoscan.'_/', $val['fullpath'])) {

                     $childids[$val['id']] = $val['id'];

                 }

             }

@@ -2907,16 +2907,16 @@ 
     function build_path_from_id_user($id_user, $protection = 0)

     {

         // phpcs:enable

-        DolUtils::dol_syslog(get_class($this) . "::build_path_from_id_user id_user=" . $id_user . " protection=" . $protection, LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::build_path_from_id_user id_user=".$id_user." protection=".$protection, LOG_DEBUG);

 

         if (!empty($this->users[$id_user]['fullpath'])) {

             // Already defined

-            DolUtils::dol_syslog(get_class($this) . "::build_path_from_id_user fullpath and fullname already defined", LOG_WARNING);

+            DolUtils::dol_syslog(get_class($this)."::build_path_from_id_user fullpath and fullname already defined", LOG_WARNING);

             return 0;

         }

 

         // Define fullpath and fullname

-        $this->users[$id_user]['fullpath'] = '_' . $id_user;

+        $this->users[$id_user]['fullpath'] = '_'.$id_user;

         $this->users[$id_user]['fullname'] = $this->users[$id_user]['lastname'];

         $i = 0;

         $cursor_user = $id_user;

@@ -2925,11 +2925,11 @@ 
         while (!empty($this->parentof[$cursor_user])) {

             if (in_array($this->parentof[$cursor_user], $useridfound)) {

                 DolUtils::dol_syslog("The hierarchy of user has a recursive loop", LOG_WARNING);

-                return -1;     // Should not happen. Protection against looping hierarchy

+                return -1; // Should not happen. Protection against looping hierarchy

             }

             $useridfound[] = $this->parentof[$cursor_user];

-            $this->users[$id_user]['fullpath'] = '_' . $this->parentof[$cursor_user] . $this->users[$id_user]['fullpath'];

-            $this->users[$id_user]['fullname'] = $this->users[$this->parentof[$cursor_user]]['lastname'] . ' >> ' . $this->users[$id_user]['fullname'];

+            $this->users[$id_user]['fullpath'] = '_'.$this->parentof[$cursor_user].$this->users[$id_user]['fullpath'];

+            $this->users[$id_user]['fullname'] = $this->users[$this->parentof[$cursor_user]]['lastname'].' >> '.$this->users[$id_user]['fullname'];

             $i++;

             $cursor_user = $this->parentof[$cursor_user];

         }

@@ -2971,10 +2971,10 @@ 
         $this->nb = array();

 

         $sql = "SELECT count(u.rowid) as nb";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user as u";

         $sql .= " WHERE u.statut > 0";

         //$sql.= " AND employee != 0";

-        $sql .= " AND u.entity IN (" . getEntity('user') . ")";

+        $sql .= " AND u.entity IN (".getEntity('user').")";

 

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

@@ -3039,8 +3039,8 @@ 
         }

 

         $sql = "SELECT rowid, email, user_mobile, civility, lastname, firstname";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user";

-        $sql .= " WHERE rowid = '" . $rowid . "'";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user";

+        $sql .= " WHERE rowid = '".$rowid."'";

 

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

@@ -3050,7 +3050,7 @@ 
                 $obj = Config::$dbEngine->fetch_object($resql);

 

                 if ($mode == 'email') {

-                    $user_property = dolGetFirstLastname($obj->firstname, $obj->lastname) . " <" . $obj->email . ">";

+                    $user_property = dolGetFirstLastname($obj->firstname, $obj->lastname)." <".$obj->email.">";

                 } else if ($mode == 'mobile') {

                     $user_property = $obj->user_mobile;

                 }

@@ -3077,7 +3077,7 @@ 
         global $conf;

 

         $sql = "SELECT t.rowid";

-        $sql .= ' FROM ' . MAIN_DB_PREFIX . $this->table_element . ' as t ';

+        $sql .= ' FROM '.MAIN_DB_PREFIX.$this->table_element.' as t ';

         $sql .= " WHERE 1";

 

         // Manage filter

@@ -3085,25 +3085,25 @@ 
         if (!empty($filter)) {

             foreach ($filter as $key => $value) {

                 if ($key == 't.rowid') {

-                    $sqlwhere[] = $key . '=' . $value;

+                    $sqlwhere[] = $key.'='.$value;

                 } elseif (strpos($key, 'date') !== false) {

-                    $sqlwhere[] = $key . ' = \'' . Config::$dbEngine->idate($value) . '\'';

+                    $sqlwhere[] = $key.' = \''.Config::$dbEngine->idate($value).'\'';

                 } elseif ($key == 'customsql') {

                     $sqlwhere[] = $value;

                 } else {

-                    $sqlwhere[] = $key . ' LIKE \'%' . Config::$dbEngine->escape($value) . '%\'';

+                    $sqlwhere[] = $key.' LIKE \'%'.Config::$dbEngine->escape($value).'%\'';

                 }

             }

         }

         if (count($sqlwhere) > 0) {

-            $sql .= ' AND (' . implode(' ' . $filtermode . ' ', $sqlwhere) . ')';

+            $sql .= ' AND ('.implode(' '.$filtermode.' ', $sqlwhere).')';

         }

         $sql .= Config::$dbEngine->order($sortfield, $sortorder);

         if ($limit) {

             $sql .= Config::$dbEngine->plimit($limit + 1, $offset);

         }

 

-        DolUtils::dol_syslog(get_class($this) . "::" . __METHOD__, LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::".__METHOD__, LOG_DEBUG);

 

         $resql = Config::$dbEngine->query($sql);

         if ($resql) {

Braces +10 added lines, -8 removed lines

@@ -520,16 +520,17 @@ 
                     $nid = $obj->id;

 

                     $sql = "DELETE FROM " . MAIN_DB_PREFIX . "user_rights WHERE fk_user = " . $this->id . " AND fk_id=" . $nid . " AND entity = " . $entity;

-                    if (!Config::$dbEngine->query($sql))

-                        $error++;

+                    if (!Config::$dbEngine->query($sql)) {
+                                            $error++;
+                    }
                     $sql = "INSERT INTO " . MAIN_DB_PREFIX . "user_rights (entity, fk_user, fk_id) VALUES (" . $entity . ", " . $this->id . ", " . $nid . ")";

-                    if (!Config::$dbEngine->query($sql))

-                        $error++;

+                    if (!Config::$dbEngine->query($sql)) {
+                                            $error++;
+                    }
 

                     $i++;

                 }

-            }

-            else {

+            } else {

                 $error++;

                 dol_print_error(Config::$dbEngine);

             }

@@ -2226,8 +2227,9 @@ 
             } else {

                 $result .= $this->getFullName($langs, '', ($mode == 'firstname' ? 2 : -1), $maxlen);

             }

-            if (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER))

-                $result .= '</div>';

+            if (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) {
+                            $result .= '</div>';
+            }
         }

         $result .= (($option == 'nolink') ? '' : $linkend);

         //if ($withpictoimg == -1) $result.='</div>';

Base/AlixarBasicView.php

Spacing +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
      */
     function top_htmlhead($head, $title = '', $disablejs = 0, $disablehead = 0, $arrayofjs = '', $arrayofcss = '', $disablejmobile = 0, $disablenofollow = 0)
     {
-        $this->top_httphead();  // TODO: Null method!
+        $this->top_httphead(); // TODO: Null method!
         // TODO: Nothing to do?
         return;
 

Base/Menubase.php

Spacing +77 added lines, -77 removed lines

@@ -83,7 +83,7 @@ 
     public $titre;

     //public Globals::$langs;

     public $level;

-    public $leftmenu;  //<! Not used

+    public $leftmenu; //<! Not used

     public $perms;

     public $enabled;

     //public $user;

@@ -117,7 +117,7 @@ 
         $this->type = trim($this->type);

         $this->mainmenu = trim($this->mainmenu);

         $this->leftmenu = trim($this->leftmenu);

-        $this->fk_menu = (int) $this->fk_menu;          // If -1, fk_mainmenu and fk_leftmenu must be defined

+        $this->fk_menu = (int) $this->fk_menu; // If -1, fk_mainmenu and fk_leftmenu must be defined

         $this->fk_mainmenu = trim($this->fk_mainmenu);

         $this->fk_leftmenu = trim($this->fk_leftmenu);

         $this->position = (int) $this->position;

@@ -144,7 +144,7 @@ 
         // may use an already used value because its internal cursor does not increase when we do

         // an insert with a forced id.

         if (in_array(Globals::$db->type, array('pgsql'))) {

-            $sql = "SELECT MAX(rowid) as maxrowid FROM " . MAIN_DB_PREFIX . "menu";

+            $sql = "SELECT MAX(rowid) as maxrowid FROM ".MAIN_DB_PREFIX."menu";

             $resqlrowid = Globals::$db->query($sql);

             if ($resqlrowid) {

                 $obj = Globals::$db->fetch_object($resqlrowid);

@@ -155,7 +155,7 @@ 
                     $maxrowid = 1;

                 }

 

-                $sql = "SELECT setval('" . MAIN_DB_PREFIX . "menu_rowid_seq', " . ($maxrowid) . ")";

+                $sql = "SELECT setval('".MAIN_DB_PREFIX."menu_rowid_seq', ".($maxrowid).")";

                 //print $sql; exit;

                 $resqlrowidset = Globals::$db->query($sql);

                 if (!$resqlrowidset) {

@@ -168,12 +168,12 @@ 
 

         // Check that entry does not exists yet on key menu_handler-fk_menu-position-url-entity, to avoid errors with postgresql

         $sql = "SELECT count(*)";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "menu";

-        $sql .= " WHERE menu_handler = '" . Globals::$db->escape($this->menu_handler) . "'";

-        $sql .= " AND fk_menu = " . ((int) $this->fk_menu);

-        $sql .= " AND position = " . ((int) $this->position);

-        $sql .= " AND url = '" . Globals::$db->escape($this->url) . "'";

-        $sql .= " AND entity = " . Globals::$conf->entity;

+        $sql .= " FROM ".MAIN_DB_PREFIX."menu";

+        $sql .= " WHERE menu_handler = '".Globals::$db->escape($this->menu_handler)."'";

+        $sql .= " AND fk_menu = ".((int) $this->fk_menu);

+        $sql .= " AND position = ".((int) $this->position);

+        $sql .= " AND url = '".Globals::$db->escape($this->url)."'";

+        $sql .= " AND entity = ".Globals::$conf->entity;

 

         $result = Globals::$db->query($sql);

         if ($result) {

@@ -181,7 +181,7 @@ 
 

             if ($row[0] == 0) {   // If not found

                 // Insert request

-                $sql = "INSERT INTO " . MAIN_DB_PREFIX . "menu(";

+                $sql = "INSERT INTO ".MAIN_DB_PREFIX."menu(";

                 $sql .= "menu_handler,";

                 $sql .= "entity,";

                 $sql .= "module,";

@@ -200,38 +200,38 @@ 
                 $sql .= "enabled,";

                 $sql .= "usertype";

                 $sql .= ") VALUES (";

-                $sql .= " '" . Globals::$db->escape($this->menu_handler) . "',";

-                $sql .= " '" . Globals::$db->escape($conf->entity) . "',";

-                $sql .= " '" . Globals::$db->escape($this->module) . "',";

-                $sql .= " '" . Globals::$db->escape($this->type) . "',";

-                $sql .= " " . ($this->mainmenu ? "'" . Globals::$db->escape($this->mainmenu) . "'" : "''") . ",";    // Can't be null

-                $sql .= " " . ($this->leftmenu ? "'" . Globals::$db->escape($this->leftmenu) . "'" : "null") . ",";

-                $sql .= " " . ((int) $this->fk_menu) . ",";

-                $sql .= " " . ($this->fk_mainmenu ? "'" . Globals::$db->escape($this->fk_mainmenu) . "'" : "null") . ",";

-                $sql .= " " . ($this->fk_leftmenu ? "'" . Globals::$db->escape($this->fk_leftmenu) . "'" : "null") . ",";

-                $sql .= " " . ((int) $this->position) . ",";

-                $sql .= " '" . Globals::$db->escape($this->url) . "',";

-                $sql .= " '" . Globals::$db->escape($this->target) . "',";

-                $sql .= " '" . Globals::$db->escape($this->titre) . "',";

-                $sql .= " '" . Globals::$db->escape($this->langs) . "',";

-                $sql .= " '" . Globals::$db->escape($this->perms) . "',";

-                $sql .= " '" . Globals::$db->escape($this->enabled) . "',";

-                $sql .= " '" . Globals::$db->escape($this->user) . "'";

+                $sql .= " '".Globals::$db->escape($this->menu_handler)."',";

+                $sql .= " '".Globals::$db->escape($conf->entity)."',";

+                $sql .= " '".Globals::$db->escape($this->module)."',";

+                $sql .= " '".Globals::$db->escape($this->type)."',";

+                $sql .= " ".($this->mainmenu ? "'".Globals::$db->escape($this->mainmenu)."'" : "''").","; // Can't be null

+                $sql .= " ".($this->leftmenu ? "'".Globals::$db->escape($this->leftmenu)."'" : "null").",";

+                $sql .= " ".((int) $this->fk_menu).",";

+                $sql .= " ".($this->fk_mainmenu ? "'".Globals::$db->escape($this->fk_mainmenu)."'" : "null").",";

+                $sql .= " ".($this->fk_leftmenu ? "'".Globals::$db->escape($this->fk_leftmenu)."'" : "null").",";

+                $sql .= " ".((int) $this->position).",";

+                $sql .= " '".Globals::$db->escape($this->url)."',";

+                $sql .= " '".Globals::$db->escape($this->target)."',";

+                $sql .= " '".Globals::$db->escape($this->titre)."',";

+                $sql .= " '".Globals::$db->escape($this->langs)."',";

+                $sql .= " '".Globals::$db->escape($this->perms)."',";

+                $sql .= " '".Globals::$db->escape($this->enabled)."',";

+                $sql .= " '".Globals::$db->escape($this->user)."'";

                 $sql .= ")";

 

-                DolUtils::dol_syslog(get_class($this) . "::create", LOG_DEBUG);

+                DolUtils::dol_syslog(get_class($this)."::create", LOG_DEBUG);

                 $resql = Globals::$db->query($sql);

                 if ($resql) {

-                    $this->id = Globals::$db->last_insert_id(MAIN_DB_PREFIX . "menu");

-                    DolUtils::dol_syslog(get_class($this) . "::create record added has rowid=" . $this->id, LOG_DEBUG);

+                    $this->id = Globals::$db->last_insert_id(MAIN_DB_PREFIX."menu");

+                    DolUtils::dol_syslog(get_class($this)."::create record added has rowid=".$this->id, LOG_DEBUG);

 

                     return $this->id;

                 } else {

-                    $this->error = "Error " . Globals::$db->lasterror();

+                    $this->error = "Error ".Globals::$db->lasterror();

                     return -1;

                 }

             } else {

-                DolUtils::dol_syslog(get_class($this) . "::create menu entry already exists", LOG_WARNING);

+                DolUtils::dol_syslog(get_class($this)."::create menu entry already exists", LOG_WARNING);

                 $this->error = 'Error Menu entry already exists';

                 return 0;

             }

@@ -272,29 +272,29 @@ 
         // Check parameters

         // Put here code to add control on parameters values

         // Update request

-        $sql = "UPDATE " . MAIN_DB_PREFIX . "menu SET";

-        $sql .= " menu_handler='" . Globals::$db->escape($this->menu_handler) . "',";

-        $sql .= " module='" . Globals::$db->escape($this->module) . "',";

-        $sql .= " type='" . Globals::$db->escape($this->type) . "',";

-        $sql .= " mainmenu='" . Globals::$db->escape($this->mainmenu) . "',";

-        $sql .= " leftmenu='" . Globals::$db->escape($this->leftmenu) . "',";

-        $sql .= " fk_menu=" . $this->fk_menu . ",";

-        $sql .= " fk_mainmenu=" . ($this->fk_mainmenu ? "'" . Globals::$db->escape($this->fk_mainmenu) . "'" : "null") . ",";

-        $sql .= " fk_leftmenu=" . ($this->fk_leftmenu ? "'" . Globals::$db->escape($this->fk_leftmenu) . "'" : "null") . ",";

-        $sql .= " position=" . ($this->position > 0 ? $this->position : 0) . ",";

-        $sql .= " url='" . Globals::$db->escape($this->url) . "',";

-        $sql .= " target='" . Globals::$db->escape($this->target) . "',";

-        $sql .= " titre='" . Globals::$db->escape($this->titre) . "',";

-        $sql .= " langs='" . Globals::$db->escape($this->langs) . "',";

-        $sql .= " perms='" . Globals::$db->escape($this->perms) . "',";

-        $sql .= " enabled='" . Globals::$db->escape($this->enabled) . "',";

-        $sql .= " usertype='" . Globals::$db->escape($this->user) . "'";

-        $sql .= " WHERE rowid=" . $this->id;

-

-        DolUtils::dol_syslog(get_class($this) . "::update", LOG_DEBUG);

+        $sql = "UPDATE ".MAIN_DB_PREFIX."menu SET";

+        $sql .= " menu_handler='".Globals::$db->escape($this->menu_handler)."',";

+        $sql .= " module='".Globals::$db->escape($this->module)."',";

+        $sql .= " type='".Globals::$db->escape($this->type)."',";

+        $sql .= " mainmenu='".Globals::$db->escape($this->mainmenu)."',";

+        $sql .= " leftmenu='".Globals::$db->escape($this->leftmenu)."',";

+        $sql .= " fk_menu=".$this->fk_menu.",";

+        $sql .= " fk_mainmenu=".($this->fk_mainmenu ? "'".Globals::$db->escape($this->fk_mainmenu)."'" : "null").",";

+        $sql .= " fk_leftmenu=".($this->fk_leftmenu ? "'".Globals::$db->escape($this->fk_leftmenu)."'" : "null").",";

+        $sql .= " position=".($this->position > 0 ? $this->position : 0).",";

+        $sql .= " url='".Globals::$db->escape($this->url)."',";

+        $sql .= " target='".Globals::$db->escape($this->target)."',";

+        $sql .= " titre='".Globals::$db->escape($this->titre)."',";

+        $sql .= " langs='".Globals::$db->escape($this->langs)."',";

+        $sql .= " perms='".Globals::$db->escape($this->perms)."',";

+        $sql .= " enabled='".Globals::$db->escape($this->enabled)."',";

+        $sql .= " usertype='".Globals::$db->escape($this->user)."'";

+        $sql .= " WHERE rowid=".$this->id;

+

+        DolUtils::dol_syslog(get_class($this)."::update", LOG_DEBUG);

         $resql = Globals::$db->query($sql);

         if (!$resql) {

-            $this->error = "Error " . Globals::$db->lasterror();

+            $this->error = "Error ".Globals::$db->lasterror();

             return -1;

         }

 

@@ -332,10 +332,10 @@ 
         $sql .= " t.enabled,";

         $sql .= " t.usertype as user,";

         $sql .= " t.tms";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "menu as t";

-        $sql .= " WHERE t.rowid = " . $id;

+        $sql .= " FROM ".MAIN_DB_PREFIX."menu as t";

+        $sql .= " WHERE t.rowid = ".$id;

 

-        DolUtils::dol_syslog(get_class($this) . "::fetch", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::fetch", LOG_DEBUG);

         $resql = Globals::$db->query($sql);

         if ($resql) {

             if (Globals::$db->num_rows($resql)) {

@@ -366,7 +366,7 @@ 
 

             return 1;

         } else {

-            $this->error = "Error " . Globals::$db->lasterror();

+            $this->error = "Error ".Globals::$db->lasterror();

             return -1;

         }

     }

@@ -381,13 +381,13 @@ 
     {

         // global $conf, Globals::$langs;

 

-        $sql = "DELETE FROM " . MAIN_DB_PREFIX . "menu";

-        $sql .= " WHERE rowid=" . $this->id;

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."menu";

+        $sql .= " WHERE rowid=".$this->id;

 

-        DolUtils::dol_syslog(get_class($this) . "::delete", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::delete", LOG_DEBUG);

         $resql = Globals::$db->query($sql);

         if (!$resql) {

-            $this->error = "Error " . Globals::$db->lasterror();

+            $this->error = "Error ".Globals::$db->lasterror();

             return -1;

         }

 

@@ -438,8 +438,8 @@ 
         // global Globals::$langs, $user, $conf; // To export to DolUtils::dol_eval function

         // global $mainmenu, $leftmenu;  // To export to DolUtils::dol_eval function

 

-        $mainmenu = $mymainmenu;  // To export to DolUtils::dol_eval function

-        $leftmenu = $myleftmenu;  // To export to DolUtils::dol_eval function

+        $mainmenu = $mymainmenu; // To export to DolUtils::dol_eval function

+        $leftmenu = $myleftmenu; // To export to DolUtils::dol_eval function

 

         $newTabMenu = array();

         foreach ($tabMenu as $val) {

@@ -468,8 +468,8 @@ 
         //global Globals::$langs, $user, $conf;  // To export to DolUtils::dol_eval function

         // global $mainmenu, $leftmenu;  // To export to DolUtils::dol_eval function

 

-        $mainmenu = $mymainmenu;  // To export to DolUtils::dol_eval function

-        $leftmenu = $myleftmenu;  // To export to DolUtils::dol_eval function

+        $mainmenu = $mymainmenu; // To export to DolUtils::dol_eval function

+        $leftmenu = $myleftmenu; // To export to DolUtils::dol_eval function

         // Detect what is top mainmenu id

         $menutopid = '';

         foreach ($tabMenu as $key => $val) {

@@ -524,7 +524,7 @@ 
                     if ($found) {

                         $this->newmenu->insert($lastid, $val['url'], $val['titre'], $searchlastsub, $val['perms'], $val['target'], $val['mainmenu'], $val['leftmenu'], $val['position']);

                     } else {

-                        DolUtils::dol_syslog("Error. Modules " . $val['module'] . " has defined a menu entry with a parent='fk_mainmenu=" . $val['fk_leftmenu'] . ",fk_leftmenu=" . $val['fk_leftmenu'] . "' and position=" . $val['position'] . '. The parent was not found. May be you forget it into your definition of menu, or may be the parent has a "position" that is after the child (fix field "position" of parent or child in this case).', LOG_WARNING);

+                        DolUtils::dol_syslog("Error. Modules ".$val['module']." has defined a menu entry with a parent='fk_mainmenu=".$val['fk_leftmenu'].",fk_leftmenu=".$val['fk_leftmenu']."' and position=".$val['position'].'. The parent was not found. May be you forget it into your definition of menu, or may be the parent has a "position" that is after the child (fix field "position" of parent or child in this case).', LOG_WARNING);

                         //print "Parent menu not found !!<br>";

                     }

                 }

@@ -550,13 +550,13 @@ 
         //global $mainmenu, $leftmenu; // To export to DolUtils::dol_eval function

 

         $menutopid = 0;

-        $mainmenu = $mymainmenu;  // To export to DolUtils::dol_eval function

-        $leftmenu = $myleftmenu;  // To export to DolUtils::dol_eval function

+        $mainmenu = $mymainmenu; // To export to DolUtils::dol_eval function

+        $leftmenu = $myleftmenu; // To export to DolUtils::dol_eval function

 

         $sql = "SELECT m.rowid, m.type, m.module, m.fk_menu, m.fk_mainmenu, m.fk_leftmenu, m.url, m.titre, m.langs, m.perms, m.enabled, m.target, m.mainmenu, m.leftmenu, m.position";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "menu as m";

-        $sql .= " WHERE m.entity IN (0," . Globals::$conf->entity . ")";

-        $sql .= " AND m.menu_handler IN ('" . $menu_handler . "','all')";

+        $sql .= " FROM ".MAIN_DB_PREFIX."menu as m";

+        $sql .= " WHERE m.entity IN (0,".Globals::$conf->entity.")";

+        $sql .= " AND m.menu_handler IN ('".$menu_handler."','all')";

         if ($type_user == 0) {

             $sql .= " AND m.usertype IN (0,2)";

         }

@@ -567,7 +567,7 @@ 
         //print $sql;

         //$tmp1=microtime(true);

         //print '>>> 1 0<br>';

-        DolUtils::dol_syslog(get_class($this) . "::menuLoad mymainmenu=" . $mymainmenu . " myleftmenu=" . $myleftmenu . " type_user=" . $type_user . " menu_handler=" . $menu_handler . " tabMenu size=" . count($tabMenu) . "", LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this)."::menuLoad mymainmenu=".$mymainmenu." myleftmenu=".$myleftmenu." type_user=".$type_user." menu_handler=".$menu_handler." tabMenu size=".count($tabMenu)."", LOG_DEBUG);

         $resql = Config::$dbEngine->select($sql);

         if (is_array($resql)) {

             $a = 0;

@@ -600,7 +600,7 @@ 
 

                 // Define $title

                 if ($enabled) {

-                    $title = Globals::$langs->trans($menu['titre']);  // If $menu['titre'] start with $, a DolUtils::dol_eval is done.

+                    $title = Globals::$langs->trans($menu['titre']); // If $menu['titre'] start with $, a DolUtils::dol_eval is done.

                     //var_dump($title.'-'.$menu['titre']);

                     if ($title == $menu['titre']) {   // Translation not found

                         if (!empty($menu['langs'])) {    // If there is a dedicated translation file

@@ -613,7 +613,7 @@ 
 

                         if (preg_match("/\//", $menu['titre'])) { // To manage translation when title is string1/string2

                             $tab_titre = explode("/", $menu['titre']);

-                            $title = Globals::$langs->trans($tab_titre[0]) . "/" . Globals::$langs->trans($tab_titre[1]);

+                            $title = Globals::$langs->trans($tab_titre[0])."/".Globals::$langs->trans($tab_titre[1]);

                         } else if (preg_match('/\|\|/', $menu['titre'])) { // To manage different translation (Title||AltTitle@ConditionForAltTitle)

                             $tab_title = explode("||", $menu['titre']);

                             $alt_title = explode("@", $tab_title[1]);

@@ -632,9 +632,9 @@ 
                     $tabMenu[$b]['url'] = $menu['url'];

                     if (!preg_match("/^(http:\/\/|https:\/\/)/i", $tabMenu[$b]['url'])) {

                         if (preg_match('/\?/', $tabMenu[$b]['url'])) {

-                            $tabMenu[$b]['url'] .= '&amp;idmenu=' . $menu['rowid'];

+                            $tabMenu[$b]['url'] .= '&amp;idmenu='.$menu['rowid'];

                         } else {

-                            $tabMenu[$b]['url'] .= '?idmenu=' . $menu['rowid'];

+                            $tabMenu[$b]['url'] .= '?idmenu='.$menu['rowid'];

                         }

                     }

                     $tabMenu[$b]['titre'] = $title;

Base/CommonObject.php

Indentation +7086 added lines, -7086 removed lines

@@ -20,7382 +20,7382 @@
 

 abstract class CommonObject

 {

-	/**

+    /**

      * @var int The object identifier

      */

-	public $id;

-

-	/**

-	 * @var string 		Error string

-	 * @see             errors

-	 */

-	public $error;

-

-	/**

-	 * @var string[]	Array of error strings

-	 */

-	public $errors=array();

-

-	/**

-	 * @var string ID to identify managed object

-	 */

-	public $element;

-

-	/**

-	 * @var string Name of table without prefix where object is stored

-	 */

-	public $table_element;

-

-	/**

-	 * @var int    Name of subtable line

-	 */

-	public $table_element_line='';

-

-	/**

-	 * @var string		Key value used to track if data is coming from import wizard

-	 */

-	public $import_key;

-

-	/**

-	 * @var mixed		Contains data to manage extrafields

-	 */

-	public $array_options=array();

-

-	/**

-	 * @var int[][]		Array of linked objects ids. Loaded by ->fetchObjectLinked

-	 */

-	public $linkedObjectsIds;

-

-	/**

-	 * @var mixed		Array of linked objects. Loaded by ->fetchObjectLinked

-	 */

-	public $linkedObjects;

-

-	/**

-	 * @var Object      To store a cloned copy of object before to edit it and keep track of old properties

-	 */

-	public $oldcopy;

-

-	/**

-	 * @var string		Column name of the ref field.

-	 */

-	protected $table_ref_field = '';

-

-

-

-	// Following vars are used by some objects only. We keep this property here in CommonObject to be able to provide common method using them.

-

-	/**

-	 * @var array<string,mixed>		Can be used to pass information when only object is provided to method

-	 */

-	public $context=array();

-

-	/**

-	 * @var string		Contains canvas name if record is an alternative canvas record

-	 */

-	public $canvas;

-

-	/**

-	 * @var Project The related project

-	 * @see fetch_projet()

-	 */

-	public $project;

-

-	/**

-	 * @var int The related project ID

-	 * @see setProject(), project

-	 */

-	public $fk_project;

-

-	/**

-	 * @deprecated

-	 * @see project

-	 */

-	public $projet;

-

-	/**

-	 * @var Contact a related contact

-	 * @see fetch_contact()

-	 */

-	public $contact;

-

-	/**

-	 * @var int The related contact ID

-	 * @see fetch_contact()

-	 */

-	public $contact_id;

-

-	/**

-	 * @var Societe A related thirdparty

-	 * @see fetch_thirdparty()

-	 */

-	public $thirdparty;

-

-	/**

-	 * @var User A related user

-	 * @see fetch_user()

-	 */

-	public $user;

-

-	/**

-	 * @var string 	The type of originating object ('commande', 'facture', ...)

-	 * @see fetch_origin()

-	 */

-	public $origin;

-

-	/**

-	 * @var int 	The id of originating object

-	 * @see fetch_origin()

-	 */

-	public $origin_id;

-

-	/**

-	 * @var string The object's reference

-	 */

-	public $ref;

-

-	/**

-	 * @var string The object's previous reference

-	 */

-	public $ref_previous;

-

-	/**

-	 * @var string The object's next reference

-	 */

-	public $ref_next;

-

-	/**

-	 * @var string An external reference for the object

-	 */

-	public $ref_ext;

-

-	/**

-	 * @var int The object's status

-	 * @see setStatut()

-	 */

-	public $statut;

-

-	/**

-	 * @var string

-	 * @see getFullAddress()

-	 */

-	public $country;

-

-	/**

-	 * @var int

-	 * @see getFullAddress(), country

-	 */

-	public $country_id;

-

-	/**

-	 * @var string

-	 * @see getFullAddress(), isInEEC(), country

-	 */

-    public $country_code;

+    public $id;

 

     /**

-	 * @var string

-	 * @see getFullAddress()

-	 */

-	public $state;

-

-	/**

-	 * @var int

-	 * @see getFullAddress(), state

-	 */

-	public $state_id;

+     * @var string 		Error string

+     * @see             errors

+     */

+    public $error;

 

-	/**

-	 * @var string

-	 * @see getFullAddress(), state

-	 */

-    public $state_code;

+    /**

+     * @var string[]	Array of error strings

+     */

+    public $errors=array();

 

     /**

-	 * @var string

-	 * @see getFullAddress(), region

-	 */

-	public $region;

+     * @var string ID to identify managed object

+     */

+    public $element;

 

-	/**

-	 * @var string

-	 * @see getFullAddress(), region

-	 */

-    public $region_code;

+    /**

+     * @var string Name of table without prefix where object is stored

+     */

+    public $table_element;

 

-	/**

-	 * @var int

-	 * @see fetch_barcode()

-	 */

-	public $barcode_type;

-

-	/**

-	 * @var string

-	 * @see fetch_barcode(), barcode_type

-	 */

-	public $barcode_type_code;

-

-	/**

-	 * @var string

-	 * @see fetch_barcode(), barcode_type

-	 */

-	public $barcode_type_label;

-

-	/**

-	 * @var string

-	 * @see fetch_barcode(), barcode_type

-	 */

-	public $barcode_type_coder;

-

-	/**

-	 * @var int Payment method ID (cheque, cash, ...)

-	 * @see setPaymentMethods()

-	 */

-	public $mode_reglement_id;

-

-	/**

-	 * @var int Payment terms ID

-	 * @see setPaymentTerms()

-	 */

-	public $cond_reglement_id;

-

-	/**

-	 * @var int Payment terms ID

-	 * @deprecated Kept for compatibility

-	 * @see cond_reglement_id;

-	 */

-	public $cond_reglement;

-

-	/**

-	 * @var int Delivery address ID

-	 * @deprecated

-	 * @see setDeliveryAddress()

-	 */

-	public $fk_delivery_address;

-

-	/**

-	 * @var int Shipping method ID

-	 * @see setShippingMethod()

-	 */

-	public $shipping_method_id;

-

-	/**

-	 * @var string

-	 * @see SetDocModel()

-	 */

-	public $modelpdf;

-

-	/**

-	 * @var int Bank account ID

-	 * @see SetBankAccount()

-	 */

-	public $fk_account;

-

-	/**

-	 * @var string Public note

-	 * @see update_note()

-	 */

-	public $note_public;

-

-	/**

-	 * @var string Private note

-	 * @see update_note()

-	 */

-	public $note_private;

-

-	/**

-	 * @deprecated

-	 * @see note_public

-	 */

-	public $note;

-

-	/**

-	 * @var float Total amount before taxes

-	 * @see update_price()

-	 */

-	public $total_ht;

-

-	/**

-	 * @var float Total VAT amount

-	 * @see update_price()

-	 */

-	public $total_tva;

-

-	/**

-	 * @var float Total local tax 1 amount

-	 * @see update_price()

-	 */

-	public $total_localtax1;

-

-	/**

-	 * @var float Total local tax 2 amount

-	 * @see update_price()

-	 */

-	public $total_localtax2;

-

-	/**

-	 * @var float Total amount with taxes

-	 * @see update_price()

-	 */

-	public $total_ttc;

-

-	/**

-	 * @var CommonObjectLine[]

-	 */

-	public $lines;

-

-	/**

-	 * @var mixed		Contains comments

-	 * @see fetchComments()

-	 */

-	public $comments=array();

-

-	/**

-	 * @var int

-	 * @see setIncoterms()

-	 */

-	public $fk_incoterms;

-

-	/**

-	 * @var string

-	 * @see SetIncoterms()

-	 */

-	public $libelle_incoterms;

-

-	/**

-	 * @var string

-	 * @see display_incoterms()

-	 */

-	public $location_incoterms;

-

-	public $name;

-	public $lastname;

-	public $firstname;

-	public $civility_id;

-

-	// Dates

-	public $date_creation;			// Date creation

-	public $date_validation;		// Date validation

-	public $date_modification;		// Date last change (tms field)

-

-

-

-	// No constructor as it is an abstract class

-

-	/**

-	 * Check an object id/ref exists

-	 * If you don't need/want to instantiate object and just need to know if object exists, use this method instead of fetch

-	 *

-	 *  @param	string	$element   	String of element ('product', 'facture', ...)

-	 *  @param	int		$id      	Id of object

-	 *  @param  string	$ref     	Ref of object to check

-	 *  @param	string	$ref_ext	Ref ext of object to check

-	 *  @return int     			<0 if KO, 0 if OK but not found, >0 if OK and exists

-	 */

-	static function isExistingObject($element, $id, $ref='', $ref_ext='')

-	{

-		global $db,$conf;

-

-		$sql = "SELECT rowid, ref, ref_ext";

-		$sql.= " FROM ".MAIN_DB_PREFIX.$element;

-		$sql.= " WHERE entity IN (".getEntity($element).")" ;

-

-		if ($id > 0) $sql.= " AND rowid = ".$db->escape($id);

-		else if ($ref) $sql.= " AND ref = '".$db->escape($ref)."'";

-		else if ($ref_ext) $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";

-		else {

-			$error='ErrorWrongParameters';

-			dol_print_error(get_class()."::isExistingObject ".$error, LOG_ERR);

-			return -1;

-		}

-		if ($ref || $ref_ext) $sql.= " AND entity = ".$conf->entity;

-

-		dol_syslog(get_class()."::isExistingObject", LOG_DEBUG);

-		$resql = $db->query($sql);

-		if ($resql)

-		{

-			$num=$db->num_rows($resql);

-			if ($num > 0) return 1;

-			else return 0;

-		}

-		return -1;

-	}

-

-	/**

-	 * Method to output saved errors

-	 *

-	 * @return	string		String with errors

-	 */

-	function errorsToString()

-	{

-		return $this->error.(is_array($this->errors)?(($this->error!=''?', ':'').join(', ',$this->errors)):'');

-	}

-

-	/**

-	 *	Return full name (civility+' '+name+' '+lastname)

-	 *

-	 *	@param	Translate	$langs			Language object for translation of civility (used only if option is 1)

-	 *	@param	int			$option			0=No option, 1=Add civility

-	 * 	@param	int			$nameorder		-1=Auto, 0=Lastname+Firstname, 1=Firstname+Lastname, 2=Firstname

-	 * 	@param	int			$maxlen			Maximum length

-	 * 	@return	string						String with full name

-	 */

-	function getFullName($langs,$option=0,$nameorder=-1,$maxlen=0)

-	{

-		//print "lastname=".$this->lastname." name=".$this->name." nom=".$this->nom."<br>\n";

-		$lastname=$this->lastname;

-		$firstname=$this->firstname;

-		if (empty($lastname))  $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));

-

-		$ret='';

-		if ($option && $this->civility_id)

-		{

-			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';

-			else $ret.=$this->civility_id.' ';

-		}

-

-		$ret.=dolGetFirstLastname($firstname, $lastname, $nameorder);

-

-		return dol_trunc($ret,$maxlen);

-	}

-

-	/**

-	 * 	Return full address of contact

-	 *

-	 * 	@param		int			$withcountry		1=Add country into address string

-	 *  @param		string		$sep				Separator to use to build string

-	 *  @param		int		    $withregion			1=Add region into address string

-	 *	@return		string							Full address string

-	 */

-	function getFullAddress($withcountry=0, $sep="\n", $withregion=0)

-	{

-		if ($withcountry && $this->country_id && (empty($this->country_code) || empty($this->country)))

-		{

-			require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';

-			$tmparray=getCountry($this->country_id,'all');

-			$this->country_code=$tmparray['code'];

-			$this->country     =$tmparray['label'];

-		}

+    /**

+     * @var int    Name of subtable line

+     */

+    public $table_element_line='';

 

-        if ($withregion && $this->state_id && (empty($this->state_code) || empty($this->state) || empty($this->region) || empty($this->region_cpde)))

-    	{

-    		require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';

-    		$tmparray=getState($this->state_id,'all',0,1);

-			$this->state_code   =$tmparray['code'];

-			$this->state        =$tmparray['label'];

-			$this->region_code  =$tmparray['region_code'];

-			$this->region       =$tmparray['region'];

-        }

-

-		return dol_format_address($this, $withcountry, $sep);

-	}

-

-

-	/**

-	 * 	Return full address for banner

-	 *

-	 * 	@param		string		$htmlkey            HTML id to make banner content unique

-	 *  @param      Object      $object				Object (thirdparty, thirdparty of contact for contact, null for a member)

-	 *	@return		string							Full address string

-	 */

-	function getBannerAddress($htmlkey, $object)

-	{

-		global $conf, $langs;

-

-		$countriesusingstate=array('AU','US','IN','GB','ES','UK','TR');    // See also option MAIN_FORCE_STATE_INTO_ADDRESS

-

-		$contactid=0;

-		$thirdpartyid=0;

-		if ($this->element == 'societe')

-		{

-			$thirdpartyid=$this->id;

-		}

-		if ($this->element == 'contact')

-		{

-			$contactid=$this->id;

-			$thirdpartyid=$object->fk_soc;

-		}

-		if ($this->element == 'user')

-		{

-			$contactid=$this->contact_id;

-			$thirdpartyid=$object->fk_soc;

-		}

-

-		$out='<!-- BEGIN part to show address block -->';

-

-		$outdone=0;

-		$coords = $this->getFullAddress(1,', ',$conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT);

-		if ($coords)

-		{

-			if (! empty($conf->use_javascript_ajax))

-			{

-				$namecoords = $this->getFullName($langs,1).'<br>'.$coords;

-				// hideonsmatphone because copyToClipboard call jquery dialog that does not work with jmobile

-				$out.='<a href="#" class="hideonsmartphone" onclick="return copyToClipboard(\''.dol_escape_js($namecoords).'\',\''.dol_escape_js($langs->trans("HelpCopyToClipboard")).'\');">';

-				$out.=img_picto($langs->trans("Address"), 'object_address.png');

-				$out.='</a> ';

-			}

-			$out.=dol_print_address($coords, 'address_'.$htmlkey.'_'.$this->id, $this->element, $this->id, 1, ', '); $outdone++;

-			$outdone++;

-		}

-

-		if (! in_array($this->country_code,$countriesusingstate) && empty($conf->global->MAIN_FORCE_STATE_INTO_ADDRESS)   // If MAIN_FORCE_STATE_INTO_ADDRESS is on, state is already returned previously with getFullAddress

-				&& empty($conf->global->SOCIETE_DISABLE_STATE) && $this->state)

-		{

-            if (!empty($conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT) && $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT == 1 && $this->region) {

-                $out.=($outdone?' - ':'').$this->region.' - '.$this->state;

-            }

-            else {

-                $out.=($outdone?' - ':'').$this->state;

-            }

-			$outdone++;

-		}

-

-		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) $out.=($outdone?'<br>':'');

-		if (! empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone

-			$out.=dol_print_phone($this->phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

-		}

-		if (! empty($this->phone_pro)) {

-			$out.=dol_print_phone($this->phone_pro,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

-		}

-		if (! empty($this->phone_mobile)) {

-			$out.=dol_print_phone($this->phone_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;

-		}

-		if (! empty($this->phone_perso)) {

-			$out.=dol_print_phone($this->phone_perso,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePerso")); $outdone++;

-		}

-		if (! empty($this->office_phone)) {

-			$out.=dol_print_phone($this->office_phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

-		}

-		if (! empty($this->user_mobile)) {

-			$out.=dol_print_phone($this->user_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;

-		}

-		if (! empty($this->fax)) {

-			$out.=dol_print_phone($this->fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;

-		}

-		if (! empty($this->office_fax)) {

-			$out.=dol_print_phone($this->office_fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;

-		}

-

-		$out.='<div style="clear: both;"></div>';

-		$outdone=0;

-		if (! empty($this->email))

-		{

-			$out.=dol_print_email($this->email,$this->id,$object->id,'AC_EMAIL',0,0,1);

-			$outdone++;

-		}

-		if (! empty($this->url))

-		{

-			$out.=dol_print_url($this->url,'_goout',0,1);

-			$outdone++;

-		}

-		$out.='<div style="clear: both;">';

-		if (! empty($conf->socialnetworks->enabled))

-		{

-			if ($this->skype) $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');

-			$outdone++;

-			if ($this->jabberid) $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');

-			$outdone++;

-			if ($this->twitter) $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');

-			$outdone++;

-			if ($this->facebook) $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');

-			$outdone++;

-		}

-		$out.='</div>';

-

-		$out.='<!-- END Part to show address block -->';

-

-		return $out;

-	}

-

-	/**

-	 * Return the link of last main doc file for direct public download.

-	 *

-	 * @param	string	$modulepart			Module related to document

-	 * @param	int		$initsharekey		Init the share key if it was not yet defined

-	 * @param	int		$relativelink		0=Return full external link, 1=Return link relative to root of file

-	 * @return	string						Link or empty string if there is no download link

-	 */

-	function getLastMainDocLink($modulepart, $initsharekey=0, $relativelink=0)

-	{

-		global $user, $dolibarr_main_url_root;

-

-		if (empty($this->last_main_doc))

-		{

-			return '';		// No way to known which document name to use

-		}

-

-		include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';

-		$ecmfile=new EcmFiles($this->db);

-		$result = $ecmfile->fetch(0, '', $this->last_main_doc);

-		if ($result < 0)

-		{

-			$this->error = $ecmfile->error;

-			$this->errors = $ecmfile->errors;

-			return -1;

-		}

-

-		if (empty($ecmfile->id))

-		{

-			// Add entry into index

-			if ($initsharekey)

-			{

-				require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

-				// TODO We can't, we dont' have full path of file, only last_main_doc adn ->element, so we must rebuild full path first

-				/*

-				$ecmfile->filepath = $rel_dir;

-				$ecmfile->filename = $filename;

-				$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

-				$ecmfile->fullpath_orig = '';

-				$ecmfile->gen_or_uploaded = 'generated';

-				$ecmfile->description = '';    // indexed content

-				$ecmfile->keyword = '';        // keyword content

-				$ecmfile->share = getRandomPassword(true);

-				$result = $ecmfile->create($user);

-				if ($result < 0)

-				{

-					$this->error = $ecmfile->error;

-					$this->errors = $ecmfile->errors;

-				}

-				*/

-			}

-			else return '';

-		}

-		elseif (empty($ecmfile->share))

-		{

-			// Add entry into index

-			if ($initsharekey)

-			{

-				require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

-				$ecmfile->share = getRandomPassword(true);

-				$ecmfile->update($user);

-			}

-			else return '';

-		}

-

-		// Define $urlwithroot

-		$urlwithouturlroot=preg_replace('/'.preg_quote(DOL_URL_ROOT,'/').'$/i','',trim($dolibarr_main_url_root));

-		$urlwithroot=$urlwithouturlroot.DOL_URL_ROOT;		// This is to use external domain name found into config file

-		//$urlwithroot=DOL_MAIN_URL_ROOT;					// This is to use same domain name than current

-

-		$forcedownload=0;

-

-		$paramlink='';

-		//if (! empty($modulepart)) $paramlink.=($paramlink?'&':'').'modulepart='.$modulepart;		// For sharing with hash (so public files), modulepart is not required.

-		//if (! empty($ecmfile->entity)) $paramlink.='&entity='.$ecmfile->entity; 					// For sharing with hash (so public files), entity is not required.

-		//$paramlink.=($paramlink?'&':'').'file='.urlencode($filepath);								// No need of name of file for public link, we will use the hash

-		if (! empty($ecmfile->share)) $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;			// Hash for public share

-		if ($forcedownload) $paramlink.=($paramlink?'&':'').'attachment=1';

-

-		if ($relativelink)

-		{

-			$linktoreturn='document.php'.($paramlink?'?'.$paramlink:'');

-		}

-		else

-		{

-			$linktoreturn=$urlwithroot.'/document.php'.($paramlink?'?'.$paramlink:'');

-		}

-

-		// Here $ecmfile->share is defined

-		return $linktoreturn;

-	}

+    /**

+     * @var string		Key value used to track if data is coming from import wizard

+     */

+    public $import_key;

 

+    /**

+     * @var mixed		Contains data to manage extrafields

+     */

+    public $array_options=array();

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *  Add a link between element $this->element and a contact

-	 *

-	 *  @param	int		$fk_socpeople       Id of thirdparty contact (if source = 'external') or id of user (if souce = 'internal') to link

-	 *  @param 	int		$type_contact 		Type of contact (code or id). Must be id or code found into table llx_c_type_contact. For example: SALESREPFOLL

-	 *  @param  string	$source             external=Contact extern (llx_socpeople), internal=Contact intern (llx_user)

-	 *  @param  int		$notrigger			Disable all triggers

-	 *  @return int                 		<0 if KO, >0 if OK

-	 */

-	function add_contact($fk_socpeople, $type_contact, $source='external',$notrigger=0)

-	{

-        // phpcs:enable

-		global $user,$langs;

-

-

-		dol_syslog(get_class($this)."::add_contact $fk_socpeople, $type_contact, $source, $notrigger");

-

-		// Check parameters

-		if ($fk_socpeople <= 0)

-		{

-			$langs->load("errors");

-			$this->error=$langs->trans("ErrorWrongValueForParameterX","1");

-			dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);

-			return -1;

-		}

-		if (! $type_contact)

-		{

-			$langs->load("errors");

-			$this->error=$langs->trans("ErrorWrongValueForParameterX","2");

-			dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);

-			return -2;

-		}

-

-		$id_type_contact=0;

-		if (is_numeric($type_contact))

-		{

-			$id_type_contact=$type_contact;

-		}

-		else

-		{

-			// We look for id type_contact

-			$sql = "SELECT tc.rowid";

-			$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

-			$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

-			$sql.= " AND tc.source='".$this->db->escape($source)."'";

-			$sql.= " AND tc.code='".$this->db->escape($type_contact)."' AND tc.active=1";

-			//print $sql;

-			$resql=$this->db->query($sql);

-			if ($resql)

-			{

-				$obj = $this->db->fetch_object($resql);

-				if ($obj) $id_type_contact=$obj->rowid;

-			}

-		}

-

-		if ($id_type_contact == 0)

-		{

-			$this->error='CODE_NOT_VALID_FOR_THIS_ELEMENT';

-			dol_syslog("CODE_NOT_VALID_FOR_THIS_ELEMENT: Code type of contact '".$type_contact."' does not exists or is not active for element ".$this->element.", we can ignore it");

-			return -3;

-		}

-

-		$datecreate = dol_now();

-

-		// Socpeople must have already been added by some trigger, then we have to check it to avoid DB_ERROR_RECORD_ALREADY_EXISTS error

-		$TListeContacts=$this->liste_contact(-1, $source);

-		$already_added=false;

-		if(!empty($TListeContacts)) {

-			foreach($TListeContacts as $array_contact) {

-				if($array_contact['status'] == 4 && $array_contact['id'] == $fk_socpeople && $array_contact['fk_c_type_contact'] == $id_type_contact) {

-					$already_added=true;

-					break;

-				}

-			}

-		}

+    /**

+     * @var int[][]		Array of linked objects ids. Loaded by ->fetchObjectLinked

+     */

+    public $linkedObjectsIds;

 

-		if(!$already_added) {

+    /**

+     * @var mixed		Array of linked objects. Loaded by ->fetchObjectLinked

+     */

+    public $linkedObjects;

 

-			$this->db->begin();

+    /**

+     * @var Object      To store a cloned copy of object before to edit it and keep track of old properties

+     */

+    public $oldcopy;

 

-			// Insert into database

-			$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_contact";

-			$sql.= " (element_id, fk_socpeople, datecreate, statut, fk_c_type_contact) ";

-			$sql.= " VALUES (".$this->id.", ".$fk_socpeople." , " ;

-			$sql.= "'".$this->db->idate($datecreate)."'";

-			$sql.= ", 4, ". $id_type_contact;

-			$sql.= ")";

+    /**

+     * @var string		Column name of the ref field.

+     */

+    protected $table_ref_field = '';

 

-			$resql=$this->db->query($sql);

-			if ($resql)

-			{

-				if (! $notrigger)

-				{

-					$result=$this->call_trigger(strtoupper($this->element).'_ADD_CONTACT', $user);

-					if ($result < 0)

-					{

-						$this->db->rollback();

-						return -1;

-					}

-				}

 

-				$this->db->commit();

-				return 1;

-			}

-			else

-			{

-				if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')

-				{

-					$this->error=$this->db->errno();

-					$this->db->rollback();

-					echo 'err rollback';

-					return -2;

-				}

-				else

-				{

-					$this->error=$this->db->error();

-					$this->db->rollback();

-					return -1;

-				}

-			}

-		} else return 0;

-	}

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    Copy contact from one element to current

-	 *

-	 *    @param    CommonObject    $objFrom    Source element

-	 *    @param    string          $source     Nature of contact ('internal' or 'external')

-	 *    @return   int                         >0 if OK, <0 if KO

-	 */

-	function copy_linked_contact($objFrom, $source='internal')

-	{

-        // phpcs:enable

-		$contacts = $objFrom->liste_contact(-1, $source);

-		foreach($contacts as $contact)

-		{

-			if ($this->add_contact($contact['id'], $contact['fk_c_type_contact'], $contact['source']) < 0)

-			{

-				$this->error=$this->db->lasterror();

-				return -1;

-			}

-		}

-		return 1;

-	}

+    // Following vars are used by some objects only. We keep this property here in CommonObject to be able to provide common method using them.

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *      Update a link to contact line

-	 *

-	 *      @param	int		$rowid              Id of line contact-element

-	 * 		@param	int		$statut	            New status of link

-	 *      @param  int		$type_contact_id    Id of contact type (not modified if 0)

-	 *      @param  int		$fk_socpeople	    Id of soc_people to update (not modified if 0)

-	 *      @return int                 		<0 if KO, >= 0 if OK

-	 */

-	function update_contact($rowid, $statut, $type_contact_id=0, $fk_socpeople=0)

-	{

-        // phpcs:enable

-		// Insert into database

-		$sql = "UPDATE ".MAIN_DB_PREFIX."element_contact set";

-		$sql.= " statut = ".$statut;

-		if ($type_contact_id) $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";

-		if ($fk_socpeople) $sql.= ", fk_socpeople = '".$fk_socpeople ."'";

-		$sql.= " where rowid = ".$rowid;

-		$resql=$this->db->query($sql);

-		if ($resql)

-		{

-			return 0;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			return -1;

-		}

-	}

+    /**

+     * @var array<string,mixed>		Can be used to pass information when only object is provided to method

+     */

+    public $context=array();

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    Delete a link to contact line

-	 *

-	 *    @param	int		$rowid			Id of contact link line to delete

-	 *    @param	int		$notrigger		Disable all triggers

-	 *    @return   int						>0 if OK, <0 if KO

-	 */

-	function delete_contact($rowid, $notrigger=0)

-	{

-        // phpcs:enable

-		global $user;

+    /**

+     * @var string		Contains canvas name if record is an alternative canvas record

+     */

+    public $canvas;

 

+    /**

+     * @var Project The related project

+     * @see fetch_projet()

+     */

+    public $project;

 

-		$this->db->begin();

+    /**

+     * @var int The related project ID

+     * @see setProject(), project

+     */

+    public $fk_project;

 

-		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

-		$sql.= " WHERE rowid =".$rowid;

+    /**

+     * @deprecated

+     * @see project

+     */

+    public $projet;

 

-		dol_syslog(get_class($this)."::delete_contact", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			if (! $notrigger)

-			{

-				$result=$this->call_trigger(strtoupper($this->element).'_DELETE_CONTACT', $user);

-				if ($result < 0) { $this->db->rollback(); return -1; }

-			}

-

-			$this->db->commit();

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return -1;

-		}

-	}

+    /**

+     * @var Contact a related contact

+     * @see fetch_contact()

+     */

+    public $contact;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    Delete all links between an object $this and all its contacts

-	 *

-	 *	  @param	string	$source		'' or 'internal' or 'external'

-	 *	  @param	string	$code		Type of contact (code or id)

-	 *    @return   int					>0 if OK, <0 if KO

-	 */

-	function delete_linked_contact($source='',$code='')

-	{

-        // phpcs:enable

-		$temp = array();

-		$typeContact = $this->liste_type_contact($source,'',0,0,$code);

-

-		foreach($typeContact as $key => $value)

-		{

-			array_push($temp,$key);

-		}

-		$listId = implode(",", $temp);

-

-		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

-		$sql.= " WHERE element_id = ".$this->id;

-		if ($listId)

-			$sql.= " AND fk_c_type_contact IN (".$listId.")";

-

-		dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			return -1;

-		}

-	}

+    /**

+     * @var int The related contact ID

+     * @see fetch_contact()

+     */

+    public $contact_id;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    Get array of all contacts for an object

-	 *

-	 *    @param	int			$statut		Status of links to get (-1=all)

-	 *    @param	string		$source		Source of contact: external or thirdparty (llx_socpeople) or internal (llx_user)

-	 *    @param	int         $list       0:Return array contains all properties, 1:Return array contains just id

-	 *    @param    string      $code       Filter on this code of contact type ('SHIPPING', 'BILLING', ...)

-	 *    @return	array|int		        Array of contacts, -1 if error

-	 */

-	function liste_contact($statut=-1,$source='external',$list=0,$code='')

-	{

-        // phpcs:enable

-		global $langs;

-

-		$tab=array();

-

-		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact";    // This field contains id of llx_socpeople or id of llx_user

-		if ($source == 'internal') $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";

-		if ($source == 'external' || $source == 'thirdparty') $sql.=", t.fk_soc as socid, t.statut as statuscontact";

-		$sql.= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";

-		$sql.= ", tc.source, tc.element, tc.code, tc.libelle";

-		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";

-		$sql.= ", ".MAIN_DB_PREFIX."element_contact ec";

-		if ($source == 'internal') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";

-		if ($source == 'external'|| $source == 'thirdparty') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";

-		$sql.= " WHERE ec.element_id =".$this->id;

-		$sql.= " AND ec.fk_c_type_contact=tc.rowid";

-		$sql.= " AND tc.element='".$this->db->escape($this->element)."'";

-		if ($code) $sql.= " AND tc.code = '".$this->db->escape($code)."'";

-		if ($source == 'internal') $sql.= " AND tc.source = 'internal'";

-		if ($source == 'external' || $source == 'thirdparty') $sql.= " AND tc.source = 'external'";

-		$sql.= " AND tc.active=1";

-		if ($statut >= 0) $sql.= " AND ec.statut = '".$statut."'";

-		$sql.=" ORDER BY t.lastname ASC";

-

-		dol_syslog(get_class($this)."::liste_contact", LOG_DEBUG);

-		$resql=$this->db->query($sql);

-		if ($resql)

-		{

-			$num=$this->db->num_rows($resql);

-			$i=0;

-			while ($i < $num)

-			{

-				$obj = $this->db->fetch_object($resql);

+    /**

+     * @var Societe A related thirdparty

+     * @see fetch_thirdparty()

+     */

+    public $thirdparty;

 

-				if (! $list)

-				{

-					$transkey="TypeContact_".$obj->element."_".$obj->source."_".$obj->code;

-					$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

-					$tab[$i]=array('source'=>$obj->source,'socid'=>$obj->socid,'id'=>$obj->id,

-								   'nom'=>$obj->lastname,      // For backward compatibility

-								   'civility'=>$obj->civility, 'lastname'=>$obj->lastname, 'firstname'=>$obj->firstname, 'email'=>$obj->email, 'login'=>$obj->login, 'photo'=>$obj->photo, 'statuscontact'=>$obj->statuscontact,

-								   'rowid'=>$obj->rowid, 'code'=>$obj->code, 'libelle'=>$libelle_type, 'status'=>$obj->statuslink, 'fk_c_type_contact'=>$obj->fk_c_type_contact);

-				}

-				else

-				{

-					$tab[$i]=$obj->id;

-				}

+    /**

+     * @var User A related user

+     * @see fetch_user()

+     */

+    public $user;

 

-				$i++;

-			}

-

-			return $tab;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			dol_print_error($this->db);

-			return -1;

-		}

-	}

-

-

-	/**

-	 * 		Update status of a contact linked to object

-	 *

-	 * 		@param	int		$rowid		Id of link between object and contact

-	 * 		@return	int					<0 if KO, >=0 if OK

-	 */

-	function swapContactStatus($rowid)

-	{

-		$sql = "SELECT ec.datecreate, ec.statut, ec.fk_socpeople, ec.fk_c_type_contact,";

-		$sql.= " tc.code, tc.libelle";

-		//$sql.= ", s.fk_soc";

-		$sql.= " FROM (".MAIN_DB_PREFIX."element_contact as ec, ".MAIN_DB_PREFIX."c_type_contact as tc)";

-		//$sql.= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople as s ON ec.fk_socpeople=s.rowid";	// Si contact de type external, alors il est lie a une societe

-		$sql.= " WHERE ec.rowid =".$rowid;

-		$sql.= " AND ec.fk_c_type_contact=tc.rowid";

-		$sql.= " AND tc.element = '".$this->db->escape($this->element)."'";

-

-		dol_syslog(get_class($this)."::swapContactStatus", LOG_DEBUG);

-		$resql=$this->db->query($sql);

-		if ($resql)

-		{

-			$obj = $this->db->fetch_object($resql);

-			$newstatut = ($obj->statut == 4) ? 5 : 4;

-			$result = $this->update_contact($rowid, $newstatut);

-			$this->db->free($resql);

-			return $result;

-		}

-		else

-		{

-			$this->error=$this->db->error();

-			dol_print_error($this->db);

-			return -1;

-		}

-	}

+    /**

+     * @var string 	The type of originating object ('commande', 'facture', ...)

+     * @see fetch_origin()

+     */

+    public $origin;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *      Return array with list of possible values for type of contacts

-	 *

-	 *      @param	string	$source     'internal', 'external' or 'all'

-	 *      @param	string	$order		Sort order by : 'position', 'code', 'rowid'...

-	 *      @param  int		$option     0=Return array id->label, 1=Return array code->label

-	 *      @param  int		$activeonly 0=all status of contact, 1=only the active

-	 *		@param	string	$code		Type of contact (Example: 'CUSTOMER', 'SERVICE')

-	 *      @return array       		Array list of type of contacts (id->label if option=0, code->label if option=1)

-	 */

-	function liste_type_contact($source='internal', $order='position', $option=0, $activeonly=0, $code='')

-	{

-        // phpcs:enable

-		global $langs;

-

-		if (empty($order)) $order='position';

-		if ($order == 'position') $order.=',code';

-

-		$tab = array();

-		$sql = "SELECT DISTINCT tc.rowid, tc.code, tc.libelle, tc.position";

-		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

-		$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

-		if ($activeonly == 1) $sql.= " AND tc.active=1"; // only the active types

-		if (! empty($source) && $source != 'all') $sql.= " AND tc.source='".$this->db->escape($source)."'";

-		if (! empty($code)) $sql.= " AND tc.code='".$this->db->escape($code)."'";

-		$sql.= $this->db->order($order,'ASC');

-

-		//print "sql=".$sql;

-		$resql=$this->db->query($sql);

-		if ($resql)

-		{

-			$num=$this->db->num_rows($resql);

-			$i=0;

-			while ($i < $num)

-			{

-				$obj = $this->db->fetch_object($resql);

-

-				$transkey="TypeContact_".$this->element."_".$source."_".$obj->code;

-				$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

-				if (empty($option)) $tab[$obj->rowid]=$libelle_type;

-				else $tab[$obj->code]=$libelle_type;

-				$i++;

-			}

-			return $tab;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			//dol_print_error($this->db);

-			return null;

-		}

-	}

-

-	/**

-	 *      Return id of contacts for a source and a contact code.

-	 *      Example: contact client de facturation ('external', 'BILLING')

-	 *      Example: contact client de livraison ('external', 'SHIPPING')

-	 *      Example: contact interne suivi paiement ('internal', 'SALESREPFOLL')

-	 *

-	 *		@param	string	$source		'external' or 'internal'

-	 *		@param	string	$code		'BILLING', 'SHIPPING', 'SALESREPFOLL', ...

-	 *		@param	int		$status		limited to a certain status

-	 *      @return array       		List of id for such contacts

-	 */

-	function getIdContact($source,$code,$status=0)

-	{

-		global $conf;

-

-		$result=array();

-		$i=0;

-		//cas particulier pour les expeditions

-		if($this->element=='shipping' && $this->origin_id != 0) {

-			$id=$this->origin_id;

-			$element='commande';

-        } else if($this->element=='reception' && $this->origin_id != 0) {

-            $id=$this->origin_id;

-            $element='order_supplier';

-		} else {

-			$id=$this->id;

-			$element=$this->element;

-		}

-

-		$sql = "SELECT ec.fk_socpeople";

-		$sql.= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";

-		if ($source == 'internal') $sql.= " ".MAIN_DB_PREFIX."user as c,";

-		if ($source == 'external') $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";

-		$sql.= " ".MAIN_DB_PREFIX."c_type_contact as tc";

-		$sql.= " WHERE ec.element_id = ".$id;

-		$sql.= " AND ec.fk_socpeople = c.rowid";

-		if ($source == 'internal') $sql.= " AND c.entity IN (".getEntity('user').")";

-		if ($source == 'external') $sql.= " AND c.entity IN (".getEntity('societe').")";

-		$sql.= " AND ec.fk_c_type_contact = tc.rowid";

-		$sql.= " AND tc.element = '".$element."'";

-		$sql.= " AND tc.source = '".$source."'";

-		$sql.= " AND tc.code = '".$code."'";

-		$sql.= " AND tc.active = 1";

-		if ($status) $sql.= " AND ec.statut = ".$status;

-

-		dol_syslog(get_class($this)."::getIdContact", LOG_DEBUG);

-		$resql=$this->db->query($sql);

-		if ($resql)

-		{

-			while ($obj = $this->db->fetch_object($resql))

-			{

-				$result[$i]=$obj->fk_socpeople;

-				$i++;

-			}

-		}

-		else

-		{

-			$this->error=$this->db->error();

-			return null;

-		}

-

-		return $result;

-	}

+    /**

+     * @var int 	The id of originating object

+     * @see fetch_origin()

+     */

+    public $origin_id;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *		Load object contact with id=$this->contactid into $this->contact

-	 *

-	 *		@param	int		$contactid      Id du contact. Use this->contactid if empty.

-	 *		@return	int						<0 if KO, >0 if OK

-	 */

-	function fetch_contact($contactid=null)

-	{

-        // phpcs:enable

-		if (empty($contactid)) $contactid=$this->contactid;

+    /**

+     * @var string The object's reference

+     */

+    public $ref;

 

-		if (empty($contactid)) return 0;

+    /**

+     * @var string The object's previous reference

+     */

+    public $ref_previous;

 

-		require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

-		$contact = new Contact($this->db);

-		$result=$contact->fetch($contactid);

-		$this->contact = $contact;

-		return $result;

-	}

+    /**

+     * @var string The object's next reference

+     */

+    public $ref_next;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    	Load the third party of object, from id $this->socid or $this->fk_soc, into this->thirdparty

-	 *

-	 *		@param		int		$force_thirdparty_id	Force thirdparty id

-	 *		@return		int								<0 if KO, >0 if OK

-	 */

-	function fetch_thirdparty($force_thirdparty_id=0)

-	{

-        // phpcs:enable

-		global $conf;

+    /**

+     * @var string An external reference for the object

+     */

+    public $ref_ext;

 

-		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id))

-			return 0;

+    /**

+     * @var int The object's status

+     * @see setStatut()

+     */

+    public $statut;

 

-		require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

+    /**

+     * @var string

+     * @see getFullAddress()

+     */

+    public $country;

 

-		$idtofetch = isset($this->socid) ? $this->socid : (isset($this->fk_soc) ? $this->fk_soc : $this->fk_thirdparty);

-		if ($force_thirdparty_id)

-			$idtofetch = $force_thirdparty_id;

+    /**

+     * @var int

+     * @see getFullAddress(), country

+     */

+    public $country_id;

 

-		if ($idtofetch) {

-			$thirdparty = new Societe($this->db);

-			$result = $thirdparty->fetch($idtofetch);

-			$this->thirdparty = $thirdparty;

+    /**

+     * @var string

+     * @see getFullAddress(), isInEEC(), country

+     */

+    public $country_code;

 

-			// Use first price level if level not defined for third party

-			if (!empty($conf->global->PRODUIT_MULTIPRICES) && empty($this->thirdparty->price_level)) {

-				$this->thirdparty->price_level = 1;

-			}

+    /**

+     * @var string

+     * @see getFullAddress()

+     */

+    public $state;

 

-			return $result;

-		} else

-			return -1;

-	}

+    /**

+     * @var int

+     * @see getFullAddress(), state

+     */

+    public $state_id;

 

+    /**

+     * @var string

+     * @see getFullAddress(), state

+     */

+    public $state_code;

 

-	/**

-	 * Looks for an object with ref matching the wildcard provided

-	 * It does only work when $this->table_ref_field is set

-	 *

-	 * @param string $ref Wildcard

-	 * @return int >1 = OK, 0 = Not found or table_ref_field not defined, <0 = KO

-	 */

-	public function fetchOneLike($ref)

-	{

-		if (!$this->table_ref_field) {

-			return 0;

-		}

+    /**

+     * @var string

+     * @see getFullAddress(), region

+     */

+    public $region;

 

-		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element.' WHERE '.$this->table_ref_field.' LIKE "'.$this->db->escape($ref).'" LIMIT 1';

+    /**

+     * @var string

+     * @see getFullAddress(), region

+     */

+    public $region_code;

 

-		$query = $this->db->query($sql);

+    /**

+     * @var int

+     * @see fetch_barcode()

+     */

+    public $barcode_type;

 

-		if (!$this->db->num_rows($query)) {

-			return 0;

-		}

+    /**

+     * @var string

+     * @see fetch_barcode(), barcode_type

+     */

+    public $barcode_type_code;

 

-		$result = $this->db->fetch_object($query);

+    /**

+     * @var string

+     * @see fetch_barcode(), barcode_type

+     */

+    public $barcode_type_label;

 

-		return $this->fetch($result->rowid);

-	}

+    /**

+     * @var string

+     * @see fetch_barcode(), barcode_type

+     */

+    public $barcode_type_coder;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *	Load data for barcode into properties ->barcode_type*

-	 *	Properties ->barcode_type that is id of barcode. Type is used to find other properties, but

-	 *  if it is not defined, ->element must be defined to know default barcode type.

-	 *

-	 *	@return		int			<0 if KO, 0 if can't guess type of barcode (ISBN, EAN13...), >0 if OK (all barcode properties loaded)

-	 */

-	function fetch_barcode()

-	{

-        // phpcs:enable

-		global $conf;

+    /**

+     * @var int Payment method ID (cheque, cash, ...)

+     * @see setPaymentMethods()

+     */

+    public $mode_reglement_id;

 

-		dol_syslog(get_class($this).'::fetch_barcode this->element='.$this->element.' this->barcode_type='.$this->barcode_type);

+    /**

+     * @var int Payment terms ID

+     * @see setPaymentTerms()

+     */

+    public $cond_reglement_id;

 

-		$idtype=$this->barcode_type;

-		if (empty($idtype) && $idtype != '0')	// If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

-		{

-			if ($this->element == 'product')      $idtype = $conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;

-			else if ($this->element == 'societe') $idtype = $conf->global->GENBARCODE_BARCODETYPE_THIRDPARTY;

-			else dol_syslog('Call fetch_barcode with barcode_type not defined and cant be guessed', LOG_WARNING);

-		}

+    /**

+     * @var int Payment terms ID

+     * @deprecated Kept for compatibility

+     * @see cond_reglement_id;

+     */

+    public $cond_reglement;

 

-		if ($idtype > 0)

-		{

-			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder))    // If data not already loaded

-			{

-				$sql = "SELECT rowid, code, libelle as label, coder";

-				$sql.= " FROM ".MAIN_DB_PREFIX."c_barcode_type";

-				$sql.= " WHERE rowid = ".$idtype;

-				dol_syslog(get_class($this).'::fetch_barcode', LOG_DEBUG);

-				$resql = $this->db->query($sql);

-				if ($resql)

-				{

-					$obj = $this->db->fetch_object($resql);

-					$this->barcode_type       = $obj->rowid;

-					$this->barcode_type_code  = $obj->code;

-					$this->barcode_type_label = $obj->label;

-					$this->barcode_type_coder = $obj->coder;

-					return 1;

-				}

-				else

-				{

-					dol_print_error($this->db);

-					return -1;

-				}

-			}

-		}

-		return 0;

-	}

+    /**

+     * @var int Delivery address ID

+     * @deprecated

+     * @see setDeliveryAddress()

+     */

+    public $fk_delivery_address;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *		Load the project with id $this->fk_project into this->project

-	 *

-	 *		@return		int			<0 if KO, >=0 if OK

-	 */

-	function fetch_projet()

-	{

-        // phpcs:enable

-		include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';

+    /**

+     * @var int Shipping method ID

+     * @see setShippingMethod()

+     */

+    public $shipping_method_id;

 

-		if (empty($this->fk_project) && ! empty($this->fk_projet)) $this->fk_project = $this->fk_projet;	// For backward compatibility

-		if (empty($this->fk_project)) return 0;

+    /**

+     * @var string

+     * @see SetDocModel()

+     */

+    public $modelpdf;

 

-		$project = new Project($this->db);

-		$result = $project->fetch($this->fk_project);

+    /**

+     * @var int Bank account ID

+     * @see SetBankAccount()

+     */

+    public $fk_account;

 

-		$this->projet = $project;	// deprecated

-		$this->project = $project;

-		return $result;

-	}

+    /**

+     * @var string Public note

+     * @see update_note()

+     */

+    public $note_public;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *		Load the product with id $this->fk_product into this->product

-	 *

-	 *		@return		int			<0 if KO, >=0 if OK

-	 */

-	function fetch_product()

-	{

-        // phpcs:enable

-		include_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

+    /**

+     * @var string Private note

+     * @see update_note()

+     */

+    public $note_private;

 

-		if (empty($this->fk_product)) return 0;

+    /**

+     * @deprecated

+     * @see note_public

+     */

+    public $note;

 

-		$product = new Product($this->db);

-		$result = $product->fetch($this->fk_product);

+    /**

+     * @var float Total amount before taxes

+     * @see update_price()

+     */

+    public $total_ht;

 

-		$this->product = $product;

-		return $result;

-	}

+    /**

+     * @var float Total VAT amount

+     * @see update_price()

+     */

+    public $total_tva;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *		Load the user with id $userid into this->user

-	 *

-	 *		@param	int		$userid 		Id du contact

-	 *		@return	int						<0 if KO, >0 if OK

-	 */

-	function fetch_user($userid)

-	{

-        // phpcs:enable

-		$user = new User($this->db);

-		$result=$user->fetch($userid);

-		$this->user = $user;

-		return $result;

-	}

+    /**

+     * @var float Total local tax 1 amount

+     * @see update_price()

+     */

+    public $total_localtax1;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *	Read linked origin object

-	 *

-	 *	@return		void

-	 */

-	function fetch_origin()

-	{

-        // phpcs:enable

-		if ($this->origin == 'shipping') $this->origin = 'expedition';

-		if ($this->origin == 'delivery') $this->origin = 'livraison';

-        if ($this->origin == 'order_supplier') $this->origin = 'commandeFournisseur';

+    /**

+     * @var float Total local tax 2 amount

+     * @see update_price()

+     */

+    public $total_localtax2;

 

-		$origin = $this->origin;

+    /**

+     * @var float Total amount with taxes

+     * @see update_price()

+     */

+    public $total_ttc;

 

-		$classname = ucfirst($origin);

-		$this->$origin = new $classname($this->db);

-		$this->$origin->fetch($this->origin_id);

-	}

+    /**

+     * @var CommonObjectLine[]

+     */

+    public $lines;

 

-	/**

-     *  Load object from specific field

-     *

-     *  @param	string	$table		Table element or element line

-     *  @param	string	$field		Field selected

-     *  @param	string	$key		Import key

-     *  @param	string	$element	Element name

-     *	@return	int					<0 if KO, >0 if OK

+    /**

+     * @var mixed		Contains comments

+     * @see fetchComments()

      */

-	function fetchObjectFrom($table, $field, $key, $element = null)

-	{

-		global $conf;

-

-		$result=false;

-

-		$sql = "SELECT rowid FROM ".MAIN_DB_PREFIX.$table;

-		$sql.= " WHERE ".$field." = '".$key."'";

-		if (! empty($element)) {

-			$sql.= " AND entity IN (".getEntity($element).")";

-		} else {

-			$sql.= " AND entity = ".$conf->entity;

-		}

-

-		dol_syslog(get_class($this).'::fetchObjectFrom', LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$row = $this->db->fetch_row($resql);

-			// Test for avoid error -1

-			if ($row[0] > 0) {

-				$result = $this->fetch($row[0]);

-			}

-		}

-

-		return $result;

-	}

-

-	/**

-	 *	Getter generic. Load value from a specific field

-	 *

-	 *	@param	string	$table		Table of element or element line

-	 *	@param	int		$id			Element id

-	 *	@param	string	$field		Field selected

-	 *	@return	int					<0 if KO, >0 if OK

-	 */

-	function getValueFrom($table, $id, $field)

-	{

-		$result=false;

-		if (!empty($id) && !empty($field) && !empty($table)) {

-			$sql = "SELECT ".$field." FROM ".MAIN_DB_PREFIX.$table;

-			$sql.= " WHERE rowid = ".$id;

-

-			dol_syslog(get_class($this).'::getValueFrom', LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if ($resql)

-			{

-				$row = $this->db->fetch_row($resql);

-				$result = $row[0];

-			}

-		}

-		return $result;

-	}

-

-	/**

-	 *	Setter generic. Update a specific field into database.

-	 *  Warning: Trigger is run only if param trigkey is provided.

-	 *

-	 *	@param	string		$field			Field to update

-	 *	@param	mixed		$value			New value

-	 *	@param	string		$table			To force other table element or element line (should not be used)

-	 *	@param	int			$id				To force other object id (should not be used)

-	 *	@param	string		$format			Data format ('text', 'date'). 'text' is used if not defined

-	 *	@param	string		$id_field		To force rowid field name. 'rowid' is used if not defined

-	 *	@param	User|string	$fuser			Update the user of last update field with this user. If not provided, current user is used except if value is 'none'

-	 *  @param  string      $trigkey    	Trigger key to run (in most cases something like 'XXX_MODIFY')

-	 *  @param	string		$fk_user_field	Name of field to save user id making change

-	 *	@return	int							<0 if KO, >0 if OK

-	 *  @see updateExtraField

-	 */

-	function setValueFrom($field, $value, $table='', $id=null, $format='', $id_field='', $fuser=null, $trigkey='', $fk_user_field='fk_user_modif')

-	{

-		global $user,$langs,$conf;

-

-		if (empty($table)) 	  $table=$this->table_element;

-		if (empty($id))    	  $id=$this->id;

-		if (empty($format))   $format='text';

-		if (empty($id_field)) $id_field='rowid';

-

-		$error=0;

-

-		$this->db->begin();

-

-		// Special case

-		if ($table == 'product' && $field == 'note_private') $field='note';

-		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) $fk_user_field = 'fk_user_mod';

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$table." SET ";

-

-		if ($format == 'text') $sql.= $field." = '".$this->db->escape($value)."'";

-		else if ($format == 'int') $sql.= $field." = ".$this->db->escape($value);

-		else if ($format == 'date') $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");

-

-		if ($fk_user_field)

-		{

-			if (! empty($fuser) && is_object($fuser)) $sql.=", ".$fk_user_field." = ".$fuser->id;

-			elseif (empty($fuser) || $fuser != 'none') $sql.=", ".$fk_user_field." = ".$user->id;

-		}

-

-		$sql.= " WHERE ".$id_field." = ".$id;

-

-		dol_syslog(get_class($this)."::".__FUNCTION__."", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			if ($trigkey)

-			{

-				// call trigger with updated object values

-				if (empty($this->fields) && method_exists($this, 'fetch'))

-				{

-					$result = $this->fetch($id);

-				}

-				else

-				{

-					$result = $this->fetchCommon($id);

-				}

-				if ($result >= 0) $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);   // This may set this->errors

-				if ($result < 0) $error++;

-			}

+    public $comments=array();

 

-			if (! $error)

-			{

-				if (property_exists($this, $field)) $this->$field = $value;

-				$this->db->commit();

-				return 1;

-			}

-			else

-			{

-				$this->db->rollback();

-				return -2;

-			}

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return -1;

-		}

-	}

+    /**

+     * @var int

+     * @see setIncoterms()

+     */

+    public $fk_incoterms;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *      Load properties id_previous and id_next by comparing $fieldid with $this->ref

-	 *

-	 *      @param	string	$filter		Optional filter. Example: " AND (t.field1 = 'aa' OR t.field2 = 'bb')"

-	 *	 	@param  string	$fieldid   	Name of field to use for the select MAX and MIN

-	 *		@param	int		$nodbprefix	Do not include DB prefix to forge table name

-	 *      @return int         		<0 if KO, >0 if OK

-	 */

-	function load_previous_next_ref($filter, $fieldid, $nodbprefix=0)

-	{

-        // phpcs:enable

-		global $conf, $user;

-

-		if (! $this->table_element)

-		{

-			dol_print_error('',get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");

-			return -1;

-		}

-		if ($fieldid == 'none') return 1;

-

-		// Security on socid

-		$socid = 0;

-		if ($user->societe_id > 0) $socid = $user->societe_id;

-

-		// this->ismultientitymanaged contains

-		// 0=No test on entity, 1=Test with field entity, 2=Test with link by societe

-		$alias = 's';

-		if ($this->element == 'societe') $alias = 'te';

-

-		$sql = "SELECT MAX(te.".$fieldid.")";

-		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

-		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

-		$sql.= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

-		if (! empty($filter))

-		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

-			$sql.=$filter;

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

-			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

-					$sql.= " AND te.entity IS NOT NULL"; // Show all users

-				} else {

-					$sql.= " AND ug.fk_user = te.rowid";

-					$sql.= " AND ug.entity IN (".getEntity($this->element).")";

-				}

-			} else {

-				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

-			}

-		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

-		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

-

-		$result = $this->db->query($sql);

-		if (! $result)

-		{

-			$this->error=$this->db->lasterror();

-			return -1;

-		}

-		$row = $this->db->fetch_row($result);

-		$this->ref_previous = $row[0];

-

-

-		$sql = "SELECT MIN(te.".$fieldid.")";

-		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

-		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

-		$sql.= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

-		if (! empty($filter))

-		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

-			$sql.=$filter;

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

-			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

-					$sql.= " AND te.entity IS NOT NULL"; // Show all users

-				} else {

-					$sql.= " AND ug.fk_user = te.rowid";

-					$sql.= " AND ug.entity IN (".getEntity($this->element).")";

-				}

-			} else {

-				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

-			}

-		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

-		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

-		// Rem: Bug in some mysql version: SELECT MIN(rowid) FROM llx_socpeople WHERE rowid > 1 when one row in database with rowid=1, returns 1 instead of null

-

-		$result = $this->db->query($sql);

-		if (! $result)

-		{

-			$this->error=$this->db->lasterror();

-			return -2;

-		}

-		$row = $this->db->fetch_row($result);

-		$this->ref_next = $row[0];

-

-		return 1;

-	}

-

-

-	/**

-	 *      Return list of id of contacts of object

-	 *

-	 *      @param	string	$source     Source of contact: external (llx_socpeople) or internal (llx_user) or thirdparty (llx_societe)

-	 *      @return array				Array of id of contacts (if source=external or internal)

-	 * 									Array of id of third parties with at least one contact on object (if source=thirdparty)

-	 */

-	function getListContactId($source='external')

-	{

-		$contactAlreadySelected = array();

-		$tab = $this->liste_contact(-1,$source);

-		$num=count($tab);

-		$i = 0;

-		while ($i < $num)

-		{

-			if ($source == 'thirdparty') $contactAlreadySelected[$i] = $tab[$i]['socid'];

-			else  $contactAlreadySelected[$i] = $tab[$i]['id'];

-			$i++;

-		}

-		return $contactAlreadySelected;

-	}

-

-

-	/**

-	 *	Link element with a project

-	 *

-	 *	@param     	int		$projectid		Project id to link element to

-	 *	@return		int						<0 if KO, >0 if OK

-	 */

-	function setProject($projectid)

-	{

-		if (! $this->table_element)

-		{

-			dol_syslog(get_class($this)."::setProject was called on objet with property table_element not defined",LOG_ERR);

-			return -1;

-		}

-

-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-		if ($this->table_element == 'actioncomm')

-		{

-			if ($projectid) $sql.= ' SET fk_project = '.$projectid;

-			else $sql.= ' SET fk_project = NULL';

-			$sql.= ' WHERE id = '.$this->id;

-		}

-		else

-		{

-			if ($projectid) $sql.= ' SET fk_projet = '.$projectid;

-			else $sql.= ' SET fk_projet = NULL';

-			$sql.= ' WHERE rowid = '.$this->id;

-		}

-

-		dol_syslog(get_class($this)."::setProject", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			$this->fk_project = $projectid;

-			return 1;

-		}

-		else

-		{

-			dol_print_error($this->db);

-			return -1;

-		}

-	}

-

-	/**

-	 *  Change the payments methods

-	 *

-	 *  @param		int		$id		Id of new payment method

-	 *  @return		int				>0 if OK, <0 if KO

-	 */

-	function setPaymentMethods($id)

-	{

-		dol_syslog(get_class($this).'::setPaymentMethods('.$id.')');

-		if ($this->statut >= 0 || $this->element == 'societe')

-		{

-			// TODO uniformize field name

-			$fieldname = 'fk_mode_reglement';

-			if ($this->element == 'societe') $fieldname = 'mode_reglement';

-			if (get_class($this) == 'Fournisseur') $fieldname = 'mode_reglement_supplier';

-

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-			$sql .= ' SET '.$fieldname.' = '.$id;

-			$sql .= ' WHERE rowid='.$this->id;

-

-			if ($this->db->query($sql))

-			{

-				$this->mode_reglement_id = $id;

-				// for supplier

-				if (get_class($this) == 'Fournisseur') $this->mode_reglement_supplier_id = $id;

-				return 1;

-			}

-			else

-			{

-				dol_syslog(get_class($this).'::setPaymentMethods Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

-				return -1;

-			}

-		}

-		else

-		{

-			dol_syslog(get_class($this).'::setPaymentMethods, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

-			return -2;

-		}

-	}

-

-	/**

-	 *  Change the multicurrency code

-	 *

-	 *  @param		string	$code	multicurrency code

-	 *  @return		int				>0 if OK, <0 if KO

-	 */

-	function setMulticurrencyCode($code)

-	{

-		dol_syslog(get_class($this).'::setMulticurrencyCode('.$id.')');

-		if ($this->statut >= 0 || $this->element == 'societe')

-		{

-			$fieldname = 'multicurrency_code';

-

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-			$sql .= ' SET '.$fieldname." = '".$this->db->escape($code)."'";

-			$sql .= ' WHERE rowid='.$this->id;

-

-			if ($this->db->query($sql))

-			{

-				$this->multicurrency_code = $code;

+    /**

+     * @var string

+     * @see SetIncoterms()

+     */

+    public $libelle_incoterms;

 

-				list($fk_multicurrency, $rate) = MultiCurrency::getIdAndTxFromCode($this->db, $code);

-				if ($rate) $this->setMulticurrencyRate($rate,2);

+    /**

+     * @var string

+     * @see display_incoterms()

+     */

+    public $location_incoterms;

 

-				return 1;

-			}

-			else

-			{

-				dol_syslog(get_class($this).'::setMulticurrencyCode Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

-				return -1;

-			}

-		}

-		else

-		{

-			dol_syslog(get_class($this).'::setMulticurrencyCode, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

-			return -2;

-		}

-	}

-

-	/**

-	 *  Change the multicurrency rate

-	 *

-	 *  @param		double	$rate	multicurrency rate

-	 *  @param		int		$mode	mode 1 : amounts in company currency will be recalculated, mode 2 : amounts in foreign currency

-	 *  @return		int				>0 if OK, <0 if KO

-	 */

-	function setMulticurrencyRate($rate, $mode=1)

-	{

-		dol_syslog(get_class($this).'::setMulticurrencyRate('.$id.')');

-		if ($this->statut >= 0 || $this->element == 'societe')

-		{

-			$fieldname = 'multicurrency_tx';

-

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-			$sql .= ' SET '.$fieldname.' = '.$rate;

-			$sql .= ' WHERE rowid='.$this->id;

-

-			if ($this->db->query($sql))

-			{

-				$this->multicurrency_tx = $rate;

+    public $name;

+    public $lastname;

+    public $firstname;

+    public $civility_id;

 

-				// Update line price

-				if (!empty($this->lines))

-				{

-					foreach ($this->lines as &$line)

-					{

-						if($mode == 1) {

-							$line->subprice = 0;

-						}

+    // Dates

+    public $date_creation;			// Date creation

+    public $date_validation;		// Date validation

+    public $date_modification;		// Date last change (tms field)

 

-						switch ($this->element) {

-							case 'propal':

-								$this->updateline(

-									$line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,

-									($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

-									$line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->date_start,

-									$line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

-								);

-								break;

-							case 'commande':

-								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

-									$line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->date_start, $line->date_end,

-									$line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,

-									$line->special_code, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

-								);

-								break;

-							case 'facture':

-								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

-									$line->date_start, $line->date_end, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits,

-									$line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,

-									$line->special_code, $line->array_options, $line->situation_percent, $line->fk_unit, $line->multicurrency_subprice

-								);

-								break;

-							case 'supplier_proposal':

-								$this->updateline(

-									$line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,

-									($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

-									$line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->array_options,

-									$line->ref_fourn, $line->multicurrency_subprice

-								);

-								break;

-							case 'order_supplier':

-								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

-									$line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->product_type, false,

-									$line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

-								);

-								break;

-							case 'invoice_supplier':

-								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->tva_tx, $line->localtax1_tx,

-									$line->localtax2_tx, $line->qty, 0, 'HT', $line->info_bits, $line->product_type, $line->remise_percent, false,

-									$line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

-								);

-								break;

-							default:

-								dol_syslog(get_class($this).'::setMulticurrencyRate no updateline defined', LOG_DEBUG);

-								break;

-						}

-					}

-				}

 

-				return 1;

-			}

-			else

-			{

-				dol_syslog(get_class($this).'::setMulticurrencyRate Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

-				return -1;

-			}

-		}

-		else

-		{

-			dol_syslog(get_class($this).'::setMulticurrencyRate, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

-			return -2;

-		}

-	}

-

-	/**

-	 *  Change the payments terms

-	 *

-	 *  @param		int		$id		Id of new payment terms

-	 *  @return		int				>0 if OK, <0 if KO

-	 */

-	function setPaymentTerms($id)

-	{

-		dol_syslog(get_class($this).'::setPaymentTerms('.$id.')');

-		if ($this->statut >= 0 || $this->element == 'societe')

-		{

-			// TODO uniformize field name

-			$fieldname = 'fk_cond_reglement';

-			if ($this->element == 'societe') $fieldname = 'cond_reglement';

-			if (get_class($this) == 'Fournisseur') $fieldname = 'cond_reglement_supplier';

-

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-			$sql .= ' SET '.$fieldname.' = '.$id;

-			$sql .= ' WHERE rowid='.$this->id;

-

-			if ($this->db->query($sql))

-			{

-				$this->cond_reglement_id = $id;

-				// for supplier

-				if (get_class($this) == 'Fournisseur') $this->cond_reglement_supplier_id = $id;

-				$this->cond_reglement = $id;	// for compatibility

-				return 1;

-			}

-			else

-			{

-				dol_syslog(get_class($this).'::setPaymentTerms Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

-				return -1;

-			}

-		}

-		else

-		{

-			dol_syslog(get_class($this).'::setPaymentTerms, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

-			return -2;

-		}

-	}

-

-	/**

-	 *	Define delivery address

-	 *  @deprecated

-	 *

-	 *	@param      int		$id		Address id

-	 *	@return     int				<0 si ko, >0 si ok

-	 */

-	function setDeliveryAddress($id)

-	{

-		$fieldname = 'fk_delivery_address';

-		if ($this->element == 'delivery' || $this->element == 'shipping') $fieldname = 'fk_address';

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element." SET ".$fieldname." = ".$id;

-		$sql.= " WHERE rowid = ".$this->id." AND fk_statut = 0";

-

-		if ($this->db->query($sql))

-		{

-			$this->fk_delivery_address = $id;

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->error();

-			dol_syslog(get_class($this).'::setDeliveryAddress Erreur '.$sql.' - '.$this->error);

-			return -1;

-		}

-	}

-

-

-	/**

-	 *  Change the shipping method

-	 *

-	 *  @param      int     $shipping_method_id     Id of shipping method

-     *  @param      bool    $notrigger              false=launch triggers after, true=disable triggers

-     *  @param      User	$userused               Object user

-	 *

-	 *  @return     int              1 if OK, 0 if KO

-	 */

-	function setShippingMethod($shipping_method_id, $notrigger=false, $userused=null)

-	{

-        global $user;

 

-        if (empty($userused)) $userused=$user;

+    // No constructor as it is an abstract class

 

-        $error = 0;

+    /**

+     * Check an object id/ref exists

+     * If you don't need/want to instantiate object and just need to know if object exists, use this method instead of fetch

+     *

+     *  @param	string	$element   	String of element ('product', 'facture', ...)

+     *  @param	int		$id      	Id of object

+     *  @param  string	$ref     	Ref of object to check

+     *  @param	string	$ref_ext	Ref ext of object to check

+     *  @return int     			<0 if KO, 0 if OK but not found, >0 if OK and exists

+     */

+    static function isExistingObject($element, $id, $ref='', $ref_ext='')

+    {

+        global $db,$conf;

+

+        $sql = "SELECT rowid, ref, ref_ext";

+        $sql.= " FROM ".MAIN_DB_PREFIX.$element;

+        $sql.= " WHERE entity IN (".getEntity($element).")" ;

+

+        if ($id > 0) $sql.= " AND rowid = ".$db->escape($id);

+        else if ($ref) $sql.= " AND ref = '".$db->escape($ref)."'";

+        else if ($ref_ext) $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";

+        else {

+            $error='ErrorWrongParameters';

+            dol_print_error(get_class()."::isExistingObject ".$error, LOG_ERR);

+            return -1;

+        }

+        if ($ref || $ref_ext) $sql.= " AND entity = ".$conf->entity;

 

-		if (! $this->table_element) {

-			dol_syslog(get_class($this)."::setShippingMethod was called on objet with property table_element not defined",LOG_ERR);

-			return -1;

-		}

+        dol_syslog(get_class()."::isExistingObject", LOG_DEBUG);

+        $resql = $db->query($sql);

+        if ($resql)

+        {

+            $num=$db->num_rows($resql);

+            if ($num > 0) return 1;

+            else return 0;

+        }

+        return -1;

+    }

 

-        $this->db->begin();

+    /**

+     * Method to output saved errors

+     *

+     * @return	string		String with errors

+     */

+    function errorsToString()

+    {

+        return $this->error.(is_array($this->errors)?(($this->error!=''?', ':'').join(', ',$this->errors)):'');

+    }

 

-		if ($shipping_method_id<0) $shipping_method_id='NULL';

-		dol_syslog(get_class($this).'::setShippingMethod('.$shipping_method_id.')');

+    /**

+     *	Return full name (civility+' '+name+' '+lastname)

+     *

+     *	@param	Translate	$langs			Language object for translation of civility (used only if option is 1)

+     *	@param	int			$option			0=No option, 1=Add civility

+     * 	@param	int			$nameorder		-1=Auto, 0=Lastname+Firstname, 1=Firstname+Lastname, 2=Firstname

+     * 	@param	int			$maxlen			Maximum length

+     * 	@return	string						String with full name

+     */

+    function getFullName($langs,$option=0,$nameorder=-1,$maxlen=0)

+    {

+        //print "lastname=".$this->lastname." name=".$this->name." nom=".$this->nom."<br>\n";

+        $lastname=$this->lastname;

+        $firstname=$this->firstname;

+        if (empty($lastname))  $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));

 

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET fk_shipping_method = ".$shipping_method_id;

-		$sql.= " WHERE rowid=".$this->id;

-        $resql = $this->db->query($sql);

-		if (! $resql) {

-			dol_syslog(get_class($this).'::setShippingMethod Error ', LOG_DEBUG);

-			$this->error = $this->db->lasterror();

-			$error++;

-        } else {

-            if (!$notrigger)

-            {

-                // Call trigger

-                $this->context=array('shippingmethodupdate'=>1);

-                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

-                if ($result < 0) $error++;

-                // End call trigger

-            }

+        $ret='';

+        if ($option && $this->civility_id)

+        {

+            if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';

+            else $ret.=$this->civility_id.' ';

         }

-        if ($error)

+

+        $ret.=dolGetFirstLastname($firstname, $lastname, $nameorder);

+

+        return dol_trunc($ret,$maxlen);

+    }

+

+    /**

+     * 	Return full address of contact

+     *

+     * 	@param		int			$withcountry		1=Add country into address string

+     *  @param		string		$sep				Separator to use to build string

+     *  @param		int		    $withregion			1=Add region into address string

+     *	@return		string							Full address string

+     */

+    function getFullAddress($withcountry=0, $sep="\n", $withregion=0)

+    {

+        if ($withcountry && $this->country_id && (empty($this->country_code) || empty($this->country)))

         {

-            $this->db->rollback();

-            return -1;

-        } else {

-            $this->shipping_method_id = ($shipping_method_id=='NULL')?null:$shipping_method_id;

-            $this->db->commit();

-            return 1;

+            require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';

+            $tmparray=getCountry($this->country_id,'all');

+            $this->country_code=$tmparray['code'];

+            $this->country     =$tmparray['label'];

         }

-	}

-

-

-	/**

-	 *  Change the warehouse

-	 *

-	 *  @param      int     $warehouse_id     Id of warehouse

-	 *  @return     int              1 if OK, 0 if KO

-	 */

-	function setWarehouse($warehouse_id)

-	{

-		if (! $this->table_element) {

-			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined",LOG_ERR);

-			return -1;

-		}

-		if ($warehouse_id<0) $warehouse_id='NULL';

-		dol_syslog(get_class($this).'::setWarehouse('.$warehouse_id.')');

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET fk_warehouse = ".$warehouse_id;

-		$sql.= " WHERE rowid=".$this->id;

-

-		if ($this->db->query($sql)) {

-			$this->warehouse_id = ($warehouse_id=='NULL')?null:$warehouse_id;

-			return 1;

-		} else {

-			dol_syslog(get_class($this).'::setWarehouse Error ', LOG_DEBUG);

-			$this->error=$this->db->error();

-			return 0;

-		}

-	}

-

-

-	/**

-	 *		Set last model used by doc generator

-	 *

-	 *		@param		User	$user		User object that make change

-	 *		@param		string	$modelpdf	Modele name

-	 *		@return		int					<0 if KO, >0 if OK

-	 */

-	function setDocModel($user, $modelpdf)

-	{

-		if (! $this->table_element)

-		{

-			dol_syslog(get_class($this)."::setDocModel was called on objet with property table_element not defined",LOG_ERR);

-			return -1;

-		}

-

-		$newmodelpdf=dol_trunc($modelpdf,255);

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET model_pdf = '".$this->db->escape($newmodelpdf)."'";

-		$sql.= " WHERE rowid = ".$this->id;

-		// if ($this->element == 'facture') $sql.= " AND fk_statut < 2";

-		// if ($this->element == 'propal')  $sql.= " AND fk_statut = 0";

-

-		dol_syslog(get_class($this)."::setDocModel", LOG_DEBUG);

-		$resql=$this->db->query($sql);

-		if ($resql)

-		{

-			$this->modelpdf=$modelpdf;

-			return 1;

-		}

-		else

-		{

-			dol_print_error($this->db);

-			return 0;

-		}

-	}

-

-

-	/**

-	 *  Change the bank account

-	 *

-	 *  @param		int		$fk_account		Id of bank account

-	 *  @param      bool    $notrigger      false=launch triggers after, true=disable triggers

-	 *  @param      User	$userused		Object user

-	 *  @return		int				1 if OK, 0 if KO

-	 */

-	function setBankAccount($fk_account, $notrigger=false, $userused=null)

-	{

-        global $user;

 

-        if (empty($userused)) $userused=$user;

+        if ($withregion && $this->state_id && (empty($this->state_code) || empty($this->state) || empty($this->region) || empty($this->region_cpde)))

+        {

+            require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';

+            $tmparray=getState($this->state_id,'all',0,1);

+            $this->state_code   =$tmparray['code'];

+            $this->state        =$tmparray['label'];

+            $this->region_code  =$tmparray['region_code'];

+            $this->region       =$tmparray['region'];

+        }

 

-        $error = 0;

+        return dol_format_address($this, $withcountry, $sep);

+    }

 

-		if (! $this->table_element) {

-			dol_syslog(get_class($this)."::setBankAccount was called on objet with property table_element not defined",LOG_ERR);

-			return -1;

-		}

-        $this->db->begin();

 

-		if ($fk_account<0) $fk_account='NULL';

-		dol_syslog(get_class($this).'::setBankAccount('.$fk_account.')');

+    /**

+     * 	Return full address for banner

+     *

+     * 	@param		string		$htmlkey            HTML id to make banner content unique

+     *  @param      Object      $object				Object (thirdparty, thirdparty of contact for contact, null for a member)

+     *	@return		string							Full address string

+     */

+    function getBannerAddress($htmlkey, $object)

+    {

+        global $conf, $langs;

 

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET fk_account = ".$fk_account;

-		$sql.= " WHERE rowid=".$this->id;

+        $countriesusingstate=array('AU','US','IN','GB','ES','UK','TR');    // See also option MAIN_FORCE_STATE_INTO_ADDRESS

 

-        $resql = $this->db->query($sql);

-        if (! $resql)

+        $contactid=0;

+        $thirdpartyid=0;

+        if ($this->element == 'societe')

         {

-            dol_syslog(get_class($this).'::setBankAccount Error '.$sql.' - '.$this->db->error());

-            $this->error = $this->db->lasterror();

-            $error++;

+            $thirdpartyid=$this->id;

         }

-        else

+        if ($this->element == 'contact')

         {

-            if (!$notrigger)

+            $contactid=$this->id;

+            $thirdpartyid=$object->fk_soc;

+        }

+        if ($this->element == 'user')

+        {

+            $contactid=$this->contact_id;

+            $thirdpartyid=$object->fk_soc;

+        }

+

+        $out='<!-- BEGIN part to show address block -->';

+

+        $outdone=0;

+        $coords = $this->getFullAddress(1,', ',$conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT);

+        if ($coords)

+        {

+            if (! empty($conf->use_javascript_ajax))

             {

-                // Call trigger

-                $this->context=array('bankaccountupdate'=>1);

-                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

-                if ($result < 0) $error++;

-                // End call trigger

+                $namecoords = $this->getFullName($langs,1).'<br>'.$coords;

+                // hideonsmatphone because copyToClipboard call jquery dialog that does not work with jmobile

+                $out.='<a href="#" class="hideonsmartphone" onclick="return copyToClipboard(\''.dol_escape_js($namecoords).'\',\''.dol_escape_js($langs->trans("HelpCopyToClipboard")).'\');">';

+                $out.=img_picto($langs->trans("Address"), 'object_address.png');

+                $out.='</a> ';

             }

+            $out.=dol_print_address($coords, 'address_'.$htmlkey.'_'.$this->id, $this->element, $this->id, 1, ', '); $outdone++;

+            $outdone++;

         }

-        if ($error)

+

+        if (! in_array($this->country_code,$countriesusingstate) && empty($conf->global->MAIN_FORCE_STATE_INTO_ADDRESS)   // If MAIN_FORCE_STATE_INTO_ADDRESS is on, state is already returned previously with getFullAddress

+                && empty($conf->global->SOCIETE_DISABLE_STATE) && $this->state)

         {

-            $this->db->rollback();

-            return -1;

+            if (!empty($conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT) && $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT == 1 && $this->region) {

+                $out.=($outdone?' - ':'').$this->region.' - '.$this->state;

+            }

+            else {

+                $out.=($outdone?' - ':'').$this->state;

+            }

+            $outdone++;

         }

-        else

+

+        if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) $out.=($outdone?'<br>':'');

+        if (! empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone

+            $out.=dol_print_phone($this->phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

+        }

+        if (! empty($this->phone_pro)) {

+            $out.=dol_print_phone($this->phone_pro,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

+        }

+        if (! empty($this->phone_mobile)) {

+            $out.=dol_print_phone($this->phone_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;

+        }

+        if (! empty($this->phone_perso)) {

+            $out.=dol_print_phone($this->phone_perso,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePerso")); $outdone++;

+        }

+        if (! empty($this->office_phone)) {

+            $out.=dol_print_phone($this->office_phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

+        }

+        if (! empty($this->user_mobile)) {

+            $out.=dol_print_phone($this->user_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;

+        }

+        if (! empty($this->fax)) {

+            $out.=dol_print_phone($this->fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;

+        }

+        if (! empty($this->office_fax)) {

+            $out.=dol_print_phone($this->office_fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;

+        }

+

+        $out.='<div style="clear: both;"></div>';

+        $outdone=0;

+        if (! empty($this->email))

         {

-            $this->fk_account = ($fk_account=='NULL')?null:$fk_account;

-            $this->db->commit();

-            return 1;

+            $out.=dol_print_email($this->email,$this->id,$object->id,'AC_EMAIL',0,0,1);

+            $outdone++;

+        }

+        if (! empty($this->url))

+        {

+            $out.=dol_print_url($this->url,'_goout',0,1);

+            $outdone++;

+        }

+        $out.='<div style="clear: both;">';

+        if (! empty($conf->socialnetworks->enabled))

+        {

+            if ($this->skype) $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');

+            $outdone++;

+            if ($this->jabberid) $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');

+            $outdone++;

+            if ($this->twitter) $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');

+            $outdone++;

+            if ($this->facebook) $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');

+            $outdone++;

         }

+        $out.='</div>';

+

+        $out.='<!-- END Part to show address block -->';

+

+        return $out;

     }

 

+    /**

+     * Return the link of last main doc file for direct public download.

+     *

+     * @param	string	$modulepart			Module related to document

+     * @param	int		$initsharekey		Init the share key if it was not yet defined

+     * @param	int		$relativelink		0=Return full external link, 1=Return link relative to root of file

+     * @return	string						Link or empty string if there is no download link

+     */

+    function getLastMainDocLink($modulepart, $initsharekey=0, $relativelink=0)

+    {

+        global $user, $dolibarr_main_url_root;

 

-	// TODO: Move line related operations to CommonObjectLine?

+        if (empty($this->last_main_doc))

+        {

+            return '';		// No way to known which document name to use

+        }

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *  Save a new position (field rang) for details lines.

-	 *  You can choose to set position for lines with already a position or lines without any position defined.

-	 *

-	 * 	@param		boolean		$renum			   True to renum all already ordered lines, false to renum only not already ordered lines.

-	 * 	@param		string		$rowidorder		   ASC or DESC

-	 * 	@param		boolean		$fk_parent_line    Table with fk_parent_line field or not

-	 * 	@return		int                            <0 if KO, >0 if OK

-	 */

-	function line_order($renum=false, $rowidorder='ASC', $fk_parent_line=true)

-	{

-        // phpcs:enable

-		if (! $this->table_element_line)

-		{

-			dol_syslog(get_class($this)."::line_order was called on objet with property table_element_line not defined",LOG_ERR);

-			return -1;

-		}

-		if (! $this->fk_element)

-		{

-			dol_syslog(get_class($this)."::line_order was called on objet with property fk_element not defined",LOG_ERR);

-			return -1;

-		}

-

-		// Count number of lines to reorder (according to choice $renum)

-		$nl=0;

-		$sql = 'SELECT count(rowid) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.'='.$this->id;

-		if (! $renum) $sql.= ' AND rang = 0';

-		if ($renum) $sql.= ' AND rang <> 0';

-

-		dol_syslog(get_class($this)."::line_order", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$row = $this->db->fetch_row($resql);

-			$nl = $row[0];

-		}

-		else dol_print_error($this->db);

-		if ($nl > 0)

-		{

-			// The goal of this part is to reorder all lines, with all children lines sharing the same

-			// counter that parents.

-			$rows=array();

-

-			// We first search all lines that are parent lines (for multilevel details lines)

-			$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			if ($fk_parent_line) $sql.= ' AND fk_parent_line IS NULL';

-			$sql.= ' ORDER BY rang ASC, rowid '.$rowidorder;

-

-			dol_syslog(get_class($this)."::line_order search all parent lines", LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if ($resql)

-			{

-				$i=0;

-				$num = $this->db->num_rows($resql);

-				while ($i < $num)

-				{

-					$row = $this->db->fetch_row($resql);

-					$rows[] = $row[0];	// Add parent line into array rows

-					$childrens = $this->getChildrenOfLine($row[0]);

-					if (! empty($childrens))

-					{

-						foreach($childrens as $child)

-						{

-							array_push($rows, $child);

-						}

-					}

-					$i++;

-				}

+        include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';

+        $ecmfile=new EcmFiles($this->db);

+        $result = $ecmfile->fetch(0, '', $this->last_main_doc);

+        if ($result < 0)

+        {

+            $this->error = $ecmfile->error;

+            $this->errors = $ecmfile->errors;

+            return -1;

+        }

 

-				// Now we set a new number for each lines (parent and children with children included into parent tree)

-				if (! empty($rows))

+        if (empty($ecmfile->id))

+        {

+            // Add entry into index

+            if ($initsharekey)

+            {

+                require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

+                // TODO We can't, we dont' have full path of file, only last_main_doc adn ->element, so we must rebuild full path first

+                /*

+				$ecmfile->filepath = $rel_dir;

+				$ecmfile->filename = $filename;

+				$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

+				$ecmfile->fullpath_orig = '';

+				$ecmfile->gen_or_uploaded = 'generated';

+				$ecmfile->description = '';    // indexed content

+				$ecmfile->keyword = '';        // keyword content

+				$ecmfile->share = getRandomPassword(true);

+				$result = $ecmfile->create($user);

+				if ($result < 0)

 				{

-					foreach($rows as $key => $row)

-					{

-						$this->updateRangOfLine($row, ($key+1));

-					}

+					$this->error = $ecmfile->error;

+					$this->errors = $ecmfile->errors;

 				}

-			}

-			else

-			{

-				dol_print_error($this->db);

-			}

-		}

-		return 1;

-	}

-

-	/**

-	 * 	Get children of line

-	 *

-	 * 	@param	int		$id		Id of parent line

-	 * 	@return	array			Array with list of children lines id

-	 */

-	function getChildrenOfLine($id)

-	{

-		$rows=array();

-

-		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-		$sql.= ' AND fk_parent_line = '.$id;

-		$sql.= ' ORDER BY rang ASC';

-

-		dol_syslog(get_class($this)."::getChildrenOfLine search children lines for line ".$id."", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$i=0;

-			$num = $this->db->num_rows($resql);

-			while ($i < $num)

-			{

-				$row = $this->db->fetch_row($resql);

-				$rows[$i] = $row[0];

-				$i++;

-			}

-		}

+				*/

+            }

+            else return '';

+        }

+        elseif (empty($ecmfile->share))

+        {

+            // Add entry into index

+            if ($initsharekey)

+            {

+                require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

+                $ecmfile->share = getRandomPassword(true);

+                $ecmfile->update($user);

+            }

+            else return '';

+        }

 

-		return $rows;

-	}

+        // Define $urlwithroot

+        $urlwithouturlroot=preg_replace('/'.preg_quote(DOL_URL_ROOT,'/').'$/i','',trim($dolibarr_main_url_root));

+        $urlwithroot=$urlwithouturlroot.DOL_URL_ROOT;		// This is to use external domain name found into config file

+        //$urlwithroot=DOL_MAIN_URL_ROOT;					// This is to use same domain name than current

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 * 	Update a line to have a lower rank

-	 *

-	 * 	@param 	int			$rowid				Id of line

-	 * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not

-	 * 	@return	void

-	 */

-	function line_up($rowid, $fk_parent_line=true)

-	{

-        // phpcs:enable

-		$this->line_order(false, 'ASC', $fk_parent_line);

+        $forcedownload=0;

 

-		// Get rang of line

-		$rang = $this->getRangOfLine($rowid);

+        $paramlink='';

+        //if (! empty($modulepart)) $paramlink.=($paramlink?'&':'').'modulepart='.$modulepart;		// For sharing with hash (so public files), modulepart is not required.

+        //if (! empty($ecmfile->entity)) $paramlink.='&entity='.$ecmfile->entity; 					// For sharing with hash (so public files), entity is not required.

+        //$paramlink.=($paramlink?'&':'').'file='.urlencode($filepath);								// No need of name of file for public link, we will use the hash

+        if (! empty($ecmfile->share)) $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;			// Hash for public share

+        if ($forcedownload) $paramlink.=($paramlink?'&':'').'attachment=1';

 

-		// Update position of line

-		$this->updateLineUp($rowid, $rang);

-	}

+        if ($relativelink)

+        {

+            $linktoreturn='document.php'.($paramlink?'?'.$paramlink:'');

+        }

+        else

+        {

+            $linktoreturn=$urlwithroot.'/document.php'.($paramlink?'?'.$paramlink:'');

+        }

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 * 	Update a line to have a higher rank

-	 *

-	 * 	@param	int			$rowid				Id of line

-	 * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not

-	 * 	@return	void

-	 */

-	function line_down($rowid, $fk_parent_line=true)

-	{

-        // phpcs:enable

-		$this->line_order(false, 'ASC', $fk_parent_line);

-

-		// Get rang of line

-		$rang = $this->getRangOfLine($rowid);

-

-		// Get max value for rang

-		$max = $this->line_max();

-

-		// Update position of line

-		$this->updateLineDown($rowid, $rang, $max);

-	}

-

-	/**

-	 * 	Update position of line (rang)

-	 *

-	 * 	@param	int		$rowid		Id of line

-	 * 	@param	int		$rang		Position

-	 * 	@return	void

-	 */

-	function updateRangOfLine($rowid,$rang)

-	{

-		$fieldposition = 'rang';

-		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

-

-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

-		$sql.= ' WHERE rowid = '.$rowid;

-

-		dol_syslog(get_class($this)."::updateRangOfLine", LOG_DEBUG);

-		if (! $this->db->query($sql))

-		{

-			dol_print_error($this->db);

-		}

-	}

+        // Here $ecmfile->share is defined

+        return $linktoreturn;

+    }

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 * 	Update position of line with ajax (rang)

-	 *

-	 * 	@param	array	$rows	Array of rows

-	 * 	@return	void

-	 */

-	function line_ajaxorder($rows)

-	{

-        // phpcs:enable

-		$num = count($rows);

-		for ($i = 0 ; $i < $num ; $i++)

-		{

-			$this->updateRangOfLine($rows[$i], ($i+1));

-		}

-	}

-

-	/**

-	 * 	Update position of line up (rang)

-	 *

-	 * 	@param	int		$rowid		Id of line

-	 * 	@param	int		$rang		Position

-	 * 	@return	void

-	 */

-	function updateLineUp($rowid,$rang)

-	{

-		if ($rang > 1)

-		{

-			$fieldposition = 'rang';

-			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

-

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang ;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			$sql.= ' AND rang = '.($rang - 1);

-			if ($this->db->query($sql) )

-			{

-				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang - 1);

-				$sql.= ' WHERE rowid = '.$rowid;

-				if (! $this->db->query($sql) )

-				{

-					dol_print_error($this->db);

-				}

-			}

-			else

-			{

-				dol_print_error($this->db);

-			}

-		}

-	}

-

-	/**

-	 * 	Update position of line down (rang)

-	 *

-	 * 	@param	int		$rowid		Id of line

-	 * 	@param	int		$rang		Position

-	 * 	@param	int		$max		Max

-	 * 	@return	void

-	 */

-	function updateLineDown($rowid,$rang,$max)

-	{

-		if ($rang < $max)

-		{

-			$fieldposition = 'rang';

-			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

-

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			$sql.= ' AND rang = '.($rang+1);

-			if ($this->db->query($sql) )

-			{

-				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang+1);

-				$sql.= ' WHERE rowid = '.$rowid;

-				if (! $this->db->query($sql) )

-				{

-					dol_print_error($this->db);

-				}

-			}

-			else

-			{

-				dol_print_error($this->db);

-			}

-		}

-	}

-

-	/**

-	 * 	Get position of line (rang)

-	 *

-	 * 	@param		int		$rowid		Id of line

-	 *  @return		int     			Value of rang in table of lines

-	 */

-	function getRangOfLine($rowid)

-	{

-		$sql = 'SELECT rang FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE rowid ='.$rowid;

-

-		dol_syslog(get_class($this)."::getRangOfLine", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$row = $this->db->fetch_row($resql);

-			return $row[0];

-		}

-	}

-

-	/**

-	 * 	Get rowid of the line relative to its position

-	 *

-	 * 	@param		int		$rang		Rang value

-	 *  @return     int     			Rowid of the line

-	 */

-	function getIdOfLine($rang)

-	{

-		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-		$sql.= ' AND rang = '.$rang;

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$row = $this->db->fetch_row($resql);

-			return $row[0];

-		}

-	}

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 * 	Get max value used for position of line (rang)

-	 *

-	 * 	@param		int		$fk_parent_line		Parent line id

-	 *  @return     int  			   			Max value of rang in table of lines

-	 */

-	function line_max($fk_parent_line=0)

-	{

+    /**

+     *  Add a link between element $this->element and a contact

+     *

+     *  @param	int		$fk_socpeople       Id of thirdparty contact (if source = 'external') or id of user (if souce = 'internal') to link

+     *  @param 	int		$type_contact 		Type of contact (code or id). Must be id or code found into table llx_c_type_contact. For example: SALESREPFOLL

+     *  @param  string	$source             external=Contact extern (llx_socpeople), internal=Contact intern (llx_user)

+     *  @param  int		$notrigger			Disable all triggers

+     *  @return int                 		<0 if KO, >0 if OK

+     */

+    function add_contact($fk_socpeople, $type_contact, $source='external',$notrigger=0)

+    {

         // phpcs:enable

-		// Search the last rang with fk_parent_line

-		if ($fk_parent_line)

-		{

-			$sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			$sql.= ' AND fk_parent_line = '.$fk_parent_line;

-

-			dol_syslog(get_class($this)."::line_max", LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if ($resql)

-			{

-				$row = $this->db->fetch_row($resql);

-				if (! empty($row[0]))

-				{

-					return $row[0];

-				}

-				else

-				{

-					return $this->getRangOfLine($fk_parent_line);

-				}

-			}

-		}

-		// If not, search the last rang of element

-		else

-		{

-			$sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-

-			dol_syslog(get_class($this)."::line_max", LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if ($resql)

-			{

-				$row = $this->db->fetch_row($resql);

-				return $row[0];

-			}

-		}

-	}

+        global $user,$langs;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *  Update external ref of element

-	 *

-	 *  @param      string		$ref_ext	Update field ref_ext

-	 *  @return     int      		   		<0 if KO, >0 if OK

-	 */

-	function update_ref_ext($ref_ext)

-	{

-        // phpcs:enable

-		if (! $this->table_element)

-		{

-			dol_syslog(get_class($this)."::update_ref_ext was called on objet with property table_element not defined", LOG_ERR);

-			return -1;

-		}

-

-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET ref_ext = '".$this->db->escape($ref_ext)."'";

-		$sql.= " WHERE ".(isset($this->table_rowid)?$this->table_rowid:'rowid')." = ". $this->id;

-

-		dol_syslog(get_class($this)."::update_ref_ext", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			$this->ref_ext = $ref_ext;

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->error();

-			return -1;

-		}

-	}

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *  Update note of element

-	 *

-	 *  @param      string		$note		New value for note

-	 *  @param		string		$suffix		'', '_public' or '_private'

-	 *  @return     int      		   		<0 if KO, >0 if OK

-	 */

-	function update_note($note, $suffix='')

-	{

-        // phpcs:enable

-		global $user;

-

-		if (! $this->table_element)

-		{

-			$this->error='update_note was called on objet with property table_element not defined';

-			dol_syslog(get_class($this)."::update_note was called on objet with property table_element not defined", LOG_ERR);

-			return -1;

-		}

-		if (! in_array($suffix,array('','_public','_private')))

-		{

-			$this->error='update_note Parameter suffix must be empty, \'_private\' or \'_public\'';

-			dol_syslog(get_class($this)."::update_note Parameter suffix must be empty, '_private' or '_public'", LOG_ERR);

-			return -2;

-		}

-		// Special cas

-		//var_dump($this->table_element);exit;

-		if ($this->table_element == 'product') $suffix='';

-

-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET note".$suffix." = ".(!empty($note)?("'".$this->db->escape($note)."'"):"NULL");

-		$sql.= " ,".(in_array($this->table_element, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))?"fk_user_mod":"fk_user_modif")." = ".$user->id;

-		$sql.= " WHERE rowid =". $this->id;

-

-		dol_syslog(get_class($this)."::update_note", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			if ($suffix == '_public') $this->note_public = $note;

-			else if ($suffix == '_private') $this->note_private = $note;

-			else

-			{

-				$this->note = $note;      // deprecated

-				$this->note_private = $note;

-			}

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			return -1;

-		}

-	}

+        dol_syslog(get_class($this)."::add_contact $fk_socpeople, $type_contact, $source, $notrigger");

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 * 	Update public note (kept for backward compatibility)

-	 *

-	 * @param      string		$note		New value for note

-	 * @return     int      		   		<0 if KO, >0 if OK

-	 * @deprecated

-	 * @see update_note()

-	 */

-	function update_note_public($note)

-	{

-        // phpcs:enable

-		return $this->update_note($note,'_public');

-	}

+        // Check parameters

+        if ($fk_socpeople <= 0)

+        {

+            $langs->load("errors");

+            $this->error=$langs->trans("ErrorWrongValueForParameterX","1");

+            dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);

+            return -1;

+        }

+        if (! $type_contact)

+        {

+            $langs->load("errors");

+            $this->error=$langs->trans("ErrorWrongValueForParameterX","2");

+            dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);

+            return -2;

+        }

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *	Update total_ht, total_ttc, total_vat, total_localtax1, total_localtax2 for an object (sum of lines).

-	 *  Must be called at end of methods addline or updateline.

-	 *

-	 *	@param	int		$exclspec          	>0 = Exclude special product (product_type=9)

-	 *  @param  string	$roundingadjust    	'none'=Do nothing, 'auto'=Use default method (MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND if defined, or '0'), '0'=Force mode total of rounding, '1'=Force mode rounding of total

-	 *  @param	int		$nodatabaseupdate	1=Do not update database. Update only properties of object.

-	 *  @param	Societe	$seller				If roundingadjust is '0' or '1' or maybe 'auto', it means we recalculate total for lines before calculating total for object and for this, we need seller object.

-	 *	@return	int    			           	<0 if KO, >0 if OK

-	 */

-	function update_price($exclspec=0,$roundingadjust='none',$nodatabaseupdate=0,$seller=null)

-	{

-        // phpcs:enable

-		global $conf, $hookmanager, $action;

-

-		// Some external module want no update price after a trigger because they have another method to calculate the total (ex: with an extrafield)

-		$MODULE = "";

-		if ($this->element == 'propal')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_PROPOSAL";

-		elseif ($this->element == 'order')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_ORDER";

-		elseif ($this->element == 'facture')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_INVOICE";

-		elseif ($this->element == 'facture_fourn')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_INVOICE";

-		elseif ($this->element == 'order_supplier')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_ORDER";

-		elseif ($this->element == 'supplier_proposal')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";

-

-		if (! empty($MODULE)) {

-			if (! empty($conf->global->$MODULE)) {

-				$modsactivated = explode(',', $conf->global->$MODULE);

-				foreach ($modsactivated as $mod) {

-					if ($conf->$mod->enabled)

-						return 1; // update was disabled by specific setup

-				}

-			}

-		}

-

-		include_once DOL_DOCUMENT_ROOT.'/core/lib/price.lib.php';

-

-		if ($roundingadjust == '-1') $roundingadjust='auto';	// For backward compatibility

-

-		$forcedroundingmode=$roundingadjust;

-		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode=$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;

-		elseif ($forcedroundingmode == 'auto') $forcedroundingmode='0';

-

-		$error=0;

-

-		$multicurrency_tx = !empty($this->multicurrency_tx) ? $this->multicurrency_tx : 1;

-

-		// Define constants to find lines to sum

-		$fieldtva='total_tva';

-		$fieldlocaltax1='total_localtax1';

-		$fieldlocaltax2='total_localtax2';

-		$fieldup='subprice';

-		if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier')

-		{

-			$fieldtva='tva';

-			$fieldup='pu_ht';

-		}

-		if ($this->element == 'expensereport')

-		{

-			$fieldup='value_unit';

-		}

-

-		$sql = 'SELECT rowid, qty, '.$fieldup.' as up, remise_percent, total_ht, '.$fieldtva.' as total_tva, total_ttc, '.$fieldlocaltax1.' as total_localtax1, '.$fieldlocaltax2.' as total_localtax2,';

-		$sql.= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';

-			if ($this->table_element_line == 'facturedet') $sql.= ', situation_percent';

-			$sql.= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';

-		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-		if ($exclspec)

-		{

-			$product_field='product_type';

-			if ($this->table_element_line == 'contratdet') $product_field='';    // contratdet table has no product_type field

-			if ($product_field) $sql.= ' AND '.$product_field.' <> 9';

-		}

-		$sql.= ' ORDER by rowid';	// We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used

-

-		dol_syslog(get_class($this)."::update_price", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$this->total_ht  = 0;

-			$this->total_tva = 0;

-			$this->total_localtax1 = 0;

-			$this->total_localtax2 = 0;

-			$this->total_ttc = 0;

-			$total_ht_by_vats  = array();

-			$total_tva_by_vats = array();

-			$total_ttc_by_vats = array();

-			$this->multicurrency_total_ht	= 0;

-			$this->multicurrency_total_tva	= 0;

-			$this->multicurrency_total_ttc	= 0;

-

-			$num = $this->db->num_rows($resql);

-			$i = 0;

-			while ($i < $num)

-			{

-				$obj = $this->db->fetch_object($resql);

+        $id_type_contact=0;

+        if (is_numeric($type_contact))

+        {

+            $id_type_contact=$type_contact;

+        }

+        else

+        {

+            // We look for id type_contact

+            $sql = "SELECT tc.rowid";

+            $sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

+            $sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

+            $sql.= " AND tc.source='".$this->db->escape($source)."'";

+            $sql.= " AND tc.code='".$this->db->escape($type_contact)."' AND tc.active=1";

+            //print $sql;

+            $resql=$this->db->query($sql);

+            if ($resql)

+            {

+                $obj = $this->db->fetch_object($resql);

+                if ($obj) $id_type_contact=$obj->rowid;

+            }

+        }

 

-				// Note: There is no check on detail line and no check on total, if $forcedroundingmode = 'none'

-				$parameters=array('fk_element' => $obj->rowid);

-				$reshook = $hookmanager->executeHooks('changeRoundingMode', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

+        if ($id_type_contact == 0)

+        {

+            $this->error='CODE_NOT_VALID_FOR_THIS_ELEMENT';

+            dol_syslog("CODE_NOT_VALID_FOR_THIS_ELEMENT: Code type of contact '".$type_contact."' does not exists or is not active for element ".$this->element.", we can ignore it");

+            return -3;

+        }

 

-				if (empty($reshook) && $forcedroundingmode == '0')	// Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

-				{

-					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);

-					$tmpcal=calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);

-					$diff=price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);

-					if ($diff)

-					{

-						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;

-						dol_syslog('We found unconsistent data into detailed line (difference of '.$diff.') for line rowid = '.$obj->rowid." (total vat of line calculated=".$tmpcal[1].", database=".$obj->total_tva."). We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

-								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

-								$obj->total_tva = $tmpcal[1];

-								$obj->total_ttc = $tmpcal[2];

-						//

-					}

-				}

+        $datecreate = dol_now();

+

+        // Socpeople must have already been added by some trigger, then we have to check it to avoid DB_ERROR_RECORD_ALREADY_EXISTS error

+        $TListeContacts=$this->liste_contact(-1, $source);

+        $already_added=false;

+        if(!empty($TListeContacts)) {

+            foreach($TListeContacts as $array_contact) {

+                if($array_contact['status'] == 4 && $array_contact['id'] == $fk_socpeople && $array_contact['fk_c_type_contact'] == $id_type_contact) {

+                    $already_added=true;

+                    break;

+                }

+            }

+        }

 

-				$this->total_ht        += $obj->total_ht;		// The field visible at end of line detail

-				$this->total_tva       += $obj->total_tva;

-				$this->total_localtax1 += $obj->total_localtax1;

-				$this->total_localtax2 += $obj->total_localtax2;

-				$this->total_ttc       += $obj->total_ttc;

-				$this->multicurrency_total_ht        += $obj->multicurrency_total_ht;		// The field visible at end of line detail

-				$this->multicurrency_total_tva       += $obj->multicurrency_total_tva;

-				$this->multicurrency_total_ttc       += $obj->multicurrency_total_ttc;

-

-				if (! isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate]=0;

-				if (! isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate]=0;

-				if (! isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate]=0;

-				$total_ht_by_vats[$obj->vatrate]  += $obj->total_ht;

-				$total_tva_by_vats[$obj->vatrate] += $obj->total_tva;

-				$total_ttc_by_vats[$obj->vatrate] += $obj->total_ttc;

-

-				if ($forcedroundingmode == '1')	// Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

-				{

-					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);

-					$diff=price2num($total_tva_by_vats[$obj->vatrate]-$tmpvat, 'MT', 1);

-					//print 'Line '.$i.' rowid='.$obj->rowid.' vat_rate='.$obj->vatrate.' total_ht='.$obj->total_ht.' total_tva='.$obj->total_tva.' total_ttc='.$obj->total_ttc.' total_ht_by_vats='.$total_ht_by_vats[$obj->vatrate].' total_tva_by_vats='.$total_tva_by_vats[$obj->vatrate].' (new calculation = '.$tmpvat.') total_ttc_by_vats='.$total_ttc_by_vats[$obj->vatrate].($diff?" => DIFF":"")."<br>\n";

-					if ($diff)

-					{

-						if (abs($diff) > 0.1) { dol_syslog('A rounding difference was detected into TOTAL but is too high to be corrected', LOG_WARNING); exit; }

-						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;

-						dol_syslog('We found a difference of '.$diff.' for line rowid = '.$obj->rowid.". We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

-								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

-								$this->total_tva -= $diff;

-								$this->total_ttc -= $diff;

-								$total_tva_by_vats[$obj->vatrate] -= $diff;

-								$total_ttc_by_vats[$obj->vatrate] -= $diff;

-					}

-				}

+        if(!$already_added) {

 

-				$i++;

-			}

+            $this->db->begin();

 

-			// Add revenue stamp to total

-			$this->total_ttc       			+= isset($this->revenuestamp)?$this->revenuestamp:0;

-			$this->multicurrency_total_ttc  += isset($this->revenuestamp)?($this->revenuestamp * $multicurrency_tx):0;

+            // Insert into database

+            $sql = "INSERT INTO ".MAIN_DB_PREFIX."element_contact";

+            $sql.= " (element_id, fk_socpeople, datecreate, statut, fk_c_type_contact) ";

+            $sql.= " VALUES (".$this->id.", ".$fk_socpeople." , " ;

+            $sql.= "'".$this->db->idate($datecreate)."'";

+            $sql.= ", 4, ". $id_type_contact;

+            $sql.= ")";

 

-			// Situations totals

-			if ($this->situation_cycle_ref && $this->situation_counter > 1 && method_exists($this, 'get_prev_sits') && $this->type != $this::TYPE_CREDIT_NOTE )

-			{

-				$prev_sits = $this->get_prev_sits();

-

-				foreach ($prev_sits as $sit) {				// $sit is an object Facture loaded with a fetch.

-					$this->total_ht -= $sit->total_ht;

-					$this->total_tva -= $sit->total_tva;

-					$this->total_localtax1 -= $sit->total_localtax1;

-					$this->total_localtax2 -= $sit->total_localtax2;

-					$this->total_ttc -= $sit->total_ttc;

-					$this->multicurrency_total_ht -= $sit->multicurrency_total_ht;

-					$this->multicurrency_total_tva -= $sit->multicurrency_total_tva;

-					$this->multicurrency_total_ttc -= $sit->multicurrency_total_ttc;

-				}

-			}

-

-			$this->db->free($resql);

-

-			// Now update global field total_ht, total_ttc and tva

-			$fieldht='total_ht';

-			$fieldtva='tva';

-			$fieldlocaltax1='localtax1';

-			$fieldlocaltax2='localtax2';

-			$fieldttc='total_ttc';

-			// Specific code for backward compatibility with old field names

-			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht='total';

-			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva='total_tva';

-			if ($this->element == 'propal')                                                $fieldttc='total';

-			if ($this->element == 'expensereport')                                         $fieldtva='total_tva';

-			if ($this->element == 'supplier_proposal')                                     $fieldttc='total';

-

-			if (empty($nodatabaseupdate))

-			{

-				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET';

-				$sql .= " ".$fieldht."='".price2num($this->total_ht)."',";

-				$sql .= " ".$fieldtva."='".price2num($this->total_tva)."',";

-				$sql .= " ".$fieldlocaltax1."='".price2num($this->total_localtax1)."',";

-				$sql .= " ".$fieldlocaltax2."='".price2num($this->total_localtax2)."',";

-				$sql .= " ".$fieldttc."='".price2num($this->total_ttc)."'";

-						$sql .= ", multicurrency_total_ht='".price2num($this->multicurrency_total_ht, 'MT', 1)."'";

-						$sql .= ", multicurrency_total_tva='".price2num($this->multicurrency_total_tva, 'MT', 1)."'";

-						$sql .= ", multicurrency_total_ttc='".price2num($this->multicurrency_total_ttc, 'MT', 1)."'";

-				$sql .= ' WHERE rowid = '.$this->id;

-

-

-				dol_syslog(get_class($this)."::update_price", LOG_DEBUG);

-				$resql=$this->db->query($sql);

-				if (! $resql)

-				{

-					$error++;

-					$this->error=$this->db->lasterror();

-					$this->errors[]=$this->db->lasterror();

-				}

-			}

+            $resql=$this->db->query($sql);

+            if ($resql)

+            {

+                if (! $notrigger)

+                {

+                    $result=$this->call_trigger(strtoupper($this->element).'_ADD_CONTACT', $user);

+                    if ($result < 0)

+                    {

+                        $this->db->rollback();

+                        return -1;

+                    }

+                }

+

+                $this->db->commit();

+                return 1;

+            }

+            else

+            {

+                if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')

+                {

+                    $this->error=$this->db->errno();

+                    $this->db->rollback();

+                    echo 'err rollback';

+                    return -2;

+                }

+                else

+                {

+                    $this->error=$this->db->error();

+                    $this->db->rollback();

+                    return -1;

+                }

+            }

+        } else return 0;

+    }

 

-			if (! $error)

-			{

-				return 1;

-			}

-			else

-			{

-				return -1;

-			}

-		}

-		else

-		{

-			dol_print_error($this->db,'Bad request in update_price');

-			return -1;

-		}

-	}

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *    Copy contact from one element to current

+     *

+     *    @param    CommonObject    $objFrom    Source element

+     *    @param    string          $source     Nature of contact ('internal' or 'external')

+     *    @return   int                         >0 if OK, <0 if KO

+     */

+    function copy_linked_contact($objFrom, $source='internal')

+    {

+        // phpcs:enable

+        $contacts = $objFrom->liste_contact(-1, $source);

+        foreach($contacts as $contact)

+        {

+            if ($this->add_contact($contact['id'], $contact['fk_c_type_contact'], $contact['source']) < 0)

+            {

+                $this->error=$this->db->lasterror();

+                return -1;

+            }

+        }

+        return 1;

+    }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *	Add objects linked in llx_element_element.

-	 *

-	 *	@param		string	$origin		Linked element type

-	 *	@param		int		$origin_id	Linked element id

-	 *	@return		int					<=0 if KO, >0 if OK

-	 *	@see		fetchObjectLinked, updateObjectLinked, deleteObjectLinked

-	 */

-	function add_object_linked($origin=null, $origin_id=null)

-	{

+    /**

+     *      Update a link to contact line

+     *

+     *      @param	int		$rowid              Id of line contact-element

+     * 		@param	int		$statut	            New status of link

+     *      @param  int		$type_contact_id    Id of contact type (not modified if 0)

+     *      @param  int		$fk_socpeople	    Id of soc_people to update (not modified if 0)

+     *      @return int                 		<0 if KO, >= 0 if OK

+     */

+    function update_contact($rowid, $statut, $type_contact_id=0, $fk_socpeople=0)

+    {

         // phpcs:enable

-		$origin = (! empty($origin) ? $origin : $this->origin);

-		$origin_id = (! empty($origin_id) ? $origin_id : $this->origin_id);

-

-		// Special case

-		if ($origin == 'order') $origin='commande';

-		if ($origin == 'invoice') $origin='facture';

-		if ($origin == 'invoice_template') $origin='facturerec';

-    	if ($origin == 'supplierorder') $origin='order_supplier';

-		$this->db->begin();

-

-		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";

-		$sql.= "fk_source";

-		$sql.= ", sourcetype";

-		$sql.= ", fk_target";

-		$sql.= ", targettype";

-		$sql.= ") VALUES (";

-		$sql.= $origin_id;

-		$sql.= ", '".$this->db->escape($origin)."'";

-		$sql.= ", ".$this->id;

-		$sql.= ", '".$this->db->escape($this->element)."'";

-		$sql.= ")";

-

-		dol_syslog(get_class($this)."::add_object_linked", LOG_DEBUG);

-		if ($this->db->query($sql))

-	  	{

-	  		$this->db->commit();

-	  		return 1;

-	  	}

-	  	else

-	  	{

-	  		$this->error=$this->db->lasterror();

-	  		$this->db->rollback();

-	  		return 0;

-	  	}

-	}

-

-	/**

-	 *	Fetch array of objects linked to current object (object of enabled modules only). Links are loaded into

-	 *		this->linkedObjectsIds array and

-	 *		this->linkedObjects array if $loadalsoobjects = 1

-	 *  Possible usage for parameters:

-	 *  - all parameters empty -> we look all link to current object (current object can be source or target)

-	 *  - source id+type -> will get target list linked to source

-	 *  - target id+type -> will get source list linked to target

-	 *  - source id+type + target type -> will get target list of the type

-	 *  - target id+type + target source -> will get source list of the type

-	 *

-	 *	@param	int		$sourceid			Object source id (if not defined, id of object)

-	 *	@param  string	$sourcetype			Object source type (if not defined, element name of object)

-	 *	@param  int		$targetid			Object target id (if not defined, id of object)

-	 *	@param  string	$targettype			Object target type (if not defined, elemennt name of object)

-	 *	@param  string	$clause				'OR' or 'AND' clause used when both source id and target id are provided

-	 *  @param  int		$alsosametype		0=Return only links to object that differs from source type. 1=Include also link to objects of same type.

-	 *  @param  string	$orderby			SQL 'ORDER BY' clause

-	 *  @param	int		$loadalsoobjects	Load also array this->linkedObjects (Use 0 to increase performances)

-	 *	@return int							<0 if KO, >0 if OK

-	 *  @see	add_object_linked, updateObjectLinked, deleteObjectLinked

-	 */

-	function fetchObjectLinked($sourceid=null,$sourcetype='',$targetid=null,$targettype='',$clause='OR',$alsosametype=1,$orderby='sourcetype',$loadalsoobjects=1)

-	{

-		global $conf;

-

-		$this->linkedObjectsIds=array();

-		$this->linkedObjects=array();

-

-		$justsource=false;

-		$justtarget=false;

-		$withtargettype=false;

-		$withsourcetype=false;

-

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid))

-		{

-			$justsource=true;  // the source (id and type) is a search criteria

-			if (! empty($targettype)) $withtargettype=true;

-		}

-		if (! empty($targetid) && ! empty($targettype) && empty($sourceid))

-		{

-			$justtarget=true;  // the target (id and type) is a search criteria

-			if (! empty($sourcetype)) $withsourcetype=true;

-		}

-

-		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

-		$targetid = (! empty($targetid) ? $targetid : $this->id);

-		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

-		$targettype = (! empty($targettype) ? $targettype : $this->element);

-

-		/*if (empty($sourceid) && empty($targetid))

-		 {

-		 dol_syslog('Bad usage of function. No source nor target id defined (nor as parameter nor as object id)', LOG_ERR);

-		 return -1;

-		 }*/

+        // Insert into database

+        $sql = "UPDATE ".MAIN_DB_PREFIX."element_contact set";

+        $sql.= " statut = ".$statut;

+        if ($type_contact_id) $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";

+        if ($fk_socpeople) $sql.= ", fk_socpeople = '".$fk_socpeople ."'";

+        $sql.= " where rowid = ".$rowid;

+        $resql=$this->db->query($sql);

+        if ($resql)

+        {

+            return 0;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            return -1;

+        }

+    }

 

-		// Links between objects are stored in table element_element

-		$sql = 'SELECT rowid, fk_source, sourcetype, fk_target, targettype';

-		$sql.= ' FROM '.MAIN_DB_PREFIX.'element_element';

-		$sql.= " WHERE ";

-		if ($justsource || $justtarget)

-		{

-			if ($justsource)

-			{

-				$sql.= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";

-				if ($withtargettype) $sql.= " AND targettype = '".$targettype."'";

-			}

-			else if ($justtarget)

-			{

-				$sql.= "fk_target = ".$targetid." AND targettype = '".$targettype."'";

-				if ($withsourcetype) $sql.= " AND sourcetype = '".$sourcetype."'";

-			}

-		}

-		else

-		{

-			$sql.= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";

-			$sql.= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";

-		}

-		$sql .= ' ORDER BY '.$orderby;

-

-		dol_syslog(get_class($this)."::fetchObjectLink", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$num = $this->db->num_rows($resql);

-			$i = 0;

-			while ($i < $num)

-			{

-				$obj = $this->db->fetch_object($resql);

-				if ($justsource || $justtarget)

-				{

-					if ($justsource)

-					{

-						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

-					}

-					else if ($justtarget)

-					{

-						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

-					}

-				}

-				else

-				{

-					if ($obj->fk_source == $sourceid && $obj->sourcetype == $sourcetype)

-					{

-						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

-					}

-					if ($obj->fk_target == $targetid && $obj->targettype == $targettype)

-					{

-						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

-					}

-				}

-				$i++;

-			}

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *    Delete a link to contact line

+     *

+     *    @param	int		$rowid			Id of contact link line to delete

+     *    @param	int		$notrigger		Disable all triggers

+     *    @return   int						>0 if OK, <0 if KO

+     */

+    function delete_contact($rowid, $notrigger=0)

+    {

+        // phpcs:enable

+        global $user;

 

-			if (! empty($this->linkedObjectsIds))

-			{

-				$tmparray = $this->linkedObjectsIds;

-				foreach($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

-				{

-					// Parse element/subelement (ex: project_task, cabinetmed_consultation, ...)

-					$module = $element = $subelement = $objecttype;

-					if ($objecttype != 'supplier_proposal' && $objecttype != 'order_supplier' && $objecttype != 'invoice_supplier'

-						&& preg_match('/^([^_]+)_([^_]+)/i',$objecttype,$regs))

-					{

-						$module = $element = $regs[1];

-						$subelement = $regs[2];

-					}

-

-					$classpath = $element.'/class';

-					// To work with non standard classpath or module name

-					if ($objecttype == 'facture')			{

-						$classpath = 'compta/facture/class';

-					}

-					else if ($objecttype == 'facturerec')			{

-						$classpath = 'compta/facture/class'; $module = 'facture';

-					}

-					else if ($objecttype == 'propal')			{

-						$classpath = 'comm/propal/class';

-					}

-					else if ($objecttype == 'supplier_proposal')			{

-						$classpath = 'supplier_proposal/class';

-					}

-					else if ($objecttype == 'shipping')			{

-						$classpath = 'expedition/class'; $subelement = 'expedition'; $module = 'expedition_bon';

-					}

-					else if ($objecttype == 'delivery')			{

-						$classpath = 'livraison/class'; $subelement = 'livraison'; $module = 'livraison_bon';

-					}

-					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

-						$classpath = 'fourn/class'; $module = 'fournisseur';

-					}

-					else if ($objecttype == 'fichinter')			{

-						$classpath = 'fichinter/class'; $subelement = 'fichinter'; $module = 'ficheinter';

-					}

-					else if ($objecttype == 'subscription')			{

-						$classpath = 'adherents/class'; $module = 'adherent';

-					}

-

-					// Set classfile

-					$classfile = strtolower($subelement); $classname = ucfirst($subelement);

-

-					if ($objecttype == 'order') {

-						$classfile = 'commande'; $classname = 'Commande';

-					}

-					else if ($objecttype == 'invoice_supplier') {

-						$classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';

-					}

-					else if ($objecttype == 'order_supplier')   {

-						$classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';

-					}

-					else if ($objecttype == 'supplier_proposal')   {

-						$classfile = 'supplier_proposal'; $classname = 'SupplierProposal';

-					}

-					else if ($objecttype == 'facturerec')   {

-						$classfile = 'facture-rec'; $classname = 'FactureRec';

-					}

-					else if ($objecttype == 'subscription')   {

-						$classfile = 'subscription'; $classname = 'Subscription';

-					}

-

-					// Here $module, $classfile and $classname are set

-					if ($conf->$module->enabled && (($element != $this->element) || $alsosametype))

-					{

-						if ($loadalsoobjects)

-						{

-							dol_include_once('/'.$classpath.'/'.$classfile.'.class.php');

-							//print '/'.$classpath.'/'.$classfile.'.class.php '.class_exists($classname);

-							if (class_exists($classname))

-							{

-								foreach($objectids as $i => $objectid)	// $i is rowid into llx_element_element

-								{

-									$object = new $classname($this->db);

-									$ret = $object->fetch($objectid);

-									if ($ret >= 0)

-									{

-										$this->linkedObjects[$objecttype][$i] = $object;

-									}

-								}

-							}

-						}

-					}

-					else

-					{

-						unset($this->linkedObjectsIds[$objecttype]);

-					}

-				}

-			}

-			return 1;

-		}

-		else

-		{

-			dol_print_error($this->db);

-			return -1;

-		}

-	}

-

-	/**

-	 *	Update object linked of a current object

-	 *

-	 *	@param	int		$sourceid		Object source id

-	 *	@param  string	$sourcetype		Object source type

-	 *	@param  int		$targetid		Object target id

-	 *	@param  string	$targettype		Object target type

-	 *	@return							int	>0 if OK, <0 if KO

-	 *	@see	add_object_linked, fetObjectLinked, deleteObjectLinked

-	 */

-	function updateObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='')

-	{

-		$updatesource=false;

-		$updatetarget=false;

-

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $updatetarget=true;

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX."element_element SET ";

-		if ($updatesource)

-		{

-			$sql.= "fk_source = ".$sourceid;

-			$sql.= ", sourcetype = '".$this->db->escape($sourcetype)."'";

-			$sql.= " WHERE fk_target = ".$this->id;

-			$sql.= " AND targettype = '".$this->db->escape($this->element)."'";

-		}

-		else if ($updatetarget)

-		{

-			$sql.= "fk_target = ".$targetid;

-			$sql.= ", targettype = '".$this->db->escape($targettype)."'";

-			$sql.= " WHERE fk_source = ".$this->id;

-			$sql.= " AND sourcetype = '".$this->db->escape($this->element)."'";

-		}

-

-		dol_syslog(get_class($this)."::updateObjectLinked", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			return -1;

-		}

-	}

-

-	/**

-	 *	Delete all links between an object $this

-	 *

-	 *	@param	int		$sourceid		Object source id

-	 *	@param  string	$sourcetype		Object source type

-	 *	@param  int		$targetid		Object target id

-	 *	@param  string	$targettype		Object target type

-	 *  @param	int		$rowid			Row id of line to delete. If defined, other parameters are not used.

-	 *	@return     					int	>0 if OK, <0 if KO

-	 *	@see	add_object_linked, updateObjectLinked, fetchObjectLinked

-	 */

-	function deleteObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='', $rowid='')

-	{

-		$deletesource=false;

-		$deletetarget=false;

-

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $deletetarget=true;

-

-		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

-		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

-		$targetid = (! empty($targetid) ? $targetid : $this->id);

-		$targettype = (! empty($targettype) ? $targettype : $this->element);

-

-		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_element";

-		$sql.= " WHERE";

-		if ($rowid > 0)

-		{

-			$sql.=" rowid = ".$rowid;

-		}

-		else

-		{

-			if ($deletesource)

-			{

-				$sql.= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";

-				$sql.= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";

-			}

-			else if ($deletetarget)

-			{

-				$sql.= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";

-				$sql.= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";

-			}

-			else

-			{

-				$sql.= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";

-				$sql.= " OR";

-				$sql.= " (fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."')";

-			}

-		}

-

-		dol_syslog(get_class($this)."::deleteObjectLinked", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			$this->errors[]=$this->error;

-			return -1;

-		}

-	}

-

-	/**

-	 *      Set status of an object

-	 *

-	 *      @param	int		$status			Status to set

-	 *      @param	int		$elementId		Id of element to force (use this->id by default)

-	 *      @param	string	$elementType	Type of element to force (use this->table_element by default)

-	 *      @param	string	$trigkey		Trigger key to use for trigger

-	 *      @return int						<0 if KO, >0 if OK

-	 */

-	function setStatut($status, $elementId=null, $elementType='', $trigkey='')

-	{

-		global $user,$langs,$conf;

-

-		$savElementId=$elementId;  // To be used later to know if we were using the method using the id of this or not.

-

-		$elementId = (!empty($elementId)?$elementId:$this->id);

-		$elementTable = (!empty($elementType)?$elementType:$this->table_element);

-

-		$this->db->begin();

-

-		$fieldstatus="fk_statut";

-		if ($elementTable == 'facture_rec') $fieldstatus="suspended";

-		if ($elementTable == 'mailing') $fieldstatus="statut";

-		if ($elementTable == 'cronjob') $fieldstatus="status";

-		if ($elementTable == 'user') $fieldstatus="statut";

-		if ($elementTable == 'expensereport') $fieldstatus="fk_statut";

-		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus="status";

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$elementTable;

-		$sql.= " SET ".$fieldstatus." = ".$status;

-		// If status = 1 = validated, update also fk_user_valid

-		if ($status == 1 && $elementTable == 'expensereport') $sql.=", fk_user_valid = ".$user->id;

-		$sql.= " WHERE rowid=".$elementId;

-

-		dol_syslog(get_class($this)."::setStatut", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			$error = 0;

-

-			// Try autoset of trigkey

-			if (empty($trigkey))

-			{

-				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey='SUPPLIER_PROPOSAL_SIGN';   // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey='SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey='SUPPLIER_PROPOSAL_CLOSE';  // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

-				if ($this->element == 'fichinter' && $status == 3) $trigkey='FICHINTER_CLASSIFY_DONE';

-				if ($this->element == 'fichinter' && $status == 2) $trigkey='FICHINTER_CLASSIFY_BILLED';

-				if ($this->element == 'fichinter' && $status == 1) $trigkey='FICHINTER_CLASSIFY_UNBILLED';

-			}

-

-			if ($trigkey)

-			{

-				// Appel des triggers

-				include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';

-				$interface=new Interfaces($this->db);

-				$result=$interface->run_triggers($trigkey,$this,$user,$langs,$conf);

-				if ($result < 0) {

-					$error++; $this->errors=$interface->errors;

-				}

-				// Fin appel triggers

-			}

 

-			if (! $error)

-			{

-				$this->db->commit();

+        $this->db->begin();

 

-				if (empty($savElementId))    // If the element we update was $this (so $elementId is null)

-				{

-					$this->statut = $status;

-					$this->status = $status;

-				}

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

+        $sql.= " WHERE rowid =".$rowid;

 

-				return 1;

-			}

-			else

-			{

-				$this->db->rollback();

-				dol_syslog(get_class($this)."::setStatus ".$this->error,LOG_ERR);

-				return -1;

-			}

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return -1;

-		}

-	}

-

-

-	/**

-	 *  Load type of canvas of an object if it exists

-	 *

-	 *  @param      int		$id     Record id

-	 *  @param      string	$ref    Record ref

-	 *  @return		int				<0 if KO, 0 if nothing done, >0 if OK

-	 */

-	function getCanvas($id=0,$ref='')

-	{

-		global $conf;

-

-		if (empty($id) && empty($ref)) return 0;

-		if (! empty($conf->global->MAIN_DISABLE_CANVAS)) return 0;    // To increase speed. Not enabled by default.

-

-		// Clean parameters

-		$ref = trim($ref);

-

-		$sql = "SELECT rowid, canvas";

-		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " WHERE entity IN (".getEntity($this->element).")";

-		if (! empty($id))  $sql.= " AND rowid = ".$id;

-		if (! empty($ref)) $sql.= " AND ref = '".$this->db->escape($ref)."'";

-

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$obj = $this->db->fetch_object($resql);

-			if ($obj)

-			{

-				$this->canvas   = $obj->canvas;

-				return 1;

-			}

-			else return 0;

-		}

-		else

-		{

-			dol_print_error($this->db);

-			return -1;

-		}

-	}

-

-

-	/**

-	 * 	Get special code of a line

-	 *

-	 * 	@param	int		$lineid		Id of line

-	 * 	@return	int					Special code

-	 */

-	function getSpecialCode($lineid)

-	{

-		$sql = 'SELECT special_code FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE rowid = '.$lineid;

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$row = $this->db->fetch_row($resql);

-			return $row[0];

-		}

-	}

-

-	/**

-	 *  Function to check if an object is used by others.

-	 *  Check is done into this->childtables. There is no check into llx_element_element.

-	 *

-	 *  @param	int		$id			Force id of object

-	 *  @return	int					<0 if KO, 0 if not used, >0 if already used

-	 */

-	function isObjectUsed($id=0)

-	{

-		global $langs;

-

-		if (empty($id)) $id=$this->id;

-

-		// Check parameters

-		if (! isset($this->childtables) || ! is_array($this->childtables) || count($this->childtables) == 0)

-		{

-			dol_print_error('Called isObjectUsed on a class with property this->childtables not defined');

-			return -1;

-		}

-

-		$arraytoscan = $this->childtables;

-		// For backward compatibility, we check if array is old format array('table1', 'table2', ...)

-		$tmparray=array_keys($this->childtables);

-		if (is_numeric($tmparray[0]))

-		{

-			$arraytoscan = array_flip($this->childtables);

-		}

-

-		// Test if child exists

-		$haschild=0;

-		foreach($arraytoscan as $table => $elementname)

-		{

-			//print $id.'-'.$table.'-'.$elementname.'<br>';

-			// Check if third party can be deleted

-			$sql = "SELECT COUNT(*) as nb from ".MAIN_DB_PREFIX.$table;

-			$sql.= " WHERE ".$this->fk_element." = ".$id;

-			$resql=$this->db->query($sql);

-			if ($resql)

-			{

-				$obj=$this->db->fetch_object($resql);

-				if ($obj->nb > 0)

-				{

-					$langs->load("errors");

-					//print 'Found into table '.$table.', type '.$langs->transnoentitiesnoconv($elementname).', haschild='.$haschild;

-					$haschild += $obj->nb;

-					if (is_numeric($elementname))	// old usage

-					{

-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);

-					}

-					else	// new usage: $elementname=Translation key

-					{

-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));

-					}

-					break;    // We found at least one, we stop here

-				}

-			}

-			else

-			{

-				$this->errors[]=$this->db->lasterror();

-				return -1;

-			}

-		}

-		if ($haschild > 0)

-		{

-			$this->errors[]="ErrorRecordHasChildren";

-			return $haschild;

-		}

-		else return 0;

-	}

-

-	/**

-	 *  Function to say how many lines object contains

-	 *

-	 *	@param	int		$predefined		-1=All, 0=Count free product/service only, 1=Count predefined product/service only, 2=Count predefined product, 3=Count predefined service

-	 *  @return	int						<0 if KO, 0 if no predefined products, nb of lines with predefined products if found

-	 */

-	function hasProductsOrServices($predefined=-1)

-	{

-		$nb=0;

-

-		foreach($this->lines as $key => $val)

-		{

-			$qualified=0;

-			if ($predefined == -1) $qualified=1;

-			if ($predefined == 1 && $val->fk_product > 0) $qualified=1;

-			if ($predefined == 0 && $val->fk_product <= 0) $qualified=1;

-			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) $qualified=1;

-			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) $qualified=1;

-			if ($qualified) $nb++;

-		}

-		dol_syslog(get_class($this).'::hasProductsOrServices we found '.$nb.' qualified lines of products/servcies');

-		return $nb;

-	}

-

-	/**

-	 * Function that returns the total amount HT of discounts applied for all lines.

-	 *

-	 * @return 	float

-	 */

-	function getTotalDiscount()

-	{

-		$total_discount=0.00;

-

-		$sql = "SELECT subprice as pu_ht, qty, remise_percent, total_ht";

-		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element."det";

-		$sql.= " WHERE ".$this->fk_element." = ".$this->id;

-

-		dol_syslog(get_class($this).'::getTotalDiscount', LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$num=$this->db->num_rows($resql);

-			$i=0;

-			while ($i < $num)

-			{

-				$obj = $this->db->fetch_object($resql);

-

-				$pu_ht = $obj->pu_ht;

-				$qty= $obj->qty;

-				$total_ht = $obj->total_ht;

-

-				$total_discount_line = floatval(price2num(($pu_ht * $qty) - $total_ht, 'MT'));

-				$total_discount += $total_discount_line;

-

-				$i++;

-			}

-		}

-

-		//print $total_discount; exit;

-		return price2num($total_discount);

-	}

-

-

-	/**

-	 * Return into unit=0, the calculated total of weight and volume of all lines * qty

-	 * Calculate by adding weight and volume of each product line, so properties ->volume/volume_units/weight/weight_units must be loaded on line.

-	 *

-	 * @return  array                           array('weight'=>...,'volume'=>...)

-	 */

-	function getTotalWeightVolume()

-	{

-		$totalWeight = 0;

-		$totalVolume = 0;

-		// defined for shipment only

-		$totalOrdered = '';

-		// defined for shipment only

-		$totalToShip = '';

-

-		foreach ($this->lines as $line)

-		{

-			if (isset($line->qty_asked))

-			{

-				if (empty($totalOrdered)) $totalOrdered=0;  // Avoid warning because $totalOrdered is ''

-				$totalOrdered+=$line->qty_asked;    // defined for shipment only

-			}

-			if (isset($line->qty_shipped))

-			{

-				if (empty($totalToShip)) $totalToShip=0;    // Avoid warning because $totalToShip is ''

-				$totalToShip+=$line->qty_shipped;   // defined for shipment only

-            }else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

+        dol_syslog(get_class($this)."::delete_contact", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            if (! $notrigger)

             {

-                if (empty($totalToShip)) $totalToShip=0;

-                $totalToShip+=$line->qty;   // defined for reception only

-			}

-

-			// Define qty, weight, volume, weight_units, volume_units

-			if ($this->element == 'shipping') {

-				// for shipments

-				$qty = $line->qty_shipped ? $line->qty_shipped : 0;

-			}

-			else {

-				$qty = $line->qty ? $line->qty : 0;

-			}

-

-			$weight = $line->weight ? $line->weight : 0;

-            ($weight==0 && !empty($line->product->weight))? $weight=$line->product->weight: 0;

-			$volume = $line->volume ? $line->volume : 0;

-			($volume==0 && !empty($line->product->volume))? $volume=$line->product->volume: 0;

+                $result=$this->call_trigger(strtoupper($this->element).'_DELETE_CONTACT', $user);

+                if ($result < 0) { $this->db->rollback(); return -1; }

+            }

 

-			$weight_units=$line->weight_units;

-			($weight_units==0 && !empty($line->product->weight_units))? $weight_units=$line->product->weight_units: 0;

-			$volume_units=$line->volume_units;

-			($volume_units==0 && !empty($line->product->volume_units))? $volume_units=$line->product->volume_units: 0;

+            $this->db->commit();

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return -1;

+        }

+    }

 

-			$weightUnit=0;

-			$volumeUnit=0;

-			if (! empty($weight_units)) $weightUnit = $weight_units;

-			if (! empty($volume_units)) $volumeUnit = $volume_units;

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *    Delete all links between an object $this and all its contacts

+     *

+     *	  @param	string	$source		'' or 'internal' or 'external'

+     *	  @param	string	$code		Type of contact (code or id)

+     *    @return   int					>0 if OK, <0 if KO

+     */

+    function delete_linked_contact($source='',$code='')

+    {

+        // phpcs:enable

+        $temp = array();

+        $typeContact = $this->liste_type_contact($source,'',0,0,$code);

 

-			if (empty($totalWeight)) $totalWeight=0;  // Avoid warning because $totalWeight is ''

-			if (empty($totalVolume)) $totalVolume=0;  // Avoid warning because $totalVolume is ''

+        foreach($typeContact as $key => $value)

+        {

+            array_push($temp,$key);

+        }

+        $listId = implode(",", $temp);

 

-			//var_dump($line->volume_units);

-			if ($weight_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

-			{

-				$trueWeightUnit=pow(10, $weightUnit);

-				$totalWeight += $weight * $qty * $trueWeightUnit;

-			}

-			else {

-		if ($weight_units == 99) {

-			// conversion 1 Pound = 0.45359237 KG

-			$trueWeightUnit = 0.45359237;

-			$totalWeight += $weight * $qty * $trueWeightUnit;

-		} elseif ($weight_units == 98) {

-			// conversion 1 Ounce = 0.0283495 KG

-			$trueWeightUnit = 0.0283495;

-			$totalWeight += $weight * $qty * $trueWeightUnit;

-		}

-		else

-					$totalWeight += $weight * $qty;   // This may be wrong if we mix different units

-			}

-			if ($volume_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

-			{

-				//print $line->volume."x".$line->volume_units."x".($line->volume_units < 50)."x".$volumeUnit;

-				$trueVolumeUnit=pow(10, $volumeUnit);

-				//print $line->volume;

-				$totalVolume += $volume * $qty * $trueVolumeUnit;

-			}

-			else

-			{

-				$totalVolume += $volume * $qty;   // This may be wrong if we mix different units

-			}

-		}

-

-		return array('weight'=>$totalWeight, 'volume'=>$totalVolume, 'ordered'=>$totalOrdered, 'toship'=>$totalToShip);

-	}

-

-

-	/**

-	 *	Set extra parameters

-	 *

-	 *	@return	int      <0 if KO, >0 if OK

-	 */

-	function setExtraParameters()

-	{

-		$this->db->begin();

-

-		$extraparams = (! empty($this->extraparams) ? json_encode($this->extraparams) : null);

-

-		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET extraparams = ".(! empty($extraparams) ? "'".$this->db->escape($extraparams)."'" : "null");

-		$sql.= " WHERE rowid = ".$this->id;

-

-		dol_syslog(get_class($this)."::setExtraParameters", LOG_DEBUG);

-		$resql = $this->db->query($sql);

-		if (! $resql)

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return -1;

-		}

-		else

-		{

-			$this->db->commit();

-			return 1;

-		}

-	}

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

+        $sql.= " WHERE element_id = ".$this->id;

+        if ($listId)

+            $sql.= " AND fk_c_type_contact IN (".$listId.")";

 

+        dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            return -1;

+        }

+    }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    Return incoterms informations

-	 *    TODO Use a cache for label get

-	 *

-	 *    @return	string	incoterms info

-	 */

-	function display_incoterms()

-	{

+    /**

+     *    Get array of all contacts for an object

+     *

+     *    @param	int			$statut		Status of links to get (-1=all)

+     *    @param	string		$source		Source of contact: external or thirdparty (llx_socpeople) or internal (llx_user)

+     *    @param	int         $list       0:Return array contains all properties, 1:Return array contains just id

+     *    @param    string      $code       Filter on this code of contact type ('SHIPPING', 'BILLING', ...)

+     *    @return	array|int		        Array of contacts, -1 if error

+     */

+    function liste_contact($statut=-1,$source='external',$list=0,$code='')

+    {

         // phpcs:enable

-		$out = '';

-		$this->libelle_incoterms = '';

-		if (!empty($this->fk_incoterms))

-		{

-			$sql = 'SELECT code FROM '.MAIN_DB_PREFIX.'c_incoterms WHERE rowid = '.(int) $this->fk_incoterms;

-			$result = $this->db->query($sql);

-			if ($result)

-			{

-				$res = $this->db->fetch_object($result);

-				$out .= $res->code;

-			}

-		}

-

-		$out .= (($res->code && $this->location_incoterms)?' - ':'').$this->location_incoterms;

-

-		return $out;

-	}

-

-	/**

-	 *    Return incoterms informations for pdf display

-	 *

-	 *    @return	string		incoterms info

-	 */

-	function getIncotermsForPDF()

-	{

-		$sql = 'SELECT code FROM '.MAIN_DB_PREFIX.'c_incoterms WHERE rowid = '.(int) $this->fk_incoterms;

-		$resql = $this->db->query($sql);

-		if ($resql)

-		{

-			$num = $this->db->num_rows($resql);

-			if ($num > 0)

-			{

-				$res = $this->db->fetch_object($resql);

-				return 'Incoterm : '.$res->code.' - '.$this->location_incoterms;

-			}

-			else

-			{

-				return '';

-			}

-		}

-		else

-		{

-			$this->errors[] = $this->db->lasterror();

-			return false;

-		}

-	}

-

-	/**

-	 *    Define incoterms values of current object

-	 *

-	 *    @param	int		$id_incoterm     Id of incoterm to set or '' to remove

-	 * 	  @param 	string  $location		 location of incoterm

-	 *    @return	int     		<0 if KO, >0 if OK

-	 */

-	function setIncoterms($id_incoterm, $location)

-	{

-		if ($this->id && $this->table_element)

-		{

-			$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-			$sql.= " SET fk_incoterms = ".($id_incoterm > 0 ? $id_incoterm : "null");

-			$sql.= ", location_incoterms = ".($id_incoterm > 0 ? "'".$this->db->escape($location)."'" : "null");

-			$sql.= " WHERE rowid = " . $this->id;

-			dol_syslog(get_class($this).'::setIncoterms', LOG_DEBUG);

-			$resql=$this->db->query($sql);

-			if ($resql)

-			{

-				$this->fk_incoterms = $id_incoterm;

-				$this->location_incoterms = $location;

-

-				$sql = 'SELECT libelle FROM '.MAIN_DB_PREFIX.'c_incoterms WHERE rowid = '.(int) $this->fk_incoterms;

-				$res = $this->db->query($sql);

-				if ($res)

-				{

-					$obj = $this->db->fetch_object($res);

-					$this->libelle_incoterms = $obj->libelle;

-				}

-				return 1;

-			}

-			else

-			{

-				$this->errors[] = $this->db->lasterror();

-				return -1;

-			}

-		}

-		else return -1;

-	}

-

-

-	// --------------------

-	// TODO: All functions here must be redesigned and moved as they are not business functions but output functions

-	// --------------------

-

-	/* This is to show add lines */

-

-	/**

-	 *	Show add free and predefined products/services form

-	 *

-	 *  @param	int		        $dateSelector       1=Show also date range input fields

-	 *  @param	Societe			$seller				Object thirdparty who sell

-	 *  @param	Societe			$buyer				Object thirdparty who buy

-	 *	@return	void

-	 */

-	function formAddObjectLine($dateSelector, $seller, $buyer)

-	{

-		global $conf,$user,$langs,$object,$hookmanager;

-		global $form,$bcnd,$var;

-

-		// Line extrafield

-		require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

-		$extrafieldsline = new ExtraFields($this->db);

-		$extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);

-

-		// Output template part (modules that overwrite templates must declare this into descriptor)

-		// Use global variables + $dateSelector + $seller and $buyer

-		$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-		foreach($dirtpls as $reldir)

-		{

-			$tpl = dol_buildpath($reldir.'/objectline_create.tpl.php');

-			if (empty($conf->file->strict_mode)) {

-				$res=@include $tpl;

-			} else {

-				$res=include $tpl; // for debug

-			}

-			if ($res) break;

-		}

-	}

-

-

-

-	/* This is to show array of line of details */

-

-

-	/**

-	 *	Return HTML table for object lines

-	 *	TODO Move this into an output class file (htmlline.class.php)

-	 *	If lines are into a template, title must also be into a template

-	 *	But for the moment we don't know if it's possible as we keep a method available on overloaded objects.

-	 *

-	 *	@param	string		$action				Action code

-	 *	@param  string		$seller            	Object of seller third party

-	 *	@param  string  	$buyer             	Object of buyer third party

-	 *	@param	int			$selected		   	Object line selected

-	 *	@param  int	    	$dateSelector      	1=Show also date range input fields

-	 *	@return	void

-	 */

-	function printObjectLines($action, $seller, $buyer, $selected=0, $dateSelector=0)

-	{

-		global $conf, $hookmanager, $langs, $user;

-		// TODO We should not use global var for this !

-		global $inputalsopricewithtax, $usemargins, $disableedit, $disablemove, $disableremove, $outputalsopricetotalwithtax;

-

-		// Define usemargins

-		$usemargins=0;

-		if (! empty($conf->margin->enabled) && ! empty($this->element) && in_array($this->element,array('facture','propal','commande'))) $usemargins=1;

-

-		$num = count($this->lines);

-

-		// Line extrafield

-		require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

-		$extrafieldsline = new ExtraFields($this->db);

-		$extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);

-

-		$parameters = array('num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

-		$reshook = $hookmanager->executeHooks('printObjectLineTitle', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

-		if (empty($reshook))

-		{

-			// Title line

-		    print "<thead>\n";

-

-			print '<tr class="liste_titre nodrag nodrop">';

-

-			// Adds a line numbering column

-			if (! empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';

-

-			// Description

-			print '<td class="linecoldescription">'.$langs->trans('Description').'</td>';

-

-			if ($this->element == 'supplier_proposal' || $this->element == 'order_supplier' || $this->element == 'invoice_supplier')

-			{

-				print '<td class="linerefsupplier"><span id="title_fourn_ref">'.$langs->trans("SupplierRef").'</span></td>';

-			}

-

-			// VAT

-			print '<td class="linecolvat" align="right" width="80">'.$langs->trans('VAT').'</td>';

+        global $langs;

+

+        $tab=array();

+

+        $sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact";    // This field contains id of llx_socpeople or id of llx_user

+        if ($source == 'internal') $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";

+        if ($source == 'external' || $source == 'thirdparty') $sql.=", t.fk_soc as socid, t.statut as statuscontact";

+        $sql.= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";

+        $sql.= ", tc.source, tc.element, tc.code, tc.libelle";

+        $sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";

+        $sql.= ", ".MAIN_DB_PREFIX."element_contact ec";

+        if ($source == 'internal') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";

+        if ($source == 'external'|| $source == 'thirdparty') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";

+        $sql.= " WHERE ec.element_id =".$this->id;

+        $sql.= " AND ec.fk_c_type_contact=tc.rowid";

+        $sql.= " AND tc.element='".$this->db->escape($this->element)."'";

+        if ($code) $sql.= " AND tc.code = '".$this->db->escape($code)."'";

+        if ($source == 'internal') $sql.= " AND tc.source = 'internal'";

+        if ($source == 'external' || $source == 'thirdparty') $sql.= " AND tc.source = 'external'";

+        $sql.= " AND tc.active=1";

+        if ($statut >= 0) $sql.= " AND ec.statut = '".$statut."'";

+        $sql.=" ORDER BY t.lastname ASC";

+

+        dol_syslog(get_class($this)."::liste_contact", LOG_DEBUG);

+        $resql=$this->db->query($sql);

+        if ($resql)

+        {

+            $num=$this->db->num_rows($resql);

+            $i=0;

+            while ($i < $num)

+            {

+                $obj = $this->db->fetch_object($resql);

+

+                if (! $list)

+                {

+                    $transkey="TypeContact_".$obj->element."_".$obj->source."_".$obj->code;

+                    $libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

+                    $tab[$i]=array('source'=>$obj->source,'socid'=>$obj->socid,'id'=>$obj->id,

+                                    'nom'=>$obj->lastname,      // For backward compatibility

+                                    'civility'=>$obj->civility, 'lastname'=>$obj->lastname, 'firstname'=>$obj->firstname, 'email'=>$obj->email, 'login'=>$obj->login, 'photo'=>$obj->photo, 'statuscontact'=>$obj->statuscontact,

+                                    'rowid'=>$obj->rowid, 'code'=>$obj->code, 'libelle'=>$libelle_type, 'status'=>$obj->statuslink, 'fk_c_type_contact'=>$obj->fk_c_type_contact);

+                }

+                else

+                {

+                    $tab[$i]=$obj->id;

+                }

+

+                $i++;

+            }

 

-			// Price HT

-			print '<td class="linecoluht" align="right" width="80">'.$langs->trans('PriceUHT').'</td>';

+            return $tab;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            dol_print_error($this->db);

+            return -1;

+        }

+    }

 

-			// Multicurrency

-			if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) print '<td class="linecoluht_currency" align="right" width="80">'.$langs->trans('PriceUHTCurrency', $this->multicurrency_code).'</td>';

 

-			if ($inputalsopricewithtax) print '<td align="right" width="80">'.$langs->trans('PriceUTTC').'</td>';

+    /**

+     * 		Update status of a contact linked to object

+     *

+     * 		@param	int		$rowid		Id of link between object and contact

+     * 		@return	int					<0 if KO, >=0 if OK

+     */

+    function swapContactStatus($rowid)

+    {

+        $sql = "SELECT ec.datecreate, ec.statut, ec.fk_socpeople, ec.fk_c_type_contact,";

+        $sql.= " tc.code, tc.libelle";

+        //$sql.= ", s.fk_soc";

+        $sql.= " FROM (".MAIN_DB_PREFIX."element_contact as ec, ".MAIN_DB_PREFIX."c_type_contact as tc)";

+        //$sql.= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople as s ON ec.fk_socpeople=s.rowid";	// Si contact de type external, alors il est lie a une societe

+        $sql.= " WHERE ec.rowid =".$rowid;

+        $sql.= " AND ec.fk_c_type_contact=tc.rowid";

+        $sql.= " AND tc.element = '".$this->db->escape($this->element)."'";

+

+        dol_syslog(get_class($this)."::swapContactStatus", LOG_DEBUG);

+        $resql=$this->db->query($sql);

+        if ($resql)

+        {

+            $obj = $this->db->fetch_object($resql);

+            $newstatut = ($obj->statut == 4) ? 5 : 4;

+            $result = $this->update_contact($rowid, $newstatut);

+            $this->db->free($resql);

+            return $result;

+        }

+        else

+        {

+            $this->error=$this->db->error();

+            dol_print_error($this->db);

+            return -1;

+        }

+    }

 

-			// Qty

-			print '<td class="linecolqty" align="right">'.$langs->trans('Qty').'</td>';

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *      Return array with list of possible values for type of contacts

+     *

+     *      @param	string	$source     'internal', 'external' or 'all'

+     *      @param	string	$order		Sort order by : 'position', 'code', 'rowid'...

+     *      @param  int		$option     0=Return array id->label, 1=Return array code->label

+     *      @param  int		$activeonly 0=all status of contact, 1=only the active

+     *		@param	string	$code		Type of contact (Example: 'CUSTOMER', 'SERVICE')

+     *      @return array       		Array list of type of contacts (id->label if option=0, code->label if option=1)

+     */

+    function liste_type_contact($source='internal', $order='position', $option=0, $activeonly=0, $code='')

+    {

+        // phpcs:enable

+        global $langs;

+

+        if (empty($order)) $order='position';

+        if ($order == 'position') $order.=',code';

+

+        $tab = array();

+        $sql = "SELECT DISTINCT tc.rowid, tc.code, tc.libelle, tc.position";

+        $sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

+        $sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

+        if ($activeonly == 1) $sql.= " AND tc.active=1"; // only the active types

+        if (! empty($source) && $source != 'all') $sql.= " AND tc.source='".$this->db->escape($source)."'";

+        if (! empty($code)) $sql.= " AND tc.code='".$this->db->escape($code)."'";

+        $sql.= $this->db->order($order,'ASC');

+

+        //print "sql=".$sql;

+        $resql=$this->db->query($sql);

+        if ($resql)

+        {

+            $num=$this->db->num_rows($resql);

+            $i=0;

+            while ($i < $num)

+            {

+                $obj = $this->db->fetch_object($resql);

 

-			if($conf->global->PRODUCT_USE_UNITS)

-			{

-				print '<td class="linecoluseunit" align="left">'.$langs->trans('Unit').'</td>';

-			}

+                $transkey="TypeContact_".$this->element."_".$source."_".$obj->code;

+                $libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

+                if (empty($option)) $tab[$obj->rowid]=$libelle_type;

+                else $tab[$obj->code]=$libelle_type;

+                $i++;

+            }

+            return $tab;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            //dol_print_error($this->db);

+            return null;

+        }

+    }

 

-			// Reduction short

-			print '<td class="linecoldiscount" align="right">'.$langs->trans('ReductionShort').'</td>';

+    /**

+     *      Return id of contacts for a source and a contact code.

+     *      Example: contact client de facturation ('external', 'BILLING')

+     *      Example: contact client de livraison ('external', 'SHIPPING')

+     *      Example: contact interne suivi paiement ('internal', 'SALESREPFOLL')

+     *

+     *		@param	string	$source		'external' or 'internal'

+     *		@param	string	$code		'BILLING', 'SHIPPING', 'SALESREPFOLL', ...

+     *		@param	int		$status		limited to a certain status

+     *      @return array       		List of id for such contacts

+     */

+    function getIdContact($source,$code,$status=0)

+    {

+        global $conf;

 

-			if ($this->situation_cycle_ref) {

-				print '<td class="linecolcycleref" align="right">' . $langs->trans('Progress') . '</td>';

-			}

+        $result=array();

+        $i=0;

+        //cas particulier pour les expeditions

+        if($this->element=='shipping' && $this->origin_id != 0) {

+            $id=$this->origin_id;

+            $element='commande';

+        } else if($this->element=='reception' && $this->origin_id != 0) {

+            $id=$this->origin_id;

+            $element='order_supplier';

+        } else {

+            $id=$this->id;

+            $element=$this->element;

+        }

 

-			if ($usemargins && ! empty($conf->margin->enabled) && empty($user->societe_id))

-			{

-				if (!empty($user->rights->margins->creer))

-				{

-					if ($conf->global->MARGIN_TYPE == "1")

-						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('BuyingPrice').'</td>';

-					else

-						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';

-				}

+        $sql = "SELECT ec.fk_socpeople";

+        $sql.= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";

+        if ($source == 'internal') $sql.= " ".MAIN_DB_PREFIX."user as c,";

+        if ($source == 'external') $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";

+        $sql.= " ".MAIN_DB_PREFIX."c_type_contact as tc";

+        $sql.= " WHERE ec.element_id = ".$id;

+        $sql.= " AND ec.fk_socpeople = c.rowid";

+        if ($source == 'internal') $sql.= " AND c.entity IN (".getEntity('user').")";

+        if ($source == 'external') $sql.= " AND c.entity IN (".getEntity('societe').")";

+        $sql.= " AND ec.fk_c_type_contact = tc.rowid";

+        $sql.= " AND tc.element = '".$element."'";

+        $sql.= " AND tc.source = '".$source."'";

+        $sql.= " AND tc.code = '".$code."'";

+        $sql.= " AND tc.active = 1";

+        if ($status) $sql.= " AND ec.statut = ".$status;

+

+        dol_syslog(get_class($this)."::getIdContact", LOG_DEBUG);

+        $resql=$this->db->query($sql);

+        if ($resql)

+        {

+            while ($obj = $this->db->fetch_object($resql))

+            {

+                $result[$i]=$obj->fk_socpeople;

+                $i++;

+            }

+        }

+        else

+        {

+            $this->error=$this->db->error();

+            return null;

+        }

 

-				if (! empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)

-					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';

-				if (! empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)

-					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';

-			}

+        return $result;

+    }

 

-			// Total HT

-			print '<td class="linecolht" align="right">'.$langs->trans('TotalHTShort').'</td>';

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *		Load object contact with id=$this->contactid into $this->contact

+     *

+     *		@param	int		$contactid      Id du contact. Use this->contactid if empty.

+     *		@return	int						<0 if KO, >0 if OK

+     */

+    function fetch_contact($contactid=null)

+    {

+        // phpcs:enable

+        if (empty($contactid)) $contactid=$this->contactid;

 

-			// Multicurrency

-			if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) print '<td class="linecoltotalht_currency" align="right">'.$langs->trans('TotalHTShortCurrency', $this->multicurrency_code).'</td>';

+        if (empty($contactid)) return 0;

 

-			if ($outputalsopricetotalwithtax) print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';

+        require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

+        $contact = new Contact($this->db);

+        $result=$contact->fetch($contactid);

+        $this->contact = $contact;

+        return $result;

+    }

 

-			print '<td class="linecoledit"></td>';  // No width to allow autodim

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *    	Load the third party of object, from id $this->socid or $this->fk_soc, into this->thirdparty

+     *

+     *		@param		int		$force_thirdparty_id	Force thirdparty id

+     *		@return		int								<0 if KO, >0 if OK

+     */

+    function fetch_thirdparty($force_thirdparty_id=0)

+    {

+        // phpcs:enable

+        global $conf;

 

-			print '<td class="linecoldelete" width="10"></td>';

+        if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id))

+            return 0;

 

-			print '<td class="linecolmove" width="10"></td>';

+        require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

 

-			if($action == 'selectlines')

-			{

-			    print '<td class="linecolcheckall" align="center">';

-			    print '<input type="checkbox" class="linecheckboxtoggle" />';

-			    print '<script type="text/javascript">$(document).ready(function() {$(".linecheckboxtoggle").click(function() {var checkBoxes = $(".linecheckbox");checkBoxes.prop("checked", this.checked);})});</script>';

-			    print '</td>';

-			}

-

-			print "</tr>\n";

-			print "</thead>\n";

-		}

-

-		$var = true;

-		$i	 = 0;

-

-		print "<tbody>\n";

-		foreach ($this->lines as $line)

-		{

-			//Line extrafield

-			$line->fetch_optionals();

-

-			//if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

-			if (is_object($hookmanager))   // Old code is commented on preceding line.

-			{

-				if (empty($line->fk_parent_line))

-				{

-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

-					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

-				}

-				else

-				{

-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);

-					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

-				}

-			}

-			if (empty($reshook))

-			{

-				$this->printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected,$extrafieldsline);

-			}

-

-			$i++;

-		}

-		print "</tbody>\n";

-	}

-

-	/**

-	 *	Return HTML content of a detail line

-	 *	TODO Move this into an output class file (htmlline.class.php)

-	 *

-	 *	@param	string		$action				GET/POST action

-	 *	@param CommonObjectLine $line		       	Selected object line to output

-	 *	@param  string	    $var               	Is it a an odd line (true)

-	 *	@param  int		    $num               	Number of line (0)

-	 *	@param  int		    $i					I

-	 *	@param  int		    $dateSelector      	1=Show also date range input fields

-	 *	@param  string	    $seller            	Object of seller third party

-	 *	@param  string	    $buyer             	Object of buyer third party

-	 *	@param	int			$selected		   	Object line selected

-	 *  @param  int			$extrafieldsline	Object of extrafield line attribute

-	 *	@return	void

-	 */

-	function printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected=0,$extrafieldsline=0)

-	{

-		global $conf,$langs,$user,$object,$hookmanager;

-		global $form,$bc,$bcdd;

-		global $object_rights, $disableedit, $disablemove, $disableremove;   // TODO We should not use global var for this !

-

-		$object_rights = $this->getRights();

-

-		$element=$this->element;

-

-		$text=''; $description=''; $type=0;

-

-		// Show product and description

-		$type=(! empty($line->product_type)?$line->product_type:$line->fk_product_type);

-		// Try to enhance type detection using date_start and date_end for free lines where type was not saved.

-		if (! empty($line->date_start)) $type=1; // deprecated

-		if (! empty($line->date_end)) $type=1; // deprecated

-

-		// Ligne en mode visu

-		if ($action != 'editline' || $selected != $line->id)

-		{

-			// Product

-			if ($line->fk_product > 0)

-			{

-				$product_static = new Product($this->db);

-				$product_static->fetch($line->fk_product);

+        $idtofetch = isset($this->socid) ? $this->socid : (isset($this->fk_soc) ? $this->fk_soc : $this->fk_thirdparty);

+        if ($force_thirdparty_id)

+            $idtofetch = $force_thirdparty_id;

 

-				$product_static->ref = $line->ref; //can change ref in hook

-				$product_static->label = $line->label; //can change label in hook

-				$text=$product_static->getNomUrl(1);

+        if ($idtofetch) {

+            $thirdparty = new Societe($this->db);

+            $result = $thirdparty->fetch($idtofetch);

+            $this->thirdparty = $thirdparty;

 

-				// Define output language and label

-				if (! empty($conf->global->MAIN_MULTILANGS))

-				{

-					if (! is_object($this->thirdparty))

-					{

-						dol_print_error('','Error: Method printObjectLine was called on an object and object->fetch_thirdparty was not done before');

-						return;

-					}

-

-					$prod = new Product($this->db);

-					$prod->fetch($line->fk_product);

-

-					$outputlangs = $langs;

-					$newlang='';

-					if (empty($newlang) && GETPOST('lang_id','aZ09')) $newlang=GETPOST('lang_id','aZ09');

-					if (! empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang=$this->thirdparty->default_lang;		// For language to language of customer

-					if (! empty($newlang))

-					{

-						$outputlangs = new Translate("",$conf);

-						$outputlangs->setDefaultLang($newlang);

-					}

-

-					$label = (! empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;

-				}

-				else

-				{

-					$label = $line->product_label;

-				}

+            // Use first price level if level not defined for third party

+            if (!empty($conf->global->PRODUIT_MULTIPRICES) && empty($this->thirdparty->price_level)) {

+                $this->thirdparty->price_level = 1;

+            }

 

-				$text.= ' - '.(! empty($line->label)?$line->label:$label);

-				$description.=(! empty($conf->global->PRODUIT_DESC_IN_FORM)?'':dol_htmlentitiesbr($line->description));	// Description is what to show on popup. We shown nothing if already into desc.

-			}

+            return $result;

+        } else

+            return -1;

+    }

 

-			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');

 

-			// Output template part (modules that overwrite templates must declare this into descriptor)

-			// Use global variables + $dateSelector + $seller and $buyer

-			$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-			foreach($dirtpls as $reldir)

-			{

-				$tpl = dol_buildpath($reldir.'/objectline_view.tpl.php');

-				if (empty($conf->file->strict_mode)) {

-					$res=@include $tpl;

-				} else {

-					$res=include $tpl; // for debug

-				}

-				if ($res) break;

-			}

-		}

-

-		// Ligne en mode update

-		if ($this->statut == 0 && $action == 'editline' && $selected == $line->id)

-		{

-			$label = (! empty($line->label) ? $line->label : (($line->fk_product > 0) ? $line->product_label : ''));

-			$placeholder=' placeholder="'.$langs->trans("Label").'"';

-

-			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');

-

-			// Output template part (modules that overwrite templates must declare this into descriptor)

-			// Use global variables + $dateSelector + $seller and $buyer

-			$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-			foreach($dirtpls as $reldir)

-			{

-				$tpl = dol_buildpath($reldir.'/objectline_edit.tpl.php');

-				if (empty($conf->file->strict_mode)) {

-					$res=@include $tpl;

-				} else {

-					$res=include $tpl; // for debug

-				}

-				if ($res) break;

-			}

-		}

-	}

-

-

-	/* This is to show array of line of details of source object */

-

-

-	/**

-	 * 	Return HTML table table of source object lines

-	 *  TODO Move this and previous function into output html class file (htmlline.class.php).

-	 *  If lines are into a template, title must also be into a template

-	 *  But for the moment we don't know if it's possible, so we keep the method available on overloaded objects.

-	 *

-	 *	@param	string		$restrictlist		''=All lines, 'services'=Restrict to services only

-	 *  @return	void

-	 */

-	function printOriginLinesList($restrictlist='')

-	{

-		global $langs, $hookmanager, $conf;

-

-		print '<tr class="liste_titre">';

-		print '<td>'.$langs->trans('Ref').'</td>';

-		print '<td>'.$langs->trans('Description').'</td>';

-		print '<td align="right">'.$langs->trans('VATRate').'</td>';

-		print '<td align="right">'.$langs->trans('PriceUHT').'</td>';

-		if (!empty($conf->multicurrency->enabled)) print '<td align="right">'.$langs->trans('PriceUHTCurrency').'</td>';

-		print '<td align="right">'.$langs->trans('Qty').'</td>';

-		if($conf->global->PRODUCT_USE_UNITS)

-		{

-			print '<td align="left">'.$langs->trans('Unit').'</td>';

-		}

-		print '<td align="right">'.$langs->trans('ReductionShort').'</td></tr>';

-

-		$var = true;

-		$i	 = 0;

-

-		if (! empty($this->lines))

-		{

-			foreach ($this->lines as $line)

-			{

-				if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

-				{

-					if (empty($line->fk_parent_line))

-					{

-						$parameters=array('line'=>$line,'var'=>$var,'i'=>$i);

-						$action='';

-						$hookmanager->executeHooks('printOriginObjectLine',$parameters,$this,$action);    // Note that $action and $object may have been modified by some hooks

-					}

-				}

-				else

-				{

-					$this->printOriginLine($line, $var, $restrictlist);

-				}

+    /**

+     * Looks for an object with ref matching the wildcard provided

+     * It does only work when $this->table_ref_field is set

+     *

+     * @param string $ref Wildcard

+     * @return int >1 = OK, 0 = Not found or table_ref_field not defined, <0 = KO

+     */

+    public function fetchOneLike($ref)

+    {

+        if (!$this->table_ref_field) {

+            return 0;

+        }

 

-				$i++;

-			}

-		}

-	}

-

-	/**

-	 * 	Return HTML with a line of table array of source object lines

-	 *  TODO Move this and previous function into output html class file (htmlline.class.php).

-	 *  If lines are into a template, title must also be into a template

-	 *  But for the moment we don't know if it's possible as we keep a method available on overloaded objects.

-	 *

-	 * 	@param	CommonObjectLine	$line				Line

-	 * 	@param	string				$var				Var

-	 *	@param	string				$restrictlist		''=All lines, 'services'=Restrict to services only (strike line if not)

-	 * 	@return	void

-	 */

-	function printOriginLine($line, $var, $restrictlist='')

-	{

-		global $langs, $conf;

-

-		//var_dump($line);

-		if (!empty($line->date_start))

-		{

-			$date_start=$line->date_start;

-		}

-		else

-		{

-			$date_start=$line->date_debut_prevue;

-			if ($line->date_debut_reel) $date_start=$line->date_debut_reel;

-		}

-		if (!empty($line->date_end))

-		{

-			$date_end=$line->date_end;

-		}

-		else

-		{

-			$date_end=$line->date_fin_prevue;

-			if ($line->date_fin_reel) $date_end=$line->date_fin_reel;

-		}

-

-		$this->tpl['label'] = '';

-		if (! empty($line->fk_parent_line)) $this->tpl['label'].= img_picto('', 'rightarrow');

-

-		if (($line->info_bits & 2) == 2)  // TODO Not sure this is used for source object

-		{

-			$discount=new DiscountAbsolute($this->db);

-			$discount->fk_soc = $this->socid;

-			$this->tpl['label'].= $discount->getNomUrl(0,'discount');

-		}

-		else if (! empty($line->fk_product))

-		{

-			$productstatic = new Product($this->db);

-			$productstatic->id = $line->fk_product;

-			$productstatic->ref = $line->ref;

-			$productstatic->type = $line->fk_product_type;

-            if(empty($productstatic->ref)){

-				$line->fetch_product();

-				$productstatic = $line->product;

-			}

-			

-			$this->tpl['label'].= $productstatic->getNomUrl(1);

-			$this->tpl['label'].= ' - '.(! empty($line->label)?$line->label:$line->product_label);

-			// Dates

-			if ($line->product_type == 1 && ($date_start || $date_end))

-			{

-				$this->tpl['label'].= get_date_range($date_start,$date_end);

-			}

-		}

-		else

-		{

-			$this->tpl['label'].= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''),'service') : img_object($langs->trans(''),'product')));

-			if (!empty($line->desc)) {

-				$this->tpl['label'].=$line->desc;

-			}else {

-				$this->tpl['label'].= ($line->label ? '&nbsp;'.$line->label : '');

-			}

-			

-			// Dates

-			if ($line->product_type == 1 && ($date_start || $date_end))

-			{

-				$this->tpl['label'].= get_date_range($date_start,$date_end);

-			}

-		}

+        $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element.' WHERE '.$this->table_ref_field.' LIKE "'.$this->db->escape($ref).'" LIMIT 1';

 

-		if (! empty($line->desc))

-		{

-			if ($line->desc == '(CREDIT_NOTE)')  // TODO Not sure this is used for source object

-			{

-				$discount=new DiscountAbsolute($this->db);

-				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(DEPOSIT)')  // TODO Not sure this is used for source object

-			{

-				$discount=new DiscountAbsolute($this->db);

-				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(EXCESS RECEIVED)')

-			{

-				$discount=new DiscountAbsolute($this->db);

-				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(EXCESS PAID)')

-			{

-				$discount=new DiscountAbsolute($this->db);

-				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid",$discount->getNomUrl(0));

-			}

-			else

-			{

-				$this->tpl['description'] = dol_trunc($line->desc,60);

-			}

-		}

-		else

-		{

-			$this->tpl['description'] = '&nbsp;';

-		}

+        $query = $this->db->query($sql);

 

-        // VAT Rate

-        $this->tpl['vat_rate'] = vatrate($line->tva_tx, true);

-        $this->tpl['vat_rate'] .= (($line->info_bits & 1) == 1) ? '*' : '';

-        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';

+        if (!$this->db->num_rows($query)) {

+            return 0;

+        }

 

-		$this->tpl['price'] = price($line->subprice);

-		$this->tpl['multicurrency_price'] = price($line->multicurrency_subprice);

-		$this->tpl['qty'] = (($line->info_bits & 2) != 2) ? $line->qty : '&nbsp;';

-		if ($conf->global->PRODUCT_USE_UNITS) $this->tpl['unit'] = $langs->transnoentities($line->getLabelOfUnit('long'));

-		$this->tpl['remise_percent'] = (($line->info_bits & 2) != 2) ? vatrate($line->remise_percent, true) : '&nbsp;';

-

-		// Is the line strike or not

-		$this->tpl['strike']=0;

-		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike']=1;

-

-		// Output template part (modules that overwrite templates must declare this into descriptor)

-		// Use global variables + $dateSelector + $seller and $buyer

-		$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-		foreach($dirtpls as $reldir)

-		{

-			$tpl = dol_buildpath($reldir.'/originproductline.tpl.php');

-			if (empty($conf->file->strict_mode)) {

-				$res=@include $tpl;

-			} else {

-				$res=include $tpl; // for debug

-			}

-			if ($res) break;

-		}

-	}

+        $result = $this->db->fetch_object($query);

 

+        return $this->fetch($result->rowid);

+    }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *	Add resources to the current object : add entry into llx_element_resources

-	 *	Need $this->element & $this->id

-	 *

-	 *	@param		int		$resource_id		Resource id

-	 *	@param		string	$resource_type		'resource'

-	 *	@param		int		$busy				Busy or not

-	 *	@param		int		$mandatory			Mandatory or not

-	 *	@return		int							<=0 if KO, >0 if OK

-	 */

-	function add_element_resource($resource_id, $resource_type, $busy=0, $mandatory=0)

-	{

+    /**

+     *	Load data for barcode into properties ->barcode_type*

+     *	Properties ->barcode_type that is id of barcode. Type is used to find other properties, but

+     *  if it is not defined, ->element must be defined to know default barcode type.

+     *

+     *	@return		int			<0 if KO, 0 if can't guess type of barcode (ISBN, EAN13...), >0 if OK (all barcode properties loaded)

+     */

+    function fetch_barcode()

+    {

         // phpcs:enable

-		$this->db->begin();

-

-		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_resources (";

-		$sql.= "resource_id";

-		$sql.= ", resource_type";

-		$sql.= ", element_id";

-		$sql.= ", element_type";

-		$sql.= ", busy";

-		$sql.= ", mandatory";

-		$sql.= ") VALUES (";

-		$sql.= $resource_id;

-		$sql.= ", '".$this->db->escape($resource_type)."'";

-		$sql.= ", '".$this->db->escape($this->id)."'";

-		$sql.= ", '".$this->db->escape($this->element)."'";

-		$sql.= ", '".$this->db->escape($busy)."'";

-		$sql.= ", '".$this->db->escape($mandatory)."'";

-		$sql.= ")";

-

-		dol_syslog(get_class($this)."::add_element_resource", LOG_DEBUG);

-		if ($this->db->query($sql))

-		{

-			$this->db->commit();

-			return 1;

-		}

-		else

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return  0;

-		}

-	}

+        global $conf;

+

+        dol_syslog(get_class($this).'::fetch_barcode this->element='.$this->element.' this->barcode_type='.$this->barcode_type);

+

+        $idtype=$this->barcode_type;

+        if (empty($idtype) && $idtype != '0')	// If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

+        {

+            if ($this->element == 'product')      $idtype = $conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;

+            else if ($this->element == 'societe') $idtype = $conf->global->GENBARCODE_BARCODETYPE_THIRDPARTY;

+            else dol_syslog('Call fetch_barcode with barcode_type not defined and cant be guessed', LOG_WARNING);

+        }

+

+        if ($idtype > 0)

+        {

+            if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder))    // If data not already loaded

+            {

+                $sql = "SELECT rowid, code, libelle as label, coder";

+                $sql.= " FROM ".MAIN_DB_PREFIX."c_barcode_type";

+                $sql.= " WHERE rowid = ".$idtype;

+                dol_syslog(get_class($this).'::fetch_barcode', LOG_DEBUG);

+                $resql = $this->db->query($sql);

+                if ($resql)

+                {

+                    $obj = $this->db->fetch_object($resql);

+                    $this->barcode_type       = $obj->rowid;

+                    $this->barcode_type_code  = $obj->code;

+                    $this->barcode_type_label = $obj->label;

+                    $this->barcode_type_coder = $obj->coder;

+                    return 1;

+                }

+                else

+                {

+                    dol_print_error($this->db);

+                    return -1;

+                }

+            }

+        }

+        return 0;

+    }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *    Delete a link to resource line

-	 *

-	 *    @param	int		$rowid			Id of resource line to delete

-	 *    @param	int		$element		element name (for trigger) TODO: use $this->element into commonobject class

-	 *    @param	int		$notrigger		Disable all triggers

-	 *    @return   int						>0 if OK, <0 if KO

-	 */

-	function delete_resource($rowid, $element, $notrigger=0)

-	{

+    /**

+     *		Load the project with id $this->fk_project into this->project

+     *

+     *		@return		int			<0 if KO, >=0 if OK

+     */

+    function fetch_projet()

+    {

         // phpcs:enable

-		global $user;

-

-		$this->db->begin();

+        include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';

 

-		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_resources";

-		$sql.= " WHERE rowid=".$rowid;

+        if (empty($this->fk_project) && ! empty($this->fk_projet)) $this->fk_project = $this->fk_projet;	// For backward compatibility

+        if (empty($this->fk_project)) return 0;

 

-		dol_syslog(get_class($this)."::delete_resource", LOG_DEBUG);

+        $project = new Project($this->db);

+        $result = $project->fetch($this->fk_project);

 

-		$resql=$this->db->query($sql);

-		if (! $resql)

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return -1;

-		}

-		else

-		{

-			if (! $notrigger)

-			{

-				$result=$this->call_trigger(strtoupper($element).'_DELETE_RESOURCE', $user);

-				if ($result < 0) { $this->db->rollback(); return -1; }

-			}

-			$this->db->commit();

-			return 1;

-		}

-	}

-

-

-	/**

-	 * Overwrite magic function to solve problem of cloning object that are kept as references

-	 *

-	 * @return void

-	 */

-	function __clone()

-	{

-		// Force a copy of this->lines, otherwise it will point to same object.

-		if (isset($this->lines) && is_array($this->lines))

-		{

-			$nboflines=count($this->lines);

-			for($i=0; $i < $nboflines; $i++)

-			{

-				$this->lines[$i] = clone $this->lines[$i];

-			}

-		}

-	}

-

-	/**

-	 * Common function for all objects extending CommonObject for generating documents

-	 *

-	 * @param 	string 		$modelspath 	Relative folder where generators are placed

-	 * @param 	string 		$modele 		Generator to use. Caller must set it to obj->modelpdf or GETPOST('modelpdf') for example.

-	 * @param 	Translate 	$outputlangs 	Output language to use

-	 * @param 	int 		$hidedetails 	1 to hide details. 0 by default

-	 * @param 	int 		$hidedesc 		1 to hide product description. 0 by default

-	 * @param 	int 		$hideref 		1 to hide product reference. 0 by default

-	 * @param   null|array  $moreparams     Array to provide more information

-	 * @return 	int 						>0 if OK, <0 if KO

-	 * @see	addFileIntoDatabaseIndex

-	 */

-	protected function commonGenerateDocument($modelspath, $modele, $outputlangs, $hidedetails, $hidedesc, $hideref, $moreparams=null)

-	{

-		global $conf, $langs, $user;

-

-		$srctemplatepath='';

-

-		// Increase limit for PDF build

-		$err=error_reporting();

-		error_reporting(0);

-		@set_time_limit(120);

-		error_reporting($err);

-

-		// If selected model is a filename template (then $modele="modelname" or "modelname:filename")

-		$tmp=explode(':',$modele,2);

-		if (! empty($tmp[1]))

-		{

-			$modele=$tmp[0];

-			$srctemplatepath=$tmp[1];

-		}

-

-		// Search template files

-		$file=''; $classname=''; $filefound=0;

-		$dirmodels=array('/');

-		if (is_array($conf->modules_parts['models'])) $dirmodels=array_merge($dirmodels,$conf->modules_parts['models']);

-		foreach($dirmodels as $reldir)

-		{

-			foreach(array('doc','pdf') as $prefix)

-			{

-				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php";     // Member module use prefix_module.class.php

-				else $file = $prefix."_".$modele.".modules.php";

+        $this->projet = $project;	// deprecated

+        $this->project = $project;

+        return $result;

+    }

 

-				// On verifie l'emplacement du modele

-				$file=dol_buildpath($reldir.$modelspath.$file,0);

-				if (file_exists($file))

-				{

-					$filefound=1;

-					$classname=$prefix.'_'.$modele;

-					break;

-				}

-			}

-			if ($filefound) break;

-		}

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *		Load the product with id $this->fk_product into this->product

+     *

+     *		@return		int			<0 if KO, >=0 if OK

+     */

+    function fetch_product()

+    {

+        // phpcs:enable

+        include_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

 

-		// If generator was found

-		if ($filefound)

-		{

-			global $db;  // Required to solve a conception default in commonstickergenerator.class.php making an include of code using $db

+        if (empty($this->fk_product)) return 0;

 

-			require_once $file;

+        $product = new Product($this->db);

+        $result = $product->fetch($this->fk_product);

 

-			$obj = new $classname($this->db);

+        $this->product = $product;

+        return $result;

+    }

 

-			// If generator is ODT, we must have srctemplatepath defined, if not we set it.

-			if ($obj->type == 'odt' && empty($srctemplatepath))

-			{

-				$varfortemplatedir=$obj->scandir;

-				if ($varfortemplatedir && ! empty($conf->global->$varfortemplatedir))

-				{

-					$dirtoscan=$conf->global->$varfortemplatedir;

-

-					$listoffiles=array();

-

-					// Now we add first model found in directories scanned

-					$listofdir=explode(',',$dirtoscan);

-					foreach($listofdir as $key => $tmpdir)

-					{

-						$tmpdir=trim($tmpdir);

-						$tmpdir=preg_replace('/DOL_DATA_ROOT/',DOL_DATA_ROOT,$tmpdir);

-						if (! $tmpdir) { unset($listofdir[$key]); continue; }

-						if (is_dir($tmpdir))

-						{

-							$tmpfiles=dol_dir_list($tmpdir,'files',0,'\.od(s|t)$','','name',SORT_ASC,0);

-							if (count($tmpfiles)) $listoffiles=array_merge($listoffiles,$tmpfiles);

-						}

-					}

-

-					if (count($listoffiles))

-					{

-						foreach($listoffiles as $record)

-						{

-							$srctemplatepath=$record['fullname'];

-							break;

-						}

-					}

-				}

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *		Load the user with id $userid into this->user

+     *

+     *		@param	int		$userid 		Id du contact

+     *		@return	int						<0 if KO, >0 if OK

+     */

+    function fetch_user($userid)

+    {

+        // phpcs:enable

+        $user = new User($this->db);

+        $result=$user->fetch($userid);

+        $this->user = $user;

+        return $result;

+    }

 

-				if (empty($srctemplatepath))

-				{

-					$this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotDefined';

-					return -1;

-				}

-			}

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *	Read linked origin object

+     *

+     *	@return		void

+     */

+    function fetch_origin()

+    {

+        // phpcs:enable

+        if ($this->origin == 'shipping') $this->origin = 'expedition';

+        if ($this->origin == 'delivery') $this->origin = 'livraison';

+        if ($this->origin == 'order_supplier') $this->origin = 'commandeFournisseur';

 

-			if ($obj->type == 'odt' && ! empty($srctemplatepath))

-			{

-				if (! dol_is_file($srctemplatepath))

-				{

-					$this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotFound';

-					return -1;

-				}

-			}

+        $origin = $this->origin;

 

-			// We save charset_output to restore it because write_file can change it if needed for

-			// output format that does not support UTF8.

-			$sav_charset_output=$outputlangs->charset_output;

+        $classname = ucfirst($origin);

+        $this->$origin = new $classname($this->db);

+        $this->$origin->fetch($this->origin_id);

+    }

 

-			if (in_array(get_class($this), array('Adherent')))

-			{

-				$arrayofrecords = array();   // The write_file of templates of adherent class need this var

-				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, 'member', 1, $moreparams);

-			}

-			else

-			{

-				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, $hidedetails, $hidedesc, $hideref, $moreparams);

-			}

-			// After call of write_file $obj->result['fullpath'] is set with generated file. It will be used to update the ECM database index.

+    /**

+     *  Load object from specific field

+     *

+     *  @param	string	$table		Table element or element line

+     *  @param	string	$field		Field selected

+     *  @param	string	$key		Import key

+     *  @param	string	$element	Element name

+     *	@return	int					<0 if KO, >0 if OK

+     */

+    function fetchObjectFrom($table, $field, $key, $element = null)

+    {

+        global $conf;

 

-			if ($resultwritefile > 0)

-			{

-				$outputlangs->charset_output=$sav_charset_output;

+        $result=false;

 

-				// We delete old preview

-				require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';

-				dol_delete_preview($this);

+        $sql = "SELECT rowid FROM ".MAIN_DB_PREFIX.$table;

+        $sql.= " WHERE ".$field." = '".$key."'";

+        if (! empty($element)) {

+            $sql.= " AND entity IN (".getEntity($element).")";

+        } else {

+            $sql.= " AND entity = ".$conf->entity;

+        }

 

-				// Index file in database

-				if (! empty($obj->result['fullpath']))

-				{

-					$destfull = $obj->result['fullpath'];

-					$upload_dir = dirname($destfull);

-					$destfile = basename($destfull);

-					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $upload_dir);

-

-					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir

-					{

-						$filename = basename($destfile);

-						$rel_dir = preg_replace('/[\\/]$/', '', $rel_dir);

-						$rel_dir = preg_replace('/^[\\/]/', '', $rel_dir);

-

-						include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';

-						$ecmfile=new EcmFiles($this->db);

-						$result = $ecmfile->fetch(0, '', ($rel_dir?$rel_dir.'/':'').$filename);

-

-						// Set the public "share" key

-						$setsharekey = false;

-						if ($this->element == 'propal')

-						{

-							$useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL;	// Replace this with 1 when feature to make online signature is ok

-							if ($useonlinesignature) $setsharekey=true;

-							if (! empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

-						}

-						if ($this->element == 'commande'     && ! empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey=true;

-						if ($this->element == 'facture'      && ! empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey=true;

-						if ($this->element == 'bank_account' && ! empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

-

-						if ($setsharekey)

-						{

-							if (empty($ecmfile->share))	// Because object not found or share not set yet

-							{

-								require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

-								$ecmfile->share = getRandomPassword(true);

-							}

-						}

+        dol_syslog(get_class($this).'::fetchObjectFrom', LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $row = $this->db->fetch_row($resql);

+            // Test for avoid error -1

+            if ($row[0] > 0) {

+                $result = $this->fetch($row[0]);

+            }

+        }

 

-						if ($result > 0)

-						{

-							$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

-							$ecmfile->fullpath_orig = '';

-							$ecmfile->gen_or_uploaded = 'generated';

-							$ecmfile->description = '';    // indexed content

-							$ecmfile->keyword = '';        // keyword content

-							$result = $ecmfile->update($user);

-							if ($result < 0)

-							{

-								setEventMessages($ecmfile->error, $ecmfile->errors, 'warnings');

-							}

-						}

-						else

-						{

-							$ecmfile->entity = $conf->entity;

-							$ecmfile->filepath = $rel_dir;

-							$ecmfile->filename = $filename;

-							$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

-							$ecmfile->fullpath_orig = '';

-							$ecmfile->gen_or_uploaded = 'generated';

-							$ecmfile->description = '';    // indexed content

-							$ecmfile->keyword = '';        // keyword content

-							$ecmfile->src_object_type = $this->table_element;

-							$ecmfile->src_object_id   = $this->id;

-

-							$result = $ecmfile->create($user);

-							if ($result < 0)

-							{

-								setEventMessages($ecmfile->error, $ecmfile->errors, 'warnings');

-							}

-						}

+        return $result;

+    }

 

-						/*$this->result['fullname']=$destfull;

-						$this->result['filepath']=$ecmfile->filepath;

-						$this->result['filename']=$ecmfile->filename;*/

-						//var_dump($obj->update_main_doc_field);exit;

-

-						// Update the last_main_doc field into main object (if documenent generator has property ->update_main_doc_field set)

-						$update_main_doc_field=0;

-						if (! empty($obj->update_main_doc_field)) $update_main_doc_field=1;

-						if ($update_main_doc_field && ! empty($this->table_element))

-						{

-							$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element." SET last_main_doc = '".($ecmfile->filepath.'/'.$ecmfile->filename)."'";

-							$sql.= ' WHERE rowid = '.$this->id;

-							$resql = $this->db->query($sql);

-							if (! $resql) dol_print_error($this->db);

-						}

-					}

-				}

-				else

-				{

-					dol_syslog('Method ->write_file was called on object '.get_class($obj).' and return a success but the return array ->result["fullpath"] was not set.', LOG_WARNING);

-				}

+    /**

+     *	Getter generic. Load value from a specific field

+     *

+     *	@param	string	$table		Table of element or element line

+     *	@param	int		$id			Element id

+     *	@param	string	$field		Field selected

+     *	@return	int					<0 if KO, >0 if OK

+     */

+    function getValueFrom($table, $id, $field)

+    {

+        $result=false;

+        if (!empty($id) && !empty($field) && !empty($table)) {

+            $sql = "SELECT ".$field." FROM ".MAIN_DB_PREFIX.$table;

+            $sql.= " WHERE rowid = ".$id;

+

+            dol_syslog(get_class($this).'::getValueFrom', LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if ($resql)

+            {

+                $row = $this->db->fetch_row($resql);

+                $result = $row[0];

+            }

+        }

+        return $result;

+    }

 

-				// Success in building document. We build meta file.

-				dol_meta_create($this);

+    /**

+     *	Setter generic. Update a specific field into database.

+     *  Warning: Trigger is run only if param trigkey is provided.

+     *

+     *	@param	string		$field			Field to update

+     *	@param	mixed		$value			New value

+     *	@param	string		$table			To force other table element or element line (should not be used)

+     *	@param	int			$id				To force other object id (should not be used)

+     *	@param	string		$format			Data format ('text', 'date'). 'text' is used if not defined

+     *	@param	string		$id_field		To force rowid field name. 'rowid' is used if not defined

+     *	@param	User|string	$fuser			Update the user of last update field with this user. If not provided, current user is used except if value is 'none'

+     *  @param  string      $trigkey    	Trigger key to run (in most cases something like 'XXX_MODIFY')

+     *  @param	string		$fk_user_field	Name of field to save user id making change

+     *	@return	int							<0 if KO, >0 if OK

+     *  @see updateExtraField

+     */

+    function setValueFrom($field, $value, $table='', $id=null, $format='', $id_field='', $fuser=null, $trigkey='', $fk_user_field='fk_user_modif')

+    {

+        global $user,$langs,$conf;

 

-				return 1;

-			}

-			else

-			{

-				$outputlangs->charset_output=$sav_charset_output;

-				dol_print_error($this->db, "Error generating document for ".__CLASS__.". Error: ".$obj->error, $obj->errors);

-				return -1;

-			}

-		}

-		else

-		{

-			$this->error=$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);

-			dol_print_error('',$this->error);

-			return -1;

-		}

-	}

-

-	/**

-	 *  Build thumb

-	 *  @TODO Move this into files.lib.php

-	 *

-	 *  @param      string	$file           Path file in UTF8 to original file to create thumbs from.

-	 *	@return		void

-	 */

-	function addThumbs($file)

-	{

-		global $maxwidthsmall, $maxheightsmall, $maxwidthmini, $maxheightmini, $quality;

-

-		require_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';		// This define also $maxwidthsmall, $quality, ...

-

-		$file_osencoded=dol_osencode($file);

-		if (file_exists($file_osencoded))

-		{

-			// Create small thumbs for company (Ratio is near 16/9)

-			// Used on logon for example

-			vignette($file_osencoded, $maxwidthsmall, $maxheightsmall, '_small', $quality);

-

-			// Create mini thumbs for company (Ratio is near 16/9)

-			// Used on menu or for setup page for example

-			vignette($file_osencoded, $maxwidthmini, $maxheightmini, '_mini', $quality);

-		}

-	}

-

-

-	/* Functions common to commonobject and commonobjectline */

-

-	/* For default values */

-

-	/**

-	 * Return the default value to use for a field when showing the create form of object.

-	 * Return values in this order:

-	 * 1) If parameter is available into POST, we return it first.

-	 * 2) If not but an alternate value was provided as parameter of function, we return it.

-	 * 3) If not but a constant $conf->global->OBJECTELEMENT_FIELDNAME is set, we return it (It is better to use the dedicated table).

-	 * 4) Return value found into database (TODO No yet implemented)

-	 *

-	 * @param   string              $fieldname          Name of field

-	 * @param   string              $alternatevalue     Alternate value to use

-	 * @return  string|string[]                         Default value (can be an array if the GETPOST return an array)

-	 **/

-	function getDefaultCreateValueFor($fieldname, $alternatevalue=null)

-	{

-		global $conf, $_POST;

-

-		// If param here has been posted, we use this value first.

-		if (isset($_POST[$fieldname])) return GETPOST($fieldname, 2);

-

-		if (isset($alternatevalue)) return $alternatevalue;

-

-		$newelement=$this->element;

-		if ($newelement == 'facture') $newelement='invoice';

-		if ($newelement == 'commande') $newelement='order';

-		if (empty($newelement))

-		{

-			dol_syslog("Ask a default value using common method getDefaultCreateValueForField on an object with no property ->element defined. Return empty string.", LOG_WARNING);

-			return '';

-		}

-

-		$keyforfieldname=strtoupper($newelement.'_DEFAULT_'.$fieldname);

-		//var_dump($keyforfieldname);

-		if (isset($conf->global->$keyforfieldname)) return $conf->global->$keyforfieldname;

-

-		// TODO Ad here a scan into table llx_overwrite_default with a filter on $this->element and $fieldname

-	}

-

-

-	/* For triggers */

+        if (empty($table)) 	  $table=$this->table_element;

+        if (empty($id))    	  $id=$this->id;

+        if (empty($format))   $format='text';

+        if (empty($id_field)) $id_field='rowid';

 

+        $error=0;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 * Call trigger based on this instance.

-	 * Some context information may also be provided into array property this->context.

-	 * NB:  Error from trigger are stacked in interface->errors

-	 * NB2: If return code of triggers are < 0, action calling trigger should cancel all transaction.

-	 *

-	 * @param   string    $trigger_name   trigger's name to execute

-	 * @param   User      $user           Object user

-	 * @return  int                       Result of run_triggers

-	 */

-	function call_trigger($trigger_name, $user)

-	{

-        // phpcs:enable

-		global $langs,$conf;

+        $this->db->begin();

 

-		include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';

-		$interface=new Interfaces($this->db);

-		$result=$interface->run_triggers($trigger_name,$this,$user,$langs,$conf);

+        // Special case

+        if ($table == 'product' && $field == 'note_private') $field='note';

+        if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) $fk_user_field = 'fk_user_mod';

 

-		if ($result < 0)

-		{

-			if (!empty($this->errors))

-			{

-				$this->errors=array_unique(array_merge($this->errors,$interface->errors));   // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.

-			}

-			else

-			{

-				$this->errors=$interface->errors;

-			}

-		}

-		return $result;

-	}

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$table." SET ";

 

+        if ($format == 'text') $sql.= $field." = '".$this->db->escape($value)."'";

+        else if ($format == 'int') $sql.= $field." = ".$this->db->escape($value);

+        else if ($format == 'date') $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");

 

-	/* Functions for extrafields */

+        if ($fk_user_field)

+        {

+            if (! empty($fuser) && is_object($fuser)) $sql.=", ".$fk_user_field." = ".$fuser->id;

+            elseif (empty($fuser) || $fuser != 'none') $sql.=", ".$fk_user_field." = ".$user->id;

+        }

 

+        $sql.= " WHERE ".$id_field." = ".$id;

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *  Function to get extra fields of an object into $this->array_options

-	 *  This method is in most cases called by method fetch of objects but you can call it separately.

-	 *

-	 *  @param	int		$rowid			Id of line. Use the id of object if not defined. Deprecated. Function must be called without parameters.

-	 *  @param  array	$optionsArray   Array resulting of call of extrafields->fetch_name_optionals_label(). Deprecated. Function must be called without parameters.

-	 *  @return	int						<0 if error, 0 if no values of extrafield to find nor found, 1 if an attribute is found and value loaded

-	 */

-	function fetch_optionals($rowid=null, $optionsArray=null)

-	{

-        // phpcs:enable

-		if (empty($rowid)) $rowid=$this->id;

-

-		// To avoid SQL errors. Probably not the better solution though

-		if (!$this->table_element) {

-			return 0;

-		}

-

-		$this->array_options=array();

-

-		if (! is_array($optionsArray))

-		{

-			// If $extrafields is not a known object, we initialize it. Best practice is to have $extrafields defined into card.php or list.php page.

-			// TODO Use of existing $extrafield is not yet ready (must mutualize code that use extrafields in form first)

-			// global $extrafields;

-			//if (! is_object($extrafields))

-			//{

-				// require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

-            $extrafields = new ExtraFields();

-            //}

+        dol_syslog(get_class($this)."::".__FUNCTION__."", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            if ($trigkey)

+            {

+                // call trigger with updated object values

+                if (empty($this->fields) && method_exists($this, 'fetch'))

+                {

+                    $result = $this->fetch($id);

+                }

+                else

+                {

+                    $result = $this->fetchCommon($id);

+                }

+                if ($result >= 0) $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);   // This may set this->errors

+                if ($result < 0) $error++;

+            }

 

-			// Load array of extrafields for elementype = $this->table_element

-			if (empty($extrafields->attributes[$this->table_element]['loaded']))

-			{

-				$extrafields->fetch_name_optionals_label($this->table_element);

-			}

-			$optionsArray = (! empty($extrafields->attributes[$this->table_element]['label'])?$extrafields->attributes[$this->table_element]['label']:null);

-		}

-		else

-		{

-			global $extrafields;

-			dol_syslog("Warning: fetch_optionals was called with param optionsArray defined when you should pass null now", LOG_WARNING);

-		}

-

-		$table_element = $this->table_element;

-		if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

-

-		// Request to get complementary values

-		if (is_array($optionsArray) && count($optionsArray) > 0)

-		{

-			$sql = "SELECT rowid";

-			foreach ($optionsArray as $name => $label)

-			{

-				if (empty($extrafields->attributes[$this->table_element]['type'][$name]) || $extrafields->attributes[$this->table_element]['type'][$name] != 'separate')

-				{

-					$sql.= ", ".$name;

-				}

-			}

-			$sql.= " FROM ".MAIN_DB_PREFIX.$table_element."_extrafields";

-			$sql.= " WHERE fk_object = ".$rowid;

+            if (! $error)

+            {

+                if (property_exists($this, $field)) $this->$field = $value;

+                $this->db->commit();

+                return 1;

+            }

+            else

+            {

+                $this->db->rollback();

+                return -2;

+            }

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return -1;

+        }

+    }

 

-			//dol_syslog(get_class($this)."::fetch_optionals get extrafields data for ".$this->table_element, LOG_DEBUG);		// Too verbose

-			$resql=$this->db->query($sql);

-			if ($resql)

-			{

-				$this->array_options = array();

-				$numrows=$this->db->num_rows($resql);

-				if ($numrows)

-				{

-					$tab = $this->db->fetch_array($resql);

-

-					foreach ($tab as $key => $value)

-					{

-						// Test fetch_array ! is_int($key) because fetch_array result is a mix table with Key as alpha and Key as int (depend db engine)

-						if ($key != 'rowid' && $key != 'tms' && $key != 'fk_member' && ! is_int($key))

-						{

-							// we can add this attribute to object

-							if (! empty($extrafields) && in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date','datetime')))

-							{

-								//var_dump($extrafields->attributes[$this->table_element]['type'][$key]);

-								$this->array_options["options_".$key]=$this->db->jdate($value);

-							}

-							else

-							{

-								$this->array_options["options_".$key]=$value;

-							}

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *      Load properties id_previous and id_next by comparing $fieldid with $this->ref

+     *

+     *      @param	string	$filter		Optional filter. Example: " AND (t.field1 = 'aa' OR t.field2 = 'bb')"

+     *	 	@param  string	$fieldid   	Name of field to use for the select MAX and MIN

+     *		@param	int		$nodbprefix	Do not include DB prefix to forge table name

+     *      @return int         		<0 if KO, >0 if OK

+     */

+    function load_previous_next_ref($filter, $fieldid, $nodbprefix=0)

+    {

+        // phpcs:enable

+        global $conf, $user;

 

-							//var_dump('key '.$key.' '.$value.' type='.$extrafields->attributes[$this->table_element]['type'][$key].' '.$this->array_options["options_".$key]);

-						}

-					}

-				}

+        if (! $this->table_element)

+        {

+            dol_print_error('',get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");

+            return -1;

+        }

+        if ($fieldid == 'none') return 1;

 

-				$this->db->free($resql);

+        // Security on socid

+        $socid = 0;

+        if ($user->societe_id > 0) $socid = $user->societe_id;

 

-				if ($numrows) return $numrows;

-				else return 0;

-			}

-			else

-			{

-				dol_print_error($this->db);

-				return -1;

-			}

-		}

-		return 0;

-	}

-

-	/**

-	 *	Delete all extra fields values for the current object.

-	 *

-	 *  @return	int		<0 if KO, >0 if OK

-	 */

-	function deleteExtraFields()

-	{

-		$this->db->begin();

-

-		$table_element = $this->table_element;

-		if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

-

-		$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

-		dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);

-		$resql=$this->db->query($sql_del);

-		if (! $resql)

-		{

-			$this->error=$this->db->lasterror();

-			$this->db->rollback();

-			return -1;

-		}

-		else

-		{

-			$this->db->commit();

-			return 1;

-		}

-	}

-

-	/**

-	 *	Add/Update all extra fields values for the current object.

-	 *  Data to describe values to insert/update are stored into $this->array_options=array('options_codeforfield1'=>'valueforfield1', 'options_codeforfield2'=>'valueforfield2', ...)

-	 *  This function delete record with all extrafields and insert them again from the array $this->array_options.

-	 *

-	 *  @param	string		$trigger		If defined, call also the trigger (for example COMPANY_MODIFY)

-	 *  @param	User		$userused		Object user

-	 *  @return int 						-1=error, O=did nothing, 1=OK

-	 *  @see updateExtraField, setValueFrom

-	 */

-	function insertExtraFields($trigger='', $userused=null)

-	{

-		global $conf,$langs,$user;

-

-		if (empty($userused)) $userused=$user;

-

-		$error=0;

-

-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

-

-		if (! empty($this->array_options))

-		{

-			// Check parameters

-			$langs->load('admin');

-			require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

-			$extrafields = new ExtraFields($this->db);

-			$target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);

-

-			//Eliminate copied source object extra_fields that do not exist in target object

-			$new_array_options=array();

-			foreach ($this->array_options as $key => $value) {

-				if (in_array(substr($key,8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test

-					$new_array_options[$key] = $value;

-				elseif (in_array($key, array_keys($target_extrafields)))		// We test on $key that does not contains the 'options_' prefix

-					$new_array_options['options_'.$key] = $value;

-			}

-

-			foreach($new_array_options as $key => $value)

-			{

-			   	$attributeKey      = substr($key,8);   // Remove 'options_' prefix

-			   	$attributeType     = $extrafields->attributes[$this->table_element]['type'][$attributeKey];

-			   	$attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$attributeKey];

-			   	$attributeParam    = $extrafields->attributes[$this->table_element]['param'][$attributeKey];

-			   	$attributeRequired = $extrafields->attributes[$this->table_element]['required'][$attributeKey];

-

-			   	if ($attributeRequired)

-			   	{

-			   		$mandatorypb=false;

-			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb=true;

-			   		if ($this->array_options[$key] === '') $mandatorypb=true;

-			   		if ($mandatorypb)

-			   		{

-			   			dol_syslog($this->error);

-			   			$this->errors[]=$langs->trans('ErrorFieldRequired', $attributeLabel);

-			   			return -1;

-			   		}

-			   	}

-

-				//dol_syslog("attributeLabel=".$attributeLabel, LOG_DEBUG);

-				//dol_syslog("attributeType=".$attributeType, LOG_DEBUG);

-

-			   	switch ($attributeType)

-			   	{

-			   		case 'int':

-			  			if (!is_numeric($value) && $value!='')

-			   			{

-			   				$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

-			   				return -1;

-			  			}

-			   			elseif ($value=='')

-			   			{

-			   				$new_array_options[$key] = null;

-			   			}

-			 			break;

-					case 'double':

-						$value = price2num($value);

-						if (!is_numeric($value) && $value!='')

-						{

-							dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

-							$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

-							return -1;

-						}

-						elseif ($value=='')

-						{

-							$new_array_options[$key] = null;

-						}

-						//dol_syslog("double value"." sur ".$attributeLabel."(".$value." is '".$attributeType."')", LOG_DEBUG);

-						$new_array_options[$key] = $value;

-						break;

-			 		/*case 'select':	// Not required, we chosed value='0' for undefined values

-             			if ($value=='-1')

-             			{

-             				$this->array_options[$key] = null;

-             			}

-             			break;*/

-			   		case 'password':

-			   			$algo='';

-			   			if ($this->array_options[$key] != '' && is_array($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']))

-			   			{

-			   				// If there is an encryption choice, we use it to crypt data before insert

-			   				$tmparrays = array_keys($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']);

-			   				$algo=reset($tmparrays);

-			   				if ($algo != '')

-			   				{

-			   					//global $action;		// $action may be 'create', 'update', 'update_extras'...

-			   					//var_dump($action);

-			   					//var_dump($this->oldcopy);exit;

-			   					if (is_object($this->oldcopy))		// If this->oldcopy is not defined, we can't know if we change attribute or not, so we must keep value

-			   					{

-			   						//var_dump($this->oldcopy->array_options[$key]); var_dump($this->array_options[$key]);

-				   					if ($this->array_options[$key] == $this->oldcopy->array_options[$key])	// If old value crypted in database is same than submited new value, it means we don't change it, so we don't update.

-				   					{

-				   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

-				   					}

-									else

-									{

-										// var_dump($algo);

-										$newvalue = dol_hash($this->array_options[$key], $algo);

-										$new_array_options[$key] = $newvalue;

-									}

-			   					}

-			   					else

-			   					{

-			   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

-			   					}

-			   				}

-			   			}

-			   			else	// Common usage

-			   			{

-			   				$new_array_options[$key] = $this->array_options[$key];

-			   			}

-			   			break;

-			   		case 'price':

-						$new_array_options[$key] = price2num($this->array_options[$key]);

-						break;

-					case 'date':

-						$new_array_options[$key] = $this->db->idate($this->array_options[$key]);

-						break;

-					case 'datetime':

-						// If data is a string instead of a timestamp, we convert it

-						if (! is_int($this->array_options[$key])) {

-							$this->array_options[$key] = strtotime($this->array_options[$key]);

-						}

-						$new_array_options[$key] = $this->db->idate($this->array_options[$key]);

-						break;

-		   			case 'link':

-						$param_list=array_keys($attributeParam['options']);

-						// 0 : ObjectName

-						// 1 : classPath

-						$InfoFieldList = explode(":", $param_list[0]);

-						dol_include_once($InfoFieldList[1]);

-						if ($InfoFieldList[0] && class_exists($InfoFieldList[0]))

-						{

-							if ($value == '-1')	// -1 is key for no defined in combo list of objects

-							{

-								$new_array_options[$key]='';

-							}

-							elseif ($value)

-							{

-								$object = new $InfoFieldList[0]($this->db);

-								if (is_numeric($value)) $res=$object->fetch($value);

-								else $res=$object->fetch('',$value);

-

-								if ($res > 0) $new_array_options[$key]=$object->id;

-								else

-								{

-									$this->error="Id/Ref '".$value."' for object '".$object->element."' not found";

-									$this->db->rollback();

-									return -1;

-								}

-							}

-						}

-						else

-						{

-							dol_syslog('Error bad setup of extrafield', LOG_WARNING);

-						}

-						break;

-			   	}

-			}

+        // this->ismultientitymanaged contains

+        // 0=No test on entity, 1=Test with field entity, 2=Test with link by societe

+        $alias = 's';

+        if ($this->element == 'societe') $alias = 'te';

 

-			$this->db->begin();

+        $sql = "SELECT MAX(te.".$fieldid.")";

+        $sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

+        if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+            $sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

+        }

+        if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

+        else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

+        else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

+        if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+        $sql.= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

+        if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

+        if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

+        if (! empty($filter))

+        {

+            if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

+            $sql.=$filter;

+        }

+        if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

+        else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+        if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

+            if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+                if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

+                    $sql.= " AND te.entity IS NOT NULL"; // Show all users

+                } else {

+                    $sql.= " AND ug.fk_user = te.rowid";

+                    $sql.= " AND ug.entity IN (".getEntity($this->element).")";

+                }

+            } else {

+                $sql.= ' AND te.entity IN ('.getEntity($this->element).')';

+            }

+        }

+        if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

+        if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

+        if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+        //print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 

-			$table_element = $this->table_element;

-			if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+        $result = $this->db->query($sql);

+        if (! $result)

+        {

+            $this->error=$this->db->lasterror();

+            return -1;

+        }

+        $row = $this->db->fetch_row($result);

+        $this->ref_previous = $row[0];

 

-			$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

-			dol_syslog(get_class($this)."::insertExtraFields delete", LOG_DEBUG);

-			$this->db->query($sql_del);

 

-			$sql = "INSERT INTO ".MAIN_DB_PREFIX.$table_element."_extrafields (fk_object";

-			foreach($new_array_options as $key => $value)

-			{

-				$attributeKey = substr($key,8);   // Remove 'options_' prefix

-				// Add field of attribut

-				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator

-					$sql.=",".$attributeKey;

-			}

-			$sql .= ") VALUES (".$this->id;

-

-			foreach($new_array_options as $key => $value)

-			{

-				$attributeKey = substr($key,8);   // Remove 'options_' prefix

-				// Add field of attribute

-				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator)

-				{

-					if ($new_array_options[$key] != '')

-					{

-						$sql.=",'".$this->db->escape($new_array_options[$key])."'";

-					}

-					else

-					{

-						$sql.=",null";

-					}

-				}

-			}

-			$sql.=")";

+        $sql = "SELECT MIN(te.".$fieldid.")";

+        $sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

+        if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+            $sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

+        }

+        if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

+        else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

+        else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

+        if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+        $sql.= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

+        if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

+        if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

+        if (! empty($filter))

+        {

+            if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

+            $sql.=$filter;

+        }

+        if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

+        else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+        if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

+            if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+                if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

+                    $sql.= " AND te.entity IS NOT NULL"; // Show all users

+                } else {

+                    $sql.= " AND ug.fk_user = te.rowid";

+                    $sql.= " AND ug.entity IN (".getEntity($this->element).")";

+                }

+            } else {

+                $sql.= ' AND te.entity IN ('.getEntity($this->element).')';

+            }

+        }

+        if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

+        if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

+        if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+        //print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

+        // Rem: Bug in some mysql version: SELECT MIN(rowid) FROM llx_socpeople WHERE rowid > 1 when one row in database with rowid=1, returns 1 instead of null

+

+        $result = $this->db->query($sql);

+        if (! $result)

+        {

+            $this->error=$this->db->lasterror();

+            return -2;

+        }

+        $row = $this->db->fetch_row($result);

+        $this->ref_next = $row[0];

 

-			dol_syslog(get_class($this)."::insertExtraFields insert", LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if (! $resql)

-			{

-				$this->error=$this->db->lasterror();

-				$error++;

-			}

+        return 1;

+    }

 

-			if (! $error && $trigger)

-			{

-				// Call trigger

-				$this->context=array('extrafieldaddupdate'=>1);

-				$result=$this->call_trigger($trigger, $userused);

-				if ($result < 0) $error++;

-				// End call trigger

-			}

-

-			if ($error)

-			{

-				$this->db->rollback();

-				return -1;

-			}

-			else

-			{

-				$this->db->commit();

-				return 1;

-			}

-		}

-		else return 0;

-	}

-

-	/**

-	 *	Update an extra field value for the current object.

-	 *  Data to describe values to update are stored into $this->array_options=array('options_codeforfield1'=>'valueforfield1', 'options_codeforfield2'=>'valueforfield2', ...)

-	 *

-	 *  @param  string      $key    		Key of the extrafield (without starting 'options_')

-	 *  @param	string		$trigger		If defined, call also the trigger (for example COMPANY_MODIFY)

-	 *  @param	User		$userused		Object user

-	 *  @return int                 		-1=error, O=did nothing, 1=OK

-	 *  @see setValueFrom, insertExtraFields

-	 */

-	function updateExtraField($key, $trigger=null, $userused=null)

-	{

-		global $conf,$langs,$user;

-

-		if (empty($userused)) $userused=$user;

-

-		$error=0;

-

-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

-

-		if (! empty($this->array_options) && isset($this->array_options["options_".$key]))

-		{

-			// Check parameters

-			$langs->load('admin');

-			require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

-			$extrafields = new ExtraFields($this->db);

-			$target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);

-

-			$value=$this->array_options["options_".$key];

-

-			$attributeType     = $extrafields->attributes[$this->table_element]['type'][$key];

-			$attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$key];

-			$attributeParam    = $extrafields->attributes[$this->table_element]['param'][$key];

-			$attributeRequired = $extrafields->attributes[$this->table_element]['required'][$key];

-

-			//dol_syslog("attributeLabel=".$attributeLabel, LOG_DEBUG);

-			//dol_syslog("attributeType=".$attributeType, LOG_DEBUG);

-

-			switch ($attributeType)

-			{

-				case 'int':

-					if (!is_numeric($value) && $value!='')

-					{

-						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue",$attributeLabel);

-						return -1;

-					}

-					elseif ($value=='')

-					{

-						$this->array_options["options_".$key] = null;

-					}

-					break;

-				case 'double':

-					$value = price2num($value);

-					if (!is_numeric($value) && $value!='')

-					{

-						dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

-						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

-						return -1;

-					}

-					elseif ($value=='')

-					{

-						$this->array_options["options_".$key] = null;

-					}

-					//dol_syslog("double value"." sur ".$attributeLabel."(".$value." is '".$attributeType."')", LOG_DEBUG);

-					$this->array_options["options_".$key] = $value;

-					break;

-			 	/*case 'select':	// Not required, we chosed value='0' for undefined values

-             		if ($value=='-1')

-             		{

-             			$this->array_options[$key] = null;

-             		}

-             		break;*/

-				case 'price':

-					$this->array_options["options_".$key] = price2num($this->array_options["options_".$key]);

-					break;

-				case 'date':

-					$this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);

-					break;

-				case 'datetime':

-					$this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);

-					break;

-				case 'link':

-					$param_list=array_keys($attributeParam['options']);

-					// 0 : ObjectName

-					// 1 : classPath

-					$InfoFieldList = explode(":", $param_list[0]);

-					dol_include_once($InfoFieldList[1]);

-					if ($value)

-					{

-						$object = new $InfoFieldList[0]($this->db);

-						$object->fetch(0,$value);

-						$this->array_options["options_".$key]=$object->id;

-					}

-					break;

-			}

-

-			$this->db->begin();

-			$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element."_extrafields SET ".$key."='".$this->db->escape($this->array_options["options_".$key])."'";

-			$sql .= " WHERE fk_object = ".$this->id;

-			$resql = $this->db->query($sql);

-			if (! $resql)

-			{

-				$error++;

-				$this->error=$this->db->lasterror();

-			}

 

-			if (! $error && $trigger)

-			{

-				// Call trigger

-				$this->context=array('extrafieldupdate'=>1);

-				$result=$this->call_trigger($trigger, $userused);

-				if ($result < 0) $error++;

-				// End call trigger

-			}

-

-			if ($error)

-			{

-				dol_syslog(get_class($this) . "::".__METHOD__ . $this->error, LOG_ERR);

-				$this->db->rollback();

-				return -1;

-			}

-			else

-			{

-				$this->db->commit();

-				return 1;

-			}

-		}

-		else return 0;

-	}

-

-

-	/**

-	 * Return HTML string to put an input field into a page

-	 * Code very similar with showInputField of extra fields

-	 *

-	 * @param  array   		$val	       Array of properties for field to show

-	 * @param  string  		$key           Key of attribute

-	 * @param  string  		$value         Preselected value to show (for date type it must be in timestamp format, for amount or price it must be a php numeric value)

-	 * @param  string  		$moreparam     To add more parameters on html input tag

-	 * @param  string  		$keysuffix     Prefix string to add into name and id of field (can be used to avoid duplicate names)

-	 * @param  string  		$keyprefix     Suffix string to add into name and id of field (can be used to avoid duplicate names)

-	 * @param  string|int		$morecss       Value for css to define style/length of field. May also be a numeric.

-	 * @return string

-	 */

-	function showInputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $morecss=0)

-	{

-		global $conf,$langs,$form;

-

-		if (! is_object($form))

-		{

-			require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';

-			$form=new Form($this->db);

-		}

-

-		$val=$this->fields[$key];

-

-		$out='';

-        $type='';

-        $param = array();

-        $param['options']=array();

-        $size =$this->fields[$key]['size'];

-        // Because we work on extrafields

-        if(preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)){

-            $param['options']=array($reg[1].':'.$reg[2]=>'N');

-            $type ='link';

-        } elseif(preg_match('/^link:(.*):(.*)/i', $val['type'], $reg)) {

-            $param['options']=array($reg[1].':'.$reg[2]=>'N');

-            $type ='link';

-        } elseif(preg_match('/^sellist:(.*):(.*):(.*):(.*)/i', $val['type'], $reg)) {

-            $param['options']=array($reg[1].':'.$reg[2].':'.$reg[3].':'.$reg[4]=>'N');

-            $type ='sellist';

-        } elseif(preg_match('/varchar\((\d+)\)/', $val['type'],$reg)) {

-            $param['options']=array();

-            $type ='varchar';

-            $size=$reg[1];

-        } elseif(preg_match('/varchar/', $val['type'])) {

-            $param['options']=array();

-            $type ='varchar';

-        } elseif(is_array($this->fields[$key]['arrayofkeyval'])) {

-            $param['options']=$this->fields[$key]['arrayofkeyval'];

-            $type ='select';

-        } else {

-            $param['options']=array();

-            $type =$this->fields[$key]['type'];

+    /**

+     *      Return list of id of contacts of object

+     *

+     *      @param	string	$source     Source of contact: external (llx_socpeople) or internal (llx_user) or thirdparty (llx_societe)

+     *      @return array				Array of id of contacts (if source=external or internal)

+     * 									Array of id of third parties with at least one contact on object (if source=thirdparty)

+     */

+    function getListContactId($source='external')

+    {

+        $contactAlreadySelected = array();

+        $tab = $this->liste_contact(-1,$source);

+        $num=count($tab);

+        $i = 0;

+        while ($i < $num)

+        {

+            if ($source == 'thirdparty') $contactAlreadySelected[$i] = $tab[$i]['socid'];

+            else  $contactAlreadySelected[$i] = $tab[$i]['id'];

+            $i++;

         }

+        return $contactAlreadySelected;

+    }

 

-		$label=$this->fields[$key]['label'];

-		//$elementtype=$this->fields[$key]['elementtype'];	// Seems not used

-		$default=$this->fields[$key]['default'];

-		$computed=$this->fields[$key]['computed'];

-		$unique=$this->fields[$key]['unique'];

-		$required=$this->fields[$key]['required'];

 

-		$langfile=$this->fields[$key]['langfile'];

-		$list=$this->fields[$key]['list'];

-		$hidden=abs($this->fields[$key]['visible'])!=1?1:0;

+    /**

+     *	Link element with a project

+     *

+     *	@param     	int		$projectid		Project id to link element to

+     *	@return		int						<0 if KO, >0 if OK

+     */

+    function setProject($projectid)

+    {

+        if (! $this->table_element)

+        {

+            dol_syslog(get_class($this)."::setProject was called on objet with property table_element not defined",LOG_ERR);

+            return -1;

+        }

 

-		$objectid = $this->id;

+        $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+        if ($this->table_element == 'actioncomm')

+        {

+            if ($projectid) $sql.= ' SET fk_project = '.$projectid;

+            else $sql.= ' SET fk_project = NULL';

+            $sql.= ' WHERE id = '.$this->id;

+        }

+        else

+        {

+            if ($projectid) $sql.= ' SET fk_projet = '.$projectid;

+            else $sql.= ' SET fk_projet = NULL';

+            $sql.= ' WHERE rowid = '.$this->id;

+        }

 

+        dol_syslog(get_class($this)."::setProject", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            $this->fk_project = $projectid;

+            return 1;

+        }

+        else

+        {

+            dol_print_error($this->db);

+            return -1;

+        }

+    }

 

-		if ($computed)

-		{

-			if (! preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';

-			else return '';

-		}

+    /**

+     *  Change the payments methods

+     *

+     *  @param		int		$id		Id of new payment method

+     *  @return		int				>0 if OK, <0 if KO

+     */

+    function setPaymentMethods($id)

+    {

+        dol_syslog(get_class($this).'::setPaymentMethods('.$id.')');

+        if ($this->statut >= 0 || $this->element == 'societe')

+        {

+            // TODO uniformize field name

+            $fieldname = 'fk_mode_reglement';

+            if ($this->element == 'societe') $fieldname = 'mode_reglement';

+            if (get_class($this) == 'Fournisseur') $fieldname = 'mode_reglement_supplier';

 

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+            $sql .= ' SET '.$fieldname.' = '.$id;

+            $sql .= ' WHERE rowid='.$this->id;

 

-		// Use in priority showsize from parameters, then $val['css'] then autodefine

-		if (empty($morecss) && ! empty($val['css']))

-		{

-			$showsize = $val['css'];

-		}

-		if (empty($morecss))

-		{

-			if ($type == 'date')

-			{

-				$morecss = 'minwidth100imp';

-			}

-			elseif ($type == 'datetime')

-			{

-				$morecss = 'minwidth200imp';

-			}

-			elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

-			{

-				$morecss = 'maxwidth75';

-                        }elseif ($type == 'url')

-			{

-				$morecss='minwidth400';

-			}

-			elseif ($type == 'boolean')

-			{

-				$morecss='';

-			}

-			else

-			{

-				if (round($size) < 12)

-				{

-					$morecss = 'minwidth100';

-				}

-				else if (round($size) <= 48)

-				{

-					$morecss = 'minwidth200';

-				}

-				else

-				{

-					$morecss = 'minwidth400';

-				}

-			}

-		}

-

-		if (in_array($type,array('date','datetime')))

-		{

-			$tmp=explode(',',$size);

-			$newsize=$tmp[0];

-

-			$showtime = in_array($type,array('datetime')) ? 1 : 0;

-

-			// Do not show current date when field not required (see selectDate() method)

-			if (!$required && $value == '') $value = '-1';

-

-			// TODO Must also support $moreparam

-			$out = $form->selectDate($value, $keyprefix.$key.$keysuffix, $showtime, $showtime, $required, '', 1, (($keyprefix != 'search_' && $keyprefix != 'search_options_') ? 1 : 0), 0, 1);

-		}

-		elseif (in_array($type,array('int','integer')))

-		{

-			$tmp=explode(',',$size);

-			$newsize=$tmp[0];

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

-		}

-		elseif (preg_match('/varchar/', $type))

-		{

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

-		}

-		elseif (in_array($type, array('mail', 'phone', 'url')))

-		{

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'text')

-		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

-			{

-				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

-				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,false,ROWS_5,'90%');

-				$out=$doleditor->Create(1);

-			}

-			else

-			{

-				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

-			}

-		}

-		elseif ($type == 'html')

-		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

-			{

-				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

-				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,! empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE,ROWS_5,'90%');

-				$out=$doleditor->Create(1);

-			}

-			else

-			{

-				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

-			}

-		}

-		elseif ($type == 'boolean')

-		{

-			$checked='';

-			if (!empty($value)) {

-				$checked=' checked value="1" ';

-			} else {

-				$checked=' value="1" ';

-			}

-			$out='<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'price')

-		{

-			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

-				$value=price($value);

-			}

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> '.$langs->getCurrencySymbol($conf->currency);

-		}

-		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

-		{

-			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

-				$value=price($value);

-			}

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> ';

-		}

-		elseif ($type == 'select')

-		{

-			$out = '';

-			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

-			{

-				include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

-				$out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

-			}

+            if ($this->db->query($sql))

+            {

+                $this->mode_reglement_id = $id;

+                // for supplier

+                if (get_class($this) == 'Fournisseur') $this->mode_reglement_supplier_id = $id;

+                return 1;

+            }

+            else

+            {

+                dol_syslog(get_class($this).'::setPaymentMethods Erreur '.$sql.' - '.$this->db->error());

+                $this->error=$this->db->error();

+                return -1;

+            }

+        }

+        else

+        {

+            dol_syslog(get_class($this).'::setPaymentMethods, status of the object is incompatible');

+            $this->error='Status of the object is incompatible '.$this->statut;

+            return -2;

+        }

+    }

 

-			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

-                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1))$out.='<option value="0">&nbsp;</option>';

-			foreach ($param['options'] as $key => $val)

-			{

-				if ((string) $key == '') continue;

-				list($val, $parent) = explode('|', $val);

-				$out.='<option value="'.$key.'"';

-				$out.= (((string) $value == (string) $key)?' selected':'');

-				$out.= (!empty($parent)?' parent="'.$parent.'"':'');

-				$out.='>'.$val.'</option>';

-			}

-			$out.='</select>';

-		}

-		elseif ($type == 'sellist')

-		{

-			$out = '';

-			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

-			{

-				include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

-				$out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

-			}

+    /**

+     *  Change the multicurrency code

+     *

+     *  @param		string	$code	multicurrency code

+     *  @return		int				>0 if OK, <0 if KO

+     */

+    function setMulticurrencyCode($code)

+    {

+        dol_syslog(get_class($this).'::setMulticurrencyCode('.$id.')');

+        if ($this->statut >= 0 || $this->element == 'societe')

+        {

+            $fieldname = 'multicurrency_code';

 

-			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

-			if (is_array($param['options']))

-			{

-				$param_list=array_keys($param['options']);

-				$InfoFieldList = explode(":", $param_list[0]);

-				$parentName='';

-				$parentField='';

-				// 0 : tableName

-				// 1 : label field name

-				// 2 : key fields name (if differ of rowid)

-				// 3 : key field parent (for dependent lists)

-				// 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value

-				$keyList=(empty($InfoFieldList[2])?'rowid':$InfoFieldList[2].' as rowid');

-

-

-				if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4]))

-				{

-					if (strpos($InfoFieldList[4], 'extra.') !== false)

-					{

-						$keyList='main.'.$InfoFieldList[2].' as rowid';

-					} else {

-						$keyList=$InfoFieldList[2].' as rowid';

-					}

-				}

-				if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3]))

-				{

-					list($parentName, $parentField) = explode('|', $InfoFieldList[3]);

-					$keyList.= ', '.$parentField;

-				}

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+            $sql .= ' SET '.$fieldname." = '".$this->db->escape($code)."'";

+            $sql .= ' WHERE rowid='.$this->id;

 

-				$fields_label = explode('|',$InfoFieldList[1]);

-				if (is_array($fields_label))

-				{

-					$keyList .=', ';

-					$keyList .= implode(', ', $fields_label);

-				}

+            if ($this->db->query($sql))

+            {

+                $this->multicurrency_code = $code;

 

-				$sqlwhere='';

-				$sql = 'SELECT '.$keyList;

-				$sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];

-				if (!empty($InfoFieldList[4]))

-				{

-					// can use SELECT request

-					if (strpos($InfoFieldList[4], '$SEL$')!==false) {

-						$InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);

-					}

-

-					// current object id can be use into filter

-					if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {

-						$InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);

-					} else {

-						$InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);

-					}

-					//We have to join on extrafield table

-					if (strpos($InfoFieldList[4], 'extra')!==false)

-					{

-						$sql.= ' as main, '.MAIN_DB_PREFIX .$InfoFieldList[0].'_extrafields as extra';

-						$sqlwhere.= ' WHERE extra.fk_object=main.'.$InfoFieldList[2]. ' AND '.$InfoFieldList[4];

-					}

-					else

-					{

-						$sqlwhere.= ' WHERE '.$InfoFieldList[4];

-					}

-				}

-				else

-				{

-					$sqlwhere.= ' WHERE 1=1';

-				}

-				// Some tables may have field, some other not. For the moment we disable it.

-				if (in_array($InfoFieldList[0],array('tablewithentity')))

-				{

-					$sqlwhere.= ' AND entity = '.$conf->entity;

-				}

-				$sql.=$sqlwhere;

-				//print $sql;

+                list($fk_multicurrency, $rate) = MultiCurrency::getIdAndTxFromCode($this->db, $code);

+                if ($rate) $this->setMulticurrencyRate($rate,2);

 

-				$sql .= ' ORDER BY ' . implode(', ', $fields_label);

+                return 1;

+            }

+            else

+            {

+                dol_syslog(get_class($this).'::setMulticurrencyCode Erreur '.$sql.' - '.$this->db->error());

+                $this->error=$this->db->error();

+                return -1;

+            }

+        }

+        else

+        {

+            dol_syslog(get_class($this).'::setMulticurrencyCode, status of the object is incompatible');

+            $this->error='Status of the object is incompatible '.$this->statut;

+            return -2;

+        }

+    }

 

-				dol_syslog(get_class($this).'::showInputField type=sellist', LOG_DEBUG);

-				$resql = $this->db->query($sql);

-				if ($resql)

-				{

-					$out.='<option value="0">&nbsp;</option>';

-					$num = $this->db->num_rows($resql);

-					$i = 0;

-					while ($i < $num)

-					{

-						$labeltoshow='';

-						$obj = $this->db->fetch_object($resql);

-

-						// Several field into label (eq table:code|libelle:rowid)

-						$notrans = false;

-						$fields_label = explode('|',$InfoFieldList[1]);

-						if (is_array($fields_label))

-						{

-							$notrans = true;

-							foreach ($fields_label as $field_toshow)

-							{

-								$labeltoshow.= $obj->$field_toshow.' ';

-							}

-						}

-						else

-						{

-							$labeltoshow=$obj->{$InfoFieldList[1]};

-						}

-						$labeltoshow=dol_trunc($labeltoshow,45);

-

-						if ($value == $obj->rowid)

-						{

-							foreach ($fields_label as $field_toshow)

-							{

-								$translabel=$langs->trans($obj->$field_toshow);

-								if ($translabel!=$obj->$field_toshow) {

-									$labeltoshow=dol_trunc($translabel,18).' ';

-								}else {

-									$labeltoshow=dol_trunc($obj->$field_toshow,18).' ';

-								}

-							}

-							$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

-						}

-						else

-						{

-							if (! $notrans)

-							{

-								$translabel=$langs->trans($obj->{$InfoFieldList[1]});

-								if ($translabel!=$obj->{$InfoFieldList[1]}) {

-									$labeltoshow=dol_trunc($translabel,18);

-								}

-								else {

-									$labeltoshow=dol_trunc($obj->{$InfoFieldList[1]},18);

-								}

-							}

-							if (empty($labeltoshow)) $labeltoshow='(not defined)';

-							if ($value==$obj->rowid)

-							{

-								$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

-							}

+    /**

+     *  Change the multicurrency rate

+     *

+     *  @param		double	$rate	multicurrency rate

+     *  @param		int		$mode	mode 1 : amounts in company currency will be recalculated, mode 2 : amounts in foreign currency

+     *  @return		int				>0 if OK, <0 if KO

+     */

+    function setMulticurrencyRate($rate, $mode=1)

+    {

+        dol_syslog(get_class($this).'::setMulticurrencyRate('.$id.')');

+        if ($this->statut >= 0 || $this->element == 'societe')

+        {

+            $fieldname = 'multicurrency_tx';

 

-							if (!empty($InfoFieldList[3]) && $parentField)

-							{

-								$parent = $parentName.':'.$obj->{$parentField};

-							}

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+            $sql .= ' SET '.$fieldname.' = '.$rate;

+            $sql .= ' WHERE rowid='.$this->id;

 

-							$out.='<option value="'.$obj->rowid.'"';

-							$out.= ($value==$obj->rowid?' selected':'');

-							$out.= (!empty($parent)?' parent="'.$parent.'"':'');

-							$out.='>'.$labeltoshow.'</option>';

-						}

+            if ($this->db->query($sql))

+            {

+                $this->multicurrency_tx = $rate;

+

+                // Update line price

+                if (!empty($this->lines))

+                {

+                    foreach ($this->lines as &$line)

+                    {

+                        if($mode == 1) {

+                            $line->subprice = 0;

+                        }

+

+                        switch ($this->element) {

+                            case 'propal':

+                                $this->updateline(

+                                    $line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,

+                                    ($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

+                                    $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->date_start,

+                                    $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

+                                );

+                                break;

+                            case 'commande':

+                                $this->updateline(

+                                    $line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

+                                    $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->date_start, $line->date_end,

+                                    $line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,

+                                    $line->special_code, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

+                                );

+                                break;

+                            case 'facture':

+                                $this->updateline(

+                                    $line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

+                                    $line->date_start, $line->date_end, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits,

+                                    $line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,

+                                    $line->special_code, $line->array_options, $line->situation_percent, $line->fk_unit, $line->multicurrency_subprice

+                                );

+                                break;

+                            case 'supplier_proposal':

+                                $this->updateline(

+                                    $line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,

+                                    ($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

+                                    $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->array_options,

+                                    $line->ref_fourn, $line->multicurrency_subprice

+                                );

+                                break;

+                            case 'order_supplier':

+                                $this->updateline(

+                                    $line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

+                                    $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->product_type, false,

+                                    $line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

+                                );

+                                break;

+                            case 'invoice_supplier':

+                                $this->updateline(

+                                    $line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->tva_tx, $line->localtax1_tx,

+                                    $line->localtax2_tx, $line->qty, 0, 'HT', $line->info_bits, $line->product_type, $line->remise_percent, false,

+                                    $line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

+                                );

+                                break;

+                            default:

+                                dol_syslog(get_class($this).'::setMulticurrencyRate no updateline defined', LOG_DEBUG);

+                                break;

+                        }

+                    }

+                }

+

+                return 1;

+            }

+            else

+            {

+                dol_syslog(get_class($this).'::setMulticurrencyRate Erreur '.$sql.' - '.$this->db->error());

+                $this->error=$this->db->error();

+                return -1;

+            }

+        }

+        else

+        {

+            dol_syslog(get_class($this).'::setMulticurrencyRate, status of the object is incompatible');

+            $this->error='Status of the object is incompatible '.$this->statut;

+            return -2;

+        }

+    }

 

-						$i++;

-					}

-					$this->db->free($resql);

-				}

-				else {

-					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';

-				}

-			}

-			$out.='</select>';

-		}

-		elseif ($type == 'checkbox')

-		{

-			$value_arr=explode(',',$value);

-			$out=$form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options'])?null:$param['options']), $value_arr, '', 0, '', 0, '100%');

-		}

-		elseif ($type == 'radio')

-		{

-			$out='';

-			foreach ($param['options'] as $keyopt => $val)

-			{

-				$out.='<input class="flat '.$morecss.'" type="radio" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'');

-				$out.=' value="'.$keyopt.'"';

-				$out.=' id="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'"';

-				$out.= ($value==$keyopt?'checked':'');

-				$out.='/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';

-			}

-		}

-		elseif ($type == 'chkbxlst')

-		{

-			if (is_array($value)) {

-				$value_arr = $value;

-			}

-			else {

-				$value_arr = explode(',', $value);

-			}

-

-			if (is_array($param['options'])) {

-				$param_list = array_keys($param['options']);

-				$InfoFieldList = explode(":", $param_list[0]);

-				$parentName='';

-				$parentField='';

-				// 0 : tableName

-				// 1 : label field name

-				// 2 : key fields name (if differ of rowid)

-				// 3 : key field parent (for dependent lists)

-				// 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value

-				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2] . ' as rowid');

-

-				if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3])) {

-					list ( $parentName, $parentField ) = explode('|', $InfoFieldList[3]);

-					$keyList .= ', ' . $parentField;

-				}

-				if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4])) {

-					if (strpos($InfoFieldList[4], 'extra.') !== false) {

-						$keyList = 'main.' . $InfoFieldList[2] . ' as rowid';

-					} else {

-						$keyList = $InfoFieldList[2] . ' as rowid';

-					}

-				}

+    /**

+     *  Change the payments terms

+     *

+     *  @param		int		$id		Id of new payment terms

+     *  @return		int				>0 if OK, <0 if KO

+     */

+    function setPaymentTerms($id)

+    {

+        dol_syslog(get_class($this).'::setPaymentTerms('.$id.')');

+        if ($this->statut >= 0 || $this->element == 'societe')

+        {

+            // TODO uniformize field name

+            $fieldname = 'fk_cond_reglement';

+            if ($this->element == 'societe') $fieldname = 'cond_reglement';

+            if (get_class($this) == 'Fournisseur') $fieldname = 'cond_reglement_supplier';

+

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+            $sql .= ' SET '.$fieldname.' = '.$id;

+            $sql .= ' WHERE rowid='.$this->id;

+

+            if ($this->db->query($sql))

+            {

+                $this->cond_reglement_id = $id;

+                // for supplier

+                if (get_class($this) == 'Fournisseur') $this->cond_reglement_supplier_id = $id;

+                $this->cond_reglement = $id;	// for compatibility

+                return 1;

+            }

+            else

+            {

+                dol_syslog(get_class($this).'::setPaymentTerms Erreur '.$sql.' - '.$this->db->error());

+                $this->error=$this->db->error();

+                return -1;

+            }

+        }

+        else

+        {

+            dol_syslog(get_class($this).'::setPaymentTerms, status of the object is incompatible');

+            $this->error='Status of the object is incompatible '.$this->statut;

+            return -2;

+        }

+    }

+

+    /**

+     *	Define delivery address

+     *  @deprecated

+     *

+     *	@param      int		$id		Address id

+     *	@return     int				<0 si ko, >0 si ok

+     */

+    function setDeliveryAddress($id)

+    {

+        $fieldname = 'fk_delivery_address';

+        if ($this->element == 'delivery' || $this->element == 'shipping') $fieldname = 'fk_address';

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element." SET ".$fieldname." = ".$id;

+        $sql.= " WHERE rowid = ".$this->id." AND fk_statut = 0";

+

+        if ($this->db->query($sql))

+        {

+            $this->fk_delivery_address = $id;

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->error();

+            dol_syslog(get_class($this).'::setDeliveryAddress Erreur '.$sql.' - '.$this->error);

+            return -1;

+        }

+    }

+

+

+    /**

+     *  Change the shipping method

+     *

+     *  @param      int     $shipping_method_id     Id of shipping method

+     *  @param      bool    $notrigger              false=launch triggers after, true=disable triggers

+     *  @param      User	$userused               Object user

+     *

+     *  @return     int              1 if OK, 0 if KO

+     */

+    function setShippingMethod($shipping_method_id, $notrigger=false, $userused=null)

+    {

+        global $user;

+

+        if (empty($userused)) $userused=$user;

+

+        $error = 0;

+

+        if (! $this->table_element) {

+            dol_syslog(get_class($this)."::setShippingMethod was called on objet with property table_element not defined",LOG_ERR);

+            return -1;

+        }

+

+        $this->db->begin();

+

+        if ($shipping_method_id<0) $shipping_method_id='NULL';

+        dol_syslog(get_class($this).'::setShippingMethod('.$shipping_method_id.')');

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET fk_shipping_method = ".$shipping_method_id;

+        $sql.= " WHERE rowid=".$this->id;

+        $resql = $this->db->query($sql);

+        if (! $resql) {

+            dol_syslog(get_class($this).'::setShippingMethod Error ', LOG_DEBUG);

+            $this->error = $this->db->lasterror();

+            $error++;

+        } else {

+            if (!$notrigger)

+            {

+                // Call trigger

+                $this->context=array('shippingmethodupdate'=>1);

+                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

+                if ($result < 0) $error++;

+                // End call trigger

+            }

+        }

+        if ($error)

+        {

+            $this->db->rollback();

+            return -1;

+        } else {

+            $this->shipping_method_id = ($shipping_method_id=='NULL')?null:$shipping_method_id;

+            $this->db->commit();

+            return 1;

+        }

+    }

+

+

+    /**

+     *  Change the warehouse

+     *

+     *  @param      int     $warehouse_id     Id of warehouse

+     *  @return     int              1 if OK, 0 if KO

+     */

+    function setWarehouse($warehouse_id)

+    {

+        if (! $this->table_element) {

+            dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined",LOG_ERR);

+            return -1;

+        }

+        if ($warehouse_id<0) $warehouse_id='NULL';

+        dol_syslog(get_class($this).'::setWarehouse('.$warehouse_id.')');

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET fk_warehouse = ".$warehouse_id;

+        $sql.= " WHERE rowid=".$this->id;

+

+        if ($this->db->query($sql)) {

+            $this->warehouse_id = ($warehouse_id=='NULL')?null:$warehouse_id;

+            return 1;

+        } else {

+            dol_syslog(get_class($this).'::setWarehouse Error ', LOG_DEBUG);

+            $this->error=$this->db->error();

+            return 0;

+        }

+    }

+

+

+    /**

+     *		Set last model used by doc generator

+     *

+     *		@param		User	$user		User object that make change

+     *		@param		string	$modelpdf	Modele name

+     *		@return		int					<0 if KO, >0 if OK

+     */

+    function setDocModel($user, $modelpdf)

+    {

+        if (! $this->table_element)

+        {

+            dol_syslog(get_class($this)."::setDocModel was called on objet with property table_element not defined",LOG_ERR);

+            return -1;

+        }

+

+        $newmodelpdf=dol_trunc($modelpdf,255);

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET model_pdf = '".$this->db->escape($newmodelpdf)."'";

+        $sql.= " WHERE rowid = ".$this->id;

+        // if ($this->element == 'facture') $sql.= " AND fk_statut < 2";

+        // if ($this->element == 'propal')  $sql.= " AND fk_statut = 0";

+

+        dol_syslog(get_class($this)."::setDocModel", LOG_DEBUG);

+        $resql=$this->db->query($sql);

+        if ($resql)

+        {

+            $this->modelpdf=$modelpdf;

+            return 1;

+        }

+        else

+        {

+            dol_print_error($this->db);

+            return 0;

+        }

+    }

+

+

+    /**

+     *  Change the bank account

+     *

+     *  @param		int		$fk_account		Id of bank account

+     *  @param      bool    $notrigger      false=launch triggers after, true=disable triggers

+     *  @param      User	$userused		Object user

+     *  @return		int				1 if OK, 0 if KO

+     */

+    function setBankAccount($fk_account, $notrigger=false, $userused=null)

+    {

+        global $user;

+

+        if (empty($userused)) $userused=$user;

+

+        $error = 0;

+

+        if (! $this->table_element) {

+            dol_syslog(get_class($this)."::setBankAccount was called on objet with property table_element not defined",LOG_ERR);

+            return -1;

+        }

+        $this->db->begin();

+

+        if ($fk_account<0) $fk_account='NULL';

+        dol_syslog(get_class($this).'::setBankAccount('.$fk_account.')');

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET fk_account = ".$fk_account;

+        $sql.= " WHERE rowid=".$this->id;

+

+        $resql = $this->db->query($sql);

+        if (! $resql)

+        {

+            dol_syslog(get_class($this).'::setBankAccount Error '.$sql.' - '.$this->db->error());

+            $this->error = $this->db->lasterror();

+            $error++;

+        }

+        else

+        {

+            if (!$notrigger)

+            {

+                // Call trigger

+                $this->context=array('bankaccountupdate'=>1);

+                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

+                if ($result < 0) $error++;

+                // End call trigger

+            }

+        }

+        if ($error)

+        {

+            $this->db->rollback();

+            return -1;

+        }

+        else

+        {

+            $this->fk_account = ($fk_account=='NULL')?null:$fk_account;

+            $this->db->commit();

+            return 1;

+        }

+    }

+

+

+    // TODO: Move line related operations to CommonObjectLine?

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *  Save a new position (field rang) for details lines.

+     *  You can choose to set position for lines with already a position or lines without any position defined.

+     *

+     * 	@param		boolean		$renum			   True to renum all already ordered lines, false to renum only not already ordered lines.

+     * 	@param		string		$rowidorder		   ASC or DESC

+     * 	@param		boolean		$fk_parent_line    Table with fk_parent_line field or not

+     * 	@return		int                            <0 if KO, >0 if OK

+     */

+    function line_order($renum=false, $rowidorder='ASC', $fk_parent_line=true)

+    {

+        // phpcs:enable

+        if (! $this->table_element_line)

+        {

+            dol_syslog(get_class($this)."::line_order was called on objet with property table_element_line not defined",LOG_ERR);

+            return -1;

+        }

+        if (! $this->fk_element)

+        {

+            dol_syslog(get_class($this)."::line_order was called on objet with property fk_element not defined",LOG_ERR);

+            return -1;

+        }

+

+        // Count number of lines to reorder (according to choice $renum)

+        $nl=0;

+        $sql = 'SELECT count(rowid) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+        $sql.= ' WHERE '.$this->fk_element.'='.$this->id;

+        if (! $renum) $sql.= ' AND rang = 0';

+        if ($renum) $sql.= ' AND rang <> 0';

+

+        dol_syslog(get_class($this)."::line_order", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $row = $this->db->fetch_row($resql);

+            $nl = $row[0];

+        }

+        else dol_print_error($this->db);

+        if ($nl > 0)

+        {

+            // The goal of this part is to reorder all lines, with all children lines sharing the same

+            // counter that parents.

+            $rows=array();

+

+            // We first search all lines that are parent lines (for multilevel details lines)

+            $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+            $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+            if ($fk_parent_line) $sql.= ' AND fk_parent_line IS NULL';

+            $sql.= ' ORDER BY rang ASC, rowid '.$rowidorder;

+

+            dol_syslog(get_class($this)."::line_order search all parent lines", LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if ($resql)

+            {

+                $i=0;

+                $num = $this->db->num_rows($resql);

+                while ($i < $num)

+                {

+                    $row = $this->db->fetch_row($resql);

+                    $rows[] = $row[0];	// Add parent line into array rows

+                    $childrens = $this->getChildrenOfLine($row[0]);

+                    if (! empty($childrens))

+                    {

+                        foreach($childrens as $child)

+                        {

+                            array_push($rows, $child);

+                        }

+                    }

+                    $i++;

+                }

+

+                // Now we set a new number for each lines (parent and children with children included into parent tree)

+                if (! empty($rows))

+                {

+                    foreach($rows as $key => $row)

+                    {

+                        $this->updateRangOfLine($row, ($key+1));

+                    }

+                }

+            }

+            else

+            {

+                dol_print_error($this->db);

+            }

+        }

+        return 1;

+    }

+

+    /**

+     * 	Get children of line

+     *

+     * 	@param	int		$id		Id of parent line

+     * 	@return	array			Array with list of children lines id

+     */

+    function getChildrenOfLine($id)

+    {

+        $rows=array();

+

+        $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+        $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+        $sql.= ' AND fk_parent_line = '.$id;

+        $sql.= ' ORDER BY rang ASC';

+

+        dol_syslog(get_class($this)."::getChildrenOfLine search children lines for line ".$id."", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $i=0;

+            $num = $this->db->num_rows($resql);

+            while ($i < $num)

+            {

+                $row = $this->db->fetch_row($resql);

+                $rows[$i] = $row[0];

+                $i++;

+            }

+        }

+

+        return $rows;

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     * 	Update a line to have a lower rank

+     *

+     * 	@param 	int			$rowid				Id of line

+     * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not

+     * 	@return	void

+     */

+    function line_up($rowid, $fk_parent_line=true)

+    {

+        // phpcs:enable

+        $this->line_order(false, 'ASC', $fk_parent_line);

+

+        // Get rang of line

+        $rang = $this->getRangOfLine($rowid);

+

+        // Update position of line

+        $this->updateLineUp($rowid, $rang);

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     * 	Update a line to have a higher rank

+     *

+     * 	@param	int			$rowid				Id of line

+     * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not

+     * 	@return	void

+     */

+    function line_down($rowid, $fk_parent_line=true)

+    {

+        // phpcs:enable

+        $this->line_order(false, 'ASC', $fk_parent_line);

+

+        // Get rang of line

+        $rang = $this->getRangOfLine($rowid);

+

+        // Get max value for rang

+        $max = $this->line_max();

+

+        // Update position of line

+        $this->updateLineDown($rowid, $rang, $max);

+    }

+

+    /**

+     * 	Update position of line (rang)

+     *

+     * 	@param	int		$rowid		Id of line

+     * 	@param	int		$rang		Position

+     * 	@return	void

+     */

+    function updateRangOfLine($rowid,$rang)

+    {

+        $fieldposition = 'rang';

+        if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+

+        $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

+        $sql.= ' WHERE rowid = '.$rowid;

+

+        dol_syslog(get_class($this)."::updateRangOfLine", LOG_DEBUG);

+        if (! $this->db->query($sql))

+        {

+            dol_print_error($this->db);

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     * 	Update position of line with ajax (rang)

+     *

+     * 	@param	array	$rows	Array of rows

+     * 	@return	void

+     */

+    function line_ajaxorder($rows)

+    {

+        // phpcs:enable

+        $num = count($rows);

+        for ($i = 0 ; $i < $num ; $i++)

+        {

+            $this->updateRangOfLine($rows[$i], ($i+1));

+        }

+    }

+

+    /**

+     * 	Update position of line up (rang)

+     *

+     * 	@param	int		$rowid		Id of line

+     * 	@param	int		$rang		Position

+     * 	@return	void

+     */

+    function updateLineUp($rowid,$rang)

+    {

+        if ($rang > 1)

+        {

+            $fieldposition = 'rang';

+            if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang ;

+            $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+            $sql.= ' AND rang = '.($rang - 1);

+            if ($this->db->query($sql) )

+            {

+                $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang - 1);

+                $sql.= ' WHERE rowid = '.$rowid;

+                if (! $this->db->query($sql) )

+                {

+                    dol_print_error($this->db);

+                }

+            }

+            else

+            {

+                dol_print_error($this->db);

+            }

+        }

+    }

+

+    /**

+     * 	Update position of line down (rang)

+     *

+     * 	@param	int		$rowid		Id of line

+     * 	@param	int		$rang		Position

+     * 	@param	int		$max		Max

+     * 	@return	void

+     */

+    function updateLineDown($rowid,$rang,$max)

+    {

+        if ($rang < $max)

+        {

+            $fieldposition = 'rang';

+            if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

+            $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+            $sql.= ' AND rang = '.($rang+1);

+            if ($this->db->query($sql) )

+            {

+                $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang+1);

+                $sql.= ' WHERE rowid = '.$rowid;

+                if (! $this->db->query($sql) )

+                {

+                    dol_print_error($this->db);

+                }

+            }

+            else

+            {

+                dol_print_error($this->db);

+            }

+        }

+    }

+

+    /**

+     * 	Get position of line (rang)

+     *

+     * 	@param		int		$rowid		Id of line

+     *  @return		int     			Value of rang in table of lines

+     */

+    function getRangOfLine($rowid)

+    {

+        $sql = 'SELECT rang FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+        $sql.= ' WHERE rowid ='.$rowid;

+

+        dol_syslog(get_class($this)."::getRangOfLine", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $row = $this->db->fetch_row($resql);

+            return $row[0];

+        }

+    }

+

+    /**

+     * 	Get rowid of the line relative to its position

+     *

+     * 	@param		int		$rang		Rang value

+     *  @return     int     			Rowid of the line

+     */

+    function getIdOfLine($rang)

+    {

+        $sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+        $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+        $sql.= ' AND rang = '.$rang;

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $row = $this->db->fetch_row($resql);

+            return $row[0];

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     * 	Get max value used for position of line (rang)

+     *

+     * 	@param		int		$fk_parent_line		Parent line id

+     *  @return     int  			   			Max value of rang in table of lines

+     */

+    function line_max($fk_parent_line=0)

+    {

+        // phpcs:enable

+        // Search the last rang with fk_parent_line

+        if ($fk_parent_line)

+        {

+            $sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+            $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+            $sql.= ' AND fk_parent_line = '.$fk_parent_line;

+

+            dol_syslog(get_class($this)."::line_max", LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if ($resql)

+            {

+                $row = $this->db->fetch_row($resql);

+                if (! empty($row[0]))

+                {

+                    return $row[0];

+                }

+                else

+                {

+                    return $this->getRangOfLine($fk_parent_line);

+                }

+            }

+        }

+        // If not, search the last rang of element

+        else

+        {

+            $sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+            $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+

+            dol_syslog(get_class($this)."::line_max", LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if ($resql)

+            {

+                $row = $this->db->fetch_row($resql);

+                return $row[0];

+            }

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *  Update external ref of element

+     *

+     *  @param      string		$ref_ext	Update field ref_ext

+     *  @return     int      		   		<0 if KO, >0 if OK

+     */

+    function update_ref_ext($ref_ext)

+    {

+        // phpcs:enable

+        if (! $this->table_element)

+        {

+            dol_syslog(get_class($this)."::update_ref_ext was called on objet with property table_element not defined", LOG_ERR);

+            return -1;

+        }

+

+        $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET ref_ext = '".$this->db->escape($ref_ext)."'";

+        $sql.= " WHERE ".(isset($this->table_rowid)?$this->table_rowid:'rowid')." = ". $this->id;

+

+        dol_syslog(get_class($this)."::update_ref_ext", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            $this->ref_ext = $ref_ext;

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->error();

+            return -1;

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *  Update note of element

+     *

+     *  @param      string		$note		New value for note

+     *  @param		string		$suffix		'', '_public' or '_private'

+     *  @return     int      		   		<0 if KO, >0 if OK

+     */

+    function update_note($note, $suffix='')

+    {

+        // phpcs:enable

+        global $user;

+

+        if (! $this->table_element)

+        {

+            $this->error='update_note was called on objet with property table_element not defined';

+            dol_syslog(get_class($this)."::update_note was called on objet with property table_element not defined", LOG_ERR);

+            return -1;

+        }

+        if (! in_array($suffix,array('','_public','_private')))

+        {

+            $this->error='update_note Parameter suffix must be empty, \'_private\' or \'_public\'';

+            dol_syslog(get_class($this)."::update_note Parameter suffix must be empty, '_private' or '_public'", LOG_ERR);

+            return -2;

+        }

+        // Special cas

+        //var_dump($this->table_element);exit;

+        if ($this->table_element == 'product') $suffix='';

+

+        $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET note".$suffix." = ".(!empty($note)?("'".$this->db->escape($note)."'"):"NULL");

+        $sql.= " ,".(in_array($this->table_element, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))?"fk_user_mod":"fk_user_modif")." = ".$user->id;

+        $sql.= " WHERE rowid =". $this->id;

+

+        dol_syslog(get_class($this)."::update_note", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            if ($suffix == '_public') $this->note_public = $note;

+            else if ($suffix == '_private') $this->note_private = $note;

+            else

+            {

+                $this->note = $note;      // deprecated

+                $this->note_private = $note;

+            }

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            return -1;

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     * 	Update public note (kept for backward compatibility)

+     *

+     * @param      string		$note		New value for note

+     * @return     int      		   		<0 if KO, >0 if OK

+     * @deprecated

+     * @see update_note()

+     */

+    function update_note_public($note)

+    {

+        // phpcs:enable

+        return $this->update_note($note,'_public');

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *	Update total_ht, total_ttc, total_vat, total_localtax1, total_localtax2 for an object (sum of lines).

+     *  Must be called at end of methods addline or updateline.

+     *

+     *	@param	int		$exclspec          	>0 = Exclude special product (product_type=9)

+     *  @param  string	$roundingadjust    	'none'=Do nothing, 'auto'=Use default method (MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND if defined, or '0'), '0'=Force mode total of rounding, '1'=Force mode rounding of total

+     *  @param	int		$nodatabaseupdate	1=Do not update database. Update only properties of object.

+     *  @param	Societe	$seller				If roundingadjust is '0' or '1' or maybe 'auto', it means we recalculate total for lines before calculating total for object and for this, we need seller object.

+     *	@return	int    			           	<0 if KO, >0 if OK

+     */

+    function update_price($exclspec=0,$roundingadjust='none',$nodatabaseupdate=0,$seller=null)

+    {

+        // phpcs:enable

+        global $conf, $hookmanager, $action;

+

+        // Some external module want no update price after a trigger because they have another method to calculate the total (ex: with an extrafield)

+        $MODULE = "";

+        if ($this->element == 'propal')

+            $MODULE = "MODULE_DISALLOW_UPDATE_PRICE_PROPOSAL";

+        elseif ($this->element == 'order')

+            $MODULE = "MODULE_DISALLOW_UPDATE_PRICE_ORDER";

+        elseif ($this->element == 'facture')

+            $MODULE = "MODULE_DISALLOW_UPDATE_PRICE_INVOICE";

+        elseif ($this->element == 'facture_fourn')

+            $MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_INVOICE";

+        elseif ($this->element == 'order_supplier')

+            $MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_ORDER";

+        elseif ($this->element == 'supplier_proposal')

+            $MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";

+

+        if (! empty($MODULE)) {

+            if (! empty($conf->global->$MODULE)) {

+                $modsactivated = explode(',', $conf->global->$MODULE);

+                foreach ($modsactivated as $mod) {

+                    if ($conf->$mod->enabled)

+                        return 1; // update was disabled by specific setup

+                }

+            }

+        }

+

+        include_once DOL_DOCUMENT_ROOT.'/core/lib/price.lib.php';

+

+        if ($roundingadjust == '-1') $roundingadjust='auto';	// For backward compatibility

+

+        $forcedroundingmode=$roundingadjust;

+        if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode=$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;

+        elseif ($forcedroundingmode == 'auto') $forcedroundingmode='0';

+

+        $error=0;

+

+        $multicurrency_tx = !empty($this->multicurrency_tx) ? $this->multicurrency_tx : 1;

+

+        // Define constants to find lines to sum

+        $fieldtva='total_tva';

+        $fieldlocaltax1='total_localtax1';

+        $fieldlocaltax2='total_localtax2';

+        $fieldup='subprice';

+        if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier')

+        {

+            $fieldtva='tva';

+            $fieldup='pu_ht';

+        }

+        if ($this->element == 'expensereport')

+        {

+            $fieldup='value_unit';

+        }

+

+        $sql = 'SELECT rowid, qty, '.$fieldup.' as up, remise_percent, total_ht, '.$fieldtva.' as total_tva, total_ttc, '.$fieldlocaltax1.' as total_localtax1, '.$fieldlocaltax2.' as total_localtax2,';

+        $sql.= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';

+            if ($this->table_element_line == 'facturedet') $sql.= ', situation_percent';

+            $sql.= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';

+        $sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+        $sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+        if ($exclspec)

+        {

+            $product_field='product_type';

+            if ($this->table_element_line == 'contratdet') $product_field='';    // contratdet table has no product_type field

+            if ($product_field) $sql.= ' AND '.$product_field.' <> 9';

+        }

+        $sql.= ' ORDER by rowid';	// We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used

+

+        dol_syslog(get_class($this)."::update_price", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $this->total_ht  = 0;

+            $this->total_tva = 0;

+            $this->total_localtax1 = 0;

+            $this->total_localtax2 = 0;

+            $this->total_ttc = 0;

+            $total_ht_by_vats  = array();

+            $total_tva_by_vats = array();

+            $total_ttc_by_vats = array();

+            $this->multicurrency_total_ht	= 0;

+            $this->multicurrency_total_tva	= 0;

+            $this->multicurrency_total_ttc	= 0;

+

+            $num = $this->db->num_rows($resql);

+            $i = 0;

+            while ($i < $num)

+            {

+                $obj = $this->db->fetch_object($resql);

+

+                // Note: There is no check on detail line and no check on total, if $forcedroundingmode = 'none'

+                $parameters=array('fk_element' => $obj->rowid);

+                $reshook = $hookmanager->executeHooks('changeRoundingMode', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

+

+                if (empty($reshook) && $forcedroundingmode == '0')	// Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

+                {

+                    $localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);

+                    $tmpcal=calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);

+                    $diff=price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);

+                    if ($diff)

+                    {

+                        $sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;

+                        dol_syslog('We found unconsistent data into detailed line (difference of '.$diff.') for line rowid = '.$obj->rowid." (total vat of line calculated=".$tmpcal[1].", database=".$obj->total_tva."). We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

+                                $resqlfix=$this->db->query($sqlfix);

+                                if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+                                $obj->total_tva = $tmpcal[1];

+                                $obj->total_ttc = $tmpcal[2];

+                        //

+                    }

+                }

+

+                $this->total_ht        += $obj->total_ht;		// The field visible at end of line detail

+                $this->total_tva       += $obj->total_tva;

+                $this->total_localtax1 += $obj->total_localtax1;

+                $this->total_localtax2 += $obj->total_localtax2;

+                $this->total_ttc       += $obj->total_ttc;

+                $this->multicurrency_total_ht        += $obj->multicurrency_total_ht;		// The field visible at end of line detail

+                $this->multicurrency_total_tva       += $obj->multicurrency_total_tva;

+                $this->multicurrency_total_ttc       += $obj->multicurrency_total_ttc;

+

+                if (! isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate]=0;

+                if (! isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate]=0;

+                if (! isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate]=0;

+                $total_ht_by_vats[$obj->vatrate]  += $obj->total_ht;

+                $total_tva_by_vats[$obj->vatrate] += $obj->total_tva;

+                $total_ttc_by_vats[$obj->vatrate] += $obj->total_ttc;

+

+                if ($forcedroundingmode == '1')	// Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

+                {

+                    $tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);

+                    $diff=price2num($total_tva_by_vats[$obj->vatrate]-$tmpvat, 'MT', 1);

+                    //print 'Line '.$i.' rowid='.$obj->rowid.' vat_rate='.$obj->vatrate.' total_ht='.$obj->total_ht.' total_tva='.$obj->total_tva.' total_ttc='.$obj->total_ttc.' total_ht_by_vats='.$total_ht_by_vats[$obj->vatrate].' total_tva_by_vats='.$total_tva_by_vats[$obj->vatrate].' (new calculation = '.$tmpvat.') total_ttc_by_vats='.$total_ttc_by_vats[$obj->vatrate].($diff?" => DIFF":"")."<br>\n";

+                    if ($diff)

+                    {

+                        if (abs($diff) > 0.1) { dol_syslog('A rounding difference was detected into TOTAL but is too high to be corrected', LOG_WARNING); exit; }

+                        $sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;

+                        dol_syslog('We found a difference of '.$diff.' for line rowid = '.$obj->rowid.". We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

+                                $resqlfix=$this->db->query($sqlfix);

+                                if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+                                $this->total_tva -= $diff;

+                                $this->total_ttc -= $diff;

+                                $total_tva_by_vats[$obj->vatrate] -= $diff;

+                                $total_ttc_by_vats[$obj->vatrate] -= $diff;

+                    }

+                }

+

+                $i++;

+            }

+

+            // Add revenue stamp to total

+            $this->total_ttc       			+= isset($this->revenuestamp)?$this->revenuestamp:0;

+            $this->multicurrency_total_ttc  += isset($this->revenuestamp)?($this->revenuestamp * $multicurrency_tx):0;

+

+            // Situations totals

+            if ($this->situation_cycle_ref && $this->situation_counter > 1 && method_exists($this, 'get_prev_sits') && $this->type != $this::TYPE_CREDIT_NOTE )

+            {

+                $prev_sits = $this->get_prev_sits();

+

+                foreach ($prev_sits as $sit) {				// $sit is an object Facture loaded with a fetch.

+                    $this->total_ht -= $sit->total_ht;

+                    $this->total_tva -= $sit->total_tva;

+                    $this->total_localtax1 -= $sit->total_localtax1;

+                    $this->total_localtax2 -= $sit->total_localtax2;

+                    $this->total_ttc -= $sit->total_ttc;

+                    $this->multicurrency_total_ht -= $sit->multicurrency_total_ht;

+                    $this->multicurrency_total_tva -= $sit->multicurrency_total_tva;

+                    $this->multicurrency_total_ttc -= $sit->multicurrency_total_ttc;

+                }

+            }

+

+            $this->db->free($resql);

+

+            // Now update global field total_ht, total_ttc and tva

+            $fieldht='total_ht';

+            $fieldtva='tva';

+            $fieldlocaltax1='localtax1';

+            $fieldlocaltax2='localtax2';

+            $fieldttc='total_ttc';

+            // Specific code for backward compatibility with old field names

+            if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht='total';

+            if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva='total_tva';

+            if ($this->element == 'propal')                                                $fieldttc='total';

+            if ($this->element == 'expensereport')                                         $fieldtva='total_tva';

+            if ($this->element == 'supplier_proposal')                                     $fieldttc='total';

+

+            if (empty($nodatabaseupdate))

+            {

+                $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET';

+                $sql .= " ".$fieldht."='".price2num($this->total_ht)."',";

+                $sql .= " ".$fieldtva."='".price2num($this->total_tva)."',";

+                $sql .= " ".$fieldlocaltax1."='".price2num($this->total_localtax1)."',";

+                $sql .= " ".$fieldlocaltax2."='".price2num($this->total_localtax2)."',";

+                $sql .= " ".$fieldttc."='".price2num($this->total_ttc)."'";

+                        $sql .= ", multicurrency_total_ht='".price2num($this->multicurrency_total_ht, 'MT', 1)."'";

+                        $sql .= ", multicurrency_total_tva='".price2num($this->multicurrency_total_tva, 'MT', 1)."'";

+                        $sql .= ", multicurrency_total_ttc='".price2num($this->multicurrency_total_ttc, 'MT', 1)."'";

+                $sql .= ' WHERE rowid = '.$this->id;

+

+

+                dol_syslog(get_class($this)."::update_price", LOG_DEBUG);

+                $resql=$this->db->query($sql);

+                if (! $resql)

+                {

+                    $error++;

+                    $this->error=$this->db->lasterror();

+                    $this->errors[]=$this->db->lasterror();

+                }

+            }

+

+            if (! $error)

+            {

+                return 1;

+            }

+            else

+            {

+                return -1;

+            }

+        }

+        else

+        {

+            dol_print_error($this->db,'Bad request in update_price');

+            return -1;

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *	Add objects linked in llx_element_element.

+     *

+     *	@param		string	$origin		Linked element type

+     *	@param		int		$origin_id	Linked element id

+     *	@return		int					<=0 if KO, >0 if OK

+     *	@see		fetchObjectLinked, updateObjectLinked, deleteObjectLinked

+     */

+    function add_object_linked($origin=null, $origin_id=null)

+    {

+        // phpcs:enable

+        $origin = (! empty($origin) ? $origin : $this->origin);

+        $origin_id = (! empty($origin_id) ? $origin_id : $this->origin_id);

+

+        // Special case

+        if ($origin == 'order') $origin='commande';

+        if ($origin == 'invoice') $origin='facture';

+        if ($origin == 'invoice_template') $origin='facturerec';

+        if ($origin == 'supplierorder') $origin='order_supplier';

+        $this->db->begin();

+

+        $sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";

+        $sql.= "fk_source";

+        $sql.= ", sourcetype";

+        $sql.= ", fk_target";

+        $sql.= ", targettype";

+        $sql.= ") VALUES (";

+        $sql.= $origin_id;

+        $sql.= ", '".$this->db->escape($origin)."'";

+        $sql.= ", ".$this->id;

+        $sql.= ", '".$this->db->escape($this->element)."'";

+        $sql.= ")";

+

+        dol_syslog(get_class($this)."::add_object_linked", LOG_DEBUG);

+        if ($this->db->query($sql))

+            {

+                $this->db->commit();

+                return 1;

+            }

+            else

+            {

+                $this->error=$this->db->lasterror();

+                $this->db->rollback();

+                return 0;

+            }

+    }

+

+    /**

+     *	Fetch array of objects linked to current object (object of enabled modules only). Links are loaded into

+     *		this->linkedObjectsIds array and

+     *		this->linkedObjects array if $loadalsoobjects = 1

+     *  Possible usage for parameters:

+     *  - all parameters empty -> we look all link to current object (current object can be source or target)

+     *  - source id+type -> will get target list linked to source

+     *  - target id+type -> will get source list linked to target

+     *  - source id+type + target type -> will get target list of the type

+     *  - target id+type + target source -> will get source list of the type

+     *

+     *	@param	int		$sourceid			Object source id (if not defined, id of object)

+     *	@param  string	$sourcetype			Object source type (if not defined, element name of object)

+     *	@param  int		$targetid			Object target id (if not defined, id of object)

+     *	@param  string	$targettype			Object target type (if not defined, elemennt name of object)

+     *	@param  string	$clause				'OR' or 'AND' clause used when both source id and target id are provided

+     *  @param  int		$alsosametype		0=Return only links to object that differs from source type. 1=Include also link to objects of same type.

+     *  @param  string	$orderby			SQL 'ORDER BY' clause

+     *  @param	int		$loadalsoobjects	Load also array this->linkedObjects (Use 0 to increase performances)

+     *	@return int							<0 if KO, >0 if OK

+     *  @see	add_object_linked, updateObjectLinked, deleteObjectLinked

+     */

+    function fetchObjectLinked($sourceid=null,$sourcetype='',$targetid=null,$targettype='',$clause='OR',$alsosametype=1,$orderby='sourcetype',$loadalsoobjects=1)

+    {

+        global $conf;

+

+        $this->linkedObjectsIds=array();

+        $this->linkedObjects=array();

+

+        $justsource=false;

+        $justtarget=false;

+        $withtargettype=false;

+        $withsourcetype=false;

+

+        if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid))

+        {

+            $justsource=true;  // the source (id and type) is a search criteria

+            if (! empty($targettype)) $withtargettype=true;

+        }

+        if (! empty($targetid) && ! empty($targettype) && empty($sourceid))

+        {

+            $justtarget=true;  // the target (id and type) is a search criteria

+            if (! empty($sourcetype)) $withsourcetype=true;

+        }

+

+        $sourceid = (! empty($sourceid) ? $sourceid : $this->id);

+        $targetid = (! empty($targetid) ? $targetid : $this->id);

+        $sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

+        $targettype = (! empty($targettype) ? $targettype : $this->element);

+

+        /*if (empty($sourceid) && empty($targetid))

+		 {

+		 dol_syslog('Bad usage of function. No source nor target id defined (nor as parameter nor as object id)', LOG_ERR);

+		 return -1;

+		 }*/

+

+        // Links between objects are stored in table element_element

+        $sql = 'SELECT rowid, fk_source, sourcetype, fk_target, targettype';

+        $sql.= ' FROM '.MAIN_DB_PREFIX.'element_element';

+        $sql.= " WHERE ";

+        if ($justsource || $justtarget)

+        {

+            if ($justsource)

+            {

+                $sql.= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";

+                if ($withtargettype) $sql.= " AND targettype = '".$targettype."'";

+            }

+            else if ($justtarget)

+            {

+                $sql.= "fk_target = ".$targetid." AND targettype = '".$targettype."'";

+                if ($withsourcetype) $sql.= " AND sourcetype = '".$sourcetype."'";

+            }

+        }

+        else

+        {

+            $sql.= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";

+            $sql.= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";

+        }

+        $sql .= ' ORDER BY '.$orderby;

+

+        dol_syslog(get_class($this)."::fetchObjectLink", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $num = $this->db->num_rows($resql);

+            $i = 0;

+            while ($i < $num)

+            {

+                $obj = $this->db->fetch_object($resql);

+                if ($justsource || $justtarget)

+                {

+                    if ($justsource)

+                    {

+                        $this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

+                    }

+                    else if ($justtarget)

+                    {

+                        $this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

+                    }

+                }

+                else

+                {

+                    if ($obj->fk_source == $sourceid && $obj->sourcetype == $sourcetype)

+                    {

+                        $this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

+                    }

+                    if ($obj->fk_target == $targetid && $obj->targettype == $targettype)

+                    {

+                        $this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

+                    }

+                }

+                $i++;

+            }

+

+            if (! empty($this->linkedObjectsIds))

+            {

+                $tmparray = $this->linkedObjectsIds;

+                foreach($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

+                {

+                    // Parse element/subelement (ex: project_task, cabinetmed_consultation, ...)

+                    $module = $element = $subelement = $objecttype;

+                    if ($objecttype != 'supplier_proposal' && $objecttype != 'order_supplier' && $objecttype != 'invoice_supplier'

+                        && preg_match('/^([^_]+)_([^_]+)/i',$objecttype,$regs))

+                    {

+                        $module = $element = $regs[1];

+                        $subelement = $regs[2];

+                    }

+

+                    $classpath = $element.'/class';

+                    // To work with non standard classpath or module name

+                    if ($objecttype == 'facture')			{

+                        $classpath = 'compta/facture/class';

+                    }

+                    else if ($objecttype == 'facturerec')			{

+                        $classpath = 'compta/facture/class'; $module = 'facture';

+                    }

+                    else if ($objecttype == 'propal')			{

+                        $classpath = 'comm/propal/class';

+                    }

+                    else if ($objecttype == 'supplier_proposal')			{

+                        $classpath = 'supplier_proposal/class';

+                    }

+                    else if ($objecttype == 'shipping')			{

+                        $classpath = 'expedition/class'; $subelement = 'expedition'; $module = 'expedition_bon';

+                    }

+                    else if ($objecttype == 'delivery')			{

+                        $classpath = 'livraison/class'; $subelement = 'livraison'; $module = 'livraison_bon';

+                    }

+                    else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

+                        $classpath = 'fourn/class'; $module = 'fournisseur';

+                    }

+                    else if ($objecttype == 'fichinter')			{

+                        $classpath = 'fichinter/class'; $subelement = 'fichinter'; $module = 'ficheinter';

+                    }

+                    else if ($objecttype == 'subscription')			{

+                        $classpath = 'adherents/class'; $module = 'adherent';

+                    }

+

+                    // Set classfile

+                    $classfile = strtolower($subelement); $classname = ucfirst($subelement);

+

+                    if ($objecttype == 'order') {

+                        $classfile = 'commande'; $classname = 'Commande';

+                    }

+                    else if ($objecttype == 'invoice_supplier') {

+                        $classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';

+                    }

+                    else if ($objecttype == 'order_supplier')   {

+                        $classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';

+                    }

+                    else if ($objecttype == 'supplier_proposal')   {

+                        $classfile = 'supplier_proposal'; $classname = 'SupplierProposal';

+                    }

+                    else if ($objecttype == 'facturerec')   {

+                        $classfile = 'facture-rec'; $classname = 'FactureRec';

+                    }

+                    else if ($objecttype == 'subscription')   {

+                        $classfile = 'subscription'; $classname = 'Subscription';

+                    }

+

+                    // Here $module, $classfile and $classname are set

+                    if ($conf->$module->enabled && (($element != $this->element) || $alsosametype))

+                    {

+                        if ($loadalsoobjects)

+                        {

+                            dol_include_once('/'.$classpath.'/'.$classfile.'.class.php');

+                            //print '/'.$classpath.'/'.$classfile.'.class.php '.class_exists($classname);

+                            if (class_exists($classname))

+                            {

+                                foreach($objectids as $i => $objectid)	// $i is rowid into llx_element_element

+                                {

+                                    $object = new $classname($this->db);

+                                    $ret = $object->fetch($objectid);

+                                    if ($ret >= 0)

+                                    {

+                                        $this->linkedObjects[$objecttype][$i] = $object;

+                                    }

+                                }

+                            }

+                        }

+                    }

+                    else

+                    {

+                        unset($this->linkedObjectsIds[$objecttype]);

+                    }

+                }

+            }

+            return 1;

+        }

+        else

+        {

+            dol_print_error($this->db);

+            return -1;

+        }

+    }

+

+    /**

+     *	Update object linked of a current object

+     *

+     *	@param	int		$sourceid		Object source id

+     *	@param  string	$sourcetype		Object source type

+     *	@param  int		$targetid		Object target id

+     *	@param  string	$targettype		Object target type

+     *	@return							int	>0 if OK, <0 if KO

+     *	@see	add_object_linked, fetObjectLinked, deleteObjectLinked

+     */

+    function updateObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='')

+    {

+        $updatesource=false;

+        $updatetarget=false;

+

+        if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource=true;

+        else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $updatetarget=true;

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX."element_element SET ";

+        if ($updatesource)

+        {

+            $sql.= "fk_source = ".$sourceid;

+            $sql.= ", sourcetype = '".$this->db->escape($sourcetype)."'";

+            $sql.= " WHERE fk_target = ".$this->id;

+            $sql.= " AND targettype = '".$this->db->escape($this->element)."'";

+        }

+        else if ($updatetarget)

+        {

+            $sql.= "fk_target = ".$targetid;

+            $sql.= ", targettype = '".$this->db->escape($targettype)."'";

+            $sql.= " WHERE fk_source = ".$this->id;

+            $sql.= " AND sourcetype = '".$this->db->escape($this->element)."'";

+        }

+

+        dol_syslog(get_class($this)."::updateObjectLinked", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            return -1;

+        }

+    }

+

+    /**

+     *	Delete all links between an object $this

+     *

+     *	@param	int		$sourceid		Object source id

+     *	@param  string	$sourcetype		Object source type

+     *	@param  int		$targetid		Object target id

+     *	@param  string	$targettype		Object target type

+     *  @param	int		$rowid			Row id of line to delete. If defined, other parameters are not used.

+     *	@return     					int	>0 if OK, <0 if KO

+     *	@see	add_object_linked, updateObjectLinked, fetchObjectLinked

+     */

+    function deleteObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='', $rowid='')

+    {

+        $deletesource=false;

+        $deletetarget=false;

+

+        if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource=true;

+        else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $deletetarget=true;

+

+        $sourceid = (! empty($sourceid) ? $sourceid : $this->id);

+        $sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

+        $targetid = (! empty($targetid) ? $targetid : $this->id);

+        $targettype = (! empty($targettype) ? $targettype : $this->element);

+

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."element_element";

+        $sql.= " WHERE";

+        if ($rowid > 0)

+        {

+            $sql.=" rowid = ".$rowid;

+        }

+        else

+        {

+            if ($deletesource)

+            {

+                $sql.= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";

+                $sql.= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";

+            }

+            else if ($deletetarget)

+            {

+                $sql.= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";

+                $sql.= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";

+            }

+            else

+            {

+                $sql.= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";

+                $sql.= " OR";

+                $sql.= " (fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."')";

+            }

+        }

+

+        dol_syslog(get_class($this)."::deleteObjectLinked", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            $this->errors[]=$this->error;

+            return -1;

+        }

+    }

+

+    /**

+     *      Set status of an object

+     *

+     *      @param	int		$status			Status to set

+     *      @param	int		$elementId		Id of element to force (use this->id by default)

+     *      @param	string	$elementType	Type of element to force (use this->table_element by default)

+     *      @param	string	$trigkey		Trigger key to use for trigger

+     *      @return int						<0 if KO, >0 if OK

+     */

+    function setStatut($status, $elementId=null, $elementType='', $trigkey='')

+    {

+        global $user,$langs,$conf;

+

+        $savElementId=$elementId;  // To be used later to know if we were using the method using the id of this or not.

+

+        $elementId = (!empty($elementId)?$elementId:$this->id);

+        $elementTable = (!empty($elementType)?$elementType:$this->table_element);

+

+        $this->db->begin();

+

+        $fieldstatus="fk_statut";

+        if ($elementTable == 'facture_rec') $fieldstatus="suspended";

+        if ($elementTable == 'mailing') $fieldstatus="statut";

+        if ($elementTable == 'cronjob') $fieldstatus="status";

+        if ($elementTable == 'user') $fieldstatus="statut";

+        if ($elementTable == 'expensereport') $fieldstatus="fk_statut";

+        if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus="status";

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$elementTable;

+        $sql.= " SET ".$fieldstatus." = ".$status;

+        // If status = 1 = validated, update also fk_user_valid

+        if ($status == 1 && $elementTable == 'expensereport') $sql.=", fk_user_valid = ".$user->id;

+        $sql.= " WHERE rowid=".$elementId;

+

+        dol_syslog(get_class($this)."::setStatut", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            $error = 0;

+

+            // Try autoset of trigkey

+            if (empty($trigkey))

+            {

+                if ($this->element == 'supplier_proposal' && $status == 2) $trigkey='SUPPLIER_PROPOSAL_SIGN';   // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

+                if ($this->element == 'supplier_proposal' && $status == 3) $trigkey='SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

+                if ($this->element == 'supplier_proposal' && $status == 4) $trigkey='SUPPLIER_PROPOSAL_CLOSE';  // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

+                if ($this->element == 'fichinter' && $status == 3) $trigkey='FICHINTER_CLASSIFY_DONE';

+                if ($this->element == 'fichinter' && $status == 2) $trigkey='FICHINTER_CLASSIFY_BILLED';

+                if ($this->element == 'fichinter' && $status == 1) $trigkey='FICHINTER_CLASSIFY_UNBILLED';

+            }

+

+            if ($trigkey)

+            {

+                // Appel des triggers

+                include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';

+                $interface=new Interfaces($this->db);

+                $result=$interface->run_triggers($trigkey,$this,$user,$langs,$conf);

+                if ($result < 0) {

+                    $error++; $this->errors=$interface->errors;

+                }

+                // Fin appel triggers

+            }

+

+            if (! $error)

+            {

+                $this->db->commit();

+

+                if (empty($savElementId))    // If the element we update was $this (so $elementId is null)

+                {

+                    $this->statut = $status;

+                    $this->status = $status;

+                }

+

+                return 1;

+            }

+            else

+            {

+                $this->db->rollback();

+                dol_syslog(get_class($this)."::setStatus ".$this->error,LOG_ERR);

+                return -1;

+            }

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return -1;

+        }

+    }

+

+

+    /**

+     *  Load type of canvas of an object if it exists

+     *

+     *  @param      int		$id     Record id

+     *  @param      string	$ref    Record ref

+     *  @return		int				<0 if KO, 0 if nothing done, >0 if OK

+     */

+    function getCanvas($id=0,$ref='')

+    {

+        global $conf;

+

+        if (empty($id) && empty($ref)) return 0;

+        if (! empty($conf->global->MAIN_DISABLE_CANVAS)) return 0;    // To increase speed. Not enabled by default.

+

+        // Clean parameters

+        $ref = trim($ref);

+

+        $sql = "SELECT rowid, canvas";

+        $sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " WHERE entity IN (".getEntity($this->element).")";

+        if (! empty($id))  $sql.= " AND rowid = ".$id;

+        if (! empty($ref)) $sql.= " AND ref = '".$this->db->escape($ref)."'";

+

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $obj = $this->db->fetch_object($resql);

+            if ($obj)

+            {

+                $this->canvas   = $obj->canvas;

+                return 1;

+            }

+            else return 0;

+        }

+        else

+        {

+            dol_print_error($this->db);

+            return -1;

+        }

+    }

+

+

+    /**

+     * 	Get special code of a line

+     *

+     * 	@param	int		$lineid		Id of line

+     * 	@return	int					Special code

+     */

+    function getSpecialCode($lineid)

+    {

+        $sql = 'SELECT special_code FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+        $sql.= ' WHERE rowid = '.$lineid;

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $row = $this->db->fetch_row($resql);

+            return $row[0];

+        }

+    }

+

+    /**

+     *  Function to check if an object is used by others.

+     *  Check is done into this->childtables. There is no check into llx_element_element.

+     *

+     *  @param	int		$id			Force id of object

+     *  @return	int					<0 if KO, 0 if not used, >0 if already used

+     */

+    function isObjectUsed($id=0)

+    {

+        global $langs;

+

+        if (empty($id)) $id=$this->id;

+

+        // Check parameters

+        if (! isset($this->childtables) || ! is_array($this->childtables) || count($this->childtables) == 0)

+        {

+            dol_print_error('Called isObjectUsed on a class with property this->childtables not defined');

+            return -1;

+        }

+

+        $arraytoscan = $this->childtables;

+        // For backward compatibility, we check if array is old format array('table1', 'table2', ...)

+        $tmparray=array_keys($this->childtables);

+        if (is_numeric($tmparray[0]))

+        {

+            $arraytoscan = array_flip($this->childtables);

+        }

+

+        // Test if child exists

+        $haschild=0;

+        foreach($arraytoscan as $table => $elementname)

+        {

+            //print $id.'-'.$table.'-'.$elementname.'<br>';

+            // Check if third party can be deleted

+            $sql = "SELECT COUNT(*) as nb from ".MAIN_DB_PREFIX.$table;

+            $sql.= " WHERE ".$this->fk_element." = ".$id;

+            $resql=$this->db->query($sql);

+            if ($resql)

+            {

+                $obj=$this->db->fetch_object($resql);

+                if ($obj->nb > 0)

+                {

+                    $langs->load("errors");

+                    //print 'Found into table '.$table.', type '.$langs->transnoentitiesnoconv($elementname).', haschild='.$haschild;

+                    $haschild += $obj->nb;

+                    if (is_numeric($elementname))	// old usage

+                    {

+                        $this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);

+                    }

+                    else	// new usage: $elementname=Translation key

+                    {

+                        $this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));

+                    }

+                    break;    // We found at least one, we stop here

+                }

+            }

+            else

+            {

+                $this->errors[]=$this->db->lasterror();

+                return -1;

+            }

+        }

+        if ($haschild > 0)

+        {

+            $this->errors[]="ErrorRecordHasChildren";

+            return $haschild;

+        }

+        else return 0;

+    }

+

+    /**

+     *  Function to say how many lines object contains

+     *

+     *	@param	int		$predefined		-1=All, 0=Count free product/service only, 1=Count predefined product/service only, 2=Count predefined product, 3=Count predefined service

+     *  @return	int						<0 if KO, 0 if no predefined products, nb of lines with predefined products if found

+     */

+    function hasProductsOrServices($predefined=-1)

+    {

+        $nb=0;

+

+        foreach($this->lines as $key => $val)

+        {

+            $qualified=0;

+            if ($predefined == -1) $qualified=1;

+            if ($predefined == 1 && $val->fk_product > 0) $qualified=1;

+            if ($predefined == 0 && $val->fk_product <= 0) $qualified=1;

+            if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) $qualified=1;

+            if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) $qualified=1;

+            if ($qualified) $nb++;

+        }

+        dol_syslog(get_class($this).'::hasProductsOrServices we found '.$nb.' qualified lines of products/servcies');

+        return $nb;

+    }

+

+    /**

+     * Function that returns the total amount HT of discounts applied for all lines.

+     *

+     * @return 	float

+     */

+    function getTotalDiscount()

+    {

+        $total_discount=0.00;

+

+        $sql = "SELECT subprice as pu_ht, qty, remise_percent, total_ht";

+        $sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element."det";

+        $sql.= " WHERE ".$this->fk_element." = ".$this->id;

+

+        dol_syslog(get_class($this).'::getTotalDiscount', LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $num=$this->db->num_rows($resql);

+            $i=0;

+            while ($i < $num)

+            {

+                $obj = $this->db->fetch_object($resql);

+

+                $pu_ht = $obj->pu_ht;

+                $qty= $obj->qty;

+                $total_ht = $obj->total_ht;

+

+                $total_discount_line = floatval(price2num(($pu_ht * $qty) - $total_ht, 'MT'));

+                $total_discount += $total_discount_line;

+

+                $i++;

+            }

+        }

+

+        //print $total_discount; exit;

+        return price2num($total_discount);

+    }

+

+

+    /**

+     * Return into unit=0, the calculated total of weight and volume of all lines * qty

+     * Calculate by adding weight and volume of each product line, so properties ->volume/volume_units/weight/weight_units must be loaded on line.

+     *

+     * @return  array                           array('weight'=>...,'volume'=>...)

+     */

+    function getTotalWeightVolume()

+    {

+        $totalWeight = 0;

+        $totalVolume = 0;

+        // defined for shipment only

+        $totalOrdered = '';

+        // defined for shipment only

+        $totalToShip = '';

+

+        foreach ($this->lines as $line)

+        {

+            if (isset($line->qty_asked))

+            {

+                if (empty($totalOrdered)) $totalOrdered=0;  // Avoid warning because $totalOrdered is ''

+                $totalOrdered+=$line->qty_asked;    // defined for shipment only

+            }

+            if (isset($line->qty_shipped))

+            {

+                if (empty($totalToShip)) $totalToShip=0;    // Avoid warning because $totalToShip is ''

+                $totalToShip+=$line->qty_shipped;   // defined for shipment only

+            }else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

+            {

+                if (empty($totalToShip)) $totalToShip=0;

+                $totalToShip+=$line->qty;   // defined for reception only

+            }

+

+            // Define qty, weight, volume, weight_units, volume_units

+            if ($this->element == 'shipping') {

+                // for shipments

+                $qty = $line->qty_shipped ? $line->qty_shipped : 0;

+            }

+            else {

+                $qty = $line->qty ? $line->qty : 0;

+            }

+

+            $weight = $line->weight ? $line->weight : 0;

+            ($weight==0 && !empty($line->product->weight))? $weight=$line->product->weight: 0;

+            $volume = $line->volume ? $line->volume : 0;

+            ($volume==0 && !empty($line->product->volume))? $volume=$line->product->volume: 0;

+

+            $weight_units=$line->weight_units;

+            ($weight_units==0 && !empty($line->product->weight_units))? $weight_units=$line->product->weight_units: 0;

+            $volume_units=$line->volume_units;

+            ($volume_units==0 && !empty($line->product->volume_units))? $volume_units=$line->product->volume_units: 0;

+

+            $weightUnit=0;

+            $volumeUnit=0;

+            if (! empty($weight_units)) $weightUnit = $weight_units;

+            if (! empty($volume_units)) $volumeUnit = $volume_units;

+

+            if (empty($totalWeight)) $totalWeight=0;  // Avoid warning because $totalWeight is ''

+            if (empty($totalVolume)) $totalVolume=0;  // Avoid warning because $totalVolume is ''

+

+            //var_dump($line->volume_units);

+            if ($weight_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

+            {

+                $trueWeightUnit=pow(10, $weightUnit);

+                $totalWeight += $weight * $qty * $trueWeightUnit;

+            }

+            else {

+        if ($weight_units == 99) {

+            // conversion 1 Pound = 0.45359237 KG

+            $trueWeightUnit = 0.45359237;

+            $totalWeight += $weight * $qty * $trueWeightUnit;

+        } elseif ($weight_units == 98) {

+            // conversion 1 Ounce = 0.0283495 KG

+            $trueWeightUnit = 0.0283495;

+            $totalWeight += $weight * $qty * $trueWeightUnit;

+        }

+        else

+                    $totalWeight += $weight * $qty;   // This may be wrong if we mix different units

+            }

+            if ($volume_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

+            {

+                //print $line->volume."x".$line->volume_units."x".($line->volume_units < 50)."x".$volumeUnit;

+                $trueVolumeUnit=pow(10, $volumeUnit);

+                //print $line->volume;

+                $totalVolume += $volume * $qty * $trueVolumeUnit;

+            }

+            else

+            {

+                $totalVolume += $volume * $qty;   // This may be wrong if we mix different units

+            }

+        }

+

+        return array('weight'=>$totalWeight, 'volume'=>$totalVolume, 'ordered'=>$totalOrdered, 'toship'=>$totalToShip);

+    }

+

+

+    /**

+     *	Set extra parameters

+     *

+     *	@return	int      <0 if KO, >0 if OK

+     */

+    function setExtraParameters()

+    {

+        $this->db->begin();

+

+        $extraparams = (! empty($this->extraparams) ? json_encode($this->extraparams) : null);

+

+        $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

+        $sql.= " SET extraparams = ".(! empty($extraparams) ? "'".$this->db->escape($extraparams)."'" : "null");

+        $sql.= " WHERE rowid = ".$this->id;

+

+        dol_syslog(get_class($this)."::setExtraParameters", LOG_DEBUG);

+        $resql = $this->db->query($sql);

+        if (! $resql)

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return -1;

+        }

+        else

+        {

+            $this->db->commit();

+            return 1;

+        }

+    }

+

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *    Return incoterms informations

+     *    TODO Use a cache for label get

+     *

+     *    @return	string	incoterms info

+     */

+    function display_incoterms()

+    {

+        // phpcs:enable

+        $out = '';

+        $this->libelle_incoterms = '';

+        if (!empty($this->fk_incoterms))

+        {

+            $sql = 'SELECT code FROM '.MAIN_DB_PREFIX.'c_incoterms WHERE rowid = '.(int) $this->fk_incoterms;

+            $result = $this->db->query($sql);

+            if ($result)

+            {

+                $res = $this->db->fetch_object($result);

+                $out .= $res->code;

+            }

+        }

+

+        $out .= (($res->code && $this->location_incoterms)?' - ':'').$this->location_incoterms;

+

+        return $out;

+    }

+

+    /**

+     *    Return incoterms informations for pdf display

+     *

+     *    @return	string		incoterms info

+     */

+    function getIncotermsForPDF()

+    {

+        $sql = 'SELECT code FROM '.MAIN_DB_PREFIX.'c_incoterms WHERE rowid = '.(int) $this->fk_incoterms;

+        $resql = $this->db->query($sql);

+        if ($resql)

+        {

+            $num = $this->db->num_rows($resql);

+            if ($num > 0)

+            {

+                $res = $this->db->fetch_object($resql);

+                return 'Incoterm : '.$res->code.' - '.$this->location_incoterms;

+            }

+            else

+            {

+                return '';

+            }

+        }

+        else

+        {

+            $this->errors[] = $this->db->lasterror();

+            return false;

+        }

+    }

+

+    /**

+     *    Define incoterms values of current object

+     *

+     *    @param	int		$id_incoterm     Id of incoterm to set or '' to remove

+     * 	  @param 	string  $location		 location of incoterm

+     *    @return	int     		<0 if KO, >0 if OK

+     */

+    function setIncoterms($id_incoterm, $location)

+    {

+        if ($this->id && $this->table_element)

+        {

+            $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

+            $sql.= " SET fk_incoterms = ".($id_incoterm > 0 ? $id_incoterm : "null");

+            $sql.= ", location_incoterms = ".($id_incoterm > 0 ? "'".$this->db->escape($location)."'" : "null");

+            $sql.= " WHERE rowid = " . $this->id;

+            dol_syslog(get_class($this).'::setIncoterms', LOG_DEBUG);

+            $resql=$this->db->query($sql);

+            if ($resql)

+            {

+                $this->fk_incoterms = $id_incoterm;

+                $this->location_incoterms = $location;

+

+                $sql = 'SELECT libelle FROM '.MAIN_DB_PREFIX.'c_incoterms WHERE rowid = '.(int) $this->fk_incoterms;

+                $res = $this->db->query($sql);

+                if ($res)

+                {

+                    $obj = $this->db->fetch_object($res);

+                    $this->libelle_incoterms = $obj->libelle;

+                }

+                return 1;

+            }

+            else

+            {

+                $this->errors[] = $this->db->lasterror();

+                return -1;

+            }

+        }

+        else return -1;

+    }

+

+

+    // --------------------

+    // TODO: All functions here must be redesigned and moved as they are not business functions but output functions

+    // --------------------

+

+    /* This is to show add lines */

+

+    /**

+     *	Show add free and predefined products/services form

+     *

+     *  @param	int		        $dateSelector       1=Show also date range input fields

+     *  @param	Societe			$seller				Object thirdparty who sell

+     *  @param	Societe			$buyer				Object thirdparty who buy

+     *	@return	void

+     */

+    function formAddObjectLine($dateSelector, $seller, $buyer)

+    {

+        global $conf,$user,$langs,$object,$hookmanager;

+        global $form,$bcnd,$var;

+

+        // Line extrafield

+        require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

+        $extrafieldsline = new ExtraFields($this->db);

+        $extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);

+

+        // Output template part (modules that overwrite templates must declare this into descriptor)

+        // Use global variables + $dateSelector + $seller and $buyer

+        $dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

+        foreach($dirtpls as $reldir)

+        {

+            $tpl = dol_buildpath($reldir.'/objectline_create.tpl.php');

+            if (empty($conf->file->strict_mode)) {

+                $res=@include $tpl;

+            } else {

+                $res=include $tpl; // for debug

+            }

+            if ($res) break;

+        }

+    }

+

+

+

+    /* This is to show array of line of details */

+

+

+    /**

+     *	Return HTML table for object lines

+     *	TODO Move this into an output class file (htmlline.class.php)

+     *	If lines are into a template, title must also be into a template

+     *	But for the moment we don't know if it's possible as we keep a method available on overloaded objects.

+     *

+     *	@param	string		$action				Action code

+     *	@param  string		$seller            	Object of seller third party

+     *	@param  string  	$buyer             	Object of buyer third party

+     *	@param	int			$selected		   	Object line selected

+     *	@param  int	    	$dateSelector      	1=Show also date range input fields

+     *	@return	void

+     */

+    function printObjectLines($action, $seller, $buyer, $selected=0, $dateSelector=0)

+    {

+        global $conf, $hookmanager, $langs, $user;

+        // TODO We should not use global var for this !

+        global $inputalsopricewithtax, $usemargins, $disableedit, $disablemove, $disableremove, $outputalsopricetotalwithtax;

+

+        // Define usemargins

+        $usemargins=0;

+        if (! empty($conf->margin->enabled) && ! empty($this->element) && in_array($this->element,array('facture','propal','commande'))) $usemargins=1;

+

+        $num = count($this->lines);

+

+        // Line extrafield

+        require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

+        $extrafieldsline = new ExtraFields($this->db);

+        $extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);

+

+        $parameters = array('num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

+        $reshook = $hookmanager->executeHooks('printObjectLineTitle', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

+        if (empty($reshook))

+        {

+            // Title line

+            print "<thead>\n";

+

+            print '<tr class="liste_titre nodrag nodrop">';

+

+            // Adds a line numbering column

+            if (! empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';

+

+            // Description

+            print '<td class="linecoldescription">'.$langs->trans('Description').'</td>';

+

+            if ($this->element == 'supplier_proposal' || $this->element == 'order_supplier' || $this->element == 'invoice_supplier')

+            {

+                print '<td class="linerefsupplier"><span id="title_fourn_ref">'.$langs->trans("SupplierRef").'</span></td>';

+            }

+

+            // VAT

+            print '<td class="linecolvat" align="right" width="80">'.$langs->trans('VAT').'</td>';

+

+            // Price HT

+            print '<td class="linecoluht" align="right" width="80">'.$langs->trans('PriceUHT').'</td>';

+

+            // Multicurrency

+            if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) print '<td class="linecoluht_currency" align="right" width="80">'.$langs->trans('PriceUHTCurrency', $this->multicurrency_code).'</td>';

+

+            if ($inputalsopricewithtax) print '<td align="right" width="80">'.$langs->trans('PriceUTTC').'</td>';

+

+            // Qty

+            print '<td class="linecolqty" align="right">'.$langs->trans('Qty').'</td>';

+

+            if($conf->global->PRODUCT_USE_UNITS)

+            {

+                print '<td class="linecoluseunit" align="left">'.$langs->trans('Unit').'</td>';

+            }

+

+            // Reduction short

+            print '<td class="linecoldiscount" align="right">'.$langs->trans('ReductionShort').'</td>';

+

+            if ($this->situation_cycle_ref) {

+                print '<td class="linecolcycleref" align="right">' . $langs->trans('Progress') . '</td>';

+            }

+

+            if ($usemargins && ! empty($conf->margin->enabled) && empty($user->societe_id))

+            {

+                if (!empty($user->rights->margins->creer))

+                {

+                    if ($conf->global->MARGIN_TYPE == "1")

+                        print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('BuyingPrice').'</td>';

+                    else

+                        print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';

+                }

+

+                if (! empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)

+                    print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';

+                if (! empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)

+                    print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';

+            }

+

+            // Total HT

+            print '<td class="linecolht" align="right">'.$langs->trans('TotalHTShort').'</td>';

+

+            // Multicurrency

+            if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) print '<td class="linecoltotalht_currency" align="right">'.$langs->trans('TotalHTShortCurrency', $this->multicurrency_code).'</td>';

+

+            if ($outputalsopricetotalwithtax) print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';

+

+            print '<td class="linecoledit"></td>';  // No width to allow autodim

+

+            print '<td class="linecoldelete" width="10"></td>';

+

+            print '<td class="linecolmove" width="10"></td>';

+

+            if($action == 'selectlines')

+            {

+                print '<td class="linecolcheckall" align="center">';

+                print '<input type="checkbox" class="linecheckboxtoggle" />';

+                print '<script type="text/javascript">$(document).ready(function() {$(".linecheckboxtoggle").click(function() {var checkBoxes = $(".linecheckbox");checkBoxes.prop("checked", this.checked);})});</script>';

+                print '</td>';

+            }

+

+            print "</tr>\n";

+            print "</thead>\n";

+        }

+

+        $var = true;

+        $i	 = 0;

+

+        print "<tbody>\n";

+        foreach ($this->lines as $line)

+        {

+            //Line extrafield

+            $line->fetch_optionals();

+

+            //if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

+            if (is_object($hookmanager))   // Old code is commented on preceding line.

+            {

+                if (empty($line->fk_parent_line))

+                {

+                    $parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

+                    $reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

+                }

+                else

+                {

+                    $parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);

+                    $reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

+                }

+            }

+            if (empty($reshook))

+            {

+                $this->printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected,$extrafieldsline);

+            }

+

+            $i++;

+        }

+        print "</tbody>\n";

+    }

+

+    /**

+     *	Return HTML content of a detail line

+     *	TODO Move this into an output class file (htmlline.class.php)

+     *

+     *	@param	string		$action				GET/POST action

+     *	@param CommonObjectLine $line		       	Selected object line to output

+     *	@param  string	    $var               	Is it a an odd line (true)

+     *	@param  int		    $num               	Number of line (0)

+     *	@param  int		    $i					I

+     *	@param  int		    $dateSelector      	1=Show also date range input fields

+     *	@param  string	    $seller            	Object of seller third party

+     *	@param  string	    $buyer             	Object of buyer third party

+     *	@param	int			$selected		   	Object line selected

+     *  @param  int			$extrafieldsline	Object of extrafield line attribute

+     *	@return	void

+     */

+    function printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected=0,$extrafieldsline=0)

+    {

+        global $conf,$langs,$user,$object,$hookmanager;

+        global $form,$bc,$bcdd;

+        global $object_rights, $disableedit, $disablemove, $disableremove;   // TODO We should not use global var for this !

+

+        $object_rights = $this->getRights();

+

+        $element=$this->element;

+

+        $text=''; $description=''; $type=0;

+

+        // Show product and description

+        $type=(! empty($line->product_type)?$line->product_type:$line->fk_product_type);

+        // Try to enhance type detection using date_start and date_end for free lines where type was not saved.

+        if (! empty($line->date_start)) $type=1; // deprecated

+        if (! empty($line->date_end)) $type=1; // deprecated

+

+        // Ligne en mode visu

+        if ($action != 'editline' || $selected != $line->id)

+        {

+            // Product

+            if ($line->fk_product > 0)

+            {

+                $product_static = new Product($this->db);

+                $product_static->fetch($line->fk_product);

+

+                $product_static->ref = $line->ref; //can change ref in hook

+                $product_static->label = $line->label; //can change label in hook

+                $text=$product_static->getNomUrl(1);

+

+                // Define output language and label

+                if (! empty($conf->global->MAIN_MULTILANGS))

+                {

+                    if (! is_object($this->thirdparty))

+                    {

+                        dol_print_error('','Error: Method printObjectLine was called on an object and object->fetch_thirdparty was not done before');

+                        return;

+                    }

+

+                    $prod = new Product($this->db);

+                    $prod->fetch($line->fk_product);

+

+                    $outputlangs = $langs;

+                    $newlang='';

+                    if (empty($newlang) && GETPOST('lang_id','aZ09')) $newlang=GETPOST('lang_id','aZ09');

+                    if (! empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang=$this->thirdparty->default_lang;		// For language to language of customer

+                    if (! empty($newlang))

+                    {

+                        $outputlangs = new Translate("",$conf);

+                        $outputlangs->setDefaultLang($newlang);

+                    }

+

+                    $label = (! empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;

+                }

+                else

+                {

+                    $label = $line->product_label;

+                }

+

+                $text.= ' - '.(! empty($line->label)?$line->label:$label);

+                $description.=(! empty($conf->global->PRODUIT_DESC_IN_FORM)?'':dol_htmlentitiesbr($line->description));	// Description is what to show on popup. We shown nothing if already into desc.

+            }

+

+            $line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');

+

+            // Output template part (modules that overwrite templates must declare this into descriptor)

+            // Use global variables + $dateSelector + $seller and $buyer

+            $dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

+            foreach($dirtpls as $reldir)

+            {

+                $tpl = dol_buildpath($reldir.'/objectline_view.tpl.php');

+                if (empty($conf->file->strict_mode)) {

+                    $res=@include $tpl;

+                } else {

+                    $res=include $tpl; // for debug

+                }

+                if ($res) break;

+            }

+        }

+

+        // Ligne en mode update

+        if ($this->statut == 0 && $action == 'editline' && $selected == $line->id)

+        {

+            $label = (! empty($line->label) ? $line->label : (($line->fk_product > 0) ? $line->product_label : ''));

+            $placeholder=' placeholder="'.$langs->trans("Label").'"';

+

+            $line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');

+

+            // Output template part (modules that overwrite templates must declare this into descriptor)

+            // Use global variables + $dateSelector + $seller and $buyer

+            $dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

+            foreach($dirtpls as $reldir)

+            {

+                $tpl = dol_buildpath($reldir.'/objectline_edit.tpl.php');

+                if (empty($conf->file->strict_mode)) {

+                    $res=@include $tpl;

+                } else {

+                    $res=include $tpl; // for debug

+                }

+                if ($res) break;

+            }

+        }

+    }

+

+

+    /* This is to show array of line of details of source object */

+

+

+    /**

+     * 	Return HTML table table of source object lines

+     *  TODO Move this and previous function into output html class file (htmlline.class.php).

+     *  If lines are into a template, title must also be into a template

+     *  But for the moment we don't know if it's possible, so we keep the method available on overloaded objects.

+     *

+     *	@param	string		$restrictlist		''=All lines, 'services'=Restrict to services only

+     *  @return	void

+     */

+    function printOriginLinesList($restrictlist='')

+    {

+        global $langs, $hookmanager, $conf;

+

+        print '<tr class="liste_titre">';

+        print '<td>'.$langs->trans('Ref').'</td>';

+        print '<td>'.$langs->trans('Description').'</td>';

+        print '<td align="right">'.$langs->trans('VATRate').'</td>';

+        print '<td align="right">'.$langs->trans('PriceUHT').'</td>';

+        if (!empty($conf->multicurrency->enabled)) print '<td align="right">'.$langs->trans('PriceUHTCurrency').'</td>';

+        print '<td align="right">'.$langs->trans('Qty').'</td>';

+        if($conf->global->PRODUCT_USE_UNITS)

+        {

+            print '<td align="left">'.$langs->trans('Unit').'</td>';

+        }

+        print '<td align="right">'.$langs->trans('ReductionShort').'</td></tr>';

+

+        $var = true;

+        $i	 = 0;

+

+        if (! empty($this->lines))

+        {

+            foreach ($this->lines as $line)

+            {

+                if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

+                {

+                    if (empty($line->fk_parent_line))

+                    {

+                        $parameters=array('line'=>$line,'var'=>$var,'i'=>$i);

+                        $action='';

+                        $hookmanager->executeHooks('printOriginObjectLine',$parameters,$this,$action);    // Note that $action and $object may have been modified by some hooks

+                    }

+                }

+                else

+                {

+                    $this->printOriginLine($line, $var, $restrictlist);

+                }

+

+                $i++;

+            }

+        }

+    }

+

+    /**

+     * 	Return HTML with a line of table array of source object lines

+     *  TODO Move this and previous function into output html class file (htmlline.class.php).

+     *  If lines are into a template, title must also be into a template

+     *  But for the moment we don't know if it's possible as we keep a method available on overloaded objects.

+     *

+     * 	@param	CommonObjectLine	$line				Line

+     * 	@param	string				$var				Var

+     *	@param	string				$restrictlist		''=All lines, 'services'=Restrict to services only (strike line if not)

+     * 	@return	void

+     */

+    function printOriginLine($line, $var, $restrictlist='')

+    {

+        global $langs, $conf;

+

+        //var_dump($line);

+        if (!empty($line->date_start))

+        {

+            $date_start=$line->date_start;

+        }

+        else

+        {

+            $date_start=$line->date_debut_prevue;

+            if ($line->date_debut_reel) $date_start=$line->date_debut_reel;

+        }

+        if (!empty($line->date_end))

+        {

+            $date_end=$line->date_end;

+        }

+        else

+        {

+            $date_end=$line->date_fin_prevue;

+            if ($line->date_fin_reel) $date_end=$line->date_fin_reel;

+        }

+

+        $this->tpl['label'] = '';

+        if (! empty($line->fk_parent_line)) $this->tpl['label'].= img_picto('', 'rightarrow');

+

+        if (($line->info_bits & 2) == 2)  // TODO Not sure this is used for source object

+        {

+            $discount=new DiscountAbsolute($this->db);

+            $discount->fk_soc = $this->socid;

+            $this->tpl['label'].= $discount->getNomUrl(0,'discount');

+        }

+        else if (! empty($line->fk_product))

+        {

+            $productstatic = new Product($this->db);

+            $productstatic->id = $line->fk_product;

+            $productstatic->ref = $line->ref;

+            $productstatic->type = $line->fk_product_type;

+            if(empty($productstatic->ref)){

+                $line->fetch_product();

+                $productstatic = $line->product;

+            }

+			

+            $this->tpl['label'].= $productstatic->getNomUrl(1);

+            $this->tpl['label'].= ' - '.(! empty($line->label)?$line->label:$line->product_label);

+            // Dates

+            if ($line->product_type == 1 && ($date_start || $date_end))

+            {

+                $this->tpl['label'].= get_date_range($date_start,$date_end);

+            }

+        }

+        else

+        {

+            $this->tpl['label'].= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''),'service') : img_object($langs->trans(''),'product')));

+            if (!empty($line->desc)) {

+                $this->tpl['label'].=$line->desc;

+            }else {

+                $this->tpl['label'].= ($line->label ? '&nbsp;'.$line->label : '');

+            }

+			

+            // Dates

+            if ($line->product_type == 1 && ($date_start || $date_end))

+            {

+                $this->tpl['label'].= get_date_range($date_start,$date_end);

+            }

+        }

+

+        if (! empty($line->desc))

+        {

+            if ($line->desc == '(CREDIT_NOTE)')  // TODO Not sure this is used for source object

+            {

+                $discount=new DiscountAbsolute($this->db);

+                $discount->fetch($line->fk_remise_except);

+                $this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote",$discount->getNomUrl(0));

+            }

+            elseif ($line->desc == '(DEPOSIT)')  // TODO Not sure this is used for source object

+            {

+                $discount=new DiscountAbsolute($this->db);

+                $discount->fetch($line->fk_remise_except);

+                $this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit",$discount->getNomUrl(0));

+            }

+            elseif ($line->desc == '(EXCESS RECEIVED)')

+            {

+                $discount=new DiscountAbsolute($this->db);

+                $discount->fetch($line->fk_remise_except);

+                $this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived",$discount->getNomUrl(0));

+            }

+            elseif ($line->desc == '(EXCESS PAID)')

+            {

+                $discount=new DiscountAbsolute($this->db);

+                $discount->fetch($line->fk_remise_except);

+                $this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid",$discount->getNomUrl(0));

+            }

+            else

+            {

+                $this->tpl['description'] = dol_trunc($line->desc,60);

+            }

+        }

+        else

+        {

+            $this->tpl['description'] = '&nbsp;';

+        }

+

+        // VAT Rate

+        $this->tpl['vat_rate'] = vatrate($line->tva_tx, true);

+        $this->tpl['vat_rate'] .= (($line->info_bits & 1) == 1) ? '*' : '';

+        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';

+

+        $this->tpl['price'] = price($line->subprice);

+        $this->tpl['multicurrency_price'] = price($line->multicurrency_subprice);

+        $this->tpl['qty'] = (($line->info_bits & 2) != 2) ? $line->qty : '&nbsp;';

+        if ($conf->global->PRODUCT_USE_UNITS) $this->tpl['unit'] = $langs->transnoentities($line->getLabelOfUnit('long'));

+        $this->tpl['remise_percent'] = (($line->info_bits & 2) != 2) ? vatrate($line->remise_percent, true) : '&nbsp;';

+

+        // Is the line strike or not

+        $this->tpl['strike']=0;

+        if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike']=1;

+

+        // Output template part (modules that overwrite templates must declare this into descriptor)

+        // Use global variables + $dateSelector + $seller and $buyer

+        $dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

+        foreach($dirtpls as $reldir)

+        {

+            $tpl = dol_buildpath($reldir.'/originproductline.tpl.php');

+            if (empty($conf->file->strict_mode)) {

+                $res=@include $tpl;

+            } else {

+                $res=include $tpl; // for debug

+            }

+            if ($res) break;

+        }

+    }

+

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *	Add resources to the current object : add entry into llx_element_resources

+     *	Need $this->element & $this->id

+     *

+     *	@param		int		$resource_id		Resource id

+     *	@param		string	$resource_type		'resource'

+     *	@param		int		$busy				Busy or not

+     *	@param		int		$mandatory			Mandatory or not

+     *	@return		int							<=0 if KO, >0 if OK

+     */

+    function add_element_resource($resource_id, $resource_type, $busy=0, $mandatory=0)

+    {

+        // phpcs:enable

+        $this->db->begin();

+

+        $sql = "INSERT INTO ".MAIN_DB_PREFIX."element_resources (";

+        $sql.= "resource_id";

+        $sql.= ", resource_type";

+        $sql.= ", element_id";

+        $sql.= ", element_type";

+        $sql.= ", busy";

+        $sql.= ", mandatory";

+        $sql.= ") VALUES (";

+        $sql.= $resource_id;

+        $sql.= ", '".$this->db->escape($resource_type)."'";

+        $sql.= ", '".$this->db->escape($this->id)."'";

+        $sql.= ", '".$this->db->escape($this->element)."'";

+        $sql.= ", '".$this->db->escape($busy)."'";

+        $sql.= ", '".$this->db->escape($mandatory)."'";

+        $sql.= ")";

+

+        dol_syslog(get_class($this)."::add_element_resource", LOG_DEBUG);

+        if ($this->db->query($sql))

+        {

+            $this->db->commit();

+            return 1;

+        }

+        else

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return  0;

+        }

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *    Delete a link to resource line

+     *

+     *    @param	int		$rowid			Id of resource line to delete

+     *    @param	int		$element		element name (for trigger) TODO: use $this->element into commonobject class

+     *    @param	int		$notrigger		Disable all triggers

+     *    @return   int						>0 if OK, <0 if KO

+     */

+    function delete_resource($rowid, $element, $notrigger=0)

+    {

+        // phpcs:enable

+        global $user;

+

+        $this->db->begin();

+

+        $sql = "DELETE FROM ".MAIN_DB_PREFIX."element_resources";

+        $sql.= " WHERE rowid=".$rowid;

+

+        dol_syslog(get_class($this)."::delete_resource", LOG_DEBUG);

+

+        $resql=$this->db->query($sql);

+        if (! $resql)

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return -1;

+        }

+        else

+        {

+            if (! $notrigger)

+            {

+                $result=$this->call_trigger(strtoupper($element).'_DELETE_RESOURCE', $user);

+                if ($result < 0) { $this->db->rollback(); return -1; }

+            }

+            $this->db->commit();

+            return 1;

+        }

+    }

+

+

+    /**

+     * Overwrite magic function to solve problem of cloning object that are kept as references

+     *

+     * @return void

+     */

+    function __clone()

+    {

+        // Force a copy of this->lines, otherwise it will point to same object.

+        if (isset($this->lines) && is_array($this->lines))

+        {

+            $nboflines=count($this->lines);

+            for($i=0; $i < $nboflines; $i++)

+            {

+                $this->lines[$i] = clone $this->lines[$i];

+            }

+        }

+    }

+

+    /**

+     * Common function for all objects extending CommonObject for generating documents

+     *

+     * @param 	string 		$modelspath 	Relative folder where generators are placed

+     * @param 	string 		$modele 		Generator to use. Caller must set it to obj->modelpdf or GETPOST('modelpdf') for example.

+     * @param 	Translate 	$outputlangs 	Output language to use

+     * @param 	int 		$hidedetails 	1 to hide details. 0 by default

+     * @param 	int 		$hidedesc 		1 to hide product description. 0 by default

+     * @param 	int 		$hideref 		1 to hide product reference. 0 by default

+     * @param   null|array  $moreparams     Array to provide more information

+     * @return 	int 						>0 if OK, <0 if KO

+     * @see	addFileIntoDatabaseIndex

+     */

+    protected function commonGenerateDocument($modelspath, $modele, $outputlangs, $hidedetails, $hidedesc, $hideref, $moreparams=null)

+    {

+        global $conf, $langs, $user;

+

+        $srctemplatepath='';

+

+        // Increase limit for PDF build

+        $err=error_reporting();

+        error_reporting(0);

+        @set_time_limit(120);

+        error_reporting($err);

+

+        // If selected model is a filename template (then $modele="modelname" or "modelname:filename")

+        $tmp=explode(':',$modele,2);

+        if (! empty($tmp[1]))

+        {

+            $modele=$tmp[0];

+            $srctemplatepath=$tmp[1];

+        }

+

+        // Search template files

+        $file=''; $classname=''; $filefound=0;

+        $dirmodels=array('/');

+        if (is_array($conf->modules_parts['models'])) $dirmodels=array_merge($dirmodels,$conf->modules_parts['models']);

+        foreach($dirmodels as $reldir)

+        {

+            foreach(array('doc','pdf') as $prefix)

+            {

+                if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php";     // Member module use prefix_module.class.php

+                else $file = $prefix."_".$modele.".modules.php";

+

+                // On verifie l'emplacement du modele

+                $file=dol_buildpath($reldir.$modelspath.$file,0);

+                if (file_exists($file))

+                {

+                    $filefound=1;

+                    $classname=$prefix.'_'.$modele;

+                    break;

+                }

+            }

+            if ($filefound) break;

+        }

+

+        // If generator was found

+        if ($filefound)

+        {

+            global $db;  // Required to solve a conception default in commonstickergenerator.class.php making an include of code using $db

+

+            require_once $file;

+

+            $obj = new $classname($this->db);

+

+            // If generator is ODT, we must have srctemplatepath defined, if not we set it.

+            if ($obj->type == 'odt' && empty($srctemplatepath))

+            {

+                $varfortemplatedir=$obj->scandir;

+                if ($varfortemplatedir && ! empty($conf->global->$varfortemplatedir))

+                {

+                    $dirtoscan=$conf->global->$varfortemplatedir;

+

+                    $listoffiles=array();

+

+                    // Now we add first model found in directories scanned

+                    $listofdir=explode(',',$dirtoscan);

+                    foreach($listofdir as $key => $tmpdir)

+                    {

+                        $tmpdir=trim($tmpdir);

+                        $tmpdir=preg_replace('/DOL_DATA_ROOT/',DOL_DATA_ROOT,$tmpdir);

+                        if (! $tmpdir) { unset($listofdir[$key]); continue; }

+                        if (is_dir($tmpdir))

+                        {

+                            $tmpfiles=dol_dir_list($tmpdir,'files',0,'\.od(s|t)$','','name',SORT_ASC,0);

+                            if (count($tmpfiles)) $listoffiles=array_merge($listoffiles,$tmpfiles);

+                        }

+                    }

+

+                    if (count($listoffiles))

+                    {

+                        foreach($listoffiles as $record)

+                        {

+                            $srctemplatepath=$record['fullname'];

+                            break;

+                        }

+                    }

+                }

+

+                if (empty($srctemplatepath))

+                {

+                    $this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotDefined';

+                    return -1;

+                }

+            }

+

+            if ($obj->type == 'odt' && ! empty($srctemplatepath))

+            {

+                if (! dol_is_file($srctemplatepath))

+                {

+                    $this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotFound';

+                    return -1;

+                }

+            }

+

+            // We save charset_output to restore it because write_file can change it if needed for

+            // output format that does not support UTF8.

+            $sav_charset_output=$outputlangs->charset_output;

+

+            if (in_array(get_class($this), array('Adherent')))

+            {

+                $arrayofrecords = array();   // The write_file of templates of adherent class need this var

+                $resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, 'member', 1, $moreparams);

+            }

+            else

+            {

+                $resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, $hidedetails, $hidedesc, $hideref, $moreparams);

+            }

+            // After call of write_file $obj->result['fullpath'] is set with generated file. It will be used to update the ECM database index.

+

+            if ($resultwritefile > 0)

+            {

+                $outputlangs->charset_output=$sav_charset_output;

+

+                // We delete old preview

+                require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';

+                dol_delete_preview($this);

+

+                // Index file in database

+                if (! empty($obj->result['fullpath']))

+                {

+                    $destfull = $obj->result['fullpath'];

+                    $upload_dir = dirname($destfull);

+                    $destfile = basename($destfull);

+                    $rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $upload_dir);

+

+                    if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir

+                    {

+                        $filename = basename($destfile);

+                        $rel_dir = preg_replace('/[\\/]$/', '', $rel_dir);

+                        $rel_dir = preg_replace('/^[\\/]/', '', $rel_dir);

+

+                        include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';

+                        $ecmfile=new EcmFiles($this->db);

+                        $result = $ecmfile->fetch(0, '', ($rel_dir?$rel_dir.'/':'').$filename);

+

+                        // Set the public "share" key

+                        $setsharekey = false;

+                        if ($this->element == 'propal')

+                        {

+                            $useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL;	// Replace this with 1 when feature to make online signature is ok

+                            if ($useonlinesignature) $setsharekey=true;

+                            if (! empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

+                        }

+                        if ($this->element == 'commande'     && ! empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey=true;

+                        if ($this->element == 'facture'      && ! empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey=true;

+                        if ($this->element == 'bank_account' && ! empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

+

+                        if ($setsharekey)

+                        {

+                            if (empty($ecmfile->share))	// Because object not found or share not set yet

+                            {

+                                require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

+                                $ecmfile->share = getRandomPassword(true);

+                            }

+                        }

+

+                        if ($result > 0)

+                        {

+                            $ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

+                            $ecmfile->fullpath_orig = '';

+                            $ecmfile->gen_or_uploaded = 'generated';

+                            $ecmfile->description = '';    // indexed content

+                            $ecmfile->keyword = '';        // keyword content

+                            $result = $ecmfile->update($user);

+                            if ($result < 0)

+                            {

+                                setEventMessages($ecmfile->error, $ecmfile->errors, 'warnings');

+                            }

+                        }

+                        else

+                        {

+                            $ecmfile->entity = $conf->entity;

+                            $ecmfile->filepath = $rel_dir;

+                            $ecmfile->filename = $filename;

+                            $ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

+                            $ecmfile->fullpath_orig = '';

+                            $ecmfile->gen_or_uploaded = 'generated';

+                            $ecmfile->description = '';    // indexed content

+                            $ecmfile->keyword = '';        // keyword content

+                            $ecmfile->src_object_type = $this->table_element;

+                            $ecmfile->src_object_id   = $this->id;

+

+                            $result = $ecmfile->create($user);

+                            if ($result < 0)

+                            {

+                                setEventMessages($ecmfile->error, $ecmfile->errors, 'warnings');

+                            }

+                        }

+

+                        /*$this->result['fullname']=$destfull;

+						$this->result['filepath']=$ecmfile->filepath;

+						$this->result['filename']=$ecmfile->filename;*/

+                        //var_dump($obj->update_main_doc_field);exit;

+

+                        // Update the last_main_doc field into main object (if documenent generator has property ->update_main_doc_field set)

+                        $update_main_doc_field=0;

+                        if (! empty($obj->update_main_doc_field)) $update_main_doc_field=1;

+                        if ($update_main_doc_field && ! empty($this->table_element))

+                        {

+                            $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element." SET last_main_doc = '".($ecmfile->filepath.'/'.$ecmfile->filename)."'";

+                            $sql.= ' WHERE rowid = '.$this->id;

+                            $resql = $this->db->query($sql);

+                            if (! $resql) dol_print_error($this->db);

+                        }

+                    }

+                }

+                else

+                {

+                    dol_syslog('Method ->write_file was called on object '.get_class($obj).' and return a success but the return array ->result["fullpath"] was not set.', LOG_WARNING);

+                }

+

+                // Success in building document. We build meta file.

+                dol_meta_create($this);

+

+                return 1;

+            }

+            else

+            {

+                $outputlangs->charset_output=$sav_charset_output;

+                dol_print_error($this->db, "Error generating document for ".__CLASS__.". Error: ".$obj->error, $obj->errors);

+                return -1;

+            }

+        }

+        else

+        {

+            $this->error=$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);

+            dol_print_error('',$this->error);

+            return -1;

+        }

+    }

+

+    /**

+     *  Build thumb

+     *  @TODO Move this into files.lib.php

+     *

+     *  @param      string	$file           Path file in UTF8 to original file to create thumbs from.

+     *	@return		void

+     */

+    function addThumbs($file)

+    {

+        global $maxwidthsmall, $maxheightsmall, $maxwidthmini, $maxheightmini, $quality;

+

+        require_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';		// This define also $maxwidthsmall, $quality, ...

+

+        $file_osencoded=dol_osencode($file);

+        if (file_exists($file_osencoded))

+        {

+            // Create small thumbs for company (Ratio is near 16/9)

+            // Used on logon for example

+            vignette($file_osencoded, $maxwidthsmall, $maxheightsmall, '_small', $quality);

+

+            // Create mini thumbs for company (Ratio is near 16/9)

+            // Used on menu or for setup page for example

+            vignette($file_osencoded, $maxwidthmini, $maxheightmini, '_mini', $quality);

+        }

+    }

+

+

+    /* Functions common to commonobject and commonobjectline */

+

+    /* For default values */

+

+    /**

+     * Return the default value to use for a field when showing the create form of object.

+     * Return values in this order:

+     * 1) If parameter is available into POST, we return it first.

+     * 2) If not but an alternate value was provided as parameter of function, we return it.

+     * 3) If not but a constant $conf->global->OBJECTELEMENT_FIELDNAME is set, we return it (It is better to use the dedicated table).

+     * 4) Return value found into database (TODO No yet implemented)

+     *

+     * @param   string              $fieldname          Name of field

+     * @param   string              $alternatevalue     Alternate value to use

+     * @return  string|string[]                         Default value (can be an array if the GETPOST return an array)

+     **/

+    function getDefaultCreateValueFor($fieldname, $alternatevalue=null)

+    {

+        global $conf, $_POST;

+

+        // If param here has been posted, we use this value first.

+        if (isset($_POST[$fieldname])) return GETPOST($fieldname, 2);

+

+        if (isset($alternatevalue)) return $alternatevalue;

+

+        $newelement=$this->element;

+        if ($newelement == 'facture') $newelement='invoice';

+        if ($newelement == 'commande') $newelement='order';

+        if (empty($newelement))

+        {

+            dol_syslog("Ask a default value using common method getDefaultCreateValueForField on an object with no property ->element defined. Return empty string.", LOG_WARNING);

+            return '';

+        }

+

+        $keyforfieldname=strtoupper($newelement.'_DEFAULT_'.$fieldname);

+        //var_dump($keyforfieldname);

+        if (isset($conf->global->$keyforfieldname)) return $conf->global->$keyforfieldname;

+

+        // TODO Ad here a scan into table llx_overwrite_default with a filter on $this->element and $fieldname

+    }

+

+

+    /* For triggers */

+

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     * Call trigger based on this instance.

+     * Some context information may also be provided into array property this->context.

+     * NB:  Error from trigger are stacked in interface->errors

+     * NB2: If return code of triggers are < 0, action calling trigger should cancel all transaction.

+     *

+     * @param   string    $trigger_name   trigger's name to execute

+     * @param   User      $user           Object user

+     * @return  int                       Result of run_triggers

+     */

+    function call_trigger($trigger_name, $user)

+    {

+        // phpcs:enable

+        global $langs,$conf;

+

+        include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';

+        $interface=new Interfaces($this->db);

+        $result=$interface->run_triggers($trigger_name,$this,$user,$langs,$conf);

+

+        if ($result < 0)

+        {

+            if (!empty($this->errors))

+            {

+                $this->errors=array_unique(array_merge($this->errors,$interface->errors));   // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.

+            }

+            else

+            {

+                $this->errors=$interface->errors;

+            }

+        }

+        return $result;

+    }

+

+

+    /* Functions for extrafields */

+

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *  Function to get extra fields of an object into $this->array_options

+     *  This method is in most cases called by method fetch of objects but you can call it separately.

+     *

+     *  @param	int		$rowid			Id of line. Use the id of object if not defined. Deprecated. Function must be called without parameters.

+     *  @param  array	$optionsArray   Array resulting of call of extrafields->fetch_name_optionals_label(). Deprecated. Function must be called without parameters.

+     *  @return	int						<0 if error, 0 if no values of extrafield to find nor found, 1 if an attribute is found and value loaded

+     */

+    function fetch_optionals($rowid=null, $optionsArray=null)

+    {

+        // phpcs:enable

+        if (empty($rowid)) $rowid=$this->id;

+

+        // To avoid SQL errors. Probably not the better solution though

+        if (!$this->table_element) {

+            return 0;

+        }

+

+        $this->array_options=array();

+

+        if (! is_array($optionsArray))

+        {

+            // If $extrafields is not a known object, we initialize it. Best practice is to have $extrafields defined into card.php or list.php page.

+            // TODO Use of existing $extrafield is not yet ready (must mutualize code that use extrafields in form first)

+            // global $extrafields;

+            //if (! is_object($extrafields))

+            //{

+                // require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

+            $extrafields = new ExtraFields();

+            //}

+

+            // Load array of extrafields for elementype = $this->table_element

+            if (empty($extrafields->attributes[$this->table_element]['loaded']))

+            {

+                $extrafields->fetch_name_optionals_label($this->table_element);

+            }

+            $optionsArray = (! empty($extrafields->attributes[$this->table_element]['label'])?$extrafields->attributes[$this->table_element]['label']:null);

+        }

+        else

+        {

+            global $extrafields;

+            dol_syslog("Warning: fetch_optionals was called with param optionsArray defined when you should pass null now", LOG_WARNING);

+        }

+

+        $table_element = $this->table_element;

+        if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+

+        // Request to get complementary values

+        if (is_array($optionsArray) && count($optionsArray) > 0)

+        {

+            $sql = "SELECT rowid";

+            foreach ($optionsArray as $name => $label)

+            {

+                if (empty($extrafields->attributes[$this->table_element]['type'][$name]) || $extrafields->attributes[$this->table_element]['type'][$name] != 'separate')

+                {

+                    $sql.= ", ".$name;

+                }

+            }

+            $sql.= " FROM ".MAIN_DB_PREFIX.$table_element."_extrafields";

+            $sql.= " WHERE fk_object = ".$rowid;

+

+            //dol_syslog(get_class($this)."::fetch_optionals get extrafields data for ".$this->table_element, LOG_DEBUG);		// Too verbose

+            $resql=$this->db->query($sql);

+            if ($resql)

+            {

+                $this->array_options = array();

+                $numrows=$this->db->num_rows($resql);

+                if ($numrows)

+                {

+                    $tab = $this->db->fetch_array($resql);

+

+                    foreach ($tab as $key => $value)

+                    {

+                        // Test fetch_array ! is_int($key) because fetch_array result is a mix table with Key as alpha and Key as int (depend db engine)

+                        if ($key != 'rowid' && $key != 'tms' && $key != 'fk_member' && ! is_int($key))

+                        {

+                            // we can add this attribute to object

+                            if (! empty($extrafields) && in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date','datetime')))

+                            {

+                                //var_dump($extrafields->attributes[$this->table_element]['type'][$key]);

+                                $this->array_options["options_".$key]=$this->db->jdate($value);

+                            }

+                            else

+                            {

+                                $this->array_options["options_".$key]=$value;

+                            }

+

+                            //var_dump('key '.$key.' '.$value.' type='.$extrafields->attributes[$this->table_element]['type'][$key].' '.$this->array_options["options_".$key]);

+                        }

+                    }

+                }

+

+                $this->db->free($resql);

+

+                if ($numrows) return $numrows;

+                else return 0;

+            }

+            else

+            {

+                dol_print_error($this->db);

+                return -1;

+            }

+        }

+        return 0;

+    }

+

+    /**

+     *	Delete all extra fields values for the current object.

+     *

+     *  @return	int		<0 if KO, >0 if OK

+     */

+    function deleteExtraFields()

+    {

+        $this->db->begin();

+

+        $table_element = $this->table_element;

+        if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+

+        $sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

+        dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);

+        $resql=$this->db->query($sql_del);

+        if (! $resql)

+        {

+            $this->error=$this->db->lasterror();

+            $this->db->rollback();

+            return -1;

+        }

+        else

+        {

+            $this->db->commit();

+            return 1;

+        }

+    }

+

+    /**

+     *	Add/Update all extra fields values for the current object.

+     *  Data to describe values to insert/update are stored into $this->array_options=array('options_codeforfield1'=>'valueforfield1', 'options_codeforfield2'=>'valueforfield2', ...)

+     *  This function delete record with all extrafields and insert them again from the array $this->array_options.

+     *

+     *  @param	string		$trigger		If defined, call also the trigger (for example COMPANY_MODIFY)

+     *  @param	User		$userused		Object user

+     *  @return int 						-1=error, O=did nothing, 1=OK

+     *  @see updateExtraField, setValueFrom

+     */

+    function insertExtraFields($trigger='', $userused=null)

+    {

+        global $conf,$langs,$user;

+

+        if (empty($userused)) $userused=$user;

+

+        $error=0;

+

+        if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

+

+        if (! empty($this->array_options))

+        {

+            // Check parameters

+            $langs->load('admin');

+            require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

+            $extrafields = new ExtraFields($this->db);

+            $target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);

+

+            //Eliminate copied source object extra_fields that do not exist in target object

+            $new_array_options=array();

+            foreach ($this->array_options as $key => $value) {

+                if (in_array(substr($key,8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test

+                    $new_array_options[$key] = $value;

+                elseif (in_array($key, array_keys($target_extrafields)))		// We test on $key that does not contains the 'options_' prefix

+                    $new_array_options['options_'.$key] = $value;

+            }

+

+            foreach($new_array_options as $key => $value)

+            {

+                    $attributeKey      = substr($key,8);   // Remove 'options_' prefix

+                    $attributeType     = $extrafields->attributes[$this->table_element]['type'][$attributeKey];

+                    $attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$attributeKey];

+                    $attributeParam    = $extrafields->attributes[$this->table_element]['param'][$attributeKey];

+                    $attributeRequired = $extrafields->attributes[$this->table_element]['required'][$attributeKey];

+

+                    if ($attributeRequired)

+                    {

+                        $mandatorypb=false;

+                        if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb=true;

+                        if ($this->array_options[$key] === '') $mandatorypb=true;

+                        if ($mandatorypb)

+                        {

+                            dol_syslog($this->error);

+                            $this->errors[]=$langs->trans('ErrorFieldRequired', $attributeLabel);

+                            return -1;

+                        }

+                    }

+

+                //dol_syslog("attributeLabel=".$attributeLabel, LOG_DEBUG);

+                //dol_syslog("attributeType=".$attributeType, LOG_DEBUG);

+

+                    switch ($attributeType)

+                    {

+                        case 'int':

+                          if (!is_numeric($value) && $value!='')

+                            {

+                                $this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

+                                return -1;

+                            }

+                            elseif ($value=='')

+                            {

+                                $new_array_options[$key] = null;

+                            }

+                            break;

+                    case 'double':

+                        $value = price2num($value);

+                        if (!is_numeric($value) && $value!='')

+                        {

+                            dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

+                            $this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

+                            return -1;

+                        }

+                        elseif ($value=='')

+                        {

+                            $new_array_options[$key] = null;

+                        }

+                        //dol_syslog("double value"." sur ".$attributeLabel."(".$value." is '".$attributeType."')", LOG_DEBUG);

+                        $new_array_options[$key] = $value;

+                        break;

+                        /*case 'select':	// Not required, we chosed value='0' for undefined values

+             			if ($value=='-1')

+             			{

+             				$this->array_options[$key] = null;

+             			}

+             			break;*/

+                        case 'password':

+                           $algo='';

+                            if ($this->array_options[$key] != '' && is_array($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']))

+                            {

+                                // If there is an encryption choice, we use it to crypt data before insert

+                                $tmparrays = array_keys($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']);

+                                $algo=reset($tmparrays);

+                                if ($algo != '')

+                                {

+                                    //global $action;		// $action may be 'create', 'update', 'update_extras'...

+                                    //var_dump($action);

+                                    //var_dump($this->oldcopy);exit;

+                                    if (is_object($this->oldcopy))		// If this->oldcopy is not defined, we can't know if we change attribute or not, so we must keep value

+                                    {

+                                        //var_dump($this->oldcopy->array_options[$key]); var_dump($this->array_options[$key]);

+                                        if ($this->array_options[$key] == $this->oldcopy->array_options[$key])	// If old value crypted in database is same than submited new value, it means we don't change it, so we don't update.

+                                        {

+                                            $new_array_options[$key] = $this->array_options[$key];	// Value is kept

+                                        }

+                                    else

+                                    {

+                                        // var_dump($algo);

+                                        $newvalue = dol_hash($this->array_options[$key], $algo);

+                                        $new_array_options[$key] = $newvalue;

+                                    }

+                                    }

+                                    else

+                                    {

+                                        $new_array_options[$key] = $this->array_options[$key];	// Value is kept

+                                    }

+                                }

+                            }

+                            else	// Common usage

+                            {

+                                $new_array_options[$key] = $this->array_options[$key];

+                            }

+                            break;

+                        case 'price':

+                        $new_array_options[$key] = price2num($this->array_options[$key]);

+                        break;

+                    case 'date':

+                        $new_array_options[$key] = $this->db->idate($this->array_options[$key]);

+                        break;

+                    case 'datetime':

+                        // If data is a string instead of a timestamp, we convert it

+                        if (! is_int($this->array_options[$key])) {

+                            $this->array_options[$key] = strtotime($this->array_options[$key]);

+                        }

+                        $new_array_options[$key] = $this->db->idate($this->array_options[$key]);

+                        break;

+                        case 'link':

+                        $param_list=array_keys($attributeParam['options']);

+                        // 0 : ObjectName

+                        // 1 : classPath

+                        $InfoFieldList = explode(":", $param_list[0]);

+                        dol_include_once($InfoFieldList[1]);

+                        if ($InfoFieldList[0] && class_exists($InfoFieldList[0]))

+                        {

+                            if ($value == '-1')	// -1 is key for no defined in combo list of objects

+                            {

+                                $new_array_options[$key]='';

+                            }

+                            elseif ($value)

+                            {

+                                $object = new $InfoFieldList[0]($this->db);

+                                if (is_numeric($value)) $res=$object->fetch($value);

+                                else $res=$object->fetch('',$value);

+

+                                if ($res > 0) $new_array_options[$key]=$object->id;

+                                else

+                                {

+                                    $this->error="Id/Ref '".$value."' for object '".$object->element."' not found";

+                                    $this->db->rollback();

+                                    return -1;

+                                }

+                            }

+                        }

+                        else

+                        {

+                            dol_syslog('Error bad setup of extrafield', LOG_WARNING);

+                        }

+                        break;

+                    }

+            }

+

+            $this->db->begin();

+

+            $table_element = $this->table_element;

+            if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+

+            $sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

+            dol_syslog(get_class($this)."::insertExtraFields delete", LOG_DEBUG);

+            $this->db->query($sql_del);

+

+            $sql = "INSERT INTO ".MAIN_DB_PREFIX.$table_element."_extrafields (fk_object";

+            foreach($new_array_options as $key => $value)

+            {

+                $attributeKey = substr($key,8);   // Remove 'options_' prefix

+                // Add field of attribut

+                if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator

+                    $sql.=",".$attributeKey;

+            }

+            $sql .= ") VALUES (".$this->id;

+

+            foreach($new_array_options as $key => $value)

+            {

+                $attributeKey = substr($key,8);   // Remove 'options_' prefix

+                // Add field of attribute

+                if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator)

+                {

+                    if ($new_array_options[$key] != '')

+                    {

+                        $sql.=",'".$this->db->escape($new_array_options[$key])."'";

+                    }

+                    else

+                    {

+                        $sql.=",null";

+                    }

+                }

+            }

+            $sql.=")";

+

+            dol_syslog(get_class($this)."::insertExtraFields insert", LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if (! $resql)

+            {

+                $this->error=$this->db->lasterror();

+                $error++;

+            }

+

+            if (! $error && $trigger)

+            {

+                // Call trigger

+                $this->context=array('extrafieldaddupdate'=>1);

+                $result=$this->call_trigger($trigger, $userused);

+                if ($result < 0) $error++;

+                // End call trigger

+            }

+

+            if ($error)

+            {

+                $this->db->rollback();

+                return -1;

+            }

+            else

+            {

+                $this->db->commit();

+                return 1;

+            }

+        }

+        else return 0;

+    }

+

+    /**

+     *	Update an extra field value for the current object.

+     *  Data to describe values to update are stored into $this->array_options=array('options_codeforfield1'=>'valueforfield1', 'options_codeforfield2'=>'valueforfield2', ...)

+     *

+     *  @param  string      $key    		Key of the extrafield (without starting 'options_')

+     *  @param	string		$trigger		If defined, call also the trigger (for example COMPANY_MODIFY)

+     *  @param	User		$userused		Object user

+     *  @return int                 		-1=error, O=did nothing, 1=OK

+     *  @see setValueFrom, insertExtraFields

+     */

+    function updateExtraField($key, $trigger=null, $userused=null)

+    {

+        global $conf,$langs,$user;

+

+        if (empty($userused)) $userused=$user;

+

+        $error=0;

+

+        if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

+

+        if (! empty($this->array_options) && isset($this->array_options["options_".$key]))

+        {

+            // Check parameters

+            $langs->load('admin');

+            require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

+            $extrafields = new ExtraFields($this->db);

+            $target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);

+

+            $value=$this->array_options["options_".$key];

+

+            $attributeType     = $extrafields->attributes[$this->table_element]['type'][$key];

+            $attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$key];

+            $attributeParam    = $extrafields->attributes[$this->table_element]['param'][$key];

+            $attributeRequired = $extrafields->attributes[$this->table_element]['required'][$key];

+

+            //dol_syslog("attributeLabel=".$attributeLabel, LOG_DEBUG);

+            //dol_syslog("attributeType=".$attributeType, LOG_DEBUG);

+

+            switch ($attributeType)

+            {

+                case 'int':

+                    if (!is_numeric($value) && $value!='')

+                    {

+                        $this->errors[]=$langs->trans("ExtraFieldHasWrongValue",$attributeLabel);

+                        return -1;

+                    }

+                    elseif ($value=='')

+                    {

+                        $this->array_options["options_".$key] = null;

+                    }

+                    break;

+                case 'double':

+                    $value = price2num($value);

+                    if (!is_numeric($value) && $value!='')

+                    {

+                        dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

+                        $this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

+                        return -1;

+                    }

+                    elseif ($value=='')

+                    {

+                        $this->array_options["options_".$key] = null;

+                    }

+                    //dol_syslog("double value"." sur ".$attributeLabel."(".$value." is '".$attributeType."')", LOG_DEBUG);

+                    $this->array_options["options_".$key] = $value;

+                    break;

+                    /*case 'select':	// Not required, we chosed value='0' for undefined values

+             		if ($value=='-1')

+             		{

+             			$this->array_options[$key] = null;

+             		}

+             		break;*/

+                case 'price':

+                    $this->array_options["options_".$key] = price2num($this->array_options["options_".$key]);

+                    break;

+                case 'date':

+                    $this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);

+                    break;

+                case 'datetime':

+                    $this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);

+                    break;

+                case 'link':

+                    $param_list=array_keys($attributeParam['options']);

+                    // 0 : ObjectName

+                    // 1 : classPath

+                    $InfoFieldList = explode(":", $param_list[0]);

+                    dol_include_once($InfoFieldList[1]);

+                    if ($value)

+                    {

+                        $object = new $InfoFieldList[0]($this->db);

+                        $object->fetch(0,$value);

+                        $this->array_options["options_".$key]=$object->id;

+                    }

+                    break;

+            }

+

+            $this->db->begin();

+            $sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element."_extrafields SET ".$key."='".$this->db->escape($this->array_options["options_".$key])."'";

+            $sql .= " WHERE fk_object = ".$this->id;

+            $resql = $this->db->query($sql);

+            if (! $resql)

+            {

+                $error++;

+                $this->error=$this->db->lasterror();

+            }

+

+            if (! $error && $trigger)

+            {

+                // Call trigger

+                $this->context=array('extrafieldupdate'=>1);

+                $result=$this->call_trigger($trigger, $userused);

+                if ($result < 0) $error++;

+                // End call trigger

+            }

+

+            if ($error)

+            {

+                dol_syslog(get_class($this) . "::".__METHOD__ . $this->error, LOG_ERR);

+                $this->db->rollback();

+                return -1;

+            }

+            else

+            {

+                $this->db->commit();

+                return 1;

+            }

+        }

+        else return 0;

+    }

+

+

+    /**

+     * Return HTML string to put an input field into a page

+     * Code very similar with showInputField of extra fields

+     *

+     * @param  array   		$val	       Array of properties for field to show

+     * @param  string  		$key           Key of attribute

+     * @param  string  		$value         Preselected value to show (for date type it must be in timestamp format, for amount or price it must be a php numeric value)

+     * @param  string  		$moreparam     To add more parameters on html input tag

+     * @param  string  		$keysuffix     Prefix string to add into name and id of field (can be used to avoid duplicate names)

+     * @param  string  		$keyprefix     Suffix string to add into name and id of field (can be used to avoid duplicate names)

+     * @param  string|int		$morecss       Value for css to define style/length of field. May also be a numeric.

+     * @return string

+     */

+    function showInputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $morecss=0)

+    {

+        global $conf,$langs,$form;

+

+        if (! is_object($form))

+        {

+            require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';

+            $form=new Form($this->db);

+        }

+

+        $val=$this->fields[$key];

+

+        $out='';

+        $type='';

+        $param = array();

+        $param['options']=array();

+        $size =$this->fields[$key]['size'];

+        // Because we work on extrafields

+        if(preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)){

+            $param['options']=array($reg[1].':'.$reg[2]=>'N');

+            $type ='link';

+        } elseif(preg_match('/^link:(.*):(.*)/i', $val['type'], $reg)) {

+            $param['options']=array($reg[1].':'.$reg[2]=>'N');

+            $type ='link';

+        } elseif(preg_match('/^sellist:(.*):(.*):(.*):(.*)/i', $val['type'], $reg)) {

+            $param['options']=array($reg[1].':'.$reg[2].':'.$reg[3].':'.$reg[4]=>'N');

+            $type ='sellist';

+        } elseif(preg_match('/varchar\((\d+)\)/', $val['type'],$reg)) {

+            $param['options']=array();

+            $type ='varchar';

+            $size=$reg[1];

+        } elseif(preg_match('/varchar/', $val['type'])) {

+            $param['options']=array();

+            $type ='varchar';

+        } elseif(is_array($this->fields[$key]['arrayofkeyval'])) {

+            $param['options']=$this->fields[$key]['arrayofkeyval'];

+            $type ='select';

+        } else {

+            $param['options']=array();

+            $type =$this->fields[$key]['type'];

+        }

 

-				$fields_label = explode('|', $InfoFieldList[1]);

-				if (is_array($fields_label)) {

-					$keyList .= ', ';

-					$keyList .= implode(', ', $fields_label);

-				}

+        $label=$this->fields[$key]['label'];

+        //$elementtype=$this->fields[$key]['elementtype'];	// Seems not used

+        $default=$this->fields[$key]['default'];

+        $computed=$this->fields[$key]['computed'];

+        $unique=$this->fields[$key]['unique'];

+        $required=$this->fields[$key]['required'];

+

+        $langfile=$this->fields[$key]['langfile'];

+        $list=$this->fields[$key]['list'];

+        $hidden=abs($this->fields[$key]['visible'])!=1?1:0;

+

+        $objectid = $this->id;

+

+

+        if ($computed)

+        {

+            if (! preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';

+            else return '';

+        }

+

+

+        // Use in priority showsize from parameters, then $val['css'] then autodefine

+        if (empty($morecss) && ! empty($val['css']))

+        {

+            $showsize = $val['css'];

+        }

+        if (empty($morecss))

+        {

+            if ($type == 'date')

+            {

+                $morecss = 'minwidth100imp';

+            }

+            elseif ($type == 'datetime')

+            {

+                $morecss = 'minwidth200imp';

+            }

+            elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+            {

+                $morecss = 'maxwidth75';

+                        }elseif ($type == 'url')

+            {

+                $morecss='minwidth400';

+            }

+            elseif ($type == 'boolean')

+            {

+                $morecss='';

+            }

+            else

+            {

+                if (round($size) < 12)

+                {

+                    $morecss = 'minwidth100';

+                }

+                else if (round($size) <= 48)

+                {

+                    $morecss = 'minwidth200';

+                }

+                else

+                {

+                    $morecss = 'minwidth400';

+                }

+            }

+        }

+

+        if (in_array($type,array('date','datetime')))

+        {

+            $tmp=explode(',',$size);

+            $newsize=$tmp[0];

+

+            $showtime = in_array($type,array('datetime')) ? 1 : 0;

+

+            // Do not show current date when field not required (see selectDate() method)

+            if (!$required && $value == '') $value = '-1';

+

+            // TODO Must also support $moreparam

+            $out = $form->selectDate($value, $keyprefix.$key.$keysuffix, $showtime, $showtime, $required, '', 1, (($keyprefix != 'search_' && $keyprefix != 'search_options_') ? 1 : 0), 0, 1);

+        }

+        elseif (in_array($type,array('int','integer')))

+        {

+            $tmp=explode(',',$size);

+            $newsize=$tmp[0];

+            $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

+        }

+        elseif (preg_match('/varchar/', $type))

+        {

+            $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

+        }

+        elseif (in_array($type, array('mail', 'phone', 'url')))

+        {

+            $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

+        }

+        elseif ($type == 'text')

+        {

+            if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+            {

+                require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

+                $doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,false,ROWS_5,'90%');

+                $out=$doleditor->Create(1);

+            }

+            else

+            {

+                $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

+            }

+        }

+        elseif ($type == 'html')

+        {

+            if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+            {

+                require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

+                $doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,! empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE,ROWS_5,'90%');

+                $out=$doleditor->Create(1);

+            }

+            else

+            {

+                $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

+            }

+        }

+        elseif ($type == 'boolean')

+        {

+            $checked='';

+            if (!empty($value)) {

+                $checked=' checked value="1" ';

+            } else {

+                $checked=' value="1" ';

+            }

+            $out='<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam?$moreparam:'').'>';

+        }

+        elseif ($type == 'price')

+        {

+            if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

+                $value=price($value);

+            }

+            $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> '.$langs->getCurrencySymbol($conf->currency);

+        }

+        elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+        {

+            if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

+                $value=price($value);

+            }

+            $out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> ';

+        }

+        elseif ($type == 'select')

+        {

+            $out = '';

+            if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

+            {

+                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                $out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

+            }

+

+            $out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

+                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1))$out.='<option value="0">&nbsp;</option>';

+            foreach ($param['options'] as $key => $val)

+            {

+                if ((string) $key == '') continue;

+                list($val, $parent) = explode('|', $val);

+                $out.='<option value="'.$key.'"';

+                $out.= (((string) $value == (string) $key)?' selected':'');

+                $out.= (!empty($parent)?' parent="'.$parent.'"':'');

+                $out.='>'.$val.'</option>';

+            }

+            $out.='</select>';

+        }

+        elseif ($type == 'sellist')

+        {

+            $out = '';

+            if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

+            {

+                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                $out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

+            }

+

+            $out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

+            if (is_array($param['options']))

+            {

+                $param_list=array_keys($param['options']);

+                $InfoFieldList = explode(":", $param_list[0]);

+                $parentName='';

+                $parentField='';

+                // 0 : tableName

+                // 1 : label field name

+                // 2 : key fields name (if differ of rowid)

+                // 3 : key field parent (for dependent lists)

+                // 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value

+                $keyList=(empty($InfoFieldList[2])?'rowid':$InfoFieldList[2].' as rowid');

+

+

+                if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4]))

+                {

+                    if (strpos($InfoFieldList[4], 'extra.') !== false)

+                    {

+                        $keyList='main.'.$InfoFieldList[2].' as rowid';

+                    } else {

+                        $keyList=$InfoFieldList[2].' as rowid';

+                    }

+                }

+                if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3]))

+                {

+                    list($parentName, $parentField) = explode('|', $InfoFieldList[3]);

+                    $keyList.= ', '.$parentField;

+                }

+

+                $fields_label = explode('|',$InfoFieldList[1]);

+                if (is_array($fields_label))

+                {

+                    $keyList .=', ';

+                    $keyList .= implode(', ', $fields_label);

+                }

+

+                $sqlwhere='';

+                $sql = 'SELECT '.$keyList;

+                $sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];

+                if (!empty($InfoFieldList[4]))

+                {

+                    // can use SELECT request

+                    if (strpos($InfoFieldList[4], '$SEL$')!==false) {

+                        $InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);

+                    }

+

+                    // current object id can be use into filter

+                    if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {

+                        $InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);

+                    } else {

+                        $InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);

+                    }

+                    //We have to join on extrafield table

+                    if (strpos($InfoFieldList[4], 'extra')!==false)

+                    {

+                        $sql.= ' as main, '.MAIN_DB_PREFIX .$InfoFieldList[0].'_extrafields as extra';

+                        $sqlwhere.= ' WHERE extra.fk_object=main.'.$InfoFieldList[2]. ' AND '.$InfoFieldList[4];

+                    }

+                    else

+                    {

+                        $sqlwhere.= ' WHERE '.$InfoFieldList[4];

+                    }

+                }

+                else

+                {

+                    $sqlwhere.= ' WHERE 1=1';

+                }

+                // Some tables may have field, some other not. For the moment we disable it.

+                if (in_array($InfoFieldList[0],array('tablewithentity')))

+                {

+                    $sqlwhere.= ' AND entity = '.$conf->entity;

+                }

+                $sql.=$sqlwhere;

+                //print $sql;

+

+                $sql .= ' ORDER BY ' . implode(', ', $fields_label);

+

+                dol_syslog(get_class($this).'::showInputField type=sellist', LOG_DEBUG);

+                $resql = $this->db->query($sql);

+                if ($resql)

+                {

+                    $out.='<option value="0">&nbsp;</option>';

+                    $num = $this->db->num_rows($resql);

+                    $i = 0;

+                    while ($i < $num)

+                    {

+                        $labeltoshow='';

+                        $obj = $this->db->fetch_object($resql);

+

+                        // Several field into label (eq table:code|libelle:rowid)

+                        $notrans = false;

+                        $fields_label = explode('|',$InfoFieldList[1]);

+                        if (is_array($fields_label))

+                        {

+                            $notrans = true;

+                            foreach ($fields_label as $field_toshow)

+                            {

+                                $labeltoshow.= $obj->$field_toshow.' ';

+                            }

+                        }

+                        else

+                        {

+                            $labeltoshow=$obj->{$InfoFieldList[1]};

+                        }

+                        $labeltoshow=dol_trunc($labeltoshow,45);

+

+                        if ($value == $obj->rowid)

+                        {

+                            foreach ($fields_label as $field_toshow)

+                            {

+                                $translabel=$langs->trans($obj->$field_toshow);

+                                if ($translabel!=$obj->$field_toshow) {

+                                    $labeltoshow=dol_trunc($translabel,18).' ';

+                                }else {

+                                    $labeltoshow=dol_trunc($obj->$field_toshow,18).' ';

+                                }

+                            }

+                            $out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

+                        }

+                        else

+                        {

+                            if (! $notrans)

+                            {

+                                $translabel=$langs->trans($obj->{$InfoFieldList[1]});

+                                if ($translabel!=$obj->{$InfoFieldList[1]}) {

+                                    $labeltoshow=dol_trunc($translabel,18);

+                                }

+                                else {

+                                    $labeltoshow=dol_trunc($obj->{$InfoFieldList[1]},18);

+                                }

+                            }

+                            if (empty($labeltoshow)) $labeltoshow='(not defined)';

+                            if ($value==$obj->rowid)

+                            {

+                                $out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

+                            }

+

+                            if (!empty($InfoFieldList[3]) && $parentField)

+                            {

+                                $parent = $parentName.':'.$obj->{$parentField};

+                            }

+

+                            $out.='<option value="'.$obj->rowid.'"';

+                            $out.= ($value==$obj->rowid?' selected':'');

+                            $out.= (!empty($parent)?' parent="'.$parent.'"':'');

+                            $out.='>'.$labeltoshow.'</option>';

+                        }

+

+                        $i++;

+                    }

+                    $this->db->free($resql);

+                }

+                else {

+                    print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';

+                }

+            }

+            $out.='</select>';

+        }

+        elseif ($type == 'checkbox')

+        {

+            $value_arr=explode(',',$value);

+            $out=$form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options'])?null:$param['options']), $value_arr, '', 0, '', 0, '100%');

+        }

+        elseif ($type == 'radio')

+        {

+            $out='';

+            foreach ($param['options'] as $keyopt => $val)

+            {

+                $out.='<input class="flat '.$morecss.'" type="radio" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'');

+                $out.=' value="'.$keyopt.'"';

+                $out.=' id="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'"';

+                $out.= ($value==$keyopt?'checked':'');

+                $out.='/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';

+            }

+        }

+        elseif ($type == 'chkbxlst')

+        {

+            if (is_array($value)) {

+                $value_arr = $value;

+            }

+            else {

+                $value_arr = explode(',', $value);

+            }

+

+            if (is_array($param['options'])) {

+                $param_list = array_keys($param['options']);

+                $InfoFieldList = explode(":", $param_list[0]);

+                $parentName='';

+                $parentField='';

+                // 0 : tableName

+                // 1 : label field name

+                // 2 : key fields name (if differ of rowid)

+                // 3 : key field parent (for dependent lists)

+                // 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value

+                $keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2] . ' as rowid');

+

+                if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3])) {

+                    list ( $parentName, $parentField ) = explode('|', $InfoFieldList[3]);

+                    $keyList .= ', ' . $parentField;

+                }

+                if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4])) {

+                    if (strpos($InfoFieldList[4], 'extra.') !== false) {

+                        $keyList = 'main.' . $InfoFieldList[2] . ' as rowid';

+                    } else {

+                        $keyList = $InfoFieldList[2] . ' as rowid';

+                    }

+                }

+

+                $fields_label = explode('|', $InfoFieldList[1]);

+                if (is_array($fields_label)) {

+                    $keyList .= ', ';

+                    $keyList .= implode(', ', $fields_label);

+                }

+

+                $sqlwhere = '';

+                $sql = 'SELECT ' . $keyList;

+                $sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];

+                if (! empty($InfoFieldList[4])) {

+

+                    // can use SELECT request

+                    if (strpos($InfoFieldList[4], '$SEL$')!==false) {

+                        $InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);

+                    }

+

+                    // current object id can be use into filter

+                    if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {

+                        $InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);

+                    } else {

+                        $InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);

+                    }

+

+                    // We have to join on extrafield table

+                    if (strpos($InfoFieldList[4], 'extra') !== false) {

+                        $sql .= ' as main, ' . MAIN_DB_PREFIX . $InfoFieldList[0] . '_extrafields as extra';

+                        $sqlwhere .= ' WHERE extra.fk_object=main.' . $InfoFieldList[2] . ' AND ' . $InfoFieldList[4];

+                    } else {

+                        $sqlwhere .= ' WHERE ' . $InfoFieldList[4];

+                    }

+                } else {

+                    $sqlwhere .= ' WHERE 1=1';

+                }

+                // Some tables may have field, some other not. For the moment we disable it.

+                if (in_array($InfoFieldList[0], array ('tablewithentity')))

+                {

+                    $sqlwhere .= ' AND entity = ' . $conf->entity;

+                }

+                // $sql.=preg_replace('/^ AND /','',$sqlwhere);

+                // print $sql;

+

+                $sql .= $sqlwhere;

+                dol_syslog(get_class($this) . '::showInputField type=chkbxlst',LOG_DEBUG);

+                $resql = $this->db->query($sql);

+                if ($resql) {

+                    $num = $this->db->num_rows($resql);

+                    $i = 0;

+

+                    $data=array();

+

+                    while ( $i < $num ) {

+                        $labeltoshow = '';

+                        $obj = $this->db->fetch_object($resql);

+

+                        $notrans = false;

+                        // Several field into label (eq table:code|libelle:rowid)

+                        $fields_label = explode('|', $InfoFieldList[1]);

+                        if (is_array($fields_label)) {

+                            $notrans = true;

+                            foreach ( $fields_label as $field_toshow ) {

+                                $labeltoshow .= $obj->$field_toshow . ' ';

+                            }

+                        } else {

+                            $labeltoshow = $obj->{$InfoFieldList[1]};

+                        }

+                        $labeltoshow = dol_trunc($labeltoshow, 45);

+

+                        if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

+                            foreach ( $fields_label as $field_toshow ) {

+                                $translabel = $langs->trans($obj->$field_toshow);

+                                if ($translabel != $obj->$field_toshow) {

+                                    $labeltoshow = dol_trunc($translabel, 18) . ' ';

+                                } else {

+                                    $labeltoshow = dol_trunc($obj->$field_toshow, 18) . ' ';

+                                }

+                            }

+

+                            $data[$obj->rowid]=$labeltoshow;

+                        } else {

+                            if (! $notrans) {

+                                $translabel = $langs->trans($obj->{$InfoFieldList[1]});

+                                if ($translabel != $obj->{$InfoFieldList[1]}) {

+                                    $labeltoshow = dol_trunc($translabel, 18);

+                                } else {

+                                    $labeltoshow = dol_trunc($obj->{$InfoFieldList[1]}, 18);

+                                }

+                            }

+                            if (empty($labeltoshow))

+                                $labeltoshow = '(not defined)';

+

+                                if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

+                                    $data[$obj->rowid]=$labeltoshow;

+                                }

+

+                                if (! empty($InfoFieldList[3]) && $parentField) {

+                                    $parent = $parentName . ':' . $obj->{$parentField};

+                                }

+

+                                $data[$obj->rowid]=$labeltoshow;

+                        }

+

+                        $i ++;

+                    }

+                    $this->db->free($resql);

+

+                    $out=$form->multiselectarray($keyprefix.$key.$keysuffix, $data, $value_arr, '', 0, '', 0, '100%');

+                } else {

+                    print 'Error in request ' . $sql . ' ' . $this->db->lasterror() . '. Check setup of extra parameters.<br>';

+                }

+            }

+        }

+        elseif ($type == 'link')

+        {

+            $param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

+            $showempty=(($required && $default != '')?0:1);

+            $out=$form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);

+            if ($conf->global->MAIN_FEATURES_LEVEL >= 2)

+            {

+                        list($class,$classfile)=explode(':',$param_list[0]);

+                        if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);

+                        else $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);

+                        $out.='<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';

+                        // TODO Add Javascript code to add input fields contents to new elements urls

+            }

+        }

+        elseif ($type == 'password')

+        {

+            // If prefix is 'search_', field is used as a filter, we use a common text field.

+            $out='<input type="'.($keyprefix=='search_'?'text':'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'>';

+        }

+        elseif ($type == 'array')

+        {

+            $newval = $val;

+            $newval['type'] = 'varchar(256)';

+

+            $out='';

+

+            $inputs = array();

+            if(! empty($value)) {

+                foreach($value as $option) {

+                    $out.= '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

+                    $out.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', $option, $moreparam, '', '', $showsize).'<br></span>';

+                }

+            }

+

+            $out.= '<a id="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_add" href="javascript:;"><span class="fa fa-plus-circle valignmiddle"></span></a>';

+

+            $newInput = '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

+            $newInput.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', '', $moreparam, '', '', $showsize).'<br></span>';

+

+            if(! empty($conf->use_javascript_ajax)) {

+                $out.= '

+					<script type="text/javascript">

+					$(document).ready(function() {

+						$("a#'.dol_escape_js($keyprefix.$key.$keysuffix).'_add").click(function() {

+							$("'.dol_escape_js($newInput).'").insertBefore(this);

+						});

+

+						$(document).on("click", "a.'.dol_escape_js($keyprefix.$key.$keysuffix).'_del", function() {

+							$(this).parent().remove();

+						});

+					});

+					</script>';

+            }

+        }

+        if (!empty($hidden)) {

+            $out='<input type="hidden" value="'.$value.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'"/>';

+        }

+        /* Add comments

+		 if ($type == 'date') $out.=' (YYYY-MM-DD)';

+		 elseif ($type == 'datetime') $out.=' (YYYY-MM-DD HH:MM:SS)';

+		 */

+        return $out;

+    }

+

+    /**

+     * Return HTML string to show a field into a page

+     * Code very similar with showOutputField of extra fields

+     *

+     * @param  array   $val		       Array of properties of field to show

+     * @param  string  $key            Key of attribute

+     * @param  string  $value          Preselected value to show (for date type it must be in timestamp format, for amount or price it must be a php numeric value)

+     * @param  string  $moreparam      To add more parametes on html input tag

+     * @param  string  $keysuffix      Prefix string to add into name and id of field (can be used to avoid duplicate names)

+     * @param  string  $keyprefix      Suffix string to add into name and id of field (can be used to avoid duplicate names)

+     * @param  mixed   $showsize       Value for css to define size. May also be a numeric.

+     * @return string

+     */

+    function showOutputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $showsize=0)

+    {

+        global $conf,$langs,$form;

+

+        if (! is_object($form))

+        {

+            require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';

+            $form=new Form($this->db);

+        }

+

+        $objectid = $this->id;

+        $label = $val['label'];

+        $type  = $val['type'];

+        $size  = $val['css'];

+

+        // Convert var to be able to share same code than showOutputField of extrafields

+        if (preg_match('/varchar\((\d+)\)/', $type, $reg))

+        {

+            $type = 'varchar';		// convert varchar(xx) int varchar

+            $size = $reg[1];

+        }

+        elseif (preg_match('/varchar/', $type)) $type = 'varchar';		// convert varchar(xx) int varchar

+        if (is_array($val['arrayofkeyval'])) $type='select';

+        if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type='link';

+

+        $default=$val['default'];

+        $computed=$val['computed'];

+        $unique=$val['unique'];

+        $required=$val['required'];

+        $param=$val['param'];

+        if (is_array($val['arrayofkeyval'])) $param['options'] = $val['arrayofkeyval'];

+        if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg))

+        {

+            $type='link';

+            $param['options']=array($reg[1].':'.$reg[2]=>$reg[1].':'.$reg[2]);

+        }

+        $langfile=$val['langfile'];

+        $list=$val['list'];

+        $help=$val['help'];

+        $hidden=(($val['visible'] == 0) ? 1 : 0);			// If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)

+

+        if ($hidden) return '';

+

+        // If field is a computed field, value must become result of compute

+        if ($computed)

+        {

+            // Make the eval of compute string

+            //var_dump($computed);

+            $value = dol_eval($computed, 1, 0);

+        }

+

+        if (empty($showsize))

+        {

+            if ($type == 'date')

+            {

+                //$showsize=10;

+                $showsize = 'minwidth100imp';

+            }

+            elseif ($type == 'datetime')

+            {

+                //$showsize=19;

+                $showsize = 'minwidth200imp';

+            }

+            elseif (in_array($type,array('int','double','price')))

+            {

+                //$showsize=10;

+                $showsize = 'maxwidth75';

+            }

+            elseif ($type == 'url')

+            {

+                $showsize='minwidth400';

+            }

+            elseif ($type == 'boolean')

+            {

+                $showsize='';

+            }

+            else

+            {

+                if (round($size) < 12)

+                {

+                    $showsize = 'minwidth100';

+                }

+                else if (round($size) <= 48)

+                {

+                    $showsize = 'minwidth200';

+                }

+                else

+                {

+                    //$showsize=48;

+                    $showsize = 'minwidth400';

+                }

+            }

+        }

+

+        // Format output value differently according to properties of field

+        if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value=$this->getNomUrl(1, '', 0, '', 1);

+        elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value=$this->getLibStatut(3);

+        elseif ($type == 'date')

+        {

+            if(! empty($value)) {

+                $value=dol_print_date($value,'day');

+            } else {

+                $value='';

+            }

+        }

+        elseif ($type == 'datetime')

+        {

+            if(! empty($value)) {

+                $value=dol_print_date($value,'dayhour');

+            } else {

+                $value='';

+            }

+        }

+        elseif ($type == 'double')

+        {

+            if (!empty($value)) {

+                $value=price($value);

+            }

+        }

+        elseif ($type == 'boolean')

+        {

+            $checked='';

+            if (!empty($value)) {

+                $checked=' checked ';

+            }

+            $value='<input type="checkbox" '.$checked.' '.($moreparam?$moreparam:'').' readonly disabled>';

+        }

+        elseif ($type == 'mail')

+        {

+            $value=dol_print_email($value,0,0,0,64,1,1);

+        }

+        elseif ($type == 'url')

+        {

+            $value=dol_print_url($value,'_blank',32,1);

+        }

+        elseif ($type == 'phone')

+        {

+            $value=dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);

+        }

+        elseif ($type == 'price')

+        {

+            $value=price($value,0,$langs,0,0,-1,$conf->currency);

+        }

+        elseif ($type == 'select')

+        {

+            $value=$param['options'][$value];

+        }

+        elseif ($type == 'sellist')

+        {

+            $param_list=array_keys($param['options']);

+            $InfoFieldList = explode(":", $param_list[0]);

+

+            $selectkey="rowid";

+            $keyList='rowid';

+

+            if (count($InfoFieldList)>=3)

+            {

+                $selectkey = $InfoFieldList[2];

+                $keyList=$InfoFieldList[2].' as rowid';

+            }

+

+            $fields_label = explode('|',$InfoFieldList[1]);

+            if(is_array($fields_label)) {

+                $keyList .=', ';

+                $keyList .= implode(', ', $fields_label);

+            }

+

+            $sql = 'SELECT '.$keyList;

+            $sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];

+            if (strpos($InfoFieldList[4], 'extra')!==false)

+            {

+                $sql.= ' as main';

+            }

+            if ($selectkey=='rowid' && empty($value)) {

+                $sql.= " WHERE ".$selectkey."=0";

+            } elseif ($selectkey=='rowid') {

+                $sql.= " WHERE ".$selectkey."=".$this->db->escape($value);

+            }else {

+                $sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

+            }

+

+            //$sql.= ' AND entity = '.$conf->entity;

+

+            dol_syslog(get_class($this).':showOutputField:$type=sellist', LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if ($resql)

+            {

+                $value='';	// value was used, so now we reste it to use it to build final output

+

+                $obj = $this->db->fetch_object($resql);

+

+                // Several field into label (eq table:code|libelle:rowid)

+                $fields_label = explode('|',$InfoFieldList[1]);

+

+                if(is_array($fields_label) && count($fields_label)>1)

+                {

+                    foreach ($fields_label as $field_toshow)

+                    {

+                        $translabel='';

+                        if (!empty($obj->$field_toshow)) {

+                            $translabel=$langs->trans($obj->$field_toshow);

+                        }

+                        if ($translabel!=$field_toshow) {

+                            $value.=dol_trunc($translabel,18).' ';

+                        }else {

+                            $value.=$obj->$field_toshow.' ';

+                        }

+                    }

+                }

+                else

+                {

+                    $translabel='';

+                    if (!empty($obj->{$InfoFieldList[1]})) {

+                        $translabel=$langs->trans($obj->{$InfoFieldList[1]});

+                    }

+                    if ($translabel!=$obj->{$InfoFieldList[1]}) {

+                        $value=dol_trunc($translabel,18);

+                    }else {

+                        $value=$obj->{$InfoFieldList[1]};

+                    }

+                }

+            }

+            else dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);

+        }

+        elseif ($type == 'radio')

+        {

+            $value=$param['options'][$value];

+        }

+        elseif ($type == 'checkbox')

+        {

+            $value_arr=explode(',',$value);

+            $value='';

+            if (is_array($value_arr) && count($value_arr)>0)

+            {

+                foreach ($value_arr as $keyval=>$valueval) {

+                    $toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$param['options'][$valueval].'</li>';

+                }

+                $value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

+            }

+        }

+        elseif ($type == 'chkbxlst')

+        {

+            $value_arr = explode(',', $value);

+

+            $param_list = array_keys($param['options']);

+            $InfoFieldList = explode(":", $param_list[0]);

+

+            $selectkey = "rowid";

+            $keyList = 'rowid';

+

+            if (count($InfoFieldList) >= 3) {

+                $selectkey = $InfoFieldList[2];

+                $keyList = $InfoFieldList[2] . ' as rowid';

+            }

+

+            $fields_label = explode('|', $InfoFieldList[1]);

+            if (is_array($fields_label)) {

+                $keyList .= ', ';

+                $keyList .= implode(', ', $fields_label);

+            }

+

+            $sql = 'SELECT ' . $keyList;

+            $sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];

+            if (strpos($InfoFieldList[4], 'extra') !== false) {

+                $sql .= ' as main';

+            }

+            // $sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

+            // $sql.= ' AND entity = '.$conf->entity;

+

+            dol_syslog(get_class($this) . ':showOutputField:$type=chkbxlst',LOG_DEBUG);

+            $resql = $this->db->query($sql);

+            if ($resql) {

+                $value = ''; // value was used, so now we reste it to use it to build final output

+                $toprint=array();

+                while ( $obj = $this->db->fetch_object($resql) ) {

+

+                    // Several field into label (eq table:code|libelle:rowid)

+                    $fields_label = explode('|', $InfoFieldList[1]);

+                    if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

+                        if (is_array($fields_label) && count($fields_label) > 1) {

+                            foreach ( $fields_label as $field_toshow ) {

+                                $translabel = '';

+                                if (! empty($obj->$field_toshow)) {

+                                    $translabel = $langs->trans($obj->$field_toshow);

+                                }

+                                if ($translabel != $field_toshow) {

+                                    $toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

+                                } else {

+                                    $toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->$field_toshow.'</li>';

+                                }

+                            }

+                        } else {

+                            $translabel = '';

+                            if (! empty($obj->{$InfoFieldList[1]})) {

+                                $translabel = $langs->trans($obj->{$InfoFieldList[1]});

+                            }

+                            if ($translabel != $obj->{$InfoFieldList[1]}) {

+                                $toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

+                            } else {

+                                $toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->{$InfoFieldList[1]}.'</li>';

+                            }

+                        }

+                    }

+                }

+                $value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

+            } else {

+                dol_syslog(get_class($this) . '::showOutputField error ' . $this->db->lasterror(), LOG_WARNING);

+            }

+        }

+        elseif ($type == 'link')

+        {

+            $out='';

+

+            // only if something to display (perf)

+            if ($value)

+            {

+                $param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

+

+                $InfoFieldList = explode(":", $param_list[0]);

+                $classname=$InfoFieldList[0];

+                $classpath=$InfoFieldList[1];

+                $getnomurlparam=(empty($InfoFieldList[2]) ? 3 : $InfoFieldList[2]);

+                if (! empty($classpath))

+                {

+                    dol_include_once($InfoFieldList[1]);

+                    if ($classname && class_exists($classname))

+                    {

+                        $object = new $classname($this->db);

+                        $object->fetch($value);

+                        $value=$object->getNomUrl($getnomurlparam);

+                    }

+                }

+                else

+                {

+                    dol_syslog('Error bad setup of extrafield', LOG_WARNING);

+                    return 'Error bad setup of extrafield';

+                }

+            }

+            else $value='';

+        }

+        elseif ($type == 'text' || $type == 'html')

+        {

+            $value=dol_htmlentitiesbr($value);

+        }

+        elseif ($type == 'password')

+        {

+            $value=preg_replace('/./i','*',$value);

+        }

+        elseif ($type == 'array')

+        {

+            $value = implode('<br>', $value);

+        }

+

+        //print $type.'-'.$size;

+        $out=$value;

+

+        return $out;

+    }

+

+

+    /**

+     * Function to show lines of extrafields with output datas

+     *

+     * @param 	Extrafields $extrafields    Extrafield Object

+     * @param 	string      $mode           Show output (view) or input (edit) for extrafield

+     * @param 	array       $params         Optional parameters. Example: array('style'=>'class="oddeven"', 'colspan'=>$colspan)

+     * @param 	string      $keysuffix      Suffix string to add after name and id of field (can be used to avoid duplicate names)

+     * @param 	string      $keyprefix      Prefix string to add before name and id of field (can be used to avoid duplicate names)

+     * @param	string		$onetrtd		All fields in same tr td

+     * @return 	string

+     */

+    function showOptionals($extrafields, $mode='view', $params=null, $keysuffix='', $keyprefix='', $onetrtd=0)

+    {

+        global $db, $conf, $langs, $action, $form;

+

+        if (! is_object($form)) $form=new Form($db);

+

+        $out = '';

+

+        if (is_array($extrafields->attributes[$this->table_element]['label']) && count($extrafields->attributes[$this->table_element]['label']) > 0)

+        {

+            $out .= "\n";

+            $out .= '<!-- showOptionalsInput --> ';

+            $out .= "\n";

 

-				$sqlwhere = '';

-				$sql = 'SELECT ' . $keyList;

-				$sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];

-				if (! empty($InfoFieldList[4])) {

-

-					// can use SELECT request

-					if (strpos($InfoFieldList[4], '$SEL$')!==false) {

-						$InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);

-					}

-

-					// current object id can be use into filter

-					if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {

-						$InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);

-					} else {

-						$InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);

-					}

-

-					// We have to join on extrafield table

-					if (strpos($InfoFieldList[4], 'extra') !== false) {

-						$sql .= ' as main, ' . MAIN_DB_PREFIX . $InfoFieldList[0] . '_extrafields as extra';

-						$sqlwhere .= ' WHERE extra.fk_object=main.' . $InfoFieldList[2] . ' AND ' . $InfoFieldList[4];

-					} else {

-						$sqlwhere .= ' WHERE ' . $InfoFieldList[4];

-					}

-				} else {

-					$sqlwhere .= ' WHERE 1=1';

-				}

-				// Some tables may have field, some other not. For the moment we disable it.

-				if (in_array($InfoFieldList[0], array ('tablewithentity')))

-				{

-					$sqlwhere .= ' AND entity = ' . $conf->entity;

-				}

-				// $sql.=preg_replace('/^ AND /','',$sqlwhere);

-				// print $sql;

-

-				$sql .= $sqlwhere;

-				dol_syslog(get_class($this) . '::showInputField type=chkbxlst',LOG_DEBUG);

-				$resql = $this->db->query($sql);

-				if ($resql) {

-					$num = $this->db->num_rows($resql);

-					$i = 0;

-

-					$data=array();

-

-					while ( $i < $num ) {

-						$labeltoshow = '';

-						$obj = $this->db->fetch_object($resql);

-

-						$notrans = false;

-						// Several field into label (eq table:code|libelle:rowid)

-						$fields_label = explode('|', $InfoFieldList[1]);

-						if (is_array($fields_label)) {

-							$notrans = true;

-							foreach ( $fields_label as $field_toshow ) {

-								$labeltoshow .= $obj->$field_toshow . ' ';

+            $e = 0;

+            foreach($extrafields->attributes[$this->table_element]['label'] as $key=>$label)

+            {

+                // Show only the key field in params

+                if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) continue;

+

+                $enabled = 1;

+                if ($enabled && isset($extrafields->attributes[$this->table_element]['list'][$key]))

+                {

+                    $enabled = dol_eval($extrafields->attributes[$this->table_element]['list'][$key], 1);

+                }

+

+                $perms = 1;

+                if ($perms && isset($extrafields->attributes[$this->table_element]['perms'][$key]))

+                {

+                    $perms = dol_eval($extrafields->attributes[$this->table_element]['perms'][$key], 1);

+                }

+

+                if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue;	// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

+                if (empty($perms)) continue;

+

+                // Load language if required

+                if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);

+

+                $colspan='3';

+                if (is_array($params) && count($params)>0) {

+                    if (array_key_exists('colspan',$params)) {

+                        $colspan=$params['colspan'];

+                    }

+                }

+

+                switch($mode) {

+                    case "view":

+                        $value=$this->array_options["options_".$key.$keysuffix];

+                        break;

+                    case "edit":

+                        $getposttemp = GETPOST($keyprefix.'options_'.$key.$keysuffix, 'none');				// GETPOST can get value from GET, POST or setup of default values.

+                        // GETPOST("options_" . $key) can be 'abc' or array(0=>'abc')

+                        if (is_array($getposttemp) || $getposttemp != '' || GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix))

+                        {

+                            if (is_array($getposttemp)) {

+                                // $getposttemp is an array but following code expects a comma separated string

+                                $value = implode(",", $getposttemp);

+                            } else {

+                                $value = $getposttemp;

+                            }

+                        } else {

+                            $value = $this->array_options["options_" . $key];			// No GET, no POST, no default value, so we take value of object.

+                        }

+                        //var_dump($keyprefix.' - '.$key.' - '.$keysuffix.' - '.$keyprefix.'options_'.$key.$keysuffix.' - '.$this->array_options["options_".$key.$keysuffix].' - '.$getposttemp.' - '.$value);

+                        break;

+                }

+

+                if ($extrafields->attributes[$this->table_element]['type'][$key] == 'separate')

+                {

+                    $out .= $extrafields->showSeparator($key, $this);

+                }

+                else

+                {

+                    $csstyle='';

+                    $class=(!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');

+                    if (is_array($params) && count($params)>0) {

+                        if (array_key_exists('style',$params)) {

+                            $csstyle=$params['style'];

+                        }

+                    }

+

+                    // add html5 elements

+                    $domData  = ' data-element="extrafield"';

+                    $domData .= ' data-targetelement="'.$this->element.'"';

+                    $domData .= ' data-targetid="'.$this->id.'"';

+

+                    $html_id = !empty($this->id) ? 'extrarow-'.$this->element.'_'.$key.'_'.$this->id : '';

+

+                    $out .= '<tr id="'.$html_id.'" '.$csstyle.' class="'.$class.$this->element.'_extras_'.$key.'" '.$domData.' >';

+

+                    if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0)

+                    {

+                        if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0) { $colspan='0'; }

+                    }

+

+                    if ($action == 'selectlines') { $colspan++; }

+

+                    // Convert date into timestamp format (value in memory must be a timestamp)

+                    if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('date','datetime')))

+                    {

+                        $datenotinstring = $this->array_options['options_' . $key];

+                        if (! is_numeric($this->array_options['options_' . $key]))	// For backward compatibility

+                        {

+                            $datenotinstring = $this->db->jdate($datenotinstring);

+                        }

+                        $value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min",'int',3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year",'int',3)):$datenotinstring;

+                    }

+                    // Convert float submited string into real php numeric (value in memory must be a php numeric)

+                    if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('price','double')))

+                    {

+                        $value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?price2num(GETPOST($keyprefix.'options_'.$key.$keysuffix, 'alpha', 3)):$this->array_options['options_'.$key];

+                    }

+

+                    $labeltoshow = $langs->trans($label);

+

+                    $out .= '<td class="titlefield';

+                    if (GETPOST('action','none') == 'create') $out.='create';

+                    if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';

+                    $out .= '">';

+                    if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);

+                    else $out .= $labeltoshow;

+                    $out .= '</td>';

+

+                    $html_id = !empty($this->id) ? $this->element.'_extras_'.$key.'_'.$this->id : '';

+                    $out .='<td id="'.$html_id.'" class="'.$this->element.'_extras_'.$key.'" '.($colspan?' colspan="'.$colspan.'"':'').'>';

+

+                    switch($mode) {

+                        case "view":

+                            $out .= $extrafields->showOutputField($key, $value);

+                            break;

+                        case "edit":

+                            $out .= $extrafields->showInputField($key, $value, '', $keysuffix, '', 0, $this->id);

+                            break;

+                    }

+

+                    $out .= '</td>';

+

+                    if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';

+                    else $out .= '</tr>';

+                    $e++;

+                }

+            }

+            $out .= "\n";

+            // Add code to manage list depending on others

+            if (! empty($conf->use_javascript_ajax)) {

+                $out .= '

+				<script type="text/javascript">

+				    jQuery(document).ready(function() {

+				    	function showOptions(child_list, parent_list)

+				    	{

+				    		var val = $("select[name=\"options_"+parent_list+"\"]").val();

+				    		var parentVal = parent_list + ":" + val;

+							if(val > 0) {

+					    		$("select[name=\""+child_list+"\"] option[parent]").hide();

+					    		$("select[name=\""+child_list+"\"] option[parent=\""+parentVal+"\"]").show();

+							} else {

+								$("select[name=\""+child_list+"\"] option").show();

 							}

-						} else {

-							$labeltoshow = $obj->{$InfoFieldList[1]};

+				    	}

+						function setListDependencies() {

+					    	jQuery("select option[parent]").parent().each(function() {

+					    		var child_list = $(this).attr("name");

+								var parent = $(this).find("option[parent]:first").attr("parent");

+								var infos = parent.split(":");

+								var parent_list = infos[0];

+								$("select[name=\""+parent_list+"\"]").change(function() {

+									showOptions(child_list, parent_list);

+								});

+					    	});

 						}

-						$labeltoshow = dol_trunc($labeltoshow, 45);

-

-						if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

-							foreach ( $fields_label as $field_toshow ) {

-								$translabel = $langs->trans($obj->$field_toshow);

-								if ($translabel != $obj->$field_toshow) {

-									$labeltoshow = dol_trunc($translabel, 18) . ' ';

-								} else {

-									$labeltoshow = dol_trunc($obj->$field_toshow, 18) . ' ';

-								}

-							}

 

-							$data[$obj->rowid]=$labeltoshow;

-						} else {

-							if (! $notrans) {

-								$translabel = $langs->trans($obj->{$InfoFieldList[1]});

-								if ($translabel != $obj->{$InfoFieldList[1]}) {

-									$labeltoshow = dol_trunc($translabel, 18);

-								} else {

-									$labeltoshow = dol_trunc($obj->{$InfoFieldList[1]}, 18);

-								}

-							}

-							if (empty($labeltoshow))

-								$labeltoshow = '(not defined)';

+						setListDependencies();

+				    });

+				</script>'."\n";

+                $out .= '<!-- /showOptionalsInput --> '."\n";

+            }

+        }

+        return $out;

+    }

 

-								if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

-									$data[$obj->rowid]=$labeltoshow;

-								}

 

-								if (! empty($InfoFieldList[3]) && $parentField) {

-									$parent = $parentName . ':' . $obj->{$parentField};

-								}

+    /**

+     * Returns the rights used for this class

+     * @return stdClass

+     */

+    public function getRights()

+    {

+        global $user;

 

-								$data[$obj->rowid]=$labeltoshow;

-						}

+        $element = $this->element;

+        if ($element == 'facturerec') $element='facture';

 

-						$i ++;

-					}

-					$this->db->free($resql);

+        return $user->rights->{$element};

+    }

 

-					$out=$form->multiselectarray($keyprefix.$key.$keysuffix, $data, $value_arr, '', 0, '', 0, '100%');

-				} else {

-					print 'Error in request ' . $sql . ' ' . $this->db->lasterror() . '. Check setup of extra parameters.<br>';

-				}

-			}

-		}

-		elseif ($type == 'link')

-		{

-			$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

-			$showempty=(($required && $default != '')?0:1);

-			$out=$form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);

-			if ($conf->global->MAIN_FEATURES_LEVEL >= 2)

-			{

-            			list($class,$classfile)=explode(':',$param_list[0]);

-            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);

-            			else $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);

-            			$out.='<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';

-            			// TODO Add Javascript code to add input fields contents to new elements urls

-			}

-		}

-		elseif ($type == 'password')

-		{

-			// If prefix is 'search_', field is used as a filter, we use a common text field.

-			$out='<input type="'.($keyprefix=='search_'?'text':'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'array')

-		{

-			$newval = $val;

-			$newval['type'] = 'varchar(256)';

-

-			$out='';

-

-			$inputs = array();

-			if(! empty($value)) {

-				foreach($value as $option) {

-					$out.= '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

-					$out.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', $option, $moreparam, '', '', $showsize).'<br></span>';

-				}

-			}

+    /**

+     * Function used to replace a thirdparty id with another one.

+     * This function is meant to be called from replaceThirdparty with the appropiate tables

+     * Column name fk_soc MUST be used to identify thirdparties

+     *

+     * @param  DoliDB 	   $db 			  Database handler

+     * @param  int 		   $origin_id     Old thirdparty id (the thirdparty to delete)

+     * @param  int 		   $dest_id       New thirdparty id (the thirdparty that will received element of the other)

+     * @param  string[]    $tables        Tables that need to be changed

+     * @param  int         $ignoreerrors  Ignore errors. Return true even if errors. We need this when replacement can fails like for categories (categorie of old thirdparty may already exists on new one)

+     * @return bool						  True if success, False if error

+     */

+    public static function commonReplaceThirdparty(DoliDB $db, $origin_id, $dest_id, array $tables, $ignoreerrors=0)

+    {

+        foreach ($tables as $table)

+        {

+            $sql = 'UPDATE '.MAIN_DB_PREFIX.$table.' SET fk_soc = '.$dest_id.' WHERE fk_soc = '.$origin_id;

 

-			$out.= '<a id="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_add" href="javascript:;"><span class="fa fa-plus-circle valignmiddle"></span></a>';

+            if (! $db->query($sql))

+            {

+                if ($ignoreerrors) return true;		// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

+                //$this->errors = $db->lasterror();

+                return false;

+            }

+        }

 

-			$newInput = '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

-			$newInput.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', '', $moreparam, '', '', $showsize).'<br></span>';

+        return true;

+    }

 

-			if(! empty($conf->use_javascript_ajax)) {

-				$out.= '

-					<script type="text/javascript">

-					$(document).ready(function() {

-						$("a#'.dol_escape_js($keyprefix.$key.$keysuffix).'_add").click(function() {

-							$("'.dol_escape_js($newInput).'").insertBefore(this);

-						});

+    /**

+     * Get buy price to use for margin calculation. This function is called when buy price is unknown.

+     *	 Set buy price = sell price if ForceBuyingPriceIfNull configured,

+     *   else if calculation MARGIN_TYPE = 'costprice' and costprice is defined, use costprice as buyprice

+     *	 else if calculation MARGIN_TYPE = 'pmp' and pmp is calculated, use pmp as buyprice

+     *	 else set min buy price as buy price

+     *

+     * @param float		$unitPrice		 Product unit price

+     * @param float		$discountPercent Line discount percent

+     * @param int		$fk_product		 Product id

+     * @return	float                    <0 if KO, buyprice if OK

+     */

+    public function defineBuyPrice($unitPrice = 0.0, $discountPercent = 0.0, $fk_product = 0)

+    {

+        global $conf;

 

-						$(document).on("click", "a.'.dol_escape_js($keyprefix.$key.$keysuffix).'_del", function() {

-							$(this).parent().remove();

-						});

-					});

-					</script>';

-			}

-		}

-		if (!empty($hidden)) {

-			$out='<input type="hidden" value="'.$value.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'"/>';

-		}

-		/* Add comments

-		 if ($type == 'date') $out.=' (YYYY-MM-DD)';

-		 elseif ($type == 'datetime') $out.=' (YYYY-MM-DD HH:MM:SS)';

-		 */

-		return $out;

-	}

-

-	/**

-	 * Return HTML string to show a field into a page

-	 * Code very similar with showOutputField of extra fields

-	 *

-	 * @param  array   $val		       Array of properties of field to show

-	 * @param  string  $key            Key of attribute

-	 * @param  string  $value          Preselected value to show (for date type it must be in timestamp format, for amount or price it must be a php numeric value)

-	 * @param  string  $moreparam      To add more parametes on html input tag

-	 * @param  string  $keysuffix      Prefix string to add into name and id of field (can be used to avoid duplicate names)

-	 * @param  string  $keyprefix      Suffix string to add into name and id of field (can be used to avoid duplicate names)

-	 * @param  mixed   $showsize       Value for css to define size. May also be a numeric.

-	 * @return string

-	 */

-	function showOutputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $showsize=0)

-	{

-		global $conf,$langs,$form;

-

-		if (! is_object($form))

-		{

-			require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';

-			$form=new Form($this->db);

-		}

-

-		$objectid = $this->id;

-		$label = $val['label'];

-		$type  = $val['type'];

-		$size  = $val['css'];

-

-		// Convert var to be able to share same code than showOutputField of extrafields

-		if (preg_match('/varchar\((\d+)\)/', $type, $reg))

-		{

-			$type = 'varchar';		// convert varchar(xx) int varchar

-			$size = $reg[1];

-		}

-		elseif (preg_match('/varchar/', $type)) $type = 'varchar';		// convert varchar(xx) int varchar

-		if (is_array($val['arrayofkeyval'])) $type='select';

-		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type='link';

-

-		$default=$val['default'];

-		$computed=$val['computed'];

-		$unique=$val['unique'];

-		$required=$val['required'];

-		$param=$val['param'];

-		if (is_array($val['arrayofkeyval'])) $param['options'] = $val['arrayofkeyval'];

-		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg))

-		{

-			$type='link';

-			$param['options']=array($reg[1].':'.$reg[2]=>$reg[1].':'.$reg[2]);

-		}

-		$langfile=$val['langfile'];

-		$list=$val['list'];

-		$help=$val['help'];

-		$hidden=(($val['visible'] == 0) ? 1 : 0);			// If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)

-

-		if ($hidden) return '';

-

-		// If field is a computed field, value must become result of compute

-		if ($computed)

-		{

-			// Make the eval of compute string

-			//var_dump($computed);

-			$value = dol_eval($computed, 1, 0);

-		}

-

-		if (empty($showsize))

-		{

-			if ($type == 'date')

-			{

-				//$showsize=10;

-				$showsize = 'minwidth100imp';

-			}

-			elseif ($type == 'datetime')

-			{

-				//$showsize=19;

-				$showsize = 'minwidth200imp';

-			}

-			elseif (in_array($type,array('int','double','price')))

-			{

-				//$showsize=10;

-				$showsize = 'maxwidth75';

-			}

-			elseif ($type == 'url')

-			{

-				$showsize='minwidth400';

-			}

-			elseif ($type == 'boolean')

-			{

-				$showsize='';

-			}

-			else

-			{

-				if (round($size) < 12)

-				{

-					$showsize = 'minwidth100';

-				}

-				else if (round($size) <= 48)

-				{

-					$showsize = 'minwidth200';

-				}

-				else

-				{

-					//$showsize=48;

-					$showsize = 'minwidth400';

-				}

-			}

-		}

-

-		// Format output value differently according to properties of field

-		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value=$this->getNomUrl(1, '', 0, '', 1);

-		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value=$this->getLibStatut(3);

-		elseif ($type == 'date')

-		{

-			if(! empty($value)) {

-				$value=dol_print_date($value,'day');

-			} else {

-				$value='';

-			}

-		}

-		elseif ($type == 'datetime')

-		{

-			if(! empty($value)) {

-				$value=dol_print_date($value,'dayhour');

-			} else {

-				$value='';

-			}

-		}

-		elseif ($type == 'double')

-		{

-			if (!empty($value)) {

-				$value=price($value);

-			}

-		}

-		elseif ($type == 'boolean')

-		{

-			$checked='';

-			if (!empty($value)) {

-				$checked=' checked ';

-			}

-			$value='<input type="checkbox" '.$checked.' '.($moreparam?$moreparam:'').' readonly disabled>';

-		}

-		elseif ($type == 'mail')

-		{

-			$value=dol_print_email($value,0,0,0,64,1,1);

-		}

-		elseif ($type == 'url')

-		{

-			$value=dol_print_url($value,'_blank',32,1);

-		}

-		elseif ($type == 'phone')

-		{

-			$value=dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);

-		}

-		elseif ($type == 'price')

-		{

-			$value=price($value,0,$langs,0,0,-1,$conf->currency);

-		}

-		elseif ($type == 'select')

-		{

-			$value=$param['options'][$value];

-		}

-		elseif ($type == 'sellist')

-		{

-			$param_list=array_keys($param['options']);

-			$InfoFieldList = explode(":", $param_list[0]);

-

-			$selectkey="rowid";

-			$keyList='rowid';

-

-			if (count($InfoFieldList)>=3)

-			{

-				$selectkey = $InfoFieldList[2];

-				$keyList=$InfoFieldList[2].' as rowid';

-			}

-

-			$fields_label = explode('|',$InfoFieldList[1]);

-			if(is_array($fields_label)) {

-				$keyList .=', ';

-				$keyList .= implode(', ', $fields_label);

-			}

-

-			$sql = 'SELECT '.$keyList;

-			$sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];

-			if (strpos($InfoFieldList[4], 'extra')!==false)

-			{

-				$sql.= ' as main';

-			}

-			if ($selectkey=='rowid' && empty($value)) {

-				$sql.= " WHERE ".$selectkey."=0";

-			} elseif ($selectkey=='rowid') {

-				$sql.= " WHERE ".$selectkey."=".$this->db->escape($value);

-			}else {

-				$sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

-			}

-

-			//$sql.= ' AND entity = '.$conf->entity;

-

-			dol_syslog(get_class($this).':showOutputField:$type=sellist', LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if ($resql)

-			{

-				$value='';	// value was used, so now we reste it to use it to build final output

+        $buyPrice = 0;

+

+        if (($unitPrice > 0) && (isset($conf->global->ForceBuyingPriceIfNull) && $conf->global->ForceBuyingPriceIfNull == 1)) // In most cases, test here is false

+        {

+            $buyPrice = $unitPrice * (1 - $discountPercent / 100);

+        }

+        else

+        {

+            // Get cost price for margin calculation

+            if (! empty($fk_product))

+            {

+                if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'costprice')

+                {

+                    require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

+                    $product = new Product($this->db);

+                    $result = $product->fetch($fk_product);

+                    if ($result <= 0)

+                    {

+                        $this->errors[] = 'ErrorProductIdDoesNotExists';

+                        return -1;

+                    }

+                    if ($product->cost_price > 0)

+                    {

+                        $buyPrice = $product->cost_price;

+                    }

+                    else if ($product->pmp > 0)

+                    {

+                        $buyPrice = $product->pmp;

+                    }

+                }

+                else if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'pmp')

+                {

+                    require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

+                    $product = new Product($this->db);

+                    $result = $product->fetch($fk_product);

+                    if ($result <= 0)

+                    {

+                        $this->errors[] = 'ErrorProductIdDoesNotExists';

+                        return -1;

+                    }

+                    if ($product->pmp > 0)

+                    {

+                        $buyPrice = $product->pmp;

+                    }

+                }

+

+                if (empty($buyPrice) && isset($conf->global->MARGIN_TYPE) && in_array($conf->global->MARGIN_TYPE, array('1','pmp','costprice')))

+                {

+                    require_once DOL_DOCUMENT_ROOT.'/fourn/class/fournisseur.product.class.php';

+                    $productFournisseur = new ProductFournisseur($this->db);

+                    if (($result = $productFournisseur->find_min_price_product_fournisseur($fk_product)) > 0)

+                    {

+                        $buyPrice = $productFournisseur->fourn_unitprice;

+                    }

+                    else if ($result < 0)

+                    {

+                        $this->errors[] = $productFournisseur->error;

+                        return -2;

+                    }

+                }

+            }

+        }

+        return $buyPrice;

+    }

+

+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

+    /**

+     *  Show photos of an object (nbmax maximum), into several columns

+     *

+     *  @param		string	$modulepart		'product', 'ticket', ...

+     *  @param      string	$sdir        	Directory to scan (full absolute path)

+     *  @param      int		$size        	0=original size, 1='small' use thumbnail if possible

+     *  @param      int		$nbmax       	Nombre maximum de photos (0=pas de max)

+     *  @param      int		$nbbyrow     	Number of image per line or -1 to use div. Used only if size=1.

+     * 	@param		int		$showfilename	1=Show filename

+     * 	@param		int		$showaction		1=Show icon with action links (resize, delete)

+     * 	@param		int		$maxHeight		Max height of original image when size='small' (so we can use original even if small requested). If 0, always use 'small' thumb image.

+     * 	@param		int		$maxWidth		Max width of original image when size='small'

+     *  @param      int     $nolink         Do not add a href link to view enlarged imaged into a new tab

+     *  @param      int     $notitle        Do not add title tag on image

+     *  @param		int		$usesharelink	Use the public shared link of image (if not available, the 'nophoto' image will be shown instead)

+     *  @return     string					Html code to show photo. Number of photos shown is saved in this->nbphoto

+     */

+    function show_photos($modulepart, $sdir, $size=0, $nbmax=0, $nbbyrow=5, $showfilename=0, $showaction=0, $maxHeight=120, $maxWidth=160, $nolink=0, $notitle=0, $usesharelink=0)

+    {

+        // phpcs:enable

+        global $conf,$user,$langs;

+

+        include_once DOL_DOCUMENT_ROOT .'/core/lib/files.lib.php';

+        include_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';

+

+        $sortfield='position_name';

+        $sortorder='asc';

+

+        $dir = $sdir . '/';

+        $pdir = '/';

+        if ($modulepart == 'ticket')

+        {

+            $dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

+            $pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

+        }

+        else

+        {

+            $dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

+            $pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

+        }

+

+        // For backward compatibility

+        if ($modulepart == 'product' && ! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))

+        {

+            $dir = $sdir . '/'. get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";

+            $pdir = '/' . get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";

+        }

+

+        // Defined relative dir to DOL_DATA_ROOT

+        $relativedir = '';

+        if ($dir)

+        {

+            $relativedir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $dir);

+            $relativedir = preg_replace('/^[\\/]/','',$relativedir);

+            $relativedir = preg_replace('/[\\/]$/','',$relativedir);

+        }

+

+        $dirthumb = $dir.'thumbs/';

+        $pdirthumb = $pdir.'thumbs/';

+

+        $return ='<!-- Photo -->'."\n";

+        $nbphoto=0;

+

+        $filearray=dol_dir_list($dir,"files",0,'','(\.meta|_preview.*\.png)$',$sortfield,(strtolower($sortorder)=='desc'?SORT_DESC:SORT_ASC),1);

+

+        /*if (! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))    // For backward compatiblity, we scan also old dirs

+		 {

+		 $filearrayold=dol_dir_list($dirold,"files",0,'','(\.meta|_preview.*\.png)$',$sortfield,(strtolower($sortorder)=='desc'?SORT_DESC:SORT_ASC),1);

+		 $filearray=array_merge($filearray, $filearrayold);

+		 }*/

+

+        completeFileArrayWithDatabaseInfo($filearray, $relativedir);

+

+        if (count($filearray))

+        {

+            if ($sortfield && $sortorder)

+            {

+                $filearray=dol_sort_array($filearray, $sortfield, $sortorder);

+            }

+

+            foreach($filearray as $key => $val)

+            {

+                $photo='';

+                $file = $val['name'];

+

+                //if (! utf8_check($file)) $file=utf8_encode($file);	// To be sure file is stored in UTF8 in memory

+

+                //if (dol_is_file($dir.$file) && image_format_supported($file) >= 0)

+                if (image_format_supported($file) >= 0)

+                {

+                    $nbphoto++;

+                    $photo = $file;

+                    $viewfilename = $file;

+

+                    if ($size == 1 || $size == 'small') {   // Format vignette

+

+                        // Find name of thumb file

+                        $photo_vignette=basename(getImageFileNameForSize($dir.$file, '_small'));

+                        if (! dol_is_file($dirthumb.$photo_vignette)) $photo_vignette='';

+

+                        // Get filesize of original file

+                        $imgarray=dol_getImageSize($dir.$photo);

+

+                        if ($nbbyrow > 0)

+                        {

+                            if ($nbphoto == 1) $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';

+

+                            if ($nbphoto % $nbbyrow == 1) $return.= '<tr align=center valign=middle border=1>';

+                            $return.= '<td width="'.ceil(100/$nbbyrow).'%" class="photo">';

+                        }

+                        else if ($nbbyrow < 0) $return .= '<div class="inline-block">';

+

+                        $return.= "\n";

+

+                        $relativefile=preg_replace('/^\//', '', $pdir.$photo);

+                        if (empty($nolink))

+                        {

+                            $urladvanced=getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);

+                            if ($urladvanced) $return.='<a href="'.$urladvanced.'">';

+                            else $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';

+                        }

+

+                        // Show image (width height=$maxHeight)

+                        // Si fichier vignette disponible et image source trop grande, on utilise la vignette, sinon on utilise photo origine

+                        $alt=$langs->transnoentitiesnoconv('File').': '.$relativefile;

+                        $alt.=' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];

+                        if ($notitle) $alt='';

+

+                        if ($usesharelink)

+                        {

+                            if ($val['share'])

+                            {

+                                if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

+                                {

+                                    $return.= '<!-- Show original file (thumb not yet available with shared links) -->';

+                                    $return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

+                                }

+                                else {

+                                    $return.= '<!-- Show original file -->';

+                                    $return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

+                                }

+                            }

+                            else

+                            {

+                                $return.= '<!-- Show nophoto file (because file is not shared) -->';

+                                $return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';

+                            }

+                        }

+                        else

+                        {

+                            if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

+                            {

+                                $return.= '<!-- Show thumb -->';

+                                $return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';

+                            }

+                            else {

+                                $return.= '<!-- Show original file -->';

+                                $return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';

+                            }

+                        }

+

+                        if (empty($nolink)) $return.= '</a>';

+                        $return.="\n";

+

+                        if ($showfilename) $return.= '<br>'.$viewfilename;

+                        if ($showaction)

+                        {

+                            $return.= '<br>';

+                            // On propose la generation de la vignette si elle n'existe pas et si la taille est superieure aux limites

+                            if ($photo_vignette && (image_format_supported($photo) > 0) && ($this->imgWidth > $maxWidth || $this->imgHeight > $maxHeight))

+                            {

+                                $return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=addthumb&amp;file='.urlencode($pdir.$viewfilename).'">'.img_picto($langs->trans('GenerateThumb'),'refresh').'&nbsp;&nbsp;</a>';

+                            }

+                            // Special cas for product

+                            if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))

+                            {

+                                // Link to resize

+                                $return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

+

+                                // Link to delete

+                                $return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

+                                $return.= img_delete().'</a>';

+                            }

+                        }

+                        $return.= "\n";

+

+                        if ($nbbyrow > 0)

+                        {

+                            $return.= '</td>';

+                            if (($nbphoto % $nbbyrow) == 0) $return.= '</tr>';

+                        }

+                        else if ($nbbyrow < 0) $return.='</div>';

+                    }

+

+                    if (empty($size)) {     // Format origine

+                        $return.= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';

+

+                        if ($showfilename) $return.= '<br>'.$viewfilename;

+                        if ($showaction)

+                        {

+                            // Special case for product

+                            if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))

+                            {

+                                // Link to resize

+                                $return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

+

+                                // Link to delete

+                                $return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

+                                $return.= img_delete().'</a>';

+                            }

+                        }

+                    }

+

+                    // On continue ou on arrete de boucler ?

+                    if ($nbmax && $nbphoto >= $nbmax) break;

+                }

+            }

+

+            if ($size==1 || $size=='small')

+            {

+                if ($nbbyrow > 0)

+                {

+                    // Ferme tableau

+                    while ($nbphoto % $nbbyrow)

+                    {

+                        $return.= '<td width="'.ceil(100/$nbbyrow).'%">&nbsp;</td>';

+                        $nbphoto++;

+                    }

+

+                    if ($nbphoto) $return.= '</table>';

+                }

+            }

+        }

+

+        $this->nbphoto = $nbphoto;

+

+        return $return;

+    }

+

+

+    /**

+     * Function test if type is array

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    protected function isArray($info)

+    {

+        if(is_array($info))

+        {

+            if(isset($info['type']) && $info['type']=='array') return true;

+            else return false;

+        }

+        else return false;

+    }

+

+    /**

+     * Function test if type is null

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    protected function isNull($info)

+    {

+        if(is_array($info))

+        {

+            if(isset($info['type']) && $info['type']=='null') return true;

+            else return false;

+        }

+        else return false;

+    }

+

+    /**

+     * Function test if type is date

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    public function isDate($info)

+    {

+        if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) return true;

+        else return false;

+    }

+

+    /**

+     * Function test if type is integer

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    public function isInt($info)

+    {

+        if(is_array($info))

+        {

+            if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) return true;

+            else return false;

+        }

+        else return false;

+    }

+

+    /**

+     * Function test if type is float

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    public function isFloat($info)

+    {

+        if(is_array($info))

+        {

+            if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) return true;

+            else return false;

+        }

+        else return false;

+    }

+

+    /**

+     * Function test if type is text

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    public function isText($info)

+    {

+        if(is_array($info))

+        {

+            if(isset($info['type']) && $info['type']=='text') return true;

+            else return false;

+        }

+        else return false;

+    }

+

+    /**

+     * Function test if is indexed

+     *

+     * @param   array   $info   content informations of field

+     * @return                  bool

+     */

+    protected function isIndex($info)

+    {

+        if(is_array($info))

+        {

+            if(isset($info['index']) && $info['index']==true) return true;

+            else return false;

+        }

+        else return false;

+    }

+

+    /**

+     * Function to prepare the values to insert.

+     * Note $this->${field} are set by the page that make the createCommon or the updateCommon.

+     *

+     * @return array

+     */

+    protected function setSaveQuery()

+    {

+        global $conf;

+

+        $queryarray=array();

+        foreach ($this->fields as $field=>$info)	// Loop on definition of fields

+        {

+            // Depending on field type ('datetime', ...)

+            if($this->isDate($info))

+            {

+                if(empty($this->{$field}))

+                {

+                    $queryarray[$field] = null;

+                }

+                else

+                {

+                    $queryarray[$field] = $this->db->idate($this->{$field});

+                }

+            }

+            else if($this->isArray($info))

+            {

+                if(! empty($this->{$field})) {

+                    if(! is_array($this->{$field})) {

+                        $this->{$field} = array($this->{$field});

+                    }

+                    $queryarray[$field] = serialize($this->{$field});

+                } else {

+                    $queryarray[$field] = null;

+                }

+            }

+            else if($this->isInt($info))

+            {

+                if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field]=$conf->entity;

+                else

+                {

+                    $queryarray[$field] = (int) price2num($this->{$field});

+                    if (empty($queryarray[$field])) $queryarray[$field]=0;		// May be reset to null later if property 'notnull' is -1 for this field.

+                }

+            }

+            else if($this->isFloat($info))

+            {

+                $queryarray[$field] = (double) price2num($this->{$field});

+                if (empty($queryarray[$field])) $queryarray[$field]=0;

+            }

+            else

+            {

+                $queryarray[$field] = $this->{$field};

+            }

+

+            if ($info['type'] == 'timestamp' && empty($queryarray[$field])) unset($queryarray[$field]);

+            if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;

+        }

+

+        return $queryarray;

+    }

+

+    /**

+     * Function to load data from a SQL pointer into properties of current object $this

+     *

+     * @param   stdClass    $obj    Contain data of object from database

+     * @return void

+     */

+    protected function setVarsFromFetchObj(&$obj)

+    {

+        foreach ($this->fields as $field => $info)

+        {

+            if($this->isDate($info))

+            {

+                if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;

+                else $this->{$field} = strtotime($obj->{$field});

+            }

+            elseif($this->isArray($info))

+            {

+                if(! empty($obj->{$field})) {

+                    $this->{$field} = @unserialize($obj->{$field});

+                    // Hack for data not in UTF8

+                    if($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));

+                } else {

+                    $this->{$field} = array();

+                }

+            }

+            elseif($this->isInt($info))

+            {

+                if ($field == 'rowid') $this->id = (int) $obj->{$field};

+                else $this->{$field} = (int) $obj->{$field};

+            }

+            elseif($this->isFloat($info))

+            {

+                $this->{$field} = (double) $obj->{$field};

+            }

+            elseif($this->isNull($info))

+            {

+                $val = $obj->{$field};

+                // zero is not null

+                $this->{$field} = (is_null($val) || (empty($val) && $val!==0 && $val!=='0') ? null : $val);

+            }

+            else

+            {

+                $this->{$field} = $obj->{$field};

+            }

+        }

+

+        // If there is no 'ref' field, we force property ->ref to ->id for a better compatibility with common functions.

+        if (! isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;

+    }

+

+    /**

+     * Function to concat keys of fields

+     *

+     * @return string

+     */

+    protected function getFieldList()

+    {

+        $keys = array_keys($this->fields);

+        return implode(',', $keys);

+    }

+

+    /**

+     * Add quote to field value if necessary

+     *

+     * @param 	string|int	$value			Value to protect

+     * @param	array		$fieldsentry	Properties of field

+     * @return 	string

+     */

+    protected function quote($value, $fieldsentry)

+    {

+        if (is_null($value)) return 'NULL';

+        else if (preg_match('/^(int|double|real)/i', $fieldsentry['type'])) return $this->db->escape("$value");

+        else return "'".$this->db->escape($value)."'";

+    }

+

+

+    /**

+     * Create object into database

+     *

+     * @param  User $user      User that creates

+     * @param  bool $notrigger false=launch triggers after, true=disable triggers

+     * @return int             <0 if KO, Id of created object if OK

+     */

+    public function createCommon(User $user, $notrigger = false)

+    {

+        global $langs;

 

-				$obj = $this->db->fetch_object($resql);

+        $error = 0;

 

-				// Several field into label (eq table:code|libelle:rowid)

-				$fields_label = explode('|',$InfoFieldList[1]);

+        $now=dol_now();

 

-				if(is_array($fields_label) && count($fields_label)>1)

-				{

-					foreach ($fields_label as $field_toshow)

-					{

-						$translabel='';

-						if (!empty($obj->$field_toshow)) {

-							$translabel=$langs->trans($obj->$field_toshow);

-						}

-						if ($translabel!=$field_toshow) {

-							$value.=dol_trunc($translabel,18).' ';

-						}else {

-							$value.=$obj->$field_toshow.' ';

-						}

-					}

-				}

-				else

-				{

-					$translabel='';

-					if (!empty($obj->{$InfoFieldList[1]})) {

-						$translabel=$langs->trans($obj->{$InfoFieldList[1]});

-					}

-					if ($translabel!=$obj->{$InfoFieldList[1]}) {

-						$value=dol_trunc($translabel,18);

-					}else {

-						$value=$obj->{$InfoFieldList[1]};

-					}

-				}

-			}

-			else dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);

-		}

-		elseif ($type == 'radio')

-		{

-			$value=$param['options'][$value];

-		}

-		elseif ($type == 'checkbox')

-		{

-			$value_arr=explode(',',$value);

-			$value='';

-			if (is_array($value_arr) && count($value_arr)>0)

-			{

-				foreach ($value_arr as $keyval=>$valueval) {

-					$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$param['options'][$valueval].'</li>';

-				}

-				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

-			}

-		}

-		elseif ($type == 'chkbxlst')

-		{

-			$value_arr = explode(',', $value);

-

-			$param_list = array_keys($param['options']);

-			$InfoFieldList = explode(":", $param_list[0]);

-

-			$selectkey = "rowid";

-			$keyList = 'rowid';

-

-			if (count($InfoFieldList) >= 3) {

-				$selectkey = $InfoFieldList[2];

-				$keyList = $InfoFieldList[2] . ' as rowid';

-			}

-

-			$fields_label = explode('|', $InfoFieldList[1]);

-			if (is_array($fields_label)) {

-				$keyList .= ', ';

-				$keyList .= implode(', ', $fields_label);

-			}

-

-			$sql = 'SELECT ' . $keyList;

-			$sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];

-			if (strpos($InfoFieldList[4], 'extra') !== false) {

-				$sql .= ' as main';

-			}

-			// $sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

-			// $sql.= ' AND entity = '.$conf->entity;

-

-			dol_syslog(get_class($this) . ':showOutputField:$type=chkbxlst',LOG_DEBUG);

-			$resql = $this->db->query($sql);

-			if ($resql) {

-				$value = ''; // value was used, so now we reste it to use it to build final output

-				$toprint=array();

-				while ( $obj = $this->db->fetch_object($resql) ) {

-

-					// Several field into label (eq table:code|libelle:rowid)

-					$fields_label = explode('|', $InfoFieldList[1]);

-					if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

-						if (is_array($fields_label) && count($fields_label) > 1) {

-							foreach ( $fields_label as $field_toshow ) {

-								$translabel = '';

-								if (! empty($obj->$field_toshow)) {

-									$translabel = $langs->trans($obj->$field_toshow);

-								}

-								if ($translabel != $field_toshow) {

-									$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

-								} else {

-									$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->$field_toshow.'</li>';

-								}

-							}

-						} else {

-							$translabel = '';

-							if (! empty($obj->{$InfoFieldList[1]})) {

-								$translabel = $langs->trans($obj->{$InfoFieldList[1]});

-							}

-							if ($translabel != $obj->{$InfoFieldList[1]}) {

-								$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

-							} else {

-								$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->{$InfoFieldList[1]}.'</li>';

-							}

-						}

-					}

-				}

-				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

-			} else {

-				dol_syslog(get_class($this) . '::showOutputField error ' . $this->db->lasterror(), LOG_WARNING);

-			}

-		}

-		elseif ($type == 'link')

-		{

-			$out='';

-

-			// only if something to display (perf)

-			if ($value)

-			{

-				$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

+        $fieldvalues = $this->setSaveQuery();

+        if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation']=$this->db->idate($now);

+        if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat']=$user->id;

+        unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.

 

-				$InfoFieldList = explode(":", $param_list[0]);

-				$classname=$InfoFieldList[0];

-				$classpath=$InfoFieldList[1];

-				$getnomurlparam=(empty($InfoFieldList[2]) ? 3 : $InfoFieldList[2]);

-				if (! empty($classpath))

-				{

-					dol_include_once($InfoFieldList[1]);

-					if ($classname && class_exists($classname))

-					{

-						$object = new $classname($this->db);

-						$object->fetch($value);

-						$value=$object->getNomUrl($getnomurlparam);

-					}

-				}

-				else

-				{

-					dol_syslog('Error bad setup of extrafield', LOG_WARNING);

-					return 'Error bad setup of extrafield';

-				}

-			}

-			else $value='';

-		}

-		elseif ($type == 'text' || $type == 'html')

-		{

-			$value=dol_htmlentitiesbr($value);

-		}

-		elseif ($type == 'password')

-		{

-			$value=preg_replace('/./i','*',$value);

-		}

-		elseif ($type == 'array')

-		{

-			$value = implode('<br>', $value);

-		}

-

-		//print $type.'-'.$size;

-		$out=$value;

-

-		return $out;

-	}

-

-

-	/**

-	 * Function to show lines of extrafields with output datas

-	 *

-	 * @param 	Extrafields $extrafields    Extrafield Object

-	 * @param 	string      $mode           Show output (view) or input (edit) for extrafield

-	 * @param 	array       $params         Optional parameters. Example: array('style'=>'class="oddeven"', 'colspan'=>$colspan)

-	 * @param 	string      $keysuffix      Suffix string to add after name and id of field (can be used to avoid duplicate names)

-	 * @param 	string      $keyprefix      Prefix string to add before name and id of field (can be used to avoid duplicate names)

-	 * @param	string		$onetrtd		All fields in same tr td

-	 * @return 	string

-	 */

-	function showOptionals($extrafields, $mode='view', $params=null, $keysuffix='', $keyprefix='', $onetrtd=0)

-	{

-		global $db, $conf, $langs, $action, $form;

-

-		if (! is_object($form)) $form=new Form($db);

-

-		$out = '';

-

-		if (is_array($extrafields->attributes[$this->table_element]['label']) && count($extrafields->attributes[$this->table_element]['label']) > 0)

-		{

-			$out .= "\n";

-			$out .= '<!-- showOptionalsInput --> ';

-			$out .= "\n";

-

-			$e = 0;

-			foreach($extrafields->attributes[$this->table_element]['label'] as $key=>$label)

-			{

-				// Show only the key field in params

-				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) continue;

+        $keys=array();

+        $values = array();

+        foreach ($fieldvalues as $k => $v) {

+            $keys[$k] = $k;

+            $value = $this->fields[$k];

+            $values[$k] = $this->quote($v, $value);

+        }

 

-				$enabled = 1;

-				if ($enabled && isset($extrafields->attributes[$this->table_element]['list'][$key]))

-				{

-					$enabled = dol_eval($extrafields->attributes[$this->table_element]['list'][$key], 1);

-				}

+        // Clean and check mandatory

+        foreach($keys as $key)

+        {

+            // If field is an implicit foreign key field

+            if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';

+            if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';

 

-				$perms = 1;

-				if ($perms && isset($extrafields->attributes[$this->table_element]['perms'][$key]))

-				{

-					$perms = dol_eval($extrafields->attributes[$this->table_element]['perms'][$key], 1);

-				}

+            //var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

+            if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && ! isset($values[$key]) && is_null($val['default']))

+            {

+                $error++;

+                $this->errors[]=$langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);

+            }

 

-				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue;	// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

-				if (empty($perms)) continue;

+            // If field is an implicit foreign key field

+            if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key]='null';

+            if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key]='null';

+        }

 

-				// Load language if required

-				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);

+        if ($error) return -1;

 

-				$colspan='3';

-				if (is_array($params) && count($params)>0) {

-					if (array_key_exists('colspan',$params)) {

-						$colspan=$params['colspan'];

-					}

-				}

+        $this->db->begin();

 

-				switch($mode) {

-					case "view":

-						$value=$this->array_options["options_".$key.$keysuffix];

-						break;

-					case "edit":

-						$getposttemp = GETPOST($keyprefix.'options_'.$key.$keysuffix, 'none');				// GETPOST can get value from GET, POST or setup of default values.

-						// GETPOST("options_" . $key) can be 'abc' or array(0=>'abc')

-						if (is_array($getposttemp) || $getposttemp != '' || GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix))

-						{

-							if (is_array($getposttemp)) {

-								// $getposttemp is an array but following code expects a comma separated string

-								$value = implode(",", $getposttemp);

-							} else {

-								$value = $getposttemp;

-							}

-						} else {

-							$value = $this->array_options["options_" . $key];			// No GET, no POST, no default value, so we take value of object.

-						}

-						//var_dump($keyprefix.' - '.$key.' - '.$keysuffix.' - '.$keyprefix.'options_'.$key.$keysuffix.' - '.$this->array_options["options_".$key.$keysuffix].' - '.$getposttemp.' - '.$value);

-						break;

-				}

+        if (! $error)

+        {

+            $sql = 'INSERT INTO '.MAIN_DB_PREFIX.$this->table_element;

+            $sql.= ' ('.implode( ", ", $keys ).')';

+            $sql.= ' VALUES ('.implode( ", ", $values ).')';

+

+            $res = $this->db->query($sql);

+            if ($res===false) {

+                $error++;

+                $this->errors[] = $this->db->lasterror();

+            }

+        }

 

-				if ($extrafields->attributes[$this->table_element]['type'][$key] == 'separate')

-				{

-					$out .= $extrafields->showSeparator($key, $this);

-				}

-				else

-				{

-					$csstyle='';

-					$class=(!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');

-					if (is_array($params) && count($params)>0) {

-						if (array_key_exists('style',$params)) {

-							$csstyle=$params['style'];

-						}

-					}

+        if (! $error)

+        {

+            $this->id = $this->db->last_insert_id(MAIN_DB_PREFIX . $this->table_element);

+        }

 

-					// add html5 elements

-					$domData  = ' data-element="extrafield"';

-					$domData .= ' data-targetelement="'.$this->element.'"';

-					$domData .= ' data-targetid="'.$this->id.'"';

+        // Create extrafields

+        if (! $error)

+        {

+            $result=$this->insertExtraFields();

+            if ($result < 0) $error++;

+        }

 

-					$html_id = !empty($this->id) ? 'extrarow-'.$this->element.'_'.$key.'_'.$this->id : '';

+        // Triggers

+        if (! $error && ! $notrigger)

+        {

+            // Call triggers

+            $result=$this->call_trigger(strtoupper(get_class($this)).'_CREATE',$user);

+            if ($result < 0) { $error++; }

+            // End call triggers

+        }

 

-					$out .= '<tr id="'.$html_id.'" '.$csstyle.' class="'.$class.$this->element.'_extras_'.$key.'" '.$domData.' >';

+        // Commit or rollback

+        if ($error) {

+            $this->db->rollback();

+            return -1;

+        } else {

+            $this->db->commit();

+            return $this->id;

+        }

+    }

 

-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0)

-					{

-						if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0) { $colspan='0'; }

-					}

 

-					if ($action == 'selectlines') { $colspan++; }

+    /**

+     * Load object in memory from the database

+     *

+     * @param	int    $id				Id object

+     * @param	string $ref				Ref

+     * @param	string	$morewhere		More SQL filters (' AND ...')

+     * @return 	int         			<0 if KO, 0 if not found, >0 if OK

+     */

+    public function fetchCommon($id, $ref = null, $morewhere = '')

+    {

+        if (empty($id) && empty($ref) && empty($morewhere)) return -1;

 

-					// Convert date into timestamp format (value in memory must be a timestamp)

-					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('date','datetime')))

-					{

-						$datenotinstring = $this->array_options['options_' . $key];

-						if (! is_numeric($this->array_options['options_' . $key]))	// For backward compatibility

-						{

-							$datenotinstring = $this->db->jdate($datenotinstring);

-						}

-						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min",'int',3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year",'int',3)):$datenotinstring;

-					}

-					// Convert float submited string into real php numeric (value in memory must be a php numeric)

-					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('price','double')))

-					{

-						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?price2num(GETPOST($keyprefix.'options_'.$key.$keysuffix, 'alpha', 3)):$this->array_options['options_'.$key];

-					}

-

-					$labeltoshow = $langs->trans($label);

-

-					$out .= '<td class="titlefield';

-					if (GETPOST('action','none') == 'create') $out.='create';

-					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';

-					$out .= '">';

-					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);

-					else $out .= $labeltoshow;

-					$out .= '</td>';

-

-					$html_id = !empty($this->id) ? $this->element.'_extras_'.$key.'_'.$this->id : '';

-					$out .='<td id="'.$html_id.'" class="'.$this->element.'_extras_'.$key.'" '.($colspan?' colspan="'.$colspan.'"':'').'>';

-

-					switch($mode) {

-						case "view":

-							$out .= $extrafields->showOutputField($key, $value);

-							break;

-						case "edit":

-							$out .= $extrafields->showInputField($key, $value, '', $keysuffix, '', 0, $this->id);

-							break;

-					}

-

-					$out .= '</td>';

-

-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';

-					else $out .= '</tr>';

-					$e++;

-				}

-			}

-			$out .= "\n";

-			// Add code to manage list depending on others

-			if (! empty($conf->use_javascript_ajax)) {

-				$out .= '

-				<script type="text/javascript">

-				    jQuery(document).ready(function() {

-				    	function showOptions(child_list, parent_list)

-				    	{

-				    		var val = $("select[name=\"options_"+parent_list+"\"]").val();

-				    		var parentVal = parent_list + ":" + val;

-							if(val > 0) {

-					    		$("select[name=\""+child_list+"\"] option[parent]").hide();

-					    		$("select[name=\""+child_list+"\"] option[parent=\""+parentVal+"\"]").show();

-							} else {

-								$("select[name=\""+child_list+"\"] option").show();

-							}

-				    	}

-						function setListDependencies() {

-					    	jQuery("select option[parent]").parent().each(function() {

-					    		var child_list = $(this).attr("name");

-								var parent = $(this).find("option[parent]:first").attr("parent");

-								var infos = parent.split(":");

-								var parent_list = infos[0];

-								$("select[name=\""+parent_list+"\"]").change(function() {

-									showOptions(child_list, parent_list);

-								});

-					    	});

-						}

+        $sql = 'SELECT '.$this->getFieldList();

+        $sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element;

 

-						setListDependencies();

-				    });

-				</script>'."\n";

-				$out .= '<!-- /showOptionalsInput --> '."\n";

-			}

-		}

-		return $out;

-	}

-

-

-	/**

-	 * Returns the rights used for this class

-	 * @return stdClass

-	 */

-	public function getRights()

-	{

-		global $user;

-

-		$element = $this->element;

-		if ($element == 'facturerec') $element='facture';

-

-		return $user->rights->{$element};

-	}

-

-	/**

-	 * Function used to replace a thirdparty id with another one.

-	 * This function is meant to be called from replaceThirdparty with the appropiate tables

-	 * Column name fk_soc MUST be used to identify thirdparties

-	 *

-	 * @param  DoliDB 	   $db 			  Database handler

-	 * @param  int 		   $origin_id     Old thirdparty id (the thirdparty to delete)

-	 * @param  int 		   $dest_id       New thirdparty id (the thirdparty that will received element of the other)

-	 * @param  string[]    $tables        Tables that need to be changed

-	 * @param  int         $ignoreerrors  Ignore errors. Return true even if errors. We need this when replacement can fails like for categories (categorie of old thirdparty may already exists on new one)

-	 * @return bool						  True if success, False if error

-	 */

-	public static function commonReplaceThirdparty(DoliDB $db, $origin_id, $dest_id, array $tables, $ignoreerrors=0)

-	{

-		foreach ($tables as $table)

-		{

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$table.' SET fk_soc = '.$dest_id.' WHERE fk_soc = '.$origin_id;

-

-			if (! $db->query($sql))

-			{

-				if ($ignoreerrors) return true;		// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

-				//$this->errors = $db->lasterror();

-				return false;

-			}

-		}

-

-		return true;

-	}

-

-	/**

-	 * Get buy price to use for margin calculation. This function is called when buy price is unknown.

-	 *	 Set buy price = sell price if ForceBuyingPriceIfNull configured,

-	 *   else if calculation MARGIN_TYPE = 'costprice' and costprice is defined, use costprice as buyprice

-	 *	 else if calculation MARGIN_TYPE = 'pmp' and pmp is calculated, use pmp as buyprice

-	 *	 else set min buy price as buy price

-	 *

-	 * @param float		$unitPrice		 Product unit price

-	 * @param float		$discountPercent Line discount percent

-	 * @param int		$fk_product		 Product id

-	 * @return	float                    <0 if KO, buyprice if OK

-	 */

-	public function defineBuyPrice($unitPrice = 0.0, $discountPercent = 0.0, $fk_product = 0)

-	{

-		global $conf;

-

-		$buyPrice = 0;

-

-		if (($unitPrice > 0) && (isset($conf->global->ForceBuyingPriceIfNull) && $conf->global->ForceBuyingPriceIfNull == 1)) // In most cases, test here is false

-		{

-			$buyPrice = $unitPrice * (1 - $discountPercent / 100);

-		}

-		else

-		{

-			// Get cost price for margin calculation

-			if (! empty($fk_product))

-			{

-				if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'costprice')

-				{

-					require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

-					$product = new Product($this->db);

-					$result = $product->fetch($fk_product);

-					if ($result <= 0)

-					{

-						$this->errors[] = 'ErrorProductIdDoesNotExists';

-						return -1;

-					}

-					if ($product->cost_price > 0)

-					{

-						$buyPrice = $product->cost_price;

-					}

-					else if ($product->pmp > 0)

-					{

-						$buyPrice = $product->pmp;

-					}

-				}

-				else if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'pmp')

-				{

-					require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

-					$product = new Product($this->db);

-					$result = $product->fetch($fk_product);

-					if ($result <= 0)

-					{

-						$this->errors[] = 'ErrorProductIdDoesNotExists';

-						return -1;

-					}

-					if ($product->pmp > 0)

-					{

-						$buyPrice = $product->pmp;

-					}

-				}

+        if (!empty($id))  $sql.= ' WHERE rowid = '.$id;

+        elseif (!empty($ref)) $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);

+        else $sql.=' WHERE 1 = 1';	// usage with empty id and empty ref is very rare

+        if ($morewhere)   $sql.= $morewhere;

+        $sql.=' LIMIT 1';	// This is a fetch, to be sure to get only one record

 

-				if (empty($buyPrice) && isset($conf->global->MARGIN_TYPE) && in_array($conf->global->MARGIN_TYPE, array('1','pmp','costprice')))

-				{

-					require_once DOL_DOCUMENT_ROOT.'/fourn/class/fournisseur.product.class.php';

-					$productFournisseur = new ProductFournisseur($this->db);

-					if (($result = $productFournisseur->find_min_price_product_fournisseur($fk_product)) > 0)

-					{

-						$buyPrice = $productFournisseur->fourn_unitprice;

-					}

-					else if ($result < 0)

-					{

-						$this->errors[] = $productFournisseur->error;

-						return -2;

-					}

-				}

-			}

-		}

-		return $buyPrice;

-	}

+        $res = $this->db->query($sql);

+        if ($res)

+        {

+            $obj = $this->db->fetch_object($res);

+            if ($obj)

+            {

+                $this->setVarsFromFetchObj($obj);

+                return $this->id;

+            }

+            else

+            {

+                return 0;

+            }

+        }

+        else

+        {

+            $this->error = $this->db->lasterror();

+            $this->errors[] = $this->error;

+            return -1;

+        }

+    }

 

-    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

-	/**

-	 *  Show photos of an object (nbmax maximum), into several columns

-	 *

-	 *  @param		string	$modulepart		'product', 'ticket', ...

-	 *  @param      string	$sdir        	Directory to scan (full absolute path)

-	 *  @param      int		$size        	0=original size, 1='small' use thumbnail if possible

-	 *  @param      int		$nbmax       	Nombre maximum de photos (0=pas de max)

-	 *  @param      int		$nbbyrow     	Number of image per line or -1 to use div. Used only if size=1.

-	 * 	@param		int		$showfilename	1=Show filename

-	 * 	@param		int		$showaction		1=Show icon with action links (resize, delete)

-	 * 	@param		int		$maxHeight		Max height of original image when size='small' (so we can use original even if small requested). If 0, always use 'small' thumb image.

-	 * 	@param		int		$maxWidth		Max width of original image when size='small'

-	 *  @param      int     $nolink         Do not add a href link to view enlarged imaged into a new tab

-	 *  @param      int     $notitle        Do not add title tag on image

-	 *  @param		int		$usesharelink	Use the public shared link of image (if not available, the 'nophoto' image will be shown instead)

-	 *  @return     string					Html code to show photo. Number of photos shown is saved in this->nbphoto

-	 */

-	function show_photos($modulepart, $sdir, $size=0, $nbmax=0, $nbbyrow=5, $showfilename=0, $showaction=0, $maxHeight=120, $maxWidth=160, $nolink=0, $notitle=0, $usesharelink=0)

-	{

-        // phpcs:enable

-		global $conf,$user,$langs;

-

-		include_once DOL_DOCUMENT_ROOT .'/core/lib/files.lib.php';

-		include_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';

-

-		$sortfield='position_name';

-		$sortorder='asc';

-

-		$dir = $sdir . '/';

-		$pdir = '/';

-		if ($modulepart == 'ticket')

-		{

-			$dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

-			$pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

-		}

-		else

-		{

-			$dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

-			$pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

-		}

-

-		// For backward compatibility

-		if ($modulepart == 'product' && ! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))

-		{

-			$dir = $sdir . '/'. get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";

-			$pdir = '/' . get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";

-		}

-

-		// Defined relative dir to DOL_DATA_ROOT

-		$relativedir = '';

-		if ($dir)

-		{

-			$relativedir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $dir);

-			$relativedir = preg_replace('/^[\\/]/','',$relativedir);

-			$relativedir = preg_replace('/[\\/]$/','',$relativedir);

-		}

-

-		$dirthumb = $dir.'thumbs/';

-		$pdirthumb = $pdir.'thumbs/';

-

-		$return ='<!-- Photo -->'."\n";

-		$nbphoto=0;

-

-		$filearray=dol_dir_list($dir,"files",0,'','(\.meta|_preview.*\.png)$',$sortfield,(strtolower($sortorder)=='desc'?SORT_DESC:SORT_ASC),1);

-

-		/*if (! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))    // For backward compatiblity, we scan also old dirs

-		 {

-		 $filearrayold=dol_dir_list($dirold,"files",0,'','(\.meta|_preview.*\.png)$',$sortfield,(strtolower($sortorder)=='desc'?SORT_DESC:SORT_ASC),1);

-		 $filearray=array_merge($filearray, $filearrayold);

-		 }*/

+    /**

+     * Update object into database

+     *

+     * @param  User $user      	User that modifies

+     * @param  bool $notrigger 	false=launch triggers after, true=disable triggers

+     * @return int             	<0 if KO, >0 if OK

+     */

+    public function updateCommon(User $user, $notrigger = false)

+    {

+        global $conf, $langs;

 

-		completeFileArrayWithDatabaseInfo($filearray, $relativedir);

+        $error = 0;

 

-		if (count($filearray))

-		{

-			if ($sortfield && $sortorder)

-			{

-				$filearray=dol_sort_array($filearray, $sortfield, $sortorder);

-			}

+        $now=dol_now();

 

-			foreach($filearray as $key => $val)

-			{

-				$photo='';

-				$file = $val['name'];

+        $fieldvalues = $this->setSaveQuery();

+        if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification']=$this->db->idate($now);

+        if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif']=$user->id;

+        unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.

 

-				//if (! utf8_check($file)) $file=utf8_encode($file);	// To be sure file is stored in UTF8 in memory

+        $keys=array();

+        $values = array();

+        foreach ($fieldvalues as $k => $v) {

+            $keys[$k] = $k;

+            $value = $this->fields[$k];

+            $values[$k] = $this->quote($v, $value);

+            $tmp[] = $k.'='.$this->quote($v, $this->fields[$k]);

+        }

 

-				//if (dol_is_file($dir.$file) && image_format_supported($file) >= 0)

-				if (image_format_supported($file) >= 0)

-				{

-					$nbphoto++;

-					$photo = $file;

-					$viewfilename = $file;

+        // Clean and check mandatory

+        foreach($keys as $key)

+        {

+            if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';		// This is an implicit foreign key field

+            if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';					// This is an explicit foreign key field

+

+            //var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

+            /*

+			if ($this->fields[$key]['notnull'] == 1 && empty($values[$key]))

+			{

+				$error++;

+				$this->errors[]=$langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);

+			}*/

+        }

 

-					if ($size == 1 || $size == 'small') {   // Format vignette

+        $sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode( ',', $tmp ).' WHERE rowid='.$this->id ;

 

-						// Find name of thumb file

-						$photo_vignette=basename(getImageFileNameForSize($dir.$file, '_small'));

-						if (! dol_is_file($dirthumb.$photo_vignette)) $photo_vignette='';

+        $this->db->begin();

+        if (! $error)

+        {

+            $res = $this->db->query($sql);

+            if ($res===false)

+            {

+                $error++;

+                $this->errors[] = $this->db->lasterror();

+            }

+        }

 

-						// Get filesize of original file

-						$imgarray=dol_getImageSize($dir.$photo);

+        // Update extrafield

+        if (! $error && empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && is_array($this->array_options) && count($this->array_options)>0)

+        {

+            $result=$this->insertExtraFields();

+            if ($result < 0)

+            {

+                $error++;

+            }

+        }

 

-						if ($nbbyrow > 0)

-						{

-							if ($nbphoto == 1) $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';

+        // Triggers

+        if (! $error && ! $notrigger)

+        {

+            // Call triggers

+            $result=$this->call_trigger(strtoupper(get_class($this)).'_MODIFY',$user);

+            if ($result < 0) { $error++; } //Do also here what you must do to rollback action if trigger fail

+            // End call triggers

+        }

 

-							if ($nbphoto % $nbbyrow == 1) $return.= '<tr align=center valign=middle border=1>';

-							$return.= '<td width="'.ceil(100/$nbbyrow).'%" class="photo">';

-						}

-						else if ($nbbyrow < 0) $return .= '<div class="inline-block">';

+        // Commit or rollback

+        if ($error) {

+            $this->db->rollback();

+            return -1;

+        } else {

+            $this->db->commit();

+            return $this->id;

+        }

+    }

 

-						$return.= "\n";

+    /**

+     * Delete object in database

+     *

+     * @param 	User 	$user       			User that deletes

+     * @param 	bool 	$notrigger  			false=launch triggers after, true=disable triggers

+     * @param	int		$forcechilddeletion		0=no, 1=Force deletion of children

+     * @return 	int             				<=0 if KO, >0 if OK

+     */

+    public function deleteCommon(User $user, $notrigger=false, $forcechilddeletion=0)

+    {

+        $error=0;

 

-						$relativefile=preg_replace('/^\//', '', $pdir.$photo);

-						if (empty($nolink))

-						{

-							$urladvanced=getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);

-							if ($urladvanced) $return.='<a href="'.$urladvanced.'">';

-							else $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';

-						}

+        $this->db->begin();

 

-						// Show image (width height=$maxHeight)

-						// Si fichier vignette disponible et image source trop grande, on utilise la vignette, sinon on utilise photo origine

-						$alt=$langs->transnoentitiesnoconv('File').': '.$relativefile;

-						$alt.=' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];

-						if ($notitle) $alt='';

-

-						if ($usesharelink)

-						{

-							if ($val['share'])

-							{

-								if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

-								{

-									$return.= '<!-- Show original file (thumb not yet available with shared links) -->';

-									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

-								}

-								else {

-									$return.= '<!-- Show original file -->';

-									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

-								}

-							}

-							else

-							{

-								$return.= '<!-- Show nophoto file (because file is not shared) -->';

-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';

-							}

-						}

-						else

-						{

-							if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

-							{

-								$return.= '<!-- Show thumb -->';

-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';

-							}

-							else {

-								$return.= '<!-- Show original file -->';

-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';

-							}

-						}

+        if ($forcechilddeletion)

+        {

+            foreach($this->childtables as $table)

+            {

+                $sql = 'DELETE FROM '.MAIN_DB_PREFIX.$table.' WHERE '.$this->fk_element.' = '.$this->id;

+                $resql = $this->db->query($sql);

+                if (! $resql)

+                {

+                    $this->error=$this->db->lasterror();

+                    $this->errors[]=$this->error;

+                    $this->db->rollback();

+                    return -1;

+                }

+            }

+        }

+        elseif (! empty($this->fk_element) && ! empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.

+        {

+            $objectisused = $this->isObjectUsed($this->id);

+            if (! empty($objectisused))

+            {

+                dol_syslog(get_class($this)."::deleteCommon Can't delete record as it has some child", LOG_WARNING);

+                $this->error='ErrorRecordHasChildren';

+                $this->errors[]=$this->error;

+                $this->db->rollback();

+                return 0;

+            }

+        }

 

-						if (empty($nolink)) $return.= '</a>';

-						$return.="\n";

-

-						if ($showfilename) $return.= '<br>'.$viewfilename;

-						if ($showaction)

-						{

-							$return.= '<br>';

-							// On propose la generation de la vignette si elle n'existe pas et si la taille est superieure aux limites

-							if ($photo_vignette && (image_format_supported($photo) > 0) && ($this->imgWidth > $maxWidth || $this->imgHeight > $maxHeight))

-							{

-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=addthumb&amp;file='.urlencode($pdir.$viewfilename).'">'.img_picto($langs->trans('GenerateThumb'),'refresh').'&nbsp;&nbsp;</a>';

-							}

-							// Special cas for product

-							if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))

-							{

-								// Link to resize

-								$return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

-

-								// Link to delete

-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

-								$return.= img_delete().'</a>';

-							}

-						}

-						$return.= "\n";

+        if (! $error) {

+            if (! $notrigger) {

+                // Call triggers

+                $result=$this->call_trigger(strtoupper(get_class($this)).'_DELETE', $user);

+                if ($result < 0) { $error++; } // Do also here what you must do to rollback action if trigger fail

+                // End call triggers

+            }

+        }

 

-						if ($nbbyrow > 0)

-						{

-							$return.= '</td>';

-							if (($nbphoto % $nbbyrow) == 0) $return.= '</tr>';

-						}

-						else if ($nbbyrow < 0) $return.='</div>';

-					}

-

-					if (empty($size)) {     // Format origine

-						$return.= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';

-

-						if ($showfilename) $return.= '<br>'.$viewfilename;

-						if ($showaction)

-						{

-							// Special case for product

-							if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))

-							{

-								// Link to resize

-								$return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

-

-								// Link to delete

-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

-								$return.= img_delete().'</a>';

-							}

-						}

-					}

+        if (! $error && ! empty($this->isextrafieldmanaged))

+        {

+            $sql = "DELETE FROM " . MAIN_DB_PREFIX . $this->table_element."_extrafields";

+            $sql.= " WHERE fk_object=" . $this->id;

 

-					// On continue ou on arrete de boucler ?

-					if ($nbmax && $nbphoto >= $nbmax) break;

-				}

-			}

+            $resql = $this->db->query($sql);

+            if (! $resql)

+            {

+                $this->errors[] = $this->db->lasterror();

+                $error++;

+            }

+        }

 

-			if ($size==1 || $size=='small')

-			{

-				if ($nbbyrow > 0)

-				{

-					// Ferme tableau

-					while ($nbphoto % $nbbyrow)

-					{

-						$return.= '<td width="'.ceil(100/$nbbyrow).'%">&nbsp;</td>';

-						$nbphoto++;

-					}

-

-					if ($nbphoto) $return.= '</table>';

-				}

-			}

-		}

-

-		$this->nbphoto = $nbphoto;

-

-		return $return;

-	}

-

-

-	/**

-	 * Function test if type is array

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	protected function isArray($info)

-	{

-		if(is_array($info))

-		{

-			if(isset($info['type']) && $info['type']=='array') return true;

-			else return false;

-		}

-		else return false;

-	}

-

-	/**

-	 * Function test if type is null

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	protected function isNull($info)

-	{

-		if(is_array($info))

-		{

-			if(isset($info['type']) && $info['type']=='null') return true;

-			else return false;

-		}

-		else return false;

-	}

-

-	/**

-	 * Function test if type is date

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	public function isDate($info)

-	{

-		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) return true;

-		else return false;

-	}

-

-	/**

-	 * Function test if type is integer

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	public function isInt($info)

-	{

-		if(is_array($info))

-		{

-			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) return true;

-			else return false;

-		}

-		else return false;

-	}

-

-	/**

-	 * Function test if type is float

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	public function isFloat($info)

-	{

-		if(is_array($info))

-		{

-			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) return true;

-			else return false;

-		}

-		else return false;

-	}

-

-	/**

-	 * Function test if type is text

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	public function isText($info)

-	{

-		if(is_array($info))

-		{

-			if(isset($info['type']) && $info['type']=='text') return true;

-			else return false;

-		}

-		else return false;

-	}

-

-	/**

-	 * Function test if is indexed

-	 *

-	 * @param   array   $info   content informations of field

-	 * @return                  bool

-	 */

-	protected function isIndex($info)

-	{

-		if(is_array($info))

-		{

-			if(isset($info['index']) && $info['index']==true) return true;

-			else return false;

-		}

-		else return false;

-	}

-

-	/**

-	 * Function to prepare the values to insert.

-	 * Note $this->${field} are set by the page that make the createCommon or the updateCommon.

-	 *

-	 * @return array

-	 */

-	protected function setSaveQuery()

-	{

-		global $conf;

-

-		$queryarray=array();

-		foreach ($this->fields as $field=>$info)	// Loop on definition of fields

-		{

-			// Depending on field type ('datetime', ...)

-			if($this->isDate($info))

-			{

-				if(empty($this->{$field}))

-				{

-					$queryarray[$field] = null;

-				}

-				else

-				{

-					$queryarray[$field] = $this->db->idate($this->{$field});

-				}

-			}

-			else if($this->isArray($info))

-			{

-				if(! empty($this->{$field})) {

-					if(! is_array($this->{$field})) {

-						$this->{$field} = array($this->{$field});

-					}

-					$queryarray[$field] = serialize($this->{$field});

-				} else {

-					$queryarray[$field] = null;

-				}

-			}

-			else if($this->isInt($info))

-			{

-				if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field]=$conf->entity;

-				else

-				{

-					$queryarray[$field] = (int) price2num($this->{$field});

-					if (empty($queryarray[$field])) $queryarray[$field]=0;		// May be reset to null later if property 'notnull' is -1 for this field.

-				}

-			}

-			else if($this->isFloat($info))

-			{

-				$queryarray[$field] = (double) price2num($this->{$field});

-				if (empty($queryarray[$field])) $queryarray[$field]=0;

-			}

-			else

-			{

-				$queryarray[$field] = $this->{$field};

-			}

+        if (! $error)

+        {

+            $sql = 'DELETE FROM '.MAIN_DB_PREFIX.$this->table_element.' WHERE rowid='.$this->id;

 

-			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) unset($queryarray[$field]);

-			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;

-		}

+            $res = $this->db->query($sql);

+            if($res===false) {

+                $error++;

+                $this->errors[] = $this->db->lasterror();

+            }

+        }

 

-		return $queryarray;

-	}

+        // Commit or rollback

+        if ($error) {

+            $this->db->rollback();

+            return -1;

+        } else {

+            $this->db->commit();

+            return 1;

+        }

+    }

 

-	/**

-	 * Function to load data from a SQL pointer into properties of current object $this

-	 *

-	 * @param   stdClass    $obj    Contain data of object from database

+    /**

+     * Initialise object with example values

+     * Id must be 0 if object instance is a specimen

+     *

      * @return void

-	 */

-	protected function setVarsFromFetchObj(&$obj)

-	{

-		foreach ($this->fields as $field => $info)

-		{

-			if($this->isDate($info))

-			{

-				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;

-				else $this->{$field} = strtotime($obj->{$field});

-			}

-			elseif($this->isArray($info))

-			{

-				if(! empty($obj->{$field})) {

-					$this->{$field} = @unserialize($obj->{$field});

-					// Hack for data not in UTF8

-					if($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));

-				} else {

-					$this->{$field} = array();

-				}

-			}

-			elseif($this->isInt($info))

-			{

-				if ($field == 'rowid') $this->id = (int) $obj->{$field};

-				else $this->{$field} = (int) $obj->{$field};

-			}

-			elseif($this->isFloat($info))

-			{

-				$this->{$field} = (double) $obj->{$field};

-			}

-			elseif($this->isNull($info))

-			{

-				$val = $obj->{$field};

-				// zero is not null

-				$this->{$field} = (is_null($val) || (empty($val) && $val!==0 && $val!=='0') ? null : $val);

-			}

-			else

-			{

-				$this->{$field} = $obj->{$field};

-			}

-		}

-

-		// If there is no 'ref' field, we force property ->ref to ->id for a better compatibility with common functions.

-		if (! isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;

-	}

-

-	/**

-	 * Function to concat keys of fields

-	 *

-	 * @return string

-	 */

-	protected function getFieldList()

-	{

-		$keys = array_keys($this->fields);

-		return implode(',', $keys);

-	}

-

-	/**

-	 * Add quote to field value if necessary

-	 *

-	 * @param 	string|int	$value			Value to protect

-	 * @param	array		$fieldsentry	Properties of field

-	 * @return 	string

-	 */

-    protected function quote($value, $fieldsentry)

+     */

+    public function initAsSpecimenCommon()

     {

-		if (is_null($value)) return 'NULL';

-		else if (preg_match('/^(int|double|real)/i', $fieldsentry['type'])) return $this->db->escape("$value");

-		else return "'".$this->db->escape($value)."'";

-	}

-

-

-	/**

-	 * Create object into database

-	 *

-	 * @param  User $user      User that creates

-	 * @param  bool $notrigger false=launch triggers after, true=disable triggers

-	 * @return int             <0 if KO, Id of created object if OK

-	 */

-	public function createCommon(User $user, $notrigger = false)

-	{

-		global $langs;

-

-		$error = 0;

-

-		$now=dol_now();

-

-		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation']=$this->db->idate($now);

-		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat']=$user->id;

-		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.

-

-		$keys=array();

-		$values = array();

-		foreach ($fieldvalues as $k => $v) {

-			$keys[$k] = $k;

-			$value = $this->fields[$k];

-			$values[$k] = $this->quote($v, $value);

-		}

-

-		// Clean and check mandatory

-		foreach($keys as $key)

-		{

-			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';

-

-			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

-			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && ! isset($values[$key]) && is_null($val['default']))

-			{

-				$error++;

-				$this->errors[]=$langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);

-			}

-

-			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key]='null';

-			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key]='null';

-		}

-

-		if ($error) return -1;

-

-		$this->db->begin();

+        $this->id = 0;

 

-		if (! $error)

-		{

-			$sql = 'INSERT INTO '.MAIN_DB_PREFIX.$this->table_element;

-			$sql.= ' ('.implode( ", ", $keys ).')';

-			$sql.= ' VALUES ('.implode( ", ", $values ).')';

+        // TODO...

+    }

 

-			$res = $this->db->query($sql);

-			if ($res===false) {

-				$error++;

-				$this->errors[] = $this->db->lasterror();

-			}

-		}

-

-		if (! $error)

-		{

-			$this->id = $this->db->last_insert_id(MAIN_DB_PREFIX . $this->table_element);

-		}

-

-		// Create extrafields

-		if (! $error)

-		{

-			$result=$this->insertExtraFields();

-			if ($result < 0) $error++;

-		}

-

-		// Triggers

-		if (! $error && ! $notrigger)

-		{

-			// Call triggers

-			$result=$this->call_trigger(strtoupper(get_class($this)).'_CREATE',$user);

-			if ($result < 0) { $error++; }

-			// End call triggers

-		}

-

-		// Commit or rollback

-		if ($error) {

-			$this->db->rollback();

-			return -1;

-		} else {

-			$this->db->commit();

-			return $this->id;

-		}

-	}

-

-

-	/**

-	 * Load object in memory from the database

-	 *

-	 * @param	int    $id				Id object

-	 * @param	string $ref				Ref

-	 * @param	string	$morewhere		More SQL filters (' AND ...')

-	 * @return 	int         			<0 if KO, 0 if not found, >0 if OK

-	 */

-	public function fetchCommon($id, $ref = null, $morewhere = '')

-	{

-		if (empty($id) && empty($ref) && empty($morewhere)) return -1;

-

-		$sql = 'SELECT '.$this->getFieldList();

-		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element;

-

-		if (!empty($id))  $sql.= ' WHERE rowid = '.$id;

-		elseif (!empty($ref)) $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);

-		else $sql.=' WHERE 1 = 1';	// usage with empty id and empty ref is very rare

-		if ($morewhere)   $sql.= $morewhere;

-		$sql.=' LIMIT 1';	// This is a fetch, to be sure to get only one record

-

-		$res = $this->db->query($sql);

-		if ($res)

-		{

-			$obj = $this->db->fetch_object($res);

-			if ($obj)

-			{

-				$this->setVarsFromFetchObj($obj);

-				return $this->id;

-			}

-			else

-			{

-				return 0;

-			}

-		}

-		else

-		{

-			$this->error = $this->db->lasterror();

-			$this->errors[] = $this->error;

-			return -1;

-		}

-	}

-

-	/**

-	 * Update object into database

-	 *

-	 * @param  User $user      	User that modifies

-	 * @param  bool $notrigger 	false=launch triggers after, true=disable triggers

-	 * @return int             	<0 if KO, >0 if OK

-	 */

-	public function updateCommon(User $user, $notrigger = false)

-	{

-		global $conf, $langs;

-

-		$error = 0;

-

-		$now=dol_now();

-

-		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification']=$this->db->idate($now);

-		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif']=$user->id;

-		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.

-

-		$keys=array();

-		$values = array();

-		foreach ($fieldvalues as $k => $v) {

-			$keys[$k] = $k;

-			$value = $this->fields[$k];

-			$values[$k] = $this->quote($v, $value);

-			$tmp[] = $k.'='.$this->quote($v, $this->fields[$k]);

-		}

-

-		// Clean and check mandatory

-		foreach($keys as $key)

-		{

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';		// This is an implicit foreign key field

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';					// This is an explicit foreign key field

-

-			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

-			/*

-			if ($this->fields[$key]['notnull'] == 1 && empty($values[$key]))

-			{

-				$error++;

-				$this->errors[]=$langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);

-			}*/

-		}

 

-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode( ',', $tmp ).' WHERE rowid='.$this->id ;

+    /* Part for comments */

 

-		$this->db->begin();

-		if (! $error)

-		{

-			$res = $this->db->query($sql);

-			if ($res===false)

-			{

-				$error++;

-				$this->errors[] = $this->db->lasterror();

-			}

-		}

-

-		// Update extrafield

-		if (! $error && empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && is_array($this->array_options) && count($this->array_options)>0)

-		{

-			$result=$this->insertExtraFields();

-			if ($result < 0)

-			{

-				$error++;

-			}

-		}

-

-		// Triggers

-		if (! $error && ! $notrigger)

-		{

-			// Call triggers

-			$result=$this->call_trigger(strtoupper(get_class($this)).'_MODIFY',$user);

-			if ($result < 0) { $error++; } //Do also here what you must do to rollback action if trigger fail

-			// End call triggers

-		}

-

-		// Commit or rollback

-		if ($error) {

-			$this->db->rollback();

-			return -1;

-		} else {

-			$this->db->commit();

-			return $this->id;

-		}

-	}

-

-	/**

-	 * Delete object in database

-	 *

-	 * @param 	User 	$user       			User that deletes

-	 * @param 	bool 	$notrigger  			false=launch triggers after, true=disable triggers

-	 * @param	int		$forcechilddeletion		0=no, 1=Force deletion of children

-	 * @return 	int             				<=0 if KO, >0 if OK

-	 */

-	public function deleteCommon(User $user, $notrigger=false, $forcechilddeletion=0)

-	{

-		$error=0;

-

-		$this->db->begin();

-

-		if ($forcechilddeletion)

-		{

-			foreach($this->childtables as $table)

-			{

-				$sql = 'DELETE FROM '.MAIN_DB_PREFIX.$table.' WHERE '.$this->fk_element.' = '.$this->id;

-				$resql = $this->db->query($sql);

-				if (! $resql)

-				{

-					$this->error=$this->db->lasterror();

-					$this->errors[]=$this->error;

-					$this->db->rollback();

-					return -1;

-				}

-			}

-		}

-		elseif (! empty($this->fk_element) && ! empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.

-		{

-			$objectisused = $this->isObjectUsed($this->id);

-			if (! empty($objectisused))

-			{

-				dol_syslog(get_class($this)."::deleteCommon Can't delete record as it has some child", LOG_WARNING);

-				$this->error='ErrorRecordHasChildren';

-				$this->errors[]=$this->error;

-				$this->db->rollback();

-				return 0;

-			}

-		}

-

-		if (! $error) {

-			if (! $notrigger) {

-				// Call triggers

-				$result=$this->call_trigger(strtoupper(get_class($this)).'_DELETE', $user);

-				if ($result < 0) { $error++; } // Do also here what you must do to rollback action if trigger fail

-				// End call triggers

-			}

-		}

-

-		if (! $error && ! empty($this->isextrafieldmanaged))

-		{

-			$sql = "DELETE FROM " . MAIN_DB_PREFIX . $this->table_element."_extrafields";

-			$sql.= " WHERE fk_object=" . $this->id;

-

-			$resql = $this->db->query($sql);

-			if (! $resql)

-			{

-				$this->errors[] = $this->db->lasterror();

-				$error++;

-			}

-		}

+    /**

+     * Load comments linked with current task

+     *	@return boolean	1 if ok

+     */

+    public function fetchComments()

+    {

+        require_once DOL_DOCUMENT_ROOT.'/core/class/comment.class.php';

 

-		if (! $error)

-		{

-			$sql = 'DELETE FROM '.MAIN_DB_PREFIX.$this->table_element.' WHERE rowid='.$this->id;

+        $comment = new Comment($this->db);

+        $result=$comment->fetchAllFor($this->element, $this->id);

+        if ($result<0) {

+            $this->errors=array_merge($this->errors, $comment->errors);

+            return -1;

+        } else {

+            $this->comments = $comment->comments;

+        }

+        return count($this->comments);

+    }

 

-			$res = $this->db->query($sql);

-			if($res===false) {

-				$error++;

-				$this->errors[] = $this->db->lasterror();

-			}

-		}

-

-		// Commit or rollback

-		if ($error) {

-			$this->db->rollback();

-			return -1;

-		} else {

-			$this->db->commit();

-			return 1;

-		}

-	}

-

-	/**

-	 * Initialise object with example values

-	 * Id must be 0 if object instance is a specimen

-	 *

-	 * @return void

-	 */

-	public function initAsSpecimenCommon()

-	{

-		$this->id = 0;

-

-		// TODO...

-	}

-

-

-	/* Part for comments */

-

-	/**

-	 * Load comments linked with current task

-	 *	@return boolean	1 if ok

-	 */

-	public function fetchComments()

-	{

-		require_once DOL_DOCUMENT_ROOT.'/core/class/comment.class.php';

-

-		$comment = new Comment($this->db);

-		$result=$comment->fetchAllFor($this->element, $this->id);

-		if ($result<0) {

-			$this->errors=array_merge($this->errors, $comment->errors);

-			return -1;

-		} else {

-			$this->comments = $comment->comments;

-		}

-		return count($this->comments);

-	}

-

-	/**

-	 * Return nb comments already posted

-	 *

-	 * @return int

-	 */

-	public function getNbComments()

-	{

-		return count($this->comments);

-	}

+    /**

+     * Return nb comments already posted

+     *

+     * @return int

+     */

+    public function getNbComments()

+    {

+        return count($this->comments);

+    }

 

     /**

      * Trim object parameters

Spacing +1526 added lines, -1526 removed lines

@@ -34,7 +34,7 @@ 
 	/**

 	 * @var string[]	Array of error strings

 	 */

-	public $errors=array();

+	public $errors = array();

 

 	/**

 	 * @var string ID to identify managed object

@@ -49,7 +49,7 @@ 
 	/**

 	 * @var int    Name of subtable line

 	 */

-	public $table_element_line='';

+	public $table_element_line = '';

 

 	/**

 	 * @var string		Key value used to track if data is coming from import wizard

@@ -59,7 +59,7 @@ 
 	/**

 	 * @var mixed		Contains data to manage extrafields

 	 */

-	public $array_options=array();

+	public $array_options = array();

 

 	/**

 	 * @var int[][]		Array of linked objects ids. Loaded by ->fetchObjectLinked

@@ -88,7 +88,7 @@ 
 	/**

 	 * @var array<string,mixed>		Can be used to pass information when only object is provided to method

 	 */

-	public $context=array();

+	public $context = array();

 

 	/**

 	 * @var string		Contains canvas name if record is an alternative canvas record

@@ -348,7 +348,7 @@ 
 	 * @var mixed		Contains comments

 	 * @see fetchComments()

 	 */

-	public $comments=array();

+	public $comments = array();

 

 	/**

 	 * @var int

@@ -374,9 +374,9 @@ 
 	public $civility_id;

 

 	// Dates

-	public $date_creation;			// Date creation

-	public $date_validation;		// Date validation

-	public $date_modification;		// Date last change (tms field)

+	public $date_creation; // Date creation

+	public $date_validation; // Date validation

+	public $date_modification; // Date last change (tms field)

 

 

 

@@ -392,29 +392,29 @@ 
 	 *  @param	string	$ref_ext	Ref ext of object to check

 	 *  @return int     			<0 if KO, 0 if OK but not found, >0 if OK and exists

 	 */

-	static function isExistingObject($element, $id, $ref='', $ref_ext='')

+	static function isExistingObject($element, $id, $ref = '', $ref_ext = '')

 	{

-		global $db,$conf;

+		global $db, $conf;

 

 		$sql = "SELECT rowid, ref, ref_ext";

-		$sql.= " FROM ".MAIN_DB_PREFIX.$element;

-		$sql.= " WHERE entity IN (".getEntity($element).")" ;

+		$sql .= " FROM ".MAIN_DB_PREFIX.$element;

+		$sql .= " WHERE entity IN (".getEntity($element).")";

 

-		if ($id > 0) $sql.= " AND rowid = ".$db->escape($id);

-		else if ($ref) $sql.= " AND ref = '".$db->escape($ref)."'";

-		else if ($ref_ext) $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";

+		if ($id > 0) $sql .= " AND rowid = ".$db->escape($id);

+		else if ($ref) $sql .= " AND ref = '".$db->escape($ref)."'";

+		else if ($ref_ext) $sql .= " AND ref_ext = '".$db->escape($ref_ext)."'";

 		else {

-			$error='ErrorWrongParameters';

+			$error = 'ErrorWrongParameters';

 			dol_print_error(get_class()."::isExistingObject ".$error, LOG_ERR);

 			return -1;

 		}

-		if ($ref || $ref_ext) $sql.= " AND entity = ".$conf->entity;

+		if ($ref || $ref_ext) $sql .= " AND entity = ".$conf->entity;

 

 		dol_syslog(get_class()."::isExistingObject", LOG_DEBUG);

 		$resql = $db->query($sql);

 		if ($resql)

 		{

-			$num=$db->num_rows($resql);

+			$num = $db->num_rows($resql);

 			if ($num > 0) return 1;

 			else return 0;

 		}

@@ -428,7 +428,7 @@ 
 	 */

 	function errorsToString()

 	{

-		return $this->error.(is_array($this->errors)?(($this->error!=''?', ':'').join(', ',$this->errors)):'');

+		return $this->error.(is_array($this->errors) ? (($this->error != '' ? ', ' : '').join(', ', $this->errors)) : '');

 	}

 

 	/**

@@ -440,23 +440,23 @@ 
 	 * 	@param	int			$maxlen			Maximum length

 	 * 	@return	string						String with full name

 	 */

-	function getFullName($langs,$option=0,$nameorder=-1,$maxlen=0)

+	function getFullName($langs, $option = 0, $nameorder = -1, $maxlen = 0)

 	{

 		//print "lastname=".$this->lastname." name=".$this->name." nom=".$this->nom."<br>\n";

-		$lastname=$this->lastname;

-		$firstname=$this->firstname;

-		if (empty($lastname))  $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));

+		$lastname = $this->lastname;

+		$firstname = $this->firstname;

+		if (empty($lastname))  $lastname = (isset($this->lastname) ? $this->lastname : (isset($this->name) ? $this->name : (isset($this->nom) ? $this->nom : (isset($this->societe) ? $this->societe : (isset($this->company) ? $this->company : '')))));

 

-		$ret='';

+		$ret = '';

 		if ($option && $this->civility_id)

 		{

-			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';

-			else $ret.=$this->civility_id.' ';

+			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id) != "Civility".$this->civility_id) $ret .= $langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';

+			else $ret .= $this->civility_id.' ';

 		}

 

-		$ret.=dolGetFirstLastname($firstname, $lastname, $nameorder);

+		$ret .= dolGetFirstLastname($firstname, $lastname, $nameorder);

 

-		return dol_trunc($ret,$maxlen);

+		return dol_trunc($ret, $maxlen);

 	}

 

 	/**

@@ -467,24 +467,24 @@ 
 	 *  @param		int		    $withregion			1=Add region into address string

 	 *	@return		string							Full address string

 	 */

-	function getFullAddress($withcountry=0, $sep="\n", $withregion=0)

+	function getFullAddress($withcountry = 0, $sep = "\n", $withregion = 0)

 	{

 		if ($withcountry && $this->country_id && (empty($this->country_code) || empty($this->country)))

 		{

-			require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';

-			$tmparray=getCountry($this->country_id,'all');

-			$this->country_code=$tmparray['code'];

-			$this->country     =$tmparray['label'];

+			require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';

+			$tmparray = getCountry($this->country_id, 'all');

+			$this->country_code = $tmparray['code'];

+			$this->country     = $tmparray['label'];

 		}

 

         if ($withregion && $this->state_id && (empty($this->state_code) || empty($this->state) || empty($this->region) || empty($this->region_cpde)))

     	{

-    		require_once DOL_DOCUMENT_ROOT .'/core/lib/company.lib.php';

-    		$tmparray=getState($this->state_id,'all',0,1);

-			$this->state_code   =$tmparray['code'];

-			$this->state        =$tmparray['label'];

-			$this->region_code  =$tmparray['region_code'];

-			$this->region       =$tmparray['region'];

+    		require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';

+    		$tmparray = getState($this->state_id, 'all', 0, 1);

+			$this->state_code   = $tmparray['code'];

+			$this->state        = $tmparray['label'];

+			$this->region_code  = $tmparray['region_code'];

+			$this->region       = $tmparray['region'];

         }

 

 		return dol_format_address($this, $withcountry, $sep);

@@ -502,108 +502,108 @@ 
 	{

 		global $conf, $langs;

 

-		$countriesusingstate=array('AU','US','IN','GB','ES','UK','TR');    // See also option MAIN_FORCE_STATE_INTO_ADDRESS

+		$countriesusingstate = array('AU', 'US', 'IN', 'GB', 'ES', 'UK', 'TR'); // See also option MAIN_FORCE_STATE_INTO_ADDRESS

 

-		$contactid=0;

-		$thirdpartyid=0;

+		$contactid = 0;

+		$thirdpartyid = 0;

 		if ($this->element == 'societe')

 		{

-			$thirdpartyid=$this->id;

+			$thirdpartyid = $this->id;

 		}

 		if ($this->element == 'contact')

 		{

-			$contactid=$this->id;

-			$thirdpartyid=$object->fk_soc;

+			$contactid = $this->id;

+			$thirdpartyid = $object->fk_soc;

 		}

 		if ($this->element == 'user')

 		{

-			$contactid=$this->contact_id;

-			$thirdpartyid=$object->fk_soc;

+			$contactid = $this->contact_id;

+			$thirdpartyid = $object->fk_soc;

 		}

 

-		$out='<!-- BEGIN part to show address block -->';

+		$out = '<!-- BEGIN part to show address block -->';

 

-		$outdone=0;

-		$coords = $this->getFullAddress(1,', ',$conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT);

+		$outdone = 0;

+		$coords = $this->getFullAddress(1, ', ', $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT);

 		if ($coords)

 		{

-			if (! empty($conf->use_javascript_ajax))

+			if (!empty($conf->use_javascript_ajax))

 			{

-				$namecoords = $this->getFullName($langs,1).'<br>'.$coords;

+				$namecoords = $this->getFullName($langs, 1).'<br>'.$coords;

 				// hideonsmatphone because copyToClipboard call jquery dialog that does not work with jmobile

-				$out.='<a href="#" class="hideonsmartphone" onclick="return copyToClipboard(\''.dol_escape_js($namecoords).'\',\''.dol_escape_js($langs->trans("HelpCopyToClipboard")).'\');">';

-				$out.=img_picto($langs->trans("Address"), 'object_address.png');

-				$out.='</a> ';

+				$out .= '<a href="#" class="hideonsmartphone" onclick="return copyToClipboard(\''.dol_escape_js($namecoords).'\',\''.dol_escape_js($langs->trans("HelpCopyToClipboard")).'\');">';

+				$out .= img_picto($langs->trans("Address"), 'object_address.png');

+				$out .= '</a> ';

 			}

-			$out.=dol_print_address($coords, 'address_'.$htmlkey.'_'.$this->id, $this->element, $this->id, 1, ', '); $outdone++;

+			$out .= dol_print_address($coords, 'address_'.$htmlkey.'_'.$this->id, $this->element, $this->id, 1, ', '); $outdone++;

 			$outdone++;

 		}

 

-		if (! in_array($this->country_code,$countriesusingstate) && empty($conf->global->MAIN_FORCE_STATE_INTO_ADDRESS)   // If MAIN_FORCE_STATE_INTO_ADDRESS is on, state is already returned previously with getFullAddress

+		if (!in_array($this->country_code, $countriesusingstate) && empty($conf->global->MAIN_FORCE_STATE_INTO_ADDRESS)   // If MAIN_FORCE_STATE_INTO_ADDRESS is on, state is already returned previously with getFullAddress

 				&& empty($conf->global->SOCIETE_DISABLE_STATE) && $this->state)

 		{

             if (!empty($conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT) && $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT == 1 && $this->region) {

-                $out.=($outdone?' - ':'').$this->region.' - '.$this->state;

+                $out .= ($outdone ? ' - ' : '').$this->region.' - '.$this->state;

             }

             else {

-                $out.=($outdone?' - ':'').$this->state;

+                $out .= ($outdone ? ' - ' : '').$this->state;

             }

 			$outdone++;

 		}

 

-		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) $out.=($outdone?'<br>':'');

-		if (! empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone

-			$out.=dol_print_phone($this->phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

+		if (!empty($this->phone) || !empty($this->phone_pro) || !empty($this->phone_mobile) || !empty($this->phone_perso) || !empty($this->fax) || !empty($this->office_phone) || !empty($this->user_mobile) || !empty($this->office_fax)) $out .= ($outdone ? '<br>' : '');

+		if (!empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone

+			$out .= dol_print_phone($this->phone, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePro")); $outdone++;

 		}

-		if (! empty($this->phone_pro)) {

-			$out.=dol_print_phone($this->phone_pro,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

+		if (!empty($this->phone_pro)) {

+			$out .= dol_print_phone($this->phone_pro, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePro")); $outdone++;

 		}

-		if (! empty($this->phone_mobile)) {

-			$out.=dol_print_phone($this->phone_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;

+		if (!empty($this->phone_mobile)) {

+			$out .= dol_print_phone($this->phone_mobile, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'mobile', $langs->trans("PhoneMobile")); $outdone++;

 		}

-		if (! empty($this->phone_perso)) {

-			$out.=dol_print_phone($this->phone_perso,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePerso")); $outdone++;

+		if (!empty($this->phone_perso)) {

+			$out .= dol_print_phone($this->phone_perso, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePerso")); $outdone++;

 		}

-		if (! empty($this->office_phone)) {

-			$out.=dol_print_phone($this->office_phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

+		if (!empty($this->office_phone)) {

+			$out .= dol_print_phone($this->office_phone, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'phone', $langs->trans("PhonePro")); $outdone++;

 		}

-		if (! empty($this->user_mobile)) {

-			$out.=dol_print_phone($this->user_mobile,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','mobile',$langs->trans("PhoneMobile")); $outdone++;

+		if (!empty($this->user_mobile)) {

+			$out .= dol_print_phone($this->user_mobile, $this->country_code, $contactid, $thirdpartyid, 'AC_TEL', '&nbsp;', 'mobile', $langs->trans("PhoneMobile")); $outdone++;

 		}

-		if (! empty($this->fax)) {

-			$out.=dol_print_phone($this->fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;

+		if (!empty($this->fax)) {

+			$out .= dol_print_phone($this->fax, $this->country_code, $contactid, $thirdpartyid, 'AC_FAX', '&nbsp;', 'fax', $langs->trans("Fax")); $outdone++;

 		}

-		if (! empty($this->office_fax)) {

-			$out.=dol_print_phone($this->office_fax,$this->country_code,$contactid,$thirdpartyid,'AC_FAX','&nbsp;','fax',$langs->trans("Fax")); $outdone++;

+		if (!empty($this->office_fax)) {

+			$out .= dol_print_phone($this->office_fax, $this->country_code, $contactid, $thirdpartyid, 'AC_FAX', '&nbsp;', 'fax', $langs->trans("Fax")); $outdone++;

 		}

 

-		$out.='<div style="clear: both;"></div>';

-		$outdone=0;

-		if (! empty($this->email))

+		$out .= '<div style="clear: both;"></div>';

+		$outdone = 0;

+		if (!empty($this->email))

 		{

-			$out.=dol_print_email($this->email,$this->id,$object->id,'AC_EMAIL',0,0,1);

+			$out .= dol_print_email($this->email, $this->id, $object->id, 'AC_EMAIL', 0, 0, 1);

 			$outdone++;

 		}

-		if (! empty($this->url))

+		if (!empty($this->url))

 		{

-			$out.=dol_print_url($this->url,'_goout',0,1);

+			$out .= dol_print_url($this->url, '_goout', 0, 1);

 			$outdone++;

 		}

-		$out.='<div style="clear: both;">';

-		if (! empty($conf->socialnetworks->enabled))

+		$out .= '<div style="clear: both;">';

+		if (!empty($conf->socialnetworks->enabled))

 		{

-			if ($this->skype) $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');

+			if ($this->skype) $out .= dol_print_socialnetworks($this->skype, $this->id, $object->id, 'skype');

 			$outdone++;

-			if ($this->jabberid) $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');

+			if ($this->jabberid) $out .= dol_print_socialnetworks($this->jabberid, $this->id, $object->id, 'jabber');

 			$outdone++;

-			if ($this->twitter) $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');

+			if ($this->twitter) $out .= dol_print_socialnetworks($this->twitter, $this->id, $object->id, 'twitter');

 			$outdone++;

-			if ($this->facebook) $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');

+			if ($this->facebook) $out .= dol_print_socialnetworks($this->facebook, $this->id, $object->id, 'facebook');

 			$outdone++;

 		}

-		$out.='</div>';

+		$out .= '</div>';

 

-		$out.='<!-- END Part to show address block -->';

+		$out .= '<!-- END Part to show address block -->';

 

 		return $out;

 	}

@@ -616,17 +616,17 @@ 
 	 * @param	int		$relativelink		0=Return full external link, 1=Return link relative to root of file

 	 * @return	string						Link or empty string if there is no download link

 	 */

-	function getLastMainDocLink($modulepart, $initsharekey=0, $relativelink=0)

+	function getLastMainDocLink($modulepart, $initsharekey = 0, $relativelink = 0)

 	{

 		global $user, $dolibarr_main_url_root;

 

 		if (empty($this->last_main_doc))

 		{

-			return '';		// No way to known which document name to use

+			return ''; // No way to known which document name to use

 		}

 

 		include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';

-		$ecmfile=new EcmFiles($this->db);

+		$ecmfile = new EcmFiles($this->db);

 		$result = $ecmfile->fetch(0, '', $this->last_main_doc);

 		if ($result < 0)

 		{

@@ -674,26 +674,26 @@ 
 		}

 

 		// Define $urlwithroot

-		$urlwithouturlroot=preg_replace('/'.preg_quote(DOL_URL_ROOT,'/').'$/i','',trim($dolibarr_main_url_root));

-		$urlwithroot=$urlwithouturlroot.DOL_URL_ROOT;		// This is to use external domain name found into config file

+		$urlwithouturlroot = preg_replace('/'.preg_quote(DOL_URL_ROOT, '/').'$/i', '', trim($dolibarr_main_url_root));

+		$urlwithroot = $urlwithouturlroot.DOL_URL_ROOT; // This is to use external domain name found into config file

 		//$urlwithroot=DOL_MAIN_URL_ROOT;					// This is to use same domain name than current

 

-		$forcedownload=0;

+		$forcedownload = 0;

 

-		$paramlink='';

+		$paramlink = '';

 		//if (! empty($modulepart)) $paramlink.=($paramlink?'&':'').'modulepart='.$modulepart;		// For sharing with hash (so public files), modulepart is not required.

 		//if (! empty($ecmfile->entity)) $paramlink.='&entity='.$ecmfile->entity; 					// For sharing with hash (so public files), entity is not required.

 		//$paramlink.=($paramlink?'&':'').'file='.urlencode($filepath);								// No need of name of file for public link, we will use the hash

-		if (! empty($ecmfile->share)) $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;			// Hash for public share

-		if ($forcedownload) $paramlink.=($paramlink?'&':'').'attachment=1';

+		if (!empty($ecmfile->share)) $paramlink .= ($paramlink ? '&' : '').'hashp='.$ecmfile->share; // Hash for public share

+		if ($forcedownload) $paramlink .= ($paramlink ? '&' : '').'attachment=1';

 

 		if ($relativelink)

 		{

-			$linktoreturn='document.php'.($paramlink?'?'.$paramlink:'');

+			$linktoreturn = 'document.php'.($paramlink ? '?'.$paramlink : '');

 		}

 		else

 		{

-			$linktoreturn=$urlwithroot.'/document.php'.($paramlink?'?'.$paramlink:'');

+			$linktoreturn = $urlwithroot.'/document.php'.($paramlink ? '?'.$paramlink : '');

 		}

 

 		// Here $ecmfile->share is defined

@@ -711,10 +711,10 @@ 
 	 *  @param  int		$notrigger			Disable all triggers

 	 *  @return int                 		<0 if KO, >0 if OK

 	 */

-	function add_contact($fk_socpeople, $type_contact, $source='external',$notrigger=0)

+	function add_contact($fk_socpeople, $type_contact, $source = 'external', $notrigger = 0)

 	{

         // phpcs:enable

-		global $user,$langs;

+		global $user, $langs;

 

 

 		dol_syslog(get_class($this)."::add_contact $fk_socpeople, $type_contact, $source, $notrigger");

@@ -723,43 +723,43 @@ 
 		if ($fk_socpeople <= 0)

 		{

 			$langs->load("errors");

-			$this->error=$langs->trans("ErrorWrongValueForParameterX","1");

-			dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);

+			$this->error = $langs->trans("ErrorWrongValueForParameterX", "1");

+			dol_syslog(get_class($this)."::add_contact ".$this->error, LOG_ERR);

 			return -1;

 		}

-		if (! $type_contact)

+		if (!$type_contact)

 		{

 			$langs->load("errors");

-			$this->error=$langs->trans("ErrorWrongValueForParameterX","2");

-			dol_syslog(get_class($this)."::add_contact ".$this->error,LOG_ERR);

+			$this->error = $langs->trans("ErrorWrongValueForParameterX", "2");

+			dol_syslog(get_class($this)."::add_contact ".$this->error, LOG_ERR);

 			return -2;

 		}

 

-		$id_type_contact=0;

+		$id_type_contact = 0;

 		if (is_numeric($type_contact))

 		{

-			$id_type_contact=$type_contact;

+			$id_type_contact = $type_contact;

 		}

 		else

 		{

 			// We look for id type_contact

 			$sql = "SELECT tc.rowid";

-			$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

-			$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

-			$sql.= " AND tc.source='".$this->db->escape($source)."'";

-			$sql.= " AND tc.code='".$this->db->escape($type_contact)."' AND tc.active=1";

+			$sql .= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

+			$sql .= " WHERE tc.element='".$this->db->escape($this->element)."'";

+			$sql .= " AND tc.source='".$this->db->escape($source)."'";

+			$sql .= " AND tc.code='".$this->db->escape($type_contact)."' AND tc.active=1";

 			//print $sql;

-			$resql=$this->db->query($sql);

+			$resql = $this->db->query($sql);

 			if ($resql)

 			{

 				$obj = $this->db->fetch_object($resql);

-				if ($obj) $id_type_contact=$obj->rowid;

+				if ($obj) $id_type_contact = $obj->rowid;

 			}

 		}

 

 		if ($id_type_contact == 0)

 		{

-			$this->error='CODE_NOT_VALID_FOR_THIS_ELEMENT';

+			$this->error = 'CODE_NOT_VALID_FOR_THIS_ELEMENT';

 			dol_syslog("CODE_NOT_VALID_FOR_THIS_ELEMENT: Code type of contact '".$type_contact."' does not exists or is not active for element ".$this->element.", we can ignore it");

 			return -3;

 		}

@@ -767,35 +767,35 @@ 
 		$datecreate = dol_now();

 

 		// Socpeople must have already been added by some trigger, then we have to check it to avoid DB_ERROR_RECORD_ALREADY_EXISTS error

-		$TListeContacts=$this->liste_contact(-1, $source);

-		$already_added=false;

-		if(!empty($TListeContacts)) {

-			foreach($TListeContacts as $array_contact) {

-				if($array_contact['status'] == 4 && $array_contact['id'] == $fk_socpeople && $array_contact['fk_c_type_contact'] == $id_type_contact) {

-					$already_added=true;

+		$TListeContacts = $this->liste_contact(-1, $source);

+		$already_added = false;

+		if (!empty($TListeContacts)) {

+			foreach ($TListeContacts as $array_contact) {

+				if ($array_contact['status'] == 4 && $array_contact['id'] == $fk_socpeople && $array_contact['fk_c_type_contact'] == $id_type_contact) {

+					$already_added = true;

 					break;

 				}

 			}

 		}

 

-		if(!$already_added) {

+		if (!$already_added) {

 

 			$this->db->begin();

 

 			// Insert into database

 			$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_contact";

-			$sql.= " (element_id, fk_socpeople, datecreate, statut, fk_c_type_contact) ";

-			$sql.= " VALUES (".$this->id.", ".$fk_socpeople." , " ;

-			$sql.= "'".$this->db->idate($datecreate)."'";

-			$sql.= ", 4, ". $id_type_contact;

-			$sql.= ")";

+			$sql .= " (element_id, fk_socpeople, datecreate, statut, fk_c_type_contact) ";

+			$sql .= " VALUES (".$this->id.", ".$fk_socpeople." , ";

+			$sql .= "'".$this->db->idate($datecreate)."'";

+			$sql .= ", 4, ".$id_type_contact;

+			$sql .= ")";

 

-			$resql=$this->db->query($sql);

+			$resql = $this->db->query($sql);

 			if ($resql)

 			{

-				if (! $notrigger)

+				if (!$notrigger)

 				{

-					$result=$this->call_trigger(strtoupper($this->element).'_ADD_CONTACT', $user);

+					$result = $this->call_trigger(strtoupper($this->element).'_ADD_CONTACT', $user);

 					if ($result < 0)

 					{

 						$this->db->rollback();

@@ -810,14 +810,14 @@ 
 			{

 				if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')

 				{

-					$this->error=$this->db->errno();

+					$this->error = $this->db->errno();

 					$this->db->rollback();

 					echo 'err rollback';

 					return -2;

 				}

 				else

 				{

-					$this->error=$this->db->error();

+					$this->error = $this->db->error();

 					$this->db->rollback();

 					return -1;

 				}

@@ -833,15 +833,15 @@ 
 	 *    @param    string          $source     Nature of contact ('internal' or 'external')

 	 *    @return   int                         >0 if OK, <0 if KO

 	 */

-	function copy_linked_contact($objFrom, $source='internal')

+	function copy_linked_contact($objFrom, $source = 'internal')

 	{

         // phpcs:enable

 		$contacts = $objFrom->liste_contact(-1, $source);

-		foreach($contacts as $contact)

+		foreach ($contacts as $contact)

 		{

 			if ($this->add_contact($contact['id'], $contact['fk_c_type_contact'], $contact['source']) < 0)

 			{

-				$this->error=$this->db->lasterror();

+				$this->error = $this->db->lasterror();

 				return -1;

 			}

 		}

@@ -858,23 +858,23 @@ 
 	 *      @param  int		$fk_socpeople	    Id of soc_people to update (not modified if 0)

 	 *      @return int                 		<0 if KO, >= 0 if OK

 	 */

-	function update_contact($rowid, $statut, $type_contact_id=0, $fk_socpeople=0)

+	function update_contact($rowid, $statut, $type_contact_id = 0, $fk_socpeople = 0)

 	{

         // phpcs:enable

 		// Insert into database

 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_contact set";

-		$sql.= " statut = ".$statut;

-		if ($type_contact_id) $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";

-		if ($fk_socpeople) $sql.= ", fk_socpeople = '".$fk_socpeople ."'";

-		$sql.= " where rowid = ".$rowid;

-		$resql=$this->db->query($sql);

+		$sql .= " statut = ".$statut;

+		if ($type_contact_id) $sql .= ", fk_c_type_contact = '".$type_contact_id."'";

+		if ($fk_socpeople) $sql .= ", fk_socpeople = '".$fk_socpeople."'";

+		$sql .= " where rowid = ".$rowid;

+		$resql = $this->db->query($sql);

 		if ($resql)

 		{

 			return 0;

 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			return -1;

 		}

 	}

@@ -887,7 +887,7 @@ 
 	 *    @param	int		$notrigger		Disable all triggers

 	 *    @return   int						>0 if OK, <0 if KO

 	 */

-	function delete_contact($rowid, $notrigger=0)

+	function delete_contact($rowid, $notrigger = 0)

 	{

         // phpcs:enable

 		global $user;

@@ -896,14 +896,14 @@ 
 		$this->db->begin();

 

 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

-		$sql.= " WHERE rowid =".$rowid;

+		$sql .= " WHERE rowid =".$rowid;

 

 		dol_syslog(get_class($this)."::delete_contact", LOG_DEBUG);

 		if ($this->db->query($sql))

 		{

-			if (! $notrigger)

+			if (!$notrigger)

 			{

-				$result=$this->call_trigger(strtoupper($this->element).'_DELETE_CONTACT', $user);

+				$result = $this->call_trigger(strtoupper($this->element).'_DELETE_CONTACT', $user);

 				if ($result < 0) { $this->db->rollback(); return -1; }

 			}

 

@@ -912,7 +912,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return -1;

 		}

@@ -926,22 +926,22 @@ 
 	 *	  @param	string	$code		Type of contact (code or id)

 	 *    @return   int					>0 if OK, <0 if KO

 	 */

-	function delete_linked_contact($source='',$code='')

+	function delete_linked_contact($source = '', $code = '')

 	{

         // phpcs:enable

 		$temp = array();

-		$typeContact = $this->liste_type_contact($source,'',0,0,$code);

+		$typeContact = $this->liste_type_contact($source, '', 0, 0, $code);

 

-		foreach($typeContact as $key => $value)

+		foreach ($typeContact as $key => $value)

 		{

-			array_push($temp,$key);

+			array_push($temp, $key);

 		}

 		$listId = implode(",", $temp);

 

 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

-		$sql.= " WHERE element_id = ".$this->id;

+		$sql .= " WHERE element_id = ".$this->id;

 		if ($listId)

-			$sql.= " AND fk_c_type_contact IN (".$listId.")";

+			$sql .= " AND fk_c_type_contact IN (".$listId.")";

 

 		dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);

 		if ($this->db->query($sql))

@@ -950,7 +950,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			return -1;

 		}

 	}

@@ -965,54 +965,54 @@ 
 	 *    @param    string      $code       Filter on this code of contact type ('SHIPPING', 'BILLING', ...)

 	 *    @return	array|int		        Array of contacts, -1 if error

 	 */

-	function liste_contact($statut=-1,$source='external',$list=0,$code='')

+	function liste_contact($statut = -1, $source = 'external', $list = 0, $code = '')

 	{

         // phpcs:enable

 		global $langs;

 

-		$tab=array();

-

-		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact";    // This field contains id of llx_socpeople or id of llx_user

-		if ($source == 'internal') $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";

-		if ($source == 'external' || $source == 'thirdparty') $sql.=", t.fk_soc as socid, t.statut as statuscontact";

-		$sql.= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";

-		$sql.= ", tc.source, tc.element, tc.code, tc.libelle";

-		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";

-		$sql.= ", ".MAIN_DB_PREFIX."element_contact ec";

-		if ($source == 'internal') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";

-		if ($source == 'external'|| $source == 'thirdparty') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";

-		$sql.= " WHERE ec.element_id =".$this->id;

-		$sql.= " AND ec.fk_c_type_contact=tc.rowid";

-		$sql.= " AND tc.element='".$this->db->escape($this->element)."'";

-		if ($code) $sql.= " AND tc.code = '".$this->db->escape($code)."'";

-		if ($source == 'internal') $sql.= " AND tc.source = 'internal'";

-		if ($source == 'external' || $source == 'thirdparty') $sql.= " AND tc.source = 'external'";

-		$sql.= " AND tc.active=1";

-		if ($statut >= 0) $sql.= " AND ec.statut = '".$statut."'";

-		$sql.=" ORDER BY t.lastname ASC";

+		$tab = array();

+

+		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact"; // This field contains id of llx_socpeople or id of llx_user

+		if ($source == 'internal') $sql .= ", '-1' as socid, t.statut as statuscontact, t.login, t.photo";

+		if ($source == 'external' || $source == 'thirdparty') $sql .= ", t.fk_soc as socid, t.statut as statuscontact";

+		$sql .= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";

+		$sql .= ", tc.source, tc.element, tc.code, tc.libelle";

+		$sql .= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";

+		$sql .= ", ".MAIN_DB_PREFIX."element_contact ec";

+		if ($source == 'internal') $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";

+		if ($source == 'external' || $source == 'thirdparty') $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";

+		$sql .= " WHERE ec.element_id =".$this->id;

+		$sql .= " AND ec.fk_c_type_contact=tc.rowid";

+		$sql .= " AND tc.element='".$this->db->escape($this->element)."'";

+		if ($code) $sql .= " AND tc.code = '".$this->db->escape($code)."'";

+		if ($source == 'internal') $sql .= " AND tc.source = 'internal'";

+		if ($source == 'external' || $source == 'thirdparty') $sql .= " AND tc.source = 'external'";

+		$sql .= " AND tc.active=1";

+		if ($statut >= 0) $sql .= " AND ec.statut = '".$statut."'";

+		$sql .= " ORDER BY t.lastname ASC";

 

 		dol_syslog(get_class($this)."::liste_contact", LOG_DEBUG);

-		$resql=$this->db->query($sql);

+		$resql = $this->db->query($sql);

 		if ($resql)

 		{

-			$num=$this->db->num_rows($resql);

-			$i=0;

+			$num = $this->db->num_rows($resql);

+			$i = 0;

 			while ($i < $num)

 			{

 				$obj = $this->db->fetch_object($resql);

 

-				if (! $list)

+				if (!$list)

 				{

-					$transkey="TypeContact_".$obj->element."_".$obj->source."_".$obj->code;

-					$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

-					$tab[$i]=array('source'=>$obj->source,'socid'=>$obj->socid,'id'=>$obj->id,

-								   'nom'=>$obj->lastname,      // For backward compatibility

+					$transkey = "TypeContact_".$obj->element."_".$obj->source."_".$obj->code;

+					$libelle_type = ($langs->trans($transkey) != $transkey ? $langs->trans($transkey) : $obj->libelle);

+					$tab[$i] = array('source'=>$obj->source, 'socid'=>$obj->socid, 'id'=>$obj->id,

+								   'nom'=>$obj->lastname, // For backward compatibility

 								   'civility'=>$obj->civility, 'lastname'=>$obj->lastname, 'firstname'=>$obj->firstname, 'email'=>$obj->email, 'login'=>$obj->login, 'photo'=>$obj->photo, 'statuscontact'=>$obj->statuscontact,

 								   'rowid'=>$obj->rowid, 'code'=>$obj->code, 'libelle'=>$libelle_type, 'status'=>$obj->statuslink, 'fk_c_type_contact'=>$obj->fk_c_type_contact);

 				}

 				else

 				{

-					$tab[$i]=$obj->id;

+					$tab[$i] = $obj->id;

 				}

 

 				$i++;

@@ -1022,7 +1022,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			dol_print_error($this->db);

 			return -1;

 		}

@@ -1038,16 +1038,16 @@ 
 	function swapContactStatus($rowid)

 	{

 		$sql = "SELECT ec.datecreate, ec.statut, ec.fk_socpeople, ec.fk_c_type_contact,";

-		$sql.= " tc.code, tc.libelle";

+		$sql .= " tc.code, tc.libelle";

 		//$sql.= ", s.fk_soc";

-		$sql.= " FROM (".MAIN_DB_PREFIX."element_contact as ec, ".MAIN_DB_PREFIX."c_type_contact as tc)";

+		$sql .= " FROM (".MAIN_DB_PREFIX."element_contact as ec, ".MAIN_DB_PREFIX."c_type_contact as tc)";

 		//$sql.= " LEFT JOIN ".MAIN_DB_PREFIX."socpeople as s ON ec.fk_socpeople=s.rowid";	// Si contact de type external, alors il est lie a une societe

-		$sql.= " WHERE ec.rowid =".$rowid;

-		$sql.= " AND ec.fk_c_type_contact=tc.rowid";

-		$sql.= " AND tc.element = '".$this->db->escape($this->element)."'";

+		$sql .= " WHERE ec.rowid =".$rowid;

+		$sql .= " AND ec.fk_c_type_contact=tc.rowid";

+		$sql .= " AND tc.element = '".$this->db->escape($this->element)."'";

 

 		dol_syslog(get_class($this)."::swapContactStatus", LOG_DEBUG);

-		$resql=$this->db->query($sql);

+		$resql = $this->db->query($sql);

 		if ($resql)

 		{

 			$obj = $this->db->fetch_object($resql);

@@ -1058,7 +1058,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->error();

+			$this->error = $this->db->error();

 			dol_print_error($this->db);

 			return -1;

 		}

@@ -1075,44 +1075,44 @@ 
 	 *		@param	string	$code		Type of contact (Example: 'CUSTOMER', 'SERVICE')

 	 *      @return array       		Array list of type of contacts (id->label if option=0, code->label if option=1)

 	 */

-	function liste_type_contact($source='internal', $order='position', $option=0, $activeonly=0, $code='')

+	function liste_type_contact($source = 'internal', $order = 'position', $option = 0, $activeonly = 0, $code = '')

 	{

         // phpcs:enable

 		global $langs;

 

-		if (empty($order)) $order='position';

-		if ($order == 'position') $order.=',code';

+		if (empty($order)) $order = 'position';

+		if ($order == 'position') $order .= ',code';

 

 		$tab = array();

 		$sql = "SELECT DISTINCT tc.rowid, tc.code, tc.libelle, tc.position";

-		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

-		$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

-		if ($activeonly == 1) $sql.= " AND tc.active=1"; // only the active types

-		if (! empty($source) && $source != 'all') $sql.= " AND tc.source='".$this->db->escape($source)."'";

-		if (! empty($code)) $sql.= " AND tc.code='".$this->db->escape($code)."'";

-		$sql.= $this->db->order($order,'ASC');

+		$sql .= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

+		$sql .= " WHERE tc.element='".$this->db->escape($this->element)."'";

+		if ($activeonly == 1) $sql .= " AND tc.active=1"; // only the active types

+		if (!empty($source) && $source != 'all') $sql .= " AND tc.source='".$this->db->escape($source)."'";

+		if (!empty($code)) $sql .= " AND tc.code='".$this->db->escape($code)."'";

+		$sql .= $this->db->order($order, 'ASC');

 

 		//print "sql=".$sql;

-		$resql=$this->db->query($sql);

+		$resql = $this->db->query($sql);

 		if ($resql)

 		{

-			$num=$this->db->num_rows($resql);

-			$i=0;

+			$num = $this->db->num_rows($resql);

+			$i = 0;

 			while ($i < $num)

 			{

 				$obj = $this->db->fetch_object($resql);

 

-				$transkey="TypeContact_".$this->element."_".$source."_".$obj->code;

-				$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

-				if (empty($option)) $tab[$obj->rowid]=$libelle_type;

-				else $tab[$obj->code]=$libelle_type;

+				$transkey = "TypeContact_".$this->element."_".$source."_".$obj->code;

+				$libelle_type = ($langs->trans($transkey) != $transkey ? $langs->trans($transkey) : $obj->libelle);

+				if (empty($option)) $tab[$obj->rowid] = $libelle_type;

+				else $tab[$obj->code] = $libelle_type;

 				$i++;

 			}

 			return $tab;

 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			//dol_print_error($this->db);

 			return null;

 		}

@@ -1129,53 +1129,53 @@ 
 	 *		@param	int		$status		limited to a certain status

 	 *      @return array       		List of id for such contacts

 	 */

-	function getIdContact($source,$code,$status=0)

+	function getIdContact($source, $code, $status = 0)

 	{

 		global $conf;

 

-		$result=array();

-		$i=0;

+		$result = array();

+		$i = 0;

 		//cas particulier pour les expeditions

-		if($this->element=='shipping' && $this->origin_id != 0) {

-			$id=$this->origin_id;

-			$element='commande';

-        } else if($this->element=='reception' && $this->origin_id != 0) {

-            $id=$this->origin_id;

-            $element='order_supplier';

+		if ($this->element == 'shipping' && $this->origin_id != 0) {

+			$id = $this->origin_id;

+			$element = 'commande';

+        } else if ($this->element == 'reception' && $this->origin_id != 0) {

+            $id = $this->origin_id;

+            $element = 'order_supplier';

 		} else {

-			$id=$this->id;

-			$element=$this->element;

+			$id = $this->id;

+			$element = $this->element;

 		}

 

 		$sql = "SELECT ec.fk_socpeople";

-		$sql.= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";

-		if ($source == 'internal') $sql.= " ".MAIN_DB_PREFIX."user as c,";

-		if ($source == 'external') $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";

-		$sql.= " ".MAIN_DB_PREFIX."c_type_contact as tc";

-		$sql.= " WHERE ec.element_id = ".$id;

-		$sql.= " AND ec.fk_socpeople = c.rowid";

-		if ($source == 'internal') $sql.= " AND c.entity IN (".getEntity('user').")";

-		if ($source == 'external') $sql.= " AND c.entity IN (".getEntity('societe').")";

-		$sql.= " AND ec.fk_c_type_contact = tc.rowid";

-		$sql.= " AND tc.element = '".$element."'";

-		$sql.= " AND tc.source = '".$source."'";

-		$sql.= " AND tc.code = '".$code."'";

-		$sql.= " AND tc.active = 1";

-		if ($status) $sql.= " AND ec.statut = ".$status;

+		$sql .= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";

+		if ($source == 'internal') $sql .= " ".MAIN_DB_PREFIX."user as c,";

+		if ($source == 'external') $sql .= " ".MAIN_DB_PREFIX."socpeople as c,";

+		$sql .= " ".MAIN_DB_PREFIX."c_type_contact as tc";

+		$sql .= " WHERE ec.element_id = ".$id;

+		$sql .= " AND ec.fk_socpeople = c.rowid";

+		if ($source == 'internal') $sql .= " AND c.entity IN (".getEntity('user').")";

+		if ($source == 'external') $sql .= " AND c.entity IN (".getEntity('societe').")";

+		$sql .= " AND ec.fk_c_type_contact = tc.rowid";

+		$sql .= " AND tc.element = '".$element."'";

+		$sql .= " AND tc.source = '".$source."'";

+		$sql .= " AND tc.code = '".$code."'";

+		$sql .= " AND tc.active = 1";

+		if ($status) $sql .= " AND ec.statut = ".$status;

 

 		dol_syslog(get_class($this)."::getIdContact", LOG_DEBUG);

-		$resql=$this->db->query($sql);

+		$resql = $this->db->query($sql);

 		if ($resql)

 		{

 			while ($obj = $this->db->fetch_object($resql))

 			{

-				$result[$i]=$obj->fk_socpeople;

+				$result[$i] = $obj->fk_socpeople;

 				$i++;

 			}

 		}

 		else

 		{

-			$this->error=$this->db->error();

+			$this->error = $this->db->error();

 			return null;

 		}

 

@@ -1189,16 +1189,16 @@ 
 	 *		@param	int		$contactid      Id du contact. Use this->contactid if empty.

 	 *		@return	int						<0 if KO, >0 if OK

 	 */

-	function fetch_contact($contactid=null)

+	function fetch_contact($contactid = null)

 	{

         // phpcs:enable

-		if (empty($contactid)) $contactid=$this->contactid;

+		if (empty($contactid)) $contactid = $this->contactid;

 

 		if (empty($contactid)) return 0;

 

 		require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

 		$contact = new Contact($this->db);

-		$result=$contact->fetch($contactid);

+		$result = $contact->fetch($contactid);

 		$this->contact = $contact;

 		return $result;

 	}

@@ -1210,7 +1210,7 @@ 
 	 *		@param		int		$force_thirdparty_id	Force thirdparty id

 	 *		@return		int								<0 if KO, >0 if OK

 	 */

-	function fetch_thirdparty($force_thirdparty_id=0)

+	function fetch_thirdparty($force_thirdparty_id = 0)

 	{

         // phpcs:enable

 		global $conf;

@@ -1218,7 +1218,7 @@ 
 		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id))

 			return 0;

 

-		require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

+		require_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';

 

 		$idtofetch = isset($this->socid) ? $this->socid : (isset($this->fk_soc) ? $this->fk_soc : $this->fk_thirdparty);

 		if ($force_thirdparty_id)

@@ -1281,7 +1281,7 @@ 
 

 		dol_syslog(get_class($this).'::fetch_barcode this->element='.$this->element.' this->barcode_type='.$this->barcode_type);

 

-		$idtype=$this->barcode_type;

+		$idtype = $this->barcode_type;

 		if (empty($idtype) && $idtype != '0')	// If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

 		{

 			if ($this->element == 'product')      $idtype = $conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;

@@ -1294,8 +1294,8 @@ 
 			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder))    // If data not already loaded

 			{

 				$sql = "SELECT rowid, code, libelle as label, coder";

-				$sql.= " FROM ".MAIN_DB_PREFIX."c_barcode_type";

-				$sql.= " WHERE rowid = ".$idtype;

+				$sql .= " FROM ".MAIN_DB_PREFIX."c_barcode_type";

+				$sql .= " WHERE rowid = ".$idtype;

 				dol_syslog(get_class($this).'::fetch_barcode', LOG_DEBUG);

 				$resql = $this->db->query($sql);

 				if ($resql)

@@ -1328,13 +1328,13 @@ 
         // phpcs:enable

 		include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';

 

-		if (empty($this->fk_project) && ! empty($this->fk_projet)) $this->fk_project = $this->fk_projet;	// For backward compatibility

+		if (empty($this->fk_project) && !empty($this->fk_projet)) $this->fk_project = $this->fk_projet; // For backward compatibility

 		if (empty($this->fk_project)) return 0;

 

 		$project = new Project($this->db);

 		$result = $project->fetch($this->fk_project);

 

-		$this->projet = $project;	// deprecated

+		$this->projet = $project; // deprecated

 		$this->project = $project;

 		return $result;

 	}

@@ -1370,7 +1370,7 @@ 
 	{

         // phpcs:enable

 		$user = new User($this->db);

-		$result=$user->fetch($userid);

+		$result = $user->fetch($userid);

 		$this->user = $user;

 		return $result;

 	}

@@ -1408,14 +1408,14 @@ 
 	{

 		global $conf;

 

-		$result=false;

+		$result = false;

 

 		$sql = "SELECT rowid FROM ".MAIN_DB_PREFIX.$table;

-		$sql.= " WHERE ".$field." = '".$key."'";

-		if (! empty($element)) {

-			$sql.= " AND entity IN (".getEntity($element).")";

+		$sql .= " WHERE ".$field." = '".$key."'";

+		if (!empty($element)) {

+			$sql .= " AND entity IN (".getEntity($element).")";

 		} else {

-			$sql.= " AND entity = ".$conf->entity;

+			$sql .= " AND entity = ".$conf->entity;

 		}

 

 		dol_syslog(get_class($this).'::fetchObjectFrom', LOG_DEBUG);

@@ -1442,10 +1442,10 @@ 
 	 */

 	function getValueFrom($table, $id, $field)

 	{

-		$result=false;

+		$result = false;

 		if (!empty($id) && !empty($field) && !empty($table)) {

 			$sql = "SELECT ".$field." FROM ".MAIN_DB_PREFIX.$table;

-			$sql.= " WHERE rowid = ".$id;

+			$sql .= " WHERE rowid = ".$id;

 

 			dol_syslog(get_class($this).'::getValueFrom', LOG_DEBUG);

 			$resql = $this->db->query($sql);

@@ -1474,36 +1474,36 @@ 
 	 *	@return	int							<0 if KO, >0 if OK

 	 *  @see updateExtraField

 	 */

-	function setValueFrom($field, $value, $table='', $id=null, $format='', $id_field='', $fuser=null, $trigkey='', $fk_user_field='fk_user_modif')

+	function setValueFrom($field, $value, $table = '', $id = null, $format = '', $id_field = '', $fuser = null, $trigkey = '', $fk_user_field = 'fk_user_modif')

 	{

-		global $user,$langs,$conf;

+		global $user, $langs, $conf;

 

-		if (empty($table)) 	  $table=$this->table_element;

-		if (empty($id))    	  $id=$this->id;

-		if (empty($format))   $format='text';

-		if (empty($id_field)) $id_field='rowid';

+		if (empty($table)) 	  $table = $this->table_element;

+		if (empty($id))    	  $id = $this->id;

+		if (empty($format))   $format = 'text';

+		if (empty($id_field)) $id_field = 'rowid';

 

-		$error=0;

+		$error = 0;

 

 		$this->db->begin();

 

 		// Special case

-		if ($table == 'product' && $field == 'note_private') $field='note';

+		if ($table == 'product' && $field == 'note_private') $field = 'note';

 		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) $fk_user_field = 'fk_user_mod';

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$table." SET ";

 

-		if ($format == 'text') $sql.= $field." = '".$this->db->escape($value)."'";

-		else if ($format == 'int') $sql.= $field." = ".$this->db->escape($value);

-		else if ($format == 'date') $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");

+		if ($format == 'text') $sql .= $field." = '".$this->db->escape($value)."'";

+		else if ($format == 'int') $sql .= $field." = ".$this->db->escape($value);

+		else if ($format == 'date') $sql .= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");

 

 		if ($fk_user_field)

 		{

-			if (! empty($fuser) && is_object($fuser)) $sql.=", ".$fk_user_field." = ".$fuser->id;

-			elseif (empty($fuser) || $fuser != 'none') $sql.=", ".$fk_user_field." = ".$user->id;

+			if (!empty($fuser) && is_object($fuser)) $sql .= ", ".$fk_user_field." = ".$fuser->id;

+			elseif (empty($fuser) || $fuser != 'none') $sql .= ", ".$fk_user_field." = ".$user->id;

 		}

 

-		$sql.= " WHERE ".$id_field." = ".$id;

+		$sql .= " WHERE ".$id_field." = ".$id;

 

 		dol_syslog(get_class($this)."::".__FUNCTION__."", LOG_DEBUG);

 		$resql = $this->db->query($sql);

@@ -1520,11 +1520,11 @@ 
 				{

 					$result = $this->fetchCommon($id);

 				}

-				if ($result >= 0) $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);   // This may set this->errors

+				if ($result >= 0) $result = $this->call_trigger($trigkey, (!empty($fuser) && is_object($fuser)) ? $fuser : $user); // This may set this->errors

 				if ($result < 0) $error++;

 			}

 

-			if (! $error)

+			if (!$error)

 			{

 				if (property_exists($this, $field)) $this->$field = $value;

 				$this->db->commit();

@@ -1538,7 +1538,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return -1;

 		}

@@ -1553,14 +1553,14 @@ 
 	 *		@param	int		$nodbprefix	Do not include DB prefix to forge table name

 	 *      @return int         		<0 if KO, >0 if OK

 	 */

-	function load_previous_next_ref($filter, $fieldid, $nodbprefix=0)

+	function load_previous_next_ref($filter, $fieldid, $nodbprefix = 0)

 	{

         // phpcs:enable

 		global $conf, $user;

 

-		if (! $this->table_element)

+		if (!$this->table_element)

 		{

-			dol_print_error('',get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");

+			dol_print_error('', get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");

 			return -1;

 		}

 		if ($fieldid == 'none') return 1;

@@ -1575,45 +1575,45 @@ 
 		if ($this->element == 'societe') $alias = 'te';

 

 		$sql = "SELECT MAX(te.".$fieldid.")";

-		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

-		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

-		$sql.= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

-		if (! empty($filter))

-		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

-			$sql.=$filter;

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+		$sql .= " FROM ".(empty($nodbprefix) ?MAIN_DB_PREFIX:'').$this->table_element." as te";

+		if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+			$sql .= ",".MAIN_DB_PREFIX."usergroup_user as ug";

+		}

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to socid

+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid"; // If we need to link to societe to limit select to socid

+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+		$sql .= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'"; // ->ref must always be defined (set to id if field does not exists)

+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND sc.fk_user = ".$user->id;

+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND (sc.fk_user = ".$user->id.' OR te.fk_soc IS NULL)';

+		if (!empty($filter))

+		{

+			if (!preg_match('/^\s*AND/i', $filter)) $sql .= " AND "; // For backward compatibility

+			$sql .= $filter;

+		}

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to socid

 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

-			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

-					$sql.= " AND te.entity IS NOT NULL"; // Show all users

+			if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+				if (!empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

+					$sql .= " AND te.entity IS NOT NULL"; // Show all users

 				} else {

-					$sql.= " AND ug.fk_user = te.rowid";

-					$sql.= " AND ug.entity IN (".getEntity($this->element).")";

+					$sql .= " AND ug.fk_user = te.rowid";

+					$sql .= " AND ug.entity IN (".getEntity($this->element).")";

 				}

 			} else {

-				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

+				$sql .= ' AND te.entity IN ('.getEntity($this->element).')';

 			}

 		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql .= ' AND te.fk_soc = '.$socid;

+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql .= ' AND (te.fk_soc = '.$socid.' OR te.fk_soc IS NULL)';

+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql .= ' AND te.rowid = '.$socid;

 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 

 		$result = $this->db->query($sql);

-		if (! $result)

+		if (!$result)

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			return -1;

 		}

 		$row = $this->db->fetch_row($result);

@@ -1621,46 +1621,46 @@ 
 

 

 		$sql = "SELECT MIN(te.".$fieldid.")";

-		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

-		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

-		$sql.= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

-		if (! empty($filter))

-		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

-			$sql.=$filter;

-		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+		$sql .= " FROM ".(empty($nodbprefix) ?MAIN_DB_PREFIX:'').$this->table_element." as te";

+		if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+			$sql .= ",".MAIN_DB_PREFIX."usergroup_user as ug";

+		}

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ", ".MAIN_DB_PREFIX."societe as s"; // If we need to link to societe to limit select to socid

+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid"; // If we need to link to societe to limit select to socid

+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+		$sql .= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'"; // ->ref must always be defined (set to id if field does not exists)

+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND sc.fk_user = ".$user->id;

+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql .= " AND (sc.fk_user = ".$user->id.' OR te.fk_soc IS NULL)';

+		if (!empty($filter))

+		{

+			if (!preg_match('/^\s*AND/i', $filter)) $sql .= " AND "; // For backward compatibility

+			$sql .= $filter;

+		}

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql .= ' AND te.fk_soc = s.rowid'; // If we need to link to societe to limit select to socid

 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

-			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

-					$sql.= " AND te.entity IS NOT NULL"; // Show all users

+			if ($this->element == 'user' && !empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

+				if (!empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

+					$sql .= " AND te.entity IS NOT NULL"; // Show all users

 				} else {

-					$sql.= " AND ug.fk_user = te.rowid";

-					$sql.= " AND ug.entity IN (".getEntity($this->element).")";

+					$sql .= " AND ug.fk_user = te.rowid";

+					$sql .= " AND ug.entity IN (".getEntity($this->element).")";

 				}

 			} else {

-				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

+				$sql .= ' AND te.entity IN ('.getEntity($this->element).')';

 			}

 		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql .= ' AND te.fk_soc = '.$socid;

+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql .= ' AND (te.fk_soc = '.$socid.' OR te.fk_soc IS NULL)';

+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql .= ' AND te.rowid = '.$socid;

 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 		// Rem: Bug in some mysql version: SELECT MIN(rowid) FROM llx_socpeople WHERE rowid > 1 when one row in database with rowid=1, returns 1 instead of null

 

 		$result = $this->db->query($sql);

-		if (! $result)

+		if (!$result)

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			return -2;

 		}

 		$row = $this->db->fetch_row($result);

@@ -1677,11 +1677,11 @@ 
 	 *      @return array				Array of id of contacts (if source=external or internal)

 	 * 									Array of id of third parties with at least one contact on object (if source=thirdparty)

 	 */

-	function getListContactId($source='external')

+	function getListContactId($source = 'external')

 	{

 		$contactAlreadySelected = array();

-		$tab = $this->liste_contact(-1,$source);

-		$num=count($tab);

+		$tab = $this->liste_contact(-1, $source);

+		$num = count($tab);

 		$i = 0;

 		while ($i < $num)

 		{

@@ -1701,24 +1701,24 @@ 
 	 */

 	function setProject($projectid)

 	{

-		if (! $this->table_element)

+		if (!$this->table_element)

 		{

-			dol_syslog(get_class($this)."::setProject was called on objet with property table_element not defined",LOG_ERR);

+			dol_syslog(get_class($this)."::setProject was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 		if ($this->table_element == 'actioncomm')

 		{

-			if ($projectid) $sql.= ' SET fk_project = '.$projectid;

-			else $sql.= ' SET fk_project = NULL';

-			$sql.= ' WHERE id = '.$this->id;

+			if ($projectid) $sql .= ' SET fk_project = '.$projectid;

+			else $sql .= ' SET fk_project = NULL';

+			$sql .= ' WHERE id = '.$this->id;

 		}

 		else

 		{

-			if ($projectid) $sql.= ' SET fk_projet = '.$projectid;

-			else $sql.= ' SET fk_projet = NULL';

-			$sql.= ' WHERE rowid = '.$this->id;

+			if ($projectid) $sql .= ' SET fk_projet = '.$projectid;

+			else $sql .= ' SET fk_projet = NULL';

+			$sql .= ' WHERE rowid = '.$this->id;

 		}

 

 		dol_syslog(get_class($this)."::setProject", LOG_DEBUG);

@@ -1764,14 +1764,14 @@ 
 			else

 			{

 				dol_syslog(get_class($this).'::setPaymentMethods Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

+				$this->error = $this->db->error();

 				return -1;

 			}

 		}

 		else

 		{

 			dol_syslog(get_class($this).'::setPaymentMethods, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

+			$this->error = 'Status of the object is incompatible '.$this->statut;

 			return -2;

 		}

 	}

@@ -1798,21 +1798,21 @@ 
 				$this->multicurrency_code = $code;

 

 				list($fk_multicurrency, $rate) = MultiCurrency::getIdAndTxFromCode($this->db, $code);

-				if ($rate) $this->setMulticurrencyRate($rate,2);

+				if ($rate) $this->setMulticurrencyRate($rate, 2);

 

 				return 1;

 			}

 			else

 			{

 				dol_syslog(get_class($this).'::setMulticurrencyCode Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

+				$this->error = $this->db->error();

 				return -1;

 			}

 		}

 		else

 		{

 			dol_syslog(get_class($this).'::setMulticurrencyCode, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

+			$this->error = 'Status of the object is incompatible '.$this->statut;

 			return -2;

 		}

 	}

@@ -1824,7 +1824,7 @@ 
 	 *  @param		int		$mode	mode 1 : amounts in company currency will be recalculated, mode 2 : amounts in foreign currency

 	 *  @return		int				>0 if OK, <0 if KO

 	 */

-	function setMulticurrencyRate($rate, $mode=1)

+	function setMulticurrencyRate($rate, $mode = 1)

 	{

 		dol_syslog(get_class($this).'::setMulticurrencyRate('.$id.')');

 		if ($this->statut >= 0 || $this->element == 'societe')

@@ -1844,7 +1844,7 @@ 
 				{

 					foreach ($this->lines as &$line)

 					{

-						if($mode == 1) {

+						if ($mode == 1) {

 							$line->subprice = 0;

 						}

 

@@ -1852,14 +1852,14 @@ 
 							case 'propal':

 								$this->updateline(

 									$line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,

-									($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

+									($line->description ? $line->description : $line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

 									$line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->date_start,

 									$line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

 								);

 								break;

 							case 'commande':

 								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->qty, $line->remise_percent,

 									$line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->date_start, $line->date_end,

 									$line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,

 									$line->special_code, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

@@ -1867,7 +1867,7 @@ 
 								break;

 							case 'facture':

 								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->qty, $line->remise_percent,

 									$line->date_start, $line->date_end, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits,

 									$line->product_type, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label,

 									$line->special_code, $line->array_options, $line->situation_percent, $line->fk_unit, $line->multicurrency_subprice

@@ -1876,21 +1876,21 @@ 
 							case 'supplier_proposal':

 								$this->updateline(

 									$line->id, $line->subprice, $line->qty, $line->remise_percent, $line->tva_tx, $line->localtax1_tx, $line->localtax2_tx,

-									($line->description?$line->description:$line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

+									($line->description ? $line->description : $line->desc), 'HT', $line->info_bits, $line->special_code, $line->fk_parent_line,

 									$line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->product_type, $line->array_options,

 									$line->ref_fourn, $line->multicurrency_subprice

 								);

 								break;

 							case 'order_supplier':

 								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->qty, $line->remise_percent,

+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->qty, $line->remise_percent,

 									$line->tva_tx, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->product_type, false,

 									$line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

 								);

 								break;

 							case 'invoice_supplier':

 								$this->updateline(

-									$line->id, ($line->description?$line->description:$line->desc), $line->subprice, $line->tva_tx, $line->localtax1_tx,

+									$line->id, ($line->description ? $line->description : $line->desc), $line->subprice, $line->tva_tx, $line->localtax1_tx,

 									$line->localtax2_tx, $line->qty, 0, 'HT', $line->info_bits, $line->product_type, $line->remise_percent, false,

 									$line->date_start, $line->date_end, $line->array_options, $line->fk_unit, $line->multicurrency_subprice

 								);

@@ -1907,14 +1907,14 @@ 
 			else

 			{

 				dol_syslog(get_class($this).'::setMulticurrencyRate Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

+				$this->error = $this->db->error();

 				return -1;

 			}

 		}

 		else

 		{

 			dol_syslog(get_class($this).'::setMulticurrencyRate, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

+			$this->error = 'Status of the object is incompatible '.$this->statut;

 			return -2;

 		}

 	}

@@ -1944,20 +1944,20 @@ 
 				$this->cond_reglement_id = $id;

 				// for supplier

 				if (get_class($this) == 'Fournisseur') $this->cond_reglement_supplier_id = $id;

-				$this->cond_reglement = $id;	// for compatibility

+				$this->cond_reglement = $id; // for compatibility

 				return 1;

 			}

 			else

 			{

 				dol_syslog(get_class($this).'::setPaymentTerms Erreur '.$sql.' - '.$this->db->error());

-				$this->error=$this->db->error();

+				$this->error = $this->db->error();

 				return -1;

 			}

 		}

 		else

 		{

 			dol_syslog(get_class($this).'::setPaymentTerms, status of the object is incompatible');

-			$this->error='Status of the object is incompatible '.$this->statut;

+			$this->error = 'Status of the object is incompatible '.$this->statut;

 			return -2;

 		}

 	}

@@ -1975,7 +1975,7 @@ 
 		if ($this->element == 'delivery' || $this->element == 'shipping') $fieldname = 'fk_address';

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element." SET ".$fieldname." = ".$id;

-		$sql.= " WHERE rowid = ".$this->id." AND fk_statut = 0";

+		$sql .= " WHERE rowid = ".$this->id." AND fk_statut = 0";

 

 		if ($this->db->query($sql))

 		{

@@ -1984,7 +1984,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->error();

+			$this->error = $this->db->error();

 			dol_syslog(get_class($this).'::setDeliveryAddress Erreur '.$sql.' - '.$this->error);

 			return -1;

 		}

@@ -2000,29 +2000,29 @@ 
 	 *

 	 *  @return     int              1 if OK, 0 if KO

 	 */

-	function setShippingMethod($shipping_method_id, $notrigger=false, $userused=null)

+	function setShippingMethod($shipping_method_id, $notrigger = false, $userused = null)

 	{

         global $user;

 

-        if (empty($userused)) $userused=$user;

+        if (empty($userused)) $userused = $user;

 

         $error = 0;

 

-		if (! $this->table_element) {

-			dol_syslog(get_class($this)."::setShippingMethod was called on objet with property table_element not defined",LOG_ERR);

+		if (!$this->table_element) {

+			dol_syslog(get_class($this)."::setShippingMethod was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

 

         $this->db->begin();

 

-		if ($shipping_method_id<0) $shipping_method_id='NULL';

+		if ($shipping_method_id < 0) $shipping_method_id = 'NULL';

 		dol_syslog(get_class($this).'::setShippingMethod('.$shipping_method_id.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET fk_shipping_method = ".$shipping_method_id;

-		$sql.= " WHERE rowid=".$this->id;

+		$sql .= " SET fk_shipping_method = ".$shipping_method_id;

+		$sql .= " WHERE rowid=".$this->id;

         $resql = $this->db->query($sql);

-		if (! $resql) {

+		if (!$resql) {

 			dol_syslog(get_class($this).'::setShippingMethod Error ', LOG_DEBUG);

 			$this->error = $this->db->lasterror();

 			$error++;

@@ -2030,8 +2030,8 @@ 
             if (!$notrigger)

             {

                 // Call trigger

-                $this->context=array('shippingmethodupdate'=>1);

-                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

+                $this->context = array('shippingmethodupdate'=>1);

+                $result = $this->call_trigger(strtoupper(get_class($this)).'_MODIFY', $userused);

                 if ($result < 0) $error++;

                 // End call trigger

             }

@@ -2041,7 +2041,7 @@ 
             $this->db->rollback();

             return -1;

         } else {

-            $this->shipping_method_id = ($shipping_method_id=='NULL')?null:$shipping_method_id;

+            $this->shipping_method_id = ($shipping_method_id == 'NULL') ?null:$shipping_method_id;

             $this->db->commit();

             return 1;

         }

@@ -2056,23 +2056,23 @@ 
 	 */

 	function setWarehouse($warehouse_id)

 	{

-		if (! $this->table_element) {

-			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined",LOG_ERR);

+		if (!$this->table_element) {

+			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

-		if ($warehouse_id<0) $warehouse_id='NULL';

+		if ($warehouse_id < 0) $warehouse_id = 'NULL';

 		dol_syslog(get_class($this).'::setWarehouse('.$warehouse_id.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET fk_warehouse = ".$warehouse_id;

-		$sql.= " WHERE rowid=".$this->id;

+		$sql .= " SET fk_warehouse = ".$warehouse_id;

+		$sql .= " WHERE rowid=".$this->id;

 

 		if ($this->db->query($sql)) {

-			$this->warehouse_id = ($warehouse_id=='NULL')?null:$warehouse_id;

+			$this->warehouse_id = ($warehouse_id == 'NULL') ?null:$warehouse_id;

 			return 1;

 		} else {

 			dol_syslog(get_class($this).'::setWarehouse Error ', LOG_DEBUG);

-			$this->error=$this->db->error();

+			$this->error = $this->db->error();

 			return 0;

 		}

 	}

@@ -2087,25 +2087,25 @@ 
 	 */

 	function setDocModel($user, $modelpdf)

 	{

-		if (! $this->table_element)

+		if (!$this->table_element)

 		{

-			dol_syslog(get_class($this)."::setDocModel was called on objet with property table_element not defined",LOG_ERR);

+			dol_syslog(get_class($this)."::setDocModel was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

 

-		$newmodelpdf=dol_trunc($modelpdf,255);

+		$newmodelpdf = dol_trunc($modelpdf, 255);

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET model_pdf = '".$this->db->escape($newmodelpdf)."'";

-		$sql.= " WHERE rowid = ".$this->id;

+		$sql .= " SET model_pdf = '".$this->db->escape($newmodelpdf)."'";

+		$sql .= " WHERE rowid = ".$this->id;

 		// if ($this->element == 'facture') $sql.= " AND fk_statut < 2";

 		// if ($this->element == 'propal')  $sql.= " AND fk_statut = 0";

 

 		dol_syslog(get_class($this)."::setDocModel", LOG_DEBUG);

-		$resql=$this->db->query($sql);

+		$resql = $this->db->query($sql);

 		if ($resql)

 		{

-			$this->modelpdf=$modelpdf;

+			$this->modelpdf = $modelpdf;

 			return 1;

 		}

 		else

@@ -2124,29 +2124,29 @@ 
 	 *  @param      User	$userused		Object user

 	 *  @return		int				1 if OK, 0 if KO

 	 */

-	function setBankAccount($fk_account, $notrigger=false, $userused=null)

+	function setBankAccount($fk_account, $notrigger = false, $userused = null)

 	{

         global $user;

 

-        if (empty($userused)) $userused=$user;

+        if (empty($userused)) $userused = $user;

 

         $error = 0;

 

-		if (! $this->table_element) {

-			dol_syslog(get_class($this)."::setBankAccount was called on objet with property table_element not defined",LOG_ERR);

+		if (!$this->table_element) {

+			dol_syslog(get_class($this)."::setBankAccount was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

         $this->db->begin();

 

-		if ($fk_account<0) $fk_account='NULL';

+		if ($fk_account < 0) $fk_account = 'NULL';

 		dol_syslog(get_class($this).'::setBankAccount('.$fk_account.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET fk_account = ".$fk_account;

-		$sql.= " WHERE rowid=".$this->id;

+		$sql .= " SET fk_account = ".$fk_account;

+		$sql .= " WHERE rowid=".$this->id;

 

         $resql = $this->db->query($sql);

-        if (! $resql)

+        if (!$resql)

         {

             dol_syslog(get_class($this).'::setBankAccount Error '.$sql.' - '.$this->db->error());

             $this->error = $this->db->lasterror();

@@ -2157,8 +2157,8 @@ 
             if (!$notrigger)

             {

                 // Call trigger

-                $this->context=array('bankaccountupdate'=>1);

-                $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

+                $this->context = array('bankaccountupdate'=>1);

+                $result = $this->call_trigger(strtoupper(get_class($this)).'_MODIFY', $userused);

                 if ($result < 0) $error++;

                 // End call trigger

             }

@@ -2170,7 +2170,7 @@ 
         }

         else

         {

-            $this->fk_account = ($fk_account=='NULL')?null:$fk_account;

+            $this->fk_account = ($fk_account == 'NULL') ?null:$fk_account;

             $this->db->commit();

             return 1;

         }

@@ -2189,26 +2189,26 @@ 
 	 * 	@param		boolean		$fk_parent_line    Table with fk_parent_line field or not

 	 * 	@return		int                            <0 if KO, >0 if OK

 	 */

-	function line_order($renum=false, $rowidorder='ASC', $fk_parent_line=true)

+	function line_order($renum = false, $rowidorder = 'ASC', $fk_parent_line = true)

 	{

         // phpcs:enable

-		if (! $this->table_element_line)

+		if (!$this->table_element_line)

 		{

-			dol_syslog(get_class($this)."::line_order was called on objet with property table_element_line not defined",LOG_ERR);

+			dol_syslog(get_class($this)."::line_order was called on objet with property table_element_line not defined", LOG_ERR);

 			return -1;

 		}

-		if (! $this->fk_element)

+		if (!$this->fk_element)

 		{

-			dol_syslog(get_class($this)."::line_order was called on objet with property fk_element not defined",LOG_ERR);

+			dol_syslog(get_class($this)."::line_order was called on objet with property fk_element not defined", LOG_ERR);

 			return -1;

 		}

 

 		// Count number of lines to reorder (according to choice $renum)

-		$nl=0;

+		$nl = 0;

 		$sql = 'SELECT count(rowid) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.'='.$this->id;

-		if (! $renum) $sql.= ' AND rang = 0';

-		if ($renum) $sql.= ' AND rang <> 0';

+		$sql .= ' WHERE '.$this->fk_element.'='.$this->id;

+		if (!$renum) $sql .= ' AND rang = 0';

+		if ($renum) $sql .= ' AND rang <> 0';

 

 		dol_syslog(get_class($this)."::line_order", LOG_DEBUG);

 		$resql = $this->db->query($sql);

@@ -2222,28 +2222,28 @@ 
 		{

 			// The goal of this part is to reorder all lines, with all children lines sharing the same

 			// counter that parents.

-			$rows=array();

+			$rows = array();

 

 			// We first search all lines that are parent lines (for multilevel details lines)

 			$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			if ($fk_parent_line) $sql.= ' AND fk_parent_line IS NULL';

-			$sql.= ' ORDER BY rang ASC, rowid '.$rowidorder;

+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

+			if ($fk_parent_line) $sql .= ' AND fk_parent_line IS NULL';

+			$sql .= ' ORDER BY rang ASC, rowid '.$rowidorder;

 

 			dol_syslog(get_class($this)."::line_order search all parent lines", LOG_DEBUG);

 			$resql = $this->db->query($sql);

 			if ($resql)

 			{

-				$i=0;

+				$i = 0;

 				$num = $this->db->num_rows($resql);

 				while ($i < $num)

 				{

 					$row = $this->db->fetch_row($resql);

-					$rows[] = $row[0];	// Add parent line into array rows

+					$rows[] = $row[0]; // Add parent line into array rows

 					$childrens = $this->getChildrenOfLine($row[0]);

-					if (! empty($childrens))

+					if (!empty($childrens))

 					{

-						foreach($childrens as $child)

+						foreach ($childrens as $child)

 						{

 							array_push($rows, $child);

 						}

@@ -2252,11 +2252,11 @@ 
 				}

 

 				// Now we set a new number for each lines (parent and children with children included into parent tree)

-				if (! empty($rows))

+				if (!empty($rows))

 				{

-					foreach($rows as $key => $row)

+					foreach ($rows as $key => $row)

 					{

-						$this->updateRangOfLine($row, ($key+1));

+						$this->updateRangOfLine($row, ($key + 1));

 					}

 				}

 			}

@@ -2276,18 +2276,18 @@ 
 	 */

 	function getChildrenOfLine($id)

 	{

-		$rows=array();

+		$rows = array();

 

 		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-		$sql.= ' AND fk_parent_line = '.$id;

-		$sql.= ' ORDER BY rang ASC';

+		$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

+		$sql .= ' AND fk_parent_line = '.$id;

+		$sql .= ' ORDER BY rang ASC';

 

 		dol_syslog(get_class($this)."::getChildrenOfLine search children lines for line ".$id."", LOG_DEBUG);

 		$resql = $this->db->query($sql);

 		if ($resql)

 		{

-			$i=0;

+			$i = 0;

 			$num = $this->db->num_rows($resql);

 			while ($i < $num)

 			{

@@ -2308,7 +2308,7 @@ 
 	 * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not

 	 * 	@return	void

 	 */

-	function line_up($rowid, $fk_parent_line=true)

+	function line_up($rowid, $fk_parent_line = true)

 	{

         // phpcs:enable

 		$this->line_order(false, 'ASC', $fk_parent_line);

@@ -2328,7 +2328,7 @@ 
 	 * 	@param	boolean		$fk_parent_line		Table with fk_parent_line field or not

 	 * 	@return	void

 	 */

-	function line_down($rowid, $fk_parent_line=true)

+	function line_down($rowid, $fk_parent_line = true)

 	{

         // phpcs:enable

 		$this->line_order(false, 'ASC', $fk_parent_line);

@@ -2350,16 +2350,16 @@ 
 	 * 	@param	int		$rang		Position

 	 * 	@return	void

 	 */

-	function updateRangOfLine($rowid,$rang)

+	function updateRangOfLine($rowid, $rang)

 	{

 		$fieldposition = 'rang';

 		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

-		$sql.= ' WHERE rowid = '.$rowid;

+		$sql .= ' WHERE rowid = '.$rowid;

 

 		dol_syslog(get_class($this)."::updateRangOfLine", LOG_DEBUG);

-		if (! $this->db->query($sql))

+		if (!$this->db->query($sql))

 		{

 			dol_print_error($this->db);

 		}

@@ -2376,9 +2376,9 @@ 
 	{

         // phpcs:enable

 		$num = count($rows);

-		for ($i = 0 ; $i < $num ; $i++)

+		for ($i = 0; $i < $num; $i++)

 		{

-			$this->updateRangOfLine($rows[$i], ($i+1));

+			$this->updateRangOfLine($rows[$i], ($i + 1));

 		}

 	}

 

@@ -2389,21 +2389,21 @@ 
 	 * 	@param	int		$rang		Position

 	 * 	@return	void

 	 */

-	function updateLineUp($rowid,$rang)

+	function updateLineUp($rowid, $rang)

 	{

 		if ($rang > 1)

 		{

 			$fieldposition = 'rang';

 			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

 

-			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang ;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			$sql.= ' AND rang = '.($rang - 1);

-			if ($this->db->query($sql) )

+			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

+			$sql .= ' AND rang = '.($rang - 1);

+			if ($this->db->query($sql))

 			{

 				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang - 1);

-				$sql.= ' WHERE rowid = '.$rowid;

-				if (! $this->db->query($sql) )

+				$sql .= ' WHERE rowid = '.$rowid;

+				if (!$this->db->query($sql))

 				{

 					dol_print_error($this->db);

 				}

@@ -2423,7 +2423,7 @@ 
 	 * 	@param	int		$max		Max

 	 * 	@return	void

 	 */

-	function updateLineDown($rowid,$rang,$max)

+	function updateLineDown($rowid, $rang, $max)

 	{

 		if ($rang < $max)

 		{

@@ -2431,13 +2431,13 @@ 
 			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			$sql.= ' AND rang = '.($rang+1);

-			if ($this->db->query($sql) )

+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

+			$sql .= ' AND rang = '.($rang + 1);

+			if ($this->db->query($sql))

 			{

-				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang+1);

-				$sql.= ' WHERE rowid = '.$rowid;

-				if (! $this->db->query($sql) )

+				$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.($rang + 1);

+				$sql .= ' WHERE rowid = '.$rowid;

+				if (!$this->db->query($sql))

 				{

 					dol_print_error($this->db);

 				}

@@ -2458,7 +2458,7 @@ 
 	function getRangOfLine($rowid)

 	{

 		$sql = 'SELECT rang FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE rowid ='.$rowid;

+		$sql .= ' WHERE rowid ='.$rowid;

 

 		dol_syslog(get_class($this)."::getRangOfLine", LOG_DEBUG);

 		$resql = $this->db->query($sql);

@@ -2478,8 +2478,8 @@ 
 	function getIdOfLine($rang)

 	{

 		$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-		$sql.= ' AND rang = '.$rang;

+		$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

+		$sql .= ' AND rang = '.$rang;

 		$resql = $this->db->query($sql);

 		if ($resql)

 		{

@@ -2495,22 +2495,22 @@ 
 	 * 	@param		int		$fk_parent_line		Parent line id

 	 *  @return     int  			   			Max value of rang in table of lines

 	 */

-	function line_max($fk_parent_line=0)

+	function line_max($fk_parent_line = 0)

 	{

         // phpcs:enable

 		// Search the last rang with fk_parent_line

 		if ($fk_parent_line)

 		{

 			$sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			$sql.= ' AND fk_parent_line = '.$fk_parent_line;

+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

+			$sql .= ' AND fk_parent_line = '.$fk_parent_line;

 

 			dol_syslog(get_class($this)."::line_max", LOG_DEBUG);

 			$resql = $this->db->query($sql);

 			if ($resql)

 			{

 				$row = $this->db->fetch_row($resql);

-				if (! empty($row[0]))

+				if (!empty($row[0]))

 				{

 					return $row[0];

 				}

@@ -2524,7 +2524,7 @@ 
 		else

 		{

 			$sql = 'SELECT max(rang) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+			$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

 

 			dol_syslog(get_class($this)."::line_max", LOG_DEBUG);

 			$resql = $this->db->query($sql);

@@ -2546,15 +2546,15 @@ 
 	function update_ref_ext($ref_ext)

 	{

         // phpcs:enable

-		if (! $this->table_element)

+		if (!$this->table_element)

 		{

 			dol_syslog(get_class($this)."::update_ref_ext was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET ref_ext = '".$this->db->escape($ref_ext)."'";

-		$sql.= " WHERE ".(isset($this->table_rowid)?$this->table_rowid:'rowid')." = ". $this->id;

+		$sql .= " SET ref_ext = '".$this->db->escape($ref_ext)."'";

+		$sql .= " WHERE ".(isset($this->table_rowid) ? $this->table_rowid : 'rowid')." = ".$this->id;

 

 		dol_syslog(get_class($this)."::update_ref_ext", LOG_DEBUG);

 		if ($this->db->query($sql))

@@ -2564,7 +2564,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->error();

+			$this->error = $this->db->error();

 			return -1;

 		}

 	}

@@ -2577,31 +2577,31 @@ 
 	 *  @param		string		$suffix		'', '_public' or '_private'

 	 *  @return     int      		   		<0 if KO, >0 if OK

 	 */

-	function update_note($note, $suffix='')

+	function update_note($note, $suffix = '')

 	{

         // phpcs:enable

 		global $user;

 

-		if (! $this->table_element)

+		if (!$this->table_element)

 		{

-			$this->error='update_note was called on objet with property table_element not defined';

+			$this->error = 'update_note was called on objet with property table_element not defined';

 			dol_syslog(get_class($this)."::update_note was called on objet with property table_element not defined", LOG_ERR);

 			return -1;

 		}

-		if (! in_array($suffix,array('','_public','_private')))

+		if (!in_array($suffix, array('', '_public', '_private')))

 		{

-			$this->error='update_note Parameter suffix must be empty, \'_private\' or \'_public\'';

+			$this->error = 'update_note Parameter suffix must be empty, \'_private\' or \'_public\'';

 			dol_syslog(get_class($this)."::update_note Parameter suffix must be empty, '_private' or '_public'", LOG_ERR);

 			return -2;

 		}

 		// Special cas

 		//var_dump($this->table_element);exit;

-		if ($this->table_element == 'product') $suffix='';

+		if ($this->table_element == 'product') $suffix = '';

 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET note".$suffix." = ".(!empty($note)?("'".$this->db->escape($note)."'"):"NULL");

-		$sql.= " ,".(in_array($this->table_element, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))?"fk_user_mod":"fk_user_modif")." = ".$user->id;

-		$sql.= " WHERE rowid =". $this->id;

+		$sql .= " SET note".$suffix." = ".(!empty($note) ? ("'".$this->db->escape($note)."'") : "NULL");

+		$sql .= " ,".(in_array($this->table_element, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment')) ? "fk_user_mod" : "fk_user_modif")." = ".$user->id;

+		$sql .= " WHERE rowid =".$this->id;

 

 		dol_syslog(get_class($this)."::update_note", LOG_DEBUG);

 		if ($this->db->query($sql))

@@ -2610,14 +2610,14 @@ 
 			else if ($suffix == '_private') $this->note_private = $note;

 			else

 			{

-				$this->note = $note;      // deprecated

+				$this->note = $note; // deprecated

 				$this->note_private = $note;

 			}

 			return 1;

 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			return -1;

 		}

 	}

@@ -2634,7 +2634,7 @@ 
 	function update_note_public($note)

 	{

         // phpcs:enable

-		return $this->update_note($note,'_public');

+		return $this->update_note($note, '_public');

 	}

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -2648,7 +2648,7 @@ 
 	 *  @param	Societe	$seller				If roundingadjust is '0' or '1' or maybe 'auto', it means we recalculate total for lines before calculating total for object and for this, we need seller object.

 	 *	@return	int    			           	<0 if KO, >0 if OK

 	 */

-	function update_price($exclspec=0,$roundingadjust='none',$nodatabaseupdate=0,$seller=null)

+	function update_price($exclspec = 0, $roundingadjust = 'none', $nodatabaseupdate = 0, $seller = null)

 	{

         // phpcs:enable

 		global $conf, $hookmanager, $action;

@@ -2668,8 +2668,8 @@ 
 		elseif ($this->element == 'supplier_proposal')

 			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";

 

-		if (! empty($MODULE)) {

-			if (! empty($conf->global->$MODULE)) {

+		if (!empty($MODULE)) {

+			if (!empty($conf->global->$MODULE)) {

 				$modsactivated = explode(',', $conf->global->$MODULE);

 				foreach ($modsactivated as $mod) {

 					if ($conf->$mod->enabled)

@@ -2680,44 +2680,44 @@ 
 

 		include_once DOL_DOCUMENT_ROOT.'/core/lib/price.lib.php';

 

-		if ($roundingadjust == '-1') $roundingadjust='auto';	// For backward compatibility

+		if ($roundingadjust == '-1') $roundingadjust = 'auto'; // For backward compatibility

 

-		$forcedroundingmode=$roundingadjust;

-		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode=$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;

-		elseif ($forcedroundingmode == 'auto') $forcedroundingmode='0';

+		$forcedroundingmode = $roundingadjust;

+		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode = $conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;

+		elseif ($forcedroundingmode == 'auto') $forcedroundingmode = '0';

 

-		$error=0;

+		$error = 0;

 

 		$multicurrency_tx = !empty($this->multicurrency_tx) ? $this->multicurrency_tx : 1;

 

 		// Define constants to find lines to sum

-		$fieldtva='total_tva';

-		$fieldlocaltax1='total_localtax1';

-		$fieldlocaltax2='total_localtax2';

-		$fieldup='subprice';

+		$fieldtva = 'total_tva';

+		$fieldlocaltax1 = 'total_localtax1';

+		$fieldlocaltax2 = 'total_localtax2';

+		$fieldup = 'subprice';

 		if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier')

 		{

-			$fieldtva='tva';

-			$fieldup='pu_ht';

+			$fieldtva = 'tva';

+			$fieldup = 'pu_ht';

 		}

 		if ($this->element == 'expensereport')

 		{

-			$fieldup='value_unit';

+			$fieldup = 'value_unit';

 		}

 

 		$sql = 'SELECT rowid, qty, '.$fieldup.' as up, remise_percent, total_ht, '.$fieldtva.' as total_tva, total_ttc, '.$fieldlocaltax1.' as total_localtax1, '.$fieldlocaltax2.' as total_localtax2,';

-		$sql.= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';

-			if ($this->table_element_line == 'facturedet') $sql.= ', situation_percent';

-			$sql.= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';

-		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

+		$sql .= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';

+			if ($this->table_element_line == 'facturedet') $sql .= ', situation_percent';

+			$sql .= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';

+		$sql .= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;

+		$sql .= ' WHERE '.$this->fk_element.' = '.$this->id;

 		if ($exclspec)

 		{

-			$product_field='product_type';

-			if ($this->table_element_line == 'contratdet') $product_field='';    // contratdet table has no product_type field

-			if ($product_field) $sql.= ' AND '.$product_field.' <> 9';

+			$product_field = 'product_type';

+			if ($this->table_element_line == 'contratdet') $product_field = ''; // contratdet table has no product_type field

+			if ($product_field) $sql .= ' AND '.$product_field.' <> 9';

 		}

-		$sql.= ' ORDER by rowid';	// We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used

+		$sql .= ' ORDER by rowid'; // We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used

 

 		dol_syslog(get_class($this)."::update_price", LOG_DEBUG);

 		$resql = $this->db->query($sql);

@@ -2731,7 +2731,7 @@ 
 			$total_ht_by_vats  = array();

 			$total_tva_by_vats = array();

 			$total_ttc_by_vats = array();

-			$this->multicurrency_total_ht	= 0;

+			$this->multicurrency_total_ht = 0;

 			$this->multicurrency_total_tva	= 0;

 			$this->multicurrency_total_ttc	= 0;

 

@@ -2742,54 +2742,54 @@ 
 				$obj = $this->db->fetch_object($resql);

 

 				// Note: There is no check on detail line and no check on total, if $forcedroundingmode = 'none'

-				$parameters=array('fk_element' => $obj->rowid);

+				$parameters = array('fk_element' => $obj->rowid);

 				$reshook = $hookmanager->executeHooks('changeRoundingMode', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 

 				if (empty($reshook) && $forcedroundingmode == '0')	// Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

 				{

-					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);

-					$tmpcal=calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);

-					$diff=price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);

+					$localtax_array = array($obj->localtax1_type, $obj->localtax1_tx, $obj->localtax2_type, $obj->localtax2_tx);

+					$tmpcal = calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);

+					$diff = price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);

 					if ($diff)

 					{

-						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;

+						$sqlfix = "UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;

 						dol_syslog('We found unconsistent data into detailed line (difference of '.$diff.') for line rowid = '.$obj->rowid." (total vat of line calculated=".$tmpcal[1].", database=".$obj->total_tva."). We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

-								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+								$resqlfix = $this->db->query($sqlfix);

+								if (!$resqlfix) dol_print_error($this->db, 'Failed to update line');

 								$obj->total_tva = $tmpcal[1];

 								$obj->total_ttc = $tmpcal[2];

 						//

 					}

 				}

 

-				$this->total_ht        += $obj->total_ht;		// The field visible at end of line detail

+				$this->total_ht        += $obj->total_ht; // The field visible at end of line detail

 				$this->total_tva       += $obj->total_tva;

 				$this->total_localtax1 += $obj->total_localtax1;

 				$this->total_localtax2 += $obj->total_localtax2;

 				$this->total_ttc       += $obj->total_ttc;

-				$this->multicurrency_total_ht        += $obj->multicurrency_total_ht;		// The field visible at end of line detail

+				$this->multicurrency_total_ht        += $obj->multicurrency_total_ht; // The field visible at end of line detail

 				$this->multicurrency_total_tva       += $obj->multicurrency_total_tva;

 				$this->multicurrency_total_ttc       += $obj->multicurrency_total_ttc;

 

-				if (! isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate]=0;

-				if (! isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate]=0;

-				if (! isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate]=0;

+				if (!isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate] = 0;

+				if (!isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate] = 0;

+				if (!isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate] = 0;

 				$total_ht_by_vats[$obj->vatrate]  += $obj->total_ht;

 				$total_tva_by_vats[$obj->vatrate] += $obj->total_tva;

 				$total_ttc_by_vats[$obj->vatrate] += $obj->total_ttc;

 

 				if ($forcedroundingmode == '1')	// Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

 				{

-					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);

-					$diff=price2num($total_tva_by_vats[$obj->vatrate]-$tmpvat, 'MT', 1);

+					$tmpvat = price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);

+					$diff = price2num($total_tva_by_vats[$obj->vatrate] - $tmpvat, 'MT', 1);

 					//print 'Line '.$i.' rowid='.$obj->rowid.' vat_rate='.$obj->vatrate.' total_ht='.$obj->total_ht.' total_tva='.$obj->total_tva.' total_ttc='.$obj->total_ttc.' total_ht_by_vats='.$total_ht_by_vats[$obj->vatrate].' total_tva_by_vats='.$total_tva_by_vats[$obj->vatrate].' (new calculation = '.$tmpvat.') total_ttc_by_vats='.$total_ttc_by_vats[$obj->vatrate].($diff?" => DIFF":"")."<br>\n";

 					if ($diff)

 					{

 						if (abs($diff) > 0.1) { dol_syslog('A rounding difference was detected into TOTAL but is too high to be corrected', LOG_WARNING); exit; }

-						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;

+						$sqlfix = "UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;

 						dol_syslog('We found a difference of '.$diff.' for line rowid = '.$obj->rowid.". We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

-								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+								$resqlfix = $this->db->query($sqlfix);

+								if (!$resqlfix) dol_print_error($this->db, 'Failed to update line');

 								$this->total_tva -= $diff;

 								$this->total_ttc -= $diff;

 								$total_tva_by_vats[$obj->vatrate] -= $diff;

@@ -2801,11 +2801,11 @@ 
 			}

 

 			// Add revenue stamp to total

-			$this->total_ttc       			+= isset($this->revenuestamp)?$this->revenuestamp:0;

-			$this->multicurrency_total_ttc  += isset($this->revenuestamp)?($this->revenuestamp * $multicurrency_tx):0;

+			$this->total_ttc += isset($this->revenuestamp) ? $this->revenuestamp : 0;

+			$this->multicurrency_total_ttc += isset($this->revenuestamp) ? ($this->revenuestamp * $multicurrency_tx) : 0;

 

 			// Situations totals

-			if ($this->situation_cycle_ref && $this->situation_counter > 1 && method_exists($this, 'get_prev_sits') && $this->type != $this::TYPE_CREDIT_NOTE )

+			if ($this->situation_cycle_ref && $this->situation_counter > 1 && method_exists($this, 'get_prev_sits') && $this->type != $this::TYPE_CREDIT_NOTE)

 			{

 				$prev_sits = $this->get_prev_sits();

 

@@ -2824,17 +2824,17 @@ 
 			$this->db->free($resql);

 

 			// Now update global field total_ht, total_ttc and tva

-			$fieldht='total_ht';

-			$fieldtva='tva';

-			$fieldlocaltax1='localtax1';

-			$fieldlocaltax2='localtax2';

-			$fieldttc='total_ttc';

+			$fieldht = 'total_ht';

+			$fieldtva = 'tva';

+			$fieldlocaltax1 = 'localtax1';

+			$fieldlocaltax2 = 'localtax2';

+			$fieldttc = 'total_ttc';

 			// Specific code for backward compatibility with old field names

-			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht='total';

-			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva='total_tva';

-			if ($this->element == 'propal')                                                $fieldttc='total';

-			if ($this->element == 'expensereport')                                         $fieldtva='total_tva';

-			if ($this->element == 'supplier_proposal')                                     $fieldttc='total';

+			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht = 'total';

+			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva = 'total_tva';

+			if ($this->element == 'propal')                                                $fieldttc = 'total';

+			if ($this->element == 'expensereport')                                         $fieldtva = 'total_tva';

+			if ($this->element == 'supplier_proposal')                                     $fieldttc = 'total';

 

 			if (empty($nodatabaseupdate))

 			{

@@ -2851,16 +2851,16 @@ 
 

 

 				dol_syslog(get_class($this)."::update_price", LOG_DEBUG);

-				$resql=$this->db->query($sql);

-				if (! $resql)

+				$resql = $this->db->query($sql);

+				if (!$resql)

 				{

 					$error++;

-					$this->error=$this->db->lasterror();

-					$this->errors[]=$this->db->lasterror();

+					$this->error = $this->db->lasterror();

+					$this->errors[] = $this->db->lasterror();

 				}

 			}

 

-			if (! $error)

+			if (!$error)

 			{

 				return 1;

 			}

@@ -2871,7 +2871,7 @@ 
 		}

 		else

 		{

-			dol_print_error($this->db,'Bad request in update_price');

+			dol_print_error($this->db, 'Bad request in update_price');

 			return -1;

 		}

 	}

@@ -2885,30 +2885,30 @@ 
 	 *	@return		int					<=0 if KO, >0 if OK

 	 *	@see		fetchObjectLinked, updateObjectLinked, deleteObjectLinked

 	 */

-	function add_object_linked($origin=null, $origin_id=null)

+	function add_object_linked($origin = null, $origin_id = null)

 	{

         // phpcs:enable

-		$origin = (! empty($origin) ? $origin : $this->origin);

-		$origin_id = (! empty($origin_id) ? $origin_id : $this->origin_id);

+		$origin = (!empty($origin) ? $origin : $this->origin);

+		$origin_id = (!empty($origin_id) ? $origin_id : $this->origin_id);

 

 		// Special case

-		if ($origin == 'order') $origin='commande';

-		if ($origin == 'invoice') $origin='facture';

-		if ($origin == 'invoice_template') $origin='facturerec';

-    	if ($origin == 'supplierorder') $origin='order_supplier';

+		if ($origin == 'order') $origin = 'commande';

+		if ($origin == 'invoice') $origin = 'facture';

+		if ($origin == 'invoice_template') $origin = 'facturerec';

+    	if ($origin == 'supplierorder') $origin = 'order_supplier';

 		$this->db->begin();

 

 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";

-		$sql.= "fk_source";

-		$sql.= ", sourcetype";

-		$sql.= ", fk_target";

-		$sql.= ", targettype";

-		$sql.= ") VALUES (";

-		$sql.= $origin_id;

-		$sql.= ", '".$this->db->escape($origin)."'";

-		$sql.= ", ".$this->id;

-		$sql.= ", '".$this->db->escape($this->element)."'";

-		$sql.= ")";

+		$sql .= "fk_source";

+		$sql .= ", sourcetype";

+		$sql .= ", fk_target";

+		$sql .= ", targettype";

+		$sql .= ") VALUES (";

+		$sql .= $origin_id;

+		$sql .= ", '".$this->db->escape($origin)."'";

+		$sql .= ", ".$this->id;

+		$sql .= ", '".$this->db->escape($this->element)."'";

+		$sql .= ")";

 

 		dol_syslog(get_class($this)."::add_object_linked", LOG_DEBUG);

 		if ($this->db->query($sql))

@@ -2918,7 +2918,7 @@ 
 	  	}

 	  	else

 	  	{

-	  		$this->error=$this->db->lasterror();

+	  		$this->error = $this->db->lasterror();

 	  		$this->db->rollback();

 	  		return 0;

 	  	}

@@ -2946,33 +2946,33 @@ 
 	 *	@return int							<0 if KO, >0 if OK

 	 *  @see	add_object_linked, updateObjectLinked, deleteObjectLinked

 	 */

-	function fetchObjectLinked($sourceid=null,$sourcetype='',$targetid=null,$targettype='',$clause='OR',$alsosametype=1,$orderby='sourcetype',$loadalsoobjects=1)

+	function fetchObjectLinked($sourceid = null, $sourcetype = '', $targetid = null, $targettype = '', $clause = 'OR', $alsosametype = 1, $orderby = 'sourcetype', $loadalsoobjects = 1)

 	{

 		global $conf;

 

-		$this->linkedObjectsIds=array();

-		$this->linkedObjects=array();

+		$this->linkedObjectsIds = array();

+		$this->linkedObjects = array();

 

-		$justsource=false;

-		$justtarget=false;

-		$withtargettype=false;

-		$withsourcetype=false;

+		$justsource = false;

+		$justtarget = false;

+		$withtargettype = false;

+		$withsourcetype = false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid))

+		if (!empty($sourceid) && !empty($sourcetype) && empty($targetid))

 		{

-			$justsource=true;  // the source (id and type) is a search criteria

-			if (! empty($targettype)) $withtargettype=true;

+			$justsource = true; // the source (id and type) is a search criteria

+			if (!empty($targettype)) $withtargettype = true;

 		}

-		if (! empty($targetid) && ! empty($targettype) && empty($sourceid))

+		if (!empty($targetid) && !empty($targettype) && empty($sourceid))

 		{

-			$justtarget=true;  // the target (id and type) is a search criteria

-			if (! empty($sourcetype)) $withsourcetype=true;

+			$justtarget = true; // the target (id and type) is a search criteria

+			if (!empty($sourcetype)) $withsourcetype = true;

 		}

 

-		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

-		$targetid = (! empty($targetid) ? $targetid : $this->id);

-		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

-		$targettype = (! empty($targettype) ? $targettype : $this->element);

+		$sourceid = (!empty($sourceid) ? $sourceid : $this->id);

+		$targetid = (!empty($targetid) ? $targetid : $this->id);

+		$sourcetype = (!empty($sourcetype) ? $sourcetype : $this->element);

+		$targettype = (!empty($targettype) ? $targettype : $this->element);

 

 		/*if (empty($sourceid) && empty($targetid))

 		 {

@@ -2982,25 +2982,25 @@ 
 

 		// Links between objects are stored in table element_element

 		$sql = 'SELECT rowid, fk_source, sourcetype, fk_target, targettype';

-		$sql.= ' FROM '.MAIN_DB_PREFIX.'element_element';

-		$sql.= " WHERE ";

+		$sql .= ' FROM '.MAIN_DB_PREFIX.'element_element';

+		$sql .= " WHERE ";

 		if ($justsource || $justtarget)

 		{

 			if ($justsource)

 			{

-				$sql.= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";

-				if ($withtargettype) $sql.= " AND targettype = '".$targettype."'";

+				$sql .= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";

+				if ($withtargettype) $sql .= " AND targettype = '".$targettype."'";

 			}

 			else if ($justtarget)

 			{

-				$sql.= "fk_target = ".$targetid." AND targettype = '".$targettype."'";

-				if ($withsourcetype) $sql.= " AND sourcetype = '".$sourcetype."'";

+				$sql .= "fk_target = ".$targetid." AND targettype = '".$targettype."'";

+				if ($withsourcetype) $sql .= " AND sourcetype = '".$sourcetype."'";

 			}

 		}

 		else

 		{

-			$sql.= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";

-			$sql.= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";

+			$sql .= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";

+			$sql .= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";

 		}

 		$sql .= ' ORDER BY '.$orderby;

 

@@ -3017,36 +3017,36 @@ 
 				{

 					if ($justsource)

 					{

-						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

+						$this->linkedObjectsIds[$obj->targettype][$obj->rowid] = $obj->fk_target;

 					}

 					else if ($justtarget)

 					{

-						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

+						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid] = $obj->fk_source;

 					}

 				}

 				else

 				{

 					if ($obj->fk_source == $sourceid && $obj->sourcetype == $sourcetype)

 					{

-						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

+						$this->linkedObjectsIds[$obj->targettype][$obj->rowid] = $obj->fk_target;

 					}

 					if ($obj->fk_target == $targetid && $obj->targettype == $targettype)

 					{

-						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

+						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid] = $obj->fk_source;

 					}

 				}

 				$i++;

 			}

 

-			if (! empty($this->linkedObjectsIds))

+			if (!empty($this->linkedObjectsIds))

 			{

 				$tmparray = $this->linkedObjectsIds;

-				foreach($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

+				foreach ($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

 				{

 					// Parse element/subelement (ex: project_task, cabinetmed_consultation, ...)

 					$module = $element = $subelement = $objecttype;

 					if ($objecttype != 'supplier_proposal' && $objecttype != 'order_supplier' && $objecttype != 'invoice_supplier'

-						&& preg_match('/^([^_]+)_([^_]+)/i',$objecttype,$regs))

+						&& preg_match('/^([^_]+)_([^_]+)/i', $objecttype, $regs))

 					{

 						$module = $element = $regs[1];

 						$subelement = $regs[2];

@@ -3054,31 +3054,31 @@ 
 

 					$classpath = $element.'/class';

 					// To work with non standard classpath or module name

-					if ($objecttype == 'facture')			{

+					if ($objecttype == 'facture') {

 						$classpath = 'compta/facture/class';

 					}

-					else if ($objecttype == 'facturerec')			{

+					else if ($objecttype == 'facturerec') {

 						$classpath = 'compta/facture/class'; $module = 'facture';

 					}

-					else if ($objecttype == 'propal')			{

+					else if ($objecttype == 'propal') {

 						$classpath = 'comm/propal/class';

 					}

-					else if ($objecttype == 'supplier_proposal')			{

+					else if ($objecttype == 'supplier_proposal') {

 						$classpath = 'supplier_proposal/class';

 					}

-					else if ($objecttype == 'shipping')			{

+					else if ($objecttype == 'shipping') {

 						$classpath = 'expedition/class'; $subelement = 'expedition'; $module = 'expedition_bon';

 					}

-					else if ($objecttype == 'delivery')			{

+					else if ($objecttype == 'delivery') {

 						$classpath = 'livraison/class'; $subelement = 'livraison'; $module = 'livraison_bon';

 					}

-					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

+					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier') {

 						$classpath = 'fourn/class'; $module = 'fournisseur';

 					}

-					else if ($objecttype == 'fichinter')			{

+					else if ($objecttype == 'fichinter') {

 						$classpath = 'fichinter/class'; $subelement = 'fichinter'; $module = 'ficheinter';

 					}

-					else if ($objecttype == 'subscription')			{

+					else if ($objecttype == 'subscription') {

 						$classpath = 'adherents/class'; $module = 'adherent';

 					}

 

@@ -3091,16 +3091,16 @@ 
 					else if ($objecttype == 'invoice_supplier') {

 						$classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';

 					}

-					else if ($objecttype == 'order_supplier')   {

+					else if ($objecttype == 'order_supplier') {

 						$classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';

 					}

-					else if ($objecttype == 'supplier_proposal')   {

+					else if ($objecttype == 'supplier_proposal') {

 						$classfile = 'supplier_proposal'; $classname = 'SupplierProposal';

 					}

-					else if ($objecttype == 'facturerec')   {

+					else if ($objecttype == 'facturerec') {

 						$classfile = 'facture-rec'; $classname = 'FactureRec';

 					}

-					else if ($objecttype == 'subscription')   {

+					else if ($objecttype == 'subscription') {

 						$classfile = 'subscription'; $classname = 'Subscription';

 					}

 

@@ -3113,7 +3113,7 @@ 
 							//print '/'.$classpath.'/'.$classfile.'.class.php '.class_exists($classname);

 							if (class_exists($classname))

 							{

-								foreach($objectids as $i => $objectid)	// $i is rowid into llx_element_element

+								foreach ($objectids as $i => $objectid)	// $i is rowid into llx_element_element

 								{

 									$object = new $classname($this->db);

 									$ret = $object->fetch($objectid);

@@ -3150,28 +3150,28 @@ 
 	 *	@return							int	>0 if OK, <0 if KO

 	 *	@see	add_object_linked, fetObjectLinked, deleteObjectLinked

 	 */

-	function updateObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='')

+	function updateObjectLinked($sourceid = null, $sourcetype = '', $targetid = null, $targettype = '')

 	{

-		$updatesource=false;

-		$updatetarget=false;

+		$updatesource = false;

+		$updatetarget = false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $updatetarget=true;

+		if (!empty($sourceid) && !empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource = true;

+		else if (empty($sourceid) && empty($sourcetype) && !empty($targetid) && !empty($targettype)) $updatetarget = true;

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_element SET ";

 		if ($updatesource)

 		{

-			$sql.= "fk_source = ".$sourceid;

-			$sql.= ", sourcetype = '".$this->db->escape($sourcetype)."'";

-			$sql.= " WHERE fk_target = ".$this->id;

-			$sql.= " AND targettype = '".$this->db->escape($this->element)."'";

+			$sql .= "fk_source = ".$sourceid;

+			$sql .= ", sourcetype = '".$this->db->escape($sourcetype)."'";

+			$sql .= " WHERE fk_target = ".$this->id;

+			$sql .= " AND targettype = '".$this->db->escape($this->element)."'";

 		}

 		else if ($updatetarget)

 		{

-			$sql.= "fk_target = ".$targetid;

-			$sql.= ", targettype = '".$this->db->escape($targettype)."'";

-			$sql.= " WHERE fk_source = ".$this->id;

-			$sql.= " AND sourcetype = '".$this->db->escape($this->element)."'";

+			$sql .= "fk_target = ".$targetid;

+			$sql .= ", targettype = '".$this->db->escape($targettype)."'";

+			$sql .= " WHERE fk_source = ".$this->id;

+			$sql .= " AND sourcetype = '".$this->db->escape($this->element)."'";

 		}

 

 		dol_syslog(get_class($this)."::updateObjectLinked", LOG_DEBUG);

@@ -3181,7 +3181,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			return -1;

 		}

 	}

@@ -3197,42 +3197,42 @@ 
 	 *	@return     					int	>0 if OK, <0 if KO

 	 *	@see	add_object_linked, updateObjectLinked, fetchObjectLinked

 	 */

-	function deleteObjectLinked($sourceid=null, $sourcetype='', $targetid=null, $targettype='', $rowid='')

+	function deleteObjectLinked($sourceid = null, $sourcetype = '', $targetid = null, $targettype = '', $rowid = '')

 	{

-		$deletesource=false;

-		$deletetarget=false;

+		$deletesource = false;

+		$deletetarget = false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $deletetarget=true;

+		if (!empty($sourceid) && !empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource = true;

+		else if (empty($sourceid) && empty($sourcetype) && !empty($targetid) && !empty($targettype)) $deletetarget = true;

 

-		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

-		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

-		$targetid = (! empty($targetid) ? $targetid : $this->id);

-		$targettype = (! empty($targettype) ? $targettype : $this->element);

+		$sourceid = (!empty($sourceid) ? $sourceid : $this->id);

+		$sourcetype = (!empty($sourcetype) ? $sourcetype : $this->element);

+		$targetid = (!empty($targetid) ? $targetid : $this->id);

+		$targettype = (!empty($targettype) ? $targettype : $this->element);

 

 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_element";

-		$sql.= " WHERE";

+		$sql .= " WHERE";

 		if ($rowid > 0)

 		{

-			$sql.=" rowid = ".$rowid;

+			$sql .= " rowid = ".$rowid;

 		}

 		else

 		{

 			if ($deletesource)

 			{

-				$sql.= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";

-				$sql.= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";

+				$sql .= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";

+				$sql .= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";

 			}

 			else if ($deletetarget)

 			{

-				$sql.= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";

-				$sql.= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";

+				$sql .= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";

+				$sql .= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";

 			}

 			else

 			{

-				$sql.= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";

-				$sql.= " OR";

-				$sql.= " (fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."')";

+				$sql .= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";

+				$sql .= " OR";

+				$sql .= " (fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."')";

 			}

 		}

 

@@ -3243,8 +3243,8 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

-			$this->errors[]=$this->error;

+			$this->error = $this->db->lasterror();

+			$this->errors[] = $this->error;

 			return -1;

 		}

 	}

@@ -3258,30 +3258,30 @@ 
 	 *      @param	string	$trigkey		Trigger key to use for trigger

 	 *      @return int						<0 if KO, >0 if OK

 	 */

-	function setStatut($status, $elementId=null, $elementType='', $trigkey='')

+	function setStatut($status, $elementId = null, $elementType = '', $trigkey = '')

 	{

-		global $user,$langs,$conf;

+		global $user, $langs, $conf;

 

-		$savElementId=$elementId;  // To be used later to know if we were using the method using the id of this or not.

+		$savElementId = $elementId; // To be used later to know if we were using the method using the id of this or not.

 

-		$elementId = (!empty($elementId)?$elementId:$this->id);

-		$elementTable = (!empty($elementType)?$elementType:$this->table_element);

+		$elementId = (!empty($elementId) ? $elementId : $this->id);

+		$elementTable = (!empty($elementType) ? $elementType : $this->table_element);

 

 		$this->db->begin();

 

-		$fieldstatus="fk_statut";

-		if ($elementTable == 'facture_rec') $fieldstatus="suspended";

-		if ($elementTable == 'mailing') $fieldstatus="statut";

-		if ($elementTable == 'cronjob') $fieldstatus="status";

-		if ($elementTable == 'user') $fieldstatus="statut";

-		if ($elementTable == 'expensereport') $fieldstatus="fk_statut";

-		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus="status";

+		$fieldstatus = "fk_statut";

+		if ($elementTable == 'facture_rec') $fieldstatus = "suspended";

+		if ($elementTable == 'mailing') $fieldstatus = "statut";

+		if ($elementTable == 'cronjob') $fieldstatus = "status";

+		if ($elementTable == 'user') $fieldstatus = "statut";

+		if ($elementTable == 'expensereport') $fieldstatus = "fk_statut";

+		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus = "status";

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$elementTable;

-		$sql.= " SET ".$fieldstatus." = ".$status;

+		$sql .= " SET ".$fieldstatus." = ".$status;

 		// If status = 1 = validated, update also fk_user_valid

-		if ($status == 1 && $elementTable == 'expensereport') $sql.=", fk_user_valid = ".$user->id;

-		$sql.= " WHERE rowid=".$elementId;

+		if ($status == 1 && $elementTable == 'expensereport') $sql .= ", fk_user_valid = ".$user->id;

+		$sql .= " WHERE rowid=".$elementId;

 

 		dol_syslog(get_class($this)."::setStatut", LOG_DEBUG);

 		if ($this->db->query($sql))

@@ -3291,27 +3291,27 @@ 
 			// Try autoset of trigkey

 			if (empty($trigkey))

 			{

-				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey='SUPPLIER_PROPOSAL_SIGN';   // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey='SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey='SUPPLIER_PROPOSAL_CLOSE';  // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

-				if ($this->element == 'fichinter' && $status == 3) $trigkey='FICHINTER_CLASSIFY_DONE';

-				if ($this->element == 'fichinter' && $status == 2) $trigkey='FICHINTER_CLASSIFY_BILLED';

-				if ($this->element == 'fichinter' && $status == 1) $trigkey='FICHINTER_CLASSIFY_UNBILLED';

+				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey = 'SUPPLIER_PROPOSAL_SIGN'; // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

+				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey = 'SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

+				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey = 'SUPPLIER_PROPOSAL_CLOSE'; // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

+				if ($this->element == 'fichinter' && $status == 3) $trigkey = 'FICHINTER_CLASSIFY_DONE';

+				if ($this->element == 'fichinter' && $status == 2) $trigkey = 'FICHINTER_CLASSIFY_BILLED';

+				if ($this->element == 'fichinter' && $status == 1) $trigkey = 'FICHINTER_CLASSIFY_UNBILLED';

 			}

 

 			if ($trigkey)

 			{

 				// Appel des triggers

-				include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';

-				$interface=new Interfaces($this->db);

-				$result=$interface->run_triggers($trigkey,$this,$user,$langs,$conf);

+				include_once DOL_DOCUMENT_ROOT.'/core/class/interfaces.class.php';

+				$interface = new Interfaces($this->db);

+				$result = $interface->run_triggers($trigkey, $this, $user, $langs, $conf);

 				if ($result < 0) {

-					$error++; $this->errors=$interface->errors;

+					$error++; $this->errors = $interface->errors;

 				}

 				// Fin appel triggers

 			}

 

-			if (! $error)

+			if (!$error)

 			{

 				$this->db->commit();

 

@@ -3326,13 +3326,13 @@ 
 			else

 			{

 				$this->db->rollback();

-				dol_syslog(get_class($this)."::setStatus ".$this->error,LOG_ERR);

+				dol_syslog(get_class($this)."::setStatus ".$this->error, LOG_ERR);

 				return -1;

 			}

 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return -1;

 		}

@@ -3346,21 +3346,21 @@ 
 	 *  @param      string	$ref    Record ref

 	 *  @return		int				<0 if KO, 0 if nothing done, >0 if OK

 	 */

-	function getCanvas($id=0,$ref='')

+	function getCanvas($id = 0, $ref = '')

 	{

 		global $conf;

 

 		if (empty($id) && empty($ref)) return 0;

-		if (! empty($conf->global->MAIN_DISABLE_CANVAS)) return 0;    // To increase speed. Not enabled by default.

+		if (!empty($conf->global->MAIN_DISABLE_CANVAS)) return 0; // To increase speed. Not enabled by default.

 

 		// Clean parameters

 		$ref = trim($ref);

 

 		$sql = "SELECT rowid, canvas";

-		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " WHERE entity IN (".getEntity($this->element).")";

-		if (! empty($id))  $sql.= " AND rowid = ".$id;

-		if (! empty($ref)) $sql.= " AND ref = '".$this->db->escape($ref)."'";

+		$sql .= " FROM ".MAIN_DB_PREFIX.$this->table_element;

+		$sql .= " WHERE entity IN (".getEntity($this->element).")";

+		if (!empty($id))  $sql .= " AND rowid = ".$id;

+		if (!empty($ref)) $sql .= " AND ref = '".$this->db->escape($ref)."'";

 

 		$resql = $this->db->query($sql);

 		if ($resql)

@@ -3368,7 +3368,7 @@ 
 			$obj = $this->db->fetch_object($resql);

 			if ($obj)

 			{

-				$this->canvas   = $obj->canvas;

+				$this->canvas = $obj->canvas;

 				return 1;

 			}

 			else return 0;

@@ -3390,7 +3390,7 @@ 
 	function getSpecialCode($lineid)

 	{

 		$sql = 'SELECT special_code FROM '.MAIN_DB_PREFIX.$this->table_element_line;

-		$sql.= ' WHERE rowid = '.$lineid;

+		$sql .= ' WHERE rowid = '.$lineid;

 		$resql = $this->db->query($sql);

 		if ($resql)

 		{

@@ -3406,14 +3406,14 @@ 
 	 *  @param	int		$id			Force id of object

 	 *  @return	int					<0 if KO, 0 if not used, >0 if already used

 	 */

-	function isObjectUsed($id=0)

+	function isObjectUsed($id = 0)

 	{

 		global $langs;

 

-		if (empty($id)) $id=$this->id;

+		if (empty($id)) $id = $this->id;

 

 		// Check parameters

-		if (! isset($this->childtables) || ! is_array($this->childtables) || count($this->childtables) == 0)

+		if (!isset($this->childtables) || !is_array($this->childtables) || count($this->childtables) == 0)

 		{

 			dol_print_error('Called isObjectUsed on a class with property this->childtables not defined');

 			return -1;

@@ -3421,24 +3421,24 @@ 
 

 		$arraytoscan = $this->childtables;

 		// For backward compatibility, we check if array is old format array('table1', 'table2', ...)

-		$tmparray=array_keys($this->childtables);

+		$tmparray = array_keys($this->childtables);

 		if (is_numeric($tmparray[0]))

 		{

 			$arraytoscan = array_flip($this->childtables);

 		}

 

 		// Test if child exists

-		$haschild=0;

-		foreach($arraytoscan as $table => $elementname)

+		$haschild = 0;

+		foreach ($arraytoscan as $table => $elementname)

 		{

 			//print $id.'-'.$table.'-'.$elementname.'<br>';

 			// Check if third party can be deleted

 			$sql = "SELECT COUNT(*) as nb from ".MAIN_DB_PREFIX.$table;

-			$sql.= " WHERE ".$this->fk_element." = ".$id;

-			$resql=$this->db->query($sql);

+			$sql .= " WHERE ".$this->fk_element." = ".$id;

+			$resql = $this->db->query($sql);

 			if ($resql)

 			{

-				$obj=$this->db->fetch_object($resql);

+				$obj = $this->db->fetch_object($resql);

 				if ($obj->nb > 0)

 				{

 					$langs->load("errors");

@@ -3446,24 +3446,24 @@ 
 					$haschild += $obj->nb;

 					if (is_numeric($elementname))	// old usage

 					{

-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);

+						$this->errors[] = $langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);

 					}

 					else	// new usage: $elementname=Translation key

 					{

-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));

+						$this->errors[] = $langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));

 					}

-					break;    // We found at least one, we stop here

+					break; // We found at least one, we stop here

 				}

 			}

 			else

 			{

-				$this->errors[]=$this->db->lasterror();

+				$this->errors[] = $this->db->lasterror();

 				return -1;

 			}

 		}

 		if ($haschild > 0)

 		{

-			$this->errors[]="ErrorRecordHasChildren";

+			$this->errors[] = "ErrorRecordHasChildren";

 			return $haschild;

 		}

 		else return 0;

@@ -3475,18 +3475,18 @@ 
 	 *	@param	int		$predefined		-1=All, 0=Count free product/service only, 1=Count predefined product/service only, 2=Count predefined product, 3=Count predefined service

 	 *  @return	int						<0 if KO, 0 if no predefined products, nb of lines with predefined products if found

 	 */

-	function hasProductsOrServices($predefined=-1)

+	function hasProductsOrServices($predefined = -1)

 	{

-		$nb=0;

+		$nb = 0;

 

-		foreach($this->lines as $key => $val)

+		foreach ($this->lines as $key => $val)

 		{

-			$qualified=0;

-			if ($predefined == -1) $qualified=1;

-			if ($predefined == 1 && $val->fk_product > 0) $qualified=1;

-			if ($predefined == 0 && $val->fk_product <= 0) $qualified=1;

-			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) $qualified=1;

-			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) $qualified=1;

+			$qualified = 0;

+			if ($predefined == -1) $qualified = 1;

+			if ($predefined == 1 && $val->fk_product > 0) $qualified = 1;

+			if ($predefined == 0 && $val->fk_product <= 0) $qualified = 1;

+			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type == 0) $qualified = 1;

+			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type == 1) $qualified = 1;

 			if ($qualified) $nb++;

 		}

 		dol_syslog(get_class($this).'::hasProductsOrServices we found '.$nb.' qualified lines of products/servcies');

@@ -3500,24 +3500,24 @@ 
 	 */

 	function getTotalDiscount()

 	{

-		$total_discount=0.00;

+		$total_discount = 0.00;

 

 		$sql = "SELECT subprice as pu_ht, qty, remise_percent, total_ht";

-		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element."det";

-		$sql.= " WHERE ".$this->fk_element." = ".$this->id;

+		$sql .= " FROM ".MAIN_DB_PREFIX.$this->table_element."det";

+		$sql .= " WHERE ".$this->fk_element." = ".$this->id;

 

 		dol_syslog(get_class($this).'::getTotalDiscount', LOG_DEBUG);

 		$resql = $this->db->query($sql);

 		if ($resql)

 		{

-			$num=$this->db->num_rows($resql);

-			$i=0;

+			$num = $this->db->num_rows($resql);

+			$i = 0;

 			while ($i < $num)

 			{

 				$obj = $this->db->fetch_object($resql);

 

 				$pu_ht = $obj->pu_ht;

-				$qty= $obj->qty;

+				$qty = $obj->qty;

 				$total_ht = $obj->total_ht;

 

 				$total_discount_line = floatval(price2num(($pu_ht * $qty) - $total_ht, 'MT'));

@@ -3551,17 +3551,17 @@ 
 		{

 			if (isset($line->qty_asked))

 			{

-				if (empty($totalOrdered)) $totalOrdered=0;  // Avoid warning because $totalOrdered is ''

-				$totalOrdered+=$line->qty_asked;    // defined for shipment only

+				if (empty($totalOrdered)) $totalOrdered = 0; // Avoid warning because $totalOrdered is ''

+				$totalOrdered += $line->qty_asked; // defined for shipment only

 			}

 			if (isset($line->qty_shipped))

 			{

-				if (empty($totalToShip)) $totalToShip=0;    // Avoid warning because $totalToShip is ''

-				$totalToShip+=$line->qty_shipped;   // defined for shipment only

-            }else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

+				if (empty($totalToShip)) $totalToShip = 0; // Avoid warning because $totalToShip is ''

+				$totalToShip += $line->qty_shipped; // defined for shipment only

+            } else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

             {

-                if (empty($totalToShip)) $totalToShip=0;

-                $totalToShip+=$line->qty;   // defined for reception only

+                if (empty($totalToShip)) $totalToShip = 0;

+                $totalToShip += $line->qty; // defined for reception only

 			}

 

 			// Define qty, weight, volume, weight_units, volume_units

@@ -3574,27 +3574,27 @@ 
 			}

 

 			$weight = $line->weight ? $line->weight : 0;

-            ($weight==0 && !empty($line->product->weight))? $weight=$line->product->weight: 0;

+            ($weight == 0 && !empty($line->product->weight)) ? $weight = $line->product->weight : 0;

 			$volume = $line->volume ? $line->volume : 0;

-			($volume==0 && !empty($line->product->volume))? $volume=$line->product->volume: 0;

+			($volume == 0 && !empty($line->product->volume)) ? $volume = $line->product->volume : 0;

 

-			$weight_units=$line->weight_units;

-			($weight_units==0 && !empty($line->product->weight_units))? $weight_units=$line->product->weight_units: 0;

-			$volume_units=$line->volume_units;

-			($volume_units==0 && !empty($line->product->volume_units))? $volume_units=$line->product->volume_units: 0;

+			$weight_units = $line->weight_units;

+			($weight_units == 0 && !empty($line->product->weight_units)) ? $weight_units = $line->product->weight_units : 0;

+			$volume_units = $line->volume_units;

+			($volume_units == 0 && !empty($line->product->volume_units)) ? $volume_units = $line->product->volume_units : 0;

 

-			$weightUnit=0;

-			$volumeUnit=0;

-			if (! empty($weight_units)) $weightUnit = $weight_units;

-			if (! empty($volume_units)) $volumeUnit = $volume_units;

+			$weightUnit = 0;

+			$volumeUnit = 0;

+			if (!empty($weight_units)) $weightUnit = $weight_units;

+			if (!empty($volume_units)) $volumeUnit = $volume_units;

 

-			if (empty($totalWeight)) $totalWeight=0;  // Avoid warning because $totalWeight is ''

-			if (empty($totalVolume)) $totalVolume=0;  // Avoid warning because $totalVolume is ''

+			if (empty($totalWeight)) $totalWeight = 0; // Avoid warning because $totalWeight is ''

+			if (empty($totalVolume)) $totalVolume = 0; // Avoid warning because $totalVolume is ''

 

 			//var_dump($line->volume_units);

 			if ($weight_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

 			{

-				$trueWeightUnit=pow(10, $weightUnit);

+				$trueWeightUnit = pow(10, $weightUnit);

 				$totalWeight += $weight * $qty * $trueWeightUnit;

 			}

 			else {

@@ -3608,18 +3608,18 @@ 
 			$totalWeight += $weight * $qty * $trueWeightUnit;

 		}

 		else

-					$totalWeight += $weight * $qty;   // This may be wrong if we mix different units

+					$totalWeight += $weight * $qty; // This may be wrong if we mix different units

 			}

 			if ($volume_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

 			{

 				//print $line->volume."x".$line->volume_units."x".($line->volume_units < 50)."x".$volumeUnit;

-				$trueVolumeUnit=pow(10, $volumeUnit);

+				$trueVolumeUnit = pow(10, $volumeUnit);

 				//print $line->volume;

 				$totalVolume += $volume * $qty * $trueVolumeUnit;

 			}

 			else

 			{

-				$totalVolume += $volume * $qty;   // This may be wrong if we mix different units

+				$totalVolume += $volume * $qty; // This may be wrong if we mix different units

 			}

 		}

 

@@ -3636,17 +3636,17 @@ 
 	{

 		$this->db->begin();

 

-		$extraparams = (! empty($this->extraparams) ? json_encode($this->extraparams) : null);

+		$extraparams = (!empty($this->extraparams) ? json_encode($this->extraparams) : null);

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-		$sql.= " SET extraparams = ".(! empty($extraparams) ? "'".$this->db->escape($extraparams)."'" : "null");

-		$sql.= " WHERE rowid = ".$this->id;

+		$sql .= " SET extraparams = ".(!empty($extraparams) ? "'".$this->db->escape($extraparams)."'" : "null");

+		$sql .= " WHERE rowid = ".$this->id;

 

 		dol_syslog(get_class($this)."::setExtraParameters", LOG_DEBUG);

 		$resql = $this->db->query($sql);

-		if (! $resql)

+		if (!$resql)

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return -1;

 		}

@@ -3681,7 +3681,7 @@ 
 			}

 		}

 

-		$out .= (($res->code && $this->location_incoterms)?' - ':'').$this->location_incoterms;

+		$out .= (($res->code && $this->location_incoterms) ? ' - ' : '').$this->location_incoterms;

 

 		return $out;

 	}

@@ -3727,11 +3727,11 @@ 
 		if ($this->id && $this->table_element)

 		{

 			$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

-			$sql.= " SET fk_incoterms = ".($id_incoterm > 0 ? $id_incoterm : "null");

-			$sql.= ", location_incoterms = ".($id_incoterm > 0 ? "'".$this->db->escape($location)."'" : "null");

-			$sql.= " WHERE rowid = " . $this->id;

+			$sql .= " SET fk_incoterms = ".($id_incoterm > 0 ? $id_incoterm : "null");

+			$sql .= ", location_incoterms = ".($id_incoterm > 0 ? "'".$this->db->escape($location)."'" : "null");

+			$sql .= " WHERE rowid = ".$this->id;

 			dol_syslog(get_class($this).'::setIncoterms', LOG_DEBUG);

-			$resql=$this->db->query($sql);

+			$resql = $this->db->query($sql);

 			if ($resql)

 			{

 				$this->fk_incoterms = $id_incoterm;

@@ -3772,24 +3772,24 @@ 
 	 */

 	function formAddObjectLine($dateSelector, $seller, $buyer)

 	{

-		global $conf,$user,$langs,$object,$hookmanager;

-		global $form,$bcnd,$var;

+		global $conf, $user, $langs, $object, $hookmanager;

+		global $form, $bcnd, $var;

 

 		// Line extrafield

 		require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

 		$extrafieldsline = new ExtraFields($this->db);

-		$extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);

+		$extralabelslines = $extrafieldsline->fetch_name_optionals_label($this->table_element_line);

 

 		// Output template part (modules that overwrite templates must declare this into descriptor)

 		// Use global variables + $dateSelector + $seller and $buyer

-		$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-		foreach($dirtpls as $reldir)

+		$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));

+		foreach ($dirtpls as $reldir)

 		{

 			$tpl = dol_buildpath($reldir.'/objectline_create.tpl.php');

 			if (empty($conf->file->strict_mode)) {

-				$res=@include $tpl;

+				$res = @include $tpl;

 			} else {

-				$res=include $tpl; // for debug

+				$res = include $tpl; // for debug

 			}

 			if ($res) break;

 		}

@@ -3813,24 +3813,24 @@ 
 	 *	@param  int	    	$dateSelector      	1=Show also date range input fields

 	 *	@return	void

 	 */

-	function printObjectLines($action, $seller, $buyer, $selected=0, $dateSelector=0)

+	function printObjectLines($action, $seller, $buyer, $selected = 0, $dateSelector = 0)

 	{

 		global $conf, $hookmanager, $langs, $user;

 		// TODO We should not use global var for this !

 		global $inputalsopricewithtax, $usemargins, $disableedit, $disablemove, $disableremove, $outputalsopricetotalwithtax;

 

 		// Define usemargins

-		$usemargins=0;

-		if (! empty($conf->margin->enabled) && ! empty($this->element) && in_array($this->element,array('facture','propal','commande'))) $usemargins=1;

+		$usemargins = 0;

+		if (!empty($conf->margin->enabled) && !empty($this->element) && in_array($this->element, array('facture', 'propal', 'commande'))) $usemargins = 1;

 

 		$num = count($this->lines);

 

 		// Line extrafield

 		require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

 		$extrafieldsline = new ExtraFields($this->db);

-		$extralabelslines=$extrafieldsline->fetch_name_optionals_label($this->table_element_line);

+		$extralabelslines = $extrafieldsline->fetch_name_optionals_label($this->table_element_line);

 

-		$parameters = array('num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

+		$parameters = array('num'=>$num, 'i'=>$i, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

 		$reshook = $hookmanager->executeHooks('printObjectLineTitle', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 		if (empty($reshook))

 		{

@@ -3840,7 +3840,7 @@ 
 			print '<tr class="liste_titre nodrag nodrop">';

 

 			// Adds a line numbering column

-			if (! empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';

+			if (!empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';

 

 			// Description

 			print '<td class="linecoldescription">'.$langs->trans('Description').'</td>';

@@ -3864,7 +3864,7 @@ 
 			// Qty

 			print '<td class="linecolqty" align="right">'.$langs->trans('Qty').'</td>';

 

-			if($conf->global->PRODUCT_USE_UNITS)

+			if ($conf->global->PRODUCT_USE_UNITS)

 			{

 				print '<td class="linecoluseunit" align="left">'.$langs->trans('Unit').'</td>';

 			}

@@ -3873,10 +3873,10 @@ 
 			print '<td class="linecoldiscount" align="right">'.$langs->trans('ReductionShort').'</td>';

 

 			if ($this->situation_cycle_ref) {

-				print '<td class="linecolcycleref" align="right">' . $langs->trans('Progress') . '</td>';

+				print '<td class="linecolcycleref" align="right">'.$langs->trans('Progress').'</td>';

 			}

 

-			if ($usemargins && ! empty($conf->margin->enabled) && empty($user->societe_id))

+			if ($usemargins && !empty($conf->margin->enabled) && empty($user->societe_id))

 			{

 				if (!empty($user->rights->margins->creer))

 				{

@@ -3886,9 +3886,9 @@ 
 						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';

 				}

 

-				if (! empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)

+				if (!empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)

 					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';

-				if (! empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)

+				if (!empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)

 					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';

 			}

 

@@ -3900,13 +3900,13 @@ 
 

 			if ($outputalsopricetotalwithtax) print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';

 

-			print '<td class="linecoledit"></td>';  // No width to allow autodim

+			print '<td class="linecoledit"></td>'; // No width to allow autodim

 

 			print '<td class="linecoldelete" width="10"></td>';

 

 			print '<td class="linecolmove" width="10"></td>';

 

-			if($action == 'selectlines')

+			if ($action == 'selectlines')

 			{

 			    print '<td class="linecolcheckall" align="center">';

 			    print '<input type="checkbox" class="linecheckboxtoggle" />';

@@ -3919,7 +3919,7 @@ 
 		}

 

 		$var = true;

-		$i	 = 0;

+		$i = 0;

 

 		print "<tbody>\n";

 		foreach ($this->lines as $line)

@@ -3932,18 +3932,18 @@ 
 			{

 				if (empty($line->fk_parent_line))

 				{

-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

-					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

+					$parameters = array('line'=>$line, 'var'=>$var, 'num'=>$num, 'i'=>$i, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

+					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 				}

 				else

 				{

-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);

-					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

+					$parameters = array('line'=>$line, 'var'=>$var, 'num'=>$num, 'i'=>$i, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);

+					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 				}

 			}

 			if (empty($reshook))

 			{

-				$this->printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected,$extrafieldsline);

+				$this->printObjectLine($action, $line, $var, $num, $i, $dateSelector, $seller, $buyer, $selected, $extrafieldsline);

 			}

 

 			$i++;

@@ -3967,23 +3967,23 @@ 
 	 *  @param  int			$extrafieldsline	Object of extrafield line attribute

 	 *	@return	void

 	 */

-	function printObjectLine($action,$line,$var,$num,$i,$dateSelector,$seller,$buyer,$selected=0,$extrafieldsline=0)

+	function printObjectLine($action, $line, $var, $num, $i, $dateSelector, $seller, $buyer, $selected = 0, $extrafieldsline = 0)

 	{

-		global $conf,$langs,$user,$object,$hookmanager;

-		global $form,$bc,$bcdd;

-		global $object_rights, $disableedit, $disablemove, $disableremove;   // TODO We should not use global var for this !

+		global $conf, $langs, $user, $object, $hookmanager;

+		global $form, $bc, $bcdd;

+		global $object_rights, $disableedit, $disablemove, $disableremove; // TODO We should not use global var for this !

 

 		$object_rights = $this->getRights();

 

-		$element=$this->element;

+		$element = $this->element;

 

-		$text=''; $description=''; $type=0;

+		$text = ''; $description = ''; $type = 0;

 

 		// Show product and description

-		$type=(! empty($line->product_type)?$line->product_type:$line->fk_product_type);

+		$type = (!empty($line->product_type) ? $line->product_type : $line->fk_product_type);

 		// Try to enhance type detection using date_start and date_end for free lines where type was not saved.

-		if (! empty($line->date_start)) $type=1; // deprecated

-		if (! empty($line->date_end)) $type=1; // deprecated

+		if (!empty($line->date_start)) $type = 1; // deprecated

+		if (!empty($line->date_end)) $type = 1; // deprecated

 

 		// Ligne en mode visu

 		if ($action != 'editline' || $selected != $line->id)

@@ -3996,14 +3996,14 @@ 
 

 				$product_static->ref = $line->ref; //can change ref in hook

 				$product_static->label = $line->label; //can change label in hook

-				$text=$product_static->getNomUrl(1);

+				$text = $product_static->getNomUrl(1);

 

 				// Define output language and label

-				if (! empty($conf->global->MAIN_MULTILANGS))

+				if (!empty($conf->global->MAIN_MULTILANGS))

 				{

-					if (! is_object($this->thirdparty))

+					if (!is_object($this->thirdparty))

 					{

-						dol_print_error('','Error: Method printObjectLine was called on an object and object->fetch_thirdparty was not done before');

+						dol_print_error('', 'Error: Method printObjectLine was called on an object and object->fetch_thirdparty was not done before');

 						return;

 					}

 

@@ -4011,38 +4011,38 @@ 
 					$prod->fetch($line->fk_product);

 

 					$outputlangs = $langs;

-					$newlang='';

-					if (empty($newlang) && GETPOST('lang_id','aZ09')) $newlang=GETPOST('lang_id','aZ09');

-					if (! empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang=$this->thirdparty->default_lang;		// For language to language of customer

-					if (! empty($newlang))

+					$newlang = '';

+					if (empty($newlang) && GETPOST('lang_id', 'aZ09')) $newlang = GETPOST('lang_id', 'aZ09');

+					if (!empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang = $this->thirdparty->default_lang; // For language to language of customer

+					if (!empty($newlang))

 					{

-						$outputlangs = new Translate("",$conf);

+						$outputlangs = new Translate("", $conf);

 						$outputlangs->setDefaultLang($newlang);

 					}

 

-					$label = (! empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;

+					$label = (!empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;

 				}

 				else

 				{

 					$label = $line->product_label;

 				}

 

-				$text.= ' - '.(! empty($line->label)?$line->label:$label);

-				$description.=(! empty($conf->global->PRODUIT_DESC_IN_FORM)?'':dol_htmlentitiesbr($line->description));	// Description is what to show on popup. We shown nothing if already into desc.

+				$text .= ' - '.(!empty($line->label) ? $line->label : $label);

+				$description .= (!empty($conf->global->PRODUIT_DESC_IN_FORM) ? '' : dol_htmlentitiesbr($line->description)); // Description is what to show on popup. We shown nothing if already into desc.

 			}

 

-			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');

+			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx / 100)), 'MU');

 

 			// Output template part (modules that overwrite templates must declare this into descriptor)

 			// Use global variables + $dateSelector + $seller and $buyer

-			$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-			foreach($dirtpls as $reldir)

+			$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));

+			foreach ($dirtpls as $reldir)

 			{

 				$tpl = dol_buildpath($reldir.'/objectline_view.tpl.php');

 				if (empty($conf->file->strict_mode)) {

-					$res=@include $tpl;

+					$res = @include $tpl;

 				} else {

-					$res=include $tpl; // for debug

+					$res = include $tpl; // for debug

 				}

 				if ($res) break;

 			}

@@ -4051,21 +4051,21 @@ 
 		// Ligne en mode update

 		if ($this->statut == 0 && $action == 'editline' && $selected == $line->id)

 		{

-			$label = (! empty($line->label) ? $line->label : (($line->fk_product > 0) ? $line->product_label : ''));

-			$placeholder=' placeholder="'.$langs->trans("Label").'"';

+			$label = (!empty($line->label) ? $line->label : (($line->fk_product > 0) ? $line->product_label : ''));

+			$placeholder = ' placeholder="'.$langs->trans("Label").'"';

 

-			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx/100)), 'MU');

+			$line->pu_ttc = price2num($line->subprice * (1 + ($line->tva_tx / 100)), 'MU');

 

 			// Output template part (modules that overwrite templates must declare this into descriptor)

 			// Use global variables + $dateSelector + $seller and $buyer

-			$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-			foreach($dirtpls as $reldir)

+			$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));

+			foreach ($dirtpls as $reldir)

 			{

 				$tpl = dol_buildpath($reldir.'/objectline_edit.tpl.php');

 				if (empty($conf->file->strict_mode)) {

-					$res=@include $tpl;

+					$res = @include $tpl;

 				} else {

-					$res=include $tpl; // for debug

+					$res = include $tpl; // for debug

 				}

 				if ($res) break;

 			}

@@ -4085,7 +4085,7 @@ 
 	 *	@param	string		$restrictlist		''=All lines, 'services'=Restrict to services only

 	 *  @return	void

 	 */

-	function printOriginLinesList($restrictlist='')

+	function printOriginLinesList($restrictlist = '')

 	{

 		global $langs, $hookmanager, $conf;

 

@@ -4096,26 +4096,26 @@ 
 		print '<td align="right">'.$langs->trans('PriceUHT').'</td>';

 		if (!empty($conf->multicurrency->enabled)) print '<td align="right">'.$langs->trans('PriceUHTCurrency').'</td>';

 		print '<td align="right">'.$langs->trans('Qty').'</td>';

-		if($conf->global->PRODUCT_USE_UNITS)

+		if ($conf->global->PRODUCT_USE_UNITS)

 		{

 			print '<td align="left">'.$langs->trans('Unit').'</td>';

 		}

 		print '<td align="right">'.$langs->trans('ReductionShort').'</td></tr>';

 

 		$var = true;

-		$i	 = 0;

+		$i = 0;

 

-		if (! empty($this->lines))

+		if (!empty($this->lines))

 		{

 			foreach ($this->lines as $line)

 			{

-				if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

+				if (is_object($hookmanager) && (($line->product_type == 9 && !empty($line->special_code)) || !empty($line->fk_parent_line)))

 				{

 					if (empty($line->fk_parent_line))

 					{

-						$parameters=array('line'=>$line,'var'=>$var,'i'=>$i);

-						$action='';

-						$hookmanager->executeHooks('printOriginObjectLine',$parameters,$this,$action);    // Note that $action and $object may have been modified by some hooks

+						$parameters = array('line'=>$line, 'var'=>$var, 'i'=>$i);

+						$action = '';

+						$hookmanager->executeHooks('printOriginObjectLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 					}

 				}

 				else

@@ -4139,103 +4139,103 @@ 
 	 *	@param	string				$restrictlist		''=All lines, 'services'=Restrict to services only (strike line if not)

 	 * 	@return	void

 	 */

-	function printOriginLine($line, $var, $restrictlist='')

+	function printOriginLine($line, $var, $restrictlist = '')

 	{

 		global $langs, $conf;

 

 		//var_dump($line);

 		if (!empty($line->date_start))

 		{

-			$date_start=$line->date_start;

+			$date_start = $line->date_start;

 		}

 		else

 		{

-			$date_start=$line->date_debut_prevue;

-			if ($line->date_debut_reel) $date_start=$line->date_debut_reel;

+			$date_start = $line->date_debut_prevue;

+			if ($line->date_debut_reel) $date_start = $line->date_debut_reel;

 		}

 		if (!empty($line->date_end))

 		{

-			$date_end=$line->date_end;

+			$date_end = $line->date_end;

 		}

 		else

 		{

-			$date_end=$line->date_fin_prevue;

-			if ($line->date_fin_reel) $date_end=$line->date_fin_reel;

+			$date_end = $line->date_fin_prevue;

+			if ($line->date_fin_reel) $date_end = $line->date_fin_reel;

 		}

 

 		$this->tpl['label'] = '';

-		if (! empty($line->fk_parent_line)) $this->tpl['label'].= img_picto('', 'rightarrow');

+		if (!empty($line->fk_parent_line)) $this->tpl['label'] .= img_picto('', 'rightarrow');

 

 		if (($line->info_bits & 2) == 2)  // TODO Not sure this is used for source object

 		{

-			$discount=new DiscountAbsolute($this->db);

+			$discount = new DiscountAbsolute($this->db);

 			$discount->fk_soc = $this->socid;

-			$this->tpl['label'].= $discount->getNomUrl(0,'discount');

+			$this->tpl['label'] .= $discount->getNomUrl(0, 'discount');

 		}

-		else if (! empty($line->fk_product))

+		else if (!empty($line->fk_product))

 		{

 			$productstatic = new Product($this->db);

 			$productstatic->id = $line->fk_product;

 			$productstatic->ref = $line->ref;

 			$productstatic->type = $line->fk_product_type;

-            if(empty($productstatic->ref)){

+            if (empty($productstatic->ref)) {

 				$line->fetch_product();

 				$productstatic = $line->product;

 			}

 			

-			$this->tpl['label'].= $productstatic->getNomUrl(1);

-			$this->tpl['label'].= ' - '.(! empty($line->label)?$line->label:$line->product_label);

+			$this->tpl['label'] .= $productstatic->getNomUrl(1);

+			$this->tpl['label'] .= ' - '.(!empty($line->label) ? $line->label : $line->product_label);

 			// Dates

 			if ($line->product_type == 1 && ($date_start || $date_end))

 			{

-				$this->tpl['label'].= get_date_range($date_start,$date_end);

+				$this->tpl['label'] .= get_date_range($date_start, $date_end);

 			}

 		}

 		else

 		{

-			$this->tpl['label'].= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''),'service') : img_object($langs->trans(''),'product')));

+			$this->tpl['label'] .= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''), 'service') : img_object($langs->trans(''), 'product')));

 			if (!empty($line->desc)) {

-				$this->tpl['label'].=$line->desc;

-			}else {

-				$this->tpl['label'].= ($line->label ? '&nbsp;'.$line->label : '');

+				$this->tpl['label'] .= $line->desc;

+			} else {

+				$this->tpl['label'] .= ($line->label ? '&nbsp;'.$line->label : '');

 			}

 			

 			// Dates

 			if ($line->product_type == 1 && ($date_start || $date_end))

 			{

-				$this->tpl['label'].= get_date_range($date_start,$date_end);

+				$this->tpl['label'] .= get_date_range($date_start, $date_end);

 			}

 		}

 

-		if (! empty($line->desc))

+		if (!empty($line->desc))

 		{

 			if ($line->desc == '(CREDIT_NOTE)')  // TODO Not sure this is used for source object

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount = new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote",$discount->getNomUrl(0));

+				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote", $discount->getNomUrl(0));

 			}

 			elseif ($line->desc == '(DEPOSIT)')  // TODO Not sure this is used for source object

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount = new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit",$discount->getNomUrl(0));

+				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit", $discount->getNomUrl(0));

 			}

 			elseif ($line->desc == '(EXCESS RECEIVED)')

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount = new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived",$discount->getNomUrl(0));

+				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived", $discount->getNomUrl(0));

 			}

 			elseif ($line->desc == '(EXCESS PAID)')

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount = new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

-				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid",$discount->getNomUrl(0));

+				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid", $discount->getNomUrl(0));

 			}

 			else

 			{

-				$this->tpl['description'] = dol_trunc($line->desc,60);

+				$this->tpl['description'] = dol_trunc($line->desc, 60);

 			}

 		}

 		else

@@ -4246,7 +4246,7 @@ 
         // VAT Rate

         $this->tpl['vat_rate'] = vatrate($line->tva_tx, true);

         $this->tpl['vat_rate'] .= (($line->info_bits & 1) == 1) ? '*' : '';

-        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';

+        if (!empty($line->vat_src_code) && !preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'] .= ' ('.$line->vat_src_code.')';

 

 		$this->tpl['price'] = price($line->subprice);

 		$this->tpl['multicurrency_price'] = price($line->multicurrency_subprice);

@@ -4255,19 +4255,19 @@ 
 		$this->tpl['remise_percent'] = (($line->info_bits & 2) != 2) ? vatrate($line->remise_percent, true) : '&nbsp;';

 

 		// Is the line strike or not

-		$this->tpl['strike']=0;

-		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike']=1;

+		$this->tpl['strike'] = 0;

+		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike'] = 1;

 

 		// Output template part (modules that overwrite templates must declare this into descriptor)

 		// Use global variables + $dateSelector + $seller and $buyer

-		$dirtpls=array_merge($conf->modules_parts['tpl'],array('/core/tpl'));

-		foreach($dirtpls as $reldir)

+		$dirtpls = array_merge($conf->modules_parts['tpl'], array('/core/tpl'));

+		foreach ($dirtpls as $reldir)

 		{

 			$tpl = dol_buildpath($reldir.'/originproductline.tpl.php');

 			if (empty($conf->file->strict_mode)) {

-				$res=@include $tpl;

+				$res = @include $tpl;

 			} else {

-				$res=include $tpl; // for debug

+				$res = include $tpl; // for debug

 			}

 			if ($res) break;

 		}

@@ -4285,26 +4285,26 @@ 
 	 *	@param		int		$mandatory			Mandatory or not

 	 *	@return		int							<=0 if KO, >0 if OK

 	 */

-	function add_element_resource($resource_id, $resource_type, $busy=0, $mandatory=0)

+	function add_element_resource($resource_id, $resource_type, $busy = 0, $mandatory = 0)

 	{

         // phpcs:enable

 		$this->db->begin();

 

 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_resources (";

-		$sql.= "resource_id";

-		$sql.= ", resource_type";

-		$sql.= ", element_id";

-		$sql.= ", element_type";

-		$sql.= ", busy";

-		$sql.= ", mandatory";

-		$sql.= ") VALUES (";

-		$sql.= $resource_id;

-		$sql.= ", '".$this->db->escape($resource_type)."'";

-		$sql.= ", '".$this->db->escape($this->id)."'";

-		$sql.= ", '".$this->db->escape($this->element)."'";

-		$sql.= ", '".$this->db->escape($busy)."'";

-		$sql.= ", '".$this->db->escape($mandatory)."'";

-		$sql.= ")";

+		$sql .= "resource_id";

+		$sql .= ", resource_type";

+		$sql .= ", element_id";

+		$sql .= ", element_type";

+		$sql .= ", busy";

+		$sql .= ", mandatory";

+		$sql .= ") VALUES (";

+		$sql .= $resource_id;

+		$sql .= ", '".$this->db->escape($resource_type)."'";

+		$sql .= ", '".$this->db->escape($this->id)."'";

+		$sql .= ", '".$this->db->escape($this->element)."'";

+		$sql .= ", '".$this->db->escape($busy)."'";

+		$sql .= ", '".$this->db->escape($mandatory)."'";

+		$sql .= ")";

 

 		dol_syslog(get_class($this)."::add_element_resource", LOG_DEBUG);

 		if ($this->db->query($sql))

@@ -4314,7 +4314,7 @@ 
 		}

 		else

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return  0;

 		}

@@ -4329,7 +4329,7 @@ 
 	 *    @param	int		$notrigger		Disable all triggers

 	 *    @return   int						>0 if OK, <0 if KO

 	 */

-	function delete_resource($rowid, $element, $notrigger=0)

+	function delete_resource($rowid, $element, $notrigger = 0)

 	{

         // phpcs:enable

 		global $user;

@@ -4337,22 +4337,22 @@ 
 		$this->db->begin();

 

 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_resources";

-		$sql.= " WHERE rowid=".$rowid;

+		$sql .= " WHERE rowid=".$rowid;

 

 		dol_syslog(get_class($this)."::delete_resource", LOG_DEBUG);

 

-		$resql=$this->db->query($sql);

-		if (! $resql)

+		$resql = $this->db->query($sql);

+		if (!$resql)

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return -1;

 		}

 		else

 		{

-			if (! $notrigger)

+			if (!$notrigger)

 			{

-				$result=$this->call_trigger(strtoupper($element).'_DELETE_RESOURCE', $user);

+				$result = $this->call_trigger(strtoupper($element).'_DELETE_RESOURCE', $user);

 				if ($result < 0) { $this->db->rollback(); return -1; }

 			}

 			$this->db->commit();

@@ -4371,8 +4371,8 @@ 
 		// Force a copy of this->lines, otherwise it will point to same object.

 		if (isset($this->lines) && is_array($this->lines))

 		{

-			$nboflines=count($this->lines);

-			for($i=0; $i < $nboflines; $i++)

+			$nboflines = count($this->lines);

+			for ($i = 0; $i < $nboflines; $i++)

 			{

 				$this->lines[$i] = clone $this->lines[$i];

 			}

@@ -4392,43 +4392,43 @@ 
 	 * @return 	int 						>0 if OK, <0 if KO

 	 * @see	addFileIntoDatabaseIndex

 	 */

-	protected function commonGenerateDocument($modelspath, $modele, $outputlangs, $hidedetails, $hidedesc, $hideref, $moreparams=null)

+	protected function commonGenerateDocument($modelspath, $modele, $outputlangs, $hidedetails, $hidedesc, $hideref, $moreparams = null)

 	{

 		global $conf, $langs, $user;

 

-		$srctemplatepath='';

+		$srctemplatepath = '';

 

 		// Increase limit for PDF build

-		$err=error_reporting();

+		$err = error_reporting();

 		error_reporting(0);

 		@set_time_limit(120);

 		error_reporting($err);

 

 		// If selected model is a filename template (then $modele="modelname" or "modelname:filename")

-		$tmp=explode(':',$modele,2);

-		if (! empty($tmp[1]))

+		$tmp = explode(':', $modele, 2);

+		if (!empty($tmp[1]))

 		{

-			$modele=$tmp[0];

-			$srctemplatepath=$tmp[1];

+			$modele = $tmp[0];

+			$srctemplatepath = $tmp[1];

 		}

 

 		// Search template files

-		$file=''; $classname=''; $filefound=0;

-		$dirmodels=array('/');

-		if (is_array($conf->modules_parts['models'])) $dirmodels=array_merge($dirmodels,$conf->modules_parts['models']);

-		foreach($dirmodels as $reldir)

+		$file = ''; $classname = ''; $filefound = 0;

+		$dirmodels = array('/');

+		if (is_array($conf->modules_parts['models'])) $dirmodels = array_merge($dirmodels, $conf->modules_parts['models']);

+		foreach ($dirmodels as $reldir)

 		{

-			foreach(array('doc','pdf') as $prefix)

+			foreach (array('doc', 'pdf') as $prefix)

 			{

-				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php";     // Member module use prefix_module.class.php

+				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php"; // Member module use prefix_module.class.php

 				else $file = $prefix."_".$modele.".modules.php";

 

 				// On verifie l'emplacement du modele

-				$file=dol_buildpath($reldir.$modelspath.$file,0);

+				$file = dol_buildpath($reldir.$modelspath.$file, 0);

 				if (file_exists($file))

 				{

-					$filefound=1;

-					$classname=$prefix.'_'.$modele;

+					$filefound = 1;

+					$classname = $prefix.'_'.$modele;

 					break;

 				}

 			}

@@ -4438,7 +4438,7 @@ 
 		// If generator was found

 		if ($filefound)

 		{

-			global $db;  // Required to solve a conception default in commonstickergenerator.class.php making an include of code using $db

+			global $db; // Required to solve a conception default in commonstickergenerator.class.php making an include of code using $db

 

 			require_once $file;

 

@@ -4447,32 +4447,32 @@ 
 			// If generator is ODT, we must have srctemplatepath defined, if not we set it.

 			if ($obj->type == 'odt' && empty($srctemplatepath))

 			{

-				$varfortemplatedir=$obj->scandir;

-				if ($varfortemplatedir && ! empty($conf->global->$varfortemplatedir))

+				$varfortemplatedir = $obj->scandir;

+				if ($varfortemplatedir && !empty($conf->global->$varfortemplatedir))

 				{

-					$dirtoscan=$conf->global->$varfortemplatedir;

+					$dirtoscan = $conf->global->$varfortemplatedir;

 

-					$listoffiles=array();

+					$listoffiles = array();

 

 					// Now we add first model found in directories scanned

-					$listofdir=explode(',',$dirtoscan);

-					foreach($listofdir as $key => $tmpdir)

+					$listofdir = explode(',', $dirtoscan);

+					foreach ($listofdir as $key => $tmpdir)

 					{

-						$tmpdir=trim($tmpdir);

-						$tmpdir=preg_replace('/DOL_DATA_ROOT/',DOL_DATA_ROOT,$tmpdir);

-						if (! $tmpdir) { unset($listofdir[$key]); continue; }

+						$tmpdir = trim($tmpdir);

+						$tmpdir = preg_replace('/DOL_DATA_ROOT/', DOL_DATA_ROOT, $tmpdir);

+						if (!$tmpdir) { unset($listofdir[$key]); continue; }

 						if (is_dir($tmpdir))

 						{

-							$tmpfiles=dol_dir_list($tmpdir,'files',0,'\.od(s|t)$','','name',SORT_ASC,0);

-							if (count($tmpfiles)) $listoffiles=array_merge($listoffiles,$tmpfiles);

+							$tmpfiles = dol_dir_list($tmpdir, 'files', 0, '\.od(s|t)$', '', 'name', SORT_ASC, 0);

+							if (count($tmpfiles)) $listoffiles = array_merge($listoffiles, $tmpfiles);

 						}

 					}

 

 					if (count($listoffiles))

 					{

-						foreach($listoffiles as $record)

+						foreach ($listoffiles as $record)

 						{

-							$srctemplatepath=$record['fullname'];

+							$srctemplatepath = $record['fullname'];

 							break;

 						}

 					}

@@ -4480,27 +4480,27 @@ 
 

 				if (empty($srctemplatepath))

 				{

-					$this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotDefined';

+					$this->error = 'ErrorGenerationAskedForOdtTemplateWithSrcFileNotDefined';

 					return -1;

 				}

 			}

 

-			if ($obj->type == 'odt' && ! empty($srctemplatepath))

+			if ($obj->type == 'odt' && !empty($srctemplatepath))

 			{

-				if (! dol_is_file($srctemplatepath))

+				if (!dol_is_file($srctemplatepath))

 				{

-					$this->error='ErrorGenerationAskedForOdtTemplateWithSrcFileNotFound';

+					$this->error = 'ErrorGenerationAskedForOdtTemplateWithSrcFileNotFound';

 					return -1;

 				}

 			}

 

 			// We save charset_output to restore it because write_file can change it if needed for

 			// output format that does not support UTF8.

-			$sav_charset_output=$outputlangs->charset_output;

+			$sav_charset_output = $outputlangs->charset_output;

 

 			if (in_array(get_class($this), array('Adherent')))

 			{

-				$arrayofrecords = array();   // The write_file of templates of adherent class need this var

+				$arrayofrecords = array(); // The write_file of templates of adherent class need this var

 				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, 'member', 1, $moreparams);

 			}

 			else

@@ -4511,41 +4511,41 @@ 
 

 			if ($resultwritefile > 0)

 			{

-				$outputlangs->charset_output=$sav_charset_output;

+				$outputlangs->charset_output = $sav_charset_output;

 

 				// We delete old preview

 				require_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';

 				dol_delete_preview($this);

 

 				// Index file in database

-				if (! empty($obj->result['fullpath']))

+				if (!empty($obj->result['fullpath']))

 				{

 					$destfull = $obj->result['fullpath'];

 					$upload_dir = dirname($destfull);

 					$destfile = basename($destfull);

-					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $upload_dir);

+					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT, '/').'/', '', $upload_dir);

 

-					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir

+					if (!preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir

 					{

 						$filename = basename($destfile);

 						$rel_dir = preg_replace('/[\\/]$/', '', $rel_dir);

 						$rel_dir = preg_replace('/^[\\/]/', '', $rel_dir);

 

 						include_once DOL_DOCUMENT_ROOT.'/ecm/class/ecmfiles.class.php';

-						$ecmfile=new EcmFiles($this->db);

-						$result = $ecmfile->fetch(0, '', ($rel_dir?$rel_dir.'/':'').$filename);

+						$ecmfile = new EcmFiles($this->db);

+						$result = $ecmfile->fetch(0, '', ($rel_dir ? $rel_dir.'/' : '').$filename);

 

 						// Set the public "share" key

 						$setsharekey = false;

 						if ($this->element == 'propal')

 						{

-							$useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL;	// Replace this with 1 when feature to make online signature is ok

-							if ($useonlinesignature) $setsharekey=true;

-							if (! empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

+							$useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL; // Replace this with 1 when feature to make online signature is ok

+							if ($useonlinesignature) $setsharekey = true;

+							if (!empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey = true;

 						}

-						if ($this->element == 'commande'     && ! empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey=true;

-						if ($this->element == 'facture'      && ! empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey=true;

-						if ($this->element == 'bank_account' && ! empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

+						if ($this->element == 'commande' && !empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey = true;

+						if ($this->element == 'facture' && !empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey = true;

+						if ($this->element == 'bank_account' && !empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey = true;

 

 						if ($setsharekey)

 						{

@@ -4558,11 +4558,11 @@ 
 

 						if ($result > 0)

 						{

-							$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

+							$ecmfile->label = md5_file(dol_osencode($destfull)); // hash of file content

 							$ecmfile->fullpath_orig = '';

 							$ecmfile->gen_or_uploaded = 'generated';

-							$ecmfile->description = '';    // indexed content

-							$ecmfile->keyword = '';        // keyword content

+							$ecmfile->description = ''; // indexed content

+							$ecmfile->keyword = ''; // keyword content

 							$result = $ecmfile->update($user);

 							if ($result < 0)

 							{

@@ -4574,11 +4574,11 @@ 
 							$ecmfile->entity = $conf->entity;

 							$ecmfile->filepath = $rel_dir;

 							$ecmfile->filename = $filename;

-							$ecmfile->label = md5_file(dol_osencode($destfull));	// hash of file content

+							$ecmfile->label = md5_file(dol_osencode($destfull)); // hash of file content

 							$ecmfile->fullpath_orig = '';

 							$ecmfile->gen_or_uploaded = 'generated';

-							$ecmfile->description = '';    // indexed content

-							$ecmfile->keyword = '';        // keyword content

+							$ecmfile->description = ''; // indexed content

+							$ecmfile->keyword = ''; // keyword content

 							$ecmfile->src_object_type = $this->table_element;

 							$ecmfile->src_object_id   = $this->id;

 

@@ -4595,14 +4595,14 @@ 
 						//var_dump($obj->update_main_doc_field);exit;

 

 						// Update the last_main_doc field into main object (if documenent generator has property ->update_main_doc_field set)

-						$update_main_doc_field=0;

-						if (! empty($obj->update_main_doc_field)) $update_main_doc_field=1;

-						if ($update_main_doc_field && ! empty($this->table_element))

+						$update_main_doc_field = 0;

+						if (!empty($obj->update_main_doc_field)) $update_main_doc_field = 1;

+						if ($update_main_doc_field && !empty($this->table_element))

 						{

 							$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element." SET last_main_doc = '".($ecmfile->filepath.'/'.$ecmfile->filename)."'";

-							$sql.= ' WHERE rowid = '.$this->id;

+							$sql .= ' WHERE rowid = '.$this->id;

 							$resql = $this->db->query($sql);

-							if (! $resql) dol_print_error($this->db);

+							if (!$resql) dol_print_error($this->db);

 						}

 					}

 				}

@@ -4618,15 +4618,15 @@ 
 			}

 			else

 			{

-				$outputlangs->charset_output=$sav_charset_output;

+				$outputlangs->charset_output = $sav_charset_output;

 				dol_print_error($this->db, "Error generating document for ".__CLASS__.". Error: ".$obj->error, $obj->errors);

 				return -1;

 			}

 		}

 		else

 		{

-			$this->error=$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);

-			dol_print_error('',$this->error);

+			$this->error = $langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists", $file);

+			dol_print_error('', $this->error);

 			return -1;

 		}

 	}

@@ -4642,9 +4642,9 @@ 
 	{

 		global $maxwidthsmall, $maxheightsmall, $maxwidthmini, $maxheightmini, $quality;

 

-		require_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';		// This define also $maxwidthsmall, $quality, ...

+		require_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php'; // This define also $maxwidthsmall, $quality, ...

 

-		$file_osencoded=dol_osencode($file);

+		$file_osencoded = dol_osencode($file);

 		if (file_exists($file_osencoded))

 		{

 			// Create small thumbs for company (Ratio is near 16/9)

@@ -4674,7 +4674,7 @@ 
 	 * @param   string              $alternatevalue     Alternate value to use

 	 * @return  string|string[]                         Default value (can be an array if the GETPOST return an array)

 	 **/

-	function getDefaultCreateValueFor($fieldname, $alternatevalue=null)

+	function getDefaultCreateValueFor($fieldname, $alternatevalue = null)

 	{

 		global $conf, $_POST;

 

@@ -4683,16 +4683,16 @@ 
 

 		if (isset($alternatevalue)) return $alternatevalue;

 

-		$newelement=$this->element;

-		if ($newelement == 'facture') $newelement='invoice';

-		if ($newelement == 'commande') $newelement='order';

+		$newelement = $this->element;

+		if ($newelement == 'facture') $newelement = 'invoice';

+		if ($newelement == 'commande') $newelement = 'order';

 		if (empty($newelement))

 		{

 			dol_syslog("Ask a default value using common method getDefaultCreateValueForField on an object with no property ->element defined. Return empty string.", LOG_WARNING);

 			return '';

 		}

 

-		$keyforfieldname=strtoupper($newelement.'_DEFAULT_'.$fieldname);

+		$keyforfieldname = strtoupper($newelement.'_DEFAULT_'.$fieldname);

 		//var_dump($keyforfieldname);

 		if (isset($conf->global->$keyforfieldname)) return $conf->global->$keyforfieldname;

 

@@ -4717,21 +4717,21 @@ 
 	function call_trigger($trigger_name, $user)

 	{

         // phpcs:enable

-		global $langs,$conf;

+		global $langs, $conf;

 

-		include_once DOL_DOCUMENT_ROOT . '/core/class/interfaces.class.php';

-		$interface=new Interfaces($this->db);

-		$result=$interface->run_triggers($trigger_name,$this,$user,$langs,$conf);

+		include_once DOL_DOCUMENT_ROOT.'/core/class/interfaces.class.php';

+		$interface = new Interfaces($this->db);

+		$result = $interface->run_triggers($trigger_name, $this, $user, $langs, $conf);

 

 		if ($result < 0)

 		{

 			if (!empty($this->errors))

 			{

-				$this->errors=array_unique(array_merge($this->errors,$interface->errors));   // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.

+				$this->errors = array_unique(array_merge($this->errors, $interface->errors)); // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.

 			}

 			else

 			{

-				$this->errors=$interface->errors;

+				$this->errors = $interface->errors;

 			}

 		}

 		return $result;

@@ -4750,19 +4750,19 @@ 
 	 *  @param  array	$optionsArray   Array resulting of call of extrafields->fetch_name_optionals_label(). Deprecated. Function must be called without parameters.

 	 *  @return	int						<0 if error, 0 if no values of extrafield to find nor found, 1 if an attribute is found and value loaded

 	 */

-	function fetch_optionals($rowid=null, $optionsArray=null)

+	function fetch_optionals($rowid = null, $optionsArray = null)

 	{

         // phpcs:enable

-		if (empty($rowid)) $rowid=$this->id;

+		if (empty($rowid)) $rowid = $this->id;

 

 		// To avoid SQL errors. Probably not the better solution though

 		if (!$this->table_element) {

 			return 0;

 		}

 

-		$this->array_options=array();

+		$this->array_options = array();

 

-		if (! is_array($optionsArray))

+		if (!is_array($optionsArray))

 		{

 			// If $extrafields is not a known object, we initialize it. Best practice is to have $extrafields defined into card.php or list.php page.

 			// TODO Use of existing $extrafield is not yet ready (must mutualize code that use extrafields in form first)

@@ -4778,7 +4778,7 @@ 
 			{

 				$extrafields->fetch_name_optionals_label($this->table_element);

 			}

-			$optionsArray = (! empty($extrafields->attributes[$this->table_element]['label'])?$extrafields->attributes[$this->table_element]['label']:null);

+			$optionsArray = (!empty($extrafields->attributes[$this->table_element]['label']) ? $extrafields->attributes[$this->table_element]['label'] : null);

 		}

 		else

 		{

@@ -4797,18 +4797,18 @@ 
 			{

 				if (empty($extrafields->attributes[$this->table_element]['type'][$name]) || $extrafields->attributes[$this->table_element]['type'][$name] != 'separate')

 				{

-					$sql.= ", ".$name;

+					$sql .= ", ".$name;

 				}

 			}

-			$sql.= " FROM ".MAIN_DB_PREFIX.$table_element."_extrafields";

-			$sql.= " WHERE fk_object = ".$rowid;

+			$sql .= " FROM ".MAIN_DB_PREFIX.$table_element."_extrafields";

+			$sql .= " WHERE fk_object = ".$rowid;

 

 			//dol_syslog(get_class($this)."::fetch_optionals get extrafields data for ".$this->table_element, LOG_DEBUG);		// Too verbose

-			$resql=$this->db->query($sql);

+			$resql = $this->db->query($sql);

 			if ($resql)

 			{

 				$this->array_options = array();

-				$numrows=$this->db->num_rows($resql);

+				$numrows = $this->db->num_rows($resql);

 				if ($numrows)

 				{

 					$tab = $this->db->fetch_array($resql);

@@ -4816,17 +4816,17 @@ 
 					foreach ($tab as $key => $value)

 					{

 						// Test fetch_array ! is_int($key) because fetch_array result is a mix table with Key as alpha and Key as int (depend db engine)

-						if ($key != 'rowid' && $key != 'tms' && $key != 'fk_member' && ! is_int($key))

+						if ($key != 'rowid' && $key != 'tms' && $key != 'fk_member' && !is_int($key))

 						{

 							// we can add this attribute to object

-							if (! empty($extrafields) && in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date','datetime')))

+							if (!empty($extrafields) && in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date', 'datetime')))

 							{

 								//var_dump($extrafields->attributes[$this->table_element]['type'][$key]);

-								$this->array_options["options_".$key]=$this->db->jdate($value);

+								$this->array_options["options_".$key] = $this->db->jdate($value);

 							}

 							else

 							{

-								$this->array_options["options_".$key]=$value;

+								$this->array_options["options_".$key] = $value;

 							}

 

 							//var_dump('key '.$key.' '.$value.' type='.$extrafields->attributes[$this->table_element]['type'][$key].' '.$this->array_options["options_".$key]);

@@ -4862,10 +4862,10 @@ 
 

 		$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

 		dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);

-		$resql=$this->db->query($sql_del);

-		if (! $resql)

+		$resql = $this->db->query($sql_del);

+		if (!$resql)

 		{

-			$this->error=$this->db->lasterror();

+			$this->error = $this->db->lasterror();

 			$this->db->rollback();

 			return -1;

 		}

@@ -4886,36 +4886,36 @@ 
 	 *  @return int 						-1=error, O=did nothing, 1=OK

 	 *  @see updateExtraField, setValueFrom

 	 */

-	function insertExtraFields($trigger='', $userused=null)

+	function insertExtraFields($trigger = '', $userused = null)

 	{

-		global $conf,$langs,$user;

+		global $conf, $langs, $user;

 

-		if (empty($userused)) $userused=$user;

+		if (empty($userused)) $userused = $user;

 

-		$error=0;

+		$error = 0;

 

-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

+		if (!empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0; // For avoid conflicts if trigger used

 

-		if (! empty($this->array_options))

+		if (!empty($this->array_options))

 		{

 			// Check parameters

 			$langs->load('admin');

 			require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

 			$extrafields = new ExtraFields($this->db);

-			$target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);

+			$target_extrafields = $extrafields->fetch_name_optionals_label($this->table_element);

 

 			//Eliminate copied source object extra_fields that do not exist in target object

-			$new_array_options=array();

+			$new_array_options = array();

 			foreach ($this->array_options as $key => $value) {

-				if (in_array(substr($key,8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test

+				if (in_array(substr($key, 8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test

 					$new_array_options[$key] = $value;

 				elseif (in_array($key, array_keys($target_extrafields)))		// We test on $key that does not contains the 'options_' prefix

 					$new_array_options['options_'.$key] = $value;

 			}

 

-			foreach($new_array_options as $key => $value)

+			foreach ($new_array_options as $key => $value)

 			{

-			   	$attributeKey      = substr($key,8);   // Remove 'options_' prefix

+			   	$attributeKey      = substr($key, 8); // Remove 'options_' prefix

 			   	$attributeType     = $extrafields->attributes[$this->table_element]['type'][$attributeKey];

 			   	$attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$attributeKey];

 			   	$attributeParam    = $extrafields->attributes[$this->table_element]['param'][$attributeKey];

@@ -4923,13 +4923,13 @@ 
 

 			   	if ($attributeRequired)

 			   	{

-			   		$mandatorypb=false;

-			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb=true;

-			   		if ($this->array_options[$key] === '') $mandatorypb=true;

+			   		$mandatorypb = false;

+			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb = true;

+			   		if ($this->array_options[$key] === '') $mandatorypb = true;

 			   		if ($mandatorypb)

 			   		{

 			   			dol_syslog($this->error);

-			   			$this->errors[]=$langs->trans('ErrorFieldRequired', $attributeLabel);

+			   			$this->errors[] = $langs->trans('ErrorFieldRequired', $attributeLabel);

 			   			return -1;

 			   		}

 			   	}

@@ -4940,25 +4940,25 @@ 
 			   	switch ($attributeType)

 			   	{

 			   		case 'int':

-			  			if (!is_numeric($value) && $value!='')

+			  			if (!is_numeric($value) && $value != '')

 			   			{

-			   				$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

+			   				$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 			   				return -1;

 			  			}

-			   			elseif ($value=='')

+			   			elseif ($value == '')

 			   			{

 			   				$new_array_options[$key] = null;

 			   			}

 			 			break;

 					case 'double':

 						$value = price2num($value);

-						if (!is_numeric($value) && $value!='')

+						if (!is_numeric($value) && $value != '')

 						{

 							dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

-							$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

+							$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 							return -1;

 						}

-						elseif ($value=='')

+						elseif ($value == '')

 						{

 							$new_array_options[$key] = null;

 						}

@@ -4972,12 +4972,12 @@ 
              			}

              			break;*/

 			   		case 'password':

-			   			$algo='';

+			   			$algo = '';

 			   			if ($this->array_options[$key] != '' && is_array($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']))

 			   			{

 			   				// If there is an encryption choice, we use it to crypt data before insert

 			   				$tmparrays = array_keys($extrafields->attributes[$this->table_element]['param'][$attributeKey]['options']);

-			   				$algo=reset($tmparrays);

+			   				$algo = reset($tmparrays);

 			   				if ($algo != '')

 			   				{

 			   					//global $action;		// $action may be 'create', 'update', 'update_extras'...

@@ -4988,7 +4988,7 @@ 
 			   						//var_dump($this->oldcopy->array_options[$key]); var_dump($this->array_options[$key]);

 				   					if ($this->array_options[$key] == $this->oldcopy->array_options[$key])	// If old value crypted in database is same than submited new value, it means we don't change it, so we don't update.

 				   					{

-				   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

+				   						$new_array_options[$key] = $this->array_options[$key]; // Value is kept

 				   					}

 									else

 									{

@@ -4999,7 +4999,7 @@ 
 			   					}

 			   					else

 			   					{

-			   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

+			   						$new_array_options[$key] = $this->array_options[$key]; // Value is kept

 			   					}

 			   				}

 			   			}

@@ -5016,13 +5016,13 @@ 
 						break;

 					case 'datetime':

 						// If data is a string instead of a timestamp, we convert it

-						if (! is_int($this->array_options[$key])) {

+						if (!is_int($this->array_options[$key])) {

 							$this->array_options[$key] = strtotime($this->array_options[$key]);

 						}

 						$new_array_options[$key] = $this->db->idate($this->array_options[$key]);

 						break;

 		   			case 'link':

-						$param_list=array_keys($attributeParam['options']);

+						$param_list = array_keys($attributeParam['options']);

 						// 0 : ObjectName

 						// 1 : classPath

 						$InfoFieldList = explode(":", $param_list[0]);

@@ -5031,18 +5031,18 @@ 
 						{

 							if ($value == '-1')	// -1 is key for no defined in combo list of objects

 							{

-								$new_array_options[$key]='';

+								$new_array_options[$key] = '';

 							}

 							elseif ($value)

 							{

 								$object = new $InfoFieldList[0]($this->db);

-								if (is_numeric($value)) $res=$object->fetch($value);

-								else $res=$object->fetch('',$value);

+								if (is_numeric($value)) $res = $object->fetch($value);

+								else $res = $object->fetch('', $value);

 

-								if ($res > 0) $new_array_options[$key]=$object->id;

+								if ($res > 0) $new_array_options[$key] = $object->id;

 								else

 								{

-									$this->error="Id/Ref '".$value."' for object '".$object->element."' not found";

+									$this->error = "Id/Ref '".$value."' for object '".$object->element."' not found";

 									$this->db->rollback();

 									return -1;

 								}

@@ -5066,46 +5066,46 @@ 
 			$this->db->query($sql_del);

 

 			$sql = "INSERT INTO ".MAIN_DB_PREFIX.$table_element."_extrafields (fk_object";

-			foreach($new_array_options as $key => $value)

+			foreach ($new_array_options as $key => $value)

 			{

-				$attributeKey = substr($key,8);   // Remove 'options_' prefix

+				$attributeKey = substr($key, 8); // Remove 'options_' prefix

 				// Add field of attribut

 				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator

-					$sql.=",".$attributeKey;

+					$sql .= ",".$attributeKey;

 			}

 			$sql .= ") VALUES (".$this->id;

 

-			foreach($new_array_options as $key => $value)

+			foreach ($new_array_options as $key => $value)

 			{

-				$attributeKey = substr($key,8);   // Remove 'options_' prefix

+				$attributeKey = substr($key, 8); // Remove 'options_' prefix

 				// Add field of attribute

 				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator)

 				{

 					if ($new_array_options[$key] != '')

 					{

-						$sql.=",'".$this->db->escape($new_array_options[$key])."'";

+						$sql .= ",'".$this->db->escape($new_array_options[$key])."'";

 					}

 					else

 					{

-						$sql.=",null";

+						$sql .= ",null";

 					}

 				}

 			}

-			$sql.=")";

+			$sql .= ")";

 

 			dol_syslog(get_class($this)."::insertExtraFields insert", LOG_DEBUG);

 			$resql = $this->db->query($sql);

-			if (! $resql)

+			if (!$resql)

 			{

-				$this->error=$this->db->lasterror();

+				$this->error = $this->db->lasterror();

 				$error++;

 			}

 

-			if (! $error && $trigger)

+			if (!$error && $trigger)

 			{

 				// Call trigger

-				$this->context=array('extrafieldaddupdate'=>1);

-				$result=$this->call_trigger($trigger, $userused);

+				$this->context = array('extrafieldaddupdate'=>1);

+				$result = $this->call_trigger($trigger, $userused);

 				if ($result < 0) $error++;

 				// End call trigger

 			}

@@ -5134,25 +5134,25 @@ 
 	 *  @return int                 		-1=error, O=did nothing, 1=OK

 	 *  @see setValueFrom, insertExtraFields

 	 */

-	function updateExtraField($key, $trigger=null, $userused=null)

+	function updateExtraField($key, $trigger = null, $userused = null)

 	{

-		global $conf,$langs,$user;

+		global $conf, $langs, $user;

 

-		if (empty($userused)) $userused=$user;

+		if (empty($userused)) $userused = $user;

 

-		$error=0;

+		$error = 0;

 

-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

+		if (!empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0; // For avoid conflicts if trigger used

 

-		if (! empty($this->array_options) && isset($this->array_options["options_".$key]))

+		if (!empty($this->array_options) && isset($this->array_options["options_".$key]))

 		{

 			// Check parameters

 			$langs->load('admin');

 			require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php';

 			$extrafields = new ExtraFields($this->db);

-			$target_extrafields=$extrafields->fetch_name_optionals_label($this->table_element);

+			$target_extrafields = $extrafields->fetch_name_optionals_label($this->table_element);

 

-			$value=$this->array_options["options_".$key];

+			$value = $this->array_options["options_".$key];

 

 			$attributeType     = $extrafields->attributes[$this->table_element]['type'][$key];

 			$attributeLabel    = $extrafields->attributes[$this->table_element]['label'][$key];

@@ -5165,25 +5165,25 @@ 
 			switch ($attributeType)

 			{

 				case 'int':

-					if (!is_numeric($value) && $value!='')

+					if (!is_numeric($value) && $value != '')

 					{

-						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue",$attributeLabel);

+						$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 						return -1;

 					}

-					elseif ($value=='')

+					elseif ($value == '')

 					{

 						$this->array_options["options_".$key] = null;

 					}

 					break;

 				case 'double':

 					$value = price2num($value);

-					if (!is_numeric($value) && $value!='')

+					if (!is_numeric($value) && $value != '')

 					{

 						dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

-						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

+						$this->errors[] = $langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 						return -1;

 					}

-					elseif ($value=='')

+					elseif ($value == '')

 					{

 						$this->array_options["options_".$key] = null;

 					}

@@ -5200,13 +5200,13 @@ 
 					$this->array_options["options_".$key] = price2num($this->array_options["options_".$key]);

 					break;

 				case 'date':

-					$this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);

+					$this->array_options["options_".$key] = $this->db->idate($this->array_options["options_".$key]);

 					break;

 				case 'datetime':

-					$this->array_options["options_".$key]=$this->db->idate($this->array_options["options_".$key]);

+					$this->array_options["options_".$key] = $this->db->idate($this->array_options["options_".$key]);

 					break;

 				case 'link':

-					$param_list=array_keys($attributeParam['options']);

+					$param_list = array_keys($attributeParam['options']);

 					// 0 : ObjectName

 					// 1 : classPath

 					$InfoFieldList = explode(":", $param_list[0]);

@@ -5214,8 +5214,8 @@ 
 					if ($value)

 					{

 						$object = new $InfoFieldList[0]($this->db);

-						$object->fetch(0,$value);

-						$this->array_options["options_".$key]=$object->id;

+						$object->fetch(0, $value);

+						$this->array_options["options_".$key] = $object->id;

 					}

 					break;

 			}

@@ -5224,24 +5224,24 @@ 
 			$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element."_extrafields SET ".$key."='".$this->db->escape($this->array_options["options_".$key])."'";

 			$sql .= " WHERE fk_object = ".$this->id;

 			$resql = $this->db->query($sql);

-			if (! $resql)

+			if (!$resql)

 			{

 				$error++;

-				$this->error=$this->db->lasterror();

+				$this->error = $this->db->lasterror();

 			}

 

-			if (! $error && $trigger)

+			if (!$error && $trigger)

 			{

 				// Call trigger

-				$this->context=array('extrafieldupdate'=>1);

-				$result=$this->call_trigger($trigger, $userused);

+				$this->context = array('extrafieldupdate'=>1);

+				$result = $this->call_trigger($trigger, $userused);

 				if ($result < 0) $error++;

 				// End call trigger

 			}

 

 			if ($error)

 			{

-				dol_syslog(get_class($this) . "::".__METHOD__ . $this->error, LOG_ERR);

+				dol_syslog(get_class($this)."::".__METHOD__.$this->error, LOG_ERR);

 				$this->db->rollback();

 				return -1;

 			}

@@ -5268,71 +5268,71 @@ 
 	 * @param  string|int		$morecss       Value for css to define style/length of field. May also be a numeric.

 	 * @return string

 	 */

-	function showInputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $morecss=0)

+	function showInputField($val, $key, $value, $moreparam = '', $keysuffix = '', $keyprefix = '', $morecss = 0)

 	{

-		global $conf,$langs,$form;

+		global $conf, $langs, $form;

 

-		if (! is_object($form))

+		if (!is_object($form))

 		{

 			require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';

-			$form=new Form($this->db);

+			$form = new Form($this->db);

 		}

 

-		$val=$this->fields[$key];

+		$val = $this->fields[$key];

 

-		$out='';

-        $type='';

+		$out = '';

+        $type = '';

         $param = array();

-        $param['options']=array();

-        $size =$this->fields[$key]['size'];

+        $param['options'] = array();

+        $size = $this->fields[$key]['size'];

         // Because we work on extrafields

-        if(preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)){

-            $param['options']=array($reg[1].':'.$reg[2]=>'N');

-            $type ='link';

-        } elseif(preg_match('/^link:(.*):(.*)/i', $val['type'], $reg)) {

-            $param['options']=array($reg[1].':'.$reg[2]=>'N');

-            $type ='link';

-        } elseif(preg_match('/^sellist:(.*):(.*):(.*):(.*)/i', $val['type'], $reg)) {

-            $param['options']=array($reg[1].':'.$reg[2].':'.$reg[3].':'.$reg[4]=>'N');

-            $type ='sellist';

-        } elseif(preg_match('/varchar\((\d+)\)/', $val['type'],$reg)) {

-            $param['options']=array();

-            $type ='varchar';

-            $size=$reg[1];

-        } elseif(preg_match('/varchar/', $val['type'])) {

-            $param['options']=array();

-            $type ='varchar';

-        } elseif(is_array($this->fields[$key]['arrayofkeyval'])) {

-            $param['options']=$this->fields[$key]['arrayofkeyval'];

-            $type ='select';

+        if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) {

+            $param['options'] = array($reg[1].':'.$reg[2]=>'N');

+            $type = 'link';

+        } elseif (preg_match('/^link:(.*):(.*)/i', $val['type'], $reg)) {

+            $param['options'] = array($reg[1].':'.$reg[2]=>'N');

+            $type = 'link';

+        } elseif (preg_match('/^sellist:(.*):(.*):(.*):(.*)/i', $val['type'], $reg)) {

+            $param['options'] = array($reg[1].':'.$reg[2].':'.$reg[3].':'.$reg[4]=>'N');

+            $type = 'sellist';

+        } elseif (preg_match('/varchar\((\d+)\)/', $val['type'], $reg)) {

+            $param['options'] = array();

+            $type = 'varchar';

+            $size = $reg[1];

+        } elseif (preg_match('/varchar/', $val['type'])) {

+            $param['options'] = array();

+            $type = 'varchar';

+        } elseif (is_array($this->fields[$key]['arrayofkeyval'])) {

+            $param['options'] = $this->fields[$key]['arrayofkeyval'];

+            $type = 'select';

         } else {

-            $param['options']=array();

-            $type =$this->fields[$key]['type'];

+            $param['options'] = array();

+            $type = $this->fields[$key]['type'];

         }

 

-		$label=$this->fields[$key]['label'];

+		$label = $this->fields[$key]['label'];

 		//$elementtype=$this->fields[$key]['elementtype'];	// Seems not used

-		$default=$this->fields[$key]['default'];

-		$computed=$this->fields[$key]['computed'];

-		$unique=$this->fields[$key]['unique'];

-		$required=$this->fields[$key]['required'];

+		$default = $this->fields[$key]['default'];

+		$computed = $this->fields[$key]['computed'];

+		$unique = $this->fields[$key]['unique'];

+		$required = $this->fields[$key]['required'];

 

-		$langfile=$this->fields[$key]['langfile'];

-		$list=$this->fields[$key]['list'];

-		$hidden=abs($this->fields[$key]['visible'])!=1?1:0;

+		$langfile = $this->fields[$key]['langfile'];

+		$list = $this->fields[$key]['list'];

+		$hidden = abs($this->fields[$key]['visible']) != 1 ? 1 : 0;

 

 		$objectid = $this->id;

 

 

 		if ($computed)

 		{

-			if (! preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';

+			if (!preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';

 			else return '';

 		}

 

 

 		// Use in priority showsize from parameters, then $val['css'] then autodefine

-		if (empty($morecss) && ! empty($val['css']))

+		if (empty($morecss) && !empty($val['css']))

 		{

 			$showsize = $val['css'];

 		}

@@ -5346,16 +5346,16 @@ 
 			{

 				$morecss = 'minwidth200imp';

 			}

-			elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+			elseif (in_array($type, array('int', 'integer', 'price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/', $type))

 			{

 				$morecss = 'maxwidth75';

                         }elseif ($type == 'url')

 			{

-				$morecss='minwidth400';

+				$morecss = 'minwidth400';

 			}

 			elseif ($type == 'boolean')

 			{

-				$morecss='';

+				$morecss = '';

 			}

 			else

 			{

@@ -5374,12 +5374,12 @@ 
 			}

 		}

 

-		if (in_array($type,array('date','datetime')))

+		if (in_array($type, array('date', 'datetime')))

 		{

-			$tmp=explode(',',$size);

-			$newsize=$tmp[0];

+			$tmp = explode(',', $size);

+			$newsize = $tmp[0];

 

-			$showtime = in_array($type,array('datetime')) ? 1 : 0;

+			$showtime = in_array($type, array('datetime')) ? 1 : 0;

 

 			// Do not show current date when field not required (see selectDate() method)

 			if (!$required && $value == '') $value = '-1';

@@ -5387,237 +5387,237 @@ 
 			// TODO Must also support $moreparam

 			$out = $form->selectDate($value, $keyprefix.$key.$keysuffix, $showtime, $showtime, $required, '', 1, (($keyprefix != 'search_' && $keyprefix != 'search_options_') ? 1 : 0), 0, 1);

 		}

-		elseif (in_array($type,array('int','integer')))

+		elseif (in_array($type, array('int', 'integer')))

 		{

-			$tmp=explode(',',$size);

-			$newsize=$tmp[0];

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

+			$tmp = explode(',', $size);

+			$newsize = $tmp[0];

+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam ? $moreparam : '').'>';

 		}

 		elseif (preg_match('/varchar/', $type))

 		{

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam ? $moreparam : '').'>';

 		}

 		elseif (in_array($type, array('mail', 'phone', 'url')))

 		{

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam ? $moreparam : '').'>';

 		}

 		elseif ($type == 'text')

 		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+			if (!preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

 			{

 				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

-				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,false,ROWS_5,'90%');

-				$out=$doleditor->Create(1);

+				$doleditor = new DolEditor($keyprefix.$key.$keysuffix, $value, '', 200, 'dolibarr_notes', 'In', false, false, false, ROWS_5, '90%');

+				$out = $doleditor->Create(1);

 			}

 			else

 			{

-				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

+				$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam ? $moreparam : '').'>';

 			}

 		}

 		elseif ($type == 'html')

 		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+			if (!preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

 			{

 				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

-				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,! empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE,ROWS_5,'90%');

-				$out=$doleditor->Create(1);

+				$doleditor = new DolEditor($keyprefix.$key.$keysuffix, $value, '', 200, 'dolibarr_notes', 'In', false, false, !empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE, ROWS_5, '90%');

+				$out = $doleditor->Create(1);

 			}

 			else

 			{

-				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

+				$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam ? $moreparam : '').'>';

 			}

 		}

 		elseif ($type == 'boolean')

 		{

-			$checked='';

+			$checked = '';

 			if (!empty($value)) {

-				$checked=' checked value="1" ';

+				$checked = ' checked value="1" ';

 			} else {

-				$checked=' value="1" ';

+				$checked = ' value="1" ';

 			}

-			$out='<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam?$moreparam:'').'>';

+			$out = '<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam ? $moreparam : '').'>';

 		}

 		elseif ($type == 'price')

 		{

 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

-				$value=price($value);

+				$value = price($value);

 			}

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> '.$langs->getCurrencySymbol($conf->currency);

+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam ? $moreparam : '').'> '.$langs->getCurrencySymbol($conf->currency);

 		}

-		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/', $type))

 		{

 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

-				$value=price($value);

+				$value = price($value);

 			}

-			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> ';

+			$out = '<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam ? $moreparam : '').'> ';

 		}

 		elseif ($type == 'select')

 		{

 			$out = '';

-			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

+			if (!empty($conf->use_javascript_ajax) && !empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

 			{

-				include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

-				$out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

+				include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

+				$out .= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

 			}

 

-			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

-                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1))$out.='<option value="0">&nbsp;</option>';

+			$out .= '<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam ? $moreparam : '').'>';

+                if ((!isset($this->fields[$key]['default'])) || ($this->fields[$key]['notnull'] != 1))$out .= '<option value="0">&nbsp;</option>';

 			foreach ($param['options'] as $key => $val)

 			{

 				if ((string) $key == '') continue;

 				list($val, $parent) = explode('|', $val);

-				$out.='<option value="'.$key.'"';

-				$out.= (((string) $value == (string) $key)?' selected':'');

-				$out.= (!empty($parent)?' parent="'.$parent.'"':'');

-				$out.='>'.$val.'</option>';

+				$out .= '<option value="'.$key.'"';

+				$out .= (((string) $value == (string) $key) ? ' selected' : '');

+				$out .= (!empty($parent) ? ' parent="'.$parent.'"' : '');

+				$out .= '>'.$val.'</option>';

 			}

-			$out.='</select>';

+			$out .= '</select>';

 		}

 		elseif ($type == 'sellist')

 		{

 			$out = '';

-			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

+			if (!empty($conf->use_javascript_ajax) && !empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

 			{

-				include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

-				$out.= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

+				include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

+				$out .= ajax_combobox($keyprefix.$key.$keysuffix, array(), 0);

 			}

 

-			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

+			$out .= '<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam ? $moreparam : '').'>';

 			if (is_array($param['options']))

 			{

-				$param_list=array_keys($param['options']);

+				$param_list = array_keys($param['options']);

 				$InfoFieldList = explode(":", $param_list[0]);

-				$parentName='';

-				$parentField='';

+				$parentName = '';

+				$parentField = '';

 				// 0 : tableName

 				// 1 : label field name

 				// 2 : key fields name (if differ of rowid)

 				// 3 : key field parent (for dependent lists)

 				// 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value

-				$keyList=(empty($InfoFieldList[2])?'rowid':$InfoFieldList[2].' as rowid');

+				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2].' as rowid');

 

 

-				if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4]))

+				if (count($InfoFieldList) > 4 && !empty($InfoFieldList[4]))

 				{

 					if (strpos($InfoFieldList[4], 'extra.') !== false)

 					{

-						$keyList='main.'.$InfoFieldList[2].' as rowid';

+						$keyList = 'main.'.$InfoFieldList[2].' as rowid';

 					} else {

-						$keyList=$InfoFieldList[2].' as rowid';

+						$keyList = $InfoFieldList[2].' as rowid';

 					}

 				}

-				if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3]))

+				if (count($InfoFieldList) > 3 && !empty($InfoFieldList[3]))

 				{

 					list($parentName, $parentField) = explode('|', $InfoFieldList[3]);

-					$keyList.= ', '.$parentField;

+					$keyList .= ', '.$parentField;

 				}

 

-				$fields_label = explode('|',$InfoFieldList[1]);

+				$fields_label = explode('|', $InfoFieldList[1]);

 				if (is_array($fields_label))

 				{

-					$keyList .=', ';

+					$keyList .= ', ';

 					$keyList .= implode(', ', $fields_label);

 				}

 

-				$sqlwhere='';

+				$sqlwhere = '';

 				$sql = 'SELECT '.$keyList;

-				$sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];

+				$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];

 				if (!empty($InfoFieldList[4]))

 				{

 					// can use SELECT request

-					if (strpos($InfoFieldList[4], '$SEL$')!==false) {

-						$InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);

+					if (strpos($InfoFieldList[4], '$SEL$') !== false) {

+						$InfoFieldList[4] = str_replace('$SEL$', 'SELECT', $InfoFieldList[4]);

 					}

 

 					// current object id can be use into filter

-					if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {

-						$InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);

+					if (strpos($InfoFieldList[4], '$ID$') !== false && !empty($objectid)) {

+						$InfoFieldList[4] = str_replace('$ID$', $objectid, $InfoFieldList[4]);

 					} else {

-						$InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);

+						$InfoFieldList[4] = str_replace('$ID$', '0', $InfoFieldList[4]);

 					}

 					//We have to join on extrafield table

-					if (strpos($InfoFieldList[4], 'extra')!==false)

+					if (strpos($InfoFieldList[4], 'extra') !== false)

 					{

-						$sql.= ' as main, '.MAIN_DB_PREFIX .$InfoFieldList[0].'_extrafields as extra';

-						$sqlwhere.= ' WHERE extra.fk_object=main.'.$InfoFieldList[2]. ' AND '.$InfoFieldList[4];

+						$sql .= ' as main, '.MAIN_DB_PREFIX.$InfoFieldList[0].'_extrafields as extra';

+						$sqlwhere .= ' WHERE extra.fk_object=main.'.$InfoFieldList[2].' AND '.$InfoFieldList[4];

 					}

 					else

 					{

-						$sqlwhere.= ' WHERE '.$InfoFieldList[4];

+						$sqlwhere .= ' WHERE '.$InfoFieldList[4];

 					}

 				}

 				else

 				{

-					$sqlwhere.= ' WHERE 1=1';

+					$sqlwhere .= ' WHERE 1=1';

 				}

 				// Some tables may have field, some other not. For the moment we disable it.

-				if (in_array($InfoFieldList[0],array('tablewithentity')))

+				if (in_array($InfoFieldList[0], array('tablewithentity')))

 				{

-					$sqlwhere.= ' AND entity = '.$conf->entity;

+					$sqlwhere .= ' AND entity = '.$conf->entity;

 				}

-				$sql.=$sqlwhere;

+				$sql .= $sqlwhere;

 				//print $sql;

 

-				$sql .= ' ORDER BY ' . implode(', ', $fields_label);

+				$sql .= ' ORDER BY '.implode(', ', $fields_label);

 

 				dol_syslog(get_class($this).'::showInputField type=sellist', LOG_DEBUG);

 				$resql = $this->db->query($sql);

 				if ($resql)

 				{

-					$out.='<option value="0">&nbsp;</option>';

+					$out .= '<option value="0">&nbsp;</option>';

 					$num = $this->db->num_rows($resql);

 					$i = 0;

 					while ($i < $num)

 					{

-						$labeltoshow='';

+						$labeltoshow = '';

 						$obj = $this->db->fetch_object($resql);

 

 						// Several field into label (eq table:code|libelle:rowid)

 						$notrans = false;

-						$fields_label = explode('|',$InfoFieldList[1]);

+						$fields_label = explode('|', $InfoFieldList[1]);

 						if (is_array($fields_label))

 						{

 							$notrans = true;

 							foreach ($fields_label as $field_toshow)

 							{

-								$labeltoshow.= $obj->$field_toshow.' ';

+								$labeltoshow .= $obj->$field_toshow.' ';

 							}

 						}

 						else

 						{

-							$labeltoshow=$obj->{$InfoFieldList[1]};

+							$labeltoshow = $obj->{$InfoFieldList[1]};

 						}

-						$labeltoshow=dol_trunc($labeltoshow,45);

+						$labeltoshow = dol_trunc($labeltoshow, 45);

 

 						if ($value == $obj->rowid)

 						{

 							foreach ($fields_label as $field_toshow)

 							{

-								$translabel=$langs->trans($obj->$field_toshow);

-								if ($translabel!=$obj->$field_toshow) {

-									$labeltoshow=dol_trunc($translabel,18).' ';

-								}else {

-									$labeltoshow=dol_trunc($obj->$field_toshow,18).' ';

+								$translabel = $langs->trans($obj->$field_toshow);

+								if ($translabel != $obj->$field_toshow) {

+									$labeltoshow = dol_trunc($translabel, 18).' ';

+								} else {

+									$labeltoshow = dol_trunc($obj->$field_toshow, 18).' ';

 								}

 							}

-							$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

+							$out .= '<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

 						}

 						else

 						{

-							if (! $notrans)

+							if (!$notrans)

 							{

-								$translabel=$langs->trans($obj->{$InfoFieldList[1]});

-								if ($translabel!=$obj->{$InfoFieldList[1]}) {

-									$labeltoshow=dol_trunc($translabel,18);

+								$translabel = $langs->trans($obj->{$InfoFieldList[1]});

+								if ($translabel != $obj->{$InfoFieldList[1]}) {

+									$labeltoshow = dol_trunc($translabel, 18);

 								}

 								else {

-									$labeltoshow=dol_trunc($obj->{$InfoFieldList[1]},18);

+									$labeltoshow = dol_trunc($obj->{$InfoFieldList[1]},18);

 								}

 							}

-							if (empty($labeltoshow)) $labeltoshow='(not defined)';

-							if ($value==$obj->rowid)

+							if (empty($labeltoshow)) $labeltoshow = '(not defined)';

+							if ($value == $obj->rowid)

 							{

-								$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

+								$out .= '<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

 							}

 

 							if (!empty($InfoFieldList[3]) && $parentField)

@@ -5625,10 +5625,10 @@ 
 								$parent = $parentName.':'.$obj->{$parentField};

 							}

 

-							$out.='<option value="'.$obj->rowid.'"';

-							$out.= ($value==$obj->rowid?' selected':'');

-							$out.= (!empty($parent)?' parent="'.$parent.'"':'');

-							$out.='>'.$labeltoshow.'</option>';

+							$out .= '<option value="'.$obj->rowid.'"';

+							$out .= ($value == $obj->rowid ? ' selected' : '');

+							$out .= (!empty($parent) ? ' parent="'.$parent.'"' : '');

+							$out .= '>'.$labeltoshow.'</option>';

 						}

 

 						$i++;

@@ -5639,23 +5639,23 @@ 
 					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';

 				}

 			}

-			$out.='</select>';

+			$out .= '</select>';

 		}

 		elseif ($type == 'checkbox')

 		{

-			$value_arr=explode(',',$value);

-			$out=$form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options'])?null:$param['options']), $value_arr, '', 0, '', 0, '100%');

+			$value_arr = explode(',', $value);

+			$out = $form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options']) ?null:$param['options']), $value_arr, '', 0, '', 0, '100%');

 		}

 		elseif ($type == 'radio')

 		{

-			$out='';

+			$out = '';

 			foreach ($param['options'] as $keyopt => $val)

 			{

-				$out.='<input class="flat '.$morecss.'" type="radio" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'');

-				$out.=' value="'.$keyopt.'"';

-				$out.=' id="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'"';

-				$out.= ($value==$keyopt?'checked':'');

-				$out.='/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';

+				$out .= '<input class="flat '.$morecss.'" type="radio" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam ? $moreparam : '');

+				$out .= ' value="'.$keyopt.'"';

+				$out .= ' id="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'"';

+				$out .= ($value == $keyopt ? 'checked' : '');

+				$out .= '/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';

 			}

 		}

 		elseif ($type == 'chkbxlst')

@@ -5670,24 +5670,24 @@ 
 			if (is_array($param['options'])) {

 				$param_list = array_keys($param['options']);

 				$InfoFieldList = explode(":", $param_list[0]);

-				$parentName='';

-				$parentField='';

+				$parentName = '';

+				$parentField = '';

 				// 0 : tableName

 				// 1 : label field name

 				// 2 : key fields name (if differ of rowid)

 				// 3 : key field parent (for dependent lists)

 				// 4 : where clause filter on column or table extrafield, syntax field='value' or extra.field=value

-				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2] . ' as rowid');

+				$keyList = (empty($InfoFieldList[2]) ? 'rowid' : $InfoFieldList[2].' as rowid');

 

-				if (count($InfoFieldList) > 3 && ! empty($InfoFieldList[3])) {

-					list ( $parentName, $parentField ) = explode('|', $InfoFieldList[3]);

-					$keyList .= ', ' . $parentField;

+				if (count($InfoFieldList) > 3 && !empty($InfoFieldList[3])) {

+					list ($parentName, $parentField) = explode('|', $InfoFieldList[3]);

+					$keyList .= ', '.$parentField;

 				}

-				if (count($InfoFieldList) > 4 && ! empty($InfoFieldList[4])) {

+				if (count($InfoFieldList) > 4 && !empty($InfoFieldList[4])) {

 					if (strpos($InfoFieldList[4], 'extra.') !== false) {

-						$keyList = 'main.' . $InfoFieldList[2] . ' as rowid';

+						$keyList = 'main.'.$InfoFieldList[2].' as rowid';

 					} else {

-						$keyList = $InfoFieldList[2] . ' as rowid';

+						$keyList = $InfoFieldList[2].' as rowid';

 					}

 				}

 

@@ -5698,50 +5698,50 @@ 
 				}

 

 				$sqlwhere = '';

-				$sql = 'SELECT ' . $keyList;

-				$sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];

-				if (! empty($InfoFieldList[4])) {

+				$sql = 'SELECT '.$keyList;

+				$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];

+				if (!empty($InfoFieldList[4])) {

 

 					// can use SELECT request

-					if (strpos($InfoFieldList[4], '$SEL$')!==false) {

-						$InfoFieldList[4]=str_replace('$SEL$','SELECT',$InfoFieldList[4]);

+					if (strpos($InfoFieldList[4], '$SEL$') !== false) {

+						$InfoFieldList[4] = str_replace('$SEL$', 'SELECT', $InfoFieldList[4]);

 					}

 

 					// current object id can be use into filter

-					if (strpos($InfoFieldList[4], '$ID$')!==false && !empty($objectid)) {

-						$InfoFieldList[4]=str_replace('$ID$',$objectid,$InfoFieldList[4]);

+					if (strpos($InfoFieldList[4], '$ID$') !== false && !empty($objectid)) {

+						$InfoFieldList[4] = str_replace('$ID$', $objectid, $InfoFieldList[4]);

 					} else {

-						$InfoFieldList[4]=str_replace('$ID$','0',$InfoFieldList[4]);

+						$InfoFieldList[4] = str_replace('$ID$', '0', $InfoFieldList[4]);

 					}

 

 					// We have to join on extrafield table

 					if (strpos($InfoFieldList[4], 'extra') !== false) {

-						$sql .= ' as main, ' . MAIN_DB_PREFIX . $InfoFieldList[0] . '_extrafields as extra';

-						$sqlwhere .= ' WHERE extra.fk_object=main.' . $InfoFieldList[2] . ' AND ' . $InfoFieldList[4];

+						$sql .= ' as main, '.MAIN_DB_PREFIX.$InfoFieldList[0].'_extrafields as extra';

+						$sqlwhere .= ' WHERE extra.fk_object=main.'.$InfoFieldList[2].' AND '.$InfoFieldList[4];

 					} else {

-						$sqlwhere .= ' WHERE ' . $InfoFieldList[4];

+						$sqlwhere .= ' WHERE '.$InfoFieldList[4];

 					}

 				} else {

 					$sqlwhere .= ' WHERE 1=1';

 				}

 				// Some tables may have field, some other not. For the moment we disable it.

-				if (in_array($InfoFieldList[0], array ('tablewithentity')))

+				if (in_array($InfoFieldList[0], array('tablewithentity')))

 				{

-					$sqlwhere .= ' AND entity = ' . $conf->entity;

+					$sqlwhere .= ' AND entity = '.$conf->entity;

 				}

 				// $sql.=preg_replace('/^ AND /','',$sqlwhere);

 				// print $sql;

 

 				$sql .= $sqlwhere;

-				dol_syslog(get_class($this) . '::showInputField type=chkbxlst',LOG_DEBUG);

+				dol_syslog(get_class($this).'::showInputField type=chkbxlst', LOG_DEBUG);

 				$resql = $this->db->query($sql);

 				if ($resql) {

 					$num = $this->db->num_rows($resql);

 					$i = 0;

 

-					$data=array();

+					$data = array();

 

-					while ( $i < $num ) {

+					while ($i < $num) {

 						$labeltoshow = '';

 						$obj = $this->db->fetch_object($resql);

 

@@ -5750,8 +5750,8 @@ 
 						$fields_label = explode('|', $InfoFieldList[1]);

 						if (is_array($fields_label)) {

 							$notrans = true;

-							foreach ( $fields_label as $field_toshow ) {

-								$labeltoshow .= $obj->$field_toshow . ' ';

+							foreach ($fields_label as $field_toshow) {

+								$labeltoshow .= $obj->$field_toshow.' ';

 							}

 						} else {

 							$labeltoshow = $obj->{$InfoFieldList[1]};

@@ -5759,18 +5759,18 @@ 
 						$labeltoshow = dol_trunc($labeltoshow, 45);

 

 						if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

-							foreach ( $fields_label as $field_toshow ) {

+							foreach ($fields_label as $field_toshow) {

 								$translabel = $langs->trans($obj->$field_toshow);

 								if ($translabel != $obj->$field_toshow) {

-									$labeltoshow = dol_trunc($translabel, 18) . ' ';

+									$labeltoshow = dol_trunc($translabel, 18).' ';

 								} else {

-									$labeltoshow = dol_trunc($obj->$field_toshow, 18) . ' ';

+									$labeltoshow = dol_trunc($obj->$field_toshow, 18).' ';

 								}

 							}

 

-							$data[$obj->rowid]=$labeltoshow;

+							$data[$obj->rowid] = $labeltoshow;

 						} else {

-							if (! $notrans) {

+							if (!$notrans) {

 								$translabel = $langs->trans($obj->{$InfoFieldList[1]});

 								if ($translabel != $obj->{$InfoFieldList[1]}) {

 									$labeltoshow = dol_trunc($translabel, 18);

@@ -5782,67 +5782,67 @@ 
 								$labeltoshow = '(not defined)';

 

 								if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

-									$data[$obj->rowid]=$labeltoshow;

+									$data[$obj->rowid] = $labeltoshow;

 								}

 

-								if (! empty($InfoFieldList[3]) && $parentField) {

-									$parent = $parentName . ':' . $obj->{$parentField};

+								if (!empty($InfoFieldList[3]) && $parentField) {

+									$parent = $parentName.':'.$obj->{$parentField};

 								}

 

-								$data[$obj->rowid]=$labeltoshow;

+								$data[$obj->rowid] = $labeltoshow;

 						}

 

-						$i ++;

+						$i++;

 					}

 					$this->db->free($resql);

 

-					$out=$form->multiselectarray($keyprefix.$key.$keysuffix, $data, $value_arr, '', 0, '', 0, '100%');

+					$out = $form->multiselectarray($keyprefix.$key.$keysuffix, $data, $value_arr, '', 0, '', 0, '100%');

 				} else {

-					print 'Error in request ' . $sql . ' ' . $this->db->lasterror() . '. Check setup of extra parameters.<br>';

+					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';

 				}

 			}

 		}

 		elseif ($type == 'link')

 		{

-			$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

-			$showempty=(($required && $default != '')?0:1);

-			$out=$form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);

+			$param_list = array_keys($param['options']); // $param_list='ObjectName:classPath'

+			$showempty = (($required && $default != '') ? 0 : 1);

+			$out = $form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);

 			if ($conf->global->MAIN_FEATURES_LEVEL >= 2)

 			{

-            			list($class,$classfile)=explode(':',$param_list[0]);

-            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);

-            			else $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);

-            			$out.='<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';

+            			list($class, $classfile) = explode(':', $param_list[0]);

+            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path = dol_buildpath(dirname(dirname($classfile)).'/card.php', 1);

+            			else $url_path = dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php', 1);

+            			$out .= '<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';

             			// TODO Add Javascript code to add input fields contents to new elements urls

 			}

 		}

 		elseif ($type == 'password')

 		{

 			// If prefix is 'search_', field is used as a filter, we use a common text field.

-			$out='<input type="'.($keyprefix=='search_'?'text':'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'>';

+			$out = '<input type="'.($keyprefix == 'search_' ? 'text' : 'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam ? $moreparam : '').'>';

 		}

 		elseif ($type == 'array')

 		{

 			$newval = $val;

 			$newval['type'] = 'varchar(256)';

 

-			$out='';

+			$out = '';

 

 			$inputs = array();

-			if(! empty($value)) {

-				foreach($value as $option) {

-					$out.= '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

-					$out.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', $option, $moreparam, '', '', $showsize).'<br></span>';

+			if (!empty($value)) {

+				foreach ($value as $option) {

+					$out .= '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

+					$out .= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', $option, $moreparam, '', '', $showsize).'<br></span>';

 				}

 			}

 

-			$out.= '<a id="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_add" href="javascript:;"><span class="fa fa-plus-circle valignmiddle"></span></a>';

+			$out .= '<a id="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_add" href="javascript:;"><span class="fa fa-plus-circle valignmiddle"></span></a>';

 

 			$newInput = '<span><a class="'.dol_escape_htmltag($keyprefix.$key.$keysuffix).'_del" href="javascript:;"><span class="fa fa-minus-circle valignmiddle"></span></a> ';

-			$newInput.= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', '', $moreparam, '', '', $showsize).'<br></span>';

+			$newInput .= $this->showInputField($newval, $keyprefix.$key.$keysuffix.'[]', '', $moreparam, '', '', $showsize).'<br></span>';

 

-			if(! empty($conf->use_javascript_ajax)) {

-				$out.= '

+			if (!empty($conf->use_javascript_ajax)) {

+				$out .= '

 					<script type="text/javascript">

 					$(document).ready(function() {

 						$("a#'.dol_escape_js($keyprefix.$key.$keysuffix).'_add").click(function() {

@@ -5857,7 +5857,7 @@ 
 			}

 		}

 		if (!empty($hidden)) {

-			$out='<input type="hidden" value="'.$value.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'"/>';

+			$out = '<input type="hidden" value="'.$value.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'"/>';

 		}

 		/* Add comments

 		 if ($type == 'date') $out.=' (YYYY-MM-DD)';

@@ -5879,14 +5879,14 @@ 
 	 * @param  mixed   $showsize       Value for css to define size. May also be a numeric.

 	 * @return string

 	 */

-	function showOutputField($val, $key, $value, $moreparam='', $keysuffix='', $keyprefix='', $showsize=0)

+	function showOutputField($val, $key, $value, $moreparam = '', $keysuffix = '', $keyprefix = '', $showsize = 0)

 	{

-		global $conf,$langs,$form;

+		global $conf, $langs, $form;

 

-		if (! is_object($form))

+		if (!is_object($form))

 		{

 			require_once DOL_DOCUMENT_ROOT.'/core/class/html.form.class.php';

-			$form=new Form($this->db);

+			$form = new Form($this->db);

 		}

 

 		$objectid = $this->id;

@@ -5897,28 +5897,28 @@ 
 		// Convert var to be able to share same code than showOutputField of extrafields

 		if (preg_match('/varchar\((\d+)\)/', $type, $reg))

 		{

-			$type = 'varchar';		// convert varchar(xx) int varchar

+			$type = 'varchar'; // convert varchar(xx) int varchar

 			$size = $reg[1];

 		}

-		elseif (preg_match('/varchar/', $type)) $type = 'varchar';		// convert varchar(xx) int varchar

-		if (is_array($val['arrayofkeyval'])) $type='select';

-		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type='link';

+		elseif (preg_match('/varchar/', $type)) $type = 'varchar'; // convert varchar(xx) int varchar

+		if (is_array($val['arrayofkeyval'])) $type = 'select';

+		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type = 'link';

 

-		$default=$val['default'];

-		$computed=$val['computed'];

-		$unique=$val['unique'];

-		$required=$val['required'];

-		$param=$val['param'];

+		$default = $val['default'];

+		$computed = $val['computed'];

+		$unique = $val['unique'];

+		$required = $val['required'];

+		$param = $val['param'];

 		if (is_array($val['arrayofkeyval'])) $param['options'] = $val['arrayofkeyval'];

 		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg))

 		{

-			$type='link';

-			$param['options']=array($reg[1].':'.$reg[2]=>$reg[1].':'.$reg[2]);

+			$type = 'link';

+			$param['options'] = array($reg[1].':'.$reg[2]=>$reg[1].':'.$reg[2]);

 		}

-		$langfile=$val['langfile'];

-		$list=$val['list'];

-		$help=$val['help'];

-		$hidden=(($val['visible'] == 0) ? 1 : 0);			// If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)

+		$langfile = $val['langfile'];

+		$list = $val['list'];

+		$help = $val['help'];

+		$hidden = (($val['visible'] == 0) ? 1 : 0); // If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)

 

 		if ($hidden) return '';

 

@@ -5942,18 +5942,18 @@ 
 				//$showsize=19;

 				$showsize = 'minwidth200imp';

 			}

-			elseif (in_array($type,array('int','double','price')))

+			elseif (in_array($type, array('int', 'double', 'price')))

 			{

 				//$showsize=10;

 				$showsize = 'maxwidth75';

 			}

 			elseif ($type == 'url')

 			{

-				$showsize='minwidth400';

+				$showsize = 'minwidth400';

 			}

 			elseif ($type == 'boolean')

 			{

-				$showsize='';

+				$showsize = '';

 			}

 			else

 			{

@@ -5974,90 +5974,90 @@ 
 		}

 

 		// Format output value differently according to properties of field

-		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value=$this->getNomUrl(1, '', 0, '', 1);

-		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value=$this->getLibStatut(3);

+		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value = $this->getNomUrl(1, '', 0, '', 1);

+		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value = $this->getLibStatut(3);

 		elseif ($type == 'date')

 		{

-			if(! empty($value)) {

-				$value=dol_print_date($value,'day');

+			if (!empty($value)) {

+				$value = dol_print_date($value, 'day');

 			} else {

-				$value='';

+				$value = '';

 			}

 		}

 		elseif ($type == 'datetime')

 		{

-			if(! empty($value)) {

-				$value=dol_print_date($value,'dayhour');

+			if (!empty($value)) {

+				$value = dol_print_date($value, 'dayhour');

 			} else {

-				$value='';

+				$value = '';

 			}

 		}

 		elseif ($type == 'double')

 		{

 			if (!empty($value)) {

-				$value=price($value);

+				$value = price($value);

 			}

 		}

 		elseif ($type == 'boolean')

 		{

-			$checked='';

+			$checked = '';

 			if (!empty($value)) {

-				$checked=' checked ';

+				$checked = ' checked ';

 			}

-			$value='<input type="checkbox" '.$checked.' '.($moreparam?$moreparam:'').' readonly disabled>';

+			$value = '<input type="checkbox" '.$checked.' '.($moreparam ? $moreparam : '').' readonly disabled>';

 		}

 		elseif ($type == 'mail')

 		{

-			$value=dol_print_email($value,0,0,0,64,1,1);

+			$value = dol_print_email($value, 0, 0, 0, 64, 1, 1);

 		}

 		elseif ($type == 'url')

 		{

-			$value=dol_print_url($value,'_blank',32,1);

+			$value = dol_print_url($value, '_blank', 32, 1);

 		}

 		elseif ($type == 'phone')

 		{

-			$value=dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);

+			$value = dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);

 		}

 		elseif ($type == 'price')

 		{

-			$value=price($value,0,$langs,0,0,-1,$conf->currency);

+			$value = price($value, 0, $langs, 0, 0, -1, $conf->currency);

 		}

 		elseif ($type == 'select')

 		{

-			$value=$param['options'][$value];

+			$value = $param['options'][$value];

 		}

 		elseif ($type == 'sellist')

 		{

-			$param_list=array_keys($param['options']);

+			$param_list = array_keys($param['options']);

 			$InfoFieldList = explode(":", $param_list[0]);

 

-			$selectkey="rowid";

-			$keyList='rowid';

+			$selectkey = "rowid";

+			$keyList = 'rowid';

 

-			if (count($InfoFieldList)>=3)

+			if (count($InfoFieldList) >= 3)

 			{

 				$selectkey = $InfoFieldList[2];

-				$keyList=$InfoFieldList[2].' as rowid';

+				$keyList = $InfoFieldList[2].' as rowid';

 			}

 

-			$fields_label = explode('|',$InfoFieldList[1]);

-			if(is_array($fields_label)) {

-				$keyList .=', ';

+			$fields_label = explode('|', $InfoFieldList[1]);

+			if (is_array($fields_label)) {

+				$keyList .= ', ';

 				$keyList .= implode(', ', $fields_label);

 			}

 

 			$sql = 'SELECT '.$keyList;

-			$sql.= ' FROM '.MAIN_DB_PREFIX .$InfoFieldList[0];

-			if (strpos($InfoFieldList[4], 'extra')!==false)

+			$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];

+			if (strpos($InfoFieldList[4], 'extra') !== false)

 			{

-				$sql.= ' as main';

+				$sql .= ' as main';

 			}

-			if ($selectkey=='rowid' && empty($value)) {

-				$sql.= " WHERE ".$selectkey."=0";

-			} elseif ($selectkey=='rowid') {

-				$sql.= " WHERE ".$selectkey."=".$this->db->escape($value);

-			}else {

-				$sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

+			if ($selectkey == 'rowid' && empty($value)) {

+				$sql .= " WHERE ".$selectkey."=0";

+			} elseif ($selectkey == 'rowid') {

+				$sql .= " WHERE ".$selectkey."=".$this->db->escape($value);

+			} else {

+				$sql .= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

 			}

 

 			//$sql.= ' AND entity = '.$conf->entity;

@@ -6066,38 +6066,38 @@ 
 			$resql = $this->db->query($sql);

 			if ($resql)

 			{

-				$value='';	// value was used, so now we reste it to use it to build final output

+				$value = ''; // value was used, so now we reste it to use it to build final output

 

 				$obj = $this->db->fetch_object($resql);

 

 				// Several field into label (eq table:code|libelle:rowid)

-				$fields_label = explode('|',$InfoFieldList[1]);

+				$fields_label = explode('|', $InfoFieldList[1]);

 

-				if(is_array($fields_label) && count($fields_label)>1)

+				if (is_array($fields_label) && count($fields_label) > 1)

 				{

 					foreach ($fields_label as $field_toshow)

 					{

-						$translabel='';

+						$translabel = '';

 						if (!empty($obj->$field_toshow)) {

-							$translabel=$langs->trans($obj->$field_toshow);

+							$translabel = $langs->trans($obj->$field_toshow);

 						}

-						if ($translabel!=$field_toshow) {

-							$value.=dol_trunc($translabel,18).' ';

-						}else {

-							$value.=$obj->$field_toshow.' ';

+						if ($translabel != $field_toshow) {

+							$value .= dol_trunc($translabel, 18).' ';

+						} else {

+							$value .= $obj->$field_toshow.' ';

 						}

 					}

 				}

 				else

 				{

-					$translabel='';

+					$translabel = '';

 					if (!empty($obj->{$InfoFieldList[1]})) {

-						$translabel=$langs->trans($obj->{$InfoFieldList[1]});

+						$translabel = $langs->trans($obj->{$InfoFieldList[1]});

 					}

-					if ($translabel!=$obj->{$InfoFieldList[1]}) {

-						$value=dol_trunc($translabel,18);

-					}else {

-						$value=$obj->{$InfoFieldList[1]};

+					if ($translabel != $obj->{$InfoFieldList[1]}) {

+						$value = dol_trunc($translabel, 18);

+					} else {

+						$value = $obj->{$InfoFieldList[1]};

 					}

 				}

 			}

@@ -6105,18 +6105,18 @@ 
 		}

 		elseif ($type == 'radio')

 		{

-			$value=$param['options'][$value];

+			$value = $param['options'][$value];

 		}

 		elseif ($type == 'checkbox')

 		{

-			$value_arr=explode(',',$value);

-			$value='';

-			if (is_array($value_arr) && count($value_arr)>0)

+			$value_arr = explode(',', $value);

+			$value = '';

+			if (is_array($value_arr) && count($value_arr) > 0)

 			{

 				foreach ($value_arr as $keyval=>$valueval) {

-					$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$param['options'][$valueval].'</li>';

+					$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$param['options'][$valueval].'</li>';

 				}

-				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

+				$value = '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

 			}

 		}

 		elseif ($type == 'chkbxlst')

@@ -6131,7 +6131,7 @@ 
 

 			if (count($InfoFieldList) >= 3) {

 				$selectkey = $InfoFieldList[2];

-				$keyList = $InfoFieldList[2] . ' as rowid';

+				$keyList = $InfoFieldList[2].' as rowid';

 			}

 

 			$fields_label = explode('|', $InfoFieldList[1]);

@@ -6140,75 +6140,75 @@ 
 				$keyList .= implode(', ', $fields_label);

 			}

 

-			$sql = 'SELECT ' . $keyList;

-			$sql .= ' FROM ' . MAIN_DB_PREFIX . $InfoFieldList[0];

+			$sql = 'SELECT '.$keyList;

+			$sql .= ' FROM '.MAIN_DB_PREFIX.$InfoFieldList[0];

 			if (strpos($InfoFieldList[4], 'extra') !== false) {

 				$sql .= ' as main';

 			}

 			// $sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

 			// $sql.= ' AND entity = '.$conf->entity;

 

-			dol_syslog(get_class($this) . ':showOutputField:$type=chkbxlst',LOG_DEBUG);

+			dol_syslog(get_class($this).':showOutputField:$type=chkbxlst', LOG_DEBUG);

 			$resql = $this->db->query($sql);

 			if ($resql) {

 				$value = ''; // value was used, so now we reste it to use it to build final output

-				$toprint=array();

-				while ( $obj = $this->db->fetch_object($resql) ) {

+				$toprint = array();

+				while ($obj = $this->db->fetch_object($resql)) {

 

 					// Several field into label (eq table:code|libelle:rowid)

 					$fields_label = explode('|', $InfoFieldList[1]);

 					if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

 						if (is_array($fields_label) && count($fields_label) > 1) {

-							foreach ( $fields_label as $field_toshow ) {

+							foreach ($fields_label as $field_toshow) {

 								$translabel = '';

-								if (! empty($obj->$field_toshow)) {

+								if (!empty($obj->$field_toshow)) {

 									$translabel = $langs->trans($obj->$field_toshow);

 								}

 								if ($translabel != $field_toshow) {

-									$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

+									$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

 								} else {

-									$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->$field_toshow.'</li>';

+									$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->$field_toshow.'</li>';

 								}

 							}

 						} else {

 							$translabel = '';

-							if (! empty($obj->{$InfoFieldList[1]})) {

+							if (!empty($obj->{$InfoFieldList[1]})) {

 								$translabel = $langs->trans($obj->{$InfoFieldList[1]});

 							}

 							if ($translabel != $obj->{$InfoFieldList[1]}) {

-								$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

+								$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.dol_trunc($translabel, 18).'</li>';

 							} else {

-								$toprint[]='<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->{$InfoFieldList[1]}.'</li>';

+								$toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories" style="background: #aaa">'.$obj->{$InfoFieldList[1]}.'</li>';

 							}

 						}

 					}

 				}

-				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

+				$value = '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

 			} else {

-				dol_syslog(get_class($this) . '::showOutputField error ' . $this->db->lasterror(), LOG_WARNING);

+				dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);

 			}

 		}

 		elseif ($type == 'link')

 		{

-			$out='';

+			$out = '';

 

 			// only if something to display (perf)

 			if ($value)

 			{

-				$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

+				$param_list = array_keys($param['options']); // $param_list='ObjectName:classPath'

 

 				$InfoFieldList = explode(":", $param_list[0]);

-				$classname=$InfoFieldList[0];

-				$classpath=$InfoFieldList[1];

-				$getnomurlparam=(empty($InfoFieldList[2]) ? 3 : $InfoFieldList[2]);

-				if (! empty($classpath))

+				$classname = $InfoFieldList[0];

+				$classpath = $InfoFieldList[1];

+				$getnomurlparam = (empty($InfoFieldList[2]) ? 3 : $InfoFieldList[2]);

+				if (!empty($classpath))

 				{

 					dol_include_once($InfoFieldList[1]);

 					if ($classname && class_exists($classname))

 					{

 						$object = new $classname($this->db);

 						$object->fetch($value);

-						$value=$object->getNomUrl($getnomurlparam);

+						$value = $object->getNomUrl($getnomurlparam);

 					}

 				}

 				else

@@ -6217,15 +6217,15 @@ 
 					return 'Error bad setup of extrafield';

 				}

 			}

-			else $value='';

+			else $value = '';

 		}

 		elseif ($type == 'text' || $type == 'html')

 		{

-			$value=dol_htmlentitiesbr($value);

+			$value = dol_htmlentitiesbr($value);

 		}

 		elseif ($type == 'password')

 		{

-			$value=preg_replace('/./i','*',$value);

+			$value = preg_replace('/./i', '*', $value);

 		}

 		elseif ($type == 'array')

 		{

@@ -6233,7 +6233,7 @@ 
 		}

 

 		//print $type.'-'.$size;

-		$out=$value;

+		$out = $value;

 

 		return $out;

 	}

@@ -6250,11 +6250,11 @@ 
 	 * @param	string		$onetrtd		All fields in same tr td

 	 * @return 	string

 	 */

-	function showOptionals($extrafields, $mode='view', $params=null, $keysuffix='', $keyprefix='', $onetrtd=0)

+	function showOptionals($extrafields, $mode = 'view', $params = null, $keysuffix = '', $keyprefix = '', $onetrtd = 0)

 	{

 		global $db, $conf, $langs, $action, $form;

 

-		if (! is_object($form)) $form=new Form($db);

+		if (!is_object($form)) $form = new Form($db);

 

 		$out = '';

 

@@ -6265,10 +6265,10 @@ 
 			$out .= "\n";

 

 			$e = 0;

-			foreach($extrafields->attributes[$this->table_element]['label'] as $key=>$label)

+			foreach ($extrafields->attributes[$this->table_element]['label'] as $key=>$label)

 			{

 				// Show only the key field in params

-				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) continue;

+				if (is_array($params) && array_key_exists('onlykey', $params) && $key != $params['onlykey']) continue;

 

 				$enabled = 1;

 				if ($enabled && isset($extrafields->attributes[$this->table_element]['list'][$key]))

@@ -6282,25 +6282,25 @@ 
 					$perms = dol_eval($extrafields->attributes[$this->table_element]['perms'][$key], 1);

 				}

 

-				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue;	// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

+				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue; // <> -1 and <> 1 and <> 3 = not visible on forms, only on list

 				if (empty($perms)) continue;

 

 				// Load language if required

-				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);

+				if (!empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);

 

-				$colspan='3';

-				if (is_array($params) && count($params)>0) {

-					if (array_key_exists('colspan',$params)) {

-						$colspan=$params['colspan'];

+				$colspan = '3';

+				if (is_array($params) && count($params) > 0) {

+					if (array_key_exists('colspan', $params)) {

+						$colspan = $params['colspan'];

 					}

 				}

 

-				switch($mode) {

+				switch ($mode) {

 					case "view":

-						$value=$this->array_options["options_".$key.$keysuffix];

+						$value = $this->array_options["options_".$key.$keysuffix];

 						break;

 					case "edit":

-						$getposttemp = GETPOST($keyprefix.'options_'.$key.$keysuffix, 'none');				// GETPOST can get value from GET, POST or setup of default values.

+						$getposttemp = GETPOST($keyprefix.'options_'.$key.$keysuffix, 'none'); // GETPOST can get value from GET, POST or setup of default values.

 						// GETPOST("options_" . $key) can be 'abc' or array(0=>'abc')

 						if (is_array($getposttemp) || $getposttemp != '' || GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix))

 						{

@@ -6311,7 +6311,7 @@ 
 								$value = $getposttemp;

 							}

 						} else {

-							$value = $this->array_options["options_" . $key];			// No GET, no POST, no default value, so we take value of object.

+							$value = $this->array_options["options_".$key]; // No GET, no POST, no default value, so we take value of object.

 						}

 						//var_dump($keyprefix.' - '.$key.' - '.$keysuffix.' - '.$keyprefix.'options_'.$key.$keysuffix.' - '.$this->array_options["options_".$key.$keysuffix].' - '.$getposttemp.' - '.$value);

 						break;

@@ -6323,11 +6323,11 @@ 
 				}

 				else

 				{

-					$csstyle='';

-					$class=(!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');

-					if (is_array($params) && count($params)>0) {

-						if (array_key_exists('style',$params)) {

-							$csstyle=$params['style'];

+					$csstyle = '';

+					$class = (!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');

+					if (is_array($params) && count($params) > 0) {

+						if (array_key_exists('style', $params)) {

+							$csstyle = $params['style'];

 						}

 					}

 

@@ -6340,43 +6340,43 @@ 
 

 					$out .= '<tr id="'.$html_id.'" '.$csstyle.' class="'.$class.$this->element.'_extras_'.$key.'" '.$domData.' >';

 

-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0)

+					if (!empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0)

 					{

-						if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0) { $colspan='0'; }

+						if (!empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && ($e % 2) == 0) { $colspan = '0'; }

 					}

 

 					if ($action == 'selectlines') { $colspan++; }

 

 					// Convert date into timestamp format (value in memory must be a timestamp)

-					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('date','datetime')))

+					if (in_array($extrafields->attributes[$this->table_element]['type'][$key], array('date', 'datetime')))

 					{

-						$datenotinstring = $this->array_options['options_' . $key];

-						if (! is_numeric($this->array_options['options_' . $key]))	// For backward compatibility

+						$datenotinstring = $this->array_options['options_'.$key];

+						if (!is_numeric($this->array_options['options_'.$key]))	// For backward compatibility

 						{

 							$datenotinstring = $this->db->jdate($datenotinstring);

 						}

-						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min",'int',3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year",'int',3)):$datenotinstring;

+						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix) ?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min", 'int', 3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year", 'int', 3)) : $datenotinstring;

 					}

 					// Convert float submited string into real php numeric (value in memory must be a php numeric)

-					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('price','double')))

+					if (in_array($extrafields->attributes[$this->table_element]['type'][$key], array('price', 'double')))

 					{

-						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?price2num(GETPOST($keyprefix.'options_'.$key.$keysuffix, 'alpha', 3)):$this->array_options['options_'.$key];

+						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix) ?price2num(GETPOST($keyprefix.'options_'.$key.$keysuffix, 'alpha', 3)) : $this->array_options['options_'.$key];

 					}

 

 					$labeltoshow = $langs->trans($label);

 

 					$out .= '<td class="titlefield';

-					if (GETPOST('action','none') == 'create') $out.='create';

-					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';

+					if (GETPOST('action', 'none') == 'create') $out .= 'create';

+					if ($mode != 'view' && !empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';

 					$out .= '">';

-					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);

+					if (!empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);

 					else $out .= $labeltoshow;

 					$out .= '</td>';

 

 					$html_id = !empty($this->id) ? $this->element.'_extras_'.$key.'_'.$this->id : '';

-					$out .='<td id="'.$html_id.'" class="'.$this->element.'_extras_'.$key.'" '.($colspan?' colspan="'.$colspan.'"':'').'>';

+					$out .= '<td id="'.$html_id.'" class="'.$this->element.'_extras_'.$key.'" '.($colspan ? ' colspan="'.$colspan.'"' : '').'>';

 

-					switch($mode) {

+					switch ($mode) {

 						case "view":

 							$out .= $extrafields->showOutputField($key, $value);

 							break;

@@ -6387,14 +6387,14 @@ 
 

 					$out .= '</td>';

 

-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';

+					if (!empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';

 					else $out .= '</tr>';

 					$e++;

 				}

 			}

 			$out .= "\n";

 			// Add code to manage list depending on others

-			if (! empty($conf->use_javascript_ajax)) {

+			if (!empty($conf->use_javascript_ajax)) {

 				$out .= '

 				<script type="text/javascript">

 				    jQuery(document).ready(function() {

@@ -6440,7 +6440,7 @@ 
 		global $user;

 

 		$element = $this->element;

-		if ($element == 'facturerec') $element='facture';

+		if ($element == 'facturerec') $element = 'facture';

 

 		return $user->rights->{$element};

 	}

@@ -6457,15 +6457,15 @@ 
 	 * @param  int         $ignoreerrors  Ignore errors. Return true even if errors. We need this when replacement can fails like for categories (categorie of old thirdparty may already exists on new one)

 	 * @return bool						  True if success, False if error

 	 */

-	public static function commonReplaceThirdparty(DoliDB $db, $origin_id, $dest_id, array $tables, $ignoreerrors=0)

+	public static function commonReplaceThirdparty(DoliDB $db, $origin_id, $dest_id, array $tables, $ignoreerrors = 0)

 	{

 		foreach ($tables as $table)

 		{

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$table.' SET fk_soc = '.$dest_id.' WHERE fk_soc = '.$origin_id;

 

-			if (! $db->query($sql))

+			if (!$db->query($sql))

 			{

-				if ($ignoreerrors) return true;		// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

+				if ($ignoreerrors) return true; // TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

 				//$this->errors = $db->lasterror();

 				return false;

 			}

@@ -6499,7 +6499,7 @@ 
 		else

 		{

 			// Get cost price for margin calculation

-			if (! empty($fk_product))

+			if (!empty($fk_product))

 			{

 				if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'costprice')

 				{

@@ -6536,7 +6536,7 @@ 
 					}

 				}

 

-				if (empty($buyPrice) && isset($conf->global->MARGIN_TYPE) && in_array($conf->global->MARGIN_TYPE, array('1','pmp','costprice')))

+				if (empty($buyPrice) && isset($conf->global->MARGIN_TYPE) && in_array($conf->global->MARGIN_TYPE, array('1', 'pmp', 'costprice')))

 				{

 					require_once DOL_DOCUMENT_ROOT.'/fourn/class/fournisseur.product.class.php';

 					$productFournisseur = new ProductFournisseur($this->db);

@@ -6573,18 +6573,18 @@ 
 	 *  @param		int		$usesharelink	Use the public shared link of image (if not available, the 'nophoto' image will be shown instead)

 	 *  @return     string					Html code to show photo. Number of photos shown is saved in this->nbphoto

 	 */

-	function show_photos($modulepart, $sdir, $size=0, $nbmax=0, $nbbyrow=5, $showfilename=0, $showaction=0, $maxHeight=120, $maxWidth=160, $nolink=0, $notitle=0, $usesharelink=0)

+	function show_photos($modulepart, $sdir, $size = 0, $nbmax = 0, $nbbyrow = 5, $showfilename = 0, $showaction = 0, $maxHeight = 120, $maxWidth = 160, $nolink = 0, $notitle = 0, $usesharelink = 0)

 	{

         // phpcs:enable

-		global $conf,$user,$langs;

+		global $conf, $user, $langs;

 

-		include_once DOL_DOCUMENT_ROOT .'/core/lib/files.lib.php';

-		include_once DOL_DOCUMENT_ROOT .'/core/lib/images.lib.php';

+		include_once DOL_DOCUMENT_ROOT.'/core/lib/files.lib.php';

+		include_once DOL_DOCUMENT_ROOT.'/core/lib/images.lib.php';

 

-		$sortfield='position_name';

-		$sortorder='asc';

+		$sortfield = 'position_name';

+		$sortorder = 'asc';

 

-		$dir = $sdir . '/';

+		$dir = $sdir.'/';

 		$pdir = '/';

 		if ($modulepart == 'ticket')

 		{

@@ -6598,28 +6598,28 @@ 
 		}

 

 		// For backward compatibility

-		if ($modulepart == 'product' && ! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))

+		if ($modulepart == 'product' && !empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))

 		{

-			$dir = $sdir . '/'. get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";

-			$pdir = '/' . get_exdir($this->id,2,0,0,$this,$modulepart) . $this->id ."/photos/";

+			$dir = $sdir.'/'.get_exdir($this->id, 2, 0, 0, $this, $modulepart).$this->id."/photos/";

+			$pdir = '/'.get_exdir($this->id, 2, 0, 0, $this, $modulepart).$this->id."/photos/";

 		}

 

 		// Defined relative dir to DOL_DATA_ROOT

 		$relativedir = '';

 		if ($dir)

 		{

-			$relativedir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $dir);

-			$relativedir = preg_replace('/^[\\/]/','',$relativedir);

-			$relativedir = preg_replace('/[\\/]$/','',$relativedir);

+			$relativedir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT, '/').'/', '', $dir);

+			$relativedir = preg_replace('/^[\\/]/', '', $relativedir);

+			$relativedir = preg_replace('/[\\/]$/', '', $relativedir);

 		}

 

 		$dirthumb = $dir.'thumbs/';

 		$pdirthumb = $pdir.'thumbs/';

 

-		$return ='<!-- Photo -->'."\n";

-		$nbphoto=0;

+		$return = '<!-- Photo -->'."\n";

+		$nbphoto = 0;

 

-		$filearray=dol_dir_list($dir,"files",0,'','(\.meta|_preview.*\.png)$',$sortfield,(strtolower($sortorder)=='desc'?SORT_DESC:SORT_ASC),1);

+		$filearray = dol_dir_list($dir, "files", 0, '', '(\.meta|_preview.*\.png)$', $sortfield, (strtolower($sortorder) == 'desc' ?SORT_DESC:SORT_ASC), 1);

 

 		/*if (! empty($conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))    // For backward compatiblity, we scan also old dirs

 		 {

@@ -6633,12 +6633,12 @@ 
 		{

 			if ($sortfield && $sortorder)

 			{

-				$filearray=dol_sort_array($filearray, $sortfield, $sortorder);

+				$filearray = dol_sort_array($filearray, $sortfield, $sortorder);

 			}

 

-			foreach($filearray as $key => $val)

+			foreach ($filearray as $key => $val)

 			{

-				$photo='';

+				$photo = '';

 				$file = $val['name'];

 

 				//if (! utf8_check($file)) $file=utf8_encode($file);	// To be sure file is stored in UTF8 in memory

@@ -6653,36 +6653,36 @@ 
 					if ($size == 1 || $size == 'small') {   // Format vignette

 

 						// Find name of thumb file

-						$photo_vignette=basename(getImageFileNameForSize($dir.$file, '_small'));

-						if (! dol_is_file($dirthumb.$photo_vignette)) $photo_vignette='';

+						$photo_vignette = basename(getImageFileNameForSize($dir.$file, '_small'));

+						if (!dol_is_file($dirthumb.$photo_vignette)) $photo_vignette = '';

 

 						// Get filesize of original file

-						$imgarray=dol_getImageSize($dir.$photo);

+						$imgarray = dol_getImageSize($dir.$photo);

 

 						if ($nbbyrow > 0)

 						{

-							if ($nbphoto == 1) $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';

+							if ($nbphoto == 1) $return .= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';

 

-							if ($nbphoto % $nbbyrow == 1) $return.= '<tr align=center valign=middle border=1>';

-							$return.= '<td width="'.ceil(100/$nbbyrow).'%" class="photo">';

+							if ($nbphoto % $nbbyrow == 1) $return .= '<tr align=center valign=middle border=1>';

+							$return .= '<td width="'.ceil(100 / $nbbyrow).'%" class="photo">';

 						}

 						else if ($nbbyrow < 0) $return .= '<div class="inline-block">';

 

-						$return.= "\n";

+						$return .= "\n";

 

-						$relativefile=preg_replace('/^\//', '', $pdir.$photo);

+						$relativefile = preg_replace('/^\//', '', $pdir.$photo);

 						if (empty($nolink))

 						{

-							$urladvanced=getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);

-							if ($urladvanced) $return.='<a href="'.$urladvanced.'">';

-							else $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';

+							$urladvanced = getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);

+							if ($urladvanced) $return .= '<a href="'.$urladvanced.'">';

+							else $return .= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';

 						}

 

 						// Show image (width height=$maxHeight)

 						// Si fichier vignette disponible et image source trop grande, on utilise la vignette, sinon on utilise photo origine

-						$alt=$langs->transnoentitiesnoconv('File').': '.$relativefile;

-						$alt.=' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];

-						if ($notitle) $alt='';

+						$alt = $langs->transnoentitiesnoconv('File').': '.$relativefile;

+						$alt .= ' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];

+						if ($notitle) $alt = '';

 

 						if ($usesharelink)

 						{

@@ -6690,81 +6690,81 @@ 
 							{

 								if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

 								{

-									$return.= '<!-- Show original file (thumb not yet available with shared links) -->';

-									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

+									$return .= '<!-- Show original file (thumb not yet available with shared links) -->';

+									$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

 								}

 								else {

-									$return.= '<!-- Show original file -->';

-									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

+									$return .= '<!-- Show original file -->';

+									$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

 								}

 							}

 							else

 							{

-								$return.= '<!-- Show nophoto file (because file is not shared) -->';

-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';

+								$return .= '<!-- Show nophoto file (because file is not shared) -->';

+								$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';

 							}

 						}

 						else

 						{

 							if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

 							{

-								$return.= '<!-- Show thumb -->';

-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';

+								$return .= '<!-- Show thumb -->';

+								$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';

 							}

 							else {

-								$return.= '<!-- Show original file -->';

-								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';

+								$return .= '<!-- Show original file -->';

+								$return .= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';

 							}

 						}

 

-						if (empty($nolink)) $return.= '</a>';

-						$return.="\n";

+						if (empty($nolink)) $return .= '</a>';

+						$return .= "\n";

 

-						if ($showfilename) $return.= '<br>'.$viewfilename;

+						if ($showfilename) $return .= '<br>'.$viewfilename;

 						if ($showaction)

 						{

-							$return.= '<br>';

+							$return .= '<br>';

 							// On propose la generation de la vignette si elle n'existe pas et si la taille est superieure aux limites

 							if ($photo_vignette && (image_format_supported($photo) > 0) && ($this->imgWidth > $maxWidth || $this->imgHeight > $maxHeight))

 							{

-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=addthumb&amp;file='.urlencode($pdir.$viewfilename).'">'.img_picto($langs->trans('GenerateThumb'),'refresh').'&nbsp;&nbsp;</a>';

+								$return .= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=addthumb&amp;file='.urlencode($pdir.$viewfilename).'">'.img_picto($langs->trans('GenerateThumb'), 'refresh').'&nbsp;&nbsp;</a>';

 							}

 							// Special cas for product

 							if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))

 							{

 								// Link to resize

-								$return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

+								$return .= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

 

 								// Link to delete

-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

-								$return.= img_delete().'</a>';

+								$return .= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

+								$return .= img_delete().'</a>';

 							}

 						}

-						$return.= "\n";

+						$return .= "\n";

 

 						if ($nbbyrow > 0)

 						{

-							$return.= '</td>';

-							if (($nbphoto % $nbbyrow) == 0) $return.= '</tr>';

+							$return .= '</td>';

+							if (($nbphoto % $nbbyrow) == 0) $return .= '</tr>';

 						}

-						else if ($nbbyrow < 0) $return.='</div>';

+						else if ($nbbyrow < 0) $return .= '</div>';

 					}

 

 					if (empty($size)) {     // Format origine

-						$return.= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';

+						$return .= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';

 

-						if ($showfilename) $return.= '<br>'.$viewfilename;

+						if ($showfilename) $return .= '<br>'.$viewfilename;

 						if ($showaction)

 						{

 							// Special case for product

 							if ($modulepart == 'product' && ($user->rights->produit->creer || $user->rights->service->creer))

 							{

 								// Link to resize

-								$return.= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

+								$return .= '<a href="'.DOL_URL_ROOT.'/core/photos_resize.php?modulepart='.urlencode('produit|service').'&id='.$this->id.'&amp;file='.urlencode($pdir.$viewfilename).'" title="'.dol_escape_htmltag($langs->trans("Resize")).'">'.img_picto($langs->trans("Resize"), 'resize', '').'</a> &nbsp; ';

 

 								// Link to delete

-								$return.= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

-								$return.= img_delete().'</a>';

+								$return .= '<a href="'.$_SERVER["PHP_SELF"].'?id='.$this->id.'&amp;action=delete&amp;file='.urlencode($pdir.$viewfilename).'">';

+								$return .= img_delete().'</a>';

 							}

 						}

 					}

@@ -6774,18 +6774,18 @@ 
 				}

 			}

 

-			if ($size==1 || $size=='small')

+			if ($size == 1 || $size == 'small')

 			{

 				if ($nbbyrow > 0)

 				{

 					// Ferme tableau

 					while ($nbphoto % $nbbyrow)

 					{

-						$return.= '<td width="'.ceil(100/$nbbyrow).'%">&nbsp;</td>';

+						$return .= '<td width="'.ceil(100 / $nbbyrow).'%">&nbsp;</td>';

 						$nbphoto++;

 					}

 

-					if ($nbphoto) $return.= '</table>';

+					if ($nbphoto) $return .= '</table>';

 				}

 			}

 		}

@@ -6804,9 +6804,9 @@ 
 	 */

 	protected function isArray($info)

 	{

-		if(is_array($info))

+		if (is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='array') return true;

+			if (isset($info['type']) && $info['type'] == 'array') return true;

 			else return false;

 		}

 		else return false;

@@ -6820,9 +6820,9 @@ 
 	 */

 	protected function isNull($info)

 	{

-		if(is_array($info))

+		if (is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='null') return true;

+			if (isset($info['type']) && $info['type'] == 'null') return true;

 			else return false;

 		}

 		else return false;

@@ -6836,7 +6836,7 @@ 
 	 */

 	public function isDate($info)

 	{

-		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) return true;

+		if (isset($info['type']) && ($info['type'] == 'date' || $info['type'] == 'datetime' || $info['type'] == 'timestamp')) return true;

 		else return false;

 	}

 

@@ -6848,9 +6848,9 @@ 
 	 */

 	public function isInt($info)

 	{

-		if(is_array($info))

+		if (is_array($info))

 		{

-			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) return true;

+			if (isset($info['type']) && ($info['type'] == 'int' || preg_match('/^integer/i', $info['type']))) return true;

 			else return false;

 		}

 		else return false;

@@ -6864,7 +6864,7 @@ 
 	 */

 	public function isFloat($info)

 	{

-		if(is_array($info))

+		if (is_array($info))

 		{

 			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) return true;

 			else return false;

@@ -6880,9 +6880,9 @@ 
 	 */

 	public function isText($info)

 	{

-		if(is_array($info))

+		if (is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='text') return true;

+			if (isset($info['type']) && $info['type'] == 'text') return true;

 			else return false;

 		}

 		else return false;

@@ -6896,9 +6896,9 @@ 
 	 */

 	protected function isIndex($info)

 	{

-		if(is_array($info))

+		if (is_array($info))

 		{

-			if(isset($info['index']) && $info['index']==true) return true;

+			if (isset($info['index']) && $info['index'] == true) return true;

 			else return false;

 		}

 		else return false;

@@ -6914,13 +6914,13 @@ 
 	{

 		global $conf;

 

-		$queryarray=array();

+		$queryarray = array();

 		foreach ($this->fields as $field=>$info)	// Loop on definition of fields

 		{

 			// Depending on field type ('datetime', ...)

-			if($this->isDate($info))

+			if ($this->isDate($info))

 			{

-				if(empty($this->{$field}))

+				if (empty($this->{$field}))

 				{

 					$queryarray[$field] = null;

 				}

@@ -6929,10 +6929,10 @@ 
 					$queryarray[$field] = $this->db->idate($this->{$field});

 				}

 			}

-			else if($this->isArray($info))

+			else if ($this->isArray($info))

 			{

-				if(! empty($this->{$field})) {

-					if(! is_array($this->{$field})) {

+				if (!empty($this->{$field})) {

+					if (!is_array($this->{$field})) {

 						$this->{$field} = array($this->{$field});

 					}

 					$queryarray[$field] = serialize($this->{$field});

@@ -6940,19 +6940,19 @@ 
 					$queryarray[$field] = null;

 				}

 			}

-			else if($this->isInt($info))

+			else if ($this->isInt($info))

 			{

-				if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field]=$conf->entity;

+				if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field] = $conf->entity;

 				else

 				{

 					$queryarray[$field] = (int) price2num($this->{$field});

-					if (empty($queryarray[$field])) $queryarray[$field]=0;		// May be reset to null later if property 'notnull' is -1 for this field.

+					if (empty($queryarray[$field])) $queryarray[$field] = 0; // May be reset to null later if property 'notnull' is -1 for this field.

 				}

 			}

-			else if($this->isFloat($info))

+			else if ($this->isFloat($info))

 			{

 				$queryarray[$field] = (double) price2num($this->{$field});

-				if (empty($queryarray[$field])) $queryarray[$field]=0;

+				if (empty($queryarray[$field])) $queryarray[$field] = 0;

 			}

 			else

 			{

@@ -6960,7 +6960,7 @@ 
 			}

 

 			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) unset($queryarray[$field]);

-			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;

+			if (!empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;

 		}

 

 		return $queryarray;

@@ -6976,35 +6976,35 @@ 
 	{

 		foreach ($this->fields as $field => $info)

 		{

-			if($this->isDate($info))

+			if ($this->isDate($info))

 			{

-				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;

+				if (empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;

 				else $this->{$field} = strtotime($obj->{$field});

 			}

-			elseif($this->isArray($info))

+			elseif ($this->isArray($info))

 			{

-				if(! empty($obj->{$field})) {

+				if (!empty($obj->{$field})) {

 					$this->{$field} = @unserialize($obj->{$field});

 					// Hack for data not in UTF8

-					if($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));

+					if ($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));

 				} else {

 					$this->{$field} = array();

 				}

 			}

-			elseif($this->isInt($info))

+			elseif ($this->isInt($info))

 			{

 				if ($field == 'rowid') $this->id = (int) $obj->{$field};

 				else $this->{$field} = (int) $obj->{$field};

 			}

-			elseif($this->isFloat($info))

+			elseif ($this->isFloat($info))

 			{

 				$this->{$field} = (double) $obj->{$field};

 			}

-			elseif($this->isNull($info))

+			elseif ($this->isNull($info))

 			{

 				$val = $obj->{$field};

 				// zero is not null

-				$this->{$field} = (is_null($val) || (empty($val) && $val!==0 && $val!=='0') ? null : $val);

+				$this->{$field} = (is_null($val) || (empty($val) && $val !== 0 && $val !== '0') ? null : $val);

 			}

 			else

 			{

@@ -7013,7 +7013,7 @@ 
 		}

 

 		// If there is no 'ref' field, we force property ->ref to ->id for a better compatibility with common functions.

-		if (! isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;

+		if (!isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;

 	}

 

 	/**

@@ -7055,14 +7055,14 @@ 
 

 		$error = 0;

 

-		$now=dol_now();

+		$now = dol_now();

 

 		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation']=$this->db->idate($now);

-		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat']=$user->id;

-		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.

+		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation'] = $this->db->idate($now);

+		if (array_key_exists('fk_user_creat', $fieldvalues) && !($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat'] = $user->id;

+		unset($fieldvalues['rowid']); // The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.

 

-		$keys=array();

+		$keys = array();

 		$values = array();

 		foreach ($fieldvalues as $k => $v) {

 			$keys[$k] = $k;

@@ -7071,58 +7071,58 @@ 
 		}

 

 		// Clean and check mandatory

-		foreach($keys as $key)

+		foreach ($keys as $key)

 		{

 			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key] = '';

+			if (!empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key] = '';

 

 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

-			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && ! isset($values[$key]) && is_null($val['default']))

+			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && !isset($values[$key]) && is_null($val['default']))

 			{

 				$error++;

-				$this->errors[]=$langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);

+				$this->errors[] = $langs->trans("ErrorFieldRequired", $this->fields[$key]['label']);

 			}

 

 			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key]='null';

-			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key]='null';

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key] = 'null';

+			if (!empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key] = 'null';

 		}

 

 		if ($error) return -1;

 

 		$this->db->begin();

 

-		if (! $error)

+		if (!$error)

 		{

 			$sql = 'INSERT INTO '.MAIN_DB_PREFIX.$this->table_element;

-			$sql.= ' ('.implode( ", ", $keys ).')';

-			$sql.= ' VALUES ('.implode( ", ", $values ).')';

+			$sql .= ' ('.implode(", ", $keys).')';

+			$sql .= ' VALUES ('.implode(", ", $values).')';

 

 			$res = $this->db->query($sql);

-			if ($res===false) {

+			if ($res === false) {

 				$error++;

 				$this->errors[] = $this->db->lasterror();

 			}

 		}

 

-		if (! $error)

+		if (!$error)

 		{

-			$this->id = $this->db->last_insert_id(MAIN_DB_PREFIX . $this->table_element);

+			$this->id = $this->db->last_insert_id(MAIN_DB_PREFIX.$this->table_element);

 		}

 

 		// Create extrafields

-		if (! $error)

+		if (!$error)

 		{

-			$result=$this->insertExtraFields();

+			$result = $this->insertExtraFields();

 			if ($result < 0) $error++;

 		}

 

 		// Triggers

-		if (! $error && ! $notrigger)

+		if (!$error && !$notrigger)

 		{

 			// Call triggers

-			$result=$this->call_trigger(strtoupper(get_class($this)).'_CREATE',$user);

+			$result = $this->call_trigger(strtoupper(get_class($this)).'_CREATE', $user);

 			if ($result < 0) { $error++; }

 			// End call triggers

 		}

@@ -7151,13 +7151,13 @@ 
 		if (empty($id) && empty($ref) && empty($morewhere)) return -1;

 

 		$sql = 'SELECT '.$this->getFieldList();

-		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element;

+		$sql .= ' FROM '.MAIN_DB_PREFIX.$this->table_element;

 

-		if (!empty($id))  $sql.= ' WHERE rowid = '.$id;

-		elseif (!empty($ref)) $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);

-		else $sql.=' WHERE 1 = 1';	// usage with empty id and empty ref is very rare

-		if ($morewhere)   $sql.= $morewhere;

-		$sql.=' LIMIT 1';	// This is a fetch, to be sure to get only one record

+		if (!empty($id))  $sql .= ' WHERE rowid = '.$id;

+		elseif (!empty($ref)) $sql .= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);

+		else $sql .= ' WHERE 1 = 1'; // usage with empty id and empty ref is very rare

+		if ($morewhere)   $sql .= $morewhere;

+		$sql .= ' LIMIT 1'; // This is a fetch, to be sure to get only one record

 

 		$res = $this->db->query($sql);

 		if ($res)

@@ -7194,14 +7194,14 @@ 
 

 		$error = 0;

 

-		$now=dol_now();

+		$now = dol_now();

 

 		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification']=$this->db->idate($now);

-		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif']=$user->id;

-		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.

+		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification'] = $this->db->idate($now);

+		if (array_key_exists('fk_user_modif', $fieldvalues) && !($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif'] = $user->id;

+		unset($fieldvalues['rowid']); // The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.

 

-		$keys=array();

+		$keys = array();

 		$values = array();

 		foreach ($fieldvalues as $k => $v) {

 			$keys[$k] = $k;

@@ -7211,10 +7211,10 @@ 
 		}

 

 		// Clean and check mandatory

-		foreach($keys as $key)

+		foreach ($keys as $key)

 		{

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';		// This is an implicit foreign key field

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';					// This is an explicit foreign key field

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key] = ''; // This is an implicit foreign key field

+			if (!empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key] = ''; // This is an explicit foreign key field

 

 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

 			/*

@@ -7225,13 +7225,13 @@ 
 			}*/

 		}

 

-		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode( ',', $tmp ).' WHERE rowid='.$this->id ;

+		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element.' SET '.implode(',', $tmp).' WHERE rowid='.$this->id;

 

 		$this->db->begin();

-		if (! $error)

+		if (!$error)

 		{

 			$res = $this->db->query($sql);

-			if ($res===false)

+			if ($res === false)

 			{

 				$error++;

 				$this->errors[] = $this->db->lasterror();

@@ -7239,9 +7239,9 @@ 
 		}

 

 		// Update extrafield

-		if (! $error && empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && is_array($this->array_options) && count($this->array_options)>0)

+		if (!$error && empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && is_array($this->array_options) && count($this->array_options) > 0)

 		{

-			$result=$this->insertExtraFields();

+			$result = $this->insertExtraFields();

 			if ($result < 0)

 			{

 				$error++;

@@ -7249,10 +7249,10 @@ 
 		}

 

 		// Triggers

-		if (! $error && ! $notrigger)

+		if (!$error && !$notrigger)

 		{

 			// Call triggers

-			$result=$this->call_trigger(strtoupper(get_class($this)).'_MODIFY',$user);

+			$result = $this->call_trigger(strtoupper(get_class($this)).'_MODIFY', $user);

 			if ($result < 0) { $error++; } //Do also here what you must do to rollback action if trigger fail

 			// End call triggers

 		}

@@ -7275,68 +7275,68 @@ 
 	 * @param	int		$forcechilddeletion		0=no, 1=Force deletion of children

 	 * @return 	int             				<=0 if KO, >0 if OK

 	 */

-	public function deleteCommon(User $user, $notrigger=false, $forcechilddeletion=0)

+	public function deleteCommon(User $user, $notrigger = false, $forcechilddeletion = 0)

 	{

-		$error=0;

+		$error = 0;

 

 		$this->db->begin();

 

 		if ($forcechilddeletion)

 		{

-			foreach($this->childtables as $table)

+			foreach ($this->childtables as $table)

 			{

 				$sql = 'DELETE FROM '.MAIN_DB_PREFIX.$table.' WHERE '.$this->fk_element.' = '.$this->id;

 				$resql = $this->db->query($sql);

-				if (! $resql)

+				if (!$resql)

 				{

-					$this->error=$this->db->lasterror();

-					$this->errors[]=$this->error;

+					$this->error = $this->db->lasterror();

+					$this->errors[] = $this->error;

 					$this->db->rollback();

 					return -1;

 				}

 			}

 		}

-		elseif (! empty($this->fk_element) && ! empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.

+		elseif (!empty($this->fk_element) && !empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.

 		{

 			$objectisused = $this->isObjectUsed($this->id);

-			if (! empty($objectisused))

+			if (!empty($objectisused))

 			{

 				dol_syslog(get_class($this)."::deleteCommon Can't delete record as it has some child", LOG_WARNING);

-				$this->error='ErrorRecordHasChildren';

-				$this->errors[]=$this->error;

+				$this->error = 'ErrorRecordHasChildren';

+				$this->errors[] = $this->error;

 				$this->db->rollback();

 				return 0;

 			}

 		}

 

-		if (! $error) {

-			if (! $notrigger) {

+		if (!$error) {

+			if (!$notrigger) {

 				// Call triggers

-				$result=$this->call_trigger(strtoupper(get_class($this)).'_DELETE', $user);

+				$result = $this->call_trigger(strtoupper(get_class($this)).'_DELETE', $user);

 				if ($result < 0) { $error++; } // Do also here what you must do to rollback action if trigger fail

 				// End call triggers

 			}

 		}

 

-		if (! $error && ! empty($this->isextrafieldmanaged))

+		if (!$error && !empty($this->isextrafieldmanaged))

 		{

-			$sql = "DELETE FROM " . MAIN_DB_PREFIX . $this->table_element."_extrafields";

-			$sql.= " WHERE fk_object=" . $this->id;

+			$sql = "DELETE FROM ".MAIN_DB_PREFIX.$this->table_element."_extrafields";

+			$sql .= " WHERE fk_object=".$this->id;

 

 			$resql = $this->db->query($sql);

-			if (! $resql)

+			if (!$resql)

 			{

 				$this->errors[] = $this->db->lasterror();

 				$error++;

 			}

 		}

 

-		if (! $error)

+		if (!$error)

 		{

 			$sql = 'DELETE FROM '.MAIN_DB_PREFIX.$this->table_element.' WHERE rowid='.$this->id;

 

 			$res = $this->db->query($sql);

-			if($res===false) {

+			if ($res === false) {

 				$error++;

 				$this->errors[] = $this->db->lasterror();

 			}

@@ -7377,9 +7377,9 @@ 
 		require_once DOL_DOCUMENT_ROOT.'/core/class/comment.class.php';

 

 		$comment = new Comment($this->db);

-		$result=$comment->fetchAllFor($this->element, $this->id);

-		if ($result<0) {

-			$this->errors=array_merge($this->errors, $comment->errors);

+		$result = $comment->fetchAllFor($this->element, $this->id);

+		if ($result < 0) {

+			$this->errors = array_merge($this->errors, $comment->errors);

 			return -1;

 		} else {

 			$this->comments = $comment->comments;

Braces +1380 added lines, -847 removed lines

@@ -400,23 +400,31 @@ 
 		$sql.= " FROM ".MAIN_DB_PREFIX.$element;

 		$sql.= " WHERE entity IN (".getEntity($element).")" ;

 

-		if ($id > 0) $sql.= " AND rowid = ".$db->escape($id);

-		else if ($ref) $sql.= " AND ref = '".$db->escape($ref)."'";

-		else if ($ref_ext) $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";

-		else {

+		if ($id > 0) {
+		    $sql.= " AND rowid = ".$db->escape($id);
+		} else if ($ref) {
+		    $sql.= " AND ref = '".$db->escape($ref)."'";
+		} else if ($ref_ext) {
+		    $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";
+		} else {

 			$error='ErrorWrongParameters';

 			dol_print_error(get_class()."::isExistingObject ".$error, LOG_ERR);

 			return -1;

 		}

-		if ($ref || $ref_ext) $sql.= " AND entity = ".$conf->entity;

+		if ($ref || $ref_ext) {
+		    $sql.= " AND entity = ".$conf->entity;
+		}
 

 		dol_syslog(get_class()."::isExistingObject", LOG_DEBUG);

 		$resql = $db->query($sql);

 		if ($resql)

 		{

 			$num=$db->num_rows($resql);

-			if ($num > 0) return 1;

-			else return 0;

+			if ($num > 0) {
+			    return 1;
+			} else {
+			    return 0;
+			}
 		}

 		return -1;

 	}

@@ -445,13 +453,18 @@ 
 		//print "lastname=".$this->lastname." name=".$this->name." nom=".$this->nom."<br>\n";

 		$lastname=$this->lastname;

 		$firstname=$this->firstname;

-		if (empty($lastname))  $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));

+		if (empty($lastname)) {
+		    $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));
+		}
 

 		$ret='';

 		if ($option && $this->civility_id)

 		{

-			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';

-			else $ret.=$this->civility_id.' ';

+			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) {
+			    $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';
+			} else {
+			    $ret.=$this->civility_id.' ';
+			}
 		}

 

 		$ret.=dolGetFirstLastname($firstname, $lastname, $nameorder);

@@ -544,14 +557,15 @@ 
 		{

             if (!empty($conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT) && $conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT == 1 && $this->region) {

                 $out.=($outdone?' - ':'').$this->region.' - '.$this->state;

-            }

-            else {

+            } else {

                 $out.=($outdone?' - ':'').$this->state;

             }

 			$outdone++;

 		}

 

-		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) $out.=($outdone?'<br>':'');

+		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) {
+		    $out.=($outdone?'<br>':'');
+		}
 		if (! empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone

 			$out.=dol_print_phone($this->phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

 		}

@@ -592,13 +606,21 @@ 
 		$out.='<div style="clear: both;">';

 		if (! empty($conf->socialnetworks->enabled))

 		{

-			if ($this->skype) $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');

+			if ($this->skype) {
+			    $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');
+			}
 			$outdone++;

-			if ($this->jabberid) $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');

+			if ($this->jabberid) {
+			    $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');
+			}
 			$outdone++;

-			if ($this->twitter) $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');

+			if ($this->twitter) {
+			    $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');
+			}
 			$outdone++;

-			if ($this->facebook) $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');

+			if ($this->facebook) {
+			    $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');
+			}
 			$outdone++;

 		}

 		$out.='</div>';

@@ -658,10 +680,10 @@ 
 					$this->errors = $ecmfile->errors;

 				}

 				*/

-			}

-			else return '';

-		}

-		elseif (empty($ecmfile->share))

+			} else {
+			    return '';
+			}
+		} elseif (empty($ecmfile->share))

 		{

 			// Add entry into index

 			if ($initsharekey)

@@ -669,8 +691,9 @@ 
 				require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

 				$ecmfile->share = getRandomPassword(true);

 				$ecmfile->update($user);

-			}

-			else return '';

+			} else {
+			    return '';
+			}
 		}

 

 		// Define $urlwithroot

@@ -684,14 +707,18 @@ 
 		//if (! empty($modulepart)) $paramlink.=($paramlink?'&':'').'modulepart='.$modulepart;		// For sharing with hash (so public files), modulepart is not required.

 		//if (! empty($ecmfile->entity)) $paramlink.='&entity='.$ecmfile->entity; 					// For sharing with hash (so public files), entity is not required.

 		//$paramlink.=($paramlink?'&':'').'file='.urlencode($filepath);								// No need of name of file for public link, we will use the hash

-		if (! empty($ecmfile->share)) $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;			// Hash for public share

-		if ($forcedownload) $paramlink.=($paramlink?'&':'').'attachment=1';

+		if (! empty($ecmfile->share)) {
+		    $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;
+		}
+		// Hash for public share

+		if ($forcedownload) {
+		    $paramlink.=($paramlink?'&':'').'attachment=1';
+		}
 

 		if ($relativelink)

 		{

 			$linktoreturn='document.php'.($paramlink?'?'.$paramlink:'');

-		}

-		else

+		} else

 		{

 			$linktoreturn=$urlwithroot.'/document.php'.($paramlink?'?'.$paramlink:'');

 		}

@@ -739,8 +766,7 @@ 
 		if (is_numeric($type_contact))

 		{

 			$id_type_contact=$type_contact;

-		}

-		else

+		} else

 		{

 			// We look for id type_contact

 			$sql = "SELECT tc.rowid";

@@ -753,7 +779,9 @@ 
 			if ($resql)

 			{

 				$obj = $this->db->fetch_object($resql);

-				if ($obj) $id_type_contact=$obj->rowid;

+				if ($obj) {
+				    $id_type_contact=$obj->rowid;
+				}
 			}

 		}

 

@@ -805,8 +833,7 @@ 
 

 				$this->db->commit();

 				return 1;

-			}

-			else

+			} else

 			{

 				if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')

 				{

@@ -814,15 +841,16 @@ 
 					$this->db->rollback();

 					echo 'err rollback';

 					return -2;

-				}

-				else

+				} else

 				{

 					$this->error=$this->db->error();

 					$this->db->rollback();

 					return -1;

 				}

 			}

-		} else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -864,15 +892,18 @@ 
 		// Insert into database

 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_contact set";

 		$sql.= " statut = ".$statut;

-		if ($type_contact_id) $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";

-		if ($fk_socpeople) $sql.= ", fk_socpeople = '".$fk_socpeople ."'";

+		if ($type_contact_id) {
+		    $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";
+		}
+		if ($fk_socpeople) {
+		    $sql.= ", fk_socpeople = '".$fk_socpeople ."'";
+		}
 		$sql.= " where rowid = ".$rowid;

 		$resql=$this->db->query($sql);

 		if ($resql)

 		{

 			return 0;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -909,8 +940,7 @@ 
 

 			$this->db->commit();

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -940,15 +970,15 @@ 
 

 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

 		$sql.= " WHERE element_id = ".$this->id;

-		if ($listId)

-			$sql.= " AND fk_c_type_contact IN (".$listId.")";

+		if ($listId) {
+					$sql.= " AND fk_c_type_contact IN (".$listId.")";
+		}
 

 		dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);

 		if ($this->db->query($sql))

 		{

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -973,22 +1003,38 @@ 
 		$tab=array();

 

 		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact";    // This field contains id of llx_socpeople or id of llx_user

-		if ($source == 'internal') $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";

-		if ($source == 'external' || $source == 'thirdparty') $sql.=", t.fk_soc as socid, t.statut as statuscontact";

+		if ($source == 'internal') {
+		    $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";
+		}
+		if ($source == 'external' || $source == 'thirdparty') {
+		    $sql.=", t.fk_soc as socid, t.statut as statuscontact";
+		}
 		$sql.= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";

 		$sql.= ", tc.source, tc.element, tc.code, tc.libelle";

 		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";

 		$sql.= ", ".MAIN_DB_PREFIX."element_contact ec";

-		if ($source == 'internal') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";

-		if ($source == 'external'|| $source == 'thirdparty') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";

+		if ($source == 'internal') {
+		    $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";
+		}
+		if ($source == 'external'|| $source == 'thirdparty') {
+		    $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";
+		}
 		$sql.= " WHERE ec.element_id =".$this->id;

 		$sql.= " AND ec.fk_c_type_contact=tc.rowid";

 		$sql.= " AND tc.element='".$this->db->escape($this->element)."'";

-		if ($code) $sql.= " AND tc.code = '".$this->db->escape($code)."'";

-		if ($source == 'internal') $sql.= " AND tc.source = 'internal'";

-		if ($source == 'external' || $source == 'thirdparty') $sql.= " AND tc.source = 'external'";

+		if ($code) {
+		    $sql.= " AND tc.code = '".$this->db->escape($code)."'";
+		}
+		if ($source == 'internal') {
+		    $sql.= " AND tc.source = 'internal'";
+		}
+		if ($source == 'external' || $source == 'thirdparty') {
+		    $sql.= " AND tc.source = 'external'";
+		}
 		$sql.= " AND tc.active=1";

-		if ($statut >= 0) $sql.= " AND ec.statut = '".$statut."'";

+		if ($statut >= 0) {
+		    $sql.= " AND ec.statut = '".$statut."'";
+		}
 		$sql.=" ORDER BY t.lastname ASC";

 

 		dol_syslog(get_class($this)."::liste_contact", LOG_DEBUG);

@@ -1009,8 +1055,7 @@ 
 								   'nom'=>$obj->lastname,      // For backward compatibility

 								   'civility'=>$obj->civility, 'lastname'=>$obj->lastname, 'firstname'=>$obj->firstname, 'email'=>$obj->email, 'login'=>$obj->login, 'photo'=>$obj->photo, 'statuscontact'=>$obj->statuscontact,

 								   'rowid'=>$obj->rowid, 'code'=>$obj->code, 'libelle'=>$libelle_type, 'status'=>$obj->statuslink, 'fk_c_type_contact'=>$obj->fk_c_type_contact);

-				}

-				else

+				} else

 				{

 					$tab[$i]=$obj->id;

 				}

@@ -1019,8 +1064,7 @@ 
 			}

 

 			return $tab;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			dol_print_error($this->db);

@@ -1055,8 +1099,7 @@ 
 			$result = $this->update_contact($rowid, $newstatut);

 			$this->db->free($resql);

 			return $result;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			dol_print_error($this->db);

@@ -1080,16 +1123,27 @@ 
         // phpcs:enable

 		global $langs;

 

-		if (empty($order)) $order='position';

-		if ($order == 'position') $order.=',code';

+		if (empty($order)) {
+		    $order='position';
+		}
+		if ($order == 'position') {
+		    $order.=',code';
+		}
 

 		$tab = array();

 		$sql = "SELECT DISTINCT tc.rowid, tc.code, tc.libelle, tc.position";

 		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

 		$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

-		if ($activeonly == 1) $sql.= " AND tc.active=1"; // only the active types

-		if (! empty($source) && $source != 'all') $sql.= " AND tc.source='".$this->db->escape($source)."'";

-		if (! empty($code)) $sql.= " AND tc.code='".$this->db->escape($code)."'";

+		if ($activeonly == 1) {
+		    $sql.= " AND tc.active=1";
+		}
+		// only the active types

+		if (! empty($source) && $source != 'all') {
+		    $sql.= " AND tc.source='".$this->db->escape($source)."'";
+		}
+		if (! empty($code)) {
+		    $sql.= " AND tc.code='".$this->db->escape($code)."'";
+		}
 		$sql.= $this->db->order($order,'ASC');

 

 		//print "sql=".$sql;

@@ -1104,13 +1158,15 @@ 
 

 				$transkey="TypeContact_".$this->element."_".$source."_".$obj->code;

 				$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

-				if (empty($option)) $tab[$obj->rowid]=$libelle_type;

-				else $tab[$obj->code]=$libelle_type;

+				if (empty($option)) {
+				    $tab[$obj->rowid]=$libelle_type;
+				} else {
+				    $tab[$obj->code]=$libelle_type;
+				}
 				$i++;

 			}

 			return $tab;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			//dol_print_error($this->db);

@@ -1149,19 +1205,29 @@ 
 

 		$sql = "SELECT ec.fk_socpeople";

 		$sql.= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";

-		if ($source == 'internal') $sql.= " ".MAIN_DB_PREFIX."user as c,";

-		if ($source == 'external') $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";

+		if ($source == 'internal') {
+		    $sql.= " ".MAIN_DB_PREFIX."user as c,";
+		}
+		if ($source == 'external') {
+		    $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";
+		}
 		$sql.= " ".MAIN_DB_PREFIX."c_type_contact as tc";

 		$sql.= " WHERE ec.element_id = ".$id;

 		$sql.= " AND ec.fk_socpeople = c.rowid";

-		if ($source == 'internal') $sql.= " AND c.entity IN (".getEntity('user').")";

-		if ($source == 'external') $sql.= " AND c.entity IN (".getEntity('societe').")";

+		if ($source == 'internal') {
+		    $sql.= " AND c.entity IN (".getEntity('user').")";
+		}
+		if ($source == 'external') {
+		    $sql.= " AND c.entity IN (".getEntity('societe').")";
+		}
 		$sql.= " AND ec.fk_c_type_contact = tc.rowid";

 		$sql.= " AND tc.element = '".$element."'";

 		$sql.= " AND tc.source = '".$source."'";

 		$sql.= " AND tc.code = '".$code."'";

 		$sql.= " AND tc.active = 1";

-		if ($status) $sql.= " AND ec.statut = ".$status;

+		if ($status) {
+		    $sql.= " AND ec.statut = ".$status;
+		}
 

 		dol_syslog(get_class($this)."::getIdContact", LOG_DEBUG);

 		$resql=$this->db->query($sql);

@@ -1172,8 +1238,7 @@ 
 				$result[$i]=$obj->fk_socpeople;

 				$i++;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			return null;

@@ -1192,9 +1257,13 @@ 
 	function fetch_contact($contactid=null)

 	{

         // phpcs:enable

-		if (empty($contactid)) $contactid=$this->contactid;

+		if (empty($contactid)) {
+		    $contactid=$this->contactid;
+		}
 

-		if (empty($contactid)) return 0;

+		if (empty($contactid)) {
+		    return 0;
+		}
 

 		require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

 		$contact = new Contact($this->db);

@@ -1215,14 +1284,16 @@ 
         // phpcs:enable

 		global $conf;

 

-		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id))

-			return 0;

+		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id)) {
+					return 0;
+		}
 

 		require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

 

 		$idtofetch = isset($this->socid) ? $this->socid : (isset($this->fk_soc) ? $this->fk_soc : $this->fk_thirdparty);

-		if ($force_thirdparty_id)

-			$idtofetch = $force_thirdparty_id;

+		if ($force_thirdparty_id) {
+					$idtofetch = $force_thirdparty_id;
+		}
 

 		if ($idtofetch) {

 			$thirdparty = new Societe($this->db);

@@ -1235,8 +1306,9 @@ 
 			}

 

 			return $result;

-		} else

-			return -1;

+		} else {
+					return -1;
+		}
 	}

 

 

@@ -1282,18 +1354,24 @@ 
 		dol_syslog(get_class($this).'::fetch_barcode this->element='.$this->element.' this->barcode_type='.$this->barcode_type);

 

 		$idtype=$this->barcode_type;

-		if (empty($idtype) && $idtype != '0')	// If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

+		if (empty($idtype) && $idtype != '0') {
+		    // If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

 		{

-			if ($this->element == 'product')      $idtype = $conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;

-			else if ($this->element == 'societe') $idtype = $conf->global->GENBARCODE_BARCODETYPE_THIRDPARTY;

-			else dol_syslog('Call fetch_barcode with barcode_type not defined and cant be guessed', LOG_WARNING);

+			if ($this->element == 'product')      $idtype = $conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;
+		} else if ($this->element == 'societe') {
+			    $idtype = $conf->global->GENBARCODE_BARCODETYPE_THIRDPARTY;
+			} else {
+			    dol_syslog('Call fetch_barcode with barcode_type not defined and cant be guessed', LOG_WARNING);
+			}
 		}

 

 		if ($idtype > 0)

 		{

-			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder))    // If data not already loaded

+			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder)) {
+			    // If data not already loaded

 			{

-				$sql = "SELECT rowid, code, libelle as label, coder";

+				$sql = "SELECT rowid, code, libelle as label, coder";
+			}
 				$sql.= " FROM ".MAIN_DB_PREFIX."c_barcode_type";

 				$sql.= " WHERE rowid = ".$idtype;

 				dol_syslog(get_class($this).'::fetch_barcode', LOG_DEBUG);

@@ -1306,8 +1384,7 @@ 
 					$this->barcode_type_label = $obj->label;

 					$this->barcode_type_coder = $obj->coder;

 					return 1;

-				}

-				else

+				} else

 				{

 					dol_print_error($this->db);

 					return -1;

@@ -1328,8 +1405,13 @@ 
         // phpcs:enable

 		include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';

 

-		if (empty($this->fk_project) && ! empty($this->fk_projet)) $this->fk_project = $this->fk_projet;	// For backward compatibility

-		if (empty($this->fk_project)) return 0;

+		if (empty($this->fk_project) && ! empty($this->fk_projet)) {
+		    $this->fk_project = $this->fk_projet;
+		}
+		// For backward compatibility

+		if (empty($this->fk_project)) {
+		    return 0;
+		}
 

 		$project = new Project($this->db);

 		$result = $project->fetch($this->fk_project);

@@ -1350,7 +1432,9 @@ 
         // phpcs:enable

 		include_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

 

-		if (empty($this->fk_product)) return 0;

+		if (empty($this->fk_product)) {
+		    return 0;
+		}
 

 		$product = new Product($this->db);

 		$result = $product->fetch($this->fk_product);

@@ -1384,9 +1468,15 @@ 
 	function fetch_origin()

 	{

         // phpcs:enable

-		if ($this->origin == 'shipping') $this->origin = 'expedition';

-		if ($this->origin == 'delivery') $this->origin = 'livraison';

-        if ($this->origin == 'order_supplier') $this->origin = 'commandeFournisseur';

+		if ($this->origin == 'shipping') {
+		    $this->origin = 'expedition';
+		}
+		if ($this->origin == 'delivery') {
+		    $this->origin = 'livraison';
+		}
+        if ($this->origin == 'order_supplier') {
+            $this->origin = 'commandeFournisseur';
+        }
 

 		$origin = $this->origin;

 

@@ -1478,29 +1568,48 @@ 
 	{

 		global $user,$langs,$conf;

 

-		if (empty($table)) 	  $table=$this->table_element;

-		if (empty($id))    	  $id=$this->id;

-		if (empty($format))   $format='text';

-		if (empty($id_field)) $id_field='rowid';

+		if (empty($table)) {
+		    $table=$this->table_element;
+		}
+		if (empty($id)) {
+		    $id=$this->id;
+		}
+		if (empty($format)) {
+		    $format='text';
+		}
+		if (empty($id_field)) {
+		    $id_field='rowid';
+		}
 

 		$error=0;

 

 		$this->db->begin();

 

 		// Special case

-		if ($table == 'product' && $field == 'note_private') $field='note';

-		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) $fk_user_field = 'fk_user_mod';

+		if ($table == 'product' && $field == 'note_private') {
+		    $field='note';
+		}
+		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) {
+		    $fk_user_field = 'fk_user_mod';
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$table." SET ";

 

-		if ($format == 'text') $sql.= $field." = '".$this->db->escape($value)."'";

-		else if ($format == 'int') $sql.= $field." = ".$this->db->escape($value);

-		else if ($format == 'date') $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");

+		if ($format == 'text') {
+		    $sql.= $field." = '".$this->db->escape($value)."'";
+		} else if ($format == 'int') {
+		    $sql.= $field." = ".$this->db->escape($value);
+		} else if ($format == 'date') {
+		    $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");
+		}
 

 		if ($fk_user_field)

 		{

-			if (! empty($fuser) && is_object($fuser)) $sql.=", ".$fk_user_field." = ".$fuser->id;

-			elseif (empty($fuser) || $fuser != 'none') $sql.=", ".$fk_user_field." = ".$user->id;

+			if (! empty($fuser) && is_object($fuser)) {
+			    $sql.=", ".$fk_user_field." = ".$fuser->id;
+			} elseif (empty($fuser) || $fuser != 'none') {
+			    $sql.=", ".$fk_user_field." = ".$user->id;
+			}
 		}

 

 		$sql.= " WHERE ".$id_field." = ".$id;

@@ -1515,28 +1624,32 @@ 
 				if (empty($this->fields) && method_exists($this, 'fetch'))

 				{

 					$result = $this->fetch($id);

-				}

-				else

+				} else

 				{

 					$result = $this->fetchCommon($id);

 				}

-				if ($result >= 0) $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);   // This may set this->errors

-				if ($result < 0) $error++;

+				if ($result >= 0) {
+				    $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);
+				}
+				// This may set this->errors

+				if ($result < 0) {
+				    $error++;
+				}
 			}

 

 			if (! $error)

 			{

-				if (property_exists($this, $field)) $this->$field = $value;

+				if (property_exists($this, $field)) {
+				    $this->$field = $value;
+				}
 				$this->db->commit();

 				return 1;

-			}

-			else

+			} else

 			{

 				$this->db->rollback();

 				return -2;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -1563,36 +1676,66 @@ 
 			dol_print_error('',get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");

 			return -1;

 		}

-		if ($fieldid == 'none') return 1;

+		if ($fieldid == 'none') {
+		    return 1;
+		}
 

 		// Security on socid

 		$socid = 0;

-		if ($user->societe_id > 0) $socid = $user->societe_id;

+		if ($user->societe_id > 0) {
+		    $socid = $user->societe_id;
+		}
 

 		// this->ismultientitymanaged contains

 		// 0=No test on entity, 1=Test with field entity, 2=Test with link by societe

 		$alias = 's';

-		if ($this->element == 'societe') $alias = 'te';

+		if ($this->element == 'societe') {
+		    $alias = 'te';
+		}
 

 		$sql = "SELECT MAX(te.".$fieldid.")";

 		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

 		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

 			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to socid

+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";
+		}
+		// If we need to link to societe to limit select to socid

+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
+		}
 		$sql.= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND sc.fk_user = " .$user->id;
+		}
+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';
+		}
 		if (! empty($filter))

 		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

+			if (! preg_match('/^\s*AND/i', $filter)) {
+			    $sql.=" AND ";
+			}
+			// For backward compatibility

 			$sql.=$filter;

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to socid

 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

 			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

 				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

@@ -1605,9 +1748,15 @@ 
 				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

 			}

 		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND te.fk_soc = ' . $socid;
+		}
+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';
+		}
+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') {
+		    $sql.= ' AND te.rowid = ' . $socid;
+		}
 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 

 		$result = $this->db->query($sql);

@@ -1625,20 +1774,44 @@ 
 		if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

 			$sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to socid

+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";
+		}
+		// If we need to link to societe to limit select to socid

+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
+		}
 		$sql.= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND sc.fk_user = " .$user->id;
+		}
+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';
+		}
 		if (! empty($filter))

 		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

+			if (! preg_match('/^\s*AND/i', $filter)) {
+			    $sql.=" AND ";
+			}
+			// For backward compatibility

 			$sql.=$filter;

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to socid

 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

 			if ($this->element == 'user' && ! empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

 				if (! empty($user->admin) && empty($user->entity) && $conf->entity == 1) {

@@ -1651,9 +1824,15 @@ 
 				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

 			}

 		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND te.fk_soc = ' . $socid;
+		}
+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';
+		}
+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') {
+		    $sql.= ' AND te.rowid = ' . $socid;
+		}
 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 		// Rem: Bug in some mysql version: SELECT MIN(rowid) FROM llx_socpeople WHERE rowid > 1 when one row in database with rowid=1, returns 1 instead of null

 

@@ -1685,8 +1864,11 @@ 
 		$i = 0;

 		while ($i < $num)

 		{

-			if ($source == 'thirdparty') $contactAlreadySelected[$i] = $tab[$i]['socid'];

-			else  $contactAlreadySelected[$i] = $tab[$i]['id'];

+			if ($source == 'thirdparty') {
+			    $contactAlreadySelected[$i] = $tab[$i]['socid'];
+			} else {
+			    $contactAlreadySelected[$i] = $tab[$i]['id'];
+			}
 			$i++;

 		}

 		return $contactAlreadySelected;

@@ -1710,14 +1892,19 @@ 
 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 		if ($this->table_element == 'actioncomm')

 		{

-			if ($projectid) $sql.= ' SET fk_project = '.$projectid;

-			else $sql.= ' SET fk_project = NULL';

+			if ($projectid) {
+			    $sql.= ' SET fk_project = '.$projectid;
+			} else {
+			    $sql.= ' SET fk_project = NULL';
+			}
 			$sql.= ' WHERE id = '.$this->id;

-		}

-		else

+		} else

 		{

-			if ($projectid) $sql.= ' SET fk_projet = '.$projectid;

-			else $sql.= ' SET fk_projet = NULL';

+			if ($projectid) {
+			    $sql.= ' SET fk_projet = '.$projectid;
+			} else {
+			    $sql.= ' SET fk_projet = NULL';
+			}
 			$sql.= ' WHERE rowid = '.$this->id;

 		}

 

@@ -1726,8 +1913,7 @@ 
 		{

 			$this->fk_project = $projectid;

 			return 1;

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db);

 			return -1;

@@ -1747,8 +1933,12 @@ 
 		{

 			// TODO uniformize field name

 			$fieldname = 'fk_mode_reglement';

-			if ($this->element == 'societe') $fieldname = 'mode_reglement';

-			if (get_class($this) == 'Fournisseur') $fieldname = 'mode_reglement_supplier';

+			if ($this->element == 'societe') {
+			    $fieldname = 'mode_reglement';
+			}
+			if (get_class($this) == 'Fournisseur') {
+			    $fieldname = 'mode_reglement_supplier';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 			$sql .= ' SET '.$fieldname.' = '.$id;

@@ -1758,17 +1948,17 @@ 
 			{

 				$this->mode_reglement_id = $id;

 				// for supplier

-				if (get_class($this) == 'Fournisseur') $this->mode_reglement_supplier_id = $id;

+				if (get_class($this) == 'Fournisseur') {
+				    $this->mode_reglement_supplier_id = $id;
+				}
 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setPaymentMethods Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setPaymentMethods, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1798,18 +1988,18 @@ 
 				$this->multicurrency_code = $code;

 

 				list($fk_multicurrency, $rate) = MultiCurrency::getIdAndTxFromCode($this->db, $code);

-				if ($rate) $this->setMulticurrencyRate($rate,2);

+				if ($rate) {
+				    $this->setMulticurrencyRate($rate,2);
+				}
 

 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setMulticurrencyCode Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setMulticurrencyCode, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1903,15 +2093,13 @@ 
 				}

 

 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setMulticurrencyRate Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setMulticurrencyRate, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1932,8 +2120,12 @@ 
 		{

 			// TODO uniformize field name

 			$fieldname = 'fk_cond_reglement';

-			if ($this->element == 'societe') $fieldname = 'cond_reglement';

-			if (get_class($this) == 'Fournisseur') $fieldname = 'cond_reglement_supplier';

+			if ($this->element == 'societe') {
+			    $fieldname = 'cond_reglement';
+			}
+			if (get_class($this) == 'Fournisseur') {
+			    $fieldname = 'cond_reglement_supplier';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 			$sql .= ' SET '.$fieldname.' = '.$id;

@@ -1943,18 +2135,18 @@ 
 			{

 				$this->cond_reglement_id = $id;

 				// for supplier

-				if (get_class($this) == 'Fournisseur') $this->cond_reglement_supplier_id = $id;

+				if (get_class($this) == 'Fournisseur') {
+				    $this->cond_reglement_supplier_id = $id;
+				}
 				$this->cond_reglement = $id;	// for compatibility

 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setPaymentTerms Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setPaymentTerms, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1972,7 +2164,9 @@ 
 	function setDeliveryAddress($id)

 	{

 		$fieldname = 'fk_delivery_address';

-		if ($this->element == 'delivery' || $this->element == 'shipping') $fieldname = 'fk_address';

+		if ($this->element == 'delivery' || $this->element == 'shipping') {
+		    $fieldname = 'fk_address';
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element." SET ".$fieldname." = ".$id;

 		$sql.= " WHERE rowid = ".$this->id." AND fk_statut = 0";

@@ -1981,8 +2175,7 @@ 
 		{

 			$this->fk_delivery_address = $id;

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			dol_syslog(get_class($this).'::setDeliveryAddress Erreur '.$sql.' - '.$this->error);

@@ -2004,7 +2197,9 @@ 
 	{

         global $user;

 

-        if (empty($userused)) $userused=$user;

+        if (empty($userused)) {
+            $userused=$user;
+        }
 

         $error = 0;

 

@@ -2015,7 +2210,9 @@ 
 

         $this->db->begin();

 

-		if ($shipping_method_id<0) $shipping_method_id='NULL';

+		if ($shipping_method_id<0) {
+		    $shipping_method_id='NULL';
+		}
 		dol_syslog(get_class($this).'::setShippingMethod('.$shipping_method_id.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

@@ -2032,7 +2229,9 @@ 
                 // Call trigger

                 $this->context=array('shippingmethodupdate'=>1);

                 $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

-                if ($result < 0) $error++;

+                if ($result < 0) {
+                    $error++;
+                }
                 // End call trigger

             }

         }

@@ -2060,7 +2259,9 @@ 
 			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined",LOG_ERR);

 			return -1;

 		}

-		if ($warehouse_id<0) $warehouse_id='NULL';

+		if ($warehouse_id<0) {
+		    $warehouse_id='NULL';
+		}
 		dol_syslog(get_class($this).'::setWarehouse('.$warehouse_id.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

@@ -2107,8 +2308,7 @@ 
 		{

 			$this->modelpdf=$modelpdf;

 			return 1;

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db);

 			return 0;

@@ -2128,7 +2328,9 @@ 
 	{

         global $user;

 

-        if (empty($userused)) $userused=$user;

+        if (empty($userused)) {
+            $userused=$user;
+        }
 

         $error = 0;

 

@@ -2138,7 +2340,9 @@ 
 		}

         $this->db->begin();

 

-		if ($fk_account<0) $fk_account='NULL';

+		if ($fk_account<0) {
+		    $fk_account='NULL';
+		}
 		dol_syslog(get_class($this).'::setBankAccount('.$fk_account.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

@@ -2151,15 +2355,16 @@ 
             dol_syslog(get_class($this).'::setBankAccount Error '.$sql.' - '.$this->db->error());

             $this->error = $this->db->lasterror();

             $error++;

-        }

-        else

+        } else

         {

             if (!$notrigger)

             {

                 // Call trigger

                 $this->context=array('bankaccountupdate'=>1);

                 $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

-                if ($result < 0) $error++;

+                if ($result < 0) {
+                    $error++;
+                }
                 // End call trigger

             }

         }

@@ -2167,8 +2372,7 @@ 
         {

             $this->db->rollback();

             return -1;

-        }

-        else

+        } else

         {

             $this->fk_account = ($fk_account=='NULL')?null:$fk_account;

             $this->db->commit();

@@ -2207,8 +2411,12 @@ 
 		$nl=0;

 		$sql = 'SELECT count(rowid) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

 		$sql.= ' WHERE '.$this->fk_element.'='.$this->id;

-		if (! $renum) $sql.= ' AND rang = 0';

-		if ($renum) $sql.= ' AND rang <> 0';

+		if (! $renum) {
+		    $sql.= ' AND rang = 0';
+		}
+		if ($renum) {
+		    $sql.= ' AND rang <> 0';
+		}
 

 		dol_syslog(get_class($this)."::line_order", LOG_DEBUG);

 		$resql = $this->db->query($sql);

@@ -2216,8 +2424,9 @@ 
 		{

 			$row = $this->db->fetch_row($resql);

 			$nl = $row[0];

-		}

-		else dol_print_error($this->db);

+		} else {
+		    dol_print_error($this->db);
+		}
 		if ($nl > 0)

 		{

 			// The goal of this part is to reorder all lines, with all children lines sharing the same

@@ -2227,7 +2436,9 @@ 
 			// We first search all lines that are parent lines (for multilevel details lines)

 			$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

 			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			if ($fk_parent_line) $sql.= ' AND fk_parent_line IS NULL';

+			if ($fk_parent_line) {
+			    $sql.= ' AND fk_parent_line IS NULL';
+			}
 			$sql.= ' ORDER BY rang ASC, rowid '.$rowidorder;

 

 			dol_syslog(get_class($this)."::line_order search all parent lines", LOG_DEBUG);

@@ -2259,8 +2470,7 @@ 
 						$this->updateRangOfLine($row, ($key+1));

 					}

 				}

-			}

-			else

+			} else

 			{

 				dol_print_error($this->db);

 			}

@@ -2353,7 +2563,9 @@ 
 	function updateRangOfLine($rowid,$rang)

 	{

 		$fieldposition = 'rang';

-		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) {
+		    $fieldposition = 'position';
+		}
 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

 		$sql.= ' WHERE rowid = '.$rowid;

@@ -2394,7 +2606,9 @@ 
 		if ($rang > 1)

 		{

 			$fieldposition = 'rang';

-			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) {
+			    $fieldposition = 'position';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang ;

 			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

@@ -2407,8 +2621,7 @@ 
 				{

 					dol_print_error($this->db);

 				}

-			}

-			else

+			} else

 			{

 				dol_print_error($this->db);

 			}

@@ -2428,7 +2641,9 @@ 
 		if ($rang < $max)

 		{

 			$fieldposition = 'rang';

-			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) {
+			    $fieldposition = 'position';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

 			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

@@ -2441,8 +2656,7 @@ 
 				{

 					dol_print_error($this->db);

 				}

-			}

-			else

+			} else

 			{

 				dol_print_error($this->db);

 			}

@@ -2513,8 +2727,7 @@ 
 				if (! empty($row[0]))

 				{

 					return $row[0];

-				}

-				else

+				} else

 				{

 					return $this->getRangOfLine($fk_parent_line);

 				}

@@ -2561,8 +2774,7 @@ 
 		{

 			$this->ref_ext = $ref_ext;

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			return -1;

@@ -2596,7 +2808,9 @@ 
 		}

 		// Special cas

 		//var_dump($this->table_element);exit;

-		if ($this->table_element == 'product') $suffix='';

+		if ($this->table_element == 'product') {
+		    $suffix='';
+		}
 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 		$sql.= " SET note".$suffix." = ".(!empty($note)?("'".$this->db->escape($note)."'"):"NULL");

@@ -2606,16 +2820,17 @@ 
 		dol_syslog(get_class($this)."::update_note", LOG_DEBUG);

 		if ($this->db->query($sql))

 		{

-			if ($suffix == '_public') $this->note_public = $note;

-			else if ($suffix == '_private') $this->note_private = $note;

-			else

+			if ($suffix == '_public') {
+			    $this->note_public = $note;
+			} else if ($suffix == '_private') {
+			    $this->note_private = $note;
+			} else

 			{

 				$this->note = $note;      // deprecated

 				$this->note_private = $note;

 			}

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -2655,36 +2870,45 @@ 
 

 		// Some external module want no update price after a trigger because they have another method to calculate the total (ex: with an extrafield)

 		$MODULE = "";

-		if ($this->element == 'propal')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_PROPOSAL";

-		elseif ($this->element == 'order')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_ORDER";

-		elseif ($this->element == 'facture')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_INVOICE";

-		elseif ($this->element == 'facture_fourn')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_INVOICE";

-		elseif ($this->element == 'order_supplier')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_ORDER";

-		elseif ($this->element == 'supplier_proposal')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";

+		if ($this->element == 'propal') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_PROPOSAL";
+		} elseif ($this->element == 'order') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_ORDER";
+		} elseif ($this->element == 'facture') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_INVOICE";
+		} elseif ($this->element == 'facture_fourn') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_INVOICE";
+		} elseif ($this->element == 'order_supplier') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_ORDER";
+		} elseif ($this->element == 'supplier_proposal') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";
+		}
 

 		if (! empty($MODULE)) {

 			if (! empty($conf->global->$MODULE)) {

 				$modsactivated = explode(',', $conf->global->$MODULE);

 				foreach ($modsactivated as $mod) {

-					if ($conf->$mod->enabled)

-						return 1; // update was disabled by specific setup

+					if ($conf->$mod->enabled) {
+											return 1;
+					}
+					// update was disabled by specific setup

 				}

 			}

 		}

 

 		include_once DOL_DOCUMENT_ROOT.'/core/lib/price.lib.php';

 

-		if ($roundingadjust == '-1') $roundingadjust='auto';	// For backward compatibility

+		if ($roundingadjust == '-1') {
+		    $roundingadjust='auto';
+		}
+		// For backward compatibility

 

 		$forcedroundingmode=$roundingadjust;

-		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) $forcedroundingmode=$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;

-		elseif ($forcedroundingmode == 'auto') $forcedroundingmode='0';

+		if ($forcedroundingmode == 'auto' && isset($conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) {
+		    $forcedroundingmode=$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;
+		} elseif ($forcedroundingmode == 'auto') {
+		    $forcedroundingmode='0';
+		}
 

 		$error=0;

 

@@ -2707,15 +2931,22 @@ 
 

 		$sql = 'SELECT rowid, qty, '.$fieldup.' as up, remise_percent, total_ht, '.$fieldtva.' as total_tva, total_ttc, '.$fieldlocaltax1.' as total_localtax1, '.$fieldlocaltax2.' as total_localtax2,';

 		$sql.= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';

-			if ($this->table_element_line == 'facturedet') $sql.= ', situation_percent';

+			if ($this->table_element_line == 'facturedet') {
+			    $sql.= ', situation_percent';
+			}
 			$sql.= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';

 		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;

 		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

 		if ($exclspec)

 		{

 			$product_field='product_type';

-			if ($this->table_element_line == 'contratdet') $product_field='';    // contratdet table has no product_type field

-			if ($product_field) $sql.= ' AND '.$product_field.' <> 9';

+			if ($this->table_element_line == 'contratdet') {
+			    $product_field='';
+			}
+			// contratdet table has no product_type field

+			if ($product_field) {
+			    $sql.= ' AND '.$product_field.' <> 9';
+			}
 		}

 		$sql.= ' ORDER by rowid';	// We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used

 

@@ -2745,9 +2976,11 @@ 
 				$parameters=array('fk_element' => $obj->rowid);

 				$reshook = $hookmanager->executeHooks('changeRoundingMode', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 

-				if (empty($reshook) && $forcedroundingmode == '0')	// Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

+				if (empty($reshook) && $forcedroundingmode == '0') {
+				    // Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

 				{

-					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);

+					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);
+				}
 					$tmpcal=calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);

 					$diff=price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);

 					if ($diff)

@@ -2755,7 +2988,9 @@ 
 						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;

 						dol_syslog('We found unconsistent data into detailed line (difference of '.$diff.') for line rowid = '.$obj->rowid." (total vat of line calculated=".$tmpcal[1].", database=".$obj->total_tva."). We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

 								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+								if (! $resqlfix) {
+								    dol_print_error($this->db,'Failed to update line');
+								}
 								$obj->total_tva = $tmpcal[1];

 								$obj->total_ttc = $tmpcal[2];

 						//

@@ -2771,16 +3006,24 @@ 
 				$this->multicurrency_total_tva       += $obj->multicurrency_total_tva;

 				$this->multicurrency_total_ttc       += $obj->multicurrency_total_ttc;

 

-				if (! isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate]=0;

-				if (! isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate]=0;

-				if (! isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate]=0;

+				if (! isset($total_ht_by_vats[$obj->vatrate])) {
+				    $total_ht_by_vats[$obj->vatrate]=0;
+				}
+				if (! isset($total_tva_by_vats[$obj->vatrate])) {
+				    $total_tva_by_vats[$obj->vatrate]=0;
+				}
+				if (! isset($total_ttc_by_vats[$obj->vatrate])) {
+				    $total_ttc_by_vats[$obj->vatrate]=0;
+				}
 				$total_ht_by_vats[$obj->vatrate]  += $obj->total_ht;

 				$total_tva_by_vats[$obj->vatrate] += $obj->total_tva;

 				$total_ttc_by_vats[$obj->vatrate] += $obj->total_ttc;

 

-				if ($forcedroundingmode == '1')	// Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

+				if ($forcedroundingmode == '1') {
+				    // Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

 				{

-					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);

+					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);
+				}
 					$diff=price2num($total_tva_by_vats[$obj->vatrate]-$tmpvat, 'MT', 1);

 					//print 'Line '.$i.' rowid='.$obj->rowid.' vat_rate='.$obj->vatrate.' total_ht='.$obj->total_ht.' total_tva='.$obj->total_tva.' total_ttc='.$obj->total_ttc.' total_ht_by_vats='.$total_ht_by_vats[$obj->vatrate].' total_tva_by_vats='.$total_tva_by_vats[$obj->vatrate].' (new calculation = '.$tmpvat.') total_ttc_by_vats='.$total_ttc_by_vats[$obj->vatrate].($diff?" => DIFF":"")."<br>\n";

 					if ($diff)

@@ -2789,7 +3032,9 @@ 
 						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;

 						dol_syslog('We found a difference of '.$diff.' for line rowid = '.$obj->rowid.". We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

 								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+								if (! $resqlfix) {
+								    dol_print_error($this->db,'Failed to update line');
+								}
 								$this->total_tva -= $diff;

 								$this->total_ttc -= $diff;

 								$total_tva_by_vats[$obj->vatrate] -= $diff;

@@ -2830,11 +3075,21 @@ 
 			$fieldlocaltax2='localtax2';

 			$fieldttc='total_ttc';

 			// Specific code for backward compatibility with old field names

-			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht='total';

-			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva='total_tva';

-			if ($this->element == 'propal')                                                $fieldttc='total';

-			if ($this->element == 'expensereport')                                         $fieldtva='total_tva';

-			if ($this->element == 'supplier_proposal')                                     $fieldttc='total';

+			if ($this->element == 'facture' || $this->element == 'facturerec') {
+			    $fieldht='total';
+			}
+			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') {
+			    $fieldtva='total_tva';
+			}
+			if ($this->element == 'propal') {
+			    $fieldttc='total';
+			}
+			if ($this->element == 'expensereport') {
+			    $fieldtva='total_tva';
+			}
+			if ($this->element == 'supplier_proposal') {
+			    $fieldttc='total';
+			}
 

 			if (empty($nodatabaseupdate))

 			{

@@ -2863,13 +3118,11 @@ 
 			if (! $error)

 			{

 				return 1;

-			}

-			else

+			} else

 			{

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db,'Bad request in update_price');

 			return -1;

@@ -2892,10 +3145,18 @@ 
 		$origin_id = (! empty($origin_id) ? $origin_id : $this->origin_id);

 

 		// Special case

-		if ($origin == 'order') $origin='commande';

-		if ($origin == 'invoice') $origin='facture';

-		if ($origin == 'invoice_template') $origin='facturerec';

-    	if ($origin == 'supplierorder') $origin='order_supplier';

+		if ($origin == 'order') {
+		    $origin='commande';
+		}
+		if ($origin == 'invoice') {
+		    $origin='facture';
+		}
+		if ($origin == 'invoice_template') {
+		    $origin='facturerec';
+		}
+    	if ($origin == 'supplierorder') {
+    	    $origin='order_supplier';
+    	}
 		$this->db->begin();

 

 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";

@@ -2915,8 +3176,7 @@ 
 	  	{

 	  		$this->db->commit();

 	  		return 1;

-	  	}

-	  	else

+	  	} else

 	  	{

 	  		$this->error=$this->db->lasterror();

 	  		$this->db->rollback();

@@ -2961,12 +3221,16 @@ 
 		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid))

 		{

 			$justsource=true;  // the source (id and type) is a search criteria

-			if (! empty($targettype)) $withtargettype=true;

+			if (! empty($targettype)) {
+			    $withtargettype=true;
+			}
 		}

 		if (! empty($targetid) && ! empty($targettype) && empty($sourceid))

 		{

 			$justtarget=true;  // the target (id and type) is a search criteria

-			if (! empty($sourcetype)) $withsourcetype=true;

+			if (! empty($sourcetype)) {
+			    $withsourcetype=true;
+			}
 		}

 

 		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

@@ -2989,15 +3253,17 @@ 
 			if ($justsource)

 			{

 				$sql.= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";

-				if ($withtargettype) $sql.= " AND targettype = '".$targettype."'";

-			}

-			else if ($justtarget)

+				if ($withtargettype) {
+				    $sql.= " AND targettype = '".$targettype."'";
+				}
+			} else if ($justtarget)

 			{

 				$sql.= "fk_target = ".$targetid." AND targettype = '".$targettype."'";

-				if ($withsourcetype) $sql.= " AND sourcetype = '".$sourcetype."'";

+				if ($withsourcetype) {
+				    $sql.= " AND sourcetype = '".$sourcetype."'";
+				}
 			}

-		}

-		else

+		} else

 		{

 			$sql.= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";

 			$sql.= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";

@@ -3018,13 +3284,11 @@ 
 					if ($justsource)

 					{

 						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

-					}

-					else if ($justtarget)

+					} else if ($justtarget)

 					{

 						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

 					}

-				}

-				else

+				} else

 				{

 					if ($obj->fk_source == $sourceid && $obj->sourcetype == $sourcetype)

 					{

@@ -3041,10 +3305,12 @@ 
 			if (! empty($this->linkedObjectsIds))

 			{

 				$tmparray = $this->linkedObjectsIds;

-				foreach($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

+				foreach($tmparray as $objecttype => $objectids) {
+				    // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

 				{

 					// Parse element/subelement (ex: project_task, cabinetmed_consultation, ...)

-					$module = $element = $subelement = $objecttype;

+					$module = $element = $subelement = $objecttype;
+				}
 					if ($objecttype != 'supplier_proposal' && $objecttype != 'order_supplier' && $objecttype != 'invoice_supplier'

 						&& preg_match('/^([^_]+)_([^_]+)/i',$objecttype,$regs))

 					{

@@ -3056,29 +3322,21 @@ 
 					// To work with non standard classpath or module name

 					if ($objecttype == 'facture')			{

 						$classpath = 'compta/facture/class';

-					}

-					else if ($objecttype == 'facturerec')			{

+					} else if ($objecttype == 'facturerec')			{

 						$classpath = 'compta/facture/class'; $module = 'facture';

-					}

-					else if ($objecttype == 'propal')			{

+					} else if ($objecttype == 'propal')			{

 						$classpath = 'comm/propal/class';

-					}

-					else if ($objecttype == 'supplier_proposal')			{

+					} else if ($objecttype == 'supplier_proposal')			{

 						$classpath = 'supplier_proposal/class';

-					}

-					else if ($objecttype == 'shipping')			{

+					} else if ($objecttype == 'shipping')			{

 						$classpath = 'expedition/class'; $subelement = 'expedition'; $module = 'expedition_bon';

-					}

-					else if ($objecttype == 'delivery')			{

+					} else if ($objecttype == 'delivery')			{

 						$classpath = 'livraison/class'; $subelement = 'livraison'; $module = 'livraison_bon';

-					}

-					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

+					} else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

 						$classpath = 'fourn/class'; $module = 'fournisseur';

-					}

-					else if ($objecttype == 'fichinter')			{

+					} else if ($objecttype == 'fichinter')			{

 						$classpath = 'fichinter/class'; $subelement = 'fichinter'; $module = 'ficheinter';

-					}

-					else if ($objecttype == 'subscription')			{

+					} else if ($objecttype == 'subscription')			{

 						$classpath = 'adherents/class'; $module = 'adherent';

 					}

 

@@ -3087,20 +3345,15 @@ 
 

 					if ($objecttype == 'order') {

 						$classfile = 'commande'; $classname = 'Commande';

-					}

-					else if ($objecttype == 'invoice_supplier') {

+					} else if ($objecttype == 'invoice_supplier') {

 						$classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';

-					}

-					else if ($objecttype == 'order_supplier')   {

+					} else if ($objecttype == 'order_supplier')   {

 						$classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';

-					}

-					else if ($objecttype == 'supplier_proposal')   {

+					} else if ($objecttype == 'supplier_proposal')   {

 						$classfile = 'supplier_proposal'; $classname = 'SupplierProposal';

-					}

-					else if ($objecttype == 'facturerec')   {

+					} else if ($objecttype == 'facturerec')   {

 						$classfile = 'facture-rec'; $classname = 'FactureRec';

-					}

-					else if ($objecttype == 'subscription')   {

+					} else if ($objecttype == 'subscription')   {

 						$classfile = 'subscription'; $classname = 'Subscription';

 					}

 

@@ -3113,9 +3366,11 @@ 
 							//print '/'.$classpath.'/'.$classfile.'.class.php '.class_exists($classname);

 							if (class_exists($classname))

 							{

-								foreach($objectids as $i => $objectid)	// $i is rowid into llx_element_element

+								foreach($objectids as $i => $objectid) {
+								    // $i is rowid into llx_element_element

 								{

-									$object = new $classname($this->db);

+									$object = new $classname($this->db);
+								}
 									$ret = $object->fetch($objectid);

 									if ($ret >= 0)

 									{

@@ -3124,16 +3379,14 @@ 
 								}

 							}

 						}

-					}

-					else

+					} else

 					{

 						unset($this->linkedObjectsIds[$objecttype]);

 					}

 				}

 			}

 			return 1;

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db);

 			return -1;

@@ -3155,8 +3408,11 @@ 
 		$updatesource=false;

 		$updatetarget=false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $updatetarget=true;

+		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) {
+		    $updatesource=true;
+		} else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) {
+		    $updatetarget=true;
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_element SET ";

 		if ($updatesource)

@@ -3165,8 +3421,7 @@ 
 			$sql.= ", sourcetype = '".$this->db->escape($sourcetype)."'";

 			$sql.= " WHERE fk_target = ".$this->id;

 			$sql.= " AND targettype = '".$this->db->escape($this->element)."'";

-		}

-		else if ($updatetarget)

+		} else if ($updatetarget)

 		{

 			$sql.= "fk_target = ".$targetid;

 			$sql.= ", targettype = '".$this->db->escape($targettype)."'";

@@ -3178,8 +3433,7 @@ 
 		if ($this->db->query($sql))

 		{

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -3202,8 +3456,11 @@ 
 		$deletesource=false;

 		$deletetarget=false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $deletetarget=true;

+		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) {
+		    $deletesource=true;
+		} else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) {
+		    $deletetarget=true;
+		}
 

 		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

 		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

@@ -3215,20 +3472,17 @@ 
 		if ($rowid > 0)

 		{

 			$sql.=" rowid = ".$rowid;

-		}

-		else

+		} else

 		{

 			if ($deletesource)

 			{

 				$sql.= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";

 				$sql.= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";

-			}

-			else if ($deletetarget)

+			} else if ($deletetarget)

 			{

 				$sql.= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";

 				$sql.= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";

-			}

-			else

+			} else

 			{

 				$sql.= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";

 				$sql.= " OR";

@@ -3240,8 +3494,7 @@ 
 		if ($this->db->query($sql))

 		{

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->errors[]=$this->error;

@@ -3270,17 +3523,31 @@ 
 		$this->db->begin();

 

 		$fieldstatus="fk_statut";

-		if ($elementTable == 'facture_rec') $fieldstatus="suspended";

-		if ($elementTable == 'mailing') $fieldstatus="statut";

-		if ($elementTable == 'cronjob') $fieldstatus="status";

-		if ($elementTable == 'user') $fieldstatus="statut";

-		if ($elementTable == 'expensereport') $fieldstatus="fk_statut";

-		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus="status";

+		if ($elementTable == 'facture_rec') {
+		    $fieldstatus="suspended";
+		}
+		if ($elementTable == 'mailing') {
+		    $fieldstatus="statut";
+		}
+		if ($elementTable == 'cronjob') {
+		    $fieldstatus="status";
+		}
+		if ($elementTable == 'user') {
+		    $fieldstatus="statut";
+		}
+		if ($elementTable == 'expensereport') {
+		    $fieldstatus="fk_statut";
+		}
+		if ($elementTable == 'commande_fournisseur_dispatch') {
+		    $fieldstatus="status";
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$elementTable;

 		$sql.= " SET ".$fieldstatus." = ".$status;

 		// If status = 1 = validated, update also fk_user_valid

-		if ($status == 1 && $elementTable == 'expensereport') $sql.=", fk_user_valid = ".$user->id;

+		if ($status == 1 && $elementTable == 'expensereport') {
+		    $sql.=", fk_user_valid = ".$user->id;
+		}
 		$sql.= " WHERE rowid=".$elementId;

 

 		dol_syslog(get_class($this)."::setStatut", LOG_DEBUG);

@@ -3291,12 +3558,27 @@ 
 			// Try autoset of trigkey

 			if (empty($trigkey))

 			{

-				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey='SUPPLIER_PROPOSAL_SIGN';   // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey='SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey='SUPPLIER_PROPOSAL_CLOSE';  // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

-				if ($this->element == 'fichinter' && $status == 3) $trigkey='FICHINTER_CLASSIFY_DONE';

-				if ($this->element == 'fichinter' && $status == 2) $trigkey='FICHINTER_CLASSIFY_BILLED';

-				if ($this->element == 'fichinter' && $status == 1) $trigkey='FICHINTER_CLASSIFY_UNBILLED';

+				if ($this->element == 'supplier_proposal' && $status == 2) {
+				    $trigkey='SUPPLIER_PROPOSAL_SIGN';
+				}
+				// 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

+				if ($this->element == 'supplier_proposal' && $status == 3) {
+				    $trigkey='SUPPLIER_PROPOSAL_REFUSE';
+				}
+				// 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

+				if ($this->element == 'supplier_proposal' && $status == 4) {
+				    $trigkey='SUPPLIER_PROPOSAL_CLOSE';
+				}
+				// 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

+				if ($this->element == 'fichinter' && $status == 3) {
+				    $trigkey='FICHINTER_CLASSIFY_DONE';
+				}
+				if ($this->element == 'fichinter' && $status == 2) {
+				    $trigkey='FICHINTER_CLASSIFY_BILLED';
+				}
+				if ($this->element == 'fichinter' && $status == 1) {
+				    $trigkey='FICHINTER_CLASSIFY_UNBILLED';
+				}
 			}

 

 			if ($trigkey)

@@ -3315,22 +3597,22 @@ 
 			{

 				$this->db->commit();

 

-				if (empty($savElementId))    // If the element we update was $this (so $elementId is null)

+				if (empty($savElementId)) {
+				    // If the element we update was $this (so $elementId is null)

 				{

-					$this->statut = $status;

+					$this->statut = $status;
+				}
 					$this->status = $status;

 				}

 

 				return 1;

-			}

-			else

+			} else

 			{

 				$this->db->rollback();

 				dol_syslog(get_class($this)."::setStatus ".$this->error,LOG_ERR);

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -3350,8 +3632,13 @@ 
 	{

 		global $conf;

 

-		if (empty($id) && empty($ref)) return 0;

-		if (! empty($conf->global->MAIN_DISABLE_CANVAS)) return 0;    // To increase speed. Not enabled by default.

+		if (empty($id) && empty($ref)) {
+		    return 0;
+		}
+		if (! empty($conf->global->MAIN_DISABLE_CANVAS)) {
+		    return 0;
+		}
+		// To increase speed. Not enabled by default.

 

 		// Clean parameters

 		$ref = trim($ref);

@@ -3359,8 +3646,12 @@ 
 		$sql = "SELECT rowid, canvas";

 		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element;

 		$sql.= " WHERE entity IN (".getEntity($this->element).")";

-		if (! empty($id))  $sql.= " AND rowid = ".$id;

-		if (! empty($ref)) $sql.= " AND ref = '".$this->db->escape($ref)."'";

+		if (! empty($id)) {
+		    $sql.= " AND rowid = ".$id;
+		}
+		if (! empty($ref)) {
+		    $sql.= " AND ref = '".$this->db->escape($ref)."'";
+		}
 

 		$resql = $this->db->query($sql);

 		if ($resql)

@@ -3370,10 +3661,10 @@ 
 			{

 				$this->canvas   = $obj->canvas;

 				return 1;

-			}

-			else return 0;

-		}

-		else

+			} else {
+			    return 0;
+			}
+		} else

 		{

 			dol_print_error($this->db);

 			return -1;

@@ -3410,7 +3701,9 @@ 
 	{

 		global $langs;

 

-		if (empty($id)) $id=$this->id;

+		if (empty($id)) {
+		    $id=$this->id;
+		}
 

 		// Check parameters

 		if (! isset($this->childtables) || ! is_array($this->childtables) || count($this->childtables) == 0)

@@ -3444,18 +3737,18 @@ 
 					$langs->load("errors");

 					//print 'Found into table '.$table.', type '.$langs->transnoentitiesnoconv($elementname).', haschild='.$haschild;

 					$haschild += $obj->nb;

-					if (is_numeric($elementname))	// old usage

+					if (is_numeric($elementname)) {
+					    // old usage

 					{

-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);

-					}

-					else	// new usage: $elementname=Translation key

+						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);
+					}
+					} else	// new usage: $elementname=Translation key

 					{

 						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));

 					}

 					break;    // We found at least one, we stop here

 				}

-			}

-			else

+			} else

 			{

 				$this->errors[]=$this->db->lasterror();

 				return -1;

@@ -3465,8 +3758,9 @@ 
 		{

 			$this->errors[]="ErrorRecordHasChildren";

 			return $haschild;

-		}

-		else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

 	/**

@@ -3482,12 +3776,24 @@ 
 		foreach($this->lines as $key => $val)

 		{

 			$qualified=0;

-			if ($predefined == -1) $qualified=1;

-			if ($predefined == 1 && $val->fk_product > 0) $qualified=1;

-			if ($predefined == 0 && $val->fk_product <= 0) $qualified=1;

-			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) $qualified=1;

-			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) $qualified=1;

-			if ($qualified) $nb++;

+			if ($predefined == -1) {
+			    $qualified=1;
+			}
+			if ($predefined == 1 && $val->fk_product > 0) {
+			    $qualified=1;
+			}
+			if ($predefined == 0 && $val->fk_product <= 0) {
+			    $qualified=1;
+			}
+			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) {
+			    $qualified=1;
+			}
+			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) {
+			    $qualified=1;
+			}
+			if ($qualified) {
+			    $nb++;
+			}
 		}

 		dol_syslog(get_class($this).'::hasProductsOrServices we found '.$nb.' qualified lines of products/servcies');

 		return $nb;

@@ -3551,16 +3857,24 @@ 
 		{

 			if (isset($line->qty_asked))

 			{

-				if (empty($totalOrdered)) $totalOrdered=0;  // Avoid warning because $totalOrdered is ''

+				if (empty($totalOrdered)) {
+				    $totalOrdered=0;
+				}
+				// Avoid warning because $totalOrdered is ''

 				$totalOrdered+=$line->qty_asked;    // defined for shipment only

 			}

 			if (isset($line->qty_shipped))

 			{

-				if (empty($totalToShip)) $totalToShip=0;    // Avoid warning because $totalToShip is ''

+				if (empty($totalToShip)) {
+				    $totalToShip=0;
+				}
+				// Avoid warning because $totalToShip is ''

 				$totalToShip+=$line->qty_shipped;   // defined for shipment only

-            }else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

+            } else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

             {

-                if (empty($totalToShip)) $totalToShip=0;

+                if (empty($totalToShip)) {
+                    $totalToShip=0;
+                }
                 $totalToShip+=$line->qty;   // defined for reception only

 			}

 

@@ -3568,8 +3882,7 @@ 
 			if ($this->element == 'shipping') {

 				// for shipments

 				$qty = $line->qty_shipped ? $line->qty_shipped : 0;

-			}

-			else {

+			} else {

 				$qty = $line->qty ? $line->qty : 0;

 			}

 

@@ -3585,19 +3898,30 @@ 
 

 			$weightUnit=0;

 			$volumeUnit=0;

-			if (! empty($weight_units)) $weightUnit = $weight_units;

-			if (! empty($volume_units)) $volumeUnit = $volume_units;

-

-			if (empty($totalWeight)) $totalWeight=0;  // Avoid warning because $totalWeight is ''

-			if (empty($totalVolume)) $totalVolume=0;  // Avoid warning because $totalVolume is ''

+			if (! empty($weight_units)) {
+			    $weightUnit = $weight_units;
+			}
+			if (! empty($volume_units)) {
+			    $volumeUnit = $volume_units;
+			}
+

+			if (empty($totalWeight)) {
+			    $totalWeight=0;
+			}
+			// Avoid warning because $totalWeight is ''

+			if (empty($totalVolume)) {
+			    $totalVolume=0;
+			}
+			// Avoid warning because $totalVolume is ''

 

 			//var_dump($line->volume_units);

-			if ($weight_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

+			if ($weight_units < 50) {
+			    // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

 			{

-				$trueWeightUnit=pow(10, $weightUnit);

+				$trueWeightUnit=pow(10, $weightUnit);
+			}
 				$totalWeight += $weight * $qty * $trueWeightUnit;

-			}

-			else {

+			} else {

 		if ($weight_units == 99) {

 			// conversion 1 Pound = 0.45359237 KG

 			$trueWeightUnit = 0.45359237;

@@ -3606,18 +3930,20 @@ 
 			// conversion 1 Ounce = 0.0283495 KG

 			$trueWeightUnit = 0.0283495;

 			$totalWeight += $weight * $qty * $trueWeightUnit;

-		}

-		else

-					$totalWeight += $weight * $qty;   // This may be wrong if we mix different units

+		} else {
+							$totalWeight += $weight * $qty;
+		}
+		// This may be wrong if we mix different units

 			}

-			if ($volume_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

+			if ($volume_units < 50) {
+			    // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

 			{

 				//print $line->volume."x".$line->volume_units."x".($line->volume_units < 50)."x".$volumeUnit;

-				$trueVolumeUnit=pow(10, $volumeUnit);

+				$trueVolumeUnit=pow(10, $volumeUnit);
+			}
 				//print $line->volume;

 				$totalVolume += $volume * $qty * $trueVolumeUnit;

-			}

-			else

+			} else

 			{

 				$totalVolume += $volume * $qty;   // This may be wrong if we mix different units

 			}

@@ -3649,8 +3975,7 @@ 
 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

 			return -1;

-		}

-		else

+		} else

 		{

 			$this->db->commit();

 			return 1;

@@ -3702,13 +4027,11 @@ 
 			{

 				$res = $this->db->fetch_object($resql);

 				return 'Incoterm : '.$res->code.' - '.$this->location_incoterms;

-			}

-			else

+			} else

 			{

 				return '';

 			}

-		}

-		else

+		} else

 		{

 			$this->errors[] = $this->db->lasterror();

 			return false;

@@ -3745,14 +4068,14 @@ 
 					$this->libelle_incoterms = $obj->libelle;

 				}

 				return 1;

-			}

-			else

+			} else

 			{

 				$this->errors[] = $this->db->lasterror();

 				return -1;

 			}

-		}

-		else return -1;

+		} else {
+		    return -1;
+		}
 	}

 

 

@@ -3791,7 +4114,9 @@ 
 			} else {

 				$res=include $tpl; // for debug

 			}

-			if ($res) break;

+			if ($res) {
+			    break;
+			}
 		}

 	}

 

@@ -3821,7 +4146,9 @@ 
 

 		// Define usemargins

 		$usemargins=0;

-		if (! empty($conf->margin->enabled) && ! empty($this->element) && in_array($this->element,array('facture','propal','commande'))) $usemargins=1;

+		if (! empty($conf->margin->enabled) && ! empty($this->element) && in_array($this->element,array('facture','propal','commande'))) {
+		    $usemargins=1;
+		}
 

 		$num = count($this->lines);

 

@@ -3840,7 +4167,9 @@ 
 			print '<tr class="liste_titre nodrag nodrop">';

 

 			// Adds a line numbering column

-			if (! empty($conf->global->MAIN_VIEW_LINE_NUMBER)) print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';

+			if (! empty($conf->global->MAIN_VIEW_LINE_NUMBER)) {
+			    print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';
+			}
 

 			// Description

 			print '<td class="linecoldescription">'.$langs->trans('Description').'</td>';

@@ -3857,9 +4186,13 @@ 
 			print '<td class="linecoluht" align="right" width="80">'.$langs->trans('PriceUHT').'</td>';

 

 			// Multicurrency

-			if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) print '<td class="linecoluht_currency" align="right" width="80">'.$langs->trans('PriceUHTCurrency', $this->multicurrency_code).'</td>';

+			if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) {
+			    print '<td class="linecoluht_currency" align="right" width="80">'.$langs->trans('PriceUHTCurrency', $this->multicurrency_code).'</td>';
+			}
 

-			if ($inputalsopricewithtax) print '<td align="right" width="80">'.$langs->trans('PriceUTTC').'</td>';

+			if ($inputalsopricewithtax) {
+			    print '<td align="right" width="80">'.$langs->trans('PriceUTTC').'</td>';
+			}
 

 			// Qty

 			print '<td class="linecolqty" align="right">'.$langs->trans('Qty').'</td>';

@@ -3880,25 +4213,32 @@ 
 			{

 				if (!empty($user->rights->margins->creer))

 				{

-					if ($conf->global->MARGIN_TYPE == "1")

-						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('BuyingPrice').'</td>';

-					else

-						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';

+					if ($conf->global->MARGIN_TYPE == "1") {
+											print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('BuyingPrice').'</td>';
+					} else {
+											print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';
+					}
 				}

 

-				if (! empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)

-					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';

-				if (! empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)

-					print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';

+				if (! empty($conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous) {
+									print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';
+				}
+				if (! empty($conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous) {
+									print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';
+				}
 			}

 

 			// Total HT

 			print '<td class="linecolht" align="right">'.$langs->trans('TotalHTShort').'</td>';

 

 			// Multicurrency

-			if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) print '<td class="linecoltotalht_currency" align="right">'.$langs->trans('TotalHTShortCurrency', $this->multicurrency_code).'</td>';

+			if (!empty($conf->multicurrency->enabled) && $this->multicurrency_code != $conf->currency) {
+			    print '<td class="linecoltotalht_currency" align="right">'.$langs->trans('TotalHTShortCurrency', $this->multicurrency_code).'</td>';
+			}
 

-			if ($outputalsopricetotalwithtax) print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';

+			if ($outputalsopricetotalwithtax) {
+			    print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';
+			}
 

 			print '<td class="linecoledit"></td>';  // No width to allow autodim

 

@@ -3928,14 +4268,15 @@ 
 			$line->fetch_optionals();

 

 			//if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

-			if (is_object($hookmanager))   // Old code is commented on preceding line.

+			if (is_object($hookmanager)) {
+			    // Old code is commented on preceding line.

 			{

 				if (empty($line->fk_parent_line))

 				{

-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

+					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);
+			}
 					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

-				}

-				else

+				} else

 				{

 					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);

 					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

@@ -3982,8 +4323,14 @@ 
 		// Show product and description

 		$type=(! empty($line->product_type)?$line->product_type:$line->fk_product_type);

 		// Try to enhance type detection using date_start and date_end for free lines where type was not saved.

-		if (! empty($line->date_start)) $type=1; // deprecated

-		if (! empty($line->date_end)) $type=1; // deprecated

+		if (! empty($line->date_start)) {
+		    $type=1;
+		}
+		// deprecated

+		if (! empty($line->date_end)) {
+		    $type=1;
+		}
+		// deprecated

 

 		// Ligne en mode visu

 		if ($action != 'editline' || $selected != $line->id)

@@ -4012,8 +4359,13 @@ 
 

 					$outputlangs = $langs;

 					$newlang='';

-					if (empty($newlang) && GETPOST('lang_id','aZ09')) $newlang=GETPOST('lang_id','aZ09');

-					if (! empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) $newlang=$this->thirdparty->default_lang;		// For language to language of customer

+					if (empty($newlang) && GETPOST('lang_id','aZ09')) {
+					    $newlang=GETPOST('lang_id','aZ09');
+					}
+					if (! empty($conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) {
+					    $newlang=$this->thirdparty->default_lang;
+					}
+					// For language to language of customer

 					if (! empty($newlang))

 					{

 						$outputlangs = new Translate("",$conf);

@@ -4021,8 +4373,7 @@ 
 					}

 

 					$label = (! empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;

-				}

-				else

+				} else

 				{

 					$label = $line->product_label;

 				}

@@ -4044,7 +4395,9 @@ 
 				} else {

 					$res=include $tpl; // for debug

 				}

-				if ($res) break;

+				if ($res) {
+				    break;
+				}
 			}

 		}

 

@@ -4067,7 +4420,9 @@ 
 				} else {

 					$res=include $tpl; // for debug

 				}

-				if ($res) break;

+				if ($res) {
+				    break;
+				}
 			}

 		}

 	}

@@ -4094,7 +4449,9 @@ 
 		print '<td>'.$langs->trans('Description').'</td>';

 		print '<td align="right">'.$langs->trans('VATRate').'</td>';

 		print '<td align="right">'.$langs->trans('PriceUHT').'</td>';

-		if (!empty($conf->multicurrency->enabled)) print '<td align="right">'.$langs->trans('PriceUHTCurrency').'</td>';

+		if (!empty($conf->multicurrency->enabled)) {
+		    print '<td align="right">'.$langs->trans('PriceUHTCurrency').'</td>';
+		}
 		print '<td align="right">'.$langs->trans('Qty').'</td>';

 		if($conf->global->PRODUCT_USE_UNITS)

 		{

@@ -4117,8 +4474,7 @@ 
 						$action='';

 						$hookmanager->executeHooks('printOriginObjectLine',$parameters,$this,$action);    // Note that $action and $object may have been modified by some hooks

 					}

-				}

-				else

+				} else

 				{

 					$this->printOriginLine($line, $var, $restrictlist);

 				}

@@ -4147,32 +4503,37 @@ 
 		if (!empty($line->date_start))

 		{

 			$date_start=$line->date_start;

-		}

-		else

+		} else

 		{

 			$date_start=$line->date_debut_prevue;

-			if ($line->date_debut_reel) $date_start=$line->date_debut_reel;

+			if ($line->date_debut_reel) {
+			    $date_start=$line->date_debut_reel;
+			}
 		}

 		if (!empty($line->date_end))

 		{

 			$date_end=$line->date_end;

-		}

-		else

+		} else

 		{

 			$date_end=$line->date_fin_prevue;

-			if ($line->date_fin_reel) $date_end=$line->date_fin_reel;

+			if ($line->date_fin_reel) {
+			    $date_end=$line->date_fin_reel;
+			}
 		}

 

 		$this->tpl['label'] = '';

-		if (! empty($line->fk_parent_line)) $this->tpl['label'].= img_picto('', 'rightarrow');

+		if (! empty($line->fk_parent_line)) {
+		    $this->tpl['label'].= img_picto('', 'rightarrow');
+		}
 

-		if (($line->info_bits & 2) == 2)  // TODO Not sure this is used for source object

+		if (($line->info_bits & 2) == 2) {
+		    // TODO Not sure this is used for source object

 		{

-			$discount=new DiscountAbsolute($this->db);

+			$discount=new DiscountAbsolute($this->db);
+		}
 			$discount->fk_soc = $this->socid;

 			$this->tpl['label'].= $discount->getNomUrl(0,'discount');

-		}

-		else if (! empty($line->fk_product))

+		} else if (! empty($line->fk_product))

 		{

 			$productstatic = new Product($this->db);

 			$productstatic->id = $line->fk_product;

@@ -4190,13 +4551,12 @@ 
 			{

 				$this->tpl['label'].= get_date_range($date_start,$date_end);

 			}

-		}

-		else

+		} else

 		{

 			$this->tpl['label'].= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''),'service') : img_object($langs->trans(''),'product')));

 			if (!empty($line->desc)) {

 				$this->tpl['label'].=$line->desc;

-			}else {

+			} else {

 				$this->tpl['label'].= ($line->label ? '&nbsp;'.$line->label : '');

 			}

 			

@@ -4209,36 +4569,35 @@ 
 

 		if (! empty($line->desc))

 		{

-			if ($line->desc == '(CREDIT_NOTE)')  // TODO Not sure this is used for source object

+			if ($line->desc == '(CREDIT_NOTE)') {
+			    // TODO Not sure this is used for source object

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount=new DiscountAbsolute($this->db);
+			}
 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(DEPOSIT)')  // TODO Not sure this is used for source object

+			} elseif ($line->desc == '(DEPOSIT)') {
+			    // TODO Not sure this is used for source object

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount=new DiscountAbsolute($this->db);
+			}
 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(EXCESS RECEIVED)')

+			} elseif ($line->desc == '(EXCESS RECEIVED)')

 			{

 				$discount=new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(EXCESS PAID)')

+			} elseif ($line->desc == '(EXCESS PAID)')

 			{

 				$discount=new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid",$discount->getNomUrl(0));

-			}

-			else

+			} else

 			{

 				$this->tpl['description'] = dol_trunc($line->desc,60);

 			}

-		}

-		else

+		} else

 		{

 			$this->tpl['description'] = '&nbsp;';

 		}

@@ -4246,17 +4605,23 @@ 
         // VAT Rate

         $this->tpl['vat_rate'] = vatrate($line->tva_tx, true);

         $this->tpl['vat_rate'] .= (($line->info_bits & 1) == 1) ? '*' : '';

-        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';

+        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) {
+            $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';
+        }
 

 		$this->tpl['price'] = price($line->subprice);

 		$this->tpl['multicurrency_price'] = price($line->multicurrency_subprice);

 		$this->tpl['qty'] = (($line->info_bits & 2) != 2) ? $line->qty : '&nbsp;';

-		if ($conf->global->PRODUCT_USE_UNITS) $this->tpl['unit'] = $langs->transnoentities($line->getLabelOfUnit('long'));

+		if ($conf->global->PRODUCT_USE_UNITS) {
+		    $this->tpl['unit'] = $langs->transnoentities($line->getLabelOfUnit('long'));
+		}
 		$this->tpl['remise_percent'] = (($line->info_bits & 2) != 2) ? vatrate($line->remise_percent, true) : '&nbsp;';

 

 		// Is the line strike or not

 		$this->tpl['strike']=0;

-		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike']=1;

+		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) {
+		    $this->tpl['strike']=1;
+		}
 

 		// Output template part (modules that overwrite templates must declare this into descriptor)

 		// Use global variables + $dateSelector + $seller and $buyer

@@ -4269,7 +4634,9 @@ 
 			} else {

 				$res=include $tpl; // for debug

 			}

-			if ($res) break;

+			if ($res) {
+			    break;
+			}
 		}

 	}

 

@@ -4311,8 +4678,7 @@ 
 		{

 			$this->db->commit();

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -4347,8 +4713,7 @@ 
 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

 			return -1;

-		}

-		else

+		} else

 		{

 			if (! $notrigger)

 			{

@@ -4415,13 +4780,20 @@ 
 		// Search template files

 		$file=''; $classname=''; $filefound=0;

 		$dirmodels=array('/');

-		if (is_array($conf->modules_parts['models'])) $dirmodels=array_merge($dirmodels,$conf->modules_parts['models']);

+		if (is_array($conf->modules_parts['models'])) {
+		    $dirmodels=array_merge($dirmodels,$conf->modules_parts['models']);
+		}
 		foreach($dirmodels as $reldir)

 		{

 			foreach(array('doc','pdf') as $prefix)

 			{

-				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php";     // Member module use prefix_module.class.php

-				else $file = $prefix."_".$modele.".modules.php";

+				if (in_array(get_class($this), array('Adherent'))) {
+				    $file = $prefix."_".$modele.".class.php";
+				}
+				// Member module use prefix_module.class.php

+				else {
+				    $file = $prefix."_".$modele.".modules.php";
+				}
 

 				// On verifie l'emplacement du modele

 				$file=dol_buildpath($reldir.$modelspath.$file,0);

@@ -4432,7 +4804,9 @@ 
 					break;

 				}

 			}

-			if ($filefound) break;

+			if ($filefound) {
+			    break;
+			}
 		}

 

 		// If generator was found

@@ -4464,7 +4838,9 @@ 
 						if (is_dir($tmpdir))

 						{

 							$tmpfiles=dol_dir_list($tmpdir,'files',0,'\.od(s|t)$','','name',SORT_ASC,0);

-							if (count($tmpfiles)) $listoffiles=array_merge($listoffiles,$tmpfiles);

+							if (count($tmpfiles)) {
+							    $listoffiles=array_merge($listoffiles,$tmpfiles);
+							}
 						}

 					}

 

@@ -4502,8 +4878,7 @@ 
 			{

 				$arrayofrecords = array();   // The write_file of templates of adherent class need this var

 				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, 'member', 1, $moreparams);

-			}

-			else

+			} else

 			{

 				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, $hidedetails, $hidedesc, $hideref, $moreparams);

 			}

@@ -4525,9 +4900,11 @@ 
 					$destfile = basename($destfull);

 					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $upload_dir);

 

-					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir

+					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir)) {
+					    // If not a tmp dir

 					{

-						$filename = basename($destfile);

+						$filename = basename($destfile);
+					}
 						$rel_dir = preg_replace('/[\\/]$/', '', $rel_dir);

 						$rel_dir = preg_replace('/^[\\/]/', '', $rel_dir);

 

@@ -4540,18 +4917,30 @@ 
 						if ($this->element == 'propal')

 						{

 							$useonlinesignature = $conf->global->MAIN_FEATURES_LEVEL;	// Replace this with 1 when feature to make online signature is ok

-							if ($useonlinesignature) $setsharekey=true;

-							if (! empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

+							if ($useonlinesignature) {
+							    $setsharekey=true;
+							}
+							if (! empty($conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) {
+							    $setsharekey=true;
+							}
 						}

-						if ($this->element == 'commande'     && ! empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))        $setsharekey=true;

-						if ($this->element == 'facture'      && ! empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))      $setsharekey=true;

-						if ($this->element == 'bank_account' && ! empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) $setsharekey=true;

+						if ($this->element == 'commande'     && ! empty($conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD)) {
+						    $setsharekey=true;
+						}
+						if ($this->element == 'facture'      && ! empty($conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD)) {
+						    $setsharekey=true;
+						}
+						if ($this->element == 'bank_account' && ! empty($conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) {
+						    $setsharekey=true;
+						}
 

 						if ($setsharekey)

 						{

-							if (empty($ecmfile->share))	// Because object not found or share not set yet

+							if (empty($ecmfile->share)) {
+							    // Because object not found or share not set yet

 							{

-								require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

+								require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';
+							}
 								$ecmfile->share = getRandomPassword(true);

 							}

 						}

@@ -4568,8 +4957,7 @@ 
 							{

 								setEventMessages($ecmfile->error, $ecmfile->errors, 'warnings');

 							}

-						}

-						else

+						} else

 						{

 							$ecmfile->entity = $conf->entity;

 							$ecmfile->filepath = $rel_dir;

@@ -4596,17 +4984,20 @@ 
 

 						// Update the last_main_doc field into main object (if documenent generator has property ->update_main_doc_field set)

 						$update_main_doc_field=0;

-						if (! empty($obj->update_main_doc_field)) $update_main_doc_field=1;

+						if (! empty($obj->update_main_doc_field)) {
+						    $update_main_doc_field=1;
+						}
 						if ($update_main_doc_field && ! empty($this->table_element))

 						{

 							$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element." SET last_main_doc = '".($ecmfile->filepath.'/'.$ecmfile->filename)."'";

 							$sql.= ' WHERE rowid = '.$this->id;

 							$resql = $this->db->query($sql);

-							if (! $resql) dol_print_error($this->db);

+							if (! $resql) {
+							    dol_print_error($this->db);
+							}
 						}

 					}

-				}

-				else

+				} else

 				{

 					dol_syslog('Method ->write_file was called on object '.get_class($obj).' and return a success but the return array ->result["fullpath"] was not set.', LOG_WARNING);

 				}

@@ -4615,15 +5006,13 @@ 
 				dol_meta_create($this);

 

 				return 1;

-			}

-			else

+			} else

 			{

 				$outputlangs->charset_output=$sav_charset_output;

 				dol_print_error($this->db, "Error generating document for ".__CLASS__.". Error: ".$obj->error, $obj->errors);

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);

 			dol_print_error('',$this->error);

@@ -4679,13 +5068,21 @@ 
 		global $conf, $_POST;

 

 		// If param here has been posted, we use this value first.

-		if (isset($_POST[$fieldname])) return GETPOST($fieldname, 2);

+		if (isset($_POST[$fieldname])) {
+		    return GETPOST($fieldname, 2);
+		}
 

-		if (isset($alternatevalue)) return $alternatevalue;

+		if (isset($alternatevalue)) {
+		    return $alternatevalue;
+		}
 

 		$newelement=$this->element;

-		if ($newelement == 'facture') $newelement='invoice';

-		if ($newelement == 'commande') $newelement='order';

+		if ($newelement == 'facture') {
+		    $newelement='invoice';
+		}
+		if ($newelement == 'commande') {
+		    $newelement='order';
+		}
 		if (empty($newelement))

 		{

 			dol_syslog("Ask a default value using common method getDefaultCreateValueForField on an object with no property ->element defined. Return empty string.", LOG_WARNING);

@@ -4694,7 +5091,9 @@ 
 

 		$keyforfieldname=strtoupper($newelement.'_DEFAULT_'.$fieldname);

 		//var_dump($keyforfieldname);

-		if (isset($conf->global->$keyforfieldname)) return $conf->global->$keyforfieldname;

+		if (isset($conf->global->$keyforfieldname)) {
+		    return $conf->global->$keyforfieldname;
+		}
 

 		// TODO Ad here a scan into table llx_overwrite_default with a filter on $this->element and $fieldname

 	}

@@ -4728,8 +5127,7 @@ 
 			if (!empty($this->errors))

 			{

 				$this->errors=array_unique(array_merge($this->errors,$interface->errors));   // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.

-			}

-			else

+			} else

 			{

 				$this->errors=$interface->errors;

 			}

@@ -4753,7 +5151,9 @@ 
 	function fetch_optionals($rowid=null, $optionsArray=null)

 	{

         // phpcs:enable

-		if (empty($rowid)) $rowid=$this->id;

+		if (empty($rowid)) {
+		    $rowid=$this->id;
+		}
 

 		// To avoid SQL errors. Probably not the better solution though

 		if (!$this->table_element) {

@@ -4779,15 +5179,17 @@ 
 				$extrafields->fetch_name_optionals_label($this->table_element);

 			}

 			$optionsArray = (! empty($extrafields->attributes[$this->table_element]['label'])?$extrafields->attributes[$this->table_element]['label']:null);

-		}

-		else

+		} else

 		{

 			global $extrafields;

 			dol_syslog("Warning: fetch_optionals was called with param optionsArray defined when you should pass null now", LOG_WARNING);

 		}

 

 		$table_element = $this->table_element;

-		if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+		if ($table_element == 'categorie') {
+		    $table_element = 'categories';
+		}
+		// For compatibility

 

 		// Request to get complementary values

 		if (is_array($optionsArray) && count($optionsArray) > 0)

@@ -4823,8 +5225,7 @@ 
 							{

 								//var_dump($extrafields->attributes[$this->table_element]['type'][$key]);

 								$this->array_options["options_".$key]=$this->db->jdate($value);

-							}

-							else

+							} else

 							{

 								$this->array_options["options_".$key]=$value;

 							}

@@ -4836,10 +5237,12 @@ 
 

 				$this->db->free($resql);

 

-				if ($numrows) return $numrows;

-				else return 0;

-			}

-			else

+				if ($numrows) {
+				    return $numrows;
+				} else {
+				    return 0;
+				}
+			} else

 			{

 				dol_print_error($this->db);

 				return -1;

@@ -4858,7 +5261,10 @@ 
 		$this->db->begin();

 

 		$table_element = $this->table_element;

-		if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+		if ($table_element == 'categorie') {
+		    $table_element = 'categories';
+		}
+		// For compatibility

 

 		$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

 		dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);

@@ -4868,8 +5274,7 @@ 
 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

 			return -1;

-		}

-		else

+		} else

 		{

 			$this->db->commit();

 			return 1;

@@ -4890,11 +5295,16 @@ 
 	{

 		global $conf,$langs,$user;

 

-		if (empty($userused)) $userused=$user;

+		if (empty($userused)) {
+		    $userused=$user;
+		}
 

 		$error=0;

 

-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

+		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) {
+		    return 0;
+		}
+		// For avoid conflicts if trigger used

 

 		if (! empty($this->array_options))

 		{

@@ -4907,10 +5317,13 @@ 
 			//Eliminate copied source object extra_fields that do not exist in target object

 			$new_array_options=array();

 			foreach ($this->array_options as $key => $value) {

-				if (in_array(substr($key,8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test

-					$new_array_options[$key] = $value;

-				elseif (in_array($key, array_keys($target_extrafields)))		// We test on $key that does not contains the 'options_' prefix

-					$new_array_options['options_'.$key] = $value;

+				if (in_array(substr($key,8), array_keys($target_extrafields))) {
+				    // We remove the 'options_' from $key for test

+					$new_array_options[$key] = $value;
+				} elseif (in_array($key, array_keys($target_extrafields))) {
+				    // We test on $key that does not contains the 'options_' prefix

+					$new_array_options['options_'.$key] = $value;
+				}
 			}

 

 			foreach($new_array_options as $key => $value)

@@ -4924,8 +5337,12 @@ 
 			   	if ($attributeRequired)

 			   	{

 			   		$mandatorypb=false;

-			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb=true;

-			   		if ($this->array_options[$key] === '') $mandatorypb=true;

+			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') {
+			   		    $mandatorypb=true;
+			   		}
+			   		if ($this->array_options[$key] === '') {
+			   		    $mandatorypb=true;
+			   		}
 			   		if ($mandatorypb)

 			   		{

 			   			dol_syslog($this->error);

@@ -4944,8 +5361,7 @@ 
 			   			{

 			   				$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 			   				return -1;

-			  			}

-			   			elseif ($value=='')

+			  			} elseif ($value=='')

 			   			{

 			   				$new_array_options[$key] = null;

 			   			}

@@ -4957,8 +5373,7 @@ 
 							dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

 							$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 							return -1;

-						}

-						elseif ($value=='')

+						} elseif ($value=='')

 						{

 							$new_array_options[$key] = null;

 						}

@@ -4983,27 +5398,27 @@ 
 			   					//global $action;		// $action may be 'create', 'update', 'update_extras'...

 			   					//var_dump($action);

 			   					//var_dump($this->oldcopy);exit;

-			   					if (is_object($this->oldcopy))		// If this->oldcopy is not defined, we can't know if we change attribute or not, so we must keep value

+			   					if (is_object($this->oldcopy)) {
+			   					    // If this->oldcopy is not defined, we can't know if we change attribute or not, so we must keep value

 			   					{

 			   						//var_dump($this->oldcopy->array_options[$key]); var_dump($this->array_options[$key]);

 				   					if ($this->array_options[$key] == $this->oldcopy->array_options[$key])	// If old value crypted in database is same than submited new value, it means we don't change it, so we don't update.

 				   					{

-				   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

-				   					}

-									else

+				   						$new_array_options[$key] = $this->array_options[$key];
+			   					}
+			   					// Value is kept

+				   					} else

 									{

 										// var_dump($algo);

 										$newvalue = dol_hash($this->array_options[$key], $algo);

 										$new_array_options[$key] = $newvalue;

 									}

-			   					}

-			   					else

+			   					} else

 			   					{

 			   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

 			   					}

 			   				}

-			   			}

-			   			else	// Common usage

+			   			} else	// Common usage

 			   			{

 			   				$new_array_options[$key] = $this->array_options[$key];

 			   			}

@@ -5029,26 +5444,30 @@ 
 						dol_include_once($InfoFieldList[1]);

 						if ($InfoFieldList[0] && class_exists($InfoFieldList[0]))

 						{

-							if ($value == '-1')	// -1 is key for no defined in combo list of objects

+							if ($value == '-1') {
+							    // -1 is key for no defined in combo list of objects

 							{

-								$new_array_options[$key]='';

-							}

-							elseif ($value)

+								$new_array_options[$key]='';
+							}
+							} elseif ($value)

 							{

 								$object = new $InfoFieldList[0]($this->db);

-								if (is_numeric($value)) $res=$object->fetch($value);

-								else $res=$object->fetch('',$value);

-

-								if ($res > 0) $new_array_options[$key]=$object->id;

-								else

+								if (is_numeric($value)) {
+								    $res=$object->fetch($value);
+								} else {
+								    $res=$object->fetch('',$value);
+								}
+

+								if ($res > 0) {
+								    $new_array_options[$key]=$object->id;
+								} else

 								{

 									$this->error="Id/Ref '".$value."' for object '".$object->element."' not found";

 									$this->db->rollback();

 									return -1;

 								}

 							}

-						}

-						else

+						} else

 						{

 							dol_syslog('Error bad setup of extrafield', LOG_WARNING);

 						}

@@ -5059,7 +5478,10 @@ 
 			$this->db->begin();

 

 			$table_element = $this->table_element;

-			if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+			if ($table_element == 'categorie') {
+			    $table_element = 'categories';
+			}
+			// For compatibility

 

 			$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

 			dol_syslog(get_class($this)."::insertExtraFields delete", LOG_DEBUG);

@@ -5070,8 +5492,10 @@ 
 			{

 				$attributeKey = substr($key,8);   // Remove 'options_' prefix

 				// Add field of attribut

-				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator

-					$sql.=",".$attributeKey;

+				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') {
+				    // Only for other type than separator

+					$sql.=",".$attributeKey;
+				}
 			}

 			$sql .= ") VALUES (".$this->id;

 

@@ -5079,13 +5503,14 @@ 
 			{

 				$attributeKey = substr($key,8);   // Remove 'options_' prefix

 				// Add field of attribute

-				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator)

+				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') {
+				    // Only for other type than separator)

 				{

 					if ($new_array_options[$key] != '')

 					{

-						$sql.=",'".$this->db->escape($new_array_options[$key])."'";

-					}

-					else

+						$sql.=",'".$this->db->escape($new_array_options[$key])."'";
+				}
+					} else

 					{

 						$sql.=",null";

 					}

@@ -5106,7 +5531,9 @@ 
 				// Call trigger

 				$this->context=array('extrafieldaddupdate'=>1);

 				$result=$this->call_trigger($trigger, $userused);

-				if ($result < 0) $error++;

+				if ($result < 0) {
+				    $error++;
+				}
 				// End call trigger

 			}

 

@@ -5114,14 +5541,14 @@ 
 			{

 				$this->db->rollback();

 				return -1;

-			}

-			else

+			} else

 			{

 				$this->db->commit();

 				return 1;

 			}

-		}

-		else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

 	/**

@@ -5138,11 +5565,16 @@ 
 	{

 		global $conf,$langs,$user;

 

-		if (empty($userused)) $userused=$user;

+		if (empty($userused)) {
+		    $userused=$user;
+		}
 

 		$error=0;

 

-		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) return 0;	// For avoid conflicts if trigger used

+		if (! empty($conf->global->MAIN_EXTRAFIELDS_DISABLED)) {
+		    return 0;
+		}
+		// For avoid conflicts if trigger used

 

 		if (! empty($this->array_options) && isset($this->array_options["options_".$key]))

 		{

@@ -5169,8 +5601,7 @@ 
 					{

 						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue",$attributeLabel);

 						return -1;

-					}

-					elseif ($value=='')

+					} elseif ($value=='')

 					{

 						$this->array_options["options_".$key] = null;

 					}

@@ -5182,8 +5613,7 @@ 
 						dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

 						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 						return -1;

-					}

-					elseif ($value=='')

+					} elseif ($value=='')

 					{

 						$this->array_options["options_".$key] = null;

 					}

@@ -5235,7 +5665,9 @@ 
 				// Call trigger

 				$this->context=array('extrafieldupdate'=>1);

 				$result=$this->call_trigger($trigger, $userused);

-				if ($result < 0) $error++;

+				if ($result < 0) {
+				    $error++;
+				}
 				// End call trigger

 			}

 

@@ -5244,14 +5676,14 @@ 
 				dol_syslog(get_class($this) . "::".__METHOD__ . $this->error, LOG_ERR);

 				$this->db->rollback();

 				return -1;

-			}

-			else

+			} else

 			{

 				$this->db->commit();

 				return 1;

 			}

-		}

-		else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

 

@@ -5326,8 +5758,11 @@ 
 

 		if ($computed)

 		{

-			if (! preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';

-			else return '';

+			if (! preg_match('/^search_/', $keyprefix)) {
+			    return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';
+			} else {
+			    return '';
+			}
 		}

 

 

@@ -5341,33 +5776,27 @@ 
 			if ($type == 'date')

 			{

 				$morecss = 'minwidth100imp';

-			}

-			elseif ($type == 'datetime')

+			} elseif ($type == 'datetime')

 			{

 				$morecss = 'minwidth200imp';

-			}

-			elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+			} elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

 			{

 				$morecss = 'maxwidth75';

-                        }elseif ($type == 'url')

+                        } elseif ($type == 'url')

 			{

 				$morecss='minwidth400';

-			}

-			elseif ($type == 'boolean')

+			} elseif ($type == 'boolean')

 			{

 				$morecss='';

-			}

-			else

+			} else

 			{

 				if (round($size) < 12)

 				{

 					$morecss = 'minwidth100';

-				}

-				else if (round($size) <= 48)

+				} else if (round($size) <= 48)

 				{

 					$morecss = 'minwidth200';

-				}

-				else

+				} else

 				{

 					$morecss = 'minwidth400';

 				}

@@ -5382,52 +5811,50 @@ 
 			$showtime = in_array($type,array('datetime')) ? 1 : 0;

 

 			// Do not show current date when field not required (see selectDate() method)

-			if (!$required && $value == '') $value = '-1';

+			if (!$required && $value == '') {
+			    $value = '-1';
+			}
 

 			// TODO Must also support $moreparam

 			$out = $form->selectDate($value, $keyprefix.$key.$keysuffix, $showtime, $showtime, $required, '', 1, (($keyprefix != 'search_' && $keyprefix != 'search_options_') ? 1 : 0), 0, 1);

-		}

-		elseif (in_array($type,array('int','integer')))

+		} elseif (in_array($type,array('int','integer')))

 		{

 			$tmp=explode(',',$size);

 			$newsize=$tmp[0];

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

-		}

-		elseif (preg_match('/varchar/', $type))

+		} elseif (preg_match('/varchar/', $type))

 		{

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

-		}

-		elseif (in_array($type, array('mail', 'phone', 'url')))

+		} elseif (in_array($type, array('mail', 'phone', 'url')))

 		{

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'text')

+		} elseif ($type == 'text')

 		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+			if (! preg_match('/search_/', $keyprefix)) {
+			    // If keyprefix is search_ or search_options_, we must just use a simple text field

 			{

-				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

+				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
+			}
 				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,false,ROWS_5,'90%');

 				$out=$doleditor->Create(1);

-			}

-			else

+			} else

 			{

 				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

 			}

-		}

-		elseif ($type == 'html')

+		} elseif ($type == 'html')

 		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+			if (! preg_match('/search_/', $keyprefix)) {
+			    // If keyprefix is search_ or search_options_, we must just use a simple text field

 			{

-				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

+				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
+			}
 				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,! empty($conf->fckeditor->enabled) && $conf->global->FCKEDITOR_ENABLE_SOCIETE,ROWS_5,'90%');

 				$out=$doleditor->Create(1);

-			}

-			else

+			} else

 			{

 				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

 			}

-		}

-		elseif ($type == 'boolean')

+		} elseif ($type == 'boolean')

 		{

 			$checked='';

 			if (!empty($value)) {

@@ -5436,22 +5863,19 @@ 
 				$checked=' value="1" ';

 			}

 			$out='<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'price')

+		} elseif ($type == 'price')

 		{

 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

 				$value=price($value);

 			}

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> '.$langs->getCurrencySymbol($conf->currency);

-		}

-		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+		} elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

 		{

 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

 				$value=price($value);

 			}

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> ';

-		}

-		elseif ($type == 'select')

+		} elseif ($type == 'select')

 		{

 			$out = '';

 			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

@@ -5461,10 +5885,14 @@ 
 			}

 

 			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

-                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1))$out.='<option value="0">&nbsp;</option>';

+                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1)) {
+                    $out.='<option value="0">&nbsp;</option>';
+                }
 			foreach ($param['options'] as $key => $val)

 			{

-				if ((string) $key == '') continue;

+				if ((string) $key == '') {
+				    continue;
+				}
 				list($val, $parent) = explode('|', $val);

 				$out.='<option value="'.$key.'"';

 				$out.= (((string) $value == (string) $key)?' selected':'');

@@ -5472,8 +5900,7 @@ 
 				$out.='>'.$val.'</option>';

 			}

 			$out.='</select>';

-		}

-		elseif ($type == 'sellist')

+		} elseif ($type == 'sellist')

 		{

 			$out = '';

 			if (! empty($conf->use_javascript_ajax) && ! empty($conf->global->MAIN_EXTRAFIELDS_USE_SELECT2))

@@ -5540,13 +5967,11 @@ 
 					{

 						$sql.= ' as main, '.MAIN_DB_PREFIX .$InfoFieldList[0].'_extrafields as extra';

 						$sqlwhere.= ' WHERE extra.fk_object=main.'.$InfoFieldList[2]. ' AND '.$InfoFieldList[4];

-					}

-					else

+					} else

 					{

 						$sqlwhere.= ' WHERE '.$InfoFieldList[4];

 					}

-				}

-				else

+				} else

 				{

 					$sqlwhere.= ' WHERE 1=1';

 				}

@@ -5582,8 +6007,7 @@ 
 							{

 								$labeltoshow.= $obj->$field_toshow.' ';

 							}

-						}

-						else

+						} else

 						{

 							$labeltoshow=$obj->{$InfoFieldList[1]};

 						}

@@ -5596,25 +6020,25 @@ 
 								$translabel=$langs->trans($obj->$field_toshow);

 								if ($translabel!=$obj->$field_toshow) {

 									$labeltoshow=dol_trunc($translabel,18).' ';

-								}else {

+								} else {

 									$labeltoshow=dol_trunc($obj->$field_toshow,18).' ';

 								}

 							}

 							$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

-						}

-						else

+						} else

 						{

 							if (! $notrans)

 							{

 								$translabel=$langs->trans($obj->{$InfoFieldList[1]});

 								if ($translabel!=$obj->{$InfoFieldList[1]}) {

 									$labeltoshow=dol_trunc($translabel,18);

-								}

-								else {

+								} else {

 									$labeltoshow=dol_trunc($obj->{$InfoFieldList[1]},18);

 								}

 							}

-							if (empty($labeltoshow)) $labeltoshow='(not defined)';

+							if (empty($labeltoshow)) {
+							    $labeltoshow='(not defined)';
+							}
 							if ($value==$obj->rowid)

 							{

 								$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

@@ -5634,19 +6058,16 @@ 
 						$i++;

 					}

 					$this->db->free($resql);

-				}

-				else {

+				} else {

 					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';

 				}

 			}

 			$out.='</select>';

-		}

-		elseif ($type == 'checkbox')

+		} elseif ($type == 'checkbox')

 		{

 			$value_arr=explode(',',$value);

 			$out=$form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options'])?null:$param['options']), $value_arr, '', 0, '', 0, '100%');

-		}

-		elseif ($type == 'radio')

+		} elseif ($type == 'radio')

 		{

 			$out='';

 			foreach ($param['options'] as $keyopt => $val)

@@ -5657,13 +6078,11 @@ 
 				$out.= ($value==$keyopt?'checked':'');

 				$out.='/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';

 			}

-		}

-		elseif ($type == 'chkbxlst')

+		} elseif ($type == 'chkbxlst')

 		{

 			if (is_array($value)) {

 				$value_arr = $value;

-			}

-			else {

+			} else {

 				$value_arr = explode(',', $value);

 			}

 

@@ -5778,8 +6197,9 @@ 
 									$labeltoshow = dol_trunc($obj->{$InfoFieldList[1]}, 18);

 								}

 							}

-							if (empty($labeltoshow))

-								$labeltoshow = '(not defined)';

+							if (empty($labeltoshow)) {
+															$labeltoshow = '(not defined)';
+							}
 

 								if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

 									$data[$obj->rowid]=$labeltoshow;

@@ -5801,8 +6221,7 @@ 
 					print 'Error in request ' . $sql . ' ' . $this->db->lasterror() . '. Check setup of extra parameters.<br>';

 				}

 			}

-		}

-		elseif ($type == 'link')

+		} elseif ($type == 'link')

 		{

 			$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

 			$showempty=(($required && $default != '')?0:1);

@@ -5810,18 +6229,19 @@ 
 			if ($conf->global->MAIN_FEATURES_LEVEL >= 2)

 			{

             			list($class,$classfile)=explode(':',$param_list[0]);

-            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);

-            			else $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);

+            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) {
+            			    $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);
+            			} else {
+            			    $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);
+            			}
             			$out.='<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';

             			// TODO Add Javascript code to add input fields contents to new elements urls

 			}

-		}

-		elseif ($type == 'password')

+		} elseif ($type == 'password')

 		{

 			// If prefix is 'search_', field is used as a filter, we use a common text field.

 			$out='<input type="'.($keyprefix=='search_'?'text':'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'array')

+		} elseif ($type == 'array')

 		{

 			$newval = $val;

 			$newval['type'] = 'varchar(256)';

@@ -5899,17 +6319,25 @@ 
 		{

 			$type = 'varchar';		// convert varchar(xx) int varchar

 			$size = $reg[1];

-		}

-		elseif (preg_match('/varchar/', $type)) $type = 'varchar';		// convert varchar(xx) int varchar

-		if (is_array($val['arrayofkeyval'])) $type='select';

-		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type='link';

+		} elseif (preg_match('/varchar/', $type)) {
+		    $type = 'varchar';
+		}
+		// convert varchar(xx) int varchar

+		if (is_array($val['arrayofkeyval'])) {
+		    $type='select';
+		}
+		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) {
+		    $type='link';
+		}
 

 		$default=$val['default'];

 		$computed=$val['computed'];

 		$unique=$val['unique'];

 		$required=$val['required'];

 		$param=$val['param'];

-		if (is_array($val['arrayofkeyval'])) $param['options'] = $val['arrayofkeyval'];

+		if (is_array($val['arrayofkeyval'])) {
+		    $param['options'] = $val['arrayofkeyval'];
+		}
 		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg))

 		{

 			$type='link';

@@ -5920,7 +6348,9 @@ 
 		$help=$val['help'];

 		$hidden=(($val['visible'] == 0) ? 1 : 0);			// If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)

 

-		if ($hidden) return '';

+		if ($hidden) {
+		    return '';
+		}
 

 		// If field is a computed field, value must become result of compute

 		if ($computed)

@@ -5936,36 +6366,29 @@ 
 			{

 				//$showsize=10;

 				$showsize = 'minwidth100imp';

-			}

-			elseif ($type == 'datetime')

+			} elseif ($type == 'datetime')

 			{

 				//$showsize=19;

 				$showsize = 'minwidth200imp';

-			}

-			elseif (in_array($type,array('int','double','price')))

+			} elseif (in_array($type,array('int','double','price')))

 			{

 				//$showsize=10;

 				$showsize = 'maxwidth75';

-			}

-			elseif ($type == 'url')

+			} elseif ($type == 'url')

 			{

 				$showsize='minwidth400';

-			}

-			elseif ($type == 'boolean')

+			} elseif ($type == 'boolean')

 			{

 				$showsize='';

-			}

-			else

+			} else

 			{

 				if (round($size) < 12)

 				{

 					$showsize = 'minwidth100';

-				}

-				else if (round($size) <= 48)

+				} else if (round($size) <= 48)

 				{

 					$showsize = 'minwidth200';

-				}

-				else

+				} else

 				{

 					//$showsize=48;

 					$showsize = 'minwidth400';

@@ -5974,59 +6397,52 @@ 
 		}

 

 		// Format output value differently according to properties of field

-		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value=$this->getNomUrl(1, '', 0, '', 1);

-		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value=$this->getLibStatut(3);

-		elseif ($type == 'date')

+		if ($key == 'ref' && method_exists($this, 'getNomUrl')) {
+		    $value=$this->getNomUrl(1, '', 0, '', 1);
+		} elseif ($key == 'status' && method_exists($this, 'getLibStatut')) {
+		    $value=$this->getLibStatut(3);
+		} elseif ($type == 'date')

 		{

 			if(! empty($value)) {

 				$value=dol_print_date($value,'day');

 			} else {

 				$value='';

 			}

-		}

-		elseif ($type == 'datetime')

+		} elseif ($type == 'datetime')

 		{

 			if(! empty($value)) {

 				$value=dol_print_date($value,'dayhour');

 			} else {

 				$value='';

 			}

-		}

-		elseif ($type == 'double')

+		} elseif ($type == 'double')

 		{

 			if (!empty($value)) {

 				$value=price($value);

 			}

-		}

-		elseif ($type == 'boolean')

+		} elseif ($type == 'boolean')

 		{

 			$checked='';

 			if (!empty($value)) {

 				$checked=' checked ';

 			}

 			$value='<input type="checkbox" '.$checked.' '.($moreparam?$moreparam:'').' readonly disabled>';

-		}

-		elseif ($type == 'mail')

+		} elseif ($type == 'mail')

 		{

 			$value=dol_print_email($value,0,0,0,64,1,1);

-		}

-		elseif ($type == 'url')

+		} elseif ($type == 'url')

 		{

 			$value=dol_print_url($value,'_blank',32,1);

-		}

-		elseif ($type == 'phone')

+		} elseif ($type == 'phone')

 		{

 			$value=dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);

-		}

-		elseif ($type == 'price')

+		} elseif ($type == 'price')

 		{

 			$value=price($value,0,$langs,0,0,-1,$conf->currency);

-		}

-		elseif ($type == 'select')

+		} elseif ($type == 'select')

 		{

 			$value=$param['options'][$value];

-		}

-		elseif ($type == 'sellist')

+		} elseif ($type == 'sellist')

 		{

 			$param_list=array_keys($param['options']);

 			$InfoFieldList = explode(":", $param_list[0]);

@@ -6056,7 +6472,7 @@ 
 				$sql.= " WHERE ".$selectkey."=0";

 			} elseif ($selectkey=='rowid') {

 				$sql.= " WHERE ".$selectkey."=".$this->db->escape($value);

-			}else {

+			} else {

 				$sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

 			}

 

@@ -6083,12 +6499,11 @@ 
 						}

 						if ($translabel!=$field_toshow) {

 							$value.=dol_trunc($translabel,18).' ';

-						}else {

+						} else {

 							$value.=$obj->$field_toshow.' ';

 						}

 					}

-				}

-				else

+				} else

 				{

 					$translabel='';

 					if (!empty($obj->{$InfoFieldList[1]})) {

@@ -6096,18 +6511,17 @@ 
 					}

 					if ($translabel!=$obj->{$InfoFieldList[1]}) {

 						$value=dol_trunc($translabel,18);

-					}else {

+					} else {

 						$value=$obj->{$InfoFieldList[1]};

 					}

 				}

-			}

-			else dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);

-		}

-		elseif ($type == 'radio')

+			} else {
+			    dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);
+			}
+		} elseif ($type == 'radio')

 		{

 			$value=$param['options'][$value];

-		}

-		elseif ($type == 'checkbox')

+		} elseif ($type == 'checkbox')

 		{

 			$value_arr=explode(',',$value);

 			$value='';

@@ -6118,8 +6532,7 @@ 
 				}

 				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

 			}

-		}

-		elseif ($type == 'chkbxlst')

+		} elseif ($type == 'chkbxlst')

 		{

 			$value_arr = explode(',', $value);

 

@@ -6187,8 +6600,7 @@ 
 			} else {

 				dol_syslog(get_class($this) . '::showOutputField error ' . $this->db->lasterror(), LOG_WARNING);

 			}

-		}

-		elseif ($type == 'link')

+		} elseif ($type == 'link')

 		{

 			$out='';

 

@@ -6210,24 +6622,21 @@ 
 						$object->fetch($value);

 						$value=$object->getNomUrl($getnomurlparam);

 					}

-				}

-				else

+				} else

 				{

 					dol_syslog('Error bad setup of extrafield', LOG_WARNING);

 					return 'Error bad setup of extrafield';

 				}

-			}

-			else $value='';

-		}

-		elseif ($type == 'text' || $type == 'html')

+			} else {
+			    $value='';
+			}
+		} elseif ($type == 'text' || $type == 'html')

 		{

 			$value=dol_htmlentitiesbr($value);

-		}

-		elseif ($type == 'password')

+		} elseif ($type == 'password')

 		{

 			$value=preg_replace('/./i','*',$value);

-		}

-		elseif ($type == 'array')

+		} elseif ($type == 'array')

 		{

 			$value = implode('<br>', $value);

 		}

@@ -6254,7 +6663,9 @@ 
 	{

 		global $db, $conf, $langs, $action, $form;

 

-		if (! is_object($form)) $form=new Form($db);

+		if (! is_object($form)) {
+		    $form=new Form($db);
+		}
 

 		$out = '';

 

@@ -6268,7 +6679,9 @@ 
 			foreach($extrafields->attributes[$this->table_element]['label'] as $key=>$label)

 			{

 				// Show only the key field in params

-				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) continue;

+				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) {
+				    continue;
+				}
 

 				$enabled = 1;

 				if ($enabled && isset($extrafields->attributes[$this->table_element]['list'][$key]))

@@ -6282,11 +6695,18 @@ 
 					$perms = dol_eval($extrafields->attributes[$this->table_element]['perms'][$key], 1);

 				}

 

-				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue;	// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

-				if (empty($perms)) continue;

+				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) {
+				    continue;
+				}
+				// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

+				if (empty($perms)) {
+				    continue;
+				}
 

 				// Load language if required

-				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);

+				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) {
+				    $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);
+				}
 

 				$colspan='3';

 				if (is_array($params) && count($params)>0) {

@@ -6320,8 +6740,7 @@ 
 				if ($extrafields->attributes[$this->table_element]['type'][$key] == 'separate')

 				{

 					$out .= $extrafields->showSeparator($key, $this);

-				}

-				else

+				} else

 				{

 					$csstyle='';

 					$class=(!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');

@@ -6351,9 +6770,11 @@ 
 					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('date','datetime')))

 					{

 						$datenotinstring = $this->array_options['options_' . $key];

-						if (! is_numeric($this->array_options['options_' . $key]))	// For backward compatibility

+						if (! is_numeric($this->array_options['options_' . $key])) {
+						    // For backward compatibility

 						{

-							$datenotinstring = $this->db->jdate($datenotinstring);

+							$datenotinstring = $this->db->jdate($datenotinstring);
+						}
 						}

 						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min",'int',3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year",'int',3)):$datenotinstring;

 					}

@@ -6366,11 +6787,18 @@ 
 					$labeltoshow = $langs->trans($label);

 

 					$out .= '<td class="titlefield';

-					if (GETPOST('action','none') == 'create') $out.='create';

-					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';

+					if (GETPOST('action','none') == 'create') {
+					    $out.='create';
+					}
+					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) {
+					    $out .= ' fieldrequired';
+					}
 					$out .= '">';

-					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);

-					else $out .= $labeltoshow;

+					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) {
+					    $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);
+					} else {
+					    $out .= $labeltoshow;
+					}
 					$out .= '</td>';

 

 					$html_id = !empty($this->id) ? $this->element.'_extras_'.$key.'_'.$this->id : '';

@@ -6387,8 +6815,11 @@ 
 

 					$out .= '</td>';

 

-					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) $out .= '</tr>';

-					else $out .= '</tr>';

+					if (! empty($conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) {
+					    $out .= '</tr>';
+					} else {
+					    $out .= '</tr>';
+					}
 					$e++;

 				}

 			}

@@ -6440,7 +6871,9 @@ 
 		global $user;

 

 		$element = $this->element;

-		if ($element == 'facturerec') $element='facture';

+		if ($element == 'facturerec') {
+		    $element='facture';
+		}
 

 		return $user->rights->{$element};

 	}

@@ -6465,7 +6898,10 @@ 
 

 			if (! $db->query($sql))

 			{

-				if ($ignoreerrors) return true;		// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

+				if ($ignoreerrors) {
+				    return true;
+				}
+				// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

 				//$this->errors = $db->lasterror();

 				return false;

 			}

@@ -6492,11 +6928,12 @@ 
 

 		$buyPrice = 0;

 

-		if (($unitPrice > 0) && (isset($conf->global->ForceBuyingPriceIfNull) && $conf->global->ForceBuyingPriceIfNull == 1)) // In most cases, test here is false

+		if (($unitPrice > 0) && (isset($conf->global->ForceBuyingPriceIfNull) && $conf->global->ForceBuyingPriceIfNull == 1)) {
+		    // In most cases, test here is false

 		{

-			$buyPrice = $unitPrice * (1 - $discountPercent / 100);

-		}

-		else

+			$buyPrice = $unitPrice * (1 - $discountPercent / 100);
+		}
+		} else

 		{

 			// Get cost price for margin calculation

 			if (! empty($fk_product))

@@ -6514,13 +6951,11 @@ 
 					if ($product->cost_price > 0)

 					{

 						$buyPrice = $product->cost_price;

-					}

-					else if ($product->pmp > 0)

+					} else if ($product->pmp > 0)

 					{

 						$buyPrice = $product->pmp;

 					}

-				}

-				else if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'pmp')

+				} else if (isset($conf->global->MARGIN_TYPE) && $conf->global->MARGIN_TYPE == 'pmp')

 				{

 					require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

 					$product = new Product($this->db);

@@ -6543,8 +6978,7 @@ 
 					if (($result = $productFournisseur->find_min_price_product_fournisseur($fk_product)) > 0)

 					{

 						$buyPrice = $productFournisseur->fourn_unitprice;

-					}

-					else if ($result < 0)

+					} else if ($result < 0)

 					{

 						$this->errors[] = $productFournisseur->error;

 						return -2;

@@ -6590,8 +7024,7 @@ 
 		{

 			$dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

 			$pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

-		}

-		else

+		} else

 		{

 			$dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

 			$pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

@@ -6654,19 +7087,26 @@ 
 

 						// Find name of thumb file

 						$photo_vignette=basename(getImageFileNameForSize($dir.$file, '_small'));

-						if (! dol_is_file($dirthumb.$photo_vignette)) $photo_vignette='';

+						if (! dol_is_file($dirthumb.$photo_vignette)) {
+						    $photo_vignette='';
+						}
 

 						// Get filesize of original file

 						$imgarray=dol_getImageSize($dir.$photo);

 

 						if ($nbbyrow > 0)

 						{

-							if ($nbphoto == 1) $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';

+							if ($nbphoto == 1) {
+							    $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';
+							}
 

-							if ($nbphoto % $nbbyrow == 1) $return.= '<tr align=center valign=middle border=1>';

+							if ($nbphoto % $nbbyrow == 1) {
+							    $return.= '<tr align=center valign=middle border=1>';
+							}
 							$return.= '<td width="'.ceil(100/$nbbyrow).'%" class="photo">';

-						}

-						else if ($nbbyrow < 0) $return .= '<div class="inline-block">';

+						} else if ($nbbyrow < 0) {
+						    $return .= '<div class="inline-block">';
+						}
 

 						$return.= "\n";

 

@@ -6674,15 +7114,20 @@ 
 						if (empty($nolink))

 						{

 							$urladvanced=getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);

-							if ($urladvanced) $return.='<a href="'.$urladvanced.'">';

-							else $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';

+							if ($urladvanced) {
+							    $return.='<a href="'.$urladvanced.'">';
+							} else {
+							    $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';
+							}
 						}

 

 						// Show image (width height=$maxHeight)

 						// Si fichier vignette disponible et image source trop grande, on utilise la vignette, sinon on utilise photo origine

 						$alt=$langs->transnoentitiesnoconv('File').': '.$relativefile;

 						$alt.=' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];

-						if ($notitle) $alt='';

+						if ($notitle) {
+						    $alt='';
+						}
 

 						if ($usesharelink)

 						{

@@ -6692,35 +7137,35 @@ 
 								{

 									$return.= '<!-- Show original file (thumb not yet available with shared links) -->';

 									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

-								}

-								else {

+								} else {

 									$return.= '<!-- Show original file -->';

 									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

 								}

-							}

-							else

+							} else

 							{

 								$return.= '<!-- Show nophoto file (because file is not shared) -->';

 								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';

 							}

-						}

-						else

+						} else

 						{

 							if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

 							{

 								$return.= '<!-- Show thumb -->';

 								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';

-							}

-							else {

+							} else {

 								$return.= '<!-- Show original file -->';

 								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';

 							}

 						}

 

-						if (empty($nolink)) $return.= '</a>';

+						if (empty($nolink)) {
+						    $return.= '</a>';
+						}
 						$return.="\n";

 

-						if ($showfilename) $return.= '<br>'.$viewfilename;

+						if ($showfilename) {
+						    $return.= '<br>'.$viewfilename;
+						}
 						if ($showaction)

 						{

 							$return.= '<br>';

@@ -6745,15 +7190,20 @@ 
 						if ($nbbyrow > 0)

 						{

 							$return.= '</td>';

-							if (($nbphoto % $nbbyrow) == 0) $return.= '</tr>';

-						}

-						else if ($nbbyrow < 0) $return.='</div>';

+							if (($nbphoto % $nbbyrow) == 0) {
+							    $return.= '</tr>';
+							}
+						} else if ($nbbyrow < 0) {
+						    $return.='</div>';
+						}
 					}

 

 					if (empty($size)) {     // Format origine

 						$return.= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';

 

-						if ($showfilename) $return.= '<br>'.$viewfilename;

+						if ($showfilename) {
+						    $return.= '<br>'.$viewfilename;
+						}
 						if ($showaction)

 						{

 							// Special case for product

@@ -6770,7 +7220,9 @@ 
 					}

 

 					// On continue ou on arrete de boucler ?

-					if ($nbmax && $nbphoto >= $nbmax) break;

+					if ($nbmax && $nbphoto >= $nbmax) {
+					    break;
+					}
 				}

 			}

 

@@ -6785,7 +7237,9 @@ 
 						$nbphoto++;

 					}

 

-					if ($nbphoto) $return.= '</table>';

+					if ($nbphoto) {
+					    $return.= '</table>';
+					}
 				}

 			}

 		}

@@ -6806,10 +7260,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='array') return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && $info['type']=='array') {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6822,10 +7280,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='null') return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && $info['type']=='null') {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6836,8 +7298,11 @@ 
 	 */

 	public function isDate($info)

 	{

-		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) return true;

-		else return false;

+		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) {
+		    return true;
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6850,10 +7315,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6866,10 +7335,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) return true;

-			else return false;

-		}

-		else return false;

+			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6882,10 +7355,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='text') return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && $info['type']=='text') {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6898,10 +7375,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['index']) && $info['index']==true) return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['index']) && $info['index']==true) {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6915,21 +7396,21 @@ 
 		global $conf;

 

 		$queryarray=array();

-		foreach ($this->fields as $field=>$info)	// Loop on definition of fields

+		foreach ($this->fields as $field=>$info) {
+		    // Loop on definition of fields

 		{

 			// Depending on field type ('datetime', ...)

 			if($this->isDate($info))

 			{

 				if(empty($this->{$field}))

 				{

-					$queryarray[$field] = null;

-				}

-				else

+					$queryarray[$field] = null;
+		}
+				} else

 				{

 					$queryarray[$field] = $this->db->idate($this->{$field});

 				}

-			}

-			else if($this->isArray($info))

+			} else if($this->isArray($info))

 			{

 				if(! empty($this->{$field})) {

 					if(! is_array($this->{$field})) {

@@ -6939,28 +7420,35 @@ 
 				} else {

 					$queryarray[$field] = null;

 				}

-			}

-			else if($this->isInt($info))

+			} else if($this->isInt($info))

 			{

-				if ($field == 'entity' && is_null($this->{$field})) $queryarray[$field]=$conf->entity;

-				else

+				if ($field == 'entity' && is_null($this->{$field})) {
+				    $queryarray[$field]=$conf->entity;
+				} else

 				{

 					$queryarray[$field] = (int) price2num($this->{$field});

-					if (empty($queryarray[$field])) $queryarray[$field]=0;		// May be reset to null later if property 'notnull' is -1 for this field.

+					if (empty($queryarray[$field])) {
+					    $queryarray[$field]=0;
+					}
+					// May be reset to null later if property 'notnull' is -1 for this field.

 				}

-			}

-			else if($this->isFloat($info))

+			} else if($this->isFloat($info))

 			{

 				$queryarray[$field] = (double) price2num($this->{$field});

-				if (empty($queryarray[$field])) $queryarray[$field]=0;

-			}

-			else

+				if (empty($queryarray[$field])) {
+				    $queryarray[$field]=0;
+				}
+			} else

 			{

 				$queryarray[$field] = $this->{$field};

 			}

 

-			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) unset($queryarray[$field]);

-			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;

+			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) {
+			    unset($queryarray[$field]);
+			}
+			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) {
+			    $queryarray[$field] = null;
+			}
 		}

 

 		return $queryarray;

@@ -6978,42 +7466,47 @@ 
 		{

 			if($this->isDate($info))

 			{

-				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;

-				else $this->{$field} = strtotime($obj->{$field});

-			}

-			elseif($this->isArray($info))

+				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') {
+				    $this->{$field} = 0;
+				} else {
+				    $this->{$field} = strtotime($obj->{$field});
+				}
+			} elseif($this->isArray($info))

 			{

 				if(! empty($obj->{$field})) {

 					$this->{$field} = @unserialize($obj->{$field});

 					// Hack for data not in UTF8

-					if($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));

+					if($this->{$field } === false) {
+					    @unserialize(utf8_decode($obj->{$field}));
+					}
 				} else {

 					$this->{$field} = array();

 				}

-			}

-			elseif($this->isInt($info))

+			} elseif($this->isInt($info))

 			{

-				if ($field == 'rowid') $this->id = (int) $obj->{$field};

-				else $this->{$field} = (int) $obj->{$field};

-			}

-			elseif($this->isFloat($info))

+				if ($field == 'rowid') {
+				    $this->id = (int) $obj->{$field};
+				} else {
+				    $this->{$field} = (int) $obj->{$field};
+				}
+			} elseif($this->isFloat($info))

 			{

 				$this->{$field} = (double) $obj->{$field};

-			}

-			elseif($this->isNull($info))

+			} elseif($this->isNull($info))

 			{

 				$val = $obj->{$field};

 				// zero is not null

 				$this->{$field} = (is_null($val) || (empty($val) && $val!==0 && $val!=='0') ? null : $val);

-			}

-			else

+			} else

 			{

 				$this->{$field} = $obj->{$field};

 			}

 		}

 

 		// If there is no 'ref' field, we force property ->ref to ->id for a better compatibility with common functions.

-		if (! isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;

+		if (! isset($this->fields['ref']) && isset($this->id)) {
+		    $this->ref = $this->id;
+		}
 	}

 

 	/**

@@ -7036,9 +7529,13 @@ 
 	 */

     protected function quote($value, $fieldsentry)

     {

-		if (is_null($value)) return 'NULL';

-		else if (preg_match('/^(int|double|real)/i', $fieldsentry['type'])) return $this->db->escape("$value");

-		else return "'".$this->db->escape($value)."'";

+		if (is_null($value)) {
+		    return 'NULL';
+		} else if (preg_match('/^(int|double|real)/i', $fieldsentry['type'])) {
+		    return $this->db->escape("$value");
+		} else {
+		    return "'".$this->db->escape($value)."'";
+		}
 	}

 

 

@@ -7058,8 +7555,12 @@ 
 		$now=dol_now();

 

 		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation']=$this->db->idate($now);

-		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat']=$user->id;

+		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) {
+		    $fieldvalues['date_creation']=$this->db->idate($now);
+		}
+		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) {
+		    $fieldvalues['fk_user_creat']=$user->id;
+		}
 		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.

 

 		$keys=array();

@@ -7074,8 +7575,12 @@ 
 		foreach($keys as $key)

 		{

 			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
+			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
 

 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

 			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && ! isset($values[$key]) && is_null($val['default']))

@@ -7085,11 +7590,17 @@ 
 			}

 

 			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key]='null';

-			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key]='null';

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) {
+			    $values[$key]='null';
+			}
+			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) {
+			    $values[$key]='null';
+			}
 		}

 

-		if ($error) return -1;

+		if ($error) {
+		    return -1;
+		}
 

 		$this->db->begin();

 

@@ -7115,7 +7626,9 @@ 
 		if (! $error)

 		{

 			$result=$this->insertExtraFields();

-			if ($result < 0) $error++;

+			if ($result < 0) {
+			    $error++;
+			}
 		}

 

 		// Triggers

@@ -7148,15 +7661,24 @@ 
 	 */

 	public function fetchCommon($id, $ref = null, $morewhere = '')

 	{

-		if (empty($id) && empty($ref) && empty($morewhere)) return -1;

+		if (empty($id) && empty($ref) && empty($morewhere)) {
+		    return -1;
+		}
 

 		$sql = 'SELECT '.$this->getFieldList();

 		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element;

 

-		if (!empty($id))  $sql.= ' WHERE rowid = '.$id;

-		elseif (!empty($ref)) $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);

-		else $sql.=' WHERE 1 = 1';	// usage with empty id and empty ref is very rare

-		if ($morewhere)   $sql.= $morewhere;

+		if (!empty($id)) {
+		    $sql.= ' WHERE rowid = '.$id;
+		} elseif (!empty($ref)) {
+		    $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);
+		} else {
+		    $sql.=' WHERE 1 = 1';
+		}
+		// usage with empty id and empty ref is very rare

+		if ($morewhere) {
+		    $sql.= $morewhere;
+		}
 		$sql.=' LIMIT 1';	// This is a fetch, to be sure to get only one record

 

 		$res = $this->db->query($sql);

@@ -7167,13 +7689,11 @@ 
 			{

 				$this->setVarsFromFetchObj($obj);

 				return $this->id;

-			}

-			else

+			} else

 			{

 				return 0;

 			}

-		}

-		else

+		} else

 		{

 			$this->error = $this->db->lasterror();

 			$this->errors[] = $this->error;

@@ -7197,8 +7717,12 @@ 
 		$now=dol_now();

 

 		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification']=$this->db->idate($now);

-		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif']=$user->id;

+		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) {
+		    $fieldvalues['date_modification']=$this->db->idate($now);
+		}
+		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) {
+		    $fieldvalues['fk_user_modif']=$user->id;
+		}
 		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.

 

 		$keys=array();

@@ -7213,8 +7737,14 @@ 
 		// Clean and check mandatory

 		foreach($keys as $key)

 		{

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';		// This is an implicit foreign key field

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';					// This is an explicit foreign key field

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
+			// This is an implicit foreign key field

+			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
+			// This is an explicit foreign key field

 

 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

 			/*

@@ -7295,10 +7825,11 @@ 
 					return -1;

 				}

 			}

-		}

-		elseif (! empty($this->fk_element) && ! empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.

+		} elseif (! empty($this->fk_element) && ! empty($this->childtables)) {
+		    // If object has childs linked with a foreign key field, we check all child tables.

 		{

-			$objectisused = $this->isObjectUsed($this->id);

+			$objectisused = $this->isObjectUsed($this->id);
+		}
 			if (! empty($objectisused))

 			{

 				dol_syslog(get_class($this)."::deleteCommon Can't delete record as it has some child", LOG_WARNING);

@@ -7405,7 +7936,9 @@ 
      */

     public function trimParameters($parameters)

     {

-        if (!is_array($parameters)) return;

+        if (!is_array($parameters)) {
+            return;
+        }
         foreach ($parameters as $parameter) {

             if (isset($this->$parameter)) {

                 $this->$parameter = trim($this->$parameter);

Base/Form.php

Spacing +897 added lines, -897 removed lines

@@ -111,13 +111,13 @@ 
         if (!empty($conf->global->MAIN_USE_JQUERY_JEDITABLE) && !preg_match('/^select;/', $typeofdata)) {

             if (!empty($perm)) {

                 $tmp = explode(':', $typeofdata);

-                $ret .= '<div class="editkey_' . $tmp[0] . (!empty($tmp[1]) ? ' ' . $tmp[1] : '') . '" id="' . $htmlname . '">';

+                $ret .= '<div class="editkey_'.$tmp[0].(!empty($tmp[1]) ? ' '.$tmp[1] : '').'" id="'.$htmlname.'">';

                 if ($fieldrequired)

                     $ret .= '<span class="fieldrequired">';

                 $ret .= $langs->trans($text);

                 if ($fieldrequired)

                     $ret .= '</span>';

-                $ret .= '</div>' . "\n";

+                $ret .= '</div>'."\n";

             }

             else {

                 if ($fieldrequired)

@@ -128,7 +128,7 @@ 
             }

         }

         else {

-            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

+            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit'.$htmlname && $perm) {

                 $ret .= '<table class="nobordernopadding" width="100%"><tr><td class="nowrap">';

             }

             if ($fieldrequired) {

@@ -141,14 +141,14 @@ 
             if (!empty($notabletag)) {

                 $ret .= ' ';

             }

-            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

+            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit'.$htmlname && $perm) {

                 $ret .= '</td>';

             }

-            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

+            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit'.$htmlname && $perm) {

                 $ret .= '<td align="right">';

             }

-            if ($htmlname && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

-                $ret .= '<a href="' . $_SERVER["PHP_SELF"] . '?action=edit' . $htmlname . '&amp;' . $paramid . '=' . $object->id . $moreparam . '">' . img_edit($langs->trans('Edit'), ($notabletag ? 0 : 1)) . '</a>';

+            if ($htmlname && GETPOST('action', 'aZ09') != 'edit'.$htmlname && $perm) {

+                $ret .= '<a href="'.$_SERVER["PHP_SELF"].'?action=edit'.$htmlname.'&amp;'.$paramid.'='.$object->id.$moreparam.'">'.img_edit($langs->trans('Edit'), ($notabletag ? 0 : 1)).'</a>';

             }

             if (!empty($notabletag) && $notabletag == 1) {

                 $ret .= ' : ';

@@ -156,10 +156,10 @@ 
             if (!empty($notabletag) && $notabletag == 3) {

                 $ret .= ' ';

             }

-            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

+            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit'.$htmlname && $perm) {

                 $ret .= '</td>';

             }

-            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

+            if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit'.$htmlname && $perm) {

                 $ret .= '</tr></table>';

             }

         }

@@ -199,41 +199,41 @@ 
         if (!empty($conf->global->MAIN_USE_JQUERY_JEDITABLE) && !preg_match('/^select;|datehourpicker/', $typeofdata)) { // TODO add jquery timepicker

             $ret .= $this->editInPlace($object, $value, $htmlname, $perm, $typeofdata, $editvalue, $extObject, $custommsg);

         } else {

-            if (GETPOST('action', 'aZ09') == 'edit' . $htmlname) {

+            if (GETPOST('action', 'aZ09') == 'edit'.$htmlname) {

                 $ret .= "\n";

-                $ret .= '<form method="post" action="' . $_SERVER["PHP_SELF"] . ($moreparam ? '?' . $moreparam : '') . '">';

-                $ret .= '<input type="hidden" name="action" value="set' . $htmlname . '">';

-                $ret .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

-                $ret .= '<input type="hidden" name="' . $paramid . '" value="' . $object->id . '">';

+                $ret .= '<form method="post" action="'.$_SERVER["PHP_SELF"].($moreparam ? '?'.$moreparam : '').'">';

+                $ret .= '<input type="hidden" name="action" value="set'.$htmlname.'">';

+                $ret .= '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

+                $ret .= '<input type="hidden" name="'.$paramid.'" value="'.$object->id.'">';

                 if (empty($notabletag))

                     $ret .= '<table class="nobordernopadding centpercent" cellpadding="0" cellspacing="0">';

                 if (empty($notabletag))

                     $ret .= '<tr><td>';

                 if (preg_match('/^(string|email)/', $typeofdata)) {

                     $tmp = explode(':', $typeofdata);

-                    $ret .= '<input type="text" id="' . $htmlname . '" name="' . $htmlname . '" value="' . ($editvalue ? $editvalue : $value) . '"' . ($tmp[1] ? ' size="' . $tmp[1] . '"' : '') . '>';

+                    $ret .= '<input type="text" id="'.$htmlname.'" name="'.$htmlname.'" value="'.($editvalue ? $editvalue : $value).'"'.($tmp[1] ? ' size="'.$tmp[1].'"' : '').'>';

                 } else if (preg_match('/^(numeric|amount)/', $typeofdata)) {

                     $tmp = explode(':', $typeofdata);

                     $valuetoshow = price2num($editvalue ? $editvalue : $value);

-                    $ret .= '<input type="text" id="' . $htmlname . '" name="' . $htmlname . '" value="' . ($valuetoshow != '' ? price($valuetoshow) : '') . '"' . ($tmp[1] ? ' size="' . $tmp[1] . '"' : '') . '>';

+                    $ret .= '<input type="text" id="'.$htmlname.'" name="'.$htmlname.'" value="'.($valuetoshow != '' ? price($valuetoshow) : '').'"'.($tmp[1] ? ' size="'.$tmp[1].'"' : '').'>';

                 } else if (preg_match('/^text/', $typeofdata) || preg_match('/^note/', $typeofdata)) {

                     $tmp = explode(':', $typeofdata);

                     $cols = $tmp[2];

                     $morealt = '';

                     if (preg_match('/%/', $cols)) {

-                        $morealt = ' style="width: ' . $cols . '"';

+                        $morealt = ' style="width: '.$cols.'"';

                         $cols = '';

                     }

 

                     $valuetoshow = ($editvalue ? $editvalue : $value);

 

-                    $ret .= '<textarea id="' . $htmlname . '" name="' . $htmlname . '" wrap="soft" rows="' . ($tmp[1] ? $tmp[1] : '20') . '"' . ($cols ? ' cols="' . $cols . '"' : 'class="quatrevingtpercent"') . $morealt . '">';

+                    $ret .= '<textarea id="'.$htmlname.'" name="'.$htmlname.'" wrap="soft" rows="'.($tmp[1] ? $tmp[1] : '20').'"'.($cols ? ' cols="'.$cols.'"' : 'class="quatrevingtpercent"').$morealt.'">';

                     $ret .= dol_string_neverthesehtmltags($valuetoshow, array('textarea'));

                     $ret .= '</textarea>';

                 } else if ($typeofdata == 'day' || $typeofdata == 'datepicker') {

-                    $ret .= $this->selectDate($value, $htmlname, 0, 0, 1, 'form' . $htmlname, 1, 0);

+                    $ret .= $this->selectDate($value, $htmlname, 0, 0, 1, 'form'.$htmlname, 1, 0);

                 } else if ($typeofdata == 'dayhour' || $typeofdata == 'datehourpicker') {

-                    $ret .= $this->selectDate($value, $htmlname, 1, 1, 1, 'form' . $htmlname, 1, 0);

+                    $ret .= $this->selectDate($value, $htmlname, 1, 1, 1, 'form'.$htmlname, 1, 0);

                 } else if (preg_match('/^select;/', $typeofdata)) {

                     $arraydata = explode(',', preg_replace('/^select;/', '', $typeofdata));

                     foreach ($arraydata as $val) {

@@ -242,8 +242,8 @@ 
                     }

                     $ret .= $this->selectarray($htmlname, $arraylist, $value);

                 } else if (preg_match('/^ckeditor/', $typeofdata)) {

-                    $tmp = explode(':', $typeofdata);  // Example: ckeditor:dolibarr_zzz:width:height:savemethod:toolbarstartexpanded:rows:cols

-                    require_once DOL_DOCUMENT_ROOT . '/core/class/doleditor.class.php';

+                    $tmp = explode(':', $typeofdata); // Example: ckeditor:dolibarr_zzz:width:height:savemethod:toolbarstartexpanded:rows:cols

+                    require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

                     $doleditor = new DolEditor($htmlname, ($editvalue ? $editvalue : $value), ($tmp[2] ? $tmp[2] : ''), ($tmp[3] ? $tmp[3] : '100'), ($tmp[1] ? $tmp[1] : 'dolibarr_notes'), 'In', ($tmp[5] ? $tmp[5] : 0), true, true, ($tmp[6] ? $tmp[6] : '20'), ($tmp[7] ? $tmp[7] : '100'));

                     $ret .= $doleditor->Create(1);

                 }

@@ -253,16 +253,16 @@ 
                 if (empty($notabletag))

                     $ret .= '<td align="left">';

                 //else $ret.='<div class="clearboth"></div>';

-                $ret .= '<input type="submit" class="button' . (empty($notabletag) ? '' : ' ') . '" name="modify" value="' . $langs->trans("Modify") . '">';

+                $ret .= '<input type="submit" class="button'.(empty($notabletag) ? '' : ' ').'" name="modify" value="'.$langs->trans("Modify").'">';

                 if (preg_match('/ckeditor|textarea/', $typeofdata) && empty($notabletag))

-                    $ret .= '<br>' . "\n";

-                $ret .= '<input type="submit" class="button' . (empty($notabletag) ? '' : ' ') . '" name="cancel" value="' . $langs->trans("Cancel") . '">';

+                    $ret .= '<br>'."\n";

+                $ret .= '<input type="submit" class="button'.(empty($notabletag) ? '' : ' ').'" name="cancel" value="'.$langs->trans("Cancel").'">';

                 if (empty($notabletag))

                     $ret .= '</td>';

 

                 if (empty($notabletag))

-                    $ret .= '</tr></table>' . "\n";

-                $ret .= '</form>' . "\n";

+                    $ret .= '</tr></table>'."\n";

+                $ret .= '</form>'."\n";

             }

             else {

                 if (preg_match('/^(email)/', $typeofdata))

@@ -287,7 +287,7 @@ 
                     if (!empty($conf->global->MAIN_DISABLE_NOTES_TAB)) {

                         $firstline = preg_replace('/<br>.*/', '', $tmpcontent);

                         $firstline = preg_replace('/[\n\r].*/', '', $firstline);

-                        $tmpcontent = $firstline . ((strlen($firstline) != strlen($tmpcontent)) ? '...' : '');

+                        $tmpcontent = $firstline.((strlen($firstline) != strlen($tmpcontent)) ? '...' : '');

                     }

                     $ret .= $tmpcontent;

                 } else

@@ -355,7 +355,7 @@ 
                     $inputOption = $tmp[1];

                 if (!empty($tmp[2]))

                     $savemethod = $tmp[2];

-                $out .= '<input id="width_' . $htmlname . '" value="' . $inputOption . '" type="hidden"/>' . "\n";

+                $out .= '<input id="width_'.$htmlname.'" value="'.$inputOption.'" type="hidden"/>'."\n";

             }

             else if ((preg_match('/^day$/', $inputType)) || (preg_match('/^datepicker/', $inputType)) || (preg_match('/^datehourpicker/', $inputType))) {

                 $tmp = explode(':', $inputType);

@@ -365,7 +365,7 @@ 
                 if (!empty($tmp[2]))

                     $savemethod = $tmp[2];

 

-                $out .= '<input id="timestamp" type="hidden"/>' . "\n"; // Use for timestamp format

+                $out .= '<input id="timestamp" type="hidden"/>'."\n"; // Use for timestamp format

             }

             else if (preg_match('/^(select|autocomplete)/', $inputType)) {

                 $tmp = explode(':', $inputType);

@@ -393,35 +393,35 @@ 
                     $savemethod = $tmp[4];

 

                 if (!empty($conf->fckeditor->enabled)) {

-                    $out .= '<input id="ckeditor_toolbar" value="' . $toolbar . '" type="hidden"/>' . "\n";

+                    $out .= '<input id="ckeditor_toolbar" value="'.$toolbar.'" type="hidden"/>'."\n";

                 } else {

                     $inputType = 'textarea';

                 }

             }

 

-            $out .= '<input id="element_' . $htmlname . '" value="' . $element . '" type="hidden"/>' . "\n";

-            $out .= '<input id="table_element_' . $htmlname . '" value="' . $table_element . '" type="hidden"/>' . "\n";

-            $out .= '<input id="fk_element_' . $htmlname . '" value="' . $fk_element . '" type="hidden"/>' . "\n";

-            $out .= '<input id="loadmethod_' . $htmlname . '" value="' . $loadmethod . '" type="hidden"/>' . "\n";

+            $out .= '<input id="element_'.$htmlname.'" value="'.$element.'" type="hidden"/>'."\n";

+            $out .= '<input id="table_element_'.$htmlname.'" value="'.$table_element.'" type="hidden"/>'."\n";

+            $out .= '<input id="fk_element_'.$htmlname.'" value="'.$fk_element.'" type="hidden"/>'."\n";

+            $out .= '<input id="loadmethod_'.$htmlname.'" value="'.$loadmethod.'" type="hidden"/>'."\n";

             if (!empty($savemethod))

-                $out .= '<input id="savemethod_' . $htmlname . '" value="' . $savemethod . '" type="hidden"/>' . "\n";

+                $out .= '<input id="savemethod_'.$htmlname.'" value="'.$savemethod.'" type="hidden"/>'."\n";

             if (!empty($ext_element))

-                $out .= '<input id="ext_element_' . $htmlname . '" value="' . $ext_element . '" type="hidden"/>' . "\n";

+                $out .= '<input id="ext_element_'.$htmlname.'" value="'.$ext_element.'" type="hidden"/>'."\n";

             if (!empty($custommsg)) {

                 if (is_array($custommsg)) {

                     if (!empty($custommsg['success']))

-                        $out .= '<input id="successmsg_' . $htmlname . '" value="' . $custommsg['success'] . '" type="hidden"/>' . "\n";

+                        $out .= '<input id="successmsg_'.$htmlname.'" value="'.$custommsg['success'].'" type="hidden"/>'."\n";

                     if (!empty($custommsg['error']))

-                        $out .= '<input id="errormsg_' . $htmlname . '" value="' . $custommsg['error'] . '" type="hidden"/>' . "\n";

+                        $out .= '<input id="errormsg_'.$htmlname.'" value="'.$custommsg['error'].'" type="hidden"/>'."\n";

                 } else

-                    $out .= '<input id="successmsg_' . $htmlname . '" value="' . $custommsg . '" type="hidden"/>' . "\n";

+                    $out .= '<input id="successmsg_'.$htmlname.'" value="'.$custommsg.'" type="hidden"/>'."\n";

             }

             if ($inputType == 'textarea') {

-                $out .= '<input id="textarea_' . $htmlname . '_rows" value="' . $rows . '" type="hidden"/>' . "\n";

-                $out .= '<input id="textarea_' . $htmlname . '_cols" value="' . $cols . '" type="hidden"/>' . "\n";

+                $out .= '<input id="textarea_'.$htmlname.'_rows" value="'.$rows.'" type="hidden"/>'."\n";

+                $out .= '<input id="textarea_'.$htmlname.'_cols" value="'.$cols.'" type="hidden"/>'."\n";

             }

-            $out .= '<span id="viewval_' . $htmlname . '" class="viewval_' . $inputType . ($button_only ? ' inactive' : ' active') . '">' . $value . '</span>' . "\n";

-            $out .= '<span id="editval_' . $htmlname . '" class="editval_' . $inputType . ($button_only ? ' inactive' : ' active') . ' hideobject">' . (!empty($editvalue) ? $editvalue : $value) . '</span>' . "\n";

+            $out .= '<span id="viewval_'.$htmlname.'" class="viewval_'.$inputType.($button_only ? ' inactive' : ' active').'">'.$value.'</span>'."\n";

+            $out .= '<span id="editval_'.$htmlname.'" class="editval_'.$inputType.($button_only ? ' inactive' : ' active').' hideobject">'.(!empty($editvalue) ? $editvalue : $value).'</span>'."\n";

         } else {

             $out = $value;

         }

@@ -453,7 +453,7 @@ 
         global $conf;

 

         if ($incbefore) {

-            $text = $incbefore . $text;

+            $text = $incbefore.$text;

         }

         if (!$htmltext) {

             return $text;

@@ -473,11 +473,11 @@ 
 

         $extrastyle = '';

         if ($direction < 0) {

-            $extracss = ($extracss ? $extracss . ' ' : '') . 'inline-block';

+            $extracss = ($extracss ? $extracss.' ' : '').'inline-block';

             $extrastyle = 'padding: 0px; padding-left: 3px !important;';

         }

         if ($direction > 0) {

-            $extracss = ($extracss ? $extracss . ' ' : '') . 'inline-block';

+            $extracss = ($extracss ? $extracss.' ' : '').'inline-block';

             $extrastyle = 'padding: 0px; padding-right: 3px !important;';

         }

 

@@ -490,53 +490,53 @@ 
             $htmltext = str_replace('"', "&quot;", $htmltext);

         } else {

             $classfortooltip = 'classfortooltiponclick';

-            $textfordialog .= '<div style="display: none;" id="idfortooltiponclick_' . $tooltiptrigger . '" class="classfortooltiponclicktext">' . $htmltext . '</div>';

+            $textfordialog .= '<div style="display: none;" id="idfortooltiponclick_'.$tooltiptrigger.'" class="classfortooltiponclicktext">'.$htmltext.'</div>';

         }

         if ($tooltipon == 2 || $tooltipon == 3) {

-            $paramfortooltipimg = ' class="' . $classfortooltip . ' inline-block' . ($extracss ? ' ' . $extracss : '') . '" style="padding: 0px;' . ($extrastyle ? ' ' . $extrastyle : '') . '"';

+            $paramfortooltipimg = ' class="'.$classfortooltip.' inline-block'.($extracss ? ' '.$extracss : '').'" style="padding: 0px;'.($extrastyle ? ' '.$extrastyle : '').'"';

             if ($tooltiptrigger == '') {

-                $paramfortooltipimg .= ' title="' . ($noencodehtmltext ? $htmltext : dol_escape_htmltag($htmltext, 1)) . '"'; // Attribut to put on img tag to store tooltip

+                $paramfortooltipimg .= ' title="'.($noencodehtmltext ? $htmltext : dol_escape_htmltag($htmltext, 1)).'"'; // Attribut to put on img tag to store tooltip

             } else {

-                $paramfortooltipimg .= ' dolid="' . $tooltiptrigger . '"';

+                $paramfortooltipimg .= ' dolid="'.$tooltiptrigger.'"';

             }

         } else {

-            $paramfortooltipimg = ($extracss ? ' class="' . $extracss . '"' : '') . ($extrastyle ? ' style="' . $extrastyle . '"' : ''); // Attribut to put on td text tag

+            $paramfortooltipimg = ($extracss ? ' class="'.$extracss.'"' : '').($extrastyle ? ' style="'.$extrastyle.'"' : ''); // Attribut to put on td text tag

         }

         if ($tooltipon == 1 || $tooltipon == 3) {

-            $paramfortooltiptd = ' class="' . ($tooltipon == 3 ? 'cursorpointer ' : '') . $classfortooltip . ' inline-block' . ($extracss ? ' ' . $extracss : '') . '" style="padding: 0px;' . ($extrastyle ? ' ' . $extrastyle : '') . '" ';

+            $paramfortooltiptd = ' class="'.($tooltipon == 3 ? 'cursorpointer ' : '').$classfortooltip.' inline-block'.($extracss ? ' '.$extracss : '').'" style="padding: 0px;'.($extrastyle ? ' '.$extrastyle : '').'" ';

             if ($tooltiptrigger == '') {

-                $paramfortooltiptd .= ' title="' . ($noencodehtmltext ? $htmltext : dol_escape_htmltag($htmltext, 1)) . '"'; // Attribut to put on td tag to store tooltip

+                $paramfortooltiptd .= ' title="'.($noencodehtmltext ? $htmltext : dol_escape_htmltag($htmltext, 1)).'"'; // Attribut to put on td tag to store tooltip

             } else {

-                $paramfortooltiptd .= ' dolid="' . $tooltiptrigger . '"';

+                $paramfortooltiptd .= ' dolid="'.$tooltiptrigger.'"';

             }

         } else {

-            $paramfortooltiptd = ($extracss ? ' class="' . $extracss . '"' : '') . ($extrastyle ? ' style="' . $extrastyle . '"' : ''); // Attribut to put on td text tag

+            $paramfortooltiptd = ($extracss ? ' class="'.$extracss.'"' : '').($extrastyle ? ' style="'.$extrastyle.'"' : ''); // Attribut to put on td text tag

         }

         if (empty($notabs)) {

             $s .= '<table class="nobordernopadding" summary=""><tr style="height: auto;">';

         } elseif ($notabs == 2) {

-            $s .= '<div class="inline-block' . ($forcenowrap ? ' nowrap' : '') . '">';

+            $s .= '<div class="inline-block'.($forcenowrap ? ' nowrap' : '').'">';

         }

         // Define value if value is before

         if ($direction < 0) {

-            $s .= '<' . $tag . $paramfortooltipimg;

+            $s .= '<'.$tag.$paramfortooltipimg;

             if ($tag == 'td') {

                 $s .= ' valign="top" width="14"';

             }

-            $s .= '>' . $textfordialog . $img . '</' . $tag . '>';

+            $s .= '>'.$textfordialog.$img.'</'.$tag.'>';

         }

         // Use another method to help avoid having a space in value in order to use this value with jquery

         // Define label

         if ((string) $text != '') {

-            $s .= '<' . $tag . $paramfortooltiptd . '>' . $text . '</' . $tag . '>';

+            $s .= '<'.$tag.$paramfortooltiptd.'>'.$text.'</'.$tag.'>';

         }

         // Define value if value is after

         if ($direction > 0) {

-            $s .= '<' . $tag . $paramfortooltipimg;

+            $s .= '<'.$tag.$paramfortooltipimg;

             if ($tag == 'td') {

                 $s .= ' valign="middle" width="14"';

             }

-            $s .= '>' . $textfordialog . $img . '</' . $tag . '>';

+            $s .= '>'.$textfordialog.$img.'</'.$tag.'>';

         }

         if (empty($notabs)) {

             $s .= '</tr></table>';

@@ -629,15 +629,15 @@ 
 

         $disabled = 0;

         $ret = '<div class="centpercent center">';

-        $ret .= '<select class="flat' . (empty($conf->use_javascript_ajax) ? '' : ' hideobject') . ' massaction massactionselect" name="massaction"' . ($disabled ? ' disabled="disabled"' : '') . '>';

+        $ret .= '<select class="flat'.(empty($conf->use_javascript_ajax) ? '' : ' hideobject').' massaction massactionselect" name="massaction"'.($disabled ? ' disabled="disabled"' : '').'>';

 

         // Complete list with data from external modules. THe module can use $_SERVER['PHP_SELF'] to know on which page we are, or use the $parameters['currentcontext'] completed by executeHooks.

         $parameters = array();

-        $reshook = $hookmanager->executeHooks('addMoreMassActions', $parameters);    // Note that $action and $object may have been modified by hook

+        $reshook = $hookmanager->executeHooks('addMoreMassActions', $parameters); // Note that $action and $object may have been modified by hook

         if (empty($reshook)) {

-            $ret .= '<option value="0"' . ($disabled ? ' disabled="disabled"' : '') . '>-- ' . $langs->trans("SelectAction") . ' --</option>';

+            $ret .= '<option value="0"'.($disabled ? ' disabled="disabled"' : '').'>-- '.$langs->trans("SelectAction").' --</option>';

             foreach ($arrayofaction as $code => $label) {

-                $ret .= '<option value="' . $code . '"' . ($disabled ? ' disabled="disabled"' : '') . '>' . $label . '</option>';

+                $ret .= '<option value="'.$code.'"'.($disabled ? ' disabled="disabled"' : '').'>'.$label.'</option>';

             }

         }

         $ret .= $hookmanager->resPrint;

@@ -645,7 +645,7 @@ 
         $ret .= '</select>';

         // Warning: if you set submit button to disabled, post using 'Enter' will no more work if there is no another input submit. So we add a hidden button

         $ret .= '<input type="submit" name="confirmmassactioninvisible" style="display: none" tabindex="-1">'; // Hidden button BEFORE so it is the one used when we submit with ENTER.

-        $ret .= '<input type="submit" disabled name="confirmmassaction" class="button' . (empty($conf->use_javascript_ajax) ? '' : ' hideobject') . ' massaction massactionconfirmed" value="' . dol_escape_htmltag($langs->trans("Confirm")) . '">';

+        $ret .= '<input type="submit" disabled name="confirmmassaction" class="button'.(empty($conf->use_javascript_ajax) ? '' : ' hideobject').' massaction massactionconfirmed" value="'.dol_escape_htmltag($langs->trans("Confirm")).'">';

         $ret .= '</div>';

 

         if (!empty($conf->use_javascript_ajax)) {

@@ -659,11 +659,11 @@ 
     	  				if ($(this).is(\':checked\')) atleastoneselected++;

     	  			});

 					console.log("initCheckForSelect mode="+mode+" atleastoneselected="+atleastoneselected);

-    	  			if (atleastoneselected || ' . $alwaysvisible . ')

+    	  			if (atleastoneselected || ' . $alwaysvisible.')

     	  			{

     	  				jQuery(".massaction").show();

-        			    ' . ($selected ? 'if (atleastoneselected) { jQuery(".massactionselect").val("' . $selected . '"); jQuery(".massactionconfirmed").prop(\'disabled\', false); }' : '') . '

-        			    ' . ($selected ? 'if (! atleastoneselected) { jQuery(".massactionselect").val("0"); jQuery(".massactionconfirmed").prop(\'disabled\', true); } ' : '') . '

+        			    ' . ($selected ? 'if (atleastoneselected) { jQuery(".massactionselect").val("'.$selected.'"); jQuery(".massactionconfirmed").prop(\'disabled\', false); }' : '').'

+        			    ' . ($selected ? 'if (! atleastoneselected) { jQuery(".massactionselect").val("0"); jQuery(".massactionconfirmed").prop(\'disabled\', true); } ' : '').'

     	  			}

     	  			else

     	  			{

@@ -732,14 +732,14 @@ 
         $atleastonefavorite = 0;

 

         $sql = "SELECT rowid, code as code_iso, code_iso as code_iso3, label, favorite";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_country";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_country";

         $sql .= " WHERE active > 0";

         //$sql.= " ORDER BY code ASC";

 

-        dol_syslog(get_class($this) . "::select_country", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_country", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

-            $out .= '<select id="select' . $htmlname . '" class="flat maxwidth200onsmartphone selectcountry' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '" ' . $htmloption . '>';

+            $out .= '<select id="select'.$htmlname.'" class="flat maxwidth200onsmartphone selectcountry'.($morecss ? ' '.$morecss : '').'" name="'.$htmlname.'" '.$htmloption.'>';

             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

@@ -750,7 +750,7 @@ 
                     $countryArray[$i]['rowid'] = $obj->rowid;

                     $countryArray[$i]['code_iso'] = $obj->code_iso;

                     $countryArray[$i]['code_iso3'] = $obj->code_iso3;

-                    $countryArray[$i]['label'] = ($obj->code_iso && $langs->transnoentitiesnoconv("Country" . $obj->code_iso) != "Country" . $obj->code_iso ? $langs->transnoentitiesnoconv("Country" . $obj->code_iso) : ($obj->label != '-' ? $obj->label : ''));

+                    $countryArray[$i]['label'] = ($obj->code_iso && $langs->transnoentitiesnoconv("Country".$obj->code_iso) != "Country".$obj->code_iso ? $langs->transnoentitiesnoconv("Country".$obj->code_iso) : ($obj->label != '-' ? $obj->label : ''));

                     $countryArray[$i]['favorite'] = $obj->favorite;

                     $favorite[$i] = $obj->favorite;

                     $label[$i] = dol_string_unaccent($countryArray[$i]['label']);

@@ -763,16 +763,16 @@ 
                     $countryArray = dol_sort_array($countryArray, 'label');

 

                 if ($showempty) {

-                    $out .= '<option value="">&nbsp;</option>' . "\n";

+                    $out .= '<option value="">&nbsp;</option>'."\n";

                 }

 

                 if ($addspecialentries) { // Add dedicated entries for groups of countries

                     //if ($showempty) $out.= '<option value="" disabled class="selectoptiondisabledwhite">--------------</option>';

-                    $out .= '<option value="special_allnotme"' . ($selected == 'special_allnotme' ? ' selected' : '') . '>' . $langs->trans("CountriesExceptMe", $langs->transnoentitiesnoconv("Country" . $mysoc->country_code)) . '</option>';

-                    $out .= '<option value="special_eec"' . ($selected == 'special_eec' ? ' selected' : '') . '>' . $langs->trans("CountriesInEEC") . '</option>';

+                    $out .= '<option value="special_allnotme"'.($selected == 'special_allnotme' ? ' selected' : '').'>'.$langs->trans("CountriesExceptMe", $langs->transnoentitiesnoconv("Country".$mysoc->country_code)).'</option>';

+                    $out .= '<option value="special_eec"'.($selected == 'special_eec' ? ' selected' : '').'>'.$langs->trans("CountriesInEEC").'</option>';

                     if ($mysoc->isInEEC())

-                        $out .= '<option value="special_eecnotme"' . ($selected == 'special_eecnotme' ? ' selected' : '') . '>' . $langs->trans("CountriesInEECExceptMe", $langs->transnoentitiesnoconv("Country" . $mysoc->country_code)) . '</option>';

-                    $out .= '<option value="special_noteec"' . ($selected == 'special_noteec' ? ' selected' : '') . '>' . $langs->trans("CountriesNotInEEC") . '</option>';

+                        $out .= '<option value="special_eecnotme"'.($selected == 'special_eecnotme' ? ' selected' : '').'>'.$langs->trans("CountriesInEECExceptMe", $langs->transnoentitiesnoconv("Country".$mysoc->country_code)).'</option>';

+                    $out .= '<option value="special_noteec"'.($selected == 'special_noteec' ? ' selected' : '').'>'.$langs->trans("CountriesNotInEEC").'</option>';

                     $out .= '<option value="" disabled class="selectoptiondisabledwhite">--------------</option>';

                 }

 

@@ -790,16 +790,16 @@ 
                     }

                     if ($selected && $selected != '-1' && ($selected == $row['rowid'] || $selected == $row['code_iso'] || $selected == $row['code_iso3'] || $selected == $row['label'])) {

                         $foundselected = true;

-                        $out .= '<option value="' . ($usecodeaskey ? ($usecodeaskey == 'code2' ? $row['code_iso'] : $row['code_iso3']) : $row['rowid']) . '" selected>';

+                        $out .= '<option value="'.($usecodeaskey ? ($usecodeaskey == 'code2' ? $row['code_iso'] : $row['code_iso3']) : $row['rowid']).'" selected>';

                     } else {

-                        $out .= '<option value="' . ($usecodeaskey ? ($usecodeaskey == 'code2' ? $row['code_iso'] : $row['code_iso3']) : $row['rowid']) . '">';

+                        $out .= '<option value="'.($usecodeaskey ? ($usecodeaskey == 'code2' ? $row['code_iso'] : $row['code_iso3']) : $row['rowid']).'">';

                     }

                     if ($row['label'])

                         $out .= dol_trunc($row['label'], $maxlength, 'middle');

                     else

                         $out .= '&nbsp;';

                     if ($row['code_iso'])

-                        $out .= ' (' . $row['code_iso'] . ')';

+                        $out .= ' ('.$row['code_iso'].')';

                     $out .= '</option>';

                 }

             }

@@ -810,8 +810,8 @@ 
         }

 

         // Make select dynamic

-        include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

-        $out .= ajax_combobox('select' . $htmlname);

+        include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

+        $out .= ajax_combobox('select'.$htmlname);

 

         return $out;

     }

@@ -840,25 +840,25 @@ 
         $incotermArray = array();

 

         $sql = "SELECT rowid, code";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_incoterms";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_incoterms";

         $sql .= " WHERE active > 0";

         $sql .= " ORDER BY code ASC";

 

-        dol_syslog(get_class($this) . "::select_incoterm", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_incoterm", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

             if ($conf->use_javascript_ajax && !$forcecombo) {

-                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

                 $out .= ajax_combobox($htmlname, $events);

             }

 

             if (!empty($page)) {

-                $out .= '<form method="post" action="' . $page . '">';

+                $out .= '<form method="post" action="'.$page.'">';

                 $out .= '<input type="hidden" name="action" value="set_incoterms">';

-                $out .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+                $out .= '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             }

 

-            $out .= '<select id="' . $htmlname . '" class="flat selectincoterm minwidth100imp noenlargeonsmartphone" name="' . $htmlname . '" ' . $htmloption . '>';

+            $out .= '<select id="'.$htmlname.'" class="flat selectincoterm minwidth100imp noenlargeonsmartphone" name="'.$htmlname.'" '.$htmloption.'>';

             $out .= '<option value="0">&nbsp;</option>';

             $num = $this->db->num_rows($resql);

             $i = 0;

@@ -874,9 +874,9 @@ 
 

                 foreach ($incotermArray as $row) {

                     if ($selected && ($selected == $row['rowid'] || $selected == $row['code'])) {

-                        $out .= '<option value="' . $row['rowid'] . '" selected>';

+                        $out .= '<option value="'.$row['rowid'].'" selected>';

                     } else {

-                        $out .= '<option value="' . $row['rowid'] . '">';

+                        $out .= '<option value="'.$row['rowid'].'">';

                     }

 

                     if ($row['code'])

@@ -887,10 +887,10 @@ 
             }

             $out .= '</select>';

 

-            $out .= '<input id="location_incoterms" class="maxwidth100onsmartphone" name="location_incoterms" value="' . $location_incoterms . '">';

+            $out .= '<input id="location_incoterms" class="maxwidth100onsmartphone" name="location_incoterms" value="'.$location_incoterms.'">';

 

             if (!empty($page)) {

-                $out .= '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '"></form>';

+                $out .= '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'"></form>';

             }

         } else {

             dol_print_error($this->db);

@@ -919,8 +919,8 @@ 
         // If product & services are enabled or both disabled.

         if ($forceall == 1 || (empty($forceall) && !empty($conf->product->enabled) && !empty($conf->service->enabled)) || (empty($forceall) && empty($conf->product->enabled) && empty($conf->service->enabled))) {

             if (empty($hidetext))

-                print $langs->trans("Type") . ': ';

-            print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

+                print $langs->trans("Type").': ';

+            print '<select class="flat" id="select_'.$htmlname.'" name="'.$htmlname.'">';

             if ($showempty) {

                 print '<option value="-1"';

                 if ($selected == -1)

@@ -931,26 +931,26 @@ 
             print '<option value="0"';

             if (0 == $selected)

                 print ' selected';

-            print '>' . $langs->trans("Product");

+            print '>'.$langs->trans("Product");

 

             print '<option value="1"';

             if (1 == $selected)

                 print ' selected';

-            print '>' . $langs->trans("Service");

+            print '>'.$langs->trans("Service");

 

             print '</select>';

             //if ($user->admin) print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"),1);

         }

         if ((empty($forceall) && empty($conf->product->enabled) && !empty($conf->service->enabled)) || $forceall == 3) {

             print $langs->trans("Service");

-            print '<input type="hidden" name="' . $htmlname . '" value="1">';

+            print '<input type="hidden" name="'.$htmlname.'" value="1">';

         }

         if ((empty($forceall) && !empty($conf->product->enabled) && empty($conf->service->enabled)) || $forceall == 2) {

             print $langs->trans("Product");

-            print '<input type="hidden" name="' . $htmlname . '" value="0">';

+            print '<input type="hidden" name="'.$htmlname.'" value="0">';

         }

         if ($forceall < 0) { // This should happened only for contracts when both predefined product and service are disabled.

-            print '<input type="hidden" name="' . $htmlname . '" value="1">'; // By default we set on service for contract. If CONTRACT_SUPPORT_PRODUCTS is set, forceall should be 1 not -1

+            print '<input type="hidden" name="'.$htmlname.'" value="1">'; // By default we set on service for contract. If CONTRACT_SUPPORT_PRODUCTS is set, forceall should be 1 not -1

         }

     }

 

@@ -967,14 +967,14 @@ 
 

         $num = count($this->cache_types_fees);

         if ($num > 0)

-            return 0;    // Cache already loaded

+            return 0; // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

         $langs->load("trips");

 

         $sql = "SELECT c.code, c.label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_type_fees as c";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_type_fees as c";

         $sql .= " WHERE active > 0";

 

         $resql = $this->db->query($sql);

@@ -1014,11 +1014,11 @@ 
         // phpcs:enable

         global $user, $langs;

 

-        dol_syslog(__METHOD__ . " selected=" . $selected . ", htmlname=" . $htmlname, LOG_DEBUG);

+        dol_syslog(__METHOD__." selected=".$selected.", htmlname=".$htmlname, LOG_DEBUG);

 

         $this->load_cache_types_fees();

 

-        print '<select id="select_' . $htmlname . '" class="flat" name="' . $htmlname . '">';

+        print '<select id="select_'.$htmlname.'" class="flat" name="'.$htmlname.'">';

         if ($showempty) {

             print '<option value="-1"';

             if ($selected == -1)

@@ -1027,7 +1027,7 @@ 
         }

 

         foreach ($this->cache_types_fees as $key => $value) {

-            print '<option value="' . $key . '"';

+            print '<option value="'.$key.'"';

             if ($key == $selected)

                 print ' selected';

             print '>';

@@ -1090,25 +1090,25 @@ 
             // No immediate load of all database

             $placeholder = '';

             if ($selected && empty($selected_input_value)) {

-                require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';

                 $societetmp = new Societe($this->db);

                 $societetmp->fetch($selected);

                 $selected_input_value = $societetmp->name;

                 unset($societetmp);

             }

             // mode 1

-            $urloption = 'htmlname=' . $htmlname . '&outjson=1&filter=' . $filter . ($showtype ? '&showtype=' . $showtype : '');

-            $out .= ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT . '/societe/ajax/company.php', $urloption, $conf->global->COMPANY_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

+            $urloption = 'htmlname='.$htmlname.'&outjson=1&filter='.$filter.($showtype ? '&showtype='.$showtype : '');

+            $out .= ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT.'/societe/ajax/company.php', $urloption, $conf->global->COMPANY_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

             $out .= '<style type="text/css">.ui-autocomplete { z-index: 250; }</style>';

             if (empty($hidelabel))

-                print $langs->trans("RefOrLabel") . ' : ';

+                print $langs->trans("RefOrLabel").' : ';

             else if ($hidelabel > 1) {

-                $placeholder = ' placeholder="' . $langs->trans("RefOrLabel") . '"';

+                $placeholder = ' placeholder="'.$langs->trans("RefOrLabel").'"';

                 if ($hidelabel == 2) {

                     $out .= img_picto($langs->trans("Search"), 'search');

                 }

             }

-            $out .= '<input type="text" class="' . $morecss . '" name="search_' . $htmlname . '" id="search_' . $htmlname . '" value="' . $selected_input_value . '"' . $placeholder . ' ' . (!empty($conf->global->THIRDPARTY_SEARCH_AUTOFOCUS) ? 'autofocus' : '') . ' />';

+            $out .= '<input type="text" class="'.$morecss.'" name="search_'.$htmlname.'" id="search_'.$htmlname.'" value="'.$selected_input_value.'"'.$placeholder.' '.(!empty($conf->global->THIRDPARTY_SEARCH_AUTOFOCUS) ? 'autofocus' : '').' />';

             if ($hidelabel == 3) {

                 $out .= img_picto($langs->trans("Search"), 'search');

             }

@@ -1169,20 +1169,20 @@ 
             $sql .= " , dictp.code as country_code";

         }

 

-        $sql .= " FROM (" . MAIN_DB_PREFIX . "societe as s";

+        $sql .= " FROM (".MAIN_DB_PREFIX."societe as s";

         if (!$user->rights->societe->client->voir && !$user->socid)

-            $sql .= ", " . MAIN_DB_PREFIX . "societe_commerciaux as sc";

+            $sql .= ", ".MAIN_DB_PREFIX."societe_commerciaux as sc";

         $sql .= " )";

         if ($conf->global->COMPANY_SHOW_ADDRESS_SELECTLIST) {

-            $sql .= " LEFT OUTER JOIN " . MAIN_DB_PREFIX . "c_country as dictp ON dictp.rowid=s.fk_pays";

+            $sql .= " LEFT OUTER JOIN ".MAIN_DB_PREFIX."c_country as dictp ON dictp.rowid=s.fk_pays";

         }

-        $sql .= " WHERE s.entity IN (" . getEntity('societe') . ")";

+        $sql .= " WHERE s.entity IN (".getEntity('societe').")";

         if (!empty($user->socid))

-            $sql .= " AND s.rowid = " . $user->socid;

+            $sql .= " AND s.rowid = ".$user->socid;

         if ($filter)

-            $sql .= " AND (" . $filter . ")";

+            $sql .= " AND (".$filter.")";

         if (!$user->rights->societe->client->voir && !$user->socid)

-            $sql .= " AND s.rowid = sc.fk_soc AND sc.fk_user = " . $user->id;

+            $sql .= " AND s.rowid = sc.fk_soc AND sc.fk_user = ".$user->id;

         if (!empty($conf->global->COMPANY_HIDE_INACTIVE_IN_COMBOBOX))

             $sql .= " AND s.status <> 0";

         // Add criteria

@@ -1197,31 +1197,31 @@ 
             foreach ($scrit as $crit) {

                 if ($i > 0)

                     $sql .= " AND ";

-                $sql .= "(s.nom LIKE '" . $this->db->escape($prefix . $crit) . "%')";

+                $sql .= "(s.nom LIKE '".$this->db->escape($prefix.$crit)."%')";

                 $i++;

             }

             if (count($scrit) > 1)

                 $sql .= ")";

             if (!empty($conf->barcode->enabled)) {

-                $sql .= " OR s.barcode LIKE '" . $this->db->escape($prefix . $filterkey) . "%'";

+                $sql .= " OR s.barcode LIKE '".$this->db->escape($prefix.$filterkey)."%'";

             }

-            $sql .= " OR s.code_client LIKE '" . $this->db->escape($prefix . $filterkey) . "%' OR s.code_fournisseur LIKE '" . $this->db->escape($prefix . $filterkey) . "%'";

+            $sql .= " OR s.code_client LIKE '".$this->db->escape($prefix.$filterkey)."%' OR s.code_fournisseur LIKE '".$this->db->escape($prefix.$filterkey)."%'";

             $sql .= ")";

         }

         $sql .= $this->db->order("nom", "ASC");

         $sql .= $this->db->plimit($limit, 0);

 

         // Build output string

-        dol_syslog(get_class($this) . "::select_thirdparty_list", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_thirdparty_list", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

             if (!$forcecombo) {

-                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

                 $out .= ajax_combobox($htmlname, $events, $conf->global->COMPANY_USE_SEARCH_TO_SELECT);

             }

 

             // Construct $out and $outarray

-            $out .= '<select id="' . $htmlname . '" class="flat' . ($morecss ? ' ' . $morecss : '') . '"' . ($moreparam ? ' ' . $moreparam : '') . ' name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . '>' . "\n";

+            $out .= '<select id="'.$htmlname.'" class="flat'.($morecss ? ' '.$morecss : '').'"'.($moreparam ? ' '.$moreparam : '').' name="'.$htmlname.($multiple ? '[]' : '').'" '.($multiple ? 'multiple' : '').'>'."\n";

 

             $textifempty = '';

             // Do not use textifempty = ' ' or '&nbsp;' here, or search on key will search on ' key'.

@@ -1233,7 +1233,7 @@ 
                     $textifempty .= $langs->trans("All");

             }

             if ($showempty)

-                $out .= '<option value="-1">' . $textifempty . '</option>' . "\n";

+                $out .= '<option value="-1">'.$textifempty.'</option>'."\n";

 

             $num = $this->db->num_rows($resql);

             $i = 0;

@@ -1243,18 +1243,18 @@ 
                     $label = '';

                     if ($conf->global->SOCIETE_ADD_REF_IN_LIST) {

                         if (($obj->client) && (!empty($obj->code_client))) {

-                            $label = $obj->code_client . ' - ';

+                            $label = $obj->code_client.' - ';

                         }

                         if (($obj->fournisseur) && (!empty($obj->code_fournisseur))) {

-                            $label .= $obj->code_fournisseur . ' - ';

+                            $label .= $obj->code_fournisseur.' - ';

                         }

-                        $label .= ' ' . $obj->name;

+                        $label .= ' '.$obj->name;

                     } else {

                         $label = $obj->name;

                     }

 

                     if (!empty($obj->name_alias)) {

-                        $label .= ' (' . $obj->name_alias . ')';

+                        $label .= ' ('.$obj->name_alias.')';

                     }

 

                     if ($showtype) {

@@ -1263,25 +1263,25 @@ 
                         if ($obj->client == 1 || $obj->client == 3)

                             $label .= $langs->trans("Customer");

                         if ($obj->client == 2 || $obj->client == 3)

-                            $label .= ($obj->client == 3 ? ', ' : '') . $langs->trans("Prospect");

+                            $label .= ($obj->client == 3 ? ', ' : '').$langs->trans("Prospect");

                         if ($obj->fournisseur)

-                            $label .= ($obj->client ? ', ' : '') . $langs->trans("Supplier");

+                            $label .= ($obj->client ? ', ' : '').$langs->trans("Supplier");

                         if ($obj->client || $obj->fournisseur)

                             $label .= ')';

                     }

 

                     if ($conf->global->COMPANY_SHOW_ADDRESS_SELECTLIST) {

-                        $label .= '-' . $obj->address . '-' . $obj->zip . ' ' . $obj->town;

+                        $label .= '-'.$obj->address.'-'.$obj->zip.' '.$obj->town;

                         if (!empty($obj->country_code)) {

-                            $label .= ' ' . $langs->trans('Country' . $obj->country_code);

+                            $label .= ' '.$langs->trans('Country'.$obj->country_code);

                         }

                     }

 

                     if (empty($outputmode)) {

                         if (in_array($obj->rowid, $selected)) {

-                            $out .= '<option value="' . $obj->rowid . '" selected>' . $label . '</option>';

+                            $out .= '<option value="'.$obj->rowid.'" selected>'.$label.'</option>';

                         } else {

-                            $out .= '<option value="' . $obj->rowid . '">' . $label . '</option>';

+                            $out .= '<option value="'.$obj->rowid.'">'.$label.'</option>';

                         }

                     } else {

                         array_push($outarray, array('key' => $obj->rowid, 'value' => $label, 'label' => $label));

@@ -1292,7 +1292,7 @@ 
                         $out .= "\n";

                 }

             }

-            $out .= '</select>' . "\n";

+            $out .= '</select>'."\n";

         }

         else {

             dol_print_error($this->db);

@@ -1324,17 +1324,17 @@ 
         // On recherche les remises

         $sql = "SELECT re.rowid, re.amount_ht, re.amount_tva, re.amount_ttc,";

         $sql .= " re.description, re.fk_facture_source";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "societe_remise_except as re";

-        $sql .= " WHERE re.fk_soc = " . (int) $socid;

-        $sql .= " AND re.entity = " . $conf->entity;

+        $sql .= " FROM ".MAIN_DB_PREFIX."societe_remise_except as re";

+        $sql .= " WHERE re.fk_soc = ".(int) $socid;

+        $sql .= " AND re.entity = ".$conf->entity;

         if ($filter)

-            $sql .= " AND " . $filter;

+            $sql .= " AND ".$filter;

         $sql .= " ORDER BY re.description ASC";

 

-        dol_syslog(get_class($this) . "::select_remises", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_remises", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

-            print '<select id="select_' . $htmlname . '" class="flat maxwidthonsmartphone" name="' . $htmlname . '">';

+            print '<select id="select_'.$htmlname.'" class="flat maxwidthonsmartphone" name="'.$htmlname.'">';

             $num = $this->db->num_rows($resql);

 

             $qualifiedlines = $num;

@@ -1367,10 +1367,10 @@ 
                     if (!empty($conf->global->MAIN_SHOW_FACNUMBER_IN_DISCOUNT_LIST) && !empty($obj->fk_facture_source)) {

                         $tmpfac = new Facture($this->db);

                         if ($tmpfac->fetch($obj->fk_facture_source) > 0)

-                            $desc = $desc . ' - ' . $tmpfac->ref;

+                            $desc = $desc.' - '.$tmpfac->ref;

                     }

 

-                    print '<option value="' . $obj->rowid . '"' . $selectstring . $disabled . '>' . $desc . ' (' . price($obj->amount_ht) . ' ' . $langs->trans("HT") . ' - ' . price($obj->amount_ttc) . ' ' . $langs->trans("TTC") . ')</option>';

+                    print '<option value="'.$obj->rowid.'"'.$selectstring.$disabled.'>'.$desc.' ('.price($obj->amount_ht).' '.$langs->trans("HT").' - '.price($obj->amount_ttc).' '.$langs->trans("TTC").')</option>';

                     $i++;

                 }

             }

@@ -1450,7 +1450,7 @@ 
         $out = '';

 

         if (!is_object($hookmanager)) {

-            include_once DOL_DOCUMENT_ROOT . '/core/class/hookmanager.class.php';

+            include_once DOL_DOCUMENT_ROOT.'/core/class/hookmanager.class.php';

             $hookmanager = new HookManager($this->db);

         }

 

@@ -1458,36 +1458,36 @@ 
         $sql = "SELECT sp.rowid, sp.lastname, sp.statut, sp.firstname, sp.poste";

         if ($showsoc > 0)

             $sql .= " , s.nom as company";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "socpeople as sp";

+        $sql .= " FROM ".MAIN_DB_PREFIX."socpeople as sp";

         if ($showsoc > 0)

-            $sql .= " LEFT OUTER JOIN  " . MAIN_DB_PREFIX . "societe as s ON s.rowid=sp.fk_soc";

-        $sql .= " WHERE sp.entity IN (" . getEntity('socpeople') . ")";

+            $sql .= " LEFT OUTER JOIN  ".MAIN_DB_PREFIX."societe as s ON s.rowid=sp.fk_soc";

+        $sql .= " WHERE sp.entity IN (".getEntity('socpeople').")";

         if ($socid > 0 || $socid == -1)

-            $sql .= " AND sp.fk_soc=" . $socid;

+            $sql .= " AND sp.fk_soc=".$socid;

         if (!empty($conf->global->CONTACT_HIDE_INACTIVE_IN_COMBOBOX))

             $sql .= " AND sp.statut <> 0";

         $sql .= " ORDER BY sp.lastname ASC";

 

-        dol_syslog(get_class($this) . "::select_contacts", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_contacts", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

             $num = $this->db->num_rows($resql);

 

             if ($conf->use_javascript_ajax && !$forcecombo && !$options_only) {

-                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

                 $out .= ajax_combobox($htmlid, $events, $conf->global->CONTACT_USE_SEARCH_TO_SELECT);

             }

 

             if ($htmlname != 'none' || $options_only)

-                $out .= '<select class="flat' . ($moreclass ? ' ' . $moreclass : '') . '" id="' . $htmlid . '" name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . ' ' . (!empty($moreparam) ? $moreparam : '') . '>';

+                $out .= '<select class="flat'.($moreclass ? ' '.$moreclass : '').'" id="'.$htmlid.'" name="'.$htmlname.($multiple ? '[]' : '').'" '.($multiple ? 'multiple' : '').' '.(!empty($moreparam) ? $moreparam : '').'>';

             if (($showempty == 1 || ($showempty == 3 && $num > 1)) && !$multiple)

-                $out .= '<option value="0"' . (in_array(0, $selected) ? ' selected' : '') . '>&nbsp;</option>';

+                $out .= '<option value="0"'.(in_array(0, $selected) ? ' selected' : '').'>&nbsp;</option>';

             if ($showempty == 2)

-                $out .= '<option value="0"' . (in_array(0, $selected) ? ' selected' : '') . '>' . $langs->trans("Internal") . '</option>';

+                $out .= '<option value="0"'.(in_array(0, $selected) ? ' selected' : '').'>'.$langs->trans("Internal").'</option>';

             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

-                include_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';

+                include_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

                 $contactstatic = new Contact($this->db);

 

                 while ($i < $num) {

@@ -1504,27 +1504,27 @@ 
                             if (is_array($limitto) && count($limitto) && !in_array($obj->rowid, $limitto))

                                 $disabled = 1;

                             if (!empty($selected) && in_array($obj->rowid, $selected)) {

-                                $out .= '<option value="' . $obj->rowid . '"';

+                                $out .= '<option value="'.$obj->rowid.'"';

                                 if ($disabled)

                                     $out .= ' disabled';

                                 $out .= ' selected>';

                                 $out .= $contactstatic->getFullName($langs);

                                 if ($showfunction && $obj->poste)

-                                    $out .= ' (' . $obj->poste . ')';

+                                    $out .= ' ('.$obj->poste.')';

                                 if (($showsoc > 0) && $obj->company)

-                                    $out .= ' - (' . $obj->company . ')';

+                                    $out .= ' - ('.$obj->company.')';

                                 $out .= '</option>';

                             }

                             else {

-                                $out .= '<option value="' . $obj->rowid . '"';

+                                $out .= '<option value="'.$obj->rowid.'"';

                                 if ($disabled)

                                     $out .= ' disabled';

                                 $out .= '>';

                                 $out .= $contactstatic->getFullName($langs);

                                 if ($showfunction && $obj->poste)

-                                    $out .= ' (' . $obj->poste . ')';

+                                    $out .= ' ('.$obj->poste.')';

                                 if (($showsoc > 0) && $obj->company)

-                                    $out .= ' - (' . $obj->company . ')';

+                                    $out .= ' - ('.$obj->company.')';

                                 $out .= '</option>';

                             }

                         }

@@ -1532,9 +1532,9 @@ 
                             if (in_array($obj->rowid, $selected)) {

                                 $out .= $contactstatic->getFullName($langs);

                                 if ($showfunction && $obj->poste)

-                                    $out .= ' (' . $obj->poste . ')';

+                                    $out .= ' ('.$obj->poste.')';

                                 if (($showsoc > 0) && $obj->company)

-                                    $out .= ' - (' . $obj->company . ')';

+                                    $out .= ' - ('.$obj->company.')';

                             }

                         }

                     }

@@ -1542,7 +1542,7 @@ 
                 }

             }

             else {

-                $out .= '<option value="-1"' . (($showempty == 2 || $multiple) ? '' : ' selected') . ' disabled>';

+                $out .= '<option value="-1"'.(($showempty == 2 || $multiple) ? '' : ' selected').' disabled>';

                 $out .= ($socid != -1) ? ($langs->trans($socid ? "NoContactDefinedForThirdParty" : "NoContactDefined")) : $langs->trans('SelectAThirdPartyFirst');

                 $out .= '</option>';

             }

@@ -1556,7 +1556,7 @@ 
                 'showsoc' => $showsoc,

             );

 

-            $reshook = $hookmanager->executeHooks('afterSelectContactOptions', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

+            $reshook = $hookmanager->executeHooks('afterSelectContactOptions', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 

             if ($htmlname != 'none' || $options_only) {

                 $out .= '</select>';

@@ -1655,33 +1655,33 @@ 
         if (!empty($conf->multicompany->enabled) && $conf->entity == 1 && $user->admin && !$user->entity) {

             $sql .= ", e.label";

         }

-        $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";

+        $sql .= " FROM ".MAIN_DB_PREFIX."user as u";

         if (!empty($conf->multicompany->enabled) && $conf->entity == 1 && $user->admin && !$user->entity) {

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "entity as e ON e.rowid=u.entity";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."entity as e ON e.rowid=u.entity";

             if ($force_entity)

-                $sql .= " WHERE u.entity IN (0," . $force_entity . ")";

+                $sql .= " WHERE u.entity IN (0,".$force_entity.")";

             else

                 $sql .= " WHERE u.entity IS NOT NULL";

         }

         else {

             if (!empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

-                $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "usergroup_user as ug";

+                $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."usergroup_user as ug";

                 $sql .= " ON ug.fk_user = u.rowid";

-                $sql .= " WHERE ug.entity = " . $conf->entity;

+                $sql .= " WHERE ug.entity = ".$conf->entity;

             } else {

-                $sql .= " WHERE u.entity IN (0," . $conf->entity . ")";

+                $sql .= " WHERE u.entity IN (0,".$conf->entity.")";

             }

         }

         if (!empty($user->societe_id))

-            $sql .= " AND u.fk_soc = " . $user->societe_id;

+            $sql .= " AND u.fk_soc = ".$user->societe_id;

         if (is_array($exclude) && $excludeUsers)

-            $sql .= " AND u.rowid NOT IN (" . $excludeUsers . ")";

+            $sql .= " AND u.rowid NOT IN (".$excludeUsers.")";

         if ($includeUsers)

-            $sql .= " AND u.rowid IN (" . $includeUsers . ")";

+            $sql .= " AND u.rowid IN (".$includeUsers.")";

         if (!empty($conf->global->USER_HIDE_INACTIVE_IN_COMBOBOX) || $noactive)

             $sql .= " AND u.statut <> 0";

         if (!empty($morefilter))

-            $sql .= " " . $morefilter;

+            $sql .= " ".$morefilter;

 

         if (empty($conf->global->MAIN_FIRSTNAME_NAME_POSITION)) { // MAIN_FIRSTNAME_NAME_POSITION is 0 means firstname+lastname

             $sql .= " ORDER BY u.firstname ASC";

@@ -1689,22 +1689,22 @@ 
             $sql .= " ORDER BY u.lastname ASC";

         }

 

-        dol_syslog(get_class($this) . "::select_dolusers", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_dolusers", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

                 // Enhance with select2

-                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

                 $out .= ajax_combobox($htmlname);

 

                 // do not use maxwidthonsmartphone by default. Set it by caller so auto size to 100% will work when not defined

-                $out .= '<select class="flat' . ($morecss ? ' minwidth100 ' . $morecss : ' minwidth200') . '" id="' . $htmlname . '" name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . ' ' . ($disabled ? ' disabled' : '') . '>';

+                $out .= '<select class="flat'.($morecss ? ' minwidth100 '.$morecss : ' minwidth200').'" id="'.$htmlname.'" name="'.$htmlname.($multiple ? '[]' : '').'" '.($multiple ? 'multiple' : '').' '.($disabled ? ' disabled' : '').'>';

                 if ($show_empty && !$multiple)

-                    $out .= '<option value="-1"' . ((empty($selected) || in_array(-1, $selected)) ? ' selected' : '') . '>&nbsp;</option>' . "\n";

+                    $out .= '<option value="-1"'.((empty($selected) || in_array(-1, $selected)) ? ' selected' : '').'>&nbsp;</option>'."\n";

                 if ($show_every)

-                    $out .= '<option value="-2"' . ((in_array(-2, $selected)) ? ' selected' : '') . '>-- ' . $langs->trans("Everybody") . ' --</option>' . "\n";

+                    $out .= '<option value="-2"'.((in_array(-2, $selected)) ? ' selected' : '').'>-- '.$langs->trans("Everybody").' --</option>'."\n";

 

                 $userstatic = new User($this->db);

 

@@ -1719,14 +1719,14 @@ 
                     if (is_array($enableonly) && count($enableonly) && !in_array($obj->rowid, $enableonly))

                         $disableline = ($enableonlytext ? $enableonlytext : '1');

 

-                    if ((is_object($selected) && $selected->id == $obj->rowid) || (!is_object($selected) && in_array($obj->rowid, $selected) )) {

-                        $out .= '<option value="' . $obj->rowid . '"';

+                    if ((is_object($selected) && $selected->id == $obj->rowid) || (!is_object($selected) && in_array($obj->rowid, $selected))) {

+                        $out .= '<option value="'.$obj->rowid.'"';

                         if ($disableline)

                             $out .= ' disabled';

                         $out .= ' selected>';

                     }

                     else {

-                        $out .= '<option value="' . $obj->rowid . '"';

+                        $out .= '<option value="'.$obj->rowid.'"';

                         if ($disableline)

                             $out .= ' disabled';

                         $out .= '>';

@@ -1742,31 +1742,31 @@ 
                     // Complete name with more info

                     $moreinfo = 0;

                     if (!empty($conf->global->MAIN_SHOW_LOGIN)) {

-                        $out .= ($moreinfo ? ' - ' : ' (') . $obj->login;

+                        $out .= ($moreinfo ? ' - ' : ' (').$obj->login;

                         $moreinfo++;

                     }

                     if ($showstatus >= 0) {

                         if ($obj->statut == 1 && $showstatus == 1) {

-                            $out .= ($moreinfo ? ' - ' : ' (') . $langs->trans('Enabled');

+                            $out .= ($moreinfo ? ' - ' : ' (').$langs->trans('Enabled');

                             $moreinfo++;

                         }

                         if ($obj->statut == 0) {

-                            $out .= ($moreinfo ? ' - ' : ' (') . $langs->trans('Disabled');

+                            $out .= ($moreinfo ? ' - ' : ' (').$langs->trans('Disabled');

                             $moreinfo++;

                         }

                     }

                     if (!empty($conf->multicompany->enabled) && empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE) && $conf->entity == 1 && $user->admin && !$user->entity) {

                         if (!$obj->entity) {

-                            $out .= ($moreinfo ? ' - ' : ' (') . $langs->trans("AllEntities");

+                            $out .= ($moreinfo ? ' - ' : ' (').$langs->trans("AllEntities");

                             $moreinfo++;

                         } else {

-                            $out .= ($moreinfo ? ' - ' : ' (') . ($obj->label ? $obj->label : $langs->trans("EntityNameNotDefined"));

+                            $out .= ($moreinfo ? ' - ' : ' (').($obj->label ? $obj->label : $langs->trans("EntityNameNotDefined"));

                             $moreinfo++;

                         }

                     }

                     $out .= ($moreinfo ? ')' : '');

                     if ($disableline && $disableline != '1') {

-                        $out .= ' - ' . $disableline; // This is text from $enableonlytext parameter

+                        $out .= ' - '.$disableline; // This is text from $enableonlytext parameter

                     }

                     $out .= '</option>';

                     $outarray[$userstatic->id] = $userstatic->getFullName($langs, $fullNameMode, -1, $maxlength);

@@ -1774,8 +1774,8 @@ 
                     $i++;

                 }

             } else {

-                $out .= '<select class="flat" id="' . $htmlname . '" name="' . $htmlname . '" disabled>';

-                $out .= '<option value="">' . $langs->trans("None") . '</option>';

+                $out .= '<select class="flat" id="'.$htmlname.'" name="'.$htmlname.'" disabled>';

+                $out .= '<option value="">'.$langs->trans("None").'</option>';

             }

             $out .= '</select>';

         } else {

@@ -1826,7 +1826,7 @@ 
             $out .= '<input type="hidden" class="removedassignedhidden" name="removedassigned" value="">';

             $out .= '<script type="text/javascript" language="javascript">jQuery(document).ready(function () {    jQuery(".removedassigned").click(function() {        jQuery(".removedassignedhidden").val(jQuery(this).val());    });})</script>';

             $out .= $this->select_dolusers('', $htmlname, $show_empty, $exclude, $disabled, $include, $enableonly, $force_entity, $maxlength, $showstatus, $morefilter);

-            $out .= ' <input type="submit" class="button valignmiddle" name="' . $action . 'assignedtouser" value="' . dol_escape_htmltag($langs->trans("Add")) . '">';

+            $out .= ' <input type="submit" class="button valignmiddle" name="'.$action.'assignedtouser" value="'.dol_escape_htmltag($langs->trans("Add")).'">';

             $out .= '<br>';

         }

         $assignedtouser = array();

@@ -1850,16 +1850,16 @@ 
             $out .= $userstatic->getNomUrl(-1);

             if ($i == 0) {

                 $ownerid = $value['id'];

-                $out .= ' (' . $langs->trans("Owner") . ')';

+                $out .= ' ('.$langs->trans("Owner").')';

             }

             if ($nbassignetouser > 1 && $action != 'view') {

-                $out .= ' <input type="image" style="border: 0px;" src="' . img_picto($langs->trans("Remove"), 'delete', '', 0, 1) . '" value="' . $userstatic->id . '" class="removedassigned" id="removedassigned_' . $userstatic->id . '" name="removedassigned_' . $userstatic->id . '">';

+                $out .= ' <input type="image" style="border: 0px;" src="'.img_picto($langs->trans("Remove"), 'delete', '', 0, 1).'" value="'.$userstatic->id.'" class="removedassigned" id="removedassigned_'.$userstatic->id.'" name="removedassigned_'.$userstatic->id.'">';

             }

             // Show my availability

             if ($showproperties) {

                 if ($ownerid == $value['id'] && is_array($listofuserid) && count($listofuserid) && in_array($ownerid, array_keys($listofuserid))) {

                     $out .= '<div class="myavailability inline-block">';

-                    $out .= '&nbsp;-&nbsp;<span class="opacitymedium">' . $langs->trans("Availability") . ':</span>  <input id="transparency" class="marginleftonly marginrightonly" ' . ($action == 'view' ? 'disabled' : '') . ' type="checkbox" name="transparency"' . ($listofuserid[$ownerid]['transparency'] ? ' checked' : '') . '>' . $langs->trans("Busy");

+                    $out .= '&nbsp;-&nbsp;<span class="opacitymedium">'.$langs->trans("Availability").':</span>  <input id="transparency" class="marginleftonly marginrightonly" '.($action == 'view' ? 'disabled' : '').' type="checkbox" name="transparency"'.($listofuserid[$ownerid]['transparency'] ? ' checked' : '').'>'.$langs->trans("Busy");

                     $out .= '</div>';

                 }

             }

@@ -1913,19 +1913,19 @@ 
             $placeholder = '';

 

             if ($selected && empty($selected_input_value)) {

-                require_once DOL_DOCUMENT_ROOT . '/product/class/product.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

                 $producttmpselect = new Product($this->db);

                 $producttmpselect->fetch($selected);

                 $selected_input_value = $producttmpselect->ref;

                 unset($producttmpselect);

             }

             // mode=1 means customers products

-            $urloption = 'htmlname=' . $htmlname . '&outjson=1&price_level=' . $price_level . '&type=' . $filtertype . '&mode=1&status=' . $status . '&finished=' . $finished . '&hidepriceinlabel=' . $hidepriceinlabel . '&warehousestatus=' . $warehouseStatus;

+            $urloption = 'htmlname='.$htmlname.'&outjson=1&price_level='.$price_level.'&type='.$filtertype.'&mode=1&status='.$status.'&finished='.$finished.'&hidepriceinlabel='.$hidepriceinlabel.'&warehousestatus='.$warehouseStatus;

             //Price by customer

             if (!empty($conf->global->PRODUIT_CUSTOMER_PRICES) && !empty($socid)) {

-                $urloption .= '&socid=' . $socid;

+                $urloption .= '&socid='.$socid;

             }

-            print ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT . '/product/ajax/products.php', $urloption, $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

+            print ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT.'/product/ajax/products.php', $urloption, $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

 

             if (!empty($conf->variants->enabled)) {

 

@@ -2002,14 +2002,14 @@ 
                                 <?php

                             }

                             if (empty($hidelabel))

-                                print $langs->trans("RefOrLabel") . ' : ';

+                                print $langs->trans("RefOrLabel").' : ';

                             else if ($hidelabel > 1) {

-                                $placeholder = ' placeholder="' . $langs->trans("RefOrLabel") . '"';

+                                $placeholder = ' placeholder="'.$langs->trans("RefOrLabel").'"';

                                 if ($hidelabel == 2) {

                                     print img_picto($langs->trans("Search"), 'search');

                                 }

                             }

-                            print '<input type="text" class="minwidth100" name="search_' . $htmlname . '" id="search_' . $htmlname . '" value="' . $selected_input_value . '"' . $placeholder . ' ' . (!empty($conf->global->PRODUCT_SEARCH_AUTOFOCUS) ? 'autofocus' : '') . ' />';

+                            print '<input type="text" class="minwidth100" name="search_'.$htmlname.'" id="search_'.$htmlname.'" value="'.$selected_input_value.'"'.$placeholder.' '.(!empty($conf->global->PRODUCT_SEARCH_AUTOFOCUS) ? 'autofocus' : '').' />';

                             if ($hidelabel == 3) {

                                 print img_picto($langs->trans("Search"), 'search');

                             }

@@ -2052,7 +2052,7 @@ 
 

         $warehouseStatusArray = array();

         if (!empty($warehouseStatus)) {

-            require_once DOL_DOCUMENT_ROOT . '/product/stock/class/entrepot.class.php';

+            require_once DOL_DOCUMENT_ROOT.'/product/stock/class/entrepot.class.php';

             if (preg_match('/warehouseclosed/', $warehouseStatus)) {

                 $warehouseStatusArray[] = Entrepot::STATUS_CLOSED;

             }

@@ -2068,13 +2068,13 @@ 
         (count($warehouseStatusArray)) ? $selectFieldsGrouped = ", sum(ps.reel) as stock" : $selectFieldsGrouped = ", p.stock";

 

         $sql = "SELECT ";

-        $sql .= $selectFields . $selectFieldsGrouped;

+        $sql .= $selectFields.$selectFieldsGrouped;

 

         if (!empty($conf->global->PRODUCT_SORT_BY_CATEGORY)) {

             //Product category

-            $sql .= ", (SELECT " . MAIN_DB_PREFIX . "categorie_product.fk_categorie

-						FROM " . MAIN_DB_PREFIX . "categorie_product

-						WHERE " . MAIN_DB_PREFIX . "categorie_product.fk_product=p.rowid

+            $sql .= ", (SELECT ".MAIN_DB_PREFIX."categorie_product.fk_categorie

+						FROM " . MAIN_DB_PREFIX."categorie_product

+						WHERE " . MAIN_DB_PREFIX."categorie_product.fk_product=p.rowid

 						LIMIT 1

 				) AS categorie_product_id ";

         }

@@ -2093,45 +2093,45 @@ 
         }

         // Price by quantity

         if (!empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY) || !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES)) {

-            $sql .= ", (SELECT pp.rowid FROM " . MAIN_DB_PREFIX . "product_price as pp WHERE pp.fk_product = p.rowid";

+            $sql .= ", (SELECT pp.rowid FROM ".MAIN_DB_PREFIX."product_price as pp WHERE pp.fk_product = p.rowid";

             if ($price_level >= 1 && !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES))

-                $sql .= " AND price_level=" . $price_level;

+                $sql .= " AND price_level=".$price_level;

             $sql .= " ORDER BY date_price";

             $sql .= " DESC LIMIT 1) as price_rowid";

-            $sql .= ", (SELECT pp.price_by_qty FROM " . MAIN_DB_PREFIX . "product_price as pp WHERE pp.fk_product = p.rowid"; // price_by_qty is 1 if some prices by qty exists in subtable

+            $sql .= ", (SELECT pp.price_by_qty FROM ".MAIN_DB_PREFIX."product_price as pp WHERE pp.fk_product = p.rowid"; // price_by_qty is 1 if some prices by qty exists in subtable

             if ($price_level >= 1 && !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES))

-                $sql .= " AND price_level=" . $price_level;

+                $sql .= " AND price_level=".$price_level;

             $sql .= " ORDER BY date_price";

             $sql .= " DESC LIMIT 1) as price_by_qty";

             $selectFields .= ", price_rowid, price_by_qty";

         }

-        $sql .= " FROM " . MAIN_DB_PREFIX . "product as p";

+        $sql .= " FROM ".MAIN_DB_PREFIX."product as p";

         if (count($warehouseStatusArray)) {

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_stock as ps on ps.fk_product = p.rowid";

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "entrepot as e on ps.fk_entrepot = e.rowid";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_stock as ps on ps.fk_product = p.rowid";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."entrepot as e on ps.fk_entrepot = e.rowid";

         }

 

         // include search in supplier ref

         if (!empty($conf->global->MAIN_SEARCH_PRODUCT_BY_FOURN_REF)) {

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

         }

 

         //Price by customer

         if (!empty($conf->global->PRODUIT_CUSTOMER_PRICES) && !empty($socid)) {

-            $sql .= " LEFT JOIN  " . MAIN_DB_PREFIX . "product_customer_price as pcp ON pcp.fk_soc=" . $socid . " AND pcp.fk_product=p.rowid";

+            $sql .= " LEFT JOIN  ".MAIN_DB_PREFIX."product_customer_price as pcp ON pcp.fk_soc=".$socid." AND pcp.fk_product=p.rowid";

         }

         // Multilang : we add translation

         if (!empty($conf->global->MAIN_MULTILANGS)) {

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_lang as pl ON pl.fk_product = p.rowid AND pl.lang='" . $langs->getDefaultLang() . "'";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_lang as pl ON pl.fk_product = p.rowid AND pl.lang='".$langs->getDefaultLang()."'";

         }

 

         if (!empty($conf->global->PRODUIT_ATTRIBUTES_HIDECHILD)) {

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_attribute_combination pac ON pac.fk_product_child = p.rowid";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_attribute_combination pac ON pac.fk_product_child = p.rowid";

         }

 

-        $sql .= ' WHERE p.entity IN (' . getEntity('product') . ')';

+        $sql .= ' WHERE p.entity IN ('.getEntity('product').')';

         if (count($warehouseStatusArray)) {

-            $sql .= ' AND (p.fk_product_type = 1 OR e.statut IN (' . $this->db->escape(implode(',', $warehouseStatusArray)) . '))';

+            $sql .= ' AND (p.fk_product_type = 1 OR e.statut IN ('.$this->db->escape(implode(',', $warehouseStatusArray)).'))';

         }

 

         if (!empty($conf->global->PRODUIT_ATTRIBUTES_HIDECHILD)) {

@@ -2139,17 +2139,17 @@ 
         }

 

         if ($finished == 0) {

-            $sql .= " AND p.finished = " . $finished;

+            $sql .= " AND p.finished = ".$finished;

         } elseif ($finished == 1) {

-            $sql .= " AND p.finished = " . $finished;

+            $sql .= " AND p.finished = ".$finished;

             if ($status >= 0)

-                $sql .= " AND p.tosell = " . $status;

+                $sql .= " AND p.tosell = ".$status;

         }

         elseif ($status >= 0) {

-            $sql .= " AND p.tosell = " . $status;

+            $sql .= " AND p.tosell = ".$status;

         }

         if (strval($filtertype) != '')

-            $sql .= " AND p.fk_product_type=" . $filtertype;

+            $sql .= " AND p.fk_product_type=".$filtertype;

         // Add criteria on ref/label

         if ($filterkey != '') {

             $sql .= ' AND (';

@@ -2162,27 +2162,27 @@ 
             foreach ($scrit as $crit) {

                 if ($i > 0)

                     $sql .= " AND ";

-                $sql .= "(p.ref LIKE '" . $db->escape($prefix . $crit) . "%' OR p.label LIKE '" . $db->escape($prefix . $crit) . "%'";

+                $sql .= "(p.ref LIKE '".$db->escape($prefix.$crit)."%' OR p.label LIKE '".$db->escape($prefix.$crit)."%'";

                 if (!empty($conf->global->MAIN_MULTILANGS))

-                    $sql .= " OR pl.label LIKE '" . $db->escape($prefix . $crit) . "%'";

+                    $sql .= " OR pl.label LIKE '".$db->escape($prefix.$crit)."%'";

                 if (!empty($conf->global->PRODUCT_AJAX_SEARCH_ON_DESCRIPTION)) {

-                    $sql .= " OR p.description LIKE '" . $db->escape($prefix . $crit) . "%'";

+                    $sql .= " OR p.description LIKE '".$db->escape($prefix.$crit)."%'";

                     if (!empty($conf->global->MAIN_MULTILANGS))

-                        $sql .= " OR pl.description LIKE '" . $db->escape($prefix . $crit) . "%'";

+                        $sql .= " OR pl.description LIKE '".$db->escape($prefix.$crit)."%'";

                 }

                 if (!empty($conf->global->MAIN_SEARCH_PRODUCT_BY_FOURN_REF))

-                    $sql .= " OR pfp.ref_fourn LIKE '" . $db->escape($prefix . $crit) . "%'";

+                    $sql .= " OR pfp.ref_fourn LIKE '".$db->escape($prefix.$crit)."%'";

                 $sql .= ")";

                 $i++;

             }

             if (count($scrit) > 1)

                 $sql .= ")";

             if (!empty($conf->barcode->enabled))

-                $sql .= " OR p.barcode LIKE '" . $db->escape($prefix . $filterkey) . "%'";

+                $sql .= " OR p.barcode LIKE '".$db->escape($prefix.$filterkey)."%'";

             $sql .= ')';

         }

         if (count($warehouseStatusArray)) {

-            $sql .= ' GROUP BY' . $selectFields;

+            $sql .= ' GROUP BY'.$selectFields;

         }

 

         //Sort by category

@@ -2197,21 +2197,21 @@ 
         $sql .= $db->plimit($limit, 0);

 

         // Build output string

-        dol_syslog(get_class($this) . "::select_produits_list search product", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_produits_list search product", LOG_DEBUG);

         $result = $this->db->query($sql);

         if ($result) {

-            require_once DOL_DOCUMENT_ROOT . '/product/class/product.class.php';

-            require_once DOL_DOCUMENT_ROOT . '/product/dynamic_price/class/price_parser.class.php';

+            require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

+            require_once DOL_DOCUMENT_ROOT.'/product/dynamic_price/class/price_parser.class.php';

             $num = $this->db->num_rows($result);

 

             $events = null;

 

             if (!$forcecombo) {

-                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

                 $out .= ajax_combobox($htmlname, $events, $conf->global->PRODUIT_USE_SEARCH_TO_SELECT);

             }

 

-            $out .= '<select class="flat' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '" id="' . $htmlname . '">';

+            $out .= '<select class="flat'.($morecss ? ' '.$morecss : '').'" name="'.$htmlname.'" id="'.$htmlname.'">';

 

             $textifempty = '';

             // Do not use textifempty = ' ' or '&nbsp;' here, or search on key will search on ' key'.

@@ -2223,7 +2223,7 @@ 
                     $textifempty .= $langs->trans("All");

             }

             if ($showempty)

-                $out .= '<option value="0" selected>' . $textifempty . '</option>';

+                $out .= '<option value="0" selected>'.$textifempty.'</option>';

 

             $i = 0;

             while ($num && $i < $num) {

@@ -2233,11 +2233,11 @@ 
 

                 if ((!empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY) || !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES)) && !empty($objp->price_by_qty) && $objp->price_by_qty == 1) { // Price by quantity will return many prices for the same product

                     $sql = "SELECT rowid, quantity, price, unitprice, remise_percent, remise, price_base_type";

-                    $sql .= " FROM " . MAIN_DB_PREFIX . "product_price_by_qty";

-                    $sql .= " WHERE fk_product_price=" . $objp->price_rowid;

+                    $sql .= " FROM ".MAIN_DB_PREFIX."product_price_by_qty";

+                    $sql .= " WHERE fk_product_price=".$objp->price_rowid;

                     $sql .= " ORDER BY quantity ASC";

 

-                    dol_syslog(get_class($this) . "::select_produits_list search price by qty", LOG_DEBUG);

+                    dol_syslog(get_class($this)."::select_produits_list search price by qty", LOG_DEBUG);

                     $result2 = $this->db->query($sql);

                     if ($result2) {

                         $nb_prices = $this->db->num_rows($result2);

@@ -2341,7 +2341,7 @@ 
         if (!empty($objp->label_translated))

             $label = $objp->label_translated;

         if (!empty($filterkey) && $filterkey != '')

-            $label = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $label, 1);

+            $label = preg_replace('/('.preg_quote($filterkey).')/i', '<strong>$1</strong>', $label, 1);

 

         $outkey = $objp->rowid;

         $outref = $objp->ref;

@@ -2353,10 +2353,10 @@ 
         $outdurationvalue = $outtype == Product::TYPE_SERVICE ? substr($objp->duration, 0, dol_strlen($objp->duration) - 1) : '';

         $outdurationunit = $outtype == Product::TYPE_SERVICE ? substr($objp->duration, -1) : '';

 

-        $opt = '<option value="' . $objp->rowid . '"';

+        $opt = '<option value="'.$objp->rowid.'"';

         $opt .= ($objp->rowid == $selected) ? ' selected' : '';

         if (!empty($objp->price_by_qty_rowid) && $objp->price_by_qty_rowid > 0) {

-            $opt .= ' pbq="' . $objp->price_by_qty_rowid . '" data-pbq="' . $objp->price_by_qty_rowid . '" data-pbqqty="' . $objp->price_by_qty_quantity . '" data-pbqpercent="' . $objp->price_by_qty_remise_percent . '"';

+            $opt .= ' pbq="'.$objp->price_by_qty_rowid.'" data-pbq="'.$objp->price_by_qty_rowid.'" data-pbqqty="'.$objp->price_by_qty_quantity.'" data-pbqpercent="'.$objp->price_by_qty_remise_percent.'"';

         }

         if (!empty($conf->stock->enabled) && $objp->fk_product_type == 0 && isset($objp->stock)) {

             if ($objp->stock > 0)

@@ -2367,16 +2367,16 @@ 
         $opt .= '>';

         $opt .= $objp->ref;

         if ($outbarcode)

-            $opt .= ' (' . $outbarcode . ')';

-        $opt .= ' - ' . dol_trunc($label, $maxlengtharticle);

+            $opt .= ' ('.$outbarcode.')';

+        $opt .= ' - '.dol_trunc($label, $maxlengtharticle);

 

         $objRef = $objp->ref;

         if (!empty($filterkey) && $filterkey != '')

-            $objRef = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRef, 1);

+            $objRef = preg_replace('/('.preg_quote($filterkey).')/i', '<strong>$1</strong>', $objRef, 1);

         $outval .= $objRef;

         if ($outbarcode)

-            $outval .= ' (' . $outbarcode . ')';

-        $outval .= ' - ' . dol_trunc($label, $maxlengtharticle);

+            $outval .= ' ('.$outbarcode.')';

+        $outval .= ' - '.dol_trunc($label, $maxlengtharticle);

 

         $found = 0;

 

@@ -2384,25 +2384,25 @@ 
         // If we need a particular price level (from 1 to 6)

         if (empty($hidepriceinlabel) && $price_level >= 1 && (!empty($conf->global->PRODUIT_MULTIPRICES) || !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES))) {

             $sql = "SELECT price, price_ttc, price_base_type, tva_tx";

-            $sql .= " FROM " . MAIN_DB_PREFIX . "product_price";

-            $sql .= " WHERE fk_product='" . $objp->rowid . "'";

-            $sql .= " AND entity IN (" . getEntity('productprice') . ")";

-            $sql .= " AND price_level=" . $price_level;

+            $sql .= " FROM ".MAIN_DB_PREFIX."product_price";

+            $sql .= " WHERE fk_product='".$objp->rowid."'";

+            $sql .= " AND entity IN (".getEntity('productprice').")";

+            $sql .= " AND price_level=".$price_level;

             $sql .= " ORDER BY date_price DESC, rowid DESC"; // Warning DESC must be both on date_price and rowid.

             $sql .= " LIMIT 1";

 

-            dol_syslog(get_class($this) . '::constructProductListOption search price for level ' . $price_level . '', LOG_DEBUG);

+            dol_syslog(get_class($this).'::constructProductListOption search price for level '.$price_level.'', LOG_DEBUG);

             $result2 = $this->db->query($sql);

             if ($result2) {

                 $objp2 = $this->db->fetch_object($result2);

                 if ($objp2) {

                     $found = 1;

                     if ($objp2->price_base_type == 'HT') {

-                        $opt .= ' - ' . price($objp2->price, 1, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->trans("HT");

-                        $outval .= ' - ' . price($objp2->price, 0, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->transnoentities("HT");

+                        $opt .= ' - '.price($objp2->price, 1, $langs, 0, 0, -1, $conf->currency).' '.$langs->trans("HT");

+                        $outval .= ' - '.price($objp2->price, 0, $langs, 0, 0, -1, $conf->currency).' '.$langs->transnoentities("HT");

                     } else {

-                        $opt .= ' - ' . price($objp2->price_ttc, 1, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->trans("TTC");

-                        $outval .= ' - ' . price($objp2->price_ttc, 0, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->transnoentities("TTC");

+                        $opt .= ' - '.price($objp2->price_ttc, 1, $langs, 0, 0, -1, $conf->currency).' '.$langs->trans("TTC");

+                        $outval .= ' - '.price($objp2->price_ttc, 0, $langs, 0, 0, -1, $conf->currency).' '.$langs->transnoentities("TTC");

                     }

                     $outprice_ht = price($objp2->price);

                     $outprice_ttc = price($objp2->price_ttc);

@@ -2420,13 +2420,13 @@ 
             $outqty = $objp->quantity;

             $outdiscount = $objp->remise_percent;

             if ($objp->quantity == 1) {

-                $opt .= ' - ' . price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency) . "/";

-                $outval .= ' - ' . price($objp->unitprice, 0, $langs, 0, 0, -1, $conf->currency) . "/";

+                $opt .= ' - '.price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency)."/";

+                $outval .= ' - '.price($objp->unitprice, 0, $langs, 0, 0, -1, $conf->currency)."/";

                 $opt .= $langs->trans("Unit"); // Do not use strtolower because it breaks utf8 encoding

                 $outval .= $langs->transnoentities("Unit");

             } else {

-                $opt .= ' - ' . price($objp->price, 1, $langs, 0, 0, -1, $conf->currency) . "/" . $objp->quantity;

-                $outval .= ' - ' . price($objp->price, 0, $langs, 0, 0, -1, $conf->currency) . "/" . $objp->quantity;

+                $opt .= ' - '.price($objp->price, 1, $langs, 0, 0, -1, $conf->currency)."/".$objp->quantity;

+                $outval .= ' - '.price($objp->price, 0, $langs, 0, 0, -1, $conf->currency)."/".$objp->quantity;

                 $opt .= $langs->trans("Units"); // Do not use strtolower because it breaks utf8 encoding

                 $outval .= $langs->transnoentities("Units");

             }

@@ -2437,12 +2437,12 @@ 
             $outtva_tx = $objp->tva_tx;

         }

         if (empty($hidepriceinlabel) && !empty($objp->quantity) && $objp->quantity >= 1) {

-            $opt .= " (" . price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency) . "/" . $langs->trans("Unit") . ")"; // Do not use strtolower because it breaks utf8 encoding

-            $outval .= " (" . price($objp->unitprice, 0, $langs, 0, 0, -1, $conf->currency) . "/" . $langs->transnoentities("Unit") . ")"; // Do not use strtolower because it breaks utf8 encoding

+            $opt .= " (".price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency)."/".$langs->trans("Unit").")"; // Do not use strtolower because it breaks utf8 encoding

+            $outval .= " (".price($objp->unitprice, 0, $langs, 0, 0, -1, $conf->currency)."/".$langs->transnoentities("Unit").")"; // Do not use strtolower because it breaks utf8 encoding

         }

         if (empty($hidepriceinlabel) && !empty($objp->remise_percent) && $objp->remise_percent >= 1) {

-            $opt .= " - " . $langs->trans("Discount") . " : " . vatrate($objp->remise_percent) . ' %';

-            $outval .= " - " . $langs->transnoentities("Discount") . " : " . vatrate($objp->remise_percent) . ' %';

+            $opt .= " - ".$langs->trans("Discount")." : ".vatrate($objp->remise_percent).' %';

+            $outval .= " - ".$langs->transnoentities("Discount")." : ".vatrate($objp->remise_percent).' %';

         }

 

         // Price by customer

@@ -2451,11 +2451,11 @@ 
                 $found = 1;

 

                 if ($objp->custprice_base_type == 'HT') {

-                    $opt .= ' - ' . price($objp->custprice, 1, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->trans("HT");

-                    $outval .= ' - ' . price($objp->custprice, 0, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->transnoentities("HT");

+                    $opt .= ' - '.price($objp->custprice, 1, $langs, 0, 0, -1, $conf->currency).' '.$langs->trans("HT");

+                    $outval .= ' - '.price($objp->custprice, 0, $langs, 0, 0, -1, $conf->currency).' '.$langs->transnoentities("HT");

                 } else {

-                    $opt .= ' - ' . price($objp->custprice_ttc, 1, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->trans("TTC");

-                    $outval .= ' - ' . price($objp->custprice_ttc, 0, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->transnoentities("TTC");

+                    $opt .= ' - '.price($objp->custprice_ttc, 1, $langs, 0, 0, -1, $conf->currency).' '.$langs->trans("TTC");

+                    $outval .= ' - '.price($objp->custprice_ttc, 0, $langs, 0, 0, -1, $conf->currency).' '.$langs->transnoentities("TTC");

                 }

 

                 $outprice_ht = price($objp->custprice);

@@ -2468,11 +2468,11 @@ 
         // If level no defined or multiprice not found, we used the default price

         if (empty($hidepriceinlabel) && !$found) {

             if ($objp->price_base_type == 'HT') {

-                $opt .= ' - ' . price($objp->price, 1, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->trans("HT");

-                $outval .= ' - ' . price($objp->price, 0, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->transnoentities("HT");

+                $opt .= ' - '.price($objp->price, 1, $langs, 0, 0, -1, $conf->currency).' '.$langs->trans("HT");

+                $outval .= ' - '.price($objp->price, 0, $langs, 0, 0, -1, $conf->currency).' '.$langs->transnoentities("HT");

             } else {

-                $opt .= ' - ' . price($objp->price_ttc, 1, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->trans("TTC");

-                $outval .= ' - ' . price($objp->price_ttc, 0, $langs, 0, 0, -1, $conf->currency) . ' ' . $langs->transnoentities("TTC");

+                $opt .= ' - '.price($objp->price_ttc, 1, $langs, 0, 0, -1, $conf->currency).' '.$langs->trans("TTC");

+                $outval .= ' - '.price($objp->price_ttc, 0, $langs, 0, 0, -1, $conf->currency).' '.$langs->transnoentities("TTC");

             }

             $outprice_ht = price($objp->price);

             $outprice_ttc = price($objp->price_ttc);

@@ -2481,21 +2481,21 @@ 
         }

 

         if (!empty($conf->stock->enabled) && isset($objp->stock) && $objp->fk_product_type == 0) {

-            $opt .= ' - ' . $langs->trans("Stock") . ':' . $objp->stock;

+            $opt .= ' - '.$langs->trans("Stock").':'.$objp->stock;

 

             if ($objp->stock > 0) {

-                $outval .= ' - <span class="product_line_stock_ok">' . $langs->transnoentities("Stock") . ':' . $objp->stock . '</span>';

+                $outval .= ' - <span class="product_line_stock_ok">'.$langs->transnoentities("Stock").':'.$objp->stock.'</span>';

             } elseif ($objp->stock <= 0) {

-                $outval .= ' - <span class="product_line_stock_too_low">' . $langs->transnoentities("Stock") . ':' . $objp->stock . '</span>';

+                $outval .= ' - <span class="product_line_stock_too_low">'.$langs->transnoentities("Stock").':'.$objp->stock.'</span>';

             }

         }

 

         if ($outdurationvalue && $outdurationunit) {

             $da = array("h" => $langs->trans("Hour"), "d" => $langs->trans("Day"), "w" => $langs->trans("Week"), "m" => $langs->trans("Month"), "y" => $langs->trans("Year"));

             if (isset($da[$outdurationunit])) {

-                $key = $da[$outdurationunit] . ($outdurationvalue > 1 ? 's' : '');

-                $opt .= ' - ' . $outdurationvalue . ' ' . $langs->trans($key);

-                $outval .= ' - ' . $outdurationvalue . ' ' . $langs->transnoentities($key);

+                $key = $da[$outdurationunit].($outdurationvalue > 1 ? 's' : '');

+                $opt .= ' - '.$outdurationvalue.' '.$langs->trans($key);

+                $outval .= ' - '.$outdurationvalue.' '.$langs->transnoentities($key);

             }

         }

 

@@ -2526,7 +2526,7 @@ 
         $selected_input_value = '';

         if (!empty($conf->use_javascript_ajax) && !empty($conf->global->PRODUIT_USE_SEARCH_TO_SELECT)) {

             if ($selected > 0) {

-                require_once DOL_DOCUMENT_ROOT . '/product/class/product.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

                 $producttmpselect = new Product($this->db);

                 $producttmpselect->fetch($selected);

                 $selected_input_value = $producttmpselect->ref;

@@ -2534,9 +2534,9 @@ 
             }

 

             // mode=2 means suppliers products

-            $urloption = ($socid > 0 ? 'socid=' . $socid . '&' : '') . 'htmlname=' . $htmlname . '&outjson=1&price_level=' . $price_level . '&type=' . $filtertype . '&mode=2&status=' . $status . '&finished=' . $finished . '&alsoproductwithnosupplierprice=' . $alsoproductwithnosupplierprice;

-            print ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT . '/product/ajax/products.php', $urloption, $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

-            print ($hidelabel ? '' : $langs->trans("RefOrLabel") . ' : ') . '<input type="text" size="20" name="search_' . $htmlname . '" id="search_' . $htmlname . '" value="' . $selected_input_value . '">';

+            $urloption = ($socid > 0 ? 'socid='.$socid.'&' : '').'htmlname='.$htmlname.'&outjson=1&price_level='.$price_level.'&type='.$filtertype.'&mode=2&status='.$status.'&finished='.$finished.'&alsoproductwithnosupplierprice='.$alsoproductwithnosupplierprice;

+            print ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT.'/product/ajax/products.php', $urloption, $conf->global->PRODUIT_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

+            print ($hidelabel ? '' : $langs->trans("RefOrLabel").' : ').'<input type="text" size="20" name="search_'.$htmlname.'" id="search_'.$htmlname.'" value="'.$selected_input_value.'">';

         } else {

             print $this->select_produits_fournisseurs_list($socid, $selected, $htmlname, $filtertype, $filtre, '', -1, 0, 0, $alsoproductwithnosupplierprice);

         }

@@ -2572,17 +2572,17 @@ 
         $sql .= " pfp.ref_fourn, pfp.rowid as idprodfournprice, pfp.price as fprice, pfp.quantity, pfp.remise_percent, pfp.remise, pfp.unitprice,";

         $sql .= " pfp.fk_supplier_price_expression, pfp.fk_product, pfp.tva_tx, pfp.fk_soc, s.nom as name,";

         $sql .= " pfp.supplier_reputation";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "product as p";

-        $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

+        $sql .= " FROM ".MAIN_DB_PREFIX."product as p";

+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

         if ($socid)

-            $sql .= " AND pfp.fk_soc = " . $socid;

-        $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "societe as s ON pfp.fk_soc = s.rowid";

-        $sql .= " WHERE p.entity IN (" . getEntity('product') . ")";

+            $sql .= " AND pfp.fk_soc = ".$socid;

+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON pfp.fk_soc = s.rowid";

+        $sql .= " WHERE p.entity IN (".getEntity('product').")";

         $sql .= " AND p.tobuy = 1";

         if (strval($filtertype) != '')

-            $sql .= " AND p.fk_product_type=" . $this->db->escape($filtertype);

+            $sql .= " AND p.fk_product_type=".$this->db->escape($filtertype);

         if (!empty($filtre))

-            $sql .= " " . $filtre;

+            $sql .= " ".$filtre;

         // Add criteria on ref/label

         if ($filterkey != '') {

             $sql .= ' AND (';

@@ -2595,13 +2595,13 @@ 
             foreach ($scrit as $crit) {

                 if ($i > 0)

                     $sql .= " AND ";

-                $sql .= "(pfp.ref_fourn LIKE '" . $this->db->escape($prefix . $crit) . "%' OR p.ref LIKE '" . $this->db->escape($prefix . $crit) . "%' OR p.label LIKE '" . $this->db->escape($prefix . $crit) . "%')";

+                $sql .= "(pfp.ref_fourn LIKE '".$this->db->escape($prefix.$crit)."%' OR p.ref LIKE '".$this->db->escape($prefix.$crit)."%' OR p.label LIKE '".$this->db->escape($prefix.$crit)."%')";

                 $i++;

             }

             if (count($scrit) > 1)

                 $sql .= ")";

             if (!empty($conf->barcode->enabled))

-                $sql .= " OR p.barcode LIKE '" . $this->db->escape($prefix . $filterkey) . "%'";

+                $sql .= " OR p.barcode LIKE '".$this->db->escape($prefix.$filterkey)."%'";

             $sql .= ')';

         }

         $sql .= " ORDER BY pfp.ref_fourn DESC, pfp.quantity ASC";

@@ -2609,15 +2609,15 @@ 
 

         // Build output string

 

-        dol_syslog(get_class($this) . "::select_produits_fournisseurs_list", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_produits_fournisseurs_list", LOG_DEBUG);

         $result = $this->db->query($sql);

         if ($result) {

-            require_once DOL_DOCUMENT_ROOT . '/product/dynamic_price/class/price_parser.class.php';

+            require_once DOL_DOCUMENT_ROOT.'/product/dynamic_price/class/price_parser.class.php';

 

             $num = $this->db->num_rows($result);

 

             //$out.='<select class="flat" id="select'.$htmlname.'" name="'.$htmlname.'">';	// remove select to have id same with combo and ajax

-            $out .= '<select class="flat maxwidthonsmartphone" id="' . $htmlname . '" name="' . $htmlname . '">';

+            $out .= '<select class="flat maxwidthonsmartphone" id="'.$htmlname.'" name="'.$htmlname.'">';

             if (!$selected)

                 $out .= '<option value="0" selected>&nbsp;</option>';

             else

@@ -2627,9 +2627,9 @@ 
             while ($i < $num) {

                 $objp = $this->db->fetch_object($result);

 

-                $outkey = $objp->idprodfournprice;                                                    // id in table of price

+                $outkey = $objp->idprodfournprice; // id in table of price

                 if (!$outkey && $alsoproductwithnosupplierprice)

-                    $outkey = 'idprod_' . $objp->rowid;   // id of product

+                    $outkey = 'idprod_'.$objp->rowid; // id of product

 

                 $outref = $objp->ref;

                 $outval = '';

@@ -2639,36 +2639,36 @@ 
                 $outdurationvalue = $outtype == Product::TYPE_SERVICE ? substr($objp->duration, 0, dol_strlen($objp->duration) - 1) : '';

                 $outdurationunit = $outtype == Product::TYPE_SERVICE ? substr($objp->duration, -1) : '';

 

-                $opt = '<option value="' . $outkey . '"';

+                $opt = '<option value="'.$outkey.'"';

                 if ($selected && $selected == $objp->idprodfournprice)

                     $opt .= ' selected';

                 if (empty($objp->idprodfournprice) && empty($alsoproductwithnosupplierprice))

                     $opt .= ' disabled';

                 if (!empty($objp->idprodfournprice) && $objp->idprodfournprice > 0) {

-                    $opt .= ' pbq="' . $objp->idprodfournprice . '" data-pbq="' . $objp->idprodfournprice . '" data-pbqqty="' . $objp->quantity . '" data-pbqpercent="' . $objp->remise_percent . '"';

+                    $opt .= ' pbq="'.$objp->idprodfournprice.'" data-pbq="'.$objp->idprodfournprice.'" data-pbqqty="'.$objp->quantity.'" data-pbqpercent="'.$objp->remise_percent.'"';

                 }

                 $opt .= '>';

 

                 $objRef = $objp->ref;

                 if ($filterkey && $filterkey != '')

-                    $objRef = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRef, 1);

+                    $objRef = preg_replace('/('.preg_quote($filterkey).')/i', '<strong>$1</strong>', $objRef, 1);

                 $objRefFourn = $objp->ref_fourn;

                 if ($filterkey && $filterkey != '')

-                    $objRefFourn = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRefFourn, 1);

+                    $objRefFourn = preg_replace('/('.preg_quote($filterkey).')/i', '<strong>$1</strong>', $objRefFourn, 1);

                 $label = $objp->label;

                 if ($filterkey && $filterkey != '')

-                    $label = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $label, 1);

+                    $label = preg_replace('/('.preg_quote($filterkey).')/i', '<strong>$1</strong>', $label, 1);

 

                 $opt .= $objp->ref;

                 if (!empty($objp->idprodfournprice) && ($objp->ref != $objp->ref_fourn))

-                    $opt .= ' (' . $objp->ref_fourn . ')';

+                    $opt .= ' ('.$objp->ref_fourn.')';

                 $opt .= ' - ';

                 $outval .= $objRef;

                 if (!empty($objp->idprodfournprice) && ($objp->ref != $objp->ref_fourn))

-                    $outval .= ' (' . $objRefFourn . ')';

+                    $outval .= ' ('.$objRefFourn.')';

                 $outval .= ' - ';

-                $opt .= dol_trunc($label, 72) . ' - ';

-                $outval .= dol_trunc($label, 72) . ' - ';

+                $opt .= dol_trunc($label, 72).' - ';

+                $outval .= dol_trunc($label, 72).' - ';

 

                 if (!empty($objp->idprodfournprice)) {

                     $outqty = $objp->quantity;

@@ -2690,39 +2690,39 @@ 
                         }

                     }

                     if ($objp->quantity == 1) {

-                        $opt .= price($objp->fprice, 1, $langs, 0, 0, -1, $conf->currency) . "/";

-                        $outval .= price($objp->fprice, 0, $langs, 0, 0, -1, $conf->currency) . "/";

+                        $opt .= price($objp->fprice, 1, $langs, 0, 0, -1, $conf->currency)."/";

+                        $outval .= price($objp->fprice, 0, $langs, 0, 0, -1, $conf->currency)."/";

                         $opt .= $langs->trans("Unit"); // Do not use strtolower because it breaks utf8 encoding

                         $outval .= $langs->transnoentities("Unit");

                     } else {

-                        $opt .= price($objp->fprice, 1, $langs, 0, 0, -1, $conf->currency) . "/" . $objp->quantity;

-                        $outval .= price($objp->fprice, 0, $langs, 0, 0, -1, $conf->currency) . "/" . $objp->quantity;

-                        $opt .= ' ' . $langs->trans("Units"); // Do not use strtolower because it breaks utf8 encoding

-                        $outval .= ' ' . $langs->transnoentities("Units");

+                        $opt .= price($objp->fprice, 1, $langs, 0, 0, -1, $conf->currency)."/".$objp->quantity;

+                        $outval .= price($objp->fprice, 0, $langs, 0, 0, -1, $conf->currency)."/".$objp->quantity;

+                        $opt .= ' '.$langs->trans("Units"); // Do not use strtolower because it breaks utf8 encoding

+                        $outval .= ' '.$langs->transnoentities("Units");

                     }

 

                     if ($objp->quantity >= 1) {

-                        $opt .= " (" . price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency) . "/" . $langs->trans("Unit") . ")"; // Do not use strtolower because it breaks utf8 encoding

-                        $outval .= " (" . price($objp->unitprice, 0, $langs, 0, 0, -1, $conf->currency) . "/" . $langs->transnoentities("Unit") . ")"; // Do not use strtolower because it breaks utf8 encoding

+                        $opt .= " (".price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency)."/".$langs->trans("Unit").")"; // Do not use strtolower because it breaks utf8 encoding

+                        $outval .= " (".price($objp->unitprice, 0, $langs, 0, 0, -1, $conf->currency)."/".$langs->transnoentities("Unit").")"; // Do not use strtolower because it breaks utf8 encoding

                     }

                     if ($objp->remise_percent >= 1) {

-                        $opt .= " - " . $langs->trans("Discount") . " : " . vatrate($objp->remise_percent) . ' %';

-                        $outval .= " - " . $langs->transnoentities("Discount") . " : " . vatrate($objp->remise_percent) . ' %';

+                        $opt .= " - ".$langs->trans("Discount")." : ".vatrate($objp->remise_percent).' %';

+                        $outval .= " - ".$langs->transnoentities("Discount")." : ".vatrate($objp->remise_percent).' %';

                     }

                     if ($objp->duration) {

-                        $opt .= " - " . $objp->duration;

-                        $outval .= " - " . $objp->duration;

+                        $opt .= " - ".$objp->duration;

+                        $outval .= " - ".$objp->duration;

                     }

                     if (!$socid) {

-                        $opt .= " - " . dol_trunc($objp->name, 8);

-                        $outval .= " - " . dol_trunc($objp->name, 8);

+                        $opt .= " - ".dol_trunc($objp->name, 8);

+                        $outval .= " - ".dol_trunc($objp->name, 8);

                     }

                     if ($objp->supplier_reputation) {

                         //TODO dictionary

                         $reputations = array('' => $langs->trans('Standard'), 'FAVORITE' => $langs->trans('Favorite'), 'NOTTHGOOD' => $langs->trans('NotTheGoodQualitySupplier'), 'DONOTORDER' => $langs->trans('DoNotOrderThisProductToThisSupplier'));

 

-                        $opt .= " - " . $reputations[$objp->supplier_reputation];

-                        $outval .= " - " . $reputations[$objp->supplier_reputation];

+                        $opt .= " - ".$reputations[$objp->supplier_reputation];

+                        $outval .= " - ".$reputations[$objp->supplier_reputation];

                     }

                 } else {

                     if (empty($alsoproductwithnosupplierprice)) {     // No supplier price defined for couple product/supplier

@@ -2756,7 +2756,7 @@ 
 

             $this->db->free($result);

 

-            include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+            include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

             $out .= ajax_combobox($htmlname);

 

             if (empty($outputmode))

@@ -2787,39 +2787,39 @@ 
         $sql = "SELECT p.rowid, p.label, p.ref, p.price, p.duration, pfp.fk_soc,";

         $sql .= " pfp.ref_fourn, pfp.rowid as idprodfournprice, pfp.price as fprice, pfp.quantity, pfp.unitprice,";

         $sql .= " pfp.fk_supplier_price_expression, pfp.fk_product, pfp.tva_tx, s.nom as name";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "product as p";

-        $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

-        $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "societe as s ON pfp.fk_soc = s.rowid";

-        $sql .= " WHERE pfp.entity IN (" . getEntity('productsupplierprice') . ")";

+        $sql .= " FROM ".MAIN_DB_PREFIX."product as p";

+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

+        $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON pfp.fk_soc = s.rowid";

+        $sql .= " WHERE pfp.entity IN (".getEntity('productsupplierprice').")";

         $sql .= " AND p.tobuy = 1";

         $sql .= " AND s.fournisseur = 1";

-        $sql .= " AND p.rowid = " . $productid;

+        $sql .= " AND p.rowid = ".$productid;

         $sql .= " ORDER BY s.nom, pfp.ref_fourn DESC";

 

-        dol_syslog(get_class($this) . "::select_product_fourn_price", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_product_fourn_price", LOG_DEBUG);

         $result = $this->db->query($sql);

 

         if ($result) {

             $num = $this->db->num_rows($result);

 

-            $form = '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

+            $form = '<select class="flat" id="select_'.$htmlname.'" name="'.$htmlname.'">';

 

             if (!$num) {

-                $form .= '<option value="0">-- ' . $langs->trans("NoSupplierPriceDefinedForThisProduct") . ' --</option>';

+                $form .= '<option value="0">-- '.$langs->trans("NoSupplierPriceDefinedForThisProduct").' --</option>';

             } else {

-                require_once DOL_DOCUMENT_ROOT . '/product/dynamic_price/class/price_parser.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/product/dynamic_price/class/price_parser.class.php';

                 $form .= '<option value="0">&nbsp;</option>';

 

                 $i = 0;

                 while ($i < $num) {

                     $objp = $this->db->fetch_object($result);

 

-                    $opt = '<option value="' . $objp->idprodfournprice . '"';

+                    $opt = '<option value="'.$objp->idprodfournprice.'"';

                     //if there is only one supplier, preselect it

                     if ($num == 1 || ($selected_supplier > 0 && $objp->fk_soc == $selected_supplier)) {

                         $opt .= ' selected';

                     }

-                    $opt .= '>' . $objp->name . ' - ' . $objp->ref_fourn . ' - ';

+                    $opt .= '>'.$objp->name.' - '.$objp->ref_fourn.' - ';

 

                     if (!empty($conf->dynamicprices->enabled) && !empty($objp->fk_supplier_price_expression)) {

                         $prod_supplier = new ProductFournisseur($this->db);

@@ -2838,10 +2838,10 @@ 
                         }

                     }

                     if ($objp->quantity == 1) {

-                        $opt .= price($objp->fprice, 1, $langs, 0, 0, -1, $conf->currency) . "/";

+                        $opt .= price($objp->fprice, 1, $langs, 0, 0, -1, $conf->currency)."/";

                     }

 

-                    $opt .= $objp->quantity . ' ';

+                    $opt .= $objp->quantity.' ';

 

                     if ($objp->quantity == 1) {

                         $opt .= $langs->trans("Unit");

@@ -2850,10 +2850,10 @@ 
                     }

                     if ($objp->quantity > 1) {

                         $opt .= " - ";

-                        $opt .= price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency) . "/" . $langs->trans("Unit");

+                        $opt .= price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency)."/".$langs->trans("Unit");

                     }

                     if ($objp->duration)

-                        $opt .= " - " . $objp->duration;

+                        $opt .= " - ".$objp->duration;

                     $opt .= "</option>\n";

 

                     $form .= $opt;

@@ -2885,14 +2885,14 @@ 
         // phpcs:enable

         // looking for users

         $sql = "SELECT a.rowid, a.label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "societe_address as a";

-        $sql .= " WHERE a.fk_soc = " . $socid;

+        $sql .= " FROM ".MAIN_DB_PREFIX."societe_address as a";

+        $sql .= " WHERE a.fk_soc = ".$socid;

         $sql .= " ORDER BY a.label ASC";

 

-        dol_syslog(get_class($this) . "::select_address", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_address", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

-            print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

+            print '<select class="flat" id="select_'.$htmlname.'" name="'.$htmlname.'">';

             if ($showempty)

                 print '<option value="0">&nbsp;</option>';

             $num = $this->db->num_rows($resql);

@@ -2902,9 +2902,9 @@ 
                     $obj = $this->db->fetch_object($resql);

 

                     if ($selected && $selected == $obj->rowid) {

-                        print '<option value="' . $obj->rowid . '" selected>' . $obj->label . '</option>';

+                        print '<option value="'.$obj->rowid.'" selected>'.$obj->label.'</option>';

                     } else {

-                        print '<option value="' . $obj->rowid . '">' . $obj->label . '</option>';

+                        print '<option value="'.$obj->rowid.'">'.$obj->label.'</option>';

                     }

                     $i++;

                 }

@@ -2929,13 +2929,13 @@ 
 

         $num = count($this->cache_conditions_paiements);

         if ($num > 0)

-            return 0;    // Cache already loaded

+            return 0; // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

         $sql = "SELECT rowid, code, libelle as label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . 'c_payment_term';

-        $sql .= " WHERE entity IN (" . getEntity('c_payment_term') . ")";

+        $sql .= " FROM ".MAIN_DB_PREFIX.'c_payment_term';

+        $sql .= " WHERE entity IN (".getEntity('c_payment_term').")";

         $sql .= " AND active > 0";

         $sql .= " ORDER BY sortorder";

 

@@ -2947,7 +2947,7 @@ 
                 $obj = $this->db->fetch_object($resql);

 

                 // Si traduction existe, on l'utilise, sinon on prend le libelle par defaut

-                $label = ($langs->trans("PaymentConditionShort" . $obj->code) != ("PaymentConditionShort" . $obj->code) ? $langs->trans("PaymentConditionShort" . $obj->code) : ($obj->label != '-' ? $obj->label : ''));

+                $label = ($langs->trans("PaymentConditionShort".$obj->code) != ("PaymentConditionShort".$obj->code) ? $langs->trans("PaymentConditionShort".$obj->code) : ($obj->label != '-' ? $obj->label : ''));

                 $this->cache_conditions_paiements[$obj->rowid]['code'] = $obj->code;

                 $this->cache_conditions_paiements[$obj->rowid]['label'] = $label;

                 $i++;

@@ -2975,14 +2975,14 @@ 
 

         $num = count($this->cache_availability);

         if ($num > 0)

-            return 0;    // Cache already loaded

+            return 0; // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

         $langs->load('propal');

 

         $sql = "SELECT rowid, code, label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . 'c_availability';

+        $sql .= " FROM ".MAIN_DB_PREFIX.'c_availability';

         $sql .= " WHERE active > 0";

 

         $resql = $this->db->query($sql);

@@ -2993,7 +2993,7 @@ 
                 $obj = $this->db->fetch_object($resql);

 

                 // Si traduction existe, on l'utilise, sinon on prend le libelle par defaut

-                $label = ($langs->trans("AvailabilityType" . $obj->code) != ("AvailabilityType" . $obj->code) ? $langs->trans("AvailabilityType" . $obj->code) : ($obj->label != '-' ? $obj->label : ''));

+                $label = ($langs->trans("AvailabilityType".$obj->code) != ("AvailabilityType".$obj->code) ? $langs->trans("AvailabilityType".$obj->code) : ($obj->label != '-' ? $obj->label : ''));

                 $this->cache_availability[$obj->rowid]['code'] = $obj->code;

                 $this->cache_availability[$obj->rowid]['label'] = $label;

                 $i++;

@@ -3023,16 +3023,16 @@ 
 

         $this->load_cache_availability();

 

-        dol_syslog(__METHOD__ . " selected=" . $selected . ", htmlname=" . $htmlname, LOG_DEBUG);

+        dol_syslog(__METHOD__." selected=".$selected.", htmlname=".$htmlname, LOG_DEBUG);

 

-        print '<select id="' . $htmlname . '" class="flat" name="' . $htmlname . '">';

+        print '<select id="'.$htmlname.'" class="flat" name="'.$htmlname.'">';

         if ($addempty)

             print '<option value="0">&nbsp;</option>';

         foreach ($this->cache_availability as $id => $arrayavailability) {

             if ($selected == $id) {

-                print '<option value="' . $id . '" selected>';

+                print '<option value="'.$id.'" selected>';

             } else {

-                print '<option value="' . $id . '">';

+                print '<option value="'.$id.'">';

             }

             print $arrayavailability['label'];

             print '</option>';

@@ -3053,10 +3053,10 @@ 
 

         $num = count($this->cache_demand_reason);

         if ($num > 0)

-            return 0;    // Cache already loaded

+            return 0; // Cache already loaded

 

         $sql = "SELECT rowid, code, label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . 'c_input_reason';

+        $sql .= " FROM ".MAIN_DB_PREFIX.'c_input_reason';

         $sql .= " WHERE active > 0";

 

         $resql = $this->db->query($sql);

@@ -3069,10 +3069,10 @@ 
 

                 // Si traduction existe, on l'utilise, sinon on prend le libelle par defaut

                 $label = ($obj->label != '-' ? $obj->label : '');

-                if ($langs->trans("DemandReasonType" . $obj->code) != ("DemandReasonType" . $obj->code))

-                    $label = $langs->trans("DemandReasonType" . $obj->code); // So translation key DemandReasonTypeSRC_XXX will work

+                if ($langs->trans("DemandReasonType".$obj->code) != ("DemandReasonType".$obj->code))

+                    $label = $langs->trans("DemandReasonType".$obj->code); // So translation key DemandReasonTypeSRC_XXX will work

                 if ($langs->trans($obj->code) != $obj->code)

-                    $label = $langs->trans($obj->code);                // So translation key SRC_XXX will work

+                    $label = $langs->trans($obj->code); // So translation key SRC_XXX will work

 

                 $tmparray[$obj->rowid]['id'] = $obj->rowid;

                 $tmparray[$obj->rowid]['code'] = $obj->code;

@@ -3107,17 +3107,17 @@ 
 

         $this->loadCacheInputReason();

 

-        print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

+        print '<select class="flat" id="select_'.$htmlname.'" name="'.$htmlname.'">';

         if ($addempty)

-            print '<option value="0"' . (empty($selected) ? ' selected' : '') . '>&nbsp;</option>';

+            print '<option value="0"'.(empty($selected) ? ' selected' : '').'>&nbsp;</option>';

         foreach ($this->cache_demand_reason as $id => $arraydemandreason) {

             if ($arraydemandreason['code'] == $exclude)

                 continue;

 

             if ($selected && ($selected == $arraydemandreason['id'] || $selected == $arraydemandreason['code'])) {

-                print '<option value="' . $arraydemandreason['id'] . '" selected>';

+                print '<option value="'.$arraydemandreason['id'].'" selected>';

             } else {

-                print '<option value="' . $arraydemandreason['id'] . '">';

+                print '<option value="'.$arraydemandreason['id'].'">';

             }

             $label = $arraydemandreason['label']; // Translation of label was already done into the ->loadCacheInputReason

             print $langs->trans($label);

@@ -3141,15 +3141,15 @@ 
 

         $num = count($this->cache_types_paiements);

         if ($num > 0)

-            return $num;    // Cache already loaded

+            return $num; // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

         $this->cache_types_paiements = array();

 

         $sql = "SELECT id, code, libelle as label, type, active";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_paiement";

-        $sql .= " WHERE entity IN (" . getEntity('c_paiement') . ")";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_paiement";

+        $sql .= " WHERE entity IN (".getEntity('c_paiement').")";

         //if ($active >= 0) $sql.= " AND active = ".$active;

 

         $resql = $this->db->query($sql);

@@ -3160,7 +3160,7 @@ 
                 $obj = $this->db->fetch_object($resql);

 

                 // Si traduction existe, on l'utilise, sinon on prend le libelle par defaut

-                $label = ($langs->transnoentitiesnoconv("PaymentTypeShort" . $obj->code) != ("PaymentTypeShort" . $obj->code) ? $langs->transnoentitiesnoconv("PaymentTypeShort" . $obj->code) : ($obj->label != '-' ? $obj->label : ''));

+                $label = ($langs->transnoentitiesnoconv("PaymentTypeShort".$obj->code) != ("PaymentTypeShort".$obj->code) ? $langs->transnoentitiesnoconv("PaymentTypeShort".$obj->code) : ($obj->label != '-' ? $obj->label : ''));

                 $this->cache_types_paiements[$obj->id]['id'] = $obj->id;

                 $this->cache_types_paiements[$obj->id]['code'] = $obj->code;

                 $this->cache_types_paiements[$obj->id]['label'] = $label;

@@ -3197,7 +3197,7 @@ 
         // phpcs:enable

         global $langs, $user, $conf;

 

-        dol_syslog(__METHOD__ . " selected=" . $selected . ", htmlname=" . $htmlname, LOG_DEBUG);

+        dol_syslog(__METHOD__." selected=".$selected.", htmlname=".$htmlname, LOG_DEBUG);

 

         $this->load_cache_conditions_paiements();

 

@@ -3205,14 +3205,14 @@ 
         if (empty($selected) && !empty($conf->global->MAIN_DEFAULT_PAYMENT_TERM_ID))

             $selected = $conf->global->MAIN_DEFAULT_PAYMENT_TERM_ID;

 

-        print '<select id="' . $htmlname . '" class="flat selectpaymentterms' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '">';

+        print '<select id="'.$htmlname.'" class="flat selectpaymentterms'.($morecss ? ' '.$morecss : '').'" name="'.$htmlname.'">';

         if ($addempty)

             print '<option value="0">&nbsp;</option>';

         foreach ($this->cache_conditions_paiements as $id => $arrayconditions) {

             if ($selected == $id) {

-                print '<option value="' . $id . '" selected>';

+                print '<option value="'.$id.'" selected>';

             } else {

-                print '<option value="' . $id . '">';

+                print '<option value="'.$id.'">';

             }

             print $arrayconditions['label'];

             print '</option>';

@@ -3242,7 +3242,7 @@ 
         // phpcs:enable

         global $langs, $user;

 

-        dol_syslog(__METHOD__ . " " . $selected . ", " . $htmlname . ", " . $filtertype . ", " . $format, LOG_DEBUG);

+        dol_syslog(__METHOD__." ".$selected.", ".$htmlname.", ".$filtertype.", ".$format, LOG_DEBUG);

 

         $filterarray = array();

         if ($filtertype == 'CRDT')

@@ -3254,7 +3254,7 @@ 
 

         $this->load_cache_types_paiements();

 

-        print '<select id="select' . $htmlname . '" class="flat selectpaymenttypes' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '">';

+        print '<select id="select'.$htmlname.'" class="flat selectpaymenttypes'.($morecss ? ' '.$morecss : '').'" name="'.$htmlname.'">';

         if ($empty)

             print '<option value="">&nbsp;</option>';

         foreach ($this->cache_types_paiements as $id => $arraytypes) {

@@ -3271,13 +3271,13 @@ 
                 continue;

 

             if ($format == 0)

-                print '<option value="' . $id . '"';

+                print '<option value="'.$id.'"';

             elseif ($format == 1)

-                print '<option value="' . $arraytypes['code'] . '"';

+                print '<option value="'.$arraytypes['code'].'"';

             elseif ($format == 2)

-                print '<option value="' . $arraytypes['code'] . '"';

+                print '<option value="'.$arraytypes['code'].'"';

             elseif ($format == 3)

-                print '<option value="' . $id . '"';

+                print '<option value="'.$id.'"';

             // Si selected est text, on compare avec code, sinon avec id

             if (preg_match('/[a-z]/i', $selected) && $selected == $arraytypes['code'])

                 print ' selected';

@@ -3313,16 +3313,16 @@ 
 

         $return = '';

 

-        $return .= '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

+        $return .= '<select class="flat" id="select_'.$htmlname.'" name="'.$htmlname.'">';

         $options = array(

             'HT' => $langs->trans("HT"),

             'TTC' => $langs->trans("TTC")

         );

         foreach ($options as $id => $value) {

             if ($selected == $id) {

-                $return .= '<option value="' . $id . '" selected>' . $value;

+                $return .= '<option value="'.$id.'" selected>'.$value;

             } else {

-                $return .= '<option value="' . $id . '">' . $value;

+                $return .= '<option value="'.$id.'">'.$value;

             }

             $return .= '</option>';

         }

@@ -3349,30 +3349,30 @@ 
         $langs->load("deliveries");

 

         $sql = "SELECT rowid, code, libelle as label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_shipment_mode";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_shipment_mode";

         $sql .= " WHERE active > 0";

         if ($filtre)

-            $sql .= " AND " . $filtre;

+            $sql .= " AND ".$filtre;

         $sql .= " ORDER BY libelle ASC";

 

-        dol_syslog(get_class($this) . "::selectShippingMode", LOG_DEBUG);

+        dol_syslog(get_class($this)."::selectShippingMode", LOG_DEBUG);

         $result = $this->db->query($sql);

         if ($result) {

             $num = $this->db->num_rows($result);

             $i = 0;

             if ($num) {

-                print '<select id="select' . $htmlname . '" class="flat selectshippingmethod" name="' . $htmlname . '"' . ($moreattrib ? ' ' . $moreattrib : '') . '>';

+                print '<select id="select'.$htmlname.'" class="flat selectshippingmethod" name="'.$htmlname.'"'.($moreattrib ? ' '.$moreattrib : '').'>';

                 if ($useempty == 1 || ($useempty == 2 && $num > 1)) {

                     print '<option value="-1">&nbsp;</option>';

                 }

                 while ($i < $num) {

                     $obj = $this->db->fetch_object($result);

                     if ($selected == $obj->rowid) {

-                        print '<option value="' . $obj->rowid . '" selected>';

+                        print '<option value="'.$obj->rowid.'" selected>';

                     } else {

-                        print '<option value="' . $obj->rowid . '">';

+                        print '<option value="'.$obj->rowid.'">';

                     }

-                    print ($langs->trans("SendingMethod" . strtoupper($obj->code)) != "SendingMethod" . strtoupper($obj->code)) ? $langs->trans("SendingMethod" . strtoupper($obj->code)) : $obj->label;

+                    print ($langs->trans("SendingMethod".strtoupper($obj->code)) != "SendingMethod".strtoupper($obj->code)) ? $langs->trans("SendingMethod".strtoupper($obj->code)) : $obj->label;

                     print '</option>';

                     $i++;

                 }

@@ -3403,16 +3403,16 @@ 
         $langs->load("deliveries");

 

         if ($htmlname != "none") {

-            print '<form method="POST" action="' . $page . '">';

+            print '<form method="POST" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setshippingmethod">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $this->selectShippingMethod($selected, $htmlname, '', $addempty);

-            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if ($selected) {

                 $code = $langs->getLabelFromKey($db, $selected, 'c_shipment_mode', 'rowid', 'code');

-                print $langs->trans("SendingMethod" . strtoupper($code));

+                print $langs->trans("SendingMethod".strtoupper($code));

             } else {

                 print "&nbsp;";

             }

@@ -3434,7 +3434,7 @@ 
         $langs->load('bills');

 

         $opt = '<option value ="" selected></option>';

-        $sql = 'SELECT rowid, ref, situation_cycle_ref, situation_counter, situation_final, fk_soc FROM ' . MAIN_DB_PREFIX . 'facture WHERE situation_counter>=1';

+        $sql = 'SELECT rowid, ref, situation_cycle_ref, situation_counter, situation_final, fk_soc FROM '.MAIN_DB_PREFIX.'facture WHERE situation_counter>=1';

         $sql .= ' ORDER by situation_cycle_ref, situation_counter desc';

         $resql = $this->db->query($sql);

         if ($resql && $this->db->num_rows($resql) > 0) {

@@ -3452,9 +3452,9 @@ 
                             //Not prov?

                             if (substr($obj->ref, 1, 4) != 'PROV') {

                                 if ($selected == $obj->rowid) {

-                                    $opt .= '<option value="' . $obj->rowid . '" selected>' . $obj->ref . '</option>';

+                                    $opt .= '<option value="'.$obj->rowid.'" selected>'.$obj->ref.'</option>';

                                 } else {

-                                    $opt .= '<option value="' . $obj->rowid . '">' . $obj->ref . '</option>';

+                                    $opt .= '<option value="'.$obj->rowid.'">'.$obj->ref.'</option>';

                                 }

                             }

                         }

@@ -3462,10 +3462,10 @@ 
                 }

             }

         } else {

-            dol_syslog("Error sql=" . $sql . ", error=" . $this->error, LOG_ERR);

+            dol_syslog("Error sql=".$sql.", error=".$this->error, LOG_ERR);

         }

         if ($opt == '<option value ="" selected></option>') {

-            $opt = '<option value ="0" selected>' . $langs->trans('NoSituations') . '</option>';

+            $opt = '<option value ="0" selected>'.$langs->trans('NoSituations').'</option>';

         }

         return $opt;

     }

@@ -3484,9 +3484,9 @@ 
 

         $langs->load('products');

 

-        $return = '<select class="flat" id="' . $htmlname . '" name="' . $htmlname . '">';

+        $return = '<select class="flat" id="'.$htmlname.'" name="'.$htmlname.'">';

 

-        $sql = 'SELECT rowid, label, code from ' . MAIN_DB_PREFIX . 'c_units';

+        $sql = 'SELECT rowid, label, code from '.MAIN_DB_PREFIX.'c_units';

         $sql .= ' WHERE active > 0';

 

         $resql = $this->db->query($sql);

@@ -3496,14 +3496,14 @@ 
 

             while ($res = $this->db->fetch_object($resql)) {

                 $unitLabel = $res->label;

-                if (!empty($langs->tab_translate['unit' . $res->code])) { // check if Translation is available before

-                    $unitLabel = $langs->trans('unit' . $res->code) != $res->label ? $langs->trans('unit' . $res->code) : $res->label;

+                if (!empty($langs->tab_translate['unit'.$res->code])) { // check if Translation is available before

+                    $unitLabel = $langs->trans('unit'.$res->code) != $res->label ? $langs->trans('unit'.$res->code) : $res->label;

                 }

 

                 if ($selected == $res->rowid) {

-                    $return .= '<option value="' . $res->rowid . '" selected>' . $unitLabel . '</option>';

+                    $return .= '<option value="'.$res->rowid.'" selected>'.$unitLabel.'</option>';

                 } else {

-                    $return .= '<option value="' . $res->rowid . '">' . $unitLabel . '</option>';

+                    $return .= '<option value="'.$res->rowid.'">'.$unitLabel.'</option>';

                 }

             }

             $return .= '</select>';

@@ -3533,21 +3533,21 @@ 
         $num = 0;

 

         $sql = "SELECT rowid, label, bank, clos as status, currency_code";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "bank_account";

-        $sql .= " WHERE entity IN (" . getEntity('bank_account') . ")";

+        $sql .= " FROM ".MAIN_DB_PREFIX."bank_account";

+        $sql .= " WHERE entity IN (".getEntity('bank_account').")";

         if ($statut != 2)

-            $sql .= " AND clos = '" . $statut . "'";

+            $sql .= " AND clos = '".$statut."'";

         if ($filtre)

-            $sql .= " AND " . $filtre;

+            $sql .= " AND ".$filtre;

         $sql .= " ORDER BY label";

 

-        dol_syslog(get_class($this) . "::select_comptes", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_comptes", LOG_DEBUG);

         $result = $this->db->query($sql);

         if ($result) {

             $num = $this->db->num_rows($result);

             $i = 0;

             if ($num) {

-                print '<select id="select' . $htmlname . '" class="flat selectbankaccount" name="' . $htmlname . '"' . ($moreattrib ? ' ' . $moreattrib : '') . '>';

+                print '<select id="select'.$htmlname.'" class="flat selectbankaccount" name="'.$htmlname.'"'.($moreattrib ? ' '.$moreattrib : '').'>';

                 if ($useempty == 1 || ($useempty == 2 && $num > 1)) {

                     print '<option value="-1">&nbsp;</option>';

                 }

@@ -3555,15 +3555,15 @@ 
                 while ($i < $num) {

                     $obj = $this->db->fetch_object($result);

                     if ($selected == $obj->rowid) {

-                        print '<option value="' . $obj->rowid . '" selected>';

+                        print '<option value="'.$obj->rowid.'" selected>';

                     } else {

-                        print '<option value="' . $obj->rowid . '">';

+                        print '<option value="'.$obj->rowid.'">';

                     }

                     print trim($obj->label);

                     if ($showcurrency)

-                        print ' (' . $obj->currency_code . ')';

+                        print ' ('.$obj->currency_code.')';

                     if ($statut == 2 && $obj->status == 1)

-                        print ' (' . $langs->trans("Closed") . ')';

+                        print ' ('.$langs->trans("Closed").')';

                     print '</option>';

                     $i++;

                 }

@@ -3571,9 +3571,9 @@ 
             }

             else {

                 if ($statut == 0)

-                    print '<span class="opacitymedium">' . $langs->trans("NoActiveBankAccountDefined") . '</span>';

+                    print '<span class="opacitymedium">'.$langs->trans("NoActiveBankAccountDefined").'</span>';

                 else

-                    print '<span class="opacitymedium">' . $langs->trans("NoBankAccountFound") . '</span>';

+                    print '<span class="opacitymedium">'.$langs->trans("NoBankAccountFound").'</span>';

             }

         }

         else {

@@ -3596,19 +3596,19 @@ 
     {

         global $langs;

         if ($htmlname != "none") {

-            print '<form method="POST" action="' . $page . '">';

+            print '<form method="POST" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setbankaccount">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $nbaccountfound = $this->select_comptes($selected, $htmlname, 0, '', $addempty);

             if ($nbaccountfound > 0)

-                print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+                print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

 

             $langs->load('banks');

 

             if ($selected) {

-                require_once DOL_DOCUMENT_ROOT . '/compta/bank/class/account.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/compta/bank/class/account.class.php';

                 $bankstatic = new Account($this->db);

                 $result = $bankstatic->fetch($selected);

                 if ($result)

@@ -3638,19 +3638,19 @@ 
         global $conf, $langs;

         $langs->load("categories");

 

-        include_once DOL_DOCUMENT_ROOT . '/categories/class/categorie.class.php';

+        include_once DOL_DOCUMENT_ROOT.'/categories/class/categorie.class.php';

 

         // For backward compatibility

         if (is_numeric($type)) {

-            dol_syslog(__METHOD__ . ': using numeric value for parameter type is deprecated. Use string code instead.', LOG_WARNING);

+            dol_syslog(__METHOD__.': using numeric value for parameter type is deprecated. Use string code instead.', LOG_WARNING);

         }

 

         if ($type === Categorie::TYPE_BANK_LINE) {

             // TODO Move this into common category feature

             $categids = array();

             $sql = "SELECT c.label, c.rowid";

-            $sql .= " FROM " . MAIN_DB_PREFIX . "bank_categ as c";

-            $sql .= " WHERE entity = " . $conf->entity;

+            $sql .= " FROM ".MAIN_DB_PREFIX."bank_categ as c";

+            $sql .= " WHERE entity = ".$conf->entity;

             $sql .= " ORDER BY c.label";

             $result = $this->db->query($sql);

             if ($result) {

@@ -3671,11 +3671,11 @@ 
             $cate_arbo = $cat->get_full_arbo($type, $excludeafterid);

         }

 

-        $output = '<select class="flat" name="' . $htmlname . '" id="' . $htmlname . '">';

+        $output = '<select class="flat" name="'.$htmlname.'" id="'.$htmlname.'">';

         $outarray = array();

         if (is_array($cate_arbo)) {

             if (!count($cate_arbo))

-                $output .= '<option value="-1" disabled>' . $langs->trans("NoCategoriesDefined") . '</option>';

+                $output .= '<option value="-1" disabled>'.$langs->trans("NoCategoriesDefined").'</option>';

             else {

                 $output .= '<option value="-1">&nbsp;</option>';

                 foreach ($cate_arbo as $key => $value) {

@@ -3684,7 +3684,7 @@ 
                     } else {

                         $add = '';

                     }

-                    $output .= '<option ' . $add . 'value="' . $cate_arbo[$key]['id'] . '">' . dol_trunc($cate_arbo[$key]['fulllabel'], $maxlength, 'middle') . '</option>';

+                    $output .= '<option '.$add.'value="'.$cate_arbo[$key]['id'].'">'.dol_trunc($cate_arbo[$key]['fulllabel'], $maxlength, 'middle').'</option>';

 

                     $outarray[$cate_arbo[$key]['id']] = $cate_arbo[$key]['fulllabel'];

                 }

@@ -3718,7 +3718,7 @@ 
     function form_confirm($page, $title, $question, $action, $formquestion = '', $selectedchoice = "", $useajax = 0, $height = 170, $width = 500)

     {

         // phpcs:enable

-        dol_syslog(__METHOD__ . ': using form_confirm is deprecated. Use formconfim instead.', LOG_WARNING);

+        dol_syslog(__METHOD__.': using form_confirm is deprecated. Use formconfim instead.', LOG_WARNING);

         print $this->formconfirm($page, $title, $question, $action, $formquestion, $selectedchoice, $useajax, $height, $width);

     }

 

@@ -3766,36 +3766,36 @@ 
             foreach ($formquestion as $key => $input) {

                 if (is_array($input) && !empty($input)) {

                     if ($input['type'] == 'hidden') {

-                        $more .= '<input type="hidden" id="' . $input['name'] . '" name="' . $input['name'] . '" value="' . dol_escape_htmltag($input['value']) . '">' . "\n";

+                        $more .= '<input type="hidden" id="'.$input['name'].'" name="'.$input['name'].'" value="'.dol_escape_htmltag($input['value']).'">'."\n";

                     }

                 }

             }

 

             // Now add questions

-            $more .= '<table class="paddingtopbottomonly" width="100%">' . "\n";

+            $more .= '<table class="paddingtopbottomonly" width="100%">'."\n";

             if (!empty($formquestion['text']))

-                $more .= '<tr><td colspan="2">' . $formquestion['text'] . '</td></tr>' . "\n";

+                $more .= '<tr><td colspan="2">'.$formquestion['text'].'</td></tr>'."\n";

             foreach ($formquestion as $key => $input) {

                 if (is_array($input) && !empty($input)) {

-                    $size = (!empty($input['size']) ? ' size="' . $input['size'] . '"' : '');

-                    $moreattr = (!empty($input['moreattr']) ? ' ' . $input['moreattr'] : '');

-                    $morecss = (!empty($input['morecss']) ? ' ' . $input['morecss'] : '');

+                    $size = (!empty($input['size']) ? ' size="'.$input['size'].'"' : '');

+                    $moreattr = (!empty($input['moreattr']) ? ' '.$input['moreattr'] : '');

+                    $morecss = (!empty($input['morecss']) ? ' '.$input['morecss'] : '');

 

                     if ($input['type'] == 'text') {

-                        $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td><td align="left"><input type="text" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '"' . $size . ' value="' . $input['value'] . '"' . $moreattr . ' /></td></tr>' . "\n";

+                        $more .= '<tr><td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>'.$input['label'].'</td><td align="left"><input type="text" class="flat'.$morecss.'" id="'.$input['name'].'" name="'.$input['name'].'"'.$size.' value="'.$input['value'].'"'.$moreattr.' /></td></tr>'."\n";

                     } elseif ($input['type'] == 'password') {

-                        $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td><td align="left"><input type="password" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '"' . $size . ' value="' . $input['value'] . '"' . $moreattr . ' /></td></tr>' . "\n";

+                        $more .= '<tr><td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>'.$input['label'].'</td><td align="left"><input type="password" class="flat'.$morecss.'" id="'.$input['name'].'" name="'.$input['name'].'"'.$size.' value="'.$input['value'].'"'.$moreattr.' /></td></tr>'."\n";

                     } elseif ($input['type'] == 'select') {

-                        $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>';

+                        $more .= '<tr><td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>';

                         if (!empty($input['label']))

-                            $more .= $input['label'] . '</td><td class="tdtop" align="left">';

+                            $more .= $input['label'].'</td><td class="tdtop" align="left">';

                         $more .= $this->selectarray($input['name'], $input['values'], $input['default'], 1, 0, 0, $moreattr, 0, 0, 0, '', $morecss);

-                        $more .= '</td></tr>' . "\n";

+                        $more .= '</td></tr>'."\n";

                     }

                     elseif ($input['type'] == 'checkbox') {

                         $more .= '<tr>';

-                        $more .= '<td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . ' </td><td align="left">';

-                        $more .= '<input type="checkbox" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '"' . $moreattr;

+                        $more .= '<td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>'.$input['label'].' </td><td align="left">';

+                        $more .= '<input type="checkbox" class="flat'.$morecss.'" id="'.$input['name'].'" name="'.$input['name'].'"'.$moreattr;

                         if (!is_bool($input['value']) && $input['value'] != 'false' && $input['value'] != '0')

                             $more .= ' checked';

                         if (is_bool($input['value']) && $input['value'])

@@ -3803,51 +3803,51 @@ 
                         if (isset($input['disabled']))

                             $more .= ' disabled';

                         $more .= ' /></td>';

-                        $more .= '</tr>' . "\n";

+                        $more .= '</tr>'."\n";

                     }

                     elseif ($input['type'] == 'radio') {

                         $i = 0;

                         foreach ($input['values'] as $selkey => $selval) {

                             $more .= '<tr>';

                             if ($i == 0)

-                                $more .= '<td' . (empty($input['tdclass']) ? ' class="tdtop"' : (' class="tdtop ' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td>';

+                                $more .= '<td'.(empty($input['tdclass']) ? ' class="tdtop"' : (' class="tdtop '.$input['tdclass'].'"')).'>'.$input['label'].'</td>';

                             else

-                                $more .= '<td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>&nbsp;</td>';

-                            $more .= '<td><input type="radio" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '" value="' . $selkey . '"' . $moreattr;

+                                $more .= '<td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>&nbsp;</td>';

+                            $more .= '<td><input type="radio" class="flat'.$morecss.'" id="'.$input['name'].'" name="'.$input['name'].'" value="'.$selkey.'"'.$moreattr;

                             if ($input['disabled'])

                                 $more .= ' disabled';

                             $more .= ' /> ';

                             $more .= $selval;

-                            $more .= '</td></tr>' . "\n";

+                            $more .= '</td></tr>'."\n";

                             $i++;

                         }

                     }

                     elseif ($input['type'] == 'date') {

-                        $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td>';

+                        $more .= '<tr><td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>'.$input['label'].'</td>';

                         $more .= '<td align="left">';

                         $more .= $this->selectDate($input['value'], $input['name'], 0, 0, 0, '', 1, 0);

-                        $more .= '</td></tr>' . "\n";

-                        $formquestion[] = array('name' => $input['name'] . 'day');

-                        $formquestion[] = array('name' => $input['name'] . 'month');

-                        $formquestion[] = array('name' => $input['name'] . 'year');

-                        $formquestion[] = array('name' => $input['name'] . 'hour');

-                        $formquestion[] = array('name' => $input['name'] . 'min');

+                        $more .= '</td></tr>'."\n";

+                        $formquestion[] = array('name' => $input['name'].'day');

+                        $formquestion[] = array('name' => $input['name'].'month');

+                        $formquestion[] = array('name' => $input['name'].'year');

+                        $formquestion[] = array('name' => $input['name'].'hour');

+                        $formquestion[] = array('name' => $input['name'].'min');

                     } elseif ($input['type'] == 'other') {

-                        $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>';

+                        $more .= '<tr><td'.(empty($input['tdclass']) ? '' : (' class="'.$input['tdclass'].'"')).'>';

                         if (!empty($input['label']))

-                            $more .= $input['label'] . '</td><td align="left">';

+                            $more .= $input['label'].'</td><td align="left">';

                         $more .= $input['value'];

-                        $more .= '</td></tr>' . "\n";

+                        $more .= '</td></tr>'."\n";

                     }

 

                     elseif ($input['type'] == 'onecolumn') {

                         $more .= '<tr><td colspan="2" align="left">';

                         $more .= $input['value'];

-                        $more .= '</td></tr>' . "\n";

+                        $more .= '</td></tr>'."\n";

                     }

                 }

             }

-            $more .= '</table>' . "\n";

+            $more .= '</table>'."\n";

         }

 

         // JQUI method dialog is broken with jmobile, we use standard HTML.

@@ -3866,10 +3866,10 @@ 
                 $button = $useajax;

                 $useajax = 1;

                 $autoOpen = false;

-                $dialogconfirm .= '-' . $button;

+                $dialogconfirm .= '-'.$button;

             }

-            $pageyes = $page . (preg_match('/\?/', $page) ? '&' : '?') . 'action=' . $action . '&confirm=yes';

-            $pageno = ($useajax == 2 ? $page . (preg_match('/\?/', $page) ? '&' : '?') . 'confirm=no' : '');

+            $pageyes = $page.(preg_match('/\?/', $page) ? '&' : '?').'action='.$action.'&confirm=yes';

+            $pageno = ($useajax == 2 ? $page.(preg_match('/\?/', $page) ? '&' : '?').'confirm=no' : '');

             // Add input fields into list of fields to read during submit (inputok and inputko)

             if (is_array($formquestion)) {

                 foreach ($formquestion as $key => $input) {

@@ -3881,20 +3881,20 @@ 
                 }

             }

             // Show JQuery confirm box. Note that global var $useglobalvars is used inside this template

-            $formconfirm .= '<div id="' . $dialogconfirm . '" title="' . dol_escape_htmltag($title) . '" style="display: none;">';

+            $formconfirm .= '<div id="'.$dialogconfirm.'" title="'.dol_escape_htmltag($title).'" style="display: none;">';

             if (!empty($more)) {

-                $formconfirm .= '<div class="confirmquestions">' . $more . '</div>';

+                $formconfirm .= '<div class="confirmquestions">'.$more.'</div>';

             }

-            $formconfirm .= ($question ? '<div class="confirmmessage">' . img_help('', '') . ' ' . $question . '</div>' : '');

-            $formconfirm .= '</div>' . "\n";

+            $formconfirm .= ($question ? '<div class="confirmmessage">'.img_help('', '').' '.$question.'</div>' : '');

+            $formconfirm .= '</div>'."\n";

 

-            $formconfirm .= "\n<!-- begin ajax formconfirm page=" . $page . " -->\n";

-            $formconfirm .= '<script type="text/javascript">' . "\n";

+            $formconfirm .= "\n<!-- begin ajax formconfirm page=".$page." -->\n";

+            $formconfirm .= '<script type="text/javascript">'."\n";

             $formconfirm .= 'jQuery(document).ready(function() {

             $(function() {

-            	$( "#' . $dialogconfirm . '" ).dialog(

+            	$( "#' . $dialogconfirm.'" ).dialog(

             	{

-                    autoOpen: ' . ($autoOpen ? "true" : "false") . ',';

+                    autoOpen: ' . ($autoOpen ? "true" : "false").',';

             if ($newselectedchoice == 'no') {

                 $formconfirm .= '

 						open: function() {

@@ -3903,15 +3903,15 @@ 
             }

             $formconfirm .= '

                     resizable: false,

-                    height: "' . $height . '",

-                    width: "' . $width . '",

+                    height: "' . $height.'",

+                    width: "' . $width.'",

                     modal: true,

                     closeOnEscape: false,

                     buttons: {

-                        "' . dol_escape_js($langs->transnoentities("Yes")) . '": function() {

+                        "' . dol_escape_js($langs->transnoentities("Yes")).'": function() {

                         	var options="";

-                        	var inputok = ' . json_encode($inputok) . ';

-                         	var pageyes = "' . dol_escape_js(!empty($pageyes) ? $pageyes : '') . '";

+                        	var inputok = ' . json_encode($inputok).';

+                         	var pageyes = "' . dol_escape_js(!empty($pageyes) ? $pageyes : '').'";

                          	if (inputok.length>0) {

                          		$.each(inputok, function(i, inputname) {

                          			var more = "";

@@ -3927,10 +3927,10 @@ 
             				if (pageyes.length > 0) { location.href = urljump; }

                             $(this).dialog("close");

                         },

-                        "' . dol_escape_js($langs->transnoentities("No")) . '": function() {

+                        "' . dol_escape_js($langs->transnoentities("No")).'": function() {

                         	var options = "";

-                         	var inputko = ' . json_encode($inputko) . ';

-                         	var pageno="' . dol_escape_js(!empty($pageno) ? $pageno : '') . '";

+                         	var inputko = ' . json_encode($inputko).';

+                         	var pageno="' . dol_escape_js(!empty($pageno) ? $pageno : '').'";

                          	if (inputko.length>0) {

                          		$.each(inputko, function(i, inputname) {

                          			var more = "";

@@ -3949,10 +3949,10 @@ 
                 }

                 );

 

-            	var button = "' . $button . '";

+            	var button = "' . $button.'";

             	if (button.length > 0) {

                 	$( "#" + button ).click(function() {

-                		$("#' . $dialogconfirm . '").dialog("open");

+                		$("#' . $dialogconfirm.'").dialog("open");

         			});

                 }

             });

@@ -3960,37 +3960,37 @@ 
             </script>';

             $formconfirm .= "<!-- end ajax formconfirm -->\n";

         } else {

-            $formconfirm .= "\n<!-- begin formconfirm page=" . $page . " -->\n";

+            $formconfirm .= "\n<!-- begin formconfirm page=".$page." -->\n";

 

             if (empty($disableformtag))

-                $formconfirm .= '<form method="POST" action="' . $page . '" class="notoptoleftroright">' . "\n";

+                $formconfirm .= '<form method="POST" action="'.$page.'" class="notoptoleftroright">'."\n";

 

-            $formconfirm .= '<input type="hidden" name="action" value="' . $action . '">' . "\n";

+            $formconfirm .= '<input type="hidden" name="action" value="'.$action.'">'."\n";

             if (empty($disableformtag))

-                $formconfirm .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">' . "\n";

+                $formconfirm .= '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">'."\n";

 

-            $formconfirm .= '<table width="100%" class="valid">' . "\n";

+            $formconfirm .= '<table width="100%" class="valid">'."\n";

 

             // Line title

-            $formconfirm .= '<tr class="validtitre"><td class="validtitre" colspan="3">' . img_picto('', 'recent') . ' ' . $title . '</td></tr>' . "\n";

+            $formconfirm .= '<tr class="validtitre"><td class="validtitre" colspan="3">'.img_picto('', 'recent').' '.$title.'</td></tr>'."\n";

 

             // Line form fields

             if ($more) {

-                $formconfirm .= '<tr class="valid"><td class="valid" colspan="3">' . "\n";

+                $formconfirm .= '<tr class="valid"><td class="valid" colspan="3">'."\n";

                 $formconfirm .= $more;

-                $formconfirm .= '</td></tr>' . "\n";

+                $formconfirm .= '</td></tr>'."\n";

             }

 

             // Line with question

             $formconfirm .= '<tr class="valid">';

-            $formconfirm .= '<td class="valid">' . $question . '</td>';

+            $formconfirm .= '<td class="valid">'.$question.'</td>';

             $formconfirm .= '<td class="valid">';

             $formconfirm .= $this->selectyesno("confirm", $newselectedchoice);

             $formconfirm .= '</td>';

-            $formconfirm .= '<td class="valid" align="center"><input class="button valignmiddle" type="submit" value="' . $langs->trans("Validate") . '"></td>';

-            $formconfirm .= '</tr>' . "\n";

+            $formconfirm .= '<td class="valid" align="center"><input class="button valignmiddle" type="submit" value="'.$langs->trans("Validate").'"></td>';

+            $formconfirm .= '</tr>'."\n";

 

-            $formconfirm .= '</table>' . "\n";

+            $formconfirm .= '</table>'."\n";

 

             if (empty($disableformtag))

                 $formconfirm .= "</form>\n";

@@ -4021,8 +4021,8 @@ 
         // phpcs:enable

         global $langs;

 

-        require_once DOL_DOCUMENT_ROOT . '/core/lib/project.lib.php';

-        require_once DOL_DOCUMENT_ROOT . '/core/class/html.formprojet.class.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/lib/project.lib.php';

+        require_once DOL_DOCUMENT_ROOT.'/core/class/html.formprojet.class.php';

 

         $out = '';

 

@@ -4031,11 +4031,11 @@ 
         $langs->load("project");

         if ($htmlname != "none") {

             $out .= "\n";

-            $out .= '<form method="post" action="' . $page . '">';

+            $out .= '<form method="post" action="'.$page.'">';

             $out .= '<input type="hidden" name="action" value="classin">';

-            $out .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            $out .= '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $out .= $formproject->select_projects($socid, $selected, $htmlname, $maxlength, 0, 1, $discard_closed, $forcefocus, 0, 0, '', 1);

-            $out .= '<input type="submit" class="button" value="' . $langs->trans("Modify") . '">';

+            $out .= '<input type="submit" class="button" value="'.$langs->trans("Modify").'">';

             $out .= '</form>';

         } else {

             if ($selected) {

@@ -4070,11 +4070,11 @@ 
         // phpcs:enable

         global $langs;

         if ($htmlname != "none") {

-            print '<form method="post" action="' . $page . '">';

+            print '<form method="post" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setconditions">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $this->select_conditions_paiements($selected, $htmlname, -1, $addempty);

-            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if ($selected) {

@@ -4101,11 +4101,11 @@ 
         // phpcs:enable

         global $langs;

         if ($htmlname != "none") {

-            print '<form method="post" action="' . $page . '">';

+            print '<form method="post" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setavailability">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $this->selectAvailabilityDelay($selected, $htmlname, -1, $addempty);

-            print '<input type="submit" class="button" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if ($selected) {

@@ -4131,11 +4131,11 @@ 
     {

         global $langs;

         if ($htmlname != "none") {

-            print '<form method="post" action="' . $page . '">';

+            print '<form method="post" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setdemandreason">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $this->selectInputReason($selected, $htmlname, -1, $addempty);

-            print '<input type="submit" class="button" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if ($selected) {

@@ -4173,14 +4173,14 @@ 
         $ret = '';

 

         if ($htmlname != "none") {

-            $ret .= '<form method="post" action="' . $page . '" name="form' . $htmlname . '">';

-            $ret .= '<input type="hidden" name="action" value="set' . $htmlname . '">';

-            $ret .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            $ret .= '<form method="post" action="'.$page.'" name="form'.$htmlname.'">';

+            $ret .= '<input type="hidden" name="action" value="set'.$htmlname.'">';

+            $ret .= '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $ret .= '<table class="nobordernopadding" cellpadding="0" cellspacing="0">';

             $ret .= '<tr><td>';

-            $ret .= $this->selectDate($selected, $htmlname, $displayhour, $displaymin, 1, 'form' . $htmlname, 1, 0);

+            $ret .= $this->selectDate($selected, $htmlname, $displayhour, $displaymin, 1, 'form'.$htmlname, 1, 0);

             $ret .= '</td>';

-            $ret .= '<td align="left"><input type="submit" class="button" value="' . $langs->trans("Modify") . '"></td>';

+            $ret .= '<td align="left"><input type="submit" class="button" value="'.$langs->trans("Modify").'"></td>';

             $ret .= '</tr></table></form>';

         } else {

             if ($displayhour)

@@ -4211,15 +4211,15 @@ 
         global $langs;

 

         if ($htmlname != "none") {

-            print '<form method="POST" action="' . $page . '" name="form' . $htmlname . '">';

-            print '<input type="hidden" name="action" value="set' . $htmlname . '">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<form method="POST" action="'.$page.'" name="form'.$htmlname.'">';

+            print '<input type="hidden" name="action" value="set'.$htmlname.'">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             print $this->select_dolusers($selected, $htmlname, 1, $exclude, 0, $include);

-            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if ($selected) {

-                require_once DOL_DOCUMENT_ROOT . '/user/class/user.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/user/class/user.class.php';

                 $theuser = new User($this->db);

                 $theuser->fetch($selected);

                 print $theuser->getNomUrl(1);

@@ -4245,11 +4245,11 @@ 
         // phpcs:enable

         global $langs;

         if ($htmlname != "none") {

-            print '<form method="POST" action="' . $page . '">';

+            print '<form method="POST" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setmode">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $this->select_types_paiements($selected, $htmlname, $filtertype, 0, 0, 0, 0, $active);

-            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if ($selected) {

@@ -4275,11 +4275,11 @@ 
         // phpcs:enable

         global $langs;

         if ($htmlname != "none") {

-            print '<form method="POST" action="' . $page . '">';

+            print '<form method="POST" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setmulticurrencycode">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             print $this->selectMultiCurrency($selected, $htmlname, 0);

-            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             dol_include_once('/core/lib/company.lib.php');

@@ -4303,21 +4303,21 @@ 
         global $langs, $mysoc, $conf;

 

         if ($htmlname != "none") {

-            print '<form method="POST" action="' . $page . '">';

+            print '<form method="POST" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setmulticurrencyrate">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

-            print '<input type="text" name="' . $htmlname . '" value="' . (!empty($rate) ? price($rate) : 1) . '" size="10" /> ';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

+            print '<input type="text" name="'.$htmlname.'" value="'.(!empty($rate) ? price($rate) : 1).'" size="10" /> ';

             print '<select name="calculation_mode">';

-            print '<option value="1">' . $currency . ' > ' . $conf->currency . '</option>';

-            print '<option value="2">' . $conf->currency . ' > ' . $currency . '</option>';

+            print '<option value="1">'.$currency.' > '.$conf->currency.'</option>';

+            print '<option value="2">'.$conf->currency.' > '.$currency.'</option>';

             print '</select> ';

-            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            print '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             print '</form>';

         } else {

             if (!empty($rate)) {

                 print price($rate, 1, $langs, 1, 0);

                 if ($currency && $rate != 1)

-                    print ' &nbsp; (' . price($rate, 1, $langs, 1, 0) . ' ' . $currency . ' = 1 ' . $conf->currency . ')';

+                    print ' &nbsp; ('.price($rate, 1, $langs, 1, 0).' '.$currency.' = 1 '.$conf->currency.')';

             }

             else {

                 print 1;

@@ -4346,14 +4346,14 @@ 
         // phpcs:enable

         global $conf, $langs;

         if ($htmlname != "none") {

-            print '<form method="post" action="' . $page . '">';

+            print '<form method="post" action="'.$page.'">';

             print '<input type="hidden" name="action" value="setabsolutediscount">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             print '<div class="inline-block">';

             if (!empty($discount_type)) {

                 if (!empty($conf->global->FACTURE_DEPOSITS_ARE_JUST_PAYMENTS)) {

                     if (!$filter || $filter == "fk_invoice_supplier_source IS NULL")

-                        $translationKey = 'HasAbsoluteDiscountFromSupplier';    // If we want deposit to be substracted to payments only and not to total of final invoice

+                        $translationKey = 'HasAbsoluteDiscountFromSupplier'; // If we want deposit to be substracted to payments only and not to total of final invoice

                     else

                         $translationKey = 'HasCreditNoteFromSupplier';

                 }

@@ -4366,7 +4366,7 @@ 
             } else {

                 if (!empty($conf->global->FACTURE_DEPOSITS_ARE_JUST_PAYMENTS)) {

                     if (!$filter || $filter == "fk_facture_source IS NULL")

-                        $translationKey = 'CompanyHasAbsoluteDiscount';    // If we want deposit to be substracted to payments only and not to total of final invoice

+                        $translationKey = 'CompanyHasAbsoluteDiscount'; // If we want deposit to be substracted to payments only and not to total of final invoice

                     else

                         $translationKey = 'CompanyHasCreditNote';

                 }

@@ -4383,21 +4383,21 @@ 
             print '</div>';

             if (empty($hidelist)) {

                 print '<div class="inline-block" style="padding-right: 10px">';

-                $newfilter = 'discount_type=' . intval($discount_type);

+                $newfilter = 'discount_type='.intval($discount_type);

                 if (!empty($discount_type)) {

                     $newfilter .= ' AND fk_invoice_supplier IS NULL AND fk_invoice_supplier_line IS NULL'; // Supplier discounts available

                 } else {

                     $newfilter .= ' AND fk_facture IS NULL AND fk_facture_line IS NULL'; // Customer discounts available

                 }

                 if ($filter)

-                    $newfilter .= ' AND (' . $filter . ')';

+                    $newfilter .= ' AND ('.$filter.')';

                 $nbqualifiedlines = $this->select_remises($selected, $htmlname, $newfilter, $socid, $maxvalue);

                 if ($nbqualifiedlines > 0) {

-                    print ' &nbsp; <input type="submit" class="button" value="' . dol_escape_htmltag($langs->trans("UseLine")) . '"';

+                    print ' &nbsp; <input type="submit" class="button" value="'.dol_escape_htmltag($langs->trans("UseLine")).'"';

                     if (!empty($discount_type) && $filter && $filter != "fk_invoice_supplier_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS PAID)%')")

-                        print ' title="' . $langs->trans("UseCreditNoteInInvoicePayment") . '"';

+                        print ' title="'.$langs->trans("UseCreditNoteInInvoicePayment").'"';

                     if (empty($discount_type) && $filter && $filter != "fk_facture_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS RECEIVED)%')")

-                        print ' title="' . $langs->trans("UseCreditNoteInInvoicePayment") . '"';

+                        print ' title="'.$langs->trans("UseCreditNoteInInvoicePayment").'"';

 

                     print '>';

                 }

@@ -4434,22 +4434,22 @@ 
         global $langs, $conf;

 

         if ($htmlname != "none") {

-            print '<form method="post" action="' . $page . '">';

+            print '<form method="post" action="'.$page.'">';

             print '<input type="hidden" name="action" value="set_contact">';

-            print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            print '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             print '<table class="nobordernopadding" cellpadding="0" cellspacing="0">';

             print '<tr><td>';

             $num = $this->select_contacts($societe->id, $selected, $htmlname);

             if ($num == 0) {

                 $addcontact = (!empty($conf->global->SOCIETE_ADDRESSES_MANAGEMENT) ? $langs->trans("AddContact") : $langs->trans("AddContactAddress"));

-                print '<a href="' . DOL_URL_ROOT . '/contact/card.php?socid=' . $societe->id . '&amp;action=create&amp;backtoreferer=1">' . $addcontact . '</a>';

+                print '<a href="'.DOL_URL_ROOT.'/contact/card.php?socid='.$societe->id.'&amp;action=create&amp;backtoreferer=1">'.$addcontact.'</a>';

             }

             print '</td>';

-            print '<td align="left"><input type="submit" class="button" value="' . $langs->trans("Modify") . '"></td>';

+            print '<td align="left"><input type="submit" class="button" value="'.$langs->trans("Modify").'"></td>';

             print '</tr></table></form>';

         } else {

             if ($selected) {

-                require_once DOL_DOCUMENT_ROOT . '/contact/class/contact.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

                 $contact = new Contact($this->db);

                 $contact->fetch($selected);

                 print $contact->getFullName($langs);

@@ -4481,15 +4481,15 @@ 
 

         $out = '';

         if ($htmlname != "none") {

-            $out .= '<form method="post" action="' . $page . '">';

+            $out .= '<form method="post" action="'.$page.'">';

             $out .= '<input type="hidden" name="action" value="set_thirdparty">';

-            $out .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

+            $out .= '<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';

             $out .= $this->select_company($selected, $htmlname, $filter, $showempty, $showtype, $forcecombo, $events);

-            $out .= '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            $out .= '<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';

             $out .= '</form>';

         } else {

             if ($selected) {

-                require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

+                require_once DOL_DOCUMENT_ROOT.'/societe/class/societe.class.php';

                 $soc = new Societe($this->db);

                 $soc->fetch($selected);

                 $out .= $soc->getNomUrl($langs);

@@ -4535,17 +4535,17 @@ 
         $out = '';

 

         if ($selected == 'euro' || $selected == 'euros')

-            $selected = 'EUR';   // Pour compatibilite

+            $selected = 'EUR'; // Pour compatibilite

 

-        $out .= '<select class="flat maxwidth200onsmartphone minwidth300" name="' . $htmlname . '" id="' . $htmlname . '">';

+        $out .= '<select class="flat maxwidth200onsmartphone minwidth300" name="'.$htmlname.'" id="'.$htmlname.'">';

         foreach ($langs->cache_currencies as $code_iso => $currency) {

             if ($selected && $selected == $code_iso) {

-                $out .= '<option value="' . $code_iso . '" selected>';

+                $out .= '<option value="'.$code_iso.'" selected>';

             } else {

-                $out .= '<option value="' . $code_iso . '">';

+                $out .= '<option value="'.$code_iso.'">';

             }

             $out .= $currency['label'];

-            $out .= ' (' . $langs->getCurrencySymbol($code_iso) . ')';

+            $out .= ' ('.$langs->getCurrencySymbol($code_iso).')';

             $out .= '</option>';

         }

         $out .= '</select>';

@@ -4553,7 +4553,7 @@ 
             $out .= info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

 

         // Make select dynamic

-        include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+        include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

         $out .= ajax_combobox($htmlname);

 

         return $out;

@@ -4571,12 +4571,12 @@ 
     {

         global $db, $conf, $langs, $user;

 

-        $langs->loadCacheCurrencies('');        // Load ->cache_currencies

+        $langs->loadCacheCurrencies(''); // Load ->cache_currencies

 

         $TCurrency = array();

 

-        $sql = 'SELECT code FROM ' . MAIN_DB_PREFIX . 'multicurrency';

-        $sql .= " WHERE entity IN ('" . getEntity('mutlicurrency') . "')";

+        $sql = 'SELECT code FROM '.MAIN_DB_PREFIX.'multicurrency';

+        $sql .= " WHERE entity IN ('".getEntity('mutlicurrency')."')";

         $resql = $db->query($sql);

         if ($resql) {

             while ($obj = $db->fetch_object($resql))

@@ -4584,7 +4584,7 @@ 
         }

 

         $out = '';

-        $out .= '<select class="flat" name="' . $htmlname . '" id="' . $htmlname . '">';

+        $out .= '<select class="flat" name="'.$htmlname.'" id="'.$htmlname.'">';

         if ($useempty)

             $out .= '<option value=""></option>';

         // If company current currency not in table, we add it into list. Should always be available.

@@ -4595,12 +4595,12 @@ 
             foreach ($langs->cache_currencies as $code_iso => $currency) {

                 if (isset($TCurrency[$code_iso])) {

                     if (!empty($selected) && $selected == $code_iso)

-                        $out .= '<option value="' . $code_iso . '" selected="selected">';

+                        $out .= '<option value="'.$code_iso.'" selected="selected">';

                     else

-                        $out .= '<option value="' . $code_iso . '">';

+                        $out .= '<option value="'.$code_iso.'">';

 

                     $out .= $currency['label'];

-                    $out .= ' (' . $langs->getCurrencySymbol($code_iso) . ')';

+                    $out .= ' ('.$langs->getCurrencySymbol($code_iso).')';

                     $out .= '</option>';

                 }

             }

@@ -4608,7 +4608,7 @@ 
 

         $out .= '</select>';

         // Make select dynamic

-        include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+        include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

         $out .= ajax_combobox($htmlname);

 

         return $out;

@@ -4628,15 +4628,15 @@ 
 

         $num = count($this->cache_vatrates);

         if ($num > 0)

-            return $num;    // Cache already loaded

+            return $num; // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

         $sql = "SELECT DISTINCT t.rowid, t.code, t.taux, t.localtax1, t.localtax1_type, t.localtax2, t.localtax2_type, t.recuperableonly";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_tva as t, " . MAIN_DB_PREFIX . "c_country as c";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_tva as t, ".MAIN_DB_PREFIX."c_country as c";

         $sql .= " WHERE t.fk_pays = c.rowid";

         $sql .= " AND t.active > 0";

-        $sql .= " AND c.code IN (" . $country_code . ")";

+        $sql .= " AND c.code IN (".$country_code.")";

         $sql .= " ORDER BY t.code ASC, t.taux ASC, t.recuperableonly ASC";

 

         $resql = $this->db->query($sql);

@@ -4654,28 +4654,28 @@ 
                     $this->cache_vatrates[$i]['localtax2'] = $obj->localtax2;

                     $this->cache_vatrates[$i]['localtax2_type'] = $obj->localtax1_type;

 

-                    $this->cache_vatrates[$i]['label'] = $obj->taux . '%' . ($obj->code ? ' (' . $obj->code . ')' : '');   // Label must contains only 0-9 , . % or *

-                    $this->cache_vatrates[$i]['labelallrates'] = $obj->taux . '/' . ($obj->localtax1 ? $obj->localtax1 : '0') . '/' . ($obj->localtax2 ? $obj->localtax2 : '0') . ($obj->code ? ' (' . $obj->code . ')' : ''); // Must never be used as key, only label

+                    $this->cache_vatrates[$i]['label'] = $obj->taux.'%'.($obj->code ? ' ('.$obj->code.')' : ''); // Label must contains only 0-9 , . % or *

+                    $this->cache_vatrates[$i]['labelallrates'] = $obj->taux.'/'.($obj->localtax1 ? $obj->localtax1 : '0').'/'.($obj->localtax2 ? $obj->localtax2 : '0').($obj->code ? ' ('.$obj->code.')' : ''); // Must never be used as key, only label

                     $positiverates = '';

                     if ($obj->taux)

-                        $positiverates .= ($positiverates ? '/' : '') . $obj->taux;

+                        $positiverates .= ($positiverates ? '/' : '').$obj->taux;

                     if ($obj->localtax1)

-                        $positiverates .= ($positiverates ? '/' : '') . $obj->localtax1;

+                        $positiverates .= ($positiverates ? '/' : '').$obj->localtax1;

                     if ($obj->localtax2)

-                        $positiverates .= ($positiverates ? '/' : '') . $obj->localtax2;

+                        $positiverates .= ($positiverates ? '/' : '').$obj->localtax2;

                     if (empty($positiverates))

                         $positiverates = '0';

-                    $this->cache_vatrates[$i]['labelpositiverates'] = $positiverates . ($obj->code ? ' (' . $obj->code . ')' : ''); // Must never be used as key, only label

+                    $this->cache_vatrates[$i]['labelpositiverates'] = $positiverates.($obj->code ? ' ('.$obj->code.')' : ''); // Must never be used as key, only label

                 }

 

                 return $num;

             }

             else {

-                $this->error = '<font class="error">' . $langs->trans("ErrorNoVATRateDefinedForSellerCountry", $country_code) . '</font>';

+                $this->error = '<font class="error">'.$langs->trans("ErrorNoVATRateDefinedForSellerCountry", $country_code).'</font>';

                 return -1;

             }

         } else {

-            $this->error = '<font class="error">' . $this->db->error() . '</font>';

+            $this->error = '<font class="error">'.$this->db->error().'</font>';

             return -2;

         }

     }

@@ -4724,9 +4724,9 @@ 
         // Check parameters

         if (is_object($societe_vendeuse) && !$societe_vendeuse->country_code) {

             if ($societe_vendeuse->id == $mysoc->id) {

-                $return .= '<font class="error">' . $langs->trans("ErrorYourCountryIsNotDefined") . '</div>';

+                $return .= '<font class="error">'.$langs->trans("ErrorYourCountryIsNotDefined").'</div>';

             } else {

-                $return .= '<font class="error">' . $langs->trans("ErrorSupplierCountryIsNotDefined") . '</div>';

+                $return .= '<font class="error">'.$langs->trans("ErrorSupplierCountryIsNotDefined").'</div>';

             }

             return $return;

         }

@@ -4737,32 +4737,32 @@ 
         // Define list of countries to use to search VAT rates to show

         // First we defined code_country to use to find list

         if (is_object($societe_vendeuse)) {

-            $code_country = "'" . $societe_vendeuse->country_code . "'";

+            $code_country = "'".$societe_vendeuse->country_code."'";

         } else {

-            $code_country = "'" . $mysoc->country_code . "'";   // Pour compatibilite ascendente

+            $code_country = "'".$mysoc->country_code."'"; // Pour compatibilite ascendente

         }

         if (!empty($conf->global->SERVICE_ARE_ECOMMERCE_200238EC)) {    // If option to have vat for end customer for services is on

-            require_once DOL_DOCUMENT_ROOT . '/core/lib/company.lib.php';

+            require_once DOL_DOCUMENT_ROOT.'/core/lib/company.lib.php';

             if (!isInEEC($societe_vendeuse) && (!is_object($societe_acheteuse) || (isInEEC($societe_acheteuse) && !$societe_acheteuse->isACompany()))) {

                 // We also add the buyer

                 if (is_numeric($type)) {

                     if ($type == 1) { // We know product is a service

-                        $code_country .= ",'" . $societe_acheteuse->country_code . "'";

+                        $code_country .= ",'".$societe_acheteuse->country_code."'";

                     }

                 } else if (!$idprod) {  // We don't know type of product

-                    $code_country .= ",'" . $societe_acheteuse->country_code . "'";

+                    $code_country .= ",'".$societe_acheteuse->country_code."'";

                 } else {

                     $prodstatic = new Product($this->db);

                     $prodstatic->fetch($idprod);

                     if ($prodstatic->type == Product::TYPE_SERVICE) {   // We know product is a service

-                        $code_country .= ",'" . $societe_acheteuse->country_code . "'";

+                        $code_country .= ",'".$societe_acheteuse->country_code."'";

                     }

                 }

             }

         }

 

         // Now we get list

-        $num = $this->load_cache_vatrates($code_country);   // If no vat defined, return -1 with message into this->error

+        $num = $this->load_cache_vatrates($code_country); // If no vat defined, return -1 with message into this->error

 

         if ($num > 0) {

             // Definition du taux a pre-selectionner (si defaulttx non force et donc vaut -1 ou '')

@@ -4795,13 +4795,13 @@ 
             if (is_object($societe_vendeuse) && $societe_vendeuse->id == $mysoc->id && $societe_vendeuse->tva_assuj == "0") {

                 // Override/enable VAT for expense report regardless of global setting - needed if expense report used for business expenses

                 if (empty($conf->global->OVERRIDE_VAT_FOR_EXPENSE_REPORT)) {

-                    $title = ' title="' . $langs->trans('VATIsNotUsed') . '"';

+                    $title = ' title="'.$langs->trans('VATIsNotUsed').'"';

                     $disabled = true;

                 }

             }

 

             if (!$options_only) {

-                $return .= '<select class="flat minwidth75imp" id="' . $htmlname . '" name="' . $htmlname . '"' . ($disabled ? ' disabled' : '') . $title . '>';

+                $return .= '<select class="flat minwidth75imp" id="'.$htmlname.'" name="'.$htmlname.'"'.($disabled ? ' disabled' : '').$title.'>';

             }

 

             $selectedfound = false;

@@ -4814,11 +4814,11 @@ 
                 $key = $rate['txtva'];

                 $key .= $rate['nprtva'] ? '*' : '';

                 if ($mode > 0 && $rate['code'])

-                    $key .= ' (' . $rate['code'] . ')';

+                    $key .= ' ('.$rate['code'].')';

                 if ($mode < 0)

                     $key = $rate['rowid'];

 

-                $return .= '<option value="' . $key . '"';

+                $return .= '<option value="'.$key.'"';

                 if (!$selectedfound) {

                     if ($defaultcode) { // If defaultcode is defined, we used it in priority to select combo option instead of using rate+npr flag

                         if ($defaultcode == $rate['code']) {

@@ -4838,7 +4838,7 @@ 
                     $return .= vatrate($rate['label']);

                 }

                 //$return.=($rate['code']?' '.$rate['code']:'');

-                $return .= (empty($rate['code']) && $rate['nprtva']) ? ' *' : '';         // We show the *  (old behaviour only if new vat code is not used)

+                $return .= (empty($rate['code']) && $rate['nprtva']) ? ' *' : ''; // We show the *  (old behaviour only if new vat code is not used)

 

                 $return .= '</option>';

             }

@@ -4937,7 +4937,7 @@ 
         $orig_set_time = $set_time;

 

         if ($set_time === '' && $emptydate == 0) {

-            include_once DOL_DOCUMENT_ROOT . '/core/lib/date.lib.php';

+            include_once DOL_DOCUMENT_ROOT.'/core/lib/date.lib.php';

             $set_time = dol_now('tzuser') - (getServerTimeZoneInt('now') * 3600); // set_time must be relative to PHP server timezone

         }

 

@@ -4990,36 +4990,36 @@ 
                 //print "e".$set_time." t ".$conf->format_date_short;

                 if (strval($set_time) != '' && $set_time != -1) {

                     //$formated_date=dol_print_date($set_time,$conf->format_date_short);

-                    $formated_date = dol_print_date($set_time, $langs->trans("FormatDateShortInput"));  // FormatDateShortInput for dol_print_date / FormatDateShortJavaInput that is same for javascript

+                    $formated_date = dol_print_date($set_time, $langs->trans("FormatDateShortInput")); // FormatDateShortInput for dol_print_date / FormatDateShortJavaInput that is same for javascript

                 }

 

                 // Calendrier popup version eldy

                 if ($usecalendar == "eldy") {

                     // Zone de saisie manuelle de la date

-                    $retstring .= '<input id="' . $prefix . '" name="' . $prefix . '" type="text" class="maxwidth75" maxlength="11" value="' . $formated_date . '"';

+                    $retstring .= '<input id="'.$prefix.'" name="'.$prefix.'" type="text" class="maxwidth75" maxlength="11" value="'.$formated_date.'"';

                     $retstring .= ($disabled ? ' disabled' : '');

-                    $retstring .= ' onChange="dpChangeDay(\'' . $prefix . '\',\'' . $langs->trans("FormatDateShortJavaInput") . '\'); "';  // FormatDateShortInput for dol_print_date / FormatDateShortJavaInput that is same for javascript

+                    $retstring .= ' onChange="dpChangeDay(\''.$prefix.'\',\''.$langs->trans("FormatDateShortJavaInput").'\'); "'; // FormatDateShortInput for dol_print_date / FormatDateShortJavaInput that is same for javascript

                     $retstring .= '>';

 

                     // Icone calendrier

                     if (!$disabled) {

-                        $retstring .= '<button id="' . $prefix . 'Button" type="button" class="dpInvisibleButtons"';

-                        $base = DOL_URL_ROOT . '/core/';

-                        $retstring .= ' onClick="showDP(\'' . $base . '\',\'' . $prefix . '\',\'' . $langs->trans("FormatDateShortJavaInput") . '\',\'' . $langs->defaultlang . '\');"';

-                        $retstring .= '>' . img_object($langs->trans("SelectDate"), 'calendarday', 'class="datecallink"') . '</button>';

+                        $retstring .= '<button id="'.$prefix.'Button" type="button" class="dpInvisibleButtons"';

+                        $base = DOL_URL_ROOT.'/core/';

+                        $retstring .= ' onClick="showDP(\''.$base.'\',\''.$prefix.'\',\''.$langs->trans("FormatDateShortJavaInput").'\',\''.$langs->defaultlang.'\');"';

+                        $retstring .= '>'.img_object($langs->trans("SelectDate"), 'calendarday', 'class="datecallink"').'</button>';

                     } else

-                        $retstring .= '<button id="' . $prefix . 'Button" type="button" class="dpInvisibleButtons">' . img_object($langs->trans("Disabled"), 'calendarday', 'class="datecallink"') . '</button>';

+                        $retstring .= '<button id="'.$prefix.'Button" type="button" class="dpInvisibleButtons">'.img_object($langs->trans("Disabled"), 'calendarday', 'class="datecallink"').'</button>';

 

-                    $retstring .= '<input type="hidden" id="' . $prefix . 'day"   name="' . $prefix . 'day"   value="' . $sday . '">' . "\n";

-                    $retstring .= '<input type="hidden" id="' . $prefix . 'month" name="' . $prefix . 'month" value="' . $smonth . '">' . "\n";

-                    $retstring .= '<input type="hidden" id="' . $prefix . 'year"  name="' . $prefix . 'year"  value="' . $syear . '">' . "\n";

+                    $retstring .= '<input type="hidden" id="'.$prefix.'day"   name="'.$prefix.'day"   value="'.$sday.'">'."\n";

+                    $retstring .= '<input type="hidden" id="'.$prefix.'month" name="'.$prefix.'month" value="'.$smonth.'">'."\n";

+                    $retstring .= '<input type="hidden" id="'.$prefix.'year"  name="'.$prefix.'year"  value="'.$syear.'">'."\n";

                 }

                 elseif ($usecalendar == 'jquery') {

                     if (!$disabled) {

                         // Output javascript for datepicker

                         $retstring .= "<script type='text/javascript'>";

-                        $retstring .= "$(function(){ $('#" . $prefix . "').datepicker({

-							dateFormat: '" . $langs->trans("FormatDateShortJQueryInput") . "',

+                        $retstring .= "$(function(){ $('#".$prefix."').datepicker({

+							dateFormat: '" . $langs->trans("FormatDateShortJQueryInput")."',

 							autoclose: true,

 							todayHighlight: true,";

                         if (!empty($conf->dol_use_jmobile)) {

@@ -5042,7 +5042,7 @@ 
                              */

                             $retstring .= "

 								showOn: 'button',

-								buttonImage: '" . DOL_BASE_URI . "/theme/" . $conf->theme . "/img/object_calendarday.png',

+								buttonImage: '" . DOL_BASE_URI."/theme/".$conf->theme."/img/object_calendarday.png',

 								buttonImageOnly: true";

                         }

                         $retstring .= "

@@ -5052,9 +5052,9 @@ 
 

                     // Zone de saisie manuelle de la date

                     $retstring .= '<div class="nowrap inline-block">';

-                    $retstring .= '<input id="' . $prefix . '" name="' . $prefix . '" type="text" class="maxwidth75" maxlength="11" value="' . $formated_date . '"';

+                    $retstring .= '<input id="'.$prefix.'" name="'.$prefix.'" type="text" class="maxwidth75" maxlength="11" value="'.$formated_date.'"';

                     $retstring .= ($disabled ? ' disabled' : '');

-                    $retstring .= ' onChange="dpChangeDay(\'' . $prefix . '\',\'' . $langs->trans("FormatDateShortJavaInput") . '\'); "';  // FormatDateShortInput for dol_print_date / FormatDateShortJavaInput that is same for javascript

+                    $retstring .= ' onChange="dpChangeDay(\''.$prefix.'\',\''.$langs->trans("FormatDateShortJavaInput").'\'); "'; // FormatDateShortInput for dol_print_date / FormatDateShortJavaInput that is same for javascript

                     $retstring .= '>';

 

                     // Icone calendrier

@@ -5069,13 +5069,13 @@ 
                           $retstring.='});';

                           $retstring.="</script>"; */

                     } else {

-                        $retstring .= '<button id="' . $prefix . 'Button" type="button" class="dpInvisibleButtons">' . img_object($langs->trans("Disabled"), 'calendarday', 'class="datecallink"') . '</button>';

+                        $retstring .= '<button id="'.$prefix.'Button" type="button" class="dpInvisibleButtons">'.img_object($langs->trans("Disabled"), 'calendarday', 'class="datecallink"').'</button>';

                     }

 

                     $retstring .= '</div>';

-                    $retstring .= '<input type="hidden" id="' . $prefix . 'day"   name="' . $prefix . 'day"   value="' . $sday . '">' . "\n";

-                    $retstring .= '<input type="hidden" id="' . $prefix . 'month" name="' . $prefix . 'month" value="' . $smonth . '">' . "\n";

-                    $retstring .= '<input type="hidden" id="' . $prefix . 'year"  name="' . $prefix . 'year"  value="' . $syear . '">' . "\n";

+                    $retstring .= '<input type="hidden" id="'.$prefix.'day"   name="'.$prefix.'day"   value="'.$sday.'">'."\n";

+                    $retstring .= '<input type="hidden" id="'.$prefix.'month" name="'.$prefix.'month" value="'.$smonth.'">'."\n";

+                    $retstring .= '<input type="hidden" id="'.$prefix.'year"  name="'.$prefix.'year"  value="'.$syear.'">'."\n";

                 } else {

                     $retstring .= "Bad value of MAIN_POPUP_CALENDAR";

                 }

@@ -5084,26 +5084,26 @@ 
             else {

                 //$retstring.='<div class="inline-block">';

                 // Day

-                $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth50imp" id="' . $prefix . 'day" name="' . $prefix . 'day">';

+                $retstring .= '<select'.($disabled ? ' disabled' : '').' class="flat valignmiddle maxwidth50imp" id="'.$prefix.'day" name="'.$prefix.'day">';

 

                 if ($emptydate || $set_time == -1) {

                     $retstring .= '<option value="0" selected>&nbsp;</option>';

                 }

 

                 for ($day = 1; $day <= 31; $day++) {

-                    $retstring .= '<option value="' . $day . '"' . ($day == $sday ? ' selected' : '') . '>' . $day . '</option>';

+                    $retstring .= '<option value="'.$day.'"'.($day == $sday ? ' selected' : '').'>'.$day.'</option>';

                 }

 

                 $retstring .= "</select>";

 

-                $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth75imp" id="' . $prefix . 'month" name="' . $prefix . 'month">';

+                $retstring .= '<select'.($disabled ? ' disabled' : '').' class="flat valignmiddle maxwidth75imp" id="'.$prefix.'month" name="'.$prefix.'month">';

                 if ($emptydate || $set_time == -1) {

                     $retstring .= '<option value="0" selected>&nbsp;</option>';

                 }

 

                 // Month

                 for ($month = 1; $month <= 12; $month++) {

-                    $retstring .= '<option value="' . $month . '"' . ($month == $smonth ? ' selected' : '') . '>';

+                    $retstring .= '<option value="'.$month.'"'.($month == $smonth ? ' selected' : '').'>';

                     $retstring .= dol_print_date(mktime(12, 0, 0, $month, 1, 2000), "%b");

                     $retstring .= "</option>";

                 }

@@ -5111,12 +5111,12 @@ 
 

                 // Year

                 if ($emptydate || $set_time == -1) {

-                    $retstring .= '<input' . ($disabled ? ' disabled' : '') . ' placeholder="' . dol_escape_htmltag($langs->trans("Year")) . '" class="flat maxwidth50imp valignmiddle" type="number" min="0" max="3000" maxlength="4" id="' . $prefix . 'year" name="' . $prefix . 'year" value="' . $syear . '">';

+                    $retstring .= '<input'.($disabled ? ' disabled' : '').' placeholder="'.dol_escape_htmltag($langs->trans("Year")).'" class="flat maxwidth50imp valignmiddle" type="number" min="0" max="3000" maxlength="4" id="'.$prefix.'year" name="'.$prefix.'year" value="'.$syear.'">';

                 } else {

-                    $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth75imp" id="' . $prefix . 'year" name="' . $prefix . 'year">';

+                    $retstring .= '<select'.($disabled ? ' disabled' : '').' class="flat valignmiddle maxwidth75imp" id="'.$prefix.'year" name="'.$prefix.'year">';

 

                     for ($year = $syear - 10; $year < $syear + 10; $year++) {

-                        $retstring .= '<option value="' . $year . '"' . ($year == $syear ? ' selected' : '') . '>' . $year . '</option>';

+                        $retstring .= '<option value="'.$year.'"'.($year == $syear ? ' selected' : '').'>'.$year.'</option>';

                     }

                     $retstring .= "</select>\n";

                 }

@@ -5129,13 +5129,13 @@ 
 

         if ($h) {

             // Show hour

-            $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth50 ' . ($fullday ? $fullday . 'hour' : '') . '" id="' . $prefix . 'hour" name="' . $prefix . 'hour">';

+            $retstring .= '<select'.($disabled ? ' disabled' : '').' class="flat valignmiddle maxwidth50 '.($fullday ? $fullday.'hour' : '').'" id="'.$prefix.'hour" name="'.$prefix.'hour">';

             if ($emptyhours)

                 $retstring .= '<option value="-1">&nbsp;</option>';

             for ($hour = 0; $hour < 24; $hour++) {

                 if (strlen($hour) < 2)

-                    $hour = "0" . $hour;

-                $retstring .= '<option value="' . $hour . '"' . (($hour == $shour) ? ' selected' : '') . '>' . $hour . (empty($conf->dol_optimize_smallscreen) ? '' : 'H') . '</option>';

+                    $hour = "0".$hour;

+                $retstring .= '<option value="'.$hour.'"'.(($hour == $shour) ? ' selected' : '').'>'.$hour.(empty($conf->dol_optimize_smallscreen) ? '' : 'H').'</option>';

             }

             $retstring .= '</select>';

             if ($m && empty($conf->dol_optimize_smallscreen))

@@ -5144,17 +5144,17 @@ 
 

         if ($m) {

             // Show minutes

-            $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth50 ' . ($fullday ? $fullday . 'min' : '') . '" id="' . $prefix . 'min" name="' . $prefix . 'min">';

+            $retstring .= '<select'.($disabled ? ' disabled' : '').' class="flat valignmiddle maxwidth50 '.($fullday ? $fullday.'min' : '').'" id="'.$prefix.'min" name="'.$prefix.'min">';

             if ($emptyhours)

                 $retstring .= '<option value="-1">&nbsp;</option>';

             for ($min = 0; $min < 60; $min++) {

                 if (strlen($min) < 2)

-                    $min = "0" . $min;

-                $retstring .= '<option value="' . $min . '"' . (($min == $smin) ? ' selected' : '') . '>' . $min . (empty($conf->dol_optimize_smallscreen) ? '' : '') . '</option>';

+                    $min = "0".$min;

+                $retstring .= '<option value="'.$min.'"'.(($min == $smin) ? ' selected' : '').'>'.$min.(empty($conf->dol_optimize_smallscreen) ? '' : '').'</option>';

             }

             $retstring .= '</select>';

 

-            $retstring .= '<input type="hidden" name="' . $prefix . 'sec" value="' . $ssec . '">';

+            $retstring .= '<input type="hidden" name="'.$prefix.'sec" value="'.$ssec.'">';

         }

 

         // Add a "Now" link

@@ -5163,10 +5163,10 @@ 
             $reset_scripts = "";

 

             // Generate the date part, depending on the use or not of the javascript calendar

-            $reset_scripts .= 'jQuery(\'#' . $prefix . '\').val(\'' . dol_print_date(dol_now(), 'day') . '\');';

-            $reset_scripts .= 'jQuery(\'#' . $prefix . 'day\').val(\'' . dol_print_date(dol_now(), '%d') . '\');';

-            $reset_scripts .= 'jQuery(\'#' . $prefix . 'month\').val(\'' . dol_print_date(dol_now(), '%m') . '\');';

-            $reset_scripts .= 'jQuery(\'#' . $prefix . 'year\').val(\'' . dol_print_date(dol_now(), '%Y') . '\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'\').val(\''.dol_print_date(dol_now(), 'day').'\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'day\').val(\''.dol_print_date(dol_now(), '%d').'\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'month\').val(\''.dol_print_date(dol_now(), '%m').'\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'year\').val(\''.dol_print_date(dol_now(), '%Y').'\');';

             /* if ($usecalendar == "eldy")

               {

               $base=DOL_URL_ROOT.'/core/';

@@ -5183,7 +5183,7 @@ 
                 if ($fullday)

                     $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

                 //$reset_scripts .= 'this.form.elements[\''.$prefix.'hour\'].value=formatDate(new Date(), \'HH\'); ';

-                $reset_scripts .= 'jQuery(\'#' . $prefix . 'hour\').val(\'' . dol_print_date(dol_now(), '%H') . '\');';

+                $reset_scripts .= 'jQuery(\'#'.$prefix.'hour\').val(\''.dol_print_date(dol_now(), '%H').'\');';

                 if ($fullday)

                     $reset_scripts .= ' } ';

             }

@@ -5192,13 +5192,13 @@ 
                 if ($fullday)

                     $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

                 //$reset_scripts .= 'this.form.elements[\''.$prefix.'min\'].value=formatDate(new Date(), \'mm\'); ';

-                $reset_scripts .= 'jQuery(\'#' . $prefix . 'min\').val(\'' . dol_print_date(dol_now(), '%M') . '\');';

+                $reset_scripts .= 'jQuery(\'#'.$prefix.'min\').val(\''.dol_print_date(dol_now(), '%M').'\');';

                 if ($fullday)

                     $reset_scripts .= ' } ';

             }

             // If reset_scripts is not empty, print the link with the reset_scripts in the onClick

             if ($reset_scripts && empty($conf->dol_optimize_smallscreen)) {

-                $retstring .= ' <button class="dpInvisibleButtons datenowlink" id="' . $prefix . 'ButtonNow" type="button" name="_useless" value="now" onClick="' . $reset_scripts . '">';

+                $retstring .= ' <button class="dpInvisibleButtons datenowlink" id="'.$prefix.'ButtonNow" type="button" name="_useless" value="now" onClick="'.$reset_scripts.'">';

                 $retstring .= $langs->trans("Now");

                 $retstring .= '</button> ';

             }

@@ -5210,15 +5210,15 @@ 
             $reset_scripts = "";

 

             // Generate the date part, depending on the use or not of the javascript calendar

-            $reset_scripts .= 'jQuery(\'#' . $prefix . '\').val(\'' . dol_print_date(dol_now(), 'day') . '\');';

-            $reset_scripts .= 'jQuery(\'#' . $prefix . 'day\').val(\'' . dol_print_date(dol_now(), '%d') . '\');';

-            $reset_scripts .= 'jQuery(\'#' . $prefix . 'month\').val(\'' . dol_print_date(dol_now(), '%m') . '\');';

-            $reset_scripts .= 'jQuery(\'#' . $prefix . 'year\').val(\'' . dol_print_date(dol_now(), '%Y') . '\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'\').val(\''.dol_print_date(dol_now(), 'day').'\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'day\').val(\''.dol_print_date(dol_now(), '%d').'\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'month\').val(\''.dol_print_date(dol_now(), '%m').'\');';

+            $reset_scripts .= 'jQuery(\'#'.$prefix.'year\').val(\''.dol_print_date(dol_now(), '%Y').'\');';

             // Update the hour part

             if ($h) {

                 if ($fullday)

                     $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

-                $reset_scripts .= 'jQuery(\'#' . $prefix . 'hour\').val(\'' . dol_print_date(dol_now(), '%H') . '\');';

+                $reset_scripts .= 'jQuery(\'#'.$prefix.'hour\').val(\''.dol_print_date(dol_now(), '%H').'\');';

                 if ($fullday)

                     $reset_scripts .= ' } ';

             }

@@ -5226,13 +5226,13 @@ 
             if ($m) {

                 if ($fullday)

                     $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

-                $reset_scripts .= 'jQuery(\'#' . $prefix . 'min\').val(\'' . dol_print_date(dol_now(), '%M') . '\');';

+                $reset_scripts .= 'jQuery(\'#'.$prefix.'min\').val(\''.dol_print_date(dol_now(), '%M').'\');';

                 if ($fullday)

                     $reset_scripts .= ' } ';

             }

             // If reset_scripts is not empty, print the link with the reset_scripts in the onClick

             if ($reset_scripts && empty($conf->dol_optimize_smallscreen)) {

-                $retstring .= ' <button class="dpInvisibleButtons datenowlink" id="' . $prefix . 'ButtonPlusOne" type="button" name="_useless2" value="plusone" onClick="' . $reset_scripts . '">';

+                $retstring .= ' <button class="dpInvisibleButtons datenowlink" id="'.$prefix.'ButtonPlusOne" type="button" name="_useless2" value="plusone" onClick="'.$reset_scripts.'">';

                 $retstring .= $langs->trans("DateStartPlusOne");

                 $retstring .= '</button> ';

             }

@@ -5241,7 +5241,7 @@ 
         // Add a "Plus one hour" link

         if ($conf->use_javascript_ajax && $adddateof) {

             $tmparray = dol_getdate($adddateof);

-            $retstring .= ' - <button class="dpInvisibleButtons datenowlink" id="dateofinvoice" type="button" name="_dateofinvoice" value="now" onclick="jQuery(\'#re\').val(\'' . dol_print_date($adddateof, 'day') . '\');jQuery(\'#reday\').val(\'' . $tmparray['mday'] . '\');jQuery(\'#remonth\').val(\'' . $tmparray['mon'] . '\');jQuery(\'#reyear\').val(\'' . $tmparray['year'] . '\');">' . $langs->trans("DateInvoice") . '</a>';

+            $retstring .= ' - <button class="dpInvisibleButtons datenowlink" id="dateofinvoice" type="button" name="_dateofinvoice" value="now" onclick="jQuery(\'#re\').val(\''.dol_print_date($adddateof, 'day').'\');jQuery(\'#reday\').val(\''.$tmparray['mday'].'\');jQuery(\'#remonth\').val(\''.$tmparray['mon'].'\');jQuery(\'#reyear\').val(\''.$tmparray['year'].'\');">'.$langs->trans("DateInvoice").'</a>';

         }

 

         return $retstring;

@@ -5273,29 +5273,29 @@ 
 

         // Hours

         if ($iSecond != '') {

-            require_once DOL_DOCUMENT_ROOT . '/core/lib/date.lib.php';

+            require_once DOL_DOCUMENT_ROOT.'/core/lib/date.lib.php';

 

             $hourSelected = convertSecondToTime($iSecond, 'allhour');

             $minSelected = convertSecondToTime($iSecond, 'min');

         }

 

         if ($typehour == 'select') {

-            $retstring .= '<select class="flat" id="select_' . $prefix . 'hour" name="' . $prefix . 'hour"' . ($disabled ? ' disabled' : '') . '>';

+            $retstring .= '<select class="flat" id="select_'.$prefix.'hour" name="'.$prefix.'hour"'.($disabled ? ' disabled' : '').'>';

             for ($hour = 0; $hour < 25; $hour++) { // For a duration, we allow 24 hours

-                $retstring .= '<option value="' . $hour . '"';

+                $retstring .= '<option value="'.$hour.'"';

                 if ($hourSelected == $hour) {

                     $retstring .= " selected";

                 }

-                $retstring .= ">" . $hour . "</option>";

+                $retstring .= ">".$hour."</option>";

             }

             $retstring .= "</select>";

         } elseif ($typehour == 'text' || $typehour == 'textselect') {

-            $retstring .= '<input placeholder="' . $langs->trans('HourShort') . '" type="number" min="0" size="1" name="' . $prefix . 'hour"' . ($disabled ? ' disabled' : '') . ' class="flat maxwidth50 inputhour" value="' . (($hourSelected != '') ? ((int) $hourSelected) : '') . '">';

+            $retstring .= '<input placeholder="'.$langs->trans('HourShort').'" type="number" min="0" size="1" name="'.$prefix.'hour"'.($disabled ? ' disabled' : '').' class="flat maxwidth50 inputhour" value="'.(($hourSelected != '') ? ((int) $hourSelected) : '').'">';

         } else

             return 'BadValueForParameterTypeHour';

 

         if ($typehour != 'text')

-            $retstring .= ' ' . $langs->trans('HourShort');

+            $retstring .= ' '.$langs->trans('HourShort');

         else

             $retstring .= '<span class="hideonsmartphone">:</span>';

 

@@ -5306,21 +5306,21 @@ 
             $retstring .= '<span class="hideonsmartphone">&nbsp;</span>';

 

         if ($typehour == 'select' || $typehour == 'textselect') {

-            $retstring .= '<select class="flat" id="select_' . $prefix . 'min" name="' . $prefix . 'min"' . ($disabled ? ' disabled' : '') . '>';

+            $retstring .= '<select class="flat" id="select_'.$prefix.'min" name="'.$prefix.'min"'.($disabled ? ' disabled' : '').'>';

             for ($min = 0; $min <= 55; $min = $min + 5) {

-                $retstring .= '<option value="' . $min . '"';

+                $retstring .= '<option value="'.$min.'"';

                 if ($minSelected == $min)

                     $retstring .= ' selected';

-                $retstring .= '>' . $min . '</option>';

+                $retstring .= '>'.$min.'</option>';

             }

             $retstring .= "</select>";

         }

         elseif ($typehour == 'text') {

-            $retstring .= '<input placeholder="' . $langs->trans('MinuteShort') . '" type="number" min="0" size="1" name="' . $prefix . 'min"' . ($disabled ? ' disabled' : '') . ' class="flat maxwidth50 inputminute" value="' . (($minSelected != '') ? ((int) $minSelected) : '') . '">';

+            $retstring .= '<input placeholder="'.$langs->trans('MinuteShort').'" type="number" min="0" size="1" name="'.$prefix.'min"'.($disabled ? ' disabled' : '').' class="flat maxwidth50 inputminute" value="'.(($minSelected != '') ? ((int) $minSelected) : '').'">';

         }

 

         if ($typehour != 'text')

-            $retstring .= ' ' . $langs->trans('MinuteShort');

+            $retstring .= ' '.$langs->trans('MinuteShort');

 

         //$retstring.="&nbsp;";

 

@@ -5363,30 +5363,30 @@ 
             }

         }

         if (!is_object($objecttmp)) {

-            dol_syslog('Error bad setup of type for field ' . $InfoFieldList, LOG_WARNING);

-            return 'Error bad setup of type for field ' . join(',', $InfoFieldList);

+            dol_syslog('Error bad setup of type for field '.$InfoFieldList, LOG_WARNING);

+            return 'Error bad setup of type for field '.join(',', $InfoFieldList);

         }

 

         $prefixforautocompletemode = $objecttmp->element;

         if ($prefixforautocompletemode == 'societe')

             $prefixforautocompletemode = 'company';

-        $confkeyforautocompletemode = strtoupper($prefixforautocompletemode) . '_USE_SEARCH_TO_SELECT'; // For example COMPANY_USE_SEARCH_TO_SELECT

+        $confkeyforautocompletemode = strtoupper($prefixforautocompletemode).'_USE_SEARCH_TO_SELECT'; // For example COMPANY_USE_SEARCH_TO_SELECT

 

-        dol_syslog(get_class($this) . "::selectForForms", LOG_DEBUG);

+        dol_syslog(get_class($this)."::selectForForms", LOG_DEBUG);

 

         $out = '';

         if (!empty($conf->use_javascript_ajax) && !empty($conf->global->$confkeyforautocompletemode) && !$forcecombo) {

-            $objectdesc = $classname . ':' . $classpath;

-            $urlforajaxcall = DOL_URL_ROOT . '/core/ajax/selectobject.php';

+            $objectdesc = $classname.':'.$classpath;

+            $urlforajaxcall = DOL_URL_ROOT.'/core/ajax/selectobject.php';

             //if ($objecttmp->element == 'societe') $urlforajaxcall = DOL_URL_ROOT.'/societe/ajax/company.php';

             // No immediate load of all database

-            $urloption = 'htmlname=' . $htmlname . '&outjson=1&objectdesc=' . $objectdesc . ($moreparams ? $moreparams : '');

+            $urloption = 'htmlname='.$htmlname.'&outjson=1&objectdesc='.$objectdesc.($moreparams ? $moreparams : '');

             // Activate the auto complete using ajax call.

             $out .= ajax_autocompleter($preselectedvalue, $htmlname, $urlforajaxcall, $urloption, $conf->global->$confkeyforautocompletemode, 0, array());

             $out .= '<style type="text/css">.ui-autocomplete { z-index: 250; }</style>';

             if ($placeholder)

-                $placeholder = ' placeholder="' . $placeholder . '"';

-            $out .= '<input type="text" class="' . $morecss . '" name="search_' . $htmlname . '" id="search_' . $htmlname . '" value="' . $preselectedvalue . '"' . $placeholder . ' />';

+                $placeholder = ' placeholder="'.$placeholder.'"';

+            $out .= '<input type="text" class="'.$morecss.'" name="search_'.$htmlname.'" id="search_'.$htmlname.'" value="'.$preselectedvalue.'"'.$placeholder.' />';

         }

         else {

             // Immediate load of all database

@@ -5420,14 +5420,14 @@ 
         $prefixforautocompletemode = $objecttmp->element;

         if ($prefixforautocompletemode == 'societe')

             $prefixforautocompletemode = 'company';

-        $confkeyforautocompletemode = strtoupper($prefixforautocompletemode) . '_USE_SEARCH_TO_SELECT'; // For example COMPANY_USE_SEARCH_TO_SELECT

+        $confkeyforautocompletemode = strtoupper($prefixforautocompletemode).'_USE_SEARCH_TO_SELECT'; // For example COMPANY_USE_SEARCH_TO_SELECT

 

         $fieldstoshow = 't.ref';

         if (!empty($objecttmp->fields)) { // For object that declare it, it is better to use declared fields ( like societe, contact, ...)

             $tmpfieldstoshow = '';

             foreach ($objecttmp->fields as $key => $val) {

                 if ($val['showoncombobox'])

-                    $tmpfieldstoshow .= ($tmpfieldstoshow ? ',' : '') . 't.' . $key;

+                    $tmpfieldstoshow .= ($tmpfieldstoshow ? ',' : '').'t.'.$key;

             }

             if ($tmpfieldstoshow)

                 $fieldstoshow = $tmpfieldstoshow;

@@ -5439,36 +5439,36 @@ 
         $num = 0;

 

         // Search data

-        $sql = "SELECT t.rowid, " . $fieldstoshow . " FROM " . MAIN_DB_PREFIX . $objecttmp->table_element . " as t";

+        $sql = "SELECT t.rowid, ".$fieldstoshow." FROM ".MAIN_DB_PREFIX.$objecttmp->table_element." as t";

         if ($objecttmp->ismultientitymanaged == 2)

             if (!$user->rights->societe->client->voir && !$user->societe_id)

-                $sql .= ", " . MAIN_DB_PREFIX . "societe_commerciaux as sc";

+                $sql .= ", ".MAIN_DB_PREFIX."societe_commerciaux as sc";

         $sql .= " WHERE 1=1";

         if (!empty($objecttmp->ismultientitymanaged))

-            $sql .= " AND t.entity IN (" . getEntity($objecttmp->table_element) . ")";

+            $sql .= " AND t.entity IN (".getEntity($objecttmp->table_element).")";

         if ($objecttmp->ismultientitymanaged == 1 && !empty($user->societe_id)) {

             if ($objecttmp->element == 'societe')

-                $sql .= " AND t.rowid = " . $user->societe_id;

+                $sql .= " AND t.rowid = ".$user->societe_id;

             else

-                $sql .= " AND t.fk_soc = " . $user->societe_id;

+                $sql .= " AND t.fk_soc = ".$user->societe_id;

         }

         if ($searchkey != '')

             $sql .= natural_search(explode(',', $fieldstoshow), $searchkey);

         if ($objecttmp->ismultientitymanaged == 2)

             if (!$user->rights->societe->client->voir && !$user->societe_id)

-                $sql .= " AND t.rowid = sc.fk_soc AND sc.fk_user = " . $user->id;

+                $sql .= " AND t.rowid = sc.fk_soc AND sc.fk_user = ".$user->id;

         $sql .= $this->db->order($fieldstoshow, "ASC");

         //$sql.=$this->db->plimit($limit, 0);

         // Build output string

         $resql = $this->db->query($sql);

         if ($resql) {

             if (!$forcecombo) {

-                include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+                include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

                 $out .= ajax_combobox($htmlname, null, $conf->global->$confkeyforautocompletemode);

             }

 

             // Construct $out and $outarray

-            $out .= '<select id="' . $htmlname . '" class="flat' . ($morecss ? ' ' . $morecss : '') . '"' . ($moreparams ? ' ' . $moreparams : '') . ' name="' . $htmlname . '">' . "\n";

+            $out .= '<select id="'.$htmlname.'" class="flat'.($morecss ? ' '.$morecss : '').'"'.($moreparams ? ' '.$moreparams : '').' name="'.$htmlname.'">'."\n";

 

             // Warning: Do not use textifempty = ' ' or '&nbsp;' here, or search on key will search on ' key'. Seems it is no more true with selec2 v4

             $textifempty = '&nbsp;';

@@ -5481,7 +5481,7 @@ 
                     $textifempty .= $langs->trans("All");

             }

             if ($showempty)

-                $out .= '<option value="-1">' . $textifempty . '</option>' . "\n";

+                $out .= '<option value="-1">'.$textifempty.'</option>'."\n";

 

             $num = $this->db->num_rows($resql);

             $i = 0;

@@ -5492,13 +5492,13 @@ 
                     $tmparray = explode(',', $fieldstoshow);

                     foreach ($tmparray as $key => $val) {

                         $val = preg_replace('/t\./', '', $val);

-                        $label .= (($label && $obj->$val) ? ' - ' : '') . $obj->$val;

+                        $label .= (($label && $obj->$val) ? ' - ' : '').$obj->$val;

                     }

                     if (empty($outputmode)) {

                         if ($preselectedvalue > 0 && $preselectedvalue == $obj->rowid) {

-                            $out .= '<option value="' . $obj->rowid . '" selected>' . $label . '</option>';

+                            $out .= '<option value="'.$obj->rowid.'" selected>'.$label.'</option>';

                         } else {

-                            $out .= '<option value="' . $obj->rowid . '">' . $label . '</option>';

+                            $out .= '<option value="'.$obj->rowid.'">'.$label.'</option>';

                         }

                     } else {

                         array_push($outarray, array('key' => $obj->rowid, 'value' => $label, 'label' => $label));

@@ -5510,7 +5510,7 @@ 
                 }

             }

 

-            $out .= '</select>' . "\n";

+            $out .= '</select>'."\n";

         }

         else {

             dol_print_error($this->db);

@@ -5566,12 +5566,12 @@ 
             $tmpplugin = empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) ? (constant('REQUIRE_JQUERY_MULTISELECT') ? constant('REQUIRE_JQUERY_MULTISELECT') : 'select2') : $conf->global->MAIN_USE_JQUERY_MULTISELECT;

 

             // Enhance with select2

-            include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+            include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

             $out .= ajax_combobox($htmlname);

         }

 

-        $out .= '<select id="' . preg_replace('/^\./', '', $htmlname) . '" ' . ($disabled ? 'disabled ' : '') . 'class="flat ' . (preg_replace('/^\./', '', $htmlname)) . ($morecss ? ' ' . $morecss : '') . '"';

-        $out .= ' name="' . preg_replace('/^\./', '', $htmlname) . '" ' . ($moreparam ? $moreparam : '');

+        $out .= '<select id="'.preg_replace('/^\./', '', $htmlname).'" '.($disabled ? 'disabled ' : '').'class="flat '.(preg_replace('/^\./', '', $htmlname)).($morecss ? ' '.$morecss : '').'"';

+        $out .= ' name="'.preg_replace('/^\./', '', $htmlname).'" '.($moreparam ? $moreparam : '');

         $out .= '>';

 

         if ($show_empty) {

@@ -5580,7 +5580,7 @@ 
                 $textforempty = '&nbsp;'; // If we use ajaxcombo, we need &nbsp; here to avoid to have an empty element that is too small.

             if (!is_numeric($show_empty))

                 $textforempty = $show_empty;

-            $out .= '<option class="optiongrey" ' . ($moreparamonempty ? $moreparamonempty . ' ' : '') . 'value="' . ($show_empty < 0 ? $show_empty : -1) . '"' . ($id == $show_empty ? ' selected' : '') . '>' . $textforempty . '</option>' . "\n";

+            $out .= '<option class="optiongrey" '.($moreparamonempty ? $moreparamonempty.' ' : '').'value="'.($show_empty < 0 ? $show_empty : -1).'"'.($id == $show_empty ? ' selected' : '').'>'.$textforempty.'</option>'."\n";

         }

 

         if (is_array($array)) {

@@ -5610,9 +5610,9 @@ 
 

                 if ($key_in_label) {

                     if (empty($nohtmlescape))

-                        $selectOptionValue = dol_escape_htmltag($key . ' - ' . ($maxlen ? dol_trunc($value, $maxlen) : $value));

+                        $selectOptionValue = dol_escape_htmltag($key.' - '.($maxlen ? dol_trunc($value, $maxlen) : $value));

                     else

-                        $selectOptionValue = $key . ' - ' . ($maxlen ? dol_trunc($value, $maxlen) : $value);

+                        $selectOptionValue = $key.' - '.($maxlen ? dol_trunc($value, $maxlen) : $value);

                 }

                 else {

                     if (empty($nohtmlescape))

@@ -5623,12 +5623,12 @@ 
                         $selectOptionValue = '&nbsp;';

                 }

 

-                $out .= '<option value="' . $key . '"';

-                $out .= $style . $disabled;

+                $out .= '<option value="'.$key.'"';

+                $out .= $style.$disabled;

                 if ($id != '' && $id == $key && !$disabled)

-                    $out .= ' selected';  // To preselect a value

+                    $out .= ' selected'; // To preselect a value

                 if ($nohtmlescape)

-                    $out .= ' data-html="' . dol_escape_htmltag($selectOptionValue) . '"';

+                    $out .= ' data-html="'.dol_escape_htmltag($selectOptionValue).'"';

                 $out .= '>';

                 //var_dump($selectOptionValue);

                 $out .= $selectOptionValue;

@@ -5667,19 +5667,19 @@ 
         if (empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) && !defined('REQUIRE_JQUERY_MULTISELECT'))

             return '';

 

-        $out = '<select type="text" class="' . $htmlname . ($morecss ? ' ' . $morecss : '') . '" ' . ($moreparam ? $moreparam . ' ' : '') . 'name="' . $htmlname . '"></select>';

+        $out = '<select type="text" class="'.$htmlname.($morecss ? ' '.$morecss : '').'" '.($moreparam ? $moreparam.' ' : '').'name="'.$htmlname.'"></select>';

 

         $tmpplugin = 'select2';

-        $outdelayed = "\n" . '<!-- JS CODE TO ENABLE ' . $tmpplugin . ' for id ' . $htmlname . ' -->

+        $outdelayed = "\n".'<!-- JS CODE TO ENABLE '.$tmpplugin.' for id '.$htmlname.' -->

 	    	<script type="text/javascript">

 	    	$(document).ready(function () {

 

-    	        ' . ($callurlonselect ? 'var saveRemoteData = [];' : '') . '

+    	        ' . ($callurlonselect ? 'var saveRemoteData = [];' : '').'

 

-                $(".' . $htmlname . '").select2({

+                $(".' . $htmlname.'").select2({

 			    	ajax: {

 				    	dir: "ltr",

-				    	url: "' . $url . '",

+				    	url: "' . $url.'",

 				    	dataType: \'json\',

 				    	delay: 250,

 				    	data: function (params) {

@@ -5706,9 +5706,9 @@ 
 			    	},

 	 				language: select2arrayoflanguage,

 					containerCssClass: \':all:\',					/* Line to add class of origin SELECT propagated to the new <span class="select2-selection...> tag */

-				    placeholder: "' . dol_escape_js($placeholder) . '",

+				    placeholder: "' . dol_escape_js($placeholder).'",

 			    	escapeMarkup: function (markup) { return markup; }, 	// let our custom formatter work

-			    	minimumInputLength: ' . $minimumInputLength . ',

+			    	minimumInputLength: ' . $minimumInputLength.',

 			        formatResult: function(result, container, query, escapeMarkup) {

                         return escapeMarkup(result.text);

                     },

@@ -5716,10 +5716,10 @@ 
 

                 ' . ($callurlonselect ? '

                 /* Code to execute a GET when we select a value */

-                $(".' . $htmlname . '").change(function() {

-			    	var selected = $(".' . $htmlname . '").val();

+                $(".' . $htmlname.'").change(function() {

+			    	var selected = $(".' . $htmlname.'").val();

                 	console.log("We select in selectArrayAjax the entry "+selected)

-			        $(".' . $htmlname . '").val("");  /* reset visible combo value */

+			        $(".' . $htmlname.'").val("");  /* reset visible combo value */

     			    $.each( saveRemoteData, function( key, value ) {

     				        if (key == selected)

     			            {

@@ -5727,7 +5727,7 @@ 
     			                 location.assign(value.url);

     			            }

                     });

-    			});' : '' ) . '

+    			});' : '').'

 

     	   });

 	       </script>';

@@ -5767,7 +5767,7 @@ 
         if (empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) && !defined('REQUIRE_JQUERY_MULTISELECT'))

             return '';

 

-        $out = '<select type="text" class="' . $htmlname . ($morecss ? ' ' . $morecss : '') . '" ' . ($moreparam ? $moreparam . ' ' : '') . 'name="' . $htmlname . '"><option></option></select>';

+        $out = '<select type="text" class="'.$htmlname.($morecss ? ' '.$morecss : '').'" '.($moreparam ? $moreparam.' ' : '').'name="'.$htmlname.'"><option></option></select>';

 

         $formattedarrayresult = array();

 

@@ -5780,20 +5780,20 @@ 
         }

 

         $tmpplugin = 'select2';

-        $outdelayed = "\n" . '<!-- JS CODE TO ENABLE ' . $tmpplugin . ' for id ' . $htmlname . ' -->

+        $outdelayed = "\n".'<!-- JS CODE TO ENABLE '.$tmpplugin.' for id '.$htmlname.' -->

 			<script type="text/javascript">

 			$(document).ready(function () {

-				var data = ' . json_encode($formattedarrayresult) . ';

+				var data = ' . json_encode($formattedarrayresult).';

 

-				' . ($callurlonselect ? 'var saveRemoteData = ' . json_encode($array) . ';' : '') . '

+				' . ($callurlonselect ? 'var saveRemoteData = '.json_encode($array).';' : '').'

 

-				$(".' . $htmlname . '").select2({

+				$(".' . $htmlname.'").select2({

 					data: data,

 					language: select2arrayoflanguage,

 					containerCssClass: \':all:\',					/* Line to add class of origin SELECT propagated to the new <span class="select2-selection...> tag */

-					placeholder: "' . dol_escape_js($placeholder) . '",

+					placeholder: "' . dol_escape_js($placeholder).'",

 					escapeMarkup: function (markup) { return markup; }, 	// let our custom formatter work

-					minimumInputLength: ' . $minimumInputLength . ',

+					minimumInputLength: ' . $minimumInputLength.',

 					formatResult: function(result, container, query, escapeMarkup) {

 						return escapeMarkup(result.text);

 					},

@@ -5831,11 +5831,11 @@ 
 

 				' . ($callurlonselect ? '

 				/* Code to execute a GET when we select a value */

-				$(".' . $htmlname . '").change(function() {

-					var selected = $(".' . $htmlname . '").val();

+				$(".' . $htmlname.'").change(function() {

+					var selected = $(".' . $htmlname.'").val();

 					console.log("We select "+selected)

 

-					$(".' . $htmlname . '").val("");  /* reset visible combo value */

+					$(".' . $htmlname.'").val("");  /* reset visible combo value */

 					$.each( saveRemoteData, function( key, value ) {

 						if (key == selected)

 						{

@@ -5843,7 +5843,7 @@ 
 							location.assign(value.url);

 						}

 					});

-				});' : '' ) . '

+				});' : '').'

 

 			});

 			</script>';

@@ -5883,28 +5883,28 @@ 
 

         // Add code for jquery to use multiselect

         if (!empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) || defined('REQUIRE_JQUERY_MULTISELECT')) {

-            $out .= "\n" . '<!-- JS CODE TO ENABLE ' . $tmpplugin . ' for id ' . $htmlname . ' -->

+            $out .= "\n".'<!-- JS CODE TO ENABLE '.$tmpplugin.' for id '.$htmlname.' -->

 						<script type="text/javascript">' . "\n";

             if ($addjscombo == 1) {

                 $tmpplugin = empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) ? constant('REQUIRE_JQUERY_MULTISELECT') : $conf->global->MAIN_USE_JQUERY_MULTISELECT;

-                $out .= 'function formatResult(record) {' . "\n";

+                $out .= 'function formatResult(record) {'."\n";

                 if ($elemtype == 'category') {

-                    $out .= '	//return \'<span><img src="' . DOL_URL_ROOT . '/theme/eldy/img/object_category.png' . '"> <a href="' . DOL_URL_ROOT . '/categories/viewcat.php?type=0&id=\'+record.id+\'">\'+record.text+\'</a></span>\';

-									  	return \'<span><img src="' . DOL_URL_ROOT . '/theme/eldy/img/object_category.png' . '"> \'+record.text+\'</span>\';';

+                    $out .= '	//return \'<span><img src="'.DOL_URL_ROOT.'/theme/eldy/img/object_category.png'.'"> <a href="'.DOL_URL_ROOT.'/categories/viewcat.php?type=0&id=\'+record.id+\'">\'+record.text+\'</a></span>\';

+									  	return \'<span><img src="' . DOL_URL_ROOT.'/theme/eldy/img/object_category.png'.'"> \'+record.text+\'</span>\';';

                 } else {

                     $out .= 'return record.text;';

                 }

-                $out .= '};' . "\n";

-                $out .= 'function formatSelection(record) {' . "\n";

+                $out .= '};'."\n";

+                $out .= 'function formatSelection(record) {'."\n";

                 if ($elemtype == 'category') {

-                    $out .= '	//return \'<span><img src="' . DOL_URL_ROOT . '/theme/eldy/img/object_category.png' . '"> <a href="' . DOL_URL_ROOT . '/categories/viewcat.php?type=0&id=\'+record.id+\'">\'+record.text+\'</a></span>\';

-									  	return \'<span><img src="' . DOL_URL_ROOT . '/theme/eldy/img/object_category.png' . '"> \'+record.text+\'</span>\';';

+                    $out .= '	//return \'<span><img src="'.DOL_URL_ROOT.'/theme/eldy/img/object_category.png'.'"> <a href="'.DOL_URL_ROOT.'/categories/viewcat.php?type=0&id=\'+record.id+\'">\'+record.text+\'</a></span>\';

+									  	return \'<span><img src="' . DOL_URL_ROOT.'/theme/eldy/img/object_category.png'.'"> \'+record.text+\'</span>\';';

                 } else {

                     $out .= 'return record.text;';

                 }

-                $out .= '};' . "\n";

+                $out .= '};'."\n";

                 $out .= '$(document).ready(function () {

-							$(\'#' . $htmlname . '\').' . $tmpplugin . '({

+							$(\'#' . $htmlname.'\').'.$tmpplugin.'({

 								dir: \'ltr\',

 								// Specify format function for dropdown item

 								formatResult: formatResult,

@@ -5918,13 +5918,13 @@ 
                 // Add other js lib

                 // ...

                 $out .= '$(document).ready(function () {

-							$(\'#' . $htmlname . '\').multiSelect({

+							$(\'#' . $htmlname.'\').multiSelect({

 								containerHTML: \'<div class="multi-select-container">\',

 								menuHTML: \'<div class="multi-select-menu">\',

-								buttonHTML: \'<span class="multi-select-button ' . $morecss . '">\',

+								buttonHTML: \'<span class="multi-select-button ' . $morecss.'">\',

 								menuItemHTML: \'<label class="multi-select-menuitem">\',

 								activeClass: \'multi-select-container--open\',

-								noneText: \'' . $placeholder . '\'

+								noneText: \'' . $placeholder.'\'

 							});

 						})';

             }

@@ -5933,27 +5933,27 @@ 
 

         // Try also magic suggest

 

-        $out .= '<select id="' . $htmlname . '" class="multiselect' . ($morecss ? ' ' . $morecss : '') . '" multiple name="' . $htmlname . '[]"' . ($moreattrib ? ' ' . $moreattrib : '') . ($width ? ' style="width: ' . (preg_match('/%/', $width) ? $width : $width . 'px') . '"' : '') . '>' . "\n";

+        $out .= '<select id="'.$htmlname.'" class="multiselect'.($morecss ? ' '.$morecss : '').'" multiple name="'.$htmlname.'[]"'.($moreattrib ? ' '.$moreattrib : '').($width ? ' style="width: '.(preg_match('/%/', $width) ? $width : $width.'px').'"' : '').'>'."\n";

         if (is_array($array) && !empty($array)) {

             if ($value_as_key)

                 $array = array_combine($array, $array);

 

             if (!empty($array)) {

                 foreach ($array as $key => $value) {

-                    $out .= '<option value="' . $key . '"';

+                    $out .= '<option value="'.$key.'"';

                     if (is_array($selected) && !empty($selected) && in_array($key, $selected) && !empty($key)) {

                         $out .= ' selected';

                     }

                     $out .= '>';

 

                     $newval = ($translate ? $langs->trans($value) : $value);

-                    $newval = ($key_in_label ? $key . ' - ' . $newval : $newval);

+                    $newval = ($key_in_label ? $key.' - '.$newval : $newval);

                     $out .= dol_htmlentitiesbr($newval);

-                    $out .= '</option>' . "\n";

+                    $out .= '</option>'."\n";

                 }

             }

         }

-        $out .= '</select>' . "\n";

+        $out .= '</select>'."\n";

 

         return $out;

     }

@@ -5974,7 +5974,7 @@ 
         if (!empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER))

             return '';

 

-        $tmpvar = "MAIN_SELECTEDFIELDS_" . $varpage;

+        $tmpvar = "MAIN_SELECTEDFIELDS_".$varpage;

         if (!empty($user->conf->$tmpvar)) {

             $tmparray = explode(',', $user->conf->$tmpvar);

             foreach ($array as $key => $val) {

@@ -5996,28 +5996,28 @@ 
               var_dump(array_key_exists('enabled', $val));

               var_dump(!$val['enabled']); */

             if (array_key_exists('enabled', $val) && isset($val['enabled']) && !$val['enabled']) {

-                unset($array[$key]);     // We don't want this field

+                unset($array[$key]); // We don't want this field

                 continue;

             }

             if ($val['label']) {

-                $lis .= '<li><input type="checkbox" id="checkbox' . $key . '" value="' . $key . '"' . (empty($val['checked']) ? '' : ' checked="checked"') . '/><label for="checkbox' . $key . '">' . dol_escape_htmltag($langs->trans($val['label'])) . '</label></li>';

-                $listcheckedstring .= (empty($val['checked']) ? '' : $key . ',');

+                $lis .= '<li><input type="checkbox" id="checkbox'.$key.'" value="'.$key.'"'.(empty($val['checked']) ? '' : ' checked="checked"').'/><label for="checkbox'.$key.'">'.dol_escape_htmltag($langs->trans($val['label'])).'</label></li>';

+                $listcheckedstring .= (empty($val['checked']) ? '' : $key.',');

             }

         }

 

-        $out = '<!-- Component multiSelectArrayWithCheckbox ' . $htmlname . ' -->

+        $out = '<!-- Component multiSelectArrayWithCheckbox '.$htmlname.' -->

 

         <dl class="dropdown">

             <dt>

             <a href="#">

-              ' . img_picto('', 'list') . '

+              ' . img_picto('', 'list').'

             </a>

-            <input type="hidden" class="' . $htmlname . '" name="' . $htmlname . '" value="' . $listcheckedstring . '">

+            <input type="hidden" class="' . $htmlname.'" name="'.$htmlname.'" value="'.$listcheckedstring.'">

             </dt>

             <dd class="dropdowndd">

-                <div class="multiselectcheckbox' . $htmlname . '">

-                    <ul class="ul' . $htmlname . '">

-                    ' . $lis . '

+                <div class="multiselectcheckbox' . $htmlname.'">

+                    <ul class="ul' . $htmlname.'">

+                    ' . $lis.'

                     </ul>

                 </div>

             </dd>

@@ -6025,15 +6025,15 @@ 
 

         <script type="text/javascript">

           jQuery(document).ready(function () {

-              $(\'.multiselectcheckbox' . $htmlname . ' input[type="checkbox"]\').on(\'click\', function () {

+              $(\'.multiselectcheckbox' . $htmlname.' input[type="checkbox"]\').on(\'click\', function () {

                   console.log("A new field was added/removed")

                   $("input:hidden[name=formfilteraction]").val(\'listafterchangingselectedfields\')

                   var title = $(this).val() + ",";

                   if ($(this).is(\':checked\')) {

-                      $(\'.' . $htmlname . '\').val(title + $(\'.' . $htmlname . '\').val());

+                      $(\'.' . $htmlname.'\').val(title + $(\'.'.$htmlname.'\').val());

                   }

                   else {

-                      $(\'.' . $htmlname . '\').val( $(\'.' . $htmlname . '\').val().replace(title, \'\') )

+                      $(\'.' . $htmlname.'\').val( $(\'.'.$htmlname.'\').val().replace(title, \'\') )

                   }

                   // Now, we submit page

                   $(this).parents(\'form:first\').submit();

@@ -6057,7 +6057,7 @@ 
     {

         global $db;

 

-        include_once DOL_DOCUMENT_ROOT . '/categories/class/categorie.class.php';

+        include_once DOL_DOCUMENT_ROOT.'/categories/class/categorie.class.php';

 

         $cat = new Categorie($db);

         $categories = $cat->containing($id, $type);

@@ -6065,12 +6065,12 @@ 
         if ($rendermode == 1) {

             $toprint = array();

             foreach ($categories as $c) {

-                $ways = $c->print_all_ways();       // $ways[0] = "ccc2 >> ccc2a >> ccc2a1" with html formated text

+                $ways = $c->print_all_ways(); // $ways[0] = "ccc2 >> ccc2a >> ccc2a1" with html formated text

                 foreach ($ways as $way) {

-                    $toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories"' . ($c->color ? ' style="background: #' . $c->color . ';"' : ' style="background: #aaa"') . '>' . img_object('', 'category') . ' ' . $way . '</li>';

+                    $toprint[] = '<li class="select2-search-choice-dolibarr noborderoncategories"'.($c->color ? ' style="background: #'.$c->color.';"' : ' style="background: #aaa"').'>'.img_object('', 'category').' '.$way.'</li>';

                 }

             }

-            return '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">' . implode(' ', $toprint) . '</ul></div>';

+            return '<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

         }

 

         if ($rendermode == 0) {

@@ -6106,7 +6106,7 @@ 
             'morehtmlright' => $morehtmlright,

             'compatibleImportElementsList' => & $compatibleImportElementsList,

         );

-        $reshook = $hookmanager->executeHooks('showLinkedObjectBlock', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook

+        $reshook = $hookmanager->executeHooks('showLinkedObjectBlock', $parameters, $object, $action); // Note that $action and $object may have been modified by hook

 

         if (empty($reshook)) {

             $nbofdifferenttypes = count($object->linkedObjects);

@@ -6116,15 +6116,15 @@ 
 

 

             print '<div class="div-table-responsive-no-min">';

-            print '<table class="noborder allwidth" data-block="showLinkedObject" data-element="' . $object->element . '"  data-elementid="' . $object->id . '"   >';

+            print '<table class="noborder allwidth" data-block="showLinkedObject" data-element="'.$object->element.'"  data-elementid="'.$object->id.'"   >';

 

             print '<tr class="liste_titre">';

-            print '<td>' . $langs->trans("Type") . '</td>';

-            print '<td>' . $langs->trans("Ref") . '</td>';

+            print '<td>'.$langs->trans("Type").'</td>';

+            print '<td>'.$langs->trans("Ref").'</td>';

             print '<td align="center"></td>';

-            print '<td align="center">' . $langs->trans("Date") . '</td>';

-            print '<td align="right">' . $langs->trans("AmountHTShort") . '</td>';

-            print '<td align="right">' . $langs->trans("Status") . '</td>';

+            print '<td align="center">'.$langs->trans("Date").'</td>';

+            print '<td align="right">'.$langs->trans("AmountHTShort").'</td>';

+            print '<td align="right">'.$langs->trans("Status").'</td>';

             print '<td></td>';

             print '</tr>';

 

@@ -6142,13 +6142,13 @@ 
                 if ($objecttype != 'supplier_proposal' && preg_match('/^([^_]+)_([^_]+)/i', $objecttype, $regs)) {

                     $element = $regs[1];

                     $subelement = $regs[2];

-                    $tplpath = $element . '/' . $subelement;

+                    $tplpath = $element.'/'.$subelement;

                 }

                 $tplname = 'linkedobjectblock';

 

                 // To work with non standard path

                 if ($objecttype == 'facture') {

-                    $tplpath = 'compta/' . $element;

+                    $tplpath = 'compta/'.$element;

                     if (empty($conf->facture->enabled))

                         continue; // Do not show if module disabled

                 }

@@ -6159,7 +6159,7 @@ 
                         continue; // Do not show if module disabled

                 }

                 else if ($objecttype == 'propal') {

-                    $tplpath = 'comm/' . $element;

+                    $tplpath = 'comm/'.$element;

                     if (empty($conf->propal->enabled))

                         continue; // Do not show if module disabled

                 }

@@ -6197,14 +6197,14 @@ 
 

 

                 // Output template part (modules that overwrite templates must declare this into descriptor)

-                $dirtpls = array_merge($conf->modules_parts['tpl'], array('/' . $tplpath . '/tpl'));

+                $dirtpls = array_merge($conf->modules_parts['tpl'], array('/'.$tplpath.'/tpl'));

                 foreach ($dirtpls as $reldir) {

                     if ($nboftypesoutput == ($nbofdifferenttypes - 1)) {    // No more type to show after

                         global $noMoreLinkedObjectBlockAfter;

                         $noMoreLinkedObjectBlockAfter = 1;

                     }

 

-                    $res = @include dol_buildpath($reldir . '/' . $tplname . '.tpl.php');

+                    $res = @include dol_buildpath($reldir.'/'.$tplname.'.tpl.php');

                     if ($res) {

                         $nboftypesoutput++;

                         break;

@@ -6213,7 +6213,7 @@ 
             }

 

             if (!$nboftypesoutput) {

-                print '<tr><td class="impair opacitymedium" colspan="7">' . $langs->trans("None") . '</td></tr>';

+                print '<tr><td class="impair opacitymedium" colspan="7">'.$langs->trans("None").'</td></tr>';

             }

 

             print '</table>';

@@ -6253,26 +6253,26 @@ 
         if (is_object($object->thirdparty) && !empty($object->thirdparty->id) && $object->thirdparty->id > 0) {

             $listofidcompanytoscan = $object->thirdparty->id;

             if (($object->thirdparty->parent > 0) && !empty($conf->global->THIRDPARTY_INCLUDE_PARENT_IN_LINKTO))

-                $listofidcompanytoscan .= ',' . $object->thirdparty->parent;

+                $listofidcompanytoscan .= ','.$object->thirdparty->parent;

             if (($object->fk_project > 0) && !empty($conf->global->THIRDPARTY_INCLUDE_PROJECT_THIRDPARY_IN_LINKTO)) {

-                include_once DOL_DOCUMENT_ROOT . '/projet/class/project.class.php';

+                include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';

                 $tmpproject = new Project($this->db);

                 $tmpproject->fetch($object->fk_project);

                 if ($tmpproject->socid > 0 && ($tmpproject->socid != $object->thirdparty->id))

-                    $listofidcompanytoscan .= ',' . $tmpproject->socid;

+                    $listofidcompanytoscan .= ','.$tmpproject->socid;

                 unset($tmpproject);

             }

 

             $possiblelinks = array(

-                'propal' => array('enabled' => $conf->propal->enabled, 'perms' => 1, 'label' => 'LinkToProposal', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_client, t.total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "propal as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('propal') . ')'),

-                'order' => array('enabled' => $conf->commande->enabled, 'perms' => 1, 'label' => 'LinkToOrder', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_client, t.total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "commande as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('commande') . ')'),

-                'invoice' => array('enabled' => $conf->facture->enabled, 'perms' => 1, 'label' => 'LinkToInvoice', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_client, t.total as total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "facture as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('invoice') . ')'),

-                'invoice_template' => array('enabled' => $conf->facture->enabled, 'perms' => 1, 'label' => 'LinkToTemplateInvoice', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.titre as ref, t.total as total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "facture_rec as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('invoice') . ')'),

-                'contrat' => array('enabled' => $conf->contrat->enabled, 'perms' => 1, 'label' => 'LinkToContract', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_supplier, '' as total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "contrat as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('contract') . ')'),

-                'fichinter' => array('enabled' => $conf->ficheinter->enabled, 'perms' => 1, 'label' => 'LinkToIntervention', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "fichinter as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('intervention') . ')'),

-                'supplier_proposal' => array('enabled' => $conf->supplier_proposal->enabled, 'perms' => 1, 'label' => 'LinkToSupplierProposal', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, '' as ref_supplier, t.total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "supplier_proposal as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('supplier_proposal') . ')'),

-                'order_supplier' => array('enabled' => $conf->supplier_order->enabled, 'perms' => 1, 'label' => 'LinkToSupplierOrder', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_supplier, t.total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "commande_fournisseur as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('commande_fournisseur') . ')'),

-                'invoice_supplier' => array('enabled' => $conf->supplier_invoice->enabled, 'perms' => 1, 'label' => 'LinkToSupplierInvoice', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_supplier, t.total_ht FROM " . MAIN_DB_PREFIX . "societe as s, " . MAIN_DB_PREFIX . "facture_fourn as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (" . $listofidcompanytoscan . ') AND t.entity IN (' . getEntity('facture_fourn') . ')')

+                'propal' => array('enabled' => $conf->propal->enabled, 'perms' => 1, 'label' => 'LinkToProposal', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_client, t.total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."propal as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('propal').')'),

+                'order' => array('enabled' => $conf->commande->enabled, 'perms' => 1, 'label' => 'LinkToOrder', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_client, t.total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."commande as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('commande').')'),

+                'invoice' => array('enabled' => $conf->facture->enabled, 'perms' => 1, 'label' => 'LinkToInvoice', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_client, t.total as total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."facture as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('invoice').')'),

+                'invoice_template' => array('enabled' => $conf->facture->enabled, 'perms' => 1, 'label' => 'LinkToTemplateInvoice', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.titre as ref, t.total as total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."facture_rec as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('invoice').')'),

+                'contrat' => array('enabled' => $conf->contrat->enabled, 'perms' => 1, 'label' => 'LinkToContract', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_supplier, '' as total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."contrat as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('contract').')'),

+                'fichinter' => array('enabled' => $conf->ficheinter->enabled, 'perms' => 1, 'label' => 'LinkToIntervention', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."fichinter as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('intervention').')'),

+                'supplier_proposal' => array('enabled' => $conf->supplier_proposal->enabled, 'perms' => 1, 'label' => 'LinkToSupplierProposal', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, '' as ref_supplier, t.total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."supplier_proposal as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('supplier_proposal').')'),

+                'order_supplier' => array('enabled' => $conf->supplier_order->enabled, 'perms' => 1, 'label' => 'LinkToSupplierOrder', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_supplier, t.total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."commande_fournisseur as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('commande_fournisseur').')'),

+                'invoice_supplier' => array('enabled' => $conf->supplier_invoice->enabled, 'perms' => 1, 'label' => 'LinkToSupplierInvoice', 'sql' => "SELECT s.rowid as socid, s.nom as name, s.client, t.rowid, t.ref, t.ref_supplier, t.total_ht FROM ".MAIN_DB_PREFIX."societe as s, ".MAIN_DB_PREFIX."facture_fourn as t WHERE t.fk_soc = s.rowid AND t.fk_soc IN (".$listofidcompanytoscan.') AND t.entity IN ('.getEntity('facture_fourn').')')

             );

         }

 

@@ -6281,7 +6281,7 @@ 
         // Can complete the possiblelink array

         $hookmanager->initHooks(array('commonobject'));

         $parameters = array('listofidcompanytoscan' => $listofidcompanytoscan);

-        $reshook = $hookmanager->executeHooks('showLinkToObjectBlock', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook

+        $reshook = $hookmanager->executeHooks('showLinkToObjectBlock', $parameters, $object, $action); // Note that $action and $object may have been modified by hook

         if (empty($reshook)) {

             if (is_array($hookmanager->resArray) && count($hookmanager->resArray)) {

                 $possiblelinks = array_merge($possiblelinks, $hookmanager->resArray);

@@ -6299,7 +6299,7 @@ 
                 continue;

 

             if (!empty($possiblelink['perms']) && (empty($restrictlinksto) || in_array($key, $restrictlinksto)) && (empty($excludelinksto) || !in_array($key, $excludelinksto))) {

-                print '<div id="' . $key . 'list"' . (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER) ? ' style="display:none"' : '') . '>';

+                print '<div id="'.$key.'list"'.(empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER) ? ' style="display:none"' : '').'>';

                 $sql = $possiblelink['sql'];

 

                 $resqllist = $this->db->query($sql);

@@ -6307,34 +6307,34 @@ 
                     $num = $this->db->num_rows($resqllist);

                     $i = 0;

 

-                    print '<br><form action="' . $_SERVER["PHP_SELF"] . '" method="POST" name="formlinked' . $key . '">';

-                    print '<input type="hidden" name="id" value="' . $object->id . '">';

+                    print '<br><form action="'.$_SERVER["PHP_SELF"].'" method="POST" name="formlinked'.$key.'">';

+                    print '<input type="hidden" name="id" value="'.$object->id.'">';

                     print '<input type="hidden" name="action" value="addlink">';

-                    print '<input type="hidden" name="addlink" value="' . $key . '">';

+                    print '<input type="hidden" name="addlink" value="'.$key.'">';

                     print '<table class="noborder">';

                     print '<tr class="liste_titre">';

                     print '<td class="nowrap"></td>';

-                    print '<td align="center">' . $langs->trans("Ref") . '</td>';

-                    print '<td align="left">' . $langs->trans("RefCustomer") . '</td>';

-                    print '<td align="right">' . $langs->trans("AmountHTShort") . '</td>';

-                    print '<td align="left">' . $langs->trans("Company") . '</td>';

+                    print '<td align="center">'.$langs->trans("Ref").'</td>';

+                    print '<td align="left">'.$langs->trans("RefCustomer").'</td>';

+                    print '<td align="right">'.$langs->trans("AmountHTShort").'</td>';

+                    print '<td align="left">'.$langs->trans("Company").'</td>';

                     print '</tr>';

                     while ($i < $num) {

                         $objp = $this->db->fetch_object($resqllist);

 

                         print '<tr class="oddeven">';

                         print '<td aling="left">';

-                        print '<input type="radio" name="idtolinkto" value=' . $objp->rowid . '>';

+                        print '<input type="radio" name="idtolinkto" value='.$objp->rowid.'>';

                         print '</td>';

-                        print '<td align="center">' . $objp->ref . '</td>';

-                        print '<td>' . $objp->ref_client . '</td>';

-                        print '<td align="right">' . price($objp->total_ht) . '</td>';

-                        print '<td>' . $objp->name . '</td>';

+                        print '<td align="center">'.$objp->ref.'</td>';

+                        print '<td>'.$objp->ref_client.'</td>';

+                        print '<td align="right">'.price($objp->total_ht).'</td>';

+                        print '<td>'.$objp->name.'</td>';

                         print '</tr>';

                         $i++;

                     }

                     print '</table>';

-                    print '<div class="center"><input type="submit" class="button valignmiddle" value="' . $langs->trans('ToLink') . '">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<input type="submit" class="button" name="cancel" value="' . $langs->trans('Cancel') . '"></div>';

+                    print '<div class="center"><input type="submit" class="button valignmiddle" value="'.$langs->trans('ToLink').'">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<input type="submit" class="button" name="cancel" value="'.$langs->trans('Cancel').'"></div>';

 

                     print '</form>';

                     $this->db->free($resqllist);

@@ -6348,20 +6348,20 @@ 
 

                 //$linktoelem.=($linktoelem?' &nbsp; ':'');

                 if ($num > 0)

-                    $linktoelemlist .= '<li><a href="#linkto' . $key . '" class="linkto dropdowncloseonclick" rel="' . $key . '">' . $langs->trans($possiblelink['label']) . ' (' . $num . ')</a></li>';

+                    $linktoelemlist .= '<li><a href="#linkto'.$key.'" class="linkto dropdowncloseonclick" rel="'.$key.'">'.$langs->trans($possiblelink['label']).' ('.$num.')</a></li>';

                 //else $linktoelem.=$langs->trans($possiblelink['label']);

                 else

-                    $linktoelemlist .= '<li><span class="linktodisabled">' . $langs->trans($possiblelink['label']) . ' (0)</span></li>';

+                    $linktoelemlist .= '<li><span class="linktodisabled">'.$langs->trans($possiblelink['label']).' (0)</span></li>';

             }

         }

 

         if ($linktoelemlist) {

             $linktoelem = '

     		<dl class="dropdown" id="linktoobjectname">

-    		<dt><a href="#linktoobjectname">' . $langs->trans("LinkTo") . '...</a></dt>

+    		<dt><a href="#linktoobjectname">' . $langs->trans("LinkTo").'...</a></dt>

     		<dd>

     		<div class="multiselectlinkto">

-    		<ul class="ulselectedfields">' . $linktoelemlist . '

+    		<ul class="ulselectedfields">' . $linktoelemlist.'

     		</ul>

     		</div>

     		</dd>

@@ -6408,18 +6408,18 @@ 
 

         $disabled = ($disabled ? ' disabled' : '');

 

-        $resultyesno = '<select class="flat width75" id="' . $htmlname . '" name="' . $htmlname . '"' . $disabled . '>' . "\n";

+        $resultyesno = '<select class="flat width75" id="'.$htmlname.'" name="'.$htmlname.'"'.$disabled.'>'."\n";

         if ($useempty)

-            $resultyesno .= '<option value="-1"' . (($value < 0) ? ' selected' : '') . '>&nbsp;</option>' . "\n";

+            $resultyesno .= '<option value="-1"'.(($value < 0) ? ' selected' : '').'>&nbsp;</option>'."\n";

         if (("$value" == 'yes') || ($value == 1)) {

-            $resultyesno .= '<option value="' . $yes . '" selected>' . $langs->trans("Yes") . '</option>' . "\n";

-            $resultyesno .= '<option value="' . $no . '">' . $langs->trans("No") . '</option>' . "\n";

+            $resultyesno .= '<option value="'.$yes.'" selected>'.$langs->trans("Yes").'</option>'."\n";

+            $resultyesno .= '<option value="'.$no.'">'.$langs->trans("No").'</option>'."\n";

         } else {

             $selected = (($useempty && $value != '0' && $value != 'no') ? '' : ' selected');

-            $resultyesno .= '<option value="' . $yes . '">' . $langs->trans("Yes") . '</option>' . "\n";

-            $resultyesno .= '<option value="' . $no . '"' . $selected . '>' . $langs->trans("No") . '</option>' . "\n";

+            $resultyesno .= '<option value="'.$yes.'">'.$langs->trans("Yes").'</option>'."\n";

+            $resultyesno .= '<option value="'.$no.'"'.$selected.'>'.$langs->trans("No").'</option>'."\n";

         }

-        $resultyesno .= '</select>' . "\n";

+        $resultyesno .= '</select>'."\n";

         return $resultyesno;

     }

 

@@ -6437,12 +6437,12 @@ 
     {

         // phpcs:enable

         $sql = "SELECT rowid, label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "export_model";

-        $sql .= " WHERE type = '" . $type . "'";

+        $sql .= " FROM ".MAIN_DB_PREFIX."export_model";

+        $sql .= " WHERE type = '".$type."'";

         $sql .= " ORDER BY rowid";

         $result = $this->db->query($sql);

         if ($result) {

-            print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

+            print '<select class="flat" id="select_'.$htmlname.'" name="'.$htmlname.'">';

             if ($useempty) {

                 print '<option value="-1">&nbsp;</option>';

             }

@@ -6452,9 +6452,9 @@ 
             while ($i < $num) {

                 $obj = $this->db->fetch_object($result);

                 if ($selected == $obj->rowid) {

-                    print '<option value="' . $obj->rowid . '" selected>';

+                    print '<option value="'.$obj->rowid.'" selected>';

                 } else {

-                    print '<option value="' . $obj->rowid . '">';

+                    print '<option value="'.$obj->rowid.'">';

                 }

                 print $obj->label;

                 print '</option>';

@@ -6497,7 +6497,7 @@ 
         // Add where from hooks

         if (is_object($hookmanager)) {

             $parameters = array();

-            $reshook = $hookmanager->executeHooks('printFieldListWhere', $parameters, $object);    // Note that $action and $object may have been modified by hook

+            $reshook = $hookmanager->executeHooks('printFieldListWhere', $parameters, $object); // Note that $action and $object may have been modified by hook

             $object->next_prev_filter .= $hookmanager->resPrint;

         }

         $previous_ref = $next_ref = '';

@@ -6523,8 +6523,8 @@ 
                 $stringforfirstkey .= ' CTL +';

             }

 

-            $previous_ref = $object->ref_previous ? '<a accesskey="p" title="' . $stringforfirstkey . ' p" class="classfortooltip" href="' . $navurl . '?' . $paramid . '=' . urlencode($object->ref_previous) . $moreparam . '"><i class="fa fa-chevron-left"></i></a>' : '<span class="inactive"><i class="fa fa-chevron-left opacitymedium"></i></span>';

-            $next_ref = $object->ref_next ? '<a accesskey="n" title="' . $stringforfirstkey . ' n" class="classfortooltip" href="' . $navurl . '?' . $paramid . '=' . urlencode($object->ref_next) . $moreparam . '"><i class="fa fa-chevron-right"></i></a>' : '<span class="inactive"><i class="fa fa-chevron-right opacitymedium"></i></span>';

+            $previous_ref = $object->ref_previous ? '<a accesskey="p" title="'.$stringforfirstkey.' p" class="classfortooltip" href="'.$navurl.'?'.$paramid.'='.urlencode($object->ref_previous).$moreparam.'"><i class="fa fa-chevron-left"></i></a>' : '<span class="inactive"><i class="fa fa-chevron-left opacitymedium"></i></span>';

+            $next_ref = $object->ref_next ? '<a accesskey="n" title="'.$stringforfirstkey.' n" class="classfortooltip" href="'.$navurl.'?'.$paramid.'='.urlencode($object->ref_next).$moreparam.'"><i class="fa fa-chevron-right"></i></a>' : '<span class="inactive"><i class="fa fa-chevron-right opacitymedium"></i></span>';

         }

 

         //print "xx".$previous_ref."x".$next_ref;

@@ -6532,30 +6532,30 @@ 
 

         // Right part of banner

         if ($morehtmlright)

-            $ret .= '<div class="inline-block floatleft">' . $morehtmlright . '</div>';

+            $ret .= '<div class="inline-block floatleft">'.$morehtmlright.'</div>';

 

         if ($previous_ref || $next_ref || $morehtml) {

             $ret .= '<div class="pagination paginationref"><ul class="right">';

         }

         if ($morehtml) {

-            $ret .= '<li class="noborder litext">' . $morehtml . '</li>';

+            $ret .= '<li class="noborder litext">'.$morehtml.'</li>';

         }

         if ($shownav && ($previous_ref || $next_ref)) {

-            $ret .= '<li class="pagination">' . $previous_ref . '</li>';

-            $ret .= '<li class="pagination">' . $next_ref . '</li>';

+            $ret .= '<li class="pagination">'.$previous_ref.'</li>';

+            $ret .= '<li class="pagination">'.$next_ref.'</li>';

         }

         if ($previous_ref || $next_ref || $morehtml) {

             $ret .= '</ul></div>';

         }

 

         $parameters = array();

-        $reshook = $hookmanager->executeHooks('moreHtmlStatus', $parameters, $object);    // Note that $action and $object may have been modified by hook

+        $reshook = $hookmanager->executeHooks('moreHtmlStatus', $parameters, $object); // Note that $action and $object may have been modified by hook

         if (empty($reshook))

             $morehtmlstatus .= $hookmanager->resPrint;

         else

             $morehtmlstatus = $hookmanager->resPrint;

         if ($morehtmlstatus)

-            $ret .= '<div class="statusref">' . $morehtmlstatus . '</div>';

+            $ret .= '<div class="statusref">'.$morehtmlstatus.'</div>';

 

         $parameters = array();

         $reshook = $hookmanager->executeHooks('moreHtmlRef', $parameters, $object); // Note that $action and $object may have been modified by hook

@@ -6567,29 +6567,29 @@ 
         // Left part of banner

         if ($morehtmlleft) {

             if ($conf->browser->layout == 'phone')

-                $ret .= '<div class="floatleft">' . $morehtmlleft . '</div>';    // class="center" to have photo in middle

+                $ret .= '<div class="floatleft">'.$morehtmlleft.'</div>'; // class="center" to have photo in middle

             else

-                $ret .= '<div class="inline-block floatleft">' . $morehtmlleft . '</div>';

+                $ret .= '<div class="inline-block floatleft">'.$morehtmlleft.'</div>';

         }

 

         //if ($conf->browser->layout == 'phone') $ret.='<div class="clearboth"></div>';

-        $ret .= '<div class="inline-block floatleft valignmiddle refid' . (($shownav && ($previous_ref || $next_ref)) ? ' refidpadding' : '') . '">';

+        $ret .= '<div class="inline-block floatleft valignmiddle refid'.(($shownav && ($previous_ref || $next_ref)) ? ' refidpadding' : '').'">';

 

         // For thirdparty, contact, user, member, the ref is the id, so we show something else

         if ($object->element == 'societe') {

             $ret .= dol_htmlentities($object->name);

         } else if ($object->element == 'member') {

-            $ret .= $object->ref . '<br>';

+            $ret .= $object->ref.'<br>';

             $fullname = $object->getFullName($langs);

             if ($object->morphy == 'mor' && $object->societe) {

-                $ret .= dol_htmlentities($object->societe) . ((!empty($fullname) && $object->societe != $fullname) ? ' (' . dol_htmlentities($fullname) . ')' : '');

+                $ret .= dol_htmlentities($object->societe).((!empty($fullname) && $object->societe != $fullname) ? ' ('.dol_htmlentities($fullname).')' : '');

             } else {

-                $ret .= dol_htmlentities($fullname) . ((!empty($object->societe) && $object->societe != $fullname) ? ' (' . dol_htmlentities($object->societe) . ')' : '');

+                $ret .= dol_htmlentities($fullname).((!empty($object->societe) && $object->societe != $fullname) ? ' ('.dol_htmlentities($object->societe).')' : '');

             }

         } else if (in_array($object->element, array('contact', 'user', 'usergroup'))) {

             $ret .= dol_htmlentities($object->getFullName($langs));

         } else if (in_array($object->element, array('action', 'agenda'))) {

-            $ret .= $object->ref . '<br>' . $object->label;

+            $ret .= $object->ref.'<br>'.$object->label;

         } else if (in_array($object->element, array('adherent_type'))) {

             $ret .= $object->label;

         } else if ($object->element == 'ecm_directories') {

@@ -6599,7 +6599,7 @@ 
 

 

         if ($morehtmlref) {

-            $ret .= ' ' . $morehtmlref;

+            $ret .= ' '.$morehtmlref;

         }

         $ret .= '</div>';

 

@@ -6632,9 +6632,9 @@ 
         }

 

         // Barcode image

-        $url = DOL_URL_ROOT . '/viewimage.php?modulepart=barcode&generator=' . urlencode($object->barcode_type_coder) . '&code=' . urlencode($object->barcode) . '&encoding=' . urlencode($object->barcode_type_code);

-        $out = '<!-- url barcode = ' . $url . ' -->';

-        $out .= '<img src="' . $url . '">';

+        $url = DOL_URL_ROOT.'/viewimage.php?modulepart=barcode&generator='.urlencode($object->barcode_type_coder).'&code='.urlencode($object->barcode).'&encoding='.urlencode($object->barcode_type_code);

+        $out = '<!-- url barcode = '.$url.' -->';

+        $out .= '<img src="'.$url.'">';

         return $out;

     }

 

@@ -6671,25 +6671,25 @@ 
             $dir = $conf->societe->multidir_output[$entity];

             if (!empty($object->logo)) {

                 if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . getImageFileNameForSize($object->logo, '_mini');             // getImageFileNameForSize include the thumbs

+                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty').'/logos/'.getImageFileNameForSize($object->logo, '_mini'); // getImageFileNameForSize include the thumbs

                 else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . getImageFileNameForSize($object->logo, '_small');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty').'/logos/'.getImageFileNameForSize($object->logo, '_small');

                 else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . $object->logo;

-                $originalfile = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . $object->logo;

+                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty').'/logos/'.$object->logo;

+                $originalfile = get_exdir(0, 0, 0, 0, $object, 'thirdparty').'/logos/'.$object->logo;

             }

             $email = $object->email;

         }

         else if ($modulepart == 'contact') {

-            $dir = $conf->societe->multidir_output[$entity] . '/contact';

+            $dir = $conf->societe->multidir_output[$entity].'/contact';

             if (!empty($object->photo)) {

                 if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . getImageFileNameForSize($object->photo, '_mini');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'contact').'/photos/'.getImageFileNameForSize($object->photo, '_mini');

                 else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . getImageFileNameForSize($object->photo, '_small');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'contact').'/photos/'.getImageFileNameForSize($object->photo, '_small');

                 else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . $object->photo;

-                $originalfile = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . $object->photo;

+                    $file = get_exdir(0, 0, 0, 0, $object, 'contact').'/photos/'.$object->photo;

+                $originalfile = get_exdir(0, 0, 0, 0, $object, 'contact').'/photos/'.$object->photo;

             }

             $email = $object->email;

             $capture = 'user';

@@ -6698,15 +6698,15 @@ 
             $dir = $conf->user->dir_output;

             if (!empty($object->photo)) {

                 if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . $object->id . '/' . getImageFileNameForSize($object->photo, '_mini');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'user').$object->id.'/'.getImageFileNameForSize($object->photo, '_mini');

                 else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . $object->id . '/' . getImageFileNameForSize($object->photo, '_small');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'user').$object->id.'/'.getImageFileNameForSize($object->photo, '_small');

                 else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . '/' . $object->id . '/' . $object->photo;

-                $originalfile = get_exdir(0, 0, 0, 0, $object, 'user') . '/' . $object->id . '/' . $object->photo;

+                    $file = get_exdir(0, 0, 0, 0, $object, 'user').'/'.$object->id.'/'.$object->photo;

+                $originalfile = get_exdir(0, 0, 0, 0, $object, 'user').'/'.$object->id.'/'.$object->photo;

             }

             if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS))

-                $altfile = $object->id . ".jpg"; // For backward compatibility

+                $altfile = $object->id.".jpg"; // For backward compatibility

             $email = $object->email;

             $capture = 'user';

         }

@@ -6714,15 +6714,15 @@ 
             $dir = $conf->adherent->dir_output;

             if (!empty($object->photo)) {

                 if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . getImageFileNameForSize($object->photo, '_mini');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'member').'photos/'.getImageFileNameForSize($object->photo, '_mini');

                 else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . getImageFileNameForSize($object->photo, '_small');

+                    $file = get_exdir(0, 0, 0, 0, $object, 'member').'photos/'.getImageFileNameForSize($object->photo, '_small');

                 else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . $object->photo;

-                $originalfile = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . $object->photo;

+                    $file = get_exdir(0, 0, 0, 0, $object, 'member').'photos/'.$object->photo;

+                $originalfile = get_exdir(0, 0, 0, 0, $object, 'member').'photos/'.$object->photo;

             }

             if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS))

-                $altfile = $object->id . ".jpg"; // For backward compatibility

+                $altfile = $object->id.".jpg"; // For backward compatibility

             $email = $object->email;

             $capture = 'user';

         }

@@ -6731,15 +6731,15 @@ 
             $dir = $conf->$modulepart->dir_output;

             if (!empty($object->photo)) {

                 if ((string) $imagesize == 'mini')

-                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . getImageFileNameForSize($object->photo, '_mini');

+                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart).'photos/'.getImageFileNameForSize($object->photo, '_mini');

                 else if ((string) $imagesize == 'small')

-                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . getImageFileNameForSize($object->photo, '_small');

+                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart).'photos/'.getImageFileNameForSize($object->photo, '_small');

                 else

-                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . $object->photo;

-                $originalfile = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . $object->photo;

+                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart).'photos/'.$object->photo;

+                $originalfile = get_exdir($id, 2, 0, 0, $object, $modulepart).'photos/'.$object->photo;

             }

             if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS))

-                $altfile = $object->id . ".jpg"; // For backward compatibility

+                $altfile = $object->id.".jpg"; // For backward compatibility

             $email = $object->email;

         }

 

@@ -6747,27 +6747,27 @@ 
             $capture = $forcecapture;

 

         if ($dir) {

-            if ($file && file_exists($dir . "/" . $file)) {

+            if ($file && file_exists($dir."/".$file)) {

                 if ($addlinktofullsize) {

-                    $urladvanced = getAdvancedPreviewUrl($modulepart, $originalfile, 0, '&entity=' . $entity);

+                    $urladvanced = getAdvancedPreviewUrl($modulepart, $originalfile, 0, '&entity='.$entity);

                     if ($urladvanced)

-                        $ret .= '<a href="' . $urladvanced . '">';

+                        $ret .= '<a href="'.$urladvanced.'">';

                     else

-                        $ret .= '<a href="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($originalfile) . '&cache=' . $cache . '">';

+                        $ret .= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$entity.'&file='.urlencode($originalfile).'&cache='.$cache.'">';

                 }

-                $ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="Photo" id="photologo' . (preg_replace('/[^a-z]/i', '_', $file)) . '" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($file) . '&cache=' . $cache . '">';

+                $ret .= '<img class="photo'.$modulepart.($cssclass ? ' '.$cssclass : '').'" alt="Photo" id="photologo'.(preg_replace('/[^a-z]/i', '_', $file)).'" '.($width ? ' width="'.$width.'"' : '').($height ? ' height="'.$height.'"' : '').' src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$entity.'&file='.urlencode($file).'&cache='.$cache.'">';

                 if ($addlinktofullsize)

                     $ret .= '</a>';

             }

-            else if ($altfile && file_exists($dir . "/" . $altfile)) {

+            else if ($altfile && file_exists($dir."/".$altfile)) {

                 if ($addlinktofullsize) {

-                    $urladvanced = getAdvancedPreviewUrl($modulepart, $originalfile, 0, '&entity=' . $entity);

+                    $urladvanced = getAdvancedPreviewUrl($modulepart, $originalfile, 0, '&entity='.$entity);

                     if ($urladvanced)

-                        $ret .= '<a href="' . $urladvanced . '">';

+                        $ret .= '<a href="'.$urladvanced.'">';

                     else

-                        $ret .= '<a href="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($originalfile) . '&cache=' . $cache . '">';

+                        $ret .= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$entity.'&file='.urlencode($originalfile).'&cache='.$cache.'">';

                 }

-                $ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="Photo alt" id="photologo' . (preg_replace('/[^a-z]/i', '_', $file)) . '" class="' . $cssclass . '" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($altfile) . '&cache=' . $cache . '">';

+                $ret .= '<img class="photo'.$modulepart.($cssclass ? ' '.$cssclass : '').'" alt="Photo alt" id="photologo'.(preg_replace('/[^a-z]/i', '_', $file)).'" class="'.$cssclass.'" '.($width ? ' width="'.$width.'"' : '').($height ? ' height="'.$height.'"' : '').' src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$entity.'&file='.urlencode($altfile).'&cache='.$cache.'">';

                 if ($addlinktofullsize)

                     $ret .= '</a>';

             }

@@ -6791,10 +6791,10 @@ 
                     $ret .= '<!-- Put link to gravatar -->';

                     //$defaultimg=urlencode(dol_buildpath($nophoto,3));

                     $defaultimg = 'mm';

-                    $ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="Gravatar avatar" title="' . $email . ' Gravatar avatar" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="https://www.gravatar.com/avatar/' . dol_hash(strtolower(trim($email)), 3) . '?s=' . $width . '&d=' . $defaultimg . '">'; // gravatar need md5 hash

+                    $ret .= '<img class="photo'.$modulepart.($cssclass ? ' '.$cssclass : '').'" alt="Gravatar avatar" title="'.$email.' Gravatar avatar" '.($width ? ' width="'.$width.'"' : '').($height ? ' height="'.$height.'"' : '').' src="https://www.gravatar.com/avatar/'.dol_hash(strtolower(trim($email)), 3).'?s='.$width.'&d='.$defaultimg.'">'; // gravatar need md5 hash

                 } else {

                     //$ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="No photo" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="' . DOL_URL_ROOT . $nophoto . '">';

-                    $ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="No photo" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="' . DOL_BASE_URI . $nophoto . '">';

+                    $ret .= '<img class="photo'.$modulepart.($cssclass ? ' '.$cssclass : '').'" alt="No photo" '.($width ? ' width="'.$width.'"' : '').($height ? ' height="'.$height.'"' : '').' src="'.DOL_BASE_URI.$nophoto.'">';

                 }

             }

 

@@ -6804,13 +6804,13 @@ 
                 }

                 $ret .= '<table class="nobordernopadding centpercent">';

                 if ($object->photo) {

-                    $ret .= '<tr><td><input type="checkbox" class="flat photodelete" name="deletephoto" id="photodelete"> ' . $langs->trans("Delete") . '<br><br></td></tr>';

+                    $ret .= '<tr><td><input type="checkbox" class="flat photodelete" name="deletephoto" id="photodelete"> '.$langs->trans("Delete").'<br><br></td></tr>';

                 }

-                $ret .= '<tr><td class="tdoverflow"><input type="file" class="flat maxwidth200onsmartphone" name="photo" id="photoinput"' . ($capture ? ' capture="' . $capture . '"' : '') . '></td></tr>';

+                $ret .= '<tr><td class="tdoverflow"><input type="file" class="flat maxwidth200onsmartphone" name="photo" id="photoinput"'.($capture ? ' capture="'.$capture.'"' : '').'></td></tr>';

                 $ret .= '</table>';

             }

         } else

-            dol_print_error('', 'Call of showphoto with wrong parameters modulepart=' . $modulepart);

+            dol_print_error('', 'Call of showphoto with wrong parameters modulepart='.$modulepart);

 

         return $ret;

     }

@@ -6853,37 +6853,37 @@ 
         if (!empty($conf->multicompany->enabled) && $conf->entity == 1 && $user->admin && !$user->entity) {

             $sql .= ", e.label";

         }

-        $sql .= " FROM " . MAIN_DB_PREFIX . "usergroup as ug ";

+        $sql .= " FROM ".MAIN_DB_PREFIX."usergroup as ug ";

         if (!empty($conf->multicompany->enabled) && $conf->entity == 1 && $user->admin && !$user->entity) {

-            $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "entity as e ON e.rowid=ug.entity";

+            $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."entity as e ON e.rowid=ug.entity";

             if ($force_entity)

-                $sql .= " WHERE ug.entity IN (0," . $force_entity . ")";

+                $sql .= " WHERE ug.entity IN (0,".$force_entity.")";

             else

                 $sql .= " WHERE ug.entity IS NOT NULL";

         }

         else {

-            $sql .= " WHERE ug.entity IN (0," . $conf->entity . ")";

+            $sql .= " WHERE ug.entity IN (0,".$conf->entity.")";

         }

         if (is_array($exclude) && $excludeGroups)

-            $sql .= " AND ug.rowid NOT IN ('" . $excludeGroups . "')";

+            $sql .= " AND ug.rowid NOT IN ('".$excludeGroups."')";

         if (is_array($include) && $includeGroups)

-            $sql .= " AND ug.rowid IN ('" . $includeGroups . "')";

+            $sql .= " AND ug.rowid IN ('".$includeGroups."')";

         $sql .= " ORDER BY ug.nom ASC";

 

-        dol_syslog(get_class($this) . "::select_dolgroups", LOG_DEBUG);

+        dol_syslog(get_class($this)."::select_dolgroups", LOG_DEBUG);

         $resql = $this->db->query($sql);

         if ($resql) {

             // Enhance with select2

-            include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

+            include_once DOL_DOCUMENT_ROOT.'/core/lib/ajax.lib.php';

             $out .= ajax_combobox($htmlname);

 

-            $out .= '<select class="flat minwidth200" id="' . $htmlname . '" name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . ' ' . ($disabled ? ' disabled' : '') . '>';

+            $out .= '<select class="flat minwidth200" id="'.$htmlname.'" name="'.$htmlname.($multiple ? '[]' : '').'" '.($multiple ? 'multiple' : '').' '.($disabled ? ' disabled' : '').'>';

 

             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

                 if ($show_empty && !$multiple)

-                    $out .= '<option value="-1"' . (in_array(-1, $selected) ? ' selected' : '') . '>&nbsp;</option>' . "\n";

+                    $out .= '<option value="-1"'.(in_array(-1, $selected) ? ' selected' : '').'>&nbsp;</option>'."\n";

 

                 while ($i < $num) {

                     $obj = $this->db->fetch_object($resql);

@@ -6891,17 +6891,17 @@ 
                     if (is_array($enableonly) && count($enableonly) && !in_array($obj->rowid, $enableonly))

                         $disableline = 1;

 

-                    $out .= '<option value="' . $obj->rowid . '"';

+                    $out .= '<option value="'.$obj->rowid.'"';

                     if ($disableline)

                         $out .= ' disabled';

-                    if ((is_object($selected[0]) && $selected[0]->id == $obj->rowid) || (!is_object($selected[0]) && in_array($obj->rowid, $selected) )) {

+                    if ((is_object($selected[0]) && $selected[0]->id == $obj->rowid) || (!is_object($selected[0]) && in_array($obj->rowid, $selected))) {

                         $out .= ' selected';

                     }

                     $out .= '>';

 

                     $out .= $obj->name;

                     if (!empty($conf->multicompany->enabled) && empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE) && $conf->entity == 1) {

-                        $out .= " (" . $obj->label . ")";

+                        $out .= " (".$obj->label.")";

                     }

 

                     $out .= '</option>';

@@ -6909,8 +6909,8 @@ 
                 }

             } else {

                 if ($show_empty)

-                    $out .= '<option value="-1"' . (in_array(-1, $selected) ? ' selected' : '') . '></option>' . "\n";

-                $out .= '<option value="" disabled>' . $langs->trans("NoUserGroupDefined") . '</option>';

+                    $out .= '<option value="-1"'.(in_array(-1, $selected) ? ' selected' : '').'></option>'."\n";

+                $out .= '<option value="" disabled>'.$langs->trans("NoUserGroupDefined").'</option>';

             }

             $out .= '</select>';

         }

@@ -6931,8 +6931,8 @@ 
         global $conf, $langs;

 

         $out = '<div class="nowrap">';

-        $out .= '<input type="image" class="liste_titre" name="button_search" src="' . img_picto($langs->trans("Search"), 'search.png', '', '', 1) . '" value="' . dol_escape_htmltag($langs->trans("Search")) . '" title="' . dol_escape_htmltag($langs->trans("Search")) . '">';

-        $out .= '<input type="image" class="liste_titre" name="button_removefilter" src="' . img_picto($langs->trans("Search"), 'searchclear.png', '', '', 1) . '" value="' . dol_escape_htmltag($langs->trans("RemoveFilter")) . '" title="' . dol_escape_htmltag($langs->trans("RemoveFilter")) . '">';

+        $out .= '<input type="image" class="liste_titre" name="button_search" src="'.img_picto($langs->trans("Search"), 'search.png', '', '', 1).'" value="'.dol_escape_htmltag($langs->trans("Search")).'" title="'.dol_escape_htmltag($langs->trans("Search")).'">';

+        $out .= '<input type="image" class="liste_titre" name="button_removefilter" src="'.img_picto($langs->trans("Search"), 'searchclear.png', '', '', 1).'" value="'.dol_escape_htmltag($langs->trans("RemoveFilter")).'" title="'.dol_escape_htmltag($langs->trans("RemoveFilter")).'">';

         $out .= '</div>';

 

         return $out;

@@ -6957,12 +6957,12 @@ 
             	$("#checkallactions").click(function() {

                     if($(this).is(\':checked\')){

                         console.log("We check all");

-                		$(".' . $cssclass . '").prop(\'checked\', true).trigger(\'change\');

+                		$(".' . $cssclass.'").prop(\'checked\', true).trigger(\'change\');

                     }

                     else

                     {

                         console.log("We uncheck all");

-                		$(".' . $cssclass . '").prop(\'checked\', false).trigger(\'change\');

+                		$(".' . $cssclass.'").prop(\'checked\', false).trigger(\'change\');

                     }' . "\n";

         if ($calljsfunction)

             $out .= 'if (typeof initCheckForSelect == \'function\') { initCheckForSelect(0); } else { console.log("No function initCheckForSelect found. Call won\'t be done."); }';

@@ -7011,64 +7011,64 @@ 
     {

         global $db, $conf, $langs, $user;

 

-        $sql = 'SELECT rowid, label FROM ' . MAIN_DB_PREFIX . 'c_exp_tax_cat WHERE active = 1';

-        $sql .= ' AND entity IN (0,' . getEntity('exp_tax_cat') . ')';

+        $sql = 'SELECT rowid, label FROM '.MAIN_DB_PREFIX.'c_exp_tax_cat WHERE active = 1';

+        $sql .= ' AND entity IN (0,'.getEntity('exp_tax_cat').')';

         if (!empty($excludeid))

-            $sql .= ' AND rowid NOT IN (' . implode(',', $excludeid) . ')';

+            $sql .= ' AND rowid NOT IN ('.implode(',', $excludeid).')';

         $sql .= ' ORDER BY label';

 

         $resql = $db->query($sql);

         if ($resql) {

-            $out = '<select id="select_' . $htmlname . '" name="' . $htmlname . '" class="' . $htmlname . ' flat minwidth75imp">';

+            $out = '<select id="select_'.$htmlname.'" name="'.$htmlname.'" class="'.$htmlname.' flat minwidth75imp">';

             if ($useempty)

                 $out .= '<option value="0">&nbsp;</option>';

 

             while ($obj = $db->fetch_object($resql)) {

-                $out .= '<option ' . ($selected == $obj->rowid ? 'selected="selected"' : '') . ' value="' . $obj->rowid . '">' . $langs->trans($obj->label) . '</option>';

+                $out .= '<option '.($selected == $obj->rowid ? 'selected="selected"' : '').' value="'.$obj->rowid.'">'.$langs->trans($obj->label).'</option>';

             }

             $out .= '</select>';

             if (!empty($htmlname) && $user->admin)

-                $out .= ' ' . info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+                $out .= ' '.info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

 

             if (!empty($target)) {

-                $sql = "SELECT c.id FROM " . MAIN_DB_PREFIX . "c_type_fees as c WHERE c.code = 'EX_KME' AND c.active = 1";

+                $sql = "SELECT c.id FROM ".MAIN_DB_PREFIX."c_type_fees as c WHERE c.code = 'EX_KME' AND c.active = 1";

                 $resql = $db->query($sql);

                 if ($resql) {

                     if ($db->num_rows($resql) > 0) {

                         $obj = $db->fetch_object($resql);

                         $out .= '<script type="text/javascript">

 							$(function() {

-								$("select[name=' . $target . ']").on("change", function() {

+								$("select[name=' . $target.']").on("change", function() {

 									var current_val = $(this).val();

-									if (current_val == ' . $obj->id . ') {';

+									if (current_val == ' . $obj->id.') {';

                         if (!empty($default_selected) || !empty($selected))

-                            $out .= '$("select[name=' . $htmlname . ']").val("' . ($default_selected > 0 ? $default_selected : $selected) . '");';

+                            $out .= '$("select[name='.$htmlname.']").val("'.($default_selected > 0 ? $default_selected : $selected).'");';

 

                         $out .= '

-										$("select[name=' . $htmlname . ']").change();

+										$("select[name=' . $htmlname.']").change();

 									}

 								});

 

-								$("select[name=' . $htmlname . ']").change(function() {

+								$("select[name=' . $htmlname.']").change(function() {

 

-									if ($("select[name=' . $target . ']").val() == ' . $obj->id . ') {

+									if ($("select[name=' . $target.']").val() == '.$obj->id.') {

 										// get price of kilometer to fill the unit price

-										var data = ' . json_encode($params) . ';

+										var data = ' . json_encode($params).';

 										data.fk_c_exp_tax_cat = $(this).val();

 

 										$.ajax({

 											method: "POST",

 											dataType: "json",

 											data: data,

-											url: "' . (DOL_URL_ROOT . '/expensereport/ajax/ajaxik.php') . '",

+											url: "' . (DOL_URL_ROOT.'/expensereport/ajax/ajaxik.php').'",

 										}).done(function( data, textStatus, jqXHR ) {

 											console.log(data);

 											if (typeof data.up != "undefined") {

 												$("input[name=value_unit]").val(data.up);

-												$("select[name=' . $htmlname . ']").attr("title", data.title);

+												$("select[name=' . $htmlname.']").attr("title", data.title);

 											} else {

 												$("input[name=value_unit]").val("");

-												$("select[name=' . $htmlname . ']").attr("title", "");

+												$("select[name=' . $htmlname.']").attr("title", "");

 											}

 										});

 									}

@@ -7098,17 +7098,17 @@ 
     {

         global $db, $conf, $langs;

 

-        $sql = 'SELECT rowid, range_ik FROM ' . MAIN_DB_PREFIX . 'c_exp_tax_range';

-        $sql .= ' WHERE entity = ' . $conf->entity . ' AND active = 1';

+        $sql = 'SELECT rowid, range_ik FROM '.MAIN_DB_PREFIX.'c_exp_tax_range';

+        $sql .= ' WHERE entity = '.$conf->entity.' AND active = 1';

 

         $resql = $db->query($sql);

         if ($resql) {

-            $out = '<select id="select_' . $htmlname . '" name="' . $htmlname . '" class="' . $htmlname . ' flat minwidth75imp">';

+            $out = '<select id="select_'.$htmlname.'" name="'.$htmlname.'" class="'.$htmlname.' flat minwidth75imp">';

             if ($useempty)

                 $out .= '<option value="0"></option>';

 

             while ($obj = $db->fetch_object($resql)) {

-                $out .= '<option ' . ($selected == $obj->rowid ? 'selected="selected"' : '') . ' value="' . $obj->rowid . '">' . price($obj->range_ik, 0, $langs, 1, 0) . '</option>';

+                $out .= '<option '.($selected == $obj->rowid ? 'selected="selected"' : '').' value="'.$obj->rowid.'">'.price($obj->range_ik, 0, $langs, 1, 0).'</option>';

             }

             $out .= '</select>';

         } else {

@@ -7132,16 +7132,16 @@ 
     {

         global $db, $langs;

 

-        $sql = 'SELECT id, code, label FROM ' . MAIN_DB_PREFIX . 'c_type_fees';

+        $sql = 'SELECT id, code, label FROM '.MAIN_DB_PREFIX.'c_type_fees';

         $sql .= ' WHERE active = 1';

 

         $resql = $db->query($sql);

         if ($resql) {

-            $out = '<select id="select_' . $htmlname . '" name="' . $htmlname . '" class="' . $htmlname . ' flat minwidth75imp">';

+            $out = '<select id="select_'.$htmlname.'" name="'.$htmlname.'" class="'.$htmlname.' flat minwidth75imp">';

             if ($useempty)

                 $out .= '<option value="0"></option>';

             if ($allchoice)

-                $out .= '<option value="-1">' . $langs->trans('AllExpenseReport') . '</option>';

+                $out .= '<option value="-1">'.$langs->trans('AllExpenseReport').'</option>';

 

             $field = 'code';

             if ($useid)

@@ -7149,7 +7149,7 @@ 
 

             while ($obj = $db->fetch_object($resql)) {

                 $key = $langs->trans($obj->code);

-                $out .= '<option ' . ($selected == $obj->{$field} ? 'selected="selected"' : '') . ' value="' . $obj->{$field} . '">' . ($key != $obj->code ? $key : $obj->label) . '</option>';

+                $out .= '<option '.($selected == $obj->{$field} ? 'selected="selected"' : '').' value="'.$obj->{$field}.'">'.($key != $obj->code ? $key : $obj->label).'</option>';

             }

             $out .= '</select>';

         } else {

Braces +1254 added lines, -937 removed lines

@@ -112,22 +112,24 @@ 
             if (!empty($perm)) {

                 $tmp = explode(':', $typeofdata);

                 $ret .= '<div class="editkey_' . $tmp[0] . (!empty($tmp[1]) ? ' ' . $tmp[1] : '') . '" id="' . $htmlname . '">';

-                if ($fieldrequired)

-                    $ret .= '<span class="fieldrequired">';

+                if ($fieldrequired) {
+                                    $ret .= '<span class="fieldrequired">';
+                }
                 $ret .= $langs->trans($text);

-                if ($fieldrequired)

-                    $ret .= '</span>';

+                if ($fieldrequired) {
+                                    $ret .= '</span>';
+                }
                 $ret .= '</div>' . "\n";

-            }

-            else {

-                if ($fieldrequired)

-                    $ret .= '<span class="fieldrequired">';

+            } else {

+                if ($fieldrequired) {
+                                    $ret .= '<span class="fieldrequired">';
+                }
                 $ret .= $langs->trans($text);

-                if ($fieldrequired)

-                    $ret .= '</span>';

+                if ($fieldrequired) {
+                                    $ret .= '</span>';
+                }
             }

-        }

-        else {

+        } else {

             if (empty($notabletag) && GETPOST('action', 'aZ09') != 'edit' . $htmlname && $perm) {

                 $ret .= '<table class="nobordernopadding" width="100%"><tr><td class="nowrap">';

             }

@@ -192,8 +194,9 @@ 
         $ret = '';

 

         // Check parameters

-        if (empty($typeofdata))

-            return 'ErrorBadParameter';

+        if (empty($typeofdata)) {
+                    return 'ErrorBadParameter';
+        }
 

         // When option to edit inline is activated

         if (!empty($conf->global->MAIN_USE_JQUERY_JEDITABLE) && !preg_match('/^select;|datehourpicker/', $typeofdata)) { // TODO add jquery timepicker

@@ -205,10 +208,12 @@ 
                 $ret .= '<input type="hidden" name="action" value="set' . $htmlname . '">';

                 $ret .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

                 $ret .= '<input type="hidden" name="' . $paramid . '" value="' . $object->id . '">';

-                if (empty($notabletag))

-                    $ret .= '<table class="nobordernopadding centpercent" cellpadding="0" cellspacing="0">';

-                if (empty($notabletag))

-                    $ret .= '<tr><td>';

+                if (empty($notabletag)) {
+                                    $ret .= '<table class="nobordernopadding centpercent" cellpadding="0" cellspacing="0">';
+                }
+                if (empty($notabletag)) {
+                                    $ret .= '<tr><td>';
+                }
                 if (preg_match('/^(string|email)/', $typeofdata)) {

                     $tmp = explode(':', $typeofdata);

                     $ret .= '<input type="text" id="' . $htmlname . '" name="' . $htmlname . '" value="' . ($editvalue ? $editvalue : $value) . '"' . ($tmp[1] ? ' size="' . $tmp[1] . '"' : '') . '>';

@@ -247,35 +252,39 @@ 
                     $doleditor = new DolEditor($htmlname, ($editvalue ? $editvalue : $value), ($tmp[2] ? $tmp[2] : ''), ($tmp[3] ? $tmp[3] : '100'), ($tmp[1] ? $tmp[1] : 'dolibarr_notes'), 'In', ($tmp[5] ? $tmp[5] : 0), true, true, ($tmp[6] ? $tmp[6] : '20'), ($tmp[7] ? $tmp[7] : '100'));

                     $ret .= $doleditor->Create(1);

                 }

-                if (empty($notabletag))

-                    $ret .= '</td>';

+                if (empty($notabletag)) {
+                                    $ret .= '</td>';
+                }
 

-                if (empty($notabletag))

-                    $ret .= '<td align="left">';

+                if (empty($notabletag)) {
+                                    $ret .= '<td align="left">';
+                }
                 //else $ret.='<div class="clearboth"></div>';

                 $ret .= '<input type="submit" class="button' . (empty($notabletag) ? '' : ' ') . '" name="modify" value="' . $langs->trans("Modify") . '">';

-                if (preg_match('/ckeditor|textarea/', $typeofdata) && empty($notabletag))

-                    $ret .= '<br>' . "\n";

+                if (preg_match('/ckeditor|textarea/', $typeofdata) && empty($notabletag)) {
+                                    $ret .= '<br>' . "\n";
+                }
                 $ret .= '<input type="submit" class="button' . (empty($notabletag) ? '' : ' ') . '" name="cancel" value="' . $langs->trans("Cancel") . '">';

-                if (empty($notabletag))

-                    $ret .= '</td>';

+                if (empty($notabletag)) {
+                                    $ret .= '</td>';
+                }
 

-                if (empty($notabletag))

-                    $ret .= '</tr></table>' . "\n";

+                if (empty($notabletag)) {
+                                    $ret .= '</tr></table>' . "\n";
+                }
                 $ret .= '</form>' . "\n";

-            }

-            else {

-                if (preg_match('/^(email)/', $typeofdata))

-                    $ret .= dol_print_email($value, 0, 0, 0, 0, 1);

-                elseif (preg_match('/^(amount|numeric)/', $typeofdata))

-                    $ret .= ($value != '' ? price($value, '', $langs, 0, -1, -1, $conf->currency) : '');

-                elseif (preg_match('/^text/', $typeofdata) || preg_match('/^note/', $typeofdata))

-                    $ret .= dol_htmlentitiesbr($value);

-                elseif ($typeofdata == 'day' || $typeofdata == 'datepicker')

-                    $ret .= dol_print_date($value, 'day');

-                elseif ($typeofdata == 'dayhour' || $typeofdata == 'datehourpicker')

-                    $ret .= dol_print_date($value, 'dayhour');

-                else if (preg_match('/^select;/', $typeofdata)) {

+            } else {

+                if (preg_match('/^(email)/', $typeofdata)) {
+                                    $ret .= dol_print_email($value, 0, 0, 0, 0, 1);
+                } elseif (preg_match('/^(amount|numeric)/', $typeofdata)) {
+                                    $ret .= ($value != '' ? price($value, '', $langs, 0, -1, -1, $conf->currency) : '');
+                } elseif (preg_match('/^text/', $typeofdata) || preg_match('/^note/', $typeofdata)) {
+                                    $ret .= dol_htmlentitiesbr($value);
+                } elseif ($typeofdata == 'day' || $typeofdata == 'datepicker') {
+                                    $ret .= dol_print_date($value, 'day');
+                } elseif ($typeofdata == 'dayhour' || $typeofdata == 'datehourpicker') {
+                                    $ret .= dol_print_date($value, 'dayhour');
+                } else if (preg_match('/^select;/', $typeofdata)) {

                     $arraydata = explode(',', preg_replace('/^select;/', '', $typeofdata));

                     foreach ($arraydata as $val) {

                         $tmp = explode(':', $val);

@@ -290,8 +299,9 @@ 
                         $tmpcontent = $firstline . ((strlen($firstline) != strlen($tmpcontent)) ? '...' : '');

                     }

                     $ret .= $tmpcontent;

-                } else

-                    $ret .= $value;

+                } else {
+                                    $ret .= $value;
+                }
 

                 if ($formatfunc && method_exists($object, $formatfunc)) {

                     $ret = $object->$formatfunc($ret);

@@ -321,12 +331,13 @@ 
         $out = '';

 

         // Check parameters

-        if (preg_match('/^text/', $inputType))

-            $value = dol_nl2br($value);

-        else if (preg_match('/^numeric/', $inputType))

-            $value = price($value);

-        else if ($inputType == 'day' || $inputType == 'datepicker')

-            $value = dol_print_date($value, 'day');

+        if (preg_match('/^text/', $inputType)) {
+                    $value = dol_nl2br($value);
+        } else if (preg_match('/^numeric/', $inputType)) {
+                    $value = price($value);
+        } else if ($inputType == 'day' || $inputType == 'datepicker') {
+                    $value = dol_print_date($value, 'day');
+        }
 

         if ($condition) {

             $element = false;

@@ -351,32 +362,35 @@ 
             if (preg_match('/^(string|email|numeric)/', $inputType)) {

                 $tmp = explode(':', $inputType);

                 $inputType = $tmp[0];

-                if (!empty($tmp[1]))

-                    $inputOption = $tmp[1];

-                if (!empty($tmp[2]))

-                    $savemethod = $tmp[2];

+                if (!empty($tmp[1])) {
+                                    $inputOption = $tmp[1];
+                }
+                if (!empty($tmp[2])) {
+                                    $savemethod = $tmp[2];
+                }
                 $out .= '<input id="width_' . $htmlname . '" value="' . $inputOption . '" type="hidden"/>' . "\n";

-            }

-            else if ((preg_match('/^day$/', $inputType)) || (preg_match('/^datepicker/', $inputType)) || (preg_match('/^datehourpicker/', $inputType))) {

+            } else if ((preg_match('/^day$/', $inputType)) || (preg_match('/^datepicker/', $inputType)) || (preg_match('/^datehourpicker/', $inputType))) {

                 $tmp = explode(':', $inputType);

                 $inputType = $tmp[0];

-                if (!empty($tmp[1]))

-                    $inputOption = $tmp[1];

-                if (!empty($tmp[2]))

-                    $savemethod = $tmp[2];

+                if (!empty($tmp[1])) {
+                                    $inputOption = $tmp[1];
+                }
+                if (!empty($tmp[2])) {
+                                    $savemethod = $tmp[2];
+                }
 

                 $out .= '<input id="timestamp" type="hidden"/>' . "\n"; // Use for timestamp format

-            }

-            else if (preg_match('/^(select|autocomplete)/', $inputType)) {

+            } else if (preg_match('/^(select|autocomplete)/', $inputType)) {

                 $tmp = explode(':', $inputType);

                 $inputType = $tmp[0];

                 $loadmethod = $tmp[1];

-                if (!empty($tmp[2]))

-                    $savemethod = $tmp[2];

-                if (!empty($tmp[3]))

-                    $button_only = true;

-            }

-            else if (preg_match('/^textarea/', $inputType)) {

+                if (!empty($tmp[2])) {
+                                    $savemethod = $tmp[2];
+                }
+                if (!empty($tmp[3])) {
+                                    $button_only = true;
+                }
+            } else if (preg_match('/^textarea/', $inputType)) {

                 $tmp = explode(':', $inputType);

                 $inputType = $tmp[0];

                 $rows = (empty($tmp[1]) ? '8' : $tmp[1]);

@@ -385,12 +399,15 @@ 
                 $tmp = explode(':', $inputType);

                 $inputType = $tmp[0];

                 $toolbar = $tmp[1];

-                if (!empty($tmp[2]))

-                    $width = $tmp[2];

-                if (!empty($tmp[3]))

-                    $heigth = $tmp[3];

-                if (!empty($tmp[4]))

-                    $savemethod = $tmp[4];

+                if (!empty($tmp[2])) {
+                                    $width = $tmp[2];
+                }
+                if (!empty($tmp[3])) {
+                                    $heigth = $tmp[3];
+                }
+                if (!empty($tmp[4])) {
+                                    $savemethod = $tmp[4];
+                }
 

                 if (!empty($conf->fckeditor->enabled)) {

                     $out .= '<input id="ckeditor_toolbar" value="' . $toolbar . '" type="hidden"/>' . "\n";

@@ -403,18 +420,23 @@ 
             $out .= '<input id="table_element_' . $htmlname . '" value="' . $table_element . '" type="hidden"/>' . "\n";

             $out .= '<input id="fk_element_' . $htmlname . '" value="' . $fk_element . '" type="hidden"/>' . "\n";

             $out .= '<input id="loadmethod_' . $htmlname . '" value="' . $loadmethod . '" type="hidden"/>' . "\n";

-            if (!empty($savemethod))

-                $out .= '<input id="savemethod_' . $htmlname . '" value="' . $savemethod . '" type="hidden"/>' . "\n";

-            if (!empty($ext_element))

-                $out .= '<input id="ext_element_' . $htmlname . '" value="' . $ext_element . '" type="hidden"/>' . "\n";

+            if (!empty($savemethod)) {
+                            $out .= '<input id="savemethod_' . $htmlname . '" value="' . $savemethod . '" type="hidden"/>' . "\n";
+            }
+            if (!empty($ext_element)) {
+                            $out .= '<input id="ext_element_' . $htmlname . '" value="' . $ext_element . '" type="hidden"/>' . "\n";
+            }
             if (!empty($custommsg)) {

                 if (is_array($custommsg)) {

-                    if (!empty($custommsg['success']))

-                        $out .= '<input id="successmsg_' . $htmlname . '" value="' . $custommsg['success'] . '" type="hidden"/>' . "\n";

-                    if (!empty($custommsg['error']))

-                        $out .= '<input id="errormsg_' . $htmlname . '" value="' . $custommsg['error'] . '" type="hidden"/>' . "\n";

-                } else

-                    $out .= '<input id="successmsg_' . $htmlname . '" value="' . $custommsg . '" type="hidden"/>' . "\n";

+                    if (!empty($custommsg['success'])) {
+                                            $out .= '<input id="successmsg_' . $htmlname . '" value="' . $custommsg['success'] . '" type="hidden"/>' . "\n";
+                    }
+                    if (!empty($custommsg['error'])) {
+                                            $out .= '<input id="errormsg_' . $htmlname . '" value="' . $custommsg['error'] . '" type="hidden"/>' . "\n";
+                    }
+                } else {
+                                    $out .= '<input id="successmsg_' . $htmlname . '" value="' . $custommsg . '" type="hidden"/>' . "\n";
+                }
             }

             if ($inputType == 'textarea') {

                 $out .= '<input id="textarea_' . $htmlname . '_rows" value="' . $rows . '" type="hidden"/>' . "\n";

@@ -566,20 +588,22 @@ 
         global $conf, $langs;

 

         $alt = '';

-        if ($tooltiptrigger)

-            $alt = $langs->transnoentitiesnoconv("ClickToShowHelp");

+        if ($tooltiptrigger) {
+                    $alt = $langs->transnoentitiesnoconv("ClickToShowHelp");
+        }
 

         //For backwards compatibility

-        if ($type == '0')

-            $type = 'info';

-        elseif ($type == '1')

-            $type = 'help';

+        if ($type == '0') {
+                    $type = 'info';
+        } elseif ($type == '1') {
+                    $type = 'help';
+        }
 

         // If info or help with no javascript, show only text

         if (empty($conf->use_javascript_ajax)) {

-            if ($type == 'info' || $type == 'help')

-                return $text;

-            else {

+            if ($type == 'info' || $type == 'help') {
+                            return $text;
+            } else {

                 $alt = $htmltext;

                 $htmltext = '';

             }

@@ -587,27 +611,30 @@ 
 

         // If info or help with smartphone, show only text (tooltip hover can't works)

         if (!empty($conf->dol_no_mouse_hover) && empty($tooltiptrigger)) {

-            if ($type == 'info' || $type == 'help')

-                return $text;

+            if ($type == 'info' || $type == 'help') {
+                            return $text;
+            }
         }

         // If info or help with smartphone, show only text (tooltip on lick does not works with dialog on smaprtphone)

         if (!empty($conf->dol_no_mouse_hover) && !empty($tooltiptrigger)) {

-            if ($type == 'info' || $type == 'help')

-                return $text;

-        }

-

-        if ($type == 'info')

-            $img = img_help(0, $alt);

-        elseif ($type == 'help')

-            $img = img_help(($tooltiptrigger != '' ? 2 : 1), $alt);

-        elseif ($type == 'superadmin')

-            $img = img_picto($alt, 'redstar');

-        elseif ($type == 'admin')

-            $img = img_picto($alt, 'star');

-        elseif ($type == 'warning')

-            $img = img_warning($alt);

-        else

-            $img = img_picto($alt, $type);

+            if ($type == 'info' || $type == 'help') {
+                            return $text;
+            }
+        }

+

+        if ($type == 'info') {
+                    $img = img_help(0, $alt);
+        } elseif ($type == 'help') {
+                    $img = img_help(($tooltiptrigger != '' ? 2 : 1), $alt);
+        } elseif ($type == 'superadmin') {
+                    $img = img_picto($alt, 'redstar');
+        } elseif ($type == 'admin') {
+                    $img = img_picto($alt, 'star');
+        } elseif ($type == 'warning') {
+                    $img = img_warning($alt);
+        } else {
+                    $img = img_picto($alt, $type);
+        }
 

         return $this->textwithtooltip($text, $htmltext, (($tooltiptrigger && !$img) ? 3 : 2), $direction, $img, $extracss, $notabs, '', $noencodehtmltext, $tooltiptrigger, $forcenowrap);

     }

@@ -624,8 +651,9 @@ 
     {

         global $conf, $langs, $hookmanager;

 

-        if (count($arrayofaction) == 0)

-            return;

+        if (count($arrayofaction) == 0) {
+                    return;
+        }
 

         $disabled = 0;

         $ret = '<div class="centpercent center">';

@@ -757,10 +785,11 @@ 
                     $i++;

                 }

 

-                if (empty($disablefavorites))

-                    array_multisort($favorite, SORT_DESC, $label, SORT_ASC, $countryArray);

-                else

-                    $countryArray = dol_sort_array($countryArray, 'label');

+                if (empty($disablefavorites)) {
+                                    array_multisort($favorite, SORT_DESC, $label, SORT_ASC, $countryArray);
+                } else {
+                                    $countryArray = dol_sort_array($countryArray, 'label');
+                }
 

                 if ($showempty) {

                     $out .= '<option value="">&nbsp;</option>' . "\n";

@@ -770,8 +799,9 @@ 
                     //if ($showempty) $out.= '<option value="" disabled class="selectoptiondisabledwhite">--------------</option>';

                     $out .= '<option value="special_allnotme"' . ($selected == 'special_allnotme' ? ' selected' : '') . '>' . $langs->trans("CountriesExceptMe", $langs->transnoentitiesnoconv("Country" . $mysoc->country_code)) . '</option>';

                     $out .= '<option value="special_eec"' . ($selected == 'special_eec' ? ' selected' : '') . '>' . $langs->trans("CountriesInEEC") . '</option>';

-                    if ($mysoc->isInEEC())

-                        $out .= '<option value="special_eecnotme"' . ($selected == 'special_eecnotme' ? ' selected' : '') . '>' . $langs->trans("CountriesInEECExceptMe", $langs->transnoentitiesnoconv("Country" . $mysoc->country_code)) . '</option>';

+                    if ($mysoc->isInEEC()) {
+                                            $out .= '<option value="special_eecnotme"' . ($selected == 'special_eecnotme' ? ' selected' : '') . '>' . $langs->trans("CountriesInEECExceptMe", $langs->transnoentitiesnoconv("Country" . $mysoc->country_code)) . '</option>';
+                    }
                     $out .= '<option value="special_noteec"' . ($selected == 'special_noteec' ? ' selected' : '') . '>' . $langs->trans("CountriesNotInEEC") . '</option>';

                     $out .= '<option value="" disabled class="selectoptiondisabledwhite">--------------</option>';

                 }

@@ -782,8 +812,9 @@ 
                         continue;

                     }

 

-                    if (empty($disablefavorites) && $row['favorite'] && $row['code_iso'])

-                        $atleastonefavorite++;

+                    if (empty($disablefavorites) && $row['favorite'] && $row['code_iso']) {
+                                            $atleastonefavorite++;
+                    }
                     if (empty($row['favorite']) && $atleastonefavorite) {

                         $atleastonefavorite = 0;

                         $out .= '<option value="" disabled class="selectoptiondisabledwhite">--------------</option>';

@@ -794,18 +825,19 @@ 
                     } else {

                         $out .= '<option value="' . ($usecodeaskey ? ($usecodeaskey == 'code2' ? $row['code_iso'] : $row['code_iso3']) : $row['rowid']) . '">';

                     }

-                    if ($row['label'])

-                        $out .= dol_trunc($row['label'], $maxlength, 'middle');

-                    else

-                        $out .= '&nbsp;';

-                    if ($row['code_iso'])

-                        $out .= ' (' . $row['code_iso'] . ')';

+                    if ($row['label']) {
+                                            $out .= dol_trunc($row['label'], $maxlength, 'middle');
+                    } else {
+                                            $out .= '&nbsp;';
+                    }
+                    if ($row['code_iso']) {
+                                            $out .= ' (' . $row['code_iso'] . ')';
+                    }
                     $out .= '</option>';

                 }

             }

             $out .= '</select>';

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

 

@@ -879,8 +911,9 @@ 
                         $out .= '<option value="' . $row['rowid'] . '">';

                     }

 

-                    if ($row['code'])

-                        $out .= $row['code'];

+                    if ($row['code']) {
+                                            $out .= $row['code'];
+                    }
 

                     $out .= '</option>';

                 }

@@ -918,24 +951,28 @@ 
 

         // If product & services are enabled or both disabled.

         if ($forceall == 1 || (empty($forceall) && !empty($conf->product->enabled) && !empty($conf->service->enabled)) || (empty($forceall) && empty($conf->product->enabled) && empty($conf->service->enabled))) {

-            if (empty($hidetext))

-                print $langs->trans("Type") . ': ';

+            if (empty($hidetext)) {
+                            print $langs->trans("Type") . ': ';
+            }
             print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

             if ($showempty) {

                 print '<option value="-1"';

-                if ($selected == -1)

-                    print ' selected';

+                if ($selected == -1) {
+                                    print ' selected';
+                }
                 print '>&nbsp;</option>';

             }

 

             print '<option value="0"';

-            if (0 == $selected)

-                print ' selected';

+            if (0 == $selected) {
+                            print ' selected';
+            }
             print '>' . $langs->trans("Product");

 

             print '<option value="1"';

-            if (1 == $selected)

-                print ' selected';

+            if (1 == $selected) {
+                            print ' selected';
+            }
             print '>' . $langs->trans("Service");

 

             print '</select>';

@@ -966,8 +1003,10 @@ 
         global $langs;

 

         $num = count($this->cache_types_fees);

-        if ($num > 0)

-            return 0;    // Cache already loaded

+        if ($num > 0) {
+                    return 0;
+        }
+        // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

@@ -1021,23 +1060,26 @@ 
         print '<select id="select_' . $htmlname . '" class="flat" name="' . $htmlname . '">';

         if ($showempty) {

             print '<option value="-1"';

-            if ($selected == -1)

-                print ' selected';

+            if ($selected == -1) {
+                            print ' selected';
+            }
             print '>&nbsp;</option>';

         }

 

         foreach ($this->cache_types_fees as $key => $value) {

             print '<option value="' . $key . '"';

-            if ($key == $selected)

-                print ' selected';

+            if ($key == $selected) {
+                            print ' selected';
+            }
             print '>';

             print $value;

             print '</option>';

         }

 

         print '</select>';

-        if ($user->admin)

-            print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+        if ($user->admin) {
+                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+        }
     }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -1100,9 +1142,9 @@ 
             $urloption = 'htmlname=' . $htmlname . '&outjson=1&filter=' . $filter . ($showtype ? '&showtype=' . $showtype : '');

             $out .= ajax_autocompleter($selected, $htmlname, DOL_URL_ROOT . '/societe/ajax/company.php', $urloption, $conf->global->COMPANY_USE_SEARCH_TO_SELECT, 0, $ajaxoptions);

             $out .= '<style type="text/css">.ui-autocomplete { z-index: 250; }</style>';

-            if (empty($hidelabel))

-                print $langs->trans("RefOrLabel") . ' : ';

-            else if ($hidelabel > 1) {

+            if (empty($hidelabel)) {
+                            print $langs->trans("RefOrLabel") . ' : ';
+            } else if ($hidelabel > 1) {

                 $placeholder = ' placeholder="' . $langs->trans("RefOrLabel") . '"';

                 if ($hidelabel == 2) {

                     $out .= img_picto($langs->trans("Search"), 'search');

@@ -1149,10 +1191,11 @@ 
         $num = 0;

         $outarray = array();

 

-        if ($selected === '')

-            $selected = array();

-        else if (!is_array($selected))

-            $selected = array($selected);

+        if ($selected === '') {
+                    $selected = array();
+        } else if (!is_array($selected)) {
+                    $selected = array($selected);
+        }
 

         // Clean $filter that may contains sql conditions so sql code

         if (function_exists('testSqlAndScriptInject')) {

@@ -1170,21 +1213,26 @@ 
         }

 

         $sql .= " FROM (" . MAIN_DB_PREFIX . "societe as s";

-        if (!$user->rights->societe->client->voir && !$user->socid)

-            $sql .= ", " . MAIN_DB_PREFIX . "societe_commerciaux as sc";

+        if (!$user->rights->societe->client->voir && !$user->socid) {
+                    $sql .= ", " . MAIN_DB_PREFIX . "societe_commerciaux as sc";
+        }
         $sql .= " )";

         if ($conf->global->COMPANY_SHOW_ADDRESS_SELECTLIST) {

             $sql .= " LEFT OUTER JOIN " . MAIN_DB_PREFIX . "c_country as dictp ON dictp.rowid=s.fk_pays";

         }

         $sql .= " WHERE s.entity IN (" . getEntity('societe') . ")";

-        if (!empty($user->socid))

-            $sql .= " AND s.rowid = " . $user->socid;

-        if ($filter)

-            $sql .= " AND (" . $filter . ")";

-        if (!$user->rights->societe->client->voir && !$user->socid)

-            $sql .= " AND s.rowid = sc.fk_soc AND sc.fk_user = " . $user->id;

-        if (!empty($conf->global->COMPANY_HIDE_INACTIVE_IN_COMBOBOX))

-            $sql .= " AND s.status <> 0";

+        if (!empty($user->socid)) {
+                    $sql .= " AND s.rowid = " . $user->socid;
+        }
+        if ($filter) {
+                    $sql .= " AND (" . $filter . ")";
+        }
+        if (!$user->rights->societe->client->voir && !$user->socid) {
+                    $sql .= " AND s.rowid = sc.fk_soc AND sc.fk_user = " . $user->id;
+        }
+        if (!empty($conf->global->COMPANY_HIDE_INACTIVE_IN_COMBOBOX)) {
+                    $sql .= " AND s.status <> 0";
+        }
         // Add criteria

         if ($filterkey && $filterkey != '') {

             $sql .= " AND (";

@@ -1192,16 +1240,19 @@ 
             // For natural search

             $scrit = explode(' ', $filterkey);

             $i = 0;

-            if (count($scrit) > 1)

-                $sql .= "(";

+            if (count($scrit) > 1) {
+                            $sql .= "(";
+            }
             foreach ($scrit as $crit) {

-                if ($i > 0)

-                    $sql .= " AND ";

+                if ($i > 0) {
+                                    $sql .= " AND ";
+                }
                 $sql .= "(s.nom LIKE '" . $this->db->escape($prefix . $crit) . "%')";

                 $i++;

             }

-            if (count($scrit) > 1)

-                $sql .= ")";

+            if (count($scrit) > 1) {
+                            $sql .= ")";
+            }
             if (!empty($conf->barcode->enabled)) {

                 $sql .= " OR s.barcode LIKE '" . $this->db->escape($prefix . $filterkey) . "%'";

             }

@@ -1227,13 +1278,15 @@ 
             // Do not use textifempty = ' ' or '&nbsp;' here, or search on key will search on ' key'.

             //if (! empty($conf->use_javascript_ajax) || $forcecombo) $textifempty='';

             if (!empty($conf->global->COMPANY_USE_SEARCH_TO_SELECT)) {

-                if ($showempty && !is_numeric($showempty))

-                    $textifempty = $langs->trans($showempty);

-                else

-                    $textifempty .= $langs->trans("All");

+                if ($showempty && !is_numeric($showempty)) {
+                                    $textifempty = $langs->trans($showempty);
+                } else {
+                                    $textifempty .= $langs->trans("All");
+                }
             }

-            if ($showempty)

-                $out .= '<option value="-1">' . $textifempty . '</option>' . "\n";

+            if ($showempty) {
+                            $out .= '<option value="-1">' . $textifempty . '</option>' . "\n";
+            }
 

             $num = $this->db->num_rows($resql);

             $i = 0;

@@ -1258,16 +1311,21 @@ 
                     }

 

                     if ($showtype) {

-                        if ($obj->client || $obj->fournisseur)

-                            $label .= ' (';

-                        if ($obj->client == 1 || $obj->client == 3)

-                            $label .= $langs->trans("Customer");

-                        if ($obj->client == 2 || $obj->client == 3)

-                            $label .= ($obj->client == 3 ? ', ' : '') . $langs->trans("Prospect");

-                        if ($obj->fournisseur)

-                            $label .= ($obj->client ? ', ' : '') . $langs->trans("Supplier");

-                        if ($obj->client || $obj->fournisseur)

-                            $label .= ')';

+                        if ($obj->client || $obj->fournisseur) {
+                                                    $label .= ' (';
+                        }
+                        if ($obj->client == 1 || $obj->client == 3) {
+                                                    $label .= $langs->trans("Customer");
+                        }
+                        if ($obj->client == 2 || $obj->client == 3) {
+                                                    $label .= ($obj->client == 3 ? ', ' : '') . $langs->trans("Prospect");
+                        }
+                        if ($obj->fournisseur) {
+                                                    $label .= ($obj->client ? ', ' : '') . $langs->trans("Supplier");
+                        }
+                        if ($obj->client || $obj->fournisseur) {
+                                                    $label .= ')';
+                        }
                     }

 

                     if ($conf->global->COMPANY_SHOW_ADDRESS_SELECTLIST) {

@@ -1288,20 +1346,21 @@ 
                     }

 

                     $i++;

-                    if (($i % 10) == 0)

-                        $out .= "\n";

+                    if (($i % 10) == 0) {
+                                            $out .= "\n";
+                    }
                 }

             }

             $out .= '</select>' . "\n";

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

 

         $this->result = array('nbofthirdparties' => $num);

 

-        if ($outputmode)

-            return $outarray;

+        if ($outputmode) {
+                    return $outarray;
+        }
         return $out;

     }

 

@@ -1327,8 +1386,9 @@ 
         $sql .= " FROM " . MAIN_DB_PREFIX . "societe_remise_except as re";

         $sql .= " WHERE re.fk_soc = " . (int) $socid;

         $sql .= " AND re.entity = " . $conf->entity;

-        if ($filter)

-            $sql .= " AND " . $filter;

+        if ($filter) {
+                    $sql .= " AND " . $filter;
+        }
         $sql .= " ORDER BY re.description ASC";

 

         dol_syslog(get_class($this) . "::select_remises", LOG_DEBUG);

@@ -1345,18 +1405,23 @@ 
                 while ($i < $num) {

                     $obj = $this->db->fetch_object($resql);

                     $desc = dol_trunc($obj->description, 40);

-                    if (preg_match('/\(CREDIT_NOTE\)/', $desc))

-                        $desc = preg_replace('/\(CREDIT_NOTE\)/', $langs->trans("CreditNote"), $desc);

-                    if (preg_match('/\(DEPOSIT\)/', $desc))

-                        $desc = preg_replace('/\(DEPOSIT\)/', $langs->trans("Deposit"), $desc);

-                    if (preg_match('/\(EXCESS RECEIVED\)/', $desc))

-                        $desc = preg_replace('/\(EXCESS RECEIVED\)/', $langs->trans("ExcessReceived"), $desc);

-                    if (preg_match('/\(EXCESS PAID\)/', $desc))

-                        $desc = preg_replace('/\(EXCESS PAID\)/', $langs->trans("ExcessPaid"), $desc);

+                    if (preg_match('/\(CREDIT_NOTE\)/', $desc)) {
+                                            $desc = preg_replace('/\(CREDIT_NOTE\)/', $langs->trans("CreditNote"), $desc);
+                    }
+                    if (preg_match('/\(DEPOSIT\)/', $desc)) {
+                                            $desc = preg_replace('/\(DEPOSIT\)/', $langs->trans("Deposit"), $desc);
+                    }
+                    if (preg_match('/\(EXCESS RECEIVED\)/', $desc)) {
+                                            $desc = preg_replace('/\(EXCESS RECEIVED\)/', $langs->trans("ExcessReceived"), $desc);
+                    }
+                    if (preg_match('/\(EXCESS PAID\)/', $desc)) {
+                                            $desc = preg_replace('/\(EXCESS PAID\)/', $langs->trans("ExcessPaid"), $desc);
+                    }
 

                     $selectstring = '';

-                    if ($selected > 0 && $selected == $obj->rowid)

-                        $selectstring = ' selected';

+                    if ($selected > 0 && $selected == $obj->rowid) {
+                                            $selectstring = ' selected';
+                    }
 

                     $disabled = '';

                     if ($maxvalue > 0 && $obj->amount_ttc > $maxvalue) {

@@ -1366,8 +1431,9 @@ 
 

                     if (!empty($conf->global->MAIN_SHOW_FACNUMBER_IN_DISCOUNT_LIST) && !empty($obj->fk_facture_source)) {

                         $tmpfac = new Facture($this->db);

-                        if ($tmpfac->fetch($obj->fk_facture_source) > 0)

-                            $desc = $desc . ' - ' . $tmpfac->ref;

+                        if ($tmpfac->fetch($obj->fk_facture_source) > 0) {
+                                                    $desc = $desc . ' - ' . $tmpfac->ref;
+                        }
                     }

 

                     print '<option value="' . $obj->rowid . '"' . $selectstring . $disabled . '>' . $desc . ' (' . price($obj->amount_ht) . ' ' . $langs->trans("HT") . ' - ' . price($obj->amount_ttc) . ' ' . $langs->trans("TTC") . ')</option>';

@@ -1376,8 +1442,7 @@ 
             }

             print '</select>';

             return $qualifiedlines;

-        }

-        else {

+        } else {

             dol_print_error($this->db);

             return -1;

         }

@@ -1440,13 +1505,15 @@ 
 

         $langs->load('companies');

 

-        if (empty($htmlid))

-            $htmlid = $htmlname;

+        if (empty($htmlid)) {
+                    $htmlid = $htmlname;
+        }
 

-        if ($selected === '')

-            $selected = array();

-        else if (!is_array($selected))

-            $selected = array($selected);

+        if ($selected === '') {
+                    $selected = array();
+        } else if (!is_array($selected)) {
+                    $selected = array($selected);
+        }
         $out = '';

 

         if (!is_object($hookmanager)) {

@@ -1456,16 +1523,20 @@ 
 

         // We search third parties

         $sql = "SELECT sp.rowid, sp.lastname, sp.statut, sp.firstname, sp.poste";

-        if ($showsoc > 0)

-            $sql .= " , s.nom as company";

+        if ($showsoc > 0) {
+                    $sql .= " , s.nom as company";
+        }
         $sql .= " FROM " . MAIN_DB_PREFIX . "socpeople as sp";

-        if ($showsoc > 0)

-            $sql .= " LEFT OUTER JOIN  " . MAIN_DB_PREFIX . "societe as s ON s.rowid=sp.fk_soc";

+        if ($showsoc > 0) {
+                    $sql .= " LEFT OUTER JOIN  " . MAIN_DB_PREFIX . "societe as s ON s.rowid=sp.fk_soc";
+        }
         $sql .= " WHERE sp.entity IN (" . getEntity('socpeople') . ")";

-        if ($socid > 0 || $socid == -1)

-            $sql .= " AND sp.fk_soc=" . $socid;

-        if (!empty($conf->global->CONTACT_HIDE_INACTIVE_IN_COMBOBOX))

-            $sql .= " AND sp.statut <> 0";

+        if ($socid > 0 || $socid == -1) {
+                    $sql .= " AND sp.fk_soc=" . $socid;
+        }
+        if (!empty($conf->global->CONTACT_HIDE_INACTIVE_IN_COMBOBOX)) {
+                    $sql .= " AND sp.statut <> 0";
+        }
         $sql .= " ORDER BY sp.lastname ASC";

 

         dol_syslog(get_class($this) . "::select_contacts", LOG_DEBUG);

@@ -1478,12 +1549,15 @@ 
                 $out .= ajax_combobox($htmlid, $events, $conf->global->CONTACT_USE_SEARCH_TO_SELECT);

             }

 

-            if ($htmlname != 'none' || $options_only)

-                $out .= '<select class="flat' . ($moreclass ? ' ' . $moreclass : '') . '" id="' . $htmlid . '" name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . ' ' . (!empty($moreparam) ? $moreparam : '') . '>';

-            if (($showempty == 1 || ($showempty == 3 && $num > 1)) && !$multiple)

-                $out .= '<option value="0"' . (in_array(0, $selected) ? ' selected' : '') . '>&nbsp;</option>';

-            if ($showempty == 2)

-                $out .= '<option value="0"' . (in_array(0, $selected) ? ' selected' : '') . '>' . $langs->trans("Internal") . '</option>';

+            if ($htmlname != 'none' || $options_only) {
+                            $out .= '<select class="flat' . ($moreclass ? ' ' . $moreclass : '') . '" id="' . $htmlid . '" name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . ' ' . (!empty($moreparam) ? $moreparam : '') . '>';
+            }
+            if (($showempty == 1 || ($showempty == 3 && $num > 1)) && !$multiple) {
+                            $out .= '<option value="0"' . (in_array(0, $selected) ? ' selected' : '') . '>&nbsp;</option>';
+            }
+            if ($showempty == 2) {
+                            $out .= '<option value="0"' . (in_array(0, $selected) ? ' selected' : '') . '>' . $langs->trans("Internal") . '</option>';
+            }
             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

@@ -1499,49 +1573,56 @@ 
                     if ($obj->statut == 1) {

                         if ($htmlname != 'none') {

                             $disabled = 0;

-                            if (is_array($exclude) && count($exclude) && in_array($obj->rowid, $exclude))

-                                $disabled = 1;

-                            if (is_array($limitto) && count($limitto) && !in_array($obj->rowid, $limitto))

-                                $disabled = 1;

+                            if (is_array($exclude) && count($exclude) && in_array($obj->rowid, $exclude)) {
+                                                            $disabled = 1;
+                            }
+                            if (is_array($limitto) && count($limitto) && !in_array($obj->rowid, $limitto)) {
+                                                            $disabled = 1;
+                            }
                             if (!empty($selected) && in_array($obj->rowid, $selected)) {

                                 $out .= '<option value="' . $obj->rowid . '"';

-                                if ($disabled)

-                                    $out .= ' disabled';

+                                if ($disabled) {
+                                                                    $out .= ' disabled';
+                                }
                                 $out .= ' selected>';

                                 $out .= $contactstatic->getFullName($langs);

-                                if ($showfunction && $obj->poste)

-                                    $out .= ' (' . $obj->poste . ')';

-                                if (($showsoc > 0) && $obj->company)

-                                    $out .= ' - (' . $obj->company . ')';

+                                if ($showfunction && $obj->poste) {
+                                                                    $out .= ' (' . $obj->poste . ')';
+                                }
+                                if (($showsoc > 0) && $obj->company) {
+                                                                    $out .= ' - (' . $obj->company . ')';
+                                }
                                 $out .= '</option>';

-                            }

-                            else {

+                            } else {

                                 $out .= '<option value="' . $obj->rowid . '"';

-                                if ($disabled)

-                                    $out .= ' disabled';

+                                if ($disabled) {
+                                                                    $out .= ' disabled';
+                                }
                                 $out .= '>';

                                 $out .= $contactstatic->getFullName($langs);

-                                if ($showfunction && $obj->poste)

-                                    $out .= ' (' . $obj->poste . ')';

-                                if (($showsoc > 0) && $obj->company)

-                                    $out .= ' - (' . $obj->company . ')';

+                                if ($showfunction && $obj->poste) {
+                                                                    $out .= ' (' . $obj->poste . ')';
+                                }
+                                if (($showsoc > 0) && $obj->company) {
+                                                                    $out .= ' - (' . $obj->company . ')';
+                                }
                                 $out .= '</option>';

                             }

-                        }

-                        else {

+                        } else {

                             if (in_array($obj->rowid, $selected)) {

                                 $out .= $contactstatic->getFullName($langs);

-                                if ($showfunction && $obj->poste)

-                                    $out .= ' (' . $obj->poste . ')';

-                                if (($showsoc > 0) && $obj->company)

-                                    $out .= ' - (' . $obj->company . ')';

+                                if ($showfunction && $obj->poste) {
+                                                                    $out .= ' (' . $obj->poste . ')';
+                                }
+                                if (($showsoc > 0) && $obj->company) {
+                                                                    $out .= ' - (' . $obj->company . ')';
+                                }
                             }

                         }

                     }

                     $i++;

                 }

-            }

-            else {

+            } else {

                 $out .= '<option value="-1"' . (($showempty == 2 || $multiple) ? '' : ' selected') . ' disabled>';

                 $out .= ($socid != -1) ? ($langs->trans($socid ? "NoContactDefinedForThirdParty" : "NoContactDefined")) : $langs->trans('SelectAThirdPartyFirst');

                 $out .= '</option>';

@@ -1622,24 +1703,27 @@ 
         global $conf, $user, $langs;

 

         // If no preselected user defined, we take current user

-        if ((is_numeric($selected) && ($selected < -2 || empty($selected))) && empty($conf->global->SOCIETE_DISABLE_DEFAULT_SALESREPRESENTATIVE))

-            $selected = $user->id;

+        if ((is_numeric($selected) && ($selected < -2 || empty($selected))) && empty($conf->global->SOCIETE_DISABLE_DEFAULT_SALESREPRESENTATIVE)) {
+                    $selected = $user->id;
+        }
 

-        if ($selected === '')

-            $selected = array();

-        else if (!is_array($selected))

-            $selected = array($selected);

+        if ($selected === '') {
+                    $selected = array();
+        } else if (!is_array($selected)) {
+                    $selected = array($selected);
+        }
 

         $excludeUsers = null;

         $includeUsers = null;

 

         // Permettre l'exclusion d'utilisateurs

-        if (is_array($exclude))

-            $excludeUsers = implode(",", $exclude);

+        if (is_array($exclude)) {
+                    $excludeUsers = implode(",", $exclude);
+        }
         // Permettre l'inclusion d'utilisateurs

-        if (is_array($include))

-            $includeUsers = implode(",", $include);

-        else if ($include == 'hierarchy') {

+        if (is_array($include)) {
+                    $includeUsers = implode(",", $include);
+        } else if ($include == 'hierarchy') {

             // Build list includeUsers to have only hierarchy

             $includeUsers = implode(",", $user->getAllChildIds(0));

         } else if ($include == 'hierarchyme') {

@@ -1658,12 +1742,12 @@ 
         $sql .= " FROM " . MAIN_DB_PREFIX . "user as u";

         if (!empty($conf->multicompany->enabled) && $conf->entity == 1 && $user->admin && !$user->entity) {

             $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "entity as e ON e.rowid=u.entity";

-            if ($force_entity)

-                $sql .= " WHERE u.entity IN (0," . $force_entity . ")";

-            else

-                $sql .= " WHERE u.entity IS NOT NULL";

-        }

-        else {

+            if ($force_entity) {
+                            $sql .= " WHERE u.entity IN (0," . $force_entity . ")";
+            } else {
+                            $sql .= " WHERE u.entity IS NOT NULL";
+            }
+        } else {

             if (!empty($conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

                 $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "usergroup_user as ug";

                 $sql .= " ON ug.fk_user = u.rowid";

@@ -1672,16 +1756,21 @@ 
                 $sql .= " WHERE u.entity IN (0," . $conf->entity . ")";

             }

         }

-        if (!empty($user->societe_id))

-            $sql .= " AND u.fk_soc = " . $user->societe_id;

-        if (is_array($exclude) && $excludeUsers)

-            $sql .= " AND u.rowid NOT IN (" . $excludeUsers . ")";

-        if ($includeUsers)

-            $sql .= " AND u.rowid IN (" . $includeUsers . ")";

-        if (!empty($conf->global->USER_HIDE_INACTIVE_IN_COMBOBOX) || $noactive)

-            $sql .= " AND u.statut <> 0";

-        if (!empty($morefilter))

-            $sql .= " " . $morefilter;

+        if (!empty($user->societe_id)) {
+                    $sql .= " AND u.fk_soc = " . $user->societe_id;
+        }
+        if (is_array($exclude) && $excludeUsers) {
+                    $sql .= " AND u.rowid NOT IN (" . $excludeUsers . ")";
+        }
+        if ($includeUsers) {
+                    $sql .= " AND u.rowid IN (" . $includeUsers . ")";
+        }
+        if (!empty($conf->global->USER_HIDE_INACTIVE_IN_COMBOBOX) || $noactive) {
+                    $sql .= " AND u.statut <> 0";
+        }
+        if (!empty($morefilter)) {
+                    $sql .= " " . $morefilter;
+        }
 

         if (empty($conf->global->MAIN_FIRSTNAME_NAME_POSITION)) { // MAIN_FIRSTNAME_NAME_POSITION is 0 means firstname+lastname

             $sql .= " ORDER BY u.firstname ASC";

@@ -1701,10 +1790,12 @@ 
 

                 // do not use maxwidthonsmartphone by default. Set it by caller so auto size to 100% will work when not defined

                 $out .= '<select class="flat' . ($morecss ? ' minwidth100 ' . $morecss : ' minwidth200') . '" id="' . $htmlname . '" name="' . $htmlname . ($multiple ? '[]' : '') . '" ' . ($multiple ? 'multiple' : '') . ' ' . ($disabled ? ' disabled' : '') . '>';

-                if ($show_empty && !$multiple)

-                    $out .= '<option value="-1"' . ((empty($selected) || in_array(-1, $selected)) ? ' selected' : '') . '>&nbsp;</option>' . "\n";

-                if ($show_every)

-                    $out .= '<option value="-2"' . ((in_array(-2, $selected)) ? ' selected' : '') . '>-- ' . $langs->trans("Everybody") . ' --</option>' . "\n";

+                if ($show_empty && !$multiple) {
+                                    $out .= '<option value="-1"' . ((empty($selected) || in_array(-1, $selected)) ? ' selected' : '') . '>&nbsp;</option>' . "\n";
+                }
+                if ($show_every) {
+                                    $out .= '<option value="-2"' . ((in_array(-2, $selected)) ? ' selected' : '') . '>-- ' . $langs->trans("Everybody") . ' --</option>' . "\n";
+                }
 

                 $userstatic = new User($this->db);

 

@@ -1716,19 +1807,21 @@ 
                     $userstatic->firstname = $obj->firstname;

 

                     $disableline = '';

-                    if (is_array($enableonly) && count($enableonly) && !in_array($obj->rowid, $enableonly))

-                        $disableline = ($enableonlytext ? $enableonlytext : '1');

+                    if (is_array($enableonly) && count($enableonly) && !in_array($obj->rowid, $enableonly)) {
+                                            $disableline = ($enableonlytext ? $enableonlytext : '1');
+                    }
 

                     if ((is_object($selected) && $selected->id == $obj->rowid) || (!is_object($selected) && in_array($obj->rowid, $selected) )) {

                         $out .= '<option value="' . $obj->rowid . '"';

-                        if ($disableline)

-                            $out .= ' disabled';

+                        if ($disableline) {
+                                                    $out .= ' disabled';
+                        }
                         $out .= ' selected>';

-                    }

-                    else {

+                    } else {

                         $out .= '<option value="' . $obj->rowid . '"';

-                        if ($disableline)

-                            $out .= ' disabled';

+                        if ($disableline) {
+                                                    $out .= ' disabled';
+                        }
                         $out .= '>';

                     }

 

@@ -1782,8 +1875,9 @@ 
             dol_print_error($this->db);

         }

 

-        if ($outputmode)

-            return $outarray;

+        if ($outputmode) {
+                    return $outarray;
+        }
         return $out;

     }

 

@@ -1835,15 +1929,18 @@ 
         }

         $nbassignetouser = count($assignedtouser);

 

-        if ($nbassignetouser && $action != 'view')

-            $out .= '<br>';

-        if ($nbassignetouser)

-            $out .= '<ul class="attendees">';

+        if ($nbassignetouser && $action != 'view') {
+                    $out .= '<br>';
+        }
+        if ($nbassignetouser) {
+                    $out .= '<ul class="attendees">';
+        }
         $i = 0;

         $ownerid = 0;

         foreach ($assignedtouser as $key => $value) {

-            if ($value['id'] == $ownerid)

-                continue;

+            if ($value['id'] == $ownerid) {
+                            continue;
+            }
 

             $out .= '<li>';

             $userstatic->fetch($value['id']);

@@ -1869,8 +1966,9 @@ 
             $out .= '</li>';

             $i++;

         }

-        if ($nbassignetouser)

-            $out .= '</ul>';

+        if ($nbassignetouser) {
+                    $out .= '</ul>';
+        }
 

         //$out.='</form>';

         return $out;

@@ -2001,9 +2099,9 @@ 
                                 </script>

                                 <?php

                             }

-                            if (empty($hidelabel))

-                                print $langs->trans("RefOrLabel") . ' : ';

-                            else if ($hidelabel > 1) {

+                            if (empty($hidelabel)) {
+                                                            print $langs->trans("RefOrLabel") . ' : ';
+                            } else if ($hidelabel > 1) {

                                 $placeholder = ' placeholder="' . $langs->trans("RefOrLabel") . '"';

                                 if ($hidelabel == 2) {

                                     print img_picto($langs->trans("Search"), 'search');

@@ -2094,13 +2192,15 @@ 
         // Price by quantity

         if (!empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY) || !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES)) {

             $sql .= ", (SELECT pp.rowid FROM " . MAIN_DB_PREFIX . "product_price as pp WHERE pp.fk_product = p.rowid";

-            if ($price_level >= 1 && !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES))

-                $sql .= " AND price_level=" . $price_level;

+            if ($price_level >= 1 && !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES)) {
+                            $sql .= " AND price_level=" . $price_level;
+            }
             $sql .= " ORDER BY date_price";

             $sql .= " DESC LIMIT 1) as price_rowid";

             $sql .= ", (SELECT pp.price_by_qty FROM " . MAIN_DB_PREFIX . "product_price as pp WHERE pp.fk_product = p.rowid"; // price_by_qty is 1 if some prices by qty exists in subtable

-            if ($price_level >= 1 && !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES))

-                $sql .= " AND price_level=" . $price_level;

+            if ($price_level >= 1 && !empty($conf->global->PRODUIT_CUSTOMER_PRICES_BY_QTY_MULTIPRICES)) {
+                            $sql .= " AND price_level=" . $price_level;
+            }
             $sql .= " ORDER BY date_price";

             $sql .= " DESC LIMIT 1) as price_by_qty";

             $selectFields .= ", price_rowid, price_by_qty";

@@ -2142,14 +2242,15 @@ 
             $sql .= " AND p.finished = " . $finished;

         } elseif ($finished == 1) {

             $sql .= " AND p.finished = " . $finished;

-            if ($status >= 0)

-                $sql .= " AND p.tosell = " . $status;

-        }

-        elseif ($status >= 0) {

+            if ($status >= 0) {
+                            $sql .= " AND p.tosell = " . $status;
+            }
+        } elseif ($status >= 0) {

             $sql .= " AND p.tosell = " . $status;

         }

-        if (strval($filtertype) != '')

-            $sql .= " AND p.fk_product_type=" . $filtertype;

+        if (strval($filtertype) != '') {
+                    $sql .= " AND p.fk_product_type=" . $filtertype;
+        }
         // Add criteria on ref/label

         if ($filterkey != '') {

             $sql .= ' AND (';

@@ -2157,28 +2258,35 @@ 
             // For natural search

             $scrit = explode(' ', $filterkey);

             $i = 0;

-            if (count($scrit) > 1)

-                $sql .= "(";

+            if (count($scrit) > 1) {
+                            $sql .= "(";
+            }
             foreach ($scrit as $crit) {

-                if ($i > 0)

-                    $sql .= " AND ";

+                if ($i > 0) {
+                                    $sql .= " AND ";
+                }
                 $sql .= "(p.ref LIKE '" . $db->escape($prefix . $crit) . "%' OR p.label LIKE '" . $db->escape($prefix . $crit) . "%'";

-                if (!empty($conf->global->MAIN_MULTILANGS))

-                    $sql .= " OR pl.label LIKE '" . $db->escape($prefix . $crit) . "%'";

+                if (!empty($conf->global->MAIN_MULTILANGS)) {
+                                    $sql .= " OR pl.label LIKE '" . $db->escape($prefix . $crit) . "%'";
+                }
                 if (!empty($conf->global->PRODUCT_AJAX_SEARCH_ON_DESCRIPTION)) {

                     $sql .= " OR p.description LIKE '" . $db->escape($prefix . $crit) . "%'";

-                    if (!empty($conf->global->MAIN_MULTILANGS))

-                        $sql .= " OR pl.description LIKE '" . $db->escape($prefix . $crit) . "%'";

+                    if (!empty($conf->global->MAIN_MULTILANGS)) {
+                                            $sql .= " OR pl.description LIKE '" . $db->escape($prefix . $crit) . "%'";
+                    }
                 }

-                if (!empty($conf->global->MAIN_SEARCH_PRODUCT_BY_FOURN_REF))

-                    $sql .= " OR pfp.ref_fourn LIKE '" . $db->escape($prefix . $crit) . "%'";

+                if (!empty($conf->global->MAIN_SEARCH_PRODUCT_BY_FOURN_REF)) {
+                                    $sql .= " OR pfp.ref_fourn LIKE '" . $db->escape($prefix . $crit) . "%'";
+                }
                 $sql .= ")";

                 $i++;

             }

-            if (count($scrit) > 1)

-                $sql .= ")";

-            if (!empty($conf->barcode->enabled))

-                $sql .= " OR p.barcode LIKE '" . $db->escape($prefix . $filterkey) . "%'";

+            if (count($scrit) > 1) {
+                            $sql .= ")";
+            }
+            if (!empty($conf->barcode->enabled)) {
+                            $sql .= " OR p.barcode LIKE '" . $db->escape($prefix . $filterkey) . "%'";
+            }
             $sql .= ')';

         }

         if (count($warehouseStatusArray)) {

@@ -2217,13 +2325,15 @@ 
             // Do not use textifempty = ' ' or '&nbsp;' here, or search on key will search on ' key'.

             //if (! empty($conf->use_javascript_ajax) || $forcecombo) $textifempty='';

             if (!empty($conf->global->PRODUIT_USE_SEARCH_TO_SELECT)) {

-                if ($showempty && !is_numeric($showempty))

-                    $textifempty = $langs->trans($showempty);

-                else

-                    $textifempty .= $langs->trans("All");

+                if ($showempty && !is_numeric($showempty)) {
+                                    $textifempty = $langs->trans($showempty);
+                } else {
+                                    $textifempty .= $langs->trans("All");
+                }
             }

-            if ($showempty)

-                $out .= '<option value="0" selected>' . $textifempty . '</option>';

+            if ($showempty) {
+                            $out .= '<option value="0" selected>' . $textifempty . '</option>';
+            }
 

             $i = 0;

             while ($num && $i < $num) {

@@ -2297,11 +2407,11 @@ 
 

             $this->db->free($result);

 

-            if (empty($outputmode))

-                return $out;

+            if (empty($outputmode)) {
+                            return $out;
+            }
             return $outarray;

-        }

-        else {

+        } else {

             dol_print_error($db);

         }

     }

@@ -2338,10 +2448,12 @@ 
         $maxlengtharticle = (empty($conf->global->PRODUCT_MAX_LENGTH_COMBO) ? 48 : $conf->global->PRODUCT_MAX_LENGTH_COMBO);

 

         $label = $objp->label;

-        if (!empty($objp->label_translated))

-            $label = $objp->label_translated;

-        if (!empty($filterkey) && $filterkey != '')

-            $label = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $label, 1);

+        if (!empty($objp->label_translated)) {
+                    $label = $objp->label_translated;
+        }
+        if (!empty($filterkey) && $filterkey != '') {
+                    $label = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $label, 1);
+        }
 

         $outkey = $objp->rowid;

         $outref = $objp->ref;

@@ -2359,23 +2471,27 @@ 
             $opt .= ' pbq="' . $objp->price_by_qty_rowid . '" data-pbq="' . $objp->price_by_qty_rowid . '" data-pbqqty="' . $objp->price_by_qty_quantity . '" data-pbqpercent="' . $objp->price_by_qty_remise_percent . '"';

         }

         if (!empty($conf->stock->enabled) && $objp->fk_product_type == 0 && isset($objp->stock)) {

-            if ($objp->stock > 0)

-                $opt .= ' class="product_line_stock_ok"';

-            else if ($objp->stock <= 0)

-                $opt .= ' class="product_line_stock_too_low"';

+            if ($objp->stock > 0) {
+                            $opt .= ' class="product_line_stock_ok"';
+            } else if ($objp->stock <= 0) {
+                            $opt .= ' class="product_line_stock_too_low"';
+            }
         }

         $opt .= '>';

         $opt .= $objp->ref;

-        if ($outbarcode)

-            $opt .= ' (' . $outbarcode . ')';

+        if ($outbarcode) {
+                    $opt .= ' (' . $outbarcode . ')';
+        }
         $opt .= ' - ' . dol_trunc($label, $maxlengtharticle);

 

         $objRef = $objp->ref;

-        if (!empty($filterkey) && $filterkey != '')

-            $objRef = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRef, 1);

+        if (!empty($filterkey) && $filterkey != '') {
+                    $objRef = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRef, 1);
+        }
         $outval .= $objRef;

-        if ($outbarcode)

-            $outval .= ' (' . $outbarcode . ')';

+        if ($outbarcode) {
+                    $outval .= ' (' . $outbarcode . ')';
+        }
         $outval .= ' - ' . dol_trunc($label, $maxlengtharticle);

 

         $found = 0;

@@ -2574,15 +2690,18 @@ 
         $sql .= " pfp.supplier_reputation";

         $sql .= " FROM " . MAIN_DB_PREFIX . "product as p";

         $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "product_fournisseur_price as pfp ON p.rowid = pfp.fk_product";

-        if ($socid)

-            $sql .= " AND pfp.fk_soc = " . $socid;

+        if ($socid) {
+                    $sql .= " AND pfp.fk_soc = " . $socid;
+        }
         $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "societe as s ON pfp.fk_soc = s.rowid";

         $sql .= " WHERE p.entity IN (" . getEntity('product') . ")";

         $sql .= " AND p.tobuy = 1";

-        if (strval($filtertype) != '')

-            $sql .= " AND p.fk_product_type=" . $this->db->escape($filtertype);

-        if (!empty($filtre))

-            $sql .= " " . $filtre;

+        if (strval($filtertype) != '') {
+                    $sql .= " AND p.fk_product_type=" . $this->db->escape($filtertype);
+        }
+        if (!empty($filtre)) {
+                    $sql .= " " . $filtre;
+        }
         // Add criteria on ref/label

         if ($filterkey != '') {

             $sql .= ' AND (';

@@ -2590,18 +2709,22 @@ 
             // For natural search

             $scrit = explode(' ', $filterkey);

             $i = 0;

-            if (count($scrit) > 1)

-                $sql .= "(";

+            if (count($scrit) > 1) {
+                            $sql .= "(";
+            }
             foreach ($scrit as $crit) {

-                if ($i > 0)

-                    $sql .= " AND ";

+                if ($i > 0) {
+                                    $sql .= " AND ";
+                }
                 $sql .= "(pfp.ref_fourn LIKE '" . $this->db->escape($prefix . $crit) . "%' OR p.ref LIKE '" . $this->db->escape($prefix . $crit) . "%' OR p.label LIKE '" . $this->db->escape($prefix . $crit) . "%')";

                 $i++;

             }

-            if (count($scrit) > 1)

-                $sql .= ")";

-            if (!empty($conf->barcode->enabled))

-                $sql .= " OR p.barcode LIKE '" . $this->db->escape($prefix . $filterkey) . "%'";

+            if (count($scrit) > 1) {
+                            $sql .= ")";
+            }
+            if (!empty($conf->barcode->enabled)) {
+                            $sql .= " OR p.barcode LIKE '" . $this->db->escape($prefix . $filterkey) . "%'";
+            }
             $sql .= ')';

         }

         $sql .= " ORDER BY pfp.ref_fourn DESC, pfp.quantity ASC";

@@ -2618,18 +2741,21 @@ 
 

             //$out.='<select class="flat" id="select'.$htmlname.'" name="'.$htmlname.'">';	// remove select to have id same with combo and ajax

             $out .= '<select class="flat maxwidthonsmartphone" id="' . $htmlname . '" name="' . $htmlname . '">';

-            if (!$selected)

-                $out .= '<option value="0" selected>&nbsp;</option>';

-            else

-                $out .= '<option value="0">&nbsp;</option>';

+            if (!$selected) {
+                            $out .= '<option value="0" selected>&nbsp;</option>';
+            } else {
+                            $out .= '<option value="0">&nbsp;</option>';
+            }
 

             $i = 0;

             while ($i < $num) {

                 $objp = $this->db->fetch_object($result);

 

                 $outkey = $objp->idprodfournprice;                                                    // id in table of price

-                if (!$outkey && $alsoproductwithnosupplierprice)

-                    $outkey = 'idprod_' . $objp->rowid;   // id of product

+                if (!$outkey && $alsoproductwithnosupplierprice) {
+                                    $outkey = 'idprod_' . $objp->rowid;
+                }
+                // id of product

 

                 $outref = $objp->ref;

                 $outval = '';

@@ -2640,32 +2766,39 @@ 
                 $outdurationunit = $outtype == Product::TYPE_SERVICE ? substr($objp->duration, -1) : '';

 

                 $opt = '<option value="' . $outkey . '"';

-                if ($selected && $selected == $objp->idprodfournprice)

-                    $opt .= ' selected';

-                if (empty($objp->idprodfournprice) && empty($alsoproductwithnosupplierprice))

-                    $opt .= ' disabled';

+                if ($selected && $selected == $objp->idprodfournprice) {
+                                    $opt .= ' selected';
+                }
+                if (empty($objp->idprodfournprice) && empty($alsoproductwithnosupplierprice)) {
+                                    $opt .= ' disabled';
+                }
                 if (!empty($objp->idprodfournprice) && $objp->idprodfournprice > 0) {

                     $opt .= ' pbq="' . $objp->idprodfournprice . '" data-pbq="' . $objp->idprodfournprice . '" data-pbqqty="' . $objp->quantity . '" data-pbqpercent="' . $objp->remise_percent . '"';

                 }

                 $opt .= '>';

 

                 $objRef = $objp->ref;

-                if ($filterkey && $filterkey != '')

-                    $objRef = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRef, 1);

+                if ($filterkey && $filterkey != '') {
+                                    $objRef = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRef, 1);
+                }
                 $objRefFourn = $objp->ref_fourn;

-                if ($filterkey && $filterkey != '')

-                    $objRefFourn = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRefFourn, 1);

+                if ($filterkey && $filterkey != '') {
+                                    $objRefFourn = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $objRefFourn, 1);
+                }
                 $label = $objp->label;

-                if ($filterkey && $filterkey != '')

-                    $label = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $label, 1);

+                if ($filterkey && $filterkey != '') {
+                                    $label = preg_replace('/(' . preg_quote($filterkey) . ')/i', '<strong>$1</strong>', $label, 1);
+                }
 

                 $opt .= $objp->ref;

-                if (!empty($objp->idprodfournprice) && ($objp->ref != $objp->ref_fourn))

-                    $opt .= ' (' . $objp->ref_fourn . ')';

+                if (!empty($objp->idprodfournprice) && ($objp->ref != $objp->ref_fourn)) {
+                                    $opt .= ' (' . $objp->ref_fourn . ')';
+                }
                 $opt .= ' - ';

                 $outval .= $objRef;

-                if (!empty($objp->idprodfournprice) && ($objp->ref != $objp->ref_fourn))

-                    $outval .= ' (' . $objRefFourn . ')';

+                if (!empty($objp->idprodfournprice) && ($objp->ref != $objp->ref_fourn)) {
+                                    $outval .= ' (' . $objRefFourn . ')';
+                }
                 $outval .= ' - ';

                 $opt .= dol_trunc($label, 72) . ' - ';

                 $outval .= dol_trunc($label, 72) . ' - ';

@@ -2759,11 +2892,11 @@ 
             include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

             $out .= ajax_combobox($htmlname);

 

-            if (empty($outputmode))

-                return $out;

+            if (empty($outputmode)) {
+                            return $out;
+            }
             return $outarray;

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

     }

@@ -2852,8 +2985,9 @@ 
                         $opt .= " - ";

                         $opt .= price($objp->unitprice, 1, $langs, 0, 0, -1, $conf->currency) . "/" . $langs->trans("Unit");

                     }

-                    if ($objp->duration)

-                        $opt .= " - " . $objp->duration;

+                    if ($objp->duration) {
+                                            $opt .= " - " . $objp->duration;
+                    }
                     $opt .= "</option>\n";

 

                     $form .= $opt;

@@ -2864,8 +2998,7 @@ 
             $form .= '</select>';

             $this->db->free($result);

             return $form;

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

     }

@@ -2893,8 +3026,9 @@ 
         $resql = $this->db->query($sql);

         if ($resql) {

             print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

-            if ($showempty)

-                print '<option value="0">&nbsp;</option>';

+            if ($showempty) {
+                            print '<option value="0">&nbsp;</option>';
+            }
             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

@@ -2928,8 +3062,10 @@ 
         global $langs;

 

         $num = count($this->cache_conditions_paiements);

-        if ($num > 0)

-            return 0;    // Cache already loaded

+        if ($num > 0) {
+                    return 0;
+        }
+        // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

@@ -2974,8 +3110,10 @@ 
         global $langs;

 

         $num = count($this->cache_availability);

-        if ($num > 0)

-            return 0;    // Cache already loaded

+        if ($num > 0) {
+                    return 0;
+        }
+        // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

@@ -3026,8 +3164,9 @@ 
         dol_syslog(__METHOD__ . " selected=" . $selected . ", htmlname=" . $htmlname, LOG_DEBUG);

 

         print '<select id="' . $htmlname . '" class="flat" name="' . $htmlname . '">';

-        if ($addempty)

-            print '<option value="0">&nbsp;</option>';

+        if ($addempty) {
+                    print '<option value="0">&nbsp;</option>';
+        }
         foreach ($this->cache_availability as $id => $arrayavailability) {

             if ($selected == $id) {

                 print '<option value="' . $id . '" selected>';

@@ -3038,8 +3177,9 @@ 
             print '</option>';

         }

         print '</select>';

-        if ($user->admin)

-            print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+        if ($user->admin) {
+                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+        }
     }

 

     /**

@@ -3052,8 +3192,10 @@ 
         global $langs;

 

         $num = count($this->cache_demand_reason);

-        if ($num > 0)

-            return 0;    // Cache already loaded

+        if ($num > 0) {
+                    return 0;
+        }
+        // Cache already loaded

 

         $sql = "SELECT rowid, code, label";

         $sql .= " FROM " . MAIN_DB_PREFIX . 'c_input_reason';

@@ -3069,10 +3211,14 @@ 
 

                 // Si traduction existe, on l'utilise, sinon on prend le libelle par defaut

                 $label = ($obj->label != '-' ? $obj->label : '');

-                if ($langs->trans("DemandReasonType" . $obj->code) != ("DemandReasonType" . $obj->code))

-                    $label = $langs->trans("DemandReasonType" . $obj->code); // So translation key DemandReasonTypeSRC_XXX will work

-                if ($langs->trans($obj->code) != $obj->code)

-                    $label = $langs->trans($obj->code);                // So translation key SRC_XXX will work

+                if ($langs->trans("DemandReasonType" . $obj->code) != ("DemandReasonType" . $obj->code)) {
+                                    $label = $langs->trans("DemandReasonType" . $obj->code);
+                }
+                // So translation key DemandReasonTypeSRC_XXX will work

+                if ($langs->trans($obj->code) != $obj->code) {
+                                    $label = $langs->trans($obj->code);
+                }
+                // So translation key SRC_XXX will work

 

                 $tmparray[$obj->rowid]['id'] = $obj->rowid;

                 $tmparray[$obj->rowid]['code'] = $obj->code;

@@ -3084,8 +3230,7 @@ 
 

             unset($tmparray);

             return $num;

-        }

-        else {

+        } else {

             dol_print_error($this->db);

             return -1;

         }

@@ -3108,11 +3253,13 @@ 
         $this->loadCacheInputReason();

 

         print '<select class="flat" id="select_' . $htmlname . '" name="' . $htmlname . '">';

-        if ($addempty)

-            print '<option value="0"' . (empty($selected) ? ' selected' : '') . '>&nbsp;</option>';

+        if ($addempty) {
+                    print '<option value="0"' . (empty($selected) ? ' selected' : '') . '>&nbsp;</option>';
+        }
         foreach ($this->cache_demand_reason as $id => $arraydemandreason) {

-            if ($arraydemandreason['code'] == $exclude)

-                continue;

+            if ($arraydemandreason['code'] == $exclude) {
+                            continue;
+            }
 

             if ($selected && ($selected == $arraydemandreason['id'] || $selected == $arraydemandreason['code'])) {

                 print '<option value="' . $arraydemandreason['id'] . '" selected>';

@@ -3124,8 +3271,9 @@ 
             print '</option>';

         }

         print '</select>';

-        if ($user->admin)

-            print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+        if ($user->admin) {
+                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+        }
     }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -3140,8 +3288,10 @@ 
         global $langs;

 

         $num = count($this->cache_types_paiements);

-        if ($num > 0)

-            return $num;    // Cache already loaded

+        if ($num > 0) {
+                    return $num;
+        }
+        // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

@@ -3202,12 +3352,14 @@ 
         $this->load_cache_conditions_paiements();

 

         // Set default value if not already set by caller

-        if (empty($selected) && !empty($conf->global->MAIN_DEFAULT_PAYMENT_TERM_ID))

-            $selected = $conf->global->MAIN_DEFAULT_PAYMENT_TERM_ID;

+        if (empty($selected) && !empty($conf->global->MAIN_DEFAULT_PAYMENT_TERM_ID)) {
+                    $selected = $conf->global->MAIN_DEFAULT_PAYMENT_TERM_ID;
+        }
 

         print '<select id="' . $htmlname . '" class="flat selectpaymentterms' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '">';

-        if ($addempty)

-            print '<option value="0">&nbsp;</option>';

+        if ($addempty) {
+                    print '<option value="0">&nbsp;</option>';
+        }
         foreach ($this->cache_conditions_paiements as $id => $arrayconditions) {

             if ($selected == $id) {

                 print '<option value="' . $id . '" selected>';

@@ -3218,8 +3370,9 @@ 
             print '</option>';

         }

         print '</select>';

-        if ($user->admin && empty($noinfoadmin))

-            print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+        if ($user->admin && empty($noinfoadmin)) {
+                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+        }
     }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -3245,59 +3398,68 @@ 
         dol_syslog(__METHOD__ . " " . $selected . ", " . $htmlname . ", " . $filtertype . ", " . $format, LOG_DEBUG);

 

         $filterarray = array();

-        if ($filtertype == 'CRDT')

-            $filterarray = array(0, 2, 3);

-        elseif ($filtertype == 'DBIT')

-            $filterarray = array(1, 2, 3);

-        elseif ($filtertype != '' && $filtertype != '-1')

-            $filterarray = explode(',', $filtertype);

+        if ($filtertype == 'CRDT') {
+                    $filterarray = array(0, 2, 3);
+        } elseif ($filtertype == 'DBIT') {
+                    $filterarray = array(1, 2, 3);
+        } elseif ($filtertype != '' && $filtertype != '-1') {
+                    $filterarray = explode(',', $filtertype);
+        }
 

         $this->load_cache_types_paiements();

 

         print '<select id="select' . $htmlname . '" class="flat selectpaymenttypes' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '">';

-        if ($empty)

-            print '<option value="">&nbsp;</option>';

+        if ($empty) {
+                    print '<option value="">&nbsp;</option>';
+        }
         foreach ($this->cache_types_paiements as $id => $arraytypes) {

             // If not good status

-            if ($active >= 0 && $arraytypes['active'] != $active)

-                continue;

+            if ($active >= 0 && $arraytypes['active'] != $active) {
+                            continue;
+            }
 

             // On passe si on a demande de filtrer sur des modes de paiments particuliers

-            if (count($filterarray) && !in_array($arraytypes['type'], $filterarray))

-                continue;

+            if (count($filterarray) && !in_array($arraytypes['type'], $filterarray)) {
+                            continue;
+            }
 

             // We discard empty line if showempty is on because an empty line has already been output.

-            if ($empty && empty($arraytypes['code']))

-                continue;

-

-            if ($format == 0)

-                print '<option value="' . $id . '"';

-            elseif ($format == 1)

-                print '<option value="' . $arraytypes['code'] . '"';

-            elseif ($format == 2)

-                print '<option value="' . $arraytypes['code'] . '"';

-            elseif ($format == 3)

-                print '<option value="' . $id . '"';

+            if ($empty && empty($arraytypes['code'])) {
+                            continue;
+            }
+

+            if ($format == 0) {
+                            print '<option value="' . $id . '"';
+            } elseif ($format == 1) {
+                            print '<option value="' . $arraytypes['code'] . '"';
+            } elseif ($format == 2) {
+                            print '<option value="' . $arraytypes['code'] . '"';
+            } elseif ($format == 3) {
+                            print '<option value="' . $id . '"';
+            }
             // Si selected est text, on compare avec code, sinon avec id

-            if (preg_match('/[a-z]/i', $selected) && $selected == $arraytypes['code'])

-                print ' selected';

-            elseif ($selected == $id)

-                print ' selected';

+            if (preg_match('/[a-z]/i', $selected) && $selected == $arraytypes['code']) {
+                            print ' selected';
+            } elseif ($selected == $id) {
+                            print ' selected';
+            }
             print '>';

-            if ($format == 0)

-                $value = ($maxlength ? dol_trunc($arraytypes['label'], $maxlength) : $arraytypes['label']);

-            elseif ($format == 1)

-                $value = $arraytypes['code'];

-            elseif ($format == 2)

-                $value = ($maxlength ? dol_trunc($arraytypes['label'], $maxlength) : $arraytypes['label']);

-            elseif ($format == 3)

-                $value = $arraytypes['code'];

+            if ($format == 0) {
+                            $value = ($maxlength ? dol_trunc($arraytypes['label'], $maxlength) : $arraytypes['label']);
+            } elseif ($format == 1) {
+                            $value = $arraytypes['code'];
+            } elseif ($format == 2) {
+                            $value = ($maxlength ? dol_trunc($arraytypes['label'], $maxlength) : $arraytypes['label']);
+            } elseif ($format == 3) {
+                            $value = $arraytypes['code'];
+            }
             print $value ? $value : '&nbsp;';

             print '</option>';

         }

         print '</select>';

-        if ($user->admin && !$noadmininfo)

-            print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+        if ($user->admin && !$noadmininfo) {
+                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+        }
     }

 

     /**

@@ -3351,8 +3513,9 @@ 
         $sql = "SELECT rowid, code, libelle as label";

         $sql .= " FROM " . MAIN_DB_PREFIX . "c_shipment_mode";

         $sql .= " WHERE active > 0";

-        if ($filtre)

-            $sql .= " AND " . $filtre;

+        if ($filtre) {
+                    $sql .= " AND " . $filtre;
+        }
         $sql .= " ORDER BY libelle ASC";

 

         dol_syslog(get_class($this) . "::selectShippingMode", LOG_DEBUG);

@@ -3377,8 +3540,9 @@ 
                     $i++;

                 }

                 print "</select>";

-                if ($user->admin)

-                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+                if ($user->admin) {
+                                    print info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+                }
             } else {

                 print $langs->trans("NoShippingMethodDefined");

             }

@@ -3491,8 +3655,9 @@ 
 

         $resql = $this->db->query($sql);

         if ($resql && $this->db->num_rows($resql) > 0) {

-            if ($showempty)

-                $return .= '<option value="none"></option>';

+            if ($showempty) {
+                            $return .= '<option value="none"></option>';
+            }
 

             while ($res = $this->db->fetch_object($resql)) {

                 $unitLabel = $res->label;

@@ -3535,10 +3700,12 @@ 
         $sql = "SELECT rowid, label, bank, clos as status, currency_code";

         $sql .= " FROM " . MAIN_DB_PREFIX . "bank_account";

         $sql .= " WHERE entity IN (" . getEntity('bank_account') . ")";

-        if ($statut != 2)

-            $sql .= " AND clos = '" . $statut . "'";

-        if ($filtre)

-            $sql .= " AND " . $filtre;

+        if ($statut != 2) {
+                    $sql .= " AND clos = '" . $statut . "'";
+        }
+        if ($filtre) {
+                    $sql .= " AND " . $filtre;
+        }
         $sql .= " ORDER BY label";

 

         dol_syslog(get_class($this) . "::select_comptes", LOG_DEBUG);

@@ -3560,23 +3727,24 @@ 
                         print '<option value="' . $obj->rowid . '">';

                     }

                     print trim($obj->label);

-                    if ($showcurrency)

-                        print ' (' . $obj->currency_code . ')';

-                    if ($statut == 2 && $obj->status == 1)

-                        print ' (' . $langs->trans("Closed") . ')';

+                    if ($showcurrency) {
+                                            print ' (' . $obj->currency_code . ')';
+                    }
+                    if ($statut == 2 && $obj->status == 1) {
+                                            print ' (' . $langs->trans("Closed") . ')';
+                    }
                     print '</option>';

                     $i++;

                 }

                 print "</select>";

+            } else {

+                if ($statut == 0) {
+                                    print '<span class="opacitymedium">' . $langs->trans("NoActiveBankAccountDefined") . '</span>';
+                } else {
+                                    print '<span class="opacitymedium">' . $langs->trans("NoBankAccountFound") . '</span>';
+                }
             }

-            else {

-                if ($statut == 0)

-                    print '<span class="opacitymedium">' . $langs->trans("NoActiveBankAccountDefined") . '</span>';

-                else

-                    print '<span class="opacitymedium">' . $langs->trans("NoBankAccountFound") . '</span>';

-            }

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

 

@@ -3600,8 +3768,9 @@ 
             print '<input type="hidden" name="action" value="setbankaccount">';

             print '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';

             $nbaccountfound = $this->select_comptes($selected, $htmlname, 0, '', $addempty);

-            if ($nbaccountfound > 0)

-                print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';

+            if ($nbaccountfound > 0) {
+                            print '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';
+            }
             print '</form>';

         } else {

 

@@ -3611,8 +3780,9 @@ 
                 require_once DOL_DOCUMENT_ROOT . '/compta/bank/class/account.class.php';

                 $bankstatic = new Account($this->db);

                 $result = $bankstatic->fetch($selected);

-                if ($result)

-                    print $bankstatic->getNomUrl(1);

+                if ($result) {
+                                    print $bankstatic->getNomUrl(1);
+                }
             } else {

                 print "&nbsp;";

             }

@@ -3658,15 +3828,16 @@ 
                 $i = 0;

                 while ($i < $num) {

                     $objp = $this->db->fetch_object($result);

-                    if ($objp)

-                        $cate_arbo[$objp->rowid] = array('id' => $objp->rowid, 'fulllabel' => $objp->label);

+                    if ($objp) {
+                                            $cate_arbo[$objp->rowid] = array('id' => $objp->rowid, 'fulllabel' => $objp->label);
+                    }
                     $i++;

                 }

                 $this->db->free($result);

-            } else

-                dol_print_error($this->db);

-        }

-        else {

+            } else {
+                            dol_print_error($this->db);
+            }
+        } else {

             $cat = new Categorie($this->db);

             $cate_arbo = $cat->get_full_arbo($type, $excludeafterid);

         }

@@ -3674,9 +3845,9 @@ 
         $output = '<select class="flat" name="' . $htmlname . '" id="' . $htmlname . '">';

         $outarray = array();

         if (is_array($cate_arbo)) {

-            if (!count($cate_arbo))

-                $output .= '<option value="-1" disabled>' . $langs->trans("NoCategoriesDefined") . '</option>';

-            else {

+            if (!count($cate_arbo)) {
+                            $output .= '<option value="-1" disabled>' . $langs->trans("NoCategoriesDefined") . '</option>';
+            } else {

                 $output .= '<option value="-1">&nbsp;</option>';

                 foreach ($cate_arbo as $key => $value) {

                     if ($cate_arbo[$key]['id'] == $selected || ($selected == 'auto' && count($cate_arbo) == 1)) {

@@ -3693,8 +3864,9 @@ 
         $output .= '</select>';

         $output .= "\n";

 

-        if ($outputmode)

-            return $outarray;

+        if ($outputmode) {
+                    return $outarray;
+        }
         return $output;

     }

 

@@ -3758,8 +3930,9 @@ 
 

         // Clean parameters

         $newselectedchoice = empty($selectedchoice) ? "no" : $selectedchoice;

-        if ($conf->browser->layout == 'phone')

-            $width = '95%';

+        if ($conf->browser->layout == 'phone') {
+                    $width = '95%';
+        }
 

         if (is_array($formquestion) && !empty($formquestion)) {

             // First add hidden fields and value

@@ -3773,8 +3946,9 @@ 
 

             // Now add questions

             $more .= '<table class="paddingtopbottomonly" width="100%">' . "\n";

-            if (!empty($formquestion['text']))

-                $more .= '<tr><td colspan="2">' . $formquestion['text'] . '</td></tr>' . "\n";

+            if (!empty($formquestion['text'])) {
+                            $more .= '<tr><td colspan="2">' . $formquestion['text'] . '</td></tr>' . "\n";
+            }
             foreach ($formquestion as $key => $input) {

                 if (is_array($input) && !empty($input)) {

                     $size = (!empty($input['size']) ? ' size="' . $input['size'] . '"' : '');

@@ -3787,42 +3961,45 @@ 
                         $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td><td align="left"><input type="password" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '"' . $size . ' value="' . $input['value'] . '"' . $moreattr . ' /></td></tr>' . "\n";

                     } elseif ($input['type'] == 'select') {

                         $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>';

-                        if (!empty($input['label']))

-                            $more .= $input['label'] . '</td><td class="tdtop" align="left">';

+                        if (!empty($input['label'])) {
+                                                    $more .= $input['label'] . '</td><td class="tdtop" align="left">';
+                        }
                         $more .= $this->selectarray($input['name'], $input['values'], $input['default'], 1, 0, 0, $moreattr, 0, 0, 0, '', $morecss);

                         $more .= '</td></tr>' . "\n";

-                    }

-                    elseif ($input['type'] == 'checkbox') {

+                    } elseif ($input['type'] == 'checkbox') {

                         $more .= '<tr>';

                         $more .= '<td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . ' </td><td align="left">';

                         $more .= '<input type="checkbox" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '"' . $moreattr;

-                        if (!is_bool($input['value']) && $input['value'] != 'false' && $input['value'] != '0')

-                            $more .= ' checked';

-                        if (is_bool($input['value']) && $input['value'])

-                            $more .= ' checked';

-                        if (isset($input['disabled']))

-                            $more .= ' disabled';

+                        if (!is_bool($input['value']) && $input['value'] != 'false' && $input['value'] != '0') {
+                                                    $more .= ' checked';
+                        }
+                        if (is_bool($input['value']) && $input['value']) {
+                                                    $more .= ' checked';
+                        }
+                        if (isset($input['disabled'])) {
+                                                    $more .= ' disabled';
+                        }
                         $more .= ' /></td>';

                         $more .= '</tr>' . "\n";

-                    }

-                    elseif ($input['type'] == 'radio') {

+                    } elseif ($input['type'] == 'radio') {

                         $i = 0;

                         foreach ($input['values'] as $selkey => $selval) {

                             $more .= '<tr>';

-                            if ($i == 0)

-                                $more .= '<td' . (empty($input['tdclass']) ? ' class="tdtop"' : (' class="tdtop ' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td>';

-                            else

-                                $more .= '<td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>&nbsp;</td>';

+                            if ($i == 0) {
+                                                            $more .= '<td' . (empty($input['tdclass']) ? ' class="tdtop"' : (' class="tdtop ' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td>';
+                            } else {
+                                                            $more .= '<td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>&nbsp;</td>';
+                            }
                             $more .= '<td><input type="radio" class="flat' . $morecss . '" id="' . $input['name'] . '" name="' . $input['name'] . '" value="' . $selkey . '"' . $moreattr;

-                            if ($input['disabled'])

-                                $more .= ' disabled';

+                            if ($input['disabled']) {
+                                                            $more .= ' disabled';
+                            }
                             $more .= ' /> ';

                             $more .= $selval;

                             $more .= '</td></tr>' . "\n";

                             $i++;

                         }

-                    }

-                    elseif ($input['type'] == 'date') {

+                    } elseif ($input['type'] == 'date') {

                         $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>' . $input['label'] . '</td>';

                         $more .= '<td align="left">';

                         $more .= $this->selectDate($input['value'], $input['name'], 0, 0, 0, '', 1, 0);

@@ -3834,13 +4011,12 @@ 
                         $formquestion[] = array('name' => $input['name'] . 'min');

                     } elseif ($input['type'] == 'other') {

                         $more .= '<tr><td' . (empty($input['tdclass']) ? '' : (' class="' . $input['tdclass'] . '"')) . '>';

-                        if (!empty($input['label']))

-                            $more .= $input['label'] . '</td><td align="left">';

+                        if (!empty($input['label'])) {
+                                                    $more .= $input['label'] . '</td><td align="left">';
+                        }
                         $more .= $input['value'];

                         $more .= '</td></tr>' . "\n";

-                    }

-

-                    elseif ($input['type'] == 'onecolumn') {

+                    } elseif ($input['type'] == 'onecolumn') {

                         $more .= '<tr><td colspan="2" align="left">';

                         $more .= $input['value'];

                         $more .= '</td></tr>' . "\n";

@@ -3853,10 +4029,12 @@ 
         // JQUI method dialog is broken with jmobile, we use standard HTML.

         // Note: When using dol_use_jmobile or no js, you must also check code for button use a GET url with action=xxx and check that you also output the confirm code when action=xxx

         // See page product/card.php for example

-        if (!empty($conf->dol_use_jmobile))

-            $useajax = 0;

-        if (empty($conf->use_javascript_ajax))

-            $useajax = 0;

+        if (!empty($conf->dol_use_jmobile)) {
+                    $useajax = 0;
+        }
+        if (empty($conf->use_javascript_ajax)) {
+                    $useajax = 0;
+        }
 

         if ($useajax) {

             $autoOpen = true;

@@ -3874,10 +4052,12 @@ 
             if (is_array($formquestion)) {

                 foreach ($formquestion as $key => $input) {

                     //print "xx ".$key." rr ".is_array($input)."<br>\n";

-                    if (is_array($input) && isset($input['name']))

-                        array_push($inputok, $input['name']);

-                    if (isset($input['inputko']) && $input['inputko'] == 1)

-                        array_push($inputko, $input['name']);

+                    if (is_array($input) && isset($input['name'])) {
+                                            array_push($inputok, $input['name']);
+                    }
+                    if (isset($input['inputko']) && $input['inputko'] == 1) {
+                                            array_push($inputko, $input['name']);
+                    }
                 }

             }

             // Show JQuery confirm box. Note that global var $useglobalvars is used inside this template

@@ -3962,12 +4142,14 @@ 
         } else {

             $formconfirm .= "\n<!-- begin formconfirm page=" . $page . " -->\n";

 

-            if (empty($disableformtag))

-                $formconfirm .= '<form method="POST" action="' . $page . '" class="notoptoleftroright">' . "\n";

+            if (empty($disableformtag)) {
+                            $formconfirm .= '<form method="POST" action="' . $page . '" class="notoptoleftroright">' . "\n";
+            }
 

             $formconfirm .= '<input type="hidden" name="action" value="' . $action . '">' . "\n";

-            if (empty($disableformtag))

-                $formconfirm .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">' . "\n";

+            if (empty($disableformtag)) {
+                            $formconfirm .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">' . "\n";
+            }
 

             $formconfirm .= '<table width="100%" class="valid">' . "\n";

 

@@ -3992,8 +4174,9 @@ 
 

             $formconfirm .= '</table>' . "\n";

 

-            if (empty($disableformtag))

-                $formconfirm .= "</form>\n";

+            if (empty($disableformtag)) {
+                            $formconfirm .= "</form>\n";
+            }
             $formconfirm .= '<br>';

 

             $formconfirm .= "<!-- end formconfirm -->\n";

@@ -4183,14 +4366,16 @@ 
             $ret .= '<td align="left"><input type="submit" class="button" value="' . $langs->trans("Modify") . '"></td>';

             $ret .= '</tr></table></form>';

         } else {

-            if ($displayhour)

-                $ret .= dol_print_date($selected, 'dayhour');

-            else

-                $ret .= dol_print_date($selected, 'day');

+            if ($displayhour) {
+                            $ret .= dol_print_date($selected, 'dayhour');
+            } else {
+                            $ret .= dol_print_date($selected, 'day');
+            }
         }

 

-        if (empty($nooutput))

-            print $ret;

+        if (empty($nooutput)) {
+                    print $ret;
+        }
         return $ret;

     }

 

@@ -4316,10 +4501,10 @@ 
         } else {

             if (!empty($rate)) {

                 print price($rate, 1, $langs, 1, 0);

-                if ($currency && $rate != 1)

-                    print ' &nbsp; (' . price($rate, 1, $langs, 1, 0) . ' ' . $currency . ' = 1 ' . $conf->currency . ')';

-            }

-            else {

+                if ($currency && $rate != 1) {
+                                    print ' &nbsp; (' . price($rate, 1, $langs, 1, 0) . ' ' . $currency . ' = 1 ' . $conf->currency . ')';
+                }
+            } else {

                 print 1;

             }

         }

@@ -4352,34 +4537,41 @@ 
             print '<div class="inline-block">';

             if (!empty($discount_type)) {

                 if (!empty($conf->global->FACTURE_DEPOSITS_ARE_JUST_PAYMENTS)) {

-                    if (!$filter || $filter == "fk_invoice_supplier_source IS NULL")

-                        $translationKey = 'HasAbsoluteDiscountFromSupplier';    // If we want deposit to be substracted to payments only and not to total of final invoice

-                    else

-                        $translationKey = 'HasCreditNoteFromSupplier';

-                }

-                else {

-                    if (!$filter || $filter == "fk_invoice_supplier_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS PAID)%')")

-                        $translationKey = 'HasAbsoluteDiscountFromSupplier';

-                    else

-                        $translationKey = 'HasCreditNoteFromSupplier';

+                    if (!$filter || $filter == "fk_invoice_supplier_source IS NULL") {
+                                            $translationKey = 'HasAbsoluteDiscountFromSupplier';
+                    }
+                    // If we want deposit to be substracted to payments only and not to total of final invoice

+                    else {
+                                            $translationKey = 'HasCreditNoteFromSupplier';
+                    }
+                } else {

+                    if (!$filter || $filter == "fk_invoice_supplier_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS PAID)%')") {
+                                            $translationKey = 'HasAbsoluteDiscountFromSupplier';
+                    } else {
+                                            $translationKey = 'HasCreditNoteFromSupplier';
+                    }
                 }

             } else {

                 if (!empty($conf->global->FACTURE_DEPOSITS_ARE_JUST_PAYMENTS)) {

-                    if (!$filter || $filter == "fk_facture_source IS NULL")

-                        $translationKey = 'CompanyHasAbsoluteDiscount';    // If we want deposit to be substracted to payments only and not to total of final invoice

-                    else

-                        $translationKey = 'CompanyHasCreditNote';

-                }

-                else {

-                    if (!$filter || $filter == "fk_facture_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS RECEIVED)%')")

-                        $translationKey = 'CompanyHasAbsoluteDiscount';

-                    else

-                        $translationKey = 'CompanyHasCreditNote';

+                    if (!$filter || $filter == "fk_facture_source IS NULL") {
+                                            $translationKey = 'CompanyHasAbsoluteDiscount';
+                    }
+                    // If we want deposit to be substracted to payments only and not to total of final invoice

+                    else {
+                                            $translationKey = 'CompanyHasCreditNote';
+                    }
+                } else {

+                    if (!$filter || $filter == "fk_facture_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS RECEIVED)%')") {
+                                            $translationKey = 'CompanyHasAbsoluteDiscount';
+                    } else {
+                                            $translationKey = 'CompanyHasCreditNote';
+                    }
                 }

             }

             print $langs->trans($translationKey, price($amount, 0, $langs, 0, 0, -1, $conf->currency));

-            if (empty($hidelist))

-                print ': ';

+            if (empty($hidelist)) {
+                            print ': ';
+            }
             print '</div>';

             if (empty($hidelist)) {

                 print '<div class="inline-block" style="padding-right: 10px">';

@@ -4389,15 +4581,18 @@ 
                 } else {

                     $newfilter .= ' AND fk_facture IS NULL AND fk_facture_line IS NULL'; // Customer discounts available

                 }

-                if ($filter)

-                    $newfilter .= ' AND (' . $filter . ')';

+                if ($filter) {
+                                    $newfilter .= ' AND (' . $filter . ')';
+                }
                 $nbqualifiedlines = $this->select_remises($selected, $htmlname, $newfilter, $socid, $maxvalue);

                 if ($nbqualifiedlines > 0) {

                     print ' &nbsp; <input type="submit" class="button" value="' . dol_escape_htmltag($langs->trans("UseLine")) . '"';

-                    if (!empty($discount_type) && $filter && $filter != "fk_invoice_supplier_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS PAID)%')")

-                        print ' title="' . $langs->trans("UseCreditNoteInInvoicePayment") . '"';

-                    if (empty($discount_type) && $filter && $filter != "fk_facture_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS RECEIVED)%')")

-                        print ' title="' . $langs->trans("UseCreditNoteInInvoicePayment") . '"';

+                    if (!empty($discount_type) && $filter && $filter != "fk_invoice_supplier_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS PAID)%')") {
+                                            print ' title="' . $langs->trans("UseCreditNoteInInvoicePayment") . '"';
+                    }
+                    if (empty($discount_type) && $filter && $filter != "fk_facture_source IS NULL OR (description LIKE '(DEPOSIT)%' AND description NOT LIKE '(EXCESS RECEIVED)%')") {
+                                            print ' title="' . $langs->trans("UseCreditNoteInInvoicePayment") . '"';
+                    }
 

                     print '>';

                 }

@@ -4498,10 +4693,11 @@ 
             }

         }

 

-        if ($nooutput)

-            return $out;

-        else

-            print $out;

+        if ($nooutput) {
+                    return $out;
+        } else {
+                    print $out;
+        }
     }

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -4534,8 +4730,10 @@ 
 

         $out = '';

 

-        if ($selected == 'euro' || $selected == 'euros')

-            $selected = 'EUR';   // Pour compatibilite

+        if ($selected == 'euro' || $selected == 'euros') {
+                    $selected = 'EUR';
+        }
+        // Pour compatibilite

 

         $out .= '<select class="flat maxwidth200onsmartphone minwidth300" name="' . $htmlname . '" id="' . $htmlname . '">';

         foreach ($langs->cache_currencies as $code_iso => $currency) {

@@ -4549,8 +4747,9 @@ 
             $out .= '</option>';

         }

         $out .= '</select>';

-        if ($user->admin)

-            $out .= info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+        if ($user->admin) {
+                    $out .= info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+        }
 

         // Make select dynamic

         include_once DOL_DOCUMENT_ROOT . '/core/lib/ajax.lib.php';

@@ -4579,14 +4778,16 @@ 
         $sql .= " WHERE entity IN ('" . getEntity('mutlicurrency') . "')";

         $resql = $db->query($sql);

         if ($resql) {

-            while ($obj = $db->fetch_object($resql))

-                $TCurrency[$obj->code] = $obj->code;

+            while ($obj = $db->fetch_object($resql)) {
+                            $TCurrency[$obj->code] = $obj->code;
+            }
         }

 

         $out = '';

         $out .= '<select class="flat" name="' . $htmlname . '" id="' . $htmlname . '">';

-        if ($useempty)

-            $out .= '<option value=""></option>';

+        if ($useempty) {
+                    $out .= '<option value=""></option>';
+        }
         // If company current currency not in table, we add it into list. Should always be available.

         if (!in_array($conf->currency, $TCurrency)) {

             $TCurrency[$conf->currency] = $conf->currency;

@@ -4594,10 +4795,11 @@ 
         if (count($TCurrency) > 0) {

             foreach ($langs->cache_currencies as $code_iso => $currency) {

                 if (isset($TCurrency[$code_iso])) {

-                    if (!empty($selected) && $selected == $code_iso)

-                        $out .= '<option value="' . $code_iso . '" selected="selected">';

-                    else

-                        $out .= '<option value="' . $code_iso . '">';

+                    if (!empty($selected) && $selected == $code_iso) {
+                                            $out .= '<option value="' . $code_iso . '" selected="selected">';
+                    } else {
+                                            $out .= '<option value="' . $code_iso . '">';
+                    }
 

                     $out .= $currency['label'];

                     $out .= ' (' . $langs->getCurrencySymbol($code_iso) . ')';

@@ -4627,8 +4829,10 @@ 
         global $langs;

 

         $num = count($this->cache_vatrates);

-        if ($num > 0)

-            return $num;    // Cache already loaded

+        if ($num > 0) {
+                    return $num;
+        }
+        // Cache already loaded

 

         dol_syslog(__METHOD__, LOG_DEBUG);

 

@@ -4657,20 +4861,23 @@ 
                     $this->cache_vatrates[$i]['label'] = $obj->taux . '%' . ($obj->code ? ' (' . $obj->code . ')' : '');   // Label must contains only 0-9 , . % or *

                     $this->cache_vatrates[$i]['labelallrates'] = $obj->taux . '/' . ($obj->localtax1 ? $obj->localtax1 : '0') . '/' . ($obj->localtax2 ? $obj->localtax2 : '0') . ($obj->code ? ' (' . $obj->code . ')' : ''); // Must never be used as key, only label

                     $positiverates = '';

-                    if ($obj->taux)

-                        $positiverates .= ($positiverates ? '/' : '') . $obj->taux;

-                    if ($obj->localtax1)

-                        $positiverates .= ($positiverates ? '/' : '') . $obj->localtax1;

-                    if ($obj->localtax2)

-                        $positiverates .= ($positiverates ? '/' : '') . $obj->localtax2;

-                    if (empty($positiverates))

-                        $positiverates = '0';

+                    if ($obj->taux) {
+                                            $positiverates .= ($positiverates ? '/' : '') . $obj->taux;
+                    }
+                    if ($obj->localtax1) {
+                                            $positiverates .= ($positiverates ? '/' : '') . $obj->localtax1;
+                    }
+                    if ($obj->localtax2) {
+                                            $positiverates .= ($positiverates ? '/' : '') . $obj->localtax2;
+                    }
+                    if (empty($positiverates)) {
+                                            $positiverates = '0';
+                    }
                     $this->cache_vatrates[$i]['labelpositiverates'] = $positiverates . ($obj->code ? ' (' . $obj->code . ')' : ''); // Must never be used as key, only label

                 }

 

                 return $num;

-            }

-            else {

+            } else {

                 $this->error = '<font class="error">' . $langs->trans("ErrorNoVATRateDefinedForSellerCountry", $country_code) . '</font>';

                 return -1;

             }

@@ -4807,16 +5014,19 @@ 
             $selectedfound = false;

             foreach ($this->cache_vatrates as $rate) {

                 // Keep only 0 if seller is not subject to VAT

-                if ($disabled && $rate['txtva'] != 0)

-                    continue;

+                if ($disabled && $rate['txtva'] != 0) {
+                                    continue;
+                }
 

                 // Define key to use into select list

                 $key = $rate['txtva'];

                 $key .= $rate['nprtva'] ? '*' : '';

-                if ($mode > 0 && $rate['code'])

-                    $key .= ' (' . $rate['code'] . ')';

-                if ($mode < 0)

-                    $key = $rate['rowid'];

+                if ($mode > 0 && $rate['code']) {
+                                    $key .= ' (' . $rate['code'] . ')';
+                }
+                if ($mode < 0) {
+                                    $key = $rate['rowid'];
+                }
 

                 $return .= '<option value="' . $key . '"';

                 if (!$selectedfound) {

@@ -4843,10 +5053,10 @@ 
                 $return .= '</option>';

             }

 

-            if (!$options_only)

-                $return .= '</select>';

-        }

-        else {

+            if (!$options_only) {
+                            $return .= '</select>';
+            }
+        } else {

             $return .= $this->error;

         }

 

@@ -4918,12 +5128,15 @@ 
 

         $retstring = '';

 

-        if ($prefix == '')

-            $prefix = 're';

-        if ($h == '')

-            $h = 0;

-        if ($m == '')

-            $m = 0;

+        if ($prefix == '') {
+                    $prefix = 're';
+        }
+        if ($h == '') {
+                    $h = 0;
+        }
+        if ($m == '') {
+                    $m = 0;
+        }
         $emptydate = 0;

         $emptyhours = 0;

         if ($empty == 1) {

@@ -4972,10 +5185,12 @@ 
             $smin = !isset($conf->global->MAIN_DEFAULT_DATE_MIN) ? ($h == -1 ? '59' : '') : $conf->global->MAIN_DEFAULT_DATE_MIN;

             $ssec = !isset($conf->global->MAIN_DEFAULT_DATE_SEC) ? ($h == -1 ? '59' : '') : $conf->global->MAIN_DEFAULT_DATE_SEC;

         }

-        if ($h == 3)

-            $shour = '';

-        if ($m == 3)

-            $smin = '';

+        if ($h == 3) {
+                    $shour = '';
+        }
+        if ($m == 3) {
+                    $smin = '';
+        }
 

         // You can set MAIN_POPUP_CALENDAR to 'eldy' or 'jquery'

         $usecalendar = 'combo';

@@ -5007,14 +5222,14 @@ 
                         $base = DOL_URL_ROOT . '/core/';

                         $retstring .= ' onClick="showDP(\'' . $base . '\',\'' . $prefix . '\',\'' . $langs->trans("FormatDateShortJavaInput") . '\',\'' . $langs->defaultlang . '\');"';

                         $retstring .= '>' . img_object($langs->trans("SelectDate"), 'calendarday', 'class="datecallink"') . '</button>';

-                    } else

-                        $retstring .= '<button id="' . $prefix . 'Button" type="button" class="dpInvisibleButtons">' . img_object($langs->trans("Disabled"), 'calendarday', 'class="datecallink"') . '</button>';

+                    } else {
+                                            $retstring .= '<button id="' . $prefix . 'Button" type="button" class="dpInvisibleButtons">' . img_object($langs->trans("Disabled"), 'calendarday', 'class="datecallink"') . '</button>';
+                    }
 

                     $retstring .= '<input type="hidden" id="' . $prefix . 'day"   name="' . $prefix . 'day"   value="' . $sday . '">' . "\n";

                     $retstring .= '<input type="hidden" id="' . $prefix . 'month" name="' . $prefix . 'month" value="' . $smonth . '">' . "\n";

                     $retstring .= '<input type="hidden" id="' . $prefix . 'year"  name="' . $prefix . 'year"  value="' . $syear . '">' . "\n";

-                }

-                elseif ($usecalendar == 'jquery') {

+                } elseif ($usecalendar == 'jquery') {

                     if (!$disabled) {

                         // Output javascript for datepicker

                         $retstring .= "<script type='text/javascript'>";

@@ -5124,32 +5339,38 @@ 
             }

         }

 

-        if ($d && $h)

-            $retstring .= ($h == 2 ? '<br>' : ' ');

+        if ($d && $h) {
+                    $retstring .= ($h == 2 ? '<br>' : ' ');
+        }
 

         if ($h) {

             // Show hour

             $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth50 ' . ($fullday ? $fullday . 'hour' : '') . '" id="' . $prefix . 'hour" name="' . $prefix . 'hour">';

-            if ($emptyhours)

-                $retstring .= '<option value="-1">&nbsp;</option>';

+            if ($emptyhours) {
+                            $retstring .= '<option value="-1">&nbsp;</option>';
+            }
             for ($hour = 0; $hour < 24; $hour++) {

-                if (strlen($hour) < 2)

-                    $hour = "0" . $hour;

+                if (strlen($hour) < 2) {
+                                    $hour = "0" . $hour;
+                }
                 $retstring .= '<option value="' . $hour . '"' . (($hour == $shour) ? ' selected' : '') . '>' . $hour . (empty($conf->dol_optimize_smallscreen) ? '' : 'H') . '</option>';

             }

             $retstring .= '</select>';

-            if ($m && empty($conf->dol_optimize_smallscreen))

-                $retstring .= ":";

+            if ($m && empty($conf->dol_optimize_smallscreen)) {
+                            $retstring .= ":";
+            }
         }

 

         if ($m) {

             // Show minutes

             $retstring .= '<select' . ($disabled ? ' disabled' : '') . ' class="flat valignmiddle maxwidth50 ' . ($fullday ? $fullday . 'min' : '') . '" id="' . $prefix . 'min" name="' . $prefix . 'min">';

-            if ($emptyhours)

-                $retstring .= '<option value="-1">&nbsp;</option>';

+            if ($emptyhours) {
+                            $retstring .= '<option value="-1">&nbsp;</option>';
+            }
             for ($min = 0; $min < 60; $min++) {

-                if (strlen($min) < 2)

-                    $min = "0" . $min;

+                if (strlen($min) < 2) {
+                                    $min = "0" . $min;
+                }
                 $retstring .= '<option value="' . $min . '"' . (($min == $smin) ? ' selected' : '') . '>' . $min . (empty($conf->dol_optimize_smallscreen) ? '' : '') . '</option>';

             }

             $retstring .= '</select>';

@@ -5180,21 +5401,25 @@ 
               } */

             // Update the hour part

             if ($h) {

-                if ($fullday)

-                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

+                if ($fullday) {
+                                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";
+                }
                 //$reset_scripts .= 'this.form.elements[\''.$prefix.'hour\'].value=formatDate(new Date(), \'HH\'); ';

                 $reset_scripts .= 'jQuery(\'#' . $prefix . 'hour\').val(\'' . dol_print_date(dol_now(), '%H') . '\');';

-                if ($fullday)

-                    $reset_scripts .= ' } ';

+                if ($fullday) {
+                                    $reset_scripts .= ' } ';
+                }
             }

             // Update the minute part

             if ($m) {

-                if ($fullday)

-                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

+                if ($fullday) {
+                                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";
+                }
                 //$reset_scripts .= 'this.form.elements[\''.$prefix.'min\'].value=formatDate(new Date(), \'mm\'); ';

                 $reset_scripts .= 'jQuery(\'#' . $prefix . 'min\').val(\'' . dol_print_date(dol_now(), '%M') . '\');';

-                if ($fullday)

-                    $reset_scripts .= ' } ';

+                if ($fullday) {
+                                    $reset_scripts .= ' } ';
+                }
             }

             // If reset_scripts is not empty, print the link with the reset_scripts in the onClick

             if ($reset_scripts && empty($conf->dol_optimize_smallscreen)) {

@@ -5216,19 +5441,23 @@ 
             $reset_scripts .= 'jQuery(\'#' . $prefix . 'year\').val(\'' . dol_print_date(dol_now(), '%Y') . '\');';

             // Update the hour part

             if ($h) {

-                if ($fullday)

-                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

+                if ($fullday) {
+                                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";
+                }
                 $reset_scripts .= 'jQuery(\'#' . $prefix . 'hour\').val(\'' . dol_print_date(dol_now(), '%H') . '\');';

-                if ($fullday)

-                    $reset_scripts .= ' } ';

+                if ($fullday) {
+                                    $reset_scripts .= ' } ';
+                }
             }

             // Update the minute part

             if ($m) {

-                if ($fullday)

-                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";

+                if ($fullday) {
+                                    $reset_scripts .= " if (jQuery('#fullday:checked').val() == null) {";
+                }
                 $reset_scripts .= 'jQuery(\'#' . $prefix . 'min\').val(\'' . dol_print_date(dol_now(), '%M') . '\');';

-                if ($fullday)

-                    $reset_scripts .= ' } ';

+                if ($fullday) {
+                                    $reset_scripts .= ' } ';
+                }
             }

             // If reset_scripts is not empty, print the link with the reset_scripts in the onClick

             if ($reset_scripts && empty($conf->dol_optimize_smallscreen)) {

@@ -5291,41 +5520,46 @@ 
             $retstring .= "</select>";

         } elseif ($typehour == 'text' || $typehour == 'textselect') {

             $retstring .= '<input placeholder="' . $langs->trans('HourShort') . '" type="number" min="0" size="1" name="' . $prefix . 'hour"' . ($disabled ? ' disabled' : '') . ' class="flat maxwidth50 inputhour" value="' . (($hourSelected != '') ? ((int) $hourSelected) : '') . '">';

-        } else

-            return 'BadValueForParameterTypeHour';

+        } else {
+                    return 'BadValueForParameterTypeHour';
+        }
 

-        if ($typehour != 'text')

-            $retstring .= ' ' . $langs->trans('HourShort');

-        else

-            $retstring .= '<span class="hideonsmartphone">:</span>';

+        if ($typehour != 'text') {
+                    $retstring .= ' ' . $langs->trans('HourShort');
+        } else {
+                    $retstring .= '<span class="hideonsmartphone">:</span>';
+        }
 

         // Minutes

-        if ($minunderhours)

-            $retstring .= '<br>';

-        else

-            $retstring .= '<span class="hideonsmartphone">&nbsp;</span>';

+        if ($minunderhours) {
+                    $retstring .= '<br>';
+        } else {
+                    $retstring .= '<span class="hideonsmartphone">&nbsp;</span>';
+        }
 

         if ($typehour == 'select' || $typehour == 'textselect') {

             $retstring .= '<select class="flat" id="select_' . $prefix . 'min" name="' . $prefix . 'min"' . ($disabled ? ' disabled' : '') . '>';

             for ($min = 0; $min <= 55; $min = $min + 5) {

                 $retstring .= '<option value="' . $min . '"';

-                if ($minSelected == $min)

-                    $retstring .= ' selected';

+                if ($minSelected == $min) {
+                                    $retstring .= ' selected';
+                }
                 $retstring .= '>' . $min . '</option>';

             }

             $retstring .= "</select>";

-        }

-        elseif ($typehour == 'text') {

+        } elseif ($typehour == 'text') {

             $retstring .= '<input placeholder="' . $langs->trans('MinuteShort') . '" type="number" min="0" size="1" name="' . $prefix . 'min"' . ($disabled ? ' disabled' : '') . ' class="flat maxwidth50 inputminute" value="' . (($minSelected != '') ? ((int) $minSelected) : '') . '">';

         }

 

-        if ($typehour != 'text')

-            $retstring .= ' ' . $langs->trans('MinuteShort');

+        if ($typehour != 'text') {
+                    $retstring .= ' ' . $langs->trans('MinuteShort');
+        }
 

         //$retstring.="&nbsp;";

 

-        if (!empty($nooutput))

-            return $retstring;

+        if (!empty($nooutput)) {
+                    return $retstring;
+        }
 

         print $retstring;

         return;

@@ -5368,8 +5602,9 @@ 
         }

 

         $prefixforautocompletemode = $objecttmp->element;

-        if ($prefixforautocompletemode == 'societe')

-            $prefixforautocompletemode = 'company';

+        if ($prefixforautocompletemode == 'societe') {
+                    $prefixforautocompletemode = 'company';
+        }
         $confkeyforautocompletemode = strtoupper($prefixforautocompletemode) . '_USE_SEARCH_TO_SELECT'; // For example COMPANY_USE_SEARCH_TO_SELECT

 

         dol_syslog(get_class($this) . "::selectForForms", LOG_DEBUG);

@@ -5384,11 +5619,11 @@ 
             // Activate the auto complete using ajax call.

             $out .= ajax_autocompleter($preselectedvalue, $htmlname, $urlforajaxcall, $urloption, $conf->global->$confkeyforautocompletemode, 0, array());

             $out .= '<style type="text/css">.ui-autocomplete { z-index: 250; }</style>';

-            if ($placeholder)

-                $placeholder = ' placeholder="' . $placeholder . '"';

+            if ($placeholder) {
+                            $placeholder = ' placeholder="' . $placeholder . '"';
+            }
             $out .= '<input type="text" class="' . $morecss . '" name="search_' . $htmlname . '" id="search_' . $htmlname . '" value="' . $preselectedvalue . '"' . $placeholder . ' />';

-        }

-        else {

+        } else {

             // Immediate load of all database

             $out .= $this->selectForFormsList($objecttmp, $htmlname, $preselectedvalue, $showempty, $searchkey, $placeholder, $morecss, $moreparams, $forcecombo);

         }

@@ -5418,19 +5653,22 @@ 
         global $conf, $langs, $user;

 

         $prefixforautocompletemode = $objecttmp->element;

-        if ($prefixforautocompletemode == 'societe')

-            $prefixforautocompletemode = 'company';

+        if ($prefixforautocompletemode == 'societe') {
+                    $prefixforautocompletemode = 'company';
+        }
         $confkeyforautocompletemode = strtoupper($prefixforautocompletemode) . '_USE_SEARCH_TO_SELECT'; // For example COMPANY_USE_SEARCH_TO_SELECT

 

         $fieldstoshow = 't.ref';

         if (!empty($objecttmp->fields)) { // For object that declare it, it is better to use declared fields ( like societe, contact, ...)

             $tmpfieldstoshow = '';

             foreach ($objecttmp->fields as $key => $val) {

-                if ($val['showoncombobox'])

-                    $tmpfieldstoshow .= ($tmpfieldstoshow ? ',' : '') . 't.' . $key;

+                if ($val['showoncombobox']) {
+                                    $tmpfieldstoshow .= ($tmpfieldstoshow ? ',' : '') . 't.' . $key;
+                }
             }

-            if ($tmpfieldstoshow)

-                $fieldstoshow = $tmpfieldstoshow;

+            if ($tmpfieldstoshow) {
+                            $fieldstoshow = $tmpfieldstoshow;
+            }
         }

 

         $out = '';

@@ -5440,23 +5678,28 @@ 
 

         // Search data

         $sql = "SELECT t.rowid, " . $fieldstoshow . " FROM " . MAIN_DB_PREFIX . $objecttmp->table_element . " as t";

-        if ($objecttmp->ismultientitymanaged == 2)

-            if (!$user->rights->societe->client->voir && !$user->societe_id)

-                $sql .= ", " . MAIN_DB_PREFIX . "societe_commerciaux as sc";

+        if ($objecttmp->ismultientitymanaged == 2) {
+                    if (!$user->rights->societe->client->voir && !$user->societe_id)

+                $sql .= ", " . MAIN_DB_PREFIX . "societe_commerciaux as sc";
+        }
         $sql .= " WHERE 1=1";

-        if (!empty($objecttmp->ismultientitymanaged))

-            $sql .= " AND t.entity IN (" . getEntity($objecttmp->table_element) . ")";

+        if (!empty($objecttmp->ismultientitymanaged)) {
+                    $sql .= " AND t.entity IN (" . getEntity($objecttmp->table_element) . ")";
+        }
         if ($objecttmp->ismultientitymanaged == 1 && !empty($user->societe_id)) {

-            if ($objecttmp->element == 'societe')

-                $sql .= " AND t.rowid = " . $user->societe_id;

-            else

-                $sql .= " AND t.fk_soc = " . $user->societe_id;

-        }

-        if ($searchkey != '')

-            $sql .= natural_search(explode(',', $fieldstoshow), $searchkey);

-        if ($objecttmp->ismultientitymanaged == 2)

-            if (!$user->rights->societe->client->voir && !$user->societe_id)

-                $sql .= " AND t.rowid = sc.fk_soc AND sc.fk_user = " . $user->id;

+            if ($objecttmp->element == 'societe') {
+                            $sql .= " AND t.rowid = " . $user->societe_id;
+            } else {
+                            $sql .= " AND t.fk_soc = " . $user->societe_id;
+            }
+        }

+        if ($searchkey != '') {
+                    $sql .= natural_search(explode(',', $fieldstoshow), $searchkey);
+        }
+        if ($objecttmp->ismultientitymanaged == 2) {
+                    if (!$user->rights->societe->client->voir && !$user->societe_id)

+                $sql .= " AND t.rowid = sc.fk_soc AND sc.fk_user = " . $user->id;
+        }
         $sql .= $this->db->order($fieldstoshow, "ASC");

         //$sql.=$this->db->plimit($limit, 0);

         // Build output string

@@ -5475,13 +5718,15 @@ 
 

             //if (! empty($conf->use_javascript_ajax) || $forcecombo) $textifempty='';

             if (!empty($conf->global->$confkeyforautocompletemode)) {

-                if ($showempty && !is_numeric($showempty))

-                    $textifempty = $langs->trans($showempty);

-                else

-                    $textifempty .= $langs->trans("All");

+                if ($showempty && !is_numeric($showempty)) {
+                                    $textifempty = $langs->trans($showempty);
+                } else {
+                                    $textifempty .= $langs->trans("All");
+                }
             }

-            if ($showempty)

-                $out .= '<option value="-1">' . $textifempty . '</option>' . "\n";

+            if ($showempty) {
+                            $out .= '<option value="-1">' . $textifempty . '</option>' . "\n";
+            }
 

             $num = $this->db->num_rows($resql);

             $i = 0;

@@ -5505,21 +5750,22 @@ 
                     }

 

                     $i++;

-                    if (($i % 10) == 0)

-                        $out .= "\n";

+                    if (($i % 10) == 0) {
+                                            $out .= "\n";
+                    }
                 }

             }

 

             $out .= '</select>' . "\n";

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

 

         $this->result = array('nbofelement' => $num);

 

-        if ($outputmode)

-            return $outarray;

+        if ($outputmode) {
+                    return $outarray;
+        }
         return $out;

     }

 

@@ -5555,8 +5801,9 @@ 
         //if (preg_match('/^multi/',$htmlname)) $jsbeautify = 1;

         $jsbeautify = 1;

 

-        if ($value_as_key)

-            $array = array_combine($array, $array);

+        if ($value_as_key) {
+                    $array = array_combine($array, $array);
+        }
 

         $out = '';

 

@@ -5576,10 +5823,13 @@ 
 

         if ($show_empty) {

             $textforempty = ' ';

-            if (!empty($conf->use_javascript_ajax))

-                $textforempty = '&nbsp;'; // If we use ajaxcombo, we need &nbsp; here to avoid to have an empty element that is too small.

-            if (!is_numeric($show_empty))

-                $textforempty = $show_empty;

+            if (!empty($conf->use_javascript_ajax)) {
+                            $textforempty = '&nbsp;';
+            }
+            // If we use ajaxcombo, we need &nbsp; here to avoid to have an empty element that is too small.

+            if (!is_numeric($show_empty)) {
+                            $textforempty = $show_empty;
+            }
             $out .= '<option class="optiongrey" ' . ($moreparamonempty ? $moreparamonempty . ' ' : '') . 'value="' . ($show_empty < 0 ? $show_empty : -1) . '"' . ($id == $show_empty ? ' selected' : '') . '>' . $textforempty . '</option>' . "\n";

         }

 

@@ -5592,10 +5842,11 @@ 
             }

 

             // Sort

-            if ($sort == 'ASC')

-                asort($array);

-            elseif ($sort == 'DESC')

-                arsort($array);

+            if ($sort == 'ASC') {
+                            asort($array);
+            } elseif ($sort == 'DESC') {
+                            arsort($array);
+            }
 

             foreach ($array as $key => $value) {

                 $disabled = '';

@@ -5609,26 +5860,31 @@ 
                 }

 

                 if ($key_in_label) {

-                    if (empty($nohtmlescape))

-                        $selectOptionValue = dol_escape_htmltag($key . ' - ' . ($maxlen ? dol_trunc($value, $maxlen) : $value));

-                    else

-                        $selectOptionValue = $key . ' - ' . ($maxlen ? dol_trunc($value, $maxlen) : $value);

-                }

-                else {

-                    if (empty($nohtmlescape))

-                        $selectOptionValue = dol_escape_htmltag($maxlen ? dol_trunc($value, $maxlen) : $value);

-                    else

-                        $selectOptionValue = $maxlen ? dol_trunc($value, $maxlen) : $value;

-                    if ($value == '' || $value == '-')

-                        $selectOptionValue = '&nbsp;';

+                    if (empty($nohtmlescape)) {
+                                            $selectOptionValue = dol_escape_htmltag($key . ' - ' . ($maxlen ? dol_trunc($value, $maxlen) : $value));
+                    } else {
+                                            $selectOptionValue = $key . ' - ' . ($maxlen ? dol_trunc($value, $maxlen) : $value);
+                    }
+                } else {

+                    if (empty($nohtmlescape)) {
+                                            $selectOptionValue = dol_escape_htmltag($maxlen ? dol_trunc($value, $maxlen) : $value);
+                    } else {
+                                            $selectOptionValue = $maxlen ? dol_trunc($value, $maxlen) : $value;
+                    }
+                    if ($value == '' || $value == '-') {
+                                            $selectOptionValue = '&nbsp;';
+                    }
                 }

 

                 $out .= '<option value="' . $key . '"';

                 $out .= $style . $disabled;

-                if ($id != '' && $id == $key && !$disabled)

-                    $out .= ' selected';  // To preselect a value

-                if ($nohtmlescape)

-                    $out .= ' data-html="' . dol_escape_htmltag($selectOptionValue) . '"';

+                if ($id != '' && $id == $key && !$disabled) {
+                                    $out .= ' selected';
+                }
+                // To preselect a value

+                if ($nohtmlescape) {
+                                    $out .= ' data-html="' . dol_escape_htmltag($selectOptionValue) . '"';
+                }
                 $out .= '>';

                 //var_dump($selectOptionValue);

                 $out .= $selectOptionValue;

@@ -5664,8 +5920,9 @@ 
         global $delayedhtmlcontent;

 

         // TODO Use an internal dolibarr component instead of select2

-        if (empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) && !defined('REQUIRE_JQUERY_MULTISELECT'))

-            return '';

+        if (empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) && !defined('REQUIRE_JQUERY_MULTISELECT')) {
+                    return '';
+        }
 

         $out = '<select type="text" class="' . $htmlname . ($morecss ? ' ' . $morecss : '') . '" ' . ($moreparam ? $moreparam . ' ' : '') . 'name="' . $htmlname . '"></select>';

 

@@ -5764,8 +6021,9 @@ 
         global $delayedhtmlcontent;

 

         // TODO Use an internal dolibarr component instead of select2

-        if (empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) && !defined('REQUIRE_JQUERY_MULTISELECT'))

-            return '';

+        if (empty($conf->global->MAIN_USE_JQUERY_MULTISELECT) && !defined('REQUIRE_JQUERY_MULTISELECT')) {
+                    return '';
+        }
 

         $out = '<select type="text" class="' . $htmlname . ($morecss ? ' ' . $morecss : '') . '" ' . ($moreparam ? $moreparam . ' ' : '') . 'name="' . $htmlname . '"><option></option></select>';

 

@@ -5935,8 +6193,9 @@ 
 

         $out .= '<select id="' . $htmlname . '" class="multiselect' . ($morecss ? ' ' . $morecss : '') . '" multiple name="' . $htmlname . '[]"' . ($moreattrib ? ' ' . $moreattrib : '') . ($width ? ' style="width: ' . (preg_match('/%/', $width) ? $width : $width . 'px') . '"' : '') . '>' . "\n";

         if (is_array($array) && !empty($array)) {

-            if ($value_as_key)

-                $array = array_combine($array, $array);

+            if ($value_as_key) {
+                            $array = array_combine($array, $array);
+            }
 

             if (!empty($array)) {

                 foreach ($array as $key => $value) {

@@ -5971,8 +6230,9 @@ 
     {

         global $conf, $langs, $user;

 

-        if (!empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER))

-            return '';

+        if (!empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER)) {
+                    return '';
+        }
 

         $tmpvar = "MAIN_SELECTEDFIELDS_" . $varpage;

         if (!empty($user->conf->$tmpvar)) {

@@ -5980,10 +6240,11 @@ 
             foreach ($array as $key => $val) {

                 //var_dump($key);

                 //var_dump($tmparray);

-                if (in_array($key, $tmparray))

-                    $array[$key]['checked'] = 1;

-                else

-                    $array[$key]['checked'] = 0;

+                if (in_array($key, $tmparray)) {
+                                    $array[$key]['checked'] = 1;
+                } else {
+                                    $array[$key]['checked'] = 0;
+                }
             }

         }

         //var_dump($array);

@@ -6149,40 +6410,47 @@ 
                 // To work with non standard path

                 if ($objecttype == 'facture') {

                     $tplpath = 'compta/' . $element;

-                    if (empty($conf->facture->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'facturerec') {

+                    if (empty($conf->facture->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'facturerec') {

                     $tplpath = 'compta/facture';

                     $tplname = 'linkedobjectblockForRec';

-                    if (empty($conf->facture->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'propal') {

+                    if (empty($conf->facture->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'propal') {

                     $tplpath = 'comm/' . $element;

-                    if (empty($conf->propal->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'supplier_proposal') {

-                    if (empty($conf->supplier_proposal->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'shipping' || $objecttype == 'shipment') {

+                    if (empty($conf->propal->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'supplier_proposal') {

+                    if (empty($conf->supplier_proposal->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'shipping' || $objecttype == 'shipment') {

                     $tplpath = 'expedition';

-                    if (empty($conf->expedition->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'reception') {

+                    if (empty($conf->expedition->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'reception') {

                     $tplpath = 'reception';

-                    if (empty($conf->reception->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'delivery') {

+                    if (empty($conf->reception->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'delivery') {

                     $tplpath = 'livraison';

-                    if (empty($conf->expedition->enabled))

-                        continue; // Do not show if module disabled

-                }

-                else if ($objecttype == 'invoice_supplier') {

+                    if (empty($conf->expedition->enabled)) {
+                                            continue;
+                    }
+                    // Do not show if module disabled

+                } else if ($objecttype == 'invoice_supplier') {

                     $tplpath = 'fourn/facture';

                 } else if ($objecttype == 'order_supplier') {

                     $tplpath = 'fourn/commande';

@@ -6246,20 +6514,23 @@ 
         $linktoelemlist = '';

         $listofidcompanytoscan = '';

 

-        if (!is_object($object->thirdparty))

-            $object->fetch_thirdparty();

+        if (!is_object($object->thirdparty)) {
+                    $object->fetch_thirdparty();
+        }
 

         $possiblelinks = array();

         if (is_object($object->thirdparty) && !empty($object->thirdparty->id) && $object->thirdparty->id > 0) {

             $listofidcompanytoscan = $object->thirdparty->id;

-            if (($object->thirdparty->parent > 0) && !empty($conf->global->THIRDPARTY_INCLUDE_PARENT_IN_LINKTO))

-                $listofidcompanytoscan .= ',' . $object->thirdparty->parent;

+            if (($object->thirdparty->parent > 0) && !empty($conf->global->THIRDPARTY_INCLUDE_PARENT_IN_LINKTO)) {
+                            $listofidcompanytoscan .= ',' . $object->thirdparty->parent;
+            }
             if (($object->fk_project > 0) && !empty($conf->global->THIRDPARTY_INCLUDE_PROJECT_THIRDPARY_IN_LINKTO)) {

                 include_once DOL_DOCUMENT_ROOT . '/projet/class/project.class.php';

                 $tmpproject = new Project($this->db);

                 $tmpproject->fetch($object->fk_project);

-                if ($tmpproject->socid > 0 && ($tmpproject->socid != $object->thirdparty->id))

-                    $listofidcompanytoscan .= ',' . $tmpproject->socid;

+                if ($tmpproject->socid > 0 && ($tmpproject->socid != $object->thirdparty->id)) {
+                                    $listofidcompanytoscan .= ',' . $tmpproject->socid;
+                }
                 unset($tmpproject);

             }

 

@@ -6295,8 +6566,9 @@ 
         foreach ($possiblelinks as $key => $possiblelink) {

             $num = 0;

 

-            if (empty($possiblelink['enabled']))

-                continue;

+            if (empty($possiblelink['enabled'])) {
+                            continue;
+            }
 

             if (!empty($possiblelink['perms']) && (empty($restrictlinksto) || in_array($key, $restrictlinksto)) && (empty($excludelinksto) || !in_array($key, $excludelinksto))) {

                 print '<div id="' . $key . 'list"' . (empty($conf->global->MAIN_OPTIMIZEFORTEXTBROWSER) ? ' style="display:none"' : '') . '>';

@@ -6347,11 +6619,13 @@ 
                 }

 

                 //$linktoelem.=($linktoelem?' &nbsp; ':'');

-                if ($num > 0)

-                    $linktoelemlist .= '<li><a href="#linkto' . $key . '" class="linkto dropdowncloseonclick" rel="' . $key . '">' . $langs->trans($possiblelink['label']) . ' (' . $num . ')</a></li>';

+                if ($num > 0) {
+                                    $linktoelemlist .= '<li><a href="#linkto' . $key . '" class="linkto dropdowncloseonclick" rel="' . $key . '">' . $langs->trans($possiblelink['label']) . ' (' . $num . ')</a></li>';
+                }
                 //else $linktoelem.=$langs->trans($possiblelink['label']);

-                else

-                    $linktoelemlist .= '<li><span class="linktodisabled">' . $langs->trans($possiblelink['label']) . ' (0)</span></li>';

+                else {
+                                    $linktoelemlist .= '<li><span class="linktodisabled">' . $langs->trans($possiblelink['label']) . ' (0)</span></li>';
+                }
             }

         }

 

@@ -6409,8 +6683,9 @@ 
         $disabled = ($disabled ? ' disabled' : '');

 

         $resultyesno = '<select class="flat width75" id="' . $htmlname . '" name="' . $htmlname . '"' . $disabled . '>' . "\n";

-        if ($useempty)

-            $resultyesno .= '<option value="-1"' . (($value < 0) ? ' selected' : '') . '>&nbsp;</option>' . "\n";

+        if ($useempty) {
+                    $resultyesno .= '<option value="-1"' . (($value < 0) ? ' selected' : '') . '>&nbsp;</option>' . "\n";
+        }
         if (("$value" == 'yes') || ($value == 1)) {

             $resultyesno .= '<option value="' . $yes . '" selected>' . $langs->trans("Yes") . '</option>' . "\n";

             $resultyesno .= '<option value="' . $no . '">' . $langs->trans("No") . '</option>' . "\n";

@@ -6489,10 +6764,12 @@ 
         global $langs, $conf, $hookmanager;

 

         $ret = '';

-        if (empty($fieldid))

-            $fieldid = 'rowid';

-        if (empty($fieldref))

-            $fieldref = 'ref';

+        if (empty($fieldid)) {
+                    $fieldid = 'rowid';
+        }
+        if (empty($fieldref)) {
+                    $fieldref = 'ref';
+        }
 

         // Add where from hooks

         if (is_object($hookmanager)) {

@@ -6531,8 +6808,9 @@ 
         $ret .= '<!-- Start banner content --><div style="vertical-align: middle">';

 

         // Right part of banner

-        if ($morehtmlright)

-            $ret .= '<div class="inline-block floatleft">' . $morehtmlright . '</div>';

+        if ($morehtmlright) {
+                    $ret .= '<div class="inline-block floatleft">' . $morehtmlright . '</div>';
+        }
 

         if ($previous_ref || $next_ref || $morehtml) {

             $ret .= '<div class="pagination paginationref"><ul class="right">';

@@ -6550,26 +6828,32 @@ 
 

         $parameters = array();

         $reshook = $hookmanager->executeHooks('moreHtmlStatus', $parameters, $object);    // Note that $action and $object may have been modified by hook

-        if (empty($reshook))

-            $morehtmlstatus .= $hookmanager->resPrint;

-        else

-            $morehtmlstatus = $hookmanager->resPrint;

-        if ($morehtmlstatus)

-            $ret .= '<div class="statusref">' . $morehtmlstatus . '</div>';

+        if (empty($reshook)) {
+                    $morehtmlstatus .= $hookmanager->resPrint;
+        } else {
+                    $morehtmlstatus = $hookmanager->resPrint;
+        }
+        if ($morehtmlstatus) {
+                    $ret .= '<div class="statusref">' . $morehtmlstatus . '</div>';
+        }
 

         $parameters = array();

         $reshook = $hookmanager->executeHooks('moreHtmlRef', $parameters, $object); // Note that $action and $object may have been modified by hook

-        if (empty($reshook))

-            $morehtmlref .= $hookmanager->resPrint;

-        elseif ($reshook > 0)

-            $morehtmlref = $hookmanager->resPrint;

+        if (empty($reshook)) {
+                    $morehtmlref .= $hookmanager->resPrint;
+        } elseif ($reshook > 0) {
+                    $morehtmlref = $hookmanager->resPrint;
+        }
 

         // Left part of banner

         if ($morehtmlleft) {

-            if ($conf->browser->layout == 'phone')

-                $ret .= '<div class="floatleft">' . $morehtmlleft . '</div>';    // class="center" to have photo in middle

-            else

-                $ret .= '<div class="inline-block floatleft">' . $morehtmlleft . '</div>';

+            if ($conf->browser->layout == 'phone') {
+                            $ret .= '<div class="floatleft">' . $morehtmlleft . '</div>';
+            }
+            // class="center" to have photo in middle

+            else {
+                            $ret .= '<div class="inline-block floatleft">' . $morehtmlleft . '</div>';
+            }
         }

 

         //if ($conf->browser->layout == 'phone') $ret.='<div class="clearboth"></div>';

@@ -6594,8 +6878,9 @@ 
             $ret .= $object->label;

         } else if ($object->element == 'ecm_directories') {

             $ret .= '';

-        } else if ($fieldref != 'none')

-            $ret .= dol_htmlentities($object->$fieldref);

+        } else if ($fieldref != 'none') {
+                    $ret .= dol_htmlentities($object->$fieldref);
+        }
 

 

         if ($morehtmlref) {

@@ -6620,15 +6905,17 @@ 
         global $conf;

 

         //Check if barcode is filled in the card

-        if (empty($object->barcode))

-            return '';

+        if (empty($object->barcode)) {
+                    return '';
+        }
 

         // Complete object if not complete

         if (empty($object->barcode_type_code) || empty($object->barcode_type_coder)) {

             $result = $object->fetch_barcode();

             //Check if fetch_barcode() failed

-            if ($result < 1)

-                return '<!-- ErrorFetchBarcode -->';

+            if ($result < 1) {
+                            return '<!-- ErrorFetchBarcode -->';
+            }
         }

 

         // Barcode image

@@ -6670,108 +6957,120 @@ 
         if ($modulepart == 'societe') {

             $dir = $conf->societe->multidir_output[$entity];

             if (!empty($object->logo)) {

-                if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . getImageFileNameForSize($object->logo, '_mini');             // getImageFileNameForSize include the thumbs

-                else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . getImageFileNameForSize($object->logo, '_small');

-                else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . $object->logo;

+                if ((string) $imagesize == 'mini') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . getImageFileNameForSize($object->logo, '_mini');
+                }
+                // getImageFileNameForSize include the thumbs

+                else if ((string) $imagesize == 'small') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . getImageFileNameForSize($object->logo, '_small');
+                } else {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . $object->logo;
+                }
                 $originalfile = get_exdir(0, 0, 0, 0, $object, 'thirdparty') . '/logos/' . $object->logo;

             }

             $email = $object->email;

-        }

-        else if ($modulepart == 'contact') {

+        } else if ($modulepart == 'contact') {

             $dir = $conf->societe->multidir_output[$entity] . '/contact';

             if (!empty($object->photo)) {

-                if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . getImageFileNameForSize($object->photo, '_mini');

-                else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . getImageFileNameForSize($object->photo, '_small');

-                else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . $object->photo;

+                if ((string) $imagesize == 'mini') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . getImageFileNameForSize($object->photo, '_mini');
+                } else if ((string) $imagesize == 'small') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . getImageFileNameForSize($object->photo, '_small');
+                } else {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . $object->photo;
+                }
                 $originalfile = get_exdir(0, 0, 0, 0, $object, 'contact') . '/photos/' . $object->photo;

             }

             $email = $object->email;

             $capture = 'user';

-        }

-        else if ($modulepart == 'userphoto') {

+        } else if ($modulepart == 'userphoto') {

             $dir = $conf->user->dir_output;

             if (!empty($object->photo)) {

-                if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . $object->id . '/' . getImageFileNameForSize($object->photo, '_mini');

-                else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . $object->id . '/' . getImageFileNameForSize($object->photo, '_small');

-                else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . '/' . $object->id . '/' . $object->photo;

+                if ((string) $imagesize == 'mini') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . $object->id . '/' . getImageFileNameForSize($object->photo, '_mini');
+                } else if ((string) $imagesize == 'small') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . $object->id . '/' . getImageFileNameForSize($object->photo, '_small');
+                } else {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'user') . '/' . $object->id . '/' . $object->photo;
+                }
                 $originalfile = get_exdir(0, 0, 0, 0, $object, 'user') . '/' . $object->id . '/' . $object->photo;

             }

-            if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS))

-                $altfile = $object->id . ".jpg"; // For backward compatibility

+            if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS)) {
+                            $altfile = $object->id . ".jpg";
+            }
+            // For backward compatibility

             $email = $object->email;

             $capture = 'user';

-        }

-        else if ($modulepart == 'memberphoto') {

+        } else if ($modulepart == 'memberphoto') {

             $dir = $conf->adherent->dir_output;

             if (!empty($object->photo)) {

-                if ((string) $imagesize == 'mini')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . getImageFileNameForSize($object->photo, '_mini');

-                else if ((string) $imagesize == 'small')

-                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . getImageFileNameForSize($object->photo, '_small');

-                else

-                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . $object->photo;

+                if ((string) $imagesize == 'mini') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . getImageFileNameForSize($object->photo, '_mini');
+                } else if ((string) $imagesize == 'small') {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . getImageFileNameForSize($object->photo, '_small');
+                } else {
+                                    $file = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . $object->photo;
+                }
                 $originalfile = get_exdir(0, 0, 0, 0, $object, 'member') . 'photos/' . $object->photo;

             }

-            if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS))

-                $altfile = $object->id . ".jpg"; // For backward compatibility

+            if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS)) {
+                            $altfile = $object->id . ".jpg";
+            }
+            // For backward compatibility

             $email = $object->email;

             $capture = 'user';

-        }

-        else {

+        } else {

             // Generic case to show photos

             $dir = $conf->$modulepart->dir_output;

             if (!empty($object->photo)) {

-                if ((string) $imagesize == 'mini')

-                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . getImageFileNameForSize($object->photo, '_mini');

-                else if ((string) $imagesize == 'small')

-                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . getImageFileNameForSize($object->photo, '_small');

-                else

-                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . $object->photo;

+                if ((string) $imagesize == 'mini') {
+                                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . getImageFileNameForSize($object->photo, '_mini');
+                } else if ((string) $imagesize == 'small') {
+                                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . getImageFileNameForSize($object->photo, '_small');
+                } else {
+                                    $file = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . $object->photo;
+                }
                 $originalfile = get_exdir($id, 2, 0, 0, $object, $modulepart) . 'photos/' . $object->photo;

             }

-            if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS))

-                $altfile = $object->id . ".jpg"; // For backward compatibility

+            if (!empty($conf->global->MAIN_OLD_IMAGE_LINKS)) {
+                            $altfile = $object->id . ".jpg";
+            }
+            // For backward compatibility

             $email = $object->email;

         }

 

-        if ($forcecapture)

-            $capture = $forcecapture;

+        if ($forcecapture) {
+                    $capture = $forcecapture;
+        }
 

         if ($dir) {

             if ($file && file_exists($dir . "/" . $file)) {

                 if ($addlinktofullsize) {

                     $urladvanced = getAdvancedPreviewUrl($modulepart, $originalfile, 0, '&entity=' . $entity);

-                    if ($urladvanced)

-                        $ret .= '<a href="' . $urladvanced . '">';

-                    else

-                        $ret .= '<a href="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($originalfile) . '&cache=' . $cache . '">';

+                    if ($urladvanced) {
+                                            $ret .= '<a href="' . $urladvanced . '">';
+                    } else {
+                                            $ret .= '<a href="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($originalfile) . '&cache=' . $cache . '">';
+                    }
                 }

                 $ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="Photo" id="photologo' . (preg_replace('/[^a-z]/i', '_', $file)) . '" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($file) . '&cache=' . $cache . '">';

-                if ($addlinktofullsize)

-                    $ret .= '</a>';

-            }

-            else if ($altfile && file_exists($dir . "/" . $altfile)) {

+                if ($addlinktofullsize) {
+                                    $ret .= '</a>';
+                }
+            } else if ($altfile && file_exists($dir . "/" . $altfile)) {

                 if ($addlinktofullsize) {

                     $urladvanced = getAdvancedPreviewUrl($modulepart, $originalfile, 0, '&entity=' . $entity);

-                    if ($urladvanced)

-                        $ret .= '<a href="' . $urladvanced . '">';

-                    else

-                        $ret .= '<a href="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($originalfile) . '&cache=' . $cache . '">';

+                    if ($urladvanced) {
+                                            $ret .= '<a href="' . $urladvanced . '">';
+                    } else {
+                                            $ret .= '<a href="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($originalfile) . '&cache=' . $cache . '">';
+                    }
                 }

                 $ret .= '<img class="photo' . $modulepart . ($cssclass ? ' ' . $cssclass : '') . '" alt="Photo alt" id="photologo' . (preg_replace('/[^a-z]/i', '_', $file)) . '" class="' . $cssclass . '" ' . ($width ? ' width="' . $width . '"' : '') . ($height ? ' height="' . $height . '"' : '') . ' src="' . DOL_URL_ROOT . '/viewimage.php?modulepart=' . $modulepart . '&entity=' . $entity . '&file=' . urlencode($altfile) . '&cache=' . $cache . '">';

-                if ($addlinktofullsize)

-                    $ret .= '</a>';

-            }

-            else {

+                if ($addlinktofullsize) {
+                                    $ret .= '</a>';
+                }
+            } else {

                 $nophoto = '/public/theme/common/nophoto.png';

                 if (in_array($modulepart, array('userphoto', 'contact'))) { // For module that are "physical" users

                     $nophoto = '/public/theme/common/user_anonymous.png';

@@ -6809,8 +7108,9 @@ 
                 $ret .= '<tr><td class="tdoverflow"><input type="file" class="flat maxwidth200onsmartphone" name="photo" id="photoinput"' . ($capture ? ' capture="' . $capture . '"' : '') . '></td></tr>';

                 $ret .= '</table>';

             }

-        } else

-            dol_print_error('', 'Call of showphoto with wrong parameters modulepart=' . $modulepart);

+        } else {
+                    dol_print_error('', 'Call of showphoto with wrong parameters modulepart=' . $modulepart);
+        }
 

         return $ret;

     }

@@ -6837,14 +7137,17 @@ 
         global $conf, $user, $langs;

 

         // Permettre l'exclusion de groupes

-        if (is_array($exclude))

-            $excludeGroups = implode("','", $exclude);

+        if (is_array($exclude)) {
+                    $excludeGroups = implode("','", $exclude);
+        }
         // Permettre l'inclusion de groupes

-        if (is_array($include))

-            $includeGroups = implode("','", $include);

+        if (is_array($include)) {
+                    $includeGroups = implode("','", $include);
+        }
 

-        if (!is_array($selected))

-            $selected = array($selected);

+        if (!is_array($selected)) {
+                    $selected = array($selected);
+        }
 

         $out = '';

 

@@ -6856,18 +7159,20 @@ 
         $sql .= " FROM " . MAIN_DB_PREFIX . "usergroup as ug ";

         if (!empty($conf->multicompany->enabled) && $conf->entity == 1 && $user->admin && !$user->entity) {

             $sql .= " LEFT JOIN " . MAIN_DB_PREFIX . "entity as e ON e.rowid=ug.entity";

-            if ($force_entity)

-                $sql .= " WHERE ug.entity IN (0," . $force_entity . ")";

-            else

-                $sql .= " WHERE ug.entity IS NOT NULL";

-        }

-        else {

+            if ($force_entity) {
+                            $sql .= " WHERE ug.entity IN (0," . $force_entity . ")";
+            } else {
+                            $sql .= " WHERE ug.entity IS NOT NULL";
+            }
+        } else {

             $sql .= " WHERE ug.entity IN (0," . $conf->entity . ")";

         }

-        if (is_array($exclude) && $excludeGroups)

-            $sql .= " AND ug.rowid NOT IN ('" . $excludeGroups . "')";

-        if (is_array($include) && $includeGroups)

-            $sql .= " AND ug.rowid IN ('" . $includeGroups . "')";

+        if (is_array($exclude) && $excludeGroups) {
+                    $sql .= " AND ug.rowid NOT IN ('" . $excludeGroups . "')";
+        }
+        if (is_array($include) && $includeGroups) {
+                    $sql .= " AND ug.rowid IN ('" . $includeGroups . "')";
+        }
         $sql .= " ORDER BY ug.nom ASC";

 

         dol_syslog(get_class($this) . "::select_dolgroups", LOG_DEBUG);

@@ -6882,18 +7187,21 @@ 
             $num = $this->db->num_rows($resql);

             $i = 0;

             if ($num) {

-                if ($show_empty && !$multiple)

-                    $out .= '<option value="-1"' . (in_array(-1, $selected) ? ' selected' : '') . '>&nbsp;</option>' . "\n";

+                if ($show_empty && !$multiple) {
+                                    $out .= '<option value="-1"' . (in_array(-1, $selected) ? ' selected' : '') . '>&nbsp;</option>' . "\n";
+                }
 

                 while ($i < $num) {

                     $obj = $this->db->fetch_object($resql);

                     $disableline = 0;

-                    if (is_array($enableonly) && count($enableonly) && !in_array($obj->rowid, $enableonly))

-                        $disableline = 1;

+                    if (is_array($enableonly) && count($enableonly) && !in_array($obj->rowid, $enableonly)) {
+                                            $disableline = 1;
+                    }
 

                     $out .= '<option value="' . $obj->rowid . '"';

-                    if ($disableline)

-                        $out .= ' disabled';

+                    if ($disableline) {
+                                            $out .= ' disabled';
+                    }
                     if ((is_object($selected[0]) && $selected[0]->id == $obj->rowid) || (!is_object($selected[0]) && in_array($obj->rowid, $selected) )) {

                         $out .= ' selected';

                     }

@@ -6908,13 +7216,13 @@ 
                     $i++;

                 }

             } else {

-                if ($show_empty)

-                    $out .= '<option value="-1"' . (in_array(-1, $selected) ? ' selected' : '') . '></option>' . "\n";

+                if ($show_empty) {
+                                    $out .= '<option value="-1"' . (in_array(-1, $selected) ? ' selected' : '') . '></option>' . "\n";
+                }
                 $out .= '<option value="" disabled>' . $langs->trans("NoUserGroupDefined") . '</option>';

             }

             $out .= '</select>';

-        }

-        else {

+        } else {

             dol_print_error($this->db);

         }

 

@@ -6950,8 +7258,9 @@ 
         global $conf, $langs;

 

         $out = '';

-        if (!empty($conf->use_javascript_ajax))

-            $out .= '<div class="inline-block checkallactions"><input type="checkbox" id="checkallactions" name="checkallactions" class="checkallactions"></div>';

+        if (!empty($conf->use_javascript_ajax)) {
+                    $out .= '<div class="inline-block checkallactions"><input type="checkbox" id="checkallactions" name="checkallactions" class="checkallactions"></div>';
+        }
         $out .= '<script type="text/javascript">

             $(document).ready(function() {

             	$("#checkallactions").click(function() {

@@ -6964,8 +7273,9 @@ 
                         console.log("We uncheck all");

                 		$(".' . $cssclass . '").prop(\'checked\', false).trigger(\'change\');

                     }' . "\n";

-        if ($calljsfunction)

-            $out .= 'if (typeof initCheckForSelect == \'function\') { initCheckForSelect(0); } else { console.log("No function initCheckForSelect found. Call won\'t be done."); }';

+        if ($calljsfunction) {
+                    $out .= 'if (typeof initCheckForSelect == \'function\') { initCheckForSelect(0); } else { console.log("No function initCheckForSelect found. Call won\'t be done."); }';
+        }
         $out .= '         });

 

         	$(".checkforselect").change(function() {

@@ -7013,22 +7323,25 @@ 
 

         $sql = 'SELECT rowid, label FROM ' . MAIN_DB_PREFIX . 'c_exp_tax_cat WHERE active = 1';

         $sql .= ' AND entity IN (0,' . getEntity('exp_tax_cat') . ')';

-        if (!empty($excludeid))

-            $sql .= ' AND rowid NOT IN (' . implode(',', $excludeid) . ')';

+        if (!empty($excludeid)) {
+                    $sql .= ' AND rowid NOT IN (' . implode(',', $excludeid) . ')';
+        }
         $sql .= ' ORDER BY label';

 

         $resql = $db->query($sql);

         if ($resql) {

             $out = '<select id="select_' . $htmlname . '" name="' . $htmlname . '" class="' . $htmlname . ' flat minwidth75imp">';

-            if ($useempty)

-                $out .= '<option value="0">&nbsp;</option>';

+            if ($useempty) {
+                            $out .= '<option value="0">&nbsp;</option>';
+            }
 

             while ($obj = $db->fetch_object($resql)) {

                 $out .= '<option ' . ($selected == $obj->rowid ? 'selected="selected"' : '') . ' value="' . $obj->rowid . '">' . $langs->trans($obj->label) . '</option>';

             }

             $out .= '</select>';

-            if (!empty($htmlname) && $user->admin)

-                $out .= ' ' . info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);

+            if (!empty($htmlname) && $user->admin) {
+                            $out .= ' ' . info_admin($langs->trans("YouCanChangeValuesForThisListFromDictionarySetup"), 1);
+            }
 

             if (!empty($target)) {

                 $sql = "SELECT c.id FROM " . MAIN_DB_PREFIX . "c_type_fees as c WHERE c.code = 'EX_KME' AND c.active = 1";

@@ -7041,8 +7354,9 @@ 
 								$("select[name=' . $target . ']").on("change", function() {

 									var current_val = $(this).val();

 									if (current_val == ' . $obj->id . ') {';

-                        if (!empty($default_selected) || !empty($selected))

-                            $out .= '$("select[name=' . $htmlname . ']").val("' . ($default_selected > 0 ? $default_selected : $selected) . '");';

+                        if (!empty($default_selected) || !empty($selected)) {
+                                                    $out .= '$("select[name=' . $htmlname . ']").val("' . ($default_selected > 0 ? $default_selected : $selected) . '");';
+                        }
 

                         $out .= '

 										$("select[name=' . $htmlname . ']").change();

@@ -7078,8 +7392,7 @@ 
                     }

                 }

             }

-        }

-        else {

+        } else {

             dol_print_error($db);

         }

 

@@ -7104,8 +7417,9 @@ 
         $resql = $db->query($sql);

         if ($resql) {

             $out = '<select id="select_' . $htmlname . '" name="' . $htmlname . '" class="' . $htmlname . ' flat minwidth75imp">';

-            if ($useempty)

-                $out .= '<option value="0"></option>';

+            if ($useempty) {
+                            $out .= '<option value="0"></option>';
+            }
 

             while ($obj = $db->fetch_object($resql)) {

                 $out .= '<option ' . ($selected == $obj->rowid ? 'selected="selected"' : '') . ' value="' . $obj->rowid . '">' . price($obj->range_ik, 0, $langs, 1, 0) . '</option>';

@@ -7138,14 +7452,17 @@ 
         $resql = $db->query($sql);

         if ($resql) {

             $out = '<select id="select_' . $htmlname . '" name="' . $htmlname . '" class="' . $htmlname . ' flat minwidth75imp">';

-            if ($useempty)

-                $out .= '<option value="0"></option>';

-            if ($allchoice)

-                $out .= '<option value="-1">' . $langs->trans('AllExpenseReport') . '</option>';

+            if ($useempty) {
+                            $out .= '<option value="0"></option>';
+            }
+            if ($allchoice) {
+                            $out .= '<option value="-1">' . $langs->trans('AllExpenseReport') . '</option>';
+            }
 

             $field = 'code';

-            if ($useid)

-                $field = 'id';

+            if ($useid) {
+                            $field = 'id';
+            }
 

             while ($obj = $db->fetch_object($resql)) {

                 $key = $langs->trans($obj->code);

Base/Interfaces.php

Spacing +35 added lines, -35 removed lines

@@ -24,7 +24,7 @@ 
 class Interfaces

 {

 

-    var $dir;    // Directory with all core and external triggers files

+    var $dir; // Directory with all core and external triggers files

 

     /**

      * @var string[] Error codes (or messages)

@@ -58,16 +58,16 @@ 
         // phpcs:enable

         // Check parameters

         if (!is_object($object) || !is_object($conf)) { // Error

-            $this->error = 'function run_triggers called with wrong parameters action=' . $action . ' object=' . is_object($object) . ' user=' . is_object($user) . ' langs=' . is_object($langs) . ' conf=' . is_object($conf);

-            DolUtils::dol_syslog(get_class($this) . '::run_triggers ' . $this->error, LOG_ERR);

+            $this->error = 'function run_triggers called with wrong parameters action='.$action.' object='.is_object($object).' user='.is_object($user).' langs='.is_object($langs).' conf='.is_object($conf);

+            DolUtils::dol_syslog(get_class($this).'::run_triggers '.$this->error, LOG_ERR);

             $this->errors[] = $this->error;

             return -1;

         }

         if (!is_object($langs)) { // Warning

-            DolUtils::dol_syslog(get_class($this) . '::run_triggers was called with wrong parameters action=' . $action . ' object=' . is_object($object) . ' user=' . is_object($user) . ' langs=' . is_object($langs) . ' conf=' . is_object($conf), LOG_WARNING);

+            DolUtils::dol_syslog(get_class($this).'::run_triggers was called with wrong parameters action='.$action.' object='.is_object($object).' user='.is_object($user).' langs='.is_object($langs).' conf='.is_object($conf), LOG_WARNING);

         }

         if (!is_object($user)) {     // Warning

-            DolUtils::dol_syslog(get_class($this) . '::run_triggers was called with wrong parameters action=' . $action . ' object=' . is_object($object) . ' user=' . is_object($user) . ' langs=' . is_object($langs) . ' conf=' . is_object($conf), LOG_WARNING);

+            DolUtils::dol_syslog(get_class($this).'::run_triggers was called with wrong parameters action='.$action.' object='.is_object($object).' user='.is_object($user).' langs='.is_object($langs).' conf='.is_object($conf), LOG_WARNING);

             global $db;

             $user = new User($db);

         }

@@ -80,7 +80,7 @@ 
         $i = 0;

 

         // $dirtriggers = array_merge(array('/core/triggers'), $conf->modules_parts['triggers']);

-        $dirtriggers = array_merge(array(BASE_PATH . '/Helpers/triggers'), $conf->modules_parts['triggers']);

+        $dirtriggers = array_merge(array(BASE_PATH.'/Helpers/triggers'), $conf->modules_parts['triggers']);

         foreach ($dirtriggers as $reldir) {

             //$dir = DolUtils::dol_buildpath($reldir, 0);

             //$newdir = DolUtils::dol_osencode($dir);

@@ -93,7 +93,7 @@ 
             $handle = opendir($newdir);

             if (is_resource($handle)) {

                 while (($file = readdir($handle)) !== false) {

-                    if (is_readable($newdir . "/" . $file) && preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php$/i', $file, $reg)) {

+                    if (is_readable($newdir."/".$file) && preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php$/i', $file, $reg)) {

                         $part1 = $reg[1];

                         $part2 = $reg[2];

                         $part3 = $reg[3];

@@ -107,7 +107,7 @@ 
                         $qualified = true;

                         if (strtolower($reg[2]) != 'all') {

                             $module = preg_replace('/^mod/i', '', $reg[2]);

-                            $constparam = 'MAIN_MODULE_' . strtoupper($module);

+                            $constparam = 'MAIN_MODULE_'.strtoupper($module);

                             if (empty($conf->global->$constparam))

                                 $qualified = false;

                         }

@@ -117,26 +117,26 @@ 
                             continue;

                         }

 

-                        $modName = "Interface" . ucfirst($reg[3]);

+                        $modName = "Interface".ucfirst($reg[3]);

                         //print "file=$file - modName=$modName\n";

                         if (in_array($modName, $modules)) {    // $modules = list of modName already loaded

                             $langs->load("errors");

-                            DolUtils::dol_syslog(get_class($this) . "::run_triggers action=" . $action . " " . $langs->trans("ErrorDuplicateTrigger", $newdir . "/" . $file, $fullpathfiles[$modName]), LOG_WARNING);

+                            DolUtils::dol_syslog(get_class($this)."::run_triggers action=".$action." ".$langs->trans("ErrorDuplicateTrigger", $newdir."/".$file, $fullpathfiles[$modName]), LOG_WARNING);

                             continue;

                         }

 

                         try {

                             //print 'Todo for '.$modName." : ".$newdir.'/'.$file."\n";

-                            include_once $newdir . '/' . $file;

+                            include_once $newdir.'/'.$file;

                             //print 'Done for '.$modName."\n";

                         } catch (Exception $e) {

-                            DolUtils::dol_syslog('ko for ' . $modName . " " . $e->getMessage() . "\n", LOG_ERR);

+                            DolUtils::dol_syslog('ko for '.$modName." ".$e->getMessage()."\n", LOG_ERR);

                         }

 

                         $modules[$i] = $modName;

                         $files[$i] = $file;

-                        $fullpathfiles[$modName] = $newdir . '/' . $file;

-                        $orders[$i] = $part1 . '_' . $part2 . '_' . $part3;   // Set sort criteria value

+                        $fullpathfiles[$modName] = $newdir.'/'.$file;

+                        $orders[$i] = $part1.'_'.$part2.'_'.$part3; // Set sort criteria value

 

                         $i++;

                     }

@@ -160,10 +160,10 @@ 
                     //DolUtils::dol_syslog(get_class($this)."::run_triggers action=".$action." Launch runTrigger for file '".$files[$key]."'", LOG_DEBUG);

                     $result = $objMod->runTrigger($action, $object, $user, $langs, $conf);

                 } elseif (method_exists($objMod, 'run_trigger')) { // Deprecated method

-                    DolUtils::dol_syslog(get_class($this) . "::run_triggers action=" . $action . " Launch old method run_trigger (rename your trigger into runTrigger) for file '" . $files[$key] . "'", LOG_WARNING);

+                    DolUtils::dol_syslog(get_class($this)."::run_triggers action=".$action." Launch old method run_trigger (rename your trigger into runTrigger) for file '".$files[$key]."'", LOG_WARNING);

                     $result = $objMod->run_trigger($action, $object, $user, $langs, $conf);

                 } else {

-                    DolUtils::dol_syslog(get_class($this) . "::run_triggers action=" . $action . " A trigger was declared for class " . get_class($objMod) . " but method runTrigger was not found", LOG_ERR);

+                    DolUtils::dol_syslog(get_class($this)."::run_triggers action=".$action." A trigger was declared for class ".get_class($objMod)." but method runTrigger was not found", LOG_ERR);

                 }

 

                 if ($result > 0) {

@@ -188,12 +188,12 @@ 
                 }

             }

             else {

-                DolUtils::dol_syslog(get_class($this) . "::run_triggers action=" . $action . " Failed to instantiate trigger for file '" . $files[$key] . "'", LOG_ERR);

+                DolUtils::dol_syslog(get_class($this)."::run_triggers action=".$action." Failed to instantiate trigger for file '".$files[$key]."'", LOG_ERR);

             }

         }

 

         if ($nbko) {

-            DolUtils::dol_syslog(get_class($this) . "::run_triggers action=" . $action . " Files found: " . $nbfile . ", Files launched: " . $nbtotal . ", Done: " . $nbok . ", Failed: " . $nbko . " - Nb of error string returned in this->errors = " . count($this->errors), LOG_ERR);

+            DolUtils::dol_syslog(get_class($this)."::run_triggers action=".$action." Files found: ".$nbfile.", Files launched: ".$nbtotal.", Done: ".$nbok.", Failed: ".$nbko." - Nb of error string returned in this->errors = ".count($this->errors), LOG_ERR);

             return -$nbko;

         } else {

             //DolUtils::dol_syslog(get_class($this)."::run_triggers Files found: ".$nbfile.", Files launched: ".$nbtotal.", Done: ".$nbok.", Failed: ".$nbko, LOG_DEBUG);

@@ -236,7 +236,7 @@ 
             $handle = opendir($newdir);

             if (is_resource($handle)) {

                 while (($file = readdir($handle)) !== false) {

-                    if (is_readable($newdir . '/' . $file) && preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php/', $file, $reg)) {

+                    if (is_readable($newdir.'/'.$file) && preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php/', $file, $reg)) {

                         if (preg_match('/\.back$/', $file))

                             continue;

 

@@ -244,21 +244,21 @@ 
                         $part2 = $reg[2];

                         $part3 = $reg[3];

 

-                        $modName = 'Interface' . ucfirst($reg[3]);

+                        $modName = 'Interface'.ucfirst($reg[3]);

                         //print "file=$file"; print "modName=$modName"; exit;

                         if (in_array($modName, $modules)) {

                             $langs->load("errors");

-                            print '<div class="error">' . $langs->trans("Error") . ' : ' . $langs->trans("ErrorDuplicateTrigger", $modName, "/htdocs/core/triggers/") . '</div>';

+                            print '<div class="error">'.$langs->trans("Error").' : '.$langs->trans("ErrorDuplicateTrigger", $modName, "/htdocs/core/triggers/").'</div>';

                         } else {

-                            include_once $newdir . '/' . $file;

+                            include_once $newdir.'/'.$file;

                         }

 

                         $files[$i] = $file;

-                        $fullpath[$i] = $dir . '/' . $file;

-                        $relpath[$i] = preg_replace('/^\//', '', $reldir) . '/' . $file;

+                        $fullpath[$i] = $dir.'/'.$file;

+                        $relpath[$i] = preg_replace('/^\//', '', $reldir).'/'.$file;

                         $iscoreorexternal[$i] = ($reldir == '/core/triggers/' ? 'internal' : 'external');

                         $modules[$i] = $modName;

-                        $orders[$i] = $part1 . '_' . $part2 . '_' . $part3;   // Set sort criteria value

+                        $orders[$i] = $part1.'_'.$part2.'_'.$part3; // Set sort criteria value

 

                         $i++;

                     }

@@ -279,7 +279,7 @@ 
                 continue;

 

             if (!class_exists($modName)) {

-                print 'Error: A trigger file was found but its class "' . $modName . '" was not found.' . "<br>\n";

+                print 'Error: A trigger file was found but its class "'.$modName.'" was not found.'."<br>\n";

                 continue;

             }

 

@@ -296,7 +296,7 @@ 
             // Check if trigger file is for a particular module

             if (preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php/i', $files[$key], $reg)) {

                 $module = preg_replace('/^mod/i', '', $reg[2]);

-                $constparam = 'MAIN_MODULE_' . strtoupper($module);

+                $constparam = 'MAIN_MODULE_'.strtoupper($module);

                 if (strtolower($module) == 'all')

                     $disabledbymodule = 0;

                 else if (empty($conf->global->$constparam))

@@ -315,21 +315,21 @@ 
             if ($disabledbyname > 0 || $disabledbymodule > 1)

                 $triggers[$j]['status'] = '';

 

-            $text = '<b>' . $langs->trans("Description") . ':</b><br>';

-            $text .= $objMod->getDesc() . '<br>';

-            $text .= '<br><b>' . $langs->trans("Status") . ':</b><br>';

+            $text = '<b>'.$langs->trans("Description").':</b><br>';

+            $text .= $objMod->getDesc().'<br>';

+            $text .= '<br><b>'.$langs->trans("Status").':</b><br>';

             if ($disabledbyname == 1) {

-                $text .= $langs->trans("TriggerDisabledByName") . '<br>';

+                $text .= $langs->trans("TriggerDisabledByName").'<br>';

                 if ($disabledbymodule == 2)

-                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module) . '<br>';

+                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module).'<br>';

             }

             else {

                 if ($disabledbymodule == 0)

-                    $text .= $langs->trans("TriggerAlwaysActive") . '<br>';

+                    $text .= $langs->trans("TriggerAlwaysActive").'<br>';

                 if ($disabledbymodule == 1)

-                    $text .= $langs->trans("TriggerActiveAsModuleActive", $module) . '<br>';

+                    $text .= $langs->trans("TriggerActiveAsModuleActive", $module).'<br>';

                 if ($disabledbymodule == 2)

-                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module) . '<br>';

+                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module).'<br>';

             }

 

             $triggers[$j]['info'] = $text;

Braces +51 added lines, -38 removed lines

@@ -87,8 +87,9 @@ 
             $newdir = DolUtils::dol_buildpath($reldir, 0);

             //print "xx".$dir;exit;

             // Check if directory exists (we do not use dol_is_dir to avoir loading files.lib.php at each call)

-            if (!is_dir($newdir))

-                continue;

+            if (!is_dir($newdir)) {
+                            continue;
+            }
 

             $handle = opendir($newdir);

             if (is_resource($handle)) {

@@ -101,15 +102,17 @@ 
                         $nbfile++;

 

                         // Check if trigger file is disabled by name

-                        if (preg_match('/NORUN$/i', $file))

-                            continue;

+                        if (preg_match('/NORUN$/i', $file)) {
+                                                    continue;
+                        }
                         // Check if trigger file is for a particular module

                         $qualified = true;

                         if (strtolower($reg[2]) != 'all') {

                             $module = preg_replace('/^mod/i', '', $reg[2]);

                             $constparam = 'MAIN_MODULE_' . strtoupper($module);

-                            if (empty($conf->global->$constparam))

-                                $qualified = false;

+                            if (empty($conf->global->$constparam)) {
+                                                            $qualified = false;
+                            }
                         }

 

                         if (!$qualified) {

@@ -149,8 +152,9 @@ 
         // Loop on each trigger

         foreach ($orders as $key => $value) {

             $modName = $modules[$key];

-            if (empty($modName))

-                continue;

+            if (empty($modName)) {
+                            continue;
+            }
 

             $objMod = new $modName();

             if ($objMod) {

@@ -180,14 +184,14 @@ 
                     //DolUtils::dol_syslog("Error in trigger ".$action." - Nb of error string returned = ".count($objMod->errors), LOG_ERR);

                     $nbtotal++;

                     $nbko++;

-                    if (!empty($objMod->errors))

-                        $this->errors = array_merge($this->errors, $objMod->errors);

-                    else if (!empty($objMod->error))

-                        $this->errors[] = $objMod->error;

+                    if (!empty($objMod->errors)) {
+                                            $this->errors = array_merge($this->errors, $objMod->errors);
+                    } else if (!empty($objMod->error)) {
+                                            $this->errors[] = $objMod->error;
+                    }
                     //DolUtils::dol_syslog("Error in trigger ".$action." - Nb of error string returned = ".count($this->errors), LOG_ERR);

                 }

-            }

-            else {

+            } else {

                 DolUtils::dol_syslog(get_class($this) . "::run_triggers action=" . $action . " Failed to instantiate trigger for file '" . $files[$key] . "'", LOG_ERR);

             }

         }

@@ -230,15 +234,17 @@ 
             $newdir = DolUtils::dol_osencode($dir);

 

             // Check if directory exists (we do not use dol_is_dir to avoid loading files.lib.php at each call)

-            if (!is_dir($newdir))

-                continue;

+            if (!is_dir($newdir)) {
+                            continue;
+            }
 

             $handle = opendir($newdir);

             if (is_resource($handle)) {

                 while (($file = readdir($handle)) !== false) {

                     if (is_readable($newdir . '/' . $file) && preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php/', $file, $reg)) {

-                        if (preg_match('/\.back$/', $file))

-                            continue;

+                        if (preg_match('/\.back$/', $file)) {
+                                                    continue;
+                        }
 

                         $part1 = $reg[1];

                         $part2 = $reg[2];

@@ -275,8 +281,9 @@ 
         // Loop on each trigger

         foreach ($orders as $key => $value) {

             $modName = $modules[$key];

-            if (empty($modName))

-                continue;

+            if (empty($modName)) {
+                            continue;
+            }
 

             if (!class_exists($modName)) {

                 print 'Error: A trigger file was found but its class "' . $modName . '" was not found.' . "<br>\n";

@@ -291,16 +298,18 @@ 
             $module = '';

 

             // Check if trigger file is disabled by name

-            if (preg_match('/NORUN$/i', $files[$key]))

-                $disabledbyname = 1;

+            if (preg_match('/NORUN$/i', $files[$key])) {
+                            $disabledbyname = 1;
+            }
             // Check if trigger file is for a particular module

             if (preg_match('/^interface_([0-9]+)_([^_]+)_(.+)\.class\.php/i', $files[$key], $reg)) {

                 $module = preg_replace('/^mod/i', '', $reg[2]);

                 $constparam = 'MAIN_MODULE_' . strtoupper($module);

-                if (strtolower($module) == 'all')

-                    $disabledbymodule = 0;

-                else if (empty($conf->global->$constparam))

-                    $disabledbymodule = 2;

+                if (strtolower($module) == 'all') {
+                                    $disabledbymodule = 0;
+                } else if (empty($conf->global->$constparam)) {
+                                    $disabledbymodule = 2;
+                }
                 $triggers[$j]['module'] = strtolower($module);

             }

 

@@ -312,24 +321,28 @@ 
             $triggers[$j]['iscoreorexternal'] = $iscoreorexternal[$key];

             $triggers[$j]['version'] = $objMod->getVersion();

             $triggers[$j]['status'] = img_picto($langs->trans("Active"), 'tick');

-            if ($disabledbyname > 0 || $disabledbymodule > 1)

-                $triggers[$j]['status'] = '';

+            if ($disabledbyname > 0 || $disabledbymodule > 1) {
+                            $triggers[$j]['status'] = '';
+            }
 

             $text = '<b>' . $langs->trans("Description") . ':</b><br>';

             $text .= $objMod->getDesc() . '<br>';

             $text .= '<br><b>' . $langs->trans("Status") . ':</b><br>';

             if ($disabledbyname == 1) {

                 $text .= $langs->trans("TriggerDisabledByName") . '<br>';

-                if ($disabledbymodule == 2)

-                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module) . '<br>';

-            }

-            else {

-                if ($disabledbymodule == 0)

-                    $text .= $langs->trans("TriggerAlwaysActive") . '<br>';

-                if ($disabledbymodule == 1)

-                    $text .= $langs->trans("TriggerActiveAsModuleActive", $module) . '<br>';

-                if ($disabledbymodule == 2)

-                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module) . '<br>';

+                if ($disabledbymodule == 2) {
+                                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module) . '<br>';
+                }
+            } else {

+                if ($disabledbymodule == 0) {
+                                    $text .= $langs->trans("TriggerAlwaysActive") . '<br>';
+                }
+                if ($disabledbymodule == 1) {
+                                    $text .= $langs->trans("TriggerActiveAsModuleActive", $module) . '<br>';
+                }
+                if ($disabledbymodule == 2) {
+                                    $text .= $langs->trans("TriggerDisabledAsModuleDisabled", $module) . '<br>';
+                }
             }

 

             $triggers[$j]['info'] = $text;

Base/Langs.php

Spacing +66 added lines, -66 removed lines

@@ -21,13 +21,13 @@ 
 class Langs

 {

 

-    public $dir;                          // Directories that contains /langs subdirectory

-    public $defaultlang;                  // Current language for current user

-    public $charset_output = 'UTF-8';       // Codage used by "trans" method outputs

-    public $tab_translate = array();        // Array of all translations key=>value

-    private $_tab_loaded = array();         // Array to store result after loading each language file

-    public $cache_labels = array();         // Cache for labels return by getLabelFromKey method

-    public $cache_currencies = array();     // Cache to store currency symbols

+    public $dir; // Directories that contains /langs subdirectory

+    public $defaultlang; // Current language for current user

+    public $charset_output = 'UTF-8'; // Codage used by "trans" method outputs

+    public $tab_translate = array(); // Array of all translations key=>value

+    private $_tab_loaded = array(); // Array to store result after loading each language file

+    public $cache_labels = array(); // Cache for labels return by getLabelFromKey method

+    public $cache_currencies = array(); // Cache to store currency symbols

     private $cache_currencies_all_loaded = false;

 

     /**

@@ -60,13 +60,13 @@ 
             $more = array();

             $i = 0;

             foreach ($conf->file->dol_document_root as $dir) {

-                $newdir = $dir . $conf->global->MAIN_FORCELANGDIR;    // For example $conf->global->MAIN_FORCELANGDIR is '/mymodule' meaning we search files into '/mymodule/langs/xx_XX'

+                $newdir = $dir.$conf->global->MAIN_FORCELANGDIR; // For example $conf->global->MAIN_FORCELANGDIR is '/mymodule' meaning we search files into '/mymodule/langs/xx_XX'

                 if (!in_array($newdir, $this->dir)) {

-                    $more['module_' . $i] = $newdir;

-                    $i++;   // We add the forced dir into the array $more. Just after, we add entries into $more to list of lang dir $this->dir.

+                    $more['module_'.$i] = $newdir;

+                    $i++; // We add the forced dir into the array $more. Just after, we add entries into $more to list of lang dir $this->dir.

                 }

             }

-            $this->dir = array_merge($more, $this->dir);    // Forced dir ($more) are before standard dirs ($this->dir)

+            $this->dir = array_merge($more, $this->dir); // Forced dir ($more) are before standard dirs ($this->dir)

         }

 

         $this->origlang = $srclang;

@@ -90,12 +90,12 @@ 
             if (isset($longforshort[strtolower($langpart[0])]) && !in_array($codetouse, $longforshortexcep))

                 $srclang = $longforshort[strtolower($langpart[0])];

             else if (!is_numeric($langpart[1])) {  // Second part YY may be a numeric with some Chrome browser

-                $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[1]);

+                $srclang = strtolower($langpart[0])."_".strtoupper($langpart[1]);

                 $longforlong = array('no_nb' => 'nb_NO');

                 if (isset($longforlong[strtolower($srclang)]))

                     $srclang = $longforlong[strtolower($srclang)];

             } else

-                $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[0]);

+                $srclang = strtolower($langpart[0])."_".strtoupper($langpart[0]);

         }

         else {      // If it's for a codetouse that is a short code xx

             // Array to convert short lang code into long code.

@@ -103,7 +103,7 @@ 
             if (isset($longforshort[strtolower($langpart[0])]))

                 $srclang = $longforshort[strtolower($langpart[0])];

             else if (!empty($langpart[0]))

-                $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[0]);

+                $srclang = strtolower($langpart[0])."_".strtoupper($langpart[0]);

             else

                 $srclang = 'en_US';

         }

@@ -167,11 +167,11 @@ 
         //DolUtils::dol_syslog("Translate::Load Start domain=".$domain." alt=".$alt." forcelangdir=".$forcelangdir." this->defaultlang=".$this->defaultlang);

         // Check parameters

         if (empty($domain)) {

-            dol_print_error('', get_class($this) . "::Load ErrorWrongParameters");

+            dol_print_error('', get_class($this)."::Load ErrorWrongParameters");

             return -1;

         }

         if ($this->defaultlang == 'none_NONE')

-            return 0;    // Special language code to not translate keys

+            return 0; // Special language code to not translate keys

 

 

 

@@ -180,7 +180,7 @@ 
             

 // Load $this->tab_translate[] from database

         if (empty($loadfromfileonly) && count($this->tab_translate) == 0)

-            $this->loadFromDatabase($db);      // No translation was never loaded yet, so we load database.

+            $this->loadFromDatabase($db); // No translation was never loaded yet, so we load database.

 

 

         $newdomain = $domain;

@@ -209,13 +209,13 @@ 
             $alt = 2;

 

         if (empty($langofdir)) { // This may occurs when load is called without setting the language and without providing a value for forcelangdir

-            DolUtils::dol_syslog("Error: " . get_class($this) . "::Load was called but language was not set yet with langs->setDefaultLang(). Nothing will be loaded.", LOG_WARNING);

+            DolUtils::dol_syslog("Error: ".get_class($this)."::Load was called but language was not set yet with langs->setDefaultLang(). Nothing will be loaded.", LOG_WARNING);

             return -1;

         }

 

         foreach ($this->dir as $keydir => $searchdir) {

             // Directory of translation files

-            $file_lang = $searchdir . ($modulename ? '/' . $modulename : '') . "/langs/" . $langofdir . "/" . $newdomain . ".lang";

+            $file_lang = $searchdir.($modulename ? '/'.$modulename : '')."/langs/".$langofdir."/".$newdomain.".lang";

             $file_lang_osencoded = dol_osencode($file_lang);

 

             $filelangexists = is_file($file_lang_osencoded);

@@ -231,7 +231,7 @@ 
                 $usecachekey = '';

                 // Using a memcached server

                 if (!empty($conf->memcached->enabled) && !empty($conf->global->MEMCACHED_SERVER)) {

-                    $usecachekey = $newdomain . '_' . $langofdir . '_' . md5($file_lang);    // Should not contains special chars

+                    $usecachekey = $newdomain.'_'.$langofdir.'_'.md5($file_lang); // Should not contains special chars

                 }

                 // Using cache with shmop. Speed gain: 40ms - Memory overusage: 200ko (Size of session cache file)

                 else if (isset($conf->global->MAIN_OPTIMIZE_SPEED) && ($conf->global->MAIN_OPTIMIZE_SPEED & 0x02)) {

@@ -242,7 +242,7 @@ 
                     //DolUtils::dol_syslog('Translate::Load we will cache result into usecachekey '.$usecachekey);

                     //global $aaa; $aaa+=1;

                     //print $aaa." ".$usecachekey."\n";

-                    require_once DOL_BASE_PATH . '/core/lib/memory.lib.php';

+                    require_once DOL_BASE_PATH.'/core/lib/memory.lib.php';

                     $tmparray = dol_getcache($usecachekey);

                     if (is_array($tmparray) && count($tmparray)) {

                         $this->tab_translate += $tmparray; // Faster than array_merge($tmparray,$this->tab_translate). Note: If a value already exists into tab_translate, value into tmparaay is not added.

@@ -250,7 +250,7 @@ 
                         //var_dump($this->tab_translate);

                         if ($alt == 2)

                             $fileread = 1;

-                        $found = true;      // Found in dolibarr PHP cache

+                        $found = true; // Found in dolibarr PHP cache

                     }

                 }

 

@@ -300,13 +300,13 @@ 
                         if ($usecachekey && count($tabtranslatedomain)) {

                             $ressetcache = dol_setcache($usecachekey, $tabtranslatedomain);

                             if ($ressetcache < 0) {

-                                $error = 'Failed to set cache for usecachekey=' . $usecachekey . ' result=' . $ressetcache;

+                                $error = 'Failed to set cache for usecachekey='.$usecachekey.' result='.$ressetcache;

                                 DolUtils::dol_syslog($error, LOG_ERR);

                             }

                         }

 

                         if (empty($conf->global->MAIN_FORCELANGDIR))

-                            break;  // Break loop on each root dir. If a module has forced dir, we do not stop loop.

+                            break; // Break loop on each root dir. If a module has forced dir, we do not stop loop.

                     }

                 }

             }

@@ -316,11 +316,11 @@ 
         if ($alt == 0) {

             // This function MUST NOT contains call to syslog

             //DolUtils::dol_syslog("Translate::Load loading alternate translation file (to complete ".$this->defaultlang."/".$newdomain.".lang file)", LOG_DEBUG);

-            $langofdir = strtolower($langarray[0]) . '_' . strtoupper($langarray[0]);

+            $langofdir = strtolower($langarray[0]).'_'.strtoupper($langarray[0]);

             if ($langofdir == 'el_EL')

-                $langofdir = 'el_GR';                     // main parent for el_CY is not 'el_EL' but 'el_GR'

+                $langofdir = 'el_GR'; // main parent for el_CY is not 'el_EL' but 'el_GR'

             if ($langofdir == 'ar_AR')

-                $langofdir = 'ar_SA';                     // main parent for ar_EG is not 'ar_AR' but 'ar_SA'

+                $langofdir = 'ar_SA'; // main parent for ar_EG is not 'ar_AR' but 'ar_SA'

             $this->load($domain, $alt + 1, $stopafterdirection, $langofdir);

         }

 

@@ -335,7 +335,7 @@ 
         // We are in the pass of the reference file. No more files to scan to complete.

         if ($alt == 2) {

             if ($fileread)

-                $this->_tab_loaded[$newdomain] = 1;        // Set domain file as found so loaded

+                $this->_tab_loaded[$newdomain] = 1; // Set domain file as found so loaded

 

             if (empty($this->_tab_loaded[$newdomain]))

                 $this->_tab_loaded[$newdomain] = 2; // Set this file as not found

@@ -344,7 +344,7 @@ 
         // This part is deprecated and replaced with table llx_overwrite_trans

         // Kept for backward compatibility.

         if (empty($loadfromfileonly)) {

-            $overwritekey = 'MAIN_OVERWRITE_TRANS_' . $this->defaultlang;

+            $overwritekey = 'MAIN_OVERWRITE_TRANS_'.$this->defaultlang;

             if (!empty($conf->global->$overwritekey)) {    // Overwrite translation with key1:newstring1,key2:newstring2

                 // Overwrite translation with param MAIN_OVERWRITE_TRANS_xx_XX

                 $tmparray = explode(',', $conf->global->$overwritekey);

@@ -383,7 +383,7 @@ 
 

         // Check parameters

         if (empty($db))

-            return 0;    // Database handler can't be used

+            return 0; // Database handler can't be used

 

 

 

@@ -400,13 +400,13 @@ 
             return 0;

         }

 

-        $this->_tab_loaded[$newdomain] = 1;   // We want to be sure this function is called once only for domain 'database'

+        $this->_tab_loaded[$newdomain] = 1; // We want to be sure this function is called once only for domain 'database'

 

         $fileread = 0;

         $langofdir = $this->defaultlang;

 

         if (empty($langofdir)) { // This may occurs when load is called without setting the language and without providing a value for forcelangdir

-            DolUtils::dol_syslog("Error: " . get_class($this) . "::Load was called but language was not set yet with langs->setDefaultLang(). Nothing will be loaded.", LOG_WARNING);

+            DolUtils::dol_syslog("Error: ".get_class($this)."::Load was called but language was not set yet with langs->setDefaultLang(). Nothing will be loaded.", LOG_WARNING);

             return -1;

         }

 

@@ -417,7 +417,7 @@ 
         $usecachekey = '';

         // Using a memcached server

         if (!empty($conf->memcached->enabled) && !empty($conf->global->MEMCACHED_SERVER)) {

-            $usecachekey = $newdomain . '_' . $langofdir;    // Should not contains special chars

+            $usecachekey = $newdomain.'_'.$langofdir; // Should not contains special chars

         }

         // Using cache with shmop. Speed gain: 40ms - Memory overusage: 200ko (Size of session cache file)

         else if (isset($conf->global->MAIN_OPTIMIZE_SPEED) && ($conf->global->MAIN_OPTIMIZE_SPEED & 0x02)) {

@@ -428,20 +428,20 @@ 
             //DolUtils::dol_syslog('Translate::Load we will cache result into usecachekey '.$usecachekey);

             //global $aaa; $aaa+=1;

             //print $aaa." ".$usecachekey."\n";

-            require_once DOL_BASE_PATH . '/core/lib/memory.lib.php';

+            require_once DOL_BASE_PATH.'/core/lib/memory.lib.php';

             $tmparray = dol_getcache($usecachekey);

             if (is_array($tmparray) && count($tmparray)) {

                 $this->tab_translate += $tmparray; // Faster than array_merge($tmparray,$this->tab_translate). Note: If a valuer already exists into tab_translate, value into tmparaay is not added.

                 //print $newdomain."\n";

                 //var_dump($this->tab_translate);

                 $fileread = 1;

-                $found = true;      // Found in dolibarr PHP cache

+                $found = true; // Found in dolibarr PHP cache

             }

         }

 

         if (!$found && !empty($conf->global->MAIN_ENABLE_OVERWRITE_TRANSLATION)) {

             // Overwrite translation with database read

-            $sql = "SELECT transkey, transvalue FROM " . MAIN_DB_PREFIX . "overwrite_trans where lang='" . $db->escape($this->defaultlang) . "'";

+            $sql = "SELECT transkey, transvalue FROM ".MAIN_DB_PREFIX."overwrite_trans where lang='".$db->escape($this->defaultlang)."'";

             $resql = $db->query($sql);

 

             if ($resql) {

@@ -476,7 +476,7 @@ 
                     if ($usecachekey && count($tabtranslatedomain)) {

                         $ressetcache = dol_setcache($usecachekey, $tabtranslatedomain);

                         if ($ressetcache < 0) {

-                            $error = 'Failed to set cache for usecachekey=' . $usecachekey . ' result=' . $ressetcache;

+                            $error = 'Failed to set cache for usecachekey='.$usecachekey.' result='.$ressetcache;

                             DolUtils::dol_syslog($error, LOG_ERR);

                         }

                     }

@@ -490,7 +490,7 @@ 
             $this->_tab_loaded[$newdomain] = 1; // Set domain file as loaded

 

         if (empty($this->_tab_loaded[$newdomain]))

-            $this->_tab_loaded[$newdomain] = 2;           // Marque ce cas comme non trouve (no lines found for language)

+            $this->_tab_loaded[$newdomain] = 2; // Marque ce cas comme non trouve (no lines found for language)

 

         return 1;

     }

@@ -560,12 +560,12 @@ 
             $str = $this->tab_translate[$key];

 

             // Make some string replacement after translation

-            $replacekey = 'MAIN_REPLACE_TRANS_' . $this->defaultlang;

+            $replacekey = 'MAIN_REPLACE_TRANS_'.$this->defaultlang;

             if (!empty($conf->global->$replacekey)) {    // Replacement translation variable with string1:newstring1;string2:newstring2

                 $tmparray = explode(';', $conf->global->$replacekey);

                 foreach ($tmparray as $tmp) {

                     $tmparray2 = explode(':', $tmp);

-                    $str = preg_replace('/' . preg_quote($tmparray2[0]) . '/', $tmparray2[1], $str);

+                    $str = preg_replace('/'.preg_quote($tmparray2[0]).'/', $tmparray2[1], $str);

                 }

             }

 

@@ -635,12 +635,12 @@ 
             $str = $this->tab_translate[$key];

 

             // Make some string replacement after translation

-            $replacekey = 'MAIN_REPLACE_TRANS_' . $this->defaultlang;

+            $replacekey = 'MAIN_REPLACE_TRANS_'.$this->defaultlang;

             if (!empty($conf->global->$replacekey)) {    // Replacement translation variable with string1:newstring1;string2:newstring2

                 $tmparray = explode(';', $conf->global->$replacekey);

                 foreach ($tmparray as $tmp) {

                     $tmparray2 = explode(':', $tmp);

-                    $str = preg_replace('/' . preg_quote($tmparray2[0]) . '/', $tmparray2[1], $str);

+                    $str = preg_replace('/'.preg_quote($tmparray2[0]).'/', $tmparray2[1], $str);

                 }

             }

 

@@ -723,7 +723,7 @@ 
         }

 

         // We scan directory langs to detect available languages

-        $handle = opendir($langdir . "/langs");

+        $handle = opendir($langdir."/langs");

         $langs_available = array();

         while ($dir = trim(readdir($handle))) {

             if (preg_match('/^[a-z]+_[A-Z]+/i', $dir)) {

@@ -733,9 +733,9 @@ 
                     $langs_available[$dir] = $dir;

                 }

                 if ($usecode == 1 || !empty($conf->global->MAIN_SHOW_LANGUAGE_CODE)) {

-                    $langs_available[$dir] = $dir . ': ' . dol_trunc($this->trans('Language_' . $dir), $maxlength);

+                    $langs_available[$dir] = $dir.': '.dol_trunc($this->trans('Language_'.$dir), $maxlength);

                 } else {

-                    $langs_available[$dir] = $this->trans('Language_' . $dir);

+                    $langs_available[$dir] = $this->trans('Language_'.$dir);

                 }

             }

         }

@@ -755,13 +755,13 @@ 
         // phpcs:enable

         // Test si fichier dans repertoire de la langue

         foreach ($this->dir as $searchdir) {

-            if (is_readable(dol_osencode($searchdir . "/langs/" . $this->defaultlang . "/" . $filename)))

+            if (is_readable(dol_osencode($searchdir."/langs/".$this->defaultlang."/".$filename)))

                 return true;

 

             if ($searchalt) {

                 // Test si fichier dans repertoire de la langue alternative

                 if ($this->defaultlang != "en_US")

-                    $filenamealt = $searchdir . "/langs/en_US/" . $filename;

+                    $filenamealt = $searchdir."/langs/en_US/".$filename;

                 //else $filenamealt = $searchdir."/langs/fr_FR/".$filename;

                 if (is_readable(dol_osencode($filenamealt)))

                     return true;

@@ -798,8 +798,8 @@ 
                 continue; // We must not use dol_is_dir here, function may not be loaded

 

             $fonc = 'numberwords';

-            if (file_exists($newdir . '/functions_' . $fonc . '.lib.php')) {

-                include_once $newdir . '/functions_' . $fonc . '.lib.php';

+            if (file_exists($newdir.'/functions_'.$fonc.'.lib.php')) {

+                include_once $newdir.'/functions_'.$fonc.'.lib.php';

                 $newnumber = numberwords_getLabelFromNumber($this, $number, $isamount);

                 break;

             }

@@ -833,20 +833,20 @@ 
         // Check if a translation is available (this can call getTradFromKey)

         $tmp = $this->transnoentitiesnoconv($key);

         if ($tmp != $key && $tmp != 'ErrorBadValueForParamNotAString') {

-            return $tmp;    // Found in language array

+            return $tmp; // Found in language array

         }

 

         // Check in cache

         if (isset($this->cache_labels[$tablename][$key])) { // Can be defined to 0 or ''

-            return $this->cache_labels[$tablename][$key];   // Found in cache

+            return $this->cache_labels[$tablename][$key]; // Found in cache

         }

 

-        $sql = "SELECT " . $fieldlabel . " as label";

-        $sql .= " FROM " . MAIN_DB_PREFIX . $tablename;

-        $sql .= " WHERE " . $fieldkey . " = '" . $db->escape($keyforselect ? $keyforselect : $key) . "'";

+        $sql = "SELECT ".$fieldlabel." as label";

+        $sql .= " FROM ".MAIN_DB_PREFIX.$tablename;

+        $sql .= " WHERE ".$fieldkey." = '".$db->escape($keyforselect ? $keyforselect : $key)."'";

         if ($filteronentity)

-            $sql .= " AND entity IN (" . getEntity($tablename) . ')';

-        DolUtils::dol_syslog(get_class($this) . '::getLabelFromKey', LOG_DEBUG);

+            $sql .= " AND entity IN (".getEntity($tablename).')';

+        DolUtils::dol_syslog(get_class($this).'::getLabelFromKey', LOG_DEBUG);

         $resql = $db->query($sql);

         if ($resql) {

             $obj = $db->fetch_object($resql);

@@ -878,9 +878,9 @@ 
         $symbol = $this->getCurrencySymbol($currency_code);

 

         if (in_array($currency_code, array('USD')))

-            return $symbol . $amount;

+            return $symbol.$amount;

         else

-            return $amount . $symbol;

+            return $amount.$symbol;

     }

 

     /**

@@ -919,18 +919,18 @@ 
         global $db;

 

         if ($this->cache_currencies_all_loaded)

-            return 0;                                           // Cache already loaded for all

+            return 0; // Cache already loaded for all

         if (!empty($currency_code) && isset($this->cache_currencies[$currency_code]))

-            return 0;    // Cache already loaded for the currency

+            return 0; // Cache already loaded for the currency

 

         $sql = "SELECT code_iso, label, unicode";

-        $sql .= " FROM " . MAIN_DB_PREFIX . "c_currencies";

+        $sql .= " FROM ".MAIN_DB_PREFIX."c_currencies";

         $sql .= " WHERE active = 1";

         if (!empty($currency_code))

-            $sql .= " AND code_iso = '" . $db->escape($currency_code) . "'";

+            $sql .= " AND code_iso = '".$db->escape($currency_code)."'";

         //$sql.= " ORDER BY code_iso ASC"; // Not required, a sort is done later

 

-        DolUtils::dol_syslog(get_class($this) . '::loadCacheCurrencies', LOG_DEBUG);

+        DolUtils::dol_syslog(get_class($this).'::loadCacheCurrencies', LOG_DEBUG);

         $resql = $db->query($sql);

         if ($resql) {

             $this->load("dict");

@@ -945,7 +945,7 @@ 
                 $obj = $db->fetch_object($resql);

 

                 // Si traduction existe, on l'utilise, sinon on prend le libelle par defaut

-                $this->cache_currencies[$obj->code_iso]['label'] = ($obj->code_iso && $this->trans("Currency" . $obj->code_iso) != "Currency" . $obj->code_iso ? $this->trans("Currency" . $obj->code_iso) : ($obj->label != '-' ? $obj->label : ''));

+                $this->cache_currencies[$obj->code_iso]['label'] = ($obj->code_iso && $this->trans("Currency".$obj->code_iso) != "Currency".$obj->code_iso ? $this->trans("Currency".$obj->code_iso) : ($obj->label != '-' ? $obj->label : ''));

                 $this->cache_currencies[$obj->code_iso]['unicode'] = (array) json_decode($obj->unicode, true);

                 $label[$obj->code_iso] = $this->cache_currencies[$obj->code_iso]['label'];

                 $i++;

@@ -977,8 +977,8 @@ 
         $substitutionarray = array();

 

         foreach ($this->tab_translate as $code => $label) {

-            $substitutionarray['lang_' . $code] = $label;

-            $substitutionarray['__(' . $code . ')__'] = $label;

+            $substitutionarray['lang_'.$code] = $label;

+            $substitutionarray['__('.$code.')__'] = $label;

         }

 

         return $substitutionarray;

Braces +176 added lines, -117 removed lines

@@ -36,12 +36,15 @@ 
     function __construct()

     {

         $dir = DOL_BASE_PATH;

-        if (!empty($conf->file->character_set_client))

-            $this->charset_output = $conf->file->character_set_client; // If charset output is forced

-        if ($dir)

-            $this->dir = array($dir);

-        else

-            $this->dir = $conf->file->dol_document_root;

+        if (!empty($conf->file->character_set_client)) {
+                    $this->charset_output = $conf->file->character_set_client;
+        }
+        // If charset output is forced

+        if ($dir) {
+                    $this->dir = array($dir);
+        } else {
+                    $this->dir = $conf->file->dol_document_root;
+        }
     }

 

     /**

@@ -77,8 +80,9 @@ 
             $langpref = str_replace("-", "_", $langpref);

             $langlist = preg_split("/[;,]/", $langpref);

             $codetouse = $langlist[0];

-        } else

-            $codetouse = $srclang;

+        } else {
+                    $codetouse = $srclang;
+        }
 

         // We redefine $srclang

         $langpart = explode("_", $codetouse);

@@ -87,25 +91,27 @@ 
             // Array force long code from first part, even if long code is defined

             $longforshort = array('ar' => 'ar_SA');

             $longforshortexcep = array('ar_EG');

-            if (isset($longforshort[strtolower($langpart[0])]) && !in_array($codetouse, $longforshortexcep))

-                $srclang = $longforshort[strtolower($langpart[0])];

-            else if (!is_numeric($langpart[1])) {  // Second part YY may be a numeric with some Chrome browser

+            if (isset($longforshort[strtolower($langpart[0])]) && !in_array($codetouse, $longforshortexcep)) {
+                            $srclang = $longforshort[strtolower($langpart[0])];
+            } else if (!is_numeric($langpart[1])) {  // Second part YY may be a numeric with some Chrome browser

                 $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[1]);

                 $longforlong = array('no_nb' => 'nb_NO');

-                if (isset($longforlong[strtolower($srclang)]))

-                    $srclang = $longforlong[strtolower($srclang)];

-            } else

-                $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[0]);

-        }

-        else {      // If it's for a codetouse that is a short code xx

+                if (isset($longforlong[strtolower($srclang)])) {
+                                    $srclang = $longforlong[strtolower($srclang)];
+                }
+            } else {
+                            $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[0]);
+            }
+        } else {      // If it's for a codetouse that is a short code xx

             // Array to convert short lang code into long code.

             $longforshort = array('ar' => 'ar_SA', 'el' => 'el_GR', 'ca' => 'ca_ES', 'en' => 'en_US', 'nb' => 'nb_NO', 'no' => 'nb_NO');

-            if (isset($longforshort[strtolower($langpart[0])]))

-                $srclang = $longforshort[strtolower($langpart[0])];

-            else if (!empty($langpart[0]))

-                $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[0]);

-            else

-                $srclang = 'en_US';

+            if (isset($longforshort[strtolower($langpart[0])])) {
+                            $srclang = $longforshort[strtolower($langpart[0])];
+            } else if (!empty($langpart[0])) {
+                            $srclang = strtolower($langpart[0]) . "_" . strtoupper($langpart[0]);
+            } else {
+                            $srclang = 'en_US';
+            }
         }

 

         $this->defaultlang = $srclang;

@@ -121,10 +127,11 @@ 
      */

     function getDefaultLang($mode = 0)

     {

-        if (empty($mode))

-            return $this->defaultlang;

-        else

-            return substr($this->defaultlang, 0, 2);

+        if (empty($mode)) {
+                    return $this->defaultlang;
+        } else {
+                    return substr($this->defaultlang, 0, 2);
+        }
     }

 

     /**

@@ -170,8 +177,10 @@ 
             dol_print_error('', get_class($this) . "::Load ErrorWrongParameters");

             return -1;

         }

-        if ($this->defaultlang == 'none_NONE')

-            return 0;    // Special language code to not translate keys

+        if ($this->defaultlang == 'none_NONE') {
+                    return 0;
+        }
+        // Special language code to not translate keys

 

 

 

@@ -179,8 +188,10 @@ 
 

             

 // Load $this->tab_translate[] from database

-        if (empty($loadfromfileonly) && count($this->tab_translate) == 0)

-            $this->loadFromDatabase($db);      // No translation was never loaded yet, so we load database.

+        if (empty($loadfromfileonly) && count($this->tab_translate) == 0) {
+                    $this->loadFromDatabase($db);
+        }
+        // No translation was never loaded yet, so we load database.

 

 

         $newdomain = $domain;

@@ -203,10 +214,12 @@ 
 

         // Redefine alt

         $langarray = explode('_', $langofdir);

-        if ($alt < 1 && isset($langarray[1]) && (strtolower($langarray[0]) == strtolower($langarray[1]) || in_array(strtolower($langofdir), array('el_gr'))))

-            $alt = 1;

-        if ($alt < 2 && strtolower($langofdir) == 'en_us')

-            $alt = 2;

+        if ($alt < 1 && isset($langarray[1]) && (strtolower($langarray[0]) == strtolower($langarray[1]) || in_array(strtolower($langofdir), array('el_gr')))) {
+                    $alt = 1;
+        }
+        if ($alt < 2 && strtolower($langofdir) == 'en_us') {
+                    $alt = 2;
+        }
 

         if (empty($langofdir)) { // This may occurs when load is called without setting the language and without providing a value for forcelangdir

             DolUtils::dol_syslog("Error: " . get_class($this) . "::Load was called but language was not set yet with langs->setDefaultLang(). Nothing will be loaded.", LOG_WARNING);

@@ -248,16 +261,19 @@ 
                         $this->tab_translate += $tmparray; // Faster than array_merge($tmparray,$this->tab_translate). Note: If a value already exists into tab_translate, value into tmparaay is not added.

                         //print $newdomain."\n";

                         //var_dump($this->tab_translate);

-                        if ($alt == 2)

-                            $fileread = 1;

+                        if ($alt == 2) {
+                                                    $fileread = 1;
+                        }
                         $found = true;      // Found in dolibarr PHP cache

                     }

                 }

 

                 if (!$found) {

                     if ($fp = @fopen($file_lang, "rt")) {

-                        if ($usecachekey)

-                            $tabtranslatedomain = array(); // To save lang content in cache

+                        if ($usecachekey) {
+                                                    $tabtranslatedomain = array();
+                        }
+                        // To save lang content in cache

 

                         /**

                          * Read each lines until a '=' (with any combination of spaces around it)

@@ -305,8 +321,10 @@ 
                             }

                         }

 

-                        if (empty($conf->global->MAIN_FORCELANGDIR))

-                            break;  // Break loop on each root dir. If a module has forced dir, we do not stop loop.

+                        if (empty($conf->global->MAIN_FORCELANGDIR)) {
+                                                    break;
+                        }
+                        // Break loop on each root dir. If a module has forced dir, we do not stop loop.

                     }

                 }

             }

@@ -317,10 +335,14 @@ 
             // This function MUST NOT contains call to syslog

             //DolUtils::dol_syslog("Translate::Load loading alternate translation file (to complete ".$this->defaultlang."/".$newdomain.".lang file)", LOG_DEBUG);

             $langofdir = strtolower($langarray[0]) . '_' . strtoupper($langarray[0]);

-            if ($langofdir == 'el_EL')

-                $langofdir = 'el_GR';                     // main parent for el_CY is not 'el_EL' but 'el_GR'

-            if ($langofdir == 'ar_AR')

-                $langofdir = 'ar_SA';                     // main parent for ar_EG is not 'ar_AR' but 'ar_SA'

+            if ($langofdir == 'el_EL') {
+                            $langofdir = 'el_GR';
+            }
+            // main parent for el_CY is not 'el_EL' but 'el_GR'

+            if ($langofdir == 'ar_AR') {
+                            $langofdir = 'ar_SA';
+            }
+            // main parent for ar_EG is not 'ar_AR' but 'ar_SA'

             $this->load($domain, $alt + 1, $stopafterdirection, $langofdir);

         }

 

@@ -334,11 +356,15 @@ 
 

         // We are in the pass of the reference file. No more files to scan to complete.

         if ($alt == 2) {

-            if ($fileread)

-                $this->_tab_loaded[$newdomain] = 1;        // Set domain file as found so loaded

-

-            if (empty($this->_tab_loaded[$newdomain]))

-                $this->_tab_loaded[$newdomain] = 2; // Set this file as not found

+            if ($fileread) {
+                            $this->_tab_loaded[$newdomain] = 1;
+            }
+            // Set domain file as found so loaded

+

+            if (empty($this->_tab_loaded[$newdomain])) {
+                            $this->_tab_loaded[$newdomain] = 2;
+            }
+            // Set this file as not found

         }

 

         // This part is deprecated and replaced with table llx_overwrite_trans

@@ -350,15 +376,17 @@ 
                 $tmparray = explode(',', $conf->global->$overwritekey);

                 foreach ($tmparray as $tmp) {

                     $tmparray2 = explode(':', $tmp);

-                    if (!empty($tmparray2[1]))

-                        $this->tab_translate[$tmparray2[0]] = $tmparray2[1];

+                    if (!empty($tmparray2[1])) {
+                                            $this->tab_translate[$tmparray2[0]] = $tmparray2[1];
+                    }
                 }

             }

         }

 

         // Check to be sure that SeparatorDecimal differs from SeparatorThousand

-        if (!empty($this->tab_translate["SeparatorDecimal"]) && !empty($this->tab_translate["SeparatorThousand"]) && $this->tab_translate["SeparatorDecimal"] == $this->tab_translate["SeparatorThousand"])

-            $this->tab_translate["SeparatorThousand"] = '';

+        if (!empty($this->tab_translate["SeparatorDecimal"]) && !empty($this->tab_translate["SeparatorThousand"]) && $this->tab_translate["SeparatorDecimal"] == $this->tab_translate["SeparatorThousand"]) {
+                    $this->tab_translate["SeparatorThousand"] = '';
+        }
 

         return 1;

     }

@@ -382,8 +410,10 @@ 
         $domain = 'database';

 

         // Check parameters

-        if (empty($db))

-            return 0;    // Database handler can't be used

+        if (empty($db)) {
+                    return 0;
+        }
+        // Database handler can't be used

 

 

 

@@ -447,8 +477,10 @@ 
             if ($resql) {

                 $num = $db->num_rows($resql);

                 if ($num) {

-                    if ($usecachekey)

-                        $tabtranslatedomain = array(); // To save lang content in cache

+                    if ($usecachekey) {
+                                            $tabtranslatedomain = array();
+                    }
+                    // To save lang content in cache

 

                     $i = 0;

                     while ($i < $num) { // Ex: Need 225ms for all fgets on all lang file for Third party page. Same speed than file_get_contents

@@ -462,8 +494,10 @@ 
                             $value = trim(preg_replace('/\\n/', "\n", $value));

 

                             $this->tab_translate[$key] = $value;

-                            if ($usecachekey)

-                                $tabtranslatedomain[$key] = $value; // To save lang content in cache

+                            if ($usecachekey) {
+                                                            $tabtranslatedomain[$key] = $value;
+                            }
+                            // To save lang content in cache

                         }

 

                         $i++;

@@ -486,11 +520,15 @@ 
             }

         }

 

-        if ($fileread)

-            $this->_tab_loaded[$newdomain] = 1; // Set domain file as loaded

+        if ($fileread) {
+                    $this->_tab_loaded[$newdomain] = 1;
+        }
+        // Set domain file as loaded

 

-        if (empty($this->_tab_loaded[$newdomain]))

-            $this->_tab_loaded[$newdomain] = 2;           // Marque ce cas comme non trouve (no lines found for language)

+        if (empty($this->_tab_loaded[$newdomain])) {
+                    $this->_tab_loaded[$newdomain] = 2;
+        }
+        // Marque ce cas comme non trouve (no lines found for language)

 

         return 1;

     }

@@ -510,8 +548,10 @@ 
     {

         global $conf, $db;

 

-        if (!is_string($key))

-            return 'ErrorBadValueForParamNotAString'; // Avoid multiple errors with code not using function correctly.

+        if (!is_string($key)) {
+                    return 'ErrorBadValueForParamNotAString';
+        }
+        // Avoid multiple errors with code not using function correctly.

 

         $newstr = $key;

         if (preg_match('/^Civility([0-9A-Z]+)$/i', $key, $reg)) {

@@ -574,8 +614,9 @@ 
                 $str = sprintf($str, $param1, $param2, $param3, $param4); // Replace %s and %d except for FormatXXX strings.

             }

 

-            if ($maxsize)

-                $str = dol_trunc($str, $maxsize);

+            if ($maxsize) {
+                            $str = dol_trunc($str, $maxsize);
+            }
 

             // We replace some HTML tags by __xx__ to avoid having them encoded by htmlentities

             $str = str_replace(array('<', '>', '"',), array('__lt__', '__gt__', '__quot__'), $str);

@@ -586,8 +627,7 @@ 
             $str = str_replace(array('__lt__', '__gt__', '__quot__'), array('<', '>', '"',), $str);

 

             return $str;

-        }

-        else {        // Translation is not available

+        } else {        // Translation is not available

             //if ($key[0] == '$') { return dol_eval($key,1); }

             return $this->getTradFromKey($key);

         }

@@ -667,10 +707,11 @@ 
      */

     function transcountry($str, $countrycode)

     {

-        if ($this->tab_translate["$str$countrycode"])

-            return $this->trans("$str$countrycode");

-        else

-            return $this->trans($str);

+        if ($this->tab_translate["$str$countrycode"]) {
+                    return $this->trans("$str$countrycode");
+        } else {
+                    return $this->trans($str);
+        }
     }

 

     /**

@@ -682,10 +723,11 @@ 
      */

     function transcountrynoentities($str, $countrycode)

     {

-        if ($this->tab_translate["$str$countrycode"])

-            return $this->transnoentities("$str$countrycode");

-        else

-            return $this->transnoentities($str);

+        if ($this->tab_translate["$str$countrycode"]) {
+                    return $this->transnoentities("$str$countrycode");
+        } else {
+                    return $this->transnoentities($str);
+        }
     }

 

     /**

@@ -697,10 +739,12 @@ 
      */

     function convToOutputCharset($str, $pagecodefrom = 'UTF-8')

     {

-        if ($pagecodefrom == 'ISO-8859-1' && $this->charset_output == 'UTF-8')

-            $str = utf8_encode($str);

-        if ($pagecodefrom == 'UTF-8' && $this->charset_output == 'ISO-8859-1')

-            $str = utf8_decode(str_replace('€', chr(128), $str));

+        if ($pagecodefrom == 'ISO-8859-1' && $this->charset_output == 'UTF-8') {
+                    $str = utf8_encode($str);
+        }
+        if ($pagecodefrom == 'UTF-8' && $this->charset_output == 'ISO-8859-1') {
+                    $str = utf8_decode(str_replace('€', chr(128), $str));
+        }
         return $str;

     }

 

@@ -755,16 +799,19 @@ 
         // phpcs:enable

         // Test si fichier dans repertoire de la langue

         foreach ($this->dir as $searchdir) {

-            if (is_readable(dol_osencode($searchdir . "/langs/" . $this->defaultlang . "/" . $filename)))

-                return true;

+            if (is_readable(dol_osencode($searchdir . "/langs/" . $this->defaultlang . "/" . $filename))) {
+                            return true;
+            }
 

             if ($searchalt) {

                 // Test si fichier dans repertoire de la langue alternative

-                if ($this->defaultlang != "en_US")

-                    $filenamealt = $searchdir . "/langs/en_US/" . $filename;

+                if ($this->defaultlang != "en_US") {
+                                    $filenamealt = $searchdir . "/langs/en_US/" . $filename;
+                }
                 //else $filenamealt = $searchdir."/langs/fr_FR/".$filename;

-                if (is_readable(dol_osencode($filenamealt)))

-                    return true;

+                if (is_readable(dol_osencode($filenamealt))) {
+                                    return true;
+                }
             }

         }

 

@@ -794,8 +841,10 @@ 
             $newdir = dol_osencode($dir);

 

             // Check if directory exists

-            if (!is_dir($newdir))

-                continue; // We must not use dol_is_dir here, function may not be loaded

+            if (!is_dir($newdir)) {
+                            continue;
+            }
+            // We must not use dol_is_dir here, function may not be loaded

 

             $fonc = 'numberwords';

             if (file_exists($newdir . '/functions_' . $fonc . '.lib.php')) {

@@ -826,8 +875,9 @@ 
     function getLabelFromKey($db, $key, $tablename, $fieldkey, $fieldlabel, $keyforselect = '', $filteronentity = 0)

     {

         // If key empty

-        if ($key == '')

-            return '';

+        if ($key == '') {
+                    return '';
+        }
 

         //print 'param: '.$key.'-'.$keydatabase.'-'.$this->trans($key); exit;

         // Check if a translation is available (this can call getTradFromKey)

@@ -844,21 +894,22 @@ 
         $sql = "SELECT " . $fieldlabel . " as label";

         $sql .= " FROM " . MAIN_DB_PREFIX . $tablename;

         $sql .= " WHERE " . $fieldkey . " = '" . $db->escape($keyforselect ? $keyforselect : $key) . "'";

-        if ($filteronentity)

-            $sql .= " AND entity IN (" . getEntity($tablename) . ')';

+        if ($filteronentity) {
+                    $sql .= " AND entity IN (" . getEntity($tablename) . ')';
+        }
         DolUtils::dol_syslog(get_class($this) . '::getLabelFromKey', LOG_DEBUG);

         $resql = $db->query($sql);

         if ($resql) {

             $obj = $db->fetch_object($resql);

-            if ($obj)

-                $this->cache_labels[$tablename][$key] = $obj->label;

-            else

-                $this->cache_labels[$tablename][$key] = $key;

+            if ($obj) {
+                            $this->cache_labels[$tablename][$key] = $obj->label;
+            } else {
+                            $this->cache_labels[$tablename][$key] = $key;
+            }
 

             $db->free($resql);

             return $this->cache_labels[$tablename][$key];

-        }

-        else {

+        } else {

             $this->error = $db->lasterror();

             return -1;

         }

@@ -877,10 +928,11 @@ 
     {

         $symbol = $this->getCurrencySymbol($currency_code);

 

-        if (in_array($currency_code, array('USD')))

-            return $symbol . $amount;

-        else

-            return $amount . $symbol;

+        if (in_array($currency_code, array('USD'))) {
+                    return $symbol . $amount;
+        } else {
+                    return $amount . $symbol;
+        }
     }

 

     /**

@@ -918,16 +970,21 @@ 
     {

         global $db;

 

-        if ($this->cache_currencies_all_loaded)

-            return 0;                                           // Cache already loaded for all

-        if (!empty($currency_code) && isset($this->cache_currencies[$currency_code]))

-            return 0;    // Cache already loaded for the currency

+        if ($this->cache_currencies_all_loaded) {
+                    return 0;
+        }
+        // Cache already loaded for all

+        if (!empty($currency_code) && isset($this->cache_currencies[$currency_code])) {
+                    return 0;
+        }
+        // Cache already loaded for the currency

 

         $sql = "SELECT code_iso, label, unicode";

         $sql .= " FROM " . MAIN_DB_PREFIX . "c_currencies";

         $sql .= " WHERE active = 1";

-        if (!empty($currency_code))

-            $sql .= " AND code_iso = '" . $db->escape($currency_code) . "'";

+        if (!empty($currency_code)) {
+                    $sql .= " AND code_iso = '" . $db->escape($currency_code) . "'";
+        }
         //$sql.= " ORDER BY code_iso ASC"; // Not required, a sort is done later

 

         DolUtils::dol_syslog(get_class($this) . '::loadCacheCurrencies', LOG_DEBUG);

@@ -935,9 +992,11 @@ 
         if ($resql) {

             $this->load("dict");

             $label = array();

-            if (!empty($currency_code))

-                foreach ($this->cache_currencies as $key => $val)

-                    $label[$key] = $val['label']; // Label in already loaded cache

+            if (!empty($currency_code)) {
+                            foreach ($this->cache_currencies as $key => $val)

+                    $label[$key] = $val['label'];
+            }
+            // Label in already loaded cache

 

                 $num = $db->num_rows($resql);

             $i = 0;

@@ -950,15 +1009,15 @@ 
                 $label[$obj->code_iso] = $this->cache_currencies[$obj->code_iso]['label'];

                 $i++;

             }

-            if (empty($currency_code))

-                $this->cache_currencies_all_loaded = true;

+            if (empty($currency_code)) {
+                            $this->cache_currencies_all_loaded = true;
+            }
             //print count($label).' '.count($this->cache_currencies);

             // Resort cache

             array_multisort($label, SORT_ASC, $this->cache_currencies);

             //var_dump($this->cache_currencies);	$this->cache_currencies is now sorted onto label

             return $num;

-        }

-        else {

+        } else {

             dol_print_error($db);

             return -1;

         }