Inspection of "Fixed minor errors in the installation process" - alxarafe/alixar - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 324b47...7af4bb )

by Rafael

created 2024-06-15 09:02 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -361,7 +361,7 @@  discard block
 block discarded – undo
         return $this->LibStatut($this->status, $mode);
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return the status
      *
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
      */
     public function LibStatut($status, $mode = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         if (empty($this->labelStatus)) {
             global $langs;
             //$langs->load("emailcollector");

Please login to merge, or discard this patch.

htdocs/adherents/canvas/default/actions_adherentcard_default.class.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -74,7 +74,7 @@  discard block
 block discarded – undo
         return $out;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Assign custom values for canvas
      *
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
      */
     public function assign_values(&$action, $id)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $db, $langs, $user;
         global $form;
 

Please login to merge, or discard this patch.

htdocs/core/modules/expedition/doc/doc_generic_shipment_odt.modules.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -195,7 +195,7 @@  discard block
 block discarded – undo
         return $texte;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build a document on disk using the generic odt module.
      *
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (empty($srctemplatepath)) {

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -176,7 +176,7 @@
 block discarded – undo
         $maxfilesizearray = getMaxFileSizeArray();
         $maxmin = $maxfilesizearray['maxmin'];
         if ($maxmin > 0) {
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
         }
         $texte .= ' <input type="file" name="uploadfile">';
         $texte .= '<input type="hidden" value="EXPEDITION_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';

Please login to merge, or discard this patch.

htdocs/core/modules/bom/doc/doc_generic_bom_odt.modules.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -195,7 +195,7 @@  discard block
 block discarded – undo
         return $texte;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build a document on disk using the generic odt module.
      *
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (empty($srctemplatepath)) {

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -170,7 +170,7 @@
 block discarded – undo
         $maxfilesizearray = getMaxFileSizeArray();
         $maxmin = $maxfilesizearray['maxmin'];
         if ($maxmin > 0) {
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
         }
         $texte .= ' <input type="file" name="uploadfile">';
         $texte .= '<input type="hidden" value="BOM_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';

Please login to merge, or discard this patch.

modules/supplier_proposal/doc/doc_generic_supplier_proposal_odt.modules.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -195,7 +195,7 @@  discard block
 block discarded – undo
         return $texte;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build a document on disk using the generic odt module.
      *
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (empty($srctemplatepath)) {

Please login to merge, or discard this patch.

htdocs/core/modules/asset/doc/doc_generic_asset_odt.modules.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -195,7 +195,7 @@  discard block
 block discarded – undo
         return $texte;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build a document on disk using the generic odt module.
      *
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (empty($srctemplatepath)) {

Please login to merge, or discard this patch.

htdocs/core/modules/propale/doc/doc_generic_proposal_odt.modules.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -195,7 +195,7 @@  discard block
 block discarded – undo
         return $texte;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build a document on disk using the generic odt module.
      *
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (empty($srctemplatepath)) {

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -210,7 +210,7 @@
 block discarded – undo
         $maxfilesizearray = getMaxFileSizeArray();
         $maxmin = $maxfilesizearray['maxmin'];
         if ($maxmin > 0) {
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
         }
         $texte .= ' <input type="file" name="uploadfile">';
         $texte .= '<input type="hidden" value="PROPALE_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';

Please login to merge, or discard this patch.

htdocs/core/modules/mailings/partnership.modules.php 2 patches

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *    This is the main function that returns the array of emails
      *
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
      */
     public function add_to_target($mailing_id)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $langs;
 
         $cibles = array();

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -234,7 +234,7 @@  discard block
 block discarded – undo
             $num = $this->db->num_rows($resql);
 
             if (empty($conf->partnership->enabled)) {
-                $num = 0;   // Force empty list if category module is not enabled
+                $num = 0; // Force empty list if category module is not enabled
             }
 
             if ($num) {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
         // filter_status_thirdparties
         include_once DOL_DOCUMENT_ROOT . '/partnership/class/partnership.class.php';
         $tmppartnership = new Partnership($this->db);
-        $dummy = $tmppartnership->getLibStatut(0);  // We call this only to have $tmppartnership->labelStatus loaded
+        $dummy = $tmppartnership->getLibStatut(0); // We call this only to have $tmppartnership->labelStatus loaded
 
         $s .= $form->selectarray('filter_status_partnership', $tmppartnership->labelStatus, GETPOST('filter_status_partnership'), $langs->trans("Status"));
 

Please login to merge, or discard this patch.

htdocs/core/modules/mailings/thirdparties.modules.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *    This is the main function that returns the array of emails
      *
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
      */
     public function add_to_target($mailing_id)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $langs;
 
         $cibles = array();

Please login to merge, or discard this patch.

		@@ -361,7 +361,7 @@ discard block
		block discarded – undo
361	361	return $this->LibStatut($this->status, $mode);
362	362	}
363	363
364		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	364	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
365	365	/**
366	366	* Return the status
367	367	*
		@@ -371,7 +371,7 @@ discard block
		block discarded – undo
371	371	*/
372	372	public function LibStatut($status, $mode = 0)
373	373	{
374		- // phpcs:enable
	374	+ // phpcs:enable
375	375	if (empty($this->labelStatus)) {
376	376	global $langs;
377	377	//$langs->load("emailcollector");

		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	return $out;
75	75	}
76	76
77		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	77	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
78	78	/**
79	79	* Assign custom values for canvas
80	80	*
		@@ -84,7 +84,7 @@ discard block
		block discarded – undo
84	84	*/
85	85	public function assign_values(&$action, $id)
86	86	{
87		- // phpcs:enable
	87	+ // phpcs:enable
88	88	global $conf, $db, $langs, $user;
89	89	global $form;
90	90

		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	return $texte;
196	196	}
197	197
198		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	198	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
199	199	/**
200	200	* Function to build a document on disk using the generic odt module.
201	201	*
		@@ -209,7 +209,7 @@ discard block
		block discarded – undo
209	209	*/
210	210	public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
211	211	{
212		- // phpcs:enable
	212	+ // phpcs:enable
213	213	global $user, $langs, $conf, $mysoc, $hookmanager;
214	214
215	215	if (empty($srctemplatepath)) {

		@@ -176,7 +176,7 @@
		block discarded – undo
176	176	$maxfilesizearray = getMaxFileSizeArray();
177	177	$maxmin = $maxfilesizearray['maxmin'];
178	178	if ($maxmin > 0) {
179		- $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
	179	+ $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
180	180	}
181	181	$texte .= ' <input type="file" name="uploadfile">';
182	182	$texte .= '<input type="hidden" value="EXPEDITION_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';

		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	return $texte;
196	196	}
197	197
198		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	198	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
199	199	/**
200	200	* Function to build a document on disk using the generic odt module.
201	201	*
		@@ -209,7 +209,7 @@ discard block
		block discarded – undo
209	209	*/
210	210	public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
211	211	{
212		- // phpcs:enable
	212	+ // phpcs:enable
213	213	global $user, $langs, $conf, $mysoc, $hookmanager;
214	214
215	215	if (empty($srctemplatepath)) {

		@@ -170,7 +170,7 @@
		block discarded – undo
170	170	$maxfilesizearray = getMaxFileSizeArray();
171	171	$maxmin = $maxfilesizearray['maxmin'];
172	172	if ($maxmin > 0) {
173		- $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
	173	+ $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
174	174	}
175	175	$texte .= ' <input type="file" name="uploadfile">';
176	176	$texte .= '<input type="hidden" value="BOM_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';

		@@ -210,7 +210,7 @@
		block discarded – undo
210	210	$maxfilesizearray = getMaxFileSizeArray();
211	211	$maxmin = $maxfilesizearray['maxmin'];
212	212	if ($maxmin > 0) {
213		- $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
	213	+ $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
214	214	}
215	215	$texte .= ' <input type="file" name="uploadfile">';
216	216	$texte .= '<input type="hidden" value="PROPALE_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';

		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	}
57	57
58	58
59		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	59	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
60	60	/**
61	61	* This is the main function that returns the array of emails
62	62	*
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	*/
66	66	public function add_to_target($mailing_id)
67	67	{
68		- // phpcs:enable
	68	+ // phpcs:enable
69	69	global $conf, $langs;
70	70
71	71	$cibles = array();

		@@ -234,7 +234,7 @@ discard block
		block discarded – undo
234	234	$num = $this->db->num_rows($resql);
235	235
236	236	if (empty($conf->partnership->enabled)) {
237		- $num = 0; // Force empty list if category module is not enabled
	237	+ $num = 0; // Force empty list if category module is not enabled
238	238	}
239	239
240	240	if ($num) {
		@@ -259,7 +259,7 @@ discard block
		block discarded – undo
259	259	// filter_status_thirdparties
260	260	include_once DOL_DOCUMENT_ROOT . '/partnership/class/partnership.class.php';
261	261	$tmppartnership = new Partnership($this->db);
262		- $dummy = $tmppartnership->getLibStatut(0); // We call this only to have $tmppartnership->labelStatus loaded
	262	+ $dummy = $tmppartnership->getLibStatut(0); // We call this only to have $tmppartnership->labelStatus loaded
263	263
264	264	$s .= $form->selectarray('filter_status_partnership', $tmppartnership->labelStatus, GETPOST('filter_status_partnership'), $langs->trans("Status"));
265	265

alxarafe / alixar

Push — main ( 324b47...7af4bb )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch