Test Failed
Branch main (fda838)
by Rafael
54:38 queued 11s
created

AccountancyCategory   F

Complexity

Total Complexity 124

Size/Duplication

Total Lines 867
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 465
dl 0
loc 867
rs 2
c 0
b 0
f 0
wmc 124

How to fix   Complexity   

Complex Class

Complex classes like AccountancyCategory often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use AccountancyCategory, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
/* Copyright (C) 2016       Jamal Elbaz         <[email protected]>
4
 * Copyright (C) 2016-2017	Alexandre Spangaro	<[email protected]>
5
 * Copyright (C) 2018-2023  Frédéric France     <[email protected]>
6
 *
7
 * This program is free software; you can redistribute it and/or modify
8
 * it under the terms of the GNU General Public License as published by
9
 * the Free Software Foundation; either version 3 of the License, or
10
 * (at your option) any later version.
11
 *
12
 * This program is distributed in the hope that it will be useful,
13
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15
 * GNU General Public License for more details.
16
 *
17
 * You should have received a copy of the GNU General Public License
18
 * along with this program. If not, see <https://www.gnu.org/licenses/>.
19
 */
20
21
/**
22
 * \file    htdocs/accountancy/class/accountancycategory.class.php
23
 * \ingroup Accountancy (Double entries)
24
 * \brief   File of class to manage categories of an accounting category_type
25
 *
26
 * Replaced by Deprecated/Modules/Accounting/Model/AccountancyCategory.php
27
 */