Test Failed
Branch main (fda838)
by Rafael
50:22
created

Adherent::subscriptionComplementaryActions()   F

Complexity

Conditions 52
Paths > 20000

Size

Total Lines 247
Code Lines 156

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 52
eloc 156
nc 114671710
nop 14
dl 0
loc 247
rs 0
c 0
b 0
f 0

How to fix   Long Method    Complexity    Many Parameters   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
/* Copyright (C) 2002-2003  Rodolphe Quiedeville    <[email protected]>
4
 * Copyright (C) 2002-2003	Jean-Louis Bergamo		<[email protected]>
5
 * Copyright (C) 2004-2012	Laurent Destailleur		<[email protected]>
6
 * Copyright (C) 2004		Sebastien Di Cintio		<[email protected]>
7
 * Copyright (C) 2004		Benoit Mortier			<[email protected]>
8
 * Copyright (C) 2009-2017	Regis Houssin			<[email protected]>
9
 * Copyright (C) 2014-2018	Alexandre Spangaro		<[email protected]>
10
 * Copyright (C) 2015		Marcos García			<[email protected]>
11
 * Copyright (C) 2015-2024	Frédéric France			<[email protected]>
12
 * Copyright (C) 2015		Raphaël Doursenaud		<[email protected]>
13
 * Copyright (C) 2016		Juanjo Menent			<[email protected]>
14
 * Copyright (C) 2018-2019	Thibault FOUCART		<[email protected]>
15
 * Copyright (C) 2019		Nicolas ZABOURI 		<[email protected]>
16
 * Copyright (C) 2020		Josep Lluís Amador 		<[email protected]>
17
 * Copyright (C) 2021		Waël Almoman            <[email protected]>
18
 * Copyright (C) 2021		Philippe Grand          <[email protected]>
19
 * Copyright (C) 2024		MDW							<[email protected]>
20
 *
21
 * This program is free software; you can redistribute it and/or modify
22
 * it under the terms of the GNU General Public License as published by
23
 * the Free Software Foundation; either version 3 of the License, or
24
 * (at your option) any later version.
25
 *
26
 * This program is distributed in the hope that it will be useful,
27
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
28
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
29
 * GNU General Public License for more details.
30
 *
31
 * You should have received a copy of the GNU General Public License
32
 * along with this program. If not, see <https://www.gnu.org/licenses/>.
33
 */
34
35
/**
36
 * \file       htdocs/adherents/class/adherent.class.php
37
 * \ingroup    member
38
 * \brief      File of class to manage members of a foundation
39
 *
40
 * Replaced by Deprecated/Modules/Adherent/Model/Adherent.php
41
 */
42