Test Failed
Branch main (fda838)
by Rafael
50:22
created

Lettering   F

Complexity

Total Complexity 136

Size/Duplication

Total Lines 846
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 506
dl 0
loc 846
rs 2
c 0
b 0
f 0
wmc 136

How to fix   Complexity   

Complex Class

Complex classes like Lettering often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Lettering, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
/* Copyright (C) 2004-2005  Rodolphe Quiedeville    <[email protected]>
4
 * Copyright (C) 2013       Olivier Geffroy         <[email protected]>
5
 * Copyright (C) 2013-2023  Alexandre Spangaro      <[email protected]>
6
 * Copyright (C) 2018       Frédéric France         <[email protected]>
7
 *
8
 * This program is free software; you can redistribute it and/or modify
9
 * it under the terms of the GNU General Public License as published by
10
 * the Free Software Foundation; either version 3 of the License, or
11
 * (at your option) any later version.
12
 *
13
 * This program is distributed in the hope that it will be useful,
14
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
16
 * GNU General Public License for more details.
17
 *
18
 * You should have received a copy of the GNU General Public License
19
 * along with this program. If not, see <https://www.gnu.org/licenses/>.
20
 */
21
22
/**
23
 * \file        htdocs/accountancy/class/lettering.class.php
24
 * \ingroup     Accountancy (Double entries)
25
 * \brief       File of class for lettering
26
 *
27
 * Replaced by Deprecated/Modules/Accounting/Model/Lettering.php
28
 */
29