Test Failed
Push — main ( a7121c...c8394f )
by Rafael
91:23
created
public/htdocs/comm/mailing/card.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
     }
472 472
 
473 473
     // Action send test emailing
474
-    if ($action == 'send' && ! $cancel && $permissiontovalidatesend) {
474
+    if ($action == 'send' && !$cancel && $permissiontovalidatesend) {
475 475
         $error = 0;
476 476
 
477 477
         $upload_dir = $conf->mailing->dir_output . "/" . get_exdir($object->id, 2, 0, 1, $object, 'mailing');
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
     if ($action == 'add' && $permissiontocreate) {
550 550
         $mesgs = array();
551 551
 
552
-        $object->messtype       = (string) GETPOST("messtype");
552
+        $object->messtype = (string) GETPOST("messtype");
553 553
         if ($object->messtype == 'sms') {
554 554
             $object->email_from     = (string) GETPOST("from_phone", 'alphawithlgt'); // Must allow 'name <email>'
555 555
         } else {
@@ -1515,7 +1515,7 @@  discard block
 block discarded – undo
1515 1515
                 $maxfilesizearray = getMaxFileSizeArray();
1516 1516
                 $maxmin = $maxfilesizearray['maxmin'];
1517 1517
                 if ($maxmin > 0) {
1518
-                    $out .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';  // MAX_FILE_SIZE must precede the field type=file
1518
+                    $out .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
1519 1519
                 }
1520 1520
                 $out .= '<input type="file" class="flat" id="addedfile" name="addedfile" value="' . $langs->trans("Upload") . '" />';
1521 1521
                 $out .= ' ';
Please login to merge, or discard this patch.
public/htdocs/comm/mailing/cibles.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
             }
395 395
         }
396 396
         if (empty($nbemail)) {
397
-            $nbemail .= ' ' . img_warning($langs->trans('ToAddRecipientsChooseHere'));//.' <span class="warning">'.$langs->trans("NoTargetYet").'</span>';
397
+            $nbemail .= ' ' . img_warning($langs->trans('ToAddRecipientsChooseHere')); //.' <span class="warning">'.$langs->trans("NoTargetYet").'</span>';
398 398
         }
399 399
         if ($text) {
400 400
             // @phan-suppress-next-line PhanPluginSuspiciousParamPosition
@@ -549,12 +549,12 @@  discard block
 block discarded – undo
549 549
                     }
550 550
                     print img_object($langs->trans("EmailingTargetSelector") . ': ' . get_class($obj), $obj->picto, 'class="valignmiddle width25 size15x"');
551 551
                     print '</div>';
552
-                    print '<div class="tagtd valignmiddle">';   //  style="height: 4em"
552
+                    print '<div class="tagtd valignmiddle">'; //  style="height: 4em"
553 553
                     print $obj->getDesc();
554 554
                     print '</div>';
555 555
 
556 556
                     try {
557
-                        $obj->evenunsubscribe = $object->evenunsubscribe;   // Set flag to include/exclude email that has opt-out.
557
+                        $obj->evenunsubscribe = $object->evenunsubscribe; // Set flag to include/exclude email that has opt-out.
558 558
 
559 559
                         $nbofrecipient = $obj->getNbOfRecipients('');
560 560
                     } catch (Exception $e) {
@@ -899,7 +899,7 @@  discard block
 block discarded – undo
899 899
                 print '<td class="center nowraponall">';
900 900
                 if ($obj->status != $object::STATUS_DRAFT) {        // If status of target line is not draft
901 901
                     // Date sent
902
-                    print $obj->date_envoi;     // @TODO Must store date in date format
902
+                    print $obj->date_envoi; // @TODO Must store date in date format
903 903
                 }
904 904
                 print '</td>';
905 905
 
Please login to merge, or discard this patch.
public/htdocs/comm/mailing/list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 // Initialize technical objects
65 65
 $object = new Mailing($db);
66 66
 $extrafields = new ExtraFields($db);
67
-$hookmanager->initHooks(array($contextpage));   // Note that conf->hooks_modules contains array of activated contexes
67
+$hookmanager->initHooks(array($contextpage)); // Note that conf->hooks_modules contains array of activated contexes
68 68
 
69 69
 // Fetch optionals attributes and labels
70 70
 $extrafields->fetch_name_optionals_label($object->table_element);
Please login to merge, or discard this patch.
public/htdocs/comm/mailing/class/advtargetemailing.class.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         }
266 266
     }
267 267
 
268
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
268
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
269 269
     /**
270 270
      *  Load object in memory from the database
271 271
      *
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
      */
275 275
     public function fetch_by_mailing($id = 0)
276 276
     {
277
-		// phpcs:enable
277
+        // phpcs:enable
278 278
         global $langs;
279 279
         $sql = "SELECT";
280 280
         $sql .= " t.rowid,";
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
 
328 328
 
329 329
 
330
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
330
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
331 331
     /**
332 332
      *  Load object in memory from the database
333 333
      *
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
      */
338 338
     public function fetch_by_element($id = 0, $type_element = 'mailing')
339 339
     {
340
-		// phpcs:enable
340
+        // phpcs:enable
341 341
         global $langs;
342 342
         $sql = "SELECT";
343 343
         $sql .= " t.rowid,";
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
 
520 520
 
521 521
 
522
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
522
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
523 523
     /**
524 524
      * Load object in memory from database
525 525
      *
@@ -528,7 +528,7 @@  discard block
 block discarded – undo
528 528
      */
529 529
     public function query_thirdparty($arrayquery)
530 530
     {
531
-		// phpcs:enable
531
+        // phpcs:enable
532 532
         global $langs, $conf, $extrafields;
533 533
 
534 534
         $sql = "SELECT";
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
         }
677 677
     }
678 678
 
679
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
679
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
680 680
     /**
681 681
      * Load object in memory from database
682 682
      *
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
      */
687 687
     public function query_contact($arrayquery, $withThirdpartyFilter = 0)
688 688
     {
689
-		// phpcs:enable
689
+        // phpcs:enable
690 690
         global $langs, $conf;
691 691
 
692 692
         $sql = "SELECT";
Please login to merge, or discard this patch.
public/htdocs/comm/mailing/class/mailing.class.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
         }
622 622
     }
623 623
 
624
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
624
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
625 625
     /**
626 626
      *  Delete targets emailing
627 627
      *
@@ -629,7 +629,7 @@  discard block
 block discarded – undo
629 629
      */
630 630
     public function delete_targets()
631 631
     {
632
-		// phpcs:enable
632
+        // phpcs:enable
633 633
         $sql = "DELETE FROM " . MAIN_DB_PREFIX . "mailing_cibles";
634 634
         $sql .= " WHERE fk_mailing = " . ((int) $this->id);
635 635
 
@@ -646,7 +646,7 @@  discard block
 block discarded – undo
646 646
     }
647 647
 
648 648
 
649
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
649
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
650 650
     /**
651 651
      *  Change status of each recipient
652 652
      *
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
      */
656 656
     public function reset_targets_status($user)
657 657
     {
658
-		// phpcs:enable
658
+        // phpcs:enable
659 659
         $sql = "UPDATE " . MAIN_DB_PREFIX . "mailing_cibles";
660 660
         $sql .= " SET statut = 0";
661 661
         $sql .= " WHERE fk_mailing = " . ((int) $this->id);
@@ -870,7 +870,7 @@  discard block
 block discarded – undo
870 870
         return $this->LibStatut($this->status, $mode);
871 871
     }
872 872
 
873
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
873
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
874 874
     /**
875 875
      *  Return the label of a given status
876 876
      *
@@ -880,7 +880,7 @@  discard block
 block discarded – undo
880 880
      */
881 881
     public function LibStatut($status, $mode = 0)
882 882
     {
883
-		// phpcs:enable
883
+        // phpcs:enable
884 884
         global $langs;
885 885
         $langs->load("mailing");
886 886
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
                 $this->title = $obj->title;
385 385
                 $this->messtype = $obj->messtype;
386 386
 
387
-                $this->statut = $obj->status;   // deprecated
387
+                $this->statut = $obj->status; // deprecated
388 388
                 $this->status = $obj->status;
389 389
 
390 390
                 $this->nbemail = $obj->nbemail;
@@ -727,7 +727,7 @@  discard block
 block discarded – undo
727 727
                 $sql .= ' WHERE rowid = ' . ((int) $this->id);
728 728
 
729 729
                 $resqlupdate = $this->db->query($sql);
730
-                if (! $resqlupdate) {
730
+                if (!$resqlupdate) {
731 731
                     $this->error = $this->db->lasterror();
732 732
                     return -1;
733 733
                 } else {
Please login to merge, or discard this patch.
public/htdocs/comm/action/card.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 $offsetunit = GETPOST('offsetunittype_duration', 'aZ09');
76 76
 $remindertype = GETPOST('selectremindertype', 'aZ09');
77 77
 $modelmail = GETPOSTINT('actioncommsendmodel_mail');
78
-$complete = GETPOST('complete', 'alpha');   // 'na' must be allowed
78
+$complete = GETPOST('complete', 'alpha'); // 'na' must be allowed
79 79
 $private = GETPOST('private', 'alphanohtml');
80 80
 if ($complete == 'na' || $complete == -2) {
81 81
     $complete = -1;
@@ -610,12 +610,12 @@  discard block
 block discarded – undo
610 610
             if ($selectedrecurrulefreq == 'WEEKLY' && !empty($selectedrecurrulebyday)) {
611 611
                 $firstdatearray = dol_get_first_day_week(GETPOSTINT("apday"), GETPOSTINT("apmonth"), GETPOSTINT("apyear"));
612 612
                 $datep = dol_mktime($fulldayevent ? '00' : GETPOSTINT("aphour"), $fulldayevent ? '00' : GETPOSTINT("apmin"), $fulldayevent ? '00' : GETPOSTINT("apsec"), $firstdatearray['month'], $firstdatearray['first_day'], $firstdatearray['year'], $tzforfullday ? $tzforfullday : 'tzuserrel');
613
-                $datep = dol_time_plus_duree($datep, $selectedrecurrulebyday + 6, 'd');//We begin the week after
613
+                $datep = dol_time_plus_duree($datep, $selectedrecurrulebyday + 6, 'd'); //We begin the week after
614 614
                 $dayoffset = 7;
615 615
                 $monthoffset = 0;
616 616
             } elseif ($selectedrecurrulefreq == 'MONTHLY' && !empty($selectedrecurrulebymonthday)) {
617 617
                 $firstday = $selectedrecurrulebymonthday;
618
-                $firstmonth = GETPOST("apday") > $selectedrecurrulebymonthday ? GETPOSTINT("apmonth") + 1 : GETPOSTINT("apmonth");//We begin the week after
618
+                $firstmonth = GETPOST("apday") > $selectedrecurrulebymonthday ? GETPOSTINT("apmonth") + 1 : GETPOSTINT("apmonth"); //We begin the week after
619 619
                 $datep = dol_mktime($fulldayevent ? '00' : GETPOSTINT("aphour"), $fulldayevent ? '00' : GETPOSTINT("apmin"), $fulldayevent ? '00' : GETPOSTINT("apsec"), $firstmonth, $firstday, GETPOSTINT("apyear"), $tzforfullday ? $tzforfullday : 'tzuserrel');
620 620
                 $dayoffset = 0;
621 621
                 $monthoffset = 1;
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
             reset($object->socpeopleassigned);
820 820
             $object->contact_id = key($object->socpeopleassigned);
821 821
         }
822
-        $object->fk_project  = GETPOSTINT("projectid");
822
+        $object->fk_project = GETPOSTINT("projectid");
823 823
         $object->note_private = trim(GETPOST("note", "restricthtml"));
824 824
 
825 825
         if (GETPOST("elementtype", 'alpha')) {
@@ -1063,7 +1063,7 @@  discard block
 block discarded – undo
1063 1063
 if (empty($reshook) && GETPOST('actionmove', 'alpha') == 'mupdate') {
1064 1064
     $error = 0;
1065 1065
 
1066
-    $shour = dol_print_date($object->datep, "%H", 'tzuserrel');     // We take the date visible by user $newdate is also date visible by user.
1066
+    $shour = dol_print_date($object->datep, "%H", 'tzuserrel'); // We take the date visible by user $newdate is also date visible by user.
1067 1067
     $smin = dol_print_date($object->datep, "%M", 'tzuserrel');
1068 1068
 
1069 1069
     $newdate = GETPOST('newdate', 'alpha');
@@ -1273,7 +1273,7 @@  discard block
 block discarded – undo
1273 1273
         $default = getDolGlobalString('AGENDA_USE_EVENT_TYPE_DEFAULT', 'AC_RDV');
1274 1274
         print img_picto($langs->trans("ActionType"), 'square', 'class="fawidth30 inline-block" style="color: #ddd;"');
1275 1275
         $selectedvalue = GETPOSTISSET("actioncode") ? GETPOST("actioncode", 'aZ09') : ($object->type_code ? $object->type_code : $default);
1276
-        print $formactions->select_type_actions($selectedvalue, "actioncode", "systemauto", 0, -1, 0, 1);   // TODO Replace 0 with -2 in onlyautoornot
1276
+        print $formactions->select_type_actions($selectedvalue, "actioncode", "systemauto", 0, -1, 0, 1); // TODO Replace 0 with -2 in onlyautoornot
1277 1277
         print '</td></tr>';
1278 1278
     }
1279 1279
 
@@ -1587,7 +1587,7 @@  discard block
 block discarded – undo
1587 1587
         }
1588 1588
         //var_dump('origin='.$origin.' originid='.$originid.' hasPermissionOnLinkedObject='.$hasPermissionOnLinkedObject);
1589 1589
 
1590
-        if (! in_array($origin, array('societe', 'project', 'task', 'user'))) {
1590
+        if (!in_array($origin, array('societe', 'project', 'task', 'user'))) {
1591 1591
             // We do not use link for object that already contains a hard coded field to make links with agenda events
1592 1592
             print '<tr><td class="titlefieldcreate">' . $langs->trans("LinkedObject") . '</td>';
1593 1593
             print '<td colspan="3">';
@@ -1738,7 +1738,7 @@  discard block
 block discarded – undo
1738 1738
             $object->socpeopleassigned[$id] = array('id' => $tmpid);
1739 1739
         }
1740 1740
         $object->contact_id   = GETPOSTINT("contactid");
1741
-        $object->fk_project  = GETPOSTINT("projectid");
1741
+        $object->fk_project = GETPOSTINT("projectid");
1742 1742
 
1743 1743
         $object->note_private = GETPOST("note", 'restricthtml');
1744 1744
     }
@@ -1814,7 +1814,7 @@  discard block
 block discarded – undo
1814 1814
         if ($backtopage) {
1815 1815
             print '<input type="hidden" name="backtopage" value="' . ($backtopage != '1' ? $backtopage : '') . '">';
1816 1816
         }
1817
-        if (!getDolGlobalString('AGENDA_USE_EVENT_TYPE') && ! preg_match('/^TICKET_MSG_PRIVATE/', $object->code)) {
1817
+        if (!getDolGlobalString('AGENDA_USE_EVENT_TYPE') && !preg_match('/^TICKET_MSG_PRIVATE/', $object->code)) {
1818 1818
             print '<input type="hidden" name="actioncode" value="' . $object->type_code . '">';
1819 1819
         }
1820 1820
 
@@ -2187,7 +2187,7 @@  discard block
 block discarded – undo
2187 2187
                    })';
2188 2188
             print '</script>' . "\n";
2189 2189
 
2190
-            print '</div>';     // End of div for reminderparameters
2190
+            print '</div>'; // End of div for reminderparameters
2191 2191
         }
2192 2192
 
2193 2193
         print dol_get_fiche_end();
Please login to merge, or discard this patch.
public/htdocs/comm/action/pertype.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 //if (! ($usergroup > 0) && ! ($filtert > 0)) $filtert = $user->id;
57 57
 
58 58
 // $showbirthday = empty($conf->use_javascript_ajax)?GETPOST("showbirthday","int"):1;
59
-$showbirthday = 0;    // will be hidden here
59
+$showbirthday = 0; // will be hidden here
60 60
 
61 61
 // If not choice done on calendar owner, we filter on user.
62 62
 if (empty($filtert) && !getDolGlobalString('AGENDA_ALL_CALENDARS')) {
@@ -997,8 +997,8 @@  discard block
 block discarded – undo
997 997
     // We are in a particular day for $username, now we scan all events
998 998
     foreach ($eventarray as $daykey => $notused) {
999 999
         $annee = dol_print_date($daykey, '%Y', 'tzuserrel');
1000
-        $mois =  dol_print_date($daykey, '%m', 'tzuserrel');
1001
-        $jour =  dol_print_date($daykey, '%d', 'tzuserrel');
1000
+        $mois = dol_print_date($daykey, '%m', 'tzuserrel');
1001
+        $jour = dol_print_date($daykey, '%d', 'tzuserrel');
1002 1002
 
1003 1003
         if ($day == $jour && (int) $month == (int) $mois && $year == $annee) {  // Is it the day we are looking for when calling function ?
1004 1004
             // Scan all event for this date
Please login to merge, or discard this patch.
public/htdocs/comm/action/list.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
 $mode = GETPOST('mode', 'aZ09');
59 59
 if (empty($mode) && preg_match('/show_/', $action)) {
60
-    $mode = $action;    // For backward compatibility
60
+    $mode = $action; // For backward compatibility
61 61
 }
62 62
 $resourceid = GETPOSTINT("search_resourceid") ? GETPOSTINT("search_resourceid") : GETPOSTINT("resourceid");
63 63
 $pid = GETPOSTINT("search_projectid", 3) ? GETPOSTINT("search_projectid", 3) : GETPOSTINT("projectid", 3);
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
 $object->fields = dol_sort_array($object->fields, 'position');
181 181
 $arrayfields = dol_sort_array($arrayfields, 'position');
182
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
182
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
183 183
 
184 184
 $result = restrictedArea($user, 'agenda', 0, '', 'myactions');
185 185
 if ($user->socid && $socid) {
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 if (isModEnabled('category') && $user->hasRight('agenda', 'myactions', 'create')) {
415 415
     $arrayofmassactions['preaffecttag'] = img_picto('', 'category', 'class="pictofixedwidth"') . $langs->trans("AffectTag");
416 416
 }
417
-if (GETPOSTINT('nomassaction') || in_array($massaction, array('presend', 'predelete','preaffecttag'))) {
417
+if (GETPOSTINT('nomassaction') || in_array($massaction, array('presend', 'predelete', 'preaffecttag'))) {
418 418
     $arrayofmassactions = array();
419 419
 }
420 420
 $massactionbutton = $form->selectMassAction('', $arrayofmassactions);
Please login to merge, or discard this patch.
public/htdocs/comm/action/peruser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1156,8 +1156,8 @@
 block discarded – undo
1156 1156
     // We are in a particular day for $username, now we scan all events
1157 1157
     foreach ($eventarray as $daykey => $notused) {
1158 1158
         $annee = dol_print_date($daykey, '%Y', 'tzuserrel');
1159
-        $mois =  dol_print_date($daykey, '%m', 'tzuserrel');
1160
-        $jour =  dol_print_date($daykey, '%d', 'tzuserrel');
1159
+        $mois = dol_print_date($daykey, '%m', 'tzuserrel');
1160
+        $jour = dol_print_date($daykey, '%d', 'tzuserrel');
1161 1161
         //var_dump("daykey=$daykey day=$day jour=$jour, month=$month mois=$mois, year=$year annee=$annee");
1162 1162
 
1163 1163
 
Please login to merge, or discard this patch.