alxarafe /
alixar
| Conditions | 41 |
| Paths | > 20000 |
| Total Lines | 284 |
| Code Lines | 184 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 206 | public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0) |
||
| 207 | { |
||
| 208 | // phpcs:enable |
||
| 209 | global $user, $langs, $conf, $mysoc, $hookmanager; |
||
| 210 | |||
| 211 | if (empty($srctemplatepath)) { |
||
| 212 | dol_syslog("doc_generic_odt::write_file parameter srctemplatepath empty", LOG_WARNING); |
||
| 213 | return -1; |
||
| 214 | } |
||
| 215 | |||
| 216 | // Add odtgeneration hook |
||
| 217 | if (!is_object($hookmanager)) { |
||
| 218 | include_once DOL_DOCUMENT_ROOT . '/core/class/hookmanager.class.php'; |
||
| 219 | $hookmanager = new HookManager($this->db); |
||
| 220 | } |
||
| 221 | $hookmanager->initHooks(array('odtgeneration')); |
||
| 222 | global $action; |
||
| 223 | |||
| 224 | if (!is_object($outputlangs)) { |
||
| 225 | $outputlangs = $langs; |
||
| 226 | } |
||
| 227 | $sav_charset_output = $outputlangs->charset_output; |
||
| 228 | $outputlangs->charset_output = 'UTF-8'; |
||
| 229 | |||
| 230 | $outputlangs->loadLangs(array("main", "dict", "companies", "bills")); |
||
| 231 | |||
| 232 | if ($conf->fournisseur->commande->dir_output) { |
||
| 233 | $object->fetch_thirdparty(); |
||
| 234 | |||
| 235 | if ($object->specimen) { |
||
| 236 | $dir = $conf->fournisseur->commande->dir_output; |
||
| 237 | $file = $dir . "/SPECIMEN.pdf"; |
||
| 238 | } else { |
||
| 239 | $objectref = dol_sanitizeFileName($object->ref); |
||
| 240 | $objectrefsupplier = dol_sanitizeFileName($object->ref_supplier); |
||
| 241 | $dir = $conf->fournisseur->commande->dir_output . '/' . $objectref; |
||
| 242 | $file = $dir . "/" . $objectref . ".pdf"; |
||
| 243 | if (getDolGlobalString('SUPPLIER_REF_IN_NAME')) { |
||
| 244 | $file = $dir . "/" . $objectref . ($objectrefsupplier ? "_" . $objectrefsupplier : "") . ".pdf"; |
||
| 245 | } |
||
| 246 | } |
||
| 247 | |||
| 248 | if (!file_exists($dir)) { |
||
| 249 | if (dol_mkdir($dir) < 0) { |
||
| 250 | $this->error = $langs->transnoentities("ErrorCanNotCreateDir", $dir); |
||
| 251 | return -1; |
||
| 252 | } |
||
| 253 | } |
||
| 254 | |||
| 255 | if (file_exists($dir)) { |
||
| 256 | //print "srctemplatepath=".$srctemplatepath; // Src filename |
||
| 257 | $newfile = basename($srctemplatepath); |
||
| 258 | $newfiletmp = preg_replace('/\.od[ts]/i', '', $newfile); |
||
| 259 | $newfiletmp = preg_replace('/template_/i', '', $newfiletmp); |
||
| 260 | $newfiletmp = preg_replace('/modele_/i', '', $newfiletmp); |
||
| 261 | $newfiletmp = $objectref . '_' . $newfiletmp; |
||
| 262 | //$file=$dir.'/'.$newfiletmp.'.'.dol_print_date(dol_now(),'%Y%m%d%H%M%S').'.odt'; |
||
| 263 | // Get extension (ods or odt) |
||
| 264 | $newfileformat = substr($newfile, strrpos($newfile, '.') + 1); |
||
| 265 | if (getDolGlobalString('MAIN_DOC_USE_TIMING')) { |
||
| 266 | $format = getDolGlobalString('MAIN_DOC_USE_TIMING'); |
||
| 267 | if ($format == '1') { |
||
| 268 | $format = '%Y%m%d%H%M%S'; |
||
| 269 | } |
||
| 270 | $filename = $newfiletmp . '-' . dol_print_date(dol_now(), $format) . '.' . $newfileformat; |
||
| 271 | } else { |
||
| 272 | $filename = $newfiletmp . '.' . $newfileformat; |
||
| 273 | } |
||
| 274 | $file = $dir . '/' . $filename; |
||
| 275 | //print "newdir=".$dir; |
||
| 276 | //print "newfile=".$newfile; |
||
| 277 | //print "file=".$file; |
||
| 278 | //print "conf->societe->dir_temp=".$conf->societe->dir_temp; |
||
| 279 | |||
| 280 | dol_mkdir($conf->fournisseur->commande->dir_temp); |
||
| 281 | if (!is_writable($conf->fournisseur->commande->dir_temp)) { |
||
| 282 | $this->error = $langs->transnoentities("ErrorFailedToWriteInTempDirectory", $conf->fournisseur->commande->dir_temp); |
||
| 283 | dol_syslog('Error in write_file: ' . $this->error, LOG_ERR); |
||
| 284 | return -1; |
||
| 285 | } |
||
| 286 | |||
| 287 | // If CUSTOMER contact defined on order, we use it |
||
| 288 | $usecontact = false; |
||
| 289 | $arrayidcontact = $object->getIdContact('external', 'CUSTOMER'); |
||
| 290 | if (count($arrayidcontact) > 0) { |
||
| 291 | $usecontact = true; |
||
| 292 | $result = $object->fetch_contact($arrayidcontact[0]); |
||
| 293 | } |
||
| 294 | |||
| 295 | // Recipient name |
||
| 296 | $contactobject = null; |
||
| 297 | if (!empty($usecontact)) { |
||
| 298 | // We can use the company of contact instead of thirdparty company |
||
| 299 | if ($object->contact->socid != $object->thirdparty->id && (!isset($conf->global->MAIN_USE_COMPANY_NAME_OF_CONTACT) || getDolGlobalString('MAIN_USE_COMPANY_NAME_OF_CONTACT'))) { |
||
| 300 | $object->contact->fetch_thirdparty(); |
||
| 301 | $socobject = $object->contact->thirdparty; |
||
| 302 | $contactobject = $object->contact; |
||
| 303 | } else { |
||
| 304 | $socobject = $object->thirdparty; |
||
| 305 | // if we have a CUSTOMER contact and we don't use it as thirdparty recipient we store the contact object for later use |
||
| 306 | $contactobject = $object->contact; |
||
| 307 | } |
||
| 308 | } else { |
||
| 309 | $socobject = $object->thirdparty; |
||
| 310 | } |
||
| 311 | |||
| 312 | // Make substitution |
||
| 313 | $substitutionarray = array( |
||
| 314 | '__FROM_NAME__' => $this->issuer->name, |
||
| 315 | '__FROM_EMAIL__' => $this->issuer->email, |
||
| 316 | '__TOTAL_TTC__' => $object->total_ttc, |
||
| 317 | '__TOTAL_HT__' => $object->total_ht, |
||
| 318 | '__TOTAL_VAT__' => $object->total_tva |
||
| 319 | ); |
||
| 320 | complete_substitutions_array($substitutionarray, $langs, $object); |
||
| 321 | // Call the ODTSubstitution hook |
||
| 322 | $parameters = array('file' => $file, 'object' => $object, 'outputlangs' => $outputlangs, 'substitutionarray' => &$substitutionarray); |
||
| 323 | $reshook = $hookmanager->executeHooks('ODTSubstitution', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks |
||
| 324 | // Line of free text |
||
| 325 | $newfreetext = ''; |
||
| 326 | $paramfreetext = 'ORDER_FREE_TEXT'; |
||
| 327 | if (!empty($conf->global->$paramfreetext)) { |
||
| 328 | $newfreetext = make_substitutions(getDolGlobalString($paramfreetext), $substitutionarray); |
||
| 329 | } |
||
| 330 | |||
| 331 | // Open and load template |
||
| 332 | require_once ODTPHP_PATH . 'odf.php'; |
||
|
Bug
introduced
by
|
|||
| 333 | try { |
||
| 334 | $odfHandler = new Odf( |
||
| 335 | $srctemplatepath, |
||
| 336 | array( |
||
| 337 | 'PATH_TO_TMP' => $conf->fournisseur->dir_temp, |
||
| 338 | 'ZIP_PROXY' => 'PclZipProxy', // PhpZipProxy or PclZipProxy. Got "bad compression method" error when using PhpZipProxy. |
||
| 339 | 'DELIMITER_LEFT' => '{', |
||
| 340 | 'DELIMITER_RIGHT' => '}' |
||
| 341 | ) |
||
| 342 | ); |
||
| 343 | } catch (Exception $e) { |
||
| 344 | $this->error = $e->getMessage(); |
||
| 345 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 346 | return -1; |
||
| 347 | } |
||
| 348 | // After construction $odfHandler->contentXml contains content and |
||
| 349 | // [!-- BEGIN row.lines --]*[!-- END row.lines --] has been replaced by |
||
| 350 | // [!-- BEGIN lines --]*[!-- END lines --] |
||
| 351 | //print html_entity_decode($odfHandler->__toString()); |
||
| 352 | //print exit; |
||
| 353 | |||
| 354 | |||
| 355 | // Make substitutions into odt of freetext |
||
| 356 | try { |
||
| 357 | $odfHandler->setVars('free_text', $newfreetext, true, 'UTF-8'); |
||
| 358 | } catch (OdfException $e) { |
||
| 359 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 360 | } |
||
| 361 | |||
| 362 | // Define substitution array |
||
| 363 | $substitutionarray = getCommonSubstitutionArray($outputlangs, 0, null, $object); |
||
| 364 | $array_object_from_properties = $this->get_substitutionarray_each_var_object($object, $outputlangs); |
||
| 365 | $array_objet = $this->get_substitutionarray_object($object, $outputlangs); |
||
| 366 | $array_user = $this->get_substitutionarray_user($user, $outputlangs); |
||
| 367 | $array_soc = $this->get_substitutionarray_mysoc($mysoc, $outputlangs); |
||
| 368 | $array_thirdparty = $this->get_substitutionarray_thirdparty($socobject, $outputlangs); |
||
| 369 | $array_other = $this->get_substitutionarray_other($outputlangs); |
||
| 370 | // retrieve contact information for use in object as contact_xxx tags |
||
| 371 | $array_thirdparty_contact = array(); |
||
| 372 | if ($usecontact && is_object($contactobject)) { |
||
| 373 | $array_thirdparty_contact = $this->get_substitutionarray_contact($contactobject, $outputlangs, 'contact'); |
||
| 374 | } |
||
| 375 | |||
| 376 | $tmparray = array_merge($substitutionarray, $array_object_from_properties, $array_user, $array_soc, $array_thirdparty, $array_objet, $array_other, $array_thirdparty_contact); |
||
| 377 | complete_substitutions_array($tmparray, $outputlangs, $object); |
||
| 378 | |||
| 379 | // Call the ODTSubstitution hook |
||
| 380 | $parameters = array('odfHandler' => &$odfHandler, 'file' => $file, 'object' => $object, 'outputlangs' => $outputlangs, 'substitutionarray' => &$tmparray); |
||
| 381 | $reshook = $hookmanager->executeHooks('ODTSubstitution', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks |
||
| 382 | |||
| 383 | foreach ($tmparray as $key => $value) { |
||
| 384 | try { |
||
| 385 | if (preg_match('/logo$/', $key)) { // Image |
||
| 386 | if (file_exists($value)) { |
||
| 387 | $odfHandler->setImage($key, $value); |
||
| 388 | } else { |
||
| 389 | $odfHandler->setVars($key, 'ErrorFileNotFound', true, 'UTF-8'); |
||
| 390 | } |
||
| 391 | } else { // Text |
||
| 392 | $odfHandler->setVars($key, $value, true, 'UTF-8'); |
||
| 393 | } |
||
| 394 | } catch (OdfException $e) { |
||
| 395 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 396 | } |
||
| 397 | } |
||
| 398 | // Replace tags of lines |
||
| 399 | try { |
||
| 400 | $foundtagforlines = 1; |
||
| 401 | try { |
||
| 402 | $listlines = $odfHandler->setSegment('lines'); |
||
| 403 | } catch (OdfExceptionSegmentNotFound $e) { |
||
| 404 | // We may arrive here if tags for lines not present into template |
||
| 405 | $foundtagforlines = 0; |
||
| 406 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 407 | } catch (OdfException $e) { |
||
| 408 | $foundtagforlines = 0; |
||
| 409 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 410 | } |
||
| 411 | if ($foundtagforlines) { |
||
| 412 | $linenumber = 0; |
||
| 413 | foreach ($object->lines as $line) { |
||
| 414 | $linenumber++; |
||
| 415 | $tmparray = $this->get_substitutionarray_lines($line, $outputlangs, $linenumber); |
||
| 416 | complete_substitutions_array($tmparray, $outputlangs, $object, $line, "completesubstitutionarray_lines"); |
||
| 417 | // Call the ODTSubstitutionLine hook |
||
| 418 | $parameters = array('odfHandler' => &$odfHandler, 'file' => $file, 'object' => $object, 'outputlangs' => $outputlangs, 'substitutionarray' => &$tmparray, 'line' => $line); |
||
| 419 | $reshook = $hookmanager->executeHooks('ODTSubstitutionLine', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks |
||
| 420 | foreach ($tmparray as $key => $val) { |
||
| 421 | try { |
||
| 422 | $listlines->setVars($key, $val, true, 'UTF-8'); |
||
| 423 | } catch (OdfException $e) { |
||
| 424 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 425 | } catch (SegmentException $e) { |
||
| 426 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 427 | } |
||
| 428 | } |
||
| 429 | $listlines->merge(); |
||
| 430 | } |
||
| 431 | $odfHandler->mergeSegment($listlines); |
||
| 432 | } |
||
| 433 | } catch (OdfException $e) { |
||
| 434 | $this->error = $e->getMessage(); |
||
| 435 | dol_syslog($this->error, LOG_WARNING); |
||
| 436 | return -1; |
||
| 437 | } |
||
| 438 | |||
| 439 | // Replace labels translated |
||
| 440 | $tmparray = $outputlangs->get_translations_for_substitutions(); |
||
| 441 | foreach ($tmparray as $key => $value) { |
||
| 442 | try { |
||
| 443 | $odfHandler->setVars($key, $value, true, 'UTF-8'); |
||
| 444 | } catch (OdfException $e) { |
||
| 445 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 446 | } |
||
| 447 | } |
||
| 448 | |||
| 449 | // Call the beforeODTSave hook |
||
| 450 | |||
| 451 | $parameters = array('odfHandler' => &$odfHandler, 'file' => $file, 'object' => $object, 'outputlangs' => $outputlangs, 'substitutionarray' => &$tmparray); |
||
| 452 | $reshook = $hookmanager->executeHooks('beforeODTSave', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks |
||
| 453 | |||
| 454 | // Write new file |
||
| 455 | if (getDolGlobalString('MAIN_ODT_AS_PDF')) { |
||
| 456 | try { |
||
| 457 | $odfHandler->exportAsAttachedPDF($file); |
||
| 458 | } catch (Exception $e) { |
||
| 459 | $this->error = $e->getMessage(); |
||
| 460 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 461 | return -1; |
||
| 462 | } |
||
| 463 | } else { |
||
| 464 | try { |
||
| 465 | $odfHandler->saveToDisk($file); |
||
| 466 | } catch (Exception $e) { |
||
| 467 | $this->error = $e->getMessage(); |
||
| 468 | dol_syslog($e->getMessage(), LOG_INFO); |
||
| 469 | return -1; |
||
| 470 | } |
||
| 471 | } |
||
| 472 | |||
| 473 | $parameters = array('odfHandler' => &$odfHandler, 'file' => $file, 'object' => $object, 'outputlangs' => $outputlangs, 'substitutionarray' => &$tmparray); |
||
| 474 | $reshook = $hookmanager->executeHooks('afterODTCreation', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks |
||
| 475 | |||
| 476 | dolChmod($file); |
||
| 477 | |||
| 478 | $odfHandler = null; // Destroy object |
||
| 479 | |||
| 480 | $this->result = array('fullpath' => $file); |
||
| 481 | |||
| 482 | return 1; // Success |
||
| 483 | } else { |
||
| 484 | $this->error = $langs->transnoentities("ErrorCanNotCreateDir", $dir); |
||
| 485 | return -1; |
||
| 486 | } |
||
| 487 | } |
||
| 488 | |||
| 489 | return -1; |
||
| 490 | } |
||
| 492 |
Loading history...