Dolibarr\Code\Expedition\Classes\Expedition::valid()

Complexity

Conditions	29
Paths	4040

Size

Total Lines	142
Code Lines	87

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function valid($user, $notrigger = 0)
    {
        global $conf;

        require_once constant('DOL_DOCUMENT_ROOT') . '/core/lib/files.lib.php';

        dol_syslog(get_class($this) . "::valid");

        // Protection
        if ($this->status) {
            dol_syslog(get_class($this) . "::valid not in draft status", LOG_WARNING);
            return 0;
        }

        if (
            !((!getDolGlobalString('MAIN_USE_ADVANCED_PERMS') && $user->hasRight('expedition', 'creer'))
            || (getDolGlobalString('MAIN_USE_ADVANCED_PERMS') && $user->hasRight('expedition', 'shipping_advance', 'validate')))
        ) {
            $this->error = 'Permission denied';
            dol_syslog(get_class($this) . "::valid " . $this->error, LOG_ERR);
            return -1;
        }

        $this->db->begin();

        $error = 0;

        // Define new ref
        $soc = new Societe($this->db);
        $soc->fetch($this->socid);

        // Class of company linked to order
        $result = $soc->setAsCustomer();

        // Define new ref
        if (!$error && (preg_match('/^[\(]?PROV/i', $this->ref) || empty($this->ref))) { // empty should not happened, but when it occurs, the test save life
            $numref = $this->getNextNumRef($soc);
        } elseif (!empty($this->ref)) {
            $numref = $this->ref;
        } else {
            $numref = "EXP" . $this->id;
        }
        $this->newref = dol_sanitizeFileName($numref);

        $now = dol_now();

        // Validate
        $sql = "UPDATE " . MAIN_DB_PREFIX . "expedition SET";
        $sql .= " ref='" . $this->db->escape($numref) . "'";
        $sql .= ", fk_statut = 1";
        $sql .= ", date_valid = '" . $this->db->idate($now) . "'";
        $sql .= ", fk_user_valid = " . $user->id;
        $sql .= " WHERE rowid = " . ((int) $this->id);

        dol_syslog(get_class($this) . "::valid update expedition", LOG_DEBUG);
        $resql = $this->db->query($sql);
        if (!$resql) {
            $this->error = $this->db->lasterror();
            $error++;
        }

        // If stock increment is done on sending (recommended choice)
        if (!$error && isModEnabled('stock') && getDolGlobalString('STOCK_CALCULATE_ON_SHIPMENT')) {
            $result = $this->manageStockMvtOnEvt($user, "ShipmentValidatedInDolibarr");
            if ($result < 0) {
                return -2;
            }
        }

        // Change status of order to "shipment in process"
        $ret = $this->setStatut(Commande::STATUS_SHIPMENTONPROCESS, $this->origin_id, $this->origin);

The property Dolibarr\Core\Base\CommonObject::$origin has been deprecated: Use $origin_type and $origin_id instead.

        if (!$ret) {
            $error++;
        }

        if (!$error && !$notrigger) {
            // Call trigger
            $result = $this->call_trigger('SHIPPING_VALIDATE', $user);
            if ($result < 0) {
                $error++;
            }
            // End call triggers
        }

        if (!$error) {
            $this->oldref = $this->ref;

            // Rename directory if dir was a temporary ref
            if (preg_match('/^[\(]?PROV/i', $this->ref)) {
                // Now we rename also files into index
                $sql = 'UPDATE ' . MAIN_DB_PREFIX . "ecm_files set filename = CONCAT('" . $this->db->escape($this->newref) . "', SUBSTR(filename, " . (strlen($this->ref) + 1) . ")), filepath = 'expedition/sending/" . $this->db->escape($this->newref) . "'";
                $sql .= " WHERE filename LIKE '" . $this->db->escape($this->ref) . "%' AND filepath = 'expedition/sending/" . $this->db->escape($this->ref) . "' and entity = " . ((int) $conf->entity);
                $resql = $this->db->query($sql);
                if (!$resql) {
                    $error++;
                    $this->error = $this->db->lasterror();
                }
                $sql = 'UPDATE ' . MAIN_DB_PREFIX . "ecm_files set filepath = 'expedition/sending/" . $this->db->escape($this->newref) . "'";
                $sql .= " WHERE filepath = 'expedition/sending/" . $this->db->escape($this->ref) . "' and entity = " . $conf->entity;
                $resql = $this->db->query($sql);
                if (!$resql) {
                    $error++;
                    $this->error = $this->db->lasterror();
                }

                // We rename directory ($this->ref = old ref, $num = new ref) in order not to lose the attachments
                $oldref = dol_sanitizeFileName($this->ref);
                $newref = dol_sanitizeFileName($numref);
                $dirsource = $conf->expedition->dir_output . '/sending/' . $oldref;
                $dirdest = $conf->expedition->dir_output . '/sending/' . $newref;
                if (!$error && file_exists($dirsource)) {
                    dol_syslog(get_class($this) . "::valid rename dir " . $dirsource . " into " . $dirdest);

                    if (@rename($dirsource, $dirdest)) {
                        dol_syslog("Rename ok");
                        // Rename docs starting with $oldref with $newref
                        $listoffiles = dol_dir_list($conf->expedition->dir_output . '/sending/' . $newref, 'files', 1, '^' . preg_quote($oldref, '/'));
                        foreach ($listoffiles as $fileentry) {
                            $dirsource = $fileentry['name'];
                            $dirdest = preg_replace('/^' . preg_quote($oldref, '/') . '/', $newref, $dirsource);
                            $dirsource = $fileentry['path'] . '/' . $dirsource;
                            $dirdest = $fileentry['path'] . '/' . $dirdest;
                            @rename($dirsource, $dirdest);

It seems like you do not handle an error condition for rename(). This can introduce security issues, and is generally not recommended.

                        }
                    }
                }
            }
        }

        // Set new ref and current status
        if (!$error) {
            $this->ref = $numref;
            $this->statut = self::STATUS_VALIDATED;

The property Dolibarr\Core\Base\CommonObject::$statut has been deprecated: Use $status instead.

            $this->status = self::STATUS_VALIDATED;
        }

        if (!$error) {
            $this->db->commit();
            return 1;
        } else {
            $this->db->rollback();
            return -1 * $error;
        }