Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
public/htdocs/hrm/skill_list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 $optioncss   = GETPOST('optioncss', 'aZ'); // Option for the css output (always '' except when 'print')
57 57
 $mode        = GETPOST('mode', 'alpha'); // for mode view result
58 58
 
59
-$id         = GETPOSTINT('id');
59
+$id = GETPOSTINT('id');
60 60
 
61 61
 // Load variable for pagination
62 62
 $limit = GETPOSTINT('limit') ? GETPOSTINT('limit') : $conf->liste_limit;
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
 // Default sort order (if not yet defined by previous GETPOST)
87 87
 if (!$sortfield) {
88
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
88
+    reset($object->fields); // Reset is required to avoid key() to return null.
89 89
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
90 90
 }
91 91
 if (!$sortorder) {
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
 }
487 487
 
488 488
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
489
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
489
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
490 490
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
491 491
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
492 492
 
@@ -577,7 +577,7 @@  discard block
 block discarded – undo
577 577
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
578 578
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
579 579
     }
580
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
580
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
581 581
     if (!empty($arrayfields['t.' . $key]['checked'])) {
582 582
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
583 583
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/hrm/position_card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 $action     = GETPOST('action', 'aZ09') ? GETPOST('action', 'aZ09') : 'view'; // The action 'add', 'create', 'edit', 'update', 'view', ...
42 42
 $backtopage = GETPOST('backtopage', 'alpha');
43 43
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
44
-$id     = GETPOSTINT('id');
44
+$id = GETPOSTINT('id');
45 45
 
46 46
 // Initialize technical objects
47 47
 $form = new Form($db);
Please login to merge, or discard this patch.
public/htdocs/hrm/job_card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 require_once constant('DOL_DOCUMENT_ROOT') . '/hrm/class/skillrank.class.php';
39 39
 
40 40
 // Load translation files required by the page
41
-$langs->loadLangs(array('hrm', 'other', 'products'));   // why products?
41
+$langs->loadLangs(array('hrm', 'other', 'products')); // why products?
42 42
 
43 43
 // Get parameters
44 44
 $id = GETPOSTINT('id');
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'jobcard'; // To manage different context of search
50 50
 $backtopage = GETPOST('backtopage', 'alpha');
51 51
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
52
-$lineid   = GETPOSTINT('lineid');
52
+$lineid = GETPOSTINT('lineid');
53 53
 
54 54
 // Initialize technical objects
55 55
 $object = new Job($db);
Please login to merge, or discard this patch.
public/htdocs/hrm/evaluation_card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 
42 42
 
43 43
 // Load translation files required by the page
44
-$langs->loadLangs(array('hrm', 'other', 'products'));  // why products?
44
+$langs->loadLangs(array('hrm', 'other', 'products')); // why products?
45 45
 
46 46
 // Get parameters
47 47
 $id = GETPOSTINT('id');
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'evaluationcard'; // To manage different context of search
53 53
 $backtopage = GETPOST('backtopage', 'alpha');
54 54
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
55
-$lineid   = GETPOSTINT('lineid');
55
+$lineid = GETPOSTINT('lineid');
56 56
 
57 57
 // Initialize technical objects
58 58
 $object = new Evaluation($db);
Please login to merge, or discard this patch.
public/htdocs/hrm/skill_card.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
 
39 39
 // Load translation files required by the page
40
-$langs->loadLangs(array('hrm', 'other', 'products'));  // why products?
40
+$langs->loadLangs(array('hrm', 'other', 'products')); // why products?
41 41
 
42 42
 // Get parameters
43 43
 $id = GETPOSTINT('id');
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 $contextpage = GETPOST('contextpage', 'aZ') ? GETPOST('contextpage', 'aZ') : 'skillcard'; // To manage different context of search
49 49
 $backtopage = GETPOST('backtopage', 'alpha');
50 50
 $backtopageforcancel = GETPOST('backtopageforcancel', 'alpha');
51
-$lineid   = GETPOSTINT('lineid');
51
+$lineid = GETPOSTINT('lineid');
52 52
 
53 53
 // Initialize technical objects
54 54
 $object = new Skill($db);
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
     // Default sort order (if not yet defined by previous GETPOST)
535 535
     if (!$sortfield) {
536
-        reset($objectline->fields);                    // Reset is required to avoid key() to return null.
536
+        reset($objectline->fields); // Reset is required to avoid key() to return null.
537 537
         $sortfield = "t." . key($objectline->fields); // Set here default search field. By default 1st field in definition.
538 538
     }
539 539
     if (!$sortorder) {
Please login to merge, or discard this patch.
public/htdocs/hrm/position_list.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
 // Default sort order (if not yet defined by previous GETPOST)
86 86
 if (!$sortfield) {
87
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
87
+    reset($object->fields); // Reset is required to avoid key() to return null.
88 88
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
89 89
 }
90 90
 if (!$sortorder) {
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 $sql .= $object->getFieldList('t');
228 228
 $sql .= ',';
229 229
 $sql .= $userstatic->getFieldList('u', array('rowid'));
230
-$sql .= ', u.email, u.statut, u.photo, u.login';        // Add more field not yet into the user->fields
230
+$sql .= ', u.email, u.statut, u.photo, u.login'; // Add more field not yet into the user->fields
231 231
 $sql .= ', j.rowid as job_id, j.label as job_label';
232 232
 // Add fields from extrafields
233 233
 if (!empty($extrafields->attributes[$object->table_element]['label'])) {
@@ -571,7 +571,7 @@  discard block
 block discarded – undo
571 571
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
572 572
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
573 573
     }
574
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
574
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
575 575
     if (!empty($arrayfields['t.' . $key]['checked'])) {
576 576
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : '')) . "\n";
577 577
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/hrm/job_list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 // Default sort order (if not yet defined by previous GETPOST)
85 85
 if (!$sortfield) {
86
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
86
+    reset($object->fields); // Reset is required to avoid key() to return null.
87 87
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
88 88
 }
89 89
 if (!$sortorder) {
@@ -560,7 +560,7 @@  discard block
 block discarded – undo
560 560
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
561 561
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
562 562
     }
563
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
563
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
564 564
     if (!empty($arrayfields['t.' . $key]['checked'])) {
565 565
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : '')) . "\n";
566 566
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/societe/admin/societe.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
 $action = GETPOST('action', 'aZ09');
39 39
 $value = GETPOST('value', 'alpha');
40
-$modulepart = GETPOST('modulepart', 'aZ09');    // Used by actions_setmoduleoptions.inc.php
40
+$modulepart = GETPOST('modulepart', 'aZ09'); // Used by actions_setmoduleoptions.inc.php
41 41
 
42 42
 if (!$user->admin) {
43 43
     accessforbidden();
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
 print '<td class="center">' . $langs->trans("MustBeInvoiceMandatory") . '</td>';
666 666
 print "</tr>\n";
667 667
 
668
-$profid = array('IDPROF1' => array(), 'IDPROF2' => array(), 'IDPROF3' => array(), 'IDPROF4' => array(), 'IDPROF5' => array(),'IDPROF6' => array(), 'EMAIL' => array());
668
+$profid = array('IDPROF1' => array(), 'IDPROF2' => array(), 'IDPROF3' => array(), 'IDPROF4' => array(), 'IDPROF5' => array(), 'IDPROF6' => array(), 'EMAIL' => array());
669 669
 $profid['IDPROF1'][0] = $langs->trans("ProfId1");
670 670
 $profid['IDPROF1'][1] = $langs->transcountry('ProfId1', $mysoc->country_code);
671 671
 $profid['IDPROF2'][0] = $langs->trans("ProfId2");
Please login to merge, or discard this patch.
public/htdocs/societe/ajax/ajaxcompanies.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
 }
88 88
 
89 89
 // Generate list of companies
90
-if (! $socid) {
90
+if (!$socid) {
91 91
     echo json_encode(array('nom' => 'ErrorBadParameter', 'label' => 'ErrorBadParameter', 'key' => 'ErrorBadParameter', 'value' => 'ErrorBadParameter'));
92 92
     exit;
93 93
 }
Please login to merge, or discard this patch.