Inspection of "Review of the remaining code in the accountancy fo..." - alxarafe/alixar - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )

by Rafael

created 2024-09-13 06:42 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -247,7 +247,7 @@  discard block
 block discarded – undo
 
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build PDF on disk, then output on HTTP stream.
      *
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
      */
     public function write_file($arrayofrecords, $outputlangs, $srctemplatepath, $outputdir = '', $filename = 'tmp_address_sheet.pdf')
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $conf, $langs, $mysoc, $_Avery_Labels;
 
         $this->code = $srctemplatepath;

Please login to merge, or discard this patch.

public/htdocs/core/modules/printsheet/doc/pdf_standardlabel.class.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -47,7 +47,7 @@  discard block
 block discarded – undo
         // use this method in future refactoring
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      * Output a sticker on page at position _COUNTX, _COUNTY (_COUNTX and _COUNTY start from 0)
      * - %LOGO% is replace with company logo
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
      */
     public function Add_PDF_label(&$pdf, $textleft, $header, $footer, $outputlangs, $textright = '', $photo = '')
     {
-		// phpcs:enable
+        // phpcs:enable
         global $mysoc, $conf, $langs;
         global $forceimgscalewidth, $forceimgscaleheight;
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
 
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build PDF on disk, then output on HTTP stream.
      *
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
      */
     public function write_file($arrayofrecords, $outputlangs, $srctemplatepath, $outputdir = '', $filename = 'tmp_address_sheet.pdf')
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $conf, $langs, $mysoc, $_Avery_Labels;
 
         $this->code = $srctemplatepath;

Please login to merge, or discard this patch.

public/htdocs/core/modules/printsheet/modules_labels.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,7 @@  discard block
 block discarded – undo
     public $error = '';
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return list of active generation modules
      *
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
      */
     public function liste_modeles($db, $maxfilenamelength = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         $type = 'members_labels';
         $list = array();
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
  */
 function doc_label_pdf_create($db, $arrayofrecords, $modele, $outputlangs, $outputdir = '', $template = 'standardlabel', $filename = 'tmp_address_sheet.pdf')
 {
-	// phpcs:enable
+    // phpcs:enable
     global $conf, $langs;
     $langs->load("members");
 

Please login to merge, or discard this patch.

public/htdocs/core/modules/printing/printgcp.modules.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -116,7 +116,7 @@  discard block
 block discarded – undo
                 'type' => 'info',
             );
         } else {
-            $keyforprovider = '';   // @FIXME
+            $keyforprovider = ''; // @FIXME
 
             $this->google_id = getDolGlobalString('OAUTH_GOOGLE_ID');
             $this->google_secret = getDolGlobalString('OAUTH_GOOGLE_SECRET');
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
         global $conf;
         $ret = array();
 
-        $keyforprovider = '';   // @FIXME
+        $keyforprovider = ''; // @FIXME
 
         // Token storage
         $storage = new DoliStorage($this->db, $conf, $keyforprovider);
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
             'contentType' => $contenttype,
         );
 
-        $keyforprovider = '';   // @FIXME
+        $keyforprovider = ''; // @FIXME
 
         // Dolibarr Token storage
         $storage = new DoliStorage($this->db, $conf, $keyforprovider);
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
         $error = 0;
         $html = '';
 
-        $keyforprovider = '';   // @FIXME
+        $keyforprovider = ''; // @FIXME
 
         // Token storage
         $storage = new DoliStorage($this->db, $conf, $keyforprovider);

Please login to merge, or discard this patch.

public/htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -137,7 +137,7 @@  discard block
 block discarded – undo
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build pdf onto disk
      *
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $db, $hookmanager, $nblines;
 
         dol_syslog("write_file outputlangs->defaultlang=" . (is_object($outputlangs) ? $outputlangs->defaultlang : 'null'));
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return list of active generation modules
      *
@@ -804,11 +804,11 @@  discard block
 block discarded – undo
      */
     public static function liste_modeles($db, $maxfilenamelength = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         return parent::liste_modeles($db, $maxfilenamelength); // TODO: Change the autogenerated stub
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *   Show table for lines
      *
@@ -869,7 +869,7 @@  discard block
 block discarded – undo
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *  Show top header of page.
      *
@@ -1121,7 +1121,7 @@  discard block
 block discarded – undo
         return $top_shift;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *      Show footer of page. Need this->emetteur object
      *

Please login to merge, or discard this patch.

public/htdocs/core/modules/asset/doc/doc_generic_asset_odt.modules.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -195,7 +195,7 @@  discard block
 block discarded – undo
         return $texte;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build a document on disk using the generic odt module.
      *
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (empty($srctemplatepath)) {

Please login to merge, or discard this patch.

public/htdocs/core/modules/asset/modules_asset.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -39,7 +39,7 @@  discard block
 block discarded – undo
  */
 abstract class ModelePDFAsset extends CommonDocGenerator
 {
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Return list of active generation modules
      *
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
      */
     public static function liste_modeles($db, $maxfilenamelength = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         $type = 'asset';
         $list = array();
 

Please login to merge, or discard this patch.

public/htdocs/core/modules/delivery/doc/pdf_typhon.modules.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -133,7 +133,7 @@  discard block
 block discarded – undo
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build pdf onto disk
      *
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (!is_object($outputlangs)) {
@@ -587,8 +587,8 @@  discard block
 block discarded – undo
         return 0;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *   Show miscellaneous information (payment mode, payment term, ...)
      *
@@ -600,7 +600,7 @@  discard block
 block discarded – undo
      */
     protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $mysoc;
         $default_font_size = pdf_getPDFFontSize($outputlangs);
 
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
         $pdf->MultiCell($larg_sign, 2, $outputlangs->trans("ForCustomer") . ':', '', 'L');
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *   Show table for lines
      *
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *  Show top header of page.
      *
@@ -861,7 +861,7 @@  discard block
 block discarded – undo
         return 0;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *  Show footer of page. Need this->emetteur object
      *

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -71,8 +71,8 @@  discard block
 block discarded – undo
      */
     public $version = 'dolibarr';
 
-    public $posxcomm;       // For customer comment column
-    public $posxweightvol;  // For weight or volume
+    public $posxcomm; // For customer comment column
+    public $posxweightvol; // For weight or volume
     public $posxremainingqty;
 
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
 
         // Define position of columns
         $this->posxdesc = $this->marge_gauche + 1;
-        $this->posxcomm = 112;  // customer comment
+        $this->posxcomm = 112; // customer comment
         //$this->posxtva=112;
         //$this->posxup=126;
         $this->posxqty = 165;

Please login to merge, or discard this patch.

public/htdocs/core/modules/delivery/doc/pdf_storm.modules.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -112,7 +112,7 @@  discard block
 block discarded – undo
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *  Function to build pdf onto disk
      *
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
      */
     public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $user, $langs, $conf, $mysoc, $hookmanager;
 
         if (!is_object($outputlangs)) {
@@ -594,8 +594,8 @@  discard block
 block discarded – undo
         return 0;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
     /**
      *   Show miscellaneous information (payment mode, payment term, ...)
      *
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
      */
     protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
     {
-		// phpcs:enable
+        // phpcs:enable
         global $conf, $mysoc;
         $default_font_size = pdf_getPDFFontSize($outputlangs);
 
@@ -625,7 +625,7 @@  discard block
 block discarded – undo
     }
 
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *   Show table for lines
      *
@@ -675,7 +675,7 @@  discard block
 block discarded – undo
         }
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *  Show top header of page.
      *
@@ -853,7 +853,7 @@  discard block
 block discarded – undo
         return 0;
     }
 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
     /**
      *  Show footer of page. Need this->emetteur object
      *

Please login to merge, or discard this patch.

		@@ -247,7 +247,7 @@ discard block
		block discarded – undo
247	247
248	248
249	249
250		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	250	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
251	251	/**
252	252	* Function to build PDF on disk, then output on HTTP stream.
253	253	*
		@@ -260,7 +260,7 @@ discard block
		block discarded – undo
260	260	*/
261	261	public function write_file($arrayofrecords, $outputlangs, $srctemplatepath, $outputdir = '', $filename = 'tmp_address_sheet.pdf')
262	262	{
263		- // phpcs:enable
	263	+ // phpcs:enable
264	264	global $user, $conf, $langs, $mysoc, $_Avery_Labels;
265	265
266	266	$this->code = $srctemplatepath;

		@@ -137,7 +137,7 @@ discard block
		block discarded – undo
137	137	}
138	138
139	139
140		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	140	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
141	141	/**
142	142	* Function to build pdf onto disk
143	143	*
		@@ -151,7 +151,7 @@ discard block
		block discarded – undo
151	151	*/
152	152	public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
153	153	{
154		- // phpcs:enable
	154	+ // phpcs:enable
155	155	global $user, $langs, $conf, $mysoc, $db, $hookmanager, $nblines;
156	156
157	157	dol_syslog("write_file outputlangs->defaultlang=" . (is_object($outputlangs) ? $outputlangs->defaultlang : 'null'));
		@@ -794,7 +794,7 @@ discard block
		block discarded – undo
794	794	}
795	795	}
796	796
797		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	797	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
798	798	/**
799	799	* Return list of active generation modules
800	800	*
		@@ -804,11 +804,11 @@ discard block
		block discarded – undo
804	804	*/
805	805	public static function liste_modeles($db, $maxfilenamelength = 0)
806	806	{
807		- // phpcs:enable
	807	+ // phpcs:enable
808	808	return parent::liste_modeles($db, $maxfilenamelength); // TODO: Change the autogenerated stub
809	809	}
810	810
811		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	811	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
812	812	/**
813	813	* Show table for lines
814	814	*
		@@ -869,7 +869,7 @@ discard block
		block discarded – undo
869	869	}
870	870	}
871	871
872		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	872	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
873	873	/**
874	874	* Show top header of page.
875	875	*
		@@ -1121,7 +1121,7 @@ discard block
		block discarded – undo
1121	1121	return $top_shift;
1122	1122	}
1123	1123
1124		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	1124	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
1125	1125	/**
1126	1126	* Show footer of page. Need this->emetteur object
1127	1127	*

		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195	return $texte;
196	196	}
197	197
198		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	198	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
199	199	/**
200	200	* Function to build a document on disk using the generic odt module.
201	201	*
		@@ -209,7 +209,7 @@ discard block
		block discarded – undo
209	209	*/
210	210	public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
211	211	{
212		- // phpcs:enable
	212	+ // phpcs:enable
213	213	global $user, $langs, $conf, $mysoc, $hookmanager;
214	214
215	215	if (empty($srctemplatepath)) {

		@@ -133,7 +133,7 @@ discard block
		block discarded – undo
133	133	}
134	134
135	135
136		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	136	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
137	137	/**
138	138	* Function to build pdf onto disk
139	139	*
		@@ -147,7 +147,7 @@ discard block
		block discarded – undo
147	147	*/
148	148	public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
149	149	{
150		- // phpcs:enable
	150	+ // phpcs:enable
151	151	global $user, $langs, $conf, $mysoc, $hookmanager;
152	152
153	153	if (!is_object($outputlangs)) {
		@@ -587,8 +587,8 @@ discard block
		block discarded – undo
587	587	return 0;
588	588	}
589	589
590		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
591		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	590	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	591	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
592	592	/**
593	593	* Show miscellaneous information (payment mode, payment term, ...)
594	594	*
		@@ -600,7 +600,7 @@ discard block
		block discarded – undo
600	600	*/
601	601	protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
602	602	{
603		- // phpcs:enable
	603	+ // phpcs:enable
604	604	global $conf, $mysoc;
605	605	$default_font_size = pdf_getPDFFontSize($outputlangs);
606	606
		@@ -617,7 +617,7 @@ discard block
		block discarded – undo
617	617	$pdf->MultiCell($larg_sign, 2, $outputlangs->trans("ForCustomer") . ':', '', 'L');
618	618	}
619	619
620		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	620	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
621	621	/**
622	622	* Show table for lines
623	623	*
		@@ -683,7 +683,7 @@ discard block
		block discarded – undo
683	683	}
684	684	}
685	685
686		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	686	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
687	687	/**
688	688	* Show top header of page.
689	689	*
		@@ -861,7 +861,7 @@ discard block
		block discarded – undo
861	861	return 0;
862	862	}
863	863
864		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	864	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
865	865	/**
866	866	* Show footer of page. Need this->emetteur object
867	867	*

		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112	}
113	113
114	114
115		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	115	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
116	116	/**
117	117	* Function to build pdf onto disk
118	118	*
		@@ -126,7 +126,7 @@ discard block
		block discarded – undo
126	126	*/
127	127	public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
128	128	{
129		- // phpcs:enable
	129	+ // phpcs:enable
130	130	global $user, $langs, $conf, $mysoc, $hookmanager;
131	131
132	132	if (!is_object($outputlangs)) {
		@@ -594,8 +594,8 @@ discard block
		block discarded – undo
594	594	return 0;
595	595	}
596	596
597		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
598		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	597	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	598	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
599	599	/**
600	600	* Show miscellaneous information (payment mode, payment term, ...)
601	601	*
		@@ -607,7 +607,7 @@ discard block
		block discarded – undo
607	607	*/
608	608	protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
609	609	{
610		- // phpcs:enable
	610	+ // phpcs:enable
611	611	global $conf, $mysoc;
612	612	$default_font_size = pdf_getPDFFontSize($outputlangs);
613	613
		@@ -625,7 +625,7 @@ discard block
		block discarded – undo
625	625	}
626	626
627	627
628		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	628	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
629	629	/**
630	630	* Show table for lines
631	631	*
		@@ -675,7 +675,7 @@ discard block
		block discarded – undo
675	675	}
676	676	}
677	677
678		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	678	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
679	679	/**
680	680	* Show top header of page.
681	681	*
		@@ -853,7 +853,7 @@ discard block
		block discarded – undo
853	853	return 0;
854	854	}
855	855
856		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
	856	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
857	857	/**
858	858	* Show footer of page. Need this->emetteur object
859	859	*

		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	// use this method in future refactoring
48	48	}
49	49
50		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	50	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
51	51	/**
52	52	* Output a sticker on page at position _COUNTX, _COUNTY (_COUNTX and _COUNTY start from 0)
53	53	* - %LOGO% is replace with company logo
		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	*/
65	65	public function Add_PDF_label(&$pdf, $textleft, $header, $footer, $outputlangs, $textright = '', $photo = '')
66	66	{
67		- // phpcs:enable
	67	+ // phpcs:enable
68	68	global $mysoc, $conf, $langs;
69	69	global $forceimgscalewidth, $forceimgscaleheight;
70	70
		@@ -224,7 +224,7 @@ discard block
		block discarded – undo
224	224
225	225
226	226
227		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	227	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
228	228	/**
229	229	* Function to build PDF on disk, then output on HTTP stream.
230	230	*
		@@ -237,7 +237,7 @@ discard block
		block discarded – undo
237	237	*/
238	238	public function write_file($arrayofrecords, $outputlangs, $srctemplatepath, $outputdir = '', $filename = 'tmp_address_sheet.pdf')
239	239	{
240		- // phpcs:enable
	240	+ // phpcs:enable
241	241	global $user, $conf, $langs, $mysoc, $_Avery_Labels;
242	242
243	243	$this->code = $srctemplatepath;

		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	public $error = '';
43	43
44	44
45		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	45	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
46	46	/**
47	47	* Return list of active generation modules
48	48	*
		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	*/
53	53	public function liste_modeles($db, $maxfilenamelength = 0)
54	54	{
55		- // phpcs:enable
	55	+ // phpcs:enable
56	56	$type = 'members_labels';
57	57	$list = array();
58	58
		@@ -79,7 +79,7 @@ discard block
		block discarded – undo
79	79	*/
80	80	function doc_label_pdf_create($db, $arrayofrecords, $modele, $outputlangs, $outputdir = '', $template = 'standardlabel', $filename = 'tmp_address_sheet.pdf')
81	81	{
82		- // phpcs:enable
	82	+ // phpcs:enable
83	83	global $conf, $langs;
84	84	$langs->load("members");
85	85

		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	'type' => 'info',
117	117	);
118	118	} else {
119		- $keyforprovider = ''; // @FIXME
	119	+ $keyforprovider = ''; // @FIXME
120	120
121	121	$this->google_id = getDolGlobalString('OAUTH_GOOGLE_ID');
122	122	$this->google_secret = getDolGlobalString('OAUTH_GOOGLE_SECRET');
		@@ -258,7 +258,7 @@ discard block
		block discarded – undo
258	258	global $conf;
259	259	$ret = array();
260	260
261		- $keyforprovider = ''; // @FIXME
	261	+ $keyforprovider = ''; // @FIXME
262	262
263	263	// Token storage
264	264	$storage = new DoliStorage($this->db, $conf, $keyforprovider);
		@@ -400,7 +400,7 @@ discard block
		block discarded – undo
400	400	'contentType' => $contenttype,
401	401	);
402	402
403		- $keyforprovider = ''; // @FIXME
	403	+ $keyforprovider = ''; // @FIXME
404	404
405	405	// Dolibarr Token storage
406	406	$storage = new DoliStorage($this->db, $conf, $keyforprovider);
		@@ -452,7 +452,7 @@ discard block
		block discarded – undo
452	452	$error = 0;
453	453	$html = '';
454	454
455		- $keyforprovider = ''; // @FIXME
	455	+ $keyforprovider = ''; // @FIXME
456	456
457	457	// Token storage
458	458	$storage = new DoliStorage($this->db, $conf, $keyforprovider);

		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	*/
40	40	abstract class ModelePDFAsset extends CommonDocGenerator
41	41	{
42		- // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
	42	+ // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
43	43	/**
44	44	* Return list of active generation modules
45	45	*
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	*/
50	50	public static function liste_modeles($db, $maxfilenamelength = 0)
51	51	{
52		- // phpcs:enable
	52	+ // phpcs:enable
53	53	$type = 'asset';
54	54	$list = array();
55	55

		@@ -71,8 +71,8 @@ discard block
		block discarded – undo
71	71	*/
72	72	public $version = 'dolibarr';
73	73
74		- public $posxcomm; // For customer comment column
75		- public $posxweightvol; // For weight or volume
	74	+ public $posxcomm; // For customer comment column
	75	+ public $posxweightvol; // For weight or volume
76	76	public $posxremainingqty;
77	77
78	78
		@@ -115,7 +115,7 @@ discard block
		block discarded – undo
115	115
116	116	// Define position of columns
117	117	$this->posxdesc = $this->marge_gauche + 1;
118		- $this->posxcomm = 112; // customer comment
	118	+ $this->posxcomm = 112; // customer comment
119	119	//$this->posxtva=112;
120	120	//$this->posxup=126;
121	121	$this->posxqty = 165;

alxarafe / alixar

Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch