View GitHub Repository alixar

Schedule Inspection
Subscribe
Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
Status
Category
Toggle Patches
public/htdocs/core/modules/product_batch/modules_product_batch.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
  */
42 42 
 abstract class ModelePDFProductBatch extends CommonDocGenerator
43 43 
 {
44 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
44 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
45 45 
     /**
46 46 
      *  Return list of active generation modules
47 47 
      *
 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51 
      */
52 52 
     public static function liste_modeles($db, $maxfilenamelength = 0)
53 53 
     {
54 
-		// phpcs:enable
54 
+        // phpcs:enable
55 55 
         $type = 'product_batch';
56 56 
         $list = array();
57 57
Please login to merge, or discard this patch.
public/htdocs/core/modules/ticket/modules_ticket.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -35,7 +35,7 @@  discard block
 
 block discarded – undo
35 35 
  */
36 36 
 abstract class ModelePDFTicket extends CommonDocGenerator
37 37 
 {
38 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
38 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
39 39 
     /**
40 40 
      *  Return list of active generation modules
41 41 
      *
 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
      */
46 46 
     public static function liste_modeles($db, $maxfilenamelength = 0)
47 47 
     {
48 
-		// phpcs:enable
48 
+        // phpcs:enable
49 49 
         $type = 'ticket';
50 50 
         $list = array();
51 51
Please login to merge, or discard this patch.
public/htdocs/core/modules/ticket/doc/doc_generic_ticket_odt.modules.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -181,7 +181,7 @@  discard block
 
 block discarded – undo
181 181 
         return $texte;
182 182 
     }
183 183
184 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
184 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
185 185 
     /**
186 186 
      *  Function to build a document on disk using the generic odt module.
187 187 
      *
 
@@ -195,7 +195,7 @@  discard block
 
 block discarded – undo
195 195 
      */
196 196 
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
197 197 
     {
198 
-		// phpcs:enable
198 
+        // phpcs:enable
199 199 
         global $user, $langs, $conf, $mysoc, $hookmanager;
200 200
201 201 
         if (empty($srctemplatepath)) {
 
@@ -407,7 +407,7 @@  discard block
 
 block discarded – undo
407 407 
         return -1;
408 408 
     }
409 409
410 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
410 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
411 411 
     /**
412 412 
      * get substitution array for object
413 413 
      *
 
@@ -418,7 +418,7 @@  discard block
 
 block discarded – undo
418 418 
      */
419 419 
     public function get_substitutionarray_object($object, $outputlangs, $array_key = 'object')
420 420 
     {
421 
-		// phpcs:enable
421 
+        // phpcs:enable
422 422 
         if (!$object instanceof User) {
423 423 
             dol_syslog("Expected Ticket object, got " . gettype($object), LOG_ERR);
424 424 
             return array();
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -164,7 +164,7 @@
 
 block discarded – undo
164 164 
         $maxfilesizearray = getMaxFileSizeArray();
165 165 
         $maxmin = $maxfilesizearray['maxmin'];
166 166 
         if ($maxmin > 0) {
167 
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
167 
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
168 168 
         }
169 169 
         $texte .= ' <input type="file" name="uploadfile">';
170 170 
         $texte .= '<input type="hidden" value="TICKET_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';
Please login to merge, or discard this patch.
public/htdocs/core/modules/ticket/mod_ticket_universal.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@
 
 block discarded – undo
34 34 
      *  Dolibarr version of the loaded document
35 35 
      *  @var string
36 36 
      */
37 
-    public $version = 'dolibarr';  // 'development', 'experimental', 'dolibarr'
37 
+    public $version = 'dolibarr'; // 'development', 'experimental', 'dolibarr'
38 38
39 39 
     /**
40 40 
      *  @var string Error code (or message)
Please login to merge, or discard this patch.
public/htdocs/core/modules/expensereport/doc/pdf_standard.modules.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -174,7 +174,7 @@  discard block
 
 block discarded – undo
174 174 
     }
175 175
176 176
177 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
177 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
178 178 
     /**
179 179 
      *  Function to build pdf onto disk
180 180 
      *
 
@@ -188,7 +188,7 @@  discard block
 
 block discarded – undo
188 188 
      */
189 189 
     public function write_file($object, $outputlangs, $srctemplatepath = '', $hidedetails = 0, $hidedesc = 0, $hideref = 0)
190 190 
     {
191 
-		// phpcs:enable
191 
+        // phpcs:enable
192 192 
         global $user, $langs, $conf, $mysoc, $db, $hookmanager;
193 193
194 194 
         if (!is_object($outputlangs)) {
 
@@ -635,7 +635,7 @@  discard block
 
 block discarded – undo
635 635 
         $pdf->writeHTMLCell($this->posxtva - $this->posxcomment - 0.8, 4, $this->posxcomment - 1, $curY, $comment, 0, 1);
636 636 
     }
637 637
638 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
638 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
639 639 
     /**
640 640 
      *  Show top header of page.
641 641 
      *
 
@@ -880,7 +880,7 @@  discard block
 
 block discarded – undo
880 880 
         return 0;
881 881 
     }
882 882
883 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
883 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
884 884 
     /**
885 885 
      *   Show table for lines
886 886 
      *
 
@@ -1114,7 +1114,7 @@  discard block
 
 block discarded – undo
1114 1114 
         return -1;
1115 1115 
     }
1116 1116
1117 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
1117 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
1118 1118 
     /**
1119 1119 
      *  Show footer of page. Need this->emetteur object
1120 1120 
      *
Please login to merge, or discard this patch.
htdocs/core/modules/usergroup/doc/doc_generic_usergroup_odt.modules.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -195,7 +195,7 @@  discard block
 
 block discarded – undo
195 195 
         return $texte;
196 196 
     }
197 197
198 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
198 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
199 199 
     /**
200 200 
      *  Function to build a document on disk using the generic odt module.
201 201 
      *
 
@@ -209,7 +209,7 @@  discard block
 
 block discarded – undo
209 209 
      */
210 210 
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
211 211 
     {
212 
-		// phpcs:enable
212 
+        // phpcs:enable
213 213 
         global $user, $langs, $conf, $mysoc, $hookmanager;
214 214
215 215 
         if (empty($srctemplatepath)) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -199,7 +199,7 @@
 
 block discarded – undo
199 199 
         $maxfilesizearray = getMaxFileSizeArray();
200 200 
         $maxmin = $maxfilesizearray['maxmin'];
201 201 
         if ($maxmin > 0) {
202 
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
202 
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
203 203 
         }
204 204 
         $texte .= ' <input type="file" name="uploadfile">';
205 205 
         $texte .= '<input type="hidden" value="USERGROUP_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';
Please login to merge, or discard this patch.
public/htdocs/core/modules/usergroup/modules_usergroup.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34 
  */
35 35 
 abstract class ModelePDFUserGroup extends CommonDocGenerator
36 36 
 {
37 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
37 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
38 38 
     /**
39 39 
      *  Return list of active generation modules
40 40 
      *
 
@@ -44,7 +44,7 @@  discard block
 
 block discarded – undo
44 44 
      */
45 45 
     public static function liste_modeles($db, $maxfilenamelength = 0)
46 46 
     {
47 
-		// phpcs:enable
47 
+        // phpcs:enable
48 48 
         $type = 'group';
49 49 
         $list = array();
50 50
Please login to merge, or discard this patch.
public/htdocs/core/modules/product/doc/doc_generic_product_odt.modules.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -188,7 +188,7 @@  discard block
 
 block discarded – undo
188 188 
         return $texte;
189 189 
     }
190 190
191 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
191 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
192 192 
     /**
193 193 
      *  Function to build a document on disk using the generic odt module.
194 194 
      *
 
@@ -202,7 +202,7 @@  discard block
 
 block discarded – undo
202 202 
      */
203 203 
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
204 204 
     {
205 
-		// phpcs:enable
205 
+        // phpcs:enable
206 206 
         global $product, $langs, $conf, $mysoc, $hookmanager, $user;
207 207
208 208 
         if (empty($srctemplatepath)) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -171,7 +171,7 @@
 
 block discarded – undo
171 171 
         $maxfilesizearray = getMaxFileSizeArray();
172 172 
         $maxmin = $maxfilesizearray['maxmin'];
173 173 
         if ($maxmin > 0) {
174 
-            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
174 
+            $texte .= '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
175 175 
         }
176 176 
         $texte .= ' <input type="file" name="uploadfile">';
177 177 
         $texte .= '<input type="hidden" value="PRODUCT_ADDON_PDF_ODT_PATH" name="keyforuploaddir">';
Please login to merge, or discard this patch.
public/htdocs/core/modules/product/doc/pdf_standard.modules.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
     }
105 105
106 106
107 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
107 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
108 108 
     /**
109 109 
      *  Function to build a document on disk using the generic odt module.
110 110 
      *
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118 
      */
119 119 
     public function write_file($object, $outputlangs, $srctemplatepath, $hidedetails = 0, $hidedesc = 0, $hideref = 0)
120 120 
     {
121 
-		// phpcs:enable
121 
+        // phpcs:enable
122 122 
         global $user, $langs, $conf, $mysoc, $db, $hookmanager;
123 123
124 124 
         if (!is_object($outputlangs)) {
 
@@ -597,7 +597,7 @@  discard block
 
 block discarded – undo
597 597 
         }
598 598 
     }
599 599
600 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
600 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
601 601 
     /**
602 602 
      *   Show table for lines
603 603 
      *
 
@@ -697,7 +697,7 @@  discard block
 
 block discarded – undo
697 697 
         }
698 698 
     }
699 699
700 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
700 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
701 701 
     /**
702 702 
      *  Show top header of page.
703 703 
      *
 
@@ -863,7 +863,7 @@  discard block
 
 block discarded – undo
863 863 
         return 0;
864 864 
     }
865 865
866 
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
866 
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.PublicUnderscore
867 867 
     /**
868 868 
      *  Show footer of page. Need this->emetteur object
869 869 
      *
Please login to merge, or discard this patch.