Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
public/htdocs/core/ajax/flowjs-server.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 $flowChunkSize = GETPOST('flowChunkSize', 'alpha');
59 59
 $flowTotalSize = GETPOST('flowTotalSize', 'alpha');
60 60
 
61
-$result = restrictedArea($user, $module, 0, '', 0, 'fk_soc', 'rowid', 0, 1);    // Call with mode return
61
+$result = restrictedArea($user, $module, 0, '', 0, 'fk_soc', 'rowid', 0, 1); // Call with mode return
62 62
 
63 63
 if ($action != 'upload') {
64 64
     httponly_accessforbidden("Param action must be 'upload'");
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 
164 164
     // check that all the parts are present
165 165
     // the size of the last part is between chunkSize and 2*$chunkSize
166
-    if ($total_files * (float) $chunkSize >=  ((float) $totalSize - (float) $chunkSize + 1)) {
166
+    if ($total_files * (float) $chunkSize >= ((float) $totalSize - (float) $chunkSize + 1)) {
167 167
         // create the final destination file
168 168
         if (($fp = fopen($upload_dir . '/' . $fileName, 'w')) !== false) {
169 169
             for ($i = 1; $i <= $total_files; $i++) {
Please login to merge, or discard this patch.
public/htdocs/core/ajax/vatrates.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
 require constant('DOL_DOCUMENT_ROOT') . '/main.inc.php';
37 37
 
38 38
 $id = GETPOSTINT('id');
39
-$action = GETPOST('action', 'aZ09');    // 'getSellerVATRates' or 'getBuyerVATRates'
39
+$action = GETPOST('action', 'aZ09'); // 'getSellerVATRates' or 'getBuyerVATRates'
40 40
 $htmlname   = GETPOST('htmlname', 'alpha');
41 41
 $selected   = (GETPOST('selected') ? GETPOST('selected') : '-1');
42 42
 $productid = (GETPOSTINT('productid') ? GETPOSTINT('productid') : 0);
Please login to merge, or discard this patch.
public/htdocs/core/ajax/selectsearchbox.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
 if (isModEnabled('supplier_proposal') && !getDolGlobalString('MAIN_SEARCHFORM_SUPPLIER_PROPAL_DISABLED') && $user->hasRight('supplier_proposal', 'lire')) {
119 119
     $arrayresult['searchintosupplierpropal'] = array('position' => 100, 'img' => 'object_supplier_proposal', 'label' => $langs->trans("SearchIntoSupplierProposals", $search_boxvalue), 'text' => img_picto('', 'object_supplier_proposal', 'class="pictofixedwidth"') . ' ' . $langs->trans("SearchIntoSupplierProposals", $search_boxvalue), 'url' => constant('BASE_URL') . '/supplier_proposal/list.php' . ($search_boxvalue ? '?search_all=' . urlencode($search_boxvalue) : ''));
120 120
 }
121
-if (((isModEnabled('fournisseur') && !getDolGlobalString('MAIN_USE_NEW_SUPPLIERMOD') && $user->hasRight('fournisseur', 'commande', 'lire')) || (isModEnabled('supplier_order') &&  $user->hasRight('supplier_order', 'lire'))) && !getDolGlobalString('MAIN_SEARCHFORM_SUPPLIER_ORDER_DISABLED')) {
121
+if (((isModEnabled('fournisseur') && !getDolGlobalString('MAIN_USE_NEW_SUPPLIERMOD') && $user->hasRight('fournisseur', 'commande', 'lire')) || (isModEnabled('supplier_order') && $user->hasRight('supplier_order', 'lire'))) && !getDolGlobalString('MAIN_SEARCHFORM_SUPPLIER_ORDER_DISABLED')) {
122 122
     $arrayresult['searchintosupplierorder'] = array('position' => 110, 'img' => 'object_supplier_order', 'label' => $langs->trans("SearchIntoSupplierOrders", $search_boxvalue), 'text' => img_picto('', 'object_supplier_order', 'class="pictofixedwidth"') . ' ' . $langs->trans("SearchIntoSupplierOrders", $search_boxvalue), 'url' => constant('BASE_URL') . '/fourn/commande/list.php' . ($search_boxvalue ? '?search_all=' . urlencode($search_boxvalue) : ''));
123 123
 }
124 124
 if (isModEnabled('reception') && !getDolGlobalString('MAIN_SEARCHFORM_SUPPLIER_RECEPTION_DISABLED') && $user->hasRight('reception', 'lire')) {
Please login to merge, or discard this patch.
public/htdocs/core/ajax/locationincoterms.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
 // Security check
48 48
 if (!isModEnabled('incoterm')) {
49
-    httponly_accessforbidden("Module incoterm not enabled");    // This includes the exit.
49
+    httponly_accessforbidden("Module incoterm not enabled"); // This includes the exit.
50 50
 }
51 51
 // There is no other permission on this component. Everybody connected can read content of the incoterm table
52 52
 
Please login to merge, or discard this patch.
public/htdocs/core/ajax/row.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     if ($reshook > 0) {
140 140
         $perm = $hookmanager->resArray['perm'];
141 141
     }
142
-    if (! $perm) {
142
+    if (!$perm) {
143 143
         // We should not be here. If we are not allowed to reorder rows, feature should not be visible on script.
144 144
         // If we are here, it is a hack attempt, so we report a warning.
145 145
         print 'Bad permission to modify position of lines for object in table ' . $table_element_line;
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 
162 162
     // Reorder line to have position of children lines sharing same counter than parent lines
163 163
     // This should be useless because there is no need to have children sharing same counter than parent, but well, it's cleaner into database.
164
-    if (in_array($fk_element, array('fk_facture', 'fk_propal', 'fk_commande','fk_contrat'))) {
164
+    if (in_array($fk_element, array('fk_facture', 'fk_propal', 'fk_commande', 'fk_contrat'))) {
165 165
         $result = $row->line_order(true);
166 166
     }
167 167
 } else {
Please login to merge, or discard this patch.
public/htdocs/core/ajax/check_notifications.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
     $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'actioncomm_reminder as ar ON a.id = ar.fk_actioncomm AND ar.fk_user = ' . ((int) $user->id);
132 132
     $sql .= " AND ar.typeremind = 'browser' AND ar.dateremind < '" . $db->idate(dol_now()) . "'";
133 133
     $sql .= " AND ar.status = 0";
134
-    $sql .= " AND ar.entity = " . ((int) $conf->entity);  // No sharing of entity for alerts
134
+    $sql .= " AND ar.entity = " . ((int) $conf->entity); // No sharing of entity for alerts
135 135
     $sql .= $db->order('datep', 'ASC');
136 136
     $sql .= $db->plimit(10); // Avoid too many notification at once
137 137
 
Please login to merge, or discard this patch.
public/htdocs/core/ajax/objectonoff.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 // Load object according to $id and $element
55 55
 $object = fetchObjectByElement($id, $element);
56 56
 if (!is_object($object)) {
57
-    httponly_accessforbidden("Bad value for combination of parameters element/field: Object not found.");   // This includes the exit.
57
+    httponly_accessforbidden("Bad value for combination of parameters element/field: Object not found."); // This includes the exit.
58 58
 }
59 59
 
60 60
 $object->fields[$field] = array('type' => $format, 'enabled' => 1);
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 if (!empty($user->socid)) {
73 73
     $socid = $user->socid;
74 74
     if (!empty($object->socid) && $socid != $object->socid) {
75
-        httponly_accessforbidden("Access on object not allowed for this external user.");   // This includes the exit.
75
+        httponly_accessforbidden("Access on object not allowed for this external user."); // This includes the exit.
76 76
     }
77 77
 }
78 78
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 } elseif ($element == 'product' && in_array($field, array('tosell', 'tobuy', 'tobatch'))) { // Special case for products
84 84
     restrictedArea($user, 'produit|service', $object, 'product&product', '', '', 'rowid');
85 85
 } else {
86
-    httponly_accessforbidden("Bad value for combination of parameters element/field: Field not supported.");    // This includes the exit.
86
+    httponly_accessforbidden("Bad value for combination of parameters element/field: Field not supported."); // This includes the exit.
87 87
 }
88 88
 
89 89
 
Please login to merge, or discard this patch.
public/htdocs/core/bookmarks_page.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 $title = $langs->trans("Bookmarks");
72 72
 
73 73
 // URL http://mydolibarr/core/bookmarks_page?dol_use_jmobile=1 can be used for tests
74
-$head = '<!-- Bookmarks -->' . "\n";  // This is used by DoliDroid to know page is a bookmark selection page
74
+$head = '<!-- Bookmarks -->' . "\n"; // This is used by DoliDroid to know page is a bookmark selection page
75 75
 $arrayofjs = array();
76 76
 $arrayofcss = array();
77 77
 top_htmlhead($head, $title, 0, 0, $arrayofjs, $arrayofcss);
Please login to merge, or discard this patch.
public/htdocs/core/actions_sendmails.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -398,7 +398,7 @@
 block discarded – undo
398 398
                         $object->actionmsg = $message; // Long text
399 399
                         $object->actionmsg2 = $actionmsg2; // Short text ($langs->transnoentities('MailSentByTo')...);
400 400
                         if (getDolGlobalString('MAIN_MAIL_REPLACE_EVENT_TITLE_BY_EMAIL_SUBJECT')) {
401
-                            $object->actionmsg2     = $subject; // Short text
401
+                            $object->actionmsg2 = $subject; // Short text
402 402
                         }
403 403
 
404 404
                         $object->trackid = $trackid;
Please login to merge, or discard this patch.