Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
public/htdocs/contact/card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1250,7 +1250,7 @@
 block discarded – undo
1250 1250
             $maxfilesizearray = getMaxFileSizeArray();
1251 1251
             $maxmin = $maxfilesizearray['maxmin'];
1252 1252
             if ($maxmin > 0) {
1253
-                print '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
1253
+                print '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
1254 1254
             }
1255 1255
             print '<input type="file" class="flat maxwidth200" name="photo" id="photoinput">';
1256 1256
             print '</td></tr>';
Please login to merge, or discard this patch.
public/htdocs/contact/canvas/actions_contactcard_common.class.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         return $object;
82 82
     }
83 83
 
84
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
84
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
85 85
     /**
86 86
      *  Set content of ->tpl array, to use into template
87 87
      *
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
      */
92 92
     public function assign_values(&$action, $id)
93 93
     {
94
-		// phpcs:enable
94
+        // phpcs:enable
95 95
         global $conf, $langs, $user, $canvas;
96 96
         global $form, $formcompany, $objsoc;
97 97
 
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
         }
276 276
     }
277 277
 
278
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
278
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
279 279
     /**
280 280
      *  Assign POST values into object
281 281
      *
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
      */
284 284
     private function assign_post()
285 285
     {
286
-		// phpcs:enable
286
+        // phpcs:enable
287 287
         global $langs, $mysoc;
288 288
 
289 289
         $this->object->socid = GETPOSTINT("socid");
Please login to merge, or discard this patch.
public/htdocs/contact/canvas/default/actions_contactcard_default.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
         return $out;
75 75
     }
76 76
 
77
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
77
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
78 78
     /**
79 79
      *  Assign custom values for canvas
80 80
      *
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function assign_values(&$action, $id)
86 86
     {
87
-		// phpcs:enable
87
+        // phpcs:enable
88 88
         global $conf, $db, $langs, $user;
89 89
         global $form;
90 90
 
Please login to merge, or discard this patch.
public/htdocs/contact/list.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 $object->fields = dol_sort_array($object->fields, 'position');
272 272
 //$arrayfields['anotherfield'] = array('type'=>'integer', 'label'=>'AnotherField', 'checked'=>1, 'enabled'=>1, 'position'=>90, 'csslist'=>'right');
273 273
 $arrayfields = dol_sort_array($arrayfields, 'position');
274
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
274
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
275 275
 
276 276
 
277 277
 if (($id > 0 || !empty($ref)) && $action != 'add') {
@@ -512,7 +512,7 @@  discard block
 block discarded – undo
512 512
 
513 513
 // Add fields from hooks - ListFrom
514 514
 $parameters = array();
515
-$reshook = $hookmanager->executeHooks('printFieldListFrom', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook
515
+$reshook = $hookmanager->executeHooks('printFieldListFrom', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
516 516
 $sql .= $hookmanager->resPrint;
517 517
 $sql .= ' WHERE p.entity IN (' . getEntity('contact') . ')';
518 518
 if (!empty($userid)) {    // propre au commercial
@@ -943,7 +943,7 @@  discard block
 block discarded – undo
943 943
 if (isModEnabled('category') && $user->hasRight('societe', 'creer')) {
944 944
     $arrayofmassactions['preaffecttag'] = img_picto('', 'category', 'class="pictofixedwidth"') . $langs->trans("AffectTag");
945 945
 }
946
-if (GETPOSTINT('nomassaction') || in_array($massaction, array('presend', 'predelete','preaffecttag'))) {
946
+if (GETPOSTINT('nomassaction') || in_array($massaction, array('presend', 'predelete', 'preaffecttag'))) {
947 947
     $arrayofmassactions = array();
948 948
 }
949 949
 
Please login to merge, or discard this patch.
public/htdocs/contact/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 }
95 95
 $result = restrictedArea($user, 'contact', $id, 'socpeople&societe', '', '', 'rowid', 0); // If we create a contact with no company (shared contacts), no check on write permission
96 96
 
97
-$permissiontoadd = $user->hasRight('societe', 'contact', 'creer');  // Used by the include of actions_dellink.inc.php
97
+$permissiontoadd = $user->hasRight('societe', 'contact', 'creer'); // Used by the include of actions_dellink.inc.php
98 98
 
99 99
 
100 100
 /*
Please login to merge, or discard this patch.
public/htdocs/contact/perso.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -198,7 +198,7 @@
 block discarded – undo
198 198
         $maxfilesizearray = getMaxFileSizeArray();
199 199
         $maxmin = $maxfilesizearray['maxmin'];
200 200
         if ($maxmin > 0) {
201
-            print '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">';    // MAX_FILE_SIZE must precede the field type=file
201
+            print '<input type="hidden" name="MAX_FILE_SIZE" value="' . ($maxmin * 1024) . '">'; // MAX_FILE_SIZE must precede the field type=file
202 202
         }
203 203
         print '<input type="file" class="flat" name="photo" id="photoinput">';
204 204
         print '</td></tr>';
Please login to merge, or discard this patch.
public/htdocs/asset/admin/setup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -548,7 +548,7 @@
 block discarded – undo
548 548
                     $accountsystem->fetch(getDolGlobalInt('CHARTOFACCOUNTS'));
549 549
                     $sql = 'SELECT DISTINCT pcg_type FROM ' . MAIN_DB_PREFIX . 'accounting_account';
550 550
                     $sql .= " WHERE fk_pcg_version = '" . $db->escape($accountsystem->ref) . "'";
551
-                    $sql .= ' AND entity in (' . getEntity('accounting_account', 0) . ')';      // Always limit to current entity. No sharing in accountancy.
551
+                    $sql .= ' AND entity in (' . getEntity('accounting_account', 0) . ')'; // Always limit to current entity. No sharing in accountancy.
552 552
                     $sql .= ' LIMIT 50000'; // just as a sanity check
553 553
                     $resql = $db->query($sql);
554 554
                     if ($resql) {
Please login to merge, or discard this patch.
public/htdocs/asset/card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -337,7 +337,7 @@
 block discarded – undo
337 337
     print '<table class="border centpercent tableforfield">' . "\n";
338 338
 
339 339
     // Common attributes
340
-    $keyforbreak = 'date_acquisition';    // We change column just before this field
340
+    $keyforbreak = 'date_acquisition'; // We change column just before this field
341 341
     //unset($object->fields['fk_project']);             // Hide field already shown in banner
342 342
     //unset($object->fields['fk_soc']);                 // Hide field already shown in banner
343 343
     include DOL_DOCUMENT_ROOT . '/core/tpl/commonfields_view.tpl.php';
Please login to merge, or discard this patch.
public/htdocs/asset/model/list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 
72 72
 // Default sort order (if not yet defined by previous GETPOST)
73 73
 if (!$sortfield) {
74
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
74
+    reset($object->fields); // Reset is required to avoid key() to return null.
75 75
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
76 76
 }
77 77
 if (!$sortorder) {
Please login to merge, or discard this patch.