Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
public/htdocs/fourn/commande/contact.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,8 +52,8 @@
 block discarded – undo
52 52
 
53 53
 $object = new CommandeFournisseur($db);
54 54
 
55
-$usercancreate  = ($user->hasRight("fournisseur", "commande", "creer") || $user->hasRight("supplier_order", "creer"));
56
-$permissiontoadd    = $usercancreate; // Used by the include of actions_addupdatedelete.inc.php
55
+$usercancreate = ($user->hasRight("fournisseur", "commande", "creer") || $user->hasRight("supplier_order", "creer"));
56
+$permissiontoadd = $usercancreate; // Used by the include of actions_addupdatedelete.inc.php
57 57
 
58 58
 /*
59 59
  * Actions
Please login to merge, or discard this patch.
public/htdocs/fourn/commande/list.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 $search_date_order_endday = GETPOSTINT('search_date_order_endday');
68 68
 $search_date_order_endmonth = GETPOSTINT('search_date_order_endmonth');
69 69
 $search_date_order_endyear = GETPOSTINT('search_date_order_endyear');
70
-$search_date_order_start = dol_mktime(0, 0, 0, $search_date_order_startmonth, $search_date_order_startday, $search_date_order_startyear);   // Use tzserver
70
+$search_date_order_start = dol_mktime(0, 0, 0, $search_date_order_startmonth, $search_date_order_startday, $search_date_order_startyear); // Use tzserver
71 71
 $search_date_order_end = dol_mktime(23, 59, 59, $search_date_order_endmonth, $search_date_order_endday, $search_date_order_endyear);
72 72
 
73 73
 $search_date_delivery_startday = GETPOSTINT('search_date_delivery_startday');
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 $search_date_delivery_endday = GETPOSTINT('search_date_delivery_endday');
77 77
 $search_date_delivery_endmonth = GETPOSTINT('search_date_delivery_endmonth');
78 78
 $search_date_delivery_endyear = GETPOSTINT('search_date_delivery_endyear');
79
-$search_date_delivery_start = dol_mktime(0, 0, 0, $search_date_delivery_startmonth, $search_date_delivery_startday, $search_date_delivery_startyear);   // Use tzserver
79
+$search_date_delivery_start = dol_mktime(0, 0, 0, $search_date_delivery_startmonth, $search_date_delivery_startday, $search_date_delivery_startyear); // Use tzserver
80 80
 $search_date_delivery_end = dol_mktime(23, 59, 59, $search_date_delivery_endmonth, $search_date_delivery_endday, $search_date_delivery_endyear);
81 81
 
82 82
 $search_date_valid_startday = GETPOSTINT('search_date_valid_startday');
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 $search_date_valid_endday = GETPOSTINT('search_date_valid_endday');
86 86
 $search_date_valid_endmonth = GETPOSTINT('search_date_valid_endmonth');
87 87
 $search_date_valid_endyear = GETPOSTINT('search_date_valid_endyear');
88
-$search_date_valid_start = dol_mktime(0, 0, 0, $search_date_valid_startmonth, $search_date_valid_startday, $search_date_valid_startyear);   // Use tzserver
88
+$search_date_valid_start = dol_mktime(0, 0, 0, $search_date_valid_startmonth, $search_date_valid_startday, $search_date_valid_startyear); // Use tzserver
89 89
 $search_date_valid_end = dol_mktime(23, 59, 59, $search_date_valid_endmonth, $search_date_valid_endday, $search_date_valid_endyear);
90 90
 
91 91
 $search_date_approve_startday = GETPOSTINT('search_date_approve_startday');
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 $search_date_approve_endday = GETPOSTINT('search_date_approve_endday');
95 95
 $search_date_approve_endmonth = GETPOSTINT('search_date_approve_endmonth');
96 96
 $search_date_approve_endyear = GETPOSTINT('search_date_approve_endyear');
97
-$search_date_approve_start = dol_mktime(0, 0, 0, $search_date_approve_startmonth, $search_date_approve_startday, $search_date_approve_startyear);   // Use tzserver
97
+$search_date_approve_start = dol_mktime(0, 0, 0, $search_date_approve_startmonth, $search_date_approve_startday, $search_date_approve_startyear); // Use tzserver
98 98
 $search_date_approve_end = dol_mktime(23, 59, 59, $search_date_approve_endmonth, $search_date_approve_endday, $search_date_approve_endyear);
99 99
 
100 100
 $search_all = trim((GETPOST('search_all', 'alphanohtml') != '') ? GETPOST('search_all', 'alphanohtml') : GETPOST('sall', 'alphanohtml'));
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 
214 214
 $object->fields = dol_sort_array($object->fields, 'position');
215 215
 $arrayfields = dol_sort_array($arrayfields, 'position');
216
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
216
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
217 217
 
218 218
 $error = 0;
219 219
 
@@ -733,7 +733,7 @@  discard block
 block discarded – undo
733 733
         } else {
734 734
             $db->rollback();
735 735
             $action = 'create';
736
-            $_GET["origin"] = $_POST["origin"];     // Keep this ?
736
+            $_GET["origin"] = $_POST["origin"]; // Keep this ?
737 737
             $_GET["originid"] = $_POST["originid"]; // Keep this ?
738 738
             setEventMessages("Error", null, 'errors');
739 739
             $error++;
@@ -1240,7 +1240,7 @@  discard block
 block discarded – undo
1240 1240
 
1241 1241
     $topicmail = "SendOrderRef";
1242 1242
     $modelmail = "order_supplier_send";
1243
-    $objecttmp = new CommandeFournisseur($db);  // in case $object is not the good object
1243
+    $objecttmp = new CommandeFournisseur($db); // in case $object is not the good object
1244 1244
     $trackid = 'sord' . $object->id;
1245 1245
     include DOL_DOCUMENT_ROOT . '/core/tpl/massactions_pre.tpl.php';
1246 1246
 
Please login to merge, or discard this patch.
public/htdocs/fourn/commande/note.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 // Permissions
58 58
 $permissionnote = ($user->hasRight("fournisseur", "commande", "creer") || $user->hasRight("supplier_order", "creer")); // Used by the include of actions_setnotes.inc.php
59 59
 $usercancreate  = ($user->hasRight("fournisseur", "commande", "creer") || $user->hasRight("supplier_order", "creer"));
60
-$permissiontoadd    = $usercancreate; // Used by the include of actions_addupdatedelete.inc.php
60
+$permissiontoadd = $usercancreate; // Used by the include of actions_addupdatedelete.inc.php
61 61
 
62 62
 
63 63
 /*
Please login to merge, or discard this patch.
public/htdocs/blockedlog/admin/blockedlog_list.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
     $previoushash = '';
158 158
     $firstid = '';
159 159
 
160
-    if (! (GETPOSTINT('yeartoexport') > 0)) {
160
+    if (!(GETPOSTINT('yeartoexport') > 0)) {
161 161
         setEventMessages($langs->trans("ErrorFieldRequired", $langs->transnoentitiesnoconv("Year")), null, "errors");
162 162
         $error++;
163 163
     } else {
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
 
582 582
             // Link to source object
583 583
             print '<td class="tdoverflowmax150"' . (preg_match('/<a/', $object_link) ? '' : 'title="' . dol_escape_htmltag(dol_string_nohtmltag($object_link . ' - ' . $object_link_title)) . '"') . '>';
584
-            print '<!-- object_link -->';   // $object_link can be a '<a href' link or a text
584
+            print '<!-- object_link -->'; // $object_link can be a '<a href' link or a text
585 585
             print $object_link;
586 586
             print '</td>';
587 587
 
Please login to merge, or discard this patch.
public/htdocs/theme/eldy/global.inc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
147 147
     print "/* For dark mode */\n";
148 148
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
149
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
149
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
150 150
     } else {
151 151
         print "@media not print {";
152 152
     }
@@ -5402,7 +5402,7 @@  discard block
 block discarded – undo
5402 5402
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
5403 5403
     print "/* For dark mode */\n";
5404 5404
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
5405
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
5405
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
5406 5406
     } else {
5407 5407
         print "@media not print {";
5408 5408
     } ?>
Please login to merge, or discard this patch.
public/htdocs/theme/eldy/btn.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
19 19
     print "/* For dark mode */\n";
20 20
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
21
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
21
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
22 22
     } else {
23 23
         print "@media not print {";
24 24
     }
Please login to merge, or discard this patch.
public/htdocs/theme/md/style.css.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 $colortext           = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXT') ? $colortext : $conf->global->THEME_ELDY_TEXT) : (empty($user->conf->THEME_ELDY_TEXT) ? $colortext : $user->conf->THEME_ELDY_TEXT);
194 194
 $colortextlink       = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTLINK') ? $colortext : $conf->global->THEME_ELDY_TEXTLINK) : (empty($user->conf->THEME_ELDY_TEXTLINK) ? $colortextlink : $user->conf->THEME_ELDY_TEXTLINK);
195 195
 $butactionbg         = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_BTNACTION') ? $butactionbg : $conf->global->THEME_ELDY_BTNACTION) : (empty($user->conf->THEME_ELDY_BTNACTION) ? $butactionbg : $user->conf->THEME_ELDY_BTNACTION);
196
-$textbutaction     = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTBTNACTION') ? $textbutaction : $conf->global->THEME_ELDY_TEXTBTNACTION) : (empty($user->conf->THEME_ELDY_TEXTBTNACTION) ? $textbutaction : $user->conf->THEME_ELDY_TEXTBTNACTION);
196
+$textbutaction = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_TEXTBTNACTION') ? $textbutaction : $conf->global->THEME_ELDY_TEXTBTNACTION) : (empty($user->conf->THEME_ELDY_TEXTBTNACTION) ? $textbutaction : $user->conf->THEME_ELDY_TEXTBTNACTION);
197 197
 $fontsize            = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_FONT_SIZE1') ? $fontsize : $conf->global->THEME_ELDY_FONT_SIZE1) : (empty($user->conf->THEME_ELDY_FONT_SIZE1) ? $fontsize : $user->conf->THEME_ELDY_FONT_SIZE1);
198 198
 $fontsizesmaller     = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_FONT_SIZE2') ? $fontsize : $conf->global->THEME_ELDY_FONT_SIZE2) : (empty($user->conf->THEME_ELDY_FONT_SIZE2) ? $fontsize : $user->conf->THEME_ELDY_FONT_SIZE2);
199 199
 $heightrow           = empty($user->conf->THEME_ELDY_ENABLE_PERSONALIZED) ? (!getDolGlobalString('THEME_ELDY_USECOMOACTROW') ? '155%' : '300%') : (empty($user->conf->THEME_ELDY_USECOMOACTROW) ? '155%' : '300%');
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
378 378
     print "/* For dark mode */\n";
379 379
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
380
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
380
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
381 381
     } else {
382 382
         print "@media not print {";
383 383
     }
@@ -3034,7 +3034,7 @@  discard block
 block discarded – undo
3034 3034
                     if (preg_match('/^fa\-/', $iconformodule)) {
3035 3035
                         // This is a fa icon
3036 3036
                     } else {
3037
-                        $url =  dol_buildpath('/' . $val . '/img/' . $iconformodule . '.png', 1);
3037
+                        $url = dol_buildpath('/' . $val . '/img/' . $iconformodule . '.png', 1);
3038 3038
                     }
3039 3039
                     $found = 1;
3040 3040
                 } else {
Please login to merge, or discard this patch.
public/htdocs/theme/md/btn.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 if (getDolGlobalString('THEME_DARKMODEENABLED')) {
19 19
     print "/* For dark mode */\n";
20 20
     if (getDolGlobalInt('THEME_DARKMODEENABLED') != 2) {
21
-        print "@media (prefers-color-scheme: dark) {";  // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
21
+        print "@media (prefers-color-scheme: dark) {"; // To test, click on the 3 dots menu, then Other options then Display then emulate prefer-color-schemes
22 22
     } else {
23 23
         print "@media not print {";
24 24
     }
Please login to merge, or discard this patch.
public/htdocs/variants/card.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -286,7 +286,7 @@
 block discarded – undo
286 286
     if ($action != 'editline') {
287 287
         print '<div class="tabsAction">' . "\n";
288 288
         $parameters = array();
289
-        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action);    // Note that $action and $object may have been modified by hook
289
+        $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action); // Note that $action and $object may have been modified by hook
290 290
         if ($reshook < 0) {
291 291
             setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
292 292
         }
Please login to merge, or discard this patch.