Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
public/htdocs/product/inventory/ajax/searchfrombarcode.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -92,22 +92,22 @@  discard block
 block discarded – undo
92 92
                     $fk_product = $object->fk_product;
93 93
                     $reelqty = $object->reel;
94 94
 
95
-                    $objectreturn = array('fk_warehouse' => $warehouseid,'fk_product' => $fk_product,'reelqty' => $reelqty);
95
+                    $objectreturn = array('fk_warehouse' => $warehouseid, 'fk_product' => $fk_product, 'reelqty' => $reelqty);
96 96
                 }
97 97
             }
98 98
         }
99 99
         if ($warehousefound < 1) {
100
-            $response = array('status' => 'error','errorcode' => 'NotFound','message' => 'No warehouse found for barcode' . $barcode);
100
+            $response = array('status' => 'error', 'errorcode' => 'NotFound', 'message' => 'No warehouse found for barcode' . $barcode);
101 101
         } elseif ($warehousefound > 1) {
102
-            $response = array('status' => 'error','errorcode' => 'TooManyWarehouse','message' => 'Too many warehouse found');
102
+            $response = array('status' => 'error', 'errorcode' => 'TooManyWarehouse', 'message' => 'Too many warehouse found');
103 103
         } else {
104
-            $response = array('status' => 'success','message' => 'Warehouse found','object' => $objectreturn);
104
+            $response = array('status' => 'success', 'message' => 'Warehouse found', 'object' => $objectreturn);
105 105
         }
106 106
     } else {
107
-        $response = array('status' => 'error','errorcode' => 'NotFound','message' => "No results found for barcode");
107
+        $response = array('status' => 'error', 'errorcode' => 'NotFound', 'message' => "No results found for barcode");
108 108
     }
109 109
 } else {
110
-    $response = array('status' => 'error','errorcode' => 'ActionError','message' => "Error on action");
110
+    $response = array('status' => 'error', 'errorcode' => 'ActionError', 'message' => "Error on action");
111 111
 }
112 112
 
113 113
 if ($action == "addnewlineproduct") {
@@ -126,12 +126,12 @@  discard block
 block discarded – undo
126 126
 
127 127
         $result = $inventoryline->create($user);
128 128
         if ($result > 0) {
129
-            $response = array('status' => 'success','message' => 'Success on creating line','id_line' => $result);
129
+            $response = array('status' => 'success', 'message' => 'Success on creating line', 'id_line' => $result);
130 130
         } else {
131
-            $response = array('status' => 'error','errorcode' => 'ErrorCreation','message' => "Error on line creation");
131
+            $response = array('status' => 'error', 'errorcode' => 'ErrorCreation', 'message' => "Error on line creation");
132 132
         }
133 133
     } else {
134
-        $response = array('status' => 'error','errorcode' => 'NoIdForInventory','message' => "No id for inventory");
134
+        $response = array('status' => 'error', 'errorcode' => 'NoIdForInventory', 'message' => "No id for inventory");
135 135
     }
136 136
 }
137 137
 
Please login to merge, or discard this patch.
public/htdocs/product/inventory/list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 // Default sort order (if not yet defined by previous GETPOST)
75 75
 if (!$sortfield) {
76
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
76
+    reset($object->fields); // Reset is required to avoid key() to return null.
77 77
     $sortfield = "t." . key($object->fields); // Set here default search field. By default 1st field in definition.
78 78
 }
79 79
 if (!$sortorder) {
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
 // Output page
377 377
 // --------------------------------------------------------------------
378 378
 
379
-llxHeader('', $title, $help_url, '', 0, 0, $morejs, $morecss, '', 'bodyforlist');   // Can use also classforhorizontalscrolloftabs instead of bodyforlist for no horizontal scroll
379
+llxHeader('', $title, $help_url, '', 0, 0, $morejs, $morecss, '', 'bodyforlist'); // Can use also classforhorizontalscrolloftabs instead of bodyforlist for no horizontal scroll
380 380
 
381 381
 $arrayofselected = is_array($toselect) ? $toselect : array();
382 382
 
@@ -512,7 +512,7 @@  discard block
 block discarded – undo
512 512
 }
513 513
 
514 514
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
515
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
515
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
516 516
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
517 517
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
518 518
 
@@ -603,7 +603,7 @@  discard block
 block discarded – undo
603 603
     } elseif (in_array($val['type'], array('double(24,8)', 'double(6,3)', 'integer', 'real', 'price')) && !in_array($key, array('id', 'rowid', 'ref', 'status')) && $val['label'] != 'TechnicalID' && empty($val['arrayofkeyval'])) {
604 604
         $cssforfield .= ($cssforfield ? ' ' : '') . 'right';
605 605
     }
606
-    $cssforfield = preg_replace('/small\s*/', '', $cssforfield);    // the 'small' css must not be used for the title label
606
+    $cssforfield = preg_replace('/small\s*/', '', $cssforfield); // the 'small' css must not be used for the title label
607 607
     if (!empty($arrayfields['t.' . $key]['checked'])) {
608 608
         print getTitleFieldOfList($arrayfields['t.' . $key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : ''), 0, (empty($val['helplist']) ? '' : $val['helplist'])) . "\n";
609 609
         $totalarray['nbfield']++;
Please login to merge, or discard this patch.
public/htdocs/product/inventory/inventory.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
                 $line = $db->fetch_object($resql);
166 166
 
167 167
                 $qty_stock = $line->qty_stock;
168
-                $qty_view = $line->qty_view;        // The quantity viewed by inventorier, the qty we target
168
+                $qty_view = $line->qty_view; // The quantity viewed by inventorier, the qty we target
169 169
 
170 170
 
171 171
                 // Load real stock we have now.
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
                         }
223 223
                         $sqlupdate .= " WHERE rowid = " . ((int) $line->rowid);
224 224
                         $resqlupdate = $db->query($sqlupdate);
225
-                        if (! $resqlupdate) {
225
+                        if (!$resqlupdate) {
226 226
                             $error++;
227 227
                             setEventMessages($db->lasterror(), null, 'errors');
228 228
                             break;
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
                     if (!empty($line->pmp_real) && getDolGlobalString('INVENTORY_MANAGE_REAL_PMP')) {
233 233
                         $sqlpmp = 'UPDATE ' . MAIN_DB_PREFIX . 'product SET pmp = ' . ((float) $line->pmp_real) . ' WHERE rowid = ' . ((int) $line->fk_product);
234 234
                         $resqlpmp = $db->query($sqlpmp);
235
-                        if (! $resqlpmp) {
235
+                        if (!$resqlpmp) {
236 236
                             $error++;
237 237
                             setEventMessages($db->lasterror(), null, 'errors');
238 238
                             break;
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
                         if (getDolGlobalString('MAIN_PRODUCT_PERENTITY_SHARED')) {
241 241
                             $sqlpmp = 'UPDATE ' . MAIN_DB_PREFIX . 'product_perentity SET pmp = ' . ((float) $line->pmp_real) . ' WHERE fk_product = ' . ((int) $line->fk_product) . ' AND entity=' . $conf->entity;
242 242
                             $resqlpmp = $db->query($sqlpmp);
243
-                            if (! $resqlpmp) {
243
+                            if (!$resqlpmp) {
244 244
                                 $error++;
245 245
                                 setEventMessages($db->lasterror(), null, 'errors');
246 246
                                 break;
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
             $error++;
260 260
         }
261 261
 
262
-        if (! $error) {
262
+        if (!$error) {
263 263
             $db->commit();
264 264
         } else {
265 265
             $db->rollback();
@@ -299,8 +299,8 @@  discard block
 block discarded – undo
299 299
                         setEventMessages($langs->trans("FieldCannotBeNegative", $langs->transnoentitiesnoconv("RealQty")), null, 'errors');
300 300
                     }
301 301
                     if ($result > 0) {
302
-                        $inventoryline->qty_stock = (float) price2num(GETPOST('stock_qty_' . $lineid, 'alpha'), 'MS');    // The new value that was set in as hidden field
303
-                        $inventoryline->qty_view = $qtytoupdate;    // The new value we want
302
+                        $inventoryline->qty_stock = (float) price2num(GETPOST('stock_qty_' . $lineid, 'alpha'), 'MS'); // The new value that was set in as hidden field
303
+                        $inventoryline->qty_view = $qtytoupdate; // The new value we want
304 304
                         $inventoryline->pmp_real = price2num(GETPOST('realpmp_' . $lineid, 'alpha'), 'MS');
305 305
                         $inventoryline->pmp_expected = price2num(GETPOST('expectedpmp_' . $lineid, 'alpha'), 'MS');
306 306
                         $resultupdate = $inventoryline->update($user);
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
                     // Delete record
310 310
                     $result = $inventoryline->fetch($lineid);
311 311
                     if ($result > 0) {
312
-                        $inventoryline->qty_view = null;            // The new value we want
312
+                        $inventoryline->qty_view = null; // The new value we want
313 313
                         $inventoryline->pmp_real = price2num(GETPOST('realpmp_' . $lineid, 'alpha'), 'MS');
314 314
                         $inventoryline->pmp_expected = price2num(GETPOST('expectedpmp_' . $lineid, 'alpha'), 'MS');
315 315
                         $resultupdate = $inventoryline->update($user);
@@ -325,12 +325,12 @@  discard block
 block discarded – undo
325 325
         }
326 326
 
327 327
         // Update line with id of stock movement (and the start quantity if it has changed this last recording)
328
-        if (! $error) {
328
+        if (!$error) {
329 329
             $sqlupdate = "UPDATE " . MAIN_DB_PREFIX . "inventory";
330 330
             $sqlupdate .= " SET fk_user_modif = " . ((int) $user->id);
331 331
             $sqlupdate .= " WHERE rowid = " . ((int) $object->id);
332 332
             $resqlupdate = $db->query($sqlupdate);
333
-            if (! $resqlupdate) {
333
+            if (!$resqlupdate) {
334 334
                 $error++;
335 335
                 setEventMessages($db->lasterror(), null, 'errors');
336 336
             }
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
                 }
415 415
             } else {
416 416
                 // Clear var
417
-                $_POST['batch'] = '';       // TODO Replace this with a var
417
+                $_POST['batch'] = ''; // TODO Replace this with a var
418 418
                 $_POST['qtytoadd'] = '';
419 419
             }
420 420
         }
@@ -1170,7 +1170,7 @@  discard block
 block discarded – undo
1170 1170
                 print '</td>';
1171 1171
 
1172 1172
                 print '<td class="right nowraponall">';
1173
-                print $obj->qty_view;   // qty found
1173
+                print $obj->qty_view; // qty found
1174 1174
                 print '</td>';
1175 1175
 
1176 1176
                 //PMP Real
@@ -1192,7 +1192,7 @@  discard block
 block discarded – undo
1192 1192
                 $totalRealValuation += $pmp_valuation_real;
1193 1193
             } else {
1194 1194
                 print '<td class="right nowraponall">';
1195
-                print $obj->qty_view;   // qty found
1195
+                print $obj->qty_view; // qty found
1196 1196
                 print '</td>';
1197 1197
             }
1198 1198
             print '<td>';
Please login to merge, or discard this patch.
public/htdocs/product/canvas/product/actions_card_product.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     }
94 94
 
95 95
 
96
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
96
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
97 97
     /**
98 98
      *    Assign custom values for canvas (for example into this->tpl to be used by templates)
99 99
      *
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     public function assign_values(&$action, $id = 0, $ref = '')
106 106
     {
107
-		// phpcs:enable
107
+        // phpcs:enable
108 108
         global $conf, $langs, $user, $mysoc, $canvas;
109 109
         global $form, $formproduct;
110 110
 
Please login to merge, or discard this patch.
public/htdocs/product/canvas/service/actions_card_service.class.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     }
103 103
 
104 104
 
105
-	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
105
+    // phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
106 106
     /**
107 107
      *    Assign custom values for canvas (for example into this->tpl to be used by templates)
108 108
      *
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      */
114 114
     public function assign_values(&$action, $id = 0, $ref = '')
115 115
     {
116
-		// phpcs:enable
116
+        // phpcs:enable
117 117
         global $conf, $langs, $user, $mysoc, $canvas;
118 118
         global $form;
119 119
 
Please login to merge, or discard this patch.
public/htdocs/product/price_suppliers.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -971,9 +971,9 @@
 block discarded – undo
971 971
                             if (!empty($extrafields->attributes["product_fournisseur_price"]['list'][$key]) && $extrafields->attributes["product_fournisseur_price"]['list'][$key] != 3) {
972 972
                                 $extratitle = $langs->trans($value);
973 973
                                 $arrayfields['ef.' . $key] = array('label'    => $extratitle, 'checked' => 0,
974
-                                                                   'position' => (end($arrayfields)['position'] + 1),
975
-                                                                   'langfile' => $extrafields->attributes["product_fournisseur_price"]['langfile'][$key],
976
-                                                                   'help'     => $extrafields->attributes["product_fournisseur_price"]['help'][$key]);
974
+                                                                    'position' => (end($arrayfields)['position'] + 1),
975
+                                                                    'langfile' => $extrafields->attributes["product_fournisseur_price"]['langfile'][$key],
976
+                                                                    'help'     => $extrafields->attributes["product_fournisseur_price"]['help'][$key]);
977 977
                             }
978 978
                         }
979 979
                     }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 
69 69
 // If socid provided by ajax company selector
70 70
 if (GETPOSTINT('search_fourn_id')) {
71
-    $_GET['id_fourn'] = GETPOSTINT('search_fourn_id');  // Keep set to $_GET an $_POST. Used later.
71
+    $_GET['id_fourn'] = GETPOSTINT('search_fourn_id'); // Keep set to $_GET an $_POST. Used later.
72 72
     $_POST['id_fourn'] = GETPOSTINT('search_fourn_id'); // Keep set to $_GET an $_POST. Used later.
73 73
 }
74 74
 
Please login to merge, or discard this patch.
public/htdocs/product/price.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
             $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $db->escape($mysoc->country_code) . "'";
153 153
             $sql .= " AND t.taux = " . ((float) $tva_tx) . " AND t.active = 1";
154 154
             $sql .= " AND t.code = '" . $db->escape($vatratecode) . "'";
155
-            $sql .= " AND t.type_vat IN (0, 1)";    // Use only VAT rates type all or i.e. the sales type VAT rates.
155
+            $sql .= " AND t.type_vat IN (0, 1)"; // Use only VAT rates type all or i.e. the sales type VAT rates.
156 156
             $sql .= " AND t.entity IN (" . getEntity('c_tva') . ")";
157 157
             $resql = $db->query($sql);
158 158
             if ($resql) {
Please login to merge, or discard this patch.
public/htdocs/product/reassortlot.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 
95 95
 // Default sort order (if not yet defined by previous GETPOST)
96 96
 if (!$sortfield) {
97
-    reset($object->fields);                 // Reset is required to avoid key() to return null.
97
+    reset($object->fields); // Reset is required to avoid key() to return null.
98 98
     $sortfield = "p." . key($object->fields); // Set here default search field. By default 1st field in definition.
99 99
 }
100 100
 if (!$sortorder) {
Please login to merge, or discard this patch.
public/htdocs/product/stats/facture.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
 if (!empty($search_date_endyear)) {
101 101
     $option .= '&search_date_endyear=' . $search_date_endyear;
102 102
 }
103
-$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);   // Use tzserver
103
+$search_date_start = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
104 104
 $search_date_end = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
105 105
 
106 106
 if (GETPOST('button_removefilter_x', 'alpha') || GETPOST('button_removefilter', 'alpha')) {
Please login to merge, or discard this patch.