Passed
Push — GENERAL_BUG_REVIEW_240911 ( 776d89...c757bd )
by Rafael
50:33
created
public/htdocs/ticket/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
     accessforbidden();
93 93
 }
94 94
 
95
-$permissiontoadd = $user->hasRight('ticket', 'write');  // Used by the include of actions_addupdatedelete.inc.php and actions_linkedfiles
95
+$permissiontoadd = $user->hasRight('ticket', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_linkedfiles
96 96
 
97 97
 
98 98
 /*
Please login to merge, or discard this patch.
public/htdocs/expensereport/ajax/ajaxik.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -69,21 +69,21 @@
 block discarded – undo
69 69
 
70 70
 
71 71
 if (empty($fk_expense) || $fk_expense < 0) {
72
-    $rep->errorMessage =   $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_expense, 'fk_expense');
72
+    $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_expense, 'fk_expense');
73 73
 } elseif (empty($fk_c_exp_tax_cat) || $fk_c_exp_tax_cat < 0) {
74
-    $rep->errorMessage =  $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_c_exp_tax_cat, 'fk_c_exp_tax_cat');
74
+    $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorBadValueForParameter', $fk_c_exp_tax_cat, 'fk_c_exp_tax_cat');
75 75
 
76 76
     $rep->response_status = 'error';
77 77
 } else {
78 78
     // @see ndfp.class.php:3576 (method: compute_total_km)
79 79
     $expense = new ExpenseReport($db);
80 80
     if ($expense->fetch($fk_expense) <= 0) {
81
-        $rep->errorMessage =  $langs->transnoentitiesnoconv('ErrorRecordNotFound');
81
+        $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorRecordNotFound');
82 82
         $rep->response_status = 'error';
83 83
     } else {
84 84
         $userauthor = new User($db);
85 85
         if ($userauthor->fetch($expense->fk_user_author) <= 0) {
86
-            $rep->errorMessage =  $langs->transnoentitiesnoconv('ErrorRecordNotFound');
86
+            $rep->errorMessage = $langs->transnoentitiesnoconv('ErrorRecordNotFound');
87 87
             $rep->response_status = 'error';
88 88
         } else {
89 89
             $expense = new ExpenseReport($db);
Please login to merge, or discard this patch.
public/htdocs/expensereport/card.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 }
154 154
 $result = restrictedArea($user, 'expensereport', $object->id, 'expensereport');
155 155
 
156
-$permissiontoadd = $user->hasRight('expensereport', 'creer');   // Used by the include of actions_dellink.inc.php
156
+$permissiontoadd = $user->hasRight('expensereport', 'creer'); // Used by the include of actions_dellink.inc.php
157 157
 
158 158
 
159 159
 /*
@@ -2384,7 +2384,7 @@  discard block
 block discarded – undo
2384 2384
 
2385 2385
                         // Quantity
2386 2386
                         print '<td class="right">';
2387
-                        print '<input type="text" min="0" class="input_qty right maxwidth50"  name="qty" value="' . dol_escape_htmltag($line->qty) . '" />';  // We must be able to enter decimal qty
2387
+                        print '<input type="text" min="0" class="input_qty right maxwidth50"  name="qty" value="' . dol_escape_htmltag($line->qty) . '" />'; // We must be able to enter decimal qty
2388 2388
                         print '</td>';
2389 2389
 
2390 2390
                         //print '<td class="right">'.$langs->trans('AmountHT').'</td>';
Please login to merge, or discard this patch.
public/htdocs/expensereport/payment/list.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 $search_date_endday     = GETPOSTINT('search_date_endday');
68 68
 $search_date_endmonth   = GETPOSTINT('search_date_endmonth');
69 69
 $search_date_endyear    = GETPOSTINT('search_date_endyear');
70
-$search_date_start      = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);  // Use tzserver
70
+$search_date_start      = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
71 71
 $search_date_end        = dol_mktime(23, 59, 59, $search_date_endmonth, $search_date_endday, $search_date_endyear);
72 72
 $search_user            = GETPOST('search_user', 'alpha');
73 73
 $search_payment_type    = GETPOST('search_payment_type');
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     'pndf.amount'           => array('label' => "Amount", 'checked' => 1, 'position' => 70),
115 115
 );
116 116
 $arrayfields = dol_sort_array($arrayfields, 'position');
117
-'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields';  // dol_sort_array looses type for Phan
117
+'@phan-var-force array<string,array{label:string,checked?:int<0,1>,position?:int,help?:string}> $arrayfields'; // dol_sort_array looses type for Phan
118 118
 
119 119
 // Initialize technical object to manage hooks of page. Note that conf->hooks_modules contains array of hook context
120 120
 $hookmanager->initHooks(array('paymentexpensereportlist'));
@@ -420,7 +420,7 @@  discard block
 block discarded – undo
420 420
 }
421 421
 
422 422
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
423
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
423
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
424 424
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
425 425
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
426 426
 
Please login to merge, or discard this patch.
public/htdocs/expensereport/list.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 $search_date_startendday    = GETPOSTINT('search_date_startendday');
118 118
 $search_date_startendmonth  = GETPOSTINT('search_date_startendmonth');
119 119
 $search_date_startendyear   = GETPOSTINT('search_date_startendyear');
120
-$search_date_start          = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear);  // Use tzserver
120
+$search_date_start          = dol_mktime(0, 0, 0, $search_date_startmonth, $search_date_startday, $search_date_startyear); // Use tzserver
121 121
 $search_date_startend       = dol_mktime(23, 59, 59, $search_date_startendmonth, $search_date_startendday, $search_date_startendyear);
122 122
 
123 123
 $search_date_endday         = GETPOSTINT('search_date_endday');
@@ -126,10 +126,10 @@  discard block
 block discarded – undo
126 126
 $search_date_endendday      = GETPOSTINT('search_date_endendday');
127 127
 $search_date_endendmonth    = GETPOSTINT('search_date_endendmonth');
128 128
 $search_date_endendyear     = GETPOSTINT('search_date_endendyear');
129
-$search_date_end            = dol_mktime(0, 0, 0, $search_date_endmonth, $search_date_endday, $search_date_endyear);    // Use tzserver
129
+$search_date_end            = dol_mktime(0, 0, 0, $search_date_endmonth, $search_date_endday, $search_date_endyear); // Use tzserver
130 130
 $search_date_endend         = dol_mktime(23, 59, 59, $search_date_endendmonth, $search_date_endendday, $search_date_endendyear);
131 131
 
132
-$optioncss    = GETPOST('optioncss', 'alpha');
132
+$optioncss = GETPOST('optioncss', 'alpha');
133 133
 
134 134
 if ($search_status == '') {
135 135
     $search_status = -1;
@@ -588,7 +588,7 @@  discard block
 block discarded – undo
588 588
 }
589 589
 
590 590
 $varpage = empty($contextpage) ? $_SERVER["PHP_SELF"] : $contextpage;
591
-$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN'));  // This also change content of $arrayfields with user setup
591
+$htmlofselectarray = $form->multiSelectArrayWithCheckbox('selectedfields', $arrayfields, $varpage, getDolGlobalString('MAIN_CHECKBOX_LEFT_COLUMN')); // This also change content of $arrayfields with user setup
592 592
 $selectedfields = ($mode != 'kanban' ? $htmlofselectarray : '');
593 593
 $selectedfields .= (count($arrayofmassactions) ? $form->showCheckAddButtons('checkforselect', 1) : '');
594 594
 
Please login to merge, or discard this patch.
public/htdocs/expensereport/document.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
     }
97 97
 }
98 98
 
99
-$permissiontoadd = $user->hasRight('expensereport', 'creer');   // Used by the include of actions_dellink.inc.php
99
+$permissiontoadd = $user->hasRight('expensereport', 'creer'); // Used by the include of actions_dellink.inc.php
100 100
 
101 101
 
102 102
 /*
Please login to merge, or discard this patch.
public/htdocs/expensereport/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@
 block discarded – undo
141 141
 $dataseries = dol_sort_array($dataseries, 1, 'desc');
142 142
 
143 143
 // Merge all entries after the $KEEPNFIRST one into one entry called "Other..." (to avoid to have too much entries in graphic).
144
-$KEEPNFIRST = 7;    // Keep first $KEEPNFIRST one + 1 with the remain
144
+$KEEPNFIRST = 7; // Keep first $KEEPNFIRST one + 1 with the remain
145 145
 $i = 0;
146 146
 if (count($dataseries) > ($KEEPNFIRST + 1)) {
147 147
     foreach ($dataseries as $key => $val) {
Please login to merge, or discard this patch.
public/htdocs/stripe/ajax/ajax.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 }
60 60
 
61 61
 $usestripeterminals = getDolGlobalString('STRIPE_LOCATION');
62
-if (! $usestripeterminals) {
62
+if (!$usestripeterminals) {
63 63
     accessforbidden('Feature to use Stripe terminals not enabled');
64 64
 }
65 65
 
Please login to merge, or discard this patch.
public/htdocs/webservices/server_payment.php 1 patch
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -90,8 +90,8 @@  discard block
 block discarded – undo
90 90
     '',
91 91
     array(
92 92
         'dolibarrkey'       => array('name' => 'dolibarrkey', 'type' => 'xsd:string'),
93
-       'sourceapplication' => array('name' => 'sourceapplication', 'type' => 'xsd:string'),
94
-       'login'             => array('name' => 'login', 'type' => 'xsd:string'),
93
+        'sourceapplication' => array('name' => 'sourceapplication', 'type' => 'xsd:string'),
94
+        'login'             => array('name' => 'login', 'type' => 'xsd:string'),
95 95
         'password'          => array('name' => 'password', 'type' => 'xsd:string'),
96 96
         'entity'            => array('name' => 'entity', 'type' => 'xsd:string')
97 97
     )
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
         'amount'          => array('name' => 'amount', 'type' => 'xsd:double'),
121 121
         'num_payment'     => array('name' => 'num_payment', 'type' => 'xsd:string'),
122 122
         'thirdparty_id'   => array('name' => 'thirdparty_id', 'type' => 'xsd:int'),
123
-               'bank_account'    => array('name' => 'bank_account', 'type' => 'xsd:int'),
124
-               'payment_mode_id' => array('name' => 'payment_mode_id', 'type' => 'xsd:int'),
125
-               'invoice_id'      => array('name' => 'invoice_id', 'type' => 'xsd:int'),
126
-               'int_label'       => array('name' => 'int_label', 'type' => 'xsd:string'),
127
-               'emitter'         => array('name' => 'emitter', 'type' => 'xsd:string'),
128
-               'bank_source'     => array('name' => 'bank_source', 'type' => 'xsd:string'),
123
+                'bank_account'    => array('name' => 'bank_account', 'type' => 'xsd:int'),
124
+                'payment_mode_id' => array('name' => 'payment_mode_id', 'type' => 'xsd:int'),
125
+                'invoice_id'      => array('name' => 'invoice_id', 'type' => 'xsd:int'),
126
+                'int_label'       => array('name' => 'int_label', 'type' => 'xsd:string'),
127
+                'emitter'         => array('name' => 'emitter', 'type' => 'xsd:string'),
128
+                'bank_source'     => array('name' => 'bank_source', 'type' => 'xsd:string'),
129 129
     )
130 130
 );
131 131
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
     $now = dol_now();
166 166
 
167 167
     dol_syslog("Function: createPayment login=" . $authentication['login'] . " id=" . $payment->id .
168
-               ", ref=" . $payment->ref . ", ref_ext=" . $payment->ref_ext);
168
+                ", ref=" . $payment->ref . ", ref_ext=" . $payment->ref_ext);
169 169
 
170 170
     if ($authentication['entity']) {
171 171
         $conf->entity = $authentication['entity'];
Please login to merge, or discard this patch.