alxarafe / alixar

Base/CommonObject.php

Braces +1373 added lines, -865 removed lines

@@ -401,24 +401,31 @@ 
 		$sql.= " FROM ".MAIN_DB_PREFIX.$element;

 		$sql.= " WHERE entity IN (".getEntity($element).")" ;

 

-		if ($id > 0) $sql.= " AND rowid = ".$db->escape($id);

-		else if ($ref) $sql.= " AND ref = '".$db->escape($ref)."'";

-		else if ($ref_ext) $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";

-		else {

+		if ($id > 0) {
+		    $sql.= " AND rowid = ".$db->escape($id);
+		} else if ($ref) {
+		    $sql.= " AND ref = '".$db->escape($ref)."'";
+		} else if ($ref_ext) {
+		    $sql.= " AND ref_ext = '".$db->escape($ref_ext)."'";
+		} else {

 			$error='ErrorWrongParameters';

 			dol_print_error(get_class()."::isExistingObject ".$error, LOG_ERR);

 			return -1;

 		}

-		if ($ref || $ref_ext)

-            $sql .= " AND entity = " . Globals::$conf->entity;

+		if ($ref || $ref_ext) {
+		            $sql .= " AND entity = " . Globals::$conf->entity;
+		}
 

         dol_syslog(get_class()."::isExistingObject", LOG_DEBUG);

 		$resql = $db->query($sql);

 		if ($resql)

 		{

 			$num=$db->num_rows($resql);

-			if ($num > 0) return 1;

-			else return 0;

+			if ($num > 0) {
+			    return 1;
+			} else {
+			    return 0;
+			}
 		}

 		return -1;

 	}

@@ -447,13 +454,18 @@ 
 		//print "lastname=".$this->lastname." name=".$this->name." nom=".$this->nom."<br>\n";

 		$lastname=$this->lastname;

 		$firstname=$this->firstname;

-		if (empty($lastname))  $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));

+		if (empty($lastname)) {
+		    $lastname=(isset($this->lastname)?$this->lastname:(isset($this->name)?$this->name:(isset($this->nom)?$this->nom:(isset($this->societe)?$this->societe:(isset($this->company)?$this->company:'')))));
+		}
 

 		$ret='';

 		if ($option && $this->civility_id)

 		{

-			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';

-			else $ret.=$this->civility_id.' ';

+			if ($langs->transnoentitiesnoconv("Civility".$this->civility_id)!="Civility".$this->civility_id) {
+			    $ret.=$langs->transnoentitiesnoconv("Civility".$this->civility_id).' ';
+			} else {
+			    $ret.=$this->civility_id.' ';
+			}
 		}

 

 		$ret .= DolUtils::dolGetFirstLastname($firstname, $lastname, $nameorder);

@@ -544,14 +556,15 @@ 
             && empty(Globals::$conf->global->SOCIETE_DISABLE_STATE) && $this->state) {

             if (!empty(Globals::$conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT) && Globals::$conf->global->MAIN_SHOW_REGION_IN_STATE_SELECT == 1 && $this->region) {

                 $out.=($outdone?' - ':'').$this->region.' - '.$this->state;

-            }

-            else {

+            } else {

                 $out.=($outdone?' - ':'').$this->state;

             }

 			$outdone++;

 		}

 

-		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) $out.=($outdone?'<br>':'');

+		if (! empty($this->phone) || ! empty($this->phone_pro) || ! empty($this->phone_mobile) || ! empty($this->phone_perso) || ! empty($this->fax) || ! empty($this->office_phone) || ! empty($this->user_mobile) || ! empty($this->office_fax)) {
+		    $out.=($outdone?'<br>':'');
+		}
 		if (! empty($this->phone) && empty($this->phone_pro)) {		// For objects that store pro phone into ->phone

 			$out.=dol_print_phone($this->phone,$this->country_code,$contactid,$thirdpartyid,'AC_TEL','&nbsp;','phone',$langs->trans("PhonePro")); $outdone++;

 		}

@@ -591,13 +604,21 @@ 
 		}

 		$out.='<div style="clear: both;">';

 		if (!empty(Globals::$conf->socialnetworks->enabled)) {

-			if ($this->skype) $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');

+			if ($this->skype) {
+			    $out.=dol_print_socialnetworks($this->skype,$this->id,$object->id,'skype');
+			}
 			$outdone++;

-			if ($this->jabberid) $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');

+			if ($this->jabberid) {
+			    $out.=dol_print_socialnetworks($this->jabberid,$this->id,$object->id,'jabber');
+			}
 			$outdone++;

-			if ($this->twitter) $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');

+			if ($this->twitter) {
+			    $out.=dol_print_socialnetworks($this->twitter,$this->id,$object->id,'twitter');
+			}
 			$outdone++;

-			if ($this->facebook) $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');

+			if ($this->facebook) {
+			    $out.=dol_print_socialnetworks($this->facebook,$this->id,$object->id,'facebook');
+			}
 			$outdone++;

 		}

 		$out.='</div>';

@@ -657,10 +678,10 @@ 
 					$this->errors = $ecmfile->errors;

 				}

 				*/

-			}

-			else return '';

-		}

-		elseif (empty($ecmfile->share))

+			} else {
+			    return '';
+			}
+		} elseif (empty($ecmfile->share))

 		{

 			// Add entry into index

 			if ($initsharekey)

@@ -668,8 +689,9 @@ 
 				require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

 				$ecmfile->share = getRandomPassword(true);

 				$ecmfile->update($user);

-			}

-			else return '';

+			} else {
+			    return '';
+			}
 		}

 

 		// Define $urlwithroot

@@ -683,14 +705,18 @@ 
 		//if (! empty($modulepart)) $paramlink.=($paramlink?'&':'').'modulepart='.$modulepart;		// For sharing with hash (so public files), modulepart is not required.

 		//if (! empty($ecmfile->entity)) $paramlink.='&entity='.$ecmfile->entity; 					// For sharing with hash (so public files), entity is not required.

 		//$paramlink.=($paramlink?'&':'').'file='.urlencode($filepath);								// No need of name of file for public link, we will use the hash

-		if (! empty($ecmfile->share)) $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;			// Hash for public share

-		if ($forcedownload) $paramlink.=($paramlink?'&':'').'attachment=1';

+		if (! empty($ecmfile->share)) {
+		    $paramlink.=($paramlink?'&':'').'hashp='.$ecmfile->share;
+		}
+		// Hash for public share

+		if ($forcedownload) {
+		    $paramlink.=($paramlink?'&':'').'attachment=1';
+		}
 

 		if ($relativelink)

 		{

 			$linktoreturn='document.php'.($paramlink?'?'.$paramlink:'');

-		}

-		else

+		} else

 		{

 			$linktoreturn=$urlwithroot.'/document.php'.($paramlink?'?'.$paramlink:'');

 		}

@@ -738,8 +764,7 @@ 
 		if (is_numeric($type_contact))

 		{

 			$id_type_contact=$type_contact;

-		}

-		else

+		} else

 		{

 			// We look for id type_contact

 			$sql = "SELECT tc.rowid";

@@ -752,7 +777,9 @@ 
 			if ($resql)

 			{

 				$obj = $this->db->fetch_object($resql);

-				if ($obj) $id_type_contact=$obj->rowid;

+				if ($obj) {
+				    $id_type_contact=$obj->rowid;
+				}
 			}

 		}

 

@@ -804,8 +831,7 @@ 
 

 				$this->db->commit();

 				return 1;

-			}

-			else

+			} else

 			{

 				if ($this->db->errno() == 'DB_ERROR_RECORD_ALREADY_EXISTS')

 				{

@@ -813,15 +839,16 @@ 
 					$this->db->rollback();

 					echo 'err rollback';

 					return -2;

-				}

-				else

+				} else

 				{

 					$this->error=$this->db->error();

 					$this->db->rollback();

 					return -1;

 				}

 			}

-		} else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

     // phpcs:disable PEAR.NamingConventions.ValidFunctionName.NotCamelCaps

@@ -863,15 +890,18 @@ 
 		// Insert into database

 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_contact set";

 		$sql.= " statut = ".$statut;

-		if ($type_contact_id) $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";

-		if ($fk_socpeople) $sql.= ", fk_socpeople = '".$fk_socpeople ."'";

+		if ($type_contact_id) {
+		    $sql.= ", fk_c_type_contact = '".$type_contact_id ."'";
+		}
+		if ($fk_socpeople) {
+		    $sql.= ", fk_socpeople = '".$fk_socpeople ."'";
+		}
 		$sql.= " where rowid = ".$rowid;

 		$resql=$this->db->query($sql);

 		if ($resql)

 		{

 			return 0;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -908,8 +938,7 @@ 
 

 			$this->db->commit();

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -939,15 +968,15 @@ 
 

 		$sql = "DELETE FROM ".MAIN_DB_PREFIX."element_contact";

 		$sql.= " WHERE element_id = ".$this->id;

-		if ($listId)

-			$sql.= " AND fk_c_type_contact IN (".$listId.")";

+		if ($listId) {
+					$sql.= " AND fk_c_type_contact IN (".$listId.")";
+		}
 

 		dol_syslog(get_class($this)."::delete_linked_contact", LOG_DEBUG);

 		if ($this->db->query($sql))

 		{

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -972,22 +1001,38 @@ 
 		$tab=array();

 

 		$sql = "SELECT ec.rowid, ec.statut as statuslink, ec.fk_socpeople as id, ec.fk_c_type_contact";    // This field contains id of llx_socpeople or id of llx_user

-		if ($source == 'internal') $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";

-		if ($source == 'external' || $source == 'thirdparty') $sql.=", t.fk_soc as socid, t.statut as statuscontact";

+		if ($source == 'internal') {
+		    $sql.=", '-1' as socid, t.statut as statuscontact, t.login, t.photo";
+		}
+		if ($source == 'external' || $source == 'thirdparty') {
+		    $sql.=", t.fk_soc as socid, t.statut as statuscontact";
+		}
 		$sql.= ", t.civility as civility, t.lastname as lastname, t.firstname, t.email";

 		$sql.= ", tc.source, tc.element, tc.code, tc.libelle";

 		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact tc";

 		$sql.= ", ".MAIN_DB_PREFIX."element_contact ec";

-		if ($source == 'internal') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";

-		if ($source == 'external'|| $source == 'thirdparty') $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";

+		if ($source == 'internal') {
+		    $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."user t on ec.fk_socpeople = t.rowid";
+		}
+		if ($source == 'external'|| $source == 'thirdparty') {
+		    $sql.=" LEFT JOIN ".MAIN_DB_PREFIX."socpeople t on ec.fk_socpeople = t.rowid";
+		}
 		$sql.= " WHERE ec.element_id =".$this->id;

 		$sql.= " AND ec.fk_c_type_contact=tc.rowid";

 		$sql.= " AND tc.element='".$this->db->escape($this->element)."'";

-		if ($code) $sql.= " AND tc.code = '".$this->db->escape($code)."'";

-		if ($source == 'internal') $sql.= " AND tc.source = 'internal'";

-		if ($source == 'external' || $source == 'thirdparty') $sql.= " AND tc.source = 'external'";

+		if ($code) {
+		    $sql.= " AND tc.code = '".$this->db->escape($code)."'";
+		}
+		if ($source == 'internal') {
+		    $sql.= " AND tc.source = 'internal'";
+		}
+		if ($source == 'external' || $source == 'thirdparty') {
+		    $sql.= " AND tc.source = 'external'";
+		}
 		$sql.= " AND tc.active=1";

-		if ($statut >= 0) $sql.= " AND ec.statut = '".$statut."'";

+		if ($statut >= 0) {
+		    $sql.= " AND ec.statut = '".$statut."'";
+		}
 		$sql.=" ORDER BY t.lastname ASC";

 

 		dol_syslog(get_class($this)."::liste_contact", LOG_DEBUG);

@@ -1008,8 +1053,7 @@ 
 								   'nom'=>$obj->lastname,      // For backward compatibility

 								   'civility'=>$obj->civility, 'lastname'=>$obj->lastname, 'firstname'=>$obj->firstname, 'email'=>$obj->email, 'login'=>$obj->login, 'photo'=>$obj->photo, 'statuscontact'=>$obj->statuscontact,

 								   'rowid'=>$obj->rowid, 'code'=>$obj->code, 'libelle'=>$libelle_type, 'status'=>$obj->statuslink, 'fk_c_type_contact'=>$obj->fk_c_type_contact);

-				}

-				else

+				} else

 				{

 					$tab[$i]=$obj->id;

 				}

@@ -1018,8 +1062,7 @@ 
 			}

 

 			return $tab;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			dol_print_error($this->db);

@@ -1054,8 +1097,7 @@ 
 			$result = $this->update_contact($rowid, $newstatut);

 			$this->db->free($resql);

 			return $result;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			dol_print_error($this->db);

@@ -1079,16 +1121,27 @@ 
         // phpcs:enable

 		global $langs;

 

-		if (empty($order)) $order='position';

-		if ($order == 'position') $order.=',code';

+		if (empty($order)) {
+		    $order='position';
+		}
+		if ($order == 'position') {
+		    $order.=',code';
+		}
 

 		$tab = array();

 		$sql = "SELECT DISTINCT tc.rowid, tc.code, tc.libelle, tc.position";

 		$sql.= " FROM ".MAIN_DB_PREFIX."c_type_contact as tc";

 		$sql.= " WHERE tc.element='".$this->db->escape($this->element)."'";

-		if ($activeonly == 1) $sql.= " AND tc.active=1"; // only the active types

-		if (! empty($source) && $source != 'all') $sql.= " AND tc.source='".$this->db->escape($source)."'";

-		if (! empty($code)) $sql.= " AND tc.code='".$this->db->escape($code)."'";

+		if ($activeonly == 1) {
+		    $sql.= " AND tc.active=1";
+		}
+		// only the active types

+		if (! empty($source) && $source != 'all') {
+		    $sql.= " AND tc.source='".$this->db->escape($source)."'";
+		}
+		if (! empty($code)) {
+		    $sql.= " AND tc.code='".$this->db->escape($code)."'";
+		}
 		$sql.= $this->db->order($order,'ASC');

 

 		//print "sql=".$sql;

@@ -1103,13 +1156,15 @@ 
 

 				$transkey="TypeContact_".$this->element."_".$source."_".$obj->code;

 				$libelle_type=($langs->trans($transkey)!=$transkey ? $langs->trans($transkey) : $obj->libelle);

-				if (empty($option)) $tab[$obj->rowid]=$libelle_type;

-				else $tab[$obj->code]=$libelle_type;

+				if (empty($option)) {
+				    $tab[$obj->rowid]=$libelle_type;
+				} else {
+				    $tab[$obj->code]=$libelle_type;
+				}
 				$i++;

 			}

 			return $tab;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			//dol_print_error($this->db);

@@ -1148,19 +1203,29 @@ 
 

 		$sql = "SELECT ec.fk_socpeople";

 		$sql.= " FROM ".MAIN_DB_PREFIX."element_contact as ec,";

-		if ($source == 'internal') $sql.= " ".MAIN_DB_PREFIX."user as c,";

-		if ($source == 'external') $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";

+		if ($source == 'internal') {
+		    $sql.= " ".MAIN_DB_PREFIX."user as c,";
+		}
+		if ($source == 'external') {
+		    $sql.= " ".MAIN_DB_PREFIX."socpeople as c,";
+		}
 		$sql.= " ".MAIN_DB_PREFIX."c_type_contact as tc";

 		$sql.= " WHERE ec.element_id = ".$id;

 		$sql.= " AND ec.fk_socpeople = c.rowid";

-		if ($source == 'internal') $sql.= " AND c.entity IN (".getEntity('user').")";

-		if ($source == 'external') $sql.= " AND c.entity IN (".getEntity('societe').")";

+		if ($source == 'internal') {
+		    $sql.= " AND c.entity IN (".getEntity('user').")";
+		}
+		if ($source == 'external') {
+		    $sql.= " AND c.entity IN (".getEntity('societe').")";
+		}
 		$sql.= " AND ec.fk_c_type_contact = tc.rowid";

 		$sql.= " AND tc.element = '".$element."'";

 		$sql.= " AND tc.source = '".$source."'";

 		$sql.= " AND tc.code = '".$code."'";

 		$sql.= " AND tc.active = 1";

-		if ($status) $sql.= " AND ec.statut = ".$status;

+		if ($status) {
+		    $sql.= " AND ec.statut = ".$status;
+		}
 

 		dol_syslog(get_class($this)."::getIdContact", LOG_DEBUG);

 		$resql=$this->db->query($sql);

@@ -1171,8 +1236,7 @@ 
 				$result[$i]=$obj->fk_socpeople;

 				$i++;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			return null;

@@ -1191,9 +1255,13 @@ 
 	function fetch_contact($contactid=null)

 	{

         // phpcs:enable

-		if (empty($contactid)) $contactid=$this->contactid;

+		if (empty($contactid)) {
+		    $contactid=$this->contactid;
+		}
 

-		if (empty($contactid)) return 0;

+		if (empty($contactid)) {
+		    return 0;
+		}
 

 		require_once DOL_DOCUMENT_ROOT.'/contact/class/contact.class.php';

 		$contact = new Contact($this->db);

@@ -1214,14 +1282,16 @@ 
         // phpcs:enable

 		global $conf;

 

-		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id))

-			return 0;

+		if (empty($this->socid) && empty($this->fk_soc) && empty($this->fk_thirdparty) && empty($force_thirdparty_id)) {
+					return 0;
+		}
 

 		require_once DOL_DOCUMENT_ROOT . '/societe/class/societe.class.php';

 

 		$idtofetch = isset($this->socid) ? $this->socid : (isset($this->fk_soc) ? $this->fk_soc : $this->fk_thirdparty);

-		if ($force_thirdparty_id)

-			$idtofetch = $force_thirdparty_id;

+		if ($force_thirdparty_id) {
+					$idtofetch = $force_thirdparty_id;
+		}
 

 		if ($idtofetch) {

 			$thirdparty = new Societe($this->db);

@@ -1234,8 +1304,9 @@ 
 			}

 

 			return $result;

-		} else

-			return -1;

+		} else {
+					return -1;
+		}
 	}

 

 

@@ -1281,20 +1352,25 @@ 
 		dol_syslog(get_class($this).'::fetch_barcode this->element='.$this->element.' this->barcode_type='.$this->barcode_type);

 

 		$idtype=$this->barcode_type;

-		if (empty($idtype) && $idtype != '0')	// If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

+		if (empty($idtype) && $idtype != '0') {
+		    // If type of barcode no set, we try to guess. If set to '0' it means we forced to have type remain not defined

 		{

 			if ($this->element == 'product')

-                $idtype = Globals::$conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;

-            else if ($this->element == 'societe')

-                $idtype = Globals::$conf->global->GENBARCODE_BARCODETYPE_THIRDPARTY;

-            else dol_syslog('Call fetch_barcode with barcode_type not defined and cant be guessed', LOG_WARNING);

+                $idtype = Globals::$conf->global->PRODUIT_DEFAULT_BARCODE_TYPE;
+		} else if ($this->element == 'societe') {
+                            $idtype = Globals::$conf->global->GENBARCODE_BARCODETYPE_THIRDPARTY;
+            } else {
+                dol_syslog('Call fetch_barcode with barcode_type not defined and cant be guessed', LOG_WARNING);
+            }
 		}

 

 		if ($idtype > 0)

 		{

-			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder))    // If data not already loaded

+			if (empty($this->barcode_type) || empty($this->barcode_type_code) || empty($this->barcode_type_label) || empty($this->barcode_type_coder)) {
+			    // If data not already loaded

 			{

-				$sql = "SELECT rowid, code, libelle as label, coder";

+				$sql = "SELECT rowid, code, libelle as label, coder";
+			}
 				$sql.= " FROM ".MAIN_DB_PREFIX."c_barcode_type";

 				$sql.= " WHERE rowid = ".$idtype;

 				dol_syslog(get_class($this).'::fetch_barcode', LOG_DEBUG);

@@ -1307,8 +1383,7 @@ 
 					$this->barcode_type_label = $obj->label;

 					$this->barcode_type_coder = $obj->coder;

 					return 1;

-				}

-				else

+				} else

 				{

 					dol_print_error($this->db);

 					return -1;

@@ -1329,8 +1404,13 @@ 
         // phpcs:enable

 		include_once DOL_DOCUMENT_ROOT.'/projet/class/project.class.php';

 

-		if (empty($this->fk_project) && ! empty($this->fk_projet)) $this->fk_project = $this->fk_projet;	// For backward compatibility

-		if (empty($this->fk_project)) return 0;

+		if (empty($this->fk_project) && ! empty($this->fk_projet)) {
+		    $this->fk_project = $this->fk_projet;
+		}
+		// For backward compatibility

+		if (empty($this->fk_project)) {
+		    return 0;
+		}
 

 		$project = new Project($this->db);

 		$result = $project->fetch($this->fk_project);

@@ -1351,7 +1431,9 @@ 
         // phpcs:enable

 		include_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

 

-		if (empty($this->fk_product)) return 0;

+		if (empty($this->fk_product)) {
+		    return 0;
+		}
 

 		$product = new Product($this->db);

 		$result = $product->fetch($this->fk_product);

@@ -1385,9 +1467,15 @@ 
 	function fetch_origin()

 	{

         // phpcs:enable

-		if ($this->origin == 'shipping') $this->origin = 'expedition';

-		if ($this->origin == 'delivery') $this->origin = 'livraison';

-        if ($this->origin == 'order_supplier') $this->origin = 'commandeFournisseur';

+		if ($this->origin == 'shipping') {
+		    $this->origin = 'expedition';
+		}
+		if ($this->origin == 'delivery') {
+		    $this->origin = 'livraison';
+		}
+        if ($this->origin == 'order_supplier') {
+            $this->origin = 'commandeFournisseur';
+        }
 

 		$origin = $this->origin;

 

@@ -1479,29 +1567,48 @@ 
 	{

 		global $user,$langs,$conf;

 

-		if (empty($table)) 	  $table=$this->table_element;

-		if (empty($id))    	  $id=$this->id;

-		if (empty($format))   $format='text';

-		if (empty($id_field)) $id_field='rowid';

+		if (empty($table)) {
+		    $table=$this->table_element;
+		}
+		if (empty($id)) {
+		    $id=$this->id;
+		}
+		if (empty($format)) {
+		    $format='text';
+		}
+		if (empty($id_field)) {
+		    $id_field='rowid';
+		}
 

 		$error=0;

 

 		$this->db->begin();

 

 		// Special case

-		if ($table == 'product' && $field == 'note_private') $field='note';

-		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) $fk_user_field = 'fk_user_mod';

+		if ($table == 'product' && $field == 'note_private') {
+		    $field='note';
+		}
+		if (in_array($table, array('actioncomm', 'adherent', 'advtargetemailing', 'cronjob', 'establishment'))) {
+		    $fk_user_field = 'fk_user_mod';
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$table." SET ";

 

-		if ($format == 'text') $sql.= $field." = '".$this->db->escape($value)."'";

-		else if ($format == 'int') $sql.= $field." = ".$this->db->escape($value);

-		else if ($format == 'date') $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");

+		if ($format == 'text') {
+		    $sql.= $field." = '".$this->db->escape($value)."'";
+		} else if ($format == 'int') {
+		    $sql.= $field." = ".$this->db->escape($value);
+		} else if ($format == 'date') {
+		    $sql.= $field." = ".($value ? "'".$this->db->idate($value)."'" : "null");
+		}
 

 		if ($fk_user_field)

 		{

-			if (! empty($fuser) && is_object($fuser)) $sql.=", ".$fk_user_field." = ".$fuser->id;

-			elseif (empty($fuser) || $fuser != 'none') $sql.=", ".$fk_user_field." = ".$user->id;

+			if (! empty($fuser) && is_object($fuser)) {
+			    $sql.=", ".$fk_user_field." = ".$fuser->id;
+			} elseif (empty($fuser) || $fuser != 'none') {
+			    $sql.=", ".$fk_user_field." = ".$user->id;
+			}
 		}

 

 		$sql.= " WHERE ".$id_field." = ".$id;

@@ -1516,28 +1623,32 @@ 
 				if (empty($this->fields) && method_exists($this, 'fetch'))

 				{

 					$result = $this->fetch($id);

-				}

-				else

+				} else

 				{

 					$result = $this->fetchCommon($id);

 				}

-				if ($result >= 0) $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);   // This may set this->errors

-				if ($result < 0) $error++;

+				if ($result >= 0) {
+				    $result=$this->call_trigger($trigkey, (! empty($fuser) && is_object($fuser)) ? $fuser : $user);
+				}
+				// This may set this->errors

+				if ($result < 0) {
+				    $error++;
+				}
 			}

 

 			if (! $error)

 			{

-				if (property_exists($this, $field)) $this->$field = $value;

+				if (property_exists($this, $field)) {
+				    $this->$field = $value;
+				}
 				$this->db->commit();

 				return 1;

-			}

-			else

+			} else

 			{

 				$this->db->rollback();

 				return -2;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -1564,36 +1675,66 @@ 
 			dol_print_error('',get_class($this)."::load_previous_next_ref was called on objet with property table_element not defined");

 			return -1;

 		}

-		if ($fieldid == 'none') return 1;

+		if ($fieldid == 'none') {
+		    return 1;
+		}
 

 		// Security on socid

 		$socid = 0;

-		if ($user->societe_id > 0) $socid = $user->societe_id;

+		if ($user->societe_id > 0) {
+		    $socid = $user->societe_id;
+		}
 

 		// this->ismultientitymanaged contains

 		// 0=No test on entity, 1=Test with field entity, 2=Test with link by societe

 		$alias = 's';

-		if ($this->element == 'societe') $alias = 'te';

+		if ($this->element == 'societe') {
+		    $alias = 'te';
+		}
 

 		$sql = "SELECT MAX(te.".$fieldid.")";

 		$sql.= " FROM ".(empty($nodbprefix)?MAIN_DB_PREFIX:'').$this->table_element." as te";

 		if ($this->element == 'user' && !empty(Globals::$conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

             $sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid)  $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to socid

+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";
+		}
+		// If we need to link to societe to limit select to socid

+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
+		}
 		$sql.= " WHERE te.".$fieldid." < '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND sc.fk_user = " .$user->id;
+		}
+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';
+		}
 		if (! empty($filter))

 		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

+			if (! preg_match('/^\s*AND/i', $filter)) {
+			    $sql.=" AND ";
+			}
+			// For backward compatibility

 			$sql.=$filter;

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to socid

 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

 			if ($this->element == 'user' && !empty(Globals::$conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

                 if (!empty($user->admin) && empty($user->entity) && Globals::$conf->entity == 1) {

@@ -1606,9 +1747,15 @@ 
 				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

 			}

 		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND te.fk_soc = ' . $socid;
+		}
+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';
+		}
+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') {
+		    $sql.= ' AND te.rowid = ' . $socid;
+		}
 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 

 		$result = $this->db->query($sql);

@@ -1626,20 +1773,44 @@ 
 		if ($this->element == 'user' && !empty(Globals::$conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

             $sql.= ",".MAIN_DB_PREFIX."usergroup_user as ug";

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ", ".MAIN_DB_PREFIX."societe as s";	// If we need to link to societe to limit select to socid

-		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";	// If we need to link to societe to limit select to socid

-		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ", ".MAIN_DB_PREFIX."societe as s";
+		}
+		// If we need to link to societe to limit select to socid

+		else if ($this->restrictiononfksoc == 2 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe as s ON te.fk_soc = s.rowid";
+		}
+		// If we need to link to societe to limit select to socid

+		if ($this->restrictiononfksoc && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."societe_commerciaux as sc ON ".$alias.".rowid = sc.fk_soc";
+		}
 		$sql.= " WHERE te.".$fieldid." > '".$this->db->escape($this->ref)."'";  // ->ref must always be defined (set to id if field does not exists)

-		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND sc.fk_user = " .$user->id;

-		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';

+		if ($this->restrictiononfksoc == 1 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND sc.fk_user = " .$user->id;
+		}
+		if ($this->restrictiononfksoc == 2 && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= " AND (sc.fk_user = " .$user->id.' OR te.fk_soc IS NULL)';
+		}
 		if (! empty($filter))

 		{

-			if (! preg_match('/^\s*AND/i', $filter)) $sql.=" AND ";   // For backward compatibility

+			if (! preg_match('/^\s*AND/i', $filter)) {
+			    $sql.=" AND ";
+			}
+			// For backward compatibility

 			$sql.=$filter;

 		}

-		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to entity

-		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) $sql.= ' AND te.fk_soc = s.rowid';			// If we need to link to societe to limit select to socid

+		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 2) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to entity

+		else if ($this->restrictiononfksoc == 1 && $this->element != 'societe' && !$user->rights->societe->client->voir && !$socid) {
+		    $sql.= ' AND te.fk_soc = s.rowid';
+		}
+		// If we need to link to societe to limit select to socid

 		if (isset($this->ismultientitymanaged) && $this->ismultientitymanaged == 1) {

 			if ($this->element == 'user' && !empty(Globals::$conf->global->MULTICOMPANY_TRANSVERSE_MODE)) {

                 if (!empty($user->admin) && empty($user->entity) && Globals::$conf->entity == 1) {

@@ -1652,9 +1823,15 @@ 
 				$sql.= ' AND te.entity IN ('.getEntity($this->element).')';

 			}

 		}

-		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') $sql.= ' AND te.fk_soc = ' . $socid;

-		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';

-		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') $sql.= ' AND te.rowid = ' . $socid;

+		if ($this->restrictiononfksoc == 1 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND te.fk_soc = ' . $socid;
+		}
+		if ($this->restrictiononfksoc == 2 && $socid && $this->element != 'societe') {
+		    $sql.= ' AND (te.fk_soc = ' . $socid.' OR te.fk_soc IS NULL)';
+		}
+		if ($this->restrictiononfksoc && $socid && $this->element == 'societe') {
+		    $sql.= ' AND te.rowid = ' . $socid;
+		}
 		//print 'socid='.$socid.' restrictiononfksoc='.$this->restrictiononfksoc.' ismultientitymanaged = '.$this->ismultientitymanaged.' filter = '.$filter.' -> '.$sql."<br>";

 		// Rem: Bug in some mysql version: SELECT MIN(rowid) FROM llx_socpeople WHERE rowid > 1 when one row in database with rowid=1, returns 1 instead of null

 

@@ -1686,8 +1863,11 @@ 
 		$i = 0;

 		while ($i < $num)

 		{

-			if ($source == 'thirdparty') $contactAlreadySelected[$i] = $tab[$i]['socid'];

-			else  $contactAlreadySelected[$i] = $tab[$i]['id'];

+			if ($source == 'thirdparty') {
+			    $contactAlreadySelected[$i] = $tab[$i]['socid'];
+			} else {
+			    $contactAlreadySelected[$i] = $tab[$i]['id'];
+			}
 			$i++;

 		}

 		return $contactAlreadySelected;

@@ -1711,14 +1891,19 @@ 
 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 		if ($this->table_element == 'actioncomm')

 		{

-			if ($projectid) $sql.= ' SET fk_project = '.$projectid;

-			else $sql.= ' SET fk_project = NULL';

+			if ($projectid) {
+			    $sql.= ' SET fk_project = '.$projectid;
+			} else {
+			    $sql.= ' SET fk_project = NULL';
+			}
 			$sql.= ' WHERE id = '.$this->id;

-		}

-		else

+		} else

 		{

-			if ($projectid) $sql.= ' SET fk_projet = '.$projectid;

-			else $sql.= ' SET fk_projet = NULL';

+			if ($projectid) {
+			    $sql.= ' SET fk_projet = '.$projectid;
+			} else {
+			    $sql.= ' SET fk_projet = NULL';
+			}
 			$sql.= ' WHERE rowid = '.$this->id;

 		}

 

@@ -1727,8 +1912,7 @@ 
 		{

 			$this->fk_project = $projectid;

 			return 1;

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db);

 			return -1;

@@ -1748,8 +1932,12 @@ 
 		{

 			// TODO uniformize field name

 			$fieldname = 'fk_mode_reglement';

-			if ($this->element == 'societe') $fieldname = 'mode_reglement';

-			if (get_class($this) == 'Fournisseur') $fieldname = 'mode_reglement_supplier';

+			if ($this->element == 'societe') {
+			    $fieldname = 'mode_reglement';
+			}
+			if (get_class($this) == 'Fournisseur') {
+			    $fieldname = 'mode_reglement_supplier';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 			$sql .= ' SET '.$fieldname.' = '.$id;

@@ -1759,17 +1947,17 @@ 
 			{

 				$this->mode_reglement_id = $id;

 				// for supplier

-				if (get_class($this) == 'Fournisseur') $this->mode_reglement_supplier_id = $id;

+				if (get_class($this) == 'Fournisseur') {
+				    $this->mode_reglement_supplier_id = $id;
+				}
 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setPaymentMethods Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setPaymentMethods, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1799,18 +1987,18 @@ 
 				$this->multicurrency_code = $code;

 

 				list($fk_multicurrency, $rate) = MultiCurrency::getIdAndTxFromCode($this->db, $code);

-				if ($rate) $this->setMulticurrencyRate($rate,2);

+				if ($rate) {
+				    $this->setMulticurrencyRate($rate,2);
+				}
 

 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setMulticurrencyCode Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setMulticurrencyCode, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1904,15 +2092,13 @@ 
 				}

 

 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setMulticurrencyRate Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setMulticurrencyRate, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1933,8 +2119,12 @@ 
 		{

 			// TODO uniformize field name

 			$fieldname = 'fk_cond_reglement';

-			if ($this->element == 'societe') $fieldname = 'cond_reglement';

-			if (get_class($this) == 'Fournisseur') $fieldname = 'cond_reglement_supplier';

+			if ($this->element == 'societe') {
+			    $fieldname = 'cond_reglement';
+			}
+			if (get_class($this) == 'Fournisseur') {
+			    $fieldname = 'cond_reglement_supplier';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 			$sql .= ' SET '.$fieldname.' = '.$id;

@@ -1944,18 +2134,18 @@ 
 			{

 				$this->cond_reglement_id = $id;

 				// for supplier

-				if (get_class($this) == 'Fournisseur') $this->cond_reglement_supplier_id = $id;

+				if (get_class($this) == 'Fournisseur') {
+				    $this->cond_reglement_supplier_id = $id;
+				}
 				$this->cond_reglement = $id;	// for compatibility

 				return 1;

-			}

-			else

+			} else

 			{

 				dol_syslog(get_class($this).'::setPaymentTerms Erreur '.$sql.' - '.$this->db->error());

 				$this->error=$this->db->error();

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_syslog(get_class($this).'::setPaymentTerms, status of the object is incompatible');

 			$this->error='Status of the object is incompatible '.$this->statut;

@@ -1973,7 +2163,9 @@ 
 	function setDeliveryAddress($id)

 	{

 		$fieldname = 'fk_delivery_address';

-		if ($this->element == 'delivery' || $this->element == 'shipping') $fieldname = 'fk_address';

+		if ($this->element == 'delivery' || $this->element == 'shipping') {
+		    $fieldname = 'fk_address';
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element." SET ".$fieldname." = ".$id;

 		$sql.= " WHERE rowid = ".$this->id." AND fk_statut = 0";

@@ -1982,8 +2174,7 @@ 
 		{

 			$this->fk_delivery_address = $id;

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			dol_syslog(get_class($this).'::setDeliveryAddress Erreur '.$sql.' - '.$this->error);

@@ -2005,7 +2196,9 @@ 
 	{

         global $user;

 

-        if (empty($userused)) $userused=$user;

+        if (empty($userused)) {
+            $userused=$user;
+        }
 

         $error = 0;

 

@@ -2016,7 +2209,9 @@ 
 

         $this->db->begin();

 

-		if ($shipping_method_id<0) $shipping_method_id='NULL';

+		if ($shipping_method_id<0) {
+		    $shipping_method_id='NULL';
+		}
 		dol_syslog(get_class($this).'::setShippingMethod('.$shipping_method_id.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

@@ -2033,7 +2228,9 @@ 
                 // Call trigger

                 $this->context=array('shippingmethodupdate'=>1);

                 $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

-                if ($result < 0) $error++;

+                if ($result < 0) {
+                    $error++;
+                }
                 // End call trigger

             }

         }

@@ -2061,7 +2258,9 @@ 
 			dol_syslog(get_class($this)."::setWarehouse was called on objet with property table_element not defined",LOG_ERR);

 			return -1;

 		}

-		if ($warehouse_id<0) $warehouse_id='NULL';

+		if ($warehouse_id<0) {
+		    $warehouse_id='NULL';
+		}
 		dol_syslog(get_class($this).'::setWarehouse('.$warehouse_id.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

@@ -2108,8 +2307,7 @@ 
 		{

 			$this->modelpdf=$modelpdf;

 			return 1;

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db);

 			return 0;

@@ -2129,7 +2327,9 @@ 
 	{

         global $user;

 

-        if (empty($userused)) $userused=$user;

+        if (empty($userused)) {
+            $userused=$user;
+        }
 

         $error = 0;

 

@@ -2139,7 +2339,9 @@ 
 		}

         $this->db->begin();

 

-		if ($fk_account<0) $fk_account='NULL';

+		if ($fk_account<0) {
+		    $fk_account='NULL';
+		}
 		dol_syslog(get_class($this).'::setBankAccount('.$fk_account.')');

 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$this->table_element;

@@ -2152,15 +2354,16 @@ 
             dol_syslog(get_class($this).'::setBankAccount Error '.$sql.' - '.$this->db->error());

             $this->error = $this->db->lasterror();

             $error++;

-        }

-        else

+        } else

         {

             if (!$notrigger)

             {

                 // Call trigger

                 $this->context=array('bankaccountupdate'=>1);

                 $result = $this->call_trigger(strtoupper(get_class($this)) . '_MODIFY', $userused);

-                if ($result < 0) $error++;

+                if ($result < 0) {
+                    $error++;
+                }
                 // End call trigger

             }

         }

@@ -2168,8 +2371,7 @@ 
         {

             $this->db->rollback();

             return -1;

-        }

-        else

+        } else

         {

             $this->fk_account = ($fk_account=='NULL')?null:$fk_account;

             $this->db->commit();

@@ -2208,8 +2410,12 @@ 
 		$nl=0;

 		$sql = 'SELECT count(rowid) FROM '.MAIN_DB_PREFIX.$this->table_element_line;

 		$sql.= ' WHERE '.$this->fk_element.'='.$this->id;

-		if (! $renum) $sql.= ' AND rang = 0';

-		if ($renum) $sql.= ' AND rang <> 0';

+		if (! $renum) {
+		    $sql.= ' AND rang = 0';
+		}
+		if ($renum) {
+		    $sql.= ' AND rang <> 0';
+		}
 

 		dol_syslog(get_class($this)."::line_order", LOG_DEBUG);

 		$resql = $this->db->query($sql);

@@ -2217,8 +2423,9 @@ 
 		{

 			$row = $this->db->fetch_row($resql);

 			$nl = $row[0];

-		}

-		else dol_print_error($this->db);

+		} else {
+		    dol_print_error($this->db);
+		}
 		if ($nl > 0)

 		{

 			// The goal of this part is to reorder all lines, with all children lines sharing the same

@@ -2228,7 +2435,9 @@ 
 			// We first search all lines that are parent lines (for multilevel details lines)

 			$sql = 'SELECT rowid FROM '.MAIN_DB_PREFIX.$this->table_element_line;

 			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

-			if ($fk_parent_line) $sql.= ' AND fk_parent_line IS NULL';

+			if ($fk_parent_line) {
+			    $sql.= ' AND fk_parent_line IS NULL';
+			}
 			$sql.= ' ORDER BY rang ASC, rowid '.$rowidorder;

 

 			dol_syslog(get_class($this)."::line_order search all parent lines", LOG_DEBUG);

@@ -2260,8 +2469,7 @@ 
 						$this->updateRangOfLine($row, ($key+1));

 					}

 				}

-			}

-			else

+			} else

 			{

 				dol_print_error($this->db);

 			}

@@ -2354,7 +2562,9 @@ 
 	function updateRangOfLine($rowid,$rang)

 	{

 		$fieldposition = 'rang';

-		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+		if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) {
+		    $fieldposition = 'position';
+		}
 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

 		$sql.= ' WHERE rowid = '.$rowid;

@@ -2395,7 +2605,9 @@ 
 		if ($rang > 1)

 		{

 			$fieldposition = 'rang';

-			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) {
+			    $fieldposition = 'position';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang ;

 			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

@@ -2408,8 +2620,7 @@ 
 				{

 					dol_print_error($this->db);

 				}

-			}

-			else

+			} else

 			{

 				dol_print_error($this->db);

 			}

@@ -2429,7 +2640,9 @@ 
 		if ($rang < $max)

 		{

 			$fieldposition = 'rang';

-			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) $fieldposition = 'position';

+			if (in_array($this->table_element_line, array('ecm_files', 'emailcollector_emailcollectoraction'))) {
+			    $fieldposition = 'position';
+			}
 

 			$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element_line.' SET '.$fieldposition.' = '.$rang;

 			$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

@@ -2442,8 +2655,7 @@ 
 				{

 					dol_print_error($this->db);

 				}

-			}

-			else

+			} else

 			{

 				dol_print_error($this->db);

 			}

@@ -2514,8 +2726,7 @@ 
 				if (! empty($row[0]))

 				{

 					return $row[0];

-				}

-				else

+				} else

 				{

 					return $this->getRangOfLine($fk_parent_line);

 				}

@@ -2562,8 +2773,7 @@ 
 		{

 			$this->ref_ext = $ref_ext;

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->error();

 			return -1;

@@ -2597,7 +2807,9 @@ 
 		}

 		// Special cas

 		//var_dump($this->table_element);exit;

-		if ($this->table_element == 'product') $suffix='';

+		if ($this->table_element == 'product') {
+		    $suffix='';
+		}
 

 		$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element;

 		$sql.= " SET note".$suffix." = ".(!empty($note)?("'".$this->db->escape($note)."'"):"NULL");

@@ -2607,16 +2819,17 @@ 
 		dol_syslog(get_class($this)."::update_note", LOG_DEBUG);

 		if ($this->db->query($sql))

 		{

-			if ($suffix == '_public') $this->note_public = $note;

-			else if ($suffix == '_private') $this->note_private = $note;

-			else

+			if ($suffix == '_public') {
+			    $this->note_public = $note;
+			} else if ($suffix == '_private') {
+			    $this->note_private = $note;
+			} else

 			{

 				$this->note = $note;      // deprecated

 				$this->note_private = $note;

 			}

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -2656,37 +2869,45 @@ 
 

 		// Some external module want no update price after a trigger because they have another method to calculate the total (ex: with an extrafield)

 		$MODULE = "";

-		if ($this->element == 'propal')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_PROPOSAL";

-		elseif ($this->element == 'order')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_ORDER";

-		elseif ($this->element == 'facture')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_INVOICE";

-		elseif ($this->element == 'facture_fourn')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_INVOICE";

-		elseif ($this->element == 'order_supplier')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_ORDER";

-		elseif ($this->element == 'supplier_proposal')

-			$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";

+		if ($this->element == 'propal') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_PROPOSAL";
+		} elseif ($this->element == 'order') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_ORDER";
+		} elseif ($this->element == 'facture') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_INVOICE";
+		} elseif ($this->element == 'facture_fourn') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_INVOICE";
+		} elseif ($this->element == 'order_supplier') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_ORDER";
+		} elseif ($this->element == 'supplier_proposal') {
+					$MODULE = "MODULE_DISALLOW_UPDATE_PRICE_SUPPLIER_PROPOSAL";
+		}
 

 		if (! empty($MODULE)) {

 			if (!empty(Globals::$conf->global->$MODULE)) {

                 $modsactivated = explode(',', Globals::$conf->global->$MODULE);

                 foreach ($modsactivated as $mod) {

-					if (Globals::$conf->$mod->enabled)

-                        return 1; // update was disabled by specific setup

+					if (Globals::$conf->$mod->enabled) {
+					                        return 1;
+					}
+					// update was disabled by specific setup

 				}

 			}

 		}

 

 		include_once DOL_DOCUMENT_ROOT.'/core/lib/price.lib.php';

 

-		if ($roundingadjust == '-1') $roundingadjust='auto';	// For backward compatibility

+		if ($roundingadjust == '-1') {
+		    $roundingadjust='auto';
+		}
+		// For backward compatibility

 

 		$forcedroundingmode=$roundingadjust;

-		if ($forcedroundingmode == 'auto' && isset(Globals::$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND))

-            $forcedroundingmode = Globals::$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;

-        elseif ($forcedroundingmode == 'auto') $forcedroundingmode='0';

+		if ($forcedroundingmode == 'auto' && isset(Globals::$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND)) {
+		            $forcedroundingmode = Globals::$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND;
+		} elseif ($forcedroundingmode == 'auto') {
+            $forcedroundingmode='0';
+        }
 

 		$error=0;

 

@@ -2709,15 +2930,22 @@ 
 

 		$sql = 'SELECT rowid, qty, '.$fieldup.' as up, remise_percent, total_ht, '.$fieldtva.' as total_tva, total_ttc, '.$fieldlocaltax1.' as total_localtax1, '.$fieldlocaltax2.' as total_localtax2,';

 		$sql.= ' tva_tx as vatrate, localtax1_tx, localtax2_tx, localtax1_type, localtax2_type, info_bits, product_type';

-			if ($this->table_element_line == 'facturedet') $sql.= ', situation_percent';

+			if ($this->table_element_line == 'facturedet') {
+			    $sql.= ', situation_percent';
+			}
 			$sql.= ', multicurrency_total_ht, multicurrency_total_tva, multicurrency_total_ttc';

 		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element_line;

 		$sql.= ' WHERE '.$this->fk_element.' = '.$this->id;

 		if ($exclspec)

 		{

 			$product_field='product_type';

-			if ($this->table_element_line == 'contratdet') $product_field='';    // contratdet table has no product_type field

-			if ($product_field) $sql.= ' AND '.$product_field.' <> 9';

+			if ($this->table_element_line == 'contratdet') {
+			    $product_field='';
+			}
+			// contratdet table has no product_type field

+			if ($product_field) {
+			    $sql.= ' AND '.$product_field.' <> 9';
+			}
 		}

 		$sql.= ' ORDER by rowid';	// We want to be sure to always use same order of line to not change lines differently when option MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND is used

 

@@ -2747,9 +2975,11 @@ 
 				$parameters=array('fk_element' => $obj->rowid);

 				$reshook = $hookmanager->executeHooks('changeRoundingMode', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks

 

-				if (empty($reshook) && $forcedroundingmode == '0')	// Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

+				if (empty($reshook) && $forcedroundingmode == '0') {
+				    // Check if data on line are consistent. This may solve lines that were not consistent because set with $forcedroundingmode='auto'

 				{

-					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);

+					$localtax_array=array($obj->localtax1_type,$obj->localtax1_tx,$obj->localtax2_type,$obj->localtax2_tx);
+				}
 					$tmpcal=calcul_price_total($obj->qty, $obj->up, $obj->remise_percent, $obj->vatrate, $obj->localtax1_tx, $obj->localtax2_tx, 0, 'HT', $obj->info_bits, $obj->product_type, $seller, $localtax_array, (isset($obj->situation_percent) ? $obj->situation_percent : 100), $multicurrency_tx);

 					$diff=price2num($tmpcal[1] - $obj->total_tva, 'MT', 1);

 					if ($diff)

@@ -2757,7 +2987,9 @@ 
 						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".$tmpcal[1].", total_ttc = ".$tmpcal[2]." WHERE rowid = ".$obj->rowid;

 						dol_syslog('We found unconsistent data into detailed line (difference of '.$diff.') for line rowid = '.$obj->rowid." (total vat of line calculated=".$tmpcal[1].", database=".$obj->total_tva."). We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

 								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+								if (! $resqlfix) {
+								    dol_print_error($this->db,'Failed to update line');
+								}
 								$obj->total_tva = $tmpcal[1];

 								$obj->total_ttc = $tmpcal[2];

 						//

@@ -2773,16 +3005,24 @@ 
 				$this->multicurrency_total_tva       += $obj->multicurrency_total_tva;

 				$this->multicurrency_total_ttc       += $obj->multicurrency_total_ttc;

 

-				if (! isset($total_ht_by_vats[$obj->vatrate]))  $total_ht_by_vats[$obj->vatrate]=0;

-				if (! isset($total_tva_by_vats[$obj->vatrate])) $total_tva_by_vats[$obj->vatrate]=0;

-				if (! isset($total_ttc_by_vats[$obj->vatrate])) $total_ttc_by_vats[$obj->vatrate]=0;

+				if (! isset($total_ht_by_vats[$obj->vatrate])) {
+				    $total_ht_by_vats[$obj->vatrate]=0;
+				}
+				if (! isset($total_tva_by_vats[$obj->vatrate])) {
+				    $total_tva_by_vats[$obj->vatrate]=0;
+				}
+				if (! isset($total_ttc_by_vats[$obj->vatrate])) {
+				    $total_ttc_by_vats[$obj->vatrate]=0;
+				}
 				$total_ht_by_vats[$obj->vatrate]  += $obj->total_ht;

 				$total_tva_by_vats[$obj->vatrate] += $obj->total_tva;

 				$total_ttc_by_vats[$obj->vatrate] += $obj->total_ttc;

 

-				if ($forcedroundingmode == '1')	// Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

+				if ($forcedroundingmode == '1') {
+				    // Check if we need adjustement onto line for vat. TODO This works on the company currency but not on multicurrency

 				{

-					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);

+					$tmpvat=price2num($total_ht_by_vats[$obj->vatrate] * $obj->vatrate / 100, 'MT', 1);
+				}
 					$diff=price2num($total_tva_by_vats[$obj->vatrate]-$tmpvat, 'MT', 1);

 					//print 'Line '.$i.' rowid='.$obj->rowid.' vat_rate='.$obj->vatrate.' total_ht='.$obj->total_ht.' total_tva='.$obj->total_tva.' total_ttc='.$obj->total_ttc.' total_ht_by_vats='.$total_ht_by_vats[$obj->vatrate].' total_tva_by_vats='.$total_tva_by_vats[$obj->vatrate].' (new calculation = '.$tmpvat.') total_ttc_by_vats='.$total_ttc_by_vats[$obj->vatrate].($diff?" => DIFF":"")."<br>\n";

 					if ($diff)

@@ -2791,7 +3031,9 @@ 
 						$sqlfix="UPDATE ".MAIN_DB_PREFIX.$this->table_element_line." SET ".$fieldtva." = ".($obj->total_tva - $diff).", total_ttc = ".($obj->total_ttc - $diff)." WHERE rowid = ".$obj->rowid;

 						dol_syslog('We found a difference of '.$diff.' for line rowid = '.$obj->rowid.". We fix the total_vat and total_ttc of line by running sqlfix = ".$sqlfix);

 								$resqlfix=$this->db->query($sqlfix);

-								if (! $resqlfix) dol_print_error($this->db,'Failed to update line');

+								if (! $resqlfix) {
+								    dol_print_error($this->db,'Failed to update line');
+								}
 								$this->total_tva -= $diff;

 								$this->total_ttc -= $diff;

 								$total_tva_by_vats[$obj->vatrate] -= $diff;

@@ -2832,11 +3074,21 @@ 
 			$fieldlocaltax2='localtax2';

 			$fieldttc='total_ttc';

 			// Specific code for backward compatibility with old field names

-			if ($this->element == 'facture' || $this->element == 'facturerec')             $fieldht='total';

-			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') $fieldtva='total_tva';

-			if ($this->element == 'propal')                                                $fieldttc='total';

-			if ($this->element == 'expensereport')                                         $fieldtva='total_tva';

-			if ($this->element == 'supplier_proposal')                                     $fieldttc='total';

+			if ($this->element == 'facture' || $this->element == 'facturerec') {
+			    $fieldht='total';
+			}
+			if ($this->element == 'facture_fourn' || $this->element == 'invoice_supplier') {
+			    $fieldtva='total_tva';
+			}
+			if ($this->element == 'propal') {
+			    $fieldttc='total';
+			}
+			if ($this->element == 'expensereport') {
+			    $fieldtva='total_tva';
+			}
+			if ($this->element == 'supplier_proposal') {
+			    $fieldttc='total';
+			}
 

 			if (empty($nodatabaseupdate))

 			{

@@ -2865,13 +3117,11 @@ 
 			if (! $error)

 			{

 				return 1;

-			}

-			else

+			} else

 			{

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db,'Bad request in update_price');

 			return -1;

@@ -2894,10 +3144,18 @@ 
 		$origin_id = (! empty($origin_id) ? $origin_id : $this->origin_id);

 

 		// Special case

-		if ($origin == 'order') $origin='commande';

-		if ($origin == 'invoice') $origin='facture';

-		if ($origin == 'invoice_template') $origin='facturerec';

-    	if ($origin == 'supplierorder') $origin='order_supplier';

+		if ($origin == 'order') {
+		    $origin='commande';
+		}
+		if ($origin == 'invoice') {
+		    $origin='facture';
+		}
+		if ($origin == 'invoice_template') {
+		    $origin='facturerec';
+		}
+    	if ($origin == 'supplierorder') {
+    	    $origin='order_supplier';
+    	}
 		$this->db->begin();

 

 		$sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";

@@ -2917,8 +3175,7 @@ 
 	  	{

 	  		$this->db->commit();

 	  		return 1;

-	  	}

-	  	else

+	  	} else

 	  	{

 	  		$this->error=$this->db->lasterror();

 	  		$this->db->rollback();

@@ -2963,12 +3220,16 @@ 
 		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid))

 		{

 			$justsource=true;  // the source (id and type) is a search criteria

-			if (! empty($targettype)) $withtargettype=true;

+			if (! empty($targettype)) {
+			    $withtargettype=true;
+			}
 		}

 		if (! empty($targetid) && ! empty($targettype) && empty($sourceid))

 		{

 			$justtarget=true;  // the target (id and type) is a search criteria

-			if (! empty($sourcetype)) $withsourcetype=true;

+			if (! empty($sourcetype)) {
+			    $withsourcetype=true;
+			}
 		}

 

 		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

@@ -2991,15 +3252,17 @@ 
 			if ($justsource)

 			{

 				$sql.= "fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."'";

-				if ($withtargettype) $sql.= " AND targettype = '".$targettype."'";

-			}

-			else if ($justtarget)

+				if ($withtargettype) {
+				    $sql.= " AND targettype = '".$targettype."'";
+				}
+			} else if ($justtarget)

 			{

 				$sql.= "fk_target = ".$targetid." AND targettype = '".$targettype."'";

-				if ($withsourcetype) $sql.= " AND sourcetype = '".$sourcetype."'";

+				if ($withsourcetype) {
+				    $sql.= " AND sourcetype = '".$sourcetype."'";
+				}
 			}

-		}

-		else

+		} else

 		{

 			$sql.= "(fk_source = ".$sourceid." AND sourcetype = '".$sourcetype."')";

 			$sql.= " ".$clause." (fk_target = ".$targetid." AND targettype = '".$targettype."')";

@@ -3020,13 +3283,11 @@ 
 					if ($justsource)

 					{

 						$this->linkedObjectsIds[$obj->targettype][$obj->rowid]=$obj->fk_target;

-					}

-					else if ($justtarget)

+					} else if ($justtarget)

 					{

 						$this->linkedObjectsIds[$obj->sourcetype][$obj->rowid]=$obj->fk_source;

 					}

-				}

-				else

+				} else

 				{

 					if ($obj->fk_source == $sourceid && $obj->sourcetype == $sourcetype)

 					{

@@ -3043,10 +3304,12 @@ 
 			if (! empty($this->linkedObjectsIds))

 			{

 				$tmparray = $this->linkedObjectsIds;

-				foreach($tmparray as $objecttype => $objectids)       // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

+				foreach($tmparray as $objecttype => $objectids) {
+				    // $objecttype is a module name ('facture', 'mymodule', ...) or a module name with a suffix ('project_task', 'mymodule_myobj', ...)

 				{

 					// Parse element/subelement (ex: project_task, cabinetmed_consultation, ...)

-					$module = $element = $subelement = $objecttype;

+					$module = $element = $subelement = $objecttype;
+				}
 					if ($objecttype != 'supplier_proposal' && $objecttype != 'order_supplier' && $objecttype != 'invoice_supplier'

 						&& preg_match('/^([^_]+)_([^_]+)/i',$objecttype,$regs))

 					{

@@ -3058,29 +3321,21 @@ 
 					// To work with non standard classpath or module name

 					if ($objecttype == 'facture')			{

 						$classpath = 'compta/facture/class';

-					}

-					else if ($objecttype == 'facturerec')			{

+					} else if ($objecttype == 'facturerec')			{

 						$classpath = 'compta/facture/class'; $module = 'facture';

-					}

-					else if ($objecttype == 'propal')			{

+					} else if ($objecttype == 'propal')			{

 						$classpath = 'comm/propal/class';

-					}

-					else if ($objecttype == 'supplier_proposal')			{

+					} else if ($objecttype == 'supplier_proposal')			{

 						$classpath = 'supplier_proposal/class';

-					}

-					else if ($objecttype == 'shipping')			{

+					} else if ($objecttype == 'shipping')			{

 						$classpath = 'expedition/class'; $subelement = 'expedition'; $module = 'expedition_bon';

-					}

-					else if ($objecttype == 'delivery')			{

+					} else if ($objecttype == 'delivery')			{

 						$classpath = 'livraison/class'; $subelement = 'livraison'; $module = 'livraison_bon';

-					}

-					else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

+					} else if ($objecttype == 'invoice_supplier' || $objecttype == 'order_supplier')	{

 						$classpath = 'fourn/class'; $module = 'fournisseur';

-					}

-					else if ($objecttype == 'fichinter')			{

+					} else if ($objecttype == 'fichinter')			{

 						$classpath = 'fichinter/class'; $subelement = 'fichinter'; $module = 'ficheinter';

-					}

-					else if ($objecttype == 'subscription')			{

+					} else if ($objecttype == 'subscription')			{

 						$classpath = 'adherents/class'; $module = 'adherent';

 					}

 

@@ -3089,20 +3344,15 @@ 
 

 					if ($objecttype == 'order') {

 						$classfile = 'commande'; $classname = 'Commande';

-					}

-					else if ($objecttype == 'invoice_supplier') {

+					} else if ($objecttype == 'invoice_supplier') {

 						$classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';

-					}

-					else if ($objecttype == 'order_supplier')   {

+					} else if ($objecttype == 'order_supplier')   {

 						$classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';

-					}

-					else if ($objecttype == 'supplier_proposal')   {

+					} else if ($objecttype == 'supplier_proposal')   {

 						$classfile = 'supplier_proposal'; $classname = 'SupplierProposal';

-					}

-					else if ($objecttype == 'facturerec')   {

+					} else if ($objecttype == 'facturerec')   {

 						$classfile = 'facture-rec'; $classname = 'FactureRec';

-					}

-					else if ($objecttype == 'subscription')   {

+					} else if ($objecttype == 'subscription')   {

 						$classfile = 'subscription'; $classname = 'Subscription';

 					}

 

@@ -3114,9 +3364,11 @@ 
 							//print '/'.$classpath.'/'.$classfile.'.class.php '.class_exists($classname);

 							if (class_exists($classname))

 							{

-								foreach($objectids as $i => $objectid)	// $i is rowid into llx_element_element

+								foreach($objectids as $i => $objectid) {
+								    // $i is rowid into llx_element_element

 								{

-									$object = new $classname($this->db);

+									$object = new $classname($this->db);
+								}
 									$ret = $object->fetch($objectid);

 									if ($ret >= 0)

 									{

@@ -3125,16 +3377,14 @@ 
 								}

 							}

 						}

-					}

-					else

+					} else

 					{

 						unset($this->linkedObjectsIds[$objecttype]);

 					}

 				}

 			}

 			return 1;

-		}

-		else

+		} else

 		{

 			dol_print_error($this->db);

 			return -1;

@@ -3156,8 +3406,11 @@ 
 		$updatesource=false;

 		$updatetarget=false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $updatesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $updatetarget=true;

+		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) {
+		    $updatesource=true;
+		} else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) {
+		    $updatetarget=true;
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX."element_element SET ";

 		if ($updatesource)

@@ -3166,8 +3419,7 @@ 
 			$sql.= ", sourcetype = '".$this->db->escape($sourcetype)."'";

 			$sql.= " WHERE fk_target = ".$this->id;

 			$sql.= " AND targettype = '".$this->db->escape($this->element)."'";

-		}

-		else if ($updatetarget)

+		} else if ($updatetarget)

 		{

 			$sql.= "fk_target = ".$targetid;

 			$sql.= ", targettype = '".$this->db->escape($targettype)."'";

@@ -3179,8 +3431,7 @@ 
 		if ($this->db->query($sql))

 		{

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			return -1;

@@ -3203,8 +3454,11 @@ 
 		$deletesource=false;

 		$deletetarget=false;

 

-		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) $deletesource=true;

-		else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) $deletetarget=true;

+		if (! empty($sourceid) && ! empty($sourcetype) && empty($targetid) && empty($targettype)) {
+		    $deletesource=true;
+		} else if (empty($sourceid) && empty($sourcetype) && ! empty($targetid) && ! empty($targettype)) {
+		    $deletetarget=true;
+		}
 

 		$sourceid = (! empty($sourceid) ? $sourceid : $this->id);

 		$sourcetype = (! empty($sourcetype) ? $sourcetype : $this->element);

@@ -3216,20 +3470,17 @@ 
 		if ($rowid > 0)

 		{

 			$sql.=" rowid = ".$rowid;

-		}

-		else

+		} else

 		{

 			if ($deletesource)

 			{

 				$sql.= " fk_source = ".$sourceid." AND sourcetype = '".$this->db->escape($sourcetype)."'";

 				$sql.= " AND fk_target = ".$this->id." AND targettype = '".$this->db->escape($this->element)."'";

-			}

-			else if ($deletetarget)

+			} else if ($deletetarget)

 			{

 				$sql.= " fk_target = ".$targetid." AND targettype = '".$this->db->escape($targettype)."'";

 				$sql.= " AND fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."'";

-			}

-			else

+			} else

 			{

 				$sql.= " (fk_source = ".$this->id." AND sourcetype = '".$this->db->escape($this->element)."')";

 				$sql.= " OR";

@@ -3241,8 +3492,7 @@ 
 		if ($this->db->query($sql))

 		{

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->errors[]=$this->error;

@@ -3271,17 +3521,31 @@ 
 		$this->db->begin();

 

 		$fieldstatus="fk_statut";

-		if ($elementTable == 'facture_rec') $fieldstatus="suspended";

-		if ($elementTable == 'mailing') $fieldstatus="statut";

-		if ($elementTable == 'cronjob') $fieldstatus="status";

-		if ($elementTable == 'user') $fieldstatus="statut";

-		if ($elementTable == 'expensereport') $fieldstatus="fk_statut";

-		if ($elementTable == 'commande_fournisseur_dispatch') $fieldstatus="status";

+		if ($elementTable == 'facture_rec') {
+		    $fieldstatus="suspended";
+		}
+		if ($elementTable == 'mailing') {
+		    $fieldstatus="statut";
+		}
+		if ($elementTable == 'cronjob') {
+		    $fieldstatus="status";
+		}
+		if ($elementTable == 'user') {
+		    $fieldstatus="statut";
+		}
+		if ($elementTable == 'expensereport') {
+		    $fieldstatus="fk_statut";
+		}
+		if ($elementTable == 'commande_fournisseur_dispatch') {
+		    $fieldstatus="status";
+		}
 

 		$sql = "UPDATE ".MAIN_DB_PREFIX.$elementTable;

 		$sql.= " SET ".$fieldstatus." = ".$status;

 		// If status = 1 = validated, update also fk_user_valid

-		if ($status == 1 && $elementTable == 'expensereport') $sql.=", fk_user_valid = ".$user->id;

+		if ($status == 1 && $elementTable == 'expensereport') {
+		    $sql.=", fk_user_valid = ".$user->id;
+		}
 		$sql.= " WHERE rowid=".$elementId;

 

 		dol_syslog(get_class($this)."::setStatut", LOG_DEBUG);

@@ -3292,12 +3556,27 @@ 
 			// Try autoset of trigkey

 			if (empty($trigkey))

 			{

-				if ($this->element == 'supplier_proposal' && $status == 2) $trigkey='SUPPLIER_PROPOSAL_SIGN';   // 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 3) $trigkey='SUPPLIER_PROPOSAL_REFUSE'; // 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

-				if ($this->element == 'supplier_proposal' && $status == 4) $trigkey='SUPPLIER_PROPOSAL_CLOSE';  // 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

-				if ($this->element == 'fichinter' && $status == 3) $trigkey='FICHINTER_CLASSIFY_DONE';

-				if ($this->element == 'fichinter' && $status == 2) $trigkey='FICHINTER_CLASSIFY_BILLED';

-				if ($this->element == 'fichinter' && $status == 1) $trigkey='FICHINTER_CLASSIFY_UNBILLED';

+				if ($this->element == 'supplier_proposal' && $status == 2) {
+				    $trigkey='SUPPLIER_PROPOSAL_SIGN';
+				}
+				// 2 = SupplierProposal::STATUS_SIGNED. Can't use constant into this generic class

+				if ($this->element == 'supplier_proposal' && $status == 3) {
+				    $trigkey='SUPPLIER_PROPOSAL_REFUSE';
+				}
+				// 3 = SupplierProposal::STATUS_REFUSED. Can't use constant into this generic class

+				if ($this->element == 'supplier_proposal' && $status == 4) {
+				    $trigkey='SUPPLIER_PROPOSAL_CLOSE';
+				}
+				// 4 = SupplierProposal::STATUS_CLOSED. Can't use constant into this generic class

+				if ($this->element == 'fichinter' && $status == 3) {
+				    $trigkey='FICHINTER_CLASSIFY_DONE';
+				}
+				if ($this->element == 'fichinter' && $status == 2) {
+				    $trigkey='FICHINTER_CLASSIFY_BILLED';
+				}
+				if ($this->element == 'fichinter' && $status == 1) {
+				    $trigkey='FICHINTER_CLASSIFY_UNBILLED';
+				}
 			}

 

 			if ($trigkey)

@@ -3316,22 +3595,22 @@ 
 			{

 				$this->db->commit();

 

-				if (empty($savElementId))    // If the element we update was $this (so $elementId is null)

+				if (empty($savElementId)) {
+				    // If the element we update was $this (so $elementId is null)

 				{

-					$this->statut = $status;

+					$this->statut = $status;
+				}
 					$this->status = $status;

 				}

 

 				return 1;

-			}

-			else

+			} else

 			{

 				$this->db->rollback();

 				dol_syslog(get_class($this)."::setStatus ".$this->error,LOG_ERR);

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -3351,9 +3630,13 @@ 
 	{

 		global $conf;

 

-		if (empty($id) && empty($ref)) return 0;

-		if (!empty(Globals::$conf->global->MAIN_DISABLE_CANVAS))

-            return 0;    // To increase speed. Not enabled by default.

+		if (empty($id) && empty($ref)) {
+		    return 0;
+		}
+		if (!empty(Globals::$conf->global->MAIN_DISABLE_CANVAS)) {
+		            return 0;
+		}
+		// To increase speed. Not enabled by default.

 

             // Clean parameters

 		$ref = trim($ref);

@@ -3361,8 +3644,12 @@ 
 		$sql = "SELECT rowid, canvas";

 		$sql.= " FROM ".MAIN_DB_PREFIX.$this->table_element;

 		$sql.= " WHERE entity IN (".getEntity($this->element).")";

-		if (! empty($id))  $sql.= " AND rowid = ".$id;

-		if (! empty($ref)) $sql.= " AND ref = '".$this->db->escape($ref)."'";

+		if (! empty($id)) {
+		    $sql.= " AND rowid = ".$id;
+		}
+		if (! empty($ref)) {
+		    $sql.= " AND ref = '".$this->db->escape($ref)."'";
+		}
 

 		$resql = $this->db->query($sql);

 		if ($resql)

@@ -3372,10 +3659,10 @@ 
 			{

 				$this->canvas   = $obj->canvas;

 				return 1;

-			}

-			else return 0;

-		}

-		else

+			} else {
+			    return 0;
+			}
+		} else

 		{

 			dol_print_error($this->db);

 			return -1;

@@ -3412,7 +3699,9 @@ 
 	{

 		global $langs;

 

-		if (empty($id)) $id=$this->id;

+		if (empty($id)) {
+		    $id=$this->id;
+		}
 

 		// Check parameters

 		if (! isset($this->childtables) || ! is_array($this->childtables) || count($this->childtables) == 0)

@@ -3446,18 +3735,18 @@ 
 					$langs->load("errors");

 					//print 'Found into table '.$table.', type '.$langs->transnoentitiesnoconv($elementname).', haschild='.$haschild;

 					$haschild += $obj->nb;

-					if (is_numeric($elementname))	// old usage

+					if (is_numeric($elementname)) {
+					    // old usage

 					{

-						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);

-					}

-					else	// new usage: $elementname=Translation key

+						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $table);
+					}
+					} else	// new usage: $elementname=Translation key

 					{

 						$this->errors[]=$langs->trans("ErrorRecordHasAtLeastOneChildOfType", $langs->transnoentitiesnoconv($elementname));

 					}

 					break;    // We found at least one, we stop here

 				}

-			}

-			else

+			} else

 			{

 				$this->errors[]=$this->db->lasterror();

 				return -1;

@@ -3467,8 +3756,9 @@ 
 		{

 			$this->errors[]="ErrorRecordHasChildren";

 			return $haschild;

-		}

-		else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

 	/**

@@ -3484,12 +3774,24 @@ 
 		foreach($this->lines as $key => $val)

 		{

 			$qualified=0;

-			if ($predefined == -1) $qualified=1;

-			if ($predefined == 1 && $val->fk_product > 0) $qualified=1;

-			if ($predefined == 0 && $val->fk_product <= 0) $qualified=1;

-			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) $qualified=1;

-			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) $qualified=1;

-			if ($qualified) $nb++;

+			if ($predefined == -1) {
+			    $qualified=1;
+			}
+			if ($predefined == 1 && $val->fk_product > 0) {
+			    $qualified=1;
+			}
+			if ($predefined == 0 && $val->fk_product <= 0) {
+			    $qualified=1;
+			}
+			if ($predefined == 2 && $val->fk_product > 0 && $val->product_type==0) {
+			    $qualified=1;
+			}
+			if ($predefined == 3 && $val->fk_product > 0 && $val->product_type==1) {
+			    $qualified=1;
+			}
+			if ($qualified) {
+			    $nb++;
+			}
 		}

 		dol_syslog(get_class($this).'::hasProductsOrServices we found '.$nb.' qualified lines of products/servcies');

 		return $nb;

@@ -3553,16 +3855,24 @@ 
 		{

 			if (isset($line->qty_asked))

 			{

-				if (empty($totalOrdered)) $totalOrdered=0;  // Avoid warning because $totalOrdered is ''

+				if (empty($totalOrdered)) {
+				    $totalOrdered=0;
+				}
+				// Avoid warning because $totalOrdered is ''

 				$totalOrdered+=$line->qty_asked;    // defined for shipment only

 			}

 			if (isset($line->qty_shipped))

 			{

-				if (empty($totalToShip)) $totalToShip=0;    // Avoid warning because $totalToShip is ''

+				if (empty($totalToShip)) {
+				    $totalToShip=0;
+				}
+				// Avoid warning because $totalToShip is ''

 				$totalToShip+=$line->qty_shipped;   // defined for shipment only

-            }else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

+            } else if ($line->element == 'commandefournisseurdispatch' && isset($line->qty))

             {

-                if (empty($totalToShip)) $totalToShip=0;

+                if (empty($totalToShip)) {
+                    $totalToShip=0;
+                }
                 $totalToShip+=$line->qty;   // defined for reception only

 			}

 

@@ -3570,8 +3880,7 @@ 
 			if ($this->element == 'shipping') {

 				// for shipments

 				$qty = $line->qty_shipped ? $line->qty_shipped : 0;

-			}

-			else {

+			} else {

 				$qty = $line->qty ? $line->qty : 0;

 			}

 

@@ -3587,19 +3896,30 @@ 
 

 			$weightUnit=0;

 			$volumeUnit=0;

-			if (! empty($weight_units)) $weightUnit = $weight_units;

-			if (! empty($volume_units)) $volumeUnit = $volume_units;

-

-			if (empty($totalWeight)) $totalWeight=0;  // Avoid warning because $totalWeight is ''

-			if (empty($totalVolume)) $totalVolume=0;  // Avoid warning because $totalVolume is ''

+			if (! empty($weight_units)) {
+			    $weightUnit = $weight_units;
+			}
+			if (! empty($volume_units)) {
+			    $volumeUnit = $volume_units;
+			}
+

+			if (empty($totalWeight)) {
+			    $totalWeight=0;
+			}
+			// Avoid warning because $totalWeight is ''

+			if (empty($totalVolume)) {
+			    $totalVolume=0;
+			}
+			// Avoid warning because $totalVolume is ''

 

 			//var_dump($line->volume_units);

-			if ($weight_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

+			if ($weight_units < 50) {
+			    // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

 			{

-				$trueWeightUnit=pow(10, $weightUnit);

+				$trueWeightUnit=pow(10, $weightUnit);
+			}
 				$totalWeight += $weight * $qty * $trueWeightUnit;

-			}

-			else {

+			} else {

 		if ($weight_units == 99) {

 			// conversion 1 Pound = 0.45359237 KG

 			$trueWeightUnit = 0.45359237;

@@ -3608,18 +3928,20 @@ 
 			// conversion 1 Ounce = 0.0283495 KG

 			$trueWeightUnit = 0.0283495;

 			$totalWeight += $weight * $qty * $trueWeightUnit;

-		}

-		else

-					$totalWeight += $weight * $qty;   // This may be wrong if we mix different units

+		} else {
+							$totalWeight += $weight * $qty;
+		}
+		// This may be wrong if we mix different units

 			}

-			if ($volume_units < 50)   // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

+			if ($volume_units < 50) {
+			    // >50 means a standard unit (power of 10 of official unit), > 50 means an exotic unit (like inch)

 			{

 				//print $line->volume."x".$line->volume_units."x".($line->volume_units < 50)."x".$volumeUnit;

-				$trueVolumeUnit=pow(10, $volumeUnit);

+				$trueVolumeUnit=pow(10, $volumeUnit);
+			}
 				//print $line->volume;

 				$totalVolume += $volume * $qty * $trueVolumeUnit;

-			}

-			else

+			} else

 			{

 				$totalVolume += $volume * $qty;   // This may be wrong if we mix different units

 			}

@@ -3651,8 +3973,7 @@ 
 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

 			return -1;

-		}

-		else

+		} else

 		{

 			$this->db->commit();

 			return 1;

@@ -3704,13 +4025,11 @@ 
 			{

 				$res = $this->db->fetch_object($resql);

 				return 'Incoterm : '.$res->code.' - '.$this->location_incoterms;

-			}

-			else

+			} else

 			{

 				return '';

 			}

-		}

-		else

+		} else

 		{

 			$this->errors[] = $this->db->lasterror();

 			return false;

@@ -3747,14 +4066,14 @@ 
 					$this->libelle_incoterms = $obj->libelle;

 				}

 				return 1;

-			}

-			else

+			} else

 			{

 				$this->errors[] = $this->db->lasterror();

 				return -1;

 			}

-		}

-		else return -1;

+		} else {
+		    return -1;
+		}
 	}

 

 

@@ -3793,7 +4112,9 @@ 
 			} else {

 				$res=include $tpl; // for debug

 			}

-			if ($res) break;

+			if ($res) {
+			    break;
+			}
 		}

 	}

 

@@ -3823,8 +4144,9 @@ 
 

 		// Define usemargins

 		$usemargins=0;

-		if (!empty(Globals::$conf->margin->enabled) && !empty($this->element) && in_array($this->element, array('facture', 'propal', 'commande')))

-            $usemargins = 1;

+		if (!empty(Globals::$conf->margin->enabled) && !empty($this->element) && in_array($this->element, array('facture', 'propal', 'commande'))) {
+		            $usemargins = 1;
+		}
 

         $num = count($this->lines);

 

@@ -3843,8 +4165,9 @@ 
 			print '<tr class="liste_titre nodrag nodrop">';

 

 			// Adds a line numbering column

-			if (!empty(Globals::$conf->global->MAIN_VIEW_LINE_NUMBER))

-                print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';

+			if (!empty(Globals::$conf->global->MAIN_VIEW_LINE_NUMBER)) {
+			                print '<td class="linecolnum" align="center" width="5">&nbsp;</td>';
+			}
 

             // Description

 			print '<td class="linecoldescription">'.$langs->trans('Description').'</td>';

@@ -3861,10 +4184,13 @@ 
 			print '<td class="linecoluht" align="right" width="80">'.$langs->trans('PriceUHT').'</td>';

 

 			// Multicurrency

-			if (!empty(Globals::$conf->multicurrency->enabled) && $this->multicurrency_code != Globals::$conf->currency)

-                print '<td class="linecoluht_currency" align="right" width="80">' . $langs->trans('PriceUHTCurrency', $this->multicurrency_code) . '</td>';

+			if (!empty(Globals::$conf->multicurrency->enabled) && $this->multicurrency_code != Globals::$conf->currency) {
+			                print '<td class="linecoluht_currency" align="right" width="80">' . $langs->trans('PriceUHTCurrency', $this->multicurrency_code) . '</td>';
+			}
 

-            if ($inputalsopricewithtax) print '<td align="right" width="80">'.$langs->trans('PriceUTTC').'</td>';

+            if ($inputalsopricewithtax) {
+                print '<td align="right" width="80">'.$langs->trans('PriceUTTC').'</td>';
+            }
 

 			// Qty

 			print '<td class="linecolqty" align="right">'.$langs->trans('Qty').'</td>';

@@ -3883,26 +4209,32 @@ 
 			if ($usemargins && !empty(Globals::$conf->margin->enabled) && empty($user->societe_id)) {

 				if (!empty($user->rights->margins->creer))

 				{

-					if (Globals::$conf->global->MARGIN_TYPE == "1")

-                        print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('BuyingPrice').'</td>';

-					else

-						print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';

+					if (Globals::$conf->global->MARGIN_TYPE == "1") {
+					                        print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('BuyingPrice').'</td>';
+					} else {
+											print '<td class="linecolmargin1 margininfos" align="right" width="80">'.$langs->trans('CostPrice').'</td>';
+					}
 				}

 

-				if (!empty(Globals::$conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous)

-                    print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';

-				if (!empty(Globals::$conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous)

-                    print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';

+				if (!empty(Globals::$conf->global->DISPLAY_MARGIN_RATES) && $user->rights->margins->liretous) {
+				                    print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarginRate').'</td>';
+				}
+				if (!empty(Globals::$conf->global->DISPLAY_MARK_RATES) && $user->rights->margins->liretous) {
+				                    print '<td class="linecolmargin2 margininfos" align="right" width="50">'.$langs->trans('MarkRate').'</td>';
+				}
 			}

 

 			// Total HT

 			print '<td class="linecolht" align="right">'.$langs->trans('TotalHTShort').'</td>';

 

 			// Multicurrency

-			if (!empty(Globals::$conf->multicurrency->enabled) && $this->multicurrency_code != Globals::$conf->currency)

-                print '<td class="linecoltotalht_currency" align="right">' . $langs->trans('TotalHTShortCurrency', $this->multicurrency_code) . '</td>';

+			if (!empty(Globals::$conf->multicurrency->enabled) && $this->multicurrency_code != Globals::$conf->currency) {
+			                print '<td class="linecoltotalht_currency" align="right">' . $langs->trans('TotalHTShortCurrency', $this->multicurrency_code) . '</td>';
+			}
 

-            if ($outputalsopricetotalwithtax) print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';

+            if ($outputalsopricetotalwithtax) {
+                print '<td align="right" width="80">'.$langs->trans('TotalTTCShort').'</td>';
+            }
 

 			print '<td class="linecoledit"></td>';  // No width to allow autodim

 

@@ -3932,14 +4264,15 @@ 
 			$line->fetch_optionals();

 

 			//if (is_object($hookmanager) && (($line->product_type == 9 && ! empty($line->special_code)) || ! empty($line->fk_parent_line)))

-			if (is_object($hookmanager))   // Old code is commented on preceding line.

+			if (is_object($hookmanager)) {
+			    // Old code is commented on preceding line.

 			{

 				if (empty($line->fk_parent_line))

 				{

-					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);

+					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline);
+			}
 					$reshook = $hookmanager->executeHooks('printObjectLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

-				}

-				else

+				} else

 				{

 					$parameters = array('line'=>$line,'var'=>$var,'num'=>$num,'i'=>$i,'dateSelector'=>$dateSelector,'seller'=>$seller,'buyer'=>$buyer,'selected'=>$selected, 'extrafieldsline'=>$extrafieldsline, 'fk_parent_line'=>$line->fk_parent_line);

 					$reshook = $hookmanager->executeHooks('printObjectSubLine', $parameters, $this, $action);    // Note that $action and $object may have been modified by some hooks

@@ -3986,8 +4319,14 @@ 
 		// Show product and description

 		$type=(! empty($line->product_type)?$line->product_type:$line->fk_product_type);

 		// Try to enhance type detection using date_start and date_end for free lines where type was not saved.

-		if (! empty($line->date_start)) $type=1; // deprecated

-		if (! empty($line->date_end)) $type=1; // deprecated

+		if (! empty($line->date_start)) {
+		    $type=1;
+		}
+		// deprecated

+		if (! empty($line->date_end)) {
+		    $type=1;
+		}
+		// deprecated

 

 		// Ligne en mode visu

 		if ($action != 'editline' || $selected != $line->id)

@@ -4015,9 +4354,13 @@ 
 

 					$outputlangs = $langs;

 					$newlang='';

-					if (empty($newlang) && GETPOST('lang_id','aZ09')) $newlang=GETPOST('lang_id','aZ09');

-					if (!empty(Globals::$conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang))

-                        $newlang = $this->thirdparty->default_lang;  // For language to language of customer

+					if (empty($newlang) && GETPOST('lang_id','aZ09')) {
+					    $newlang=GETPOST('lang_id','aZ09');
+					}
+					if (!empty(Globals::$conf->global->PRODUIT_TEXTS_IN_THIRDPARTY_LANGUAGE) && empty($newlang)) {
+					                        $newlang = $this->thirdparty->default_lang;
+					}
+					// For language to language of customer

                     if (! empty($newlang))

 					{

 						$outputlangs = new Translate("",$conf);

@@ -4025,8 +4368,7 @@ 
 					}

 

 					$label = (! empty($prod->multilangs[$outputlangs->defaultlang]["label"])) ? $prod->multilangs[$outputlangs->defaultlang]["label"] : $line->product_label;

-				}

-				else

+				} else

 				{

 					$label = $line->product_label;

 				}

@@ -4048,7 +4390,9 @@ 
 				} else {

 					$res=include $tpl; // for debug

 				}

-				if ($res) break;

+				if ($res) {
+				    break;
+				}
 			}

 		}

 

@@ -4071,7 +4415,9 @@ 
 				} else {

 					$res=include $tpl; // for debug

 				}

-				if ($res) break;

+				if ($res) {
+				    break;
+				}
 			}

 		}

 	}

@@ -4098,8 +4444,9 @@ 
 		print '<td>'.$langs->trans('Description').'</td>';

 		print '<td align="right">'.$langs->trans('VATRate').'</td>';

 		print '<td align="right">'.$langs->trans('PriceUHT').'</td>';

-		if (!empty(Globals::$conf->multicurrency->enabled))

-            print '<td align="right">' . $langs->trans('PriceUHTCurrency') . '</td>';

+		if (!empty(Globals::$conf->multicurrency->enabled)) {
+		            print '<td align="right">' . $langs->trans('PriceUHTCurrency') . '</td>';
+		}
         print '<td align="right">'.$langs->trans('Qty').'</td>';

 		if (Globals::$conf->global->PRODUCT_USE_UNITS) {

 			print '<td align="left">'.$langs->trans('Unit').'</td>';

@@ -4121,8 +4468,7 @@ 
 						$action='';

 						$hookmanager->executeHooks('printOriginObjectLine',$parameters,$this,$action);    // Note that $action and $object may have been modified by some hooks

 					}

-				}

-				else

+				} else

 				{

 					$this->printOriginLine($line, $var, $restrictlist);

 				}

@@ -4151,32 +4497,37 @@ 
 		if (!empty($line->date_start))

 		{

 			$date_start=$line->date_start;

-		}

-		else

+		} else

 		{

 			$date_start=$line->date_debut_prevue;

-			if ($line->date_debut_reel) $date_start=$line->date_debut_reel;

+			if ($line->date_debut_reel) {
+			    $date_start=$line->date_debut_reel;
+			}
 		}

 		if (!empty($line->date_end))

 		{

 			$date_end=$line->date_end;

-		}

-		else

+		} else

 		{

 			$date_end=$line->date_fin_prevue;

-			if ($line->date_fin_reel) $date_end=$line->date_fin_reel;

+			if ($line->date_fin_reel) {
+			    $date_end=$line->date_fin_reel;
+			}
 		}

 

 		$this->tpl['label'] = '';

-		if (! empty($line->fk_parent_line)) $this->tpl['label'].= img_picto('', 'rightarrow');

+		if (! empty($line->fk_parent_line)) {
+		    $this->tpl['label'].= img_picto('', 'rightarrow');
+		}
 

-		if (($line->info_bits & 2) == 2)  // TODO Not sure this is used for source object

+		if (($line->info_bits & 2) == 2) {
+		    // TODO Not sure this is used for source object

 		{

-			$discount=new DiscountAbsolute($this->db);

+			$discount=new DiscountAbsolute($this->db);
+		}
 			$discount->fk_soc = $this->socid;

 			$this->tpl['label'].= $discount->getNomUrl(0,'discount');

-		}

-		else if (! empty($line->fk_product))

+		} else if (! empty($line->fk_product))

 		{

 			$productstatic = new Product($this->db);

 			$productstatic->id = $line->fk_product;

@@ -4194,13 +4545,12 @@ 
 			{

 				$this->tpl['label'].= get_date_range($date_start,$date_end);

 			}

-		}

-		else

+		} else

 		{

 			$this->tpl['label'].= ($line->product_type == -1 ? '&nbsp;' : ($line->product_type == 1 ? img_object($langs->trans(''),'service') : img_object($langs->trans(''),'product')));

 			if (!empty($line->desc)) {

 				$this->tpl['label'].=$line->desc;

-			}else {

+			} else {

 				$this->tpl['label'].= ($line->label ? '&nbsp;'.$line->label : '');

 			}

 			

@@ -4213,36 +4563,35 @@ 
 

 		if (! empty($line->desc))

 		{

-			if ($line->desc == '(CREDIT_NOTE)')  // TODO Not sure this is used for source object

+			if ($line->desc == '(CREDIT_NOTE)') {
+			    // TODO Not sure this is used for source object

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount=new DiscountAbsolute($this->db);
+			}
 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromCreditNote",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(DEPOSIT)')  // TODO Not sure this is used for source object

+			} elseif ($line->desc == '(DEPOSIT)') {
+			    // TODO Not sure this is used for source object

 			{

-				$discount=new DiscountAbsolute($this->db);

+				$discount=new DiscountAbsolute($this->db);
+			}
 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromDeposit",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(EXCESS RECEIVED)')

+			} elseif ($line->desc == '(EXCESS RECEIVED)')

 			{

 				$discount=new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessReceived",$discount->getNomUrl(0));

-			}

-			elseif ($line->desc == '(EXCESS PAID)')

+			} elseif ($line->desc == '(EXCESS PAID)')

 			{

 				$discount=new DiscountAbsolute($this->db);

 				$discount->fetch($line->fk_remise_except);

 				$this->tpl['description'] = $langs->transnoentities("DiscountFromExcessPaid",$discount->getNomUrl(0));

-			}

-			else

+			} else

 			{

 				$this->tpl['description'] = dol_trunc($line->desc,60);

 			}

-		}

-		else

+		} else

 		{

 			$this->tpl['description'] = '&nbsp;';

 		}

@@ -4250,18 +4599,23 @@ 
         // VAT Rate

         $this->tpl['vat_rate'] = vatrate($line->tva_tx, true);

         $this->tpl['vat_rate'] .= (($line->info_bits & 1) == 1) ? '*' : '';

-        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';

+        if (! empty($line->vat_src_code) && ! preg_match('/\(/', $this->tpl['vat_rate'])) {
+            $this->tpl['vat_rate'].=' ('.$line->vat_src_code.')';
+        }
 

 		$this->tpl['price'] = price($line->subprice);

 		$this->tpl['multicurrency_price'] = price($line->multicurrency_subprice);

 		$this->tpl['qty'] = (($line->info_bits & 2) != 2) ? $line->qty : '&nbsp;';

-		if (Globals::$conf->global->PRODUCT_USE_UNITS)

-            $this->tpl['unit'] = $langs->transnoentities($line->getLabelOfUnit('long'));

+		if (Globals::$conf->global->PRODUCT_USE_UNITS) {
+		            $this->tpl['unit'] = $langs->transnoentities($line->getLabelOfUnit('long'));
+		}
         $this->tpl['remise_percent'] = (($line->info_bits & 2) != 2) ? vatrate($line->remise_percent, true) : '&nbsp;';

 

 		// Is the line strike or not

 		$this->tpl['strike']=0;

-		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) $this->tpl['strike']=1;

+		if ($restrictlist == 'services' && $line->product_type != Product::TYPE_SERVICE) {
+		    $this->tpl['strike']=1;
+		}
 

 		// Output template part (modules that overwrite templates must declare this into descriptor)

 		// Use global variables + $dateSelector + $seller and $buyer

@@ -4274,7 +4628,9 @@ 
 			} else {

 				$res=include $tpl; // for debug

 			}

-			if ($res) break;

+			if ($res) {
+			    break;
+			}
 		}

 	}

 

@@ -4316,8 +4672,7 @@ 
 		{

 			$this->db->commit();

 			return 1;

-		}

-		else

+		} else

 		{

 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

@@ -4352,8 +4707,7 @@ 
 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

 			return -1;

-		}

-		else

+		} else

 		{

 			if (! $notrigger)

 			{

@@ -4420,14 +4774,20 @@ 
 		// Search template files

 		$file=''; $classname=''; $filefound=0;

 		$dirmodels=array('/');

-		if (is_array(Globals::$conf->modules_parts['models']))

-            $dirmodels = array_merge($dirmodels, Globals::$conf->modules_parts['models']);

+		if (is_array(Globals::$conf->modules_parts['models'])) {
+		            $dirmodels = array_merge($dirmodels, Globals::$conf->modules_parts['models']);
+		}
         foreach($dirmodels as $reldir)

 		{

 			foreach(array('doc','pdf') as $prefix)

 			{

-				if (in_array(get_class($this), array('Adherent'))) $file = $prefix."_".$modele.".class.php";     // Member module use prefix_module.class.php

-				else $file = $prefix."_".$modele.".modules.php";

+				if (in_array(get_class($this), array('Adherent'))) {
+				    $file = $prefix."_".$modele.".class.php";
+				}
+				// Member module use prefix_module.class.php

+				else {
+				    $file = $prefix."_".$modele.".modules.php";
+				}
 

 				// On verifie l'emplacement du modele

 				$file=dol_buildpath($reldir.$modelspath.$file,0);

@@ -4438,7 +4798,9 @@ 
 					break;

 				}

 			}

-			if ($filefound) break;

+			if ($filefound) {
+			    break;
+			}
 		}

 

 		// If generator was found

@@ -4469,7 +4831,9 @@ 
 						if (is_dir($tmpdir))

 						{

 							$tmpfiles=dol_dir_list($tmpdir,'files',0,'\.od(s|t)$','','name',SORT_ASC,0);

-							if (count($tmpfiles)) $listoffiles=array_merge($listoffiles,$tmpfiles);

+							if (count($tmpfiles)) {
+							    $listoffiles=array_merge($listoffiles,$tmpfiles);
+							}
 						}

 					}

 

@@ -4507,8 +4871,7 @@ 
 			{

 				$arrayofrecords = array();   // The write_file of templates of adherent class need this var

 				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, 'member', 1, $moreparams);

-			}

-			else

+			} else

 			{

 				$resultwritefile = $obj->write_file($this, $outputlangs, $srctemplatepath, $hidedetails, $hidedesc, $hideref, $moreparams);

 			}

@@ -4530,9 +4893,11 @@ 
 					$destfile = basename($destfull);

 					$rel_dir = preg_replace('/^'.preg_quote(DOL_DATA_ROOT,'/').'/', '', $upload_dir);

 

-					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir))     // If not a tmp dir

+					if (! preg_match('/[\\/]temp[\\/]|[\\/]thumbs|\.meta$/', $rel_dir)) {
+					    // If not a tmp dir

 					{

-						$filename = basename($destfile);

+						$filename = basename($destfile);
+					}
 						$rel_dir = preg_replace('/[\\/]$/', '', $rel_dir);

 						$rel_dir = preg_replace('/^[\\/]/', '', $rel_dir);

 

@@ -4545,22 +4910,30 @@ 
 						if ($this->element == 'propal')

 						{

 							$useonlinesignature = Globals::$conf->global->MAIN_FEATURES_LEVEL; // Replace this with 1 when feature to make online signature is ok

-                            if ($useonlinesignature) $setsharekey=true;

-							if (!empty(Globals::$conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD))

-                                $setsharekey = true;

+                            if ($useonlinesignature) {
+                                $setsharekey=true;
+                            }
+							if (!empty(Globals::$conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD)) {
+							                                $setsharekey = true;
+							}
                         }

-						if ($this->element == 'commande' && !empty(Globals::$conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD))

-                            $setsharekey = true;

-                        if ($this->element == 'facture' && !empty(Globals::$conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD))

-                            $setsharekey = true;

-                        if ($this->element == 'bank_account' && !empty(Globals::$conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD))

-                            $setsharekey = true;

+						if ($this->element == 'commande' && !empty(Globals::$conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD)) {
+						                            $setsharekey = true;
+						}
+                        if ($this->element == 'facture' && !empty(Globals::$conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD)) {
+                                                    $setsharekey = true;
+                        }
+                        if ($this->element == 'bank_account' && !empty(Globals::$conf->global->BANK_ACCOUNT_ALLOW_EXTERNAL_DOWNLOAD)) {
+                                                    $setsharekey = true;
+                        }
 

                         if ($setsharekey)

 						{

-							if (empty($ecmfile->share))	// Because object not found or share not set yet

+							if (empty($ecmfile->share)) {
+							    // Because object not found or share not set yet

 							{

-								require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';

+								require_once DOL_DOCUMENT_ROOT.'/core/lib/security2.lib.php';
+							}
 								$ecmfile->share = getRandomPassword(true);

 							}

 						}

@@ -4577,8 +4950,7 @@ 
 							{

 								setEventMessages($ecmfile->error, $ecmfile->errors, 'warnings');

 							}

-						}

-						else

+						} else

 						{

 							$ecmfile->entity = Globals::$conf->entity;

                             $ecmfile->filepath = $rel_dir;

@@ -4605,17 +4977,20 @@ 
 

 						// Update the last_main_doc field into main object (if documenent generator has property ->update_main_doc_field set)

 						$update_main_doc_field=0;

-						if (! empty($obj->update_main_doc_field)) $update_main_doc_field=1;

+						if (! empty($obj->update_main_doc_field)) {
+						    $update_main_doc_field=1;
+						}
 						if ($update_main_doc_field && ! empty($this->table_element))

 						{

 							$sql = 'UPDATE '.MAIN_DB_PREFIX.$this->table_element." SET last_main_doc = '".($ecmfile->filepath.'/'.$ecmfile->filename)."'";

 							$sql.= ' WHERE rowid = '.$this->id;

 							$resql = $this->db->query($sql);

-							if (! $resql) dol_print_error($this->db);

+							if (! $resql) {
+							    dol_print_error($this->db);
+							}
 						}

 					}

-				}

-				else

+				} else

 				{

 					dol_syslog('Method ->write_file was called on object '.get_class($obj).' and return a success but the return array ->result["fullpath"] was not set.', LOG_WARNING);

 				}

@@ -4624,15 +4999,13 @@ 
 				dol_meta_create($this);

 

 				return 1;

-			}

-			else

+			} else

 			{

 				$outputlangs->charset_output=$sav_charset_output;

 				dol_print_error($this->db, "Error generating document for ".__CLASS__.". Error: ".$obj->error, $obj->errors);

 				return -1;

 			}

-		}

-		else

+		} else

 		{

 			$this->error=$langs->trans("Error")." ".$langs->trans("ErrorFileDoesNotExists",$file);

 			dol_print_error('',$this->error);

@@ -4688,13 +5061,21 @@ 
 		global $conf, $_POST;

 

 		// If param here has been posted, we use this value first.

-		if (isset($_POST[$fieldname])) return GETPOST($fieldname, 2);

+		if (isset($_POST[$fieldname])) {
+		    return GETPOST($fieldname, 2);
+		}
 

-		if (isset($alternatevalue)) return $alternatevalue;

+		if (isset($alternatevalue)) {
+		    return $alternatevalue;
+		}
 

 		$newelement=$this->element;

-		if ($newelement == 'facture') $newelement='invoice';

-		if ($newelement == 'commande') $newelement='order';

+		if ($newelement == 'facture') {
+		    $newelement='invoice';
+		}
+		if ($newelement == 'commande') {
+		    $newelement='order';
+		}
 		if (empty($newelement))

 		{

 			dol_syslog("Ask a default value using common method getDefaultCreateValueForField on an object with no property ->element defined. Return empty string.", LOG_WARNING);

@@ -4703,8 +5084,9 @@ 
 

 		$keyforfieldname=strtoupper($newelement.'_DEFAULT_'.$fieldname);

 		//var_dump($keyforfieldname);

-		if (isset(Globals::$conf->global->$keyforfieldname))

-            return Globals::$conf->global->$keyforfieldname;

+		if (isset(Globals::$conf->global->$keyforfieldname)) {
+		            return Globals::$conf->global->$keyforfieldname;
+		}
 

         // TODO Ad here a scan into table llx_overwrite_default with a filter on $this->element and $fieldname

 	}

@@ -4738,8 +5120,7 @@ 
 			if (!empty($this->errors))

 			{

 				$this->errors=array_unique(array_merge($this->errors,$interface->errors));   // We use array_unique because when a trigger call another trigger on same object, this->errors is added twice.

-			}

-			else

+			} else

 			{

 				$this->errors=$interface->errors;

 			}

@@ -4791,15 +5172,17 @@ 
 				$extrafields->fetch_name_optionals_label($this->table_element);

 			}

 			$optionsArray = (! empty($extrafields->attributes[$this->table_element]['label'])?$extrafields->attributes[$this->table_element]['label']:null);

-		}

-		else

+		} else

 		{

 			// global $extrafields;

             dol_syslog("Warning: fetch_optionals was called with param optionsArray defined when you should pass null now", LOG_WARNING);

 		}

 

 		$table_element = $this->table_element;

-		if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+		if ($table_element == 'categorie') {
+		    $table_element = 'categories';
+		}
+		// For compatibility

 

 		// Request to get complementary values

 		if (is_array($optionsArray) && count($optionsArray) > 0)

@@ -4835,8 +5218,7 @@ 
 							{

 								//var_dump($extrafields->attributes[$this->table_element]['type'][$key]);

 								$this->array_options["options_".$key]=$this->db->jdate($value);

-							}

-							else

+							} else

 							{

 								$this->array_options["options_".$key]=$value;

 							}

@@ -4848,10 +5230,12 @@ 
 

 				$this->db->free($resql);

 

-				if ($numrows) return $numrows;

-				else return 0;

-			}

-			else

+				if ($numrows) {
+				    return $numrows;
+				} else {
+				    return 0;
+				}
+			} else

 			{

 				dol_print_error($this->db);

 				return -1;

@@ -4870,7 +5254,10 @@ 
 		$this->db->begin();

 

 		$table_element = $this->table_element;

-		if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+		if ($table_element == 'categorie') {
+		    $table_element = 'categories';
+		}
+		// For compatibility

 

 		$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

 		dol_syslog(get_class($this)."::deleteExtraFields delete", LOG_DEBUG);

@@ -4880,8 +5267,7 @@ 
 			$this->error=$this->db->lasterror();

 			$this->db->rollback();

 			return -1;

-		}

-		else

+		} else

 		{

 			$this->db->commit();

 			return 1;

@@ -4902,12 +5288,16 @@ 
 	{

 		global $conf,$langs,$user;

 

-		if (empty($userused)) $userused=$user;

+		if (empty($userused)) {
+		    $userused=$user;
+		}
 

 		$error=0;

 

-		if (!empty(Globals::$conf->global->MAIN_EXTRAFIELDS_DISABLED))

-            return 0; // For avoid conflicts if trigger used

+		if (!empty(Globals::$conf->global->MAIN_EXTRAFIELDS_DISABLED)) {
+		            return 0;
+		}
+		// For avoid conflicts if trigger used

 

         if (! empty($this->array_options))

 		{

@@ -4920,10 +5310,13 @@ 
 			//Eliminate copied source object extra_fields that do not exist in target object

 			$new_array_options=array();

 			foreach ($this->array_options as $key => $value) {

-				if (in_array(substr($key,8), array_keys($target_extrafields)))	// We remove the 'options_' from $key for test

-					$new_array_options[$key] = $value;

-				elseif (in_array($key, array_keys($target_extrafields)))		// We test on $key that does not contains the 'options_' prefix

-					$new_array_options['options_'.$key] = $value;

+				if (in_array(substr($key,8), array_keys($target_extrafields))) {
+				    // We remove the 'options_' from $key for test

+					$new_array_options[$key] = $value;
+				} elseif (in_array($key, array_keys($target_extrafields))) {
+				    // We test on $key that does not contains the 'options_' prefix

+					$new_array_options['options_'.$key] = $value;
+				}
 			}

 

 			foreach($new_array_options as $key => $value)

@@ -4937,8 +5330,12 @@ 
 			   	if ($attributeRequired)

 			   	{

 			   		$mandatorypb=false;

-			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') $mandatorypb=true;

-			   		if ($this->array_options[$key] === '') $mandatorypb=true;

+			   		if ($attributeType == 'link' && $this->array_options[$key] == '-1') {
+			   		    $mandatorypb=true;
+			   		}
+			   		if ($this->array_options[$key] === '') {
+			   		    $mandatorypb=true;
+			   		}
 			   		if ($mandatorypb)

 			   		{

 			   			dol_syslog($this->error);

@@ -4957,8 +5354,7 @@ 
 			   			{

 			   				$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 			   				return -1;

-			  			}

-			   			elseif ($value=='')

+			  			} elseif ($value=='')

 			   			{

 			   				$new_array_options[$key] = null;

 			   			}

@@ -4970,8 +5366,7 @@ 
 							dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

 							$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 							return -1;

-						}

-						elseif ($value=='')

+						} elseif ($value=='')

 						{

 							$new_array_options[$key] = null;

 						}

@@ -4996,27 +5391,27 @@ 
 			   					//global $action;		// $action may be 'create', 'update', 'update_extras'...

 			   					//var_dump($action);

 			   					//var_dump($this->oldcopy);exit;

-			   					if (is_object($this->oldcopy))		// If this->oldcopy is not defined, we can't know if we change attribute or not, so we must keep value

+			   					if (is_object($this->oldcopy)) {
+			   					    // If this->oldcopy is not defined, we can't know if we change attribute or not, so we must keep value

 			   					{

 			   						//var_dump($this->oldcopy->array_options[$key]); var_dump($this->array_options[$key]);

 				   					if ($this->array_options[$key] == $this->oldcopy->array_options[$key])	// If old value crypted in database is same than submited new value, it means we don't change it, so we don't update.

 				   					{

-				   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

-				   					}

-									else

+				   						$new_array_options[$key] = $this->array_options[$key];
+			   					}
+			   					// Value is kept

+				   					} else

 									{

 										// var_dump($algo);

 										$newvalue = dol_hash($this->array_options[$key], $algo);

 										$new_array_options[$key] = $newvalue;

 									}

-			   					}

-			   					else

+			   					} else

 			   					{

 			   						$new_array_options[$key] = $this->array_options[$key];	// Value is kept

 			   					}

 			   				}

-			   			}

-			   			else	// Common usage

+			   			} else	// Common usage

 			   			{

 			   				$new_array_options[$key] = $this->array_options[$key];

 			   			}

@@ -5042,26 +5437,30 @@ 
 						dol_include_once($InfoFieldList[1]);

 						if ($InfoFieldList[0] && class_exists($InfoFieldList[0]))

 						{

-							if ($value == '-1')	// -1 is key for no defined in combo list of objects

+							if ($value == '-1') {
+							    // -1 is key for no defined in combo list of objects

 							{

-								$new_array_options[$key]='';

-							}

-							elseif ($value)

+								$new_array_options[$key]='';
+							}
+							} elseif ($value)

 							{

 								$object = new $InfoFieldList[0]($this->db);

-								if (is_numeric($value)) $res=$object->fetch($value);

-								else $res=$object->fetch('',$value);

-

-								if ($res > 0) $new_array_options[$key]=$object->id;

-								else

+								if (is_numeric($value)) {
+								    $res=$object->fetch($value);
+								} else {
+								    $res=$object->fetch('',$value);
+								}
+

+								if ($res > 0) {
+								    $new_array_options[$key]=$object->id;
+								} else

 								{

 									$this->error="Id/Ref '".$value."' for object '".$object->element."' not found";

 									$this->db->rollback();

 									return -1;

 								}

 							}

-						}

-						else

+						} else

 						{

 							dol_syslog('Error bad setup of extrafield', LOG_WARNING);

 						}

@@ -5072,7 +5471,10 @@ 
 			$this->db->begin();

 

 			$table_element = $this->table_element;

-			if ($table_element == 'categorie') $table_element = 'categories'; // For compatibility

+			if ($table_element == 'categorie') {
+			    $table_element = 'categories';
+			}
+			// For compatibility

 

 			$sql_del = "DELETE FROM ".MAIN_DB_PREFIX.$table_element."_extrafields WHERE fk_object = ".$this->id;

 			dol_syslog(get_class($this)."::insertExtraFields delete", LOG_DEBUG);

@@ -5083,8 +5485,10 @@ 
 			{

 				$attributeKey = substr($key,8);   // Remove 'options_' prefix

 				// Add field of attribut

-				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator

-					$sql.=",".$attributeKey;

+				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') {
+				    // Only for other type than separator

+					$sql.=",".$attributeKey;
+				}
 			}

 			$sql .= ") VALUES (".$this->id;

 

@@ -5092,13 +5496,14 @@ 
 			{

 				$attributeKey = substr($key,8);   // Remove 'options_' prefix

 				// Add field of attribute

-				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') // Only for other type than separator)

+				if ($extrafields->attributes[$this->table_element]['type'][$attributeKey] != 'separate') {
+				    // Only for other type than separator)

 				{

 					if ($new_array_options[$key] != '')

 					{

-						$sql.=",'".$this->db->escape($new_array_options[$key])."'";

-					}

-					else

+						$sql.=",'".$this->db->escape($new_array_options[$key])."'";
+				}
+					} else

 					{

 						$sql.=",null";

 					}

@@ -5119,7 +5524,9 @@ 
 				// Call trigger

 				$this->context=array('extrafieldaddupdate'=>1);

 				$result=$this->call_trigger($trigger, $userused);

-				if ($result < 0) $error++;

+				if ($result < 0) {
+				    $error++;
+				}
 				// End call trigger

 			}

 

@@ -5127,14 +5534,14 @@ 
 			{

 				$this->db->rollback();

 				return -1;

-			}

-			else

+			} else

 			{

 				$this->db->commit();

 				return 1;

 			}

-		}

-		else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

 	/**

@@ -5151,12 +5558,16 @@ 
 	{

 		global $conf,$langs,$user;

 

-		if (empty($userused)) $userused=$user;

+		if (empty($userused)) {
+		    $userused=$user;
+		}
 

 		$error=0;

 

-		if (!empty(Globals::$conf->global->MAIN_EXTRAFIELDS_DISABLED))

-            return 0; // For avoid conflicts if trigger used

+		if (!empty(Globals::$conf->global->MAIN_EXTRAFIELDS_DISABLED)) {
+		            return 0;
+		}
+		// For avoid conflicts if trigger used

 

         if (! empty($this->array_options) && isset($this->array_options["options_".$key]))

 		{

@@ -5183,8 +5594,7 @@ 
 					{

 						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue",$attributeLabel);

 						return -1;

-					}

-					elseif ($value=='')

+					} elseif ($value=='')

 					{

 						$this->array_options["options_".$key] = null;

 					}

@@ -5196,8 +5606,7 @@ 
 						dol_syslog($langs->trans("ExtraFieldHasWrongValue")." sur ".$attributeLabel."(".$value."is not '".$attributeType."')", LOG_DEBUG);

 						$this->errors[]=$langs->trans("ExtraFieldHasWrongValue", $attributeLabel);

 						return -1;

-					}

-					elseif ($value=='')

+					} elseif ($value=='')

 					{

 						$this->array_options["options_".$key] = null;

 					}

@@ -5249,7 +5658,9 @@ 
 				// Call trigger

 				$this->context=array('extrafieldupdate'=>1);

 				$result=$this->call_trigger($trigger, $userused);

-				if ($result < 0) $error++;

+				if ($result < 0) {
+				    $error++;
+				}
 				// End call trigger

 			}

 

@@ -5258,14 +5669,14 @@ 
 				dol_syslog(get_class($this) . "::".__METHOD__ . $this->error, LOG_ERR);

 				$this->db->rollback();

 				return -1;

-			}

-			else

+			} else

 			{

 				$this->db->commit();

 				return 1;

 			}

-		}

-		else return 0;

+		} else {
+		    return 0;
+		}
 	}

 

 

@@ -5340,8 +5751,11 @@ 
 

 		if ($computed)

 		{

-			if (! preg_match('/^search_/', $keyprefix)) return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';

-			else return '';

+			if (! preg_match('/^search_/', $keyprefix)) {
+			    return '<span class="opacitymedium">'.$langs->trans("AutomaticallyCalculated").'</span>';
+			} else {
+			    return '';
+			}
 		}

 

 

@@ -5355,33 +5769,27 @@ 
 			if ($type == 'date')

 			{

 				$morecss = 'minwidth100imp';

-			}

-			elseif ($type == 'datetime')

+			} elseif ($type == 'datetime')

 			{

 				$morecss = 'minwidth200imp';

-			}

-			elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+			} elseif (in_array($type,array('int','integer','price')) || preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

 			{

 				$morecss = 'maxwidth75';

-                        }elseif ($type == 'url')

+                        } elseif ($type == 'url')

 			{

 				$morecss='minwidth400';

-			}

-			elseif ($type == 'boolean')

+			} elseif ($type == 'boolean')

 			{

 				$morecss='';

-			}

-			else

+			} else

 			{

 				if (round($size) < 12)

 				{

 					$morecss = 'minwidth100';

-				}

-				else if (round($size) <= 48)

+				} else if (round($size) <= 48)

 				{

 					$morecss = 'minwidth200';

-				}

-				else

+				} else

 				{

 					$morecss = 'minwidth400';

 				}

@@ -5396,52 +5804,50 @@ 
 			$showtime = in_array($type,array('datetime')) ? 1 : 0;

 

 			// Do not show current date when field not required (see selectDate() method)

-			if (!$required && $value == '') $value = '-1';

+			if (!$required && $value == '') {
+			    $value = '-1';
+			}
 

 			// TODO Must also support $moreparam

 			$out = $form->selectDate($value, $keyprefix.$key.$keysuffix, $showtime, $showtime, $required, '', 1, (($keyprefix != 'search_' && $keyprefix != 'search_options_') ? 1 : 0), 0, 1);

-		}

-		elseif (in_array($type,array('int','integer')))

+		} elseif (in_array($type,array('int','integer')))

 		{

 			$tmp=explode(',',$size);

 			$newsize=$tmp[0];

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$newsize.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

-		}

-		elseif (preg_match('/varchar/', $type))

+		} elseif (preg_match('/varchar/', $type))

 		{

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" maxlength="'.$size.'" value="'.dol_escape_htmltag($value).'"'.($moreparam?$moreparam:'').'>';

-		}

-		elseif (in_array($type, array('mail', 'phone', 'url')))

+		} elseif (in_array($type, array('mail', 'phone', 'url')))

 		{

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'text')

+		} elseif ($type == 'text')

 		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+			if (! preg_match('/search_/', $keyprefix)) {
+			    // If keyprefix is search_ or search_options_, we must just use a simple text field

 			{

-				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

+				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
+			}
 				$doleditor=new DolEditor($keyprefix.$key.$keysuffix,$value,'',200,'dolibarr_notes','In',false,false,false,ROWS_5,'90%');

 				$out=$doleditor->Create(1);

-			}

-			else

+			} else

 			{

 				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

 			}

-		}

-		elseif ($type == 'html')

+		} elseif ($type == 'html')

 		{

-			if (! preg_match('/search_/', $keyprefix))		// If keyprefix is search_ or search_options_, we must just use a simple text field

+			if (! preg_match('/search_/', $keyprefix)) {
+			    // If keyprefix is search_ or search_options_, we must just use a simple text field

 			{

-				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';

+				require_once DOL_DOCUMENT_ROOT.'/core/class/doleditor.class.php';
+			}
 				$doleditor = new DolEditor($keyprefix . $key . $keysuffix, $value, '', 200, 'dolibarr_notes', 'In', false, false, !empty(Globals::$conf->fckeditor->enabled) && Globals::$conf->global->FCKEDITOR_ENABLE_SOCIETE, ROWS_5, '90%');

                 $out=$doleditor->Create(1);

-			}

-			else

+			} else

 			{

 				$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.dol_escape_htmltag($value).'" '.($moreparam?$moreparam:'').'>';

 			}

-		}

-		elseif ($type == 'boolean')

+		} elseif ($type == 'boolean')

 		{

 			$checked='';

 			if (!empty($value)) {

@@ -5450,22 +5856,19 @@ 
 				$checked=' value="1" ';

 			}

 			$out='<input type="checkbox" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.$checked.' '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'price')

+		} elseif ($type == 'price')

 		{

 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

 				$value=price($value);

 			}

 			$out = '<input type="text" class="flat ' . $morecss . ' maxwidthonsmartphone" name="' . $keyprefix . $key . $keysuffix . '" id="' . $keyprefix . $key . $keysuffix . '" value="' . $value . '" ' . ($moreparam ? $moreparam : '') . '> ' . $langs->getCurrencySymbol(Globals::$conf->currency);

-        }

-		elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

+        } elseif (preg_match('/^double(\([0-9],[0-9]\)){0,1}/',$type))

 		{

 			if (!empty($value)) {		// $value in memory is a php numeric, we format it into user number format.

 				$value=price($value);

 			}

 			$out='<input type="text" class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'> ';

-		}

-		elseif ($type == 'select')

+		} elseif ($type == 'select')

 		{

 			$out = '';

 			if (!empty(Globals::$conf->use_javascript_ajax) && !empty(Globals::$conf->global->MAIN_EXTRAFIELDS_USE_SELECT2)) {

@@ -5474,10 +5877,14 @@ 
 			}

 

 			$out.='<select class="flat '.$morecss.' maxwidthonsmartphone" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" '.($moreparam?$moreparam:'').'>';

-                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1))$out.='<option value="0">&nbsp;</option>';

+                if((! isset($this->fields[$key]['default'])) ||($this->fields[$key]['notnull']!=1)) {
+                    $out.='<option value="0">&nbsp;</option>';
+                }
 			foreach ($param['options'] as $key => $val)

 			{

-				if ((string) $key == '') continue;

+				if ((string) $key == '') {
+				    continue;
+				}
 				list($val, $parent) = explode('|', $val);

 				$out.='<option value="'.$key.'"';

 				$out.= (((string) $value == (string) $key)?' selected':'');

@@ -5485,8 +5892,7 @@ 
 				$out.='>'.$val.'</option>';

 			}

 			$out.='</select>';

-		}

-		elseif ($type == 'sellist')

+		} elseif ($type == 'sellist')

 		{

 			$out = '';

 			if (!empty(Globals::$conf->use_javascript_ajax) && !empty(Globals::$conf->global->MAIN_EXTRAFIELDS_USE_SELECT2)) {

@@ -5552,13 +5958,11 @@ 
 					{

 						$sql.= ' as main, '.MAIN_DB_PREFIX .$InfoFieldList[0].'_extrafields as extra';

 						$sqlwhere.= ' WHERE extra.fk_object=main.'.$InfoFieldList[2]. ' AND '.$InfoFieldList[4];

-					}

-					else

+					} else

 					{

 						$sqlwhere.= ' WHERE '.$InfoFieldList[4];

 					}

-				}

-				else

+				} else

 				{

 					$sqlwhere.= ' WHERE 1=1';

 				}

@@ -5594,8 +5998,7 @@ 
 							{

 								$labeltoshow.= $obj->$field_toshow.' ';

 							}

-						}

-						else

+						} else

 						{

 							$labeltoshow=$obj->{$InfoFieldList[1]};

 						}

@@ -5608,25 +6011,25 @@ 
 								$translabel=$langs->trans($obj->$field_toshow);

 								if ($translabel!=$obj->$field_toshow) {

 									$labeltoshow=dol_trunc($translabel,18).' ';

-								}else {

+								} else {

 									$labeltoshow=dol_trunc($obj->$field_toshow,18).' ';

 								}

 							}

 							$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

-						}

-						else

+						} else

 						{

 							if (! $notrans)

 							{

 								$translabel=$langs->trans($obj->{$InfoFieldList[1]});

 								if ($translabel!=$obj->{$InfoFieldList[1]}) {

 									$labeltoshow=dol_trunc($translabel,18);

-								}

-								else {

+								} else {

 									$labeltoshow=dol_trunc($obj->{$InfoFieldList[1]},18);

 								}

 							}

-							if (empty($labeltoshow)) $labeltoshow='(not defined)';

+							if (empty($labeltoshow)) {
+							    $labeltoshow='(not defined)';
+							}
 							if ($value==$obj->rowid)

 							{

 								$out.='<option value="'.$obj->rowid.'" selected>'.$labeltoshow.'</option>';

@@ -5646,19 +6049,16 @@ 
 						$i++;

 					}

 					$this->db->free($resql);

-				}

-				else {

+				} else {

 					print 'Error in request '.$sql.' '.$this->db->lasterror().'. Check setup of extra parameters.<br>';

 				}

 			}

 			$out.='</select>';

-		}

-		elseif ($type == 'checkbox')

+		} elseif ($type == 'checkbox')

 		{

 			$value_arr=explode(',',$value);

 			$out=$form->multiselectarray($keyprefix.$key.$keysuffix, (empty($param['options'])?null:$param['options']), $value_arr, '', 0, '', 0, '100%');

-		}

-		elseif ($type == 'radio')

+		} elseif ($type == 'radio')

 		{

 			$out='';

 			foreach ($param['options'] as $keyopt => $val)

@@ -5669,13 +6069,11 @@ 
 				$out.= ($value==$keyopt?'checked':'');

 				$out.='/><label for="'.$keyprefix.$key.$keysuffix.'_'.$keyopt.'">'.$val.'</label><br>';

 			}

-		}

-		elseif ($type == 'chkbxlst')

+		} elseif ($type == 'chkbxlst')

 		{

 			if (is_array($value)) {

 				$value_arr = $value;

-			}

-			else {

+			} else {

 				$value_arr = explode(',', $value);

 			}

 

@@ -5790,8 +6188,9 @@ 
 									$labeltoshow = dol_trunc($obj->{$InfoFieldList[1]}, 18);

 								}

 							}

-							if (empty($labeltoshow))

-								$labeltoshow = '(not defined)';

+							if (empty($labeltoshow)) {
+															$labeltoshow = '(not defined)';
+							}
 

 								if (is_array($value_arr) && in_array($obj->rowid, $value_arr)) {

 									$data[$obj->rowid]=$labeltoshow;

@@ -5813,26 +6212,26 @@ 
 					print 'Error in request ' . $sql . ' ' . $this->db->lasterror() . '. Check setup of extra parameters.<br>';

 				}

 			}

-		}

-		elseif ($type == 'link')

+		} elseif ($type == 'link')

 		{

 			$param_list=array_keys($param['options']);				// $param_list='ObjectName:classPath'

 			$showempty=(($required && $default != '')?0:1);

 			$out=$form->selectForForms($param_list[0], $keyprefix.$key.$keysuffix, $value, $showempty);

 			if (Globals::$conf->global->MAIN_FEATURES_LEVEL >= 2) {

             			list($class,$classfile)=explode(':',$param_list[0]);

-            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);

-            			else $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);

+            			if (file_exists(dol_buildpath(dirname(dirname($classfile)).'/card.php'))) {
+            			    $url_path=dol_buildpath(dirname(dirname($classfile)).'/card.php',1);
+            			} else {
+            			    $url_path=dol_buildpath(dirname(dirname($classfile)).'/'.$class.'_card.php',1);
+            			}
             			$out.='<a class="butActionNew" href="'.$url_path.'?action=create&backtopage='.$_SERVER['PHP_SELF'].'"><span class="fa fa-plus-circle valignmiddle"></span></a>';

             			// TODO Add Javascript code to add input fields contents to new elements urls

 			}

-		}

-		elseif ($type == 'password')

+		} elseif ($type == 'password')

 		{

 			// If prefix is 'search_', field is used as a filter, we use a common text field.

 			$out='<input type="'.($keyprefix=='search_'?'text':'password').'" class="flat '.$morecss.'" name="'.$keyprefix.$key.$keysuffix.'" id="'.$keyprefix.$key.$keysuffix.'" value="'.$value.'" '.($moreparam?$moreparam:'').'>';

-		}

-		elseif ($type == 'array')

+		} elseif ($type == 'array')

 		{

 			$newval = $val;

 			$newval['type'] = 'varchar(256)';

@@ -5910,17 +6309,25 @@ 
 		{

 			$type = 'varchar';		// convert varchar(xx) int varchar

 			$size = $reg[1];

-		}

-		elseif (preg_match('/varchar/', $type)) $type = 'varchar';		// convert varchar(xx) int varchar

-		if (is_array($val['arrayofkeyval'])) $type='select';

-		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) $type='link';

+		} elseif (preg_match('/varchar/', $type)) {
+		    $type = 'varchar';
+		}
+		// convert varchar(xx) int varchar

+		if (is_array($val['arrayofkeyval'])) {
+		    $type='select';
+		}
+		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg)) {
+		    $type='link';
+		}
 

 		$default=$val['default'];

 		$computed=$val['computed'];

 		$unique=$val['unique'];

 		$required=$val['required'];

 		$param=$val['param'];

-		if (is_array($val['arrayofkeyval'])) $param['options'] = $val['arrayofkeyval'];

+		if (is_array($val['arrayofkeyval'])) {
+		    $param['options'] = $val['arrayofkeyval'];
+		}
 		if (preg_match('/^integer:(.*):(.*)/i', $val['type'], $reg))

 		{

 			$type='link';

@@ -5931,7 +6338,9 @@ 
 		$help=$val['help'];

 		$hidden=(($val['visible'] == 0) ? 1 : 0);			// If zero, we are sure it is hidden, otherwise we show. If it depends on mode (view/create/edit form or list, this must be filtered by caller)

 

-		if ($hidden) return '';

+		if ($hidden) {
+		    return '';
+		}
 

 		// If field is a computed field, value must become result of compute

 		if ($computed)

@@ -5947,36 +6356,29 @@ 
 			{

 				//$showsize=10;

 				$showsize = 'minwidth100imp';

-			}

-			elseif ($type == 'datetime')

+			} elseif ($type == 'datetime')

 			{

 				//$showsize=19;

 				$showsize = 'minwidth200imp';

-			}

-			elseif (in_array($type,array('int','double','price')))

+			} elseif (in_array($type,array('int','double','price')))

 			{

 				//$showsize=10;

 				$showsize = 'maxwidth75';

-			}

-			elseif ($type == 'url')

+			} elseif ($type == 'url')

 			{

 				$showsize='minwidth400';

-			}

-			elseif ($type == 'boolean')

+			} elseif ($type == 'boolean')

 			{

 				$showsize='';

-			}

-			else

+			} else

 			{

 				if (round($size) < 12)

 				{

 					$showsize = 'minwidth100';

-				}

-				else if (round($size) <= 48)

+				} else if (round($size) <= 48)

 				{

 					$showsize = 'minwidth200';

-				}

-				else

+				} else

 				{

 					//$showsize=48;

 					$showsize = 'minwidth400';

@@ -5985,59 +6387,52 @@ 
 		}

 

 		// Format output value differently according to properties of field

-		if ($key == 'ref' && method_exists($this, 'getNomUrl')) $value=$this->getNomUrl(1, '', 0, '', 1);

-		elseif ($key == 'status' && method_exists($this, 'getLibStatut')) $value=$this->getLibStatut(3);

-		elseif ($type == 'date')

+		if ($key == 'ref' && method_exists($this, 'getNomUrl')) {
+		    $value=$this->getNomUrl(1, '', 0, '', 1);
+		} elseif ($key == 'status' && method_exists($this, 'getLibStatut')) {
+		    $value=$this->getLibStatut(3);
+		} elseif ($type == 'date')

 		{

 			if(! empty($value)) {

 				$value=dol_print_date($value,'day');

 			} else {

 				$value='';

 			}

-		}

-		elseif ($type == 'datetime')

+		} elseif ($type == 'datetime')

 		{

 			if(! empty($value)) {

 				$value=dol_print_date($value,'dayhour');

 			} else {

 				$value='';

 			}

-		}

-		elseif ($type == 'double')

+		} elseif ($type == 'double')

 		{

 			if (!empty($value)) {

 				$value=price($value);

 			}

-		}

-		elseif ($type == 'boolean')

+		} elseif ($type == 'boolean')

 		{

 			$checked='';

 			if (!empty($value)) {

 				$checked=' checked ';

 			}

 			$value='<input type="checkbox" '.$checked.' '.($moreparam?$moreparam:'').' readonly disabled>';

-		}

-		elseif ($type == 'mail')

+		} elseif ($type == 'mail')

 		{

 			$value=dol_print_email($value,0,0,0,64,1,1);

-		}

-		elseif ($type == 'url')

+		} elseif ($type == 'url')

 		{

 			$value=dol_print_url($value,'_blank',32,1);

-		}

-		elseif ($type == 'phone')

+		} elseif ($type == 'phone')

 		{

 			$value=dol_print_phone($value, '', 0, 0, '', '&nbsp;', 1);

-		}

-		elseif ($type == 'price')

+		} elseif ($type == 'price')

 		{

 			$value = price($value, 0, $langs, 0, 0, -1, Globals::$conf->currency);

-        }

-		elseif ($type == 'select')

+        } elseif ($type == 'select')

 		{

 			$value=$param['options'][$value];

-		}

-		elseif ($type == 'sellist')

+		} elseif ($type == 'sellist')

 		{

 			$param_list=array_keys($param['options']);

 			$InfoFieldList = explode(":", $param_list[0]);

@@ -6067,7 +6462,7 @@ 
 				$sql.= " WHERE ".$selectkey."=0";

 			} elseif ($selectkey=='rowid') {

 				$sql.= " WHERE ".$selectkey."=".$this->db->escape($value);

-			}else {

+			} else {

 				$sql.= " WHERE ".$selectkey."='".$this->db->escape($value)."'";

 			}

 

@@ -6094,12 +6489,11 @@ 
 						}

 						if ($translabel!=$field_toshow) {

 							$value.=dol_trunc($translabel,18).' ';

-						}else {

+						} else {

 							$value.=$obj->$field_toshow.' ';

 						}

 					}

-				}

-				else

+				} else

 				{

 					$translabel='';

 					if (!empty($obj->{$InfoFieldList[1]})) {

@@ -6107,18 +6501,17 @@ 
 					}

 					if ($translabel!=$obj->{$InfoFieldList[1]}) {

 						$value=dol_trunc($translabel,18);

-					}else {

+					} else {

 						$value=$obj->{$InfoFieldList[1]};

 					}

 				}

-			}

-			else dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);

-		}

-		elseif ($type == 'radio')

+			} else {
+			    dol_syslog(get_class($this).'::showOutputField error '.$this->db->lasterror(), LOG_WARNING);
+			}
+		} elseif ($type == 'radio')

 		{

 			$value=$param['options'][$value];

-		}

-		elseif ($type == 'checkbox')

+		} elseif ($type == 'checkbox')

 		{

 			$value_arr=explode(',',$value);

 			$value='';

@@ -6129,8 +6522,7 @@ 
 				}

 				$value='<div class="select2-container-multi-dolibarr" style="width: 90%;"><ul class="select2-choices-dolibarr">'.implode(' ', $toprint).'</ul></div>';

 			}

-		}

-		elseif ($type == 'chkbxlst')

+		} elseif ($type == 'chkbxlst')

 		{

 			$value_arr = explode(',', $value);

 

@@ -6198,8 +6590,7 @@ 
 			} else {

 				dol_syslog(get_class($this) . '::showOutputField error ' . $this->db->lasterror(), LOG_WARNING);

 			}

-		}

-		elseif ($type == 'link')

+		} elseif ($type == 'link')

 		{

 			$out='';

 

@@ -6221,24 +6612,21 @@ 
 						$object->fetch($value);

 						$value=$object->getNomUrl($getnomurlparam);

 					}

-				}

-				else

+				} else

 				{

 					dol_syslog('Error bad setup of extrafield', LOG_WARNING);

 					return 'Error bad setup of extrafield';

 				}

-			}

-			else $value='';

-		}

-		elseif ($type == 'text' || $type == 'html')

+			} else {
+			    $value='';
+			}
+		} elseif ($type == 'text' || $type == 'html')

 		{

 			$value=dol_htmlentitiesbr($value);

-		}

-		elseif ($type == 'password')

+		} elseif ($type == 'password')

 		{

 			$value=preg_replace('/./i','*',$value);

-		}

-		elseif ($type == 'array')

+		} elseif ($type == 'array')

 		{

 			$value = implode('<br>', $value);

 		}

@@ -6265,7 +6653,9 @@ 
 	{

 		global $db, $conf, $langs, $action, $form;

 

-		if (! is_object($form)) $form=new Form($db);

+		if (! is_object($form)) {
+		    $form=new Form($db);
+		}
 

 		$out = '';

 

@@ -6279,7 +6669,9 @@ 
 			foreach($extrafields->attributes[$this->table_element]['label'] as $key=>$label)

 			{

 				// Show only the key field in params

-				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) continue;

+				if (is_array($params) && array_key_exists('onlykey',$params) && $key != $params['onlykey']) {
+				    continue;
+				}
 

 				$enabled = 1;

 				if ($enabled && isset($extrafields->attributes[$this->table_element]['list'][$key]))

@@ -6293,11 +6685,18 @@ 
 					$perms = dol_eval($extrafields->attributes[$this->table_element]['perms'][$key], 1);

 				}

 

-				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) continue;	// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

-				if (empty($perms)) continue;

+				if (($mode == 'create' || $mode == 'edit') && abs($enabled) != 1 && abs($enabled) != 3) {
+				    continue;
+				}
+				// <> -1 and <> 1 and <> 3 = not visible on forms, only on list

+				if (empty($perms)) {
+				    continue;
+				}
 

 				// Load language if required

-				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);

+				if (! empty($extrafields->attributes[$this->table_element]['langfile'][$key])) {
+				    $langs->load($extrafields->attributes[$this->table_element]['langfile'][$key]);
+				}
 

 				$colspan='3';

 				if (is_array($params) && count($params)>0) {

@@ -6331,8 +6730,7 @@ 
 				if ($extrafields->attributes[$this->table_element]['type'][$key] == 'separate')

 				{

 					$out .= $extrafields->showSeparator($key, $this);

-				}

-				else

+				} else

 				{

 					$csstyle='';

 					$class=(!empty($extrafields->attributes[$this->table_element]['hidden'][$key]) ? 'hideobject ' : '');

@@ -6363,9 +6761,11 @@ 
 					if (in_array($extrafields->attributes[$this->table_element]['type'][$key],array('date','datetime')))

 					{

 						$datenotinstring = $this->array_options['options_' . $key];

-						if (! is_numeric($this->array_options['options_' . $key]))	// For backward compatibility

+						if (! is_numeric($this->array_options['options_' . $key])) {
+						    // For backward compatibility

 						{

-							$datenotinstring = $this->db->jdate($datenotinstring);

+							$datenotinstring = $this->db->jdate($datenotinstring);
+						}
 						}

 						$value = GETPOSTISSET($keyprefix.'options_'.$key.$keysuffix)?dol_mktime(GETPOST($keyprefix.'options_'.$key.$keysuffix."hour", 'int', 3), GETPOST($keyprefix.'options_'.$key.$keysuffix."min",'int',3), 0, GETPOST($keyprefix.'options_'.$key.$keysuffix."month",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."day",'int',3), GETPOST($keyprefix.'options_'.$key.$keysuffix."year",'int',3)):$datenotinstring;

 					}

@@ -6378,11 +6778,18 @@ 
 					$labeltoshow = $langs->trans($label);

 

 					$out .= '<td class="titlefield';

-					if (GETPOST('action','none') == 'create') $out.='create';

-					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) $out .= ' fieldrequired';

+					if (GETPOST('action','none') == 'create') {
+					    $out.='create';
+					}
+					if ($mode != 'view' && ! empty($extrafields->attributes[$this->table_element]['required'][$key])) {
+					    $out .= ' fieldrequired';
+					}
 					$out .= '">';

-					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);

-					else $out .= $labeltoshow;

+					if (! empty($extrafields->attributes[$object->table_element]['help'][$key])) {
+					    $out .= $form->textwithpicto($labeltoshow, $extrafields->attributes[$object->table_element]['help'][$key]);
+					} else {
+					    $out .= $labeltoshow;
+					}
 					$out .= '</td>';

 

 					$html_id = !empty($this->id) ? $this->element.'_extras_'.$key.'_'.$this->id : '';

@@ -6399,9 +6806,11 @@ 
 

 					$out .= '</td>';

 

-					if (!empty(Globals::$conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1))

-                        $out .= '</tr>';

-                    else $out .= '</tr>';

+					if (!empty(Globals::$conf->global->MAIN_EXTRAFIELDS_USE_TWO_COLUMS) && (($e % 2) == 1)) {
+					                        $out .= '</tr>';
+					} else {
+                        $out .= '</tr>';
+                    }
 					$e++;

 				}

 			}

@@ -6453,7 +6862,9 @@ 
 		global $user;

 

 		$element = $this->element;

-		if ($element == 'facturerec') $element='facture';

+		if ($element == 'facturerec') {
+		    $element='facture';
+		}
 

 		return $user->rights->{$element};

 	}

@@ -6478,7 +6889,10 @@ 
 

 			if (! $db->query($sql))

 			{

-				if ($ignoreerrors) return true;		// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

+				if ($ignoreerrors) {
+				    return true;
+				}
+				// TODO Not enough. If there is A-B on kept thirdarty and B-C on old one, we must get A-B-C after merge. Not A-B.

 				//$this->errors = $db->lasterror();

 				return false;

 			}

@@ -6507,8 +6921,7 @@ 
 

 		if (($unitPrice > 0) && (isset(Globals::$conf->global->ForceBuyingPriceIfNull) && Globals::$conf->global->ForceBuyingPriceIfNull == 1)) { // In most cases, test here is false{

 			$buyPrice = $unitPrice * (1 - $discountPercent / 100);

-		}

-		else

+		} else

 		{

 			// Get cost price for margin calculation

 			if (! empty($fk_product))

@@ -6525,13 +6938,11 @@ 
 					if ($product->cost_price > 0)

 					{

 						$buyPrice = $product->cost_price;

-					}

-					else if ($product->pmp > 0)

+					} else if ($product->pmp > 0)

 					{

 						$buyPrice = $product->pmp;

 					}

-				}

-				else if (isset(Globals::$conf->global->MARGIN_TYPE) && Globals::$conf->global->MARGIN_TYPE == 'pmp') {

+				} else if (isset(Globals::$conf->global->MARGIN_TYPE) && Globals::$conf->global->MARGIN_TYPE == 'pmp') {

 					require_once DOL_DOCUMENT_ROOT.'/product/class/product.class.php';

 					$product = new Product($this->db);

 					$result = $product->fetch($fk_product);

@@ -6552,8 +6963,7 @@ 
 					if (($result = $productFournisseur->find_min_price_product_fournisseur($fk_product)) > 0)

 					{

 						$buyPrice = $productFournisseur->fourn_unitprice;

-					}

-					else if ($result < 0)

+					} else if ($result < 0)

 					{

 						$this->errors[] = $productFournisseur->error;

 						return -2;

@@ -6599,8 +7009,7 @@ 
 		{

 			$dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

 			$pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->track_id.'/';

-		}

-		else

+		} else

 		{

 			$dir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

 			$pdir .= get_exdir(0, 0, 0, 0, $this, $modulepart).$this->ref.'/';

@@ -6662,19 +7071,26 @@ 
 

 						// Find name of thumb file

 						$photo_vignette=basename(getImageFileNameForSize($dir.$file, '_small'));

-						if (! dol_is_file($dirthumb.$photo_vignette)) $photo_vignette='';

+						if (! dol_is_file($dirthumb.$photo_vignette)) {
+						    $photo_vignette='';
+						}
 

 						// Get filesize of original file

 						$imgarray=dol_getImageSize($dir.$photo);

 

 						if ($nbbyrow > 0)

 						{

-							if ($nbphoto == 1) $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';

+							if ($nbphoto == 1) {
+							    $return.= '<table width="100%" valign="top" align="center" border="0" cellpadding="2" cellspacing="2">';
+							}
 

-							if ($nbphoto % $nbbyrow == 1) $return.= '<tr align=center valign=middle border=1>';

+							if ($nbphoto % $nbbyrow == 1) {
+							    $return.= '<tr align=center valign=middle border=1>';
+							}
 							$return.= '<td width="'.ceil(100/$nbbyrow).'%" class="photo">';

-						}

-						else if ($nbbyrow < 0) $return .= '<div class="inline-block">';

+						} else if ($nbbyrow < 0) {
+						    $return .= '<div class="inline-block">';
+						}
 

 						$return.= "\n";

 

@@ -6682,15 +7098,20 @@ 
 						if (empty($nolink))

 						{

 							$urladvanced=getAdvancedPreviewUrl($modulepart, $relativefile, 0, 'entity='.$this->entity);

-							if ($urladvanced) $return.='<a href="'.$urladvanced.'">';

-							else $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';

+							if ($urladvanced) {
+							    $return.='<a href="'.$urladvanced.'">';
+							} else {
+							    $return.= '<a href="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" class="aphoto" target="_blank">';
+							}
 						}

 

 						// Show image (width height=$maxHeight)

 						// Si fichier vignette disponible et image source trop grande, on utilise la vignette, sinon on utilise photo origine

 						$alt=$langs->transnoentitiesnoconv('File').': '.$relativefile;

 						$alt.=' - '.$langs->transnoentitiesnoconv('Size').': '.$imgarray['width'].'x'.$imgarray['height'];

-						if ($notitle) $alt='';

+						if ($notitle) {
+						    $alt='';
+						}
 

 						if ($usesharelink)

 						{

@@ -6700,35 +7121,35 @@ 
 								{

 									$return.= '<!-- Show original file (thumb not yet available with shared links) -->';

 									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

-								}

-								else {

+								} else {

 									$return.= '<!-- Show original file -->';

 									$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?hashp='.urlencode($val['share']).'" title="'.dol_escape_htmltag($alt).'">';

 								}

-							}

-							else

+							} else

 							{

 								$return.= '<!-- Show nophoto file (because file is not shared) -->';

 								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/public/theme/common/nophoto.png" title="'.dol_escape_htmltag($alt).'">';

 							}

-						}

-						else

+						} else

 						{

 							if (empty($maxHeight) || $photo_vignette && $imgarray['height'] > $maxHeight)

 							{

 								$return.= '<!-- Show thumb -->';

 								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdirthumb.$photo_vignette).'" title="'.dol_escape_htmltag($alt).'">';

-							}

-							else {

+							} else {

 								$return.= '<!-- Show original file -->';

 								$return.= '<img class="photo photowithmargin" border="0" height="'.$maxHeight.'" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'" title="'.dol_escape_htmltag($alt).'">';

 							}

 						}

 

-						if (empty($nolink)) $return.= '</a>';

+						if (empty($nolink)) {
+						    $return.= '</a>';
+						}
 						$return.="\n";

 

-						if ($showfilename) $return.= '<br>'.$viewfilename;

+						if ($showfilename) {
+						    $return.= '<br>'.$viewfilename;
+						}
 						if ($showaction)

 						{

 							$return.= '<br>';

@@ -6753,15 +7174,20 @@ 
 						if ($nbbyrow > 0)

 						{

 							$return.= '</td>';

-							if (($nbphoto % $nbbyrow) == 0) $return.= '</tr>';

-						}

-						else if ($nbbyrow < 0) $return.='</div>';

+							if (($nbphoto % $nbbyrow) == 0) {
+							    $return.= '</tr>';
+							}
+						} else if ($nbbyrow < 0) {
+						    $return.='</div>';
+						}
 					}

 

 					if (empty($size)) {     // Format origine

 						$return.= '<img class="photo photowithmargin" border="0" src="'.DOL_URL_ROOT.'/viewimage.php?modulepart='.$modulepart.'&entity='.$this->entity.'&file='.urlencode($pdir.$photo).'">';

 

-						if ($showfilename) $return.= '<br>'.$viewfilename;

+						if ($showfilename) {
+						    $return.= '<br>'.$viewfilename;
+						}
 						if ($showaction)

 						{

 							// Special case for product

@@ -6778,7 +7204,9 @@ 
 					}

 

 					// On continue ou on arrete de boucler ?

-					if ($nbmax && $nbphoto >= $nbmax) break;

+					if ($nbmax && $nbphoto >= $nbmax) {
+					    break;
+					}
 				}

 			}

 

@@ -6793,7 +7221,9 @@ 
 						$nbphoto++;

 					}

 

-					if ($nbphoto) $return.= '</table>';

+					if ($nbphoto) {
+					    $return.= '</table>';
+					}
 				}

 			}

 		}

@@ -6814,10 +7244,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='array') return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && $info['type']=='array') {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6830,10 +7264,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='null') return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && $info['type']=='null') {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6844,8 +7282,11 @@ 
 	 */

 	public function isDate($info)

 	{

-		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) return true;

-		else return false;

+		if(isset($info['type']) && ($info['type']=='date' || $info['type']=='datetime' || $info['type']=='timestamp')) {
+		    return true;
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6858,10 +7299,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && ($info['type']=='int' || preg_match('/^integer/i',$info['type']) ) ) {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6874,10 +7319,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) return true;

-			else return false;

-		}

-		else return false;

+			if (isset($info['type']) && (preg_match('/^(double|real)/i', $info['type']))) {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6890,10 +7339,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['type']) && $info['type']=='text') return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['type']) && $info['type']=='text') {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6906,10 +7359,14 @@ 
 	{

 		if(is_array($info))

 		{

-			if(isset($info['index']) && $info['index']==true) return true;

-			else return false;

-		}

-		else return false;

+			if(isset($info['index']) && $info['index']==true) {
+			    return true;
+			} else {
+			    return false;
+			}
+		} else {
+		    return false;
+		}
 	}

 

 	/**

@@ -6923,21 +7380,21 @@ 
 		global $conf;

 

 		$queryarray=array();

-		foreach ($this->fields as $field=>$info)	// Loop on definition of fields

+		foreach ($this->fields as $field=>$info) {
+		    // Loop on definition of fields

 		{

 			// Depending on field type ('datetime', ...)

 			if($this->isDate($info))

 			{

 				if(empty($this->{$field}))

 				{

-					$queryarray[$field] = null;

-				}

-				else

+					$queryarray[$field] = null;
+		}
+				} else

 				{

 					$queryarray[$field] = $this->db->idate($this->{$field});

 				}

-			}

-			else if($this->isArray($info))

+			} else if($this->isArray($info))

 			{

 				if(! empty($this->{$field})) {

 					if(! is_array($this->{$field})) {

@@ -6947,29 +7404,35 @@ 
 				} else {

 					$queryarray[$field] = null;

 				}

-			}

-			else if($this->isInt($info))

+			} else if($this->isInt($info))

 			{

-				if ($field == 'entity' && is_null($this->{$field}))

-                    $queryarray[$field] = Globals::$conf->entity;

-                else

+				if ($field == 'entity' && is_null($this->{$field})) {
+				                    $queryarray[$field] = Globals::$conf->entity;
+				} else

 				{

 					$queryarray[$field] = (int) price2num($this->{$field});

-					if (empty($queryarray[$field])) $queryarray[$field]=0;		// May be reset to null later if property 'notnull' is -1 for this field.

+					if (empty($queryarray[$field])) {
+					    $queryarray[$field]=0;
+					}
+					// May be reset to null later if property 'notnull' is -1 for this field.

 				}

-			}

-			else if($this->isFloat($info))

+			} else if($this->isFloat($info))

 			{

 				$queryarray[$field] = (double) price2num($this->{$field});

-				if (empty($queryarray[$field])) $queryarray[$field]=0;

-			}

-			else

+				if (empty($queryarray[$field])) {
+				    $queryarray[$field]=0;
+				}
+			} else

 			{

 				$queryarray[$field] = $this->{$field};

 			}

 

-			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) unset($queryarray[$field]);

-			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) $queryarray[$field] = null;

+			if ($info['type'] == 'timestamp' && empty($queryarray[$field])) {
+			    unset($queryarray[$field]);
+			}
+			if (! empty($info['notnull']) && $info['notnull'] == -1 && empty($queryarray[$field])) {
+			    $queryarray[$field] = null;
+			}
 		}

 

 		return $queryarray;

@@ -6987,42 +7450,47 @@ 
 		{

 			if($this->isDate($info))

 			{

-				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') $this->{$field} = 0;

-				else $this->{$field} = strtotime($obj->{$field});

-			}

-			elseif($this->isArray($info))

+				if(empty($obj->{$field}) || $obj->{$field} === '0000-00-00 00:00:00' || $obj->{$field} === '1000-01-01 00:00:00') {
+				    $this->{$field} = 0;
+				} else {
+				    $this->{$field} = strtotime($obj->{$field});
+				}
+			} elseif($this->isArray($info))

 			{

 				if(! empty($obj->{$field})) {

 					$this->{$field} = @unserialize($obj->{$field});

 					// Hack for data not in UTF8

-					if($this->{$field } === false) @unserialize(utf8_decode($obj->{$field}));

+					if($this->{$field } === false) {
+					    @unserialize(utf8_decode($obj->{$field}));
+					}
 				} else {

 					$this->{$field} = array();

 				}

-			}

-			elseif($this->isInt($info))

+			} elseif($this->isInt($info))

 			{

-				if ($field == 'rowid') $this->id = (int) $obj->{$field};

-				else $this->{$field} = (int) $obj->{$field};

-			}

-			elseif($this->isFloat($info))

+				if ($field == 'rowid') {
+				    $this->id = (int) $obj->{$field};
+				} else {
+				    $this->{$field} = (int) $obj->{$field};
+				}
+			} elseif($this->isFloat($info))

 			{

 				$this->{$field} = (double) $obj->{$field};

-			}

-			elseif($this->isNull($info))

+			} elseif($this->isNull($info))

 			{

 				$val = $obj->{$field};

 				// zero is not null

 				$this->{$field} = (is_null($val) || (empty($val) && $val!==0 && $val!=='0') ? null : $val);

-			}

-			else

+			} else

 			{

 				$this->{$field} = $obj->{$field};

 			}

 		}

 

 		// If there is no 'ref' field, we force property ->ref to ->id for a better compatibility with common functions.

-		if (! isset($this->fields['ref']) && isset($this->id)) $this->ref = $this->id;

+		if (! isset($this->fields['ref']) && isset($this->id)) {
+		    $this->ref = $this->id;
+		}
 	}

 

 	/**

@@ -7045,9 +7513,13 @@ 
 	 */

     protected function quote($value, $fieldsentry)

     {

-		if (is_null($value)) return 'NULL';

-		else if (preg_match('/^(int|double|real)/i', $fieldsentry['type'])) return $this->db->escape("$value");

-		else return "'".$this->db->escape($value)."'";

+		if (is_null($value)) {
+		    return 'NULL';
+		} else if (preg_match('/^(int|double|real)/i', $fieldsentry['type'])) {
+		    return $this->db->escape("$value");
+		} else {
+		    return "'".$this->db->escape($value)."'";
+		}
 	}

 

 

@@ -7067,8 +7539,12 @@ 
 		$now=dol_now();

 

 		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) $fieldvalues['date_creation']=$this->db->idate($now);

-		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) $fieldvalues['fk_user_creat']=$user->id;

+		if (array_key_exists('date_creation', $fieldvalues) && empty($fieldvalues['date_creation'])) {
+		    $fieldvalues['date_creation']=$this->db->idate($now);
+		}
+		if (array_key_exists('fk_user_creat', $fieldvalues) && ! ($fieldvalues['fk_user_creat'] > 0)) {
+		    $fieldvalues['fk_user_creat']=$user->id;
+		}
 		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into insert.

 

 		$keys=array();

@@ -7083,8 +7559,12 @@ 
 		foreach($keys as $key)

 		{

 			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
+			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
 

 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

 			if (isset($this->fields[$key]['notnull']) && $this->fields[$key]['notnull'] == 1 && ! isset($values[$key]) && is_null($val['default']))

@@ -7094,11 +7574,17 @@ 
 			}

 

 			// If field is an implicit foreign key field

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) $values[$key]='null';

-			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) $values[$key]='null';

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && empty($values[$key])) {
+			    $values[$key]='null';
+			}
+			if (! empty($this->fields[$key]['foreignkey']) && empty($values[$key])) {
+			    $values[$key]='null';
+			}
 		}

 

-		if ($error) return -1;

+		if ($error) {
+		    return -1;
+		}
 

 		$this->db->begin();

 

@@ -7124,7 +7610,9 @@ 
 		if (! $error)

 		{

 			$result=$this->insertExtraFields();

-			if ($result < 0) $error++;

+			if ($result < 0) {
+			    $error++;
+			}
 		}

 

 		// Triggers

@@ -7157,15 +7645,24 @@ 
 	 */

 	public function fetchCommon($id, $ref = null, $morewhere = '')

 	{

-		if (empty($id) && empty($ref) && empty($morewhere)) return -1;

+		if (empty($id) && empty($ref) && empty($morewhere)) {
+		    return -1;
+		}
 

 		$sql = 'SELECT '.$this->getFieldList();

 		$sql.= ' FROM '.MAIN_DB_PREFIX.$this->table_element;

 

-		if (!empty($id))  $sql.= ' WHERE rowid = '.$id;

-		elseif (!empty($ref)) $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);

-		else $sql.=' WHERE 1 = 1';	// usage with empty id and empty ref is very rare

-		if ($morewhere)   $sql.= $morewhere;

+		if (!empty($id)) {
+		    $sql.= ' WHERE rowid = '.$id;
+		} elseif (!empty($ref)) {
+		    $sql.= " WHERE ref = ".$this->quote($ref, $this->fields['ref']);
+		} else {
+		    $sql.=' WHERE 1 = 1';
+		}
+		// usage with empty id and empty ref is very rare

+		if ($morewhere) {
+		    $sql.= $morewhere;
+		}
 		$sql.=' LIMIT 1';	// This is a fetch, to be sure to get only one record

 

 		$res = $this->db->query($sql);

@@ -7176,13 +7673,11 @@ 
 			{

 				$this->setVarsFromFetchObj($obj);

 				return $this->id;

-			}

-			else

+			} else

 			{

 				return 0;

 			}

-		}

-		else

+		} else

 		{

 			$this->error = $this->db->lasterror();

 			$this->errors[] = $this->error;

@@ -7206,8 +7701,12 @@ 
 		$now=dol_now();

 

 		$fieldvalues = $this->setSaveQuery();

-		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) $fieldvalues['date_modification']=$this->db->idate($now);

-		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) $fieldvalues['fk_user_modif']=$user->id;

+		if (array_key_exists('date_modification', $fieldvalues) && empty($fieldvalues['date_modification'])) {
+		    $fieldvalues['date_modification']=$this->db->idate($now);
+		}
+		if (array_key_exists('fk_user_modif', $fieldvalues) && ! ($fieldvalues['fk_user_modif'] > 0)) {
+		    $fieldvalues['fk_user_modif']=$user->id;
+		}
 		unset($fieldvalues['rowid']);	// The field 'rowid' is reserved field name for autoincrement field so we don't need it into update.

 

 		$keys=array();

@@ -7222,8 +7721,14 @@ 
 		// Clean and check mandatory

 		foreach($keys as $key)

 		{

-			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') $values[$key]='';		// This is an implicit foreign key field

-			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') $values[$key]='';					// This is an explicit foreign key field

+			if (preg_match('/^integer:/i', $this->fields[$key]['type']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
+			// This is an implicit foreign key field

+			if (! empty($this->fields[$key]['foreignkey']) && $values[$key] == '-1') {
+			    $values[$key]='';
+			}
+			// This is an explicit foreign key field

 

 			//var_dump($key.'-'.$values[$key].'-'.($this->fields[$key]['notnull'] == 1));

 			/*

@@ -7303,10 +7808,11 @@ 
 					return -1;

 				}

 			}

-		}

-		elseif (! empty($this->fk_element) && ! empty($this->childtables))	// If object has childs linked with a foreign key field, we check all child tables.

+		} elseif (! empty($this->fk_element) && ! empty($this->childtables)) {
+		    // If object has childs linked with a foreign key field, we check all child tables.

 		{

-			$objectisused = $this->isObjectUsed($this->id);

+			$objectisused = $this->isObjectUsed($this->id);
+		}
 			if (! empty($objectisused))

 			{

 				dol_syslog(get_class($this)."::deleteCommon Can't delete record as it has some child", LOG_WARNING);

@@ -7413,7 +7919,9 @@ 
      */

     public function trimParameters($parameters)

     {

-        if (!is_array($parameters)) return;

+        if (!is_array($parameters)) {
+            return;
+        }
         foreach ($parameters as $parameter) {

             if (isset($this->$parameter)) {

                 $this->$parameter = trim($this->$parameter);

Base/Categorie.php

Braces +58 added lines, -40 removed lines

@@ -509,8 +509,9 @@ 
         if (!$error && !$notrigger) {

             // Call trigger

             $result = $this->call_trigger('CATEGORY_DELETE', $user);

-            if ($result < 0)

-                $error++;

+            if ($result < 0) {
+                            $error++;
+            }
             // End call triggers

         }

 

@@ -580,8 +581,9 @@ 
 

         $error = 0;

 

-        if ($this->id == -1)

-            return -2;

+        if ($this->id == -1) {
+                    return -2;
+        }
 

         Config::$dbEngine->begin();

 

@@ -1089,15 +1091,18 @@ 
     function get_all_categories($type = null, $parent = false)

     {

         // phpcs:enable

-        if (!is_numeric($type))

-            $type = $this->MAP_ID[$type];

+        if (!is_numeric($type)) {
+                    $type = $this->MAP_ID[$type];
+        }
 

         $sql = "SELECT rowid FROM " . MAIN_DB_PREFIX . "categorie";

         $sql .= " WHERE entity IN (" . getEntity('category') . ")";

-        if (!is_null($type))

-            $sql .= " AND type = " . $type;

-        if ($parent)

-            $sql .= " AND fk_parent = 0";

+        if (!is_null($type)) {
+                    $sql .= " AND type = " . $type;
+        }
+        if ($parent) {
+                    $sql .= " AND fk_parent = 0";
+        }
 

         $res = Config::$dbEngine->select($sql);

         if ($res) {

@@ -1125,8 +1130,9 @@ 
         // phpcs:enable

         $type = $this->type;

 

-        if (!is_numeric($type))

-            $type = $this->MAP_ID[$type];

+        if (!is_numeric($type)) {
+                    $type = $this->MAP_ID[$type];
+        }
 

         /* We have to select any rowid from llx_categorie which category's mother and label

          * are equals to those of the calling category

@@ -1203,8 +1209,9 @@ 
                         // Check contrast with background and correct text color

                         $forced_color = 'categtextwhite';

                         if ($cat->color) {

-                            if (colorIsLight($cat->color))

-                                $forced_color = 'categtextblack';

+                            if (colorIsLight($cat->color)) {
+                                                            $forced_color = 'categtextblack';
+                            }
                         }

                     }

                 }

@@ -1280,8 +1287,9 @@ 
             }

         }

 

-        if (count($ways) == 0)

-            $ways[0][0] = $this;

+        if (count($ways) == 0) {
+                    $ways[0][0] = $this;
+        }
 

         return $ways;

     }

@@ -1300,8 +1308,9 @@ 
     {

         $cats = array();

 

-        if (is_numeric($type))

-            $type = Categorie::$MAP_ID_TO_CODE[$type];

+        if (is_numeric($type)) {
+                    $type = Categorie::$MAP_ID_TO_CODE[$type];
+        }
 

         if ($type === Categorie::TYPE_BANK_LINE) {   // TODO Remove this with standard category code

             // Load bank groups

@@ -1389,12 +1398,14 @@ 
         $sql .= " WHERE type = " . $this->MAP_ID[$type];

         $sql .= " AND entity IN (" . getEntity('category') . ")";

         if ($nom) {

-            if (!$exact)

-                $nom = '%' . str_replace('*', '%', $nom) . '%';

-            if (!$case)

-                $sql .= " AND label LIKE '" . Config::$dbEngine->escape($nom) . "'";

-            else

-                $sql .= " AND label LIKE BINARY '" . Config::$dbEngine->escape($nom) . "'";

+            if (!$exact) {
+                            $nom = '%' . str_replace('*', '%', $nom) . '%';
+            }
+            if (!$case) {
+                            $sql .= " AND label LIKE '" . Config::$dbEngine->escape($nom) . "'";
+            } else {
+                            $sql .= " AND label LIKE BINARY '" . Config::$dbEngine->escape($nom) . "'";
+            }
         }

         if ($id) {

             $sql .= " AND rowid = '" . $id . "'";

@@ -1434,8 +1445,9 @@ 
         // Check contrast with background and correct text color

         $forced_color = 'categtextwhite';

         if ($this->color) {

-            if (colorIsLight($this->color))

-                $forced_color = 'categtextblack';

+            if (colorIsLight($this->color)) {
+                            $forced_color = 'categtextblack';
+            }
         }

 

         $link = '<a href="' . DOL_URL_ROOT . '/categories/viewcat.php?id=' . $this->id . '&type=' . $this->type . '&backtopage=' . urlencode($_SERVER['PHP_SELF']) . '" title="' . dol_escape_htmltag($label, 1) . '" class="classfortooltip ' . $forced_color . '">';

@@ -1444,12 +1456,15 @@ 
         $picto = 'category';

 

 

-        if ($withpicto)

-            $result .= ($link . img_object($label, $picto, 'class="classfortooltip"') . $linkend);

-        if ($withpicto && $withpicto != 2)

-            $result .= ' ';

-        if ($withpicto != 2)

-            $result .= $link . dol_trunc(($this->ref ? $this->ref : $this->label), $maxlength) . $linkend;

+        if ($withpicto) {
+                    $result .= ($link . img_object($label, $picto, 'class="classfortooltip"') . $linkend);
+        }
+        if ($withpicto && $withpicto != 2) {
+                    $result .= ' ';
+        }
+        if ($withpicto != 2) {
+                    $result .= $link . dol_trunc(($this->ref ? $this->ref : $this->label), $maxlength) . $linkend;
+        }
         return $result;

     }

 

@@ -1537,16 +1552,18 @@ 
                         // Objet

                         $obj = array();

                         $obj['photo'] = $photo;

-                        if ($photo_vignette && is_file($dirthumb . $photo_vignette))

-                            $obj['photo_vignette'] = 'thumbs/' . $photo_vignette;

-                        else

-                            $obj['photo_vignette'] = "";

+                        if ($photo_vignette && is_file($dirthumb . $photo_vignette)) {
+                                                    $obj['photo_vignette'] = 'thumbs/' . $photo_vignette;
+                        } else {
+                                                    $obj['photo_vignette'] = "";
+                        }
 

                         $tabobj[$nbphoto - 1] = $obj;

 

                         // On continue ou on arrete de boucler

-                        if ($nbmax && $nbphoto >= $nbmax)

-                            break;

+                        if ($nbmax && $nbphoto >= $nbmax) {
+                                                    break;
+                        }
                     }

                 }

 

@@ -1650,8 +1667,9 @@ 
                 }

 

                 // on ne sauvegarde pas des champs vides

-                if ($this->multilangs["$key"]["label"] || $this->multilangs["$key"]["description"] || $this->multilangs["$key"]["note"])

-                    dol_syslog(get_class($this) . '::setMultiLangs', LOG_DEBUG);

+                if ($this->multilangs["$key"]["label"] || $this->multilangs["$key"]["description"] || $this->multilangs["$key"]["note"]) {
+                                    dol_syslog(get_class($this) . '::setMultiLangs', LOG_DEBUG);
+                }
                 if (!Config::$dbEngine->query($sql2)) {

                     $this->error = Config::$dbEngine->lasterror();

                     return -1;

Helpers/DolUtils.php

Braces +1363 added lines, -981 removed lines

@@ -75,8 +75,9 @@ 
           if ($found) return $result;

           } */

 

-        if (isset($class::$member))

-            return $class::$member;

+        if (isset($class::$member)) {
+                    return $class::$member;
+        }
         dol_print_error('', 'Try to get a static member "' . $member . '" in class "' . $class . '" that does not exists or is not static.');

         return null;

     }

@@ -127,8 +128,9 @@ 
         } else {

             $out = '';

             $addzero = array('user', 'usergroup', 'c_email_templates', 'email_template', 'default_values');

-            if (in_array($element, $addzero))

-                $out .= '0,';

+            if (in_array($element, $addzero)) {
+                            $out .= '0,';
+            }
             $out .= Globals::$conf->entity;

             return $out;

         }

@@ -307,32 +309,35 @@ 
     {

         // global $mysoc, $user, Globals::$conf;

 

-        if (empty($paramname))

-            return 'BadFirstParameterForDolUtils::GETPOST';

+        if (empty($paramname)) {
+                    return 'BadFirstParameterForDolUtils::GETPOST';
+        }
         if (empty($check)) {

             DolUtils::dol_syslog("Deprecated use of DolUtils::GETPOST, called with 1st param = " . $paramname . " and 2nd param is '', when calling page " . $_SERVER["PHP_SELF"], LOG_WARNING);

             // Enable this line to know who call the DolUtils::GETPOST with '' $check parameter.

             //var_dump(debug_backtrace()[0]);

         }

 

-        if (empty($method))

-            $out = isset($_GET[$paramname]) ? $_GET[$paramname] : (isset($_POST[$paramname]) ? $_POST[$paramname] : '');

-        elseif ($method == 1)

-            $out = isset($_GET[$paramname]) ? $_GET[$paramname] : '';

-        elseif ($method == 2)

-            $out = isset($_POST[$paramname]) ? $_POST[$paramname] : '';

-        elseif ($method == 3)

-            $out = isset($_POST[$paramname]) ? $_POST[$paramname] : (isset($_GET[$paramname]) ? $_GET[$paramname] : '');

-        elseif ($method == 4)

-            $out = isset($_POST[$paramname]) ? $_POST[$paramname] : (isset($_GET[$paramname]) ? $_GET[$paramname] : (isset($_COOKIE[$paramname]) ? $_COOKIE[$paramname] : ''));

-        else

-            return 'BadThirdParameterForDolUtils::GETPOST';

+        if (empty($method)) {
+                    $out = isset($_GET[$paramname]) ? $_GET[$paramname] : (isset($_POST[$paramname]) ? $_POST[$paramname] : '');
+        } elseif ($method == 1) {
+                    $out = isset($_GET[$paramname]) ? $_GET[$paramname] : '';
+        } elseif ($method == 2) {
+                    $out = isset($_POST[$paramname]) ? $_POST[$paramname] : '';
+        } elseif ($method == 3) {
+                    $out = isset($_POST[$paramname]) ? $_POST[$paramname] : (isset($_GET[$paramname]) ? $_GET[$paramname] : '');
+        } elseif ($method == 4) {
+                    $out = isset($_POST[$paramname]) ? $_POST[$paramname] : (isset($_GET[$paramname]) ? $_GET[$paramname] : (isset($_COOKIE[$paramname]) ? $_COOKIE[$paramname] : ''));
+        } else {
+                    return 'BadThirdParameterForDolUtils::GETPOST';
+        }
 

         if (empty($method) || $method == 3 || $method == 4) {

             $relativepathstring = $_SERVER["PHP_SELF"];

             // Clean $relativepathstring

-            if (constant('DOL_BASE_URI'))

-                $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);

+            if (constant('DOL_BASE_URI')) {
+                            $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);
+            }
             $relativepathstring = preg_replace('/^\//', '', $relativepathstring);

             $relativepathstring = preg_replace('/^custom\//', '', $relativepathstring);

             //var_dump($relativepathstring);

@@ -381,14 +386,17 @@ 
                                         $tmpqueryarraywehave = explode('&', dol_string_nohtmltag($_SERVER['QUERY_STRING']));

                                         $foundintru = 0;

                                         foreach ($tmpqueryarraytohave as $tmpquerytohave) {

-                                            if (!in_array($tmpquerytohave, $tmpqueryarraywehave))

-                                                $foundintru = 1;

+                                            if (!in_array($tmpquerytohave, $tmpqueryarraywehave)) {
+                                                                                            $foundintru = 1;
+                                            }
                                         }

-                                        if (!$foundintru)

-                                            $qualified = 1;

+                                        if (!$foundintru) {
+                                                                                    $qualified = 1;
+                                        }
                                         //var_dump($defkey.'-'.$qualified);

-                                    } else

-                                        $qualified = 1;

+                                    } else {
+                                                                            $qualified = 1;
+                                    }
 

                                     if ($qualified) {

                                         //var_dump($user->default_values[$relativepathstring][$defkey]['createform']);

@@ -415,20 +423,24 @@ 
                                             $tmpqueryarraywehave = explode('&', dol_string_nohtmltag($_SERVER['QUERY_STRING']));

                                             $foundintru = 0;

                                             foreach ($tmpqueryarraytohave as $tmpquerytohave) {

-                                                if (!in_array($tmpquerytohave, $tmpqueryarraywehave))

-                                                    $foundintru = 1;

+                                                if (!in_array($tmpquerytohave, $tmpqueryarraywehave)) {
+                                                                                                    $foundintru = 1;
+                                                }
                                             }

-                                            if (!$foundintru)

-                                                $qualified = 1;

+                                            if (!$foundintru) {
+                                                                                            $qualified = 1;
+                                            }
                                             //var_dump($defkey.'-'.$qualified);

-                                        } else

-                                            $qualified = 1;

+                                        } else {
+                                                                                    $qualified = 1;
+                                        }
 

                                         if ($qualified) {

                                             $forbidden_chars_to_replace = array(" ", "'", "/", "\\", ":", "*", "?", "\"", "<", ">", "|", "[", "]", ";", "=");  // we accept _, -, . and ,

                                             foreach ($user->default_values[$relativepathstring]['sortorder'][$defkey] as $key => $val) {

-                                                if ($out)

-                                                    $out .= ', ';

+                                                if ($out) {
+                                                                                                    $out .= ', ';
+                                                }
                                                 if ($paramname == 'sortfield') {

                                                     $out .= dol_string_nospecial($key, '', $forbidden_chars_to_replace);

                                                 }

@@ -448,14 +460,17 @@ 
                                         $tmpqueryarraywehave = explode('&', dol_string_nohtmltag($_SERVER['QUERY_STRING']));

                                         $foundintru = 0;

                                         foreach ($tmpqueryarraytohave as $tmpquerytohave) {

-                                            if (!in_array($tmpquerytohave, $tmpqueryarraywehave))

-                                                $foundintru = 1;

+                                            if (!in_array($tmpquerytohave, $tmpqueryarraywehave)) {
+                                                                                            $foundintru = 1;
+                                            }
                                         }

-                                        if (!$foundintru)

-                                            $qualified = 1;

+                                        if (!$foundintru) {
+                                                                                    $qualified = 1;
+                                        }
                                         //var_dump($defkey.'-'.$qualified);

-                                    } else

-                                        $qualified = 1;

+                                    } else {
+                                                                            $qualified = 1;
+                                    }
 

                                     if ($qualified) {

                                         if (isset($_POST['sall']) || isset($_POST['search_all']) || isset($_GET['sall']) || isset($_GET['search_all'])) {

@@ -527,8 +542,10 @@ 
                     $newout = $user->fk_user;

                 } elseif ($reg[1] == 'ENTITY_ID' || $reg[1] == 'ENTITYID') {

                     $newout = Globals::$conf->entity;

-                } else

-                    $newout = '';     // Key not found, we replace with empty string

+                } else {
+                                    $newout = '';
+                }
+                // Key not found, we replace with empty string

 

 

 

@@ -587,18 +604,20 @@ 
                 }

                 break;

             case 'intcomma':

-                if (preg_match('/[^0-9,-]+/i', $out))

-                    $out = '';

+                if (preg_match('/[^0-9,-]+/i', $out)) {
+                                    $out = '';
+                }
                 break;

             case 'alpha':

                 if (!is_array($out)) {

                     $out = trim($out);

                     // '"' is dangerous because param in url can close the href= or src= and add javascript functions.

                     // '../' is dangerous because it allows dir transversals

-                    if (preg_match('/"/', $out))

-                        $out = '';

-                    else if (preg_match('/\.\.\//', $out))

-                        $out = '';

+                    if (preg_match('/"/', $out)) {
+                                            $out = '';
+                    } else if (preg_match('/\.\.\//', $out)) {
+                                            $out = '';
+                    }
                 }

                 break;

             case 'san_alpha':

@@ -607,27 +626,31 @@ 
             case 'aZ':

                 if (!is_array($out)) {

                     $out = trim($out);

-                    if (preg_match('/[^a-z]+/i', $out))

-                        $out = '';

+                    if (preg_match('/[^a-z]+/i', $out)) {
+                                            $out = '';
+                    }
                 }

                 break;

             case 'aZ09':

                 if (!is_array($out)) {

                     $out = trim($out);

-                    if (preg_match('/[^a-z0-9_\-\.]+/i', $out))

-                        $out = '';

+                    if (preg_match('/[^a-z0-9_\-\.]+/i', $out)) {
+                                            $out = '';
+                    }
                 }

                 break;

             case 'aZ09comma':  // great to sanitize sortfield or sortorder params that can be t.abc,t.def_gh

                 if (!is_array($out)) {

                     $out = trim($out);

-                    if (preg_match('/[^a-z0-9_\-\.,]+/i', $out))

-                        $out = '';

+                    if (preg_match('/[^a-z0-9_\-\.,]+/i', $out)) {
+                                            $out = '';
+                    }
                 }

                 break;

             case 'array':

-                if (!is_array($out) || empty($out))

-                    $out = array();

+                if (!is_array($out) || empty($out)) {
+                                    $out = array();
+                }
                 break;

             case 'nohtml':  // Recommended for most scalar parameters

                 $out = dol_string_nohtmltag($out, 0);

@@ -637,16 +660,18 @@ 
                     $out = trim($out);

                     // '"' is dangerous because param in url can close the href= or src= and add javascript functions.

                     // '../' is dangerous because it allows dir transversals

-                    if (preg_match('/"/', $out))

-                        $out = '';

-                    else if (preg_match('/\.\.\//', $out))

-                        $out = '';

+                    if (preg_match('/"/', $out)) {
+                                            $out = '';
+                    } else if (preg_match('/\.\.\//', $out)) {
+                                            $out = '';
+                    }
                     $out = dol_string_nohtmltag($out);

                 }

                 break;

             case 'custom':

-                if (empty($filter))

-                    return 'BadFourthParameterForDolUtils::GETPOST';

+                if (empty($filter)) {
+                                    return 'BadFourthParameterForDolUtils::GETPOST';
+                }
                 $out = filter_var($out, $filter, $options);

                 break;

         }

@@ -764,11 +789,11 @@ 
                 }

             }

             if ($returnemptyifnotfound) {        // Not found into alternate dir

-                if ($returnemptyifnotfound == 1 || !file_exists($res))

-                    return '';

+                if ($returnemptyifnotfound == 1 || !file_exists($res)) {
+                                    return '';
+                }
             }

-        }

-        else {    // For an url path

+        } else {    // For an url path

 // We try to get local path of file on filesystem from url

 // Note that trying to know if a file on disk exist by forging path on disk from url

 // works only for some web server and some setup. This is bugged when

@@ -862,12 +887,14 @@ 
     static function dol_size($size, $type = '')

     {

         //global Globals::$conf;

-        if (empty(Globals::$conf->dol_optimize_smallscreen))

-            return $size;

-        if ($type == 'width' && $size > 250)

-            return 250;

-        else

-            return 10;

+        if (empty(Globals::$conf->dol_optimize_smallscreen)) {
+                    return $size;
+        }
+        if ($type == 'width' && $size > 250) {
+                    return 250;
+        } else {
+                    return 10;
+        }
     }

 

     /**

@@ -967,9 +994,10 @@ 
     {

         $forbidden_chars_to_replace = array(" ", "'", "/", "\\", ":", "*", "?", "\"", "<", ">", "|", "[", "]", ",", ";", "=", '°');  // more complete than dol_sanitizeFileName

         $forbidden_chars_to_remove = array();

-        if (is_array($badcharstoreplace))

-            $forbidden_chars_to_replace = $badcharstoreplace;

-//$forbidden_chars_to_remove=array("(",")");

+        if (is_array($badcharstoreplace)) {
+                    $forbidden_chars_to_replace = $badcharstoreplace;
+        }
+        //$forbidden_chars_to_remove=array("(",")");

 

         return str_replace($forbidden_chars_to_replace, $newstr, str_replace($forbidden_chars_to_remove, "", $str));

     }

@@ -1005,9 +1033,9 @@ 
         if (empty($mode)) {

             $substitjs["'"] = "\\'";

             $substitjs['"'] = "\\'";

-        } else if ($mode == 1)

-            $substitjs["'"] = "\\'";

-        else if ($mode == 2) {

+        } else if ($mode == 1) {
+                    $substitjs["'"] = "\\'";
+        } else if ($mode == 2) {

             $substitjs['"'] = '\\"';

         } else if ($mode == 3) {

             $substitjs["'"] = "\\'";

@@ -1029,10 +1057,12 @@ 
     {

 // escape quotes and backslashes, newlines, etc.

         $tmp = html_entity_decode($stringtoescape, ENT_COMPAT, 'UTF-8');  // TODO Use htmlspecialchars_decode instead, that make only required change for html tags

-        if (!$keepb)

-            $tmp = strtr($tmp, array("<b>" => '', '</b>' => ''));

-        if (!$keepn)

-            $tmp = strtr($tmp, array("\r" => '\\r', "\n" => '\\n'));

+        if (!$keepb) {
+                    $tmp = strtr($tmp, array("<b>" => '', '</b>' => ''));
+        }
+        if (!$keepn) {
+                    $tmp = strtr($tmp, array("\r" => '\\r', "\n" => '\\n'));
+        }
         return htmlentities($tmp, ENT_COMPAT, 'UTF-8');      // TODO Use htmlspecialchars instead, that make only required change for html tags

     }

 

@@ -1082,8 +1112,9 @@ 
     {

         // global Globals::$conf, $user;

 // If syslog module enabled

-        if (empty(Globals::$conf->syslog->enabled))

-            return;

+        if (empty(Globals::$conf->syslog->enabled)) {
+                    return;
+        }
 

         if ($ident < 0) {

             foreach (Globals::$conf->loghandlers as $loghandlerinstance) {

@@ -1097,8 +1128,9 @@ 
             if (!in_array($level, $logLevels, true)) {

                 throw new Exception('Incorrect log level');

             }

-            if ($level > Globals::$conf->global->SYSLOG_LEVEL)

-                return;

+            if ($level > Globals::$conf->global->SYSLOG_LEVEL) {
+                            return;
+            }
 

             $message = preg_replace('/password=\'[^\']*\'/', 'password=\'hidden\'', $message); // protection to avoid to have value of password in log

 // If adding log inside HTML page is required

@@ -1123,24 +1155,30 @@ 
             );

 

 // This is when server run behind a reverse proxy

-            if (!empty($_SERVER['HTTP_X_FORWARDED_FOR']))

-                $data['ip'] = $_SERVER['HTTP_X_FORWARDED_FOR'] . (empty($_SERVER["REMOTE_ADDR"]) ? '' : '->' . $_SERVER['REMOTE_ADDR']);

-// This is when server run normally on a server

-            else if (!empty($_SERVER["REMOTE_ADDR"]))

-                $data['ip'] = $_SERVER['REMOTE_ADDR'];

-// This is when PHP session is ran inside a web server but not inside a client request (example: init code of apache)

-            else if (!empty($_SERVER['SERVER_ADDR']))

-                $data['ip'] = $_SERVER['SERVER_ADDR'];

-// This is when PHP session is ran outside a web server, like from Windows command line (Not always defined, but useful if OS defined it).

-            else if (!empty($_SERVER['COMPUTERNAME']))

-                $data['ip'] = $_SERVER['COMPUTERNAME'] . (empty($_SERVER['USERNAME']) ? '' : '@' . $_SERVER['USERNAME']);

-// This is when PHP session is ran outside a web server, like from Linux command line (Not always defined, but usefull if OS defined it).

-            else if (!empty($_SERVER['LOGNAME']))

-                $data['ip'] = '???@' . $_SERVER['LOGNAME'];

-// Loop on each log handler and send output

+            if (!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
+                            $data['ip'] = $_SERVER['HTTP_X_FORWARDED_FOR'] . (empty($_SERVER["REMOTE_ADDR"]) ? '' : '->' . $_SERVER['REMOTE_ADDR']);
+            }
+            // This is when server run normally on a server

+            else if (!empty($_SERVER["REMOTE_ADDR"])) {
+                            $data['ip'] = $_SERVER['REMOTE_ADDR'];
+            }
+            // This is when PHP session is ran inside a web server but not inside a client request (example: init code of apache)

+            else if (!empty($_SERVER['SERVER_ADDR'])) {
+                            $data['ip'] = $_SERVER['SERVER_ADDR'];
+            }
+            // This is when PHP session is ran outside a web server, like from Windows command line (Not always defined, but useful if OS defined it).

+            else if (!empty($_SERVER['COMPUTERNAME'])) {
+                            $data['ip'] = $_SERVER['COMPUTERNAME'] . (empty($_SERVER['USERNAME']) ? '' : '@' . $_SERVER['USERNAME']);
+            }
+            // This is when PHP session is ran outside a web server, like from Linux command line (Not always defined, but usefull if OS defined it).

+            else if (!empty($_SERVER['LOGNAME'])) {
+                            $data['ip'] = '???@' . $_SERVER['LOGNAME'];
+            }
+            // Loop on each log handler and send output

             foreach (Globals::$conf->loghandlers as $loghandlerinstance) {

-                if ($restricttologhandler && $loghandlerinstance->code != $restricttologhandler)

-                    continue;

+                if ($restricttologhandler && $loghandlerinstance->code != $restricttologhandler) {
+                                    continue;
+                }
                 $loghandlerinstance->export($data, $suffixinfilename);

             }

             unset($data);

@@ -1196,13 +1234,15 @@ 
 

 // Show title

         $showtitle = 1;

-        if (!empty(Globals::$conf->dol_optimize_smallscreen))

-            $showtitle = 0;

+        if (!empty(Globals::$conf->dol_optimize_smallscreen)) {
+                    $showtitle = 0;
+        }
         if (!empty($title) && $showtitle) {

             $limittitle = 30;

             $out .= '<a class="tabTitle">';

-            if ($picto)

-                $out .= img_picto($title, ($pictoisfullpath ? '' : 'object_') . $picto, '', $pictoisfullpath) . ' ';

+            if ($picto) {
+                            $out .= img_picto($title, ($pictoisfullpath ? '' : 'object_') . $picto, '', $pictoisfullpath) . ' ';
+            }
             $out .= '<span class="tabTitleText">' . dol_trunc($title, $limittitle) . '</span>';

             $out .= '</a>';

         }

@@ -1211,12 +1251,14 @@ 
         $maxkey = -1;

         if (is_array($links) && !empty($links)) {

             $keys = array_keys($links);

-            if (count($keys))

-                $maxkey = max($keys);

+            if (count($keys)) {
+                            $maxkey = max($keys);
+            }
         }

 

-        if (!empty(Globals::$conf->dol_optimize_smallscreen))

-            Globals::$conf->global->MAIN_MAXTABS_IN_CARD = 2;

+        if (!empty(Globals::$conf->dol_optimize_smallscreen)) {
+                    Globals::$conf->global->MAIN_MAXTABS_IN_CARD = 2;
+        }
 

 // Show tabs

         $bactive = false;

@@ -1229,8 +1271,9 @@ 
         for ($i = 0; $i <= $maxkey; $i++) {

             if ((is_numeric($active) && $i == $active) || (!empty($links[$i][2]) && !is_numeric($active) && $active == $links[$i][2])) {

 // If active tab is already present

-                if ($i >= $limittoshow)

-                    $limittoshow--;

+                if ($i >= $limittoshow) {
+                                    $limittoshow--;
+                }
             }

         }

 

@@ -1271,12 +1314,12 @@ 
                 }

                 $outmore .= '<div class="popuptab wordwrap" style="display:inherit;">';

                 if (isset($links[$i][2]) && $links[$i][2] == 'image') {

-                    if (!empty($links[$i][0]))

-                        $outmore .= '<a class="tabimage' . ($morecss ? ' ' . $morecss : '') . '" href="' . $links[$i][0] . '">' . $links[$i][1] . '</a>' . "\n";

-                    else

-                        $outmore .= '<span class="tabspan">' . $links[$i][1] . '</span>' . "\n";

-                }

-                else if (!empty($links[$i][1])) {

+                    if (!empty($links[$i][0])) {
+                                            $outmore .= '<a class="tabimage' . ($morecss ? ' ' . $morecss : '') . '" href="' . $links[$i][0] . '">' . $links[$i][1] . '</a>' . "\n";
+                    } else {
+                                            $outmore .= '<span class="tabspan">' . $links[$i][1] . '</span>' . "\n";
+                    }
+                } else if (!empty($links[$i][1])) {

                     $outmore .= '<a' . (!empty($links[$i][2]) ? ' id="' . $links[$i][2] . '"' : '') . ' class="wordwrap inline-block' . ($morecss ? ' ' . $morecss : '') . '" href="' . $links[$i][0] . '">';

                     $outmore .= preg_replace('/([a-z])\/([a-z])/i', '\\1 / \\2', $links[$i][1]); // Replace x/y with x / y to allow wrap on long composed texts.

                     $outmore .= '</a>' . "\n";

@@ -1287,8 +1330,9 @@ 
             }

             $displaytab = $i;

         }

-        if ($popuptab)

-            $outmore .= '</div>';

+        if ($popuptab) {
+                    $outmore .= '</div>';
+        }
 

         if ($displaytab > $limittoshow) {

             $left = (Globals::$langs->trans("DIRECTION") == 'rtl' ? 'right' : 'left');

@@ -1311,8 +1355,9 @@ 
 

         $out .= "</div>\n";

 

-        if (!$notab || $notab == -1)

-            $out .= "\n" . '<div class="tabBar' . ($notab == -1 ? '' : ' tabBarWithBottom') . '">' . "\n";

+        if (!$notab || $notab == -1) {
+                    $out .= "\n" . '<div class="tabBar' . ($notab == -1 ? '' : ' tabBarWithBottom') . '">' . "\n";
+        }
 

         $parameters = array('tabname' => $active, 'out' => $out);

         $reshook = Globals::$hookManager->executeHooks('printTabsHead', $parameters); // This hook usage is called just before output the head of tabs. Take also a look at "completeTabsHead"

@@ -1342,10 +1387,11 @@ 
      */

     static function dol_get_fiche_end($notab = 0)

     {

-        if (!$notab || $notab == -1)

-            return "\n</div>\n";

-        else

-            return '';

+        if (!$notab || $notab == -1) {
+                    return "\n</div>\n";
+        } else {
+                    return '';
+        }
     }

 

     /**

@@ -1377,8 +1423,9 @@ 
         $showimage = 1;

         $entity = (empty($object->entity) ? Globals::$conf->entity : $object->entity);

         $showbarcode = empty(Globals::$conf->barcode->enabled) ? 0 : ($object->barcode ? 1 : 0);

-        if (!empty(Globals::$conf->global->MAIN_USE_ADVANCED_PERMS) && empty($user->rights->barcode->lire_advance))

-            $showbarcode = 0;

+        if (!empty(Globals::$conf->global->MAIN_USE_ADVANCED_PERMS) && empty($user->rights->barcode->lire_advance)) {
+                    $showbarcode = 0;
+        }
         $modulepart = 'unknown';

 

         if ($object->element == 'societe') {

@@ -1483,8 +1530,10 @@ 
                         } else {

                             $subdir = get_exdir($object->id, 0, 0, 1, $object, $modulepart);

                         }

-                        if (empty($subdir))

-                            $subdir = 'errorgettingsubdirofobject'; // Protection to avoid to return empty path

+                        if (empty($subdir)) {
+                                                    $subdir = 'errorgettingsubdirofobject';
+                        }
+                        // Protection to avoid to return empty path

 

                         $filepath = $dir_output . $subdir . "/";

 

@@ -1505,14 +1554,16 @@ 
                                 if (empty(Globals::$conf->global->MAIN_DISABLE_PDF_THUMBS)) {  // If you experienc trouble with pdf thumb generation and imagick, you can disable here.

                                     include_once DOL_BASE_PATH . '/core/lib/files.lib.php';

                                     $ret = dol_convert_file($file, 'png', $fileimage);

-                                    if ($ret < 0)

-                                        $error++;

+                                    if ($ret < 0) {
+                                                                            $error++;
+                                    }
                                 }

                             }

 

                             $heightforphotref = 70;

-                            if (!empty(Globals::$conf->dol_optimize_smallscreen))

-                                $heightforphotref = 60;

+                            if (!empty(Globals::$conf->dol_optimize_smallscreen)) {
+                                                            $heightforphotref = 60;
+                            }
                             // Si fichier png PDF d'1 page trouve

                             if (file_exists($fileimage)) {

                                 $phototoshow = '<div class="floatleft inline-block valignmiddle divphotoref"><div class="photoref">';

@@ -1548,8 +1599,10 @@ 
                         $width = 14;

                         $cssclass = 'photorefcenter';

                         $picto = $object->picto;

-                        if ($object->element == 'project' && !$object->public)

-                            $picto = 'project'; // instead of projectpub

+                        if ($object->element == 'project' && !$object->public) {
+                                                    $picto = 'project';
+                        }
+                        // instead of projectpub

                         $nophoto = img_picto('', 'object_' . $picto, '', false, 1);

                     }

                     $morehtmlleft .= '<!-- No photo to show -->';

@@ -1560,8 +1613,9 @@ 
             }

         }

 

-        if ($showbarcode)

-            $morehtmlleft .= '<div class="floatleft inline-block valignmiddle divphotoref">' . $form->showbarcode($object) . '</div>';

+        if ($showbarcode) {
+                    $morehtmlleft .= '<div class="floatleft inline-block valignmiddle divphotoref">' . $form->showbarcode($object) . '</div>';
+        }
 

         if ($object->element == 'societe') {

             if (!empty(Globals::$conf->use_javascript_ajax) && $user->rights->societe->creer && !empty(Globals::$conf->global->MAIN_DIRECT_STATUS_UPDATE)) {

@@ -1585,35 +1639,37 @@ 
             }

         } elseif (in_array($object->element, array('facture', 'invoice', 'invoice_supplier', 'chargesociales', 'loan'))) {

             $tmptxt = $object->getLibStatut(6, $object->totalpaye);

-            if (empty($tmptxt) || $tmptxt == $object->getLibStatut(3) || Globals::$conf->browser->layout == 'phone')

-                $tmptxt = $object->getLibStatut(5, $object->totalpaye);

+            if (empty($tmptxt) || $tmptxt == $object->getLibStatut(3) || Globals::$conf->browser->layout == 'phone') {
+                            $tmptxt = $object->getLibStatut(5, $object->totalpaye);
+            }
             $morehtmlstatus .= $tmptxt;

-        }

-        elseif ($object->element == 'contrat' || $object->element == 'contract') {

-            if ($object->statut == 0)

-                $morehtmlstatus .= $object->getLibStatut(5);

-            else

-                $morehtmlstatus .= $object->getLibStatut(4);

-        }

-        elseif ($object->element == 'facturerec') {

-            if ($object->frequency == 0)

-                $morehtmlstatus .= $object->getLibStatut(2);

-            else

-                $morehtmlstatus .= $object->getLibStatut(5);

-        }

-        elseif ($object->element == 'project_task') {

+        } elseif ($object->element == 'contrat' || $object->element == 'contract') {

+            if ($object->statut == 0) {
+                            $morehtmlstatus .= $object->getLibStatut(5);
+            } else {
+                            $morehtmlstatus .= $object->getLibStatut(4);
+            }
+        } elseif ($object->element == 'facturerec') {

+            if ($object->frequency == 0) {
+                            $morehtmlstatus .= $object->getLibStatut(2);
+            } else {
+                            $morehtmlstatus .= $object->getLibStatut(5);
+            }
+        } elseif ($object->element == 'project_task') {

             $object->fk_statut = 1;

-            if ($object->progress > 0)

-                $object->fk_statut = 2;

-            if ($object->progress >= 100)

-                $object->fk_statut = 3;

+            if ($object->progress > 0) {
+                            $object->fk_statut = 2;
+            }
+            if ($object->progress >= 100) {
+                            $object->fk_statut = 3;
+            }
             $tmptxt = $object->getLibStatut(5);

             $morehtmlstatus .= $tmptxt;  // No status on task

-        }

-        else { // Generic case

+        } else { // Generic case

             $tmptxt = $object->getLibStatut(6);

-            if (empty($tmptxt) || $tmptxt == $object->getLibStatut(3) || Globals::$conf->browser->layout == 'phone')

-                $tmptxt = $object->getLibStatut(5);

+            if (empty($tmptxt) || $tmptxt == $object->getLibStatut(3) || Globals::$conf->browser->layout == 'phone') {
+                            $tmptxt = $object->getLibStatut(5);
+            }
             $morehtmlstatus .= $tmptxt;

         }

 

@@ -1627,13 +1683,15 @@ 
         }

 

 // Add alias for thirdparty

-        if (!empty($object->name_alias))

-            $morehtmlref .= '<div class="refidno">' . $object->name_alias . '</div>';

+        if (!empty($object->name_alias)) {
+                    $morehtmlref .= '<div class="refidno">' . $object->name_alias . '</div>';
+        }
 

 // Add label

         if ($object->element == 'product' || $object->element == 'bank_account' || $object->element == 'project_task') {

-            if (!empty($object->label))

-                $morehtmlref .= '<div class="refidno">' . $object->label . '</div>';

+            if (!empty($object->label)) {
+                            $morehtmlref .= '<div class="refidno">' . $object->label . '</div>';
+            }
         }

 

         if (method_exists($object, 'getBannerAddress') && $object->element != 'product' && $object->element != 'bookmark' && $object->element != 'ecm_directories' && $object->element != 'ecm_files') {

@@ -1666,15 +1724,19 @@ 
     {

         // global Globals::$conf, Globals::$langs;

         $ret = '';

-        if ($fieldrequired)

-            $ret .= '<span class="fieldrequired">';

-        if ((Globals::$conf->dol_use_jmobile != 4))

-            $ret .= '<label for="' . $fieldkey . '">';

+        if ($fieldrequired) {
+                    $ret .= '<span class="fieldrequired">';
+        }
+        if ((Globals::$conf->dol_use_jmobile != 4)) {
+                    $ret .= '<label for="' . $fieldkey . '">';
+        }
         $ret .= Globals::$langs->trans($langkey);

-        if ((Globals::$conf->dol_use_jmobile != 4))

-            $ret .= '</label>';

-        if ($fieldrequired)

-            $ret .= '</span>';

+        if ((Globals::$conf->dol_use_jmobile != 4)) {
+                    $ret .= '</label>';
+        }
+        if ($fieldrequired) {
+                    $ret .= '</span>';
+        }
         return $ret;

     }

 

@@ -1689,8 +1751,9 @@ 
     {

         // global $bc;

         $ret = ' ' . $bc[$var];

-        if ($moreclass)

-            $ret = preg_replace('/class=\"/', 'class="' . $moreclass . ' ', $ret);

+        if ($moreclass) {
+                    $ret = preg_replace('/class=\"/', 'class="' . $moreclass . ' ', $ret);
+        }
         return $ret;

     }

 

@@ -1721,18 +1784,18 @@ 
             if ($object->state) {

                 $ret .= ($ret ? ", " : '') . $object->state;

             }

-            if ($object->zip)

-                $ret .= ($ret ? ", " : '') . $object->zip;

-        }

-        else if (in_array($object->country_code, array('GB', 'UK'))) { // UK: title firstname name \n address lines \n town state \n zip \n country

+            if ($object->zip) {
+                            $ret .= ($ret ? ", " : '') . $object->zip;
+            }
+        } else if (in_array($object->country_code, array('GB', 'UK'))) { // UK: title firstname name \n address lines \n town state \n zip \n country

             $ret .= ($ret ? $sep : '' ) . $object->town;

             if ($object->state) {

                 $ret .= ($ret ? ", " : '') . $object->state;

             }

-            if ($object->zip)

-                $ret .= ($ret ? $sep : '' ) . $object->zip;

-        }

-        else if (in_array($object->country_code, array('ES', 'TR'))) { // ES: title firstname name \n address lines \n zip town \n state \n country

+            if ($object->zip) {
+                            $ret .= ($ret ? $sep : '' ) . $object->zip;
+            }
+        } else if (in_array($object->country_code, array('ES', 'TR'))) { // ES: title firstname name \n address lines \n zip town \n state \n country

             $ret .= ($ret ? $sep : '' ) . $object->zip;

             $ret .= ($object->town ? (($object->zip ? ' ' : '') . $object->town) : '');

             if ($object->state) {

@@ -1749,8 +1812,9 @@ 
                 $ret .= ($ret ? ", " : '') . $object->state;

             }

         }

-        if (!is_object($outputlangs))

-            $outputlangs = Globals::$langs;

+        if (!is_object($outputlangs)) {
+                    $outputlangs = Globals::$langs;
+        }
         if ($withcountry) {

             Globals::$langs->load("dict");

             $ret .= ($object->country_code ? ($ret ? $sep : '') . $outputlangs->convToOutputCharset($outputlangs->transnoentitiesnoconv("Country" . $object->country_code)) : '');

@@ -1771,8 +1835,9 @@ 
     {

         if ((abs($ts) <= 0x7FFFFFFF)) { // check if number in 32-bit signed range

             return ($is_gmt) ? @gmstrftime($fmt, $ts) : @strftime($fmt, $ts);

-        } else

-            return 'Error date into a not supported range';

+        } else {
+                    return 'Error date into a not supported range';
+        }
     }

 

     /**

@@ -1818,10 +1883,12 @@ 
                 }

             }

         }

-        if (!is_object($outputlangs))

-            $outputlangs = Globals::$langs;

-        if (!$format)

-            $format = 'daytextshort';

+        if (!is_object($outputlangs)) {
+                    $outputlangs = Globals::$langs;
+        }
+        if (!$format) {
+                    $format = 'daytextshort';
+        }
         $reduceformat = (!empty(Globals::$conf->dol_optimize_smallscreen) && in_array($format, array('day', 'dayhour'))) ? 1 : 0;

         $formatwithoutreduce = preg_replace('/reduceformat/', '', $format);

         if ($formatwithoutreduce != $format) {

@@ -1830,40 +1897,46 @@ 
         }  // so format 'dayreduceformat' is processed like day

 // Change predefined format into computer format. If found translation in lang file we use it, otherwise we use default.

 // TODO Add format daysmallyear and dayhoursmallyear

-        if ($format == 'day')

-            $format = ($outputlangs->trans("FormatDateShort") != "FormatDateShort" ? $outputlangs->trans("FormatDateShort") : Globals::$conf->format_date_short);

-        else if ($format == 'hour')

-            $format = ($outputlangs->trans("FormatHourShort") != "FormatHourShort" ? $outputlangs->trans("FormatHourShort") : Globals::$conf->format_hour_short);

-        else if ($format == 'hourduration')

-            $format = ($outputlangs->trans("FormatHourShortDuration") != "FormatHourShortDuration" ? $outputlangs->trans("FormatHourShortDuration") : Globals::$conf->format_hour_short_duration);

-        else if ($format == 'daytext')

-            $format = ($outputlangs->trans("FormatDateText") != "FormatDateText" ? $outputlangs->trans("FormatDateText") : Globals::$conf->format_date_text);

-        else if ($format == 'daytextshort')

-// Notice: Undefined property: stdClass::$format_date_text_short in \alixar\dolibarr\htdocs\core\lib\functions.lib.php on line 1781

-            $format = ($outputlangs->trans("FormatDateTextShort") != "FormatDateTextShort" ? $outputlangs->trans("FormatDateTextShort") : Globals::$conf->format_date_text_short);

-        else if ($format == 'dayhour')

-            $format = ($outputlangs->trans("FormatDateHourShort") != "FormatDateHourShort" ? $outputlangs->trans("FormatDateHourShort") : Globals::$conf->format_date_hour_short ?? "%d/%m/%Y %H:%M");

-        else if ($format == 'dayhoursec')

-            $format = ($outputlangs->trans("FormatDateHourSecShort") != "FormatDateHourSecShort" ? $outputlangs->trans("FormatDateHourSecShort") : Globals::$conf->format_date_hour_sec_short);

-        else if ($format == 'dayhourtext')

-            $format = ($outputlangs->trans("FormatDateHourText") != "FormatDateHourText" ? $outputlangs->trans("FormatDateHourText") : Globals::$conf->format_date_hour_text);

-        else if ($format == 'dayhourtextshort')

-            $format = ($outputlangs->trans("FormatDateHourTextShort") != "FormatDateHourTextShort" ? $outputlangs->trans("FormatDateHourTextShort") : Globals::$conf->format_date_hour_text_short);

-// Format not sensitive to language

-        else if ($format == 'dayhourlog')

-            $format = '%Y%m%d%H%M%S';

-        else if ($format == 'dayhourldap')

-            $format = '%Y%m%d%H%M%SZ';

-        else if ($format == 'dayhourxcard')

-            $format = '%Y%m%dT%H%M%SZ';

-        else if ($format == 'dayxcard')

-            $format = '%Y%m%d';

-        else if ($format == 'dayrfc')

-            $format = '%Y-%m-%d';             // DATE_RFC3339

-        else if ($format == 'dayhourrfc')

-            $format = '%Y-%m-%dT%H:%M:%SZ';   // DATETIME RFC3339

-        else if ($format == 'standard')

-            $format = '%Y-%m-%d %H:%M:%S';

+        if ($format == 'day') {
+                    $format = ($outputlangs->trans("FormatDateShort") != "FormatDateShort" ? $outputlangs->trans("FormatDateShort") : Globals::$conf->format_date_short);
+        } else if ($format == 'hour') {
+                    $format = ($outputlangs->trans("FormatHourShort") != "FormatHourShort" ? $outputlangs->trans("FormatHourShort") : Globals::$conf->format_hour_short);
+        } else if ($format == 'hourduration') {
+                    $format = ($outputlangs->trans("FormatHourShortDuration") != "FormatHourShortDuration" ? $outputlangs->trans("FormatHourShortDuration") : Globals::$conf->format_hour_short_duration);
+        } else if ($format == 'daytext') {
+                    $format = ($outputlangs->trans("FormatDateText") != "FormatDateText" ? $outputlangs->trans("FormatDateText") : Globals::$conf->format_date_text);
+        } else if ($format == 'daytextshort') {
+            // Notice: Undefined property: stdClass::$format_date_text_short in \alixar\dolibarr\htdocs\core\lib\functions.lib.php on line 1781

+            $format = ($outputlangs->trans("FormatDateTextShort") != "FormatDateTextShort" ? $outputlangs->trans("FormatDateTextShort") : Globals::$conf->format_date_text_short);
+        } else if ($format == 'dayhour') {
+                    $format = ($outputlangs->trans("FormatDateHourShort") != "FormatDateHourShort" ? $outputlangs->trans("FormatDateHourShort") : Globals::$conf->format_date_hour_short ?? "%d/%m/%Y %H:%M");
+        } else if ($format == 'dayhoursec') {
+                    $format = ($outputlangs->trans("FormatDateHourSecShort") != "FormatDateHourSecShort" ? $outputlangs->trans("FormatDateHourSecShort") : Globals::$conf->format_date_hour_sec_short);
+        } else if ($format == 'dayhourtext') {
+                    $format = ($outputlangs->trans("FormatDateHourText") != "FormatDateHourText" ? $outputlangs->trans("FormatDateHourText") : Globals::$conf->format_date_hour_text);
+        } else if ($format == 'dayhourtextshort') {
+                    $format = ($outputlangs->trans("FormatDateHourTextShort") != "FormatDateHourTextShort" ? $outputlangs->trans("FormatDateHourTextShort") : Globals::$conf->format_date_hour_text_short);
+        }
+        // Format not sensitive to language

+        else if ($format == 'dayhourlog') {
+                    $format = '%Y%m%d%H%M%S';
+        } else if ($format == 'dayhourldap') {
+                    $format = '%Y%m%d%H%M%SZ';
+        } else if ($format == 'dayhourxcard') {
+                    $format = '%Y%m%dT%H%M%SZ';
+        } else if ($format == 'dayxcard') {
+                    $format = '%Y%m%d';
+        } else if ($format == 'dayrfc') {
+                    $format = '%Y-%m-%d';
+        }
+        // DATE_RFC3339

+        else if ($format == 'dayhourrfc') {
+                    $format = '%Y-%m-%dT%H:%M:%SZ';
+        }
+        // DATETIME RFC3339

+        else if ($format == 'standard') {
+                    $format = '%Y-%m-%d %H:%M:%S';
+        }
 

         if ($reduceformat) {

             $format = str_replace('%Y', '%y', $format);

@@ -1871,8 +1944,10 @@ 
         }

 

 // If date undefined or "", we return ""

-        if (DolUtils::dol_strlen($time) == 0)

-            return '';  // $time=0 allowed (it means 01/01/1970 00:00:00)

+        if (DolUtils::dol_strlen($time) == 0) {
+                    return '';
+        }
+        // $time=0 allowed (it means 01/01/1970 00:00:00)

 

 

 

@@ -1950,8 +2025,9 @@ 
                 $timetouse = $time + $offsettz + $offsetdst; // TODO Replace this with static function Date PHP. We also should not use anymore offsettz and offsetdst but only offsettzstring.

 

                 $ret = adodb_strftime($format, $timetouse, $to_gmt);

-            } else

-                $ret = 'Bad value ' . $time . ' for date';

+            } else {
+                            $ret = 'Bad value ' . $time . ' for date';
+            }
         }

 

         if (preg_match('/__b__/i', $format)) {

@@ -2022,10 +2098,14 @@ 
         // global Globals::$conf;

 

         $usealternatemethod = false;

-        if ($timestamp <= 0)

-            $usealternatemethod = true;    // <= 1970

-        if ($timestamp >= 2145913200)

-            $usealternatemethod = true;  // >= 2038

+        if ($timestamp <= 0) {
+                    $usealternatemethod = true;
+        }
+        // <= 1970

+        if ($timestamp >= 2145913200) {
+                    $usealternatemethod = true;
+        }
+        // >= 2038

 

         if ($usealternatemethod) {

             $arrayinfo = adodb_getdate($timestamp, $fast);

@@ -2060,27 +2140,36 @@ 
         // global Globals::$conf;

 //print "- ".$hour.",".$minute.",".$second.",".$month.",".$day.",".$year.",".$_SERVER["WINDIR"]." -";

 // Clean parameters

-        if ($hour == -1 || empty($hour))

-            $hour = 0;

-        if ($minute == -1 || empty($minute))

-            $minute = 0;

-        if ($second == -1 || empty($second))

-            $second = 0;

+        if ($hour == -1 || empty($hour)) {
+                    $hour = 0;
+        }
+        if ($minute == -1 || empty($minute)) {
+                    $minute = 0;
+        }
+        if ($second == -1 || empty($second)) {
+                    $second = 0;
+        }
 

 // Check parameters

         if ($check) {

-            if (!$month || !$day)

-                return '';

-            if ($day > 31)

-                return '';

-            if ($month > 12)

-                return '';

-            if ($hour < 0 || $hour > 24)

-                return '';

-            if ($minute < 0 || $minute > 60)

-                return '';

-            if ($second < 0 || $second > 60)

-                return '';

+            if (!$month || !$day) {
+                            return '';
+            }
+            if ($day > 31) {
+                            return '';
+            }
+            if ($month > 12) {
+                            return '';
+            }
+            if ($hour < 0 || $hour > 24) {
+                            return '';
+            }
+            if ($minute < 0 || $minute > 60) {
+                            return '';
+            }
+            if ($second < 0 || $second > 60) {
+                            return '';
+            }
         }

 

         if (method_exists('DateTime', 'getTimestamp')) {

@@ -2137,8 +2226,10 @@ 
 

 // Note that gmmktime and mktime return same value (GMT) when used without parameters

 //if ($mode == 'gmt') $ret=gmmktime(); // Strict Standards: gmmktime(): You should be using the time() static function instead

-        if ($mode == 'gmt')

-            $ret = time(); // Time for now at greenwich.

+        if ($mode == 'gmt') {
+                    $ret = time();
+        }
+        // Time for now at greenwich.

         else if ($mode == 'tzserver') {  // Time for now with PHP server timezone added

             require_once DOL_BASE_PATH . '/core/lib/date.lib.php';

             $tzsecond = getServerTimeZoneInt('now');    // Contains tz+dayling saving time

@@ -2172,8 +2263,9 @@ 
         // global Globals::$conf, Globals::$langs;

         $level = 1024;

 

-        if (!empty(Globals::$conf->dol_optimize_smallscreen))

-            $shortunit = 1;

+        if (!empty(Globals::$conf->dol_optimize_smallscreen)) {
+                    $shortunit = 1;
+        }
 

 // Set value text

         if (empty($shortvalue) || $size < ($level * 10)) {

@@ -2208,19 +2300,23 @@ 
     {

         // global Globals::$langs;

 

-        if (empty($url))

-            return '';

+        if (empty($url)) {
+                    return '';
+        }
 

         $link = '<a href="';

-        if (!preg_match('/^http/i', $url))

-            $link .= 'http://';

+        if (!preg_match('/^http/i', $url)) {
+                    $link .= 'http://';
+        }
         $link .= $url;

         $link .= '"';

-        if ($target)

-            $link .= ' target="' . $target . '"';

+        if ($target) {
+                    $link .= ' target="' . $target . '"';
+        }
         $link .= '>';

-        if (!preg_match('/^http/i', $url))

-            $link .= 'http://';

+        if (!preg_match('/^http/i', $url)) {
+                    $link .= 'http://';
+        }
         $link .= dol_trunc($url, $max);

         $link .= '</a>';

         return '<div class="nospan float" style="margin-right: 10px">' . ($withpicto ? img_picto(Globals::$langs->trans("Url"), 'object_globe.png') . ' ' : '') . $link . '</div>';

@@ -2244,13 +2340,15 @@ 
 

         $newemail = $email;

 

-        if (empty($email))

-            return '&nbsp;';

+        if (empty($email)) {
+                    return '&nbsp;';
+        }
 

         if (!empty($addlink)) {

             $newemail = '<a style="text-overflow: ellipsis;" href="';

-            if (!preg_match('/^mailto:/i', $email))

-                $newemail .= 'mailto:';

+            if (!preg_match('/^mailto:/i', $email)) {
+                            $newemail .= 'mailto:';
+            }
             $newemail .= $email;

             $newemail .= '">';

             $newemail .= dol_trunc($email, $max);

@@ -2263,13 +2361,14 @@ 
             if (($cid || $socid) && !empty(Globals::$conf->agenda->enabled) && $user->rights->agenda->myactions->create) {

                 $type = 'AC_EMAIL';

                 $link = '';

-                if (!empty(Globals::$conf->global->AGENDA_ADDACTIONFOREMAIL))

-                    $link = '<a href="' . DOL_BASE_URI . '/comm/action/card.php?action=create&amp;backtopage=1&amp;actioncode=' . $type . '&amp;contactid=' . $cid . '&amp;socid=' . $socid . '">' . img_object(Globals::$langs->trans("AddAction"), "calendar") . '</a>';

-                if ($link)

-                    $newemail = '<div>' . $newemail . ' ' . $link . '</div>';

+                if (!empty(Globals::$conf->global->AGENDA_ADDACTIONFOREMAIL)) {
+                                    $link = '<a href="' . DOL_BASE_URI . '/comm/action/card.php?action=create&amp;backtopage=1&amp;actioncode=' . $type . '&amp;contactid=' . $cid . '&amp;socid=' . $socid . '">' . img_object(Globals::$langs->trans("AddAction"), "calendar") . '</a>';
+                }
+                if ($link) {
+                                    $newemail = '<div>' . $newemail . ' ' . $link . '</div>';
+                }
             }

-        }

-        else {

+        } else {

             if ($showinvalid && !isValidEmail($email)) {

                 Globals::$langs->load("errors");

                 $newemail .= img_warning(Globals::$langs->trans("ErrorBadEMail", $email));

@@ -2301,8 +2400,9 @@ 
 

         $newskype = $value;

 

-        if (empty($value))

-            return '&nbsp;';

+        if (empty($value)) {
+                    return '&nbsp;';
+        }
 

         if (!empty($type)) {

             $newskype = '<div class="divsocialnetwork inline-block valignmiddle">';

@@ -2323,13 +2423,13 @@ 
             if (($cid || $socid) && !empty(Globals::$conf->agenda->enabled) && $user->rights->agenda->myactions->create && $type == 'skype') {

                 $addlink = 'AC_SKYPE';

                 $link = '';

-                if (!empty(Globals::$conf->global->AGENDA_ADDACTIONFORSKYPE))

-                    $link = '<a href="' . DOL_BASE_URI . '/comm/action/card.php?action=create&amp;backtopage=1&amp;actioncode=' . $addlink . '&amp;contactid=' . $cid . '&amp;socid=' . $socid . '">' . img_object(Globals::$langs->trans("AddAction"), "calendar") . '</a>';

+                if (!empty(Globals::$conf->global->AGENDA_ADDACTIONFORSKYPE)) {
+                                    $link = '<a href="' . DOL_BASE_URI . '/comm/action/card.php?action=create&amp;backtopage=1&amp;actioncode=' . $addlink . '&amp;contactid=' . $cid . '&amp;socid=' . $socid . '">' . img_object(Globals::$langs->trans("AddAction"), "calendar") . '</a>';
+                }
                 $newskype .= ($link ? ' ' . $link : '');

             }

             $newskype .= '</div>';

-        }

-        else {

+        } else {

             Globals::$langs->load("errors");

             $newskype .= img_warning(Globals::$langs->trans("ErrorBadSocialNetworkValue", $value));

         }

@@ -2358,12 +2458,14 @@ 
         if (empty($phone)) {

             return '';

         }

-        if (empty($countrycode))

-            $countrycode = $mysoc->country_code;

+        if (empty($countrycode)) {
+                    $countrycode = $mysoc->country_code;
+        }
 

 // Short format for small screens

-        if (Globals::$conf->dol_optimize_smallscreen)

-            $separ = '';

+        if (Globals::$conf->dol_optimize_smallscreen) {
+                    $separ = '';
+        }
 

         $newphone = $phone;

         if (strtoupper($countrycode) == "FR") {

@@ -2529,15 +2631,18 @@ 
                 $newphone = '<a href="tel:' . $phone . '"';

                 $newphone .= '>' . $phone . '</a>';

             } else if (!empty(Globals::$conf->clicktodial->enabled) && $addlink == 'AC_TEL') {  // If click to dial, we use click to dial url

-                if (empty($user->clicktodial_loaded))

-                    $user->fetch_clicktodial();

+                if (empty($user->clicktodial_loaded)) {
+                                    $user->fetch_clicktodial();
+                }
 

 // Define urlmask

                 $urlmask = 'ErrorClickToDialModuleNotConfigured';

-                if (!empty(Globals::$conf->global->CLICKTODIAL_URL))

-                    $urlmask = Globals::$conf->global->CLICKTODIAL_URL;

-                if (!empty($user->clicktodial_url))

-                    $urlmask = $user->clicktodial_url;

+                if (!empty(Globals::$conf->global->CLICKTODIAL_URL)) {
+                                    $urlmask = Globals::$conf->global->CLICKTODIAL_URL;
+                }
+                if (!empty($user->clicktodial_url)) {
+                                    $urlmask = $user->clicktodial_url;
+                }
 

                 $clicktodial_poste = (!empty($user->clicktodial_poste) ? urlencode($user->clicktodial_poste) : '');

                 $clicktodial_login = (!empty($user->clicktodial_login) ? urlencode($user->clicktodial_login) : '');

@@ -2552,8 +2657,9 @@ 
                 $url = make_substitutions($url, $substitarray);

                 $newphonesav = $newphone;

                 $newphone = '<a href="' . $url . '"';

-                if (!empty(Globals::$conf->global->CLICKTODIAL_FORCENEWTARGET))

-                    $newphone .= ' target="_blank"';

+                if (!empty(Globals::$conf->global->CLICKTODIAL_FORCENEWTARGET)) {
+                                    $newphone .= ' target="_blank"';
+                }
                 $newphone .= '>' . $newphonesav . '</a>';

             }

 

@@ -2561,12 +2667,15 @@ 
             if (!empty(Globals::$conf->agenda->enabled) && $user->rights->agenda->myactions->create) {

                 $type = 'AC_TEL';

                 $link = '';

-                if ($addlink == 'AC_FAX')

-                    $type = 'AC_FAX';

-                if (!empty(Globals::$conf->global->AGENDA_ADDACTIONFORPHONE))

-                    $link = '<a href="' . DOL_BASE_URI . '/comm/action/card.php?action=create&amp;backtopage=1&amp;actioncode=' . $type . ($cid ? '&amp;contactid=' . $cid : '') . ($socid ? '&amp;socid=' . $socid : '') . '">' . img_object(Globals::$langs->trans("AddAction"), "calendar") . '</a>';

-                if ($link)

-                    $newphone = '<div>' . $newphone . ' ' . $link . '</div>';

+                if ($addlink == 'AC_FAX') {
+                                    $type = 'AC_FAX';
+                }
+                if (!empty(Globals::$conf->global->AGENDA_ADDACTIONFORPHONE)) {
+                                    $link = '<a href="' . DOL_BASE_URI . '/comm/action/card.php?action=create&amp;backtopage=1&amp;actioncode=' . $type . ($cid ? '&amp;contactid=' . $cid : '') . ($socid ? '&amp;socid=' . $socid : '') . '">' . img_object(Globals::$langs->trans("AddAction"), "calendar") . '</a>';
+                }
+                if ($link) {
+                                    $newphone = '<div>' . $newphone . ' ' . $link . '</div>';
+                }
             }

         }

 

@@ -2593,15 +2702,17 @@ 
                     $picto = '';

                 }

             }

-            if ($adddivfloat)

-                $rep .= '<div class="nospan float" style="margin-right: 10px">';

-            else

-                $rep .= '<span style="margin-right: 10px;">';

+            if ($adddivfloat) {
+                            $rep .= '<div class="nospan float" style="margin-right: 10px">';
+            } else {
+                            $rep .= '<span style="margin-right: 10px;">';
+            }
             $rep .= ($withpicto ? img_picto($titlealt, 'object_' . $picto . '.png') . ' ' : '') . $newphone;

-            if ($adddivfloat)

-                $rep .= '</div>';

-            else

-                $rep .= '</span>';

+            if ($adddivfloat) {
+                            $rep .= '</div>';
+            } else {
+                            $rep .= '</span>';
+            }
         }

 

         return $rep;

@@ -2631,8 +2742,9 @@ 
             if ($countrycode) { // If success, countrycode is us, fr, ...

                 if (file_exists(DOL_BASE_PATH . '/theme/common/flags/' . $countrycode . '.png')) {

                     $ret .= ' ' . img_picto($countrycode . ' ' . Globals::$langs->trans("AccordingToGeoIPDatabase"), DOL_BASE_URI . '/theme/common/flags/' . $countrycode . '.png', '', 1);

-                } else

-                    $ret .= ' (' . $countrycode . ')';

+                } else {
+                                    $ret .= ' (' . $countrycode . ')';
+                }
             }

         }

 

@@ -2729,26 +2841,33 @@ 
                 $out .= Globals::$hookManager->resPrint;

             }

             if (empty($reshook)) {

-                if (empty($charfornl))

-                    $out .= nl2br($address);

-                else

-                    $out .= preg_replace('/[\r\n]+/', $charfornl, $address);

+                if (empty($charfornl)) {
+                                    $out .= nl2br($address);
+                } else {
+                                    $out .= preg_replace('/[\r\n]+/', $charfornl, $address);
+                }
 

                 $showgmap = $showomap = 0;

 

 // TODO Add a hook here

-                if (($mode == 'thirdparty' || $mode == 'societe') && !empty(Globals::$conf->google->enabled) && !empty(Globals::$conf->global->GOOGLE_ENABLE_GMAPS))

-                    $showgmap = 1;

-                if ($mode == 'contact' && !empty(Globals::$conf->google->enabled) && !empty(Globals::$conf->global->GOOGLE_ENABLE_GMAPS_CONTACTS))

-                    $showgmap = 1;

-                if ($mode == 'member' && !empty(Globals::$conf->google->enabled) && !empty(Globals::$conf->global->GOOGLE_ENABLE_GMAPS_MEMBERS))

-                    $showgmap = 1;

-                if (($mode == 'thirdparty' || $mode == 'societe') && !empty(Globals::$conf->openstreetmap->enabled) && !empty(Globals::$conf->global->OPENSTREETMAP_ENABLE_MAPS))

-                    $showomap = 1;

-                if ($mode == 'contact' && !empty(Globals::$conf->openstreetmap->enabled) && !empty(Globals::$conf->global->OPENSTREETMAP_ENABLE_MAPS_CONTACTS))

-                    $showomap = 1;

-                if ($mode == 'member' && !empty(Globals::$conf->openstreetmap->enabled) && !empty(Globals::$conf->global->OPENSTREETMAP_ENABLE_MAPS_MEMBERS))

-                    $showomap = 1;

+                if (($mode == 'thirdparty' || $mode == 'societe') && !empty(Globals::$conf->google->enabled) && !empty(Globals::$conf->global->GOOGLE_ENABLE_GMAPS)) {
+                                    $showgmap = 1;
+                }
+                if ($mode == 'contact' && !empty(Globals::$conf->google->enabled) && !empty(Globals::$conf->global->GOOGLE_ENABLE_GMAPS_CONTACTS)) {
+                                    $showgmap = 1;
+                }
+                if ($mode == 'member' && !empty(Globals::$conf->google->enabled) && !empty(Globals::$conf->global->GOOGLE_ENABLE_GMAPS_MEMBERS)) {
+                                    $showgmap = 1;
+                }
+                if (($mode == 'thirdparty' || $mode == 'societe') && !empty(Globals::$conf->openstreetmap->enabled) && !empty(Globals::$conf->global->OPENSTREETMAP_ENABLE_MAPS)) {
+                                    $showomap = 1;
+                }
+                if ($mode == 'contact' && !empty(Globals::$conf->openstreetmap->enabled) && !empty(Globals::$conf->global->OPENSTREETMAP_ENABLE_MAPS_CONTACTS)) {
+                                    $showomap = 1;
+                }
+                if ($mode == 'member' && !empty(Globals::$conf->openstreetmap->enabled) && !empty(Globals::$conf->global->OPENSTREETMAP_ENABLE_MAPS_MEMBERS)) {
+                                    $showomap = 1;
+                }
 

                 if ($showgmap) {

                     $url = dol_buildpath('/google/gmaps.php?mode=' . $mode . '&id=' . $id, 1);

@@ -2760,10 +2879,11 @@ 
                 }

             }

         }

-        if ($noprint)

-            return $out;

-        else

-            print $out;

+        if ($noprint) {
+                    return $out;
+        } else {
+                    print $out;
+        }
     }

 

     /**

@@ -2775,10 +2895,12 @@ 
      */

     static function isValidEmail($address, $acceptsupervisorkey = 0)

     {

-        if ($acceptsupervisorkey && $address == '__SUPERVISOREMAIL__')

-            return true;

-        if (filter_var($address, FILTER_VALIDATE_EMAIL))

-            return true;

+        if ($acceptsupervisorkey && $address == '__SUPERVISOREMAIL__') {
+                    return true;
+        }
+        if (filter_var($address, FILTER_VALIDATE_EMAIL)) {
+                    return true;
+        }
 

         return false;

     }

@@ -2800,10 +2922,12 @@ 
                 $mxhosts = array();

                 $weight = array();

                 getmxrr(idn_to_ascii($domain), $mxhosts, $weight);

-                if (count($mxhosts) > 1)

-                    return 1;

-                if (count($mxhosts) == 1 && !empty($mxhosts[0]))

-                    return 1;

+                if (count($mxhosts) > 1) {
+                                    return 1;
+                }
+                if (count($mxhosts) == 1 && !empty($mxhosts[0])) {
+                                    return 1;
+                }
 

                 return 0;

             }

@@ -2832,10 +2956,11 @@ 
      */

     static function dol_strlen($string, $stringencoding = 'UTF-8')

     {

-        if (function_exists('mb_strlen'))

-            return mb_strlen($string, $stringencoding);

-        else

-            return strlen($string);

+        if (function_exists('mb_strlen')) {
+                    return mb_strlen($string, $stringencoding);
+        } else {
+                    return strlen($string);
+        }
     }

 

     /**

@@ -2852,8 +2977,9 @@ 
     {

         // global Globals::$langs;

 

-        if (empty($stringencoding))

-            $stringencoding = Globals::$langs->charset_output;

+        if (empty($stringencoding)) {
+                    $stringencoding = Globals::$langs->charset_output;
+        }
 

         $ret = '';

         if (empty($trunconbytes)) {

@@ -2889,48 +3015,55 @@ 
     {

         // global Globals::$conf;

 

-        if ($size == 0 || !empty(Globals::$conf->global->MAIN_DISABLE_TRUNC))

-            return $string;

+        if ($size == 0 || !empty(Globals::$conf->global->MAIN_DISABLE_TRUNC)) {
+                    return $string;
+        }
 

-        if (empty($stringencoding))

-            $stringencoding = 'UTF-8';

-// reduce for small screen

-        if (Globals::$conf->dol_optimize_smallscreen == 1 && $display == 1)

-            $size = round($size / 3);

+        if (empty($stringencoding)) {
+                    $stringencoding = 'UTF-8';
+        }
+        // reduce for small screen

+        if (Globals::$conf->dol_optimize_smallscreen == 1 && $display == 1) {
+                    $size = round($size / 3);
+        }
 

 // We go always here

         if ($trunc == 'right') {

             $newstring = DolUtils::dol_textishtml($string) ? dol_string_nohtmltag($string, 1) : $string;

-            if (DolUtils::dol_strlen($newstring, $stringencoding) > ($size + ($nodot ? 0 : 3)))    // If nodot is 0 and size is 1,2 or 3 chars more, we don't trunc and don't add ...

-                return dol_substr($newstring, 0, $size, $stringencoding) . ($nodot ? '' : '...');

-            else

-            //return 'u'.$size.'-'.$newstring.'-'.DolUtils::dol_strlen($newstring,$stringencoding).'-'.$string;

-                return $string;

-        }

-        elseif ($trunc == 'middle') {

+            if (DolUtils::dol_strlen($newstring, $stringencoding) > ($size + ($nodot ? 0 : 3))) {
+                // If nodot is 0 and size is 1,2 or 3 chars more, we don't trunc and don't add ...

+                return dol_substr($newstring, 0, $size, $stringencoding) . ($nodot ? '' : '...');
+            } else {
+                        //return 'u'.$size.'-'.$newstring.'-'.DolUtils::dol_strlen($newstring,$stringencoding).'-'.$string;

+                return $string;
+            }
+        } elseif ($trunc == 'middle') {

             $newstring = DolUtils::dol_textishtml($string) ? dol_string_nohtmltag($string, 1) : $string;

             if (DolUtils::dol_strlen($newstring, $stringencoding) > 2 && DolUtils::dol_strlen($newstring, $stringencoding) > ($size + 1)) {

                 $size1 = round($size / 2);

                 $size2 = round($size / 2);

                 return dol_substr($newstring, 0, $size1, $stringencoding) . '...' . dol_substr($newstring, DolUtils::dol_strlen($newstring, $stringencoding) - $size2, $size2, $stringencoding);

-            } else

-                return $string;

-        }

-        elseif ($trunc == 'left') {

+            } else {
+                            return $string;
+            }
+        } elseif ($trunc == 'left') {

             $newstring = DolUtils::dol_textishtml($string) ? dol_string_nohtmltag($string, 1) : $string;

-            if (DolUtils::dol_strlen($newstring, $stringencoding) > ($size + ($nodot ? 0 : 3)))    // If nodot is 0 and size is 1,2 or 3 chars more, we don't trunc and don't add ...

-                return '...' . dol_substr($newstring, DolUtils::dol_strlen($newstring, $stringencoding) - $size, $size, $stringencoding);

-            else

-                return $string;

-        }

-        elseif ($trunc == 'wrap') {

+            if (DolUtils::dol_strlen($newstring, $stringencoding) > ($size + ($nodot ? 0 : 3))) {
+                // If nodot is 0 and size is 1,2 or 3 chars more, we don't trunc and don't add ...

+                return '...' . dol_substr($newstring, DolUtils::dol_strlen($newstring, $stringencoding) - $size, $size, $stringencoding);
+            } else {
+                            return $string;
+            }
+        } elseif ($trunc == 'wrap') {

             $newstring = DolUtils::dol_textishtml($string) ? dol_string_nohtmltag($string, 1) : $string;

-            if (DolUtils::dol_strlen($newstring, $stringencoding) > ($size + 1))

-                return dol_substr($newstring, 0, $size, $stringencoding) . "\n" . dol_trunc(dol_substr($newstring, $size, DolUtils::dol_strlen($newstring, $stringencoding) - $size, $stringencoding), $size, $trunc);

-            else

-                return $string;

-        } else

-            return 'BadParam3CallingDolTrunc';

+            if (DolUtils::dol_strlen($newstring, $stringencoding) > ($size + 1)) {
+                            return dol_substr($newstring, 0, $size, $stringencoding) . "\n" . dol_trunc(dol_substr($newstring, $size, DolUtils::dol_strlen($newstring, $stringencoding) - $size, $stringencoding), $size, $trunc);
+            } else {
+                            return $string;
+            }
+        } else {
+                    return 'BadParam3CallingDolTrunc';
+        }
     }

 

     /**

@@ -3140,8 +3273,9 @@ 
     {

         // global Globals::$conf;

 

-        if (!preg_match('/(\.png|\.gif)$/i', $picto))

-            $picto .= '.png';

+        if (!preg_match('/(\.png|\.gif)$/i', $picto)) {
+                    $picto .= '.png';
+        }
 

 //$path = DOL_BASE_URI . '/theme/' . Globals::$conf->theme . '/img/weather/' . $picto;

         $path = DOL_BASE_URI . '/theme/' . Globals::$conf->theme . '/img/weather/' . $picto;

@@ -3217,8 +3351,9 @@ 
                 $numaction = 0;

             }

         }

-        if (!is_numeric($numaction))

-            $numaction = 0;

+        if (!is_numeric($numaction)) {
+                    $numaction = 0;
+        }
 

         return img_picto($titlealt, 'stcomm' . $numaction . '.png');

     }

@@ -3234,8 +3369,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Show');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Show');
+        }
 

         return img_picto($titlealt, 'pdf' . $size . '.png');

     }

@@ -3251,8 +3387,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Add');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Add');
+        }
 

         return img_picto($titlealt, 'edit_add.png', $other);

     }

@@ -3268,8 +3405,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Remove');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Remove');
+        }
 

         return img_picto($titlealt, 'edit_remove.png', $other);

     }

@@ -3286,8 +3424,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Modify');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Modify');
+        }
 

         return img_picto($titlealt, 'edit.png', ($float ? 'style="float: ' . (Globals::$langs->tab_translate["DIRECTION"] == 'rtl' ? 'left' : 'right') . '"' : "") . ($other ? ' ' . $other : ''));

     }

@@ -3304,8 +3443,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('View');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('View');
+        }
 

         $moreatt = ($float ? 'style="float: right" ' : '') . $other;

 

@@ -3323,8 +3463,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Delete');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Delete');
+        }
 

         return img_picto($titlealt, 'delete.png', $other);

 //return '<span class="fa fa-trash fa-2x fa-fw" style="font-size: 1.7em;" title="'.$titlealt.'"></span>';

@@ -3340,8 +3481,9 @@ 
     static function img_printer($titlealt = "default", $other = '')

     {

         // global Globals::$conf, Globals::$langs;

-        if ($titlealt == "default")

-            $titlealt = Globals::$langs->trans("Print");

+        if ($titlealt == "default") {
+                    $titlealt = Globals::$langs->trans("Print");
+        }
         return img_picto($titlealt, 'printer.png', $other);

     }

 

@@ -3356,8 +3498,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Split');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Split');
+        }
 

         return img_picto($titlealt, 'split.png', $other);

     }

@@ -3374,10 +3517,11 @@ 
         // global Globals::$conf, Globals::$langs;

 

         if ($usealttitle) {

-            if (is_string($usealttitle))

-                $usealttitle = DolUtils::dol_escape_htmltag($usealttitle);

-            else

-                $usealttitle = Globals::$langs->trans('Info');

+            if (is_string($usealttitle)) {
+                            $usealttitle = DolUtils::dol_escape_htmltag($usealttitle);
+            } else {
+                            $usealttitle = Globals::$langs->trans('Info');
+            }
         }

 

         return img_picto($usealttitle, 'info.png', 'style="vertical-align: middle;' . ($usehelpcursor == 1 ? ' cursor: help' : ($usehelpcursor == 2 ? ' cursor: pointer' : '')) . '"');

@@ -3393,8 +3537,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Informations');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Informations');
+        }
 

         return img_picto($titlealt, 'info.png', 'style="vertical-align: middle;"');

     }

@@ -3410,8 +3555,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Warning');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Warning');
+        }
 

 //return '<div class="imglatecoin">'.img_picto($titlealt, 'warning_white.png', 'class="pictowarning valignmiddle"'.($moreatt ? ($moreatt == '1' ? ' style="float: right"' : ' '.$moreatt): '')).'</div>';

         return img_picto($titlealt, 'warning.png', 'class="pictowarning valignmiddle"' . ($moreatt ? ($moreatt == '1' ? ' style="float: right"' : ' ' . $moreatt) : ''));

@@ -3427,8 +3573,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Error');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Error');
+        }
 

         return img_picto($titlealt, 'error.png', 'class="valigntextbottom"');

     }

@@ -3444,8 +3591,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Next');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Next');
+        }
 

 //return img_picto($titlealt, 'next.png', $moreatt);

         return '<span class="fa fa-chevron-right paddingright paddingleft" title="' . DolUtils::dol_escape_htmltag($titlealt) . '"></span>';

@@ -3462,8 +3610,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Previous');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Previous');
+        }
 

 //return img_picto($titlealt, 'previous.png', $moreatt);

         return '<span class="fa fa-chevron-left paddingright paddingleft" title="' . DolUtils::dol_escape_htmltag($titlealt) . '"></span>';

@@ -3481,8 +3630,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Down');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Down');
+        }
 

         return img_picto($titlealt, ($selected ? '1downarrow_selected.png' : '1downarrow.png'), 'class="imgdown' . ($moreclass ? " " . $moreclass : "") . '"');

     }

@@ -3499,8 +3649,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Up');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Up');
+        }
 

         return img_picto($titlealt, ($selected ? '1uparrow_selected.png' : '1uparrow.png'), 'class="imgup' . ($moreclass ? " " . $moreclass : "") . '"');

     }

@@ -3517,8 +3668,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Left');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Left');
+        }
 

         return img_picto($titlealt, ($selected ? '1leftarrow_selected.png' : '1leftarrow.png'), $moreatt);

     }

@@ -3535,8 +3687,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Right');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Right');
+        }
 

         return img_picto($titlealt, ($selected ? '1rightarrow_selected.png' : '1rightarrow.png'), $moreatt);

     }

@@ -3552,11 +3705,13 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Active');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Active');
+        }
 

-        if ($allow == 1)

-            return img_picto($titlealt, 'tick.png');

+        if ($allow == 1) {
+                    return img_picto($titlealt, 'tick.png');
+        }
 

         return '-';

     }

@@ -3604,8 +3759,9 @@ 
         $mimeimg = dol_mimetype($file, '', 2);

         $mimefa = dol_mimetype($file, '', 4);

 

-        if (empty($titlealt))

-            $titlealt = 'Mime type: ' . $mimetype;

+        if (empty($titlealt)) {
+                    $titlealt = 'Mime type: ' . $mimetype;
+        }
 

 //return img_picto_common($titlealt, 'mime/'.$mimeimg, 'class="'.$morecss.'"');

         return '<i class="fa fa-' . $mimefa . ' paddingright"></i>';

@@ -3627,13 +3783,15 @@ 
 

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Call');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Call');
+        }
 

-        if ($option == 1)

-            $img = 'call';

-        else

-            $img = 'call_out';

+        if ($option == 1) {
+                    $img = 'call';
+        } else {
+                    $img = 'call_out';
+        }
 

         return img_picto($titlealt, $img);

     }

@@ -3649,8 +3807,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Search');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Search');
+        }
 

         $img = img_picto($titlealt, 'search.png', $other, false, 1);

 

@@ -3671,8 +3830,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if ($titlealt == 'default')

-            $titlealt = Globals::$langs->trans('Search');

+        if ($titlealt == 'default') {
+                    $titlealt = Globals::$langs->trans('Search');
+        }
 

         $img = img_picto($titlealt, 'searchclear.png', $other, false, 1);

 

@@ -4100,12 +4260,15 @@ 
         $savtotalnboflines = $totalnboflines;

         $totalnboflines = abs($totalnboflines);

 

-        if ($picto == 'setup')

-            $picto = 'title_setup.png';

-        if ((Globals::$conf->browser->name == 'ie') && $picto == 'title_generic.png')

-            $picto = 'title.gif';

-        if ($limit < 0)

-            $limit = Globals::$conf->liste_limit;

+        if ($picto == 'setup') {
+                    $picto = 'title_setup.png';
+        }
+        if ((Globals::$conf->browser->name == 'ie') && $picto == 'title_generic.png') {
+                    $picto = 'title.gif';
+        }
+        if ($limit < 0) {
+                    $limit = Globals::$conf->liste_limit;
+        }
         if ($savlimit != 0 && (($num > $limit) || ($num == -1) || ($limit == 0))) {

             $nextpage = 1;

         } else {

@@ -4119,11 +4282,13 @@ 
 // Left

 //if ($picto && $titre) print '<td class="nobordernopadding hideonsmartphone" width="40" align="left" valign="middle">'.img_picto('', $picto, 'id="pictotitle"', $pictoisfullpath).'</td>';

         print '<td class="nobordernopadding valignmiddle">';

-        if ($picto && $titre)

-            print img_picto('', $picto, 'class="hideonsmartphone valignmiddle opacityhigh pictotitle widthpictotitle"', $pictoisfullpath);

+        if ($picto && $titre) {
+                    print img_picto('', $picto, 'class="hideonsmartphone valignmiddle opacityhigh pictotitle widthpictotitle"', $pictoisfullpath);
+        }
         print '<div class="titre inline-block">' . $titre;

-        if (!empty($titre) && $savtotalnboflines >= 0 && (string) $savtotalnboflines != '')

-            print ' (' . $totalnboflines . ')';

+        if (!empty($titre) && $savtotalnboflines >= 0 && (string) $savtotalnboflines != '') {
+                    print ' (' . $totalnboflines . ')';
+        }
         print '</div></td>';

 

 // Center

@@ -4133,21 +4298,24 @@ 
 

 // Right

         print '<td class="nobordernopadding valignmiddle" align="right">';

-        if ($sortfield)

-            $options .= "&sortfield=" . urlencode($sortfield);

-        if ($sortorder)

-            $options .= "&sortorder=" . urlencode($sortorder);

-// Show navigation bar

+        if ($sortfield) {
+                    $options .= "&sortfield=" . urlencode($sortfield);
+        }
+        if ($sortorder) {
+                    $options .= "&sortorder=" . urlencode($sortorder);
+        }
+        // Show navigation bar

         $pagelist = '';

         if ($savlimit != 0 && ($page > 0 || $num > $limit)) {

             if ($totalnboflines) { // If we know total nb of lines

 // Define nb of extra page links before and after selected page + ... + first or last

                 $maxnbofpage = (empty(Globals::$conf->dol_optimize_smallscreen) ? 4 : 1);

 

-                if ($limit > 0)

-                    $nbpages = ceil($totalnboflines / $limit);

-                else

-                    $nbpages = 1;

+                if ($limit > 0) {
+                                    $nbpages = ceil($totalnboflines / $limit);
+                } else {
+                                    $nbpages = 1;
+                }
                 $cpt = ($page - $maxnbofpage);

                 if ($cpt < 0) {

                     $cpt = 0;

@@ -4155,10 +4323,11 @@ 
 

                 if ($cpt >= 1) {

                     $pagelist .= '<li' . ((Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><a href="' . $file . '?page=0' . $options . '">1</a></li>';

-                    if ($cpt > 2)

-                        $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><span ' . ((Globals::$conf->dol_use_jmobile != 4) ? 'class="inactive"' : '') . '>...</span></li>';

-                    else if ($cpt == 2)

-                        $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><a href="' . $file . '?page=1' . $options . '">2</a></li>';

+                    if ($cpt > 2) {
+                                            $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><span ' . ((Globals::$conf->dol_use_jmobile != 4) ? 'class="inactive"' : '') . '>...</span></li>';
+                    } else if ($cpt == 2) {
+                                            $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><a href="' . $file . '?page=1' . $options . '">2</a></li>';
+                    }
                 }

 

                 do {

@@ -4171,14 +4340,14 @@ 
                 } while ($cpt < $nbpages && $cpt <= $page + $maxnbofpage);

 

                 if ($cpt < $nbpages) {

-                    if ($cpt < $nbpages - 2)

-                        $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><span ' . ((Globals::$conf->dol_use_jmobile != 4) ? 'class="inactive"' : '') . '>...</span></li>';

-                    else if ($cpt == $nbpages - 2)

-                        $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><a href="' . $file . '?page=' . ($nbpages - 2) . $options . '">' . ($nbpages - 1) . '</a></li>';

+                    if ($cpt < $nbpages - 2) {
+                                            $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><span ' . ((Globals::$conf->dol_use_jmobile != 4) ? 'class="inactive"' : '') . '>...</span></li>';
+                    } else if ($cpt == $nbpages - 2) {
+                                            $pagelist .= '<li' . ( (Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><a href="' . $file . '?page=' . ($nbpages - 2) . $options . '">' . ($nbpages - 1) . '</a></li>';
+                    }
                     $pagelist .= '<li' . ((Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><a href="' . $file . '?page=' . ($nbpages - 1) . $options . '">' . $nbpages . '</a></li>';

                 }

-            }

-            else {

+            } else {

                 $pagelist .= '<li' . ((Globals::$conf->dol_use_jmobile != 4) ? ' class="pagination"' : '') . '><span ' . ((Globals::$conf->dol_use_jmobile != 4) ? 'class="active"' : '') . '>' . ($page + 1) . "</li>";

             }

         }

@@ -4214,18 +4383,21 @@ 
             $pagesizechoices = '10:10,15:15,20:20,30:30,40:40,50:50,100:100,250:250,500:500,1000:1000,5000:5000';

 //$pagesizechoices.=',0:'.Globals::$langs->trans("All");     // Not yet supported

 //$pagesizechoices.=',2:2';

-            if (!empty(Globals::$conf->global->MAIN_PAGESIZE_CHOICES))

-                $pagesizechoices = Globals::$conf->global->MAIN_PAGESIZE_CHOICES;

+            if (!empty(Globals::$conf->global->MAIN_PAGESIZE_CHOICES)) {
+                            $pagesizechoices = Globals::$conf->global->MAIN_PAGESIZE_CHOICES;
+            }
 

             print '<li class="pagination">';

             print '<select class="flat selectlimit" name="limit" title="' . DolUtils::dol_escape_htmltag(Globals::$langs->trans("MaxNbOfRecordPerPage")) . '">';

             $tmpchoice = explode(',', $pagesizechoices);

             $tmpkey = $limit . ':' . $limit;

-            if (!in_array($tmpkey, $tmpchoice))

-                $tmpchoice[] = $tmpkey;

+            if (!in_array($tmpkey, $tmpchoice)) {
+                            $tmpchoice[] = $tmpkey;
+            }
             $tmpkey = Globals::$conf->liste_limit . ':' . Globals::$conf->liste_limit;

-            if (!in_array($tmpkey, $tmpchoice))

-                $tmpchoice[] = $tmpkey;

+            if (!in_array($tmpkey, $tmpchoice)) {
+                            $tmpchoice[] = $tmpkey;
+            }
             asort($tmpchoice, SORT_NUMERIC);

             $found = false;

             foreach ($tmpchoice as $val) {

@@ -4301,14 +4473,15 @@ 
         }

 

 // If rate is '9/9/9' we don't change it.  If rate is '9.000' we apply price()

-        if (!preg_match('/\//', $rate))

-            $ret = price($rate, 0, '', 0, 0) . ($addpercent ? '%' : '');

-        else {

+        if (!preg_match('/\//', $rate)) {
+                    $ret = price($rate, 0, '', 0, 0) . ($addpercent ? '%' : '');
+        } else {

 // TODO Split on / and output with a price2num to have clean numbers without ton of 000.

             $ret = $rate . ($addpercent ? '%' : '');

         }

-        if (($info_bits & 1) && $usestarfornpr >= 0)

-            $ret .= ' *';

+        if (($info_bits & 1) && $usestarfornpr >= 0) {
+                    $ret .= ' *';
+        }
         $ret .= $morelabel;

         return $ret;

     }

@@ -4332,11 +4505,14 @@ 
     {

         // global Globals::$langs, Globals::$conf;

 // Clean parameters

-        if (empty($amount))

-            $amount = 0; // To have a numeric value if amount not defined or = ''

+        if (empty($amount)) {
+                    $amount = 0;
+        }
+        // To have a numeric value if amount not defined or = ''

         $amount = (is_numeric($amount) ? $amount : 0); // Check if amount is numeric, for example, an error occured when amount value = o (letter) instead 0 (number)

-        if ($rounding < 0)

-            $rounding = min(Globals::$conf->global->MAIN_MAX_DECIMALS_UNIT, Globals::$conf->global->MAIN_MAX_DECIMALS_TOT);

+        if ($rounding < 0) {
+                    $rounding = min(Globals::$conf->global->MAIN_MAX_DECIMALS_UNIT, Globals::$conf->global->MAIN_MAX_DECIMALS_TOT);
+        }
         $nbdecimal = $rounding;

 

 // Output separators by default (french)

@@ -4344,18 +4520,22 @@ 
         $thousand = ' ';

 

 // If $outlangs not forced, we use use language

-        if (!is_object($outlangs))

-            $outlangs = Globals::$langs;

-

-        if ($outlangs->transnoentitiesnoconv("SeparatorDecimal") != "SeparatorDecimal")

-            $dec = $outlangs->transnoentitiesnoconv("SeparatorDecimal");

-        if ($outlangs->transnoentitiesnoconv("SeparatorThousand") != "SeparatorThousand")

-            $thousand = $outlangs->transnoentitiesnoconv("SeparatorThousand");

-        if ($thousand == 'None')

-            $thousand = '';

-        else if ($thousand == 'Space')

-            $thousand = ' ';

-//print "outlangs=".$outlangs->defaultlang." amount=".$amount." html=".$form." trunc=".$trunc." nbdecimal=".$nbdecimal." dec='".$dec."' thousand='".$thousand."'<br>";

+        if (!is_object($outlangs)) {
+                    $outlangs = Globals::$langs;
+        }
+

+        if ($outlangs->transnoentitiesnoconv("SeparatorDecimal") != "SeparatorDecimal") {
+                    $dec = $outlangs->transnoentitiesnoconv("SeparatorDecimal");
+        }
+        if ($outlangs->transnoentitiesnoconv("SeparatorThousand") != "SeparatorThousand") {
+                    $thousand = $outlangs->transnoentitiesnoconv("SeparatorThousand");
+        }
+        if ($thousand == 'None') {
+                    $thousand = '';
+        } else if ($thousand == 'Space') {
+                    $thousand = ' ';
+        }
+        //print "outlangs=".$outlangs->defaultlang." amount=".$amount." html=".$form." trunc=".$trunc." nbdecimal=".$nbdecimal." dec='".$dec."' thousand='".$thousand."'<br>";

 //print "amount=".$amount."-";

         $amount = str_replace(',', '.', $amount); // should be useless

 //print $amount."-";

@@ -4366,9 +4546,10 @@ 
         $end = '';

 

 // We increase nbdecimal if there is more decimal than asked (to not loose information)

-        if (DolUtils::dol_strlen($decpart) > $nbdecimal)

-            $nbdecimal = DolUtils::dol_strlen($decpart);

-// Si on depasse max

+        if (DolUtils::dol_strlen($decpart) > $nbdecimal) {
+                    $nbdecimal = DolUtils::dol_strlen($decpart);
+        }
+        // Si on depasse max

         if ($trunc && $nbdecimal > Globals::$conf->global->MAIN_MAX_DECIMALS_SHOWN) {

             $nbdecimal = Globals::$conf->global->MAIN_MAX_DECIMALS_SHOWN;

             if (preg_match('/\.\.\./i', Globals::$conf->global->MAIN_MAX_DECIMALS_SHOWN)) {

@@ -4378,8 +4559,9 @@ 
         }

 

 // If force rounding

-        if ($forcerounding >= 0)

-            $nbdecimal = $forcerounding;

+        if ($forcerounding >= 0) {
+                    $nbdecimal = $forcerounding;
+        }
 

 // Format number

         $output = number_format($amount, $nbdecimal, $dec, $thousand);

@@ -4390,13 +4572,14 @@ 
 // Add symbol of currency if requested

         $cursymbolbefore = $cursymbolafter = '';

         if ($currency_code) {

-            if ($currency_code == 'auto')

-                $currency_code = Globals::$conf->currency;

+            if ($currency_code == 'auto') {
+                            $currency_code = Globals::$conf->currency;
+            }
 

             $listofcurrenciesbefore = array('USD', 'GBP', 'AUD', 'MXN', 'PEN', 'CNY');

-            if (in_array($currency_code, $listofcurrenciesbefore))

-                $cursymbolbefore .= $outlangs->getCurrencySymbol($currency_code);

-            else {

+            if (in_array($currency_code, $listofcurrenciesbefore)) {
+                            $cursymbolbefore .= $outlangs->getCurrencySymbol($currency_code);
+            } else {

                 $tmpcur = $outlangs->getCurrencySymbol($currency_code);

                 $cursymbolafter .= ($tmpcur == $currency_code ? ' ' . $tmpcur : $tmpcur);

             }

@@ -4429,15 +4612,18 @@ 
 // Decimal delimiter for PHP and database SQL requests must be '.'

         $dec = ',';

         $thousand = ' ';

-        if (Globals::$langs->transnoentitiesnoconv("SeparatorDecimal") != "SeparatorDecimal")

-            $dec = Globals::$langs->transnoentitiesnoconv("SeparatorDecimal");

-        if (Globals::$langs->transnoentitiesnoconv("SeparatorThousand") != "SeparatorThousand")

-            $thousand = Globals::$langs->transnoentitiesnoconv("SeparatorThousand");

-        if ($thousand == 'None')

-            $thousand = '';

-        elseif ($thousand == 'Space')

-            $thousand = ' ';

-//print "amount=".$amount." html=".$form." trunc=".$trunc." nbdecimal=".$nbdecimal." dec='".$dec."' thousand='".$thousand."'<br>";

+        if (Globals::$langs->transnoentitiesnoconv("SeparatorDecimal") != "SeparatorDecimal") {
+                    $dec = Globals::$langs->transnoentitiesnoconv("SeparatorDecimal");
+        }
+        if (Globals::$langs->transnoentitiesnoconv("SeparatorThousand") != "SeparatorThousand") {
+                    $thousand = Globals::$langs->transnoentitiesnoconv("SeparatorThousand");
+        }
+        if ($thousand == 'None') {
+                    $thousand = '';
+        } elseif ($thousand == 'Space') {
+                    $thousand = ' ';
+        }
+        //print "amount=".$amount." html=".$form." trunc=".$trunc." nbdecimal=".$nbdecimal." dec='".$dec."' thousand='".$thousand."'<br>";

 // Convert value to universal number format (no thousand separator, '.' as decimal separator)

         if ($alreadysqlnb != 1) { // If not a PHP number or unknown, we change format

 //print 'PP'.$amount.' - '.$dec.' - '.$thousand.' - '.intval($amount).'<br>';

@@ -4452,8 +4638,10 @@ 
             }

 //print "QQ".$amount.'<br>';

 // Now make replace (the main goal of function)

-            if ($thousand != ',' && $thousand != '.')

-                $amount = str_replace(',', '.', $amount); // To accept 2 notations for french users

+            if ($thousand != ',' && $thousand != '.') {
+                            $amount = str_replace(',', '.', $amount);
+            }
+            // To accept 2 notations for french users

             $amount = str_replace(' ', '', $amount);  // To avoid spaces

             $amount = str_replace($thousand, '', $amount); // Replace of thousand before replace of dec to avoid pb if thousand is .

             $amount = str_replace($dec, '.', $amount);

@@ -4462,20 +4650,24 @@ 
 // Now, make a rounding if required

         if ($rounding) {

             $nbofdectoround = '';

-            if ($rounding == 'MU')

-                $nbofdectoround = Globals::$conf->global->MAIN_MAX_DECIMALS_UNIT;

-            elseif ($rounding == 'MT')

-                $nbofdectoround = Globals::$conf->global->MAIN_MAX_DECIMALS_TOT;

-            elseif ($rounding == 'MS')

-                $nbofdectoround = empty(Globals::$conf->global->MAIN_MAX_DECIMALS_STOCK) ? 5 : Globals::$conf->global->MAIN_MAX_DECIMALS_STOCK;

-            elseif (is_numeric($rounding))

-                $nbofdectoround = $rounding;

-//print "RR".$amount.' - '.$nbofdectoround.'<br>';

-            if (DolUtils::dol_strlen($nbofdectoround))

-                $amount = round($amount, $nbofdectoround); // $nbofdectoround can be 0.

-            else

-                return 'ErrorBadParameterProvidedToFunction';

-//print 'SS'.$amount.' - '.$nbofdec.' - '.$dec.' - '.$thousand.' - '.$nbofdectoround.'<br>';

+            if ($rounding == 'MU') {
+                            $nbofdectoround = Globals::$conf->global->MAIN_MAX_DECIMALS_UNIT;
+            } elseif ($rounding == 'MT') {
+                            $nbofdectoround = Globals::$conf->global->MAIN_MAX_DECIMALS_TOT;
+            } elseif ($rounding == 'MS') {
+                            $nbofdectoround = empty(Globals::$conf->global->MAIN_MAX_DECIMALS_STOCK) ? 5 : Globals::$conf->global->MAIN_MAX_DECIMALS_STOCK;
+            } elseif (is_numeric($rounding)) {
+                            $nbofdectoround = $rounding;
+            }
+            //print "RR".$amount.' - '.$nbofdectoround.'<br>';

+            if (DolUtils::dol_strlen($nbofdectoround)) {
+                            $amount = round($amount, $nbofdectoround);
+            }
+            // $nbofdectoround can be 0.

+            else {
+                            return 'ErrorBadParameterProvidedToFunction';
+            }
+            //print 'SS'.$amount.' - '.$nbofdec.' - '.$dec.' - '.$thousand.' - '.$nbofdectoround.'<br>';

 // Convert amount to format with dolibarr dec and thousand (this is because PHP convert a number

 // to format defined by LC_NUMERIC after a calculation and we want source format to be defined by Dolibarr setup.

             if (is_numeric($amount)) {

@@ -4488,8 +4680,10 @@ 
 //print "TT".$amount.'<br>';

 // Always make replace because each math static function (like round) replace

 // with local values and we want a number that has a SQL string format x.y

-            if ($thousand != ',' && $thousand != '.')

-                $amount = str_replace(',', '.', $amount); // To accept 2 notations for french users

+            if ($thousand != ',' && $thousand != '.') {
+                            $amount = str_replace(',', '.', $amount);
+            }
+            // To accept 2 notations for french users

             $amount = str_replace(' ', '', $amount);  // To avoid spaces

             $amount = str_replace($thousand, '', $amount); // Replace of thousand before replace of dec to avoid pb if thousand is .

             $amount = str_replace($dec, '.', $amount);

@@ -4548,8 +4742,9 @@ 
     {

         // global $db, Globals::$conf, $mysoc;

 

-        if (empty($thirdparty_seller) || !is_object($thirdparty_seller))

-            $thirdparty_seller = $mysoc;

+        if (empty($thirdparty_seller) || !is_object($thirdparty_seller)) {
+                    $thirdparty_seller = $mysoc;
+        }
 

         DolUtils::dol_syslog("get_localtax tva=" . $vatrate . " local=" . $local . " thirdparty_buyer id=" . (is_object($thirdparty_buyer) ? $thirdparty_buyer->id : '') . "/country_code=" . (is_object($thirdparty_buyer) ? $thirdparty_buyer->country_code : '') . " thirdparty_seller id=" . $thirdparty_seller->id . "/country_code=" . $thirdparty_seller->country_code . " thirdparty_seller localtax1_assuj=" . $thirdparty_seller->localtax1_assuj . "  thirdparty_seller localtax2_assuj=" . $thirdparty_seller->localtax2_assuj);

 

@@ -4567,37 +4762,43 @@ 
 // Some test to guess with no need to make database access

         if ($mysoc->country_code == 'ES') { // For spain localtaxes 1 and 2, tax is qualified if buyer use local tax

             if ($local == 1) {

-                if (!$mysoc->localtax1_assuj || (string) $vatratecleaned == "0")

-                    return 0;

+                if (!$mysoc->localtax1_assuj || (string) $vatratecleaned == "0") {
+                                    return 0;
+                }
                 if ($thirdparty_seller->id == $mysoc->id) {

-                    if (!$thirdparty_buyer->localtax1_assuj)

-                        return 0;

-                }

-                else {

-                    if (!$thirdparty_seller->localtax1_assuj)

-                        return 0;

+                    if (!$thirdparty_buyer->localtax1_assuj) {
+                                            return 0;
+                    }
+                } else {

+                    if (!$thirdparty_seller->localtax1_assuj) {
+                                            return 0;
+                    }
                 }

             }

 

             if ($local == 2) {

 //if (! $mysoc->localtax2_assuj || (string) $vatratecleaned == "0") return 0;

-                if (!$mysoc->localtax2_assuj)

-                    return 0;  // If main vat is 0, IRPF may be different than 0.

+                if (!$mysoc->localtax2_assuj) {
+                                    return 0;
+                }
+                // If main vat is 0, IRPF may be different than 0.

                 if ($thirdparty_seller->id == $mysoc->id) {

-                    if (!$thirdparty_buyer->localtax2_assuj)

-                        return 0;

-                }

-                else {

-                    if (!$thirdparty_seller->localtax2_assuj)

-                        return 0;

+                    if (!$thirdparty_buyer->localtax2_assuj) {
+                                            return 0;
+                    }
+                } else {

+                    if (!$thirdparty_seller->localtax2_assuj) {
+                                            return 0;
+                    }
                 }

             }

-        }

-        else {

-            if ($local == 1 && !$thirdparty_seller->localtax1_assuj)

-                return 0;

-            if ($local == 2 && !$thirdparty_seller->localtax2_assuj)

-                return 0;

+        } else {

+            if ($local == 1 && !$thirdparty_seller->localtax1_assuj) {
+                            return 0;
+            }
+            if ($local == 2 && !$thirdparty_seller->localtax2_assuj) {
+                            return 0;
+            }
         }

 

 // For some country MAIN_GET_LOCALTAXES_VALUES_FROM_THIRDPARTY is forced to on.

@@ -4639,19 +4840,23 @@ 
         $sql .= " FROM " . MAIN_DB_PREFIX . "c_tva as t, " . MAIN_DB_PREFIX . "c_country as c";

         $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $thirdparty_seller->country_code . "'";

         $sql .= " AND t.taux = " . ((float) $vatratecleaned) . " AND t.active = 1";

-        if ($vatratecode)

-            $sql .= " AND t.code ='" . $vatratecode . "'";  // If we have the code, we use it in priority

-        else

-            $sql .= " AND t.recuperableonly ='" . $vatnpr . "'";

+        if ($vatratecode) {
+                    $sql .= " AND t.code ='" . $vatratecode . "'";
+        }
+        // If we have the code, we use it in priority

+        else {
+                    $sql .= " AND t.recuperableonly ='" . $vatnpr . "'";
+        }
         DolUtils::dol_syslog("get_localtax", LOG_DEBUG);

         $resql = $db->query($sql);

 

         if ($resql) {

             $obj = $db->fetch_object($resql);

-            if ($local == 1)

-                return $obj->localtax1;

-            elseif ($local == 2)

-                return $obj->localtax2;

+            if ($local == 1) {
+                            return $obj->localtax1;
+            } elseif ($local == 2) {
+                            return $obj->localtax2;
+            }
         }

 

         return 0;

@@ -4697,10 +4902,11 @@ 
         $resql = $db->query($sql);

         if ($resql) {

             $obj = $db->fetch_object($resql);

-            if ($local == 1)

-                return $obj->localtax1;

-            elseif ($local == 2)

-                return $obj->localtax2;

+            if ($local == 1) {
+                            return $obj->localtax1;
+            } elseif ($local == 2) {
+                            return $obj->localtax2;
+            }
         }

 

         return 0;

@@ -4726,9 +4932,9 @@ 
 // Search local taxes

         $sql = "SELECT t.rowid, t.code, t.taux as rate, t.recuperableonly as npr, t.accountancy_code_sell, t.accountancy_code_buy";

         $sql .= " FROM " . MAIN_DB_PREFIX . "c_tva as t";

-        if ($firstparamisid)

-            $sql .= " WHERE t.rowid = " . (int) $vatrate;

-        else {

+        if ($firstparamisid) {
+                    $sql .= " WHERE t.rowid = " . (int) $vatrate;
+        } else {

             $vatratecleaned = $vatrate;

             $vatratecode = '';

             if (preg_match('/^(.*)\s*\((.*)\)$/', $vatrate, $reg)) {      // If vat is "xx (yy)"

@@ -4741,19 +4947,22 @@ 
               else $sql.= " WHERE t.fk_pays = c.rowid AND c.code = '".$seller->country_code."'"; */

             $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $seller->country_code . "'";

             $sql .= " AND t.taux = " . ((float) $vatratecleaned) . " AND t.active = 1";

-            if ($vatratecode)

-                $sql .= " AND t.code = '" . $vatratecode . "'";

+            if ($vatratecode) {
+                            $sql .= " AND t.code = '" . $vatratecode . "'";
+            }
         }

 

         $resql = $db->query($sql);

         if ($resql) {

             $obj = $db->fetch_object($resql);

-            if ($obj)

-                return array('rowid' => $obj->rowid, 'code' => $obj->code, 'rate' => $obj->rate, 'npr' => $obj->npr, 'accountancy_code_sell' => $obj->accountancy_code_sell, 'accountancy_code_buy' => $obj->accountancy_code_buy);

-            else

-                return array();

-        } else

-            dol_print_error($db);

+            if ($obj) {
+                            return array('rowid' => $obj->rowid, 'code' => $obj->code, 'rate' => $obj->rate, 'npr' => $obj->npr, 'accountancy_code_sell' => $obj->accountancy_code_sell, 'accountancy_code_buy' => $obj->accountancy_code_buy);
+            } else {
+                            return array();
+            }
+        } else {
+                    dol_print_error($db);
+        }
 

         return array();

     }

@@ -4783,9 +4992,9 @@ 
 // Search local taxes

         $sql = "SELECT t.localtax1, t.localtax1_type, t.localtax2, t.localtax2_type, t.accountancy_code_sell, t.accountancy_code_buy";

         $sql .= " FROM " . MAIN_DB_PREFIX . "c_tva as t";

-        if ($firstparamisid)

-            $sql .= " WHERE t.rowid = " . (int) $vatrate;

-        else {

+        if ($firstparamisid) {
+                    $sql .= " WHERE t.rowid = " . (int) $vatrate;
+        } else {

             $vatratecleaned = $vatrate;

             $vatratecode = '';

             if (preg_match('/^(.*)\s*\((.*)\)$/', $vatrate, $reg)) {      // If vat is "x.x (yy)"

@@ -4794,13 +5003,17 @@ 
             }

 

             $sql .= ", " . MAIN_DB_PREFIX . "c_country as c";

-            if ($mysoc->country_code == 'ES')

-                $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $buyer->country_code . "'";    // local tax in spain use the buyer country ??

-            else

-                $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $seller->country_code . "'";

+            if ($mysoc->country_code == 'ES') {
+                            $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $buyer->country_code . "'";
+            }
+            // local tax in spain use the buyer country ??

+            else {
+                            $sql .= " WHERE t.fk_pays = c.rowid AND c.code = '" . $seller->country_code . "'";
+            }
             $sql .= " AND t.taux = " . ((float) $vatratecleaned) . " AND t.active = 1";

-            if ($vatratecode)

-                $sql .= " AND t.code = '" . $vatratecode . "'";

+            if ($vatratecode) {
+                            $sql .= " AND t.code = '" . $vatratecode . "'";
+            }
         }

 

         $resql = $db->query($sql);

@@ -4846,17 +5059,17 @@ 
                 if ($idprodfournprice > 0) {     // We want vat for product for a "supplier" object

                     $product->get_buyprice($idprodfournprice, 0, 0, 0);

                     $ret = $product->vatrate_supplier;

-                    if ($product->default_vat_code)

-                        $ret .= ' (' . $product->default_vat_code . ')';

-                }

-                else {

+                    if ($product->default_vat_code) {
+                                            $ret .= ' (' . $product->default_vat_code . ')';
+                    }
+                } else {

                     $ret = $product->tva_tx;    // Default vat of product we defined

-                    if ($product->default_vat_code)

-                        $ret .= ' (' . $product->default_vat_code . ')';

+                    if ($product->default_vat_code) {
+                                            $ret .= ' (' . $product->default_vat_code . ')';
+                    }
                 }

                 $found = 1;

-            }

-            else {

+            } else {

 // TODO Read default product vat according to countrycode and product. Vat for couple countrycode/product is a feature not implemeted yet.

 // May be usefull/required if hidden option SERVICE_ARE_ECOMMERCE_200238EC is on

             }

@@ -4876,14 +5089,18 @@ 
                     $obj = $db->fetch_object($resql);

                     if ($obj) {

                         $ret = $obj->vat_rate;

-                        if ($obj->default_vat_code)

-                            $ret .= ' (' . $obj->default_vat_code . ')';

+                        if ($obj->default_vat_code) {
+                                                    $ret .= ' (' . $obj->default_vat_code . ')';
+                        }
                     }

                     $db->free($sql);

-                } else

-                    dol_print_error($db);

-            } else

-                $ret = Globals::$conf->global->MAIN_VAT_DEFAULT_IF_AUTODETECT_FAILS;    // Forced value if autodetect fails

+                } else {
+                                    dol_print_error($db);
+                }
+            } else {
+                            $ret = Globals::$conf->global->MAIN_VAT_DEFAULT_IF_AUTODETECT_FAILS;
+            }
+            // Forced value if autodetect fails

         }

 

         DolUtils::dol_syslog("get_product_vat_for_country: ret=" . $ret);

@@ -4938,13 +5155,15 @@ 
             if ($resql) {

                 $obj = $db->fetch_object($resql);

                 if ($obj) {

-                    if ($local == 1)

-                        $ret = $obj->localtax1;

-                    elseif ($local == 2)

-                        $ret = $obj->localtax2;

+                    if ($local == 1) {
+                                            $ret = $obj->localtax1;
+                    } elseif ($local == 2) {
+                                            $ret = $obj->localtax2;
+                    }
                 }

-            } else

-                dol_print_error($db);

+            } else {
+                            dol_print_error($db);
+            }
         }

 

         DolUtils::dol_syslog("get_product_localtax_for_country: ret=" . $ret);

@@ -5047,15 +5266,16 @@ 
         // global $db;

 

         if ($idprodfournprice > 0) {

-            if (!class_exists('ProductFournisseur'))

-                require_once DOL_BASE_PATH . '/fourn/class/fournisseur.product.class.php';

+            if (!class_exists('ProductFournisseur')) {
+                            require_once DOL_BASE_PATH . '/fourn/class/fournisseur.product.class.php';
+            }
             $prodprice = new ProductFournisseur($db);

             $prodprice->fetch_product_fournisseur_price($idprodfournprice);

             return $prodprice->fourn_tva_npr;

-        }

-        elseif ($idprod > 0) {

-            if (!class_exists('Product'))

-                require_once DOL_BASE_PATH . 'product/class/product.class.php';

+        } elseif ($idprod > 0) {

+            if (!class_exists('Product')) {
+                            require_once DOL_BASE_PATH . 'product/class/product.class.php';
+            }
             $prod = new Product($db);

             $prod->fetch($idprod);

             return $prod->tva_npr;

@@ -5081,30 +5301,35 @@ 
     {

         // global $mysoc;

 

-        if (!is_object($thirdparty_seller))

-            return -1;

-        if (!is_object($thirdparty_buyer))

-            return -1;

+        if (!is_object($thirdparty_seller)) {
+                    return -1;
+        }
+        if (!is_object($thirdparty_buyer)) {
+                    return -1;
+        }
 

         if ($local == 1) { // Localtax 1

             if ($mysoc->country_code == 'ES') {

-                if (is_numeric($thirdparty_buyer->localtax1_assuj) && !$thirdparty_buyer->localtax1_assuj)

-                    return 0;

-            }

-            else {

+                if (is_numeric($thirdparty_buyer->localtax1_assuj) && !$thirdparty_buyer->localtax1_assuj) {
+                                    return 0;
+                }
+            } else {

 // Si vendeur non assujeti a Localtax1, localtax1 par default=0

-                if (is_numeric($thirdparty_seller->localtax1_assuj) && !$thirdparty_seller->localtax1_assuj)

-                    return 0;

-                if (!is_numeric($thirdparty_seller->localtax1_assuj) && $thirdparty_seller->localtax1_assuj == 'localtax1off')

-                    return 0;

-            }

-        }

-        elseif ($local == 2) { //I Localtax 2

+                if (is_numeric($thirdparty_seller->localtax1_assuj) && !$thirdparty_seller->localtax1_assuj) {
+                                    return 0;
+                }
+                if (!is_numeric($thirdparty_seller->localtax1_assuj) && $thirdparty_seller->localtax1_assuj == 'localtax1off') {
+                                    return 0;
+                }
+            }

+        } elseif ($local == 2) { //I Localtax 2

 // Si vendeur non assujeti a Localtax2, localtax2 par default=0

-            if (is_numeric($thirdparty_seller->localtax2_assuj) && !$thirdparty_seller->localtax2_assuj)

-                return 0;

-            if (!is_numeric($thirdparty_seller->localtax2_assuj) && $thirdparty_seller->localtax2_assuj == 'localtax2off')

-                return 0;

+            if (is_numeric($thirdparty_seller->localtax2_assuj) && !$thirdparty_seller->localtax2_assuj) {
+                            return 0;
+            }
+            if (!is_numeric($thirdparty_seller->localtax2_assuj) && $thirdparty_seller->localtax2_assuj == 'localtax2off') {
+                            return 0;
+            }
         }

 

         if ($thirdparty_seller->country_code == $thirdparty_buyer->country_code) {

@@ -5129,31 +5354,38 @@ 
         $classname = '';

         if ($yesno == 1 || strtolower($yesno) == 'yes' || strtolower($yesno) == 'true') {  // A mettre avant test sur no a cause du == 0

             $result = Globals::$langs->trans('yes');

-            if ($case == 1 || $case == 3)

-                $result = Globals::$langs->trans("Yes");

-            if ($case == 2)

-                $result = '<input type="checkbox" value="1" checked disabled>';

-            if ($case == 3)

-                $result = '<input type="checkbox" value="1" checked disabled> ' . $result;

+            if ($case == 1 || $case == 3) {
+                            $result = Globals::$langs->trans("Yes");
+            }
+            if ($case == 2) {
+                            $result = '<input type="checkbox" value="1" checked disabled>';
+            }
+            if ($case == 3) {
+                            $result = '<input type="checkbox" value="1" checked disabled> ' . $result;
+            }
 

             $classname = 'ok';

-        }

-        elseif ($yesno == 0 || strtolower($yesno) == 'no' || strtolower($yesno) == 'false') {

+        } elseif ($yesno == 0 || strtolower($yesno) == 'no' || strtolower($yesno) == 'false') {

             $result = Globals::$langs->trans("no");

-            if ($case == 1 || $case == 3)

-                $result = Globals::$langs->trans("No");

-            if ($case == 2)

-                $result = '<input type="checkbox" value="0" disabled>';

-            if ($case == 3)

-                $result = '<input type="checkbox" value="0" disabled> ' . $result;

-

-            if ($color == 2)

-                $classname = 'ok';

-            else

-                $classname = 'error';

-        }

-        if ($color)

-            return '<font class="' . $classname . '">' . $result . '</font>';

+            if ($case == 1 || $case == 3) {
+                            $result = Globals::$langs->trans("No");
+            }
+            if ($case == 2) {
+                            $result = '<input type="checkbox" value="0" disabled>';
+            }
+            if ($case == 3) {
+                            $result = '<input type="checkbox" value="0" disabled> ' . $result;
+            }
+

+            if ($color == 2) {
+                            $classname = 'ok';
+            } else {
+                            $classname = 'error';
+            }
+        }

+        if ($color) {
+                    return '<font class="' . $classname . '">' . $result . '</font>';
+        }
         return $result;

     }

 

@@ -5179,23 +5411,27 @@ 
         $path = '';

 

         $arrayforoldpath = array('cheque', 'user', 'category', 'holiday', 'supplier_invoice', 'invoice_supplier', 'mailing', 'supplier_payment');

-        if (!empty(Globals::$conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO))

-            $arrayforoldpath[] = 'product';

+        if (!empty(Globals::$conf->global->PRODUCT_USE_OLD_PATH_FOR_PHOTO)) {
+                    $arrayforoldpath[] = 'product';
+        }
         if (!empty($level) && in_array($modulepart, $arrayforoldpath)) {

 // This part should be removed once all code is using "get_exdir" to forge path, with all parameters provided.

-            if (empty($alpha))

-                $num = preg_replace('/([^0-9])/i', '', $num);

-            else

-                $num = preg_replace('/^.*\-/i', '', $num);

+            if (empty($alpha)) {
+                            $num = preg_replace('/([^0-9])/i', '', $num);
+            } else {
+                            $num = preg_replace('/^.*\-/i', '', $num);
+            }
             $num = substr("000" . $num, -$level);

-            if ($level == 1)

-                $path = substr($num, 0, 1);

-            if ($level == 2)

-                $path = substr($num, 1, 1) . '/' . substr($num, 0, 1);

-            if ($level == 3)

-                $path = substr($num, 2, 1) . '/' . substr($num, 1, 1) . '/' . substr($num, 0, 1);

-        }

-        else {

+            if ($level == 1) {
+                            $path = substr($num, 0, 1);
+            }
+            if ($level == 2) {
+                            $path = substr($num, 1, 1) . '/' . substr($num, 0, 1);
+            }
+            if ($level == 3) {
+                            $path = substr($num, 2, 1) . '/' . substr($num, 1, 1) . '/' . substr($num, 0, 1);
+            }
+        } else {

 // TODO

 // We will enhance here a common way of forging path for document storage

 // Here, object->id, object->ref and modulepart are required.

@@ -5206,8 +5442,9 @@ 
             }

         }

 

-        if (empty($withoutslash) && !empty($path))

-            $path .= '/';

+        if (empty($withoutslash) && !empty($path)) {
+                    $path .= '/';
+        }
 

         return $path;

     }

@@ -5227,8 +5464,9 @@ 
         DolUtils::dol_syslog("functions.lib::dol_mkdir: dir=" . $dir, LOG_INFO);

 

         $dir_osencoded = dol_osencode($dir);

-        if (@is_dir($dir_osencoded))

-            return 0;

+        if (@is_dir($dir_osencoded)) {
+                    return 0;
+        }
 

         $nberr = 0;

         $nbcreated = 0;

@@ -5243,12 +5481,15 @@ 
         $cdir = explode("/", $dir);

         $num = count($cdir);

         for ($i = 0; $i < $num; $i++) {

-            if ($i > 0)

-                $ccdir .= '/' . $cdir[$i];

-            else

-                $ccdir .= $cdir[$i];

-            if (preg_match("/^.:$/", $ccdir, $regs))

-                continue; // Si chemin Windows incomplet, on poursuit par rep suivant

+            if ($i > 0) {
+                            $ccdir .= '/' . $cdir[$i];
+            } else {
+                            $ccdir .= $cdir[$i];
+            }
+            if (preg_match("/^.:$/", $ccdir, $regs)) {
+                            continue;
+            }
+            // Si chemin Windows incomplet, on poursuit par rep suivant

 

 

 

@@ -5350,8 +5591,9 @@ 
      */

     static function dol_string_nohtmltag($stringtoclean, $removelinefeed = 1, $pagecodeto = 'UTF-8', $strip_tags = 0)

     {

-        if ($removelinefeed == 2)

-            $stringtoclean = preg_replace('/<br[^>]*>\n+/ims', '<br>', $stringtoclean);

+        if ($removelinefeed == 2) {
+                    $stringtoclean = preg_replace('/<br[^>]*>\n+/ims', '<br>', $stringtoclean);
+        }
         $temp = preg_replace('/<br[^>]*>/i', "\n", $stringtoclean);

 

         if ($strip_tags) {

@@ -5368,8 +5610,9 @@ 
         $temp = dol_html_entity_decode($temp, ENT_COMPAT, $pagecodeto);

 

 // Supprime aussi les retours

-        if ($removelinefeed == 1)

-            $temp = str_replace(array("\r\n", "\r", "\n"), " ", $temp);

+        if ($removelinefeed == 1) {
+                    $temp = str_replace(array("\r\n", "\r", "\n"), " ", $temp);
+        }
 

 // et les espaces doubles

         while (strpos($temp, "  ")) {

@@ -5455,18 +5698,21 @@ 
             if ($charset == 'UTF-8') {

                 $pattern = '/(<br[^>]*>)/Uu';

             } // /U is to have UNGREEDY regex to limit to one html tag. /u is for UTF8 support

-            else

-                $pattern = '/(<br[^>]*>)/U';       // /U is to have UNGREEDY regex to limit to one html tag.

+            else {
+                            $pattern = '/(<br[^>]*>)/U';
+            }
+            // /U is to have UNGREEDY regex to limit to one html tag.

             $a = preg_split($pattern, $text, -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);

 

             $firstline = '';

             $i = 0;

             $nba = count($a); // 2x nb of lines in $a because $a contains also a line for each new line separator

             while (($i < $nba) && ($i < ($nboflines * 2))) {

-                if ($i % 2 == 0)

-                    $firstline .= $a[$i];

-                elseif (($i < (($nboflines * 2) - 1)) && ($i < ($nba - 1)))

-                    $firstline .= ($ishtml ? "<br>\n" : "\n");

+                if ($i % 2 == 0) {
+                                    $firstline .= $a[$i];
+                } elseif (($i < (($nboflines * 2) - 1)) && ($i < ($nba - 1))) {
+                                    $firstline .= ($ishtml ? "<br>\n" : "\n");
+                }
                 $i++;

             }

             unset($a);

@@ -5515,15 +5761,18 @@ 
         $newstring = $stringtoencode;

         if (DolUtils::dol_textishtml($stringtoencode)) { // Check if text is already HTML or not

             $newstring = preg_replace('/<br(\s[\sa-zA-Z_="]*)?\/?>/i', '<br>', $newstring); // Replace "<br type="_moz" />" by "<br>". It's same and avoid pb with FPDF.

-            if ($removelasteolbr)

-                $newstring = preg_replace('/<br>$/i', '', $newstring); // Remove last <br> (remove only last one)

+            if ($removelasteolbr) {
+                            $newstring = preg_replace('/<br>$/i', '', $newstring);
+            }
+            // Remove last <br> (remove only last one)

             $newstring = strtr($newstring, array('&' => '__and__', '<' => '__lt__', '>' => '__gt__', '"' => '__dquot__'));

             $newstring = DolUtils::dol_htmlentities($newstring, ENT_COMPAT, $pagecodefrom); // Make entity encoding

             $newstring = strtr($newstring, array('__and__' => '&', '__lt__' => '<', '__gt__' => '>', '__dquot__' => '"'));

-        }

-        else {

-            if ($removelasteolbr)

-                $newstring = preg_replace('/(\r\n|\r|\n)$/i', '', $newstring); // Remove last \n (may remove several)

+        } else {

+            if ($removelasteolbr) {
+                            $newstring = preg_replace('/(\r\n|\r|\n)$/i', '', $newstring);
+            }
+            // Remove last \n (may remove several)

             $newstring = dol_nl2br(DolUtils::dol_htmlentities($newstring, ENT_COMPAT, $pagecodefrom), $nl2brmode);

         }

 // Other substitutions that htmlentities does not do

@@ -5625,8 +5874,9 @@ 
      */

     static function dol_nboflines($s, $maxchar = 0)

     {

-        if ($s == '')

-            return 0;

+        if ($s == '') {
+                    return 0;
+        }
         $arraystring = explode("\n", $s);

         $nb = count($arraystring);

 

@@ -5645,15 +5895,18 @@ 
     static function dol_nboflines_bis($text, $maxlinesize = 0, $charset = 'UTF-8')

     {

         $repTable = array("\t" => " ", "\n" => "<br>", "\r" => " ", "\0" => " ", "\x0B" => " ");

-        if (DolUtils::dol_textishtml($text))

-            $repTable = array("\t" => " ", "\n" => " ", "\r" => " ", "\0" => " ", "\x0B" => " ");

+        if (DolUtils::dol_textishtml($text)) {
+                    $repTable = array("\t" => " ", "\n" => " ", "\r" => " ", "\0" => " ", "\x0B" => " ");
+        }
 

         $text = strtr($text, $repTable);

         if ($charset == 'UTF-8') {

             $pattern = '/(<br[^>]*>)/Uu';

         } // /U is to have UNGREEDY regex to limit to one html tag. /u is for UTF8 support

-        else

-            $pattern = '/(<br[^>]*>)/U';       // /U is to have UNGREEDY regex to limit to one html tag.

+        else {
+                    $pattern = '/(<br[^>]*>)/U';
+        }
+        // /U is to have UNGREEDY regex to limit to one html tag.

         $a = preg_split($pattern, $text, -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);

 

         $nblines = (int) floor((count($a) + 1) / 2);

@@ -5700,39 +5953,47 @@ 
     static function dol_textishtml($msg, $option = 0)

     {

         if ($option == 1) {

-            if (preg_match('/<html/i', $msg))

-                return true;

-            elseif (preg_match('/<body/i', $msg))

-                return true;

-            elseif (preg_match('/<br/i', $msg))

-                return true;

+            if (preg_match('/<html/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<body/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<br/i', $msg)) {
+                            return true;
+            }
             return false;

-        }

-        else {

-            if (preg_match('/<html/i', $msg))

-                return true;

-            elseif (preg_match('/<body/i', $msg))

-                return true;

-            elseif (preg_match('/<(b|em|i|u)>/i', $msg))

-                return true;

-            elseif (preg_match('/<br\/>/i', $msg))

-                return true;

-            elseif (preg_match('/<(br|div|font|li|p|span|strong|table)>/i', $msg))

-                return true;

-            elseif (preg_match('/<(br|div|font|li|p|span|strong|table)\s+[^<>\/]*>/i', $msg))

-                return true;

-            elseif (preg_match('/<(br|div|font|li|p|span|strong|table)\s+[^<>\/]*\/>/i', $msg))

-                return true;

-            elseif (preg_match('/<img\s+[^<>]*src[^<>]*>/i', $msg))

-                return true; // must accept <img src="http://example.com/aaa.png" />

-            elseif (preg_match('/<a\s+[^<>]*href[^<>]*>/i', $msg))

-                return true; // must accept <a href="http://example.com/aaa.png" />

-            elseif (preg_match('/<h[0-9]>/i', $msg))

-                return true;

-            elseif (preg_match('/&[A-Z0-9]{1,6};/i', $msg))

-                return true;    // Html entities names (http://www.w3schools.com/tags/ref_entities.asp)

-            elseif (preg_match('/&#[0-9]{2,3};/i', $msg))

-                return true;    // Html entities numbers (http://www.w3schools.com/tags/ref_entities.asp)

+        } else {

+            if (preg_match('/<html/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<body/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<(b|em|i|u)>/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<br\/>/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<(br|div|font|li|p|span|strong|table)>/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<(br|div|font|li|p|span|strong|table)\s+[^<>\/]*>/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<(br|div|font|li|p|span|strong|table)\s+[^<>\/]*\/>/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/<img\s+[^<>]*src[^<>]*>/i', $msg)) {
+                            return true;
+            }
+            // must accept <img src="http://example.com/aaa.png" />

+            elseif (preg_match('/<a\s+[^<>]*href[^<>]*>/i', $msg)) {
+                            return true;
+            }
+            // must accept <a href="http://example.com/aaa.png" />

+            elseif (preg_match('/<h[0-9]>/i', $msg)) {
+                            return true;
+            } elseif (preg_match('/&[A-Z0-9]{1,6};/i', $msg)) {
+                            return true;
+            }
+            // Html entities names (http://www.w3schools.com/tags/ref_entities.asp)

+            elseif (preg_match('/&#[0-9]{2,3};/i', $msg)) {
+                            return true;
+            }
+            // Html entities numbers (http://www.w3schools.com/tags/ref_entities.asp)

 

             return false;

         }

@@ -5884,12 +6145,14 @@ 
                 $birthday = DolUtils::dol_print_date($object->birth, 'day');

 

                 $substitutionarray['__MEMBER_ID__'] = $object->id;

-                if (method_exists($object, 'getCivilityLabel'))

-                    $substitutionarray['__MEMBER_CIVILITY__'] = $object->getCivilityLabel();

+                if (method_exists($object, 'getCivilityLabel')) {
+                                    $substitutionarray['__MEMBER_CIVILITY__'] = $object->getCivilityLabel();
+                }
                 $substitutionarray['__MEMBER_FIRSTNAME__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->firstname) : $object->firstname;

                 $substitutionarray['__MEMBER_LASTNAME__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->lastname) : $object->lastname;

-                if (method_exists($object, 'getFullName'))

-                    $substitutionarray['__MEMBER_FULLNAME__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->getFullName($outputlangs)) : $object->getFullName($outputlangs);

+                if (method_exists($object, 'getFullName')) {
+                                    $substitutionarray['__MEMBER_FULLNAME__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->getFullName($outputlangs)) : $object->getFullName($outputlangs);
+                }
                 $substitutionarray['__MEMBER_COMPANY__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->societe) : $object->societe;

                 $substitutionarray['__MEMBER_ADDRESS__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->address) : $object->address;

                 $substitutionarray['__MEMBER_ZIP__'] = $msgishtml ? DolUtils::dol_htmlentitiesbr($object->zip) : $object->zip;

@@ -5937,10 +6200,12 @@ 
                     $dateplannedstart = '';

                     $datenextexpiration = '';

                     foreach ($object->lines as $line) {

-                        if ($line->date_ouverture_prevue > $dateplannedstart)

-                            $dateplannedstart = $line->date_ouverture_prevue;

-                        if ($line->statut == 4 && $line->date_fin_prevue && (!$datenextexpiration || $line->date_fin_prevue < $datenextexpiration))

-                            $datenextexpiration = $line->date_fin_prevue;

+                        if ($line->date_ouverture_prevue > $dateplannedstart) {
+                                                    $dateplannedstart = $line->date_ouverture_prevue;
+                        }
+                        if ($line->statut == 4 && $line->date_fin_prevue && (!$datenextexpiration || $line->date_fin_prevue < $datenextexpiration)) {
+                                                    $datenextexpiration = $line->date_fin_prevue;
+                        }
                     }

                     $substitutionarray['__CONTRACT_HIGHEST_PLANNED_START_DATE__'] = DolUtils::dol_print_date($dateplannedstart, 'dayrfc');

                     $substitutionarray['__CONTRACT_HIGHEST_PLANNED_START_DATETIME__'] = DolUtils::dol_print_date($dateplannedstart, 'standard');

@@ -5950,8 +6215,9 @@ 
 

 // Create dynamic tags for __EXTRAFIELD_FIELD__

                 if ($object->table_element && $object->id > 0) {

-                    if (!is_object($extrafields))

-                        $extrafields = new ExtraFields($db);

+                    if (!is_object($extrafields)) {
+                                            $extrafields = new ExtraFields($db);
+                    }
                     $extrafields->fetch_name_optionals_label($object->table_element, true);

 

                     if ($object->fetch_optionals() > 0) {

@@ -5972,12 +6238,15 @@ 
                     require_once DOL_BASE_PATH . '/core/lib/payments.lib.php';

                     $outputlangs->loadLangs(array('paypal', 'other'));

                     $typeforonlinepayment = 'free';

-                    if (is_object($object) && $object->element == 'commande')

-                        $typeforonlinepayment = 'order';

-                    if (is_object($object) && $object->element == 'facture')

-                        $typeforonlinepayment = 'invoice';

-                    if (is_object($object) && $object->element == 'member')

-                        $typeforonlinepayment = 'member';

+                    if (is_object($object) && $object->element == 'commande') {
+                                            $typeforonlinepayment = 'order';
+                    }
+                    if (is_object($object) && $object->element == 'facture') {
+                                            $typeforonlinepayment = 'invoice';
+                    }
+                    if (is_object($object) && $object->element == 'member') {
+                                            $typeforonlinepayment = 'member';
+                    }
                     $url = getOnlinePaymentUrl(0, $typeforonlinepayment, $substitutionarray['__REF__']);

                     $paymenturl = $url;

                 }

@@ -5987,16 +6256,19 @@ 
 

                 if (!empty(Globals::$conf->global->PROPOSAL_ALLOW_EXTERNAL_DOWNLOAD) && is_object($object) && $object->element == 'propal') {

                     $substitutionarray['__DIRECTDOWNLOAD_URL_PROPOSAL__'] = $object->getLastMainDocLink($object->element);

-                } else

-                    $substitutionarray['__DIRECTDOWNLOAD_URL_PROPOSAL__'] = '';

+                } else {
+                                    $substitutionarray['__DIRECTDOWNLOAD_URL_PROPOSAL__'] = '';
+                }
                 if (!empty(Globals::$conf->global->ORDER_ALLOW_EXTERNAL_DOWNLOAD) && is_object($object) && $object->element == 'commande') {

                     $substitutionarray['__DIRECTDOWNLOAD_URL_ORDER__'] = $object->getLastMainDocLink($object->element);

-                } else

-                    $substitutionarray['__DIRECTDOWNLOAD_URL_ORDER__'] = '';

+                } else {
+                                    $substitutionarray['__DIRECTDOWNLOAD_URL_ORDER__'] = '';
+                }
                 if (!empty(Globals::$conf->global->INVOICE_ALLOW_EXTERNAL_DOWNLOAD) && is_object($object) && $object->element == 'facture') {

                     $substitutionarray['__DIRECTDOWNLOAD_URL_INVOICE__'] = $object->getLastMainDocLink($object->element);

-                } else

-                    $substitutionarray['__DIRECTDOWNLOAD_URL_INVOICE__'] = '';

+                } else {
+                                    $substitutionarray['__DIRECTDOWNLOAD_URL_INVOICE__'] = '';
+                }
             }

         }

         if (empty($exclude) || !in_array('objectamount', $exclude)) {

@@ -6006,18 +6278,22 @@ 
             $substitutionarray['__AMOUNT__'] = is_object($object) ? $object->total_ttc : '';

             $substitutionarray['__AMOUNT_EXCL_TAX__'] = is_object($object) ? $object->total_ht : '';

             $substitutionarray['__AMOUNT_VAT__'] = is_object($object) ? ($object->total_vat ? $object->total_vat : $object->total_tva) : '';

-            if ($onlykey != 2 || $mysoc->useLocalTax(1))

-                $substitutionarray['__AMOUNT_TAX2__'] = is_object($object) ? $object->total_localtax1 : '';

-            if ($onlykey != 2 || $mysoc->useLocalTax(2))

-                $substitutionarray['__AMOUNT_TAX3__'] = is_object($object) ? $object->total_localtax2 : '';

+            if ($onlykey != 2 || $mysoc->useLocalTax(1)) {
+                            $substitutionarray['__AMOUNT_TAX2__'] = is_object($object) ? $object->total_localtax1 : '';
+            }
+            if ($onlykey != 2 || $mysoc->useLocalTax(2)) {
+                            $substitutionarray['__AMOUNT_TAX3__'] = is_object($object) ? $object->total_localtax2 : '';
+            }
 

             $substitutionarray['__AMOUNT_FORMATED__'] = is_object($object) ? price($object->total_ttc, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : '';

             $substitutionarray['__AMOUNT_EXCL_TAX_FORMATED__'] = is_object($object) ? price($object->total_ht, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : '';

             $substitutionarray['__AMOUNT_VAT_FORMATED__'] = is_object($object) ? ($object->total_vat ? price($object->total_vat, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : price($object->total_tva, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency)) : '';

-            if ($onlykey != 2 || $mysoc->useLocalTax(1))

-                $substitutionarray['__AMOUNT_TAX2_FORMATED__'] = is_object($object) ? price($object->total_localtax1, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : '';

-            if ($onlykey != 2 || $mysoc->useLocalTax(2))

-                $substitutionarray['__AMOUNT_TAX3_FORMATED__'] = is_object($object) ? price($object->total_localtax2, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : '';

+            if ($onlykey != 2 || $mysoc->useLocalTax(1)) {
+                            $substitutionarray['__AMOUNT_TAX2_FORMATED__'] = is_object($object) ? price($object->total_localtax1, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : '';
+            }
+            if ($onlykey != 2 || $mysoc->useLocalTax(2)) {
+                            $substitutionarray['__AMOUNT_TAX3_FORMATED__'] = is_object($object) ? price($object->total_localtax2, 0, $outputlangs, 0, 0, -1, Globals::$conf->currency) : '';
+            }
 

 // TODO Add keys for foreign multicurrency

 // For backward compatibility

@@ -6087,23 +6363,27 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if (!is_array($substitutionarray))

-            return 'ErrorBadParameterSubstitutionArrayWhenCalling_make_substitutions';

+        if (!is_array($substitutionarray)) {
+                    return 'ErrorBadParameterSubstitutionArrayWhenCalling_make_substitutions';
+        }
 

-        if (empty($outputlangs))

-            $outputlangs = Globals::$langs;

+        if (empty($outputlangs)) {
+                    $outputlangs = Globals::$langs;
+        }
 

 // Make substitution for language keys

         if (is_object($outputlangs)) {

             while (preg_match('/__\(([^\)]+)\)__/', $text, $reg)) {

                 $msgishtml = 0;

-                if (DolUtils::dol_textishtml($text, 1))

-                    $msgishtml = 1;

+                if (DolUtils::dol_textishtml($text, 1)) {
+                                    $msgishtml = 1;
+                }
 

 // If key is __(TranslationKey|langfile)__, then force load of langfile.lang

                 $tmp = explode('|', $reg[1]);

-                if (!empty($tmp[1]))

-                    $outputlangs->load($tmp[1]);

+                if (!empty($tmp[1])) {
+                                    $outputlangs->load($tmp[1]);
+                }
 

                 $text = preg_replace('/__\(' . preg_quote($reg[1], '/') . '\)__/', $msgishtml ? DolUtils::dol_htmlentitiesbr($outputlangs->transnoentitiesnoconv($reg[1])) : $outputlangs->transnoentitiesnoconv($reg[1]), $text);

             }

@@ -6113,23 +6393,29 @@ 
 // it is also converted.

         while (preg_match('/__\[([^\]]+)\]__/', $text, $reg)) {

             $msgishtml = 0;

-            if (DolUtils::dol_textishtml($text, 1))

-                $msgishtml = 1;

+            if (DolUtils::dol_textishtml($text, 1)) {
+                            $msgishtml = 1;
+            }
 

             $keyfound = $reg[1];

-            if (preg_match('/(_pass|password|secret|_key|key$)/i', $keyfound))

-                $newval = '*****forbidden*****';

-            else

-                $newval = empty(Globals::$conf->global->$keyfound) ? '' : Globals::$conf->global->$keyfound;

+            if (preg_match('/(_pass|password|secret|_key|key$)/i', $keyfound)) {
+                            $newval = '*****forbidden*****';
+            } else {
+                            $newval = empty(Globals::$conf->global->$keyfound) ? '' : Globals::$conf->global->$keyfound;
+            }
             $text = preg_replace('/__\[' . preg_quote($keyfound, '/') . '\]__/', $msgishtml ? DolUtils::dol_htmlentitiesbr($newval) : $newval, $text);

         }

 

 // Make substitition for array $substitutionarray

         foreach ($substitutionarray as $key => $value) {

-            if ($key == '__SIGNATURE__' && (!empty(Globals::$conf->global->MAIN_MAIL_DO_NOT_USE_SIGN)))

-                $value = '';  // Protection

-            if ($key == '__USER_SIGNATURE__' && (!empty(Globals::$conf->global->MAIN_MAIL_DO_NOT_USE_SIGN)))

-                $value = ''; // Protection

+            if ($key == '__SIGNATURE__' && (!empty(Globals::$conf->global->MAIN_MAIL_DO_NOT_USE_SIGN))) {
+                            $value = '';
+            }
+            // Protection

+            if ($key == '__USER_SIGNATURE__' && (!empty(Globals::$conf->global->MAIN_MAIL_DO_NOT_USE_SIGN))) {
+                            $value = '';
+            }
+            // Protection

 

             $text = str_replace("$key", "$value", $text); // We must keep the " to work when value is 123.5 for example

         }

@@ -6175,8 +6461,9 @@ 
             $dir = dol_buildpath($reldir, 0);

 

 // Check if directory exists

-            if (!dol_is_dir($dir))

-                continue;

+            if (!dol_is_dir($dir)) {
+                            continue;
+            }
 

             $substitfiles = dol_dir_list($dir, 'files', 0, 'functions_');

             foreach ($substitfiles as $substitfile) {

@@ -6188,8 +6475,9 @@ 
                     require_once $dir . $substitfile['name'];

                     // Call the user's function, and only if it is defined

                     $function_name = $module . "_" . $callfunc;

-                    if (function_exists($function_name))

-                        $function_name($substitutionarray, $outputlangs, $object, $parameters);

+                    if (function_exists($function_name)) {
+                                            $function_name($substitutionarray, $outputlangs, $object, $parameters);
+                    }
                 }

             }

         }

@@ -6225,8 +6513,9 @@ 
 

         $out = '';

 

-        if (!is_object($outputlangs))

-            $outputlangs = Globals::$langs;

+        if (!is_object($outputlangs)) {
+                    $outputlangs = Globals::$langs;
+        }
 

         if ($date_start && $date_end) {

             $out .= ($withparenthesis ? ' (' : '') . $outputlangs->transnoentitiesnoconv('DateFromTo', DolUtils::dol_print_date($date_start, $format, false, $outputlangs), DolUtils::dol_print_date($date_end, $format, false, $outputlangs)) . ($withparenthesis ? ')' : '');

@@ -6255,20 +6544,22 @@ 
 

         $ret = '';

 // If order not defined, we use the setup

-        if ($nameorder < 0)

-            $nameorder = (empty(Globals::$conf->global->MAIN_FIRSTNAME_NAME_POSITION) ? 1 : 0);

+        if ($nameorder < 0) {
+                    $nameorder = (empty(Globals::$conf->global->MAIN_FIRSTNAME_NAME_POSITION) ? 1 : 0);
+        }
         if ($nameorder && ((string) $nameorder != '2')) {

             $ret .= $firstname;

-            if ($firstname && $lastname)

-                $ret .= ' ';

+            if ($firstname && $lastname) {
+                            $ret .= ' ';
+            }
             $ret .= $lastname;

-        }

-        else if ($nameorder == 2) {

+        } else if ($nameorder == 2) {

             $ret .= $firstname;

         } else {

             $ret .= $lastname;

-            if ($firstname && $lastname)

-                $ret .= ' ';

+            if ($firstname && $lastname) {
+                            $ret .= ' ';
+            }
             $ret .= $firstname;

         }

         return $ret;

@@ -6288,13 +6579,14 @@ 
     {

 //DolUtils::dol_syslog(__FUNCTION__ . " is deprecated", LOG_WARNING);		This is not deprecated, it is used by setEventMessages function

         if (!is_array($mesgs)) {  // If mesgs is a string

-            if ($mesgs)

-                $_SESSION['dol_events'][$style][] = $mesgs;

-        }

-        else {      // If mesgs is an array

+            if ($mesgs) {
+                            $_SESSION['dol_events'][$style][] = $mesgs;
+            }
+        } else {      // If mesgs is an array

             foreach ($mesgs as $mesg) {

-                if ($mesg)

-                    $_SESSION['dol_events'][$style][] = $mesg;

+                if ($mesg) {
+                                    $_SESSION['dol_events'][$style][] = $mesg;
+                }
             }

         }

     }

@@ -6314,13 +6606,16 @@ 
         if (empty($mesg) && empty($mesgs)) {

             DolUtils::dol_syslog("Try to add a message in stack with empty message", LOG_WARNING);

         } else {

-            if (!in_array((string) $style, array('mesgs', 'warnings', 'errors')))

-                dol_print_error('', 'Bad parameter style=' . $style . ' for setEventMessages');

-            if (empty($mesgs))

-                setEventMessage($mesg, $style);

-            else {

-                if (!empty($mesg) && !in_array($mesg, $mesgs))

-                    setEventMessage($mesg, $style); // Add message string if not already into array

+            if (!in_array((string) $style, array('mesgs', 'warnings', 'errors'))) {
+                            dol_print_error('', 'Bad parameter style=' . $style . ' for setEventMessages');
+            }
+            if (empty($mesgs)) {
+                            setEventMessage($mesg, $style);
+            } else {

+                if (!empty($mesg) && !in_array($mesg, $mesgs)) {
+                                    setEventMessage($mesg, $style);
+                }
+                // Add message string if not already into array

                 setEventMessage($mesgs, $style);

             }

         }

@@ -6339,22 +6634,25 @@ 
     {

 // Show mesgs

         if (isset($_SESSION['dol_events']['mesgs'])) {

-            if (empty($disabledoutputofmessages))

-                dol_htmloutput_mesg('', $_SESSION['dol_events']['mesgs']);

+            if (empty($disabledoutputofmessages)) {
+                            dol_htmloutput_mesg('', $_SESSION['dol_events']['mesgs']);
+            }
             unset($_SESSION['dol_events']['mesgs']);

         }

 

 // Show errors

         if (isset($_SESSION['dol_events']['errors'])) {

-            if (empty($disabledoutputofmessages))

-                dol_htmloutput_mesg('', $_SESSION['dol_events']['errors'], 'error');

+            if (empty($disabledoutputofmessages)) {
+                            dol_htmloutput_mesg('', $_SESSION['dol_events']['errors'], 'error');
+            }
             unset($_SESSION['dol_events']['errors']);

         }

 

 // Show warnings

         if (isset($_SESSION['dol_events']['warnings'])) {

-            if (empty($disabledoutputofmessages))

-                dol_htmloutput_mesg('', $_SESSION['dol_events']['warnings'], 'warning');

+            if (empty($disabledoutputofmessages)) {
+                            dol_htmloutput_mesg('', $_SESSION['dol_events']['warnings'], 'warning');
+            }
             unset($_SESSION['dol_events']['warnings']);

         }

     }

@@ -6395,8 +6693,9 @@ 
                 foreach ($mesgarray as $message) {

                     $ret++;

                     $out .= Globals::$langs->trans($message);

-                    if ($ret < count($mesgarray))

-                        $out .= "<br>\n";

+                    if ($ret < count($mesgarray)) {
+                                            $out .= "<br>\n";
+                    }
                 }

             }

             if ($mesgstring) {

@@ -6462,8 +6761,9 @@ 
      */

     static function dol_htmloutput_mesg($mesgstring = '', $mesgarray = array(), $style = 'ok', $keepembedded = 0)

     {

-        if (empty($mesgstring) && (!is_array($mesgarray) || count($mesgarray) == 0))

-            return;

+        if (empty($mesgstring) && (!is_array($mesgarray) || count($mesgarray) == 0)) {
+                    return;
+        }
 

         $iserror = 0;

         $iswarning = 0;

@@ -6478,14 +6778,17 @@ 
                     break;

                 }

             }

-        } else if ($mesgstring && preg_match('/class="error"/i', $mesgstring))

-            $iserror++;

-        else if ($mesgstring && preg_match('/class="warning"/i', $mesgstring))

-            $iswarning++;

-        if ($style == 'error')

-            $iserror++;

-        if ($style == 'warning')

-            $iswarning++;

+        } else if ($mesgstring && preg_match('/class="error"/i', $mesgstring)) {
+                    $iserror++;
+        } else if ($mesgstring && preg_match('/class="warning"/i', $mesgstring)) {
+                    $iswarning++;
+        }
+        if ($style == 'error') {
+                    $iserror++;
+        }
+        if ($style == 'warning') {
+                    $iswarning++;
+        }
 

         if ($iserror || $iswarning) {

 // Remove div from texts

@@ -6504,8 +6807,9 @@ 
                 $mesgarray = $newmesgarray;

             }

             print get_htmloutput_mesg($mesgstring, $mesgarray, ($iserror ? 'error' : 'warning'), $keepembedded);

-        } else

-            print get_htmloutput_mesg($mesgstring, $mesgarray, 'ok', $keepembedded);

+        } else {
+                    print get_htmloutput_mesg($mesgstring, $mesgarray, 'ok', $keepembedded);
+        }
     }

 

     /**

@@ -6546,15 +6850,17 @@ 
             $sizearray = count($array);

             if ($sizearray > 0) {

                 $temp = array();

-                foreach (array_keys($array) as $key)

-                    $temp[$key] = $array[$key][$index];

+                foreach (array_keys($array) as $key) {
+                                    $temp[$key] = $array[$key][$index];
+                }
 

-                if (!$natsort)

-                    ($order == 'asc') ? asort($temp) : arsort($temp);

-                else {

+                if (!$natsort) {
+                                    ($order == 'asc') ? asort($temp) : arsort($temp);
+                } else {

                     ($case_sensitive) ? natsort($temp) : natcasesort($temp);

-                    if ($order != 'asc')

-                        $temp = array_reverse($temp, true);

+                    if ($order != 'asc') {
+                                            $temp = array_reverse($temp, true);
+                    }
                 }

 

                 $sorted = array();

@@ -6580,23 +6886,38 @@ 
         // We must use here a binary strlen static function (so not DolUtils::dol_strlen)

         $strLength = DolUtils::dol_strlen($str);

         for ($i = 0; $i < $strLength; $i++) {

-            if (ord($str[$i]) < 0x80)

-                continue; // 0bbbbbbb

-            elseif ((ord($str[$i]) & 0xE0) == 0xC0)

-                $n = 1; // 110bbbbb

-            elseif ((ord($str[$i]) & 0xF0) == 0xE0)

-                $n = 2; // 1110bbbb

-            elseif ((ord($str[$i]) & 0xF8) == 0xF0)

-                $n = 3; // 11110bbb

-            elseif ((ord($str[$i]) & 0xFC) == 0xF8)

-                $n = 4; // 111110bb

-            elseif ((ord($str[$i]) & 0xFE) == 0xFC)

-                $n = 5; // 1111110b

-            else

-                return false; // Does not match any model

+            if (ord($str[$i]) < 0x80) {
+                            continue;
+            }
+            // 0bbbbbbb

+            elseif ((ord($str[$i]) & 0xE0) == 0xC0) {
+                            $n = 1;
+            }
+            // 110bbbbb

+            elseif ((ord($str[$i]) & 0xF0) == 0xE0) {
+                            $n = 2;
+            }
+            // 1110bbbb

+            elseif ((ord($str[$i]) & 0xF8) == 0xF0) {
+                            $n = 3;
+            }
+            // 11110bbb

+            elseif ((ord($str[$i]) & 0xFC) == 0xF8) {
+                            $n = 4;
+            }
+            // 111110bb

+            elseif ((ord($str[$i]) & 0xFE) == 0xFC) {
+                            $n = 5;
+            }
+            // 1111110b

+            else {
+                            return false;
+            }
+            // Does not match any model

             for ($j = 0; $j < $n; $j++) { // n bytes matching 10bbbbbb follow ?

-                if (( ++$i == strlen($str)) || ((ord($str[$i]) & 0xC0) != 0x80))

-                    return false;

+                if (( ++$i == strlen($str)) || ((ord($str[$i]) & 0xC0) != 0x80)) {
+                                    return false;
+                }
             }

         }

         return true;

@@ -6614,15 +6935,21 @@ 
         // global Globals::$conf;

 

         $tmp = ini_get("unicode.filesystem_encoding");      // Disponible avec PHP 6.0

-        if (empty($tmp) && !empty($_SERVER["WINDIR"]))

-            $tmp = 'iso-8859-1'; // By default for windows

-        if (empty($tmp))

-            $tmp = 'utf-8';          // By default for other

-        if (!empty(Globals::$conf->global->MAIN_FILESYSTEM_ENCODING))

-            $tmp = Globals::$conf->global->MAIN_FILESYSTEM_ENCODING;

-

-        if ($tmp == 'iso-8859-1')

-            return utf8_decode($str);

+        if (empty($tmp) && !empty($_SERVER["WINDIR"])) {
+                    $tmp = 'iso-8859-1';
+        }
+        // By default for windows

+        if (empty($tmp)) {
+                    $tmp = 'utf-8';
+        }
+        // By default for other

+        if (!empty(Globals::$conf->global->MAIN_FILESYSTEM_ENCODING)) {
+                    $tmp = Globals::$conf->global->MAIN_FILESYSTEM_ENCODING;
+        }
+

+        if ($tmp == 'iso-8859-1') {
+                    return utf8_decode($str);
+        }
         return $str;

     }

 

@@ -6643,8 +6970,9 @@ 
     {

         // global $cache_codes;

 // If key empty

-        if ($key == '')

-            return '';

+        if ($key == '') {
+                    return '';
+        }
 

 // Check in cache

         if (isset($cache_codes[$tablename][$key][$fieldid])) { // Can be defined to 0 or ''

@@ -6656,20 +6984,21 @@ 
         $sql = "SELECT " . $fieldid . " as valuetoget";

         $sql .= " FROM " . MAIN_DB_PREFIX . $tablename;

         $sql .= " WHERE " . $fieldkey . " = '" . $db->escape($key) . "'";

-        if (!empty($entityfilter))

-            $sql .= " AND entity IN (" . getEntity($tablename) . ")";

+        if (!empty($entityfilter)) {
+                    $sql .= " AND entity IN (" . getEntity($tablename) . ")";
+        }
 

         $resql = $db->query($sql);

         if ($resql) {

             $obj = $db->fetch_object($resql);

-            if ($obj)

-                $cache_codes[$tablename][$key][$fieldid] = $obj->valuetoget;

-            else

-                $cache_codes[$tablename][$key][$fieldid] = '';

+            if ($obj) {
+                            $cache_codes[$tablename][$key][$fieldid] = $obj->valuetoget;
+            } else {
+                            $cache_codes[$tablename][$key][$fieldid] = '';
+            }
             $db->free($resql);

             return $cache_codes[$tablename][$key][$fieldid];

-        }

-        else {

+        } else {

             return -1;

         }

     }

@@ -6715,16 +7044,17 @@ 
         // global $soc;       // For backward compatibility

 //print $s."<br>\n";

         if ($returnvalue) {

-            if ($hideerrors)

-                return @eval('return ' . $s . ';');

-            else

-                return eval('return ' . $s . ';');

-        }

-        else {

-            if ($hideerrors)

-                @eval($s);

-            else

-                eval($s);

+            if ($hideerrors) {
+                            return @eval('return ' . $s . ';');
+            } else {
+                            return eval('return ' . $s . ';');
+            }
+        } else {

+            if ($hideerrors) {
+                            @eval($s);
+            } else {
+                            eval($s);
+            }
         }

     }

 

@@ -6750,8 +7080,9 @@ 
     {

         // global Globals::$langs;

 

-        if (empty($codelang))

-            return '';

+        if (empty($codelang)) {
+                    return '';
+        }
 

         if ($codelang == 'auto') {

             return '<span class="fa fa-globe"></span>';

@@ -6765,9 +7096,9 @@ 
             'sv_SV' => 'se'

         );

 

-        if (isset($langtocountryflag[$codelang]))

-            $flagImage = $langtocountryflag[$codelang];

-        else {

+        if (isset($langtocountryflag[$codelang])) {
+                    $flagImage = $langtocountryflag[$codelang];
+        } else {

             $tmparray = explode('_', $codelang);

             $flagImage = empty($tmparray[1]) ? $tmparray[0] : $tmparray[1];

         }

@@ -6785,15 +7116,20 @@ 
     {

         // global $mysoc;

 

-        if (strtoupper($countrycode) == 'MQ')

-            return 'fr_CA';

-        if (strtoupper($countrycode) == 'SE')

-            return 'sv_SE'; // se_SE is Sami/Sweden, and we want in priority sv_SE for SE country

+        if (strtoupper($countrycode) == 'MQ') {
+                    return 'fr_CA';
+        }
+        if (strtoupper($countrycode) == 'SE') {
+                    return 'sv_SE';
+        }
+        // se_SE is Sami/Sweden, and we want in priority sv_SE for SE country

         if (strtoupper($countrycode) == 'CH') {

-            if ($mysoc->country_code == 'FR')

-                return 'fr_CH';

-            if ($mysoc->country_code == 'DE')

-                return 'de_CH';

+            if ($mysoc->country_code == 'FR') {
+                            return 'fr_CH';
+            }
+            if ($mysoc->country_code == 'DE') {
+                            return 'de_CH';
+            }
         }

 

 // Locale list taken from:

@@ -6971,8 +7307,9 @@ 
         );

 

         $buildprimarykeytotest = strtolower($countrycode) . '-' . strtoupper($countrycode);

-        if (in_array($buildprimarykeytotest, $locales))

-            return strtolower($countrycode) . '_' . strtoupper($countrycode);

+        if (in_array($buildprimarykeytotest, $locales)) {
+                    return strtolower($countrycode) . '_' . strtoupper($countrycode);
+        }
 

         foreach ($locales as $locale) {

             $locale_language = locale_get_primary_language($locale);

@@ -7026,18 +7363,21 @@ 
 

                 if ($mode == 'add' && !preg_match('/^\-/', $values[1])) {

                     if (count($values) == 6) {       // new declaration with permissions:  $value='objecttype:+tabname1:Title1:langfile@mymodule:$user->rights->mymodule->read:/mymodule/mynewtab1.php?id=__ID__'

-                        if ($values[0] != $type)

-                            continue;

+                        if ($values[0] != $type) {
+                                                    continue;
+                        }
 

                         if (verifCond($values[4])) {

-                            if ($values[3])

-                                Globals::$langs->load($values[3]);

+                            if ($values[3]) {
+                                                            Globals::$langs->load($values[3]);
+                            }
                             if (preg_match('/SUBSTITUTION_([^_]+)/i', $values[2], $reg)) {

                                 $substitutionarray = array();

                                 complete_substitutions_array($substitutionarray, Globals::$langs, $object, array('needforkey' => $values[2]));

                                 $label = make_substitutions($reg[1], $substitutionarray);

-                            } else

-                                $label = Globals::$langs->trans($values[2]);

+                            } else {
+                                                            $label = Globals::$langs->trans($values[2]);
+                            }
 

                             //$head[$h][0] = dol_buildpath(preg_replace('/__ID__/i', ((is_object($object) && !empty($object->id)) ? $object->id : ''), $values[5]), 1);

                             $head[$h][0] = BASE_URI . preg_replace('/__ID__/i', ((is_object($object) && !empty($object->id)) ? $object->id : ''), $values[5]);

@@ -7045,30 +7385,32 @@ 
                             $head[$h][2] = str_replace('+', '', $values[1]);

                             $h++;

                         }

-                    }

-                    else if (count($values) == 5) {       // deprecated

+                    } else if (count($values) == 5) {       // deprecated

                         DolUtils::dol_syslog('Passing 5 values in tabs module_parts is deprecated. Please update to 6 with permissions.', LOG_WARNING);

 

-                        if ($values[0] != $type)

-                            continue;

-                        if ($values[3])

-                            Globals::$langs->load($values[3]);

+                        if ($values[0] != $type) {
+                                                    continue;
+                        }
+                        if ($values[3]) {
+                                                    Globals::$langs->load($values[3]);
+                        }
                         if (preg_match('/SUBSTITUTION_([^_]+)/i', $values[2], $reg)) {

                             $substitutionarray = array();

                             complete_substitutions_array($substitutionarray, Globals::$langs, $object, array('needforkey' => $values[2]));

                             $label = make_substitutions($reg[1], $substitutionarray);

-                        } else

-                            $label = Globals::$langs->trans($values[2]);

+                        } else {
+                                                    $label = Globals::$langs->trans($values[2]);
+                        }
 

                         $head[$h][0] = dol_buildpath(preg_replace('/__ID__/i', ((is_object($object) && !empty($object->id)) ? $object->id : ''), $values[4]), 1);

                         $head[$h][1] = $label;

                         $head[$h][2] = str_replace('+', '', $values[1]);

                         $h++;

                     }

-                }

-                else if ($mode == 'remove' && preg_match('/^\-/', $values[1])) {

-                    if ($values[0] != $type)

-                        continue;

+                } else if ($mode == 'remove' && preg_match('/^\-/', $values[1])) {

+                    if ($values[0] != $type) {
+                                            continue;
+                    }
                     $tabname = str_replace('-', '', $values[1]);

                     foreach ($head as $key => $val) {

                         $condition = (!empty($values[3]) ? verifCond($values[3]) : 1);

@@ -7110,10 +7452,11 @@ 
         // global $action;

         // global $micro_start_time;

 

-        if ($zone == 'private')

-            print "\n" . '<!-- Common footer for private page -->' . "\n";

-        else

-            print "\n" . '<!-- Common footer for public page -->' . "\n";

+        if ($zone == 'private') {
+                    print "\n" . '<!-- Common footer for private page -->' . "\n";
+        } else {
+                    print "\n" . '<!-- Common footer for public page -->' . "\n";
+        }
 

 // A div to store page_y POST parameter so we can read it using javascript

         print "\n<!-- A div to store page_y POST paramater -->\n";

@@ -7122,8 +7465,9 @@ 
         $parameters = array();

         $reshook = Globals::$hookManager->executeHooks('printCommonFooter', $parameters);    // Note that $action and $object may have been modified by some hooks

         if (empty($reshook)) {

-            if (!empty(Globals::$conf->global->MAIN_HTML_FOOTER))

-                print Globals::$conf->global->MAIN_HTML_FOOTER . "\n";

+            if (!empty(Globals::$conf->global->MAIN_HTML_FOOTER)) {
+                            print Globals::$conf->global->MAIN_HTML_FOOTER . "\n";
+            }
 

             print "\n";

             if (!empty(Globals::$conf->use_javascript_ajax)) {

@@ -7146,8 +7490,9 @@ 
                     print '/* JS CODE TO ENABLE to manage focus and mandatory form fields */' . "\n";

                     $relativepathstring = $_SERVER["PHP_SELF"];

                     // Clean $relativepathstring

-                    if (constant('DOL_BASE_URI'))

-                        $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);

+                    if (constant('DOL_BASE_URI')) {
+                                            $relativepathstring = preg_replace('/^' . preg_quote(constant('DOL_BASE_URI'), '/') . '/', '', $relativepathstring);
+                    }
                     $relativepathstring = preg_replace('/^\//', '', $relativepathstring);

                     $relativepathstring = preg_replace('/^custom\//', '', $relativepathstring);

                     $tmpqueryarraywehave = explode('&', dol_string_nohtmltag($_SERVER['QUERY_STRING']));

@@ -7158,14 +7503,17 @@ 
                                 $tmpqueryarraytohave = explode('&', $defkey);

                                 $foundintru = 0;

                                 foreach ($tmpqueryarraytohave as $tmpquerytohave) {

-                                    if (!in_array($tmpquerytohave, $tmpqueryarraywehave))

-                                        $foundintru = 1;

+                                    if (!in_array($tmpquerytohave, $tmpqueryarraywehave)) {
+                                                                            $foundintru = 1;
+                                    }
                                 }

-                                if (!$foundintru)

-                                    $qualified = 1;

+                                if (!$foundintru) {
+                                                                    $qualified = 1;
+                                }
                                 //var_dump($defkey.'-'.$qualified);

-                            } else

-                                $qualified = 1;

+                            } else {
+                                                            $qualified = 1;
+                            }
 

                             if ($qualified) {

                                 foreach ($defval as $paramkey => $paramval) {

@@ -7184,14 +7532,17 @@ 
                                 $tmpqueryarraytohave = explode('&', $defkey);

                                 $foundintru = 0;

                                 foreach ($tmpqueryarraytohave as $tmpquerytohave) {

-                                    if (!in_array($tmpquerytohave, $tmpqueryarraywehave))

-                                        $foundintru = 1;

+                                    if (!in_array($tmpquerytohave, $tmpqueryarraywehave)) {
+                                                                            $foundintru = 1;
+                                    }
                                 }

-                                if (!$foundintru)

-                                    $qualified = 1;

+                                if (!$foundintru) {
+                                                                    $qualified = 1;
+                                }
                                 //var_dump($defkey.'-'.$qualified);

-                            } else

-                                $qualified = 1;

+                            } else {
+                                                            $qualified = 1;
+                            }
 

                             if ($qualified) {

                                 foreach ($defval as $paramkey => $paramval) {

@@ -7230,8 +7581,9 @@ 
                     print "\n";

                     print "/* JS CODE TO ENABLE to add memory info */\n";

                     print 'window.console && console.log("';

-                    if (!empty(Globals::$conf->global->MEMCACHED_SERVER))

-                        print 'MEMCACHED_SERVER=' . Globals::$conf->global->MEMCACHED_SERVER . ' - ';

+                    if (!empty(Globals::$conf->global->MEMCACHED_SERVER)) {
+                                            print 'MEMCACHED_SERVER=' . Globals::$conf->global->MEMCACHED_SERVER . ' - ';
+                    }
                     print 'MAIN_OPTIMIZE_SPEED=' . (isset(Globals::$conf->global->MAIN_OPTIMIZE_SPEED) ? Globals::$conf->global->MAIN_OPTIMIZE_SPEED : 'off');

                     if (!empty($micro_start_time)) {   // Works only if MAIN_SHOW_TUNING_INFO is defined at $_SERVER level. Not in// global variable.

                         $micro_end_time = microtime(true);

@@ -7361,8 +7713,9 @@ 
 

         $crits = explode(' ', $value);

         $res = '';

-        if (!is_array($fields))

-            $fields = array($fields);

+        if (!is_array($fields)) {
+                    $fields = array($fields);
+        }
 

         $nboffields = count($fields);

         $end2 = count($crits);

@@ -7425,8 +7778,9 @@ 
                     $tmpcrits = explode('|', $crit);

                     $i3 = 0;

                     foreach ($tmpcrits as $tmpcrit) {

-                        if (empty($tmpcrit))

-                            continue;

+                        if (empty($tmpcrit)) {
+                                                    continue;
+                        }
 

                         $newres .= (($i2 > 0 || $i3 > 0) ? ' OR ' : '');

 

@@ -7462,8 +7816,9 @@ 
                 }

                 $i++;

             }

-            if ($newres)

-                $res = $res . ($res ? ' AND ' : '') . ($i2 > 1 ? '(' : '') . $newres . ($i2 > 1 ? ')' : '');

+            if ($newres) {
+                            $res = $res . ($res ? ' AND ' : '') . ($i2 > 1 ? '(' : '') . $newres . ($i2 > 1 ? ')' : '');
+            }
             $j++;

         }

         $res = ($nofirstand ? "" : " AND ") . "(" . $res . ")";

@@ -7503,29 +7858,37 @@ 
     static function getImageFileNameForSize($file, $extName, $extImgTarget = '')

     {

         $dirName = dirname($file);

-        if ($dirName == '.')

-            $dirName = '';

+        if ($dirName == '.') {
+                    $dirName = '';
+        }
 

         $fileName = preg_replace('/(\.gif|\.jpeg|\.jpg|\.png|\.bmp)$/i', '', $file); // We remove extension, whatever is its case

         $fileName = basename($fileName);

 

-        if (empty($extImgTarget))

-            $extImgTarget = (preg_match('/\.jpg$/i', $file) ? '.jpg' : '');

-        if (empty($extImgTarget))

-            $extImgTarget = (preg_match('/\.jpeg$/i', $file) ? '.jpeg' : '');

-        if (empty($extImgTarget))

-            $extImgTarget = (preg_match('/\.gif$/i', $file) ? '.gif' : '');

-        if (empty($extImgTarget))

-            $extImgTarget = (preg_match('/\.png$/i', $file) ? '.png' : '');

-        if (empty($extImgTarget))

-            $extImgTarget = (preg_match('/\.bmp$/i', $file) ? '.bmp' : '');

-

-        if (!$extImgTarget)

-            return $file;

+        if (empty($extImgTarget)) {
+                    $extImgTarget = (preg_match('/\.jpg$/i', $file) ? '.jpg' : '');
+        }
+        if (empty($extImgTarget)) {
+                    $extImgTarget = (preg_match('/\.jpeg$/i', $file) ? '.jpeg' : '');
+        }
+        if (empty($extImgTarget)) {
+                    $extImgTarget = (preg_match('/\.gif$/i', $file) ? '.gif' : '');
+        }
+        if (empty($extImgTarget)) {
+                    $extImgTarget = (preg_match('/\.png$/i', $file) ? '.png' : '');
+        }
+        if (empty($extImgTarget)) {
+                    $extImgTarget = (preg_match('/\.bmp$/i', $file) ? '.bmp' : '');
+        }
+

+        if (!$extImgTarget) {
+                    return $file;
+        }
 

         $subdir = '';

-        if ($extName)

-            $subdir = 'thumbs/';

+        if ($extName) {
+                    $subdir = 'thumbs/';
+        }
 

         return ($dirName ? $dirName . '/' : '') . $subdir . $fileName . $extName . $extImgTarget; // New filename for thumb

     }

@@ -7543,8 +7906,9 @@ 
     {

         // global Globals::$conf, Globals::$langs;

 

-        if (empty(Globals::$conf->use_javascript_ajax))

-            return '';

+        if (empty(Globals::$conf->use_javascript_ajax)) {
+                    return '';
+        }
 

         $mime_preview = array('bmp', 'jpeg', 'png', 'gif', 'tiff', 'pdf', 'plain', 'css', 'svg+xml');

 //$mime_preview[]='vnd.oasis.opendocument.presentation';

@@ -7552,17 +7916,19 @@ 
         $num_mime = array_search(dol_mimetype($relativepath, '', 1), $mime_preview);

 

         if ($alldata == 1) {

-            if ($num_mime !== false)

-                return array('target' => '_blank', 'css' => 'documentpreview', 'url' => DOL_BASE_URI . '/document.php?modulepart=' . $modulepart . '&attachment=0&file=' . urlencode($relativepath) . ($param ? '&' . $param : ''), 'mime' => dol_mimetype($relativepath),);

-            else

-                return array();

+            if ($num_mime !== false) {
+                            return array('target' => '_blank', 'css' => 'documentpreview', 'url' => DOL_BASE_URI . '/document.php?modulepart=' . $modulepart . '&attachment=0&file=' . urlencode($relativepath) . ($param ? '&' . $param : ''), 'mime' => dol_mimetype($relativepath),);
+            } else {
+                            return array();
+            }
         }

 

 // old behavior

-        if ($num_mime !== false)

-            return 'javascript:document_preview(\'' . dol_escape_js(DOL_BASE_URI . '/document.php?modulepart=' . $modulepart . '&attachment=0&file=' . urlencode($relativepath) . ($param ? '&' . $param : '')) . '\', \'' . dol_mimetype($relativepath) . '\', \'' . dol_escape_js(Globals::$langs->trans('Preview')) . '\')';

-        else

-            return '';

+        if ($num_mime !== false) {
+                    return 'javascript:document_preview(\'' . dol_escape_js(DOL_BASE_URI . '/document.php?modulepart=' . $modulepart . '&attachment=0&file=' . urlencode($relativepath) . ($param ? '&' . $param : '')) . '\', \'' . dol_mimetype($relativepath) . '\', \'' . dol_escape_js(Globals::$langs->trans('Preview')) . '\')';
+        } else {
+                    return '';
+        }
     }

 

     /**

@@ -7580,8 +7946,9 @@ 
 				    jQuery("#' . $htmlname . '").click(function() { jQuery(this).select(); } );

 				});

 		    </script>';

-        if ($addlink)

-            $out .= ' <a href="' . $addlink . '" target="_blank">' . Globals::$langs->trans("Link") . '</a>';

+        if ($addlink) {
+                    $out .= ' <a href="' . $addlink . '" target="_blank">' . Globals::$langs->trans("Link") . '</a>';
+        }
         return $out;

     }

 

@@ -7963,8 +8330,9 @@ 
         if (!isset($dictvalues[$tablename])) {

             $dictvalues[$tablename] = array();

             $sql = 'SELECT * FROM ' . $tablename . ' WHERE 1';

-            if ($checkentity)

-                $sql .= ' AND entity IN (0,' . getEntity($tablename) . ')';

+            if ($checkentity) {
+                            $sql .= ' AND entity IN (0,' . getEntity($tablename) . ')';
+            }
 

             $resql = $db->query($sql);

             if ($resql) {

@@ -7976,11 +8344,14 @@ 
             }

         }

 

-        if (!empty($dictvalues[$tablename][$id]))

-            return $dictvalues[$tablename][$id]->{$field}; // Found

+        if (!empty($dictvalues[$tablename][$id])) {
+                    return $dictvalues[$tablename][$id]->{$field};
+        }
+        // Found

         else { // Not found

-            if ($id > 0)

-                return $id;

+            if ($id > 0) {
+                            return $id;
+            }
             return '';

         }

     }

@@ -8010,8 +8381,9 @@ 
                 $b = hexdec($hexb);

             }

             $bright = (max($r, $g, $b) + min($r, $g, $b)) / 510.0;    // HSL algorithm

-            if ($bright > 0.6)

-                $res = 1;

+            if ($bright > 0.6) {
+                            $res = 1;
+            }
         }

         return $res;

     }

@@ -8029,8 +8401,10 @@ 
         // global Globals::$conf;

 //print 'type_user='.$type_user.' module='.$menuentry['module'].' enabled='.$menuentry['enabled'].' perms='.$menuentry['perms'];

 //print 'ok='.in_array($menuentry['module'], $listofmodulesforexternal);

-        if (empty($menuentry['enabled']))

-            return 0; // Entry disabled by condition

+        if (empty($menuentry['enabled'])) {
+                    return 0;
+        }
+        // Entry disabled by condition

         if ($type_user && $menuentry['module']) {

             $tmploops = explode('|', $menuentry['module']);

             $found = 0;

@@ -8040,15 +8414,23 @@ 
                     break;

                 }

             }

-            if (!$found)

-                return 0; // Entry is for menus all excluded to external users

-        }

-        if (!$menuentry['perms'] && $type_user)

-            return 0;            // No permissions and user is external

-        if (!$menuentry['perms'] && !empty(Globals::$conf->global->MAIN_MENU_HIDE_UNAUTHORIZED))

-            return 0; // No permissions and option to hide when not allowed, even for internal user, is on

-        if (!$menuentry['perms'])

-            return 2;               // No permissions and user is external

+            if (!$found) {
+                            return 0;
+            }
+            // Entry is for menus all excluded to external users

+        }

+        if (!$menuentry['perms'] && $type_user) {
+                    return 0;
+        }
+        // No permissions and user is external

+        if (!$menuentry['perms'] && !empty(Globals::$conf->global->MAIN_MENU_HIDE_UNAUTHORIZED)) {
+                    return 0;
+        }
+        // No permissions and option to hide when not allowed, even for internal user, is on

+        if (!$menuentry['perms']) {
+                    return 2;
+        }
+        // No permissions and user is external

         return 1;

     }