DoliDBMysqli::__construct()

Complexity

Conditions	29
Paths	6432

Size

Total Lines	124
Code Lines	79

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function __construct($type, $host, $user, $pass, $name = '', $port = 0)
    {
        global $conf, $langs;

        // Note that having "static" property for "$forcecharset" and "$forcecollate" will make error here in strict mode, so they are not static
        if (!empty($conf->db->character_set)) {
            $this->forcecharset = $conf->db->character_set;
        }
        if (!empty($conf->db->dolibarr_main_db_collation)) {
            $this->forcecollate = $conf->db->dolibarr_main_db_collation;
        }

        $this->database_user = $user;
        $this->database_host = $host;
        $this->database_port = $port;

        $this->transaction_opened = 0;

        //print "Name DB: $host,$user,$pass,$name<br>";

        if (!class_exists('mysqli')) {
            $this->connected = false;
            $this->ok = false;
            $this->error = "Mysqli PHP functions for using Mysqli driver are not available in this version of PHP. Try to use another driver.";
            dol_syslog(get_only_class($this) . "::DoliDBMysqli : Mysqli PHP functions for using Mysqli driver are not available in this version of PHP. Try to use another driver.", LOG_ERR);
        }

        if (!$host) {
            $this->connected = false;
            $this->ok = false;
            $this->error = $langs->trans("ErrorWrongHostParameter");
            dol_syslog(get_only_class($this) . "::DoliDBMysqli : Connect error, wrong host parameters", LOG_ERR);
        }

        // Try server connection
        // We do not try to connect to database, only to server. Connect to database is done later in constructor
        $this->db = $this->connect($host, $user, $pass, '', $port);

It seems like $this->connect($host, $user, $pass, '', $port) can also be of type false. However, the property $db is declared as type mysqli. Maybe add an additional type check?

        if ($this->db && empty($this->db->connect_errno)) {
            $this->connected = true;
            $this->ok = true;
        } else {
            $this->connected = false;
            $this->ok = false;
            $this->error = empty($this->db) ? 'Failed to connect' : $this->db->connect_error;
            dol_syslog(get_only_class($this) . "::DoliDBMysqli Connect error: " . $this->error, LOG_ERR);
        }

        // If server connection is ok, we try to connect to the database
        if ($this->connected && $name) {
            if ($this->select_db($name)) {
                $this->database_selected = true;
                $this->database_name = $name;
                $this->ok = true;

                // If client is old latin, we force utf8
                $clientmustbe = empty($conf->db->character_set) ? 'utf8' : (string)$conf->db->character_set;
                if (preg_match('/latin1/', $clientmustbe)) {
                    $clientmustbe = 'utf8';
                }

                $disableforcecharset = 0;   // Set to 1 to test without charset forcing
                if (empty($disableforcecharset) && $this->db->character_set_name() != $clientmustbe) {
                    try {
                        //print "You should set the \$dolibarr_main_db_character_set and \$dolibarr_main_db_collation for the PHP to the one of the database ".$this->db->character_set_name();
                        dol_syslog(get_only_class($this) . "::DoliDBMysqli You should set the \$dolibarr_main_db_character_set and \$dolibarr_main_db_collation for the PHP to the one of the database " . $this->db->character_set_name(), LOG_WARNING);
                        $this->db->set_charset($clientmustbe); // This set charset, but with a bad collation
                    } catch (Exception $e) {
                        print 'Failed to force character_set_client to ' . $clientmustbe . " (according to setup) to match the one of the server database.<br>\n";
                        print $e->getMessage();
                        print "<br>\n";
                        if ($clientmustbe != 'utf8') {
                            print 'Edit conf/conf.php file to set a charset "utf8"';
                            if ($clientmustbe != 'utf8mb4') {
                                print ' or "utf8mb4"';
                            }
                            print ' instead of "' . $clientmustbe . '".' . "\n";
                        }
                        exit;

Using exit here is not recommended.

                    }

                    $collation = (empty($conf) ? 'utf8_unicode_ci' : $conf->db->dolibarr_main_db_collation);
                    if (preg_match('/latin1/', $collation)) {
                        $collation = 'utf8_unicode_ci';
                    }

                    if (!preg_match('/general/', $collation)) {
                        $this->db->query("SET collation_connection = " . $collation);
                    }
                }
            } else {
                $this->database_selected = false;
                $this->database_name = '';
                $this->ok = false;
                $this->error = $this->error();
                dol_syslog(get_only_class($this) . "::DoliDBMysqli : Select_db error " . $this->error, LOG_ERR);
            }
        } else {
            // No selection of database done. We may only be connected or not (ok or ko) to the server.
            $this->database_selected = false;

            if ($this->connected) {
                // If client is old latin, we force utf8
                $clientmustbe = empty($conf->db->character_set) ? 'utf8' : (string)$conf->db->character_set;
                if (preg_match('/latin1/', $clientmustbe)) {
                    $clientmustbe = 'utf8';
                }
                if (preg_match('/utf8mb4/', $clientmustbe)) {
                    $clientmustbe = 'utf8';
                }

                if ($this->db->character_set_name() != $clientmustbe) {
                    $this->db->set_charset($clientmustbe); // This set utf8_unicode_ci

                    $collation = $conf->db->dolibarr_main_db_collation;
                    if (preg_match('/latin1/', $collation)) {
                        $collation = 'utf8_unicode_ci';
                    }
                    if (preg_match('/utf8mb4/', $collation)) {
                        $collation = 'utf8_unicode_ci';
                    }

                    if (!preg_match('/general/', $collation)) {
                        $this->db->query("SET collation_connection = " . $collation);
                    }