alps-asd / app-state-diagram

src/HyperReference.php

<?php

declare(strict_types=1);

namespace Koriym\AppStateDiagram;

use Generator;
use Koriym\AppStateDiagram\Exception\MissingHashSignInHrefException;
use stdClass;

use function array_shift;
use function explode;
use function in_array;
use function is_int;
use function strpos;

class HyperReference
{
    /** @var array<string, string> */
    private $hrefs = [];

    /** @var FullPath  */
    private $fullPath;

    /** @var list<string> */
    private $done = [];

    /** @var LabelNameInterface */
    private $labelName;

    public function __construct(LabelNameInterface $labelName)
    {
        $this->fullPath = new FullPath();
        $this->labelName = $labelName;
    }

    public function add(string $alpsFile, string $href): void
    {
        $fullPath = ($this->fullPath)($alpsFile, $href);
        if (! is_int(strpos($fullPath, '#'))) {
            throw new MissingHashSignInHrefException($href);
        }

        [, $id] = explode('#', $fullPath);
        if (in_array($id, $this->done)) {

$this->done of type Koriym\AppStateDiagram\list is incompatible with the type array expected by parameter $haystack of in_array().

            return;
        }

        $this->hrefs[$id] = $fullPath;
        $this->done[] = $id;
    }

    /**
     * @param array<string, stdClass> $instances
     *
     * @return array<string, stdClass>
     */
    public function getInstances(array $instances): array
    {
        $hrefs = $this->hrefGenerator();
        foreach ($hrefs as $href) {
            [$file, $id] = explode('#', $href);
            if (! $file) {
                continue; // @codeCoverageIgnore
            }

            if (isset($instances[$id])) {
                continue;
            }

            $alps = new Profile($file, $this->labelName, false);
            [$importInstances, $hyperReference] = $alps->export($id, $file);
            /** @var array<string, stdClass> $importInstances */
            $this->merge($hyperReference);
            $instances += $importInstances;
        }

        return $instances;
    }

    /** @return Generator<string> */
    public function hrefGenerator(): Generator
    {
        while ($this->hrefs) {

The expression $this->hrefs of type array<string,string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            yield array_shift($this->hrefs);
        }

        return [];
    }

    public function merge(HyperReference $hyperReference): void
    {
        $this->hrefs += $hyperReference->hrefs;
    }
}