alps-asd / app-state-diagram

src/AbstractDescriptor.php

<?php

declare(strict_types=1);

namespace Koriym\AppStateDiagram;

use Koriym\AppStateDiagram\Exception\InvalidSemanticsException;
use stdClass;

use function assert;
use function explode;
use function is_string;
use function json_encode;
use function property_exists;
use function sprintf;

abstract class AbstractDescriptor
{
    /** @var string */
    public $id;

    /** @var ?string */
    public $def;

    /** @var stdClass|null */
    public $doc;

    /** @var list<stdClass> */

The type Koriym\AppStateDiagram\list was not found. Maybe you did not declare it correctly or list all dependencies?

    public $descriptor;

    /** @var string */
    public $type = 'semantic';

    /** @var ?string */
    public $rel;

    /** @var stdClass|SemanticDescriptor|null */
    public $parent;

    /** @var list<string> */
    public $tags;

    /** @var string */
    public $title;

    /** @var object */
    public $source;

    /** @var string|null */
    public $href;

    /** @var LinkRelations */
    public $linkRelations;

    public function __construct(object $descriptor, ?stdClass $parentDescriptor = null)
    {
        if (! isset($descriptor->id)) {
            throw new InvalidSemanticsException((string) json_encode($descriptor));
        }

        $this->source = $descriptor;

It seems like $descriptor of type object is incompatible with the declared type object of property $source.

        $this->id = (string) $descriptor->id;
        /** @psalm-suppress MixedAssignment */
        $this->def = $descriptor->def ?? $descriptor->ref ?? $descriptor->src ?? null;
        /** @psalm-suppress MixedAssignment */
        $this->doc = $descriptor->doc ?? null;
        /** @psalm-suppress MixedAssignment */
        $this->descriptor = $descriptor->descriptor ?? [];

It seems like $descriptor->descriptor ?? array() can also be of type array. However, the property $descriptor is declared as type Koriym\AppStateDiagram\list. Maybe add an additional type check?

        $this->parent = $parentDescriptor;
        /** @var string|list<string> $tag */
        $tag = $descriptor->tag ?? [];
        /** @psalm-suppress MixedAssignment */
        $this->tags = is_string($tag) ? explode(' ', $tag) : $tag;

It seems like is_string($tag) ? explode(' ', $tag) : $tag can also be of type string[]. However, the property $tags is declared as type Koriym\AppStateDiagram\list. Maybe add an additional type check?

        /** @psalm-suppress MixedAssignment */
        $this->title = $descriptor->title ?? '';
        if (isset($descriptor->rel)) {
            $this->rel = (string) $descriptor->rel;
        }

        if (property_exists($descriptor, 'href')) {
            assert(is_string($descriptor->href) || $descriptor->href === null);
            $this->href = $descriptor->href;
        }

        /** @psalm-suppress all */
        $this->linkRelations = new LinkRelations($descriptor->link ?? null);
    }

    public function htmlLink(string $ext): string
    {
        return sprintf('[%s](%s.%s.%s)', $this->id, $this->type, $this->id, $ext);
    }
}