Alpixel\Bundle\MenuBundle\Twig\MenuExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	0	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getFunctions()	0	10	1
A	get()	0	4	1
A	render()	0	6	1
A	getName()	0	4	1

<?php

namespace Alpixel\Bundle\MenuBundle\Twig;

use Alpixel\Bundle\MenuBundle\Builder\MenuBuilder;
use Twig_Environment;
use Twig_Extension;
use Twig_SimpleFunction;
use UnexpectedValueException;

class MenuExtension extends Twig_Extension
{
    protected $builder;

    function __construct(MenuBuilder $builder)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->builder = $builder;
    }

    public function getFunctions()
    {
        return array(
            new Twig_SimpleFunction('alpixel_get_menu', array($this, 'get')),

The class Twig_SimpleFunction has been deprecated with message: to be removed in 3.0

            new Twig_SimpleFunction('alpixel_render_menu', array($this, 'render'), array(

The class Twig_SimpleFunction has been deprecated with message: to be removed in 3.0

                'is_safe' => array('html'),
                'needs_environment' => true,
            )),
        );
    }

    public function get($machineName, $locale = null)
    {
        return $this->builder->createKnpMenu($machineName, $locale);
    }

    public function render(Twig_Environment $twig, $machineName, $locale = null)
    {
        $menu = $this->get($machineName, $locale);

$menu is not used, you could remove the assignment.

        return $twig->render();

The call to render() misses a required argument $name.

    }

    public function getName()
    {
        return 'alpixel_menu_bundle_twig_menu_extension';
    }
}