ItemAdmin::configureFormFields() - Code Metrics - Inspection of "Add flash message when URLChecker return PROBRLEM..." - alpixel/AlpixelMenuBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 630912...8bc180 )

by Benjamin

created 2016-04-08 13:14 UTC

ItemAdmin::configureFormFields() B

↳ Parent: ItemAdmin

Complexity

Conditions	5
Paths	4

Size

Total Lines	54
Code Lines	38

Duplication

Lines	20
Ratio	37.04 %

Importance

Changes	7
Bugs	2	Features	1

Metric	Value
c	7
b	2
f	1
dl	20
loc	54
rs	8.7449
cc	5
eloc	38
nc	4
nop	1

How to fix Long Method

<?php

namespace Alpixel\Bundle\MenuBundle\Controller\Admin\CRUD;

use Alpixel\Bundle\MenuBundle\Utils\URLChecker;
use Doctrine\ORM\EntityRepository;
use Sonata\AdminBundle\Admin\Admin;
use Sonata\AdminBundle\Datagrid\ListMapper;
use Sonata\AdminBundle\Form\FormMapper;
use Sonata\AdminBundle\Route\RouteCollection;

class ItemAdmin extends Admin
{
    public $last_position = 0;

    protected $datagridValues = [
        '_page'       => 1,
        '_sort_order' => 'ASC',
        '_sort_by'    => 'position',
    ];

    public function setPositionService(\Pix\SortableBehaviorBundle\Services\PositionHandler $positionHandler)
    {
        $this->positionService = $positionHandler;
    }

    protected function configureRoutes(RouteCollection $collection)
    {
        $collection->add('move', $this->getRouterIdParameter().'/move/{position}');
    }

    public function getPersistentParameters()
    {
        if (!$this->getRequest()) {
            return [];
        }

        return [
            'menu' => $this->getRequest()->query->getInt('menu'),
        ];
    }

    public function createQuery($context = 'list')
    {
        $id = $this->getRequest()->query->getInt('menu');
        $query = parent::createQuery($context);
        $query->join($query->getRootAlias().'.menu', 'm')
            ->where('m.id = :id')
            ->setParameters([
                'id' => $id,
            ]);

        return $query;
    }

    protected function configureFormFields(FormMapper $formMapper)
    {
        $id = $this->getRequest()->query->getInt('menu');
        $isNew = ($this->id($this->getSubject()) === null) ? false : true;

        if ($isNew === false) {
            $formMapper
                ->add('menu', null, [
                    'label'         => 'Menu',
                    'required'      => true,
                    'property'      => 'name',
                    'query_builder' => function (EntityRepository $entityRepository) use ($id) {

                        $query = $entityRepository->createQuerybuilder('m');
                        if ($id === null) {
                            return $query;
                        }

                        return $query
                            ->where('m.id = :id')
                            ->setParameter('id', $id);
                    },
                ]);
        }

        $formMapper
            ->add('menu', null, [
                'label'         => 'Menu',
                'required'      => true,
                'property'      => 'name',
                'query_builder' => function (EntityRepository $entityRepository) use ($id) {

                    $query = $entityRepository->createQuerybuilder('m');
                    if ($id === null) {
                        return $query;
                    }

                    return $query
                        ->where('m.id = :id')
                        ->setParameter('id', $id);
                },
            ])
            ->add('parent', null, [
                'label'    => 'Item parent',
                'required' => false,
                'property' => 'name',
            ])
            ->add('name', null, [
                'label'    => 'Nom du menu à afficher',
                'required' => true,
            ])
            ->add('uri', 'text', [
                'label'    => 'URI',
                'required' => true,
            ]);
    }

    protected function configureListFields(ListMapper $listMapper)
    {
        $this->last_position = $this->positionService->getLastPosition($this->getRoot()->getClass());

        $listMapper
            ->add('name', null, [
                'label'    => 'Label',
                'required' => true,
            ])
            ->add('uri', null, [
                'label'    => 'URI',
                'required' => true,
            ])
            ->add('position', null, [
                'label'    => 'Position',
                'required' => true,
            ])
            ->add('_action', 'actions', [
                'actions' => [
                    'edit' => [],
                    'move' => [
                        'template' => 'PixSortableBehaviorBundle:Default:_sort.html.twig',
                    ],
                ],
            ]);
    }

    public function postUpdate($object = null)
    {
        if ($object !== null && $object->getUri() !== null) {
            $container  = $this->getConfigurationPool()->getContainer();
            $checker    = $container->get('alpixel_menu.utils.url_checker');
            $url        = $object->getUri();
            if ($checker->check($url) === URLChecker::URL_PROBLEM) {
                $session = $container->get('session');
                $session->getFlashBag()->add('warning', 'Cependant une erreur semble être apparue quand nous avons tenté d\'analyser la page "'.$url.'". Vous devriez vérifier que le lien spécifié n\'affiche aucune erreur.');
            }
        }
    }
}


1		<?php
2
3		namespace Alpixel\Bundle\MenuBundle\Controller\Admin\CRUD;
4
5		use Alpixel\Bundle\MenuBundle\Utils\URLChecker;
6		use Doctrine\ORM\EntityRepository;
7		use Sonata\AdminBundle\Admin\Admin;
8		use Sonata\AdminBundle\Datagrid\ListMapper;
9		use Sonata\AdminBundle\Form\FormMapper;
10		use Sonata\AdminBundle\Route\RouteCollection;
11
12		class ItemAdmin extends Admin
13		{
14		public $last_position = 0;
15
16		protected $datagridValues = [
17		'_page' => 1,
18		'_sort_order' => 'ASC',
19		'_sort_by' => 'position',
20		];
21
22		public function setPositionService(\Pix\SortableBehaviorBundle\Services\PositionHandler $positionHandler)
23		{
24		$this->positionService = $positionHandler;
25		}
26
27		protected function configureRoutes(RouteCollection $collection)
28		{
29		$collection->add('move', $this->getRouterIdParameter().'/move/{position}');
30		}
31
32		public function getPersistentParameters()
33		{
34		if (!$this->getRequest()) {
35		return [];
36		}
37
38		return [
39		'menu' => $this->getRequest()->query->getInt('menu'),
40		];
41		}
42
43		public function createQuery($context = 'list')
44		{
45		$id = $this->getRequest()->query->getInt('menu');
46		$query = parent::createQuery($context);
47		$query->join($query->getRootAlias().'.menu', 'm')
48		->where('m.id = :id')
49		->setParameters([
50		'id' => $id,
51		]);
52
53		return $query;
54		}
55
56		protected function configureFormFields(FormMapper $formMapper)
57		{
58		$id = $this->getRequest()->query->getInt('menu');
59		$isNew = ($this->id($this->getSubject()) === null) ? false : true;
60
61		if ($isNew === false) {
62		$formMapper
63		->add('menu', null, [
64		'label' => 'Menu',
65		'required' => true,
66		'property' => 'name',
67	View Code Duplication	'query_builder' => function (EntityRepository $entityRepository) use ($id) {
		0 ignored issues – show Duplication introduced 2016-04-08 13:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		$query = $entityRepository->createQuerybuilder('m');
69		if ($id === null) {
70		return $query;
71		}
72
73		return $query
74		->where('m.id = :id')
75		->setParameter('id', $id);
76		},
77		]);
78		}
79
80		$formMapper
81		->add('menu', null, [
82		'label' => 'Menu',
83		'required' => true,
84		'property' => 'name',
85	View Code Duplication	'query_builder' => function (EntityRepository $entityRepository) use ($id) {
		0 ignored issues – show Duplication introduced 2016-04-08 13:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		$query = $entityRepository->createQuerybuilder('m');
87		if ($id === null) {
88		return $query;
89		}
90
91		return $query
92		->where('m.id = :id')
93		->setParameter('id', $id);
94		},
95		])
96		->add('parent', null, [
97		'label' => 'Item parent',
98		'required' => false,
99		'property' => 'name',
100		])
101		->add('name', null, [
102		'label' => 'Nom du menu à afficher',
103		'required' => true,
104		])
105		->add('uri', 'text', [
106		'label' => 'URI',
107		'required' => true,
108		]);
109		}
110
111		protected function configureListFields(ListMapper $listMapper)
112		{
113		$this->last_position = $this->positionService->getLastPosition($this->getRoot()->getClass());
114
115		$listMapper
116		->add('name', null, [
117		'label' => 'Label',
118		'required' => true,
119		])
120		->add('uri', null, [
121		'label' => 'URI',
122		'required' => true,
123		])
124		->add('position', null, [
125		'label' => 'Position',
126		'required' => true,
127		])
128		->add('_action', 'actions', [
129		'actions' => [
130		'edit' => [],
131		'move' => [
132		'template' => 'PixSortableBehaviorBundle:Default:_sort.html.twig',
133		],
134		],
135		]);
136		}
137
138		public function postUpdate($object = null)
139		{
140		if ($object !== null && $object->getUri() !== null) {
141		$container = $this->getConfigurationPool()->getContainer();
142		$checker = $container->get('alpixel_menu.utils.url_checker');
143		$url = $object->getUri();
144		if ($checker->check($url) === URLChecker::URL_PROBLEM) {
145		$session = $container->get('session');
146		$session->getFlashBag()->add('warning', 'Cependant une erreur semble être apparue quand nous avons tenté d\'analyser la page "'.$url.'". Vous devriez vérifier que le lien spécifié n\'affiche aucune erreur.');
147		}
148		}
149		}
150		}
151

alpixel / AlpixelMenuBundle

Push — master ( 630912...8bc180 )

ItemAdmin::configureFormFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like