CronScanCommand::execute() - Code Metrics - Inspection of "Applied fixes from StyleCI" - alpixel/AlpixelCronBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Benjamin

created 2016-01-20 18:32 UTC

CronScanCommand::execute() B

↳ Parent: CronScanCommand

Complexity

Conditions	8
Paths	12

Size

Total Lines	54
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	54
rs	7.4119
cc	8
eloc	32
nc	12
nop	2

How to fix Long Method

<?php

namespace Alpixel\Bundle\CronBundle\Command;

use Alpixel\Bundle\CronBundle\Annotation\CronJob as CronJobAnno;
use Alpixel\Bundle\CronBundle\Entity\CronJob;
use Doctrine\ORM\EntityManager;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class CronScanCommand extends ContainerAwareCommand
{
    protected function configure()
    {
        $this->setName('cron:scan')
             ->setDescription('Scans for any new or deleted cron jobs')
             ->addOption('keep-deleted', 'k', InputOption::VALUE_NONE, 'If set, deleted cron jobs will not be removed')
             ->addOption('default-disabled', 'd', InputOption::VALUE_NONE, 'If set, new jobs will be disabled by default');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $keepDeleted = $input->getOption('keep-deleted');
        $defaultDisabled = $input->getOption('default-disabled');
        $em = $this->getContainer()->get('doctrine.orm.entity_manager');

        // Enumerate the known jobs
        $jobRepo = $em->getRepository('CronBundle:CronJob');
        $knownJobs = $jobRepo->getKnownJobs();
        $knownJobs = array_fill_keys($knownJobs, true);

        // Enumerate all the jobs currently loaded
        $reader = $this->getContainer()->get('annotation_reader');

        foreach ($this->getApplication()->all() as $command) {
            // Check for an @CronJob annotation
            $reflClass = new \ReflectionClass($command);
            foreach ($reader->getClassAnnotations($reflClass) as $anno) {
                if ($anno instanceof CronJobAnno) {
                    $job = $command->getName();
                    if (array_key_exists($job, $knownJobs)) {
                        // Clear it from the known jobs so that we don't try to delete it
                        unset($knownJobs[$job]);

                        // Update the job if necessary
                        $currentJob = $jobRepo->findOneByCommand($job);
                        $currentJob->setDescription($command->getDescription());
                        if ($currentJob->getInterval() != $anno->value) {
                            $newTime = new \DateTime();
                            $newTime = $newTime->add(new \DateInterval($anno->value));

                            $currentJob->setInterval($anno->value);
                            $currentJob->setNextRun($newTime);
                            $output->writeln("Updated interval for $job to {$anno->value}");
                        }
                    } else {
                        $this->newJobFound($em, $output, $command, $anno, $defaultDisabled);
                    }
                }
            }
        }

        // Clear any jobs that weren't found
        if (!$keepDeleted) {
            foreach (array_keys($knownJobs) as $deletedJob) {
                $output->writeln("Deleting job: $deletedJob");
                $jobToDelete = $jobRepo->findOneByCommand($deletedJob);
                $em->remove($jobToDelete);
            }
        }

        $em->flush();
        $output->writeln('Finished scanning for cron jobs');
    }

    protected function newJobFound(EntityManager $em, OutputInterface $output, Command $command, CronJobAnno $anno, $defaultDisabled = false)
    {
        $newJob = new CronJob();
        $newJob->setCommand($command->getName());
        $newJob->setDescription($command->getDescription());
        $newJob->setInterval($anno->value);
        $newJob->setNextRun(new \DateTime());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $newJob->setEnabled(!$defaultDisabled);

        $output->writeln('Added the job '.$newJob->getCommand().' with interval '.$newJob->getInterval());
        $em->persist($newJob);
    }
}


1			<?php
2
3			namespace Alpixel\Bundle\CronBundle\Command;
4
5			use Alpixel\Bundle\CronBundle\Annotation\CronJob as CronJobAnno;
6			use Alpixel\Bundle\CronBundle\Entity\CronJob;
7			use Doctrine\ORM\EntityManager;
8			use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
9			use Symfony\Component\Console\Command\Command;
10			use Symfony\Component\Console\Input\InputInterface;
11			use Symfony\Component\Console\Input\InputOption;
12			use Symfony\Component\Console\Output\OutputInterface;
13
14			class CronScanCommand extends ContainerAwareCommand
15			{
16			protected function configure()
17			{
18			$this->setName('cron:scan')
19			->setDescription('Scans for any new or deleted cron jobs')
20			->addOption('keep-deleted', 'k', InputOption::VALUE_NONE, 'If set, deleted cron jobs will not be removed')
21			->addOption('default-disabled', 'd', InputOption::VALUE_NONE, 'If set, new jobs will be disabled by default');
22			}
23
24			protected function execute(InputInterface $input, OutputInterface $output)
25			{
26			$keepDeleted = $input->getOption('keep-deleted');
27			$defaultDisabled = $input->getOption('default-disabled');
28			$em = $this->getContainer()->get('doctrine.orm.entity_manager');
29
30			// Enumerate the known jobs
31			$jobRepo = $em->getRepository('CronBundle:CronJob');
32			$knownJobs = $jobRepo->getKnownJobs();
33			$knownJobs = array_fill_keys($knownJobs, true);
34
35			// Enumerate all the jobs currently loaded
36			$reader = $this->getContainer()->get('annotation_reader');
37
38			foreach ($this->getApplication()->all() as $command) {
39			// Check for an @CronJob annotation
40			$reflClass = new \ReflectionClass($command);
41			foreach ($reader->getClassAnnotations($reflClass) as $anno) {
42			if ($anno instanceof CronJobAnno) {
43			$job = $command->getName();
44			if (array_key_exists($job, $knownJobs)) {
45			// Clear it from the known jobs so that we don't try to delete it
46			unset($knownJobs[$job]);
47
48			// Update the job if necessary
49			$currentJob = $jobRepo->findOneByCommand($job);
50			$currentJob->setDescription($command->getDescription());
51			if ($currentJob->getInterval() != $anno->value) {
52			$newTime = new \DateTime();
53			$newTime = $newTime->add(new \DateInterval($anno->value));
54
55			$currentJob->setInterval($anno->value);
56			$currentJob->setNextRun($newTime);
57			$output->writeln("Updated interval for $job to {$anno->value}");
58			}
59			} else {
60			$this->newJobFound($em, $output, $command, $anno, $defaultDisabled);
61			}
62			}
63			}
64			}
65
66			// Clear any jobs that weren't found
67			if (!$keepDeleted) {
68			foreach (array_keys($knownJobs) as $deletedJob) {
69			$output->writeln("Deleting job: $deletedJob");
70			$jobToDelete = $jobRepo->findOneByCommand($deletedJob);
71			$em->remove($jobToDelete);
72			}
73			}
74
75			$em->flush();
76			$output->writeln('Finished scanning for cron jobs');
77			}
78
79			protected function newJobFound(EntityManager $em, OutputInterface $output, Command $command, CronJobAnno $anno, $defaultDisabled = false)
80			{
81			$newJob = new CronJob();
82			$newJob->setCommand($command->getName());
83			$newJob->setDescription($command->getDescription());
84			$newJob->setInterval($anno->value);
85			$newJob->setNextRun(new \DateTime());
			0 ignored issues – show Documentation introduced 2016-01-20 18:29 UTC by Report Bug Copy Issue Report `new \DateTime()` is of type `object<DateTime>`, but the function expects a `object<Alpixel\Bundle\CronBundle\Entity\datetime>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86			$newJob->setEnabled(!$defaultDisabled);
87
88			$output->writeln('Added the job '.$newJob->getCommand().' with interval '.$newJob->getInterval());
89			$em->persist($newJob);
90			}
91			}
92

alpixel / AlpixelCronBundle

Pull Request — master (#1)

CronScanCommand::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like