CronRunCommand::runJob() - Code Metrics - alpixel/AlpixelCronBundle - Measure and Improve Code Quality continuously with Scrutinizer

CronRunCommand::runJob() B
last analyzed 2017-04-07 08:20 UTC

↳ Parent: CronRunCommand

Complexity

Conditions	8
Paths	17

Size

Total Lines	56
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	56
c	0
b	0
f	0
rs	7.3333
cc	8
eloc	36
nc	17
nop	2

How to fix Long Method

<?php

namespace Alpixel\Bundle\CronBundle\Command;

use Alpixel\Bundle\CronBundle\Entity\CronJob;
use Alpixel\Bundle\CronBundle\Entity\CronJobResult;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class CronRunCommand extends ContainerAwareCommand
{
    protected function configure()
    {
        $this->setName('cron:run')
             ->setDescription('Runs any currently schedule cron jobs')
             ->addArgument('job', InputArgument::OPTIONAL, 'Run only this job (if enabled)');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $start = microtime(true);
        $entityManager = $this->getContainer()->get('doctrine.orm.entity_manager');
        $jobRepo = $entityManager->getRepository('CronBundle:CronJob');

        $jobsToRun = [];
        if ($jobName = $input->getArgument('job')) {
            try {
                $jobObj = $jobRepo->findOneByCommand($jobName);
                if ($jobObj->getEnabled()) {
                    $jobsToRun = [$jobObj];
                }
            } catch (\Exception $e) {
                $output->writeln("Couldn't find a job by the name of $jobName");

                return CronJobResult::FAILED;
            }
        } else {
            $jobsToRun = $jobRepo->findDueTasks();
        }

        $jobCount = count($jobsToRun);
        $output->writeln("Running $jobCount jobs:");

        foreach ($jobsToRun as $job) {
            $this->runJob($job, $output);
        }

        $entityManager->flush();

        $end = microtime(true);
        $duration = sprintf('%0.2f', $end - $start);
        $output->writeln("Cron run completed in $duration seconds");
    }

    protected function runJob(CronJob $job, OutputInterface $output)
    {
        $entityManager = $this->getContainer()->get('doctrine.orm.entity_manager');
        $output->write('Running '.$job->getCommand().': ');

        try {
            $commandToRun = $this->getApplication()->get($job->getCommand());
        } catch (\Symfony\Component\Console\Exception\InvalidArgumentException $ex) {
            $output->writeln(' skipped (command no longer exists)');
            $this->recordJobResult($entityManager, $job, 0, 'Command no longer exists', CronJobResult::SKIPPED);


            // No need to reschedule non-existant commands
            return;
        }

        $emptyInput = new ArgvInput();
        $jobOutput = new MemoryWriter();

        $jobStart = microtime(true);
        try {
            $returnCode = $commandToRun->execute($emptyInput, $jobOutput);
        } catch (\Exception $ex) {
            $returnCode = CronJobResult::FAILED;
            $jobOutput->writeln('');
            $jobOutput->writeln('Job execution failed with exception '.get_class($ex).':');
            $jobOutput->writeln($ex->__toString());
        }
        $jobEnd = microtime(true);

        // Clamp the result to accepted values
        if ($returnCode < CronJobResult::RESULT_MIN || $returnCode > CronJobResult::RESULT_MAX) {
            $returnCode = CronJobResult::FAILED;
        }

        // Output the result
        $statusStr = 'unknown';
        if ($returnCode == CronJobResult::SKIPPED) {
            $statusStr = 'skipped';
        } elseif ($returnCode == CronJobResult::SUCCEEDED) {
            $statusStr = 'succeeded';
        } elseif ($returnCode == CronJobResult::FAILED) {
            $statusStr = 'failed';
        }

        $durationStr = sprintf('%0.2f', $jobEnd - $jobStart);
        $output->writeln("$statusStr in $durationStr seconds");

        // Record the result
        $this->recordJobResult($job, $jobEnd - $jobStart, $jobOutput->getOutput(), $returnCode);

        // And update the job with it's next scheduled time
        $interval = new \DateInterval($job->getInterval());
        $newTime = clone $job->getNextRun();
        $newTime->add($interval);
        $job->setNextRun($newTime);
    }

    protected function recordJobResult(CronJob $job, $timeTaken, $output, $resultCode)
    {
        $entityManager = $this->getContainer()->get('doctrine.orm.entity_manager');

        // Create a new CronJobResult
        $result = new CronJobResult();
        $result->setJob($job);
        $result->setRunTime($timeTaken);
        $result->setOutput($output);
        $result->setResult($resultCode);

        // Then update associations and persist it
        $job->setMostRecentRun($result);
        $entityManager->persist($result);
    }
}


1			<?php
2
3			namespace Alpixel\Bundle\CronBundle\Command;
4
5			use Alpixel\Bundle\CronBundle\Entity\CronJob;
6			use Alpixel\Bundle\CronBundle\Entity\CronJobResult;
7			use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
8			use Symfony\Component\Console\Input\ArgvInput;
9			use Symfony\Component\Console\Input\InputArgument;
10			use Symfony\Component\Console\Input\InputInterface;
11			use Symfony\Component\Console\Output\OutputInterface;
12
13			class CronRunCommand extends ContainerAwareCommand
14			{
15			protected function configure()
16			{
17			$this->setName('cron:run')
18			->setDescription('Runs any currently schedule cron jobs')
19			->addArgument('job', InputArgument::OPTIONAL, 'Run only this job (if enabled)');
20			}
21
22			protected function execute(InputInterface $input, OutputInterface $output)
23			{
24			$start = microtime(true);
25			$entityManager = $this->getContainer()->get('doctrine.orm.entity_manager');
26			$jobRepo = $entityManager->getRepository('CronBundle:CronJob');
27
28			$jobsToRun = [];
29			if ($jobName = $input->getArgument('job')) {
30			try {
31			$jobObj = $jobRepo->findOneByCommand($jobName);
32			if ($jobObj->getEnabled()) {
33			$jobsToRun = [$jobObj];
34			}
35			} catch (\Exception $e) {
36			$output->writeln("Couldn't find a job by the name of $jobName");
37
38			return CronJobResult::FAILED;
39			}
40			} else {
41			$jobsToRun = $jobRepo->findDueTasks();
42			}
43
44			$jobCount = count($jobsToRun);
45			$output->writeln("Running $jobCount jobs:");
46
47			foreach ($jobsToRun as $job) {
48			$this->runJob($job, $output);
49			}
50
51			$entityManager->flush();
52
53			$end = microtime(true);
54			$duration = sprintf('%0.2f', $end - $start);
55			$output->writeln("Cron run completed in $duration seconds");
56			}
57
58			protected function runJob(CronJob $job, OutputInterface $output)
59			{
60			$entityManager = $this->getContainer()->get('doctrine.orm.entity_manager');
61			$output->write('Running '.$job->getCommand().': ');
62
63			try {
64			$commandToRun = $this->getApplication()->get($job->getCommand());
65			} catch (\Symfony\Component\Console\Exception\InvalidArgumentException $ex) {
66			$output->writeln(' skipped (command no longer exists)');
67			$this->recordJobResult($entityManager, $job, 0, 'Command no longer exists', CronJobResult::SKIPPED);
			0 ignored issues – show Unused Code introduced 2016-01-22 19:02 UTC by Report Bug Copy Issue Report The call to `CronRunCommand::recordJobResult()` has too many arguments starting with `\Alpixel\Bundle\CronBund...\CronJobResult::SKIPPED`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
68
69			// No need to reschedule non-existant commands
70			return;
71			}
72
73			$emptyInput = new ArgvInput();
74			$jobOutput = new MemoryWriter();
75
76			$jobStart = microtime(true);
77			try {
78			$returnCode = $commandToRun->execute($emptyInput, $jobOutput);
79			} catch (\Exception $ex) {
80			$returnCode = CronJobResult::FAILED;
81			$jobOutput->writeln('');
82			$jobOutput->writeln('Job execution failed with exception '.get_class($ex).':');
83			$jobOutput->writeln($ex->__toString());
84			}
85			$jobEnd = microtime(true);
86
87			// Clamp the result to accepted values
88			if ($returnCode < CronJobResult::RESULT_MIN \|\| $returnCode > CronJobResult::RESULT_MAX) {
89			$returnCode = CronJobResult::FAILED;
90			}
91
92			// Output the result
93			$statusStr = 'unknown';
94			if ($returnCode == CronJobResult::SKIPPED) {
95			$statusStr = 'skipped';
96			} elseif ($returnCode == CronJobResult::SUCCEEDED) {
97			$statusStr = 'succeeded';
98			} elseif ($returnCode == CronJobResult::FAILED) {
99			$statusStr = 'failed';
100			}
101
102			$durationStr = sprintf('%0.2f', $jobEnd - $jobStart);
103			$output->writeln("$statusStr in $durationStr seconds");
104
105			// Record the result
106			$this->recordJobResult($job, $jobEnd - $jobStart, $jobOutput->getOutput(), $returnCode);
107
108			// And update the job with it's next scheduled time
109			$interval = new \DateInterval($job->getInterval());
110			$newTime = clone $job->getNextRun();
111			$newTime->add($interval);
112			$job->setNextRun($newTime);
113			}
114
115			protected function recordJobResult(CronJob $job, $timeTaken, $output, $resultCode)
116			{
117			$entityManager = $this->getContainer()->get('doctrine.orm.entity_manager');
118
119			// Create a new CronJobResult
120			$result = new CronJobResult();
121			$result->setJob($job);
122			$result->setRunTime($timeTaken);
123			$result->setOutput($output);
124			$result->setResult($resultCode);
125
126			// Then update associations and persist it
127			$job->setMostRecentRun($result);
128			$entityManager->persist($result);
129			}
130			}
131

alpixel / AlpixelCronBundle

CronRunCommand::runJob() B last analyzed 2017-04-07 08:20 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

CronRunCommand::runJob() B
last analyzed 2017-04-07 08:20 UTC