alpixel / AlpixelCMSBundle

DependencyInjection/AlpixelCMSExtension.php

<?php

namespace Alpixel\Bundle\CMSBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
use Symfony\Component\DependencyInjection\Loader;
use Symfony\Component\Form\Exception\InvalidConfigurationException;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
use Symfony\Component\Yaml\Parser;

class AlpixelCMSExtension extends Extension implements PrependExtensionInterface
{
    private $_blockDefaultClass = 'Alpixel\Bundle\CMSBundle\Entity\Block';

    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);

        foreach ($config['content_types'] as $name => $contentType) {
            if (empty($contentType['title'])) {
                throw new InvalidConfigurationException('Content type '.$name.' shoud have a title');
            }

            if (empty($contentType['description'])) {
                @trigger_error('Content type '.$name.' shoud have a description', E_USER_WARNING);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            }

            if (!isset($contentType['class']) || empty($contentType['class']) || !class_exists($contentType['class'])) {
                throw new InvalidConfigurationException('CMS '.$contentType['class'].' can\'t be found');
            }
        }
        $container->setParameter('alpixel_cms.content_types', $config['content_types']);

        foreach ($config['blocks'] as $name => $contentType) {
            if (empty($contentType['title'])) {
                throw new InvalidConfigurationException('Block '.$name.' shoud have a title');
            }

            if ((!isset($contentType['class']) || empty($contentType['class'])) && class_exists($this->_blockDefaultClass)) {
                $config['blocks'][$name]['class'] = $this->_blockDefaultClass;
            }

            if (isset($contentType['class']) && !class_exists($contentType['class'])) {
                throw new InvalidConfigurationException('Block '.$contentType['class'].' can\'t be found');
            }
        }
        $container->setParameter('alpixel_cms.blocks', $config['blocks']);
        $container->setParameter('alpixel_cms.exception_template', $config['exception_template']);

        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
        $loader->load('services.yml');
    }

    public function prepend(ContainerBuilder $container)
    {
        $parser = new Parser();

        $configs = $container->getExtensionConfig($this->getAlias());
        $bundleConfig = $this->processConfiguration(new Configuration(), $configs);

        $config = $parser->parse(file_get_contents(__DIR__.'/../Resources/config/config.yml'));

        foreach ($config as $key => $configuration) {

The expression $config of type null|object<Symfony\Component\Yaml\Tag\TaggedValue>|string|array|object<stdClass> is not guaranteed to be traversable. How about adding an additional type check?

            if ($key == 'sonata_admin' && $bundleConfig['white_label'] === true) {
                foreach ($configuration['dashboard']['blocks'] as $blockKey => $block) {
                    if ($block['type'] === 'alpixel_cms.sonata.admin.block.alpixel') {
                        unset($configuration['dashboard']['blocks'][$blockKey]);
                    }
                }
            }
            $container->prependExtensionConfig($key, $configuration);
        }
    }
}