Issues in AdminNodeController.php (master) - Issues in master - alpixel/AlpixelCMSBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (71)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/AdminNodeController.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Alpixel\Bundle\CMSBundle\Controller;

use Sonata\AdminBundle\Controller\CRUDController as Controller;
use Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;

class AdminNodeController extends Controller
{
    public function forwardEditAction(Request $request)
    {
        $entityManager = $this->get('doctrine.orm.entity_manager');

        $node = $entityManager->getRepository('AlpixelCMSBundle:Node')
            ->find($request->get('id'));

        // Forward edit action from EN page set locale for admin to EN instead default locale
        $defaultLocale = $this->getParameter('default_locale');
        $request->setLocale($defaultLocale);

        if ($node !== null) {
            $instanceAdmin = $this->admin->getConfigurationPool()->getAdminByClass(get_class($node));
            if ($instanceAdmin !== null) {
                return $this->redirect($instanceAdmin->generateUrl('edit', ['id' => $request->get('id')]));
            }
        }

        $instanceAdmin = $this->admin->getConfigurationPool()->getInstance('alpixel_cms.admin.node');

        return $this->redirect($instanceAdmin->generateUrl('list'));
    }

    public function createTranslationAction(Request $request)
    {
        $object = $this->admin->getSubject();
        $locale = $request->query->get('locale');

        if ($locale === null || $object === null) {
            return $this->createNotFoundException();
        }

        $entityManager = $this->get('doctrine.orm.entity_manager');
        $translation = $entityManager->getRepository('AlpixelCMSBundle:Node')
            ->findTranslation($object, $locale);

        if ($translation !== null) {
            return $this->redirect($this->admin->generateUrl('edit', ['id' => $translation->getId()]));
        } else {
            $translatedContent = $this->get('alpixel_cms.helper.cms')->createTranslation($object, $locale);
            $entityManager->persist($translatedContent);
            $entityManager->flush();

            return $this->redirect($this->admin->generateUrl('edit', ['id' => $translatedContent->getId()]));
        }
    }

    public function seeAction(Request $request)
    {
        $object = $this->admin->getSubject();
        $contentTypes = $this->admin->getCMSTypes();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        foreach ($contentTypes as $key => $contentType) {
            if ($key === $object->getType()) {
                if (isset($contentType['controller'])) {
                    return $this->redirectToRoute('alpixel_cms', [
                        'slug'    => $object->getSlug(),
                        '_locale' => $object->getLocale(),
                    ]);
                } elseif ($contentType['admin'] !== null && $contentType['admin']->showCustomURL($object) !== null) {
                    return $this->redirect($contentType['admin']->showCustomURL($object));
                }
            }
        }

        $this->get('session')->getFlashBag()->add('warning', 'Impossible de trouver une adresse pour cette page');

        return $this->redirectTo($object);
    }

    public function listAction(Request $request = null)
    {
        if (false === $this->admin->isGranted('LIST')) {
            throw new AccessDeniedException("You can't access the list view");
        }

        $datagrid = $this->admin->getDatagrid();
        $formView = $datagrid->getForm()->createView();

        if (!$this->container->hasParameter('alpixel_cms.content_types')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw $this->createNotFoundException('alpixel_cms.content_types parameters has not been  not found, maybe you must be configured cms.yml file');
        }

        $cmsContentType = $this->container->getParameter('alpixel_cms.content_types');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->get('twig')->getExtension('form')->renderer->setTheme($formView, $this->admin->getFilterTheme());

        return $this->render($this->admin->getTemplate('list'), [
            'action'         => 'list',
            'cmsContentType' => $cmsContentType,
            'form'           => $formView,
            'datagrid'       => $datagrid,
            'csrf_token'     => $this->getCsrfToken('sonata.batch'),
        ], null, $request);
    }

    /**
     * {@inheritdoc}
     */
    protected function redirectTo($object)
    {
        $request = $this->getRequest();

        $url = $backToNodeList = false;
        $instanceAdmin = $this->admin->getConfigurationPool()->getInstance('alpixel_cms.admin.node');

        if (null !== $request->get('btn_update_and_list') || null !== $request->get('btn_create_and_list')) {
            $backToNodeList = true;
        }

        if (null !== $request->get('btn_create_and_create')) {
            $params = [];
            if ($this->admin->hasActiveSubClass()) {
                $params['subclass'] = $request->get('subclass');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            }
            $url = $this->admin->generateUrl('create', $params);
        }

        if (null !== $request->get('btn_update_and_see_page') || null !== $request->get('btn_create_and_see_page')) {
            return $this->redirectToRoute('alpixel_cms', [
                'slug'    => $object->getSlug(),
                '_locale' => $object->getLocale(),
            ]);
        }

        if ($this->getRestMethod() === 'DELETE') {
            $backToNodeList = true;
        }

        if (!$url && !$backToNodeList) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            foreach (['edit', 'show'] as $route) {
                if ($this->admin->hasRoute($route) && $this->admin->isGranted(strtoupper($route), $object)) {
                    $url = $this->admin->generateObjectUrl($route, $object);
                    break;
                }
            }
        }

        if ($backToNodeList || !$url) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $url = $instanceAdmin->generateUrl('list');
        }

        return new RedirectResponse($url);
    }
}


1		<?php
2
3		namespace Alpixel\Bundle\CMSBundle\Controller;
4
5		use Sonata\AdminBundle\Controller\CRUDController as Controller;
6		use Symfony\Component\HttpFoundation\File\Exception\AccessDeniedException;
7		use Symfony\Component\HttpFoundation\RedirectResponse;
8		use Symfony\Component\HttpFoundation\Request;
9
10		class AdminNodeController extends Controller
11		{
12		public function forwardEditAction(Request $request)
13		{
14		$entityManager = $this->get('doctrine.orm.entity_manager');
15
16		$node = $entityManager->getRepository('AlpixelCMSBundle:Node')
17		->find($request->get('id'));
18
19		// Forward edit action from EN page set locale for admin to EN instead default locale
20		$defaultLocale = $this->getParameter('default_locale');
21		$request->setLocale($defaultLocale);
22
23		if ($node !== null) {
24		$instanceAdmin = $this->admin->getConfigurationPool()->getAdminByClass(get_class($node));
25		if ($instanceAdmin !== null) {
26		return $this->redirect($instanceAdmin->generateUrl('edit', ['id' => $request->get('id')]));
27		}
28		}
29
30		$instanceAdmin = $this->admin->getConfigurationPool()->getInstance('alpixel_cms.admin.node');
31
32		return $this->redirect($instanceAdmin->generateUrl('list'));
33		}
34
35		public function createTranslationAction(Request $request)
36		{
37		$object = $this->admin->getSubject();
38		$locale = $request->query->get('locale');
39
40		if ($locale === null \|\| $object === null) {
41		return $this->createNotFoundException();
42		}
43
44		$entityManager = $this->get('doctrine.orm.entity_manager');
45		$translation = $entityManager->getRepository('AlpixelCMSBundle:Node')
46		->findTranslation($object, $locale);
47
48		if ($translation !== null) {
49		return $this->redirect($this->admin->generateUrl('edit', ['id' => $translation->getId()]));
50		} else {
51		$translatedContent = $this->get('alpixel_cms.helper.cms')->createTranslation($object, $locale);
52		$entityManager->persist($translatedContent);
53		$entityManager->flush();
54
55		return $this->redirect($this->admin->generateUrl('edit', ['id' => $translatedContent->getId()]));
56		}
57		}
58
59		public function seeAction(Request $request)
60		{
61		$object = $this->admin->getSubject();
62		$contentTypes = $this->admin->getCMSTypes();
		0 ignored issues – show Bug introduced 2016-04-13 09:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Sonata\AdminBundle\Admin\AdminInterface` as the method `getCMSTypes()` does only exist in the following implementations of said interface: `Alpixel\Bundle\CMSBundle\Admin\AdminBlock`, `Alpixel\Bundle\CMSBundle\Admin\AdminNode`, `Alpixel\Bundle\CMSBundle\Admin\BaseAdmin`, `Alpixel\Bundle\CMSBundle...in\BaseBlockEntityAdmin`, `Alpixel\Bundle\CMSBundle\Admin\BaseNodeEntityAdmin`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
63
64		foreach ($contentTypes as $key => $contentType) {
65		if ($key === $object->getType()) {
66		if (isset($contentType['controller'])) {
67		return $this->redirectToRoute('alpixel_cms', [
68		'slug' => $object->getSlug(),
69		'_locale' => $object->getLocale(),
70		]);
71		} elseif ($contentType['admin'] !== null && $contentType['admin']->showCustomURL($object) !== null) {
72		return $this->redirect($contentType['admin']->showCustomURL($object));
73		}
74		}
75		}
76
77		$this->get('session')->getFlashBag()->add('warning', 'Impossible de trouver une adresse pour cette page');
78
79		return $this->redirectTo($object);
80		}
81
82		public function listAction(Request $request = null)
83		{
84		if (false === $this->admin->isGranted('LIST')) {
85		throw new AccessDeniedException("You can't access the list view");
86		}
87
88		$datagrid = $this->admin->getDatagrid();
89		$formView = $datagrid->getForm()->createView();
90
91		if (!$this->container->hasParameter('alpixel_cms.content_types')) {
		0 ignored issues – show Bug introduced 2018-04-18 15:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `hasParameter()` does only exist in the following implementations of said interface: `Container14\ProjectServiceContainer`, `ProjectServiceContainer`, `Symfony\Component\Depend...urationContainerBuilder`, `Symfony\Component\DependencyInjection\Container`, `Symfony\Component\Depend...ection\ContainerBuilder`, `Symfony\Component\Depend...\NoConstructorContainer`, `Symfony\Component\Depend...tainers\CustomContainer`, `Symfony\Component\Depend...ProjectServiceContainer`, `Symfony\Component\Depend...ProjectServiceContainer`, `Symfony_DI_PhpDumper_Test_Almost_Circular_Private`, `Symfony_DI_PhpDumper_Test_Almost_Circular_Public`, `Symfony_DI_PhpDumper_Test_Base64Parameters`, `Symfony_DI_PhpDumper_Test_EnvParameters`, `Symfony_DI_PhpDumper_Test_Legacy_Privates`, `Symfony_DI_PhpDumper_Test_Rot13Parameters`, `Symfony_DI_PhpDumper_Test_Uninitialized_Reference`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
92		throw $this->createNotFoundException('alpixel_cms.content_types parameters has not been not found, maybe you must be configured cms.yml file');
93		}
94
95		$cmsContentType = $this->container->getParameter('alpixel_cms.content_types');
		0 ignored issues – show Bug introduced 2018-04-18 15:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `getParameter()` does only exist in the following implementations of said interface: `Container14\ProjectServiceContainer`, `ProjectServiceContainer`, `Symfony\Component\Depend...urationContainerBuilder`, `Symfony\Component\DependencyInjection\Container`, `Symfony\Component\Depend...ection\ContainerBuilder`, `Symfony\Component\Depend...\NoConstructorContainer`, `Symfony\Component\Depend...tainers\CustomContainer`, `Symfony\Component\Depend...ProjectServiceContainer`, `Symfony\Component\Depend...ProjectServiceContainer`, `Symfony_DI_PhpDumper_Test_Almost_Circular_Private`, `Symfony_DI_PhpDumper_Test_Almost_Circular_Public`, `Symfony_DI_PhpDumper_Test_Base64Parameters`, `Symfony_DI_PhpDumper_Test_EnvParameters`, `Symfony_DI_PhpDumper_Test_Legacy_Privates`, `Symfony_DI_PhpDumper_Test_Rot13Parameters`, `Symfony_DI_PhpDumper_Test_Uninitialized_Reference`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
96		$this->get('twig')->getExtension('form')->renderer->setTheme($formView, $this->admin->getFilterTheme());
97
98		return $this->render($this->admin->getTemplate('list'), [
99		'action' => 'list',
100		'cmsContentType' => $cmsContentType,
101		'form' => $formView,
102		'datagrid' => $datagrid,
103		'csrf_token' => $this->getCsrfToken('sonata.batch'),
104		], null, $request);
105		}
106
107		/**
108		* {@inheritdoc}
109		*/
110		protected function redirectTo($object)
111		{
112		$request = $this->getRequest();
113
114		$url = $backToNodeList = false;
115		$instanceAdmin = $this->admin->getConfigurationPool()->getInstance('alpixel_cms.admin.node');
116
117	View Code Duplication	if (null !== $request->get('btn_update_and_list') \|\| null !== $request->get('btn_create_and_list')) {
118		$backToNodeList = true;
119		}
120
121	View Code Duplication	if (null !== $request->get('btn_create_and_create')) {
122		$params = [];
123		if ($this->admin->hasActiveSubClass()) {
124		$params['subclass'] = $request->get('subclass');
		0 ignored issues – show Bug introduced 2016-04-13 09:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$params['subclass']` is correct as `$request->get('subclass')` (which targets `Symfony\Component\HttpFoundation\Request::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
125		}
126		$url = $this->admin->generateUrl('create', $params);
127		}
128
129	View Code Duplication	if (null !== $request->get('btn_update_and_see_page') \|\| null !== $request->get('btn_create_and_see_page')) {
130		return $this->redirectToRoute('alpixel_cms', [
131		'slug' => $object->getSlug(),
132		'_locale' => $object->getLocale(),
133		]);
134		}
135
136		if ($this->getRestMethod() === 'DELETE') {
137		$backToNodeList = true;
138		}
139
140	View Code Duplication	if (!$url && !$backToNodeList) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-13 09:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$url` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
141		foreach (['edit', 'show'] as $route) {
142		if ($this->admin->hasRoute($route) && $this->admin->isGranted(strtoupper($route), $object)) {
143		$url = $this->admin->generateObjectUrl($route, $object);
144		break;
145		}
146		}
147		}
148
149		if ($backToNodeList \|\| !$url) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-13 12:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$url` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
150		$url = $instanceAdmin->generateUrl('list');
151		}
152
153		return new RedirectResponse($url);
154		}
155		}
156

alpixel / AlpixelCMSBundle

Issues (71)

Security Analysis not enabled

Controller/AdminNodeController.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like