Issues in AdminCommandController.php (master) - Issues in master - alpixel/AlpixelCMSBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (71)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/AdminCommandController.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Alpixel\Bundle\CMSBundle\Controller;

use Sonata\AdminBundle\Controller\CRUDController as Controller;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author Alexis BUSSIERES <[email protected]>
 */
class AdminCommandController extends Controller
{
    public function commandAction()
    {
        $request = $this->getRequest();
        $query = $request->query;
        $command = $query->get('name');
        $environment = $this->get('kernel')->getEnvironment();

        if ($query->has('flush_cache') && $query->getInt('flush_cache') === 1) {
            $responseFlush = $this->commandFlushCache();
            if ($environment === 'dev') {
                if ($responseFlush->isSuccessful()) {
                    $this->addFlash('success', 'Les caches ont bien été vidés');
                } else {
                    $this->addFlash('error', 'Une erreur est survenue lors de la supression des caches !');
                }
            }
        }

        $responseCommand = $this->executeCommand(['command' => $command]);
        if ($responseCommand->isSuccessful()) {
            $this->addFlash(
                'success',
                sprintf('La commande "%s" a bien été exécuté.', $command)
            );
        } else {
            $this->addFlash(
                'error',
                sprintf('Une erreur est survenue lors de l\'exécution de la commande "%s"!', $command)
            );
        }

        return $this->redirectTo($this->admin->generateUrl('list'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function listAction()
    {
        $request = $this->getRequest();

        $this->admin->checkAccess('list');

        $preResponse = $this->preList($request);
        if ($preResponse !== null) {
            return $preResponse;
        }

        if ($listMode = $request->get('_list_mode')) {
            $this->admin->setListMode($listMode);
        }

        return $this->render('AlpixelCMSBundle:admin/page:base_list.html.twig', [

            'object'     => null,
            'action'     => 'list',
            'csrf_token' => $this->getCsrfToken('sonata.batch'),
        ], null, $request);

    }

    protected function commandFlushCache()
    {
        $environment = $this->get('kernel')->getEnvironment();
        $inputs = [
            'command' => 'cache:clear',
            '--env'   => $environment,
        ];

        return $this->executeCommand($inputs);
    }

    protected function executeCommand(array $inputs)
    {
        if (empty($inputs) || !isset($inputs['command'])) {
            throw new \Exception('The array is empty or "command" index is missing');
        }

        $kernel = $this->get('kernel');
        $application = new Application($kernel);
        $application->setAutoExit(false);

        $input = new ArrayInput($inputs);
        $output = new BufferedOutput(
            OutputInterface::VERBOSITY_NORMAL,
            true
        );

        $application->run($input, $output);
        $content = $output->fetch();

        return new Response($content);
    }
}


1			<?php
2
3			namespace Alpixel\Bundle\CMSBundle\Controller;
4
5			use Sonata\AdminBundle\Controller\CRUDController as Controller;
6			use Symfony\Bundle\FrameworkBundle\Console\Application;
7			use Symfony\Component\Console\Input\ArrayInput;
8			use Symfony\Component\Console\Output\BufferedOutput;
9			use Symfony\Component\Console\Output\OutputInterface;
10			use Symfony\Component\HttpFoundation\Response;
11
12			/**
13			* @author Alexis BUSSIERES <[email protected]>
14			*/
15			class AdminCommandController extends Controller
16			{
17			public function commandAction()
18			{
19			$request = $this->getRequest();
20			$query = $request->query;
21			$command = $query->get('name');
22			$environment = $this->get('kernel')->getEnvironment();
23
24			if ($query->has('flush_cache') && $query->getInt('flush_cache') === 1) {
25			$responseFlush = $this->commandFlushCache();
26			if ($environment === 'dev') {
27			if ($responseFlush->isSuccessful()) {
28			$this->addFlash('success', 'Les caches ont bien été vidés');
29			} else {
30			$this->addFlash('error', 'Une erreur est survenue lors de la supression des caches !');
31			}
32			}
33			}
34
35			$responseCommand = $this->executeCommand(['command' => $command]);
36			if ($responseCommand->isSuccessful()) {
37			$this->addFlash(
38			'success',
39			sprintf('La commande "%s" a bien été exécuté.', $command)
40			);
41			} else {
42			$this->addFlash(
43			'error',
44			sprintf('Une erreur est survenue lors de l\'exécution de la commande "%s"!', $command)
45			);
46			}
47
48			return $this->redirectTo($this->admin->generateUrl('list'));
			0 ignored issues – show Documentation introduced 2016-06-08 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->admin->generateUrl('list')` is of type `string`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49			}
50
51			public function listAction()
52			{
53			$request = $this->getRequest();
54
55			$this->admin->checkAccess('list');
56
57			$preResponse = $this->preList($request);
58			if ($preResponse !== null) {
59			return $preResponse;
60			}
61
62			if ($listMode = $request->get('_list_mode')) {
63			$this->admin->setListMode($listMode);
64			}
65
66			return $this->render('AlpixelCMSBundle:admin/page:base_list.html.twig', [
			0 ignored issues – show Deprecated Code introduced 2018-04-18 15:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Sonata\AdminBundle\Contr...RUDController::render()` has been deprecated with message: since version 3.27, to be removed in 4.0. Use Sonata\AdminBundle\Controller\CRUDController::renderWithExtraParams() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
67			'object' => null,
68			'action' => 'list',
69			'csrf_token' => $this->getCsrfToken('sonata.batch'),
70			], null, $request);
			0 ignored issues – show Unused Code introduced 2016-06-08 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `AdminCommandController::render()` has too many arguments starting with `$request`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
71			}
72
73			protected function commandFlushCache()
74			{
75			$environment = $this->get('kernel')->getEnvironment();
76			$inputs = [
77			'command' => 'cache:clear',
78			'--env' => $environment,
79			];
80
81			return $this->executeCommand($inputs);
82			}
83
84			protected function executeCommand(array $inputs)
85			{
86			if (empty($inputs) \|\| !isset($inputs['command'])) {
87			throw new \Exception('The array is empty or "command" index is missing');
88			}
89
90			$kernel = $this->get('kernel');
91			$application = new Application($kernel);
92			$application->setAutoExit(false);
93
94			$input = new ArrayInput($inputs);
95			$output = new BufferedOutput(
96			OutputInterface::VERBOSITY_NORMAL,
97			true
98			);
99
100			$application->run($input, $output);
101			$content = $output->fetch();
102
103			return new Response($content);
104			}
105			}
106

alpixel / AlpixelCMSBundle

Issues (71)

Security Analysis not enabled

Controller/AdminCommandController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like