alpixel / AlpixelCMSBundle

Controller/AdminBlockController.php

<?php

namespace Alpixel\Bundle\CMSBundle\Controller;

use Sonata\AdminBundle\Controller\CRUDController as Controller;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

class AdminBlockController extends Controller
{
    private $_cmsParameter = 'alpixel_cms.blocks';
    private $_cmsContentParameter = null;
    private $_blockDefaultClass = 'Alpixel\Bundle\CMSBundle\Entity\Block';

The property $_blockDefaultClass is not used and could be removed.

    public function editContentAction()
    {
        $object = $this->admin->getSubject();
        if (!$object) {
            throw new NotFoundHttpException(sprintf('unable to find the object'));
        }

        $instanceAdmin = $this->admin->getConfigurationPool()->getAdminByClass(get_class($object));
        if ($instanceAdmin !== null) {
            return $this->redirect($instanceAdmin->generateUrl('edit', ['id' => $object->getId()]));
        }

        throw new NotFoundHttpException(sprintf('unable to find a class admin for the %s class', get_class($content)));
    }

    public function listAction(Request $request = null)
    {
        if (false === $this->admin->isGranted('LIST')) {
            throw new AccessDeniedException();
        }

        $this->getInstancesAdmin();
        // set the theme for the current Admin Form
        $datagrid = $this->admin->getDatagrid();
        $formView = $datagrid->getForm()->createView();
        $this->get('twig')->getExtension('form')->renderer->setTheme($formView, $this->admin->getFilterTheme());

        return $this->render($this->admin->getTemplate('list'), [

The method Sonata\AdminBundle\Admin\AdminInterface::getTemplate() has been deprecated with message: since 3.35. To be removed in 4.0. Use TemplateRegistry services instead

The method Sonata\AdminBundle\Controller\CRUDController::render() has been deprecated with message: since version 3.27, to be removed in 4.0. Use Sonata\AdminBundle\Controller\CRUDController::renderWithExtraParams() instead.

            'action'         => 'list',
            'cmsContentType' => $this->getCMSParameter(),
            'form'           => $formView,
            'datagrid'       => $datagrid,
            'csrf_token'     => $this->getCsrfToken('sonata.batch'),
        ], null, $request);

The call to AdminBlockController::render() has too many arguments starting with $request.

    }

    /**
     *  Set instances of admin in $_cmsContentParameter.
     */
    protected function getInstancesAdmin()
    {
        foreach ($this->getCMSParameter() as $key => $value) {
            if ($this->checkRolesCMS($value)) {
                $instanceAdmin = $this->admin->getConfigurationPool()->getAdminByClass($value['class']);
                if ($instanceAdmin !== null) {
                    $this->_cmsContentParameter[$key]['admin'] = $instanceAdmin;
                }
            }
        }
    }

    /**
     * @param $role array Role in cms.yml
     *
     * Check role define in different parameter of block or content_types cms.yml
     */
    protected function checkRolesCMS(array $role)
    {
        $user = $this->getUser();

        if (!$user) {
            throw new NotFoundHttpException(sprintf('unable to find user'));
        }

        if (!array_key_exists('role', $role) || in_array($user->getRoles()[0], $role['role'])) {
            return true;
        }

        return false;
    }

    /**
     * Get content in cms.yml and set in $_cmsParameter.
     *
     * @return content of cms.yml
     */
    protected function getCMSParameter()
    {
        if ($this->_cmsContentParameter !== null) {
            return $this->_cmsContentParameter;
        }

        $this->_cmsContentParameter = $this->container->getParameter($this->_cmsParameter);

It seems like you code against a concrete implementation and not the interface Psr\Container\ContainerInterface as the method getParameter() does only exist in the following implementations of said interface: Container14\ProjectServiceContainer, ProjectServiceContainer, Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationContainerBuilder, Symfony\Component\DependencyInjection\Container, Symfony\Component\DependencyInjection\ContainerBuilder, Symfony\Component\DependencyInjection\Tests\Fixtures\Container\NoConstructorContainer, Symfony\Component\DependencyInjection\Tests\Fixtures\containers\CustomContainer, Symfony\Component\DependencyInjection\Tests\LegacyProjectServiceContainer, Symfony\Component\DependencyInjection\Tests\ProjectServiceContainer, Symfony_DI_PhpDumper_Test_Almost_Circular_Private, Symfony_DI_PhpDumper_Test_Almost_Circular_Public, Symfony_DI_PhpDumper_Test_Base64Parameters, Symfony_DI_PhpDumper_Test_EnvParameters, Symfony_DI_PhpDumper_Test_Legacy_Privates, Symfony_DI_PhpDumper_Test_Rot13Parameters, Symfony_DI_PhpDumper_Test_Uninitialized_Reference.

        return $this->_cmsContentParameter;
    }

    /**
     * {@inheritdoc}
     */
    protected function redirectTo($object)
    {
        $request = $this->getRequest();

        $url = $backToNodeList = false;
        $instanceAdmin = $this->admin->getConfigurationPool()->getInstance('alpixel_cms.admin.block');

        if (null !== $request->get('btn_update_and_list') || null !== $request->get('btn_create_and_list')) {

This code seems to be duplicated across your project.

            $backToNodeList = true;
        }

        if (null !== $request->get('btn_create_and_create')) {

This code seems to be duplicated across your project.

            $params = [];
            if ($this->admin->hasActiveSubClass()) {
                $params['subclass'] = $request->get('subclass');

Are you sure the assignment to $params['subclass'] is correct as $request->get('subclass') (which targets Symfony\Component\HttpFoundation\Request::get()) seems to always return null.

            }
            $url = $this->admin->generateUrl('create', $params);
        }

        if ($this->getRestMethod() === 'DELETE') {
            $backToNodeList = true;
        }

        if (!$url) {

The expression $url of type string|false is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === false instead.

This code seems to be duplicated across your project.

            foreach (['edit', 'show'] as $route) {
                if ($this->admin->hasRoute($route) && $this->admin->isGranted(strtoupper($route), $object)) {
                    $url = $this->admin->generateObjectUrl($route, $object);
                    break;
                }
            }
        }

        if ($backToNodeList || !$url) {

The expression $url of type string|false is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === false instead.

            $url = $instanceAdmin->generateUrl('list');
        }

        return new RedirectResponse($url);
    }
}