NodeController::dispatchAction() - Code Metrics - Inspection of "Comply to google seo standards for hreflang" - alpixel/AlpixelCMSBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2b7569...e4f5fc )

by Benjamin

created 2016-08-24 12:28 UTC

NodeController::dispatchAction() C

↳ Parent: NodeController

Complexity

Conditions	12
Paths	25

Size

Total Lines	88
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	0	Features	2

Metric	Value
c	9
b	0
f	2
dl	0
loc	88
rs	5.034
cc	12
eloc	54
nc	25
nop	2

How to fix Long Method Complexity

<?php

namespace Alpixel\Bundle\CMSBundle\Controller;

use Alpixel\Bundle\CMSBundle\Entity\Node;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Debug\Exception\ContextErrorException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\Router;

class NodeController extends Controller
{
    /**
     * @Method({"GET", "POST"})
     *
     * @param Request $request
     * @param         $slug
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function dispatchAction(Request $request, $slug)
    {
        $entityManager = $this->get('doctrine.orm.entity_manager');
        $node = $entityManager->getRepository('AlpixelCMSBundle:Node')
            ->findOneBySlugAndLocale($slug, $request->getLocale());

        if ($node !== null) {
            if ($node->getPublished() === false && !$this->isAuthenticated($request)) {
                throw $this->createNotFoundException();
            }

            $contentType = $this->get('alpixel_cms.helper.cms')->getContentTypeFromNodeElementClass($node);
            $controller = explode('::', $contentType['controller']);

            try {
                if (count($controller) !== 2) {
                    throw new \LogicException(
                        'The parameter controller must be a valid callable controller, like "My\Namespace\Controller\Class::method"'
                    );
                } elseif (!class_exists($controller[0]) || !method_exists($controller[0], $controller[1])) {
                    throw new \LogicException(
                        sprintf(
                            'Unable to find the "%s" controller or the method "%s" doesn\'t exist.',
                            $controller[0],
                            $controller[1]
                        )
                    );
                }

                /** Generating the alternate link for SEO */
                $seoHelper = $this->get('sonata.seo.page.default');
                $translatedPages = $entityManager->getRepository('AlpixelCMSBundle:Node')->findTranslations($node);

                $router = $this->get('router');
                foreach ($translatedPages as $translation) {
                    $seoHelper->addLangAlternate(
                        $router->generate(
                            "alpixel_cms",
                            [
                                'slug'    => $translation->getSlug(),
                                '_locale' => $translation->getLocale(),
                            ],
                            Router::ABSOLUTE_URL
                        ),
                        $translation->getLocale()
                    );
                }

                return $this->forward(
                    $contentType['controller'],
                    [
                        '_route'        => $request->attributes->get('_route'),
                        '_route_params' => $request->attributes->get('_route_params'),
                        'object'        => $node,
                    ]
                );
            } catch (\LogicException $e) {
                if (!$this->container->get('kernel')->isDebug()) {
                    $logger = $this->get('logger');
                    $logger->error($e->getMessage());
                } else {
                    throw $e;
                }
            }
        } else {
            //Trying to find another node with this slug, in another language
            $node = $entityManager->getRepository('AlpixelCMSBundle:Node')
                ->findOnePublishedBySlug($slug);

            if ($node !== null) {
                $translation = $entityManager->getRepository('AlpixelCMSBundle:Node')
                    ->findTranslation($node, $request->getLocale());
                if ($translation !== null) {
                    return $this->redirect(
                        $this->generateUrl(
                            'alpixel_cms',
                            [
                                'slug'    => $translation->getSlug(),
                                '_locale' => $translation->getLocale(),
                            ]
                        )
                    );
                }
            }
        }

        throw $this->createNotFoundException();
    }

    /**
     * @param $node
     *
     * @return Response
     */
    public function displayNodeAdminBarAction(Request $request, $node)
    {
        $entityManager = $this->get('doctrine.orm.entity_manager');
        $node = $entityManager->getRepository('AlpixelCMSBundle:Node')->find($node);

        $response = new Response();
        $response->setPrivate();
        $response->setMaxAge(900);

        if ($this->isAuthenticated($request)) {
            $content = $this->renderView(
                'AlpixelCMSBundle:admin:blocks/admin_bar_page.html.twig',
                [
                    'node' => $node,
                    'link' => $this->generateUrl(
                        'alpixel_admin_cms_node_forwardEdit',
                        [
                            'type' => $node->getType(),
                            'id'   => $node->getId(),
                        ]
                    ),
                ]
            );
            $response->setContent($content);
        }

        return $response;
    }

    /**
     * @param $link
     *
     * @return Response
     */
    public function displayCustomAdminBarAction(Request $request, $link)
    {
        $response = new Response();
        $response->setPrivate();
        $response->setMaxAge(900);

        if ($this->isAuthenticated($request)) {
            $content = $this->renderView(
                'AlpixelCMSBundle:admin:blocks/admin_bar_page.html.twig',
                [
                    'link' => $link,
                ]
            );
            $response->setContent($content);
        }

        return $response;
    }

    /**
     * @param Request $request
     */
    private function isAuthenticated(Request $request)
    {
        $canEdit = $request->cookies->get('can_edit');

        if (isset($canEdit)) {
            if ($request->getSession()->has('_security_admin')) {
                try {
                    $token = unserialize($request->getSession()->get('_security_admin'));
                    $user = $token->getUser();

                    return $canEdit === hash(
                        'sha256',
                        'can_edit'.$this->container->getParameter('secret').$user->getSalt()
                    );
                } catch (ContextErrorException $e) {

                }
            }
        }

        return false;
    }
}


1			<?php
2
3			namespace Alpixel\Bundle\CMSBundle\Controller;
4
5			use Alpixel\Bundle\CMSBundle\Entity\Node;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Symfony\Component\Debug\Exception\ContextErrorException;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\HttpFoundation\Response;
11			use Symfony\Component\Routing\Route;
12			use Symfony\Component\Routing\Router;
13
14			class NodeController extends Controller
15			{
16			/**
17			* @Method({"GET", "POST"})
18			*
19			* @param Request $request
20			* @param $slug
21			*
22			* @return \Symfony\Component\HttpFoundation\Response
23			*/
24			public function dispatchAction(Request $request, $slug)
25			{
26			$entityManager = $this->get('doctrine.orm.entity_manager');
27			$node = $entityManager->getRepository('AlpixelCMSBundle:Node')
28			->findOneBySlugAndLocale($slug, $request->getLocale());
29
30			if ($node !== null) {
31			if ($node->getPublished() === false && !$this->isAuthenticated($request)) {
32			throw $this->createNotFoundException();
33			}
34
35			$contentType = $this->get('alpixel_cms.helper.cms')->getContentTypeFromNodeElementClass($node);
36			$controller = explode('::', $contentType['controller']);
37
38			try {
39			if (count($controller) !== 2) {
40			throw new \LogicException(
41			'The parameter controller must be a valid callable controller, like "My\Namespace\Controller\Class::method"'
42			);
43			} elseif (!class_exists($controller[0]) \|\| !method_exists($controller[0], $controller[1])) {
44			throw new \LogicException(
45			sprintf(
46			'Unable to find the "%s" controller or the method "%s" doesn\'t exist.',
47			$controller[0],
48			$controller[1]
49			)
50			);
51			}
52
53			/** Generating the alternate link for SEO */
54			$seoHelper = $this->get('sonata.seo.page.default');
55			$translatedPages = $entityManager->getRepository('AlpixelCMSBundle:Node')->findTranslations($node);
56
57			$router = $this->get('router');
58			foreach ($translatedPages as $translation) {
59			$seoHelper->addLangAlternate(
60			$router->generate(
61			"alpixel_cms",
62			[
63			'slug' => $translation->getSlug(),
64			'_locale' => $translation->getLocale(),
65			],
66			Router::ABSOLUTE_URL
67			),
68			$translation->getLocale()
69			);
70			}
71
72			return $this->forward(
73			$contentType['controller'],
74			[
75			'_route' => $request->attributes->get('_route'),
76			'_route_params' => $request->attributes->get('_route_params'),
77			'object' => $node,
78			]
79			);
80			} catch (\LogicException $e) {
81			if (!$this->container->get('kernel')->isDebug()) {
82			$logger = $this->get('logger');
83			$logger->error($e->getMessage());
84			} else {
85			throw $e;
86			}
87			}
88			} else {
89			//Trying to find another node with this slug, in another language
90			$node = $entityManager->getRepository('AlpixelCMSBundle:Node')
91			->findOnePublishedBySlug($slug);
92
93			if ($node !== null) {
94			$translation = $entityManager->getRepository('AlpixelCMSBundle:Node')
95			->findTranslation($node, $request->getLocale());
96			if ($translation !== null) {
97			return $this->redirect(
98			$this->generateUrl(
99			'alpixel_cms',
100			[
101			'slug' => $translation->getSlug(),
102			'_locale' => $translation->getLocale(),
103			]
104			)
105			);
106			}
107			}
108			}
109
110			throw $this->createNotFoundException();
111			}
112
113			/**
114			* @param $node
115			*
116			* @return Response
117			*/
118			public function displayNodeAdminBarAction(Request $request, $node)
119			{
120			$entityManager = $this->get('doctrine.orm.entity_manager');
121			$node = $entityManager->getRepository('AlpixelCMSBundle:Node')->find($node);
122
123			$response = new Response();
124			$response->setPrivate();
125			$response->setMaxAge(900);
126
127			if ($this->isAuthenticated($request)) {
128			$content = $this->renderView(
129			'AlpixelCMSBundle:admin:blocks/admin_bar_page.html.twig',
130			[
131			'node' => $node,
132			'link' => $this->generateUrl(
133			'alpixel_admin_cms_node_forwardEdit',
134			[
135			'type' => $node->getType(),
136			'id' => $node->getId(),
137			]
138			),
139			]
140			);
141			$response->setContent($content);
142			}
143
144			return $response;
145			}
146
147			/**
148			* @param $link
149			*
150			* @return Response
151			*/
152			public function displayCustomAdminBarAction(Request $request, $link)
153			{
154			$response = new Response();
155			$response->setPrivate();
156			$response->setMaxAge(900);
157
158			if ($this->isAuthenticated($request)) {
159			$content = $this->renderView(
160			'AlpixelCMSBundle:admin:blocks/admin_bar_page.html.twig',
161			[
162			'link' => $link,
163			]
164			);
165			$response->setContent($content);
166			}
167
168			return $response;
169			}
170
171			/**
172			* @param Request $request
173			*/
174			private function isAuthenticated(Request $request)
175			{
176			$canEdit = $request->cookies->get('can_edit');
177
178			if (isset($canEdit)) {
179			if ($request->getSession()->has('_security_admin')) {
180			try {
181			$token = unserialize($request->getSession()->get('_security_admin'));
182			$user = $token->getUser();
183
184			return $canEdit === hash(
185			'sha256',
186			'can_edit'.$this->container->getParameter('secret').$user->getSalt()
187			);
188			} catch (ContextErrorException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-11 14:47 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
189			}
190			}
191			}
192
193			return false;
194			}
195			}
196

alpixel / AlpixelCMSBundle

Push — master ( 2b7569...e4f5fc )

NodeController::dispatchAction() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like