NodeRepository - Code Metrics - Inspection of "added support for alternate href lang meta tags" - alpixel/AlpixelCMSBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9917be...c47af9 )

by Benjamin

created 2016-08-22 12:49 UTC

NodeRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	132
Duplicated Lines	37.12 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	13
Bugs	2	Features	1

Metric	Value
wmc	9
c	13
b	2
f	1
lcom	1
cbo	3
dl	49
loc	132
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	findAllWithLocale()	11	11	1
A	findOnePublishedBySlug()	0	10	1
A	findOnePublishedBySlugAndLocale()	12	12	1
A	findOneBySlugAndLocale()	0	11	1
B	findTranslation()	26	28	3
B	findTranslations()	0	25	2

How to fix Duplicated Code

<?php

namespace Alpixel\Bundle\CMSBundle\Entity\Repository;

use Alpixel\Bundle\CMSBundle\Entity\Node;
use Doctrine\ORM\EntityRepository;

/**
 * @author Benjamin HUBERT <[email protected]>
 */
class NodeRepository extends EntityRepository
{
    /**
     * @param $locale
     * @return array
     */
    public function findAllWithLocale($locale)

    {
        return $this
            ->createQueryBuilder('n')
            ->andWhere('n.published = true')
            ->andWhere('n.locale = :locale')
            ->setParameter('locale', $locale)
            ->orderBy('n.position', 'ASC')
            ->getQuery()
            ->getResult();
    }

    /**
     * @param $slug
     * @return \Alpixel\Bundle\CMSBundle\Entity\Node|null
     */
    public function findOnePublishedBySlug($slug)
    {
        return $this
            ->createQueryBuilder('n')
            ->andWhere('n.published = true')
            ->andWhere('n.slug = :slug')
            ->setParameter('slug', $slug)
            ->getQuery()
            ->getOneOrNullResult();
    }

    /**
     * @param $slug
     * @param $locale
     * @return \Alpixel\Bundle\CMSBundle\Entity\Node|null
     */
    public function findOnePublishedBySlugAndLocale($slug, $locale)

    {
        return $this
            ->createQueryBuilder('n')
            ->andWhere('n.published = true')
            ->andWhere('n.locale = :locale')
            ->andWhere('n.slug = :slug')
            ->setParameter('locale', $locale)
            ->setParameter('slug', $slug)
            ->getQuery()
            ->getOneOrNullResult();
    }

    /**
     * @param $slug
     * @param $locale
     * @return \Alpixel\Bundle\CMSBundle\Entity\Node|null
     */
    public function findOneBySlugAndLocale($slug, $locale)
    {
        return $this
            ->createQueryBuilder('n')
            ->andWhere('n.locale = :locale')
            ->andWhere('n.slug = :slug')
            ->setParameter('locale', $locale)
            ->setParameter('slug', $slug)
            ->getQuery()
            ->getOneOrNullResult();
    }

    /**
     * @param \Alpixel\Bundle\CMSBundle\Entity\Node $node
     * @param $locale
     * @return \Alpixel\Bundle\CMSBundle\Entity\Node|null
     */
    public function findTranslation(Node $node, $locale)

    {
        $nodeSource = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // We are checking if the node is the translation provider or translated
        // from an other node
        if ($node->getTranslationSource() !== null) {
            $nodeSource = $node->getTranslationSource();
            if ($nodeSource->getLocale() == $locale) {
                return $nodeSource;
            }
        } else {
            $nodeSource = $node;
        }

        return $this->createQueryBuilder('n')
            ->addSelect('n')
            ->andWhere('n.translationSource = :source')
            ->andWhere('n.locale = :locale')
            ->setParameters(
                [
                    'source' => $nodeSource,
                    'locale' => $locale,
                ]
            )
            ->getQuery()
            ->getOneOrNullResult();
    }

    /**
     * @param \Alpixel\Bundle\CMSBundle\Entity\Node $node
     * @return array
     */
    public function findTranslations(Node $node)
    {
        $nodeSource = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // We are checking if the node is the translation provider or translated
        // from an other node
        if ($node->getTranslationSource() !== null) {
            $nodeSource = $node->getTranslationSource();
        } else {
            $nodeSource = $node;
        }

        return $this->createQueryBuilder('n')
            ->addSelect('n')
            ->orWhere('n.translationSource = :source')
            ->orWhere('n.id = :id')
            ->setParameters(
                [
                    'source' => $nodeSource,
                    'id'     => $nodeSource->getId(),
                ]
            )
            ->getQuery()
            ->getResult();
    }
}


1		<?php
2
3		namespace Alpixel\Bundle\CMSBundle\Entity\Repository;
4
5		use Alpixel\Bundle\CMSBundle\Entity\Node;
6		use Doctrine\ORM\EntityRepository;
7
8		/**
9		* @author Benjamin HUBERT <[email protected]>
10		*/
11		class NodeRepository extends EntityRepository
12		{
13		/**
14		* @param $locale
15		* @return array
16		*/
17	View Code Duplication	public function findAllWithLocale($locale)
		0 ignored issues – show Duplication introduced 2016-03-21 09:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		return $this
20		->createQueryBuilder('n')
21		->andWhere('n.published = true')
22		->andWhere('n.locale = :locale')
23		->setParameter('locale', $locale)
24		->orderBy('n.position', 'ASC')
25		->getQuery()
26		->getResult();
27		}
28
29		/**
30		* @param $slug
31		* @return \Alpixel\Bundle\CMSBundle\Entity\Node\|null
32		*/
33		public function findOnePublishedBySlug($slug)
34		{
35		return $this
36		->createQueryBuilder('n')
37		->andWhere('n.published = true')
38		->andWhere('n.slug = :slug')
39		->setParameter('slug', $slug)
40		->getQuery()
41		->getOneOrNullResult();
42		}
43
44		/**
45		* @param $slug
46		* @param $locale
47		* @return \Alpixel\Bundle\CMSBundle\Entity\Node\|null
48		*/
49	View Code Duplication	public function findOnePublishedBySlugAndLocale($slug, $locale)
		0 ignored issues – show Duplication introduced 2016-03-21 09:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		return $this
52		->createQueryBuilder('n')
53		->andWhere('n.published = true')
54		->andWhere('n.locale = :locale')
55		->andWhere('n.slug = :slug')
56		->setParameter('locale', $locale)
57		->setParameter('slug', $slug)
58		->getQuery()
59		->getOneOrNullResult();
60		}
61
62		/**
63		* @param $slug
64		* @param $locale
65		* @return \Alpixel\Bundle\CMSBundle\Entity\Node\|null
66		*/
67		public function findOneBySlugAndLocale($slug, $locale)
68		{
69		return $this
70		->createQueryBuilder('n')
71		->andWhere('n.locale = :locale')
72		->andWhere('n.slug = :slug')
73		->setParameter('locale', $locale)
74		->setParameter('slug', $slug)
75		->getQuery()
76		->getOneOrNullResult();
77		}
78
79		/**
80		* @param \Alpixel\Bundle\CMSBundle\Entity\Node $node
81		* @param $locale
82		* @return \Alpixel\Bundle\CMSBundle\Entity\Node\|null
83		*/
84	View Code Duplication	public function findTranslation(Node $node, $locale)
		0 ignored issues – show Duplication introduced 2016-03-29 14:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		{
86		$nodeSource = null;
		0 ignored issues – show Unused Code introduced 2016-01-21 11:07 UTC by Report Bug Copy Issue Report `$nodeSource` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
87
88		// We are checking if the node is the translation provider or translated
89		// from an other node
90		if ($node->getTranslationSource() !== null) {
91		$nodeSource = $node->getTranslationSource();
92		if ($nodeSource->getLocale() == $locale) {
93		return $nodeSource;
94		}
95		} else {
96		$nodeSource = $node;
97		}
98
99		return $this->createQueryBuilder('n')
100		->addSelect('n')
101		->andWhere('n.translationSource = :source')
102		->andWhere('n.locale = :locale')
103		->setParameters(
104		[
105		'source' => $nodeSource,
106		'locale' => $locale,
107		]
108		)
109		->getQuery()
110		->getOneOrNullResult();
111		}
112
113		/**
114		* @param \Alpixel\Bundle\CMSBundle\Entity\Node $node
115		* @return array
116		*/
117		public function findTranslations(Node $node)
118		{
119		$nodeSource = null;
		0 ignored issues – show Unused Code introduced 2016-08-22 13:10 UTC by Report Bug Copy Issue Report `$nodeSource` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
120
121		// We are checking if the node is the translation provider or translated
122		// from an other node
123		if ($node->getTranslationSource() !== null) {
124		$nodeSource = $node->getTranslationSource();
125		} else {
126		$nodeSource = $node;
127		}
128
129		return $this->createQueryBuilder('n')
130		->addSelect('n')
131		->orWhere('n.translationSource = :source')
132		->orWhere('n.id = :id')
133		->setParameters(
134		[
135		'source' => $nodeSource,
136		'id' => $nodeSource->getId(),
137		]
138		)
139		->getQuery()
140		->getResult();
141		}
142		}
143

alpixel / AlpixelCMSBundle

Push — master ( 9917be...c47af9 )

NodeRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like