Alpixel\Bundle\CMSBundle\Listener\SitemapListener

Complexity

Total Complexity

12

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	1
C	populateSitemap()	0	62	11

<?php

namespace Alpixel\Bundle\CMSBundle\Listener;

use Doctrine\ORM\EntityManager;
use Presta\SitemapBundle\Event\SitemapPopulateEvent;
use Presta\SitemapBundle\Service\SitemapListenerInterface;
use Presta\SitemapBundle\Sitemap\Url\GoogleMultilangUrlDecorator;
use Presta\SitemapBundle\Sitemap\Url\UrlConcrete;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Routing\RouterInterface;

class SitemapListener implements SitemapListenerInterface

The interface Presta\SitemapBundle\Service\SitemapListenerInterface has been deprecated with message: This interface has been deprecated in favor of Symfony standard event listener and subscriber. Please see documentation if you are in trouble. To be removed in next major release : 2.0

{
    private $entityManager;
    private $router;
    private $defaultLocale;
    private $locales;
    private $baseUrl;
    private $contentTypes;

    public function __construct(
        RouterInterface $router,
        EntityManager $entityManager,

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

        $defaultLocale,
        $locales,
        $baseUrl,
        $contentTypes
    ) {
        $this->entityManager = $entityManager;
        $this->router = $router;
        $this->defaultLocale = $defaultLocale;
        $this->locales = $locales;
        $this->baseUrl = $baseUrl;
        $this->contentTypes = $contentTypes;
    }

    public function populateSitemap(SitemapPopulateEvent $event)
    {
        $section = $event->getSection();

        if (is_null($section) || $section == 'cms') {
            foreach ($this->locales as $locale) {
                $nodeRepository = $this->entityManager->getRepository('AlpixelCMSBundle:Node');
                $pages = $nodeRepository->findAllWithLocale($locale);

The method findAllWithLocale() does not exist on Doctrine\Common\Persistence\ObjectRepository. Did you maybe mean findAll()?

                foreach ($pages as $page) {
                    $hasController = true;
                    foreach ($this->contentTypes as $contentType) {
                        if (get_class($page) == $contentType['class'] && $contentType['controller'] === null) {
                            $hasController = false;
                        }
                    }

                    if ($hasController === false) {
                        continue;
                    }

                    $url = $this->router->generate(
                        'alpixel_cms',
                        [
                            'slug'    => $page->getSlug(),
                            '_locale' => $page->getLocale(),
                        ],
                        UrlGeneratorInterface::ABSOLUTE_URL
                    );

                    $url = new UrlConcrete(
                        $url,
                        $page->getDateUpdated(),
                        UrlConcrete::CHANGEFREQ_MONTHLY,
                        .7
                    );

                    $urlLang = new GoogleMultilangUrlDecorator($url);

                    $translations = $nodeRepository->findTranslations($page);
                    foreach ($translations as $translation) {
                        if ($locale !== $translation->getLocale()) {
                            $url = $this->router->generate(
                                'alpixel_cms',
                                [
                                    'slug'    => $translation->getSlug(),
                                    '_locale' => $translation->getLocale(),
                                ],
                                UrlGeneratorInterface::ABSOLUTE_URL
                            );
                            $urlLang->addLink($url, $translation->getLocale());
                        }
                    }

                    $event->getGenerator()->addUrl(

The method Presta\SitemapBundle\Event\SitemapPopulateEvent::getGenerator() has been deprecated with message: in favor of `Presta\SitemapBundle\Event\SitemapPopulateEvent::getUrlContainer()`

                        $urlLang,
                        'cms.'.$locale
                    );
                }
            }
        }
    }
}