alphadevx / alpha

Alpha/Util/Http/Request.php

Spacing +2 added lines, -2 removed lines

@@ -628,7 +628,7 @@ 
             $URI = mb_substr($this->URI, 0, mb_strpos($this->URI, '?'));
 
             // let's take this opportunity to pass query string params to $this->params
-            $queryString = mb_substr($this->URI, (mb_strpos($this->URI, '?') + 1));
+            $queryString = mb_substr($this->URI, (mb_strpos($this->URI, '?')+1));
             $this->queryString = $queryString;
             parse_str($queryString, $this->params);
         } else {
@@ -642,7 +642,7 @@ 
             $name = $paramNames[$i];
 
             if (!isset($this->params[trim($name, '{}')])) {
-                if (isset($paramValues[$i]) && substr($name, 0, 1) == '{' && substr($name, strlen($name) - 1, 1) == '}') {
+                if (isset($paramValues[$i]) && substr($name, 0, 1) == '{' && substr($name, strlen($name)-1, 1) == '}') {
                     $this->params[trim($name, '{}')] = $paramValues[$i];
                 }
                 if (!isset($paramValues[$i]) && isset($defaultParams[trim($name, '{}')])) {

Doc Comments +2 added lines, -2 removed lines

@@ -300,7 +300,7 @@ 
      * @param string $key     The key to search for
      * @param mixed  $default If key is not found, return this instead
      *
-     * @return mixed
+     * @return string
      *
      * @since 2.0
      */
@@ -391,7 +391,7 @@ 
      * @param string $key     The key to search for
      * @param mixed  $default If key is not found, return this instead
      *
-     * @return mixed
+     * @return string
      *
      * @since 2.0
      */

Alpha/Controller/CacheController.php

Spacing +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
 
             if (isset($params['clearCache']) && $params['clearCache'] == 'true') {
                 try {
-                    FileUtils::deleteDirectoryContents($this->dataDir, array('.htaccess','html','images','pdf','xls'));
+                    FileUtils::deleteDirectoryContents($this->dataDir, array('.htaccess', 'html', 'images', 'pdf', 'xls'));
 
                     $this->setStatusMessage(View::displayUpdateMessage('Cache contents deleted successfully.'));
 

Alpha/Controller/SearchController.php

Spacing +7 added lines, -7 removed lines

@@ -199,7 +199,7 @@ 
         $config = ConfigProvider::getInstance();
 
         // used to track when our pagination range ends
-        $end = ($this->startPoint + $config->get('app.list.page.amount'));
+        $end = ($this->startPoint+$config->get('app.list.page.amount'));
 
         $body = '';
 
@@ -289,14 +289,14 @@ 
 
         $body = '';
 
-        $end = ($this->startPoint + $config->get('app.list.page.amount'));
+        $end = ($this->startPoint+$config->get('app.list.page.amount'));
 
         if ($end > $this->resultCount) {
             $end = $this->resultCount;
         }
 
         if ($this->resultCount > 0) {
-            $body .= '<p align="center">Displaying '.($this->startPoint + 1).' to '.$end.' of <strong>'.$this->resultCount.'</strong>.&nbsp;&nbsp;';
+            $body .= '<p align="center">Displaying '.($this->startPoint+1).' to '.$end.' of <strong>'.$this->resultCount.'</strong>.&nbsp;&nbsp;';
         } else {
             if (!empty($this->query)) {
                 $body .= View::displayUpdateMessage('There were no search results for your query.');
@@ -308,9 +308,9 @@ 
         if ($this->startPoint > 0) {
             // handle secure URLs
             if (isset($params['tk'])) {
-                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint - $config->get('app.list.page.amount'))).'">&laquo;</a></li>';
+                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint-$config->get('app.list.page.amount'))).'">&laquo;</a></li>';
             } else {
-                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint - $config->get('app.list.page.amount')).'">&laquo;</a></li>';
+                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint-$config->get('app.list.page.amount')).'">&laquo;</a></li>';
             }
         } elseif ($this->resultCount > $config->get('app.list.page.amount')) {
             $body .= '<li class="disabled"><a href="#">&laquo;</a></li>';
@@ -336,9 +336,9 @@ 
         if ($this->resultCount > $end) {
             // handle secure URLs
             if (isset($params['tk'])) {
-                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint + $config->get('app.list.page.amount'))).'">Next-&gt;&gt;</a></li>';
+                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint+$config->get('app.list.page.amount'))).'">Next-&gt;&gt;</a></li>';
             } else {
-                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint + $config->get('app.list.page.amount')).'">&raquo;</a></li>';
+                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint+$config->get('app.list.page.amount')).'">&raquo;</a></li>';
             }
         } elseif ($this->resultCount > $config->get('app.list.page.amount')) {
             $body .= '<li class="disabled"><a href="#">&raquo;</a></li>';

Alpha/Util/Security/SecurityUtils.php

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
             $iv
         );
 
-        return $iv . $encryptedData;
+        return $iv.$encryptedData;
     }
 
     /**

Alpha/Controller/PhpinfoController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Alpha\Util\Config\ConfigProvider;
 use Alpha\Util\Http\Request;
 use Alpha\Util\Http\Response;
-use Alpha\Util\Http\Session\SessionProviderFactory;
 use Alpha\View\View;
 use Alpha\Controller\Front\FrontController;
 

Alpha/Model/Type/Timestamp.php

Spacing +4 added lines, -4 removed lines

@@ -629,15 +629,15 @@
         $unixTS = $this->getUnixValue();
 
         if ($now > $unixTS) {
-            $difference = $now - $unixTS;
+            $difference = $now-$unixTS;
             $tense = 'ago';
         } else {
-            $difference = $unixTS - $now;
+            $difference = $unixTS-$now;
             $tense = 'from now';
         }
 
-        for ($i = 0; $difference >= $lengths[$i] && $i < count($lengths) - 1; ++$i) {
-            $difference = round($difference / $lengths[$i]);
+        for ($i = 0; $difference >= $lengths[$i] && $i < count($lengths)-1; ++$i) {
+            $difference = round($difference/$lengths[$i]);
         }
 
         $difference = round($difference);

Alpha/Controller/Controller.php

Doc Comments +11 added lines, -3 removed lines

@@ -297,7 +297,7 @@ 
     /**
      * Get the record for this controller (if any).
      *
-     * @return mixed
+     * @return ActiveRecord
      *
      * @since 1.0
      */
@@ -632,7 +632,7 @@ 
     /**
      * Getter for the unit of work MAX duration.
      *
-     * @return int
+     * @return Integer
      *
      * @since 1.0
      */
@@ -1179,7 +1179,7 @@ 
     /**
      * Generates the two security fields to prevent remote form processing.
      *
-     * @return array An array containing the two fields
+     * @return string[] An array containing the two fields
      *
      * @since 1.0
      */
@@ -1432,6 +1432,7 @@ 
      * @since 2.0
      *
      * @throws \Alpha\Exception\NotImplementedException
+     * @param Request $request
      */
     public function doHEAD($request)
     {
@@ -1444,6 +1445,7 @@ 
      * @since 2.0
      *
      * @throws \Alpha\Exception\NotImplementedException
+     * @param Request $request
      */
     public function doGET($request)
     {
@@ -1456,6 +1458,7 @@ 
      * @since 2.0
      *
      * @throws \Alpha\Exception\NotImplementedException
+     * @param Request $request
      */
     public function doPOST($request)
     {
@@ -1468,6 +1471,7 @@ 
      * @since 2.0
      *
      * @throws \Alpha\Exception\NotImplementedException
+     * @param Request $request
      */
     public function doPUT($request)
     {
@@ -1480,6 +1484,7 @@ 
      * @since 2.0
      *
      * @throws \Alpha\Exception\NotImplementedException
+     * @param Request $request
      */
     public function doPATCH($request)
     {
@@ -1492,6 +1497,7 @@ 
      * @since 2.0
      *
      * @throws \Alpha\Exception\NotImplementedException
+     * @param Request $request
      */
     public function doDELETE($request)
     {
@@ -1502,6 +1508,7 @@ 
      * {@inheritdoc}
      *
      * @since 2.0
+     * @param Request $request
      */
     public function doOPTIONS($request)
     {
@@ -1529,6 +1536,7 @@ 
      * {@inheritdoc}
      *
      * @since 2.0.2
+     * @param Request $request
      */
     public function doTRACE($request)
     {

Spacing +8 added lines, -8 removed lines

@@ -509,19 +509,19 @@ 
             }
             // found the current job
             if ($this->name == $jobs[$i]) {
-                if (isset($jobs[$i - 1])) {
+                if (isset($jobs[$i-1])) {
                     // set the previous job if it exists
-                    $this->previousJob = $jobs[$i - 1];
+                    $this->previousJob = $jobs[$i-1];
                     self::$logger->debug('Previous job ['.$this->previousJob.']');
                 }
-                if (isset($jobs[$i + 1])) {
+                if (isset($jobs[$i+1])) {
                     // set the next job if it exists
-                    $this->nextJob = $jobs[$i + 1];
+                    $this->nextJob = $jobs[$i+1];
                     self::$logger->debug('Next job ['.$this->nextJob.']');
                 }
             }
             // the last job in the sequence
-            if ($i == ($numOfJobs - 1)) {
+            if ($i == ($numOfJobs-1)) {
                 $this->lastJob = $jobs[$i];
             }
         }
@@ -685,9 +685,9 @@ 
             intval($this->unitEndTime->getYear())
             );
 
-        self::$logger->debug('<<getUnitDuration ['.($intEndTime - $intStartTime).']');
+        self::$logger->debug('<<getUnitDuration ['.($intEndTime-$intStartTime).']');
 
-        return $intEndTime - $intStartTime;
+        return $intEndTime-$intStartTime;
     }
 
     /**
@@ -1153,7 +1153,7 @@ 
              */
 
             // the server hostname + today's date less 1 hour (i.e. yesterday where time is < 1:00AM)
-            $var1 = rtrim(strtr(base64_encode(SecurityUtils::encrypt($host.date('Ymd', (time() - 3600)))), '+/', '-_'), '=');
+            $var1 = rtrim(strtr(base64_encode(SecurityUtils::encrypt($host.date('Ymd', (time()-3600)))), '+/', '-_'), '=');
             // the server's IP plus $var1
             $var2 = rtrim(strtr(base64_encode(SecurityUtils::encrypt($ip.$var1)), '+/', '-_'), '=');
 

Alpha/Controller/InstallController.php

Doc Comments +1 added lines, -1 removed lines

@@ -454,7 +454,7 @@
      * Custom version of the check rights method that only checks for a session for the config admin username/password,
      * when the system database is not set-up.
      *
-     * @return bool
+     * @return boolean|null
      *
      * @since 1.0
      */

Alpha/Model/Type/RelationLookup.php

Doc Comments +3 added lines, -2 removed lines

@@ -222,6 +222,7 @@ 
      * (non-PHPdoc)
      *
      * @see Alpha\Model\ActiveRecord::loadAllByAttribute()
+     * @param string $attribute
      */
     public function loadAllByAttribute($attribute, $value, $start = 0, $limit = 0, $orderBy = 'OID', $order = 'ASC', $ignoreClassType = false, $constructorArgs = array())
     {
@@ -312,7 +313,7 @@ 
     /**
      * Returns an array of the OIDs of the related objects.
      *
-     * @return array
+     * @return integer[]
      *
      * @since 1.0
      */
@@ -325,7 +326,7 @@ 
      * Used to set the OIDs of the related objects.  Pass a two-item array of OIDs, the first
      * one being the left object OID, the second being the right.
      *
-     * @param array $OIDs
+     * @param string[] $OIDs
      *
      * @since 1.0
      *